diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/0_code_wars/memoized_fibonacci.rb b/0_code_wars/memoized_fibonacci.rb index abc1234..def5678 100644 --- a/0_code_wars/memoized_fibonacci.rb +++ b/0_code_wars/memoized_fibonacci.rb @@ -0,0 +1,14 @@+# http://www.codewars.com/kata/529adbf7533b761c560004e5/ +# --- iteration 1 --- +def fibonacci(n) + a, b = 1,...
Add code wars (5) - memoized fibonacci
diff --git a/spec/h_spec.rb b/spec/h_spec.rb index abc1234..def5678 100644 --- a/spec/h_spec.rb +++ b/spec/h_spec.rb @@ -3,7 +3,7 @@ describe "h plugin" do it "adds h method for html escaping" do app(:h) do |r| - r.on do |id| + r.on do h("<form>") + h(:form) end end
Fix minor nit in h plugin spec
diff --git a/src/bxs.rb b/src/bxs.rb index abc1234..def5678 100644 --- a/src/bxs.rb +++ b/src/bxs.rb @@ -14,6 +14,7 @@ .collect(&:strip) .drop_while { |l| l != 'Failed examples:' } \ [2..-2] + lines = lines && lines .collect { |l| l.gsub(/\x1b\[\d+(;\d+)?m/, '') } .collect { |l| l.match(/\Arspe...
Fix issue when .rspec.out green
diff --git a/lib/notifiable/notification_status.rb b/lib/notifiable/notification_status.rb index abc1234..def5678 100644 --- a/lib/notifiable/notification_status.rb +++ b/lib/notifiable/notification_status.rb @@ -3,6 +3,7 @@ belongs_to :notification, :class_name => 'Notifiable::Notification' belongs_to :device...
Set table name for NotificationStatus
diff --git a/app/controllers/position_applications_controller.rb b/app/controllers/position_applications_controller.rb index abc1234..def5678 100644 --- a/app/controllers/position_applications_controller.rb +++ b/app/controllers/position_applications_controller.rb @@ -34,7 +34,7 @@ def update position_applicatio...
Use update_attributes (and the internal set_position handling) for position application also
diff --git a/test/test_usage.rb b/test/test_usage.rb index abc1234..def5678 100644 --- a/test/test_usage.rb +++ b/test/test_usage.rb @@ -19,7 +19,7 @@ # ensures that it uses next token and what not def test_select_usage_logging - SimpleRecord.log_usage(:select=>{:filename=>"/mnt/selects.csv", :format=...
Move the test log to /tmp as most won't have permission for /mnt
diff --git a/test/test_fulltext.rb b/test/test_fulltext.rb index abc1234..def5678 100644 --- a/test/test_fulltext.rb +++ b/test/test_fulltext.rb @@ -1,7 +1,7 @@ require 'helper' describe Arel do - before :all do + before do @table = Arel::Table.new(:people) @attr = @table[:name] @conn = FakeRecord::...
Fix on minitest to support 1.9.3
diff --git a/MockInject.podspec b/MockInject.podspec index abc1234..def5678 100644 --- a/MockInject.podspec +++ b/MockInject.podspec @@ -1,11 +1,11 @@ Pod::Spec.new do |s| s.name = "MockInject" - s.version = "0.1.1" + s.version = "1.0.0" s.summary = "A library that allows developers to gl...
Update Podspec for 1.0.0 version
diff --git a/test/register_test.rb b/test/register_test.rb index abc1234..def5678 100644 --- a/test/register_test.rb +++ b/test/register_test.rb @@ -21,4 +21,21 @@ assert_equal [["del", "widget:foo"]], breadcrumb.tracked_keys end + + it 'can register member of set keys for a specific object' do + class Mem...
Add test 'can register member of set keys for a specific object'
diff --git a/amakanize.gemspec b/amakanize.gemspec index abc1234..def5678 100644 --- a/amakanize.gemspec +++ b/amakanize.gemspec @@ -16,7 +16,7 @@ spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } spec.require_paths = ["lib"] - spec.add_development_dependency "bundler", "~> 1.12" + spec....
Allow any version bundler for Travis CI
diff --git a/spec/page_spec.rb b/spec/page_spec.rb index abc1234..def5678 100644 --- a/spec/page_spec.rb +++ b/spec/page_spec.rb @@ -0,0 +1,36 @@+describe 'Page' do + let(:site) { double } + + describe '#initialize' do + context 'when a path is provided' do + let(:page) { Dimples::Page.new(site, './pages/abou...
Add the initial Page tests
diff --git a/Casks/dump-truck.rb b/Casks/dump-truck.rb index abc1234..def5678 100644 --- a/Casks/dump-truck.rb +++ b/Casks/dump-truck.rb @@ -4,7 +4,7 @@ url 'https://www.goldenfrog.com/downloads/dumptruck/dumptruck.dmg' name 'Dump Truck' - homepage 'http://www.goldenfrog.com/dumptruck' + homepage 'https://www....
Fix homepage to use SSL in Dump Truck Cask The HTTP URL is already getting redirected to HTTPS. Using the HTTPS URL directly makes it more secure and saves a HTTP round-trip.
diff --git a/lib/hanami/assets/cache.rb b/lib/hanami/assets/cache.rb index abc1234..def5678 100644 --- a/lib/hanami/assets/cache.rb +++ b/lib/hanami/assets/cache.rb @@ -4,7 +4,7 @@ module Assets # Store assets references when compile mode is on. # - # This is expecially useful in development mode, where ...
Fix typo in documentation comment [skip ci]
diff --git a/ZamzamKit.podspec b/ZamzamKit.podspec index abc1234..def5678 100644 --- a/ZamzamKit.podspec +++ b/ZamzamKit.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "ZamzamKit" - s.version = "0.9.1" + s.version = "0.9.2" s.summary = "A Swift framework for...
Fix pod spec framework linking.
diff --git a/lib/rubocop_delayed_job.rb b/lib/rubocop_delayed_job.rb index abc1234..def5678 100644 --- a/lib/rubocop_delayed_job.rb +++ b/lib/rubocop_delayed_job.rb @@ -5,9 +5,11 @@ module Cop module Lint class DelayedJob < Cop + MSG = "Don't use the %s method to create jobs. Instead, create a cust...
Update to forbid handle_asynchronously as well
diff --git a/app/controllers/comments_controller.rb b/app/controllers/comments_controller.rb index abc1234..def5678 100644 --- a/app/controllers/comments_controller.rb +++ b/app/controllers/comments_controller.rb @@ -1,9 +1,8 @@ class CommentsController < ApplicationController def create - comment = params[:com...
Change add new comment structure
diff --git a/app/controllers/messages_controller.rb b/app/controllers/messages_controller.rb index abc1234..def5678 100644 --- a/app/controllers/messages_controller.rb +++ b/app/controllers/messages_controller.rb @@ -29,7 +29,7 @@ def new @message = Message.new - @message.receiver = User.find_by_username!...
Fix receiver on new message
diff --git a/app/controllers/sessions_controller.rb b/app/controllers/sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/sessions_controller.rb +++ b/app/controllers/sessions_controller.rb @@ -20,4 +20,10 @@ end end + def delete + session.delete(:student_id) + session.delete(:pro...
Write the controller for a logout route
diff --git a/app/models/shipwire/order_decorator.rb b/app/models/shipwire/order_decorator.rb index abc1234..def5678 100644 --- a/app/models/shipwire/order_decorator.rb +++ b/app/models/shipwire/order_decorator.rb @@ -0,0 +1,10 @@+# Fix for retrieve order from Shipwire gem +module SolidusShipwire + module FixFindOrder ...
Fix for retrieve order from Shipwire gem Shipwire::Orders.new.find must return order information instead trackings
diff --git a/lib/static_sync/storage.rb b/lib/static_sync/storage.rb index abc1234..def5678 100644 --- a/lib/static_sync/storage.rb +++ b/lib/static_sync/storage.rb @@ -49,6 +49,7 @@ :region => @config.remote['region'], :aws_access_key_id => @config.remote['username'], :aws_...
Add support for AWS STS tokens
diff --git a/lib/tasks/api_clients.rake b/lib/tasks/api_clients.rake index abc1234..def5678 100644 --- a/lib/tasks/api_clients.rake +++ b/lib/tasks/api_clients.rake @@ -1,4 +1,18 @@ namespace :api_clients do + # Used to register an API client (API clients are just a type of user), + # grant them a given named permiss...
Add helpful comment to describe parameters to rake task
diff --git a/mtransform.gemspec b/mtransform.gemspec index abc1234..def5678 100644 --- a/mtransform.gemspec +++ b/mtransform.gemspec @@ -13,9 +13,9 @@ spec.homepage = "" spec.license = "MIT" - spec.files = `git ls-files -z`.split("\x0") - spec.executables = spec.files.grep(%r{^bin/}) { |f|...
Remove git dependency from gemspec.
diff --git a/netuitived.gemspec b/netuitived.gemspec index abc1234..def5678 100644 --- a/netuitived.gemspec +++ b/netuitived.gemspec @@ -10,7 +10,7 @@ s.files = files s.homepage = 'http://rubygems.org/gems/netuitived' - s.license = 'Apache v2.0' + s.license = 'Apache-2.0' s.required_ruby_version...
Update Gemspec to use a valid license
diff --git a/active_git.gemspec b/active_git.gemspec index abc1234..def5678 100644 --- a/active_git.gemspec +++ b/active_git.gemspec @@ -23,6 +23,10 @@ s.add_development_dependency "bundler", "~> 1.3" s.add_development_dependency "rake" s.add_development_dependency 'rspec' - s.add_development_dependency 'sqlit...
Support for test with jruby
diff --git a/lib/blog/engine.rb b/lib/blog/engine.rb index abc1234..def5678 100644 --- a/lib/blog/engine.rb +++ b/lib/blog/engine.rb @@ -7,5 +7,9 @@ FactoryGirl.definition_file_paths << File.expand_path('../../../spec/factories', __FILE__) end end + + config.generators do |g| + g.test_framew...
Set rspec as test framework for generators
diff --git a/actiontext.gemspec b/actiontext.gemspec index abc1234..def5678 100644 --- a/actiontext.gemspec +++ b/actiontext.gemspec @@ -7,15 +7,15 @@ Gem::Specification.new do |s| s.name = "actiontext" s.version = ActionText::VERSION - s.authors = ["Javan Makhmali", "Sam Stephenson"] - s.email = ["jav...
Update gemspec links and Rails dependency and humbly add myself as a coauthor
diff --git a/fql.gemspec b/fql.gemspec index abc1234..def5678 100644 --- a/fql.gemspec +++ b/fql.gemspec @@ -27,6 +27,7 @@ s.add_development_dependency "rails", "~> 3.2.6" s.add_development_dependency "sqlite3", ">= 1.3.6" s.add_development_dependency "fakeweb", "~> 1.3.0" + s.add_development_dependency "vcr" ...
Add vcr to development dependencies
diff --git a/vk.gemspec b/vk.gemspec index abc1234..def5678 100644 --- a/vk.gemspec +++ b/vk.gemspec @@ -19,7 +19,7 @@ s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) } s.require_paths = %w(lib) - s.add_dependency('activesupport', '>= 3.2.22') + s.add_dependency('activesupport',...
Raise activesupport dep to one without security issues
diff --git a/lib/readline-ng.rb b/lib/readline-ng.rb index abc1234..def5678 100644 --- a/lib/readline-ng.rb +++ b/lib/readline-ng.rb @@ -60,6 +60,14 @@ nil end + def line + @lines.shift + end + + def each_line + yield @lines.shift while @lines.any? + end + end end
Add wrappers for popping lines off the stack
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -2,10 +2,11 @@ has_secure_password validates :username, :email, presence: true validates :email, uniqueness: true + validates_format_of :email, :with => /\A([^@\s]+)@((?:[-a-z...
Add validation to put a format constraint on email attribute in User class
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -1,9 +1,42 @@ class User < ActiveRecord::Base has_secure_password has_many :dogs, foreign_key: :owner - has_many :bookings + has_many :requested_bookings, foreign_key: :request...
Add validations and fix associations
diff --git a/app/admin/queue.rb b/app/admin/queue.rb index abc1234..def5678 100644 --- a/app/admin/queue.rb +++ b/app/admin/queue.rb @@ -1,6 +1,5 @@ ActiveAdmin.register_page 'Queue' do content do - # Get runs that have a background worker workers = Sidekiq::Workers.new active_runs = workers.collect do ...
Remove unhelpful comment from copy pasta
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -28,11 +28,11 @@ end def projects - Project.where('employee_id=? AND status!=?', id, Constants.get_status_id(:deleted)).order(:priority) + Project.where('employee_id=? AND...
Use '>=' for integer comparison
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -1,2 +1,11 @@ class User < ActiveRecord::Base + VALID_EMAIL_REGEX = /\A[\w+\-.]+@[a-z\d\-]+(\.[a-z]+)*\.[a-z]+\z/i + + validates :name, presence: true, + uniqueness...
Add validations to the User model
diff --git a/ci_environment/hhvm/recipes/package.rb b/ci_environment/hhvm/recipes/package.rb index abc1234..def5678 100644 --- a/ci_environment/hhvm/recipes/package.rb +++ b/ci_environment/hhvm/recipes/package.rb @@ -1,12 +1,11 @@-if node["lsb"]["codename"] == 'precise' - apt_repository "boost-backports" do - uri ...
Use chef conditional instead of ruby conditional
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -4,10 +4,9 @@ has_many :votes has_secure_password - before_validation :set_full_name - validates :full_name, :email, presence: true - validates :email, uniqueness: true + ...
Create custom method to display actionable errors
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -10,6 +10,7 @@ field :admin, :type => Boolean, :default => false field :github_access_token field :signup_channel, :default => "unknown" + field :signup_referer, :default => "...
Store the http-referers of signups.
diff --git a/app/models/vote.rb b/app/models/vote.rb index abc1234..def5678 100644 --- a/app/models/vote.rb +++ b/app/models/vote.rb @@ -4,5 +4,6 @@ validates :voter_id, presence: true validates :votable_type, presence: true validates :value, presence: true + validates :votable_id, presence: true end
Add presence validation for votable_id in Vote class
diff --git a/possessify.gemspec b/possessify.gemspec index abc1234..def5678 100644 --- a/possessify.gemspec +++ b/possessify.gemspec @@ -5,6 +5,7 @@ Gem::Specification.new do |s| s.name = "possessify" s.version = Possessify::VERSION + s.licenses = ['MIT'] s.platform = Gem::Platform::RUBY s...
Add license to gemspec and loosen version requirement for minitest
diff --git a/tchart.gemspec b/tchart.gemspec index abc1234..def5678 100644 --- a/tchart.gemspec +++ b/tchart.gemspec @@ -1,19 +1,20 @@ require './lib/tchart/version' Gem::Specification.new do |s| - s.name = "tchart" - s.summary = "Generate TeX/TikZ charts." - s.description ...
Add development dependency, adjust summary text.
diff --git a/spec/lonelyplanet_spec.rb b/spec/lonelyplanet_spec.rb index abc1234..def5678 100644 --- a/spec/lonelyplanet_spec.rb +++ b/spec/lonelyplanet_spec.rb @@ -15,7 +15,7 @@ obj = LonelyPlanetScrape::LonelyPlanetTours.new tours_found = JSON.parse(obj.tours) if !obj.tours.nil? - describe 'Check for differen...
Fix spec structure for pice
diff --git a/app.rb b/app.rb index abc1234..def5678 100644 --- a/app.rb +++ b/app.rb @@ -23,11 +23,12 @@ headcount = redis.scard('people') subject = if headcount < 2 - logger.info "personal subject" redis.srandmember('people') + elsif headcount < 3 + redis.sra...
Support personal output for 2 people Now, when there are two people, you get a response like 'Bob and Alice' instead of '2 people'. It'd be nice to know who you're going with if you're a pair, so 3 is the limit for cardinal output.
diff --git a/app.rb b/app.rb index abc1234..def5678 100644 --- a/app.rb +++ b/app.rb @@ -1,10 +1,13 @@ #encoding : utf-8 + +#Подключаем гемы require 'rubygems' require 'sinatra' require 'sinatra/reloader' require 'sqlite3' def init_db + #процедура инициализации БД db = SQLite3::Database.new 'leprosorium.db' ...
Add validation of post text
diff --git a/cookbooks/nagios/attributes/default.rb b/cookbooks/nagios/attributes/default.rb index abc1234..def5678 100644 --- a/cookbooks/nagios/attributes/default.rb +++ b/cookbooks/nagios/attributes/default.rb @@ -26,9 +26,13 @@ case node['platform_family'] when 'debian' -default['nagios']['plugin_dir'] = '/usr...
Add 32bit RHEL support for the nagios plugins directory Former-commit-id: 73bc64ab57e2e2986ee985041d88b2940822a87a [formerly 4c6d5109c5c343f56ea43ac5b1b69969023b6a46] [formerly 2eb2a13bc4b9ec104dbb8c7b739851482f642e8e [formerly 48457e6f5fd0593a8257cfff2b84db3d7642f6a4]] Former-commit-id: d6ec4eefbd945dabe4dffa393a80d...
diff --git a/recipes/mod_ftp.rb b/recipes/mod_ftp.rb index abc1234..def5678 100644 --- a/recipes/mod_ftp.rb +++ b/recipes/mod_ftp.rb @@ -0,0 +1,33 @@+# +# Author:: Kevin Rivers (<kevin@kevinrivers.com>) +# Cookbook Name:: iis +# Recipe:: mod_ftp +# +# Copyright 2014, Kevin Rivers +# +# Licensed under the Apache License...
Add iis ftp feature installation
diff --git a/backburner.gemspec b/backburner.gemspec index abc1234..def5678 100644 --- a/backburner.gemspec +++ b/backburner.gemspec @@ -17,7 +17,7 @@ s.license = 'MIT' s.add_runtime_dependency 'beaneater', '~> 0.3.1' - s.add_runtime_dependency 'dante', '~> 0.1.5' + s.add_runtime_dependency 'dante', '> 0...
Change Dante dependency to allow v0.2.0 and play nice with Stripe Mocks
diff --git a/Casks/inform.rb b/Casks/inform.rb index abc1234..def5678 100644 --- a/Casks/inform.rb +++ b/Casks/inform.rb @@ -1,6 +1,6 @@ cask 'inform' do version '6M62' - sha256 '6fd0442a4b64a66ee27f0d09caf27bcc117737bd997653b94e8404ef7795f963' + sha256 'e3c9cbbd7fd3933e7585a0a89596c0c736e89d8bb5a9f297edfd6ad7d0f9...
Fix checksum in Inform Cask
diff --git a/Casks/reeder.rb b/Casks/reeder.rb index abc1234..def5678 100644 --- a/Casks/reeder.rb +++ b/Casks/reeder.rb @@ -1,7 +1,7 @@ class Reeder < Cask - url 'http://reederapp.com/beta-reeder-for-mac/Reeder2.0b2.zip' + url 'http://reederapp.com/beta-reeder-for-mac/Reeder2.0b5.zip' homepage 'http://reederapp.c...
Update Reeder to beta 5
diff --git a/Casks/skitch.rb b/Casks/skitch.rb index abc1234..def5678 100644 --- a/Casks/skitch.rb +++ b/Casks/skitch.rb @@ -4,7 +4,7 @@ url "http://cdn1.evernote.com/skitch/mac/release/Skitch-#{version}.zip" name 'Skitch' - homepage 'http://evernote.com/skitch/' + homepage 'https://evernote.com/skitch/' li...
Fix homepage to use SSL in Skitch Cask The HTTP URL is already getting redirected to HTTPS. Using the HTTPS URL directly makes it more secure and saves a HTTP round-trip.
diff --git a/spec/lib/nfedobrasil_spec.rb b/spec/lib/nfedobrasil_spec.rb index abc1234..def5678 100644 --- a/spec/lib/nfedobrasil_spec.rb +++ b/spec/lib/nfedobrasil_spec.rb @@ -18,7 +18,7 @@ subject { NfedoBrasil.client({ssl_plcs_file: File.dirname(__FILE__) + '/../support/certificate.p12', ssl_plcs_password: 'nugh...
Update dev mode url on nfedobrasil spec
diff --git a/spec/models/bus_stop_spec.rb b/spec/models/bus_stop_spec.rb index abc1234..def5678 100644 --- a/spec/models/bus_stop_spec.rb +++ b/spec/models/bus_stop_spec.rb @@ -30,4 +30,13 @@ end end end + + describe 'completed scope' do + end + + describe 'not_started scope' do + end + + describe 'p...
Make sure to test these models
diff --git a/gittake.gemspec b/gittake.gemspec index abc1234..def5678 100644 --- a/gittake.gemspec +++ b/gittake.gemspec @@ -22,4 +22,5 @@ spec.add_development_dependency "bundler", "~> 1.3" spec.add_development_dependency "rake" + spec.add_development_dependency "pry" end
Add pry as dev dependency
diff --git a/lib/dpla.rb b/lib/dpla.rb index abc1234..def5678 100644 --- a/lib/dpla.rb +++ b/lib/dpla.rb @@ -2,10 +2,10 @@ require 'linked_vocabs' module DPLA - require 'dpla/source_resource' - require 'dpla/collection' - require 'dpla/place' - require 'dpla/time_span' - require 'dpla/aggregation' - require 'd...
Use autoload for Resource classes
diff --git a/lib/services.rb b/lib/services.rb index abc1234..def5678 100644 --- a/lib/services.rb +++ b/lib/services.rb @@ -4,19 +4,11 @@ module Services def self.publishing_api - @publishing_api ||= GdsApi::PublishingApiV2.new( - Plek.find("publishing-api"), - bearer_token: ENV.fetch("PUBLISHING_API...
Fix changing the timeout for the Publishing API client Calling the publishing_api_with_low_timeout function would cause the Publishing API client timeout to be set to 1, which would break parts of Whitehall that talk to the Publishing API, casuing it to "hang up" after a second. Rather than using `.dup`, just make it...
diff --git a/init.rb b/init.rb index abc1234..def5678 100644 --- a/init.rb +++ b/init.rb @@ -3,9 +3,7 @@ major, minor, _ = Heroku::VERSION.split(/\./).map(&:to_i) if (major > 3) || (major == 3 && minor >= 4) require File.expand_path('lib/heroku/client/heroku_postgresql', File.dirname(__FILE__)) - require File.expa...
Remove migrated commands from imports
diff --git a/lib/too_dead.rb b/lib/too_dead.rb index abc1234..def5678 100644 --- a/lib/too_dead.rb +++ b/lib/too_dead.rb @@ -11,6 +11,7 @@ module TooDead class Menu - include Vedeu + # include Vedeu + end end
Remove vedeu from Menu class.
diff --git a/lib/ule_page.rb b/lib/ule_page.rb index abc1234..def5678 100644 --- a/lib/ule_page.rb +++ b/lib/ule_page.rb @@ -27,6 +27,11 @@ @@map_initialized = false def self.setup + UlePage::Page.send(:include, Rails.application.routes.url_helpers) if defined? Rails + UlePage::Page.send(:include, ActionVi...
Include rails router and action number helper module to page base model
diff --git a/spec/classes/astrill_spec.rb b/spec/classes/astrill_spec.rb index abc1234..def5678 100644 --- a/spec/classes/astrill_spec.rb +++ b/spec/classes/astrill_spec.rb @@ -4,6 +4,6 @@ it { should contain_class('astrill') } it { should contain_package('Astrill').with_provider('appdmg') } - it { should conta...
Fix naming error produced from a copy and paste
diff --git a/spec/lib/api/helpers_spec.rb b/spec/lib/api/helpers_spec.rb index abc1234..def5678 100644 --- a/spec/lib/api/helpers_spec.rb +++ b/spec/lib/api/helpers_spec.rb @@ -0,0 +1,109 @@+require 'spec_helper' + +describe API::Helpers do + subject { Class.new.include(described_class).new } + + describe '#find_name...
Add some unit tests for lib/api/helpers.rb
diff --git a/spec/scoring/entropy_spec.rb b/spec/scoring/entropy_spec.rb index abc1234..def5678 100644 --- a/spec/scoring/entropy_spec.rb +++ b/spec/scoring/entropy_spec.rb @@ -12,13 +12,13 @@ describe '#digits_entropy' do it 'returns a base 2 log of 10 to the power of the token length' do match = Zxcvbn:...
Use fixed values rather than repeat the calculation in specs
diff --git a/test/integration/homepage_test.rb b/test/integration/homepage_test.rb index abc1234..def5678 100644 --- a/test/integration/homepage_test.rb +++ b/test/integration/homepage_test.rb @@ -34,8 +34,7 @@ should "use the English locale after visiting the Welsh content" do visit @payload[:base_path] ...
Make homepage / Welsh test less coupled to Welsh locale file The previous iteration of this test checked that 1) English text appeared, and 2) Welsh text did not appear. Whilst that fulfilled the needs of the test, 2) is a bit redundant, given that we don't render a Welsh homepage at all. It means having to maintain a...
diff --git a/test/unit/certificate_log_test.rb b/test/unit/certificate_log_test.rb index abc1234..def5678 100644 --- a/test/unit/certificate_log_test.rb +++ b/test/unit/certificate_log_test.rb @@ -0,0 +1,28 @@+require File.expand_path('../../test_helper', __FILE__) + +describe "CertificateDepot::Log" do + before do + ...
Add tests for the logger. git-svn-id: 0b34dac3a39d255f46ac888f3fd4ecac3c863f70@93 b2217739-5cbd-4580-87d5-f689c6e5027b
diff --git a/app/models/tagging_spreadsheet.rb b/app/models/tagging_spreadsheet.rb index abc1234..def5678 100644 --- a/app/models/tagging_spreadsheet.rb +++ b/app/models/tagging_spreadsheet.rb @@ -1,7 +1,10 @@ class TaggingSpreadsheet < ActiveRecord::Base validates :url, presence: true - validates_presence_of :stat...
Rewrite tagging spreadsheet validations in consistent style
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -8,7 +8,7 @@ issues_url 'https://github.com/cvent/octopus-deploy-cookbook/issues' version '0.3.0' -depends 'windows', '~> 1' +depends 'windows', '~> 1.38' supports 'windows' provides 'octopus_deploy_server...
Fix issue with cookbook dependency version constraint
diff --git a/omnisend.rb b/omnisend.rb index abc1234..def5678 100644 --- a/omnisend.rb +++ b/omnisend.rb @@ -1,8 +1,10 @@ require 'amqp' require 'mq' -exit(1) unless ARGV.size == 1 -data = Marshal.dump(ARGV[0]) +exit(1) if ARGV.empty? +message = ARGV.join(' ') +puts "Sending message #{message}" +data = Marshal.dump...
Send all command line parameters
diff --git a/vendor/sinatra-hacks/lib/hacks.rb b/vendor/sinatra-hacks/lib/hacks.rb index abc1234..def5678 100644 --- a/vendor/sinatra-hacks/lib/hacks.rb +++ b/vendor/sinatra-hacks/lib/hacks.rb @@ -0,0 +1,49 @@+module Sinatra + class EventContext + def params + @params ||= ParamsParser.new(@route_params.merge(@...
Add nested parameter support to Sinatra. Gets the job done till redux is out
diff --git a/recipes/_plugin_manager.rb b/recipes/_plugin_manager.rb index abc1234..def5678 100644 --- a/recipes/_plugin_manager.rb +++ b/recipes/_plugin_manager.rb @@ -1,3 +1,8 @@ add_vim_git_plugin({ "vundle" => "https://github.com/gmarik/vundle.git", "unbundle" => "https://github.com/sunaku/v...
Configure pathogen for autoload system-wide bundles
diff --git a/pivnet_api.gemspec b/pivnet_api.gemspec index abc1234..def5678 100644 --- a/pivnet_api.gemspec +++ b/pivnet_api.gemspec @@ -19,7 +19,6 @@ spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } spec.require_paths = ["lib"] - spec.add_development_dependency "oven" spec.add_develo...
Remove oven from development dependency
diff --git a/parse.rb b/parse.rb index abc1234..def5678 100644 --- a/parse.rb +++ b/parse.rb @@ -0,0 +1,103 @@+class KprobeOutput + attr_reader :fn, :src_ip, :dst_ip, :type + + FN_TO_NAME = { + 1 => 'netif_receive_skb', + 2 => 'ip_rcv', + 3 => 'ip_forward', + 4 => 'ip_output', + 5 => 'ip_finish_output'...
Print out packets that dont match fairly narrow expectations
diff --git a/Casks/lighttable.rb b/Casks/lighttable.rb index abc1234..def5678 100644 --- a/Casks/lighttable.rb +++ b/Casks/lighttable.rb @@ -1,7 +1,7 @@ class Lighttable < Cask - url 'http://d35ac8ww5dfjyg.cloudfront.net/playground/bins/0.6.4/LightTableMac.zip' + url 'http://d35ac8ww5dfjyg.cloudfront.net/playground/b...
Update Light Table to 0.6.5
diff --git a/Casks/vienna-rss.rb b/Casks/vienna-rss.rb index abc1234..def5678 100644 --- a/Casks/vienna-rss.rb +++ b/Casks/vienna-rss.rb @@ -0,0 +1,6 @@+class ViennaRss < Cask + url 'http://downloads.sourceforge.net/vienna-rss/Vienna3.0.0_beta11.tgz' + homepage 'http://www.vienna-rss.org' + version '3.0.0_beta11' + ...
Add cask for Vienna RSS reader
diff --git a/rb/lib/selenium/webdriver/common/driver_extensions/uploads_files.rb b/rb/lib/selenium/webdriver/common/driver_extensions/uploads_files.rb index abc1234..def5678 100644 --- a/rb/lib/selenium/webdriver/common/driver_extensions/uploads_files.rb +++ b/rb/lib/selenium/webdriver/common/driver_extensions/uploads_...
JariBakken: Update file detector Ruby example. r14082
diff --git a/spec/googlefight_spec.rb b/spec/googlefight_spec.rb index abc1234..def5678 100644 --- a/spec/googlefight_spec.rb +++ b/spec/googlefight_spec.rb @@ -7,5 +7,6 @@ describe Lita::Handlers::Googlefight, lita_handler: true do it { is_expected.to route_command("!googlefight this;that").to(:googlefight) } +...
Add test for the short variant
diff --git a/spec/models/user_spec.rb b/spec/models/user_spec.rb index abc1234..def5678 100644 --- a/spec/models/user_spec.rb +++ b/spec/models/user_spec.rb @@ -1,9 +1,4 @@ require 'rails_helper' - -# RSpec.describe User, type: :model do -# pending "add some examples to (or delete) #{__FILE__}" -# end - describe U...
Use shoulda matchers for spec refactors
diff --git a/lib/patterns.rb b/lib/patterns.rb index abc1234..def5678 100644 --- a/lib/patterns.rb +++ b/lib/patterns.rb @@ -30,6 +30,7 @@ mruby ruby rubygems + update_rubygems install uninstall sidekiq-pro
Add update_rubygems to reserve list
diff --git a/tematica.gemspec b/tematica.gemspec index abc1234..def5678 100644 --- a/tematica.gemspec +++ b/tematica.gemspec @@ -18,7 +18,7 @@ s.files = Dir["{app,config,db,lib}/**/*"] + ["MIT-LICENSE", "Rakefile", "README.markdown"] s.test_files = Dir["test/**/*"] - s.add_dependency 'rails', '~> 4.1.4' + s.ad...
Update rails version to 4.1.5
diff --git a/lib/gitlab/markdown/sanitization_filter.rb b/lib/gitlab/markdown/sanitization_filter.rb index abc1234..def5678 100644 --- a/lib/gitlab/markdown/sanitization_filter.rb +++ b/lib/gitlab/markdown/sanitization_filter.rb @@ -8,27 +8,32 @@ # Extends HTML::Pipeline::SanitizationFilter with a custom whitelist....
Customize the sanitization whitelist only once Fixes #1651
diff --git a/lib/mailer_previews/role_mailer_preview.rb b/lib/mailer_previews/role_mailer_preview.rb index abc1234..def5678 100644 --- a/lib/mailer_previews/role_mailer_preview.rb +++ b/lib/mailer_previews/role_mailer_preview.rb @@ -1,3 +1,4 @@+# Preview all emails at http://localhost:3000/rails/mailers/role_mailer cl...
Add preview for new supervisor role mail notification
diff --git a/lib/rubocop/cop/style/colon_method_call.rb b/lib/rubocop/cop/style/colon_method_call.rb index abc1234..def5678 100644 --- a/lib/rubocop/cop/style/colon_method_call.rb +++ b/lib/rubocop/cop/style/colon_method_call.rb @@ -9,11 +9,11 @@ MSG = 'Do not use `::` for method calls.' def on_send(...
Fix an offense reported by UnderscorePrefixedVariableName
diff --git a/resources/mount.rb b/resources/mount.rb index abc1234..def5678 100644 --- a/resources/mount.rb +++ b/resources/mount.rb @@ -20,7 +20,7 @@ actions :mount, :umount, :enable, :disable default_action :mount -attribute :name, :kind_of => String, :name_attribute => true -attribute :server, :kind_of => String,...
Switch to Ruby 1.9 hash syntax
diff --git a/recipes/nexi.rb b/recipes/nexi.rb index abc1234..def5678 100644 --- a/recipes/nexi.rb +++ b/recipes/nexi.rb @@ -1,10 +1,10 @@ -deb_name = 'VidyoDesktopInstaller-ubuntu64-TAG_VD_3_5_4_010.deb' +deb_name = 'VidyoDesktopInstaller-ubuntu64-TAG_VD_3_6_3_017.deb' deb_path = "#{Chef::Config[:file_cache_path]}...
Update Vidyo client to newest package
diff --git a/comfy_blog.gemspec b/comfy_blog.gemspec index abc1234..def5678 100644 --- a/comfy_blog.gemspec +++ b/comfy_blog.gemspec @@ -16,7 +16,7 @@ s.platform = Gem::Platform::RUBY s.require_paths = ['lib'] - s.add_dependency 'comfortable_mexican_loveseat', '0.0.20' + s.add_dependency 'comfortable_mexi...
Update gemspec to use the latest version of loveseat
diff --git a/lib/helpers/find_or_create_students.rb b/lib/helpers/find_or_create_students.rb index abc1234..def5678 100644 --- a/lib/helpers/find_or_create_students.rb +++ b/lib/helpers/find_or_create_students.rb @@ -6,12 +6,12 @@ using_cache = !@user_cache.nil? if !using_cache || !@user_cache.key?(username) ...
QUALITY: Use two space indentation for hash
diff --git a/lib/noosfero/core_ext/action_mailer.rb b/lib/noosfero/core_ext/action_mailer.rb index abc1234..def5678 100644 --- a/lib/noosfero/core_ext/action_mailer.rb +++ b/lib/noosfero/core_ext/action_mailer.rb @@ -1,27 +1,6 @@ class ActionMailer::Base attr_accessor :environment - - # Monkey patch to: - # 1) A...
Remove monkey patches on render
diff --git a/lib/temple/coffee_script/generators.rb b/lib/temple/coffee_script/generators.rb index abc1234..def5678 100644 --- a/lib/temple/coffee_script/generators.rb +++ b/lib/temple/coffee_script/generators.rb @@ -7,7 +7,7 @@ def call(exp) @indent = options[:indent] - compile [:multi, [:code,...
Return buffer from generator function.
diff --git a/test/user_test.rb b/test/user_test.rb index abc1234..def5678 100644 --- a/test/user_test.rb +++ b/test/user_test.rb @@ -4,14 +4,18 @@ require 'user' class UserTest < Test::Unit::TestCase + attr_reader :user + + def setup + @user = User.new 'user@example.com' + end + def test_initialize - use...
Move user creation into setup.
diff --git a/soa-demo-client.rb b/soa-demo-client.rb index abc1234..def5678 100644 --- a/soa-demo-client.rb +++ b/soa-demo-client.rb @@ -1,5 +1,9 @@ require "bunny" require "json" + +name = "Bob" +address = "123 main" +orderId = "12345" puts "I want some pizza" @@ -14,7 +18,7 @@ puts session.exchange_exi...
Use serialized hashes instead of hand rolled JSON
diff --git a/lib/mikoshi/plan.rb b/lib/mikoshi/plan.rb index abc1234..def5678 100644 --- a/lib/mikoshi/plan.rb +++ b/lib/mikoshi/plan.rb @@ -9,6 +9,7 @@ def initialize(yaml_path: nil, client: nil) raise ArgumentError, 'Yaml file path is required.' if yaml_path.nil? + raise ArgumentError, 'client...
Raise error when client is nil
diff --git a/mdspell.gemspec b/mdspell.gemspec index abc1234..def5678 100644 --- a/mdspell.gemspec +++ b/mdspell.gemspec @@ -14,8 +14,7 @@ s.extra_rdoc_files = %w(README.md LICENSE) # Manifest - s.files = Dir.glob('lib/**/*') - s.files += Dir.glob('bin/**/*') + s.files = Dir.g...
Fix files definition in gemspec.
diff --git a/que.gemspec b/que.gemspec index abc1234..def5678 100644 --- a/que.gemspec +++ b/que.gemspec @@ -8,8 +8,8 @@ spec.version = Que::Version spec.authors = ["Chris Hanks"] spec.email = ['christopher.m.hanks@gmail.com'] - spec.description = %q{Durable job queueing with PostgreSQL.}...
Tweak gem's description and summary.
diff --git a/config/schedule.rb b/config/schedule.rb index abc1234..def5678 100644 --- a/config/schedule.rb +++ b/config/schedule.rb @@ -0,0 +1,29 @@+# Use this file to easily define all of your cron jobs. +# +# It's helpful, but not entirely necessary to understand cron before proceeding. +# http://en.wikipedia.org/wi...
Add cron job to refresh cache I went for 1 hour as that is the current refresh rate for caches. https://trello.com/c/knffA0Fb/786-import-the-new-topic-registry-on-a-schedule-s
diff --git a/config/schedule.rb b/config/schedule.rb index abc1234..def5678 100644 --- a/config/schedule.rb +++ b/config/schedule.rb @@ -27,4 +27,7 @@ every 1.hour do runner 'DigestBuilder.send_daily_email' -end+end + +every :minute { command "whoami" } +every :minute { command "which ruby" }
Add crons to check env
diff --git a/config/schedule.rb b/config/schedule.rb index abc1234..def5678 100644 --- a/config/schedule.rb +++ b/config/schedule.rb @@ -19,6 +19,6 @@ rake "export:redirector_mappings" end -every :day, at: ['2am'], roles: [:backend] do +every :day, at: ['1:30am'], roles: [:backend] do rake "rummager:index:close...
Move rake task to 1:30am So not to conflic with export:redirector_mappings which is a heavy task
diff --git a/spec/requests/groups/profiles_spec.rb b/spec/requests/groups/profiles_spec.rb index abc1234..def5678 100644 --- a/spec/requests/groups/profiles_spec.rb +++ b/spec/requests/groups/profiles_spec.rb @@ -1,6 +1,25 @@ require "spec_helper" describe "Group profiles" do + context "as a public user" do + + ...
Test that the group profile page is working.
diff --git a/app/models/customer.rb b/app/models/customer.rb index abc1234..def5678 100644 --- a/app/models/customer.rb +++ b/app/models/customer.rb @@ -7,6 +7,8 @@ validates_length_of :name, :maximum=>200 validates_presence_of :name + validates_uniqueness_of :name, :scope => 'company_i...
Make sure client names are unique within a company
diff --git a/test.rb b/test.rb index abc1234..def5678 100644 --- a/test.rb +++ b/test.rb @@ -6,16 +6,31 @@ ffi_lib "gtk-x11-2.0" attach_function :gtk_init, [:pointer, :pointer], :void attach_function :gtk_main, [], :void + attach_function :gtk_main_quit, [], :void - def self.init - gtk_init nil, nil - e...
Connect signal for destroy event.
diff --git a/api/v1.rb b/api/v1.rb index abc1234..def5678 100644 --- a/api/v1.rb +++ b/api/v1.rb @@ -10,6 +10,10 @@ register Sinatra::Pebblebed set :config, Tiramisu.config + + before do + cache_control :private, :no_cache, :no_store, :must_revalidate + end helpers do
Add no-cache header to prevent Safari on IOS6 from caching POST requests (sic!)
diff --git a/bdd_settings.rb b/bdd_settings.rb index abc1234..def5678 100644 --- a/bdd_settings.rb +++ b/bdd_settings.rb @@ -13,9 +13,7 @@ require File.expand_path("../../config/environment", __FILE__) require 'rspec/rails' require 'authlogic/test_case' -require 'login_module' include Authlogic::TestCase -include Lo...
Remove the login_module requirement from rspec helper
diff --git a/src/shared/args.rb b/src/shared/args.rb index abc1234..def5678 100644 --- a/src/shared/args.rb +++ b/src/shared/args.rb @@ -5,6 +5,7 @@ while args.count > 0 arg = args.shift.strip next if arg.empty? + flag = nil if arg.start_with? '--' if flag.nil? if arg.start_with? '--' flag = arg[2...
Fix flags without arguments (`--with-cov --dump post`)
diff --git a/lib/blocktrain/aggregations/histogram_aggregation.rb b/lib/blocktrain/aggregations/histogram_aggregation.rb index abc1234..def5678 100644 --- a/lib/blocktrain/aggregations/histogram_aggregation.rb +++ b/lib/blocktrain/aggregations/histogram_aggregation.rb @@ -8,7 +8,6 @@ date_histogram: { ...
Stop changing the times of results