diff
stringlengths 65
26.7k
| message
stringlengths 7
9.92k
|
|---|---|
diff --git a/src/kff.BindingView.js b/src/kff.BindingView.js
index <HASH>..<HASH> 100644
--- a/src/kff.BindingView.js
+++ b/src/kff.BindingView.js
@@ -676,7 +676,8 @@ kff.BindingView = kff.createClass(
filterModel = this.collectionFilter.model || null;
filterFnName = this.collectionFilter.fn;
- a = this.collectionBinder.collection.array;
+ if(this.collectionBinder.collection instanceof kff.Collection) a = this.collectionBinder.collection.array;
+ else if(this.collectionBinder.collection instanceof Array) a = this.collectionBinder.collection;
for(i = 0, l = a.length; i < l; i++)
{
item = a[i];
|
fix(kff.BindingView): filtered collection binding doesn't work with plain array
|
diff --git a/lib/cucumber_analytics/version.rb b/lib/cucumber_analytics/version.rb
index <HASH>..<HASH> 100644
--- a/lib/cucumber_analytics/version.rb
+++ b/lib/cucumber_analytics/version.rb
@@ -1,3 +1,3 @@
module CucumberAnalytics
- VERSION = '1.5.2'
+ VERSION = '1.6.0'
end
|
Version bump.
Incremented the gem version to <I> in preparation for the upcoming
release.
|
diff --git a/src/sap.ui.core/src/sap/ui/base/ManagedObjectMetadata.js b/src/sap.ui.core/src/sap/ui/base/ManagedObjectMetadata.js
index <HASH>..<HASH> 100644
--- a/src/sap.ui.core/src/sap/ui/base/ManagedObjectMetadata.js
+++ b/src/sap.ui.core/src/sap/ui/base/ManagedObjectMetadata.js
@@ -766,6 +766,7 @@ function(
// as oClassInfo is volatile, we need to store the info
this._oDesignTime = oClassInfo.metadata["designtime"] || oClassInfo.metadata["designTime"];
+ this._sProvider = oClassInfo.metadata["provider"];
if ( oClassInfo.metadata.__version > 1.0 ) {
this.generateAccessors();
@@ -792,6 +793,7 @@ function(
this._sDefaultAggregation = this._sDefaultAggregation || oParent._sDefaultAggregation;
this._sDefaultProperty = this._sDefaultProperty || oParent._sDefaultProperty;
this._mAllSpecialSettings = jQuery.extend({}, oParent._mAllSpecialSettings, this._mSpecialSettings);
+ this._sProvider = this._sProvider || oParent._sProvider;
} else {
this._mAllEvents = this._mEvents;
this._mAllProperties = this._mProperties;
|
[INTERNAL] ManagedObject: Possibility to use own provider class
Change-Id: If<I>ca3bfb<I>f<I>bfadf1fb1bf9cafade7b<I>
|
diff --git a/provisioning/src/main/java/org/wildfly/build/StandaloneAetherArtifactFileResolver.java b/provisioning/src/main/java/org/wildfly/build/StandaloneAetherArtifactFileResolver.java
index <HASH>..<HASH> 100644
--- a/provisioning/src/main/java/org/wildfly/build/StandaloneAetherArtifactFileResolver.java
+++ b/provisioning/src/main/java/org/wildfly/build/StandaloneAetherArtifactFileResolver.java
@@ -119,8 +119,8 @@ public class StandaloneAetherArtifactFileResolver extends AetherArtifactFileReso
*/
public static List<RemoteRepository> getStandardRemoteRepositories() {
final List<RemoteRepository> remoteRepositories = new ArrayList<>();
- remoteRepositories.add(new RemoteRepository.Builder("central","default","http://central.maven.org/maven2/").build());
- remoteRepositories.add(new RemoteRepository.Builder("jboss-community-repository", "default", "http://repository.jboss.org/nexus/content/groups/public/").build());
+ remoteRepositories.add(new RemoteRepository.Builder("central","default","https://central.maven.org/maven2/").build());
+ remoteRepositories.add(new RemoteRepository.Builder("jboss-community-repository", "default", "https://repository.jboss.org/nexus/content/groups/public/").build());
return remoteRepositories;
}
}
|
[WFBUILD-<I>] Use https URLs for standard remote repositories
|
diff --git a/jsonapi/resource.py b/jsonapi/resource.py
index <HASH>..<HASH> 100644
--- a/jsonapi/resource.py
+++ b/jsonapi/resource.py
@@ -107,9 +107,9 @@ class Resource(object):
for field in model._meta.fields:
if field.rel and field.rel.multiple:
# relationship is ForeignKey
- if field.rel.to in model_resource_map:
+ related_model = field.rel.to
+ if related_model in model_resource_map:
# there is resource for related model
- related_model = field.rel.to
related_resource = model_resource_map[related_model]
fields[related_resource.Meta.name] = {
"type": Resource.FIELD_TYPES.TO_ONE,
|
unify method (make similar to method with the same functionality)
|
diff --git a/tests/example_spec.js b/tests/example_spec.js
index <HASH>..<HASH> 100644
--- a/tests/example_spec.js
+++ b/tests/example_spec.js
@@ -403,7 +403,7 @@ describe('Kitchen Sink [000]', function(){
})
- it('cy.uncheck() - uncheck a checkbox or radio element [00k]', function(){
+ it('cy.uncheck() - uncheck a checkbox element [00k]', function(){
// SOME OF THESE ARE COMMENTED OUT DUE TO AN
// ERROR CURRENTLY IN CYPRESS
@@ -421,7 +421,7 @@ describe('Kitchen Sink [000]', function(){
// **** Check Value ****
//
// cy.uncheck() accepts a value argument
- // that unchecks only checkboxes or radios
+ // that unchecks only checkboxes
// with matching values
//
// cy.get('.action-check [type='checkbox']').check('checkbox1').uncheck('checkbox1').should('not.be.checked')
|
removed radio el's from cy.uncheck description.
|
diff --git a/repository/upload/repository.class.php b/repository/upload/repository.class.php
index <HASH>..<HASH> 100755
--- a/repository/upload/repository.class.php
+++ b/repository/upload/repository.class.php
@@ -13,7 +13,8 @@ class repository_upload extends repository {
global $SESSION, $action, $CFG;
parent::__construct($repositoryid, $context, $options);
if($action=='upload'){
- $this->info = repository_store_to_filepool('repo_upload_file');
+ $filepath = '/'.uniqid().'/';
+ $this->info = repository_store_to_filepool('repo_upload_file', 'user_draft', $filepath);
}
}
|
"MDL-<I>, use a random path for uploaded file"
|
diff --git a/widgets/TbButtonGroup.php b/widgets/TbButtonGroup.php
index <HASH>..<HASH> 100644
--- a/widgets/TbButtonGroup.php
+++ b/widgets/TbButtonGroup.php
@@ -115,6 +115,7 @@ class TbButtonGroup extends CWidget
'items'=>isset($button['items']) ? $button['items'] : array(),
'ajaxOptions'=>isset($button['ajaxOptions']) ? $button['ajaxOptions'] : array(),
'htmlOptions'=>isset($button['htmlOptions']) ? $button['htmlOptions'] : array(),
+ 'dropdownOptions'=>isset($button['dropdownOptions']) ? $button['dropdownOptions'] : array(),
'encodeLabel'=>isset($button['encodeLabel']) ? $button['encodeLabel'] : $this->encodeLabel,
));
}
|
added possibility to set dropdownOptions for TbButtonGroup (Issue #<I>)
|
diff --git a/transport/src/main/java/io/netty/bootstrap/AbstractBootstrap.java b/transport/src/main/java/io/netty/bootstrap/AbstractBootstrap.java
index <HASH>..<HASH> 100644
--- a/transport/src/main/java/io/netty/bootstrap/AbstractBootstrap.java
+++ b/transport/src/main/java/io/netty/bootstrap/AbstractBootstrap.java
@@ -39,7 +39,7 @@ import java.util.Map;
* <p>When not used in a {@link ServerBootstrap} context, the {@link #bind()} methods are useful for connectionless
* transports such as datagram (UDP).</p>
*/
-abstract class AbstractBootstrap<B extends AbstractBootstrap<B, C>, C extends Channel> implements Cloneable {
+public abstract class AbstractBootstrap<B extends AbstractBootstrap<B, C>, C extends Channel> implements Cloneable {
private volatile EventLoopGroup group;
private volatile ChannelFactory<? extends C> channelFactory;
|
Make AbstractBootstrap public
.. to work around the issue with JDK reflection described here:
<URL>
|
diff --git a/plugins/remark.js b/plugins/remark.js
index <HASH>..<HASH> 100644
--- a/plugins/remark.js
+++ b/plugins/remark.js
@@ -16,6 +16,21 @@ class Remark {
typeof remark === 'object' && typeof slideshow === 'object');
}
+ async configure() {
+ await this.page.emulateMedia(null);
+ await this.page.evaluate(_ => {
+ for (let j = 0; j < document.styleSheets.length; j++) {
+ const sheet = document.styleSheets[j];
+ if (!sheet.rules) continue;
+ for (let i = sheet.rules.length - 1; i >= 0; i--) {
+ if (sheet.rules[i].cssText.indexOf('@media print') >= 0) {
+ sheet.deleteRule(i);
+ }
+ }
+ }
+ });
+ }
+
slideCount() {
return this.page.evaluate(_ => slideshow.getSlideCount());
}
|
Work-around Remark rendering issue with screen media emulation
|
diff --git a/examples/LedControlExample.js b/examples/LedControlExample.js
index <HASH>..<HASH> 100644
--- a/examples/LedControlExample.js
+++ b/examples/LedControlExample.js
@@ -36,7 +36,7 @@ function loop() {
}
function loop2() {
lc2.clearDisplay();
- lc2.showNumber(0, (Date.now()-startTime)/20, 0, 3, false, 3, true)
+ lc2.showNumber(0, (Date.now()-startTime)/20, 1, 4, false, 3, true)
lc2.showNumber(0, (Date.now()-startTime)/100, 0, 3, false, 7, true);
if(Date.now()-startTime>100000) startTime = Date.now();
|
added ! to characters, updated package with node version number, optimised number conversions
|
diff --git a/mod/assignment/simpletest/test_assignment_portfolio_callers.php b/mod/assignment/simpletest/test_assignment_portfolio_callers.php
index <HASH>..<HASH> 100644
--- a/mod/assignment/simpletest/test_assignment_portfolio_callers.php
+++ b/mod/assignment/simpletest/test_assignment_portfolio_callers.php
@@ -18,7 +18,7 @@ class testAssignmentPortfolioCallers extends portfoliolib_test {
parent::setUp();
$assignment_types = new stdClass();
$assignment_types->type = GENERATOR_SEQUENCE;
- $assignment_types->options = array('upload');
+ $assignment_types->options = array('online');
$settings = array('quiet' => 1,
'modules_list' => array($this->module_type), 'assignment_grades' => true,
|
MDL-<I>: assignment portfolio unit tests should not try and use file-ish assignment types yet
|
diff --git a/jupyter-js-widgets/src/utils.js b/jupyter-js-widgets/src/utils.js
index <HASH>..<HASH> 100644
--- a/jupyter-js-widgets/src/utils.js
+++ b/jupyter-js-widgets/src/utils.js
@@ -186,7 +186,7 @@ function typeset(element, text) {
*/
var escape_html = function(text) {
var esc = document.createElement('div');
- esc.innerHTML = text;
+ esc.textContent = text;
return esc.innerHTML;
};
|
Update escape_html function to return HTML character entity encoded characters based on input.
|
diff --git a/version.php b/version.php
index <HASH>..<HASH> 100644
--- a/version.php
+++ b/version.php
@@ -29,11 +29,11 @@
defined('MOODLE_INTERNAL') || die();
-$version = 2014041700.01; // YYYYMMDD = weekly release date of this DEV branch.
+$version = 2014042200.00; // YYYYMMDD = weekly release date of this DEV branch.
// RR = release increments - 00 in DEV branches.
// .XX = incremental changes.
-$release = '2.7beta+ (Build: 20140417)'; // Human-friendly version name
+$release = '2.7beta+ (Build: 20140422)'; // Human-friendly version name
$branch = '27'; // This version's branch.
$maturity = MATURITY_BETA; // This version's maturity level.
|
on-demand release <I>beta+
|
diff --git a/lib/watch.js b/lib/watch.js
index <HASH>..<HASH> 100644
--- a/lib/watch.js
+++ b/lib/watch.js
@@ -140,7 +140,7 @@ module.exports = function(chrome) {
log('Hot reloading', file)
chrome.send('Runtime.evaluate', { expression: updateSrc(file) })
- .then(Promise.all(Array.from(chrome.styles.values()).map(style => {
+ .then(() => Promise.all(Array.from(chrome.styles.values()).map(style => {
const string = style.text.split(file).join(file.split('?')[0] + '?' + Date.now())
if (string !== style.text) {
|
then takes a function, if not Promise.all runs first
|
diff --git a/events/observer.js b/events/observer.js
index <HASH>..<HASH> 100644
--- a/events/observer.js
+++ b/events/observer.js
@@ -140,7 +140,7 @@ sb.events.observer = {
//handle keypresses
this.documentKeyPress = sb.events.add(document, 'keypress', this.delegateEvents);
- if(sb.browser.agent === 'ie' && sb.browser.version < 8){
+ if(sb.browser.agent === 'ie' && sb.browser.version < 9){
this.handleIEEventBubbles();
}
|
event observer handles IE bubble events for change and submit even with IE 8, not needed for 9+
|
diff --git a/client/index.js b/client/index.js
index <HASH>..<HASH> 100644
--- a/client/index.js
+++ b/client/index.js
@@ -45,20 +45,26 @@ const render = () => {
// Match routes based on location object:
match({ routes, location }, (error, redirectLocation, renderProps) => {
if (error) console.log(error)
- // Get array of route handler components:
- const { components } = renderProps
-
- // Define locals to be provided to all lifecycle hooks:
- const locals = {
- path: renderProps.location.pathname,
- query: renderProps.location.query,
- params: renderProps.params,
- host: window.location.host,
+ let locals = {
// Allow lifecycle hooks to dispatch Redux actions:
dispatch,
getState
}
+ let components
+
+ if (renderProps) {
+ // Get array of route handler components:
+ components = renderProps.components
+
+ // Define locals to be provided to all lifecycle hooks:
+ locals = {...locals,
+ path: renderProps.location.pathname,
+ query: renderProps.location.query,
+ params: renderProps.params,
+ host: window.location.host,
+ }
+ }
// Don't fetch data for initial route, server has already done the work:
if (window.INITIAL_STATE) {
|
Fix warning when renderProps is undefined. Closes #<I>
|
diff --git a/gss/src/test/java/org/globus/gsi/gssapi/test/GlobusGSSContextTest.java b/gss/src/test/java/org/globus/gsi/gssapi/test/GlobusGSSContextTest.java
index <HASH>..<HASH> 100644
--- a/gss/src/test/java/org/globus/gsi/gssapi/test/GlobusGSSContextTest.java
+++ b/gss/src/test/java/org/globus/gsi/gssapi/test/GlobusGSSContextTest.java
@@ -62,6 +62,16 @@ public class GlobusGSSContextTest extends TestCase {
System.setProperty("org.globus.gsi.gssapi.provider",
"org.globus.gsi.gssapi.GlobusGSSManagerImpl");
+ if (clientContext != null) {
+ clientContext.dispose();
+ clientContext = null;
+ }
+
+ if (serverContext != null) {
+ serverContext.dispose();
+ serverContext = null;
+ }
+
GSSManager manager = getGSSManager();
@@ -82,10 +92,12 @@ public class GlobusGSSContextTest extends TestCase {
protected void tearDown() throws Exception {
if (clientContext != null) {
clientContext.dispose();
+ clientContext = null;
}
if (serverContext != null) {
serverContext.dispose();
+ serverContext = null;
}
}
|
These fixes take of the issue that was visible on certain non-server
class machines where Java was allocating <I>MB max.
|
diff --git a/src/crd/writer.js b/src/crd/writer.js
index <HASH>..<HASH> 100644
--- a/src/crd/writer.js
+++ b/src/crd/writer.js
@@ -176,7 +176,11 @@ function validateFields(fields) {
}
field.type = type;
if (typeof field.length !== 'number') {
- field.length = 1;
+ if (field.type.name === 'ascii') {
+ field.length = 0;
+ } else {
+ field.length = 1;
+ }
}
if (field.length < 0 || field.length > 255) {
throw new Error('field length must be a number in the range 0-255');
|
default length for ascii is variable
|
diff --git a/lib/net/ssh/authentication/methods/publickey.rb b/lib/net/ssh/authentication/methods/publickey.rb
index <HASH>..<HASH> 100644
--- a/lib/net/ssh/authentication/methods/publickey.rb
+++ b/lib/net/ssh/authentication/methods/publickey.rb
@@ -82,6 +82,8 @@ module Net
when USERAUTH_FAILURE
return false
+ when USERAUTH_SUCCESS
+ return true
else
raise Net::SSH::Exception, "unexpected reply to USERAUTH_REQUEST: #{message.type} (#{message.inspect})"
|
fixing to work with windows and wingftpserver connecting with public key
|
diff --git a/src/Common/Service/Profiler.php b/src/Common/Service/Profiler.php
index <HASH>..<HASH> 100644
--- a/src/Common/Service/Profiler.php
+++ b/src/Common/Service/Profiler.php
@@ -87,8 +87,8 @@ class Profiler
$aBacktrace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 2);
$aCaller = $aBacktrace[1];
- $sCaller = $aCaller['class'] .
- '->' . $aCaller['function'];
+ $sCaller = (!empty($aCaller['class']) ? $aCaller['class'] . '->' : '') .
+ (!empty($aCaller['function']) ? $aCaller['function'] : 'Unknown');
if (!$sLabel) {
$sLabel = $sCaller;
|
Improved Profiler rendering of caller details
|
diff --git a/python/testing/__init__.py b/python/testing/__init__.py
index <HASH>..<HASH> 100644
--- a/python/testing/__init__.py
+++ b/python/testing/__init__.py
@@ -0,0 +1,14 @@
+import unittest
+
+def test_module(m, runner=None):
+ if runner is None:
+ runner = unittest.TestRunner()
+ suite = unittest.TestSuite()
+ for key in dir(m):
+ val = getattr(m, key)
+ try:
+ if issubclass(val, unittest.TestCase):
+ suite.addTest(val)
+ except:
+ pass
+ return runner.run(suite)
\ No newline at end of file
|
Workaround for micropython-lib unittest module main() being buggy/unhelpful with module introspection
|
diff --git a/quest-owlapi3/src/test/java/it/unibz/inf/ontop/reformulation/tests/LeftJoinProfTest.java b/quest-owlapi3/src/test/java/it/unibz/inf/ontop/reformulation/tests/LeftJoinProfTest.java
index <HASH>..<HASH> 100644
--- a/quest-owlapi3/src/test/java/it/unibz/inf/ontop/reformulation/tests/LeftJoinProfTest.java
+++ b/quest-owlapi3/src/test/java/it/unibz/inf/ontop/reformulation/tests/LeftJoinProfTest.java
@@ -129,7 +129,6 @@ public class LeftJoinProfTest {
assertFalse(NO_SELF_LJ_OPTIMIZATION_MSG, containsMoreThanOneOccurrence(sql, "\"PROFESSORS\""));
}
- @Ignore("Not supported yet")
@Test
public void testFullName1() throws Exception {
@@ -155,7 +154,6 @@ public class LeftJoinProfTest {
assertFalse(NO_SELF_LJ_OPTIMIZATION_MSG, containsMoreThanOneOccurrence(sql, "\"PROFESSORS\""));
}
- @Ignore("TODO: add the fix point to enable it")
@Test
public void testFullName2() throws Exception {
|
Two tests enabled in LeftJoinProfTest.
|
diff --git a/app/worker.js b/app/worker.js
index <HASH>..<HASH> 100644
--- a/app/worker.js
+++ b/app/worker.js
@@ -1,17 +1,6 @@
const {createContext, Script} = require('vm')
const { Request, Response, Headers } = require("node-fetch");
-class FetchEvent {
- constructor(request) {
- this.type = 'fetch';
- this.request = request;
- }
-
- respondWith(response) {
- this.response = Promise.resolve(response);
- }
-}
-
class Worker {
constructor(workerContents, {forwardHost, fetch} = {}) {
this.listeners = {
@@ -37,10 +26,14 @@ class Worker {
}
- async executeFetchEvent(...args) {
- const event = new FetchEvent(new Request(...args));
- this.triggerEvent("fetch", event);
- return await event.response;
+ executeFetchEvent(...args) {
+ let response = null;
+ this.triggerEvent("fetch", {
+ type: 'fetch',
+ request: new Request(...args),
+ respondWith: (r) => response = r
+ });
+ return Promise.resolve(response);
}
addEventListener(event, listener) {
|
Removing an Unnecessary Class
|
diff --git a/src/notebook/menu/index.js b/src/notebook/menu/index.js
index <HASH>..<HASH> 100644
--- a/src/notebook/menu/index.js
+++ b/src/notebook/menu/index.js
@@ -4,6 +4,8 @@ import {
showSaveAsDialog,
} from '../api/save';
+import { tildify } from '../native-window';
+
import {
executeCell,
newKernel,
@@ -11,7 +13,7 @@ import {
saveAs,
killKernel,
} from '../actions';
-import { ipcRenderer as ipc, webFrame } from 'electron';
+import { ipcRenderer as ipc, webFrame, BrowserWindow } from 'electron';
import {
publish,
@@ -29,8 +31,9 @@ export function triggerSaveAs(store, dispatch) {
if (!filename) {
return;
}
- const { notebook } = store.getState();
+ const { notebook, executionState} = store.getState();
dispatch(saveAs(filename, notebook));
+ BrowserWindow.getFocusedWindw().setTitle(`${tildify(filename)} - ${executionState}`);
}
);
}
|
Updated focused browser window title on saveAs
|
diff --git a/visidata/loaders/npy.py b/visidata/loaders/npy.py
index <HASH>..<HASH> 100644
--- a/visidata/loaders/npy.py
+++ b/visidata/loaders/npy.py
@@ -91,4 +91,4 @@ def save_npy(vd, p, sheet):
arr = np.array(data, dtype=dtype)
with p.open_bytes(mode='w') as outf:
- np.save(outf, arr, **self.options.getall('npy_'))
+ np.save(outf, arr, **sheet.options.getall('npy_'))
|
[npy-] fix typo in save
|
diff --git a/python_modules/dagster-test/dagster_test/fixtures/docker_compose.py b/python_modules/dagster-test/dagster_test/fixtures/docker_compose.py
index <HASH>..<HASH> 100644
--- a/python_modules/dagster-test/dagster_test/fixtures/docker_compose.py
+++ b/python_modules/dagster-test/dagster_test/fixtures/docker_compose.py
@@ -9,7 +9,7 @@ import pytest
from .utils import BUILDKITE
-@pytest.fixture
+@pytest.fixture(scope="module")
def docker_compose_cm(test_directory):
@contextmanager
def docker_compose(
diff --git a/python_modules/dagster-test/dagster_test/fixtures/utils.py b/python_modules/dagster-test/dagster_test/fixtures/utils.py
index <HASH>..<HASH> 100644
--- a/python_modules/dagster-test/dagster_test/fixtures/utils.py
+++ b/python_modules/dagster-test/dagster_test/fixtures/utils.py
@@ -16,7 +16,7 @@ def retrying_requests():
yield session
-@pytest.fixture
+@pytest.fixture(scope="module")
def test_directory(request):
yield os.path.dirname(request.fspath)
|
make some docker-compose fixtures module-scoped (#<I>)
Summary:
These allow you to have fixtures that only run docker-compose once per module
Test Plan: BK
Reviewers: jmsanders
|
diff --git a/PhoneGapLib/javascripts/core/contact.js b/PhoneGapLib/javascripts/core/contact.js
index <HASH>..<HASH> 100644
--- a/PhoneGapLib/javascripts/core/contact.js
+++ b/PhoneGapLib/javascripts/core/contact.js
@@ -66,5 +66,5 @@ ContactManager.prototype.contactsCount = function(successCallback, errorCallback
}
PhoneGap.addConstructor(function() {
- if (typeof navigator.ContactManager == "undefined") navigator.ContactManager = new ContactManager();
+ if (typeof navigator.contacts == "undefined") navigator.contacts = new ContactManager();
});
|
Updated to conform to MobileSpec. navigator.ContactManager becomes navigator.contacts
see <URL>
|
diff --git a/metaextract/metaextract.py b/metaextract/metaextract.py
index <HASH>..<HASH> 100644
--- a/metaextract/metaextract.py
+++ b/metaextract/metaextract.py
@@ -50,6 +50,9 @@ class metaextract(Command):
'scripts', 'tests_require', 'tests_suite']:
if hasattr(self.distribution, key):
data[key] = getattr(self.distribution, key)
+ # dict_items objects can not be serialized with json
+ if data[key].__class__.__name__ == 'dict_items':
+ data[key] = list(data[key])
# keep list ordered!
for func in ['has_ext_modules']:
|
Fix json serialization for dict_items on py3 (#4)
With python<I>, data_files is a 'dict_items' object which is not
serializable.
Closes #4
|
diff --git a/app/models/agents/imap_folder_agent.rb b/app/models/agents/imap_folder_agent.rb
index <HASH>..<HASH> 100644
--- a/app/models/agents/imap_folder_agent.rb
+++ b/app/models/agents/imap_folder_agent.rb
@@ -302,9 +302,10 @@ module Agents
def each_unread_mail
host, port, ssl, username = interpolated.values_at(:host, :port, :ssl, :username)
ssl = boolify(ssl)
+ port = (Integer(port) if port.present?)
log "Connecting to #{host}#{':%d' % port if port}#{' via SSL' if ssl}"
- Client.open(host, Integer(port), ssl) { |imap|
+ Client.open(host, port, ssl) { |imap|
log "Logging in as #{username}"
imap.login(username, interpolated[:password])
|
ImapFolderAgent: Do not fail when port is blank.
|
diff --git a/src/Config/FastRoute.php b/src/Config/FastRoute.php
index <HASH>..<HASH> 100644
--- a/src/Config/FastRoute.php
+++ b/src/Config/FastRoute.php
@@ -11,6 +11,7 @@ class FastRoute extends SingleValueDirectiveGroup
const POST = 2;
const PUT = 4;
const DELETE = 8;
+ const RESTFUL = self::GET | self::POST | self::PUT | self::DELETE;
/**
* FastRoute constructor.
|
Add RESTFUL const to ease restful routes declaration
|
diff --git a/src/LiveDevelopment/Agents/RemoteFunctions.js b/src/LiveDevelopment/Agents/RemoteFunctions.js
index <HASH>..<HASH> 100644
--- a/src/LiveDevelopment/Agents/RemoteFunctions.js
+++ b/src/LiveDevelopment/Agents/RemoteFunctions.js
@@ -217,8 +217,8 @@ function RemoteFunctions(experimental) {
highlight.style.setProperty("z-index", 2000000);
highlight.style.setProperty("position", "absolute");
highlight.style.setProperty("pointer-events", "none");
- highlight.style.setProperty("background", "rgba(94,167,255, 0.2)");
- highlight.style.setProperty("box-shadow", "0 0 4px 2px rgba(94,167,255, 0.5)");
+ highlight.style.setProperty("background","rgba(94,167,255, 0.1)");
+ highlight.style.setProperty("box-shadow", "0 0 8px 2px rgba(94,167,255, 0.3), inset 0 0 4px 1px rgba(255,255,255,0.6)");
highlight.style.setProperty("border-top-left-radius", styles.borderTopLeftRadius);
highlight.style.setProperty("border-top-right-radius", styles.borderTopRightRadius);
highlight.style.setProperty("border-bottom-left-radius", styles.borderBottomLeftRadius);
|
Added light inset shadow for visibility on dark backgrounds, toned back some of the colors in general
|
diff --git a/niworkflows/utils/spaces.py b/niworkflows/utils/spaces.py
index <HASH>..<HASH> 100644
--- a/niworkflows/utils/spaces.py
+++ b/niworkflows/utils/spaces.py
@@ -667,6 +667,9 @@ class OutputReferencesAction(argparse.Action):
and ":resolution-" not in val
):
# by default, explicitly set volumetric resolution to native
+ # relevant discussions:
+ # https://github.com/nipreps/niworkflows/pull/457#discussion_r375510227
+ # https://github.com/nipreps/niworkflows/pull/494
val = ":".join((val, "res-native"))
for sp in Reference.from_string(val):
spaces.add(sp)
|
doc: insert urls to discussions [skip ci]
|
diff --git a/lib/database_cleaner.rb b/lib/database_cleaner.rb
index <HASH>..<HASH> 100644
--- a/lib/database_cleaner.rb
+++ b/lib/database_cleaner.rb
@@ -1,6 +1,3 @@
$LOAD_PATH.unshift(File.expand_path(File.dirname(__FILE__))) unless $LOAD_PATH.include?(File.expand_path(File.dirname(__FILE__)))
require 'database_cleaner/configuration'
-def DatabaseCleaner(*args)
- DatabaseCleaner.create_strategy(*args)
-end
diff --git a/spec/database_cleaner/configuration_spec.rb b/spec/database_cleaner/configuration_spec.rb
index <HASH>..<HASH> 100644
--- a/spec/database_cleaner/configuration_spec.rb
+++ b/spec/database_cleaner/configuration_spec.rb
@@ -21,10 +21,10 @@ describe DatabaseCleaner do
DatabaseCleaner.orm = nil
end
- describe ".create_strategy ( DatabaseCleaner() )" do
+ describe ".create_strategy" do
it "should initialize and return the appropirate strategy" do
DatabaseCleaner::ActiveRecord::Transaction.should_receive(:new).with('options' => 'hash')
- result = DatabaseCleaner(:transaction, {'options' => 'hash'})
+ result = DatabaseCleaner.create_strategy(:transaction, {'options' => 'hash'})
result.should == @strategy
end
|
DatabaseCleaner() method was cool, but really isn't needed...
|
diff --git a/src/Theme/HookManager.php b/src/Theme/HookManager.php
index <HASH>..<HASH> 100644
--- a/src/Theme/HookManager.php
+++ b/src/Theme/HookManager.php
@@ -119,11 +119,10 @@ class HookManager
}
if (!array_key_exists($classarg, $this->instances)) {
- if ($classarg instanceof WpBridgeAwareInterface) {
- $class = new $classarg;
+ $class = new $classarg;
+
+ if ($class instanceof WpBridgeAwareInterface) {
$class->setWpBridge($this->getWpBridge());
- } else {
- $class = new $classarg;
}
$this->instances[$classarg] = $class;
|
Added support for WpBridgeAwareInterface in HookManger.
|
diff --git a/src/interface/button.js b/src/interface/button.js
index <HASH>..<HASH> 100644
--- a/src/interface/button.js
+++ b/src/interface/button.js
@@ -52,6 +52,8 @@ export const destroyAll = {
export function setup() {
setupLogger();
+ getButtonsComponent();
+ getCheckoutComponent();
}
export function destroy() {
|
Register button and checkout components in setup step
|
diff --git a/src/main/java/org/lmdbjava/ByteBufferProxy.java b/src/main/java/org/lmdbjava/ByteBufferProxy.java
index <HASH>..<HASH> 100644
--- a/src/main/java/org/lmdbjava/ByteBufferProxy.java
+++ b/src/main/java/org/lmdbjava/ByteBufferProxy.java
@@ -133,7 +133,7 @@ public final class ByteBufferProxy {
final int minWords = minLength / Long.BYTES;
final boolean reverse1 = o1.order() == LITTLE_ENDIAN;
- final boolean reverse2 = o1.order() == LITTLE_ENDIAN;
+ final boolean reverse2 = o2.order() == LITTLE_ENDIAN;
for (int i = 0; i < minWords * Long.BYTES; i += Long.BYTES) {
final long lw = reverse1 ? reverseBytes(o1.getLong(i)) : o1.getLong(i);
final long rw = reverse2 ? reverseBytes(o2.getLong(i)) : o2.getLong(i);
|
fix a typo in ByteBufferProxy (#<I>)
|
diff --git a/support/mocha-blanket.js b/support/mocha-blanket.js
index <HASH>..<HASH> 100755
--- a/support/mocha-blanket.js
+++ b/support/mocha-blanket.js
@@ -59,9 +59,9 @@
});
//I dont know why these became global leaks
- runner.globals(['stats', 'failures', 'runner']);
+ runner.globals(['stats', 'failures', 'runner', '_$blanket']);
- originalReporter(runner);
+ originalReporter.apply(this, [runner]);
};
// From mocha.js HTML reporter
|
call originalReporter with correct "this"
|
diff --git a/framework/directives/scrollable.js b/framework/directives/scrollable.js
index <HASH>..<HASH> 100644
--- a/framework/directives/scrollable.js
+++ b/framework/directives/scrollable.js
@@ -38,7 +38,7 @@ limitations under the License.
scrollWrapper = element[0];
- var offset = parseInt(attrs.threshold) || 0;
+ var offset = parseInt(attrs.threshold) || 10;
scrollWrapper.addEventListener('scroll', function() {
if (scope.infinitScrollEnable) {
|
make infinit scroll threshold more sensitive
|
diff --git a/climb/config.py b/climb/config.py
index <HASH>..<HASH> 100644
--- a/climb/config.py
+++ b/climb/config.py
@@ -17,9 +17,23 @@ def load_config(name):
paths = [path.format(name=name) for path in DEFAULT_CONFIG_PATHS]
for config_path in paths:
- config_path = os.path.expanduser(config_path)
- if os.path.isfile(config_path) and os.access(config_path, os.R_OK):
- config.read(config_path)
+ if _read_config(config_path):
break
else:
raise ConfigNotFound("Could not find {name}.conf".format(name))
+
+
+def load_config_file(path):
+ config.clear()
+
+ if not _read_config(path):
+ raise ConfigNotFound("Could not load {}".format(path))
+
+
+def _read_config(path):
+ config_path = os.path.expanduser(path)
+ if os.path.isfile(config_path) and os.access(config_path, os.R_OK):
+ config.read(config_path)
+ return True
+ else:
+ return False
|
Add method for direct config loading.
|
diff --git a/lib/hamlit/doctype_compiler.rb b/lib/hamlit/doctype_compiler.rb
index <HASH>..<HASH> 100644
--- a/lib/hamlit/doctype_compiler.rb
+++ b/lib/hamlit/doctype_compiler.rb
@@ -3,26 +3,37 @@ require 'hamlit/filter'
module Hamlit
class DoctypeCompiler < Hamlit::Filter
def on_haml_doctype(format, type)
- case type
- when 'XML'
- return [:static, "<?xml version='1.0' encoding='utf-8' ?>"]
+ if type == 'XML'
+ return xml_doctype_tag(format)
+ elsif type
+ return doctype_tag(type)
end
- [:html, :doctype, convert_format(format, type).to_s]
+ case format
+ when :html4
+ doctype_tag(:transitional)
+ when :html5
+ doctype_tag(:html)
+ when :xhtml
+ doctype_tag(:transitional)
+ else
+ doctype_tag(format)
+ end
end
private
- def convert_format(format, type)
+ def xml_doctype_tag(format)
case format
when :html4, :html5
- :html
- when :xhtml
- return type if type
- :transitional
+ [:newline]
else
- format
+ [:static, "<?xml version='1.0' encoding='utf-8' ?>"]
end
end
+
+ def doctype_tag(type)
+ [:html, :doctype, type.to_s]
+ end
end
end
|
Pass doctype haml-spec
|
diff --git a/modules/timestamp.js b/modules/timestamp.js
index <HASH>..<HASH> 100644
--- a/modules/timestamp.js
+++ b/modules/timestamp.js
@@ -7,12 +7,12 @@ function updateTimestampEl(el) {
}
setInterval(function () {
- var els = [].slice.call(document.querySelectorAll('.timestamp'))
+ var els = [].slice.call(document.querySelectorAll('.pw__timestamp'))
els.forEach(updateTimestampEl)
}, 60e3)
exports.message_main_meta = function (msg) {
- return updateTimestampEl(h('a.enter.timestamp', {
+ return updateTimestampEl(h('a.enter.pw__timestamp', {
href: '#'+msg.key,
timestamp: msg.value.timestamp,
title: new Date(msg.value.timestamp)
|
stop patchbay timestamps from conflicting with patchwork-next ones (hack)
|
diff --git a/client/src/main/java/io/pravega/client/stream/impl/ControllerResolverFactory.java b/client/src/main/java/io/pravega/client/stream/impl/ControllerResolverFactory.java
index <HASH>..<HASH> 100644
--- a/client/src/main/java/io/pravega/client/stream/impl/ControllerResolverFactory.java
+++ b/client/src/main/java/io/pravega/client/stream/impl/ControllerResolverFactory.java
@@ -188,7 +188,9 @@ public class ControllerResolverFactory extends NameResolver.Factory {
public void shutdown() {
if (!shutdown) {
log.info("Shutting down ControllerNameResolver");
- this.scheduledExecutor.shutdownNow();
+ if (this.scheduledExecutor != null) {
+ this.scheduledExecutor.shutdownNow();
+ }
shutdown = true;
}
}
|
Issue <I>: NPE during shutdown of ControllerNameResolver (#<I>)
* Checks for null before ControllerNameResolver#shutdown.
|
diff --git a/index.js b/index.js
index <HASH>..<HASH> 100644
--- a/index.js
+++ b/index.js
@@ -57,7 +57,7 @@ function cftemplate(
// Format markup for insertion at the current position.
function format(form) {
return formToMarkup(form)
- // split lines
+ // Split lines.
.split('\n')
.map(function(line, index) {
return (
@@ -163,7 +163,13 @@ function cftemplate(
key = directive.substring(7)
if (!context.hasOwnProperty(key) || !context[key]) {
stringify(token.content, context, handler, callback) }
- else { callback(null, '') } } },
+ else { callback(null, '') } }
+
+ else {
+ callback(
+ addPosition(
+ new Error(),
+ ( 'Invalid directive ' + directive ))) } },
// Plaintemplate directive tokens.
{ open: '((', close: '))', start: 'begin', end: 'end' })
|
Call back with an error for unrecognized directives
|
diff --git a/pkg/codegen/dotnet/gen.go b/pkg/codegen/dotnet/gen.go
index <HASH>..<HASH> 100644
--- a/pkg/codegen/dotnet/gen.go
+++ b/pkg/codegen/dotnet/gen.go
@@ -105,6 +105,9 @@ func isImmutableArrayType(t schema.Type, wrapInput bool) bool {
}
func isValueType(t schema.Type) bool {
+ if _, ok := t.(*schema.EnumType); ok {
+ return true
+ }
switch t {
case schema.BoolType, schema.IntType, schema.NumberType:
return true
|
[codegen/dotnet] - Fix isValueType to include enums (#<I>)
|
diff --git a/core/src/main/java/com/google/bitcoin/core/Transaction.java b/core/src/main/java/com/google/bitcoin/core/Transaction.java
index <HASH>..<HASH> 100644
--- a/core/src/main/java/com/google/bitcoin/core/Transaction.java
+++ b/core/src/main/java/com/google/bitcoin/core/Transaction.java
@@ -491,6 +491,10 @@ public class Transaction extends ChildMessage implements Serializable {
s.append(" ");
s.append(getHashAsString());
s.append("\n");
+ if (inputs.size() == 0) {
+ s.append(" INCOMPLETE: No inputs!\n");
+ return s.toString();
+ }
if (isCoinBase()) {
String script;
String script2;
|
Don't crash if trying to print a transaction with no inputs
|
diff --git a/lib/amee-data-abstraction/calculation.rb b/lib/amee-data-abstraction/calculation.rb
index <HASH>..<HASH> 100644
--- a/lib/amee-data-abstraction/calculation.rb
+++ b/lib/amee-data-abstraction/calculation.rb
@@ -130,6 +130,7 @@ module AMEE
def discover_url
"http://discover.amee.com/categories#{path}"
end
+
def explorer_url
Rails.logger.info "#explorer_url method deprecated. Use #discover_url" if defined? Rails
|
change explorer_url mathod to discvoer
|
diff --git a/index.js b/index.js
index <HASH>..<HASH> 100644
--- a/index.js
+++ b/index.js
@@ -37,12 +37,13 @@ Deployor.defaults = {
Deployor.verbose = false;
+sh.config.silent = !Deployor.verbose;
var e = Deployor.exec = function (cmd) {
if (Deployor.verbose) {
console.log('$ ', cmd);
}
- return sh.exec(cmd + Deployor.verbose ? '' : ' &> /dev/null');
+ return sh.exec(cmd);
};
Deployor.cloneRepoBranch = function cloneRepoBranch(options) {
@@ -131,7 +132,7 @@ Deployor.prototype = {
if (res && res.code > 0) console.log('Can\'t tag failed, continuing !');
},
push: function () {
- var res = e('git push --tags origin $BRANCH' + Deployor.verbose ? '' : ' &> /dev/null');
+ var res = e('git push --tags origin $BRANCH');
if (res && res.code > 0) throw new Error(res.output);
}
};
|
feat(deploy): silent with shelljs.config
|
diff --git a/fseval_test.go b/fseval_test.go
index <HASH>..<HASH> 100644
--- a/fseval_test.go
+++ b/fseval_test.go
@@ -1,6 +1,7 @@
package mtree
import (
+ "encoding/json"
"io/ioutil"
"os"
"path/filepath"
@@ -8,7 +9,7 @@ import (
"time"
)
-var mockTime = time.Unix(1337888823, 88288518233)
+var mockTime = time.Unix(1337888823, 0)
// Here be some dodgy testing. In particular, we have to mess around with some
// of the FsEval functions. In particular, we change all of the FileInfos to a
@@ -155,6 +156,11 @@ func TestCheckFsEval(t *testing.T) {
t.Fatal(err)
}
if len(res) > 0 {
- t.Errorf("%#v", res)
+ buf, err := json.MarshalIndent(res, "", " ")
+ if err != nil {
+ t.Errorf("%#v", res)
+ } else {
+ t.Errorf("%s", buf)
+ }
}
}
|
fseval: not nanosecond for mock test
while testing on osx, it seems that it doesn't support nanoseconds so it
fails this check because the mockFsEval returns the nsec precision, but
the actual expected results is:
"old": "<I>"
"new": "<I>"
Ideally there will be a way to detect when the fs supports nsecs
|
diff --git a/parsl/dataflow/dflow.py b/parsl/dataflow/dflow.py
index <HASH>..<HASH> 100644
--- a/parsl/dataflow/dflow.py
+++ b/parsl/dataflow/dflow.py
@@ -61,10 +61,13 @@ class DataFlowKernel(object):
Returns:
DataFlowKernel object
"""
- self.config = {"sites" : [],
- "globals" : {},
- "controller" : {}}
- self.config.update(config)
+ if config:
+ self.config = {"sites" : [],
+ "globals" : {},
+ "controller" : {}}
+ self.config.update(config)
+ else:
+ self.config = config
# Create run dirs for this run
self.rundir = make_rundir(config=self.config, path=rundir)
|
Fixing issue with cases with no config
|
diff --git a/fault/tester.py b/fault/tester.py
index <HASH>..<HASH> 100644
--- a/fault/tester.py
+++ b/fault/tester.py
@@ -68,7 +68,7 @@ class Tester:
self.clock = clock
if reset is not None and not isinstance(reset, m.ResetType):
raise TypeError(f"Expected reset port: {reset, type(reset)}")
- self.reset = reset
+ self.reset_port = reset
self.targets = {}
# For public verilator modules
self.verilator_includes = []
@@ -387,14 +387,14 @@ class Tester:
def sync_reset(self, active_high=True, cycles=1):
# assert reset and set clock to zero
- self.poke(self.reset, 1 if active_high else 0)
+ self.poke(self.reset_port, 1 if active_high else 0)
self.poke(self.clock, 0)
# wait the desired number of clock cycles
self.step(2 * cycles)
# de-assert reset
- self.poke(self.reset, 0 if active_high else 1)
+ self.poke(self.reset_port, 0 if active_high else 1)
class LoopIndex:
|
rename reset variable to avoid conflict
|
diff --git a/samples/system-test/sample.test.js b/samples/system-test/sample.test.js
index <HASH>..<HASH> 100644
--- a/samples/system-test/sample.test.js
+++ b/samples/system-test/sample.test.js
@@ -16,7 +16,9 @@
'use strict';
const {assert} = require('chai');
-const {execSync} = require('child_process');
+const cp = require('child_process');
+
+const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
describe('container samples', () => {
it('should run the quickstart', async () => {
|
refactor: wrap execSync with encoding: utf-8 (#<I>)
|
diff --git a/pages/app/presenters/refinery/pages/title_section_presenter.rb b/pages/app/presenters/refinery/pages/title_section_presenter.rb
index <HASH>..<HASH> 100644
--- a/pages/app/presenters/refinery/pages/title_section_presenter.rb
+++ b/pages/app/presenters/refinery/pages/title_section_presenter.rb
@@ -4,6 +4,8 @@ module Refinery
# a title. These are much like normal sections except they are wrapped in
# a h1 tag rather than a div.
class TitleSectionPresenter < SectionPresenter
+ include ActionView::Helpers::SanitizeHelper
+
private
def wrap_content_in_tag(content)
|
Add SanitizeHelper to TitleSectionPresenter
|
diff --git a/crawler/crawling/pipelines.py b/crawler/crawling/pipelines.py
index <HASH>..<HASH> 100644
--- a/crawler/crawling/pipelines.py
+++ b/crawler/crawling/pipelines.py
@@ -59,7 +59,7 @@ class LoggingBeforePipeline(object):
item_copy['action'] = 'emit'
self.logger.info('Scraped page', extra=item_copy)
return item
- elif isinstance(item, ErrorResponseItem):
+ elif isinstance(item):
item['logger'] = self.logger.name()
self.logger.error('Scraper Retry', extra=item)
return None
|
ErrorResponseItem no longer needed
|
diff --git a/lib/discordrb/webhooks/client.rb b/lib/discordrb/webhooks/client.rb
index <HASH>..<HASH> 100644
--- a/lib/discordrb/webhooks/client.rb
+++ b/lib/discordrb/webhooks/client.rb
@@ -8,6 +8,11 @@ module Discordrb::Webhooks
# @param token [String] The webhook's authorisation token. Will only be used
# if `url` is not set.
def initialize(url: nil, id: nil, token: nil)
+ @url = if url
+ url
+ else
+ generate_url(id, token)
+ end
end
private
|
:anchor: Use generate_url to obtain a URL if none is given
|
diff --git a/lib/instana/instrumentation/rack.rb b/lib/instana/instrumentation/rack.rb
index <HASH>..<HASH> 100644
--- a/lib/instana/instrumentation/rack.rb
+++ b/lib/instana/instrumentation/rack.rb
@@ -5,11 +5,19 @@ module Instana
end
def call(env)
- req = ::Rack::Request.new(env)
kvs = { :http => {} }
- kvs[:http][:method] = req.request_method
- kvs[:http][:url] = ::CGI.unescape(req.path)
- ::Instana.tracer.log_start_or_continue(:rack)
+ kvs[:http][:method] = env['REQUEST_METHOD']
+ kvs[:http][:url] = ::CGI.unescape(env['PATH_INFO'])
+
+ # Check incoming context
+ incoming_context = {}
+ if env.key?('HTTP_X_INSTANA_T')
+ incoming_context[:trace_id] = env['HTTP_X_INSTANA_T']
+ incoming_context[:parent_id] = env['HTTP_X_INSTANA_S'] if env.key?('HTTP_X_INSTANA_S')
+ incoming_context[:level] = env['HTTP_X_INSTANA_L'] if env.key?('HTTP_X_INSTANA_L')
+ end
+
+ ::Instana.tracer.log_start_or_continue(:rack, {}, incoming_context)
status, headers, response = @app.call(env)
|
Pickup incoming context from HTTP headers.
|
diff --git a/pydevd_concurrency_analyser/pydevd_concurrency_logger.py b/pydevd_concurrency_analyser/pydevd_concurrency_logger.py
index <HASH>..<HASH> 100644
--- a/pydevd_concurrency_analyser/pydevd_concurrency_logger.py
+++ b/pydevd_concurrency_analyser/pydevd_concurrency_logger.py
@@ -1,4 +1,3 @@
-import time
from pydevd_concurrency_analyser.pydevd_thread_wrappers import ObjectWrapper, wrap_attr
import pydevd_file_utils
|
Fix ImportError after refactoring (PY-<I>)
(cherry picked from commit <I>d0f)
|
diff --git a/discord/http.py b/discord/http.py
index <HASH>..<HASH> 100644
--- a/discord/http.py
+++ b/discord/http.py
@@ -463,7 +463,7 @@ class HTTPClient:
def edit_member(self, guild_id, user_id, **fields):
r = Route('PATCH', '/guilds/{guild_id}/members/{user_id}', guild_id=guild_id, user_id=user_id)
- return self.request(r, json=fields, bucket=bucket)
+ return self.request(r, json=fields)
# Channel management
|
Fix NameError inside HTTPClient.edit_member.
|
diff --git a/lib/db/schemaupdater.go b/lib/db/schemaupdater.go
index <HASH>..<HASH> 100644
--- a/lib/db/schemaupdater.go
+++ b/lib/db/schemaupdater.go
@@ -452,7 +452,16 @@ func (db *schemaUpdater) updateSchemato9(prev int) error {
metas := make(map[string]*metadataTracker)
for it.Next() {
intf, err := t.unmarshalTrunc(it.Value(), false)
- if err != nil {
+ if backend.IsNotFound(err) {
+ // Unmarshal error due to missing parts (block list), probably
+ // due to a bad migration in a previous RC. Drop this key, as
+ // getFile would anyway return this as a "not found" in the
+ // normal flow of things.
+ if err := t.Delete(it.Key()); err != nil {
+ return err
+ }
+ continue
+ } else if err != nil {
return err
}
fi := intf.(protocol.FileInfo)
|
lib/db: Be more lenient during migration (fixes #<I>) (#<I>)
|
diff --git a/Configuration/TCA/tx_happyfeet_domain_model_footnote.php b/Configuration/TCA/tx_happyfeet_domain_model_footnote.php
index <HASH>..<HASH> 100644
--- a/Configuration/TCA/tx_happyfeet_domain_model_footnote.php
+++ b/Configuration/TCA/tx_happyfeet_domain_model_footnote.php
@@ -34,6 +34,7 @@ return array(
'label' => 'LLL:EXT:lang/locallang_general.xml:LGL.language',
'config' => array(
'type' => 'select',
+ 'renderType' => 'selectSingle',
'foreign_table' => 'sys_language',
'foreign_table_where' => 'ORDER BY sys_language.title',
'items' => array(
@@ -48,6 +49,7 @@ return array(
'label' => 'LLL:EXT:lang/locallang_general.xml:LGL.l18n_parent',
'config' => array(
'type' => 'select',
+ 'renderType' => 'selectSingle',
'items' => array(
array('', 0),
),
|
[TASK] Upadte TCA configuration
Add "renderType" configuration to "select" fields.
|
diff --git a/src/test/java/guru/qas/martini/DefaultMixologistTest.java b/src/test/java/guru/qas/martini/DefaultMixologistTest.java
index <HASH>..<HASH> 100644
--- a/src/test/java/guru/qas/martini/DefaultMixologistTest.java
+++ b/src/test/java/guru/qas/martini/DefaultMixologistTest.java
@@ -65,7 +65,7 @@ public class DefaultMixologistTest {
String expected = "Feature: Functionality of the Reporting Subsystem\n" +
"Resource: " + path + "\n" +
"Scenario: A Corner Case\n" +
- "Line: 10";
+ "Line: 25";
assertEquals(toString, expected, "wrong information returned through toString()");
}
|
Fixing failing tests due to line number change occurring with addition of license comments to test resource file.
|
diff --git a/lib/celluloid/version.rb b/lib/celluloid/version.rb
index <HASH>..<HASH> 100644
--- a/lib/celluloid/version.rb
+++ b/lib/celluloid/version.rb
@@ -1,3 +1,3 @@
module Celluloid
- VERSION = '0.17.0.pre4'
+ VERSION = '0.17.0.pre5'
end
|
push another prerelease until this situtation is figured out so we can just use raw repositories again
|
diff --git a/ehforwarderbot/__version__.py b/ehforwarderbot/__version__.py
index <HASH>..<HASH> 100644
--- a/ehforwarderbot/__version__.py
+++ b/ehforwarderbot/__version__.py
@@ -1,3 +1,3 @@
# coding=utf-8
-__version__ = "2.0.1.dev1"
+__version__ = "2.0.0"
|
fix: revert version number bump
|
diff --git a/lib/oxidized/output/git.rb b/lib/oxidized/output/git.rb
index <HASH>..<HASH> 100644
--- a/lib/oxidized/output/git.rb
+++ b/lib/oxidized/output/git.rb
@@ -43,7 +43,8 @@ class Git < Output
update type_repo, file, type_cfg unless type_cfg.empty?
end
- update repo, file, outputs.to_cfg
+ output = outputs.to_cfg
+ update repo, file, output unless output.empty?
end
|
don't commit empty config in git output
|
diff --git a/framework/core/js/src/forum/components/Post.js b/framework/core/js/src/forum/components/Post.js
index <HASH>..<HASH> 100644
--- a/framework/core/js/src/forum/components/Post.js
+++ b/framework/core/js/src/forum/components/Post.js
@@ -120,7 +120,7 @@ export default class Post extends Component {
/**
* Get the post's classes.
*
- * @param string classes
+ * @param existing string
* @returns {string[]}
*/
classes(existing) {
@@ -137,7 +137,7 @@ export default class Post extends Component {
classes.push('Post--by-actor');
}
- if (user && user === discussion.user()) {
+ if (user && user.id() === discussion.attribute('startUserId')) {
classes.push('Post--by-start-user');
}
|
fix: `Post--by-actor` not showing when comparing user instances as `discussion.user()` is not loaded (#<I>)
|
diff --git a/src/Application.php b/src/Application.php
index <HASH>..<HASH> 100644
--- a/src/Application.php
+++ b/src/Application.php
@@ -19,12 +19,14 @@ use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\DependencyInjection\ContainerAwareInterface;
use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\EventDispatcher\EventDispatcherInterface;
use Symfony\Component\Finder\Finder;
use Throwable;
use TJM\Component\Console\DependencyInjection\ConsoleExtension;
use TJM\Component\DependencyInjection\Loader\MultiPathLoader;
class Application extends Base implements ContainerAwareInterface{
+ protected $dispatcher;
public function __construct($config = null){
parent::__construct();
@@ -33,6 +35,11 @@ class Application extends Base implements ContainerAwareInterface{
}
}
+ //--override to support use in `doRun`
+ public function setDispatcher(EventDispatcherInterface $dispatcher){
+ $this->dispatcher = $dispatcher;
+ }
+
//--override to remove built in `-n` and `-q` short options
protected function configureIO(InputInterface $input, OutputInterface $output){
//--determine decoration
|
fix: we must override dispatcher because it is private upstream
|
diff --git a/app/models/alchemy/page/publisher.rb b/app/models/alchemy/page/publisher.rb
index <HASH>..<HASH> 100644
--- a/app/models/alchemy/page/publisher.rb
+++ b/app/models/alchemy/page/publisher.rb
@@ -19,9 +19,11 @@ module Alchemy
version = public_version(public_on)
DeleteElements.new(version.elements).call
- # We must not use .find_each here to not mess up the order of elements
- page.draft_version.elements.not_nested.available.each do |element|
- Element.copy(element, page_version_id: version.id)
+ repository = page.draft_version.element_repository
+ repository.visible.not_nested.each do |element|
+ Alchemy::DuplicateElement.new(element, repository: repository).call(
+ page_version_id: version.id,
+ )
end
end
end
|
Use page version element repo and duplicator in publisher
This should speed up page publishing considerably. Specs are sufficient.
|
diff --git a/models/classes/user/LtiUserService.php b/models/classes/user/LtiUserService.php
index <HASH>..<HASH> 100755
--- a/models/classes/user/LtiUserService.php
+++ b/models/classes/user/LtiUserService.php
@@ -65,7 +65,7 @@ abstract class LtiUserService extends ConfigurableService
*/
public function findOrSpawnUser(LtiLaunchData $launchData)
{
- $lock = $this->createLock(__METHOD__ . $launchData->getUserID() . $launchData->getLtiConsumer(), 30);
+ $lock = $this->createLock(__METHOD__ . $launchData->getUserID() . $launchData->getLtiConsumer()->getUri(), 30);
$lock->acquire(true);
try {
|
Do not generate lock id based on label
|
diff --git a/cluster/manager.go b/cluster/manager.go
index <HASH>..<HASH> 100644
--- a/cluster/manager.go
+++ b/cluster/manager.go
@@ -1386,7 +1386,7 @@ func (c *ClusterManager) Enumerate() (api.Cluster, error) {
config := api.FluentDConfig{}
- if len(splits) > 0 {
+ if len(splits) > 1 {
config.IP = splits[0]
config.Port = splits[1]
}
|
Fix potential panic - index out of range
|
diff --git a/examples/cookie/main.go b/examples/cookie/main.go
index <HASH>..<HASH> 100644
--- a/examples/cookie/main.go
+++ b/examples/cookie/main.go
@@ -72,8 +72,8 @@ func setcookies(host string, res *string) cdp.Tasks {
return cdp.Tasks{
cdp.ActionFunc(func(ctxt context.Context, h cdptypes.Handler) error {
expr := cdptypes.TimeSinceEpoch(time.Now().Add(180 * 24 * time.Hour))
- success, err := network.SetCookie(host, "cookiename", "cookievalue").
- WithExpirationDate(&expr).
+ success, err := network.SetCookie("cookiename", "cookievalue").
+ WithExpires(&expr).
WithDomain("localhost").
WithHTTPOnly(true).
Do(ctxt, h)
|
Updating cookie example for new changed API
|
diff --git a/carrot/backends/pyamqplib.py b/carrot/backends/pyamqplib.py
index <HASH>..<HASH> 100644
--- a/carrot/backends/pyamqplib.py
+++ b/carrot/backends/pyamqplib.py
@@ -200,7 +200,7 @@ class Backend(BaseBackend):
def close(self):
"""Close the channel if open."""
- if getattr(self, "channel") and self.channel.is_open:
+ if getattr(self, "_channel") and self.channel.is_open:
self.channel.close()
self._channel = None
@@ -229,6 +229,7 @@ class Backend(BaseBackend):
immediate=None):
"""Publish a message to a named exchange."""
return self.channel.basic_publish(message, exchange=exchange,
- routing_key=routing_key,
- mandatory=mandatory,
- immediate=immediate)
+ routing_key=routing_key,
+ mandatory=mandatory,
+ immediate=immediate)
+
|
pyamqplib backend close didn't work properly, typo channel -> _channel
|
diff --git a/app/controllers/alchemy/admin/essence_pictures_controller.rb b/app/controllers/alchemy/admin/essence_pictures_controller.rb
index <HASH>..<HASH> 100644
--- a/app/controllers/alchemy/admin/essence_pictures_controller.rb
+++ b/app/controllers/alchemy/admin/essence_pictures_controller.rb
@@ -35,7 +35,7 @@ module Alchemy
@essence_picture.update(essence_picture_params)
end
- # Assigns picture, but does not saves it.
+ # Assigns picture, but does not save it.
#
# When the user saves the element the content gets updated as well.
#
@@ -43,7 +43,6 @@ module Alchemy
@picture = Picture.find_by(id: params[:picture_id])
@content.essence.picture = @picture
@element = @content.element
- @options = @options.merge(sortable: @options[:grouped])
# We need to update timestamp here because we don't save yet,
# but the cache needs to be get invalid.
|
Remove superfluous options ivar from essence pictures controller
The options ivar is already set by the before_action and we dont want to override the sortable option here, as it is already set in the params.
|
diff --git a/lib/showdown.js b/lib/showdown.js
index <HASH>..<HASH> 100644
--- a/lib/showdown.js
+++ b/lib/showdown.js
@@ -1026,6 +1026,8 @@ var _DoItalicsAndBold = function(text) {
text = text.replace(/(\*\*|__)(?=\S)([^\r]*?\S[*_]*)\1/g,
"<strong>$2</strong>");
+ text = text.replace(/(\w)_(\w)/g, "$1~E95E$2") // ** JT ** "~E95E" == escaped "_"
+
text = text.replace(/(\*|_)(?=\S)([^\r]*?\S)\1/g,
"<em>$2</em>");
|
Another GFM thing: don't italicize a_b_c
|
diff --git a/test/RoaveTest/DeveloperTools/Inspection/AggregateInspectionTest.php b/test/RoaveTest/DeveloperTools/Inspection/AggregateInspectionTest.php
index <HASH>..<HASH> 100644
--- a/test/RoaveTest/DeveloperTools/Inspection/AggregateInspectionTest.php
+++ b/test/RoaveTest/DeveloperTools/Inspection/AggregateInspectionTest.php
@@ -20,6 +20,7 @@ namespace RoaveTest\DeveloperTools\Inspection;
use ArrayObject;
use Roave\DeveloperTools\Inspection\AggregateInspection;
+use Roave\DeveloperTools\Inspection\InspectionInterface;
use Roave\DeveloperTools\Inspection\TimeInspection;
/**
@@ -55,10 +56,10 @@ class AggregateInspectionTest extends AbstractInspectionTest
*/
public function testAllowsTraversableParameters()
{
- $timeInspection = new TimeInspection(123, 456);
- $inspection = new AggregateInspection(new ArrayObject([$timeInspection]));
+ $mockInspection = $this->getMock(InspectionInterface::class);
+ $inspection = new AggregateInspection(new ArrayObject([$mockInspection]));
- $this->assertEquals($timeInspection, $inspection->getInspectionData()[0]);
+ $this->assertEquals($mockInspection, $inspection->getInspectionData()[0]);
}
/**
|
Using mocks in inspection tests instead of concrede instances
|
diff --git a/lib/scientist/version.rb b/lib/scientist/version.rb
index <HASH>..<HASH> 100644
--- a/lib/scientist/version.rb
+++ b/lib/scientist/version.rb
@@ -1,3 +1,3 @@
module Scientist
- VERSION = "1.3.0"
+ VERSION = "1.4.0"
end
|
Bump to <I>
Incrementing minor version since MismatchException base class changes.
|
diff --git a/spec/tripod/predicates_spec.rb b/spec/tripod/predicates_spec.rb
index <HASH>..<HASH> 100644
--- a/spec/tripod/predicates_spec.rb
+++ b/spec/tripod/predicates_spec.rb
@@ -23,6 +23,13 @@ describe Tripod::Predicates do
stmt3.predicate = RDF::URI.new('http://name')
stmt3.object = "ric"
@graph << stmt3
+
+ # throw a random other statement (about name) in the mix!
+ stmt4 = RDF::Statement.new
+ stmt4.subject = RDF::URI.new('http://name')
+ stmt4.predicate = RDF::RDFS.label
+ stmt4.object = "name"
+ @graph << stmt4
end
let(:person) do
@@ -77,6 +84,8 @@ describe Tripod::Predicates do
person.predicates.length.should == 2
person.predicates.should == [RDF::URI('http://blog'), RDF::URI('http://name')]
end
+
+
end
end
\ No newline at end of file
|
added test for predicates being polluted by other triples
|
diff --git a/spring-cloud-bus/src/main/java/org/springframework/cloud/bus/BusEnvironmentPostProcessor.java b/spring-cloud-bus/src/main/java/org/springframework/cloud/bus/BusEnvironmentPostProcessor.java
index <HASH>..<HASH> 100644
--- a/spring-cloud-bus/src/main/java/org/springframework/cloud/bus/BusEnvironmentPostProcessor.java
+++ b/spring-cloud-bus/src/main/java/org/springframework/cloud/bus/BusEnvironmentPostProcessor.java
@@ -46,6 +46,12 @@ public class BusEnvironmentPostProcessor implements EnvironmentPostProcessor {
@Override
public void postProcessEnvironment(ConfigurableEnvironment environment, SpringApplication application) {
+ if (environment.containsProperty(ConditionalOnBusEnabled.SPRING_CLOUD_BUS_ENABLED)) {
+ if (Boolean.FALSE.toString()
+ .equalsIgnoreCase(environment.getProperty(ConditionalOnBusEnabled.SPRING_CLOUD_BUS_ENABLED))) {
+ return;
+ }
+ }
Map<String, Object> overrides = new HashMap<>();
String definition = BusConstants.BUS_CONSUMER;
if (environment.containsProperty(FN_DEF_PROP)) {
|
Do not run post processor if bus is disabled
|
diff --git a/GPflow/tf_wraps.py b/GPflow/tf_wraps.py
index <HASH>..<HASH> 100644
--- a/GPflow/tf_wraps.py
+++ b/GPflow/tf_wraps.py
@@ -25,7 +25,7 @@ from ._settings import settings
import numpy as np
-def eye(N):
+def eye(N): # pragma: no cover
"""
An identitiy matrix
"""
|
removing deprecated functinos from coverage
|
diff --git a/src/Node/File.php b/src/Node/File.php
index <HASH>..<HASH> 100644
--- a/src/Node/File.php
+++ b/src/Node/File.php
@@ -26,7 +26,7 @@ class File implements FileInterface, GenericOperationInterface
public function exists()
{
- return $this->filesystem->stat($this->filename);
+ return $this->stat();
}
public function size()
|
Even making it simple and effectively degrading exists to a stat (maybe ditch exists all together?)
|
diff --git a/src/armet/api.py b/src/armet/api.py
index <HASH>..<HASH> 100755
--- a/src/armet/api.py
+++ b/src/armet/api.py
@@ -9,7 +9,12 @@ from django.conf.urls import patterns, url, include
from armet import resources
-class Api(resources.Resource, MutableSequence):
+class DeclarativeApi(resources.DeclarativeResource, abc.ABCMeta):
+ pass
+
+
+class Api(six.with_metaclass(DeclarativeApi, resources.Resource),
+ MutableSequence):
"""Implements an api registry used to make APIs visible.
"""
|
Fused the metaclasses.
|
diff --git a/lib/drafting/instance_methods.rb b/lib/drafting/instance_methods.rb
index <HASH>..<HASH> 100644
--- a/lib/drafting/instance_methods.rb
+++ b/lib/drafting/instance_methods.rb
@@ -5,16 +5,7 @@ module Drafting
draft = Draft.find_by_id(self.draft_id) || Draft.new
- new_object = self.class.new
-
- attrs = self.attributes.select { |k,v| v != new_object.attributes[k] }
- self.draft_extra_attributes.each do |name|
- if (value = self.send(name)) != new_object.send(name)
- attrs[name.to_s] = value
- end
- end
-
- draft.data = attrs
+ draft.data = attributes_to_store_for_draft
draft.target_type = self.class.name
draft.user = user
draft.parent = self.send(self.class.draft_parent) if self.class.draft_parent
@@ -38,5 +29,20 @@ module Drafting
self.draft_id = nil if draft.destroy
end
end
+
+ def attributes_to_store_for_draft
+ # First, select attributes with values different from default
+ new_object = self.class.new
+ attrs = self.attributes.select { |k,v| v != new_object.attributes[k] }
+
+ # Second, add extra attributes with values different from default
+ self.draft_extra_attributes.each do |name|
+ if (value = self.send(name)) != new_object.send(name)
+ attrs[name.to_s] = value
+ end
+ end
+
+ attrs
+ end
end
end
|
Refactor InstanceMethods (split method)
|
diff --git a/src/Cookie/FileCookieJar.php b/src/Cookie/FileCookieJar.php
index <HASH>..<HASH> 100644
--- a/src/Cookie/FileCookieJar.php
+++ b/src/Cookie/FileCookieJar.php
@@ -56,7 +56,7 @@ class FileCookieJar extends CookieJar
}
$jsonStr = \GuzzleHttp\json_encode($json);
- if (false === file_put_contents($filename, $jsonStr)) {
+ if (false === file_put_contents($filename, $jsonStr, LOCK_EX)) {
throw new \RuntimeException("Unable to save file {$filename}");
}
}
|
Prevent concurrent writes
Concurrent writes might lead to invalid JSON being saved in the cookie jar.
|
diff --git a/src/select.js b/src/select.js
index <HASH>..<HASH> 100644
--- a/src/select.js
+++ b/src/select.js
@@ -403,10 +403,12 @@
// ctrl.tagging pushes items to ctrl.items, so we only have empty val
// for `item` if it is a detected duplicate
if ( item === undefined ) return;
+
// create new item on the fly if we don't already have one;
- // use tagging function if we have one, otherwise, push a string
- if ( ctrl.tagging.fct !== undefined && item === undefined ) {
+ // use tagging function if we have one
+ if ( ctrl.tagging.fct !== undefined && typeof item === 'string' ) {
item = ctrl.tagging.fct(ctrl.search);
+ // if item type is 'string', apply the tagging label
} else if ( typeof item === 'string' ) {
item = item.replace(ctrl.taggingLabel,'');
}
|
make sure the tagging tranform function is called if available
|
diff --git a/test/fixtures/tasks/echo.js b/test/fixtures/tasks/echo.js
index <HASH>..<HASH> 100644
--- a/test/fixtures/tasks/echo.js
+++ b/test/fixtures/tasks/echo.js
@@ -9,7 +9,7 @@
module.exports = function(grunt) {
'use strict';
grunt.registerMultiTask('echo', 'A task that echos a message.', function() {
- var msg = this.data.message || 'I do absolutely nothing.';
- grunt.log.writeln(msg);
+ var msg = this.data.message || 'I do absolutely nothing.';
+ grunt.log.writeln(msg);
});
};
|
Fix indentation in echo task fixture
|
diff --git a/clock/rfc822.go b/clock/rfc822.go
index <HASH>..<HASH> 100644
--- a/clock/rfc822.go
+++ b/clock/rfc822.go
@@ -80,3 +80,7 @@ func (t *RFC822Time) UnmarshalJSON(s []byte) error {
func (t RFC822Time) String() string {
return t.Format(RFC1123)
}
+
+func (t RFC822Time) StringWithOffset() string {
+ return t.Format(RFC1123Z)
+}
diff --git a/clock/rfc822_test.go b/clock/rfc822_test.go
index <HASH>..<HASH> 100644
--- a/clock/rfc822_test.go
+++ b/clock/rfc822_test.go
@@ -4,6 +4,7 @@ import (
"encoding/json"
"fmt"
"testing"
+ "time"
"github.com/stretchr/testify/assert"
)
@@ -162,3 +163,9 @@ func TestParseRFC822Time(t *testing.T) {
})
}
}
+
+func TestStringWithOffset(t *testing.T) {
+ now := time.Now().UTC()
+ r := NewRFC822Time(now)
+ assert.Equal(t, now.Format(time.RFC1123Z), r.StringWithOffset())
+}
|
add StringWithOffset method to RFC<I>Time struct
|
diff --git a/plugins/commands/serve/service/provider_service.rb b/plugins/commands/serve/service/provider_service.rb
index <HASH>..<HASH> 100644
--- a/plugins/commands/serve/service/provider_service.rb
+++ b/plugins/commands/serve/service/provider_service.rb
@@ -110,7 +110,7 @@ module VagrantPlugins
def state_spec(*_)
funcspec(
args: [
- SDK::Args::Target::Machine
+ SDK::Args::Target
],
result: SDK::Args::Target::Machine::State,
)
|
Request target in spec and allow conversion to machine
|
diff --git a/gomatic/go_cd_configurator.py b/gomatic/go_cd_configurator.py
index <HASH>..<HASH> 100755
--- a/gomatic/go_cd_configurator.py
+++ b/gomatic/go_cd_configurator.py
@@ -291,7 +291,8 @@ class HostRestClient(object):
return (self.__username, self.__password) if self.__username or self.__password else None
def get(self, path):
- result = requests.get(self.__path(path), auth=self.__auth(), verify=self.__verify_ssl)
+ header = {'Accept': 'application/vnd.go.cd.v1+json'}
+ result = requests.get(self.__path(path), auth=self.__auth(), verify=self.__verify_ssl, headers=header)
count = 0
while ((result.status_code == 503) or (result.status_code == 504)) and (count < 5):
result = requests.get(self.__path(path))
|
adding Accept header to allow reuse with API endpoints
|
diff --git a/spec/lib/legato/query_spec.rb b/spec/lib/legato/query_spec.rb
index <HASH>..<HASH> 100644
--- a/spec/lib/legato/query_spec.rb
+++ b/spec/lib/legato/query_spec.rb
@@ -164,6 +164,14 @@ describe Legato::Query do
@query.metrics.include?(:pageviews).should eq(true)
@query.metrics.include?(:sessions).should eq(true)
end
+
+ it 'does not share metrics across queries' do
+ query1 = Legato::Query.new(@klass)
+ query2 = Legato::Query.new(@klass)
+
+ query1.metrics << :pageviews
+ expect(query2.metrics).to_not include(:pageviews)
+ end
end
context 'when applying filters' do
|
add spec to check for sharing of metrics across query instances
|
diff --git a/dosagelib/util.py b/dosagelib/util.py
index <HASH>..<HASH> 100644
--- a/dosagelib/util.py
+++ b/dosagelib/util.py
@@ -305,7 +305,7 @@ def check_robotstxt(url, session):
roboturl = get_roboturl(url)
rp = get_robotstxt_parser(roboturl, session=session)
if not rp.can_fetch(UserAgent, str(url)):
- raise IOError("%s is disallowed by robots.txt" % url)
+ raise IOError("%s is disallowed by %s" % (url, roboturl))
@memoized
@@ -329,10 +329,10 @@ def get_robotstxt_parser(url, session=None):
def urlopen(url, session, referrer=None, max_content_bytes=None,
timeout=ConnectionTimeoutSecs, raise_for_status=True,
- stream=False, data=None):
+ stream=False, data=None, useragent=UserAgent):
"""Open an URL and return the response object."""
out.debug(u'Open URL %s' % url)
- headers = {'User-Agent': UserAgent}
+ headers = {'User-Agent': useragent}
if referrer:
headers['Referer'] = referrer
out.debug(u'Sending headers %s' % headers, level=3)
|
Minor useragent refactoring
|
diff --git a/cloudplatform/service/device/src/main/java/io/rhiot/cloudplatform/service/device/spring/DeviceServiceConfiguration.java b/cloudplatform/service/device/src/main/java/io/rhiot/cloudplatform/service/device/spring/DeviceServiceConfiguration.java
index <HASH>..<HASH> 100644
--- a/cloudplatform/service/device/src/main/java/io/rhiot/cloudplatform/service/device/spring/DeviceServiceConfiguration.java
+++ b/cloudplatform/service/device/src/main/java/io/rhiot/cloudplatform/service/device/spring/DeviceServiceConfiguration.java
@@ -22,17 +22,20 @@ import io.rhiot.cloudplatform.service.binding.ServiceBinding;
import io.rhiot.cloudplatform.service.device.MongoDbDeviceRegistry;
import org.eclipse.cloudplatform.service.device.api.DeviceRegistry;
import org.springframework.beans.factory.annotation.Value;
+import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
@Configuration
public class DeviceServiceConfiguration {
+ @ConditionalOnBean
@Bean
ServiceBinding deviceServiceBinding(PayloadEncoding payloadEncoding) {
return new ServiceBinding(payloadEncoding, "device");
}
+ @ConditionalOnBean
@Bean(name = "device")
DeviceRegistry deviceRegistry(Mongo mongo,
@Value("${device.metrics.mongodb.db:rhiot}") String db,
|
Device service components should be overridable.
|
diff --git a/test/eth/AccountsService.spec.js b/test/eth/AccountsService.spec.js
index <HASH>..<HASH> 100644
--- a/test/eth/AccountsService.spec.js
+++ b/test/eth/AccountsService.spec.js
@@ -134,6 +134,25 @@ test('useAccountWithAddress', async () => {
expect(service.currentAddress()).toEqual(a2.address);
});
+/*
+test('add and use account with no name', async () => {
+ const service = new AccountsService();
+ const engine = (service._engine = mockEngine());
+ const a1 = TestAccountProvider.nextAccount();
+ const a2 = TestAccountProvider.nextAccount();
+ await service.addAccount('foo', { type: 'privateKey', key: a1.key });
+ await service.addAccount(null, { type: 'privateKey', key: a2.key });
+ service.useAccount('foo');
+ service.useAccount(a2.address);
+
+ expect(engine.stop).toBeCalled();
+ expect(engine.removeProvider).toBeCalled();
+ expect(engine.start).toBeCalled();
+ expect(engine.addProvider).toBeCalled();
+ expect(service.currentAddress()).toEqual(a2.address);
+});
+*/
+
test('providerAccountFactory', async () => {
const rpc = new RpcSource({ rpcUrl: 'http://localhost:2000' });
const account = await providerAccountFactory(null, rpc);
|
add test for adding account with no name
|
diff --git a/lib/solargraph/source.rb b/lib/solargraph/source.rb
index <HASH>..<HASH> 100644
--- a/lib/solargraph/source.rb
+++ b/lib/solargraph/source.rb
@@ -499,8 +499,15 @@ module Solargraph
elsif c.type == :defs
s_visi = visibility
s_visi = :public if scope != :class
- method_pins.push Solargraph::Pin::Method.new(source, c, fqn || '', :class, s_visi)
- inner_map_node c, tree, scope, :class, fqn, stack
+ if c.children[0].is_a?(AST::Node) and c.children[0].type == :self
+ dfqn = fqn || ''
+ else
+ dfqn = unpack_name(c.children[0])
+ end
+ unless dfqn.nil?
+ method_pins.push Solargraph::Pin::Method.new(source, c, dfqn, :class, s_visi)
+ inner_map_node c, tree, scope, :class, dfqn, stack
+ end
next
elsif c.type == :send and [:public, :protected, :private].include?(c.children[1])
visibility = c.children[1]
|
Resolve explicit namespaces in singleton method definitions.
|
diff --git a/lib/Models/Leaflet.js b/lib/Models/Leaflet.js
index <HASH>..<HASH> 100644
--- a/lib/Models/Leaflet.js
+++ b/lib/Models/Leaflet.js
@@ -226,7 +226,7 @@ Leaflet.prototype.captureScreenshot = function() {
var deferred = when.defer();
// Temporarily hide the map credits.
- this.map.attributionControl.removeFrom(this.map);
+ this.map.attributionControl.remove();
var that = this;
|
Modify code that uses a Leafelt 1 renamed function
|
diff --git a/lib/guard/jasmine/cli.rb b/lib/guard/jasmine/cli.rb
index <HASH>..<HASH> 100644
--- a/lib/guard/jasmine/cli.rb
+++ b/lib/guard/jasmine/cli.rb
@@ -105,13 +105,14 @@ module Guard
runner_options[:jasmine_url] = options.url || "http://localhost:#{ runner_options[:port] }/jasmine"
runner_options[:phantomjs_bin] = options.bin || CLI.which('phantomjs')
runner_options[:timeout] = options.timeout
+ runner_options[:server] = options.server.to_sym
runner_options[:server_env] = options.server_env
runner_options[:server_timeout] = options.server_timeout
+ runner_options[:rackup_config] = options.rackup_config
runner_options[:spec_dir] = options.spec_dir
runner_options[:console] = [:always, :never, :failure].include?(options.console.to_sym) ? options.console.to_sym : :failure
runner_options[:errors] = [:always, :never, :failure].include?(options.errors.to_sym) ? options.errors.to_sym : :failure
runner_options[:specdoc] = [:always, :never, :failure].include?(options.specdoc.to_sym) ? options.specdoc.to_sym : :always
- runner_options[:server] = options.server.to_sym
runner_options[:focus] = options.focus
|
Allowed passing custom rackup config via CLI
|
diff --git a/pkg/test/ginkgo/junit.go b/pkg/test/ginkgo/junit.go
index <HASH>..<HASH> 100644
--- a/pkg/test/ginkgo/junit.go
+++ b/pkg/test/ginkgo/junit.go
@@ -145,7 +145,7 @@ func writeJUnitReport(filePrefix, name string, tests []*testCase, dir string, du
},
})
case test.success:
- s.NumFailed++
+ s.NumTests++
s.TestCases = append(s.TestCases, &JUnitTestCase{
Name: test.name,
Duration: test.duration.Seconds(),
|
Fix count of failures in JUnit output
Don't count success as a failure.
|
diff --git a/library/src/main/java/com/liulishuo/magicprogresswidget/MagicProgressCircle.java b/library/src/main/java/com/liulishuo/magicprogresswidget/MagicProgressCircle.java
index <HASH>..<HASH> 100644
--- a/library/src/main/java/com/liulishuo/magicprogresswidget/MagicProgressCircle.java
+++ b/library/src/main/java/com/liulishuo/magicprogresswidget/MagicProgressCircle.java
@@ -291,8 +291,10 @@ public class MagicProgressCircle extends View implements ISmoothTarget {
* @param footOverHead Boolean
*/
public void setFootOverHead(boolean footOverHead) {
- this.isFootOverHead = footOverHead;
- invalidate();
+ if (this.isFootOverHead != footOverHead) {
+ this.isFootOverHead = footOverHead;
+ invalidate();
+ }
}
public boolean isFootOverHead() {
|
refactor(MagicProgressCircle): effective invalidate when update footOverHead
|
diff --git a/setup.py b/setup.py
index <HASH>..<HASH> 100644
--- a/setup.py
+++ b/setup.py
@@ -27,8 +27,8 @@ install_requires = [
'slumber>=0.7,<0.8',
'selenium>=3.11,<4',
'transifex-client>=0.14,<0.15',
- 'cryptography>=3.2,<4',
- 'PyJWT>=1.7,<2',
+ 'cryptography~=3.4',
+ 'PyJWT~=2.1.0',
'kubernetes>=17,<19', # corresponds to server version 1.17 or 1.18
'prometheus_client>=0.6,<1',
'sentry-sdk~=1.3.0',
|
Update PyJWT and cryptography libraries
… this will lead to breaking changes: `jwt.encode/decode` method arguments and return types have changed
|
diff --git a/lib/larch/imap/mailbox.rb b/lib/larch/imap/mailbox.rb
index <HASH>..<HASH> 100644
--- a/lib/larch/imap/mailbox.rb
+++ b/lib/larch/imap/mailbox.rb
@@ -17,7 +17,7 @@ class Mailbox
@name = name
@delim = delim
@subscribed = subscribed
- @attr = *attr.flatten # flatten is necessary for Ruby 1.9
+ @attr = attr.flatten
@ids = {}
@last_id = 0
|
Ruby <I> didn't like that last <I> fix. Let's try that again.
|
diff --git a/examples/sevensegment_test.py b/examples/sevensegment_test.py
index <HASH>..<HASH> 100644
--- a/examples/sevensegment_test.py
+++ b/examples/sevensegment_test.py
@@ -44,6 +44,10 @@ def clock(device, deviceId, seconds):
device = led.sevensegment(cascaded=3)
+# Alphabet Text
+device.show_message("HELLO EVERYONE!")
+device.show_message("0123456789 abcdefghijklmnopqrstuvwxyz ABCDEFGHIJKLMNOPQRSTUVWXYZ")
+
# Digit futzing
date(device, 1)
clock(device, 0, seconds=10)
|
Update 7-segment example
|
diff --git a/staging/src/k8s.io/apiserver/pkg/server/filters/priority-and-fairness_test.go b/staging/src/k8s.io/apiserver/pkg/server/filters/priority-and-fairness_test.go
index <HASH>..<HASH> 100644
--- a/staging/src/k8s.io/apiserver/pkg/server/filters/priority-and-fairness_test.go
+++ b/staging/src/k8s.io/apiserver/pkg/server/filters/priority-and-fairness_test.go
@@ -476,9 +476,7 @@ func TestApfExecuteWatchRequestsWithInitializationSignal(t *testing.T) {
onExecuteFunc := func() {
firstRunning.Done()
- firstRunning.Wait()
- sendSignals()
fakeFilter.wait()
allRunning.Done()
@@ -502,9 +500,10 @@ func TestApfExecuteWatchRequestsWithInitializationSignal(t *testing.T) {
}
firstRunning.Wait()
+ sendSignals()
fakeFilter.wait()
-
firstRunning.Add(concurrentRequests)
+
for i := 0; i < concurrentRequests; i++ {
go func() {
defer wg.Done()
@@ -513,6 +512,8 @@ func TestApfExecuteWatchRequestsWithInitializationSignal(t *testing.T) {
}
}()
}
+ firstRunning.Wait()
+ sendSignals()
wg.Wait()
}
|
Remove race condition from TestApfExecuteWatchRequestsWithInitializationSignal
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.