diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/tests/support/mock.py b/tests/support/mock.py index <HASH>..<HASH> 100644 --- a/tests/support/mock.py +++ b/tests/support/mock.py @@ -95,8 +95,10 @@ if NO_MOCK is False: class MockFH(object): - def __init__(self, filename, read_data): + def __init__(self, filename, read_data, *args, **kwargs): ...
Track call args/kwargs in MockFH This allows for them to be verified in tests
diff --git a/src/TwentyOneRunFactory.php b/src/TwentyOneRunFactory.php index <HASH>..<HASH> 100644 --- a/src/TwentyOneRunFactory.php +++ b/src/TwentyOneRunFactory.php @@ -408,7 +408,7 @@ class TwentyOneRunFactory implements Factory ), SortOrderConfig::create( Attri...
Issue #<I>: Descend sorting by creation date
diff --git a/test/integration.js b/test/integration.js index <HASH>..<HASH> 100644 --- a/test/integration.js +++ b/test/integration.js @@ -35,20 +35,20 @@ test('should work with a single pid', async t => { test('should work with an array of pids', async t => { const child = spawn( 'node', - ['-e', 'console....
test: os x deterministic
diff --git a/revapi-java/src/main/java/org/revapi/java/compilation/ClassTreeInitializer.java b/revapi-java/src/main/java/org/revapi/java/compilation/ClassTreeInitializer.java index <HASH>..<HASH> 100644 --- a/revapi-java/src/main/java/org/revapi/java/compilation/ClassTreeInitializer.java +++ b/revapi-java/src/main/java...
Output class tree init times only on trace level.
diff --git a/lib/wns.js b/lib/wns.js index <HASH>..<HASH> 100644 --- a/lib/wns.js +++ b/lib/wns.js @@ -156,8 +156,10 @@ var obtainAccessToken = function (context) { // queue up the context until the accessToken is obtained var key = getClientKey(context); - if (pendingNotifications[key]) + if (pendingNotification...
Fix simultaneous send requests while obtaining token If you are sending a push notification for the first time, a token will be retrieved. During that time, if you attempt to send another message, it gets queued, but produces a fatal error. This is because a new request for a new token is made.
diff --git a/params/version.go b/params/version.go index <HASH>..<HASH> 100644 --- a/params/version.go +++ b/params/version.go @@ -21,10 +21,10 @@ import ( ) const ( - VersionMajor = 1 // Major version component of the current release - VersionMinor = 8 // Minor version component of the current re...
params, swarm: release Geth <I> and Swar <I>
diff --git a/tests/minifier.js b/tests/minifier.js index <HASH>..<HASH> 100644 --- a/tests/minifier.js +++ b/tests/minifier.js @@ -7,6 +7,10 @@ input, output; + test('`minifiy` exists', function() { + ok(minify); + }); + test('parsing non-trivial markup', function() { equal(minify('<p title...
test for minify() should come first
diff --git a/examples/nips17_adversarial_competition/run_attacks_and_defenses.py b/examples/nips17_adversarial_competition/run_attacks_and_defenses.py index <HASH>..<HASH> 100644 --- a/examples/nips17_adversarial_competition/run_attacks_and_defenses.py +++ b/examples/nips17_adversarial_competition/run_attacks_and_defen...
Fix bug in computation of attack score for Adversarial competition.
diff --git a/rulengine/__init__.py b/rulengine/__init__.py index <HASH>..<HASH> 100644 --- a/rulengine/__init__.py +++ b/rulengine/__init__.py @@ -1,7 +1,7 @@ from rulengine.core import RuleOperator from rulengine.conditions import execute_condition -VERSION = (0, 0, 5) +VERSION = (0, 0, 6) __version__ = '.'.join(...
version bumped to <I>
diff --git a/packages/plugin-phone/src/call.js b/packages/plugin-phone/src/call.js index <HASH>..<HASH> 100644 --- a/packages/plugin-phone/src/call.js +++ b/packages/plugin-phone/src/call.js @@ -832,11 +832,14 @@ const Call = SparkPlugin.extend({ offerToReceiveAudio: recvOnly || !!options.constraints.audio, ...
fix(plugin-phone): Fix options setting for _join
diff --git a/src/test/java/com/github/kongchen/smp/integration/utils/PetIdToStringModelConverter.java b/src/test/java/com/github/kongchen/smp/integration/utils/PetIdToStringModelConverter.java index <HASH>..<HASH> 100644 --- a/src/test/java/com/github/kongchen/smp/integration/utils/PetIdToStringModelConverter.java +++ ...
Added comments to PetIdToStringModelConverter
diff --git a/src/SessionTracker.php b/src/SessionTracker.php index <HASH>..<HASH> 100644 --- a/src/SessionTracker.php +++ b/src/SessionTracker.php @@ -2,6 +2,9 @@ namespace Bugsnag; +use Exception; +use InvalidArgumentException; + class SessionTracker { /**
Add missing imports in SessionTracker
diff --git a/src/PlaygroundDesign/Module.php b/src/PlaygroundDesign/Module.php index <HASH>..<HASH> 100644 --- a/src/PlaygroundDesign/Module.php +++ b/src/PlaygroundDesign/Module.php @@ -202,10 +202,10 @@ class Module implements $serviceManager = $e->getApplication()->getServiceManager(); $options =...
PLAYGROUND-<I>, fix translation user
diff --git a/aeron-driver/src/main/java/io/aeron/driver/IpcPublication.java b/aeron-driver/src/main/java/io/aeron/driver/IpcPublication.java index <HASH>..<HASH> 100644 --- a/aeron-driver/src/main/java/io/aeron/driver/IpcPublication.java +++ b/aeron-driver/src/main/java/io/aeron/driver/IpcPublication.java @@ -233,7 +23...
[Java] Keep checking for blocked IpcPublication even when inactive.
diff --git a/serviced/cmd.go b/serviced/cmd.go index <HASH>..<HASH> 100644 --- a/serviced/cmd.go +++ b/serviced/cmd.go @@ -127,7 +127,7 @@ func init() { flag.Var(&options.zookeepers, "zk", "Specify a zookeeper instance to connect to (e.g. -zk localhost:2181 )") flag.BoolVar(&options.repstats, "reportstats", true, "...
change metric sampling rate to 1 minute
diff --git a/src/AdapterInterface.php b/src/AdapterInterface.php index <HASH>..<HASH> 100644 --- a/src/AdapterInterface.php +++ b/src/AdapterInterface.php @@ -130,4 +130,16 @@ interface AdapterInterface * @return \React\Promise\PromiseInterface */ public function rename($fromPath, $toPath); + + /** ...
readlink and symlink methods added to adapter contract
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -100,5 +100,6 @@ setuptools.setup( "requests" ], url="https://github.com/CellProfiler/prokaryote", - version=version + version=version, + zip_safe = False )
Flailing - guess what, pip decided to install as zipped egg, lot of good that does!
diff --git a/plugins/org.eclipse.xtext.xbase/src/org/eclipse/xtext/xbase/validation/XbaseJavaValidator.java b/plugins/org.eclipse.xtext.xbase/src/org/eclipse/xtext/xbase/validation/XbaseJavaValidator.java index <HASH>..<HASH> 100644 --- a/plugins/org.eclipse.xtext.xbase/src/org/eclipse/xtext/xbase/validation/XbaseJavaV...
[xtend] Inferred return type for dispatch method is the same as the one for the dispatching method - inherited return types and explicitly defined return types have higher precedence, though - see <URL>
diff --git a/src/Robo/RoboTasks.php b/src/Robo/RoboTasks.php index <HASH>..<HASH> 100644 --- a/src/Robo/RoboTasks.php +++ b/src/Robo/RoboTasks.php @@ -203,6 +203,14 @@ class RoboTasks extends \Robo\Tasks implements LoggerAwareInterface /** @var RoboFile|CollectionBuilder $collection */ $collection = $...
[TASK] skip mysql database drop and create in case mysql bin is not set
diff --git a/src/QueryHelper.php b/src/QueryHelper.php index <HASH>..<HASH> 100644 --- a/src/QueryHelper.php +++ b/src/QueryHelper.php @@ -15,7 +15,7 @@ trait QueryHelper foreach ((array)$this as $i => $element) { $i = (string)$i; if (is_string($element)) { - return $el...
ehm, continue, not return
diff --git a/app/scripts/tests/setup.js b/app/scripts/tests/setup.js index <HASH>..<HASH> 100644 --- a/app/scripts/tests/setup.js +++ b/app/scripts/tests/setup.js @@ -1,5 +1,4 @@ var jsdom = require('jsdom').jsdom; - var exposedProperties = ['window', 'navigator', 'document']; global.document = jsdom(''); @@ -21,3...
Add Sinon-Chai setup when run tests with Mocha.
diff --git a/app/controllers/caboose/application_controller.rb b/app/controllers/caboose/application_controller.rb index <HASH>..<HASH> 100644 --- a/app/controllers/caboose/application_controller.rb +++ b/app/controllers/caboose/application_controller.rb @@ -3,6 +3,7 @@ module Caboose protect_from_forgery ...
Added all helpers to application controller
diff --git a/TYPO3.TYPO3CR/Classes/TYPO3/TYPO3CR/Domain/Model/NodeData.php b/TYPO3.TYPO3CR/Classes/TYPO3/TYPO3CR/Domain/Model/NodeData.php index <HASH>..<HASH> 100644 --- a/TYPO3.TYPO3CR/Classes/TYPO3/TYPO3CR/Domain/Model/NodeData.php +++ b/TYPO3.TYPO3CR/Classes/TYPO3/TYPO3CR/Domain/Model/NodeData.php @@ -44,11 +44,14 ...
TASK: Remove option from Index annotation It is not supported (like in later versions). Leave a comment instead,
diff --git a/lib/raven/transports/http.rb b/lib/raven/transports/http.rb index <HASH>..<HASH> 100644 --- a/lib/raven/transports/http.rb +++ b/lib/raven/transports/http.rb @@ -56,7 +56,7 @@ module Raven end def ssl_configuration - (configuration.ssl.dup || {}).merge!( + (configuration.ssl |...
Can't 'dup' a nil, besides I can just regular-merge.
diff --git a/telethon/tl/session.py b/telethon/tl/session.py index <HASH>..<HASH> 100644 --- a/telethon/tl/session.py +++ b/telethon/tl/session.py @@ -163,7 +163,8 @@ class Session: rows = [] for p_id, p_hash in data.get('entities', []): - rows.append((p_id, p_hash...
Assert hash is not None when migrating from JSON sessions
diff --git a/src/File.php b/src/File.php index <HASH>..<HASH> 100644 --- a/src/File.php +++ b/src/File.php @@ -30,13 +30,16 @@ class File extends Field $scale = m('scale'); $scale->resize($upload->fullPath(), $upload->name(), $upload->uploadDir); } + + // TODO: Work wi...
Fixed full path to support internal web-application paths
diff --git a/goscale/themes/context_processors.py b/goscale/themes/context_processors.py index <HASH>..<HASH> 100644 --- a/goscale/themes/context_processors.py +++ b/goscale/themes/context_processors.py @@ -9,7 +9,8 @@ def theme(request): # set config site_theme = settings.THEME static_theme_url = '%s...
goscale/themes/context_processors.py
diff --git a/spec/collins/api/asset_spec.rb b/spec/collins/api/asset_spec.rb index <HASH>..<HASH> 100644 --- a/spec/collins/api/asset_spec.rb +++ b/spec/collins/api/asset_spec.rb @@ -119,6 +119,18 @@ describe Collins::Api::Asset do end end + context "#count" do + include_context "collins api" + def met...
Add basic unit test for the assets count method
diff --git a/resource_aws_cloudfront_distribution.go b/resource_aws_cloudfront_distribution.go index <HASH>..<HASH> 100644 --- a/resource_aws_cloudfront_distribution.go +++ b/resource_aws_cloudfront_distribution.go @@ -6,6 +6,7 @@ import ( "time" "github.com/aws/aws-sdk-go/aws" + "github.com/aws/aws-sdk-go/aws/aw...
providers/aws: cloudfront distribution <I> should mark as gone (#<I>)
diff --git a/spec/cycle_spec.rb b/spec/cycle_spec.rb index <HASH>..<HASH> 100644 --- a/spec/cycle_spec.rb +++ b/spec/cycle_spec.rb @@ -5,6 +5,8 @@ require 'tmpdir' class Chicken < ActiveRecord::Base end +ActiveRecord::Base.logger = Logger.new(File.join(DumpRake::RailsRoot, 'log/dump.log')) + def database_configs ...
move setting logger to cycle_spec
diff --git a/profile/legacy_profile.go b/profile/legacy_profile.go index <HASH>..<HASH> 100644 --- a/profile/legacy_profile.go +++ b/profile/legacy_profile.go @@ -373,6 +373,15 @@ func cpuProfile(b []byte, period int64, parse func(b []byte) (uint64, []byte)) ( } } + if err := p.ParseMemoryMap(bytes.NewBuffer(b))...
Apply leaf cleanup to threadz samples The legacy profilez parser handles duplicate leaf samples that are a common artifact of satck unwinding. Apply the same technique to threadz profiles where duplicate samples also occur.
diff --git a/indra/tests/test_statements.py b/indra/tests/test_statements.py index <HASH>..<HASH> 100644 --- a/indra/tests/test_statements.py +++ b/indra/tests/test_statements.py @@ -1337,6 +1337,7 @@ def test_serialize(): st2 = stmts_from_json([jstr])[0] assert(st.equals(st2)) assert unicode_strs((ev1, ...
Check hash is persistend through to_json-from_json.
diff --git a/test/test.js b/test/test.js index <HASH>..<HASH> 100644 --- a/test/test.js +++ b/test/test.js @@ -96,15 +96,23 @@ describe('node-serialize', function () { '', 'http://www.w3.org/1999/xhtml' ); - - // Some older browsers require the DOCTYPE to be within a Document, - // otherwise th...
test: add HTML5 Doctype test, for <I>% test code coverage!
diff --git a/examples/conversations.php b/examples/conversations.php index <HASH>..<HASH> 100644 --- a/examples/conversations.php +++ b/examples/conversations.php @@ -32,7 +32,7 @@ $filters = (new ConversationFilters()) ->withSortField('createdAt') ->withSortOrder('asc') // See https://developer.helpscou...
Removing parenthesis from the example since it's not required
diff --git a/packages/ember-metal/lib/platform.js b/packages/ember-metal/lib/platform.js index <HASH>..<HASH> 100644 --- a/packages/ember-metal/lib/platform.js +++ b/packages/ember-metal/lib/platform.js @@ -38,7 +38,6 @@ if (!Ember.create) { Ember.create.isSimulated = true; } -Object.defineProperty = null; /** @...
Let ES5 browsers actually work
diff --git a/src/Sql/Relator/OneMany.php b/src/Sql/Relator/OneMany.php index <HASH>..<HASH> 100644 --- a/src/Sql/Relator/OneMany.php +++ b/src/Sql/Relator/OneMany.php @@ -39,6 +39,8 @@ class OneMany extends Base ); if ($relation[0] == 'one' && $result) { $result = current($result); + ...
result should not return empty array from OneMany getRelated
diff --git a/filter/tex/latex.php b/filter/tex/latex.php index <HASH>..<HASH> 100644 --- a/filter/tex/latex.php +++ b/filter/tex/latex.php @@ -44,14 +44,19 @@ } else { $this->supported_platform = false; - return false; } $this->path_lat...
Added check so render returns with false if unsupported platform.
diff --git a/base/src/org/droidparts/manager/AbstractPrefsManager.java b/base/src/org/droidparts/manager/AbstractPrefsManager.java index <HASH>..<HASH> 100644 --- a/base/src/org/droidparts/manager/AbstractPrefsManager.java +++ b/base/src/org/droidparts/manager/AbstractPrefsManager.java @@ -67,8 +67,14 @@ public abstrac...
PrefsManager helper methods.
diff --git a/productmd/composeinfo.py b/productmd/composeinfo.py index <HASH>..<HASH> 100644 --- a/productmd/composeinfo.py +++ b/productmd/composeinfo.py @@ -580,12 +580,8 @@ class VariantBase(productmd.common.MetadataBase): if variant.parent is None and '-' in variant_id and variant.type != "optional": ...
Fix VariantBase._validate_variants() Refer to the implementation of Variants.add(), variant_id could be any value. This patch could cover the case we met currently, but the validation will fail if people pass other variant_id value to Variants.add() JIRA: RHELCMP-<I>
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -3,6 +3,7 @@ """The setup script.""" import sys + from setuptools import setup, find_packages with open('README.rst') as readme_file:
space btw stdlib and related third-party libs re: pep8 guidance.
diff --git a/fabfile.py b/fabfile.py index <HASH>..<HASH> 100644 --- a/fabfile.py +++ b/fabfile.py @@ -36,8 +36,8 @@ def send(): def start(): with cd(env.tsuru_path): run("tar -xzf dist.tar.gz") - run("nohup %s/dist/collector >& /dev/null < /dev/null &" % env.tsuru_path, pty=False) - run("nohup %s/...
fabfile: redirecting output from collector and webserver to files
diff --git a/lib/Core/Values/BlockCreateStruct.php b/lib/Core/Values/BlockCreateStruct.php index <HASH>..<HASH> 100644 --- a/lib/Core/Values/BlockCreateStruct.php +++ b/lib/Core/Values/BlockCreateStruct.php @@ -29,10 +29,6 @@ class BlockCreateStruct extends APIBlockCreateStruct */ public function setParamete...
Remove uneeded check from block structs
diff --git a/lib/log.js b/lib/log.js index <HASH>..<HASH> 100644 --- a/lib/log.js +++ b/lib/log.js @@ -13,7 +13,7 @@ log.addLevel('debug', 999, {fg: 'grey'}, 'debu'); // monkey patch npmlog… log.heading = ''; log.headingStyle.fg = 'blue'; -log.disp.verbose = 'verbose'; +log.disp.verbose = 'verb'; log.disp.error = '...
normalize verbose level output to 4 char
diff --git a/src/javascripts/ng-admin/Main/component/service/config/Field.js b/src/javascripts/ng-admin/Main/component/service/config/Field.js index <HASH>..<HASH> 100644 --- a/src/javascripts/ng-admin/Main/component/service/config/Field.js +++ b/src/javascripts/ng-admin/Main/component/service/config/Field.js @@ -45,22...
Remove needless method (added by Configurable)
diff --git a/nanomath/version.py b/nanomath/version.py index <HASH>..<HASH> 100644 --- a/nanomath/version.py +++ b/nanomath/version.py @@ -1 +1 @@ -__version__ = "0.22.0" +__version__ = "0.23.0"
bumping version after pull request speeding up ave_qual
diff --git a/pyemma/msm/models/msm.py b/pyemma/msm/models/msm.py index <HASH>..<HASH> 100644 --- a/pyemma/msm/models/msm.py +++ b/pyemma/msm/models/msm.py @@ -139,11 +139,9 @@ class MSM(_Model): """ # we set reversible first, so it can be derived from P, if None was given. self.update_model_p...
[msm] use multiple calls to update_model_params to preserve order. This restores the old behaviour: if a param is set to None it can be overriden, but not set twice. Setting a parameter twice causes problems with other Estimators like ChapmanKolmogorov, which invokes set_model_params again with None.
diff --git a/test/e2e_node/runner/run_e2e.go b/test/e2e_node/runner/run_e2e.go index <HASH>..<HASH> 100644 --- a/test/e2e_node/runner/run_e2e.go +++ b/test/e2e_node/runner/run_e2e.go @@ -104,7 +104,7 @@ func main() { noColour = "\033[0m" } - go arc.getArchive() + arc.getArchive() defer arc.deleteArchive() ...
Wait for arc.getArchive() to complete before running tests
diff --git a/server/client.go b/server/client.go index <HASH>..<HASH> 100644 --- a/server/client.go +++ b/server/client.go @@ -310,23 +310,28 @@ func (c *client) processConnect(arg []byte) error { c.mu.Lock() c.clearAuthTimer() c.last = time.Now() + typ := c.typ + r := c.route + srv := c.srv c.mu.Unlock() i...
Fix data race When processing a connect request, there was a risk of race condition when the server was being shutdown. Capture fields that are checked under lock and lock when setting the route's remote ID. Resolves #<I>
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index <HASH>..<HASH> 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -5,7 +5,7 @@ require "rdkafka" def rdkafka_config config = { :"bootstrap.servers" => "localhost:9092", - :"group.id" => "ruby-test-#{Random.new.rand(0..10_000)}", + :"...
Take partition into account in wait_for_message spec helper
diff --git a/lib/Cake/Cache/Engine/FileEngine.php b/lib/Cake/Cache/Engine/FileEngine.php index <HASH>..<HASH> 100644 --- a/lib/Cake/Cache/Engine/FileEngine.php +++ b/lib/Cake/Cache/Engine/FileEngine.php @@ -388,7 +388,7 @@ class FileEngine extends CacheEngine { return false; } - $key = Inflector::underscore(s...
convert forbidden character in filename(Windows) with underline
diff --git a/klue/swagger/client.py b/klue/swagger/client.py index <HASH>..<HASH> 100644 --- a/klue/swagger/client.py +++ b/klue/swagger/client.py @@ -218,7 +218,8 @@ class ClientCaller(): raise e # max_attempts has been reached: propagate the last received Exception - log.info("R...
Fix bug of undefined exception when retrying 3 times with no error
diff --git a/decoda.php b/decoda.php index <HASH>..<HASH> 100644 --- a/decoda.php +++ b/decoda.php @@ -351,25 +351,25 @@ class Decoda { } } } + } + + // Make urls/emails clickable + if ($this->__config['clickable']) { + $string = $this->__clickable($string); + ...
Trigger utility functions even if parse is false.
diff --git a/src/Charcoal/Core/IndexableTrait.php b/src/Charcoal/Core/IndexableTrait.php index <HASH>..<HASH> 100644 --- a/src/Charcoal/Core/IndexableTrait.php +++ b/src/Charcoal/Core/IndexableTrait.php @@ -10,11 +10,21 @@ trait IndexableTrait /** * @var mixed $_id The object (unique) identifier */ - ...
set_indexable_data, to be called from classes (set_data) that uses the Indexable trait
diff --git a/ph-oton-uicore/src/main/java/com/helger/photon/uicore/icon/DefaultIcons.java b/ph-oton-uicore/src/main/java/com/helger/photon/uicore/icon/DefaultIcons.java index <HASH>..<HASH> 100644 --- a/ph-oton-uicore/src/main/java/com/helger/photon/uicore/icon/DefaultIcons.java +++ b/ph-oton-uicore/src/main/java/com/h...
Added JavaDocs :)
diff --git a/campaigns.go b/campaigns.go index <HASH>..<HASH> 100644 --- a/campaigns.go +++ b/campaigns.go @@ -1,15 +1,15 @@ package mailgun type Campaign struct { - Id string - Name string - CreatedAt string - DeliveredCount int - ClickedCount int - OpenedCount int...
Added JSON-names and did gofmt.
diff --git a/src/Entity/Base.php b/src/Entity/Base.php index <HASH>..<HASH> 100644 --- a/src/Entity/Base.php +++ b/src/Entity/Base.php @@ -10,6 +10,7 @@ abstract class Base */ protected $apiRequest = null; protected $playerInformation = null; + protected $parameters = null; public function s...
get ressource method for player + method for get parametters
diff --git a/splunklib/searchcommands/internals.py b/splunklib/searchcommands/internals.py index <HASH>..<HASH> 100644 --- a/splunklib/searchcommands/internals.py +++ b/splunklib/searchcommands/internals.py @@ -580,7 +580,7 @@ class RecordWriter(object): value = str(value.real) ...
Pull request for DVPL-<I> to treat the integer and long variables same in both python versions
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -10,6 +10,9 @@ setup( license='MIT', packages=find_packages(), install_requires=['nose>=1.3', 'six'], + dependency_links=[ + 'https://github.com/nose-devs/nose/tarball/c0f777e488337dc7dde933453799986c4...
Hit github for Nose for now, boo
diff --git a/src/File/Path/Basepath/DefaultTrait.php b/src/File/Path/Basepath/DefaultTrait.php index <HASH>..<HASH> 100644 --- a/src/File/Path/Basepath/DefaultTrait.php +++ b/src/File/Path/Basepath/DefaultTrait.php @@ -30,6 +30,7 @@ trait DefaultTrait $replacements = [ '{primaryKey}' => $this->ent...
Add {table} placeholder for path.
diff --git a/src/API/AbstractAPIClient.php b/src/API/AbstractAPIClient.php index <HASH>..<HASH> 100644 --- a/src/API/AbstractAPIClient.php +++ b/src/API/AbstractAPIClient.php @@ -58,9 +58,9 @@ abstract class AbstractAPIClient implements APIInterface $method = $request->getMethod(); // Since ...
PI-<I> fixed method for Guzzle setBody
diff --git a/ui/plugins/annotations/controller.js b/ui/plugins/annotations/controller.js index <HASH>..<HASH> 100644 --- a/ui/plugins/annotations/controller.js +++ b/ui/plugins/annotations/controller.js @@ -21,8 +21,7 @@ treeherder.controller('AnnotationsPluginCtrl', [ }, true); $scope.deleteClassif...
Bug <I> - Don't re-create bugjobmap and classification objects in the annotations plugin controller
diff --git a/src/Strategies/Settings.php b/src/Strategies/Settings.php index <HASH>..<HASH> 100644 --- a/src/Strategies/Settings.php +++ b/src/Strategies/Settings.php @@ -45,13 +45,13 @@ class Settings implements SettingsStrategyInterface const KEY_SERVER_ORIGIN = 0; /** Settings key */ - const KEY_SERVE...
Close #<I> make keys compatible with keys from parse_url
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -57,7 +57,7 @@ class Client { // Shared functions - listBuckets(data) { + listBuckets() { return this.aws.request('S3', 'listBuckets', {}, this.stage, this.region).bind(this); } @@ -107,18 +107,19 @@ class C...
Adds a delay just incase
diff --git a/src/Extensions/GroupSubsites.php b/src/Extensions/GroupSubsites.php index <HASH>..<HASH> 100644 --- a/src/Extensions/GroupSubsites.php +++ b/src/Extensions/GroupSubsites.php @@ -47,7 +47,7 @@ class GroupSubsites extends DataExtension implements PermissionProvider } // Migration for Group....
[SS-<I>-<I>] Group table name is escaped to prevent possibility of SQL injection
diff --git a/javascript/node/selenium-webdriver/lib/webdriver.js b/javascript/node/selenium-webdriver/lib/webdriver.js index <HASH>..<HASH> 100644 --- a/javascript/node/selenium-webdriver/lib/webdriver.js +++ b/javascript/node/selenium-webdriver/lib/webdriver.js @@ -1229,6 +1229,19 @@ class WebDriver { if (target ...
[js] Add a check for Grid CDP endpoint
diff --git a/realtime/shake_data.py b/realtime/shake_data.py index <HASH>..<HASH> 100644 --- a/realtime/shake_data.py +++ b/realtime/shake_data.py @@ -336,18 +336,19 @@ class ShakeData: :file:`/tmp/inasafe/realtime/shakemaps-extracted/20131105060809` - After extraction the complete path will appear ...
Fix last pylint violation.
diff --git a/instant/templates/instant/channels/superuser/client.js b/instant/templates/instant/channels/superuser/client.js index <HASH>..<HASH> 100644 --- a/instant/templates/instant/channels/superuser/client.js +++ b/instant/templates/instant/channels/superuser/client.js @@ -10,6 +10,7 @@ var superuser_callbacks_{% ...
Correction in js superuser channel client
diff --git a/lib/ee.js b/lib/ee.js index <HASH>..<HASH> 100644 --- a/lib/ee.js +++ b/lib/ee.js @@ -20,10 +20,8 @@ module.exports = { var args = slice.call(arguments, 1), array = this._events[ev]; - array && array.forEach(invokeHandler, this); - - function invokeHandler(handler) { -...
Use `for` instead of `forEach` as it minifies better.
diff --git a/client.go b/client.go index <HASH>..<HASH> 100644 --- a/client.go +++ b/client.go @@ -235,6 +235,12 @@ func (c *Client) User() string { return c.namenode.User } +// Name returns the unique name that the Client uses in communication +// with namenodes and datanodes. +func (c *Client) Name() string { + ...
Allow to get an unique name of the client
diff --git a/modules/adgenerationBidAdapter.js b/modules/adgenerationBidAdapter.js index <HASH>..<HASH> 100644 --- a/modules/adgenerationBidAdapter.js +++ b/modules/adgenerationBidAdapter.js @@ -75,11 +75,6 @@ export const spec = { return []; } const bidRequest = bidRequests.bidRequest; - if (!bidRe...
update AdGenetation adapter (<I> squashed commit) (#<I>) Squashed commits: [1b<I>ca0] update AdGenetation adapter
diff --git a/tests/unit/AbstractClientTest.php b/tests/unit/AbstractClientTest.php index <HASH>..<HASH> 100644 --- a/tests/unit/AbstractClientTest.php +++ b/tests/unit/AbstractClientTest.php @@ -162,7 +162,7 @@ class ClientTest extends Unit $client->send($request2); $transport = $this->createMock(Tr...
modify the test to be ok with the new commit definition.
diff --git a/api/app.go b/api/app.go index <HASH>..<HASH> 100644 --- a/api/app.go +++ b/api/app.go @@ -1638,6 +1638,15 @@ func forceDeleteLock(w http.ResponseWriter, r *http.Request, t auth.Token) error return nil } +// title: register unit +// path: /apps/{app}/units/register +// method: POST +// consume: applica...
api/apps: add comments to describe register unit
diff --git a/djstripe/models.py b/djstripe/models.py index <HASH>..<HASH> 100644 --- a/djstripe/models.py +++ b/djstripe/models.py @@ -283,15 +283,13 @@ Use ``Customer.sources`` and ``Customer.subscriptions`` to access them. In this case, use ``Customer.subscriptions`` instead. """ - ...
Exclude canceled subscriptions from Customer.subscriptions
diff --git a/jquery.multiple.select.js b/jquery.multiple.select.js index <HASH>..<HASH> 100644 --- a/jquery.multiple.select.js +++ b/jquery.multiple.select.js @@ -48,10 +48,6 @@ this.selectAllName = 'name="selectAll' + name + '"'; this.selectGroupName = 'name="selectGroup' + name + '"'; this....
Fix #<I>: call open function after init when isOpen and filter options are set to true.
diff --git a/test/connection_test.py b/test/connection_test.py index <HASH>..<HASH> 100755 --- a/test/connection_test.py +++ b/test/connection_test.py @@ -61,7 +61,7 @@ class BaseTest(unittest.TestCase): json.dump(klass.dbconfig, f) @classmethod - def setUpClass(klass): + def _setUpClass(klass): os.m...
Make connection_test.py work in both <I> and <I>.
diff --git a/association.go b/association.go index <HASH>..<HASH> 100644 --- a/association.go +++ b/association.go @@ -267,15 +267,16 @@ func (association *Association) Count() int { query = scope.DB() ) - if relationship.Kind == "many_to_many" { + switch relationship.Kind { + case "many_to_many": quer...
rewrite if-else chain as switch statement (#<I>) From effective Go: <URL>
diff --git a/packages/blueprint/lib/application.js b/packages/blueprint/lib/application.js index <HASH>..<HASH> 100644 --- a/packages/blueprint/lib/application.js +++ b/packages/blueprint/lib/application.js @@ -145,13 +145,15 @@ module.exports = BO.extend (Events, { * Destroy the application. */ destroy () {...
The application failed to stop at the end of testing
diff --git a/lib/active_record/connection_adapters/oracle_enhanced_schema_statements.rb b/lib/active_record/connection_adapters/oracle_enhanced_schema_statements.rb index <HASH>..<HASH> 100644 --- a/lib/active_record/connection_adapters/oracle_enhanced_schema_statements.rb +++ b/lib/active_record/connection_adapters/or...
Use the index name explicitly provided in a migration when reverting see rails/rails#<I>
diff --git a/modules/admin/resources/js/controllers.js b/modules/admin/resources/js/controllers.js index <HASH>..<HASH> 100644 --- a/modules/admin/resources/js/controllers.js +++ b/modules/admin/resources/js/controllers.js @@ -389,11 +389,15 @@ }); }; + $scope.$on('topMenuClick', function(e) { + $scope.cu...
fixed bug where activ class on dashboard still appears closing #<I>
diff --git a/yarl/__init__.py b/yarl/__init__.py index <HASH>..<HASH> 100644 --- a/yarl/__init__.py +++ b/yarl/__init__.py @@ -10,7 +10,7 @@ import idna from .quoting import _Quoter, _Unquoter -__version__ = '1.2.5a2' +__version__ = '1.2.5a3' __all__ = ('URL',)
Bump to <I>a3
diff --git a/wafer/settings.py b/wafer/settings.py index <HASH>..<HASH> 100644 --- a/wafer/settings.py +++ b/wafer/settings.py @@ -147,9 +147,9 @@ INSTALLED_APPS = ( 'wafer.sponsors', 'wafer.pages', 'wafer.tickets', + 'wafer.compare', # Django isn't finding the overridden templates 'registra...
Keep all the wafer apps together in the settings file
diff --git a/src/cli.js b/src/cli.js index <HASH>..<HASH> 100644 --- a/src/cli.js +++ b/src/cli.js @@ -37,17 +37,13 @@ commander /^(trace|debug|info|warn|error|silent)$/i, 'warn') .action((host, file, options) => { - const { port, username, password, loglevel, command } = options; - if (!host) { ...
Fix setting correct cli log level Setting of log level has been moved into `connect`, so whatever we do outside of it will be reverted by connect. Which is why we also have to pass along all options to `connect`.
diff --git a/cloudinit/cloudinit_test.go b/cloudinit/cloudinit_test.go index <HASH>..<HASH> 100644 --- a/cloudinit/cloudinit_test.go +++ b/cloudinit/cloudinit_test.go @@ -220,9 +220,7 @@ var ctests = []struct { }, { "AddFile", - "runcmd:\n" + - "- install -m 644 /dev/null '/etc/apt/apt.conf.d/99proxy'\n" + - ...
- Switch expected to a literla string.
diff --git a/DependencyInjection/Compiler/EnvironmentVariablesPass.php b/DependencyInjection/Compiler/EnvironmentVariablesPass.php index <HASH>..<HASH> 100644 --- a/DependencyInjection/Compiler/EnvironmentVariablesPass.php +++ b/DependencyInjection/Compiler/EnvironmentVariablesPass.php @@ -13,6 +13,7 @@ namespace ONGR\...
Use server value from request instead of super global variable
diff --git a/lib/excon/socket.rb b/lib/excon/socket.rb index <HASH>..<HASH> 100644 --- a/lib/excon/socket.rb +++ b/lib/excon/socket.rb @@ -36,10 +36,20 @@ module Excon end end - def read(max_length) + def read(max_length=nil) begin - until @read_buffer.length >= max_length - @...
fix nonblock stuff to work properly in read until socket closes case
diff --git a/lib/pubcontrolclient.js b/lib/pubcontrolclient.js index <HASH>..<HASH> 100644 --- a/lib/pubcontrolclient.js +++ b/lib/pubcontrolclient.js @@ -9,7 +9,7 @@ * Licensed under the MIT License, see file COPYING for details. */ -var fetch = (global.fetch !== undefined) ? global.fetch : require('node-fetch')...
node-fetch workaround for webpack
diff --git a/src/toil/test/docs/scriptsTest.py b/src/toil/test/docs/scriptsTest.py index <HASH>..<HASH> 100644 --- a/src/toil/test/docs/scriptsTest.py +++ b/src/toil/test/docs/scriptsTest.py @@ -127,9 +127,9 @@ class ToilDocumentationTest(ToilTest): def testArguments(self): self.checkExpectedOut("tutorial...
Comment out docker test and investigate on jenkins later.
diff --git a/lib/turbine/vertex.rb b/lib/turbine/vertex.rb index <HASH>..<HASH> 100644 --- a/lib/turbine/vertex.rb +++ b/lib/turbine/vertex.rb @@ -3,6 +3,9 @@ module Turbine # formed: a directed graph consists of a set of vertices and a set of arcs # (ordered pairs of vertices). class Vertex + # Public: Ret...
Vertex.new must be provided a key.
diff --git a/model/execution/implementation/KvLtiDeliveryExecutionService.php b/model/execution/implementation/KvLtiDeliveryExecutionService.php index <HASH>..<HASH> 100644 --- a/model/execution/implementation/KvLtiDeliveryExecutionService.php +++ b/model/execution/implementation/KvLtiDeliveryExecutionService.php @@ -1...
check if links of execution are not empty
diff --git a/gettext.go b/gettext.go index <HASH>..<HASH> 100644 --- a/gettext.go +++ b/gettext.go @@ -42,9 +42,9 @@ var ( // LcAll is for all of the locale. LcAll = uint(C.LC_ALL) - // LcColate is for regular expression matching (it determines the meaning of + // LcCollate is for regular expression matching (it ...
Adding old LC_* style constants for backward compatibility.
diff --git a/bucky/cfg.py b/bucky/cfg.py index <HASH>..<HASH> 100644 --- a/bucky/cfg.py +++ b/bucky/cfg.py @@ -30,7 +30,9 @@ graphite_pickle_buffer_size = 500 full_trace = False name_prefix = None +name_prefix_parts = None name_postfix = None +name_postfix_parts = None name_replace_char = '_' name_strip_duplicat...
Allow prefix and postfix to have multiple parts.
diff --git a/cache2k-config/src/test/java/org/cache2k/extra/config/test/IntegrationTest.java b/cache2k-config/src/test/java/org/cache2k/extra/config/test/IntegrationTest.java index <HASH>..<HASH> 100644 --- a/cache2k-config/src/test/java/org/cache2k/extra/config/test/IntegrationTest.java +++ b/cache2k-config/src/test/j...
ignore test again, need to fix module configuration first
diff --git a/lib/happymapper.rb b/lib/happymapper.rb index <HASH>..<HASH> 100644 --- a/lib/happymapper.rb +++ b/lib/happymapper.rb @@ -1,5 +1,3 @@ -require 'rubygems' -gem 'libxml-ruby', '=1.1.3' require 'date' require 'time' require 'xml' diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index <HASH>..<HASH> 1...
Removing rubygems.
diff --git a/test/e2e/cluster_dns.go b/test/e2e/cluster_dns.go index <HASH>..<HASH> 100644 --- a/test/e2e/cluster_dns.go +++ b/test/e2e/cluster_dns.go @@ -37,6 +37,11 @@ func TestClusterDNS(c *client.Client) bool { return true } + if testContext.provider == "vagrant" { + glog.Infof("Skipping test which is broke...
Disable a couple of e2e tests for vagrant for now. The core issue is that vagrant lacks connectivity from master to containers.
diff --git a/samoa-api/src/main/java/com/yahoo/labs/samoa/learners/classifiers/ensemble/Bagging.java b/samoa-api/src/main/java/com/yahoo/labs/samoa/learners/classifiers/ensemble/Bagging.java index <HASH>..<HASH> 100644 --- a/samoa-api/src/main/java/com/yahoo/labs/samoa/learners/classifiers/ensemble/Bagging.java +++ b/s...
Updated Bagging deafault base classifier option
diff --git a/src/ContainerBuilder.php b/src/ContainerBuilder.php index <HASH>..<HASH> 100644 --- a/src/ContainerBuilder.php +++ b/src/ContainerBuilder.php @@ -492,7 +492,9 @@ class ContainerBuilder { // process services foreach ($config["services"] as $key => $definition) { // check if th...
Only alias a key if it is not already aliased
diff --git a/backbone.js b/backbone.js index <HASH>..<HASH> 100644 --- a/backbone.js +++ b/backbone.js @@ -619,7 +619,7 @@ if (ev == 'destroy') { this._remove(model, options); } - if (ev === 'change:' + model.idAttribute) { + if (model && ev === 'change:' + model.idAttribute) { ...
Check for model before accessing its properties, fixes #<I>
diff --git a/trump/orm.py b/trump/orm.py index <HASH>..<HASH> 100644 --- a/trump/orm.py +++ b/trump/orm.py @@ -538,20 +538,25 @@ class Symbol(Base, ReprMixin): def __init__(self, name, description=None, units=None, agg_method="PRIORITY_FILL", indexname="UNNAMED", indeximp="Dat...
Change Symbol docstring to numpy style
diff --git a/lib/inject.js b/lib/inject.js index <HASH>..<HASH> 100644 --- a/lib/inject.js +++ b/lib/inject.js @@ -54,14 +54,11 @@ function injectAllRequirements() { if (!get(f, 'module')) { set(f, ['module'], '.'); } - if (!doneModules.includes(f.module)) { - injectRequirem...
Include requirements into every package, even when it's in the root
diff --git a/src/renderable/sprite.js b/src/renderable/sprite.js index <HASH>..<HASH> 100644 --- a/src/renderable/sprite.js +++ b/src/renderable/sprite.js @@ -21,7 +21,7 @@ * @param {Number} [settings.rotation] Initial rotation angle in radians. * @param {Boolean} [settings.flipX] Initial flip for X-axis. ...
[documentation] better highlight the default value for the anchor point in the `me.Sprite` constructor