diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/cli/cumulusci.py b/cli/cumulusci.py index <HASH>..<HASH> 100644 --- a/cli/cumulusci.py +++ b/cli/cumulusci.py @@ -316,6 +316,7 @@ def beta_deploy(config, tag, commit, run_tests, retries): raise e if error.find('Error: Invalid Package, Details: This package is not yet available') == ...
Add better output to show what is happening with beta_deploy retries
diff --git a/astrobase/varclass/recoverysim.py b/astrobase/varclass/recoverysim.py index <HASH>..<HASH> 100644 --- a/astrobase/varclass/recoverysim.py +++ b/astrobase/varclass/recoverysim.py @@ -884,7 +884,7 @@ def make_fakelc_collection(lclist, with open(dboutfname, 'wb') as outfd: pickle.dump(fakedb, ou...
[WIP] working on recoverysim
diff --git a/packages/core/src/Core/Model/Response/CdrResponse.php b/packages/core/src/Core/Model/Response/CdrResponse.php index <HASH>..<HASH> 100644 --- a/packages/core/src/Core/Model/Response/CdrResponse.php +++ b/packages/core/src/Core/Model/Response/CdrResponse.php @@ -34,6 +34,16 @@ class CdrResponse protect...
add is accepted, close giansalex/greenter#<I>
diff --git a/pkg/services/sqlstore/migrator/mysql_dialect.go b/pkg/services/sqlstore/migrator/mysql_dialect.go index <HASH>..<HASH> 100644 --- a/pkg/services/sqlstore/migrator/mysql_dialect.go +++ b/pkg/services/sqlstore/migrator/mysql_dialect.go @@ -30,7 +30,10 @@ func (db *Mysql) AutoIncrStr() string { } func (db...
Fixed alerting bug for mysql (#<I>)
diff --git a/api-spec-testing/rspec_matchers.rb b/api-spec-testing/rspec_matchers.rb index <HASH>..<HASH> 100644 --- a/api-spec-testing/rspec_matchers.rb +++ b/api-spec-testing/rspec_matchers.rb @@ -227,8 +227,12 @@ RSpec::Matchers.define :match_response do |pairs, test| def compare_string(expected, actual_value, te...
Test Runner: Modify rspec_matcher to parse more than one regex in expected values
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -1,12 +1,6 @@ var parsers = require('./parsers') var url = require('url') -const CONTENT_TYPE_PARSERS = { - 'application/json': parsers.json, - 'text/plain': parsers.text, - 'application/octet-stream': parsers.raw -} - ...
use regex for content-types
diff --git a/resource_aws_efs_file_system_test.go b/resource_aws_efs_file_system_test.go index <HASH>..<HASH> 100644 --- a/resource_aws_efs_file_system_test.go +++ b/resource_aws_efs_file_system_test.go @@ -317,7 +317,6 @@ resource "aws_efs_file_system" "foo" { func testAccAWSEFSFileSystemConfigPagedTags(rInt int) str...
remove some manual names to allow the automatic random names, avoid some possible conflicts
diff --git a/src/transformers/models/wav2vec2/modeling_wav2vec2.py b/src/transformers/models/wav2vec2/modeling_wav2vec2.py index <HASH>..<HASH> 100755 --- a/src/transformers/models/wav2vec2/modeling_wav2vec2.py +++ b/src/transformers/models/wav2vec2/modeling_wav2vec2.py @@ -1606,6 +1606,7 @@ class Wav2Vec2ForMaskedLM(W...
fix missing import (#<I>)
diff --git a/lib/glimpse/views/active_record.rb b/lib/glimpse/views/active_record.rb index <HASH>..<HASH> 100644 --- a/lib/glimpse/views/active_record.rb +++ b/lib/glimpse/views/active_record.rb @@ -21,7 +21,7 @@ module Glimpse end def formatted_duration - "%.2f" % (duration * 1000) + "%.2...
Add ms after duration for ActiveRecord
diff --git a/src/console/ConsoleLogTarget.php b/src/console/ConsoleLogTarget.php index <HASH>..<HASH> 100644 --- a/src/console/ConsoleLogTarget.php +++ b/src/console/ConsoleLogTarget.php @@ -6,6 +6,7 @@ use hidev\components\Log; use Psr\Log\LogLevel; use yii\helpers\Console; use yii\helpers\VarDumper; +use yii\log\L...
Convert log levels from Yii to PSR
diff --git a/builder/vmware/common/driver_fusion6.go b/builder/vmware/common/driver_fusion6.go index <HASH>..<HASH> 100644 --- a/builder/vmware/common/driver_fusion6.go +++ b/builder/vmware/common/driver_fusion6.go @@ -22,6 +22,12 @@ func (d *Fusion6Driver) Clone(dst, src string) error { "clone", src, dst, "full"...
builder/vmware: better error if clone not supported [GH-<I>]
diff --git a/lib/chef/resource/homebrew_tap.rb b/lib/chef/resource/homebrew_tap.rb index <HASH>..<HASH> 100644 --- a/lib/chef/resource/homebrew_tap.rb +++ b/lib/chef/resource/homebrew_tap.rb @@ -48,7 +48,7 @@ class Chef description: "The path to the Homebrew binary.", default: "/usr/loca...
Revert homebrew_tap to using String for owner It's using owner in an env variable and I'm not sure if that will actually work. We should stick with a string here.
diff --git a/git/githistory/log/log.go b/git/githistory/log/log.go index <HASH>..<HASH> 100644 --- a/git/githistory/log/log.go +++ b/git/githistory/log/log.go @@ -185,11 +185,7 @@ func (l *Logger) consume() { func (l *Logger) logTask(task Task) { defer l.wg.Done() - var logAll bool - if durable, ok := task.(Durabl...
git/githistory/log: collapse DurableTask interface into Task
diff --git a/salt/modules/wordpress.py b/salt/modules/wordpress.py index <HASH>..<HASH> 100644 --- a/salt/modules/wordpress.py +++ b/salt/modules/wordpress.py @@ -10,8 +10,8 @@ from __future__ import absolute_import import collections # Import Salt Modules -from salt.ext.six.moves import map import salt.utils.path...
Update reference to old salt.utils.which function
diff --git a/rocketchat_API/rocketchat.py b/rocketchat_API/rocketchat.py index <HASH>..<HASH> 100644 --- a/rocketchat_API/rocketchat.py +++ b/rocketchat_API/rocketchat.py @@ -609,6 +609,10 @@ class RocketChat: """Removes the direct message from the user’s list of direct messages.""" return self.__call...
Added method to retrieve DMs by username.
diff --git a/src/goals/ReadmeGoal.php b/src/goals/ReadmeGoal.php index <HASH>..<HASH> 100644 --- a/src/goals/ReadmeGoal.php +++ b/src/goals/ReadmeGoal.php @@ -42,6 +42,10 @@ class ReadmeGoal extends TemplateGoal public function renderBadges() { + $c = $this->config->get('composer.json'); + if ...
fixed versioneye badge: don't show when no dependencies
diff --git a/src/widgets/editor/editor.js b/src/widgets/editor/editor.js index <HASH>..<HASH> 100644 --- a/src/widgets/editor/editor.js +++ b/src/widgets/editor/editor.js @@ -5,7 +5,7 @@ * Copyright (c) 2015-2017 Fabio Spampinato * Licensed under MIT (https://github.com/svelto/svelto/blob/master/LICENSE) * ======...
Editor: avoid errors if the parser has not been loaded
diff --git a/project_generator/yaml_parser.py b/project_generator/yaml_parser.py index <HASH>..<HASH> 100644 --- a/project_generator/yaml_parser.py +++ b/project_generator/yaml_parser.py @@ -13,6 +13,8 @@ # limitations under the License. import os +from os import listdir +from os.path import isfile, join class Y...
source_files can be folders, or separate files
diff --git a/static/manager/js/src/article.js b/static/manager/js/src/article.js index <HASH>..<HASH> 100644 --- a/static/manager/js/src/article.js +++ b/static/manager/js/src/article.js @@ -10,11 +10,13 @@ var imageManager = React.render( var articleId = $('#article-admin').data('id'); var articleId = articleId ? ...
pass section id and slug into ArticleAdmin component
diff --git a/src/Symfony/Console/Command/Command.php b/src/Symfony/Console/Command/Command.php index <HASH>..<HASH> 100644 --- a/src/Symfony/Console/Command/Command.php +++ b/src/Symfony/Console/Command/Command.php @@ -21,9 +21,9 @@ abstract class Command extends Base final protected static function tempnamCheck...
snagging scrutinizer issues is getting annoying now ¬_¬
diff --git a/client/sizes.go b/client/sizes.go index <HASH>..<HASH> 100644 --- a/client/sizes.go +++ b/client/sizes.go @@ -36,11 +36,11 @@ func main() { prot = t } - var wg sync.WaitGroup + wg := &sync.WaitGroup{} wg.Add(f.NumWorkers) for i := 0; i < f.NumWorkers; i++ { - go func(prot common.Prot, wg sync...
Passing sync.WaitGroup by reference in client sizes testing program Previously it was passed by value, meaning the program would never stop.
diff --git a/tests/test_isort.py b/tests/test_isort.py index <HASH>..<HASH> 100644 --- a/tests/test_isort.py +++ b/tests/test_isort.py @@ -836,6 +836,15 @@ def test_remove_imports() -> None: ) assert test_output == "import lib1\nimport lib5\n" + # From imports + test_input = "from x import y" + tes...
Add test for removing from imports
diff --git a/packages/fireplace/lib/utils/expand_path.js b/packages/fireplace/lib/utils/expand_path.js index <HASH>..<HASH> 100644 --- a/packages/fireplace/lib/utils/expand_path.js +++ b/packages/fireplace/lib/utils/expand_path.js @@ -4,7 +4,7 @@ FP.Utils = FP.Utils || {}; FP.Utils.expandPath = function(path, opts) { ...
better assert message when path expansion is missing parts
diff --git a/src/client/pps.go b/src/client/pps.go index <HASH>..<HASH> 100644 --- a/src/client/pps.go +++ b/src/client/pps.go @@ -240,7 +240,7 @@ func (c APIClient) ListJob(pipelineName string, inputCommit []*pfs.Commit, outpu if err == io.EOF { break } else if err != nil { - return nil, err + return nil...
Scrub GRPC error text from streaming errors (so that they work with client-side error libraries)
diff --git a/TYPO3.Media/Classes/TYPO3/Media/Domain/Repository/AssetRepository.php b/TYPO3.Media/Classes/TYPO3/Media/Domain/Repository/AssetRepository.php index <HASH>..<HASH> 100644 --- a/TYPO3.Media/Classes/TYPO3/Media/Domain/Repository/AssetRepository.php +++ b/TYPO3.Media/Classes/TYPO3/Media/Domain/Repository/Asset...
[TASK] Match filenames in asset search When searching for assets the filename is now included in the search criteria allowing assets without titles to be found. Change-Id: I<I>ba<I>ead<I>e<I>b0cc<I>d8f1d4a<I>e8 Releases: master Resolves: NEOS-<I> Reviewed-on: <URL>
diff --git a/src/utils/network_utils.js b/src/utils/network_utils.js index <HASH>..<HASH> 100644 --- a/src/utils/network_utils.js +++ b/src/utils/network_utils.js @@ -74,7 +74,7 @@ const NetworkUtils = { }, getAddressAndPortFromUri(uriString) { - let regexStr = /(?:http:\/\/|rosrpc:\/\/)?([a-zA-Z\d\-.:]+):(\...
Fix regex for parsing url. (#<I>) Added `_` to the valid characters in the hostname and removed ':'. Fixes #<I>.
diff --git a/bliss/core/dmc.py b/bliss/core/dmc.py index <HASH>..<HASH> 100644 --- a/bliss/core/dmc.py +++ b/bliss/core/dmc.py @@ -42,6 +42,7 @@ TwoPi = 2 * math.pi DOY_Format = '%Y-%jT%H:%M:%SZ' ISO_8601_Format = '%Y-%m-%dT%H:%M:%SZ' +_DEFAULT_FILE_NAME = 'leapseconds.dat' LeapSeconds = None def getTimesta...
Issue #8 - Fix inconsistent default leap second file name
diff --git a/src/Listener/GenerateSitemap.php b/src/Listener/GenerateSitemap.php index <HASH>..<HASH> 100644 --- a/src/Listener/GenerateSitemap.php +++ b/src/Listener/GenerateSitemap.php @@ -4,6 +4,7 @@ namespace Terabin\Sitemap\Listener; use Illuminate\Contracts\Events\Dispatcher; use Flarum\Event\DiscussionWasSta...
add(): generate sitemap after discussion was deleted
diff --git a/test/stream-end.js b/test/stream-end.js index <HASH>..<HASH> 100644 --- a/test/stream-end.js +++ b/test/stream-end.js @@ -173,9 +173,35 @@ tape('close after both sides of a duplex stream ends', function (t) { }) A.close(function (err) { - console.log('A CLOSE') + console.log('A CLOSE', err) ...
test that "closed" is always emitted
diff --git a/manifest.php b/manifest.php index <HASH>..<HASH> 100755 --- a/manifest.php +++ b/manifest.php @@ -32,7 +32,7 @@ return array( 'version' => '8.6.0', 'author' => 'Open Assessment Technologies SA', 'requires' => array( - 'generis' => '>=6.14.0', + 'generis' => '>=12.5.0',...
TTD-<I> Added\changed 'generis' version to '>=<I>' in `requires` secition
diff --git a/scenarios/kubernetes_verify.py b/scenarios/kubernetes_verify.py index <HASH>..<HASH> 100755 --- a/scenarios/kubernetes_verify.py +++ b/scenarios/kubernetes_verify.py @@ -131,8 +131,7 @@ def main(branch, script, force, on_prow): '-e', 'KUBE_FORCE_VERIFY_CHECKS=%s' % force, '-e', 'K...
don't set TMPDIR on prow verify scenario
diff --git a/packages/razzle/config/paths.js b/packages/razzle/config/paths.js index <HASH>..<HASH> 100644 --- a/packages/razzle/config/paths.js +++ b/packages/razzle/config/paths.js @@ -36,7 +36,7 @@ module.exports = { appPublic: resolveApp('public'), appNodeModules: resolveApp('node_modules'), appSrc: resolv...
Make path to server more TS friendly by removing strict file type
diff --git a/kiner/producer.py b/kiner/producer.py index <HASH>..<HASH> 100644 --- a/kiner/producer.py +++ b/kiner/producer.py @@ -43,12 +43,14 @@ class KinesisProducer: def __init__(self, stream_name, batch_size=500, batch_time=5, max_retries=5, threads=10, - kinesis_client=bot...
Remove boto3 instantiation from constructor definition
diff --git a/salt/utils/templates.py b/salt/utils/templates.py index <HASH>..<HASH> 100644 --- a/salt/utils/templates.py +++ b/salt/utils/templates.py @@ -85,11 +85,12 @@ def render_jinja_tmpl(tmplstr, context, tmplpath=None): loader = jinja2.FileSystemLoader(context, os.path.dirname(tmplpath)) else: ...
Enable with-tag extension in Jinja2 render. Closes #<I>.
diff --git a/src/Command/Generate/ModuleCommand.php b/src/Command/Generate/ModuleCommand.php index <HASH>..<HASH> 100644 --- a/src/Command/Generate/ModuleCommand.php +++ b/src/Command/Generate/ModuleCommand.php @@ -211,7 +211,7 @@ class ModuleCommand extends Command 'composer' => $composer, 'd...
Fix the wrong param name (#<I>)
diff --git a/lib/editor/dialog.js b/lib/editor/dialog.js index <HASH>..<HASH> 100644 --- a/lib/editor/dialog.js +++ b/lib/editor/dialog.js @@ -61,7 +61,9 @@ Dialog._geckoOpenModal = function(url, action, init) { }; capwin(window); // capture other frames - for (var i = 0; i < window.frames.length; cap...
Not so nice fix for "Not allowed to write to dialogs" on FireFox!
diff --git a/tests/test_secrets.py b/tests/test_secrets.py index <HASH>..<HASH> 100644 --- a/tests/test_secrets.py +++ b/tests/test_secrets.py @@ -92,18 +92,14 @@ def test_counterspell_wild_pyromancer(): def test_dart_trap(): - game = prepare_game(CardClass.WARRIOR, CardClass.WARRIOR) + game = prepare_game(CardCla...
Make Dart Trap test more deterministic
diff --git a/apps/actor-web/src/app/components/common/MessageItem.react.js b/apps/actor-web/src/app/components/common/MessageItem.react.js index <HASH>..<HASH> 100644 --- a/apps/actor-web/src/app/components/common/MessageItem.react.js +++ b/apps/actor-web/src/app/components/common/MessageItem.react.js @@ -112,9 +112,7 ...
fix(web): removed unnessesary console.log
diff --git a/leeroy/base.py b/leeroy/base.py index <HASH>..<HASH> 100644 --- a/leeroy/base.py +++ b/leeroy/base.py @@ -103,7 +103,7 @@ def github_notification(): "%s %s (%s): %s", base_repo_name, number, html_url, action) - if action not in ("opened", "synchronize"): + if a...
Initiate build when PR is reopened. When a PR has been reopened, kick off another build for the commit(s). This also helps address issue #9 as you can close/reopen a PR to force a rebuild.
diff --git a/onecodex/lib/upload.py b/onecodex/lib/upload.py index <HASH>..<HASH> 100644 --- a/onecodex/lib/upload.py +++ b/onecodex/lib/upload.py @@ -661,7 +661,11 @@ def upload_sequence_fileobj(file_obj, file_name, fields, retry_fields, session, _direct_upload(file_obj, file_name, fields, session, samples_r...
Add additional cancelation check for failed proxy uploads. Release <I>.
diff --git a/phraseapp/config.go b/phraseapp/config.go index <HASH>..<HASH> 100644 --- a/phraseapp/config.go +++ b/phraseapp/config.go @@ -231,8 +231,8 @@ func ParseYAMLToMap(unmarshal func(interface{}) error, keysToField map[string]in *val, err = ValidateIsInt(k, v) case *bool: *val, err = ValidateIsBool(k,...
config: fix issue with map handling The map must be given as reference.
diff --git a/spec/test_helper.rb b/spec/test_helper.rb index <HASH>..<HASH> 100644 --- a/spec/test_helper.rb +++ b/spec/test_helper.rb @@ -2,7 +2,7 @@ require 'rubygems' # To get the specs to run on Ruby 1.9.x. -gem 'test-unit', '= 2.0.2' +gem 'test-unit', '= 1.2.3' gem 'activesup...
Force test-unit <I> - test-unit <I>.x causes problems.
diff --git a/api/client.go b/api/client.go index <HASH>..<HASH> 100644 --- a/api/client.go +++ b/api/client.go @@ -260,9 +260,9 @@ func NewClient(c *Config) (*Client, error) { // but in e.g. http_test actual redirect handling is necessary c.HttpClient.CheckRedirect = func(req *http.Request, via []*http.Request) e...
Add ability to set max retries to API
diff --git a/bugtool/cmd/configuration.go b/bugtool/cmd/configuration.go index <HASH>..<HASH> 100644 --- a/bugtool/cmd/configuration.go +++ b/bugtool/cmd/configuration.go @@ -77,7 +77,7 @@ func defaultCommands(confDir string, cmdDir string, k8sPods []string) []string { "ip -6 route show table 200", // xfrm "ip...
cilium: scrub keys from bugtool xfrm Remove keys from xfrm debug output. We want the state output to identify any issues with xfrm setup, the output has the stats. We don't however want to record any keys. Fixes: <I>b<I>ee<I> ("cilium: bugtool add xfrm details")
diff --git a/tests/TestCase/Console/Command/CommandListShellTest.php b/tests/TestCase/Console/Command/CommandListShellTest.php index <HASH>..<HASH> 100644 --- a/tests/TestCase/Console/Command/CommandListShellTest.php +++ b/tests/TestCase/Console/Command/CommandListShellTest.php @@ -107,6 +107,7 @@ class CommandListShel...
Skipping test that is broken in hhvm
diff --git a/generators/app/index.js b/generators/app/index.js index <HASH>..<HASH> 100644 --- a/generators/app/index.js +++ b/generators/app/index.js @@ -466,6 +466,7 @@ module.exports = class extends BaseGenerator { this.warning( 'The generated application...
Need to call done() when the project is not a git repo otherwise other generator end() methods won't be called.
diff --git a/scoop/futures.py b/scoop/futures.py index <HASH>..<HASH> 100644 --- a/scoop/futures.py +++ b/scoop/futures.py @@ -156,7 +156,6 @@ def mapScan(mapFunc, reductionOp, *iterables, **kargs): "Be sure to start your program with the " "'-...
- Removed extraneous statement.
diff --git a/tensorflow_probability/python/distributions/generalized_pareto.py b/tensorflow_probability/python/distributions/generalized_pareto.py index <HASH>..<HASH> 100644 --- a/tensorflow_probability/python/distributions/generalized_pareto.py +++ b/tensorflow_probability/python/distributions/generalized_pareto.py @...
GeneralizedPareto is not constrained to positive concentration. PiperOrigin-RevId: <I>
diff --git a/soco.py b/soco.py index <HASH>..<HASH> 100644 --- a/soco.py +++ b/soco.py @@ -689,7 +689,7 @@ class SoCo(object): Returns: A dictionary containing the following information about the speakers playing state - CurrentTransportState (PLAYING or PAUSED_PLAYBACK), CurrentTrasn...
Update soco.py added stopped to currenttransportstate
diff --git a/lib/mincer/processor.js b/lib/mincer/processor.js index <HASH>..<HASH> 100644 --- a/lib/mincer/processor.js +++ b/lib/mincer/processor.js @@ -55,15 +55,12 @@ inherits(Processor, Template); // Run processor -Processor.prototype.evaluate = function (context, locals, callback) { +Processor.prototype.eval...
Make Processor#evaluate synchronous. Resolves #<I> Closes #<I>
diff --git a/tests/test_task_utils.py b/tests/test_task_utils.py index <HASH>..<HASH> 100644 --- a/tests/test_task_utils.py +++ b/tests/test_task_utils.py @@ -1,4 +1,5 @@ import pytest +import asyncio from task_utils import pipe, Component @@ -40,6 +41,35 @@ async def test_component_start_raise(): @pytest.ma...
test that a wrong event on startup will cancel a component
diff --git a/ca/django_ca/tests/tests_extensions.py b/ca/django_ca/tests/tests_extensions.py index <HASH>..<HASH> 100644 --- a/ca/django_ca/tests/tests_extensions.py +++ b/ca/django_ca/tests/tests_extensions.py @@ -44,6 +44,7 @@ from ..extensions import SubjectAlternativeName from ..extensions import SubjectKeyIdentif...
skip test in cryptography<<I>
diff --git a/src/main/docs/resources/js/multi-language-sample.js b/src/main/docs/resources/js/multi-language-sample.js index <HASH>..<HASH> 100644 --- a/src/main/docs/resources/js/multi-language-sample.js +++ b/src/main/docs/resources/js/multi-language-sample.js @@ -102,6 +102,11 @@ function postProcessCodeBlocks() { ...
Show the first sample in a multi language if none match the language choice
diff --git a/reposerver/repository/repository.go b/reposerver/repository/repository.go index <HASH>..<HASH> 100644 --- a/reposerver/repository/repository.go +++ b/reposerver/repository/repository.go @@ -1117,7 +1117,8 @@ func (s *Service) GetAppDetails(ctx context.Context, q *apiclient.RepoServerAppD continue ...
fix: file exention comparisons are case sensitive (#<I>)
diff --git a/src/Symfony/Bundle/SecurityBundle/DependencyInjection/SecurityExtension.php b/src/Symfony/Bundle/SecurityBundle/DependencyInjection/SecurityExtension.php index <HASH>..<HASH> 100644 --- a/src/Symfony/Bundle/SecurityBundle/DependencyInjection/SecurityExtension.php +++ b/src/Symfony/Bundle/SecurityBundle/Dep...
[SecurityBundle] Add trust_resolver variable into expression | Q | A | ------------- | --- | Bug fix? | [yes] | New feature? | [no] | BC breaks? | [no] | Deprecations? | [no] | Tests pass? | [yes] | Fixed tickets | [#<I>] | License | MIT | Doc PR | [-]
diff --git a/libraries/lithium/core/Libraries.php b/libraries/lithium/core/Libraries.php index <HASH>..<HASH> 100644 --- a/libraries/lithium/core/Libraries.php +++ b/libraries/lithium/core/Libraries.php @@ -553,7 +553,7 @@ class Libraries { * @return void */ protected static function _addPlugins($plugins) { - ...
By default, plugins now conditionally load bootstrap files, only if they exist.
diff --git a/src/Model/Behavior/DuplicatableBehavior.php b/src/Model/Behavior/DuplicatableBehavior.php index <HASH>..<HASH> 100644 --- a/src/Model/Behavior/DuplicatableBehavior.php +++ b/src/Model/Behavior/DuplicatableBehavior.php @@ -292,7 +292,7 @@ class DuplicatableBehavior extends Behavior break; ...
Check for a string first to pass the condition quicker
diff --git a/tests/PHPUnit/TestingEnvironment.php b/tests/PHPUnit/TestingEnvironment.php index <HASH>..<HASH> 100644 --- a/tests/PHPUnit/TestingEnvironment.php +++ b/tests/PHPUnit/TestingEnvironment.php @@ -95,6 +95,12 @@ class Piwik_TestingEnvironment } } + if ($testingEnvironment->globa...
Allow global variables to be manipulated through TestingEnvironment class.
diff --git a/application/briefkasten/tests/test_settings.py b/application/briefkasten/tests/test_settings.py index <HASH>..<HASH> 100644 --- a/application/briefkasten/tests/test_settings.py +++ b/application/briefkasten/tests/test_settings.py @@ -2,8 +2,8 @@ from py.test import fixture size_values = { '200': 20...
Adjust to new values (probably due to updated library, not sure at this point, the change seems innocent enough, though)
diff --git a/src/Auth/BaseAuthenticate.php b/src/Auth/BaseAuthenticate.php index <HASH>..<HASH> 100644 --- a/src/Auth/BaseAuthenticate.php +++ b/src/Auth/BaseAuthenticate.php @@ -122,7 +122,7 @@ abstract class BaseAuthenticate implements EventListenerInterface // null passwords as authentication systems ...
Apply hashing to empty passwords as well. Only when the password is null should hashing be skipped.
diff --git a/src/Form/Factory/MelisSiteSelectFactory.php b/src/Form/Factory/MelisSiteSelectFactory.php index <HASH>..<HASH> 100644 --- a/src/Form/Factory/MelisSiteSelectFactory.php +++ b/src/Form/Factory/MelisSiteSelectFactory.php @@ -26,7 +26,7 @@ class MelisSiteSelectFactory extends MelisSelectFactory for ($i = 0;...
changed MelisSiteSelect options from site_name to site_label
diff --git a/src/test/java/com/jnape/palatable/lambda/io/IOTest.java b/src/test/java/com/jnape/palatable/lambda/io/IOTest.java index <HASH>..<HASH> 100644 --- a/src/test/java/com/jnape/palatable/lambda/io/IOTest.java +++ b/src/test/java/com/jnape/palatable/lambda/io/IOTest.java @@ -352,7 +352,6 @@ public class IOTest {...
travis is unable to run monitorSync in 1 second?
diff --git a/src/ServiceProvider.php b/src/ServiceProvider.php index <HASH>..<HASH> 100644 --- a/src/ServiceProvider.php +++ b/src/ServiceProvider.php @@ -8,6 +8,8 @@ use Illuminate\Support\ServiceProvider as BaseServiceProvider; class ServiceProvider extends BaseServiceProvider { + protected $transKey = 'mailgu...
Add support for laravel 6
diff --git a/src/phpDocumentor/Application.php b/src/phpDocumentor/Application.php index <HASH>..<HASH> 100644 --- a/src/phpDocumentor/Application.php +++ b/src/phpDocumentor/Application.php @@ -63,17 +63,7 @@ final class Application public function cacheFolder() : string { - if ($this->cacheFolder =...
Revert cache folder change The cache folder is checked in the constructor and far before we can actually determine one. As such we cannot pass our own, and perhaps need to find another way to do caching.
diff --git a/packages/neos-ui/src/Containers/Modals/NodeCreationDialog/index.js b/packages/neos-ui/src/Containers/Modals/NodeCreationDialog/index.js index <HASH>..<HASH> 100644 --- a/packages/neos-ui/src/Containers/Modals/NodeCreationDialog/index.js +++ b/packages/neos-ui/src/Containers/Modals/NodeCreationDialog/index....
CLEANUP: remove test id selectors
diff --git a/src/cells.js b/src/cells.js index <HASH>..<HASH> 100644 --- a/src/cells.js +++ b/src/cells.js @@ -11,7 +11,7 @@ const appendDefaultCell = appendFromTemplate( , appendRow = appendFromTemplate('<li class="zambezi-grid-row"></li>') , changed = selectionChanged() , firstLastChanged = selectionCh...
Turn off debug for cell top change.
diff --git a/test/unittest_checker_python3.py b/test/unittest_checker_python3.py index <HASH>..<HASH> 100644 --- a/test/unittest_checker_python3.py +++ b/test/unittest_checker_python3.py @@ -28,6 +28,8 @@ def python2_only(test): return unittest.skipIf(sys.version_info[0] > 2, 'Python 2 only')(test) +# TODO(cpo...
Add a new TODO entry.
diff --git a/cmd2/cmd2.py b/cmd2/cmd2.py index <HASH>..<HASH> 100644 --- a/cmd2/cmd2.py +++ b/cmd2/cmd2.py @@ -3246,6 +3246,12 @@ class Cmd(cmd.Cmd): """ expanded_filename = os.path.expanduser(filename) + if not expanded_filename.endswith('.py'): + s...
Print warning if a user tries to run something other than a *.py file with run_pyscript and ask them if they want to continue
diff --git a/tests/selenium_test.go b/tests/selenium_test.go index <HASH>..<HASH> 100644 --- a/tests/selenium_test.go +++ b/tests/selenium_test.go @@ -1,3 +1,5 @@ +// +build selenium + /* * Copyright (C) 2017 Red Hat, Inc. *
test: restrict selenium tests runs only in selenium ci job Change-Id: I<I>aa<I>ab<I>a<I>a<I>a<I>c5ce7bbc<I> Reviewed-on: <URL>
diff --git a/core/src/main/java/com/google/errorprone/refaster/UTemplater.java b/core/src/main/java/com/google/errorprone/refaster/UTemplater.java index <HASH>..<HASH> 100644 --- a/core/src/main/java/com/google/errorprone/refaster/UTemplater.java +++ b/core/src/main/java/com/google/errorprone/refaster/UTemplater.java @...
Expand on the error when a Refaster template is trying to be loaded, but the annotations required aren't on the classpath. RELNOTES=n/a PiperOrigin-RevId: <I>
diff --git a/openid/consumer/consumer.py b/openid/consumer/consumer.py index <HASH>..<HASH> 100644 --- a/openid/consumer/consumer.py +++ b/openid/consumer/consumer.py @@ -1,7 +1,7 @@ # -*- test-case-name: openid.test.consumer -*- """ This module documents the main interface with the OpenID consumer -libary. The onl...
[project @ consumer.consumer: doc typo]
diff --git a/holoviews/core/data/interface.py b/holoviews/core/data/interface.py index <HASH>..<HASH> 100644 --- a/holoviews/core/data/interface.py +++ b/holoviews/core/data/interface.py @@ -146,7 +146,7 @@ class Interface(param.Parameterized): however if the type is expensive to import at load time the ...
Fixed bug in Interface.applies (#<I>)
diff --git a/spec/examples/spec_support/preparation_spec.rb b/spec/examples/spec_support/preparation_spec.rb index <HASH>..<HASH> 100644 --- a/spec/examples/spec_support/preparation_spec.rb +++ b/spec/examples/spec_support/preparation_spec.rb @@ -75,6 +75,7 @@ describe Cequel::SpecSupport::Preparation do after(:ea...
another attempt to harden the spec prep tests against intermittent failures
diff --git a/nsinit/nsinit/main.go b/nsinit/nsinit/main.go index <HASH>..<HASH> 100644 --- a/nsinit/nsinit/main.go +++ b/nsinit/nsinit/main.go @@ -24,7 +24,7 @@ var ( ErrWrongArguments = errors.New("Wrong argument count") ) -func init() { +func registerFlags() { flag.StringVar(&console, "console", "", "console (...
Fix tests with dockerinit lookup path Docker-DCO-<I>-
diff --git a/arangodb/api.py b/arangodb/api.py index <HASH>..<HASH> 100644 --- a/arangodb/api.py +++ b/arangodb/api.py @@ -326,6 +326,30 @@ class Database(object): return db + @classmethod + def get_all(cls): + """ + """ + + api = Client.instance().api + + data = api.datab...
Now the names of all databases can be retrieved and a database can be deleted
diff --git a/lib/mycroft.rb b/lib/mycroft.rb index <HASH>..<HASH> 100644 --- a/lib/mycroft.rb +++ b/lib/mycroft.rb @@ -2,7 +2,6 @@ require 'mycroft/version' require 'mycroft/cli' require 'mycroft/helpers' require 'mycroft/messages' -require 'mycroft/logger' require 'mycroft/client' module Mycroft
Remove logger from mycroft.rb
diff --git a/src/codegeneration/ModuleTransformer.js b/src/codegeneration/ModuleTransformer.js index <HASH>..<HASH> 100644 --- a/src/codegeneration/ModuleTransformer.js +++ b/src/codegeneration/ModuleTransformer.js @@ -42,7 +42,7 @@ import {assert} from '../util/assert.js'; import { resolveUrl, canonicalizeUrl -...
Fix import path Towards #<I>. The extra `../src/` made this load the file in src instead of dist.
diff --git a/tests/settings.py b/tests/settings.py index <HASH>..<HASH> 100644 --- a/tests/settings.py +++ b/tests/settings.py @@ -18,3 +18,7 @@ INSTALLED_APPS = ( 'django.contrib.admin', 'djangosaml2', ) + +AUTHENTICATION_BACKENDS = ( + 'djangosaml2.backends.Saml2Backend', +)
Add saml auth backend to settings in test project. Now that this isn't being monkey patched in, our test project needs to have it.
diff --git a/core/src/main/java/net/kuujo/copycat/internal/cluster/coordinator/DefaultClusterCoordinator.java b/core/src/main/java/net/kuujo/copycat/internal/cluster/coordinator/DefaultClusterCoordinator.java index <HASH>..<HASH> 100644 --- a/core/src/main/java/net/kuujo/copycat/internal/cluster/coordinator/DefaultClus...
Shut down resource executors when cluster is shut down.
diff --git a/Vps/Setup.php b/Vps/Setup.php index <HASH>..<HASH> 100644 --- a/Vps/Setup.php +++ b/Vps/Setup.php @@ -26,7 +26,7 @@ class Vps_Setup public static function setUpZend() { - error_reporting(E_ALL ^ E_STRICT); + error_reporting(E_ALL & ~E_STRICT); if (file_exists(VPS_PATH.'...
use proper operator when removing strict from error reporting
diff --git a/fetcher.go b/fetcher.go index <HASH>..<HASH> 100644 --- a/fetcher.go +++ b/fetcher.go @@ -253,7 +253,7 @@ func (f *consumerFetcherRoutine) start() { Warnf(f, "Current offset %d for topic %s and partition %s is out of range.", offset, nextTopicPartition.Topic, nextTopicPartition.Partition) ...
Added topic-partition logging on fetch errors
diff --git a/lib/store.js b/lib/store.js index <HASH>..<HASH> 100644 --- a/lib/store.js +++ b/lib/store.js @@ -81,8 +81,15 @@ Store.prototype.get = function(url, cb) { } this.Resource.one({url: url}, function(err, obj) { if (obj) { - // TODO populate obj.resources - needed if raja cache is not volatile - thi...
Populate lfuObj.resources from disk store
diff --git a/src/main/java/org/takes/facets/fallback/FbStatus.java b/src/main/java/org/takes/facets/fallback/FbStatus.java index <HASH>..<HASH> 100644 --- a/src/main/java/org/takes/facets/fallback/FbStatus.java +++ b/src/main/java/org/takes/facets/fallback/FbStatus.java @@ -51,7 +51,7 @@ public final class FbStatus ext...
Rename the WHITESPACE_PATTERN variable to SPLIT_PATTERN.
diff --git a/Command/WatchCommand.php b/Command/WatchCommand.php index <HASH>..<HASH> 100644 --- a/Command/WatchCommand.php +++ b/Command/WatchCommand.php @@ -82,6 +82,10 @@ class WatchCommand extends AbstractAssetsCommand $runCommand = new RunCommand(); $runCommand->setContainer($this...
fix infinite build if a destination of a task is the source of an other one (refs #4)
diff --git a/app/controllers/cfp/controller.rb b/app/controllers/cfp/controller.rb index <HASH>..<HASH> 100644 --- a/app/controllers/cfp/controller.rb +++ b/app/controllers/cfp/controller.rb @@ -1,11 +1,14 @@ class Cfp::Controller < ::ApplicationController - before_filter :check_for_profile + before_filter :check_fo...
Separate the controller code that sets the locale
diff --git a/saltcloud/clouds/ec2.py b/saltcloud/clouds/ec2.py index <HASH>..<HASH> 100644 --- a/saltcloud/clouds/ec2.py +++ b/saltcloud/clouds/ec2.py @@ -175,7 +175,7 @@ def get_configured_provider(): ''' return config.is_provider_configured( __opts__, - 'ec2', + __active_provider_name...
EC2 is now aware of the `__active_profile_name__` context variable. Refs #<I>
diff --git a/lark/load_grammar.py b/lark/load_grammar.py index <HASH>..<HASH> 100644 --- a/lark/load_grammar.py +++ b/lark/load_grammar.py @@ -605,6 +605,7 @@ def import_from_grammar_into_namespace(grammar, namespace, aliases): _, tree, _ = imported_rules[symbol] except KeyError: rais...
No longer confusing aliases and rules when importing (Issue #<I>)
diff --git a/www/src/py_exceptions.js b/www/src/py_exceptions.js index <HASH>..<HASH> 100644 --- a/www/src/py_exceptions.js +++ b/www/src/py_exceptions.js @@ -74,14 +74,14 @@ $B.$syntax_err_line = function(exc, module, src, pos, line_num){ line = lines[line_num - 1], lpos = pos - line_pos[line...
Change in attribute offset of SyntaxError instances
diff --git a/pylint/checkers/logging.py b/pylint/checkers/logging.py index <HASH>..<HASH> 100644 --- a/pylint/checkers/logging.py +++ b/pylint/checkers/logging.py @@ -49,7 +49,7 @@ MSGS = { the end of a conversion specifier.'), 'E1205': ('Too many arguments for logging format string', ...
Fix description of E<I> Add full stop to E<I> to make it more consistent with other descriptions.
diff --git a/lib/mini_term/windows/win_32_api.rb b/lib/mini_term/windows/win_32_api.rb index <HASH>..<HASH> 100644 --- a/lib/mini_term/windows/win_32_api.rb +++ b/lib/mini_term/windows/win_32_api.rb @@ -2,8 +2,6 @@ # Replacement support for deprecated win_32_api gem. # With thanks to rb-readline gem from which this...
Got rid of snarky comments.
diff --git a/src/Router.php b/src/Router.php index <HASH>..<HASH> 100644 --- a/src/Router.php +++ b/src/Router.php @@ -157,7 +157,7 @@ class Router { return $response; } ]; - register_rest_route( $this->_namespace, $route->get_path(), $args, true ); + ...
set param in call of register_rest_route func to default (false) to prevent routes overriding
diff --git a/Resources/bundle-creator/skel/Installation/AdditionalInstaller.php b/Resources/bundle-creator/skel/Installation/AdditionalInstaller.php index <HASH>..<HASH> 100644 --- a/Resources/bundle-creator/skel/Installation/AdditionalInstaller.php +++ b/Resources/bundle-creator/skel/Installation/AdditionalInstaller.p...
[CoreBundle] Update AdditionalInstaller.php
diff --git a/src/Event/Dispatcher.php b/src/Event/Dispatcher.php index <HASH>..<HASH> 100644 --- a/src/Event/Dispatcher.php +++ b/src/Event/Dispatcher.php @@ -70,7 +70,7 @@ class Dispatcher implements EventDispatcherInterface /** * {@inheritdoc} */ - public function getListeners(string $eventName = ...
Add return types to event dispatcher Fixes #<I>
diff --git a/src/main/java/com/basho/riak/client/raw/http/HTTPClientConfig.java b/src/main/java/com/basho/riak/client/raw/http/HTTPClientConfig.java index <HASH>..<HASH> 100644 --- a/src/main/java/com/basho/riak/client/raw/http/HTTPClientConfig.java +++ b/src/main/java/com/basho/riak/client/raw/http/HTTPClientConfig.ja...
Fixed style, with apolgies to Russell
diff --git a/lib/datalib.php b/lib/datalib.php index <HASH>..<HASH> 100644 --- a/lib/datalib.php +++ b/lib/datalib.php @@ -49,14 +49,9 @@ function setup_DB() { $CFG->dboptions = array(); } - if ($CFG->dblibrary == 'adodb') { - $classname = $CFG->dbtype.'_adodb_moodle_database'; - requir...
MDL-<I> support for other database driver types
diff --git a/tests/Aura/Intl/IntlFormatterTest.php b/tests/Aura/Intl/IntlFormatterTest.php index <HASH>..<HASH> 100644 --- a/tests/Aura/Intl/IntlFormatterTest.php +++ b/tests/Aura/Intl/IntlFormatterTest.php @@ -26,7 +26,7 @@ class IntlFormatterTest extends BasicFormatterTest $string = '{:pages,plural,' ...
use # instead of {:pages} as the latter causes trouble in some cases
diff --git a/src/Convert/Converters/Gd.php b/src/Convert/Converters/Gd.php index <HASH>..<HASH> 100644 --- a/src/Convert/Converters/Gd.php +++ b/src/Convert/Converters/Gd.php @@ -353,6 +353,8 @@ class Gd extends AbstractConverter // I'm not certain that the error handler takes care of Throwable errors. ...
make sure $success is defined
diff --git a/youtubemodal/index.js b/youtubemodal/index.js index <HASH>..<HASH> 100644 --- a/youtubemodal/index.js +++ b/youtubemodal/index.js @@ -259,7 +259,10 @@ function dispose() { } singleton.dispose(); singleton = null; - player = null; + if (player) { + player.destroy(); + player = null; + } }...
destroy() YT player in youtubemodal dispose
diff --git a/src/ResourceStorage.php b/src/ResourceStorage.php index <HASH>..<HASH> 100644 --- a/src/ResourceStorage.php +++ b/src/ResourceStorage.php @@ -86,7 +86,7 @@ final class ResourceStorage implements ResourceStorageInterface assert($pool instanceof AdapterInterface); if ($etagPool instanceof...
Add red condition Set $knownTagVersionsTtl 0
diff --git a/py3status/__init__.py b/py3status/__init__.py index <HASH>..<HASH> 100755 --- a/py3status/__init__.py +++ b/py3status/__init__.py @@ -5,6 +5,7 @@ import os import select import sys +from collections import OrderedDict from contextlib import contextmanager from copy import deepcopy from datetime impo...
fix issue #<I>, ensure modules methods are always iterated alphabetically thx to @shankargopal