diff
stringlengths 65
26.7k
| message
stringlengths 7
9.92k
|
|---|---|
diff --git a/indra/tools/reading/wait_for_complete.py b/indra/tools/reading/wait_for_complete.py
index <HASH>..<HASH> 100644
--- a/indra/tools/reading/wait_for_complete.py
+++ b/indra/tools/reading/wait_for_complete.py
@@ -63,7 +63,7 @@ if __name__ == '__main__':
)
args = parser.parse_args()
- from submit_reading_pipeline import wait_for_complete
+ from indra.tools.reading.submit_reading_pipeline import wait_for_complete
job_list = None
if args.job_list is not None:
|
Clarify path to wait_for_complete.
|
diff --git a/angr/analyses/cfg/cfg_fast.py b/angr/analyses/cfg/cfg_fast.py
index <HASH>..<HASH> 100644
--- a/angr/analyses/cfg/cfg_fast.py
+++ b/angr/analyses/cfg/cfg_fast.py
@@ -1462,6 +1462,12 @@ class CFGFast(ForwardAnalysis, CFGBase): # pylint: disable=abstract-method
None
)
+ if not procedure.NO_RET:
+ # it returns
+ cfg_node.has_return = True
+ self._function_exits[current_function_addr].add(addr)
+ self._function_add_return_site(addr, current_function_addr)
+
return entries
def _scan_irsb(self, addr, current_function_addr, previous_jumpkind, previous_src_node, previous_src_ins_addr,
|
CFGFast: Add return endpoints for SimProcedure functions.
|
diff --git a/src/ResolveIteratorCapableTrait.php b/src/ResolveIteratorCapableTrait.php
index <HASH>..<HASH> 100644
--- a/src/ResolveIteratorCapableTrait.php
+++ b/src/ResolveIteratorCapableTrait.php
@@ -59,7 +59,10 @@ trait ResolveIteratorCapableTrait
$i = 0;
while (!$test($iterator) && $i < $limit) {
- /* @var $iterator IteratorAggregate */
+ if (!($iterator instanceof IteratorAggregate)) {
+ break;
+ }
+
$_it = $iterator->getIterator();
if ($iterator === $_it) {
throw $this->_createOutOfRangeException(
|
Added test for `IteratorAggregate`
This is because the test function is not guaranteed to test for
`Iterator` interface.
|
diff --git a/spyderlib/widgets/projectexplorer.py b/spyderlib/widgets/projectexplorer.py
index <HASH>..<HASH> 100644
--- a/spyderlib/widgets/projectexplorer.py
+++ b/spyderlib/widgets/projectexplorer.py
@@ -321,6 +321,8 @@ class Project(object):
item_preceding, tree, include, exclude, show_all)
parent_dirname = abspardir(dirname)
parent = dirs[parent_dirname]
+ if item_preceding is None:
+ item_preceding = parent
item_preceding = self.create_dir_item(dirname, parent,
item_preceding, tree,
include, exclude, show_all)
|
Project explorer: when refreshing tree to show a new entry preceding the first item of a branch, this entry was added as the last item of the branch instead of the first one
|
diff --git a/function/function.go b/function/function.go
index <HASH>..<HASH> 100644
--- a/function/function.go
+++ b/function/function.go
@@ -456,7 +456,10 @@ func (f *Function) Build() (io.Reader, error) {
if err := zip.AddFile(path, file); err != nil {
return nil, err
}
- defer file.Close()
+
+ if err := file.Close(); err != nil {
+ return nil, err
+ }
}
if err := zip.Close(); err != nil {
|
remove deferring of file Close() for builds
could quickly lead to exhausting descriptors
|
diff --git a/src/math.js b/src/math.js
index <HASH>..<HASH> 100644
--- a/src/math.js
+++ b/src/math.js
@@ -83,10 +83,10 @@ math.bound = function( min, val, max ){
math.makeBoundingBox = function( bb ){
if( bb == null ){
return {
- x1: 0,
- y1: 0,
- x2: 0,
- y2: 0,
+ x1: Infinity,
+ y1: Infinity,
+ x2: -Infinity,
+ y2: -Infinity,
w: 0,
h: 0
};
|
fixes bb calcs for layers #<I> with negative x1, y1
|
diff --git a/tests/test.py b/tests/test.py
index <HASH>..<HASH> 100644
--- a/tests/test.py
+++ b/tests/test.py
@@ -88,7 +88,6 @@ class UidGidTest(unittest.TestCase):
if os.getuid() != 0:
return True
- os.chown(self.pidfile, NOBODY_UID, NOBODY_GID)
os.chown(self.logfile, NOBODY_UID, NOBODY_GID)
os.system("python tests/daemon_uid_gid.py %s %s" % (self.pidfile, self.logfile))
|
Do not chown pidfile in tests
|
diff --git a/test/functional/test_auth.rb b/test/functional/test_auth.rb
index <HASH>..<HASH> 100755
--- a/test/functional/test_auth.rb
+++ b/test/functional/test_auth.rb
@@ -369,7 +369,7 @@ module LitleOnline
'orderSource'=>'ecommerce',
'card'=>{
'type'=>'VI',
- 'number' =>'4100800000000000',
+ 'number' =>'4100300000100000',
'expDate' =>'1210'
},
}
|
Fixed test_auth so that card numbers asking for special responses follow sandbox documentation
|
diff --git a/src/toil/batchSystems/mesos/batchSystem.py b/src/toil/batchSystems/mesos/batchSystem.py
index <HASH>..<HASH> 100644
--- a/src/toil/batchSystems/mesos/batchSystem.py
+++ b/src/toil/batchSystems/mesos/batchSystem.py
@@ -355,7 +355,7 @@ class MesosBatchSystem(BatchSystemSupport,
task.task_id.value, offer.id.value)
remainingCores -= jobType.cores
remainingMemory -= toMiB(jobType.memory)
- remainingDisk -= jobType.disk
+ remainingDisk -= toMiB(jobType.disk)
nextToLaunchIndex += 1
if self.jobQueues[jobType] and not runnableTasksOfType:
log.debug('Offer %(offer)s not suitable to run the tasks with requirements '
|
Fix Mesos disk allocation (resolves #<I>)
|
diff --git a/lib/dm-core/spec/shared/adapter_spec.rb b/lib/dm-core/spec/shared/adapter_spec.rb
index <HASH>..<HASH> 100644
--- a/lib/dm-core/spec/shared/adapter_spec.rb
+++ b/lib/dm-core/spec/shared/adapter_spec.rb
@@ -51,7 +51,7 @@ share_examples_for 'An Adapter' do
end
after :all do
- Object.send(:remove_const,'Heffalump')
+ Object.send(:remove_const,'Heffalump') if defined? ::Heffalump
end
if adapter_supports?(:create)
|
Be more defensive when removing Heffalump const in shared adapter specs
|
diff --git a/marshmallow_jsonapi/fields.py b/marshmallow_jsonapi/fields.py
index <HASH>..<HASH> 100644
--- a/marshmallow_jsonapi/fields.py
+++ b/marshmallow_jsonapi/fields.py
@@ -85,16 +85,20 @@ class Relationship(BaseRelationship):
return None
def add_resource_linkage(self, value):
+ def stringify(value):
+ if value is not None:
+ return str(value)
+ return value
+
if self.many:
- included_data = [
- {'type': self.type_,
- 'id': get_value_or_raise(self.id_field, each)}
- for each in value
- ]
+ included_data = [{
+ 'type': self.type_,
+ 'id': stringify(get_value_or_raise(self.id_field, each))
+ } for each in value]
else:
included_data = {
'type': self.type_,
- 'id': get_value_or_raise(self.id_field, value)
+ 'id': stringify(get_value_or_raise(self.id_field, value))
}
return included_data
|
The value of id members must always be strings unless empty
|
diff --git a/site/kotlin-example-loader.js b/site/kotlin-example-loader.js
index <HASH>..<HASH> 100644
--- a/site/kotlin-example-loader.js
+++ b/site/kotlin-example-loader.js
@@ -41,9 +41,9 @@ module.exports = function kotlinExampleLoader(source) {
then(() => {
fs.readFile(TMP_FILE_NAME, (e, buffer) => {
handleError(e);
- fs.readFile(TMP_SOURCE_MAP_FILE_NAME, (e, sourceMapBuffer) => {
+ fs.readFile(TMP_SOURCE_MAP_FILE_NAME, 'utf8', (e, sourceMap) => {
handleError(e);
- callback(null, buffer, sourceMapBuffer);
+ callback(null, buffer, sourceMap);
cleanup();
});
});
|
RING-UI-CR-<I> decode sourcemap to string before passing it to webpack
Former-commit-id: <I>edfadac1b<I>a7dd1c9a<I>d<I>f<I>c<I>
|
diff --git a/examples/sampleserver.py b/examples/sampleserver.py
index <HASH>..<HASH> 100644
--- a/examples/sampleserver.py
+++ b/examples/sampleserver.py
@@ -195,8 +195,10 @@ class ServerHandler(util.HTTPHandler):
self.wfile.write(response.body)
except:
+ import sys
+ sys.excepthook(*sys.exc_info())
self._headers(500)
- raise KeyboardInterrupt
+ raise SystemExit
def user(self):
try:
|
[project @ Added debug info when the sample server gets an exception in handleOpenIDRequest]
|
diff --git a/lib/shared.js b/lib/shared.js
index <HASH>..<HASH> 100644
--- a/lib/shared.js
+++ b/lib/shared.js
@@ -12,7 +12,7 @@ const sha256File = require('sha256-file');
* @param {Object} serverless
* @return {undefined}
*/
-function checkForAndDeleteMaxCacheVersions(options, serverless) {
+function checkForAndDeleteMaxCacheVersions({ serverless, options, log }) {
// If we're using the static cache, and we have static cache max versions enabled
if (
options.useStaticCache &&
@@ -42,10 +42,17 @@ function checkForAndDeleteMaxCacheVersions(options, serverless) {
rimraf.sync(files[i]);
items++;
}
+
// Log the number of cache files flushed
- serverless.cli.log(
- `Removed ${items} items from cache because of staticCacheMaxVersions`
- );
+ if (log) {
+ log.info(
+ `Removed ${items} items from cache because of staticCacheMaxVersions`
+ );
+ } else {
+ serverless.cli.log(
+ `Removed ${items} items from cache because of staticCacheMaxVersions`
+ );
+ }
}
}
}
|
refactor: Adapt `shared` to modern logs
|
diff --git a/app/presenters/hyrax/work_show_presenter.rb b/app/presenters/hyrax/work_show_presenter.rb
index <HASH>..<HASH> 100644
--- a/app/presenters/hyrax/work_show_presenter.rb
+++ b/app/presenters/hyrax/work_show_presenter.rb
@@ -116,7 +116,7 @@ module Hyrax
end
def link_name
- current_ability.can?(:read, id) ? to_s : 'File'
+ current_ability.can?(:read, id) ? to_s : 'Private'
end
def export_as_nt
|
Relabel the links for private child works from 'File'
"File" isn't an accurate description of a work. When a child work isn't
readable, just list it as "Private" instead.
|
diff --git a/test/specs/grapesjs/index.js b/test/specs/grapesjs/index.js
index <HASH>..<HASH> 100644
--- a/test/specs/grapesjs/index.js
+++ b/test/specs/grapesjs/index.js
@@ -376,5 +376,16 @@ describe('GrapesJS', () => {
editor = obj.init(config);
expect(editor.Commands.get('export-template').test).toEqual(1);
});
+
+ it('Dump unused css classes/selectors', () => {
+ config.fromElement = 1;
+ config.storageManager = { type: 0 };
+ fixture.innerHTML = documentEl;
+ const editor = obj.init(config);
+ const css = editor.getCss({ dumpUnusedSelectors: 1 });
+ const protCss = editor.getConfig().protectedCss;
+ expect(editor.getStyle().length).toEqual(2);
+ expect(css).toEqual(`${protCss}.test2{color:red;}.test3{color:blue;}`);
+ });
});
});
|
added unit testing to dump unused css selectors
|
diff --git a/umap/plot.py b/umap/plot.py
index <HASH>..<HASH> 100644
--- a/umap/plot.py
+++ b/umap/plot.py
@@ -20,16 +20,16 @@ except ImportError:
warn(
"""The umap.plot package requires extra plotting libraries to be installed.
You can install these via pip using
-
+
pip install umap-learn[plot]
-
+
or via conda using
-
- conda install seaborn datashader bokeh holoviews
+
+ conda install datashader bokeh holoviews colorcet
"""
)
raise ImportError(
- "umap.plot requires matplotlib, seaborn, datashader and holoviews to be "
+ "umap.plot requires matplotlib, datashader, colorcet and holoviews to be "
"installed"
) from None
|
Update import notes in plot.py
|
diff --git a/aws/aws_test.go b/aws/aws_test.go
index <HASH>..<HASH> 100644
--- a/aws/aws_test.go
+++ b/aws/aws_test.go
@@ -346,6 +346,9 @@ func Test_Examples(t *testing.T) {
"@pulumi/cloud",
"@pulumi/cloud-aws",
},
+ // #494: lambda tests are unexpectedly proposing and performing code changes
+ AllowEmptyPreviewChanges: true,
+ AllowEmptyUpdateChanges: true,
ExtraRuntimeValidation: containersRuntimeValidator(fargateRegion),
},
{
|
Allow changes in empty preview/update for long-running tests. (#<I>)
The `containers` test uses a lambda that appears to suffer from the same
unexpected no-op changes as the others in this repo. Investigating this
is tracked by #<I>.
|
diff --git a/openstack/resource_openstack_networking_port_v2.go b/openstack/resource_openstack_networking_port_v2.go
index <HASH>..<HASH> 100644
--- a/openstack/resource_openstack_networking_port_v2.go
+++ b/openstack/resource_openstack_networking_port_v2.go
@@ -137,9 +137,8 @@ func resourceNetworkingPortV2() *schema.Resource {
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"ip_address": {
- Type: schema.TypeString,
- Required: true,
- ValidateFunc: validation.SingleIP(),
+ Type: schema.TypeString,
+ Required: true,
},
"mac_address": {
Type: schema.TypeString,
|
Networking v2: Fix Allowed Address Pairs validation (#<I>)
This change reverts a previous modification which restricted an allowed
address pair's IP address to be a single IP address rather than a CIDR.
|
diff --git a/objectrocket/auth.py b/objectrocket/auth.py
index <HASH>..<HASH> 100644
--- a/objectrocket/auth.py
+++ b/objectrocket/auth.py
@@ -129,7 +129,7 @@ class Auth(bases.BaseAuthLayer):
:rtype: dict
"""
# Attempt to authenticate.
- url = '{}{}'.format(self._url, 'verify')
+ url = '{}{}/'.format(self._url, 'verify')
resp = requests.post(
url,
json={'token': token},
diff --git a/tests/test_auth.py b/tests/test_auth.py
index <HASH>..<HASH> 100644
--- a/tests/test_auth.py
+++ b/tests/test_auth.py
@@ -175,3 +175,21 @@ def test_auth_username_setter(client):
client.auth._username = testval
assert client.auth._username is testval
assert orig_val is not testval
+
+
+@responses.activate
+def test_auth_verify_makes_expected_call(client):
+ token = 'testing'
+ expected_url = 'https://sjc-api.objectrocket.com/v2/tokens/verify/'
+ expected_user_data = {'testing': 'testing'}
+ responses.add(
+ responses.POST,
+ expected_url,
+ status=200,
+ body=json.dumps({'data': expected_user_data}),
+ content_type="application/json"
+ )
+
+ output = client.auth._verify(token)
+
+ assert output == expected_user_data
|
Add test to ensure _verify functionality.
|
diff --git a/scripts/ci/extract-changelog.py b/scripts/ci/extract-changelog.py
index <HASH>..<HASH> 100755
--- a/scripts/ci/extract-changelog.py
+++ b/scripts/ci/extract-changelog.py
@@ -23,4 +23,4 @@ for i, line in enumerate(changelog):
break
if start != 0:
- print ''.join(changelog[start+1:end]).strip()
+ print(''.join(changelog[start+1:end]).strip())
|
Fix script to extract changelog for Python 3
|
diff --git a/ghost/admin/Gruntfile.js b/ghost/admin/Gruntfile.js
index <HASH>..<HASH> 100644
--- a/ghost/admin/Gruntfile.js
+++ b/ghost/admin/Gruntfile.js
@@ -34,7 +34,7 @@ module.exports = function(grunt) {
shell: {
'npm-install': {
- command: 'npm install'
+ command: 'yarn install'
},
'bower-install': {
|
🛠 switch to using yarn in our Grunt tasks (#<I>)
no issue
- use `yarn install` instead of `npm install` in our `grunt init` task (used in Ghost's `grunt init` via subgrunt)
|
diff --git a/lib/waistband/result.rb b/lib/waistband/result.rb
index <HASH>..<HASH> 100644
--- a/lib/waistband/result.rb
+++ b/lib/waistband/result.rb
@@ -13,6 +13,7 @@ module Waistband
def respond_to_missing?(method_name, include_private = false)
return true if @result_hash.keys.include?(method_name.to_s)
+ return true if @result_hash['_source'] && @result_hash['_source'].keys.include?(method_name.to_s)
super
end
|
better respond_to_missing in result
|
diff --git a/src/Mover.php b/src/Mover.php
index <HASH>..<HASH> 100644
--- a/src/Mover.php
+++ b/src/Mover.php
@@ -2,12 +2,14 @@
namespace CoenJacobs\Mozart;
+use CoenJacobs\Mozart\Composer\Autoload\Autoloader;
use CoenJacobs\Mozart\Composer\Autoload\Classmap;
use CoenJacobs\Mozart\Composer\Autoload\NamespaceAutoloader;
use CoenJacobs\Mozart\Composer\Package;
use League\Flysystem\Adapter\Local;
use League\Flysystem\Filesystem;
use Symfony\Component\Finder\Finder;
+use Symfony\Component\Finder\SplFileInfo;
class Mover
{
@@ -95,10 +97,10 @@ class Mover
/**
* @param Package $package
- * @param $autoloader
- * @param $file
- * @param $path
- * @return mixed
+ * @param Autoloader $autoloader
+ * @param SplFileInfo $file
+ * @param string $path
+ * @return string
*/
public function moveFile(Package $package, $autoloader, $file, $path = '')
{
|
Add types to method @params
|
diff --git a/src/server/pps/server/monitor.go b/src/server/pps/server/monitor.go
index <HASH>..<HASH> 100644
--- a/src/server/pps/server/monitor.go
+++ b/src/server/pps/server/monitor.go
@@ -283,7 +283,7 @@ func (a *apiServer) monitorPipeline(pachClient *client.APIClient, pipelineInfo *
return err
}
case <-pachClient.Ctx().Done():
- return context.DeadlineExceeded
+ return pachClient.Ctx().Err()
}
}
}, backoff.NewInfiniteBackOff(), func(err error, d time.Duration) error {
|
Return correct error from monitorPipeline
|
diff --git a/examples/flashing_doge.py b/examples/flashing_doge.py
index <HASH>..<HASH> 100644
--- a/examples/flashing_doge.py
+++ b/examples/flashing_doge.py
@@ -1,15 +1,16 @@
import pyfakewebcam
-import scipy.misc as misc
import numpy as np
import time
import timeit
-cam = pyfakewebcam.FakeWebcam('/dev/video1', 640, 512)
+from PIL import Image
+
+cam = pyfakewebcam.FakeWebcam('/dev/video1', 1280, 720)
cam.print_capabilities()
-im0 = misc.imread("doge1.jpg")
-im1 = np.zeros((512,640,3), dtype=np.uint8)
+im0 = np.array( Image.open("doge1.jpg") )
+im1 = np.zeros((720,1280,3), dtype=np.uint8)
while True:
|
flashing_doge.py : changed resolution to <I>p
|
diff --git a/src/ui/axis/src/orientedAxis.js b/src/ui/axis/src/orientedAxis.js
index <HASH>..<HASH> 100644
--- a/src/ui/axis/src/orientedAxis.js
+++ b/src/ui/axis/src/orientedAxis.js
@@ -55,9 +55,9 @@ export default function orientAxis(AxisComponent, orientation) {
const axisProps = omit(this.props, ['scale', 'scales']);
return (
<AxisComponent
+ {...axisProps}
tickValues={this.state.tickValues}
scale={this.props.scale || getValue(this.props, AXIS_TYPE_TO_SCALE_PATH[orientation])}
- {...axisProps}
/>
);
}
|
props provided by OrientedAxis to its wrapped Axis component should override any user-defined props
|
diff --git a/DependencyInjection/Configuration/Configuration.php b/DependencyInjection/Configuration/Configuration.php
index <HASH>..<HASH> 100644
--- a/DependencyInjection/Configuration/Configuration.php
+++ b/DependencyInjection/Configuration/Configuration.php
@@ -82,7 +82,6 @@ class Configuration implements ConfigurationInterface
->fixXmlConfig('client')
->children()
->arrayNode('clients')
- ->requiresAtLeastOneElement()
->useAttributeAsKey('alias', false)
->prototype('array')
->fixXmlConfig('dsn')
|
Remove requirement that at least one client be provided
|
diff --git a/tests/test_layers.py b/tests/test_layers.py
index <HASH>..<HASH> 100644
--- a/tests/test_layers.py
+++ b/tests/test_layers.py
@@ -240,7 +240,15 @@ def test_torch_layer():
assert not torch.allclose(model1(input), model2(input))
model2.load_state_dict(pickle.loads(pickle.dumps(model1.state_dict())))
assert torch.allclose(model1(input), model2(input))
- # TODO jittization
+
+ # tracing (freezing)
+ model3 = torch.jit.trace(input)(model2)
+ assert torch.allclose(model1(input), model3(input))
+ assert torch.allclose(model1(input + 1), model3(input + 1))
+
+ model4 = torch.jit.trace(input, optimize=True)(model2)
+ assert torch.allclose(model1(input), model4(input))
+ assert torch.allclose(model1(input + 1), model4(input + 1))
def test_keras_layer():
|
Add testing of model freezing for pytorch
|
diff --git a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/filter/WhereStep.java b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/filter/WhereStep.java
index <HASH>..<HASH> 100644
--- a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/filter/WhereStep.java
+++ b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/filter/WhereStep.java
@@ -74,6 +74,7 @@ public final class WhereStep<S> extends FilterStep<S> implements TraversalParent
for (final IsStep<?> isStep : this.scopePEndSteps) {
((ScopeP) isStep.getPredicate()).bind(this, traverser);
}
+ // return TraversalUtil.test(traverser, (Traversal.Admin<S,?>)this.predicate.getTraversals().get(0)); // TODO: we need to make WhereStep operate on Traversal (this fails for AndP() -- turn AndP() in And()?
return this.predicate.getBiPredicate().test(traverser, null);
}
|
notes for WhereStep's future.
|
diff --git a/js/aofex.js b/js/aofex.js
index <HASH>..<HASH> 100644
--- a/js/aofex.js
+++ b/js/aofex.js
@@ -325,7 +325,11 @@ module.exports = class aofex extends Exchange {
// ]
// }
//
- const result = { 'info': response };
+ const result = {
+ 'info': response,
+ 'timestamp': undefined,
+ 'datetime': undefined,
+ };
const balances = this.safeValue (response, 'result', []);
for (let i = 0; i < balances.length; i++) {
const balance = balances[i];
|
aofex-fetchBalance-timestamp
|
diff --git a/Repository/CourseSessionUserRepository.php b/Repository/CourseSessionUserRepository.php
index <HASH>..<HASH> 100644
--- a/Repository/CourseSessionUserRepository.php
+++ b/Repository/CourseSessionUserRepository.php
@@ -69,7 +69,7 @@ class CourseSessionUserRepository extends EntityRepository
JOIN csu.user u
WHERE csu.session = :session
AND u.isEnabled = true
- ORDER BY u.username ASC
+ ORDER BY u.lastName ASC
';
$query = $this->_em->createQuery($dql);
$query->setParameter('session', $session);
|
[CursusBundle] order by username to order by lastName
|
diff --git a/src-standard/main/java/javax/time/chrono/CopticChrono.java b/src-standard/main/java/javax/time/chrono/CopticChrono.java
index <HASH>..<HASH> 100644
--- a/src-standard/main/java/javax/time/chrono/CopticChrono.java
+++ b/src-standard/main/java/javax/time/chrono/CopticChrono.java
@@ -65,14 +65,17 @@ import javax.time.calendrical.CalendricalObject;
*/
public final class CopticChrono extends Chrono implements Serializable {
- private static final long serialVersionUID = 1L;
-
/**
* Singleton instance.
*/
public static final CopticChrono INSTANCE = new CopticChrono();
/**
+ * Serialization version.
+ */
+ private static final long serialVersionUID = 1L;
+
+ /**
* Restricted constructor.
*/
private CopticChrono() {
|
Javadoc, move field to correct location in file
|
diff --git a/imolecule/__init__.py b/imolecule/__init__.py
index <HASH>..<HASH> 100644
--- a/imolecule/__init__.py
+++ b/imolecule/__init__.py
@@ -1,6 +1,6 @@
from imolecule.notebook import draw, generate, to_json # noqa
__title__ = 'imolecule'
-__version__ = '0.1.8'
+__version__ = '0.1.9'
__author__ = 'Patrick Fuller'
__license__ = 'MIT'
|
Incremented version to publicize ipy<I> fix
|
diff --git a/recordlinkage/preprocessing/__init__.py b/recordlinkage/preprocessing/__init__.py
index <HASH>..<HASH> 100644
--- a/recordlinkage/preprocessing/__init__.py
+++ b/recordlinkage/preprocessing/__init__.py
@@ -2,4 +2,6 @@ from recordlinkage.preprocessing.cleaning import *
from recordlinkage.preprocessing.encoding import phonetic
from recordlinkage.preprocessing.encoding import _list_phonetic_algorithms
+
phonetic_algorithms = _list_phonetic_algorithms()
+"""List of available phonetic algorithms."""
|
Add docstring phonetic_algorithms attribute
|
diff --git a/lib/util/conflicter.js b/lib/util/conflicter.js
index <HASH>..<HASH> 100644
--- a/lib/util/conflicter.js
+++ b/lib/util/conflicter.js
@@ -4,7 +4,7 @@ var fs = require('fs');
var path = require('path');
var events = require('events');
var diff = require('diff');
-var prompt = require('../actions/prompt').prompt;
+var prompt = require('../actions/prompt');
var exists = fs.existsSync || path.existsSync;
var log = logger('conflicter');
|
fix issue with prompt when file conflict occours
|
diff --git a/eng/versioning/set_versions.py b/eng/versioning/set_versions.py
index <HASH>..<HASH> 100644
--- a/eng/versioning/set_versions.py
+++ b/eng/versioning/set_versions.py
@@ -184,6 +184,10 @@ def update_versions_file_for_nightly_devops(build_type, build_qualifier, artifac
else:
module.dependency += '-' + unreleased_build_qualifier
+ # The final unreleased dependency version needs to be of the form
+ # [1.0.0-dev.YYYYMMDD.,] <-- note the ., this is the version range for Maven
+ module.dependency = '[{},]'.format(module.dependency)
+
print(f'updating unreleased/beta dependency {module.name} to use dependency version range: "{module.dependency}"')
version_map[module.name] = module
|
Version range needs the , at the end (#<I>)
* Version range needs the , at the end
* version range needs to be in braces
Used override because nothing in this PR affects a core - ci run. The change had to be verified on a run that sets the dev version in a pipeline that has unreleased dependencies.
|
diff --git a/setuptools_scm/git_file_finder.py b/setuptools_scm/git_file_finder.py
index <HASH>..<HASH> 100644
--- a/setuptools_scm/git_file_finder.py
+++ b/setuptools_scm/git_file_finder.py
@@ -1,7 +1,3 @@
-# -*- coding: utf-8 -*-
-# Copyright © 2018 ACSONE SA/NV
-# License LGPLv3 (http://www.gnu.org/licenses/lgpl-3.0-standalone.html)
-
import os
import subprocess
import tarfile
diff --git a/testing/test_git_file_finder.py b/testing/test_git_file_finder.py
index <HASH>..<HASH> 100644
--- a/testing/test_git_file_finder.py
+++ b/testing/test_git_file_finder.py
@@ -1,7 +1,3 @@
-# -*- coding: utf-8 -*-
-# Copyright © 2018 ACSONE SA/NV
-# License LGPLv3 (http://www.gnu.org/licenses/lgpl-3.0-standalone.html)
-
import os
import sys
|
Remove file headers to follow local style
|
diff --git a/mtrace.js b/mtrace.js
index <HASH>..<HASH> 100644
--- a/mtrace.js
+++ b/mtrace.js
@@ -195,10 +195,16 @@ function finishedParsing() {
continue;
}
idx += tag.length;
- var end_idx = stdout.indexOf('\n', idx) || stdout.length;
+ var end_idx = stdout.indexOf('\n', idx);
+ if (end_idx === -1) {
+ end_idx = stdout.length;
+ }
if (end_idx === idx) {
++idx;
- end_idx = stdout.indexOf('\n', idx) || stdout.length;
+ end_idx = stdout.indexOf('\n', idx);
+ if (end_idx === -1) {
+ end_idx = stdout.length;
+ }
}
var line = stdout.slice(idx, end_idx);
if (line.slice(0, 9) === 'No symbol') {
|
Fixed incorrect condition on indexOf.
|
diff --git a/build/build.py b/build/build.py
index <HASH>..<HASH> 100755
--- a/build/build.py
+++ b/build/build.py
@@ -897,6 +897,9 @@ def runValidator():
def checkService():
+ if not os.path.exists(vnuJar):
+ release = Release()
+ release.createExecutable("jar")
doc = miniDoc.replace(" ", "%20")
query = "?out=gnu&doc=data:text/html;charset=utf-8,%s" % doc
url = "http://localhost:%s/%s" % (portNumber, query)
@@ -1050,7 +1053,7 @@ class Release():
'-cp', self.classpath, 'org.apache.tools.ant.Main',
'-f', self.buildXml, jarOrWar])
if jarOrWar == "jar":
- release.checkJar()
+ self.checkJar()
else:
self.writeHashes(distWarDir)
|
Build: Ensure jar is built before checking service
|
diff --git a/index.js b/index.js
index <HASH>..<HASH> 100644
--- a/index.js
+++ b/index.js
@@ -28,12 +28,12 @@ module.exports = {
let addonOptions = this._getAddonOptions(app).typefaceOptions || {}
let typefaces = addonOptions.disableAuto ? [] : this._getTypefacesFromPackage()
- this.options = merge.all([{}, {
+ this._options = merge.all([{}, {
typefaces
}, addonOptions])
- if (!this.options.typefaces.length) {
+ if (!this._options.typefaces.length) {
return;
}
@@ -78,7 +78,7 @@ module.exports = {
},
_checkTypefaces () {
- this.options.typefaces.forEach((typeface) => {
+ this._options.typefaces.forEach((typeface) => {
if (!typefaceList.includes(typeface)) {
throw new Error(`The font '${typeface}' is not supported. Please chose a font from the available list.`)
}
@@ -94,7 +94,7 @@ module.exports = {
},
_createImports () {
- this.options.typefaces.filter(onlyUnique).forEach((typeface) => {
+ this._options.typefaces.filter(onlyUnique).forEach((typeface) => {
this.import(`node_modules/typeface-${typeface}/index.css`, {
destDir: 'assets/files'
});
|
Prevent deprecation with options collision
|
diff --git a/core/src/main/java/org/jboss/jca/core/connectionmanager/ccm/CachedConnectionManagerImpl.java b/core/src/main/java/org/jboss/jca/core/connectionmanager/ccm/CachedConnectionManagerImpl.java
index <HASH>..<HASH> 100644
--- a/core/src/main/java/org/jboss/jca/core/connectionmanager/ccm/CachedConnectionManagerImpl.java
+++ b/core/src/main/java/org/jboss/jca/core/connectionmanager/ccm/CachedConnectionManagerImpl.java
@@ -686,6 +686,14 @@ public class CachedConnectionManagerImpl implements CachedConnectionManager
*/
public void beforeCompletion()
{
+ // No-action
+ }
+
+ /**
+ * {@inheritDoc}
+ */
+ public void afterCompletion(int status)
+ {
closing.set(true);
for (Iterator<Object> i = connections.iterator(); i.hasNext();)
@@ -695,14 +703,6 @@ public class CachedConnectionManagerImpl implements CachedConnectionManager
connections.clear();
}
-
- /**
- * {@inheritDoc}
- */
- public void afterCompletion(int status)
- {
- // No-action
- }
}
/**
|
[JBJCA-<I>] - Container is not cleaning up container-managed JMSContext
|
diff --git a/FlowCytometryTools/core/containers.py b/FlowCytometryTools/core/containers.py
index <HASH>..<HASH> 100755
--- a/FlowCytometryTools/core/containers.py
+++ b/FlowCytometryTools/core/containers.py
@@ -175,7 +175,7 @@ class FCMeasurement(Measurement):
return plot_ndpanel(channel_mat, plot_region, **kwargs)
- def view_interactively(self, backend='auto'):
+ def view_interactively(self, backend='wx'):
'''Loads the current sample in a graphical interface for drawing gates.
Parameters
|
changing default GUI back to wx
|
diff --git a/dateparser/date_parser.py b/dateparser/date_parser.py
index <HASH>..<HASH> 100644
--- a/dateparser/date_parser.py
+++ b/dateparser/date_parser.py
@@ -407,15 +407,6 @@ def parse_using_languages(date_string, date_format, languages):
raise ValueError("Invalid date: %s" % date_string)
-def _is_word_in_language(token, language):
- """Check if token is a word in the given language
- """
- # XXX: needed for unclean dates (in URLs) like 14_luglio_2014
- token = token.strip('_')
-
- return INFOS[language].month(token)
-
-
def get_language_candidates(tokens, languages=None, exclude_languages=None):
"""Find the languages which have a word matching
at least one of the given tokens and all tokens are known by this language
@@ -428,11 +419,9 @@ def get_language_candidates(tokens, languages=None, exclude_languages=None):
require_fuzzy = False
for lang in languages:
- should_add = False
+ should_add = True
for token in tokens:
- if _is_word_in_language(token, lang):
- should_add = True
- elif not token.isdigit() and not INFOS[lang].is_token_known(token):
+ if not token.isdigit() and not INFOS[lang].is_token_known(token):
require_fuzzy = True
should_add = False
break
|
Fix for languages with months given as numbers
|
diff --git a/setup.py b/setup.py
index <HASH>..<HASH> 100644
--- a/setup.py
+++ b/setup.py
@@ -19,8 +19,8 @@ setup(
platforms='any',
python_requires='>=3.7',
extras_require={
- 'dev': ['tox>3', 'flake8', 'pep8-naming', 'wheel', 'twine'],
- 'test': ['pytest>=6', 'pytest-cov'],
+ 'dev': ['tox>=3', 'flake8', 'pep8-naming', 'wheel', 'twine'],
+ 'test': ['pytest>=7', 'pytest-cov'],
},
long_description=pathlib.Path('README.rst').read_text(encoding='utf-8'),
classifiers=[
|
bump pytest to >= 7, fix tox version
|
diff --git a/tests/unit/io/XDMFTest.py b/tests/unit/io/XDMFTest.py
index <HASH>..<HASH> 100644
--- a/tests/unit/io/XDMFTest.py
+++ b/tests/unit/io/XDMFTest.py
@@ -62,7 +62,7 @@ class XDMFTest:
def test_save(self, tmpdir):
fname = tmpdir.join('test_file')
- op.io.XDMF.save(network=self.net, phases=self.phase_1, filename=fname)
+ op.io.XDMF.export_data(network=self.net, phases=self.phase_1, filename=fname)
os.remove(tmpdir.join('test_file.hdf'))
os.remove(tmpdir.join('test_file.xmf'))
|
Update XDMF tets
|
diff --git a/src/kvs.js b/src/kvs.js
index <HASH>..<HASH> 100644
--- a/src/kvs.js
+++ b/src/kvs.js
@@ -64,7 +64,7 @@ module.exports = (knex, options = {}) => {
const bootstrap = () => {
return helpers(knex).createTableIfNotExists(tableName, function(table) {
table.string('key').primary()
- table.string('value')
+ table.text('value')
table.timestamp('modified_on')
})
}
|
kvs stores info in text instead of carchar(<I>)
|
diff --git a/lib/cache.js b/lib/cache.js
index <HASH>..<HASH> 100644
--- a/lib/cache.js
+++ b/lib/cache.js
@@ -17,7 +17,10 @@ module.exports = function(){
key = req.originalUrl;
redis.get(key,function(error,reply){
- if(!error && reply){
+ if(error){
+ console.log('Error in caching layer:',error);
+ return next();
+ }else if(reply){
res.set('Content-Type', 'application/json');
res.end(reply);
}else{
|
Improved caching layer in case of a redis failure
|
diff --git a/docs/conf.py b/docs/conf.py
index <HASH>..<HASH> 100644
--- a/docs/conf.py
+++ b/docs/conf.py
@@ -294,4 +294,4 @@ epub_copyright = copyright
# Example configuration for intersphinx: refer to the Python standard library.
-intersphinx_mapping = {'http://docs.python.org/': None}
+intersphinx_mapping = {'python': ('http://docs.python.org/2', None)}
|
Changed intersphinx conf to the new format
|
diff --git a/executor/executor_test.go b/executor/executor_test.go
index <HASH>..<HASH> 100644
--- a/executor/executor_test.go
+++ b/executor/executor_test.go
@@ -107,12 +107,12 @@ var _ = Suite(&testSuiteAgg{baseTestSuite: &baseTestSuite{}})
var _ = Suite(&testSuite6{&baseTestSuite{}})
var _ = Suite(&testSuite7{&baseTestSuite{}})
var _ = Suite(&testSuite8{&baseTestSuite{}})
-var _ = SerialSuites(&testShowStatsSuite{&baseTestSuite{}})
+var _ = Suite(&testShowStatsSuite{&baseTestSuite{}})
var _ = Suite(&testBypassSuite{})
var _ = Suite(&testUpdateSuite{})
var _ = Suite(&testPointGetSuite{})
var _ = Suite(&testBatchPointGetSuite{})
-var _ = SerialSuites(&testRecoverTable{})
+var _ = Suite(&testRecoverTable{})
var _ = Suite(&testClusterReaderSuite{})
var _ = Suite(&testFlushSuite{})
var _ = SerialSuites(&testAutoRandomSuite{&baseTestSuite{}})
|
executor: optimize unit test by unset some serial test suites (#<I>)
|
diff --git a/cmd/kubeadm/app/cmd/reset.go b/cmd/kubeadm/app/cmd/reset.go
index <HASH>..<HASH> 100644
--- a/cmd/kubeadm/app/cmd/reset.go
+++ b/cmd/kubeadm/app/cmd/reset.go
@@ -168,7 +168,7 @@ func (r *Reset) Run(out io.Writer, client clientset.Interface) error {
klog.V(1).Info("[reset] removing Kubernetes-managed containers")
if err := removeContainers(utilsexec.New(), r.criSocketPath); err != nil {
- klog.Errorf("[reset] failed to remove containers: %+v", err)
+ klog.Errorf("[reset] failed to remove containers: %v", err)
}
dirsToClean = append(dirsToClean, []string{kubeadmconstants.KubeletRunDirectory, "/etc/cni/net.d", "/var/lib/dockershim", "/var/run/kubernetes"}...)
|
kubeadm: Don't dump backtrace on reset
The current code logs an error and full blown backtrace if we fail to remove
the containers upon reset. This creates unneeded, huge and rather scary log
message. Fix that by leaving just the error message.
|
diff --git a/src/matreshka-magic.js b/src/matreshka-magic.js
index <HASH>..<HASH> 100644
--- a/src/matreshka-magic.js
+++ b/src/matreshka-magic.js
@@ -702,9 +702,7 @@
},
_defineSpecial: function(object, key, noAccessors) {
- if (!object || typeof object != 'object') return object;
-
- initMK(object);
+ if (!object || typeof object != 'object' || !object[sym] ) return object;
var specialProps = object[sym].special[key];
|
don't use initMK inside _defineSpecial (performance improvement)
|
diff --git a/xclim/indices/_conversion.py b/xclim/indices/_conversion.py
index <HASH>..<HASH> 100644
--- a/xclim/indices/_conversion.py
+++ b/xclim/indices/_conversion.py
@@ -1191,9 +1191,9 @@ def universal_thermal_climate_index(
tr: xr.DataArray = None,
) -> xr.DataArray:
"""
- Mean Universal Thermal Climate Index (UTCI)
+ Universal Thermal Climate Index (UTCI)
- The mean of daily UTCI
+ The daily UTCI
Parameters
----------
|
Update xclim/indices/_conversion.py
|
diff --git a/test/e2e/storage/testsuites/multivolume.go b/test/e2e/storage/testsuites/multivolume.go
index <HASH>..<HASH> 100644
--- a/test/e2e/storage/testsuites/multivolume.go
+++ b/test/e2e/storage/testsuites/multivolume.go
@@ -305,7 +305,7 @@ func (t *multiVolumeTestSuite) DefineTests(driver TestDriver, pattern testpatter
// [ node1 ]
// \ / <- same volume mode
// [volume1]
- ginkgo.It("should concurrently access the single volume from pods on the same node", func() {
+ ginkgo.It("should concurrently access the single volume from pods on the same node [LinuxOnly]", func() {
init()
defer cleanup()
|
Add linuxonly on one multivolume test
This test is not working for windows yet due to commands issued in pod
are not available for windows
Change-Id: Ia0b<I>afd6dfe0bbb1ab<I>dc<I>a7e8ce<I>
|
diff --git a/trimesh/visual/texture.py b/trimesh/visual/texture.py
index <HASH>..<HASH> 100644
--- a/trimesh/visual/texture.py
+++ b/trimesh/visual/texture.py
@@ -135,9 +135,13 @@ class TextureVisuals(Visuals):
uv = self.uv
if uv is not None:
uv = uv.copy()
+ face_materials = self.face_materials
+ if face_materials is not None:
+ face_materials = face_materials.copy()
copied = TextureVisuals(
uv=uv,
- material=self.material.copy())
+ material=self.material.copy(),
+ face_materials=face_materials)
return copied
|
Fix TextureVisuals.copy() with face_materials.
|
diff --git a/lib/sinatra.rb b/lib/sinatra.rb
index <HASH>..<HASH> 100644
--- a/lib/sinatra.rb
+++ b/lib/sinatra.rb
@@ -1,3 +1,4 @@
+$LOAD_PATH.unshift File.dirname(__FILE__)
require 'sinatra/base'
require 'sinatra/main'
require 'sinatra/compat'
|
add lib dir to load path, for backward compatibility
|
diff --git a/tests/ee/test_energy_efficiency_meter.py b/tests/ee/test_energy_efficiency_meter.py
index <HASH>..<HASH> 100644
--- a/tests/ee/test_energy_efficiency_meter.py
+++ b/tests/ee/test_energy_efficiency_meter.py
@@ -83,7 +83,7 @@ def meter_input_daily(project_meter_input):
} for dt in record_starts
]
- trace = _natural_gas_input(records)
+ trace = _electricity_input(records)
trace.update({'interval': 'daily'})
meter_input = {
|
Make sure the daily model tests run on both gas and electric
|
diff --git a/tests/dummy/config/environment.js b/tests/dummy/config/environment.js
index <HASH>..<HASH> 100644
--- a/tests/dummy/config/environment.js
+++ b/tests/dummy/config/environment.js
@@ -6,6 +6,9 @@ module.exports = function(environment) {
environment: environment,
baseURL: '/',
locationType: 'auto',
+ 'ember-remodal': {
+ disableAnimationWhileTesting: true
+ },
EmberENV: {
FEATURES: {
// Here you can enable experimental features on an ember canary build
|
use new config flag in these tests
|
diff --git a/nbsphinx_link/__init__.py b/nbsphinx_link/__init__.py
index <HASH>..<HASH> 100644
--- a/nbsphinx_link/__init__.py
+++ b/nbsphinx_link/__init__.py
@@ -86,7 +86,7 @@ class LinkedNotebookParser(NotebookParser):
def setup(app):
"""Initialize Sphinx extension."""
app.setup_extension('nbsphinx')
- app.add_source_parser('.nblink', LinkedNotebookParser)
+ app.add_source_parser('.nblink', LinkedNotebookParser, override=True)
app.add_config_value('nbsphinx_link_target_root', None, rebuild='env')
return {'version': __version__, 'parallel_read_safe': True}
|
Update for sphinx <I>
|
diff --git a/src/server/worker/api_server.go b/src/server/worker/api_server.go
index <HASH>..<HASH> 100644
--- a/src/server/worker/api_server.go
+++ b/src/server/worker/api_server.go
@@ -21,6 +21,7 @@ import (
"sync/atomic"
"syscall"
"time"
+ "unicode/utf8"
etcd "github.com/coreos/etcd/clientv3"
"github.com/gogo/protobuf/jsonpb"
@@ -676,6 +677,9 @@ func (a *APIServer) uploadOutput(pachClient *client.APIClient, dir string, tag s
if err != nil {
return err
}
+ if !utf8.ValidString(filePath) {
+ return fmt.Errorf("Filepath is not valid utf-8: %s", filePath)
+ }
if filePath == outputPath {
tree = hashtree.NewOrdered("/")
return nil
|
Check that the paths of outputted files are valid utf-8. This is necessary because the filepath is decoded as utf-8 downstream when it's used as input for a pipeline.
|
diff --git a/pyparsing/__init__.py b/pyparsing/__init__.py
index <HASH>..<HASH> 100644
--- a/pyparsing/__init__.py
+++ b/pyparsing/__init__.py
@@ -1,6 +1,6 @@
# module pyparsing.py
#
-# Copyright (c) 2003-2019 Paul T. McGuire
+# Copyright (c) 2003-2020 Paul T. McGuire
#
# Permission is hereby granted, free of charge, to any person obtaining
# a copy of this software and associated documentation files (the
@@ -154,6 +154,7 @@ __all__ = [
"LineEnd",
"LineStart",
"Literal",
+ "Located",
"PrecededBy",
"MatchFirst",
"NoMatch",
|
Fix minor typos and add Located to `__all__` list
|
diff --git a/lib/page/html.js b/lib/page/html.js
index <HASH>..<HASH> 100644
--- a/lib/page/html.js
+++ b/lib/page/html.js
@@ -7,7 +7,7 @@ var Promise = require('../utils/promise');
var location = require('../utils/location');
// Selector to ignore
-var ANNOTATION_IGNORE = '.no-glossary,code,pre,a,script';
+var ANNOTATION_IGNORE = '.no-glossary,code,pre,a,script,h1,h2,h3,h4,h5,h6';
function HTMLPipeline(htmlString, opts) {
_.bindAll(this);
|
Ignore headings for annotations
|
diff --git a/modules_v2/upcoming_events/module.php b/modules_v2/upcoming_events/module.php
index <HASH>..<HASH> 100644
--- a/modules_v2/upcoming_events/module.php
+++ b/modules_v2/upcoming_events/module.php
@@ -28,8 +28,6 @@ if (!defined('WT_WEBTREES')) {
exit;
}
-require_once WT_ROOT.'includes/functions/functions_print_lists.php';
-
class upcoming_events_WT_Module extends WT_Module implements WT_Module_Block {
// Extend class WT_Module
public function getTitle() {
@@ -45,6 +43,8 @@ class upcoming_events_WT_Module extends WT_Module implements WT_Module_Block {
public function getBlock($block_id, $template=true, $cfg=null) {
global $ctype, $WT_IMAGES;
+ require_once WT_ROOT.'includes/functions/functions_print_lists.php';
+
$days =get_block_setting($block_id, 'days', 7);
$filter =get_block_setting($block_id, 'filter', true);
$onlyBDM =get_block_setting($block_id, 'onlyBDM', false);
|
Only load functions_print_lists on pages that actually need it
|
diff --git a/spec/factories.rb b/spec/factories.rb
index <HASH>..<HASH> 100644
--- a/spec/factories.rb
+++ b/spec/factories.rb
@@ -302,8 +302,8 @@ FactoryGirl.define do
# We can do this because the error type is determined by the
# HTTP response code.
- factory :blockscore_error, class: Hash, traits: [:resource] do
- ignore do
+ factory :blockscore_error, :class => Hash, :traits => [:resource] do
+ transient do
error_type 'api_error'
end
|
Update FactoryGirl dependency to <I>
|
diff --git a/table/tables/tables.go b/table/tables/tables.go
index <HASH>..<HASH> 100644
--- a/table/tables/tables.go
+++ b/table/tables/tables.go
@@ -681,7 +681,7 @@ func (t *TableCommon) AddRecord(sctx sessionctx.Context, r []types.Datum, opts .
pkIdx := FindPrimaryIndex(tblInfo)
pkDts := make([]types.Datum, 0, len(pkIdx.Columns))
for _, idxCol := range pkIdx.Columns {
- pkDts = append(pkDts, r[tblInfo.Columns[idxCol.Offset].Offset])
+ pkDts = append(pkDts, r[idxCol.Offset])
}
tablecodec.TruncateIndexValues(tblInfo, pkIdx, pkDts)
var handleBytes []byte
|
table: fix redundant and misleading conditions (#<I>)
|
diff --git a/fusesoc/edalizer.py b/fusesoc/edalizer.py
index <HASH>..<HASH> 100644
--- a/fusesoc/edalizer.py
+++ b/fusesoc/edalizer.py
@@ -82,7 +82,7 @@ class Edalizer(object):
else:
_name = os.path.join(rel_root, file.name)
_files.append({
- 'name' : _name,
+ 'name' : str(_name),
'core' : str(core.name),
'file_type' : file.file_type,
'is_include_file' : file.is_include_file,
|
Always cast file name to string in edalizer
|
diff --git a/addon/mixins/router.js b/addon/mixins/router.js
index <HASH>..<HASH> 100644
--- a/addon/mixins/router.js
+++ b/addon/mixins/router.js
@@ -1,19 +1,20 @@
import Ember from 'ember';
+function trackPage() {
+ Ember.run.scheduleOnce('afterRender', () => {
+ this.get('metrics').trackPage({
+ page: this.get('url'),
+ title: this.getWithDefault('currentRouteName', 'unknown')
+ });
+ });
+}
+
export default Ember.Mixin.create({
metrics: Ember.inject.service(),
didTransition() {
this._super(...arguments);
- this._trackPage();
- },
- _trackPage() {
- Ember.run.scheduleOnce('afterRender', () => {
- this.get('metrics').trackPage({
- page: this.get('url'),
- title: this.getWithDefault('currentRouteName', 'unknown')
- });
- });
+ trackPage.call(this);
}
});
|
don't pollute the Router "namespace" with _trackEvent
|
diff --git a/lib/specinfra/version.rb b/lib/specinfra/version.rb
index <HASH>..<HASH> 100644
--- a/lib/specinfra/version.rb
+++ b/lib/specinfra/version.rb
@@ -1,3 +1,3 @@
module Specinfra
- VERSION = "2.42.1"
+ VERSION = "2.42.2"
end
|
Bump up version
[skip ci]
|
diff --git a/lib/millstone.js b/lib/millstone.js
index <HASH>..<HASH> 100644
--- a/lib/millstone.js
+++ b/lib/millstone.js
@@ -268,7 +268,7 @@ function resolve(options, callback) {
var uri = url.parse(s);
// URL, download.
- if (uri.protocol) {
+ if (uri.protocol && (uri.protocol == 'http:' || uri.protocol == 'https:')) {
return (new get(s)).asBuffer(function(err, data) {
if (err) return next(err);
@@ -351,7 +351,7 @@ function resolve(options, callback) {
};
// URL.
- if (uri.protocol) {
+ if (uri.protocol && (uri.protocol == 'http:' || uri.protocol == 'https:')) {
var filepath = path.join(cache, cachepath(l.Datasource.file));
localize(uri.href, filepath, function(err, file) {
if (err) return next(err);
|
fix required for windows to avoid downloading files that have a protocol of 'c:\'
|
diff --git a/blockstack/lib/config.py b/blockstack/lib/config.py
index <HASH>..<HASH> 100644
--- a/blockstack/lib/config.py
+++ b/blockstack/lib/config.py
@@ -141,7 +141,7 @@ RPC_DEFAULT_TIMEOUT = 30 # in secs
RPC_MAX_ZONEFILE_LEN = 40960 # 40KB
RPC_MAX_INDEXING_DELAY = 2 * 3600 # 2 hours; maximum amount of time before the absence of new blocks causes the node to stop responding
-MAX_RPC_LEN = RPC_MAX_ZONEFILE_LEN * 10 # maximum blockstackd RPC length
+MAX_RPC_LEN = RPC_MAX_ZONEFILE_LEN * 250 # maximum blockstackd RPC length == 100 zone files, base64-encoded (assume 1.33x overhead for encoding, plus extra XML)
if os.environ.get("BLOCKSTACK_TEST_MAX_RPC_LEN"):
MAX_RPC_LEN = int(os.environ.get("BLOCKSTACK_TEST_MAX_RPC_LEN"))
print("Overriding MAX_RPC_LEN to {}".format(MAX_RPC_LEN))
|
make the max RPC length equal to the expected amount of space <I> fully-loaded zone files take when encoded
|
diff --git a/src/com/mebigfatguy/fbcontrib/detect/WriteOnlyCollection.java b/src/com/mebigfatguy/fbcontrib/detect/WriteOnlyCollection.java
index <HASH>..<HASH> 100755
--- a/src/com/mebigfatguy/fbcontrib/detect/WriteOnlyCollection.java
+++ b/src/com/mebigfatguy/fbcontrib/detect/WriteOnlyCollection.java
@@ -28,6 +28,7 @@ import java.util.LinkedHashSet;
import java.util.LinkedList;
import java.util.List;
import java.util.Map;
+import java.util.Queue;
import java.util.Set;
import java.util.SortedMap;
import java.util.SortedSet;
@@ -70,6 +71,7 @@ public class WriteOnlyCollection extends BytecodeScanningDetector {
collectionClasses.add(Vector.class.getName());
collectionClasses.add(ArrayList.class.getName());
collectionClasses.add(LinkedList.class.getName());
+ collectionClasses.add(Queue.class.getName());
}
private static Set<String> writeMethods = new HashSet<String>();
|
Added java.util.Queue target to WriteOnlyCollection Detector.
|
diff --git a/src/js/pouch.js b/src/js/pouch.js
index <HASH>..<HASH> 100644
--- a/src/js/pouch.js
+++ b/src/js/pouch.js
@@ -11,16 +11,13 @@ var expressPouchdb = require("express-pouchdb");
gpii.pouch.init = function (that) {
var MemPouchDB = PouchDB.defaults({db: memdown });
- if (that.options.databases && Object.keys(that.options.databases).length > 0) {
- Object.keys(that.options.databases).forEach(function (key) {
- var dbConfig = that.options.databases[key];
- var db = new MemPouchDB(key);
- if (dbConfig.data) {
- var data = require(dbConfig.data);
- db.bulkDocs(data);
- }
- });
- }
+ fluid.each(that.options.databases, function(dbConfig, key) {
+ var db = new MemPouchDB(key);
+ if (dbConfig.data) {
+ var data = require(dbConfig.data);
+ db.bulkDocs(data);
+ }
+ });
that.expressPouchdb = expressPouchdb(MemPouchDB);
|
GPII-<I>: Simplified database import code based on feedback from pull request review.
|
diff --git a/extension/fop-pdf/integrationTest/fopTest.js b/extension/fop-pdf/integrationTest/fopTest.js
index <HASH>..<HASH> 100644
--- a/extension/fop-pdf/integrationTest/fopTest.js
+++ b/extension/fop-pdf/integrationTest/fopTest.js
@@ -7,7 +7,7 @@ var assert = require("assert"),
describeReporting = require("../../../test/helpers.js").describeReporting;
-describeReporting(path.join(__dirname, "../../"), [], function(reporter) {
+describeReporting(path.join(__dirname, "../../"), ["html", "fop-pdf"], function(reporter) {
describe('fop pdf', function () {
it('should be rendered', function(done) {
|
usage of nedb in tests: grunt file refactoring, tests refactoring; excel-parser extension replaced dataParser.js
|
diff --git a/test/setup/pretest.js b/test/setup/pretest.js
index <HASH>..<HASH> 100644
--- a/test/setup/pretest.js
+++ b/test/setup/pretest.js
@@ -15,4 +15,8 @@ wrench.copyDirSyncRecursive(C.TEST_BUNDLE_SRC_PATH, C.BUNDLE_DIR, { forceDelete:
fs.writeFileSync(C.BUNDLE_CFG_PATH, JSON.stringify({ test: 'the_test_string' }));
// Delete any existing persisted replicants for the test bundle
-wrench.rmdirSyncRecursive(path.resolve(__dirname, '../../db/replicants/test-bundle'));
+var replicantDir = path.resolve(__dirname, '../../db/replicants/test-bundle');
+if (fs.existsSync(replicantDir)) {
+ wrench.rmdirSyncRecursive(replicantDir);
+}
+
|
[tests] Prevent error when test-bundle replicant dir doesn't exist
|
diff --git a/src/Handler/GuzzleV5/GuzzleHandler.php b/src/Handler/GuzzleV5/GuzzleHandler.php
index <HASH>..<HASH> 100644
--- a/src/Handler/GuzzleV5/GuzzleHandler.php
+++ b/src/Handler/GuzzleV5/GuzzleHandler.php
@@ -28,6 +28,7 @@ class GuzzleHandler
private static $validOptions = [
'proxy' => true,
'expect' => true,
+ 'cert' => true,
'verify' => true,
'timeout' => true,
'debug' => true,
|
whitelist cert http option on GuzzleV5 (#<I>)
|
diff --git a/zipline/finance/slippage.py b/zipline/finance/slippage.py
index <HASH>..<HASH> 100644
--- a/zipline/finance/slippage.py
+++ b/zipline/finance/slippage.py
@@ -103,7 +103,6 @@ class VolumeShareSlippage(object):
total_order = 0
simulated_amount = 0
simulated_impact = 0.0
- direction = 1.0
for order in current_orders:
|
MAINT: Removes unneeded assignment in slippage.
`direction` is set on each iteration of the loop,
making the initial assignment unneeded.
|
diff --git a/src/DebugConsole/DebugConsole.php b/src/DebugConsole/DebugConsole.php
index <HASH>..<HASH> 100644
--- a/src/DebugConsole/DebugConsole.php
+++ b/src/DebugConsole/DebugConsole.php
@@ -218,9 +218,12 @@ namespace PhpKit\WebConsole\DebugConsole {
* \PhpKit\WebConsole\DebugConsole\DebugConsole::trace ();
*
* @return string
+ * @throws Exception
*/
public static function trace ()
{
+ if (!extension_loaded('xdebug'))
+ throw new Exception ("<kbd>trace()</kbd> requires Xdebug to be installed.");
$v = ini_get ('xdebug.collect_params');
ob_start ();
ini_set ('xdebug.collect_params', 1);
|
Error message: "trace() requires Xdebug to be installed"
|
diff --git a/docs/assets/js/application.js b/docs/assets/js/application.js
index <HASH>..<HASH> 100644
--- a/docs/assets/js/application.js
+++ b/docs/assets/js/application.js
@@ -9,7 +9,7 @@
var $window = $(window)
// Disable certain links in docs
- $('section [href^=#]').click(function (e) {
+ $('[href=#]').click(function (e) {
e.preventDefault()
})
|
Update docs JS to prevent clicks on links with hash hrefs
|
diff --git a/src/lib/server.js b/src/lib/server.js
index <HASH>..<HASH> 100644
--- a/src/lib/server.js
+++ b/src/lib/server.js
@@ -141,6 +141,15 @@ export default class Server extends EventEmitter
})
if (!this.namespaces[ns]) this._generateNamespace(ns)
+ else
+ {
+ const index = this.namespaces[ns].events[name]
+
+ if (index !== undefined)
+ {
+ throw new Error(`Already registered event ${ns}${name}`)
+ }
+ }
this.namespaces[ns].events[name] = []
@@ -153,10 +162,14 @@ export default class Server extends EventEmitter
for (const socket_id of this.namespaces[ns].events[name])
{
- this.namespaces[ns].clients.get(socket_id).send(CircularJSON.stringify({
- notification: name,
- params: params || null
- }))
+ const socket = this.namespaces[ns].clients.get(socket_id)
+ if (socket)
+ {
+ socket.send(CircularJSON.stringify({
+ notification: name,
+ params: params || null
+ }))
+ }
}
})
}
|
Prevent multiple event registration and prevent crash after disonnection
|
diff --git a/lib/sigh/developer_center.rb b/lib/sigh/developer_center.rb
index <HASH>..<HASH> 100644
--- a/lib/sigh/developer_center.rb
+++ b/lib/sigh/developer_center.rb
@@ -51,7 +51,7 @@ module Sigh
certs = post_ajax(@list_certs_url)
- profile_name = Sigh.config[:provisioning_file_name]
+ profile_name = Sigh.config[:provisioning_name]
Helper.log.info "Checking if profile is available. (#{certs['provisioningProfiles'].count} profiles found)"
required_cert_types = (@type == DEVELOPMENT ? ['iOS Development'] : ['iOS Distribution', 'iOS UniversalDistribution'])
|
Fix name change in profile name config
|
diff --git a/projects/samskivert/src/java/com/samskivert/servlet/user/UserManager.java b/projects/samskivert/src/java/com/samskivert/servlet/user/UserManager.java
index <HASH>..<HASH> 100644
--- a/projects/samskivert/src/java/com/samskivert/servlet/user/UserManager.java
+++ b/projects/samskivert/src/java/com/samskivert/servlet/user/UserManager.java
@@ -1,5 +1,5 @@
//
-// $Id: UserManager.java,v 1.23 2003/10/14 02:00:01 mdb Exp $
+// $Id: UserManager.java,v 1.24 2003/10/14 02:37:53 mdb Exp $
//
// samskivert library - useful routines for java programs
// Copyright (C) 2001 Michael Bayne
@@ -273,6 +273,13 @@ public class UserManager
c.setMaxAge(0);
CookieUtil.widenDomain(req, c);
rsp.addCookie(c);
+
+ // we need an unwidened one to ensure that old-style cookies are
+ // wiped as well
+ c = new Cookie(USERAUTH_COOKIE, "x");
+ c.setPath("/");
+ c.setMaxAge(0);
+ rsp.addCookie(c);
}
/** The user repository. */
|
Blow away both kinds of cookie when logging out. I'm not sure if this will
do anything because these are sort of the same cookie except the domain is
different.
git-svn-id: <URL>
|
diff --git a/tests/CheckMKTagsTest.php b/tests/CheckMKTagsTest.php
index <HASH>..<HASH> 100644
--- a/tests/CheckMKTagsTest.php
+++ b/tests/CheckMKTagsTest.php
@@ -55,7 +55,7 @@ class CheckMKTagsTest extends BaseTest {
$objectID = $this->createServer();
$this->cmdbCategory->create(
$objectID,
- 'C__CATG__CMK_TAG',
+ 'C__CATG__CMK2_TAG',
[
'description' => $this->generateDescription()
]
@@ -123,7 +123,7 @@ class CheckMKTagsTest extends BaseTest {
$this->cmdbCategory->create(
$objectID,
- 'C__CATG__CMK_TAG',
+ 'C__CATG__CMK2_TAG',
[
'description' => $this->generateDescription()
]
|
Re-name constant of category "Check_MK Tags"
|
diff --git a/dvc/repo/unprotect.py b/dvc/repo/unprotect.py
index <HASH>..<HASH> 100644
--- a/dvc/repo/unprotect.py
+++ b/dvc/repo/unprotect.py
@@ -13,13 +13,16 @@ from dvc.exceptions import DvcException
def _unprotect_file(path):
if System.is_symlink(path) or System.is_hardlink(path):
logger.debug("Unprotecting '{}'".format(path))
-
tmp = os.path.join(os.path.dirname(path), "." + str(uuid.uuid4()))
- move(path, tmp)
- copyfile(tmp, path)
+ # The operations order is important here - if some application would
+ # access the file during the process of copyfile then it would get
+ # only the part of file. So, at first, the file should be copied with
+ # the temporary name, and then original file should be replaced by new.
+ copyfile(path, tmp)
+ remove(path)
+ move(tmp, path)
- remove(tmp)
else:
logger.debug(
"Skipping copying for '{}', since it is not "
|
unprotect: copy should preceed the move
It is better to make a file copy before moving it, since move is
a nearly-atomic operation and copy is a long one.
Also the biggest problem here is that if some application would access
the file during the process of `copyfile` then it would get the part of
file.
|
diff --git a/micrometer-core/src/main/java/io/micrometer/core/instrument/binder/cache/GuavaCacheMetrics.java b/micrometer-core/src/main/java/io/micrometer/core/instrument/binder/cache/GuavaCacheMetrics.java
index <HASH>..<HASH> 100644
--- a/micrometer-core/src/main/java/io/micrometer/core/instrument/binder/cache/GuavaCacheMetrics.java
+++ b/micrometer-core/src/main/java/io/micrometer/core/instrument/binder/cache/GuavaCacheMetrics.java
@@ -54,7 +54,7 @@ public class GuavaCacheMetrics implements MeterBinder {
* @see com.google.common.cache.CacheStats
*/
public static <C extends Cache> C monitor(MeterRegistry registry, C cache, String name, Iterable<Tag> tags) {
- new GuavaCacheMetrics(cache, tags, name).bindTo(registry);
+ new GuavaCacheMetrics(cache, name, tags).bindTo(registry);
return cache;
}
@@ -62,7 +62,7 @@ public class GuavaCacheMetrics implements MeterBinder {
private final Iterable<Tag> tags;
private final Cache<?, ?> cache;
- public GuavaCacheMetrics(Cache<?, ?> cache, Iterable<Tag> tags, String name) {
+ public GuavaCacheMetrics(Cache<?, ?> cache, String name, Iterable<Tag> tags) {
this.name = name;
this.tags = tags;
this.cache = cache;
|
Consistent constructor ordering for GuavaCacheMetrics (fixes #<I>)
|
diff --git a/src/sap.m/src/sap/m/FacetFilter.js b/src/sap.m/src/sap/m/FacetFilter.js
index <HASH>..<HASH> 100644
--- a/src/sap.m/src/sap/m/FacetFilter.js
+++ b/src/sap.m/src/sap/m/FacetFilter.js
@@ -1068,14 +1068,14 @@ sap.ui.define(['jquery.sap.global', './NavContainer', './library', 'sap/ui/core/
that._selectedFacetItem.invalidate();
//keyboard acc - focus on the original 1st page item
oToPage.invalidate();
- if (this.getPages().length >= 1 && focusIndex >= 0) {
+/* if (this.getPages().length >= 1) {
var focusIndex = this.getPages()[0].getContent()[0].aDelegates[0].oDelegate.getFocusedIndex();
if (focusIndex >= 0) {
jQuery.sap.delayedCall(100, this, function() {
jQuery.sap.focus(this.getPages()[0].getContent()[0].getItems()[focusIndex]);
});
}
- }
+ } */
that._selectedFacetItem = null;
}
});
|
[FIX] FacetFilter: Modified keyboard interaction
- Modified the keyboard interaction
Change-Id: Ie1d<I>b<I>a<I>bf<I>e<I>b<I>ccebd
|
diff --git a/tests/lib/toolkit/XMLDocumentTest.php b/tests/lib/toolkit/XMLDocumentTest.php
index <HASH>..<HASH> 100644
--- a/tests/lib/toolkit/XMLDocumentTest.php
+++ b/tests/lib/toolkit/XMLDocumentTest.php
@@ -22,6 +22,20 @@ final class XMLDocumentTest extends TestCase
$this->assertEquals('<xml />', $x->generate());
}
+ public function testSetVersion()
+ {
+ $x = (new \XMLDocument('xml'))->setVersion('test')->renderHeader();
+ $this->assertEquals('test', $x->getVersion());
+ $this->assertEquals('<?xml version="test" encoding="utf-8" ?><xml />', $x->generate());
+ }
+
+ public function testSetEncoding()
+ {
+ $x = (new \XMLDocument('xml'))->setEncoding('test')->renderHeader();
+ $this->assertEquals('test', $x->getEncoding());
+ $this->assertEquals('<?xml version="1.0" encoding="test" ?><xml />', $x->generate());
+ }
+
public function testGenerateWithHeader()
{
$x = (new \XMLDocument('xml', 'value'));
|
Add setVersion() and setEncoding() tests
Picked from <I>d<I>cad
Picked from 0c3ce<I>b<I>
|
diff --git a/test/tc_tc.rb b/test/tc_tc.rb
index <HASH>..<HASH> 100644
--- a/test/tc_tc.rb
+++ b/test/tc_tc.rb
@@ -121,6 +121,22 @@ class TestTc < Test::Unit::TestCase
assert_equal(3, @t.t1.length)
end
+ def test_truncate
+ @t.in_buf << ['1', '2', '3', '4']
+ @t.in_buf << ['1', '3', '3', '4']
+ assert_nothing_raised(RuntimeError) {@t.tick}
+ assert_equal(2, @t.t1.length)
+
+ @t.close_tables
+ @t = make_bud(true)
+
+ assert_equal(0, @t.t1.length)
+ @t.in_buf << ['1', '2', '3', '4']
+ @t.in_buf << ['1', '3', '3', '4']
+ assert_nothing_raised(RuntimeError) {@t.tick}
+ assert_equal(2, @t.t1.length)
+ end
+
def test_persist
@t.in_buf << [1, 2, 3, 4]
@t.in_buf << [5, 10, 3, 4]
|
Add a test case for tc_truncate behavior in tctables.
|
diff --git a/project/library/CM/Bootloader.php b/project/library/CM/Bootloader.php
index <HASH>..<HASH> 100644
--- a/project/library/CM/Bootloader.php
+++ b/project/library/CM/Bootloader.php
@@ -7,10 +7,6 @@ class CM_Bootloader {
mb_internal_encoding('UTF-8');
}
- public function session() {
- CM_Session::getInstance();
- }
-
public function autoloader() {
spl_autoload_register(function($className) {
$path = DIR_ROOT . 'library/' . str_replace('_', '/', $className) . '.php';
|
Session refactoring; replaced calls to CM_Session::getInstance with CM_Request::getSession where possible; removed usages of $_SESSION
|
diff --git a/tests/Composer/Test/Command/DiagnoseCommandTest.php b/tests/Composer/Test/Command/DiagnoseCommandTest.php
index <HASH>..<HASH> 100644
--- a/tests/Composer/Test/Command/DiagnoseCommandTest.php
+++ b/tests/Composer/Test/Command/DiagnoseCommandTest.php
@@ -32,8 +32,7 @@ class DiagnoseCommandTest extends TestCase
$this->assertStringContainsString('Checking git settings: OK
Checking http connectivity to packagist: OK
Checking https connectivity to packagist: OK
-Checking github.com rate limit: OK
-Checking disk free space: ', $output);
+Checking github.com rate limit: ', $output);
}
public function testCmdSuccess(): void
@@ -51,7 +50,6 @@ Checking disk free space: ', $output);
$this->assertStringContainsString('Checking git settings: OK
Checking http connectivity to packagist: OK
Checking https connectivity to packagist: OK
-Checking github.com rate limit: OK
-Checking disk free space: ', $output);
+Checking github.com rate limit: ', $output);
}
}
|
Do not verify rate limit OK as part of test as these might randomly fail
|
diff --git a/src/Traits/SluggableModelTrait.php b/src/Traits/SluggableModelTrait.php
index <HASH>..<HASH> 100644
--- a/src/Traits/SluggableModelTrait.php
+++ b/src/Traits/SluggableModelTrait.php
@@ -25,7 +25,7 @@ trait SluggableModelTrait
{
$value = preg_replace('/[^a-zA-Z0-9\-\_]+/', '-', $value);
- return strtolower($value);
+ return str_replace(['--', '__'], ['-', '_'], trim(strtolower($value), '-_'));
}
/**
|
Fix trailing and leading hyphens. Fix double hyphens and dashes.
|
diff --git a/lib/add-cli-config-to-app.js b/lib/add-cli-config-to-app.js
index <HASH>..<HASH> 100644
--- a/lib/add-cli-config-to-app.js
+++ b/lib/add-cli-config-to-app.js
@@ -1,7 +1,7 @@
var path = require('path');
var fs = require('fs');
var rc = require('rc');
-var userHome = process.env.HOME || process.env.HOMEPATH || process.env.USERPROFILE;
+var userHome = (process.platform === "win32" ? process.env.USERPROFILE : process.env.HOME );
var configFilePath = path.join(userHome, '.sqlpadrc');
module.exports = function (app) {
|
get user home path like rc
|
diff --git a/src/Security/Group.php b/src/Security/Group.php
index <HASH>..<HASH> 100755
--- a/src/Security/Group.php
+++ b/src/Security/Group.php
@@ -111,7 +111,7 @@ class Group extends DataObject
$list = Group::get()->exclude('ID', $this->ID);
$groups = ArrayList::create();
foreach ($list as $group) {
- $groups->push(['ID' => $group->ID, 'Title' => Convert::xml2raw($group->Breadcrumbs)]);
+ $groups->push(['ID' => $group->ID, 'Title' => $group->getBreadcrumbs(' » ')]);
}
return $groups;
}
|
Update src/Security/Group.php
|
diff --git a/go/kbfs/libfs/profilelist.go b/go/kbfs/libfs/profilelist.go
index <HASH>..<HASH> 100644
--- a/go/kbfs/libfs/profilelist.go
+++ b/go/kbfs/libfs/profilelist.go
@@ -179,10 +179,10 @@ func (pfs ProfileFS) openTimedProfile(
// TODO: Blocking here until the profile is done is
// weird. Blocking on read is better.
//
- // TODO: Maybe keep around a special last_profile file to be
- // able to start capturing a profile and then interrupt when
- // done, which would also be useful in general, since you be
- // able to save a profile even if you open it up with a tool.
+ // TODO: Maybe keep around a special last_profile file to be able
+ // to start capturing a profile and then interrupt when done,
+ // which would also be useful in general, since you'd be able to
+ // save a profile even if you open it up with a tool.
var buf bytes.Buffer
err = prof.Start(&buf)
if err != nil {
|
libfs: fix profilelist comment typo
Suggested by songgao.
Issue: #<I>
|
diff --git a/lib/disney/index.js b/lib/disney/index.js
index <HASH>..<HASH> 100644
--- a/lib/disney/index.js
+++ b/lib/disney/index.js
@@ -179,7 +179,7 @@ class WaltDisneyWorldPark extends Park {
rideObject.WaitTime = ride.waitTime.postedWaitMinutes || -1;
// set fastpass status
- rideObject.FastPass = (ride.fastpass && ride.fastpass.available) ? true : false;
+ rideObject.FastPass = (ride.waitTime && ride.waitTime.fastpass && ride.waitTime.fastpass.available) ? true : false;
}
// run get operating times to inject ride times into this data
|
Fix Disney fastpass is nested in the waitTimes object
|
diff --git a/code/model/Blog.php b/code/model/Blog.php
index <HASH>..<HASH> 100644
--- a/code/model/Blog.php
+++ b/code/model/Blog.php
@@ -962,7 +962,7 @@ class Blog_Controller extends Page_Controller {
*/
$dataRecord = $this->dataRecord;
- $posts = new PaginatedList($this->blogPosts);
+ $posts = new PaginatedList($this->getBlogPosts());
if($this->PostsPerPage > 0) {
$posts->setPageLength($this->PostsPerPage);
|
Bugfix: avoid feeding null to PaginatedList constructor
|
diff --git a/web/concrete/core/models/attribute/types/select.php b/web/concrete/core/models/attribute/types/select.php
index <HASH>..<HASH> 100644
--- a/web/concrete/core/models/attribute/types/select.php
+++ b/web/concrete/core/models/attribute/types/select.php
@@ -2,9 +2,9 @@
class Concrete5_Controller_AttributeType_Select extends AttributeTypeController {
- protected $akSelectAllowMultipleValues;
- protected $akSelectAllowOtherValues;
- protected $akSelectOptionDisplayOrder;
+ private $akSelectAllowMultipleValues;
+ private $akSelectAllowOtherValues;
+ private $akSelectOptionDisplayOrder;
protected $searchIndexFieldDefinition = 'X NULL';
|
Revert Protected Properties in Select Attribute
Revert protected properties in `SelectAttributeTypeController`
Causes issues with code in the wild that attempts to carry over private
properties
Former-commit-id: bdefa9eb<I>ff<I>f3f<I>b9ea<I>ec0c<I>c<I>c
|
diff --git a/PhpAmqpLib/Connection/AMQPSSLConnection.php b/PhpAmqpLib/Connection/AMQPSSLConnection.php
index <HASH>..<HASH> 100644
--- a/PhpAmqpLib/Connection/AMQPSSLConnection.php
+++ b/PhpAmqpLib/Connection/AMQPSSLConnection.php
@@ -23,9 +23,6 @@ class AMQPSSLConnection extends AMQPStreamConnection
$options = array(),
$ssl_protocol = 'ssl'
) {
- if (!isset($ssl_options['SNI_enabled'])) {
- $ssl_options['SNI_enabled'] = true;
- }
$ssl_context = empty($ssl_options) ? null : $this->create_ssl_context($ssl_options);
parent::__construct(
$host,
|
revert #<I> 'Enable TLS SNI by default'
|
diff --git a/plugins/inputs/kafka_consumer/kafka_consumer_integration_test.go b/plugins/inputs/kafka_consumer/kafka_consumer_integration_test.go
index <HASH>..<HASH> 100644
--- a/plugins/inputs/kafka_consumer/kafka_consumer_integration_test.go
+++ b/plugins/inputs/kafka_consumer/kafka_consumer_integration_test.go
@@ -17,6 +17,7 @@ func TestReadsMetricsFromKafka(t *testing.T) {
if testing.Short() {
t.Skip("Skipping integration test in short mode")
}
+ t.Skip("Skipping test due to circleci issue; ref #2487")
brokerPeers := []string{testutil.GetLocalHost() + ":9092"}
testTopic := fmt.Sprintf("telegraf_test_topic_%d", time.Now().Unix())
|
Skip kafka_consumer_integration_test due to issue on CircleCI
|
diff --git a/store.go b/store.go
index <HASH>..<HASH> 100644
--- a/store.go
+++ b/store.go
@@ -129,10 +129,10 @@ func buildPlatformPath(path string) string {
if xdg := os.Getenv("XDG_CONFIG_HOME"); xdg != "" {
unixConfigDir = xdg
} else {
- unixConfigDir = os.Getenv("HOME")
+ unixConfigDir = os.Getenv("HOME") + "/.config"
}
- return fmt.Sprintf("%s/.config/%s/%s", unixConfigDir,
+ return fmt.Sprintf("%s/%s/%s", unixConfigDir,
applicationName,
path)
}
|
Fixing a prefix typo from previous commit
|
diff --git a/lib/mite-rb.rb b/lib/mite-rb.rb
index <HASH>..<HASH> 100644
--- a/lib/mite-rb.rb
+++ b/lib/mite-rb.rb
@@ -1,5 +1,6 @@
require 'active_support'
require 'active_resource'
+require 'mite/version.rb'
# The official ruby library for interacting with the RESTful API of mite,
# a sleek time tracking webapp.
|
Fixed version issue (Issue #1)
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.