diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/pavement.py b/pavement.py index <HASH>..<HASH> 100644 --- a/pavement.py +++ b/pavement.py @@ -38,7 +38,8 @@ def sdist(): @task def clean(): - for p in map(path, ('greenhouse.egg-info', 'dist', 'build', 'MANIFEST.in')): + for p in map(path, ( + 'greenhouse.egg-info', 'dist', 'build', 'MANIFEST.in', 'docs/build')): if p.exists(): if p.isdir(): p.rmtree()
purge docs builds on 'clean' command
diff --git a/lib/plucky/query.rb b/lib/plucky/query.rb index <HASH>..<HASH> 100644 --- a/lib/plucky/query.rb +++ b/lib/plucky/query.rb @@ -63,7 +63,7 @@ module Plucky end def reverse - self[:sort].map! { |s| [s[0], -s[1]] } + self[:sort].map! { |s| [s[0], -s[1]] } unless self[:sort].nil? self end diff --git a/test/plucky/test_query.rb b/test/plucky/test_query.rb index <HASH>..<HASH> 100644 --- a/test/plucky/test_query.rb +++ b/test/plucky/test_query.rb @@ -230,6 +230,12 @@ class QueryTest < Test::Unit::TestCase Query.new(@collection).sort(:age).reverse.all.should == [@steve, @john, @chris] end + should "not error if no sort provided" do + assert_nothing_raised do + Query.new(@collection).reverse + end + end + should "reverse the sort order" do query = Query.new(@collection, :order => 'foo asc, bar desc') query.reverse.options[:sort].should == [['foo', -1], ['bar', 1]]
Do nothing if no sort provided.
diff --git a/code/model/jobs/DNDataTransfer.php b/code/model/jobs/DNDataTransfer.php index <HASH>..<HASH> 100644 --- a/code/model/jobs/DNDataTransfer.php +++ b/code/model/jobs/DNDataTransfer.php @@ -79,9 +79,10 @@ class DNDataTransfer extends DataObject { if($this->AuthorID) { $author = $this->Author(); $message = sprintf( - 'Initiated by %s (%s)', + 'Initiated by %s (%s), with IP Address %s', $author->getName(), - $author->Email + $author->Email, + Controller::curr()->getRequest()->getIP() ); $log->write($message); }
Add IP address into transfer log (completed HUMP-<I>)
diff --git a/src/Drupal/Driver/Cores/Drupal7.php b/src/Drupal/Driver/Cores/Drupal7.php index <HASH>..<HASH> 100644 --- a/src/Drupal/Driver/Cores/Drupal7.php +++ b/src/Drupal/Driver/Cores/Drupal7.php @@ -18,6 +18,7 @@ class Drupal7 implements CoreInterface { public function __construct($drupalRoot, $uri = 'default') { $this->drupalRoot = realpath($drupalRoot); $this->uri = $uri; + $this->random = new Random(); } /** @@ -196,7 +197,7 @@ class Drupal7 implements CoreInterface { // Create new role. $role = new \stdClass(); - $role->name = Random::name(8); + $role->name = $this->random->name(8); user_role_save($role); user_role_grant_permissions($role->rid, $permissions);
Updating D7 driver for core's random generator.
diff --git a/lib/platform/bitbucket-server/index.js b/lib/platform/bitbucket-server/index.js index <HASH>..<HASH> 100644 --- a/lib/platform/bitbucket-server/index.js +++ b/lib/platform/bitbucket-server/index.js @@ -257,11 +257,13 @@ async function deleteBranch(branchName, closePr = false) { if (closePr) { // getBranchPr const pr = await getBranchPr(branchName); - await api.post( - `/rest/api/1.0/projects/${config.projectKey}/repos/${ - config.repositorySlug - }/pull-requests/${pr.number}/decline?version=${pr.version + 1}` - ); + if (pr) { + await api.post( + `/rest/api/1.0/projects/${config.projectKey}/repos/${ + config.repositorySlug + }/pull-requests/${pr.number}/decline?version=${pr.version + 1}` + ); + } } return config.storage.deleteBranch(branchName); }
fix(bitbucket-server): pr check after deleting branch Closes #<I>
diff --git a/actionpack/test/controller/new_base/metal_test.rb b/actionpack/test/controller/new_base/metal_test.rb index <HASH>..<HASH> 100644 --- a/actionpack/test/controller/new_base/metal_test.rb +++ b/actionpack/test/controller/new_base/metal_test.rb @@ -20,8 +20,8 @@ module MetalTest class TestMiddleware < ActiveSupport::TestCase def setup @app = Rack::Builder.new do - use MetalMiddleware - run Endpoint.new + use MetalTest::MetalMiddleware + run MetalTest::Endpoint.new end.to_app end
Update MetalTest for constant scoping change in <I>
diff --git a/src/transformers/tokenization_xlnet.py b/src/transformers/tokenization_xlnet.py index <HASH>..<HASH> 100644 --- a/src/transformers/tokenization_xlnet.py +++ b/src/transformers/tokenization_xlnet.py @@ -240,7 +240,7 @@ class XLNetTokenizer(PreTrainedTokenizer): cls_segment_id = [2] if token_ids_1 is None: - return len(token_ids_0 + sep + cls) * [0] + return len(token_ids_0 + sep) * [0] + cls_segment_id return len(token_ids_0 + sep) * [0] + len(token_ids_1 + sep) * [1] + cls_segment_id def save_vocabulary(self, save_directory):
Correct segment ID for XLNet single sequence
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -8,7 +8,7 @@ REQUIRES = ["PyYAML"] PKG_ROOT = os.path.dirname(__file__) -VERSION = "0.2.16" +VERSION = "0.2.17" def get_long_description():
Bumped version in setup.py
diff --git a/src/BoomCMS/Core/Console/Commands/InstallTemplates.php b/src/BoomCMS/Core/Console/Commands/InstallTemplates.php index <HASH>..<HASH> 100644 --- a/src/BoomCMS/Core/Console/Commands/InstallTemplates.php +++ b/src/BoomCMS/Core/Console/Commands/InstallTemplates.php @@ -51,9 +51,10 @@ class InstallTemplates extends Command $this->info("Installed $template in theme $theme"); } + + $this->call('vendor:publish', ['--force']); } else { $this->info('No templates to install'); } - $this->call('vendor:publish', ['--force']); } }
Updated install templates artisan command to only call vendor:publish if templates have been installed
diff --git a/clc/client.go b/clc/client.go index <HASH>..<HASH> 100644 --- a/clc/client.go +++ b/clc/client.go @@ -3,6 +3,7 @@ package clc import ( "bytes" "encoding/json" + "errors" "fmt" "io" "io/ioutil" @@ -80,6 +81,11 @@ func (c *Client) do(method, url string, body io.Reader, resp interface{}) error if err != nil { return err } + + if res.StatusCode >= 300 { + return errors.New(fmt.Sprintf("http error: %s", res.Status)) + } + return json.NewDecoder(res.Body).Decode(resp) }
evaluate server response for non-success error codes
diff --git a/library/BrowserDetector/BrowserDetector.php b/library/BrowserDetector/BrowserDetector.php index <HASH>..<HASH> 100644 --- a/library/BrowserDetector/BrowserDetector.php +++ b/library/BrowserDetector/BrowserDetector.php @@ -274,7 +274,7 @@ class BrowserDetector ); } - $cacheId = $this->cachePrefix . $this->agent; + $cacheId = $this->cachePrefix . $this->agent;//hash('sha512', $this->cachePrefix . $this->agent); $result = null; $success = false; diff --git a/library/BrowserDetector/Input/Browscap.php b/library/BrowserDetector/Input/Browscap.php index <HASH>..<HASH> 100644 --- a/library/BrowserDetector/Input/Browscap.php +++ b/library/BrowserDetector/Input/Browscap.php @@ -121,10 +121,13 @@ class Browscap extends Core } $this->parser->setCache($this->cache) - ->setLocaleFile($this->localFile) ->setCachePrefix($this->cachePrefix) ; + if (null !== $this->localFile) { + $this->parser->setLocaleFile($this->localFile); + } + if (null !== $this->logger) { $this->setLogger($this->logger); }
fixed error when localfile is not set for Browscap input
diff --git a/lib/SendGrid.php b/lib/SendGrid.php index <HASH>..<HASH> 100644 --- a/lib/SendGrid.php +++ b/lib/SendGrid.php @@ -33,7 +33,7 @@ class SendGrid { $form['api_user'] = $this->api_user; $form['api_key'] = $this->api_key; - $response = $this->makeRequest($form); + $response = $this->makeRequest(http_build_query($form)); return $response; }
Fix limitations which do not allow to send email with multiple bcc This request would help you to fix a nasty bug - limitations which do not allow to send email with multiple bcc. When we add multiple bcc, we get a multidimensional array and an error : [php] Array to string conversion in: vendor/sendgrid/sendgrid/lib/SendGrid.php:<I>
diff --git a/src/helpers/ModelSort.php b/src/helpers/ModelSort.php index <HASH>..<HASH> 100644 --- a/src/helpers/ModelSort.php +++ b/src/helpers/ModelSort.php @@ -13,7 +13,7 @@ class ModelSort { public static function byType(): \Closure { - $order = ['CHASSIS', 'MOTHERBOARD', 'CPU', 'RAM', 'HDD', 'SSD']; + $order = ['SERVER', 'CHASSIS', 'MOTHERBOARD', 'CPU', 'RAM', 'HDD', 'SSD']; return function (Model $model) use ($order) { $type = mb_strtoupper($model->type);
Enhanced hardware sorters: SERVER should be first
diff --git a/main.go b/main.go index <HASH>..<HASH> 100644 --- a/main.go +++ b/main.go @@ -33,6 +33,7 @@ func main() { defer close(threadDumpChan) go dumpGoRoutine(threadDumpChan) + log.Printf("Targeting datadog API URL: %s \n", config.DataDogURL) datadog_nozzle := datadogfirehosenozzle.NewDatadogFirehoseNozzle(config, tokenFetcher) datadog_nozzle.Start() }
Logs API url on the start up [#<I>]
diff --git a/js/theocean.js b/js/theocean.js index <HASH>..<HASH> 100644 --- a/js/theocean.js +++ b/js/theocean.js @@ -170,7 +170,7 @@ module.exports = class theocean extends Exchange { parseOHLCV (ohlcv, market = undefined, timeframe = '5m', since = undefined, limit = undefined) { const baseDecimals = this.safeInteger (this.options['decimals'], market['base'], 18); return [ - this.safeInteger (ohlcv, 'startTime') * 1000, + this.safeTimestamp (ohlcv, 'startTime'), this.safeFloat (ohlcv, 'open'), this.safeFloat (ohlcv, 'high'), this.safeFloat (ohlcv, 'low'),
theocean safeTimestamp
diff --git a/src/Types/PaymentMethod.php b/src/Types/PaymentMethod.php index <HASH>..<HASH> 100644 --- a/src/Types/PaymentMethod.php +++ b/src/Types/PaymentMethod.php @@ -44,7 +44,7 @@ class PaymentMethod const EPS = "eps"; /** - * Gift cards + * @link https://www.mollie.com/gift-cards */ const GIFTCARD = "giftcard"; @@ -80,7 +80,7 @@ class PaymentMethod /** * @deprecated - * @link https://www.mollie.com/giftcards + * @link https://www.mollie.com/gift-cards */ const PODIUMCADEAUKAART = "podiumcadeaukaart";
Fix error in giftcards payment link, and added it to podiumcadeaukaart constant.
diff --git a/src/v2/tasks/shell.js b/src/v2/tasks/shell.js index <HASH>..<HASH> 100644 --- a/src/v2/tasks/shell.js +++ b/src/v2/tasks/shell.js @@ -34,6 +34,7 @@ module.exports = (state) => new Promise((resolve, reject) => { const options = _.reduce(ACCEPTED_OPTIONS, (result, value) => _.set(result, value, state.get(value)), {}); state.logger.info(`Executing: ${state.get('command')}`); options.env = reduceEnvArrayToObject(options.env); + options.env['PYTHONIOENCODING'] = 'utf-8'; // Filthy hack to satistfy python environments which lose encoding when piping output const child = exec(state.get('command'), options, (err, stdout) => { if (err) {
Forcing python encoding when execing tasks
diff --git a/combine/checks/open_graph.py b/combine/checks/open_graph.py index <HASH>..<HASH> 100644 --- a/combine/checks/open_graph.py +++ b/combine/checks/open_graph.py @@ -69,7 +69,10 @@ class OpenGraphURLCheck(BaseOpenGraphCheck): # ) # ) - if not url.startswith("https://"): + # TODO figure out better solution for local -- want to catch those if building production + if not url.startswith("https://") and not url.startswith( + "http://127.0.0.1" + ): issues.append( Issue( type="open-graph-url-not-canonical-https", @@ -102,7 +105,10 @@ class OpenGraphImageCheck(BaseOpenGraphCheck): # ) # ) - if not url.startswith("https://"): + # TODO figure out better solution for local -- want to catch those if building production + if not url.startswith("https://") and not url.startswith( + "http://127.0.0.1" + ): issues.append( Issue( type="open-graph-image-not-canonical-https", diff --git a/combine/core.py b/combine/core.py index <HASH>..<HASH> 100644 --- a/combine/core.py +++ b/combine/core.py @@ -123,8 +123,6 @@ class Combine: for issue in FaviconCheck(site_dir=self.output_path).run(): self.issues.append(issue) - # broken links? - if self.issues: self.issues.print(f"Issues across your site")
Allow og:url and og:image to be http://<I> for now
diff --git a/framework/widgets/BaseListView.php b/framework/widgets/BaseListView.php index <HASH>..<HASH> 100644 --- a/framework/widgets/BaseListView.php +++ b/framework/widgets/BaseListView.php @@ -40,14 +40,14 @@ abstract class BaseListView extends Widget * @var array the configuration for the pager widget. By default, [[LinkPager]] will be * used to render the pager. You can use a different widget class by configuring the "class" element. * Note that the widget must support the `pagination` property which will be populated with the - * [[\yii\data\BaseDataProvider::pagination|pagination]] value of the [[dataProvider]]. + * [[\yii\data\BaseDataProvider::pagination|pagination]] value of the [[dataProvider]] and will overwrite this value. */ public $pager = []; /** * @var array the configuration for the sorter widget. By default, [[LinkSorter]] will be * used to render the sorter. You can use a different widget class by configuring the "class" element. * Note that the widget must support the `sort` property which will be populated with the - * [[\yii\data\BaseDataProvider::sort|sort]] value of the [[dataProvider]]. + * [[\yii\data\BaseDataProvider::sort|sort]] value of the [[dataProvider]] and will overwrite this value. */ public $sorter = []; /**
Fixes #<I>: Added note clarifying config for ListView pager and sorter [skip ci]
diff --git a/emma2/msm/analysis/api.py b/emma2/msm/analysis/api.py index <HASH>..<HASH> 100644 --- a/emma2/msm/analysis/api.py +++ b/emma2/msm/analysis/api.py @@ -651,6 +651,7 @@ def mfpt(T, target): 0 & x=y \\ 1+\sum_{z} T_{x,z} \mathbb{E}_z[T_y] & x \neq y \end{array} \right. + References ---------- .. [1] Hoel, P G and S C Port and C J Stone. 1972. Introduction to
[msm/analysis] Added blank line
diff --git a/docs/conf.py b/docs/conf.py index <HASH>..<HASH> 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -18,7 +18,7 @@ import os html_context = { 'version' : '3.1', 'full_version' : '3.1.9', - 'maven_plugin_version' : '3.1.8', + 'maven_plugin_version' : '3.1.9', 'gradle_plugin_version' : '1.6.5', 'archetype_version' : '0.2.2' }
bump up maven plugin version to the latest
diff --git a/admin/tests/LeftAndMainTest.php b/admin/tests/LeftAndMainTest.php index <HASH>..<HASH> 100644 --- a/admin/tests/LeftAndMainTest.php +++ b/admin/tests/LeftAndMainTest.php @@ -24,7 +24,7 @@ class LeftAndMainTest extends FunctionalTest { public function testSaveTreeNodeSorting() { $this->loginWithPermission('ADMIN'); - $rootPages = DataObject::get('LeftAndMainTest_Object', '"ParentID" = 0'); // implicitly sorted + $rootPages = DataObject::get('LeftAndMainTest_Object', '"ParentID" = 0', '"ID"'); // forcing sorting for non-MySQL $siblingIDs = $rootPages->column('ID'); $page1 = $rootPages->offsetGet(0); $page2 = $rootPages->offsetGet(1); @@ -197,4 +197,4 @@ class LeftAndMainTest_Object extends DataObject implements TestOnly { 'Hierarchy' ); -} \ No newline at end of file +}
When relying on the order of returned objects, sort explicitly as it is nondeterminate for non-MySQL.
diff --git a/src/utils/elasticDSL.js b/src/utils/elasticDSL.js index <HASH>..<HASH> 100644 --- a/src/utils/elasticDSL.js +++ b/src/utils/elasticDSL.js @@ -43,12 +43,10 @@ let simplifyBucket = _.flow( _.mapValues(flattenMetrics), _.mapKeys(renameMetrics) ) - let simplifyBuckets = _.flow( F.when(_.isPlainObject, F.unkeyBy('key')), _.map(simplifyBucket) ) - // VERY hacky and inefficient tree simpification // inefficient due to copying the entire tree to flatten, again to unflatten, and running regex replaces on EVERY key // This will be superseeded by a transmuteTree version later :) @@ -79,10 +77,15 @@ let basicSimplifyTree = _.flow( ), // Rename __DOT__ to '.' tree => { - F.walk()(x => { + F.walk()((x, index) => { let dots = _.filter(_.includes('__DOT__'), _.keys(x)) _.each(dot => renameOn(dot, _.replace(/__DOT__/g, '.', dot), x), dots) + + if (index === 'rows' || index === 'columns') { + tree['results'][index] = simplifyBuckets(x) + } })(tree) + console.log(JSON.stringify(tree, null, 2)) return tree } )
fix: simplify buckets on rows and columns
diff --git a/lib/octokit/client.rb b/lib/octokit/client.rb index <HASH>..<HASH> 100644 --- a/lib/octokit/client.rb +++ b/lib/octokit/client.rb @@ -19,7 +19,7 @@ require 'octokit/client/users' module Octokit class Client - attr_accessor *Configuration::VALID_OPTIONS_KEYS + attr_accessor(*Configuration::VALID_OPTIONS_KEYS) def initialize(options={}) options = Octokit.options.merge(options) diff --git a/lib/octokit/configuration.rb b/lib/octokit/configuration.rb index <HASH>..<HASH> 100644 --- a/lib/octokit/configuration.rb +++ b/lib/octokit/configuration.rb @@ -22,7 +22,7 @@ module Octokit DEFAULT_OAUTH_TOKEN = nil DEFAULT_USER_AGENT = "Octokit Ruby Gem #{Octokit::VERSION}".freeze - attr_accessor *VALID_OPTIONS_KEYS + attr_accessor(*VALID_OPTIONS_KEYS) def self.extended(base) base.reset
Avoid the following ruby warnings: .../lib/octokit/configuration.rb:<I>: warning: `*' interpreted as argument prefix .../lib/octokit/client.rb:<I>: warning: `*' interpreted as argument prefix (by helping out the ruby interpreter with some parentheses)
diff --git a/css-components/gulpfile.js b/css-components/gulpfile.js index <HASH>..<HASH> 100644 --- a/css-components/gulpfile.js +++ b/css-components/gulpfile.js @@ -80,7 +80,7 @@ function cssnext() { root: __dirname + '/src/components/' }), cssnextPlugin({ - browsers: babelrc.presets[0][1].targets.browsers, + browsers: corePkg.browserslist, }), reporter({ clearAllMessages: true,
chore(css-components): Fix serve command by using browserslist
diff --git a/cosmic_ray/version.py b/cosmic_ray/version.py index <HASH>..<HASH> 100644 --- a/cosmic_ray/version.py +++ b/cosmic_ray/version.py @@ -1,4 +1,4 @@ """Cosmic Ray version info.""" -__version_info__ = (3, 1, 1) +__version_info__ = (3, 1, 2) __version__ = '.'.join(map(str, __version_info__))
Bumped patch version to initiate new release.
diff --git a/lib/filestorage/local.rb b/lib/filestorage/local.rb index <HASH>..<HASH> 100644 --- a/lib/filestorage/local.rb +++ b/lib/filestorage/local.rb @@ -37,10 +37,11 @@ module Filestorage File.open(fullpath, "rb") end - def delete(path) + def delete(path, delete_dir: false) fullpath = @base_dir + path raise NotExist.new("Not exist #{path}") unless File.exist?(fullpath) FileUtils.rm(fullpath) + sweep(fullpath.parent) if delete_dir path end @@ -58,6 +59,23 @@ module Filestorage files end + private + + def sweep(path) + paths(path).reverse.each do |p| + FileUtils.rmdir(p) if p.children.empty? + end + end + + def paths(path) + p = [] + until path.to_s == @base_dir.to_s + p << path + path = path.parent + end + p.reverse + end + end # of class Local end # of module LocalFilestorage
lib/filestorage/local.rb: Add keyword option 'delete_dir' to Local#delete.
diff --git a/src/SensiolabHelper.php b/src/SensiolabHelper.php index <HASH>..<HASH> 100644 --- a/src/SensiolabHelper.php +++ b/src/SensiolabHelper.php @@ -80,7 +80,7 @@ class SensiolabHelper $colorTag = $this->getColorTagForStatusCode($e->getResponse()->getStatusCode()); $this->command->line("HTTP StatusCode: <{$colorTag}>" . $e->getResponse()->getStatusCode() . "<{$colorTag}>"); $resp = $e->getResponse(); - if ($resp != null) { + if ($resp !== null) { $this->printMessage($resp); } $this->printMessage($e->getRequest()); @@ -91,7 +91,7 @@ class SensiolabHelper $colorTag = $this->getColorTagForStatusCode($e->getResponse()->getStatusCode()); $this->command->line("HTTP StatusCode: <{$colorTag}>" . $e->getResponse()->getStatusCode() . "<{$colorTag}>"); $resp = $e->getResponse(); - if ($resp != null) { + if ($resp !== null) { $this->printMessage($resp); } }
insight.sensiolabs.com
diff --git a/www/tests/test_file.py b/www/tests/test_file.py index <HASH>..<HASH> 100644 --- a/www/tests/test_file.py +++ b/www/tests/test_file.py @@ -16,7 +16,7 @@ with open('compression/du cote de chez swann.txt', 'r') as f: counter = 0 for line in f: counter += 1 - assert counter == 2118 + assert counter in [2117, 2118] # last LF might be removed try: with open('files/text-latin1.txt') as f:
In test_file.py, change test on number of lines read on text mode. Related to issue #<I>.
diff --git a/src/Modus/FrontController/Http.php b/src/Modus/FrontController/Http.php index <HASH>..<HASH> 100644 --- a/src/Modus/FrontController/Http.php +++ b/src/Modus/FrontController/Http.php @@ -44,20 +44,11 @@ class Http { } protected function _configureAutoloaders() { - return; $config = $this->_config; - if($config['composer']['use_composer']) { - require_once $config['composer']['composer_autoloader']; - } - $autoloaders = $config['autoloaders']; - if(count($autoloaders) > 0) { - require_once 'Modus/Autoloader/Base.php'; - } foreach($autoloaders as $file => $class) { - require_once($file); new $class(); } } @@ -149,6 +140,7 @@ class Http { protected function _setupConfig($config) { $this->_config = $config; foreach($config['directories'] as $directory) { + var_dump($directory); if(realpath($directory)) { set_include_path(get_include_path() . ":$directory"); }
Initiate autoloaders correctly so that they correctly handle. Also, figure out what path is being echoed.
diff --git a/client/lib/media/list-store.js b/client/lib/media/list-store.js index <HASH>..<HASH> 100644 --- a/client/lib/media/list-store.js +++ b/client/lib/media/list-store.js @@ -134,7 +134,7 @@ MediaListStore.isItemMatchingQuery = function( siteId, item ) { matches = true; - if ( query.search ) { + if ( query.search && ! query.source ) { // WP_Query tests a post's title and content when performing a search. // Since we're testing binary data, we match the title only. //
Don’t filter external media searches by filename External media searches occur across data other than the filename. For example, Google Photos analyzes the content of the photo and matches on that. This allows the API endpoint to determine if an item matches
diff --git a/lib/ooor/connection_handler.rb b/lib/ooor/connection_handler.rb index <HASH>..<HASH> 100644 --- a/lib/ooor/connection_handler.rb +++ b/lib/ooor/connection_handler.rb @@ -1,9 +1,10 @@ +require 'active_support/core_ext/hash/indifferent_access' require 'ooor/connection' module Ooor class ConnectionHandler def connection_spec(config) - config.slice(:url, :user_id, :password, :database, :scope_prefix) + HashWithIndifferentAccess.new(config.slice(:url, :user_id, :password, :database, :scope_prefix)) end # meant to be overriden for Omniauth, Devise...
fixed a bug with connection_spec and connections not being properly reused
diff --git a/wallace/command_line.py b/wallace/command_line.py index <HASH>..<HASH> 100755 --- a/wallace/command_line.py +++ b/wallace/command_line.py @@ -105,7 +105,7 @@ def setup_experiment(debug=True, verbose=False, app=None): # Check that the version of Wallace specified in the config file is the one # that we are currently running. wallace_version = config.get('Experiment Configuration', 'wallace_version') - this_version = pkg_resources.require("wallace")[0].version + this_version = pkg_resources.require("wallace-platform")[0].version if wallace_version != this_version: raise AssertionError( "You are using Wallace v" + this_version + ", "
Use correct package name (#<I>)
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -85,7 +85,7 @@ var _startListening = function($done) { if (err || WWW._handle) // _handle means server is already listening return $done(err); - WWW.listen(CONF.port_www, function(err) { + WWW.listen(CONF.port_www, CONF.hostname_www, function(err) { if (!err) { var msg = 'Admin UI on port ' + CONF.port_www __running.listen = true
Teach deetoo to read hostname from config
diff --git a/emma2/msm/estimation/__init__.py b/emma2/msm/estimation/__init__.py index <HASH>..<HASH> 100644 --- a/emma2/msm/estimation/__init__.py +++ b/emma2/msm/estimation/__init__.py @@ -22,7 +22,7 @@ Connectivity connected_sets - Find connected subsets largest_connected_set - Find largest connected set - connected_count_matrix - Count matrix on largest connected set + largest_connected_submatrix - Count matrix on largest connected set is_connected - Test count matrix connectivity Estimation
[doc] adopted method refactoring: connected_count_matrix -> largest_connected_submatrix
diff --git a/merb-gen/app_generators/merb/templates/autotest/merb_rspec.rb b/merb-gen/app_generators/merb/templates/autotest/merb_rspec.rb index <HASH>..<HASH> 100644 --- a/merb-gen/app_generators/merb/templates/autotest/merb_rspec.rb +++ b/merb-gen/app_generators/merb/templates/autotest/merb_rspec.rb @@ -45,7 +45,7 @@ class Autotest::MerbRspec < Autotest # Any change to global_helpers will result in all view and controller # tests being run add_mapping %r%^app/helpers/global_helpers\.rb% do - files_matching %r%^spec/(views|controllers)/.*_spec\.rb$% + files_matching %r%^spec/(views|controllers|helpers)/.*_spec\.rb$% end # Any change to a helper will cause its spec to be run
changes to the global_helpers should run every helper spec too
diff --git a/appliance/redis/cmd/flynn-redis/main_test.go b/appliance/redis/cmd/flynn-redis/main_test.go index <HASH>..<HASH> 100644 --- a/appliance/redis/cmd/flynn-redis/main_test.go +++ b/appliance/redis/cmd/flynn-redis/main_test.go @@ -41,6 +41,9 @@ func TestMain_Discoverd(t *testing.T) { return hb, nil } + // set a password + m.Process.Password = "test" + // Execute program. if err := m.Run(); err != nil { t.Fatal(err)
appliance/redis: Set a password in TestMain_Discoverd CI runs an old version of Redis which seems to handle empty passwords differently than newer versions (e.g. the version used in vagrant)
diff --git a/examples/basic_usage.py b/examples/basic_usage.py index <HASH>..<HASH> 100755 --- a/examples/basic_usage.py +++ b/examples/basic_usage.py @@ -10,7 +10,6 @@ def run(unihan_options={}): if not c.unihan.is_bootstrapped: # download and install Unihan to db c.unihan.bootstrap(unihan_options) - c.sql.reflect_db() query = c.unihan.lookup_char('好') glyph = query.first()
Remove extraneous db reflection
diff --git a/lib/chef/provider/package/zypper.rb b/lib/chef/provider/package/zypper.rb index <HASH>..<HASH> 100644 --- a/lib/chef/provider/package/zypper.rb +++ b/lib/chef/provider/package/zypper.rb @@ -70,10 +70,6 @@ class Chef end def candidate_version - @candidate_version ||= package_name_array.each_with_index.map { |pkg, i| available_version(i) } - end - - def candidate_version if source_files_exist? unless uri_scheme?(new_resource.source) || ::File.exist?(new_resource.source) @package_source_exists = false
Removed unused/repeated candidate version
diff --git a/src/org/jcodings/EncodingDB.java b/src/org/jcodings/EncodingDB.java index <HASH>..<HASH> 100644 --- a/src/org/jcodings/EncodingDB.java +++ b/src/org/jcodings/EncodingDB.java @@ -177,10 +177,15 @@ public class EncodingDB { public static void set_base(String name, String original) { } + public static Entry dummy(byte[] bytes) { + if (encodings.get(bytes) != null) throw new InternalException(ErrorMessages.ERR_ENCODING_ALREADY_REGISTERED, new String(bytes)); + Entry entry = new Entry(bytes); + encodings.putDirect(bytes, entry); + return entry; + } + public static void dummy(String name) { - byte[]bytes = name.getBytes(); - if (encodings.get(bytes) != null) throw new InternalException(ErrorMessages.ERR_ENCODING_ALREADY_REGISTERED, name); - encodings.putDirect(bytes, new Entry(bytes)); + dummy(name.getBytes()); } static {
Add easier way to instantiate dummy encodings.
diff --git a/lib/sequent/core/tenant_event_store.rb b/lib/sequent/core/tenant_event_store.rb index <HASH>..<HASH> 100644 --- a/lib/sequent/core/tenant_event_store.rb +++ b/lib/sequent/core/tenant_event_store.rb @@ -8,11 +8,14 @@ module Sequent def replay_events_for(organization_id) replay_events do @event_record_class.connection.select_all(%Q{ -SELECT event_type, event_json - FROM #{quote_table_name @event_record_class.table_name} - WHERE organization_id = #{quote organization_id} - AND event_type <> #{quote @snapshot_event_class.name} - ORDER BY id +SELECT events.event_type, events.event_json + FROM #{quote_table_name @event_record_class.table_name} aggregates + JOIN #{quote_table_name @event_record_class.table_name} events ON aggregates.aggregate_id = events.aggregate_id + WHERE aggregates.organization_id = #{quote organization_id} + AND aggregates.sequence_number = 1 + AND aggregates.event_type <> #{quote @snapshot_event_class.name} + AND events.event_type <> #{quote @snapshot_event_class.name} + ORDER BY events.id }) end end
Fix replaying events for organization Include all events for all aggregates associated with the organization (do not skip events that do not have `organization_id` set).
diff --git a/web3/types.py b/web3/types.py index <HASH>..<HASH> 100644 --- a/web3/types.py +++ b/web3/types.py @@ -161,7 +161,7 @@ TxData = TypedDict("TxData", { "gasPrice": Wei, "hash": HexBytes, "input": HexStr, - "nonce": int, + "nonce": Nonce, "r": HexBytes, "s": HexBytes, "to": ChecksumAddress, @@ -191,7 +191,7 @@ GasPriceStrategy = Callable[["Web3", TxParams], Wei] # syntax b/c "from" keyword not allowed w/ class construction TxReceipt = TypedDict("TxReceipt", { "blockHash": HexBytes, - "blockNumber": int, + "blockNumber": BlockNumber, "contractAddress": Optional[ChecksumAddress], "cumulativeGasUsed": int, "gasUsed": Wei, @@ -222,7 +222,7 @@ class MerkleProof(TypedDict): accountProof: Sequence[HexStr] balance: int codeHash: HexBytes - nonce: int + nonce: Nonce storageHash: HexBytes storageProof: Sequence[StorageProof]
Some fixes to type definitions (#<I>)
diff --git a/lib/queryko/filterer.rb b/lib/queryko/filterer.rb index <HASH>..<HASH> 100644 --- a/lib/queryko/filterer.rb +++ b/lib/queryko/filterer.rb @@ -1,11 +1,21 @@ module Queryko module Filterer + # def filter_by_filters + # fields.each do |field, filter| + # if field == 'limit' || field == 'page' + # paginate(filter, ) + # end + # self.relation = filter.first.call(relation, params[field], self) if params[field] + # end + # end + def filter_by_filters fields.each do |field, filter| - if field == 'limit' || field == 'page' - paginate(filter, ) + paginate(filter) if ['limit', 'page'].include?(field.to_s) + + filter.each do |f| + self.relation = f.call(relation, params[field], self) if params[field] end - self.relation = filter.first.call(relation, params[field], self) if params[field] end end
apply multiple filter instead of getting the first filter
diff --git a/src/transformers/integrations.py b/src/transformers/integrations.py index <HASH>..<HASH> 100644 --- a/src/transformers/integrations.py +++ b/src/transformers/integrations.py @@ -54,7 +54,7 @@ from .trainer_utils import PREFIX_CHECKPOINT_DIR, BestRun, EvaluationStrategy # # Integration functions: def is_wandb_available(): - if os.getenv("WANDB_DISABLED"): + if os.getenv("WANDB_DISABLED", "").upper() in ENV_VARS_TRUE_VALUES: return False return importlib.util.find_spec("wandb") is not None
Fix WAND_DISABLED test (#<I>) * Fix WAND_DISABLED test * Remove duplicate import * Make a test that actually works... * Fix style
diff --git a/slackclient/_channel.py b/slackclient/_channel.py index <HASH>..<HASH> 100644 --- a/slackclient/_channel.py +++ b/slackclient/_channel.py @@ -6,7 +6,7 @@ class Channel(object): self.members = members def __eq__(self, compare_str): - if self.name == compare_str or self.id == compare_str: + if self.name == compare_str or self.name == "#" + compare_str or self.id == compare_str: return True else: return False
allow channels to be found with leading #
diff --git a/lib/bibtex/entry/rdf_converter.rb b/lib/bibtex/entry/rdf_converter.rb index <HASH>..<HASH> 100644 --- a/lib/bibtex/entry/rdf_converter.rb +++ b/lib/bibtex/entry/rdf_converter.rb @@ -449,10 +449,8 @@ class BibTeX::Entry::RDFConverter if bibtex.type == :unpublished graph << [entry, RDF::DC.created, date] - graph << [entry, bibo[:created], date] else graph << [entry, RDF::DC.issued, date] - graph << [entry, bibo[:issued], date] end end
Remove bibo:created and bibo:issued from #year They do not exist. (Links to Dublin Core)
diff --git a/src/main/java/org/fxmisc/flowless/VirtualizedScrollPane.java b/src/main/java/org/fxmisc/flowless/VirtualizedScrollPane.java index <HASH>..<HASH> 100644 --- a/src/main/java/org/fxmisc/flowless/VirtualizedScrollPane.java +++ b/src/main/java/org/fxmisc/flowless/VirtualizedScrollPane.java @@ -324,7 +324,7 @@ public class VirtualizedScrollPane<V extends Node & Virtualized> extends Region pos, content.getLayoutBounds().getWidth(), content.totalWidthEstimateProperty().getValue()); - content.estimatedScrollXProperty().setValue(offset); + content.estimatedScrollXProperty().setValue((double) Math.round(offset)); } private void setVPosition(double pos) { @@ -332,7 +332,9 @@ public class VirtualizedScrollPane<V extends Node & Virtualized> extends Region pos, content.getLayoutBounds().getHeight(), content.totalHeightEstimateProperty().getValue()); - content.estimatedScrollYProperty().setValue(offset); + // offset needs rounding otherwise thin lines appear between cells, + // usually only visible when cells have dark backgrounds/borders. + content.estimatedScrollYProperty().setValue((double) Math.round(offset)); } private static void setupUnitIncrement(ScrollBar bar) {
Fix thin lines between cells 2 (#<I>)
diff --git a/app/drivers/prottable/info.py b/app/drivers/prottable/info.py index <HASH>..<HASH> 100644 --- a/app/drivers/prottable/info.py +++ b/app/drivers/prottable/info.py @@ -10,9 +10,11 @@ class AddProteinInfoDriver(ProttableAddData): super().__init__(**kwargs) self.headertypes = ['proteindata'] self.poolnames = [kwargs.get('setname')] + self.genecentric = kwargs.get('genecentric', False) def set_feature_generator(self): self.features = preparation.add_protein_data(self.in_proteins, self.lookup, self.headerfields, + self.genecentric )
Genecentric also for prottable add info
diff --git a/httputil/httputil.go b/httputil/httputil.go index <HASH>..<HASH> 100644 --- a/httputil/httputil.go +++ b/httputil/httputil.go @@ -1,5 +1,6 @@ /* Copyright 2011 Google Inc. +Modifications Copyright (c) 2014 Simon Zimmermann Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. @@ -65,7 +66,7 @@ func ReturnJSON(rw http.ResponseWriter, data interface{}) { } func ReturnJSONCode(rw http.ResponseWriter, code int, data interface{}) { - rw.Header().Set("Content-Type", "text/javascript") + rw.Header().Set("Content-Type", "application/json") js, err := json.MarshalIndent(data, "", " ") if err != nil { BadRequestError(rw, fmt.Sprintf("JSON serialization error: %v", err))
util: use application/json instead of text/javascript for JSON response
diff --git a/jaraco/windows/api/clipboard.py b/jaraco/windows/api/clipboard.py index <HASH>..<HASH> 100644 --- a/jaraco/windows/api/clipboard.py +++ b/jaraco/windows/api/clipboard.py @@ -45,3 +45,9 @@ GetClipboardData.restype = ctypes.wintypes.HANDLE SetClipboardData = ctypes.windll.user32.SetClipboardData SetClipboardData.argtypes = ctypes.wintypes.UINT, ctypes.wintypes.HANDLE SetClipboardData.restype = ctypes.wintypes.HANDLE + +OpenClipboard = ctypes.windll.user32.OpenClipboard +OpenClipboard.argtypes = ctypes.wintypes.HANDLE, +OpenClipboard.restype = ctypes.wintypes.BOOL + +ctypes.windll.user32.CloseClipboard.restype = ctypes.wintypes.BOOL
Add type declarations for clipboard operations.
diff --git a/test/util/database.js b/test/util/database.js index <HASH>..<HASH> 100644 --- a/test/util/database.js +++ b/test/util/database.js @@ -9,7 +9,7 @@ var _nsv; var refreshDb = function(done) { disposableSeraph({ - version: '2.3.1', + version: '3.0.3', edition: 'community', port: TEST_INSTANCE_PORT },
bump neo4j version in tests
diff --git a/lib/anycable/rails/railtie.rb b/lib/anycable/rails/railtie.rb index <HASH>..<HASH> 100644 --- a/lib/anycable/rails/railtie.rb +++ b/lib/anycable/rails/railtie.rb @@ -70,7 +70,7 @@ module AnyCable # Since Rails 6.1 if respond_to?(:server) server do - next unless AnyCable.config.embedded? + next unless AnyCable.config.embedded? && AnyCable::Rails.enabled? require "anycable/cli" AnyCable::CLI.embed!
fix: only run embedded server if AnyCable is enabled
diff --git a/core/client/routes/reset.js b/core/client/routes/reset.js index <HASH>..<HASH> 100644 --- a/core/client/routes/reset.js +++ b/core/client/routes/reset.js @@ -3,6 +3,12 @@ import loadingIndicator from 'ghost/mixins/loading-indicator'; var ResetRoute = Ember.Route.extend(styleBody, loadingIndicator, { classNames: ['ghost-reset'], + beforeModel: function () { + if (this.get('session').isAuthenticated) { + this.notifications.showWarn('You can\'t reset your password while you\'re signed in.', true); + this.transitionTo(SimpleAuth.Configuration.routeAfterAuthentication); + } + }, setupController: function (controller, params) { controller.token = params.token; } diff --git a/core/client/routes/signup.js b/core/client/routes/signup.js index <HASH>..<HASH> 100644 --- a/core/client/routes/signup.js +++ b/core/client/routes/signup.js @@ -5,6 +5,7 @@ var SignupRoute = Ember.Route.extend(styleBody, loadingIndicator, { classNames: ['ghost-signup'], beforeModel: function () { if (this.get('session').isAuthenticated) { + this.notifications.showWarn('You need to sign out to register as a new user.', true); this.transitionTo(SimpleAuth.Configuration.routeAfterAuthentication); } },
Reset/Signin while signed in no issue - added redirect and notification to reset route - added notification to signup route
diff --git a/lib/jitsu/commands/databases.js b/lib/jitsu/commands/databases.js index <HASH>..<HASH> 100644 --- a/lib/jitsu/commands/databases.js +++ b/lib/jitsu/commands/databases.js @@ -199,7 +199,8 @@ databases.list = function (username, callback) { // Allows arbitrary amount of arguments to deploy // if(arguments.length) { - callback = utile.args(arguments).callback; + var args = utile.args(arguments); + callback = args.callback; username = args[0] || null; }
[api][minor] added args variable to conform to other argument currying formats
diff --git a/spec/shared/evaluator_behavior.rb b/spec/shared/evaluator_behavior.rb index <HASH>..<HASH> 100644 --- a/spec/shared/evaluator_behavior.rb +++ b/spec/shared/evaluator_behavior.rb @@ -40,6 +40,9 @@ shared_examples_for 'predicate evaluator' do expect(evaluation.output).to be(true) evaluation = object.inverse.evaluation(valid_input) + + expect(evaluation.success?).to be(true) + expect(evaluation.output).to be(false) end end
Add more expectations to predicate inverse shared behavior
diff --git a/fastlane/lib/fastlane/actions/prompt.rb b/fastlane/lib/fastlane/actions/prompt.rb index <HASH>..<HASH> 100644 --- a/fastlane/lib/fastlane/actions/prompt.rb +++ b/fastlane/lib/fastlane/actions/prompt.rb @@ -18,7 +18,11 @@ module Fastlane user_input = STDIN.gets(end_tag).chomp.gsub(end_tag, "").strip else # Standard one line input - user_input = STDIN.gets.chomp.strip while (user_input || "").length == 0 + if params[:secure_text] + user_input = STDIN.noecho(&:gets).chomp while (user_input || "").length == 0 + else + user_input = STDIN.gets.chomp.strip while (user_input || "").length == 0 + end end return user_input @@ -52,6 +56,10 @@ module Fastlane description: "Is that a boolean question (yes/no)? This will add (y/n) at the end", default_value: false, is_string: false), + FastlaneCore::ConfigItem.new(key: :secure_text, + description: "Is that a secure text (yes/no)?", + default_value: false, + is_string: false), FastlaneCore::ConfigItem.new(key: :multi_line_end_keyword, description: "Enable multi-line inputs by providing an end text (e.g. 'END') which will stop the user input", optional: true,
added secure text input option (#<I>) * added secure text input option * Update prompt.rb
diff --git a/ford/output.py b/ford/output.py index <HASH>..<HASH> 100644 --- a/ford/output.py +++ b/ford/output.py @@ -249,14 +249,12 @@ class Documentation(object): shutil.copy(src.path, os.path.join(out_dir, "src", src.name)) if "mathjax_config" in self.data: - os.mkdir(os.path.join(out_dir, "js", "MathJax-config")) + mathjax_path = os.mkdir(os.path.join(out_dir, "js", "MathJax-config")) + if not os.path.join(mathjax_config) + os.mkdir(mathjax_config) shutil.copy( self.data["mathjax_config"], - os.path.join( - out_dir, - "js", - "MathJax-config", - os.path.basename(self.data["mathjax_config"]), + os.path.join(mathjax_config, os.path.basename(self.data["mathjax_config"]), ), ) # By doing this we omit a duplication of data.
Don't fail when MathJax-config dir already exists Only create the directory MathJax-config when it doesn't exist yet. Avoids a crash with FileExistsError, which I don't see why it should be fatal.
diff --git a/pkg/minikube/reason/known_issues.go b/pkg/minikube/reason/known_issues.go index <HASH>..<HASH> 100644 --- a/pkg/minikube/reason/known_issues.go +++ b/pkg/minikube/reason/known_issues.go @@ -335,7 +335,7 @@ var providerIssues = []match{ ID: "PR_HYPERKIT_VMNET_FRAMEWORK", ExitCode: ExProviderError, Advice: `Hyperkit networking is broken. Try disabling Internet Sharing: System Preference > Sharing > Internet Sharing. -Also you could try to upgrade to the latest "hyperkit" version and/or Docker for Desktop. You may choose an alternate --driver`, +Alternatively, you can try upgrading to the latest hyperkit version, or using an alternate driver.`, Issues: []int{6028, 5594}, }, Regexp: re(`error from vmnet.framework: -1`),
Update pkg/minikube/reason/known_issues.go
diff --git a/php/class-template-hierarchy.php b/php/class-template-hierarchy.php index <HASH>..<HASH> 100644 --- a/php/class-template-hierarchy.php +++ b/php/class-template-hierarchy.php @@ -15,6 +15,7 @@ class Template_Hierarchy { 'attachment', 'single', 'page', + 'singular', 'category', 'tag', 'author', @@ -107,7 +108,7 @@ class Template_Hierarchy { case 'page': $page_id = get_queried_object_id(); - $template = get_page_template_slug(); +// $template = get_page_template_slug(); $pagename = get_query_var( 'pagename' ); if ( ! $pagename && $page_id ) { @@ -129,6 +130,10 @@ class Template_Hierarchy { $templates[] = 'page.twig'; break; + case 'singular': + $templates = [ 'singular.twig' ]; + break; + case 'category': case 'tag': $term = get_queried_object(); @@ -187,4 +192,4 @@ class Template_Hierarchy { return locate_template( $templates ); } -} \ No newline at end of file +}
Added singular template to hierarchy. Fixes #3
diff --git a/lib/linters/comment.js b/lib/linters/comment.js index <HASH>..<HASH> 100644 --- a/lib/linters/comment.js +++ b/lib/linters/comment.js @@ -3,18 +3,11 @@ module.exports = { name: 'comment', nodeTypes: ['multilineComment'], - - // if we put this here, the specs don't need to copy/paste - // the error messages. pain saver. - // also makes it obvious where in the file the actual message is kept - // this may fail if a linter has multiple messages, in which case we - // can make this an object message: 'There shouldn\'t be any multi-line comments.', lint: function commentLinter (config, node) { var regexp; - // let the linter handle custom bits of its config if (config.allowed) { regexp = new RegExp(config.allowed); }
Remove old comments in comment linter
diff --git a/symphony/lib/toolkit/include.install.php b/symphony/lib/toolkit/include.install.php index <HASH>..<HASH> 100644 --- a/symphony/lib/toolkit/include.install.php +++ b/symphony/lib/toolkit/include.install.php @@ -658,7 +658,7 @@ } $htaccess = ' -### Symphony 2.1.x ### +### Symphony 2.2.x ### Options +FollowSymlinks -Indexes <IfModule mod_rewrite.c> diff --git a/update.php b/update.php index <HASH>..<HASH> 100644 --- a/update.php +++ b/update.php @@ -172,7 +172,7 @@ } $htaccess = ' -### Symphony 2.0.x ### +### Symphony 2.2.x ### Options +FollowSymlinks -Indexes <IfModule mod_rewrite.c>
Correcting Symphony version number to be used in .htaccess file.
diff --git a/problems/11-dist-tag-removal.js b/problems/11-dist-tag-removal.js index <HASH>..<HASH> 100644 --- a/problems/11-dist-tag-removal.js +++ b/problems/11-dist-tag-removal.js @@ -26,8 +26,8 @@ Run `npm help dist-tag` to learn more about the command. } //exports.solution = function () {/* -//npm dist-tags add test@1.0.0 latest -//npm dist-tags rm test old +//npm dist-tag add test@1.0.0 latest +//npm dist-tag rm test old //*/}.toString().split('\n').slice(1,-1).join('\n') exports.verify = function (args, cb) { @@ -63,7 +63,7 @@ exports.verify = function (args, cb) { console.log('Oops! Your "latest" tag still points at the most recent\n' + 'release, %s.\n' + 'Point that somewhere else, and re-run `how-to-npm verify`\n'+ - 'Use `npm help dist-tags` to learn more about how to do it.', + 'Use `npm help dist-tag` to learn more about how to do it.', mostRecentVersion) return cb(false) }
remove typo in dist-tag suggestion
diff --git a/Db.php b/Db.php index <HASH>..<HASH> 100644 --- a/Db.php +++ b/Db.php @@ -111,7 +111,8 @@ class Db extends DbOps if ($hard) { $sql = '>DELETE FROM ' . $table . ' WHERE `id` ='; } else { - $sql = '>UPDATE ' . $table . ' SET `delete_date` = NOW() WHERE `id` ='; + $deleteDate = (self::$_env->get('casing') == 'snake' ? 'delete_date' : 'deleteDate'); + $sql = '>UPDATE ' . $table . ' SET `' . $deleteDate . '` = NOW() WHERE `id` ='; } if (self::$_env->get('assumes_uuid')) { $sql .= 'UNHEX({{id}})';
Add camel-casing to delete function
diff --git a/features/support/env.js b/features/support/env.js index <HASH>..<HASH> 100644 --- a/features/support/env.js +++ b/features/support/env.js @@ -31,7 +31,7 @@ module.exports = function () { this.DEFAULT_ENVIRONMENT = Object.assign({STXXLCFG: stxxl_config}, process.env); this.DEFAULT_PROFILE = 'bicycle'; this.DEFAULT_INPUT_FORMAT = 'osm'; - this.DEFAULT_LOAD_METHOD = this.PLATFORM_WINDOWS ? 'directly' : 'datastore'; + this.DEFAULT_LOAD_METHOD = 'datastore'; this.DEFAULT_ORIGIN = [1,1]; this.OSM_USER = 'osrm'; this.OSM_GENERATOR = 'osrm-test';
revert 'directly' method on win<I>
diff --git a/presto-main/src/test/java/com/facebook/presto/spiller/TestGenericPartitioningSpiller.java b/presto-main/src/test/java/com/facebook/presto/spiller/TestGenericPartitioningSpiller.java index <HASH>..<HASH> 100644 --- a/presto-main/src/test/java/com/facebook/presto/spiller/TestGenericPartitioningSpiller.java +++ b/presto-main/src/test/java/com/facebook/presto/spiller/TestGenericPartitioningSpiller.java @@ -74,6 +74,7 @@ public class TestGenericPartitioningSpiller FeaturesConfig featuresConfig = new FeaturesConfig(); featuresConfig.setSpillerSpillPaths(tempDirectory.toString()); featuresConfig.setSpillerThreads(8); + featuresConfig.setSpillMaxUsedSpaceThreshold(1.0); singleStreamSpillerFactory = new FileSingleStreamSpillerFactory(blockEncodingSerde, new SpillerStats(), featuresConfig); factory = new GenericPartitioningSpillerFactory(singleStreamSpillerFactory); }
Allow spill tests to run when disk space is low
diff --git a/Tests/Functional/Service/HistoryManagerTest.php b/Tests/Functional/Service/HistoryManagerTest.php index <HASH>..<HASH> 100644 --- a/Tests/Functional/Service/HistoryManagerTest.php +++ b/Tests/Functional/Service/HistoryManagerTest.php @@ -15,6 +15,7 @@ use ONGR\ElasticsearchBundle\Test\AbstractElasticsearchTestCase; use ONGR\TranslationsBundle\Document\History; use ONGR\TranslationsBundle\Document\Message; use ONGR\TranslationsBundle\Service\HistoryManager; +use Symfony\Component\HttpFoundation\Request; class HistoryManagerTest extends AbstractElasticsearchTestCase { @@ -104,4 +105,12 @@ class HistoryManagerTest extends AbstractElasticsearchTestCase $this->getManager()->commit(); $this->assertEquals(3, count($this->manager->get($translation)['en'])); } + + public function testAddHistoryProcess() + { + $request = new Request([], [], [], [], [], [], json_encode(['messages' => ['en' => 'something']])); + $translationManager = $this->getContainer()->get('ongr_translations.translation_manager'); + $translationManager->update('foo', $request); + $this->assertEquals(3, count($this->manager->get($translationManager->get('foo'))['en'])); + } }
wrote a test for message addition to history
diff --git a/test.py b/test.py index <HASH>..<HASH> 100644 --- a/test.py +++ b/test.py @@ -38,7 +38,7 @@ class TestKafka(unittest.TestCase): Test that no errors are thrown, and it doesn't hang when you send a message """ producer = HerokuKafkaProducer(**kafka_params) - #producer.send(TOPIC1, b"some message") + producer.send(TOPIC1, b"some message") producer.flush() # Force event send producer.close()
Removed comment on producer.send
diff --git a/tasks/build.gulp.js b/tasks/build.gulp.js index <HASH>..<HASH> 100644 --- a/tasks/build.gulp.js +++ b/tasks/build.gulp.js @@ -36,7 +36,7 @@ module.exports = function (gulp) { projectRoot = process.cwd(); gulp.task('inject', function (callback) { - sequence('inject-bower', 'inject-styles', 'inject-partials', 'modernizr', 'inject-js', callback); + sequence('config', 'inject-bower', 'inject-styles', 'inject-partials', 'modernizr', 'inject-js', callback); }); gulp.task('inject-bower', ['bower-download'], function () { @@ -133,7 +133,7 @@ module.exports = function (gulp) { .pipe(size()); }); - gulp.task('build', ['config', 'version', 'inject', 'images', 'fonts', 'resources', 'lib', 'lint-js'], function (callback) { + gulp.task('build', ['version', 'inject', 'images', 'fonts', 'resources', 'lib', 'lint-js'], function (callback) { callback(); });
Moving config task to inject task, to run it in same sequence as other tasks that use inject
diff --git a/Repository/ResourceQueryBuilder.php b/Repository/ResourceQueryBuilder.php index <HASH>..<HASH> 100644 --- a/Repository/ResourceQueryBuilder.php +++ b/Repository/ResourceQueryBuilder.php @@ -162,7 +162,7 @@ class ResourceQueryBuilder $eol = PHP_EOL; $clause = "{$eol}({$eol}"; - for ($i = 0; $i < $count; ++$i) { + foreach ($roles as $i => $role) { $role = $roles[$i] instanceof RoleInterface ? $roles[$i]->getRole() : $roles[$i]; $clause .= $i > 0 ? ' OR ' : ' '; $clause .= "rightRole.name = :role_{$i}{$eol}";
[CoreBundle] Fixing the whereRoleIn method.
diff --git a/tests/EasyDBTest.php b/tests/EasyDBTest.php index <HASH>..<HASH> 100644 --- a/tests/EasyDBTest.php +++ b/tests/EasyDBTest.php @@ -39,6 +39,8 @@ abstract class EasyDBTest */ public function GoodFactoryCreateArgumentProvider() { + switch (getenv('DB')) { + case false: return [ [ 'sqlite::memory:', @@ -48,6 +50,13 @@ abstract class EasyDBTest 'sqlite' ], ]; + break; + } + $this->markTestIncomplete( + 'Could not determine appropriate arguments for ' . + Factory::class . + '::create() from getenv()' + ); } /**
mark test as incomplete if we cannot determine appropriate arguments for ParagonIE\EasyDB\Factory::create() via getenv()
diff --git a/tests/ProxyManagerTest/Functional/FatalPreventionFunctionalTest.php b/tests/ProxyManagerTest/Functional/FatalPreventionFunctionalTest.php index <HASH>..<HASH> 100644 --- a/tests/ProxyManagerTest/Functional/FatalPreventionFunctionalTest.php +++ b/tests/ProxyManagerTest/Functional/FatalPreventionFunctionalTest.php @@ -48,8 +48,9 @@ echo 'SUCCESS: ' . %s; PHP; /** - * Verifies that proxies generated from different factories will retain their specific implementation - * and won't conflict + * Verifies that lazy loading ghost will work with all given classes + * + * @param string $className a valid (existing/autoloadable) class name * * @dataProvider getTestedClasses */
Minor docblock fixes/clarifications
diff --git a/docs/conf.py b/docs/conf.py index <HASH>..<HASH> 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -12,6 +12,8 @@ on_rtd = os.environ.get('READTHEDOCS', None) == 'True' year = datetime.datetime.now().strftime("%Y") +sys.path.append(os.path.join(os.path.dirname(os.path.abspath(__file__)), os.pardir)) + os.environ.setdefault("DJANGO_SETTINGS_MODULE", "tests.testapp.settings") django.setup()
Add git root to python path for read the docs
diff --git a/malcolm/modules/builtin/controllers/managercontroller.py b/malcolm/modules/builtin/controllers/managercontroller.py index <HASH>..<HASH> 100644 --- a/malcolm/modules/builtin/controllers/managercontroller.py +++ b/malcolm/modules/builtin/controllers/managercontroller.py @@ -468,11 +468,12 @@ class ManagerController(StatefulController): names.sort() if os.path.isdir(self.template_designs): for f in sorted(os.listdir(self.template_designs)): - assert f.startswith("template_"), \ - "Template design %s/%s should start with 'template_'" % ( - self.template_designs, f) - if f not in names: - names.append(f) + assert f.startswith("template_") and f.endswith(".json"), \ + "Template design %s/%s should start with 'template_' " \ + "and end with .json" % (self.template_designs, f) + t_name = f.split(".json")[0] + if t_name not in names: + names.append(t_name) self.design.meta.set_choices(names) def _validated_config_filename(self, name):
Don't put .json in template design names
diff --git a/widgets/map/src/main/javascript/map.js b/widgets/map/src/main/javascript/map.js index <HASH>..<HASH> 100644 --- a/widgets/map/src/main/javascript/map.js +++ b/widgets/map/src/main/javascript/map.js @@ -232,6 +232,10 @@ $(function () { colorScale = d3.scale.linear().domain([min, max]).range(['#FFFF00', '#FF0000']); } + //change multiple for radius formula based on range of data + var maxCount = maxValue(data, sizeByField); + var multiple = 17/log10(maxCount); + _.each(data, function (element) { var point = new OpenLayers.Geometry.Point(element[lonField], element[latField]); point.transform(new OpenLayers.Projection("EPSG:4326"), new OpenLayers.Projection("EPSG:900913")); @@ -240,7 +244,7 @@ $(function () { //possible values for radius are 3-20, this formula ensures that all radii are in that range var radius = 3; if(element[sizeByField] > 1) { - radius = (2.54*log10(element[sizeByField])) + 3; + radius = (multiple*log10(element[sizeByField])) + 3; } //if colorby is utilized, change default color
NEON-<I> points layer is now sized based on range of data
diff --git a/src/input/input.js b/src/input/input.js index <HASH>..<HASH> 100644 --- a/src/input/input.js +++ b/src/input/input.js @@ -524,6 +524,7 @@ 'RIGHT' : 39, 'DOWN' : 40, 'ENTER' : 13, + 'TAB' : 9, 'SHIFT' : 16, 'CTRL' : 17, 'ALT' : 18,
added in tab key to the input bindings
diff --git a/lib/eventhub/heartbeat.rb b/lib/eventhub/heartbeat.rb index <HASH>..<HASH> 100644 --- a/lib/eventhub/heartbeat.rb +++ b/lib/eventhub/heartbeat.rb @@ -36,7 +36,7 @@ module EventHub heartbeat_cycle_in_ms: processor.heartbeat_cycle_in_s * 1000, served_queues: [processor.listener_queues], host: Socket.gethostname, - ip_addresses: ip_addresses, + addresses: addresses, messages: { total: statistics.messages_total, successful: statistics.messages_successful, @@ -51,7 +51,7 @@ module EventHub private - def ip_addresses + def addresses interfaces = Socket.getifaddrs.select do |interface| !interface.addr.ipv4_loopback? && !interface.addr.ipv6_loopback? end
fix: "ip_adresses" has to be "addresses"
diff --git a/test/router.test.js b/test/router.test.js index <HASH>..<HASH> 100644 --- a/test/router.test.js +++ b/test/router.test.js @@ -240,5 +240,6 @@ module.exports = { app.match.get('/user/5/edit').should.have.length(2); app.match.get('/').should.have.be.empty; app.match.all('/user/123').should.have.length(3); + app.match('/user/123').should.have.length(3); } };
Added app.match() as app.match.all()
diff --git a/lib/hanami/router.rb b/lib/hanami/router.rb index <HASH>..<HASH> 100644 --- a/lib/hanami/router.rb +++ b/lib/hanami/router.rb @@ -803,7 +803,9 @@ module Hanami if inspect? @inspector.add_route( - Route.new(http_method: http_method, path: path, to: to, as: as, constraints: constraints, blk: blk) + Route.new( + http_method: http_method, path: path, to: to || endpoint, as: as, constraints: constraints, blk: blk + ) ) end end diff --git a/spec/unit/hanami/router/routing.rb b/spec/unit/hanami/router/routing.rb index <HASH>..<HASH> 100644 --- a/spec/unit/hanami/router/routing.rb +++ b/spec/unit/hanami/router/routing.rb @@ -14,5 +14,17 @@ RSpec.describe Hanami::Router do expect(router.inspector.call).to include("home#index") end + + it "uses resolved block value to generate the route" do + inspector = Hanami::Router::Inspector.new + + router = Hanami::Router.new(inspector: inspector) do + get "/" do + "Block" + end + end + + expect(router.inspector.call).to include("(block)") + end end end
Fix block not given to the route when no `to` option (#<I>)
diff --git a/actions/class.TestImport.php b/actions/class.TestImport.php index <HASH>..<HASH> 100755 --- a/actions/class.TestImport.php +++ b/actions/class.TestImport.php @@ -36,7 +36,7 @@ class taoTests_actions_TestImport extends tao_actions_Import * overwrite the parent index to add the requiresRight for Tests * * @requiresRight id WRITE - * @see tao_actions_Import::index() + * @requiresRight classUri WRITE */ public function index() { diff --git a/actions/class.Tests.php b/actions/class.Tests.php index <HASH>..<HASH> 100755 --- a/actions/class.Tests.php +++ b/actions/class.Tests.php @@ -215,15 +215,6 @@ class taoTests_actions_Tests extends tao_actions_SaSModule /** * overwrite the parent moveAllInstances to add the requiresRight only in Items - * @see tao_actions_TaoModule::moveResource() - * @requiresRight classUri WRITE - */ - public function moveResource() - { - return parent::moveResource(); - } - /** - * overwrite the parent moveAllInstances to add the requiresRight only in Items * @see tao_actions_TaoModule::moveAll() * @requiresRight ids WRITE */
fix: fix permissions to view buttons
diff --git a/lib/codemirror.js b/lib/codemirror.js index <HASH>..<HASH> 100644 --- a/lib/codemirror.js +++ b/lib/codemirror.js @@ -243,11 +243,15 @@ var CodeMirror = (function() { }, getTokenAt: function(mode, state, ch) { var txt = this.text, stream = new StringStream(txt); - while (stream.pos <= ch && !stream.eol()) { + while (stream.pos < ch && !stream.eol()) { stream.start = stream.pos; var style = mode.token(stream, state); } - return {start: stream.start, end: stream.pos, string: stream.current(), className: style || null}; + return {start: stream.start, + end: stream.pos, + string: stream.current(), + className: style || null, + state: state}; }, indentation: function() {return countIndentation(this.text);}, getHTML: function(sfrom, sto, includePre) {
revise getTokenAt to return token *before* the given pos it now also returns the parser state at that position
diff --git a/lib/Predis/Protocols/Text/TextProtocol.php b/lib/Predis/Protocols/Text/TextProtocol.php index <HASH>..<HASH> 100644 --- a/lib/Predis/Protocols/Text/TextProtocol.php +++ b/lib/Predis/Protocols/Text/TextProtocol.php @@ -79,11 +79,10 @@ class TextProtocol implements IProtocolProcessor { return (int) $payload; case '-': // error - $errorMessage = substr($payload, 4); if ($this->_throwErrors) { - throw new ServerException($errorMessage); + throw new ServerException($payload); } - return new ResponseError($errorMessage); + return new ResponseError($payload); default: Helpers::onCommunicationException(new ProtocolException(
Fix missing change that should have been part of commit cc<I>c.
diff --git a/server/src/test/java/org/cloudfoundry/identity/uaa/web/CookieBasedCsrfTokenRepositoryTests.java b/server/src/test/java/org/cloudfoundry/identity/uaa/web/CookieBasedCsrfTokenRepositoryTests.java index <HASH>..<HASH> 100644 --- a/server/src/test/java/org/cloudfoundry/identity/uaa/web/CookieBasedCsrfTokenRepositoryTests.java +++ b/server/src/test/java/org/cloudfoundry/identity/uaa/web/CookieBasedCsrfTokenRepositoryTests.java @@ -138,6 +138,7 @@ public class CookieBasedCsrfTokenRepositoryTests { CookieBasedCsrfTokenRepository repo = new CookieBasedCsrfTokenRepository(); repo.setSecure(isSecure); MockHttpServletRequest request = new MockHttpServletRequest(); + request.setProtocol("http"); MockHttpServletResponse response = new MockHttpServletResponse(); CsrfToken token = repo.generateToken(request); repo.saveToken(token, request, response);
refactor: make protocol default explicit
diff --git a/aeron-cluster/src/main/java/io/aeron/cluster/ClusterTool.java b/aeron-cluster/src/main/java/io/aeron/cluster/ClusterTool.java index <HASH>..<HASH> 100644 --- a/aeron-cluster/src/main/java/io/aeron/cluster/ClusterTool.java +++ b/aeron-cluster/src/main/java/io/aeron/cluster/ClusterTool.java @@ -71,7 +71,14 @@ import static org.agrona.SystemUtil.getDurationInNanos; */ public class ClusterTool { + /** + * Timeout in nanoseconds for the tool to wait while trying to perform an operation. + */ public static final String AERON_CLUSTER_TOOL_TIMEOUT_PROP_NAME = "aeron.cluster.tool.timeout"; + + /** + * Delay in nanoseconds to be applied to an operation such as when the new cluster backup query will occur. + */ public static final String AERON_CLUSTER_TOOL_DELAY_PROP_NAME = "aeron.cluster.tool.delay"; private static final long TIMEOUT_MS =
[Java] Javadoc for ClusterTool.
diff --git a/weld/src/main/java/org/jboss/as/weld/deployment/processors/WeldPortableExtensionProcessor.java b/weld/src/main/java/org/jboss/as/weld/deployment/processors/WeldPortableExtensionProcessor.java index <HASH>..<HASH> 100644 --- a/weld/src/main/java/org/jboss/as/weld/deployment/processors/WeldPortableExtensionProcessor.java +++ b/weld/src/main/java/org/jboss/as/weld/deployment/processors/WeldPortableExtensionProcessor.java @@ -121,6 +121,8 @@ public class WeldPortableExtensionProcessor implements DeploymentUnitProcessor { throw WeldMessages.MESSAGES.extensionDoesNotImplementExtension(serviceClassName, e); } catch (Exception e) { WeldLogger.DEPLOYMENT_LOGGER.couldNotLoadPortableExceptionClass(serviceClassName, e); + } catch (LinkageError e) { + WeldLogger.DEPLOYMENT_LOGGER.couldNotLoadPortableExceptionClass(serviceClassName, e); } return null; }
WFLY-<I> Portable extensions that fail to load will prevent a deployment from completing
diff --git a/hey.go b/hey.go index <HASH>..<HASH> 100644 --- a/hey.go +++ b/hey.go @@ -19,6 +19,7 @@ import ( "flag" "fmt" "io/ioutil" + "math" "net/http" gourl "net/url" "os" @@ -26,10 +27,9 @@ import ( "regexp" "runtime" "strings" + "time" "github.com/rakyll/hey/requester" - "math" - "time" ) const (
Reorganize the imports in hey.go to be more go-style compliant (#<I>)
diff --git a/GiftedFormManager.js b/GiftedFormManager.js index <HASH>..<HASH> 100644 --- a/GiftedFormManager.js +++ b/GiftedFormManager.js @@ -51,6 +51,13 @@ function doValidateOne(k = '', value = undefined, validators = {}) { } } + // Validator ONLY accepts string arguments. + if (clonedArgs[0] === null || clonedArgs[0] === undefined) { + clonedArgs[0] = ''; + } else { + clonedArgs[0] = String(clonedArgs[0]); + } + isValid = validatorjs[validate[i].validator].apply(null, clonedArgs); result.push({
Make sure arguments to validator are ALWAYS strings Fixes #<I>.
diff --git a/lib/danger/commands/init.rb b/lib/danger/commands/init.rb index <HASH>..<HASH> 100644 --- a/lib/danger/commands/init.rb +++ b/lib/danger/commands/init.rb @@ -93,7 +93,7 @@ module Danger ui.pause 1 if considered_an_oss_repo? - ui.say "#{@bot_name} does not need privilidged access to your repo or org. This is because Danger will only" + ui.say "#{@bot_name} does not need privileged access to your repo or org. This is because Danger will only" ui.say "be writing comments, and you do not need special access for that." else ui.say "#{@bot_name} will need access to your repo. Simply because the code is not available for the public"
Fixes typo in init.rb #trivial (#<I>) `s/privilidged/privileged/`
diff --git a/bridge/whatsapp/whatsapp.go b/bridge/whatsapp/whatsapp.go index <HASH>..<HASH> 100644 --- a/bridge/whatsapp/whatsapp.go +++ b/bridge/whatsapp/whatsapp.go @@ -293,7 +293,11 @@ func (b *Bwhatsapp) Send(msg config.Message) (string, error) { if msg.ID != "" { b.Log.Debugf("updating message with id %s", msg.ID) - msg.Text += " (edited)" + if b.GetString("editsuffix") != "" { + msg.Text += b.GetString("EditSuffix") + } else { + msg.Text += " (edited)" + } } // Handle Upload a file
Make EditSuffix option actually work (whatsapp). Fixes #<I> (#<I>) To keep it backwards compatible we keep the "(edited)" message when no editsuffix is configured.
diff --git a/core-bundle/contao/dca/tl_style.php b/core-bundle/contao/dca/tl_style.php index <HASH>..<HASH> 100644 --- a/core-bundle/contao/dca/tl_style.php +++ b/core-bundle/contao/dca/tl_style.php @@ -53,8 +53,7 @@ $GLOBALS['TL_DCA']['tl_style'] = array 'keys' => array ( 'id' => 'primary', - 'pid' => 'index', - 'selector' => 'index' + 'pid' => 'index' ) ) ),
[Core] Remove the index from the `tl_style.selector` field (see #<I>)
diff --git a/fundamentals/__version__.py b/fundamentals/__version__.py index <HASH>..<HASH> 100644 --- a/fundamentals/__version__.py +++ b/fundamentals/__version__.py @@ -1 +1 @@ -__version__ = '1.6.2' +__version__ = '1.6.3'
small update to hidden yaml warnings
diff --git a/discord/client.py b/discord/client.py index <HASH>..<HASH> 100644 --- a/discord/client.py +++ b/discord/client.py @@ -165,7 +165,7 @@ class Client: - All member related events will be disabled. - :func:`on_member_update` - :func:`on_member_join` - - :func:`on_member_leave` + - :func:`on_member_remove` - Typing events will be disabled (:func:`on_typing_start`). - If ``fetch_offline_members`` is set to ``False`` then the user cache will not exist.
on_member_leave => on_member_remove
diff --git a/views/js/runner/proxy/qtiServiceProxy.js b/views/js/runner/proxy/qtiServiceProxy.js index <HASH>..<HASH> 100644 --- a/views/js/runner/proxy/qtiServiceProxy.js +++ b/views/js/runner/proxy/qtiServiceProxy.js @@ -43,21 +43,17 @@ define([ data: params, async: true, dataType: 'json' - }).then( - // success - function(data) { - if (data && data.success) { - resolve(data); - } else { - reject(false); - } - }, - - // error - function(jqXHR) { - reject(jqXHR); + }) + .done(function(data) { + if (data && data.success) { + resolve(data); + } else { + reject(false); } - ); + }) + .fail(function(jqXHR) { + reject(jqXHR); + }); }); }
TestRunner: use done/fail instead of then while using jQuery Deffered
diff --git a/synapse/cores/lmdb.py b/synapse/cores/lmdb.py index <HASH>..<HASH> 100644 --- a/synapse/cores/lmdb.py +++ b/synapse/cores/lmdb.py @@ -20,6 +20,7 @@ import synapse.lib.threads as s_threads import lmdb import xxhash +import msgpack logger = logging.getLogger(__name__) @@ -121,7 +122,7 @@ def _encIden(iden): # Try to memoize most of the prop names we get @s_compat.lru_cache(maxsize=1024) def _encProp(prop): - return s_common.msgenpack(prop) + return msgpack.dumps(prop, encoding='utf-8') # The precompiled struct parser for native size_t _SIZET_ST = struct.Struct('@Q' if sys.maxsize > 2**32 else '@L')
Change how lmdb does propEnc encoding - drops the use of use_bin_type (which we do in msgenpack). This provides a consistent encoding for prop values across unicode/str types in python 2. Does not appear to have impact on existing cores for Python3.
diff --git a/nupic/algorithms/anomaly_likelihood.py b/nupic/algorithms/anomaly_likelihood.py index <HASH>..<HASH> 100644 --- a/nupic/algorithms/anomaly_likelihood.py +++ b/nupic/algorithms/anomaly_likelihood.py @@ -152,6 +152,12 @@ class AnomalyLikelihood(object): def _calcSkipRecords(numIngested, windowSize, learningPeriod): """Return the value of skipRecords for passing to estimateAnomalyLikelihoods + If `windowSize` is very large (bigger than the amount of data) then this + could just return `learningPeriod`. But when some values have fallen out of + the historical sliding window of anomaly records, then we have to take those + into account as well so we return the `learningPeriod` minus the number + shifted out. + :param int numIngested: number of data points that have been added to the sliding window of historical data points. :param int windowSize: size of sliding window of historical data points.
Updated docstring in AnomalyLikelihood._calcSkipRecords() per Scott's code review feedback.
diff --git a/pkg/minikube/constants/constants.go b/pkg/minikube/constants/constants.go index <HASH>..<HASH> 100644 --- a/pkg/minikube/constants/constants.go +++ b/pkg/minikube/constants/constants.go @@ -54,6 +54,8 @@ var SupportedVMDrivers = [...]string{ "kvm", "xhyve", "hyperv", + "hyperkit", + "kvm2", } var DefaultMinipath = filepath.Join(homedir.HomeDir(), ".minikube")
config: make hyperkit and kvm2 available as supported drivers
diff --git a/flake8_mypy.py b/flake8_mypy.py index <HASH>..<HASH> 100644 --- a/flake8_mypy.py +++ b/flake8_mypy.py @@ -184,14 +184,22 @@ class MypyChecker: # unexpected clashes with other .py and .pyi files in the same original # directory. with TemporaryDirectory(prefix='flake8mypy_') as d: - with NamedTemporaryFile( - 'w', encoding='utf8', prefix='tmpmypy_', suffix='.py', dir=d - ) as f: - self.filename = f.name + file = NamedTemporaryFile( + 'w', + encoding='utf8', + prefix='tmpmypy_', + suffix='.py', + dir=d, + delete=False, + ) + try: + self.filename = file.name for line in self.lines: - f.write(line) - f.flush() + file.write(line) + file.close() yield from self._run() + finally: + os.remove(file.name) def _run(self) -> Iterator[_Flake8Error]: mypy_cmdline = self.build_mypy_cmdline(self.filename, self.options.mypy_config)
Make temp file creation Windows compatible On Windows the temp file must be closed, otherwise mypy can't open it again. Unfortunately, we then loose the nice to read `with` sugar and obviously must call `os.remove` manually.
diff --git a/agent/features/support/hooks.rb b/agent/features/support/hooks.rb index <HASH>..<HASH> 100644 --- a/agent/features/support/hooks.rb +++ b/agent/features/support/hooks.rb @@ -27,3 +27,7 @@ Before("@stderr") do @stderr = StringIO.new eval("$stderr = @stderr") end + +After("@stdout") do + eval("$stdout = REAL_STDOUT") +end
not sure if we need these hooks
diff --git a/godet.go b/godet.go index <HASH>..<HASH> 100644 --- a/godet.go +++ b/godet.go @@ -246,13 +246,22 @@ func (remote *RemoteDebugger) socket() (ws *websocket.Conn) { } // Close the RemoteDebugger connection. -func (remote *RemoteDebugger) Close() error { - close(remote.closed) - err := remote.ws.Close() +func (remote *RemoteDebugger) Close() (err error) { + remote.Lock() + ws := remote.ws + remote.ws = nil + remote.Unlock() + + if ws != nil { // already closed + close(remote.closed) + err = ws.Close() + } + if remote.verbose { httpclient.StopLogging() } - return err + + return } type wsMessage struct {
Tweaking Close() so that it support multiple closes
diff --git a/classes/Divergence/Controllers/RequestHandler.php b/classes/Divergence/Controllers/RequestHandler.php index <HASH>..<HASH> 100644 --- a/classes/Divergence/Controllers/RequestHandler.php +++ b/classes/Divergence/Controllers/RequestHandler.php @@ -14,6 +14,8 @@ abstract class RequestHandler protected static $_path; protected static $_parameters; protected static $_options = array(); + + public static $pathStack; public static $templateDirectory; @@ -22,13 +24,13 @@ abstract class RequestHandler protected static function setPath($path = null) { - if(!Site::$pathStack) + if(!static::$pathStack) { $requestURI = parse_url($_SERVER['REQUEST_URI']); - Site::$pathStack = Site::$requestPath = explode('/', ltrim($requestURI['path'], '/')); + static::$pathStack = static::$requestPath = explode('/', ltrim($requestURI['path'], '/')); } - static::$_path = isset($path) ? $path : Site::$pathStack; + static::$_path = isset($path) ? $path : static::$pathStack; } protected static function setOptions($options)
Set $pathStack storage to RequestHandler instead of the no longer existant Site class
diff --git a/lib/discordrb/data.rb b/lib/discordrb/data.rb index <HASH>..<HASH> 100644 --- a/lib/discordrb/data.rb +++ b/lib/discordrb/data.rb @@ -1280,7 +1280,7 @@ module Discordrb @bitrate = data['bitrate'] @user_limit = data['user_limit'] @position = data['position'] - @nsfw = data['nsfw'] + @nsfw = data['nsfw'] || false if private? @recipients = []
default Channel#nsfw to false on initialization This is an optional field that may or may not be present. Particularly in GUILD_CREATE events for older guilds, it may be absent, and so channels would have a `nil` nsfw property. Since it could not have been set to `true`, we can default this to `false`.