diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/spec/unit/flame_spec.rb b/spec/unit/flame_spec.rb index abc1234..def5678 100644 --- a/spec/unit/flame_spec.rb +++ b/spec/unit/flame_spec.rb @@ -0,0 +1,10 @@+# frozen_string_literal: true +describe 'Flame' do + it 'should require all files when flame required' do + Dir[ + File.join(__dir__, '..', '..', '...
Add full unit spec for Flame requiring
diff --git a/app/views/api/timeslots/index.json.jbuilder b/app/views/api/timeslots/index.json.jbuilder index abc1234..def5678 100644 --- a/app/views/api/timeslots/index.json.jbuilder +++ b/app/views/api/timeslots/index.json.jbuilder @@ -3,4 +3,9 @@ json.title slot.tutor.name json.start slot.start json.end...
Add color to jbuilder for calendar events
diff --git a/spec/controllers/tags_controller_spec.rb b/spec/controllers/tags_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/tags_controller_spec.rb +++ b/spec/controllers/tags_controller_spec.rb @@ -23,5 +23,10 @@ get :show, {id: 2} expect(response.status).to eq(200) end + + ...
Add test for render show template
diff --git a/spec/fc-reminder/gateways/twilio_spec.rb b/spec/fc-reminder/gateways/twilio_spec.rb index abc1234..def5678 100644 --- a/spec/fc-reminder/gateways/twilio_spec.rb +++ b/spec/fc-reminder/gateways/twilio_spec.rb @@ -29,7 +29,7 @@ end it { expect(gateway).to respond_to(:send).with(2).arguments } - ...
Improve tests description for sending message using Twilio
diff --git a/spec/features/person_communities_spec.rb b/spec/features/person_communities_spec.rb index abc1234..def5678 100644 --- a/spec/features/person_communities_spec.rb +++ b/spec/features/person_communities_spec.rb @@ -1,6 +1,15 @@ require 'rails_helper' feature "Communities" do + around(:each) do |example| +...
Enable communities feature in its spec
diff --git a/spec/features/recoveries/resetting_your_password_spec.rb b/spec/features/recoveries/resetting_your_password_spec.rb index abc1234..def5678 100644 --- a/spec/features/recoveries/resetting_your_password_spec.rb +++ b/spec/features/recoveries/resetting_your_password_spec.rb @@ -6,7 +6,7 @@ user = FactoryG...
Update the test for recoveries
diff --git a/lib/rrj/tools/replaces/handle.rb b/lib/rrj/tools/replaces/handle.rb index abc1234..def5678 100644 --- a/lib/rrj/tools/replaces/handle.rb +++ b/lib/rrj/tools/replaces/handle.rb @@ -29,8 +29,8 @@ def replace_candidate cdn = type.convert(determine_key_candidate, opts) key = cdn[0...
Fix candidates || candidates used to transaction
diff --git a/lib/tasks/csp_reports_tasks.rake b/lib/tasks/csp_reports_tasks.rake index abc1234..def5678 100644 --- a/lib/tasks/csp_reports_tasks.rake +++ b/lib/tasks/csp_reports_tasks.rake @@ -1,24 +1,41 @@ namespace :csp_reports do desc "Populate CSP Violations Report" task populate: :environment do - user = ...
Refactor populate task to upsert more data to db
diff --git a/lib/trello/quarterly_progress.rb b/lib/trello/quarterly_progress.rb index abc1234..def5678 100644 --- a/lib/trello/quarterly_progress.rb +++ b/lib/trello/quarterly_progress.rb @@ -8,10 +8,7 @@ extend TrelloBoards def self.perform - h = { - '2014' => progress(2014), - '2013' => progr...
Refactor quarterly progress to include 2015
diff --git a/0_code_wars/leonardo_dicaprio.rb b/0_code_wars/leonardo_dicaprio.rb index abc1234..def5678 100644 --- a/0_code_wars/leonardo_dicaprio.rb +++ b/0_code_wars/leonardo_dicaprio.rb @@ -0,0 +1,10 @@+# http://www.codewars.com/kata/56d49587df52101de70011e4 +# --- iteration 1 --- +def leo(oscar) + return "Leo got ...
Add code wars (8) - leonardo dicaprio
diff --git a/config/initializers/session_store.rb b/config/initializers/session_store.rb index abc1234..def5678 100644 --- a/config/initializers/session_store.rb +++ b/config/initializers/session_store.rb @@ -4,7 +4,7 @@ :redis_store, # Using the cookie_store would enable session replay attacks. servers: Gitlab::A...
Enable secure option if https is used.
diff --git a/config/initializers/session_store.rb b/config/initializers/session_store.rb index abc1234..def5678 100644 --- a/config/initializers/session_store.rb +++ b/config/initializers/session_store.rb @@ -1,3 +1,3 @@ # Be sure to restart your server when you modify this file. -Rails.application.config.session_sto...
Set cookie_store domain to :all Signed-off-by: Max Fierke <0706025b2bbcec1ed8d64822f4eccd96314938d0@maxfierke.com>
diff --git a/spec/resources/web_config_spec.rb b/spec/resources/web_config_spec.rb index abc1234..def5678 100644 --- a/spec/resources/web_config_spec.rb +++ b/spec/resources/web_config_spec.rb @@ -21,4 +21,8 @@ resource.dynamic_template("random_water_boa.py") expect(resource.dynamic_template).to eq("random_wat...
Add default action test in graphite_web_config resource specs.
diff --git a/lib/crawl.rb b/lib/crawl.rb index abc1234..def5678 100644 --- a/lib/crawl.rb +++ b/lib/crawl.rb @@ -2,7 +2,7 @@ class Crawl attr_reader :url - + def initialize(url, avoid = []) @url = url @@ -17,8 +17,9 @@ end def skip?(url) - @avoid.any? { |a| - url.start_with? a - ...
Make Crawl more flexible about url types
diff --git a/config/initializers/session_store.rb b/config/initializers/session_store.rb index abc1234..def5678 100644 --- a/config/initializers/session_store.rb +++ b/config/initializers/session_store.rb @@ -1,7 +1,7 @@ # Be sure to restart your server when you modify this file. Rails.application.config.session_sto...
Allow the disabling secure cookies in Rails production environment The publishing end to end tests run Whitehall in Rails production mode so we can mimic how the app will behave in production as closely as possible. We haven't set up HTTPS however which means that the secure cookie marker is preventing the browser fr...
diff --git a/config/initializers/session_store.rb b/config/initializers/session_store.rb index abc1234..def5678 100644 --- a/config/initializers/session_store.rb +++ b/config/initializers/session_store.rb @@ -1,3 +1,3 @@ # Be sure to restart your server when you modify this file. -Rails.application.config.session_sto...
Change session validity to 1 month
diff --git a/spec/default_spec.rb b/spec/default_spec.rb index abc1234..def5678 100644 --- a/spec/default_spec.rb +++ b/spec/default_spec.rb @@ -6,11 +6,6 @@ runner.converge 'nrpe::default' end - it 'does not blow up when the search returns no results' do - stub_search(:role, 'monitoring').and_return([]) -...
Remove spec that didn't actually do anything Doesn’t fail even if not mocked.
diff --git a/test/cookbooks/lxctests/recipes/install_lxc.rb b/test/cookbooks/lxctests/recipes/install_lxc.rb index abc1234..def5678 100644 --- a/test/cookbooks/lxctests/recipes/install_lxc.rb +++ b/test/cookbooks/lxctests/recipes/install_lxc.rb @@ -13,7 +13,7 @@ end.run_action(:install) end -execute 'add-apt-repos...
Use LXC stable, not daily
diff --git a/lib/libra2/app/controllers/concerns/authentication_behavior.rb b/lib/libra2/app/controllers/concerns/authentication_behavior.rb index abc1234..def5678 100644 --- a/lib/libra2/app/controllers/concerns/authentication_behavior.rb +++ b/lib/libra2/app/controllers/concerns/authentication_behavior.rb @@ -19,10 +...
Fix 500 error when requesting the favicon when not logged in.
diff --git a/lib/fog/aws/parsers/storage/get_bucket.rb b/lib/fog/aws/parsers/storage/get_bucket.rb index abc1234..def5678 100644 --- a/lib/fog/aws/parsers/storage/get_bucket.rb +++ b/lib/fog/aws/parsers/storage/get_bucket.rb @@ -26,7 +26,7 @@ when 'DisplayName', 'ID' @object['Owner'][name] = ...
Fix for empty ETag values Fog aws fails if API response contains empty ETag tags. It may cause when working with S3 clones (like minio in my case), that not provides ETags in their API answer.
diff --git a/app/controllers/events_controller.rb b/app/controllers/events_controller.rb index abc1234..def5678 100644 --- a/app/controllers/events_controller.rb +++ b/app/controllers/events_controller.rb @@ -19,9 +19,9 @@ session[:redirect_url] = "/events/#{params[:id]}" end @event = Event.find(params[...
Revise nudges code to refer to Student instead of User
diff --git a/app/controllers/static_controller.rb b/app/controllers/static_controller.rb index abc1234..def5678 100644 --- a/app/controllers/static_controller.rb +++ b/app/controllers/static_controller.rb @@ -4,7 +4,7 @@ def index page = (params[:id] || 'index').gsub /[^A-z0-9_\-]/, '' @favorites = if curre...
Fix possible bug empty?/any?/each on nil for anonymous user on @favorites.
diff --git a/Casks/zendstudio.rb b/Casks/zendstudio.rb index abc1234..def5678 100644 --- a/Casks/zendstudio.rb +++ b/Casks/zendstudio.rb @@ -1,6 +1,6 @@ cask :v1 => 'zendstudio' do - version '12.0.1' - sha256 'e8534e6b550e075b5da42c5b1789e82b3c9e04c739f055c6980783742f6e1160' + version '13.0.0' + sha256 '3ed2492801c...
Update Zend Studio to 13.0.0
diff --git a/last-stop/app/controllers/stops_controller.rb b/last-stop/app/controllers/stops_controller.rb index abc1234..def5678 100644 --- a/last-stop/app/controllers/stops_controller.rb +++ b/last-stop/app/controllers/stops_controller.rb @@ -1,6 +1,7 @@ class StopsController < ApplicationController def index - ...
Update stops controller to return JSON
diff --git a/DPMeterView.podspec b/DPMeterView.podspec index abc1234..def5678 100644 --- a/DPMeterView.podspec +++ b/DPMeterView.podspec @@ -10,6 +10,5 @@ s.requires_arc = true s.ios.deployment_target = '5.0' - s.osx.deployment_target = '10.7' s.frameworks = 'QuartzCore', 'CoreMotion' end
Remove osx deployment target from podspec
diff --git a/lib/olson.rb b/lib/olson.rb index abc1234..def5678 100644 --- a/lib/olson.rb +++ b/lib/olson.rb @@ -1,4 +1,4 @@+require 'active_support/concern' require 'olson/instance_methods' require 'olson/class_methods' require 'olson/version' -require 'active_support/concern'
Fix order of require statements
diff --git a/lib/generators/awe/update/update_generator.rb b/lib/generators/awe/update/update_generator.rb index abc1234..def5678 100644 --- a/lib/generators/awe/update/update_generator.rb +++ b/lib/generators/awe/update/update_generator.rb @@ -1,4 +1,5 @@ require 'rails' +require 'open-uri' module Awe module Gen...
Update the awe:update action to dynamically figure out which files are available Also, we now copy the files directly into the appropriate javascripts directory.
diff --git a/lib/gyaazle.rb b/lib/gyaazle.rb index abc1234..def5678 100644 --- a/lib/gyaazle.rb +++ b/lib/gyaazle.rb @@ -1,3 +1,5 @@+require "fileutils" + require "httpclient" require "multi_json" require "nokogiri"
Fix error on some platform (my Mac)
diff --git a/test/test_validation_with_errors.rb b/test/test_validation_with_errors.rb index abc1234..def5678 100644 --- a/test/test_validation_with_errors.rb +++ b/test/test_validation_with_errors.rb @@ -12,11 +12,11 @@ assert_equal(errors.size, test_case["errors"].size, "Expected #{test_case["errors"].size} err...
Put arguments to assert_equal in correct order
diff --git a/spec/plugins_spec.rb b/spec/plugins_spec.rb index abc1234..def5678 100644 --- a/spec/plugins_spec.rb +++ b/spec/plugins_spec.rb @@ -0,0 +1,68 @@+require 'spec_helper' + +module Pathway + describe Operation do + module SimplePlugin + module InstanceMethods + def foo; end + end + + ...
Add tests for plugin activation
diff --git a/config/application.rb b/config/application.rb index abc1234..def5678 100644 --- a/config/application.rb +++ b/config/application.rb @@ -24,8 +24,4 @@ require 'publify_version' Theme.register_themes "#{Rails.root}/themes" - - Date::DATE_FORMATS.merge!( - :long_weekday => '%a %B %e, %Y %H:%M' - )...
Remove unused long_weekday date format
diff --git a/config/application.rb b/config/application.rb index abc1234..def5678 100644 --- a/config/application.rb +++ b/config/application.rb @@ -19,9 +19,5 @@ # The default locale is :en and all translations from config/locales/*.rb,yml are auto loaded. # config.i18n.load_path += Dir[Rails.root.join('my', ...
Revert "Include docs in static assets to be served" This reverts commit 383c70d57cb2cd3a931d1208eb590148c1954066.
diff --git a/matcher.rb b/matcher.rb index abc1234..def5678 100644 --- a/matcher.rb +++ b/matcher.rb @@ -20,9 +20,9 @@ end end - def match_regexp pattern + def match_regexp regexp lambda do |string, index = 0| - found = pattern.match(string) + found = regexp.match(string) found.to_s i...
Change variable name to avoid confusion
diff --git a/filewatcher.gemspec b/filewatcher.gemspec index abc1234..def5678 100644 --- a/filewatcher.gemspec +++ b/filewatcher.gemspec @@ -2,12 +2,10 @@ require_relative 'lib/filewatcher' require_relative 'lib/filewatcher/version' -require 'date' Gem::Specification.new do |s| s.name = 'filewatcher' ...
Remove `Date.today` from gem spec It's the default.
diff --git a/repeatable.gemspec b/repeatable.gemspec index abc1234..def5678 100644 --- a/repeatable.gemspec +++ b/repeatable.gemspec @@ -16,6 +16,6 @@ spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) } spec.require_paths = ['lib'] - spec.add_development_depend...
Bump rake version for CVE More details: https://git.io/Jmxhp
diff --git a/spec/support/body.rb b/spec/support/body.rb index abc1234..def5678 100644 --- a/spec/support/body.rb +++ b/spec/support/body.rb @@ -6,7 +6,7 @@ private def body_for(value, verb) - return "" if verb.casecmp?("head") + return "" if verb.downcase == "head" # rubocop:disable Perfor...
Fix build for 2.3 and JRuby
diff --git a/app/workers/import_workers/finaliser_worker.rb b/app/workers/import_workers/finaliser_worker.rb index abc1234..def5678 100644 --- a/app/workers/import_workers/finaliser_worker.rb +++ b/app/workers/import_workers/finaliser_worker.rb @@ -26,6 +26,7 @@ # we can't get from the WDPA CmsTransfer.transfe...
Call ActiveStorageTransfer module in FinaliserWorker
diff --git a/lib/infinity_test/framework/helpers.rb b/lib/infinity_test/framework/helpers.rb index abc1234..def5678 100644 --- a/lib/infinity_test/framework/helpers.rb +++ b/lib/infinity_test/framework/helpers.rb @@ -4,6 +4,7 @@ # Run all the strategy again. # def RunAll + continuous_test_ser...
Make run all method a call to the run_strategy on continuous server object.
diff --git a/lib/mongoid/mapreduce/serialization.rb b/lib/mongoid/mapreduce/serialization.rb index abc1234..def5678 100644 --- a/lib/mongoid/mapreduce/serialization.rb +++ b/lib/mongoid/mapreduce/serialization.rb @@ -11,7 +11,9 @@ def serialize(obj, klass) return nil if obj.blank? obj = obj.is_a...
Change method for converting numbers to ruby objects
diff --git a/lib/whatsapp/protocol/iq_media_node.rb b/lib/whatsapp/protocol/iq_media_node.rb index abc1234..def5678 100644 --- a/lib/whatsapp/protocol/iq_media_node.rb +++ b/lib/whatsapp/protocol/iq_media_node.rb @@ -4,8 +4,14 @@ module Protocol class IqMediaNode < Node + attr_reader :fingerprint, :type, ...
Add media iq nodes to messages queue
diff --git a/lib/docs/scrapers/vue.rb b/lib/docs/scrapers/vue.rb index abc1234..def5678 100644 --- a/lib/docs/scrapers/vue.rb +++ b/lib/docs/scrapers/vue.rb @@ -3,8 +3,6 @@ self.name = 'Vue.js' self.slug = 'vue' self.type = 'vue' - self.root_path = '/guide/index.html' - self.initial_paths = %w(/api/...
Update Vue.js documentation (2.0.5, 1.0.28)
diff --git a/lib/ircmad/irc_client.rb b/lib/ircmad/irc_client.rb index abc1234..def5678 100644 --- a/lib/ircmad/irc_client.rb +++ b/lib/ircmad/irc_client.rb @@ -5,32 +5,38 @@ def initialize(&block) instance_eval(&block) if block_given? - unless @zircon - @zircon = Zircon.new config + @clie...
Check whether posted message is valid JSON
diff --git a/name_resolution/name_resolver.rb b/name_resolution/name_resolver.rb index abc1234..def5678 100644 --- a/name_resolution/name_resolver.rb +++ b/name_resolution/name_resolver.rb @@ -0,0 +1,21 @@+require 'resolv' + +class NameResolver < Scout::Plugin + OPTIONS=<<-EOS + nameserver: + default: 8.8.8.8 ...
Create domain name resolver plugin Takes a nameserver and resolve_address as input and raises an alert if resolution fails
diff --git a/app/helpers/sessions_helper.rb b/app/helpers/sessions_helper.rb index abc1234..def5678 100644 --- a/app/helpers/sessions_helper.rb +++ b/app/helpers/sessions_helper.rb @@ -1,2 +1,18 @@ module SessionsHelper + def current_user + @current_user ||= User.find_by_id(session[:user_id]) if session[:user_id] +...
Add session helper module for quick session changes
diff --git a/ruby-manta.gemspec b/ruby-manta.gemspec index abc1234..def5678 100644 --- a/ruby-manta.gemspec +++ b/ruby-manta.gemspec @@ -9,6 +9,7 @@ s.authors = ['Joyent'] s.email = 'marsell@joyent.com' s.homepage = 'http://github.com/joyent/ruby-manta/' + s.license = 'MIT' s.add_dependen...
Add license type to gemspec.
diff --git a/app/models/metrics/licenses.rb b/app/models/metrics/licenses.rb index abc1234..def5678 100644 --- a/app/models/metrics/licenses.rb +++ b/app/models/metrics/licenses.rb @@ -16,7 +16,7 @@ end def compute(record) - license = record['license_id'].gsub('.', "\uff0e") + license = record['lic...
Add a maybe statement to the license substitution The license identifier might be null, hence I have added a maybe statement. Signed-off-by: Konrad Reiche <4ff0213f56e2082fcd8c882d04c546881c579ce4@gmail.com>
diff --git a/db/migrate/20160125222418_create_reviews.rb b/db/migrate/20160125222418_create_reviews.rb index abc1234..def5678 100644 --- a/db/migrate/20160125222418_create_reviews.rb +++ b/db/migrate/20160125222418_create_reviews.rb @@ -3,6 +3,7 @@ create_table :reviews do |t| t.integer :film_id t.int...
Add title field to review table
diff --git a/simple_state_machine.gemspec b/simple_state_machine.gemspec index abc1234..def5678 100644 --- a/simple_state_machine.gemspec +++ b/simple_state_machine.gemspec @@ -15,7 +15,6 @@ s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) } s.rdoc_options = ["--charset=UTF-8"...
Remove old rubygesm version requirement
diff --git a/simplecov-rcov-setup.gemspec b/simplecov-rcov-setup.gemspec index abc1234..def5678 100644 --- a/simplecov-rcov-setup.gemspec +++ b/simplecov-rcov-setup.gemspec @@ -21,7 +21,7 @@ spec.add_dependency 'simplecov-rcov', '~> 0.2.3' - spec.add_development_dependency 'bundler', '~> 1.7' + spec.add_develop...
Update bundler requirement from ~> 1.7 to ~> 2.1 Updates the requirements on [bundler](https://github.com/bundler/bundler) to permit the latest version. - [Release notes](https://github.com/bundler/bundler/releases) - [Changelog](https://github.com/rubygems/bundler/blob/master/CHANGELOG.md) - [Commits](https://github....
diff --git a/bruce.rb b/bruce.rb index abc1234..def5678 100644 --- a/bruce.rb +++ b/bruce.rb @@ -1,8 +1,18 @@ require 'minitest/autorun' +require 'pry' + +class Banner + attr_reader :name, :weight + + def initialize(name, weight=1) + @name = name + @weight = weight + end +end class RandomBanner - def initi...
Add Banner class, add sanity check.
diff --git a/asciidoctor-diagram-d3js.gemspec b/asciidoctor-diagram-d3js.gemspec index abc1234..def5678 100644 --- a/asciidoctor-diagram-d3js.gemspec +++ b/asciidoctor-diagram-d3js.gemspec @@ -21,5 +21,6 @@ spec.add_development_dependency "bundler", "~> 1.7" spec.add_development_dependency "rake", "~> 10.0" - s...
Add runtime dependency to asciidoctor-diagram
diff --git a/source/blog/feed.xml.builder b/source/blog/feed.xml.builder index abc1234..def5678 100644 --- a/source/blog/feed.xml.builder +++ b/source/blog/feed.xml.builder @@ -0,0 +1,23 @@+xml.instruct! +xml.feed "xmlns" => "http://www.w3.org/2005/Atom" do + xml.title "Portland Code School News and Announcements" + ...
Add RSS feed builder. Still to do: Add link to RSS in footer and on blog page
diff --git a/acceptance/tests/storeconfigs/collections_with_queries.rb b/acceptance/tests/storeconfigs/collections_with_queries.rb index abc1234..def5678 100644 --- a/acceptance/tests/storeconfigs/collections_with_queries.rb +++ b/acceptance/tests/storeconfigs/collections_with_queries.rb @@ -0,0 +1,85 @@+test_name "col...
Add an acceptance test for storeconfigs queries This tests queries against a property, both == and !=.
diff --git a/onkcop.gemspec b/onkcop.gemspec index abc1234..def5678 100644 --- a/onkcop.gemspec +++ b/onkcop.gemspec @@ -19,7 +19,7 @@ spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } spec.require_paths = ["lib"] - spec.add_dependency "rubocop", "~> 0.46.0" + spec.add_dependency "ruboco...
Update rubocop dependency version to >= 0.47.1
diff --git a/db/migrate/20160504112519_add_run_untagged_to_ci_runner.rb b/db/migrate/20160504112519_add_run_untagged_to_ci_runner.rb index abc1234..def5678 100644 --- a/db/migrate/20160504112519_add_run_untagged_to_ci_runner.rb +++ b/db/migrate/20160504112519_add_run_untagged_to_ci_runner.rb @@ -1,11 +1,13 @@ class Add...
Use migration helper to prevent downtime migration
diff --git a/Casks/omnifocus-beta.rb b/Casks/omnifocus-beta.rb index abc1234..def5678 100644 --- a/Casks/omnifocus-beta.rb +++ b/Casks/omnifocus-beta.rb @@ -0,0 +1,18 @@+cask :v1 => 'omnifocus-beta' do + version '2.2.x-r233653' + sha256 '6dbec967be6ad55dc6def5c3284979257e2c10e7a6d9fa3b09c1abd587ac7172' + + url "http...
Add the OmniFocus beta/test builds This commit adds the OmniFocus beta/test stream.
diff --git a/Casks/vmware-fusion7.rb b/Casks/vmware-fusion7.rb index abc1234..def5678 100644 --- a/Casks/vmware-fusion7.rb +++ b/Casks/vmware-fusion7.rb @@ -0,0 +1,29 @@+cask :v1 => 'vmware-fusion7' do + version '7.1.2-2779224' + sha256 '93e809ece4f915fcb462affabfce2d7c85eb08314b548e2cde44cb2a67ad7d76' + + url "http...
Add cask for VMware Fusion 7
diff --git a/app/controllers/corporate_information_pages_controller.rb b/app/controllers/corporate_information_pages_controller.rb index abc1234..def5678 100644 --- a/app/controllers/corporate_information_pages_controller.rb +++ b/app/controllers/corporate_information_pages_controller.rb @@ -18,6 +18,8 @@ @corporat...
Make non-action controller methods private
diff --git a/vendor/plugins/themes/rails/init.rb b/vendor/plugins/themes/rails/init.rb index abc1234..def5678 100644 --- a/vendor/plugins/themes/rails/init.rb +++ b/vendor/plugins/themes/rails/init.rb @@ -1,29 +1,32 @@-# Set up middleware to serve theme files -config.middleware.use "ThemeServer" +# Before the applicati...
Fix themes breaking rake db:setup because RefinerySetting.table_exists? is false.
diff --git a/capistrano-nvie-git-workflow.gemspec b/capistrano-nvie-git-workflow.gemspec index abc1234..def5678 100644 --- a/capistrano-nvie-git-workflow.gemspec +++ b/capistrano-nvie-git-workflow.gemspec @@ -8,8 +8,8 @@ gem.version = CapistranoNvieGitWorkflow::VERSION gem.authors = ["Steve Valaitis"] ...
Update gemspec summary and description
diff --git a/app/admin/users.rb b/app/admin/users.rb index abc1234..def5678 100644 --- a/app/admin/users.rb +++ b/app/admin/users.rb @@ -1,4 +1,6 @@ ActiveAdmin.register User do + + scope :wants_newsletter index do column :first_name @@ -11,5 +13,18 @@ default_actions end - scope :wants_newsletter ...
Edit user form in admin backend.
diff --git a/lib/foodcritic/rake_task.rb b/lib/foodcritic/rake_task.rb index abc1234..def5678 100644 --- a/lib/foodcritic/rake_task.rb +++ b/lib/foodcritic/rake_task.rb @@ -24,8 +24,11 @@ desc "Lint Chef cookbooks" task(name) do result = FoodCritic::Linter.new.check(files, options) - ...
Reduce unnecessary blank lines from console output if there's nothing to print. We only print the food critic reviews if there's a warning and fail with a proper message if there's any.
diff --git a/lib/goodyear/query_cache.rb b/lib/goodyear/query_cache.rb index abc1234..def5678 100644 --- a/lib/goodyear/query_cache.rb +++ b/lib/goodyear/query_cache.rb @@ -7,6 +7,7 @@ def cache_query(query) cache_key = sha(query) + Goodyear.force_cache result = if store.exist?(cache_key) && Go...
Use force cache only when needed
diff --git a/app/models/item.rb b/app/models/item.rb index abc1234..def5678 100644 --- a/app/models/item.rb +++ b/app/models/item.rb @@ -5,7 +5,8 @@ has_many :order_items has_many :orders, through: :order_items - validates :title, :description, :price, :inventory_status, :image, presence: true + validates :tit...
Move validation to new line Style for 80 char limit.
diff --git a/config/initializers/session_store.rb b/config/initializers/session_store.rb index abc1234..def5678 100644 --- a/config/initializers/session_store.rb +++ b/config/initializers/session_store.rb @@ -11,7 +11,7 @@ # www.interconlarp.org becomes interconlarp.org second_level_domain = just_hostname.split("....
Make sure the cookie will work for subdomains
diff --git a/lib/datadog/notifications/config.rb b/lib/datadog/notifications/config.rb index abc1234..def5678 100644 --- a/lib/datadog/notifications/config.rb +++ b/lib/datadog/notifications/config.rb @@ -1,12 +1,13 @@ module Datadog class Notifications class Config - attr_accessor :hostname, :namespace, :...
Support socket path when initializing dogstatsd
diff --git a/lib/oshpark/remote_model.rb b/lib/oshpark/remote_model.rb index abc1234..def5678 100644 --- a/lib/oshpark/remote_model.rb +++ b/lib/oshpark/remote_model.rb @@ -2,6 +2,10 @@ module Oshpark module RemoteModel + + def self.included base + base.extend ClassMethods + end def save! ...
Fix bug where class methods were not being extended.
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -5,11 +5,11 @@ def deposit(amount) self.balance_cents += amount - save + save! end def payment(amount) self.balance_cents -= amount - save + save! en...
Use save! in deposit/payment methods
diff --git a/lib/rom/support/registry.rb b/lib/rom/support/registry.rb index abc1234..def5678 100644 --- a/lib/rom/support/registry.rb +++ b/lib/rom/support/registry.rb @@ -3,6 +3,7 @@ # @api private class Registry include Enumerable + include Equalizer.new(:elements) attr_reader :elements
Handle lack of schema gracefully while booting * Fix correct class for reader registry * Fix inspect for Boot
diff --git a/guides/rails_guides/helpers_ja.rb b/guides/rails_guides/helpers_ja.rb index abc1234..def5678 100644 --- a/guides/rails_guides/helpers_ja.rb +++ b/guides/rails_guides/helpers_ja.rb @@ -13,11 +13,11 @@ def docs_for_sitemap(position) case position when "L" - documents_by_section.t...
Add and sort guides with new genre '他の構成要素' in Footer
diff --git a/lib/stackprof/middleware.rb b/lib/stackprof/middleware.rb index abc1234..def5678 100644 --- a/lib/stackprof/middleware.rb +++ b/lib/stackprof/middleware.rb @@ -31,13 +31,14 @@ attr_accessor :enabled, :mode, :interval, :path alias enabled? enabled - def save + def save(filename = ni...
Allow for passing a specific filename to Middleware.save Also return the filename instead of the return value of .open() This allows for overwritting the same file when calling .save manually as well as keeping track of the exact file written (using the return value)
diff --git a/db/migrate/20190206235628_change_document_id_to_bigint.rb b/db/migrate/20190206235628_change_document_id_to_bigint.rb index abc1234..def5678 100644 --- a/db/migrate/20190206235628_change_document_id_to_bigint.rb +++ b/db/migrate/20190206235628_change_document_id_to_bigint.rb @@ -0,0 +1,9 @@+class ChangeDoc...
Update document_id primary key to bigint
diff --git a/lib/elastic_record/index/mapping.rb b/lib/elastic_record/index/mapping.rb index abc1234..def5678 100644 --- a/lib/elastic_record/index/mapping.rb +++ b/lib/elastic_record/index/mapping.rb @@ -30,8 +30,7 @@ match_mapping_type: "string", mapping: { type: "s...
Remove a case of the doc_values
diff --git a/lib/heroku_rails_deflate/railtie.rb b/lib/heroku_rails_deflate/railtie.rb index abc1234..def5678 100644 --- a/lib/heroku_rails_deflate/railtie.rb +++ b/lib/heroku_rails_deflate/railtie.rb @@ -4,7 +4,14 @@ module HerokuRailsDeflate class Railtie < Rails::Railtie initializer "heroku_rails_deflate.mid...
Put deflator in the right place -- If caching is turned on, put deflator immediately after Rack::Cache
diff --git a/lib/ohm/contrib/date_validations.rb b/lib/ohm/contrib/date_validations.rb index abc1234..def5678 100644 --- a/lib/ohm/contrib/date_validations.rb +++ b/lib/ohm/contrib/date_validations.rb @@ -2,11 +2,11 @@ module Ohm module DateValidations - DATE = /\A([0-9]{4})-([01]?[0-9])-([0123]?[0-9])\z/ + ...
Change DATE to DATE_REGEX for consistency.
diff --git a/lib/open_actions/tweet_at_target.rb b/lib/open_actions/tweet_at_target.rb index abc1234..def5678 100644 --- a/lib/open_actions/tweet_at_target.rb +++ b/lib/open_actions/tweet_at_target.rb @@ -12,8 +12,29 @@ end copy_strings do - noun 'tweet' leader_description '<strong>Tweet at someo...
Add action strings for Twitter
diff --git a/lib/tasks/auto_annotate_models.rake b/lib/tasks/auto_annotate_models.rake index abc1234..def5678 100644 --- a/lib/tasks/auto_annotate_models.rake +++ b/lib/tasks/auto_annotate_models.rake @@ -1,5 +1,12 @@ if Rails.env.development? - Annotate.set_defaults("exclude_tests" => "true", "sort" => "true") + Ann...
Exclude some of annotate gem's new annotations
diff --git a/lib/travis/worker/workers/resque.rb b/lib/travis/worker/workers/resque.rb index abc1234..def5678 100644 --- a/lib/travis/worker/workers/resque.rb +++ b/lib/travis/worker/workers/resque.rb @@ -20,10 +20,6 @@ stop_processing requeue raise $! - end - - def shell -...
Remove one more unused methods
diff --git a/cookbooks/wt_edge_server/attributes/default.rb b/cookbooks/wt_edge_server/attributes/default.rb index abc1234..def5678 100644 --- a/cookbooks/wt_edge_server/attributes/default.rb +++ b/cookbooks/wt_edge_server/attributes/default.rb @@ -1,5 +1,5 @@ # -# Cookbook Name:: wt_collection_services +# Cookbook Nam...
Fix attribute name for edge server
diff --git a/spec/rails_spec.rb b/spec/rails_spec.rb index abc1234..def5678 100644 --- a/spec/rails_spec.rb +++ b/spec/rails_spec.rb @@ -6,8 +6,16 @@ cache.rmtree if cache.exist? end + def test_file(file) + if Rails.version.split('.').first.to_i >= 5 + get :test, params: { file: 'sass' } + else + ...
Fix specs for old Rails
diff --git a/spec/rbNFA_spec.rb b/spec/rbNFA_spec.rb index abc1234..def5678 100644 --- a/spec/rbNFA_spec.rb +++ b/spec/rbNFA_spec.rb @@ -8,20 +8,39 @@ end it "can math string" do + pending("to implementig other") regexp = Regexp.new("a") regexp.match("aaa").should be_true end ...
Add basic requirements to lexer
diff --git a/features/support/knows_the_domain.rb b/features/support/knows_the_domain.rb index abc1234..def5678 100644 --- a/features/support/knows_the_domain.rb +++ b/features/support/knows_the_domain.rb @@ -1,6 +1,8 @@+require 'dawg' + module KnowsTheDomain def my_dawg - @my_dawg ||= Dawg::Node.new + @my_dawg ||...
Change my_dawg from Dawg::Node to Dawg
diff --git a/lib/web_console/template.rb b/lib/web_console/template.rb index abc1234..def5678 100644 --- a/lib/web_console/template.rb +++ b/lib/web_console/template.rb @@ -18,7 +18,7 @@ # Render a template (inferred from +template_paths+) as a plain string. def render(template) - view = View.new(templa...
Fix the Rails 6 ActionView::Base instantiation deprecations
diff --git a/features/steps/negative_comparison_steps.rb b/features/steps/negative_comparison_steps.rb index abc1234..def5678 100644 --- a/features/steps/negative_comparison_steps.rb +++ b/features/steps/negative_comparison_steps.rb @@ -1,6 +1,6 @@ Then("the error payload field {string} does not equal {string}") do |fi...
Update compare routine name [full ci]
diff --git a/lib/rails_script/loader_helper.rb b/lib/rails_script/loader_helper.rb index abc1234..def5678 100644 --- a/lib/rails_script/loader_helper.rb +++ b/lib/rails_script/loader_helper.rb @@ -9,6 +9,11 @@ return $this.#{ action_name }.call(); } }); + + jQuery(document).on('page:before-change', funct...
Remove event handlers on window and document when the page changes.
diff --git a/lib/saulabs/reportable/railtie.rb b/lib/saulabs/reportable/railtie.rb index abc1234..def5678 100644 --- a/lib/saulabs/reportable/railtie.rb +++ b/lib/saulabs/reportable/railtie.rb @@ -1,4 +1,5 @@ require 'saulabs/reportable' +require 'saulabs/reportable/report_tag_helper' require 'rails' module Saulabs...
Fix booting with a rails 3.x app.
diff --git a/config/initializers/paperclip.rb b/config/initializers/paperclip.rb index abc1234..def5678 100644 --- a/config/initializers/paperclip.rb +++ b/config/initializers/paperclip.rb @@ -36,4 +36,11 @@ end end +module PaperclipImageErrors + def mark_invalid(record, attribute, types) + record.errors.add a...
Patch keyword arguments syntax in Paperclip error handling
diff --git a/src/modules/module_monkey.rb b/src/modules/module_monkey.rb index abc1234..def5678 100644 --- a/src/modules/module_monkey.rb +++ b/src/modules/module_monkey.rb @@ -1,24 +1,18 @@ require "yaml" -class Bot - def monkey_initialize(bot) - @monkey = Monkey.new(@base_path, @module_config["monkey_file"]) - ...
Convert monkey module to new format Signed-off-by: Aki Saarinen <278bc57fbbff6b7b38435aea0f9d37e3d879167e@akisaarinen.fi>
diff --git a/cookbooks/kernel/kernel-4.1.1.rb b/cookbooks/kernel/kernel-4.1.1.rb index abc1234..def5678 100644 --- a/cookbooks/kernel/kernel-4.1.1.rb +++ b/cookbooks/kernel/kernel-4.1.1.rb @@ -14,7 +14,6 @@ git build_dir do repository "https://github.com/matsumoto-r/build-kernel-4.x-for-centos6.git" - not_if "tes...
Use :sync for git resource
diff --git a/app/controllers/authors_controller.rb b/app/controllers/authors_controller.rb index abc1234..def5678 100644 --- a/app/controllers/authors_controller.rb +++ b/app/controllers/authors_controller.rb @@ -4,7 +4,7 @@ def create author = Author.create author_params - respond_with author, serializer: ...
Return Author Collection from create action
diff --git a/app/controllers/locales_controller.rb b/app/controllers/locales_controller.rb index abc1234..def5678 100644 --- a/app/controllers/locales_controller.rb +++ b/app/controllers/locales_controller.rb @@ -17,7 +17,7 @@ return if @path.blank? return @path + '/new' if path_matches ROUTES_FOR_NEW ret...
Fix error in locale path normalization
diff --git a/app/controllers/parties_controller.rb b/app/controllers/parties_controller.rb index abc1234..def5678 100644 --- a/app/controllers/parties_controller.rb +++ b/app/controllers/parties_controller.rb @@ -10,6 +10,10 @@ @representatives = @party.current_representatives @representatives = @representativ...
Fix title of party proposition feed.
diff --git a/lib/generators/storytime/views_generator.rb b/lib/generators/storytime/views_generator.rb index abc1234..def5678 100644 --- a/lib/generators/storytime/views_generator.rb +++ b/lib/generators/storytime/views_generator.rb @@ -9,12 +9,31 @@ argument :scope, :required => false, :default => nil, ...
Add option to copy specific views to host app
diff --git a/lib/licensee/matchers/dist_zilla_matcher.rb b/lib/licensee/matchers/dist_zilla_matcher.rb index abc1234..def5678 100644 --- a/lib/licensee/matchers/dist_zilla_matcher.rb +++ b/lib/licensee/matchers/dist_zilla_matcher.rb @@ -3,9 +3,7 @@ class DistZilla < Package attr_reader :file - LICENSE...
Simplify license regex and replace . with _ character
diff --git a/app/helpers/ember_cli_rails_helper.rb b/app/helpers/ember_cli_rails_helper.rb index abc1234..def5678 100644 --- a/app/helpers/ember_cli_rails_helper.rb +++ b/app/helpers/ember_cli_rails_helper.rb @@ -1,9 +1,9 @@ module EmberCLIRailsHelper - def include_ember_script_tags(name) - javascript_include_tag *...
Allow helpers to take options for ember assets
diff --git a/pages/app/controllers/constructor_pages/templates_controller.rb b/pages/app/controllers/constructor_pages/templates_controller.rb index abc1234..def5678 100644 --- a/pages/app/controllers/constructor_pages/templates_controller.rb +++ b/pages/app/controllers/constructor_pages/templates_controller.rb @@ -6,7...
Change template before_filter for only new and edit
diff --git a/spec/jobs/raw_input_transform_job_spec.rb b/spec/jobs/raw_input_transform_job_spec.rb index abc1234..def5678 100644 --- a/spec/jobs/raw_input_transform_job_spec.rb +++ b/spec/jobs/raw_input_transform_job_spec.rb @@ -4,7 +4,7 @@ describe '#perform' do context 'with a new record' do it 'creates...
Remove useless info in spec
diff --git a/lib/app/users.rb b/lib/app/users.rb index abc1234..def5678 100644 --- a/lib/app/users.rb +++ b/lib/app/users.rb @@ -3,6 +3,7 @@ get '/:username' do |username| user = User.where(username: username).first halt 404 unless user + title(user.username) erb :user, locals: {user: user, current:...
Add <title> on user page
diff --git a/app/services/remove_status_service.rb b/app/services/remove_status_service.rb index abc1234..def5678 100644 --- a/app/services/remove_status_service.rb +++ b/app/services/remove_status_service.rb @@ -34,7 +34,7 @@ end def send_delete_salmon(account, status) - NotificationWorker.perform_async(stat...
Fix remove status service sending salmons
diff --git a/hello.rb b/hello.rb index abc1234..def5678 100644 --- a/hello.rb +++ b/hello.rb @@ -8,7 +8,7 @@ # response to '/' url get '/' do - "This is the index page" + "<h1>This is the index page<h1>" end # response to '/hello' url
Add h1 tag to index page