diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/spec/lib/gitometer/warden_helpers_spec.rb b/spec/lib/gitometer/warden_helpers_spec.rb index abc1234..def5678 100644 --- a/spec/lib/gitometer/warden_helpers_spec.rb +++ b/spec/lib/gitometer/warden_helpers_spec.rb @@ -0,0 +1,17 @@+require 'spec_helper' + +module Gitometer + class WardenHelped; include Warde...
Add pending specs until we figure out how to test warden.
diff --git a/resources/habitat_build.rb b/resources/habitat_build.rb index abc1234..def5678 100644 --- a/resources/habitat_build.rb +++ b/resources/habitat_build.rb @@ -13,6 +13,7 @@ property :artifact, String property :home_dir, String property :auth_token, String +property :live_stream, Boolean, default: true ac...
Add ability to toggle live stream for hab_build resource Signed-off-by: Elliott Davis <ddda907ff26ca0abaafd09579d559b51098ffe8e@chef.io>
diff --git a/web/test/test_web.rb b/web/test/test_web.rb index abc1234..def5678 100644 --- a/web/test/test_web.rb +++ b/web/test/test_web.rb @@ -34,6 +34,9 @@ def test_visualizations get '/visualizations' assert last_response.ok? - assert last_response.body.include? '<h1>Number of Packages per Ruby Target:</h1>...
Correct heading sizes in tests for visualization page
diff --git a/spec/poof_bang_spec.rb b/spec/poof_bang_spec.rb index abc1234..def5678 100644 --- a/spec/poof_bang_spec.rb +++ b/spec/poof_bang_spec.rb @@ -5,6 +5,9 @@ describe '#poof!' do before(:all) do + + RSpec.configure { |conf| conf.include Poof::Syntax } + ActiveRecord::Base.logger = Logger.new...
Make the spec less confusing - technically poof! is a class method, but is intended to be used as an instance method by include
diff --git a/spec/support/sequel.rb b/spec/support/sequel.rb index abc1234..def5678 100644 --- a/spec/support/sequel.rb +++ b/spec/support/sequel.rb @@ -2,6 +2,7 @@ DB = Sequel.sqlite # in memory Sequel.extension :migration Sequel::Migrator.run(DB, 'spec/support/sequel_migrations', :current => 0) + Sequel::Mod...
Set Sequel strict_param_setting globally for models
diff --git a/spec/versioner_spec.rb b/spec/versioner_spec.rb index abc1234..def5678 100644 --- a/spec/versioner_spec.rb +++ b/spec/versioner_spec.rb @@ -33,4 +33,21 @@ end end end + + describe '#mark-postinstall' do + it 'adds everything and commits' do + Kosmos::Versioner.init_repo(ksp_dir) + + ...
Add a test for mark_postinstall.
diff --git a/spec/integration/hanami/router/context_spec.rb b/spec/integration/hanami/router/context_spec.rb index abc1234..def5678 100644 --- a/spec/integration/hanami/router/context_spec.rb +++ b/spec/integration/hanami/router/context_spec.rb @@ -0,0 +1,21 @@+RSpec.describe Hanami::Router do + describe "context opti...
Add test for context option
diff --git a/spec/paho-mqtt_spec.rb b/spec/paho-mqtt_spec.rb index abc1234..def5678 100644 --- a/spec/paho-mqtt_spec.rb +++ b/spec/paho-mqtt_spec.rb @@ -6,6 +6,6 @@ end it 'does something useful' do - expect(false).to eq(true) + expect(true).to eq(true) end end
Change default spec to True
diff --git a/spec/dotenv/environment_spec.rb b/spec/dotenv/environment_spec.rb index abc1234..def5678 100644 --- a/spec/dotenv/environment_spec.rb +++ b/spec/dotenv/environment_spec.rb @@ -31,7 +31,7 @@ describe 'apply!' do it 'sets variables in the ENV' do - subject.apply + subject.apply! exp...
Call the right method in the spec closes #129
diff --git a/spec/support/factory_helpers.rb b/spec/support/factory_helpers.rb index abc1234..def5678 100644 --- a/spec/support/factory_helpers.rb +++ b/spec/support/factory_helpers.rb @@ -17,14 +17,14 @@ def build_serialized_user(options = {}) { - :nickname => options[:nickname] ||'nickname', -...
Change 'terms_accepted' to 'terms' in helper
diff --git a/db/migrate/20191031193436_remove_old_akismet_states.rb b/db/migrate/20191031193436_remove_old_akismet_states.rb index abc1234..def5678 100644 --- a/db/migrate/20191031193436_remove_old_akismet_states.rb +++ b/db/migrate/20191031193436_remove_old_akismet_states.rb @@ -1,6 +1,6 @@ # frozen_string_literal: tr...
FIX: Make migrations work with Discourse stable
diff --git a/validates_xml_of.gemspec b/validates_xml_of.gemspec index abc1234..def5678 100644 --- a/validates_xml_of.gemspec +++ b/validates_xml_of.gemspec @@ -22,7 +22,7 @@ spec.add_dependency "nokogiri" spec.add_development_dependency "bundler", "~> 1.11" - spec.add_development_dependency "rake", "~> 10.0" +...
Update rake requirement from ~> 10.0 to ~> 12.3 Updates the requirements on [rake](https://github.com/ruby/rake) to permit the latest version. - [Release notes](https://github.com/ruby/rake/releases) - [Changelog](https://github.com/ruby/rake/blob/master/History.rdoc) - [Commits](https://github.com/ruby/rake/commits/v...
diff --git a/Casks/waterfox.rb b/Casks/waterfox.rb index abc1234..def5678 100644 --- a/Casks/waterfox.rb +++ b/Casks/waterfox.rb @@ -1,6 +1,6 @@ cask :v1 => 'waterfox' do - version '39.0' - sha256 'ba25c4c3a422b2727d5d47a1369fb26b3c66d9c03967fdd22076e27fff982134' + version '40.0.2' + sha256 '49720ec39019cc799153167...
Upgrade Waterfox.app to version 40.0.2
diff --git a/ochibako_share.gemspec b/ochibako_share.gemspec index abc1234..def5678 100644 --- a/ochibako_share.gemspec +++ b/ochibako_share.gemspec @@ -9,6 +9,7 @@ s.executables = %w(ochibako-share ochibako-share-auth) s.homepage = 'https://github.com/zunda/ochibako-share#readme' s.license = 'MIT' + s....
Add doc files into gemspec
diff --git a/spec/features/search_options_spec.rb b/spec/features/search_options_spec.rb index abc1234..def5678 100644 --- a/spec/features/search_options_spec.rb +++ b/spec/features/search_options_spec.rb @@ -9,5 +9,9 @@ it 'provides an All Fields search option' do expect(page).to have_select('search_field',...
Add test for title field search config
diff --git a/spec/finders/projects_finder_spec.rb b/spec/finders/projects_finder_spec.rb index abc1234..def5678 100644 --- a/spec/finders/projects_finder_spec.rb +++ b/spec/finders/projects_finder_spec.rb @@ -46,5 +46,13 @@ end end end + + describe 'with project_ids_relation' do + let(:proje...
Add a spec for ProjectsFinder project_ids_relation option Follow-up 1003454c
diff --git a/spec/stylers/ui_image_view_styler.rb b/spec/stylers/ui_image_view_styler.rb index abc1234..def5678 100644 --- a/spec/stylers/ui_image_view_styler.rb +++ b/spec/stylers/ui_image_view_styler.rb @@ -1,6 +1,6 @@ class StyleSheetForUIViewStylerTests < RubyMotionQuery::Stylesheet - def u_image_view_kitchen_si...
Fix typo in UIImageViewStyler spec.
diff --git a/SipHash.podspec b/SipHash.podspec index abc1234..def5678 100644 --- a/SipHash.podspec +++ b/SipHash.podspec @@ -1,8 +1,8 @@ Pod::Spec.new do |spec| spec.name = 'SipHash' spec.version = '1.0.0' + spec.ios.deployment_target = "8.0" spec.osx.deployment_target = "10.9" - spec....
Fix order of deployment targets to match version.xcconfig.
diff --git a/mako.gemspec b/mako.gemspec index abc1234..def5678 100644 --- a/mako.gemspec +++ b/mako.gemspec @@ -24,6 +24,7 @@ spec.add_development_dependency 'rake' spec.add_development_dependency 'minitest' spec.add_development_dependency 'vcr' + spec.add_development_dependency 'rubocop' spec.add_runtim...
Add rubocop as a development dependency
diff --git a/spec/lib/api_canon_spec.rb b/spec/lib/api_canon_spec.rb index abc1234..def5678 100644 --- a/spec/lib/api_canon_spec.rb +++ b/spec/lib/api_canon_spec.rb @@ -7,14 +7,12 @@ end end describe 'including' do - context :class_methods do - subject {fake_controller} - its(:methods) { should i...
Fix to allow specs to run in 1.8.7
diff --git a/spec/sub_diff/diff_spec.rb b/spec/sub_diff/diff_spec.rb index abc1234..def5678 100644 --- a/spec/sub_diff/diff_spec.rb +++ b/spec/sub_diff/diff_spec.rb @@ -0,0 +1,58 @@+require_relative '../../lib/sub_diff/diff' + +RSpec.describe SubDiff::Diff do + let(:diff) { described_class.new(value,...
Add specs for `Diff` class
diff --git a/test/integration/debian7_knife_bootstrap_test.rb b/test/integration/debian7_knife_bootstrap_test.rb index abc1234..def5678 100644 --- a/test/integration/debian7_knife_bootstrap_test.rb +++ b/test/integration/debian7_knife_bootstrap_test.rb @@ -6,7 +6,7 @@ end def image_id - "ami-1d620e74" + "a...
Update the Debian 7 test AMI to Debian 7.1
diff --git a/Whisper.podspec b/Whisper.podspec index abc1234..def5678 100644 --- a/Whisper.podspec +++ b/Whisper.podspec @@ -11,4 +11,6 @@ s.requires_arc = true s.source_files = 'Source/**/*' s.resource_bundles = { 'Whisper' => ['Images/*.{png}'] } + + s.frameworks = 'UIKit', 'Foundation' end
Add UIKit and Foundation as dependencies
diff --git a/Casks/android-studio.rb b/Casks/android-studio.rb index abc1234..def5678 100644 --- a/Casks/android-studio.rb +++ b/Casks/android-studio.rb @@ -1,8 +1,8 @@ class AndroidStudio < Cask - version '0.8.2 build-135.1267975' - sha256 '55a20e6f9a9e76468344aacf2909b6db224fa3a87e4eac0d76d277ae8c479f89' + version...
Upgrade Android Studio.app to v0.8.3 build-135.1281642
diff --git a/Casks/devonthink-pro.rb b/Casks/devonthink-pro.rb index abc1234..def5678 100644 --- a/Casks/devonthink-pro.rb +++ b/Casks/devonthink-pro.rb @@ -1,11 +1,11 @@ cask :v1 => 'devonthink-pro' do - version '2.8.6' - sha256 '3b5d369bc641d6c0d8ded140ca6c496474051f93f79f53a97c872631f17530a7' + version '2.8.7' + ...
Update DEVONthink Pro to 2.8.6
diff --git a/Casks/iterm2-nightly.rb b/Casks/iterm2-nightly.rb index abc1234..def5678 100644 --- a/Casks/iterm2-nightly.rb +++ b/Casks/iterm2-nightly.rb @@ -2,8 +2,8 @@ version :latest sha256 :no_check - url 'http://www.iterm2.com/nightly/latest' - homepage 'http://www.iterm2.com/' + url 'https://www.iterm2.c...
Update Iterm2 Nightly URL and Homepage
diff --git a/Casks/the-unarchiver.rb b/Casks/the-unarchiver.rb index abc1234..def5678 100644 --- a/Casks/the-unarchiver.rb +++ b/Casks/the-unarchiver.rb @@ -1,8 +1,8 @@ cask :v1 => 'the-unarchiver' do - version '3.9.1' - sha256 '4911c332df7f4bb23877652700e845fe097b793ae37450948319398009e923a3' + version '3.10' + sh...
Upgrade The Unarchiver to v3.10
diff --git a/db/fixtures/010_fuel_markets.rb b/db/fixtures/010_fuel_markets.rb index abc1234..def5678 100644 --- a/db/fixtures/010_fuel_markets.rb +++ b/db/fixtures/010_fuel_markets.rb @@ -1,18 +1,34 @@ FuelMarket.seed_many([ {:id => 1, :name => "Wind", - :description => "The movement of air."}, + :descrip...
Add defaults to fixtures for fuel markets.
diff --git a/Casks/dbeaver-community.rb b/Casks/dbeaver-community.rb index abc1234..def5678 100644 --- a/Casks/dbeaver-community.rb +++ b/Casks/dbeaver-community.rb @@ -1,11 +1,11 @@ cask :v1 => 'dbeaver-community' do - version '3.3.0' + version '3.3.1' if Hardware::CPU.is_32_bit? - sha256 'd91acbac3dc2c86d20...
Update DBeaver community to v3.3.1
diff --git a/Casks/nulloy.rb b/Casks/nulloy.rb index abc1234..def5678 100644 --- a/Casks/nulloy.rb +++ b/Casks/nulloy.rb @@ -2,6 +2,7 @@ version '0.8.2' sha256 '67acc5ada9b5245cda7da04456bc18ad6e9b49dbdcb1e2752ce988d4d3607b35' + # github.com/nulloy/nulloy was verified as official when first introduced to the ca...
Fix `url` stanza comment for Nulloy.
diff --git a/app/models/manageiq/providers/ansible_tower/shared/automation_manager/event_parser.rb b/app/models/manageiq/providers/ansible_tower/shared/automation_manager/event_parser.rb index abc1234..def5678 100644 --- a/app/models/manageiq/providers/ansible_tower/shared/automation_manager/event_parser.rb +++ b/app/m...
Add Ansible event target type into event_type. Add Ansible event target type into event_type to distinguish the event from different event targets. No need to repeat event.changes in message to reduce the event object's size.
diff --git a/lib/asteroids/ship/ship-graphics.rb b/lib/asteroids/ship/ship-graphics.rb index abc1234..def5678 100644 --- a/lib/asteroids/ship/ship-graphics.rb +++ b/lib/asteroids/ship/ship-graphics.rb @@ -0,0 +1,15 @@+module Asteroids + class ShipGraphics < Component + + def initialize(game_object) + super(gam...
Add the ship graphics class. This class will take care for the ship drawing.
diff --git a/spec/define_dimension_spec.rb b/spec/define_dimension_spec.rb index abc1234..def5678 100644 --- a/spec/define_dimension_spec.rb +++ b/spec/define_dimension_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe Dims do +describe Measurb do describe '.define' do before :example do clear_de...
Rename Dims -> Measurb. Add more specs.
diff --git a/spec/support/active_record.rb b/spec/support/active_record.rb index abc1234..def5678 100644 --- a/spec/support/active_record.rb +++ b/spec/support/active_record.rb @@ -8,7 +8,6 @@ # require 'rspec/rails/matchers/relation_match_array' require 'rspec/rails/fixture_support' require 'rspec/rails/mocks' -requ...
Spec: Remove module_inclusion, it is a deperecated method.
diff --git a/spec/support/slack_helpers.rb b/spec/support/slack_helpers.rb index abc1234..def5678 100644 --- a/spec/support/slack_helpers.rb +++ b/spec/support/slack_helpers.rb @@ -14,7 +14,7 @@ channel_id: "C99NNAY74", channel_name: "zf-promo", command: "/heroku", - response_url: "https://hook...
Complete url is not needed
diff --git a/spec/vimrunner/errors_spec.rb b/spec/vimrunner/errors_spec.rb index abc1234..def5678 100644 --- a/spec/vimrunner/errors_spec.rb +++ b/spec/vimrunner/errors_spec.rb @@ -1,4 +1,5 @@ require "spec_helper" +require "vimrunner" require "vimrunner/errors" module Vimrunner @@ -6,7 +7,7 @@ it "has a useful...
Add a spec for InvalidCommandError
diff --git a/Reachability.podspec b/Reachability.podspec index abc1234..def5678 100644 --- a/Reachability.podspec +++ b/Reachability.podspec @@ -0,0 +1,13 @@+Pod::Spec.new do |s| + s.name = 'Reachability' + s.version = '3.0.0' + s.license = 'BSD' + s.platform = :ios + s.homepage = 'https:...
Add a CocoaPods podspec for a future 3.0.0 release.
diff --git a/app/models/friendship.rb b/app/models/friendship.rb index abc1234..def5678 100644 --- a/app/models/friendship.rb +++ b/app/models/friendship.rb @@ -21,6 +21,12 @@ end def destroy - Friendship.delete_all ['(friend_id = ? and person_id = ?) or (friend_id = ? and person_id = ?)', person.id, friend.i...
Update delete_all usage to fix deprecation
diff --git a/lib/app.rb b/lib/app.rb index abc1234..def5678 100644 --- a/lib/app.rb +++ b/lib/app.rb @@ -22,25 +22,28 @@ module ExercismWeb class App < Sinatra::Base - enable :sessions - set :session_secret, ENV.fetch('SESSION_SECRET') { "Need to know only." } + configure do + enable :sessions + ...
Clean up namespaces a bit
diff --git a/completion_generator.rb b/completion_generator.rb index abc1234..def5678 100644 --- a/completion_generator.rb +++ b/completion_generator.rb @@ -43,7 +43,8 @@ args = {} function.css('arg').each_with_object(args) do |arg, args| - args[arg['name'].to_sym] = arg['declared_type'] + ...
Handle special case when function arg doesn't have a name
diff --git a/spec/formaggio/puma_config_spec.rb b/spec/formaggio/puma_config_spec.rb index abc1234..def5678 100644 --- a/spec/formaggio/puma_config_spec.rb +++ b/spec/formaggio/puma_config_spec.rb @@ -5,7 +5,7 @@ @dummy_path ||= File.expand_path("../../dummy", __FILE__) end - it "returns correct setting...
Add test for ssl puma
diff --git a/spec/gitlab/build/build_qa_spec.rb b/spec/gitlab/build/build_qa_spec.rb index abc1234..def5678 100644 --- a/spec/gitlab/build/build_qa_spec.rb +++ b/spec/gitlab/build/build_qa_spec.rb @@ -14,7 +14,8 @@ it 'calls the git command' do allow(Build::Info).to receive(:package).and_return("gitlab-ee") ...
Fix QA spec tests for checkout
diff --git a/spec/helpers/course_helper_spec.rb b/spec/helpers/course_helper_spec.rb index abc1234..def5678 100644 --- a/spec/helpers/course_helper_spec.rb +++ b/spec/helpers/course_helper_spec.rb @@ -0,0 +1,21 @@+require 'rails_helper' + +describe CourseHelper, :type => :helper do + describe '.contribution_link' do +...
Add test of CourseHelper methods.
diff --git a/spec/ruboty/adapters/shell_spec.rb b/spec/ruboty/adapters/shell_spec.rb index abc1234..def5678 100644 --- a/spec/ruboty/adapters/shell_spec.rb +++ b/spec/ruboty/adapters/shell_spec.rb @@ -24,7 +24,7 @@ context "with `quit`" do it "stops" do - Readline.stub(readline: "exit") + Rea...
Fix typo in the spec file
diff --git a/spec/todo/containers/queue_spec.rb b/spec/todo/containers/queue_spec.rb index abc1234..def5678 100644 --- a/spec/todo/containers/queue_spec.rb +++ b/spec/todo/containers/queue_spec.rb @@ -5,4 +5,25 @@ before(:each) do @sut = Todo::Containers::Queue.new(2) end + + it('pops a value from ...
Cover all untested methods in Queue.
diff --git a/ruby/t/tc_display.rb b/ruby/t/tc_display.rb index abc1234..def5678 100644 --- a/ruby/t/tc_display.rb +++ b/ruby/t/tc_display.rb @@ -0,0 +1,24 @@+require 'test/unit' +require 'caca' + +class TC_Canvas < Test::Unit::TestCase + def test_create + d = Caca::Display.new + assert_not_nil(d, 'Display cre...
Add few unit tests for Caca::Display git-svn-id: 3f9eced0add15b5a9fa491ea3f7f263c10f60fd6@2297 92316355-f0b4-4df1-b90c-862c8a59935f
diff --git a/spec/features/geolocation_alert_spec.rb b/spec/features/geolocation_alert_spec.rb index abc1234..def5678 100644 --- a/spec/features/geolocation_alert_spec.rb +++ b/spec/features/geolocation_alert_spec.rb @@ -16,7 +16,7 @@ button = page.find('.joined-link', match: :first) button.click cl...
Complete test for geolocation error alert
diff --git a/spec/system/admin/admin_flashes_spec.rb b/spec/system/admin/admin_flashes_spec.rb index abc1234..def5678 100644 --- a/spec/system/admin/admin_flashes_spec.rb +++ b/spec/system/admin/admin_flashes_spec.rb @@ -0,0 +1,33 @@+require 'rails_helper' + +RSpec.describe 'Admin Flashes', type: :system do + let(:use...
Add system tests for Admin Flash
diff --git a/lib/reunion/rules/rules_reporter.rb b/lib/reunion/rules/rules_reporter.rb index abc1234..def5678 100644 --- a/lib/reunion/rules/rules_reporter.rb +++ b/lib/reunion/rules/rules_reporter.rb @@ -8,7 +8,8 @@ def by_line_number(filename) - Hash[@rules.map do |r| + by_lines = {} + @rules.e...
Add support for multiple rules per line.
diff --git a/spec/factories.rb b/spec/factories.rb index abc1234..def5678 100644 --- a/spec/factories.rb +++ b/spec/factories.rb @@ -1,5 +1,6 @@ FactoryGirl.define do factory :user do + # id 1 sequence(:username) { |n| "user#{n}"} sequence(:email) {|n| "email#{n}@gmail.com" } password "password" @@ ...
Modify user_id call in query factory
diff --git a/spec/factories.rb b/spec/factories.rb index abc1234..def5678 100644 --- a/spec/factories.rb +++ b/spec/factories.rb @@ -36,7 +36,7 @@ name "Bryan Ricker" end - factory :version, class: "Secretary::Version" do + factory :version, :class => "Secretary::Version" do versioned { |v| v.associatio...
Switch to 1.8 hash syntax
diff --git a/lib/tty/prompt/answers_collector.rb b/lib/tty/prompt/answers_collector.rb index abc1234..def5678 100644 --- a/lib/tty/prompt/answers_collector.rb +++ b/lib/tty/prompt/answers_collector.rb @@ -37,8 +37,14 @@ self end + # Change to collect all values for a key + # + # @example...
Change to coerce values into array type
diff --git a/UINavigationControllerWithCompletionBlock.podspec b/UINavigationControllerWithCompletionBlock.podspec index abc1234..def5678 100644 --- a/UINavigationControllerWithCompletionBlock.podspec +++ b/UINavigationControllerWithCompletionBlock.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = ...
FIX bad podspec version number
diff --git a/app/controllers/cotn_email_controller.rb b/app/controllers/cotn_email_controller.rb index abc1234..def5678 100644 --- a/app/controllers/cotn_email_controller.rb +++ b/app/controllers/cotn_email_controller.rb @@ -2,19 +2,17 @@ class CotnEmailController < ApplicationController before_action :set_users +...
Add a few tweaks to the cotn email process
diff --git a/app/controllers/supporters_controller.rb b/app/controllers/supporters_controller.rb index abc1234..def5678 100644 --- a/app/controllers/supporters_controller.rb +++ b/app/controllers/supporters_controller.rb @@ -7,12 +7,17 @@ def create @price = params[:price] - # TODO: Save customer to user - ...
Save Stripe customer to the user And don't recreate it if we already have one.
diff --git a/app/services/persister/post_persister.rb b/app/services/persister/post_persister.rb index abc1234..def5678 100644 --- a/app/services/persister/post_persister.rb +++ b/app/services/persister/post_persister.rb @@ -17,7 +17,13 @@ end def update_attributes(params) - post.update_attributes(param...
Create :updated event on Post update
diff --git a/app/controllers/api/votes_controller.rb b/app/controllers/api/votes_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/votes_controller.rb +++ b/app/controllers/api/votes_controller.rb @@ -12,7 +12,7 @@ private - def visible_records + def accessible_records load_and_authoriz...
Fix errors for logged out angular votes
diff --git a/app/controllers/campaigns_controller.rb b/app/controllers/campaigns_controller.rb index abc1234..def5678 100644 --- a/app/controllers/campaigns_controller.rb +++ b/app/controllers/campaigns_controller.rb @@ -3,7 +3,7 @@ expose(:campaign, attributes: :campaign_params) before_filter :authenticate_user...
Add json and xml output in campaigns controller
diff --git a/app/controllers/employees_controller.rb b/app/controllers/employees_controller.rb index abc1234..def5678 100644 --- a/app/controllers/employees_controller.rb +++ b/app/controllers/employees_controller.rb @@ -1,6 +1,10 @@ class EmployeesController < ApplicationController def index @employees = Emplo...
Add show, update & destroy actions
diff --git a/event_store-client-http.gemspec b/event_store-client-http.gemspec index abc1234..def5678 100644 --- a/event_store-client-http.gemspec +++ b/event_store-client-http.gemspec @@ -2,7 +2,7 @@ Gem::Specification.new do |s| s.name = 'event_store-client-http' s.summary = 'HTTP Client for EventStore' - s.ve...
Increment version⇒ 0.1.3 enabling setting override
diff --git a/app/controllers/api/public/channels_controller.rb b/app/controllers/api/public/channels_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/public/channels_controller.rb +++ b/app/controllers/api/public/channels_controller.rb @@ -13,7 +13,7 @@ end def timestamp - latest_updated_...
Set a cache time for 10 minutes. We might change this later, but this shouldn't be noticeable to the user
diff --git a/app/controllers/forem/admin/members_controller.rb b/app/controllers/forem/admin/members_controller.rb index abc1234..def5678 100644 --- a/app/controllers/forem/admin/members_controller.rb +++ b/app/controllers/forem/admin/members_controller.rb @@ -1,18 +1,19 @@ module Forem - class Admin::MembersControlle...
Fix MembersController inherited class to be Forem::Admin::BaseController
diff --git a/app/overrides/add_return_requests_to_admin_tab.rb b/app/overrides/add_return_requests_to_admin_tab.rb index abc1234..def5678 100644 --- a/app/overrides/add_return_requests_to_admin_tab.rb +++ b/app/overrides/add_return_requests_to_admin_tab.rb @@ -3,7 +3,7 @@ name: 'add_return_requests_to_admin_tab', ...
Add data hook to admin tab for easy hookin'
diff --git a/test/unit/wdpa/importer_test.rb b/test/unit/wdpa/importer_test.rb index abc1234..def5678 100644 --- a/test/unit/wdpa/importer_test.rb +++ b/test/unit/wdpa/importer_test.rb @@ -13,6 +13,7 @@ Wdpa::SourceImporter.expects(:import).with(wdpa_release).in_sequence(import) Wdpa::ProtectedAreaImporter.exp...
Add OverseasTerritoriesImporter to importer test
diff --git a/app/representers/account_representer.rb b/app/representers/account_representer.rb index abc1234..def5678 100644 --- a/app/representers/account_representer.rb +++ b/app/representers/account_representer.rb @@ -4,6 +4,7 @@ include Roar::JSON include Roar::JSON::HAL + property :id property :has_paym...
Add id to account representer.
diff --git a/bashcov.gemspec b/bashcov.gemspec index abc1234..def5678 100644 --- a/bashcov.gemspec +++ b/bashcov.gemspec @@ -18,6 +18,8 @@ gem.executables = gem.files.grep(%r{\Abin/}).map { |f| File.basename(f) } gem.require_paths = ["lib"] + gem.required_ruby_version = ">= 2.0.0" + gem.add_dependency "sim...
Make sure nobody tries to install Bashcov on obsolete Rubies [References #19]
diff --git a/lib/dock_test/dsl.rb b/lib/dock_test/dsl.rb index abc1234..def5678 100644 --- a/lib/dock_test/dsl.rb +++ b/lib/dock_test/dsl.rb @@ -13,7 +13,7 @@ ARGV.clear # clear ARGV as it is used by Rack to configure server - server = WEBrick::HTTPServer.new(:Port => port).tap do |server| + s...
Disable Webrick's access log to make tests quieter
diff --git a/spec/integration/member/update!_spec.rb b/spec/integration/member/update!_spec.rb index abc1234..def5678 100644 --- a/spec/integration/member/update!_spec.rb +++ b/spec/integration/member/update!_spec.rb @@ -0,0 +1,18 @@+# require 'spec_helper' + +# RSpec.describe 'Trell::Member.update!' do +# include In...
Add comment out tests for Trello::Member.update! Current trello update API return permission require message. Maybe, we can try it in future
diff --git a/app/uploaders/content_image_uploader.rb b/app/uploaders/content_image_uploader.rb index abc1234..def5678 100644 --- a/app/uploaders/content_image_uploader.rb +++ b/app/uploaders/content_image_uploader.rb @@ -4,7 +4,7 @@ storage :file def filename - @name ||= "#{secure_token}.#{file.extension.down...
Change where content images are saved.
diff --git a/rack-transform.gemspec b/rack-transform.gemspec index abc1234..def5678 100644 --- a/rack-transform.gemspec +++ b/rack-transform.gemspec @@ -16,7 +16,7 @@ s.files = Dir["{lib}/**/*", "MIT-LICENSE", "README.md"] s.test_files = Dir["spec/**/*"] - s.add_dependency "rack", "~> 1.5", ">= 1.5.0" + s.add_...
Update rack requirement from >= 1.5.0, ~> 1.5 to >= 1.5.0, < 3.0 Updates the requirements on [rack](https://github.com/rack/rack) to permit the latest version. - [Release notes](https://github.com/rack/rack/releases) - [Changelog](https://github.com/rack/rack/blob/master/CHANGELOG.md) - [Commits](https://github.com/ra...
diff --git a/lib/pugbot/timers.rb b/lib/pugbot/timers.rb index abc1234..def5678 100644 --- a/lib/pugbot/timers.rb +++ b/lib/pugbot/timers.rb @@ -9,7 +9,7 @@ # @return <Cinch::Timer> The timer that has just been created. # @see Game.timeout def timer_game_end(game) - Timer(15, shots: 1) { game.timeout...
Use finish_timeout constant rather than 15s in timer_game_end
diff --git a/lib/anemone/storage.rb b/lib/anemone/storage.rb index abc1234..def5678 100644 --- a/lib/anemone/storage.rb +++ b/lib/anemone/storage.rb @@ -18,7 +18,7 @@ self::TokyoCabinet.new(file) end - def self.KyotoCabinet(file = 'anemone.tch') + def self.KyotoCabinet(file = 'anemone.kch') re...
Fix default filename extension for the kyotocabinet adapter.
diff --git a/lib/asset_hat/tasks.rb b/lib/asset_hat/tasks.rb index abc1234..def5678 100644 --- a/lib/asset_hat/tasks.rb +++ b/lib/asset_hat/tasks.rb @@ -4,7 +4,7 @@ namespace :asset_hat do desc 'Minifies all CSS and JS bundles' - task :minify, :needs => :environment do + task :minify, [] => :environment do ...
Fix another deprecated rake syntax after move to rake 0.9
diff --git a/database_yml_storage.rb b/database_yml_storage.rb index abc1234..def5678 100644 --- a/database_yml_storage.rb +++ b/database_yml_storage.rb @@ -0,0 +1,32 @@+module Moltrio + module Config + + class DatabaseYmlStorage < Storage + attr_reader :real_storage, :environment + + def initialize(stora...
Remove the database.yml hack; Make it possible to not have a database.yml
diff --git a/lib/tasks/setup.rake b/lib/tasks/setup.rake index abc1234..def5678 100644 --- a/lib/tasks/setup.rake +++ b/lib/tasks/setup.rake @@ -13,11 +13,11 @@ raise "You should provide a valid password" if ENV['PASSWORD'].nil? || ENV['PASSWORD'].empty? raise "You should provide a valid subdomain" if ...
Use upcase environment variable names
diff --git a/lib/tl_ember_edit.rb b/lib/tl_ember_edit.rb index abc1234..def5678 100644 --- a/lib/tl_ember_edit.rb +++ b/lib/tl_ember_edit.rb @@ -1,4 +1,16 @@ require "tl_ember_edit/engine" module TlEmberEdit + + # Override these settings in an initializer or your application.rb + + # The editor command. 'FILENAME'...
Add a few default settings
diff --git a/spec/rails_helper.rb b/spec/rails_helper.rb index abc1234..def5678 100644 --- a/spec/rails_helper.rb +++ b/spec/rails_helper.rb @@ -4,6 +4,7 @@ require 'spec_helper' require 'rspec/rails' require "capybara/rspec" +ActiveRecord::Migration.maintain_test_schema! RSpec.configure do |config| config.fixtur...
Add Maintain Test Schema Test
diff --git a/app/jobs/feed_job.rb b/app/jobs/feed_job.rb index abc1234..def5678 100644 --- a/app/jobs/feed_job.rb +++ b/app/jobs/feed_job.rb @@ -1,12 +1,13 @@-# To create outside of Rails, insert into the `delayed_jobs` table: +# To create outside of Rails, insert a row with values for the following columns +# into the...
Clarify comments for feed job
diff --git a/lib/virus_scanner.rb b/lib/virus_scanner.rb index abc1234..def5678 100644 --- a/lib/virus_scanner.rb +++ b/lib/virus_scanner.rb @@ -6,8 +6,6 @@ # to either clamscan or clamdscan class VirusScanner class Error < StandardError; end - - # Used for sending exception notices on infection class InfectedF...
Remove unnecessary comment from VirusScanner class Now that we are explicitly handling VirusScanner::InfectedFile exceptions in VirusScanWorker#perform, I think this comment is less useful and just clutters up the code.
diff --git a/lib/map.rb b/lib/map.rb index abc1234..def5678 100644 --- a/lib/map.rb +++ b/lib/map.rb @@ -6,6 +6,8 @@ 32, 32, false) get_lines(mapfile) + get_map_width + get_map_height end def get_lines(file)
Call width and height methods in initialize
diff --git a/tasks/db.rake b/tasks/db.rake index abc1234..def5678 100644 --- a/tasks/db.rake +++ b/tasks/db.rake @@ -15,6 +15,7 @@ require 'yaml' puts "Removing database #{db_file}" FileUtils.rm_f db_file + FileUtils.mkdir_p File.dirname(db_file) end def db_file
Drop task now recreates tmp dir
diff --git a/lib/franklin/config.rb b/lib/franklin/config.rb index abc1234..def5678 100644 --- a/lib/franklin/config.rb +++ b/lib/franklin/config.rb @@ -14,7 +14,7 @@ class << self def from_yaml(yaml) - self.new(YAML.load(yaml)) + new(YAML.load(yaml)) end def load_from_file(fi...
Remove unnecessary call to `self`
diff --git a/test/integration/users_login_test.rb b/test/integration/users_login_test.rb index abc1234..def5678 100644 --- a/test/integration/users_login_test.rb +++ b/test/integration/users_login_test.rb @@ -0,0 +1,14 @@+require 'test_helper' + +class UsersLoginTest < ActionDispatch::IntegrationTest + test 'login wit...
Add integration test for user login
diff --git a/app/helpers/admin/document_collection_helper.rb b/app/helpers/admin/document_collection_helper.rb index abc1234..def5678 100644 --- a/app/helpers/admin/document_collection_helper.rb +++ b/app/helpers/admin/document_collection_helper.rb @@ -1,7 +1,7 @@ module Admin::DocumentCollectionHelper def document_...
Fix document collection membership in speed tagger Also eager load document collection groups to avoid an N+1 query
diff --git a/test/simple_drilldown/helper_test.rb b/test/simple_drilldown/helper_test.rb index abc1234..def5678 100644 --- a/test/simple_drilldown/helper_test.rb +++ b/test/simple_drilldown/helper_test.rb @@ -9,14 +9,14 @@ test 'subcaption blank' do @search = Search.new({}) - assert_equal 'Simple Dril...
Use dummy app ApplicationRecord in test
diff --git a/app/models/concerns/scholarship/role_request.rb b/app/models/concerns/scholarship/role_request.rb index abc1234..def5678 100644 --- a/app/models/concerns/scholarship/role_request.rb +++ b/app/models/concerns/scholarship/role_request.rb @@ -7,7 +7,7 @@ scope :order_by_user_full_name, -> do ...
Handle weird postgresql string concat error.
diff --git a/lib/middleware/base.rb b/lib/middleware/base.rb index abc1234..def5678 100644 --- a/lib/middleware/base.rb +++ b/lib/middleware/base.rb @@ -21,6 +21,7 @@ @exporter.start_tracker_segment(tracker_name) end + # Called on tracker end def end_tracker_segment @exporter.end_tracker_segment ...
Add a meaningful comment for tracker end
diff --git a/lib/net_x/http_unix.rb b/lib/net_x/http_unix.rb index abc1234..def5678 100644 --- a/lib/net_x/http_unix.rb +++ b/lib/net_x/http_unix.rb @@ -9,8 +9,11 @@ case address when UNIX_REGEXP @socket_type = 'unix' - @address = address.sub(UNIX_REGEXP, '') - @port = nil + @socket_path ...
Fix incorrect HOST request header causing 400 errors Without this patch nginx returns a 400 error response for requests that otherwise are 200 OK over TCP connections. The specific error message is: 2014/11/25 21:47:24 [info] 19036#0: *1 client sent invalid host header while reading client request headers, c...
diff --git a/RxSugar.podspec b/RxSugar.podspec index abc1234..def5678 100644 --- a/RxSugar.podspec +++ b/RxSugar.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "RxSugar" - s.version = "0.0.10" + s.version = "0.0.11" s.summary = "Simple RxSwift extensions for interacting with Apple ...
Update podspec to use most recent version of RxSwift This will allow it to take advantage of swift 3
diff --git a/lib/wash_out/router.rb b/lib/wash_out/router.rb index abc1234..def5678 100644 --- a/lib/wash_out/router.rb +++ b/lib/wash_out/router.rb @@ -10,7 +10,10 @@ controller = @controller_name.constantize soap_action = env['HTTP_SOAPACTION'] - soap_action.force_encoding('UTF-8') + + # RUBY...
Add a 1.8 compatibility shim.
diff --git a/lib/billogram/resources/regional_sweden.rb b/lib/billogram/resources/regional_sweden.rb index abc1234..def5678 100644 --- a/lib/billogram/resources/regional_sweden.rb +++ b/lib/billogram/resources/regional_sweden.rb @@ -1,5 +1,6 @@ module Billogram class RegionalSweden < Resource - attr_accessor :rot...
Add a field to regional sweden
diff --git a/lib/finite_machine/undefined_transition.rb b/lib/finite_machine/undefined_transition.rb index abc1234..def5678 100644 --- a/lib/finite_machine/undefined_transition.rb +++ b/lib/finite_machine/undefined_transition.rb @@ -16,6 +16,14 @@ false end + def same?(_) + false + end + + de...
Change to mock out undefined transition.
diff --git a/lib/solidus_shipwire/response_decorator.rb b/lib/solidus_shipwire/response_decorator.rb index abc1234..def5678 100644 --- a/lib/solidus_shipwire/response_decorator.rb +++ b/lib/solidus_shipwire/response_decorator.rb @@ -1,19 +1,19 @@-module SolidusShipwire::Response - def resource - body['resource'].wi...
Improve module namespacing for ResponseDecorator
diff --git a/lib/tagooru.rb b/lib/tagooru.rb index abc1234..def5678 100644 --- a/lib/tagooru.rb +++ b/lib/tagooru.rb @@ -10,11 +10,28 @@ include HTTParty base_uri 'http://tagoo.ru' - default_params :for => :audio + default_params :for => :audio, :key => '74d8940f' + headers 'Referer' => 'http://tagoo.ru/en/we...
Replace playlist search with api search Playlist search now requires authentication, so I'm replacing it with the ajax api search. Currently I'm sending in the api key used in their example on the documentation page, we'll see how long that lasts.
diff --git a/app/validators/variable_duplicates_validator.rb b/app/validators/variable_duplicates_validator.rb index abc1234..def5678 100644 --- a/app/validators/variable_duplicates_validator.rb +++ b/app/validators/variable_duplicates_validator.rb @@ -6,7 +6,9 @@ class VariableDuplicatesValidator < ActiveModel::EachVa...
Refactor outer anonymous function into a do block
diff --git a/attributes/default.rb b/attributes/default.rb index abc1234..def5678 100644 --- a/attributes/default.rb +++ b/attributes/default.rb @@ -18,7 +18,7 @@ # default['activemq']['mirror'] = 'https://repository.apache.org/content/repositories/releases/org/apache' -default['activemq']['version'] = '5.9.1' +def...
Use the latest version of ActiveMQ
diff --git a/breaktime.gemspec b/breaktime.gemspec index abc1234..def5678 100644 --- a/breaktime.gemspec +++ b/breaktime.gemspec @@ -8,7 +8,7 @@ gem.version = Breaktime::VERSION gem.authors = ["Jon Cairns"] gem.email = ["jon@joncairns.com"] - gem.description = %q{Enforce screen breaks at ...
Add a bit more to description of gem
diff --git a/vendor/plugins/somatics_generator/init.rb b/vendor/plugins/somatics_generator/init.rb index abc1234..def5678 100644 --- a/vendor/plugins/somatics_generator/init.rb +++ b/vendor/plugins/somatics_generator/init.rb @@ -1,2 +1,3 @@ # Include hook code here -require 'somatic_link_renderer'+raise "You Should ins...
Raise Error when Will Paginate Gems not installed.
diff --git a/spec_helper.rb b/spec_helper.rb index abc1234..def5678 100644 --- a/spec_helper.rb +++ b/spec_helper.rb @@ -35,5 +35,6 @@ :operatingsystemrelease => possible_releases[dist_preferred], :lsbdistid => 'Debian', :lsbdistcodename => dist_preferred.capitalize, + :architect...
Add a default architecture fact to stop tests failing. We're moving to Puppet 4 (eventually) and enabling `strict_variables` is one part of this. Adding this as a global default fixes issues in a range of module tests.
diff --git a/app/models/github_user.rb b/app/models/github_user.rb index abc1234..def5678 100644 --- a/app/models/github_user.rb +++ b/app/models/github_user.rb @@ -17,7 +17,7 @@ end def to_param - login.downcase + login end def github_client
Fix redirect loops for some github users