diff stringlengths 65 26.7k | message stringlengths 7 9.92k |
|---|---|
diff --git a/lib/requeue_content.rb b/lib/requeue_content.rb
index abc1234..def5678 100644
--- a/lib/requeue_content.rb
+++ b/lib/requeue_content.rb
@@ -8,7 +8,7 @@ end
def call
- scope.each do |edition|
+ scope.find_each do |edition|
publish_to_queue(edition)
end
end
| Use find_each instead of each
This shouldn't load the whole result set into memory.
|
diff --git a/app/models/spree/promotion/rules/copayment.rb b/app/models/spree/promotion/rules/copayment.rb
index abc1234..def5678 100644
--- a/app/models/spree/promotion/rules/copayment.rb
+++ b/app/models/spree/promotion/rules/copayment.rb
@@ -9,7 +9,7 @@ end
def eligible?(order, options = {})
- ... | Fix rule for active and inactive relations
|
diff --git a/lib/ruby_extensions.rb b/lib/ruby_extensions.rb
index abc1234..def5678 100644
--- a/lib/ruby_extensions.rb
+++ b/lib/ruby_extensions.rb
@@ -1,4 +1,4 @@-require 'unidecode'
+require 'unidecoder'
# Array extensions
Array.class_eval do
@@ -24,7 +24,7 @@ end
def transliterate
- # Unidecode gem is... | Switch to `unidecoder` gem (instead of `unidecode`)
|
diff --git a/app/serializers/sprangular/user_serializer.rb b/app/serializers/sprangular/user_serializer.rb
index abc1234..def5678 100644
--- a/app/serializers/sprangular/user_serializer.rb
+++ b/app/serializers/sprangular/user_serializer.rb
@@ -2,13 +2,8 @@ class UserSerializer < BaseSerializer
attributes *(user... | Remove completed_orders from /account response
|
diff --git a/lib/services/travis.rb b/lib/services/travis.rb
index abc1234..def5678 100644
--- a/lib/services/travis.rb
+++ b/lib/services/travis.rb
@@ -1,5 +1,11 @@ class Service::Travis < Service
self.title = "Travis CI"
+ url "https://travis-ci.org"
+
+ maintained_by :github => 'travisci'
+
+ supported_by :ema... | Add maintainer and support for Travis CI.
|
diff --git a/lib/shotoku/command.rb b/lib/shotoku/command.rb
index abc1234..def5678 100644
--- a/lib/shotoku/command.rb
+++ b/lib/shotoku/command.rb
@@ -45,6 +45,7 @@
def complete!(exitstatus: nil, termsig: nil, exception: nil)
+ raise 'already completed (possible bug)' if completed?
@exitstatus = e... | Raise error when tried to complete twice
|
diff --git a/lib/xcode/deploy/s3.rb b/lib/xcode/deploy/s3.rb
index abc1234..def5678 100644
--- a/lib/xcode/deploy/s3.rb
+++ b/lib/xcode/deploy/s3.rb
@@ -25,7 +25,7 @@
def deploy
remote_ipa = upload @builder.ipa_path
- base_url = remote_ipa.public_url(:secure => false).to_s.split("/")[0..-2].join("/")
+ ... | Change S3 to use HTTPS
iOS 7.1 requires OTA app installation links to use HTTPS – they fail otherwise. |
diff --git a/lib/tasks/budgets.rake b/lib/tasks/budgets.rake
index abc1234..def5678 100644
--- a/lib/tasks/budgets.rake
+++ b/lib/tasks/budgets.rake
@@ -15,14 +15,13 @@
desc "Update investments original_heading_id with current heading_id"
task set_original_heading_id: :environment do
- puts "Starting"
+ Ap... | Use application logger in set_original_heading_id
The pull request adding the original heading was done before we started
using `ApplicationLogger` in rake tasks.
|
diff --git a/lib/tasks/install.rake b/lib/tasks/install.rake
index abc1234..def5678 100644
--- a/lib/tasks/install.rake
+++ b/lib/tasks/install.rake
@@ -1,5 +1,6 @@ namespace :app do
task :install do
+ Rake::Task['db:drop'].invoke
Rake::Task['db:seed'].invoke
puts "Clovrr is now installed."
puts "\... | Drop the database, just in case. HC SVNT DRACONES.
|
diff --git a/lib/tay/cli/helpers.rb b/lib/tay/cli/helpers.rb
index abc1234..def5678 100644
--- a/lib/tay/cli/helpers.rb
+++ b/lib/tay/cli/helpers.rb
@@ -5,7 +5,8 @@
protected
- def spec
+ def spec(bust_cache = false)
+ @spec = nil if bust_cache
@spec ||= get_specification
end
... | Add param to force refresh of spec from disk
|
diff --git a/lib/twitchus/worker.rb b/lib/twitchus/worker.rb
index abc1234..def5678 100644
--- a/lib/twitchus/worker.rb
+++ b/lib/twitchus/worker.rb
@@ -18,7 +18,7 @@ data = {
title: channel["status"],
name: channel["name"],
- image: channel["banner"],
+ image: c... | Store video_banner instead of a banner
|
diff --git a/spec/functions/canonify_array_spec.rb b/spec/functions/canonify_array_spec.rb
index abc1234..def5678 100644
--- a/spec/functions/canonify_array_spec.rb
+++ b/spec/functions/canonify_array_spec.rb
@@ -9,43 +9,50 @@
context "with arg => ['foo']" do
it {
- is_expected.to run.with_params(['foo'])... | Fix rubocop issues with function
|
diff --git a/spec/observers/match_observer_spec.rb b/spec/observers/match_observer_spec.rb
index abc1234..def5678 100644
--- a/spec/observers/match_observer_spec.rb
+++ b/spec/observers/match_observer_spec.rb
@@ -5,8 +5,6 @@ let(:contribution) { create(:contribution, state: :confirmed) }
before do
- Notificat... | Remove unstub from match observer specs
|
diff --git a/spec/providers/storage_schema_spec.rb b/spec/providers/storage_schema_spec.rb
index abc1234..def5678 100644
--- a/spec/providers/storage_schema_spec.rb
+++ b/spec/providers/storage_schema_spec.rb
@@ -0,0 +1,16 @@+require_relative "../spec_helper"
+load_resource("graphite", "storage_schema")
+load_provider(... | Add spec coverage for the graphite_storage_schema provider.
|
diff --git a/spec/support/pathology_spec_helper.rb b/spec/support/pathology_spec_helper.rb
index abc1234..def5678 100644
--- a/spec/support/pathology_spec_helper.rb
+++ b/spec/support/pathology_spec_helper.rb
@@ -10,7 +10,7 @@ observed_at: Time.zone.now,
result: 1)
... | Fix UKRDC observations spec after changes_since change
|
diff --git a/spec/features/show_game_pairings_spec.rb b/spec/features/show_game_pairings_spec.rb
index abc1234..def5678 100644
--- a/spec/features/show_game_pairings_spec.rb
+++ b/spec/features/show_game_pairings_spec.rb
@@ -2,14 +2,19 @@
RSpec.describe "show tournament round pairings" do
context "Any vistor to th... | Add feature test for showing rounds
|
diff --git a/spec/acceptance/openldap__server__access_spec.rb b/spec/acceptance/openldap__server__access_spec.rb
index abc1234..def5678 100644
--- a/spec/acceptance/openldap__server__access_spec.rb
+++ b/spec/acceptance/openldap__server__access_spec.rb
@@ -27,8 +27,15 @@ context 'with defaults' do
it 'should ide... | Load schemas to possibly workaround the issues on centos7.
|
diff --git a/tinify.gemspec b/tinify.gemspec
index abc1234..def5678 100644
--- a/tinify.gemspec
+++ b/tinify.gemspec
@@ -22,6 +22,6 @@
spec.add_development_dependency("bundler", "~> 1.7")
spec.add_development_dependency("rake", "~> 10.0")
- spec.add_development_dependency("minitest")
- spec.add_development_dep... | Update development dependencies with versions.
|
diff --git a/Casks/intellij-idea14.rb b/Casks/intellij-idea14.rb
index abc1234..def5678 100644
--- a/Casks/intellij-idea14.rb
+++ b/Casks/intellij-idea14.rb
@@ -1,6 +1,6 @@ cask 'intellij-idea14' do
- version '14.1.5'
- sha256 '50941026863e2d43f4c8dcc1c02f749c096c2d0bcf53943220314f0898efec24'
+ version '14.1.6'
+ s... | Upgrade IntelliJ IDEA Ultimate to 14.1.6
|
diff --git a/XLPagerTabStrip.podspec b/XLPagerTabStrip.podspec
index abc1234..def5678 100644
--- a/XLPagerTabStrip.podspec
+++ b/XLPagerTabStrip.podspec
@@ -9,7 +9,7 @@ s.social_media_url = 'https://twitter.com/xmartlabs'
s.ios.deployment_target = '8.0'
s.requires_arc = true
- s.ios.source_files = 'Sources/**/... | Fix compilation of the project when using Xcode 9 new build system and CocoaPods
With current podspec, one .xib file is getting picked up as a source, and is getting into Xcode Compile Sources build step in CocoaPods generated project.
New build system is more strict than the old one, and prohibits this by saying:... |
diff --git a/test/test_helper.rb b/test/test_helper.rb
index abc1234..def5678 100644
--- a/test/test_helper.rb
+++ b/test/test_helper.rb
@@ -25,3 +25,5 @@ include TestHelpers
load File.dirname(__FILE__) + "/support/rails_app/db/schema.rb"
+
+I18n.enforce_available_locales = false
| Hide deprecation warning when running tests.
|
diff --git a/models/job_executor.rb b/models/job_executor.rb
index abc1234..def5678 100644
--- a/models/job_executor.rb
+++ b/models/job_executor.rb
@@ -22,8 +22,9 @@
begin
tests.each do |test|
- job.results << test.exec(api)
- job.save!
+ result = test.exec(api)
+ j... | Save individual results to avoid performance issue
|
diff --git a/actionpack/lib/action_view/inline_template.rb b/actionpack/lib/action_view/inline_template.rb
index abc1234..def5678 100644
--- a/actionpack/lib/action_view/inline_template.rb
+++ b/actionpack/lib/action_view/inline_template.rb
@@ -1,10 +1,6 @@ module ActionView #:nodoc:
class InlineTemplate #:nodoc:
... | Use the inline template's hash as a method key instead of relying on a counter
|
diff --git a/app/controllers/guide_container_controller.rb b/app/controllers/guide_container_controller.rb
index abc1234..def5678 100644
--- a/app/controllers/guide_container_controller.rb
+++ b/app/controllers/guide_container_controller.rb
@@ -4,18 +4,13 @@ before_action :set_guide
def show
- if current_user... | Use domain updated method to simplify logic
|
diff --git a/tasks/mongoid_search.rake b/tasks/mongoid_search.rake
index abc1234..def5678 100644
--- a/tasks/mongoid_search.rake
+++ b/tasks/mongoid_search.rake
@@ -2,14 +2,14 @@ desc 'Goes through all documents with search enabled and indexes the keywords.'
task :index => :environment do
if Mongoid::Search.c... | Use full namespace destination for Log class.
|
diff --git a/flatten_routes.gemspec b/flatten_routes.gemspec
index abc1234..def5678 100644
--- a/flatten_routes.gemspec
+++ b/flatten_routes.gemspec
@@ -20,7 +20,7 @@ spec.require_paths = ['lib']
spec.add_development_dependency 'bundler', '~> 2.0'
- spec.add_development_dependency 'rake', '~> 12.0'
+ spec.add_... | Update rake requirement from ~> 12.0 to ~> 13.0
Updates the requirements on [rake](https://github.com/ruby/rake) to permit the latest version.
- [Release notes](https://github.com/ruby/rake/releases)
- [Changelog](https://github.com/ruby/rake/blob/master/History.rdoc)
- [Commits](https://github.com/ruby/rake/compare/v... |
diff --git a/lib/cryptoexchange/exchanges/trade_ogre/services/market.rb b/lib/cryptoexchange/exchanges/trade_ogre/services/market.rb
index abc1234..def5678 100644
--- a/lib/cryptoexchange/exchanges/trade_ogre/services/market.rb
+++ b/lib/cryptoexchange/exchanges/trade_ogre/services/market.rb
@@ -34,7 +34,7 @@ ... | Fix price param for TradeOgre
|
diff --git a/spec/hcast/hcast_spec.rb b/spec/hcast/hcast_spec.rb
index abc1234..def5678 100644
--- a/spec/hcast/hcast_spec.rb
+++ b/spec/hcast/hcast_spec.rb
@@ -4,6 +4,7 @@
describe ".create" do
it "should cast hash attributes" do
+ pending
input_hash = {
contact: {
name: "John ... | Mark unimplemented spec as pending
|
diff --git a/spec/nark/plugin_spec.rb b/spec/nark/plugin_spec.rb
index abc1234..def5678 100644
--- a/spec/nark/plugin_spec.rb
+++ b/spec/nark/plugin_spec.rb
@@ -35,7 +35,7 @@
it "requires all plugins found" do
Nark.load_plugins
- Nark.available_plugins.should eql ["request_times", "requests", "revisio... | Refactor spec so that we care less about the structure of the available plugins results
|
diff --git a/spec/spec_helper_spec.rb b/spec/spec_helper_spec.rb
index abc1234..def5678 100644
--- a/spec/spec_helper_spec.rb
+++ b/spec/spec_helper_spec.rb
@@ -39,6 +39,14 @@ chef_run
end
end # /context with a recipe
+
+ context 'with both a recipe and a block' do
+ recipe 'test' do
+ ... | Test for the error case. |
diff --git a/actionmailer/actionmailer.gemspec b/actionmailer/actionmailer.gemspec
index abc1234..def5678 100644
--- a/actionmailer/actionmailer.gemspec
+++ b/actionmailer/actionmailer.gemspec
@@ -17,5 +17,5 @@ s.requirements << 'none'
s.add_dependency('actionpack', version)
- s.add_dependency('mail', '... | Upgrade mail dependency to 2.4.0
|
diff --git a/actionpack-action_caching.gemspec b/actionpack-action_caching.gemspec
index abc1234..def5678 100644
--- a/actionpack-action_caching.gemspec
+++ b/actionpack-action_caching.gemspec
@@ -6,6 +6,13 @@ gem.description = "Action caching for Action Pack (removed from core in Rails 4.0)"
gem.summary =... | Add project metadata to the gemspec
As per https://guides.rubygems.org/specification-reference/#metadata,
add metadata to the gemspec file. This'll allow people to more easily
access the source code, raise issues and read the changelog. These
`bug_tracker_uri`, `changelog_uri`, `documentation_uri` and
`source_code_uri... |
diff --git a/railties/test/error_page_test.rb b/railties/test/error_page_test.rb
index abc1234..def5678 100644
--- a/railties/test/error_page_test.rb
+++ b/railties/test/error_page_test.rb
@@ -1,6 +1,6 @@ require 'abstract_unit'
require 'action_controller'
-require 'action_controller/test_process'
+require 'action_con... | Fix test broken by test process changes
|
diff --git a/trello_newsletter.gemspec b/trello_newsletter.gemspec
index abc1234..def5678 100644
--- a/trello_newsletter.gemspec
+++ b/trello_newsletter.gemspec
@@ -13,9 +13,8 @@ spec.metadata['allowed_push_host'] = "TODO: Set to 'http://mygemserver.com' to prevent pushes to rubygems.org, or delete to allow pushes ... | Update gemspec with ruby trello and maruku gems
- Ruby Trello is used to connect to Trello API
- Maruku is used to convert markdown from Trello cards to HTML.
|
diff --git a/app/models/build.rb b/app/models/build.rb
index abc1234..def5678 100644
--- a/app/models/build.rb
+++ b/app/models/build.rb
@@ -3,7 +3,7 @@
validates :job_id, presence: true
- belongs_to :job
+ belongs_to :job, touch: true
# Creates, queues, and returns itself.
def self.create_with_queue(*a... | Build touches its job for cache
|
diff --git a/app/models/facet.rb b/app/models/facet.rb
index abc1234..def5678 100644
--- a/app/models/facet.rb
+++ b/app/models/facet.rb
@@ -4,7 +4,7 @@
def self.check_active
facets_to_save = []
- Facet.where(id: Session.product_type_id, feature_type: 'Binary').each do |facet|
+ Facet.where(product_... | Check active had a bug in it
|
diff --git a/guides/rails_guides.rb b/guides/rails_guides.rb
index abc1234..def5678 100644
--- a/guides/rails_guides.rb
+++ b/guides/rails_guides.rb
@@ -39,6 +39,25 @@ exit 1
end
+begin
+ require 'nokogiri'
+rescue LoadError
+ # This can happen if doc:guides is executed in an application.
+ $stderr.puts('Genera... | Add error message for including nokogiri in Gemfile for rake doc:guides [ci skip]
- When `rake doc:guides` is run from applications, it complains for
presence of redcarpet if it not present in Gemfile
- Similarly it should complain about nokogiri
|
diff --git a/rdf-isomorphic.gemspec b/rdf-isomorphic.gemspec
index abc1234..def5678 100644
--- a/rdf-isomorphic.gemspec
+++ b/rdf-isomorphic.gemspec
@@ -0,0 +1,35 @@+#!/usr/bin/env ruby -rubygems
+# -*- encoding: utf-8 -*-
+
+GEMSPEC = Gem::Specification.new do |gem|
+ gem.version = File.read('VERSION').cho... | Rename gemspec so bundler can target it with git directly
|
diff --git a/server/config.ru b/server/config.ru
index abc1234..def5678 100644
--- a/server/config.ru
+++ b/server/config.ru
@@ -11,8 +11,8 @@ 'soapbox_announcement_url' => '/announcement',
'soapbox_accept_url' => '/accept',
'soapbox_show_accept_button' => true,
- 'soapbox_accept_color' => '#',
- 's... | Add some colors to the plist
|
diff --git a/lib/resume/cli/argument_parser.rb b/lib/resume/cli/argument_parser.rb
index abc1234..def5678 100644
--- a/lib/resume/cli/argument_parser.rb
+++ b/lib/resume/cli/argument_parser.rb
@@ -5,11 +5,12 @@ module CLI
class ArgumentParser
def self.parse
+ help = parser.help
parser.pars... | Remove duplicate call to parser.help
|
diff --git a/predicate_bang.gemspec b/predicate_bang.gemspec
index abc1234..def5678 100644
--- a/predicate_bang.gemspec
+++ b/predicate_bang.gemspec
@@ -8,10 +8,10 @@ spec.version = PredicateBang::VERSION
spec.authors = ["Faraz Yashar"]
spec.email = ["faraz.yashar@gmail.com"]
- spec.summary... | Tidy up gem summary and description
|
diff --git a/winnow.gemspec b/winnow.gemspec
index abc1234..def5678 100644
--- a/winnow.gemspec
+++ b/winnow.gemspec
@@ -18,6 +18,8 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
spec.require_paths = ["lib"]
+ spec.add_dependency 'rouge', '~> 1.3'
+
spec.add_development_dependency "bundl... | Add rouge as a dependency.
|
diff --git a/hephaestus/lib/resque/base.rb b/hephaestus/lib/resque/base.rb
index abc1234..def5678 100644
--- a/hephaestus/lib/resque/base.rb
+++ b/hephaestus/lib/resque/base.rb
@@ -11,6 +11,13 @@ end
def self.on_failure(e, *args)
+ id = args[0]
+ begin
+ document = Document.find(id)
+ document.up... | [hephaestus] Change status if document fails
|
diff --git a/arm-eabi-binutils223.rb b/arm-eabi-binutils223.rb
index abc1234..def5678 100644
--- a/arm-eabi-binutils223.rb
+++ b/arm-eabi-binutils223.rb
@@ -0,0 +1,49 @@+require 'formula'
+
+class ArmEabiBinutils223 <Formula
+ url 'http://ftp.gnu.org/gnu/binutils/binutils-2.23.2.tar.bz2'
+ homepage 'http://www.gnu.or... | Add Binutils for ARM EABI v2.23.2 |
diff --git a/sambao21_workstation/recipes/sublime_text.rb b/sambao21_workstation/recipes/sublime_text.rb
index abc1234..def5678 100644
--- a/sambao21_workstation/recipes/sublime_text.rb
+++ b/sambao21_workstation/recipes/sublime_text.rb
@@ -6,12 +6,6 @@ begin
t = resources(:template => File.expand_path("Preferences.... | Remove last traces of sublime auto encoding ruby package
|
diff --git a/app/controllers/socializer/activities/activities_controller.rb b/app/controllers/socializer/activities/activities_controller.rb
index abc1234..def5678 100644
--- a/app/controllers/socializer/activities/activities_controller.rb
+++ b/app/controllers/socializer/activities/activities_controller.rb
@@ -27,7 +2... | Style/MultilineMethodCallIndentation: Align .decorate with .activity_stream on line 28. .decorate
|
diff --git a/app/models/link_checker_api_report/create_from_batch_report.rb b/app/models/link_checker_api_report/create_from_batch_report.rb
index abc1234..def5678 100644
--- a/app/models/link_checker_api_report/create_from_batch_report.rb
+++ b/app/models/link_checker_api_report/create_from_batch_report.rb
@@ -6,7 +6,... | Replace or create link reports
We're coming across a problem whereby the data sync is causing
a mismatch in the batch IDs stored in Whitehall and the batch IDs
stored in the Link Checker API. This is because the databases
don't get copied across at the same time.
We thought the best solution to this would be to simpl... |
diff --git a/lib/extensions/destroy_callbacks/active_record/base.rb b/lib/extensions/destroy_callbacks/active_record/base.rb
index abc1234..def5678 100644
--- a/lib/extensions/destroy_callbacks/active_record/base.rb
+++ b/lib/extensions/destroy_callbacks/active_record/base.rb
@@ -1,5 +1,14 @@ module Extensions::Destroy... | Make all actable records destroy their specific records.
This allows objects with foreign key constraints to be destroyed. This also allows for cyclic relations to be destroyed.
|
diff --git a/spec/acceptance/end_to_end_spec.rb b/spec/acceptance/end_to_end_spec.rb
index abc1234..def5678 100644
--- a/spec/acceptance/end_to_end_spec.rb
+++ b/spec/acceptance/end_to_end_spec.rb
@@ -12,6 +12,7 @@ before do
ENV["DB_PORT"] = db_port
ENV["RAILS_ENV"] = "test"
+ `./bin/bundle exec rake db:... | Make sure databases are created.
|
diff --git a/spec/dummy/lib/rom/test_adapter.rb b/spec/dummy/lib/rom/test_adapter.rb
index abc1234..def5678 100644
--- a/spec/dummy/lib/rom/test_adapter.rb
+++ b/spec/dummy/lib/rom/test_adapter.rb
@@ -2,7 +2,6 @@ module TestAdapter
class Relation < ROM::Relation
adapter :test_adapter
- schema_class S... | Remove setting schema_class in TestAdapter
See
https://github.com/rom-rb/rom/commit/e7878b1fce97bc43f2b9c85bf761af3bf238246a
|
diff --git a/spec/integration/cli_locks_spec.rb b/spec/integration/cli_locks_spec.rb
index abc1234..def5678 100644
--- a/spec/integration/cli_locks_spec.rb
+++ b/spec/integration/cli_locks_spec.rb
@@ -4,15 +4,23 @@ with_reset_sandbox_before_each
context 'when a deployment is in progress' do
- before do
+ l... | Make locks spec more deterministic
Signed-off-by: Maria Shaldibina <dc03896a0185453e5852a5e0f0fab6cbd2e026ff@pivotal.io>
|
diff --git a/spec/rackson/object_mapper_spec.rb b/spec/rackson/object_mapper_spec.rb
index abc1234..def5678 100644
--- a/spec/rackson/object_mapper_spec.rb
+++ b/spec/rackson/object_mapper_spec.rb
@@ -32,7 +32,23 @@ end
it 'understands optional properties' do
+ expect(deserialized.something_optional).to... | Add tests for more cases.
|
diff --git a/spec/shoes/builtin_methods_spec.rb b/spec/shoes/builtin_methods_spec.rb
index abc1234..def5678 100644
--- a/spec/shoes/builtin_methods_spec.rb
+++ b/spec/shoes/builtin_methods_spec.rb
@@ -3,8 +3,6 @@ describe Shoes::BuiltinMethods do
let(:input_blk) { Proc.new {} }
let(:app) { Shoes::App.new({}, &inp... | Remove unused subject in specs
|
diff --git a/spec/spec_helper/load_path_spec.rb b/spec/spec_helper/load_path_spec.rb
index abc1234..def5678 100644
--- a/spec/spec_helper/load_path_spec.rb
+++ b/spec/spec_helper/load_path_spec.rb
@@ -31,7 +31,7 @@ expect($LOAD_PATH).to include(THIRD_PARTY_DIR)
end
- it('should already have unique paths') do
... | Revert "Make word "path" plural"
This reverts commit 1dbc4c3feed1ab4774e5a122b1af9ed5b533062a.
|
diff --git a/spec/unit/add_launch_agent_spec.rb b/spec/unit/add_launch_agent_spec.rb
index abc1234..def5678 100644
--- a/spec/unit/add_launch_agent_spec.rb
+++ b/spec/unit/add_launch_agent_spec.rb
@@ -21,7 +21,7 @@ it 'symlinks the homebrew launch configuration into the launchAgents folder' do
expect(runner).to ... | Update unit spec for modern Chef
The link resource default link_type is now :symbolic instead of Symbol
|
diff --git a/spec/unit/virtus/attribute_spec.rb b/spec/unit/virtus/attribute_spec.rb
index abc1234..def5678 100644
--- a/spec/unit/virtus/attribute_spec.rb
+++ b/spec/unit/virtus/attribute_spec.rb
@@ -60,4 +60,16 @@ it_behaves_like 'a class with boolean attribute'
end
end
+
+ context 'with a module' do
+... | Extend spec for Virtus.attribute with a module example
|
diff --git a/spec/helpers/contextual_link_helpers_spec.rb b/spec/helpers/contextual_link_helpers_spec.rb
index abc1234..def5678 100644
--- a/spec/helpers/contextual_link_helpers_spec.rb
+++ b/spec/helpers/contextual_link_helpers_spec.rb
@@ -0,0 +1,19 @@+require "rails_helper"
+
+describe ContextualLinkHelpers do
+ des... | Add spec to test for contextual_links method properly handling nil block.
|
diff --git a/spec/requests/admin/admin_activities_spec.rb b/spec/requests/admin/admin_activities_spec.rb
index abc1234..def5678 100644
--- a/spec/requests/admin/admin_activities_spec.rb
+++ b/spec/requests/admin/admin_activities_spec.rb
@@ -0,0 +1,51 @@+require 'rails_helper'
+
+RSpec.describe "Admin::Activities", type... | Add admin/activities request test with index and create parts
|
diff --git a/Library/Formula/libdap.rb b/Library/Formula/libdap.rb
index abc1234..def5678 100644
--- a/Library/Formula/libdap.rb
+++ b/Library/Formula/libdap.rb
@@ -16,6 +16,12 @@ "--disable-debug",
"--disable-dependency-tracking",
"--prefix=#{prefix}",
+ # __Always pass the... | LibDAP: Use explicit path to system curl
Without this we get some really nasty arch flags in `dap-config` on Leopard and
Snow Leopard due to a fallback to buggy `libcurl.pc` files shipped with the
system.
|
diff --git a/Casks/blu-ray-player.rb b/Casks/blu-ray-player.rb
index abc1234..def5678 100644
--- a/Casks/blu-ray-player.rb
+++ b/Casks/blu-ray-player.rb
@@ -1,6 +1,6 @@ class BluRayPlayer < Cask
- version '2.10.4'
- sha256 '76e9731115b3305ba21f5c451f90d2123fd357defca8206a496a8f9b63480cc1'
+ version 'latest'
+ sha25... | Upgrade Blu-Ray-Player to latest version
|
diff --git a/lib/infra_operator/commands/base.rb b/lib/infra_operator/commands/base.rb
index abc1234..def5678 100644
--- a/lib/infra_operator/commands/base.rb
+++ b/lib/infra_operator/commands/base.rb
@@ -1,6 +1,8 @@ module InfraOperator
module Commands
class Base
+ class BackendIncompatibleError < Standar... | Raise error when given backend is incompatible
|
diff --git a/lib/mongomodel/support/reference.rb b/lib/mongomodel/support/reference.rb
index abc1234..def5678 100644
--- a/lib/mongomodel/support/reference.rb
+++ b/lib/mongomodel/support/reference.rb
@@ -12,6 +12,10 @@
def hash
id.hash
+ end
+
+ def as_json(*)
+ to_s
end
... | Fix JSON serialization of Reference type
|
diff --git a/lib/rubocop/cop/metrics/abc_size.rb b/lib/rubocop/cop/metrics/abc_size.rb
index abc1234..def5678 100644
--- a/lib/rubocop/cop/metrics/abc_size.rb
+++ b/lib/rubocop/cop/metrics/abc_size.rb
@@ -10,16 +10,27 @@ include MethodComplexity
MSG = 'Assignment Branch Condition size for %s is too h... | Change AbcSize to only iterate through child nodes once
|
diff --git a/spec/feature/accept_invitation_spec.rb b/spec/feature/accept_invitation_spec.rb
index abc1234..def5678 100644
--- a/spec/feature/accept_invitation_spec.rb
+++ b/spec/feature/accept_invitation_spec.rb
@@ -1,6 +1,6 @@ require 'rails_helper'
-RSpec.feature 'Visiting the invitation page', type: :feature do
+... | Use poltergeist for all Capybara tests
|
diff --git a/stitches.gemspec b/stitches.gemspec
index abc1234..def5678 100644
--- a/stitches.gemspec
+++ b/stitches.gemspec
@@ -14,11 +14,11 @@
s.files = `git ls-files`.split("\n")
s.test_files = `git ls-files -- {test,spec,features}/*`.split("\n")
- s.executables = `git ls-files -- bin/*`.split("... | Update gemspec with current conventions |
diff --git a/app/controllers/spree/global_collect_checkouts_controller.rb b/app/controllers/spree/global_collect_checkouts_controller.rb
index abc1234..def5678 100644
--- a/app/controllers/spree/global_collect_checkouts_controller.rb
+++ b/app/controllers/spree/global_collect_checkouts_controller.rb
@@ -10,7 +10,7 @@ ... | Check if payments can be completed before completion
|
diff --git a/DMNetworkHelper.podspec b/DMNetworkHelper.podspec
index abc1234..def5678 100644
--- a/DMNetworkHelper.podspec
+++ b/DMNetworkHelper.podspec
@@ -10,7 +10,7 @@
s.source = { :git => "https://github.com/DimaAvvakumov/DMNetworkHelper.git" }
s.source_files = "classes/*.{h,m}"
- s.public_header_file... | Fix typo in s.public_header_files podspec
|
diff --git a/guard-spork.gemspec b/guard-spork.gemspec
index abc1234..def5678 100644
--- a/guard-spork.gemspec
+++ b/guard-spork.gemspec
@@ -16,7 +16,7 @@ s.required_rubygems_version = '>= 1.3.6'
s.rubyforge_project = 'guard-spork'
- s.add_dependency 'guard', '>= 0.2.2'
+ s.add_dependency 'guard', '>= ... | Update guard dependency to 0.8.2 |
diff --git a/app/controllers/admin/authors_controller.rb b/app/controllers/admin/authors_controller.rb
index abc1234..def5678 100644
--- a/app/controllers/admin/authors_controller.rb
+++ b/app/controllers/admin/authors_controller.rb
@@ -1,4 +1,6 @@ class Admin::AuthorsController < Admin::BaseController
+ layout "boots... | Move authors to bootstrap admin
|
diff --git a/app/controllers/admin/metrics_controller.rb b/app/controllers/admin/metrics_controller.rb
index abc1234..def5678 100644
--- a/app/controllers/admin/metrics_controller.rb
+++ b/app/controllers/admin/metrics_controller.rb
@@ -6,8 +6,14 @@
def schedule
worker = MetricWorker.worker_class(@metric)
+ ... | Update job document if it already exists
Apparently, I have not understood yet how the MongoDB, respectively
Mongoid update mechanism works. If I use .create! on attributes, which
theoretically map to the same object, it is not updated to the new
value. What works for now is to try to fetch the job document and use
.u... |
diff --git a/app/controllers/georgia/pages_controller.rb b/app/controllers/georgia/pages_controller.rb
index abc1234..def5678 100644
--- a/app/controllers/georgia/pages_controller.rb
+++ b/app/controllers/georgia/pages_controller.rb
@@ -1,7 +1,5 @@ module Georgia
class PagesController < Georgia::ApplicationControlle... | Fix cancan on abstract inheritance
|
diff --git a/app/controllers/registrations_controller.rb b/app/controllers/registrations_controller.rb
index abc1234..def5678 100644
--- a/app/controllers/registrations_controller.rb
+++ b/app/controllers/registrations_controller.rb
@@ -16,6 +16,6 @@ end
def after_update_path_for(resource)
- session[:previous... | Modify after_update_path in registrations controller
|
diff --git a/app/controllers/release_notes_controller.rb b/app/controllers/release_notes_controller.rb
index abc1234..def5678 100644
--- a/app/controllers/release_notes_controller.rb
+++ b/app/controllers/release_notes_controller.rb
@@ -9,7 +9,7 @@ release_notes = ReleaseNotes.new(start_note)
@notes = content_... | Fix for release notes alert not clearing.
|
diff --git a/app/models/spree/look_book_image_product.rb b/app/models/spree/look_book_image_product.rb
index abc1234..def5678 100644
--- a/app/models/spree/look_book_image_product.rb
+++ b/app/models/spree/look_book_image_product.rb
@@ -23,6 +23,9 @@
module Spree
class LookBookImageProduct < ActiveRecord::Base
+
+... | Add default scope to look book image product
|
diff --git a/test/lib/test_query_result_collection.rb b/test/lib/test_query_result_collection.rb
index abc1234..def5678 100644
--- a/test/lib/test_query_result_collection.rb
+++ b/test/lib/test_query_result_collection.rb
@@ -0,0 +1,29 @@+require 'test_helper'
+
+class TestQueryResultCollection < Test::Unit::TestCase
+ ... | Add query result collection test file and test that initialize method sets instance variables as expected.
|
diff --git a/config/app.rb b/config/app.rb
index abc1234..def5678 100644
--- a/config/app.rb
+++ b/config/app.rb
@@ -14,6 +14,11 @@
DB = Sequel.connect(ENV.fetch('DATABASE_URL', 'postgres://localhost/wikimum'))
+# https://github.com/Starkast/wikimum/issues/412
+# https://sequel.jeremyevans.net/rdoc-plugins/files/li... | Validate database connections every 5th minute
Hopefully addresses the issues with using Fly.io hosted Postgres.
Close #412
Fixes WIKI-15
Fixes WIKI-17
|
diff --git a/lib/chinese_t2s/middleware.rb b/lib/chinese_t2s/middleware.rb
index abc1234..def5678 100644
--- a/lib/chinese_t2s/middleware.rb
+++ b/lib/chinese_t2s/middleware.rb
@@ -12,7 +12,7 @@ if status == 200 && bodies.present?
params = env['rack.request.query_hash'] || {}
- if (env['ra... | Remove session[:chinese_t2s_lang] and there is no auto-translating now
|
diff --git a/lib/tasks/publishing_api.rake b/lib/tasks/publishing_api.rake
index abc1234..def5678 100644
--- a/lib/tasks/publishing_api.rake
+++ b/lib/tasks/publishing_api.rake
@@ -0,0 +1,9 @@+namespace :publishing_api do
+ desc "Send pages to the content-api"
+ task :register => :environment do
+ %w[bank-holidays... | Add rake task to republish all calendars
This uses functionality implemented earlier.
Run with `rake publishing_api:register`.
|
diff --git a/lib/thor-install-gist/hook.rb b/lib/thor-install-gist/hook.rb
index abc1234..def5678 100644
--- a/lib/thor-install-gist/hook.rb
+++ b/lib/thor-install-gist/hook.rb
@@ -9,5 +9,15 @@
Gem.pre_uninstall do |uninstalled|
$stderr.puts "[I] uninstalling thor tasks for thor-install-gist"
- Thor::Runner.new.u... | Handle errors on gem uninstall
|
diff --git a/lib/ws_light/set/color_set.rb b/lib/ws_light/set/color_set.rb
index abc1234..def5678 100644
--- a/lib/ws_light/set/color_set.rb
+++ b/lib/ws_light/set/color_set.rb
@@ -11,8 +11,8 @@
def initialize(length = DEFAULT_LENGTH, type = DEFAULT_TYPE)
@length = length
+ @type = type
... | [BUGFIX] Set type first then get full length
|
diff --git a/spec/lib/redis_cacheable_spec.rb b/spec/lib/redis_cacheable_spec.rb
index abc1234..def5678 100644
--- a/spec/lib/redis_cacheable_spec.rb
+++ b/spec/lib/redis_cacheable_spec.rb
@@ -21,6 +21,10 @@ }
end
+class ProcKeyObject < CacheableObject
+ redis_key ->(object) { "object_#{object.id}" }
+end
+
desc... | Add test case: redis_key is proc
|
diff --git a/spec/unit/recipes/global_spec.rb b/spec/unit/recipes/global_spec.rb
index abc1234..def5678 100644
--- a/spec/unit/recipes/global_spec.rb
+++ b/spec/unit/recipes/global_spec.rb
@@ -13,4 +13,24 @@ expect(template.source).to eq("logrotate-global.erb")
expect(template.mode).to eq("0644")
end
+
+ s... | Add unit test for the global scripts feature |
diff --git a/test/models/item_test.rb b/test/models/item_test.rb
index abc1234..def5678 100644
--- a/test/models/item_test.rb
+++ b/test/models/item_test.rb
@@ -4,4 +4,8 @@ # test "the truth" do
# assert true
# end
+ test "should not save item without name, description, quantity, or price" do
+ item = Ite... | Write test checking validations for creating a new item work
|
diff --git a/test/models/user_test.rb b/test/models/user_test.rb
index abc1234..def5678 100644
--- a/test/models/user_test.rb
+++ b/test/models/user_test.rb
@@ -13,4 +13,9 @@ @user.name = ' '
assert_not @user.valid?
end
+
+ test 'email should be present' do
+ @user.email = ' '
+ assert_not @user.... | Add test case for user's email presence
|
diff --git a/app/models/manageiq/providers/openstack/cloud_manager/vnf/status.rb b/app/models/manageiq/providers/openstack/cloud_manager/vnf/status.rb
index abc1234..def5678 100644
--- a/app/models/manageiq/providers/openstack/cloud_manager/vnf/status.rb
+++ b/app/models/manageiq/providers/openstack/cloud_manager/vnf/s... | Handle VNF error state correctly
Handle VNF error state correctly
|
diff --git a/lib/by_navigation/configuration.rb b/lib/by_navigation/configuration.rb
index abc1234..def5678 100644
--- a/lib/by_navigation/configuration.rb
+++ b/lib/by_navigation/configuration.rb
@@ -18,6 +18,7 @@ end
def self.get_item(id_or_url = :main)
+ id_or_url = "/#{id_or_url}" if id_or_url.is_a?... | get_item: Add slash at the start of url if not present
|
diff --git a/spec/adapters/active_record_spec.rb b/spec/adapters/active_record_spec.rb
index abc1234..def5678 100644
--- a/spec/adapters/active_record_spec.rb
+++ b/spec/adapters/active_record_spec.rb
@@ -31,4 +31,9 @@ $passed_args.first[:param].should == 2
$passed_args.first.should be_an_instance_of ActiveSup... | Add a spec to make sure we support Rails' 1.day.from_now syntax.
|
diff --git a/spec/models/axiom_selection_spec.rb b/spec/models/axiom_selection_spec.rb
index abc1234..def5678 100644
--- a/spec/models/axiom_selection_spec.rb
+++ b/spec/models/axiom_selection_spec.rb
@@ -2,7 +2,7 @@
describe AxiomSelection do
context 'associations' do
- it { should have_one(:proof_attempt_conf... | Use expect syntax for specs.
|
diff --git a/TilllessBCScanner.podspec b/TilllessBCScanner.podspec
index abc1234..def5678 100644
--- a/TilllessBCScanner.podspec
+++ b/TilllessBCScanner.podspec
@@ -1,6 +1,6 @@ Pod::Spec.new do |s|
s.name = "TilllessBCScanner"
- s.version = "0.0.1"
+ s.version = "0.0.2"
s.summary ... | Update to remedy after upgrade to 0.36.1 of cocoapods
|
diff --git a/rails-erd.gemspec b/rails-erd.gemspec
index abc1234..def5678 100644
--- a/rails-erd.gemspec
+++ b/rails-erd.gemspec
@@ -13,8 +13,6 @@ s.description = %q{Automatically generate an entity-relationship diagram (ERD) for your Rails models.}
s.license = "MIT"
- s.rubyforge_project = "rails-erd"
-
... | Remove rubyforge_project name from gemspec :skull: RubyForge
|
diff --git a/mongoid_magic_counter_cache.gemspec b/mongoid_magic_counter_cache.gemspec
index abc1234..def5678 100644
--- a/mongoid_magic_counter_cache.gemspec
+++ b/mongoid_magic_counter_cache.gemspec
@@ -19,7 +19,7 @@ s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
s.require_path... | Remove mongoid version because we want to support both Mongoid 2.x and 3.x.
|
diff --git a/git-authors.gemspec b/git-authors.gemspec
index abc1234..def5678 100644
--- a/git-authors.gemspec
+++ b/git-authors.gemspec
@@ -16,4 +16,6 @@ gem.executables = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
gem.test_files = gem.files.grep(%r{^(test|spec|features)/})
gem.require_paths = ... | Add rspec as development dependency
|
diff --git a/app/controllers/api/v1/dependencies_controller.rb b/app/controllers/api/v1/dependencies_controller.rb
index abc1234..def5678 100644
--- a/app/controllers/api/v1/dependencies_controller.rb
+++ b/app/controllers/api/v1/dependencies_controller.rb
@@ -1,6 +1,6 @@ class Api::V1::DependenciesController < Api::Ba... | Revert "Don't throw error if gems param is omitted" until some tests are
in place for this
This reverts commit 3d367904b3e9fe341c37b349630c27c581f127fb.
|
diff --git a/app/controllers/users/contributions_controller.rb b/app/controllers/users/contributions_controller.rb
index abc1234..def5678 100644
--- a/app/controllers/users/contributions_controller.rb
+++ b/app/controllers/users/contributions_controller.rb
@@ -1,15 +1,17 @@ class Users::ContributionsController < Applic... | Migrate user contributions controller to pundit
|
diff --git a/schnitzelstyle.gemspec b/schnitzelstyle.gemspec
index abc1234..def5678 100644
--- a/schnitzelstyle.gemspec
+++ b/schnitzelstyle.gemspec
@@ -9,7 +9,7 @@ gem.homepage = "http://schnitzelpress.org/schnitzelstyle/"
gem.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
... | Update gemspec to thin down .gem contents. |
diff --git a/config/initializers/exception_notification.rb b/config/initializers/exception_notification.rb
index abc1234..def5678 100644
--- a/config/initializers/exception_notification.rb
+++ b/config/initializers/exception_notification.rb
@@ -2,5 +2,5 @@ Rails.application.config.middleware.use ExceptionNotifier,
... | Revert "Use notification email address"
Wrong email address.
This reverts commit 9123f1d42c5b17b94df88a53c2f10f10934139af.
|
diff --git a/sanitize-rails.gemspec b/sanitize-rails.gemspec
index abc1234..def5678 100644
--- a/sanitize-rails.gemspec
+++ b/sanitize-rails.gemspec
@@ -18,5 +18,5 @@ s.files = `git ls-files`.split("\n")
s.add_dependency "rails", ">= 3.0"
- s.add_dependency "sanitize", "~> 3.0"
+ s.add_dependency "s... | Allow sanitize 3.0 and up
|
diff --git a/core/lib/spree/testing_support/common_rake.rb b/core/lib/spree/testing_support/common_rake.rb
index abc1234..def5678 100644
--- a/core/lib/spree/testing_support/common_rake.rb
+++ b/core/lib/spree/testing_support/common_rake.rb
@@ -14,7 +14,7 @@ ENV["RAILS_ENV"] = 'test'
Spree::DummyGenerator.st... | Fix install generator auth option in common rake tasks
This issue was preventing solidus from being installed in all
extensions, making specs fail against master.
|
diff --git a/core/spec/models/spree/product_filter_spec.rb b/core/spec/models/spree/product_filter_spec.rb
index abc1234..def5678 100644
--- a/core/spec/models/spree/product_filter_spec.rb
+++ b/core/spec/models/spree/product_filter_spec.rb
@@ -11,7 +11,7 @@ end
it "does not attempt to call value method on A... | [core] Clean up RSpec deprecation warnings wrt 'should_not raise_error(SpecificError)'
|
diff --git a/Casks/notedup.rb b/Casks/notedup.rb
index abc1234..def5678 100644
--- a/Casks/notedup.rb
+++ b/Casks/notedup.rb
@@ -4,7 +4,7 @@
url 'https://app.yinxiang.com/shard/s10/sh/a2d0903c-f751-48fd-a5c0-68d7bcd0c450/ce188822309c0124ba328248e1bed420/res/03724cac-da8f-4981-ac1d-946bb46fa19c/NoteDup_Mac_201403140... | Fix homepage to use SSL in NoteDup Cask
The HTTP URL is already getting redirected to HTTPS. Using the HTTPS URL directly
makes it more secure and saves a HTTP round-trip.
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.