diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -20,8 +20,8 @@ # Section API objects if SECTIONS + $api_sections = {} SECTION...
Fix logic to not empty $api_sections hash
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -2,7 +2,7 @@ protect_from_forgery rescue_from CanCan::AccessDenied do |exception| - ...
Update Violation Page for Error Message Update the Violation page to ensure the error is displayed in the view.
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -8,7 +8,7 @@ # Don't use SSL for the TrackingController and only in production force_ss...
Use logger to output debugging info
diff --git a/test/integration/admin/create_admin_test.rb b/test/integration/admin/create_admin_test.rb index abc1234..def5678 100644 --- a/test/integration/admin/create_admin_test.rb +++ b/test/integration/admin/create_admin_test.rb @@ -0,0 +1,23 @@+require "test_helper" + +class Admin::CreateAdminTest < ActionDispatch...
Add integration test for creating admins
diff --git a/app/controllers/categories_controller.rb b/app/controllers/categories_controller.rb index abc1234..def5678 100644 --- a/app/controllers/categories_controller.rb +++ b/app/controllers/categories_controller.rb @@ -1,12 +1,12 @@ class CategoriesController < ApplicationController inherit_resources - acti...
Rewrite CategoriesController index action to not use inherited_resources
diff --git a/spec/error_spec.rb b/spec/error_spec.rb index abc1234..def5678 100644 --- a/spec/error_spec.rb +++ b/spec/error_spec.rb @@ -4,14 +4,10 @@ describe Error do describe '#initialize' do context 'required params are set' do - subject { described_class.new(code: anything, message: anything) ...
Test that the initialization does not raise error Instead of explicitly testing instance variable setting, simply test that no errors are raised with refactored kw arguments.
diff --git a/doc/ex/preview.rb b/doc/ex/preview.rb index abc1234..def5678 100644 --- a/doc/ex/preview.rb +++ b/doc/ex/preview.rb @@ -3,7 +3,14 @@ require 'RMagick' img = Magick::Image.read("images/Blonde_with_dog.jpg").first -preview = img.preview(Magick::SolarizePreview) + +begin + preview = img.preview(Magick::...
Handle "not supported" exception when built with IM < 5.5.8
diff --git a/spec/features/applications/over_61_applicants_can_complete_form_spec.rb b/spec/features/applications/over_61_applicants_can_complete_form_spec.rb index abc1234..def5678 100644 --- a/spec/features/applications/over_61_applicants_can_complete_form_spec.rb +++ b/spec/features/applications/over_61_applicants_c...
Test for progression through over 61 applications
diff --git a/config/initializers/cookies_serializer.rb b/config/initializers/cookies_serializer.rb index abc1234..def5678 100644 --- a/config/initializers/cookies_serializer.rb +++ b/config/initializers/cookies_serializer.rb @@ -1,3 +1,3 @@ # Be sure to restart your server when you modify this file. -Rails.applicatio...
Use hybrid cookie serializer until everyone's cookies are JSON
diff --git a/favourite-language.gemspec b/favourite-language.gemspec index abc1234..def5678 100644 --- a/favourite-language.gemspec +++ b/favourite-language.gemspec @@ -1,9 +1,10 @@ Gem::Specification.new do |s| - s.name = 'favourite-language' - s.version = '0.1.1' - s.author = 'Andrew White' - s.email = 'and...
Add link to GitHub repository
diff --git a/spec/actions_spec.rb b/spec/actions_spec.rb index abc1234..def5678 100644 --- a/spec/actions_spec.rb +++ b/spec/actions_spec.rb @@ -0,0 +1,81 @@+require 'printfection' + +module Printfection + class Widget < Resource + include Actions::Retrieve + include Actions::List + include Actions::Create + ...
Add specs for Actions mixins
diff --git a/spec/default_spec.rb b/spec/default_spec.rb index abc1234..def5678 100644 --- a/spec/default_spec.rb +++ b/spec/default_spec.rb @@ -0,0 +1,23 @@+require 'chefspec' + +describe 'tdi-example-vim::default' do + let :chef_run do + ChefSpec::SoloRunner.new(platform: 'ubuntu', version: '12.04') + end + + i...
Add spec for default recipe
diff --git a/spec/quality_spec.rb b/spec/quality_spec.rb index abc1234..def5678 100644 --- a/spec/quality_spec.rb +++ b/spec/quality_spec.rb @@ -0,0 +1,60 @@+require "spec_helper" + +# Borrowed from Bundler +# https://github.com/carlhuda/bundler/blob/1-0-stable/spec/quality_spec.rb +describe "The library itself" do + ...
Add a spec to enforce formatting code well This spec was ripped straight from Bundler (https://github.com/carlhuda/bundler/blob/1-0-stable/spec/quality_spec.rb)
diff --git a/spec/rails_helper.rb b/spec/rails_helper.rb index abc1234..def5678 100644 --- a/spec/rails_helper.rb +++ b/spec/rails_helper.rb @@ -11,3 +11,6 @@ # Only require the top-level files that are one level deep # All support/** sub-folders should be required by the top-level files Dir[Rails.root.join("spec/sup...
Maintain the test schema migrations automatically
diff --git a/spec/support_spec.rb b/spec/support_spec.rb index abc1234..def5678 100644 --- a/spec/support_spec.rb +++ b/spec/support_spec.rb @@ -0,0 +1,22 @@+require 'spec_helper' + +describe RSpec::Puppet::Support do + subject do + klass = Class.new do + include RSpec::Puppet::Support + end + klass.new ...
Add spec coverage of parser configuration Without this patch we don't have any spec coverage of the :parser configuration addition in the previous patch. This patch adds two tests that makes sure the setup_puppet method configures Puppet with the :parser setting. We don't actually test to make sure the configuration...
diff --git a/test/logging_test.rb b/test/logging_test.rb index abc1234..def5678 100644 --- a/test/logging_test.rb +++ b/test/logging_test.rb @@ -0,0 +1,44 @@+require File.expand_path(File.join(File.dirname(__FILE__), "test_helper")) + +require 'onelogin/ruby-saml/logging' + +class LoggingTest < Minitest::Test + + desc...
Add tests for existing Logging functionality
diff --git a/app/controllers/comments_controller.rb b/app/controllers/comments_controller.rb index abc1234..def5678 100644 --- a/app/controllers/comments_controller.rb +++ b/app/controllers/comments_controller.rb @@ -42,7 +42,10 @@ def destroy @resource = @comment.resource @comment.destroy if correct_user?(...
Add json reponse to delete.
diff --git a/app/controllers/messages_controller.rb b/app/controllers/messages_controller.rb index abc1234..def5678 100644 --- a/app/controllers/messages_controller.rb +++ b/app/controllers/messages_controller.rb @@ -0,0 +1,30 @@+class MessagesController < ApplicationController + #before_action :require_login + #befo...
Add a Messages Controller for the message resource. The messages controller requires a user to be logged in; checks to make sure that the user is either a responder or a requester of a particular request before creating a new message. If the user successfully creates a new message, an event alert is sent to Pusher.com...
diff --git a/test/test_command.rb b/test/test_command.rb index abc1234..def5678 100644 --- a/test/test_command.rb +++ b/test/test_command.rb @@ -1,38 +1,6 @@ require 'helper' class TestCommand < Test::Unit::TestCase - context "when calling .ignore_paths" do - context "when source is absolute" do - setup { @...
Remove tests for the Command.ignored_paths method which now lives in jekyll-watch.
diff --git a/app/controllers/profiles_controller.rb b/app/controllers/profiles_controller.rb index abc1234..def5678 100644 --- a/app/controllers/profiles_controller.rb +++ b/app/controllers/profiles_controller.rb @@ -24,6 +24,16 @@ end def profile_params - params.require(:profile).permit(:avatar) + params ...
Allow strong parameters to be editable
diff --git a/app/controllers/sessions_controller.rb b/app/controllers/sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/sessions_controller.rb +++ b/app/controllers/sessions_controller.rb @@ -25,9 +25,13 @@ end def destroy - current_user.logout_and_save! if current_user - session[:...
Make sure http referrer is from Cloudsdale. Signed-off-by: Philip Vieira <3ba3974e96044dcde818e6310ed799abe10671d4@vallin.se>
diff --git a/app/controllers/settings_controller.rb b/app/controllers/settings_controller.rb index abc1234..def5678 100644 --- a/app/controllers/settings_controller.rb +++ b/app/controllers/settings_controller.rb @@ -3,25 +3,28 @@ end def password - user = User.find_by_id(session[:user_id]) - @pass_form = ...
Disable password changes for now
diff --git a/dismissible_blocks.gemspec b/dismissible_blocks.gemspec index abc1234..def5678 100644 --- a/dismissible_blocks.gemspec +++ b/dismissible_blocks.gemspec @@ -20,6 +20,8 @@ 'LICENSE.txt' ] + s.post_install_message = 'DismissibleBlocks 2+ removed jQuery as a dependency. See README.' + s.add_runtim...
Add RubyGems post install message
diff --git a/tests/aws/models/storage/url_tests.rb b/tests/aws/models/storage/url_tests.rb index abc1234..def5678 100644 --- a/tests/aws/models/storage/url_tests.rb +++ b/tests/aws/models/storage/url_tests.rb @@ -2,7 +2,7 @@ Shindo.tests('AWS | url', ["aws"]) do - @expires = DateTime.parse('2013-01-01T00:00:00Z')....
[AWS] Create the time directly in tests, avoids using a method not present in 1.8.7
diff --git a/spec/btc_ticker_spec.rb b/spec/btc_ticker_spec.rb index abc1234..def5678 100644 --- a/spec/btc_ticker_spec.rb +++ b/spec/btc_ticker_spec.rb @@ -1,30 +1,28 @@ require "spec_helper" describe "BtcTicker::Bitstamp::API::Ticker" do - context "Given the input parameter - btc_usd" do - describe "#get_json"...
Refactor and clean up the code in the spec file
diff --git a/traject-solrj_writer.gemspec b/traject-solrj_writer.gemspec index abc1234..def5678 100644 --- a/traject-solrj_writer.gemspec +++ b/traject-solrj_writer.gemspec @@ -9,9 +9,8 @@ spec.version = Traject::SolrJWriter::VERSION spec.authors = ["Bill Dueber"] spec.email = ["bill@dueber....
Update spec with homepage and summary
diff --git a/spec/notifyable_spec.rb b/spec/notifyable_spec.rb index abc1234..def5678 100644 --- a/spec/notifyable_spec.rb +++ b/spec/notifyable_spec.rb @@ -18,4 +18,14 @@ FwtPushNotificationServer.deliveries.count.should == 1 FwtPushNotificationServer.deliveries[0].recipients.count.should == 2 end + + i...
Add test for invalid token
diff --git a/spec/support/command.rb b/spec/support/command.rb index abc1234..def5678 100644 --- a/spec/support/command.rb +++ b/spec/support/command.rb @@ -1,18 +1,24 @@-def simple_command(v, opts = {}) - Expeditor::Command.new(opts) do - v +module CommandHelpers + def simple_command(v, opts = {}) + Expeditor:...
Change global methods to module methods
diff --git a/acts_as_paranoid.gemspec b/acts_as_paranoid.gemspec index abc1234..def5678 100644 --- a/acts_as_paranoid.gemspec +++ b/acts_as_paranoid.gemspec @@ -6,11 +6,11 @@ Gem::Specification.new do |spec| spec.name = "acts_as_paranoid" spec.version = ActsAsParanoid::VERSION - spec.authors = ["G...
Add Zachary to the authors and change the gem homepage.
diff --git a/lib/deployable/recipes/default_with_database.rb b/lib/deployable/recipes/default_with_database.rb index abc1234..def5678 100644 --- a/lib/deployable/recipes/default_with_database.rb +++ b/lib/deployable/recipes/default_with_database.rb @@ -37,6 +37,11 @@ require "deployable/passenger_standalone" after...
Add config files to default recipe
diff --git a/lib/paperclip_processors/custom_file_preview.rb b/lib/paperclip_processors/custom_file_preview.rb index abc1234..def5678 100644 --- a/lib/paperclip_processors/custom_file_preview.rb +++ b/lib/paperclip_processors/custom_file_preview.rb @@ -10,16 +10,26 @@ dst = TempfileFactory.new.generate("#{basenam...
Move PDF thumbnail generation to ImageMagick Closes SCI-3579
diff --git a/lib/redmine_git_hosting/patches/member_patch.rb b/lib/redmine_git_hosting/patches/member_patch.rb index abc1234..def5678 100644 --- a/lib/redmine_git_hosting/patches/member_patch.rb +++ b/lib/redmine_git_hosting/patches/member_patch.rb @@ -9,7 +9,7 @@ base.class_eval do unloadable - ...
Use UseCase to update Project members
diff --git a/lib/streamy/message_buses/rabbit_message_bus.rb b/lib/streamy/message_buses/rabbit_message_bus.rb index abc1234..def5678 100644 --- a/lib/streamy/message_buses/rabbit_message_bus.rb +++ b/lib/streamy/message_buses/rabbit_message_bus.rb @@ -7,7 +7,6 @@ @topic_prefix = topic_prefix Hutch::Co...
Move the hutch connection out of message bus initializer
diff --git a/lib/twentyfour_seven_office/services/company.rb b/lib/twentyfour_seven_office/services/company.rb index abc1234..def5678 100644 --- a/lib/twentyfour_seven_office/services/company.rb +++ b/lib/twentyfour_seven_office/services/company.rb @@ -12,7 +12,7 @@ def all search_params = { changed_af...
Fix incorrect local variable reference
diff --git a/lib/ecc.rb b/lib/ecc.rb index abc1234..def5678 100644 --- a/lib/ecc.rb +++ b/lib/ecc.rb @@ -1,5 +1,109 @@ require "ecc/version" module Ecc - # Your code goes here... + + class Curve + + attr_accessor :a, :b, :fp + + def initialize(a, b, fp) + + @a = a + @b = b + ...
UPDATE create Curve, Point class
diff --git a/db/data_migration/20170213113416_republish_publications_migration_one.rb b/db/data_migration/20170213113416_republish_publications_migration_one.rb index abc1234..def5678 100644 --- a/db/data_migration/20170213113416_republish_publications_migration_one.rb +++ b/db/data_migration/20170213113416_republish_p...
Update data migration to correctly republish Publications Need to use `document_id` not `id`
diff --git a/swftly.gemspec b/swftly.gemspec index abc1234..def5678 100644 --- a/swftly.gemspec +++ b/swftly.gemspec @@ -1,13 +1,14 @@ Gem::Specification.new do |spec| spec.name = 'swftly' - spec.version = '0.1.4' + spec.version = '0.1.42' spec.summary = "swftly abstracts and auto...
Fix a problem causing exclusion of files in the built gem. Minor version bump.
diff --git a/rubygems-compile.gemspec b/rubygems-compile.gemspec index abc1234..def5678 100644 --- a/rubygems-compile.gemspec +++ b/rubygems-compile.gemspec @@ -2,8 +2,6 @@ s.name = 'rubygems-compile' s.version = '1.0.0' - s.required_rubygems_version = Gem::Requirement.new '>= 1.4.2' - s.rubygems_version ...
Remove unneeded spec attributes from the gemspec
diff --git a/app/helpers/component_helper.rb b/app/helpers/component_helper.rb index abc1234..def5678 100644 --- a/app/helpers/component_helper.rb +++ b/app/helpers/component_helper.rb @@ -1,6 +1,7 @@ module ComponentHelper def navigation_items return [] unless current_user + items = [] unless conte...
Add a blank line after a guard clause To improve the readability of the code.
diff --git a/app/helpers/needs_helper.rb b/app/helpers/needs_helper.rb index abc1234..def5678 100644 --- a/app/helpers/needs_helper.rb +++ b/app/helpers/needs_helper.rb @@ -2,7 +2,7 @@ def start_work_link need start_work = "http://#{Plek.current.panopticon}/artefacts/new" - form_tag start_work, :html => { :...
Use GET for asking for the new artefact form
diff --git a/app/jobs/application_job.rb b/app/jobs/application_job.rb index abc1234..def5678 100644 --- a/app/jobs/application_job.rb +++ b/app/jobs/application_job.rb @@ -1,8 +1,6 @@ class ApplicationJob < ActiveJob::Base def self.aws_sqs_queue_url - Rails.configuration.app_settings.fetch("#{to_s.underscore}_qu...
Fix implementation of queue name
diff --git a/features/lib/support/env.rb b/features/lib/support/env.rb index abc1234..def5678 100644 --- a/features/lib/support/env.rb +++ b/features/lib/support/env.rb @@ -1,8 +1,8 @@ # frozen_string_literal: true require 'aruba/cucumber' -require 'aruba/in_process' -require 'aruba/spawn_process' +require 'aruba/pr...
Remove deprecation notices from codebase by using newer aruba classes
diff --git a/dos_detector/dos_detector_worker_init.rb b/dos_detector/dos_detector_worker_init.rb index abc1234..def5678 100644 --- a/dos_detector/dos_detector_worker_init.rb +++ b/dos_detector/dos_detector_worker_init.rb @@ -1,2 +1,7 @@-Userdata.new.shared_cache = Cache.new :namespace =>"dos_detector", :size_mb=> 512 +...
Clear cache which was created before
diff --git a/Casks/intellij-idea-ce-bundled-jdk.rb b/Casks/intellij-idea-ce-bundled-jdk.rb index abc1234..def5678 100644 --- a/Casks/intellij-idea-ce-bundled-jdk.rb +++ b/Casks/intellij-idea-ce-bundled-jdk.rb @@ -1,17 +1,19 @@ cask :v1 => 'intellij-idea-ce-bundled-jdk' do - version '14' - sha256 '09bb078252e2f6af6b58...
Upgrade IntelliJ Idea CE with bundled JDK to 14.1 - Unify with other IntelliJ-based formulas (see #879)
diff --git a/sicuro.gemspec b/sicuro.gemspec index abc1234..def5678 100644 --- a/sicuro.gemspec +++ b/sicuro.gemspec @@ -12,7 +12,7 @@ s.summary = %q{Safe ruby code execution.} s.description = %q{Safe ruby code execution in a standard ruby environment. Does not use a chroot, jail, etc. No special permissions r...
Update gemspec to use Standalone v0.3.0.
diff --git a/test/helper.rb b/test/helper.rb index abc1234..def5678 100644 --- a/test/helper.rb +++ b/test/helper.rb @@ -8,12 +8,19 @@ class MiniTest::Unit::TestCase include PrettyDiff::WordDiffFinder + class FixtureNotFoundError < StandardError; end + def new_diff(*args) PrettyDiff::Diff.new(*args) en...
Raise error when fixture was not found.
diff --git a/fixtures/code/concurrent.rb b/fixtures/code/concurrent.rb index abc1234..def5678 100644 --- a/fixtures/code/concurrent.rb +++ b/fixtures/code/concurrent.rb @@ -2,7 +2,7 @@ Thread.current[:in_concurrent_rb] = true if t = Thread.current[:wait_for] - Thread.pass until t.backtrace && t.backtrace.any? { |ca...
Fix spec to correctly wait for the thread to be waiting in the require lock
diff --git a/schema.gemspec b/schema.gemspec index abc1234..def5678 100644 --- a/schema.gemspec +++ b/schema.gemspec @@ -2,7 +2,7 @@ Gem::Specification.new do |s| s.name = 'evt-schema' s.summary = "Primitives for schema and data structure" - s.version = '2.3.1.1' + s.version = '2.3.1.2' s.description = ' ' ...
Package version is increased from 2.3.1.1 to 2.3.1.2
diff --git a/yard.gemspec b/yard.gemspec index abc1234..def5678 100644 --- a/yard.gemspec +++ b/yard.gemspec @@ -20,4 +20,6 @@ s.executables = ['yard', 'yardoc', 'yri'] s.license = 'MIT' if s.respond_to?(:license=) s.metadata['yard.run'] = 'yri' + + s.add_runtime_dependency 'webrick', '~> 1.7.0' end
Add webrick as runtime dependency WEBrick was removed as a core library in Ruby 3.0 Fixes #1387
diff --git a/semian.gemspec b/semian.gemspec index abc1234..def5678 100644 --- a/semian.gemspec +++ b/semian.gemspec @@ -16,14 +16,13 @@ s.email = 'scott.francis@shopify.com' s.license = 'MIT' - s.metadata['allowed_push_host'] = 'https://rubygems.org' - s.files = Dir['{lib,ext}/**/**/*.{rb,h,c}'] s.extens...
Move allowed_push_host in gemspec to all other metadata.
diff --git a/CreateSend.podspec b/CreateSend.podspec index abc1234..def5678 100644 --- a/CreateSend.podspec +++ b/CreateSend.podspec @@ -5,7 +5,7 @@ s.homepage = "http://campaignmonitor.github.io/createsend-objectivec/" s.license = { :type => "MIT", :file => "LICENSE" } s.authors ...
Use s.version to populate git tag in s.source.
diff --git a/app/models/call_data_record.rb b/app/models/call_data_record.rb index abc1234..def5678 100644 --- a/app/models/call_data_record.rb +++ b/app/models/call_data_record.rb @@ -27,8 +27,7 @@ self.direction = cdr.direction self.duration_sec = cdr.duration_sec self.bill_sec = cdr.bill_sec - save ...
Remove logging but raise errors on validation
diff --git a/app/services/shared_markers.rb b/app/services/shared_markers.rb index abc1234..def5678 100644 --- a/app/services/shared_markers.rb +++ b/app/services/shared_markers.rb @@ -3,11 +3,11 @@ def autolink(link, _link_type) href = if ALLOWED_HOSTS_IN_MARKDOWN.include?(URI(link).host) - link - ...
Apply review suggestion from @nilsding Co-authored-by: Georg Gadinger <9e8f1a26fbf401b045347f083556ffd7c0b25a58@nilsding.org>
diff --git a/test/db/sqlite3.rb b/test/db/sqlite3.rb index abc1234..def5678 100644 --- a/test/db/sqlite3.rb +++ b/test/db/sqlite3.rb @@ -1,8 +1,9 @@ require 'jdbc/sqlite3' if jruby? config = { - :adapter => jruby? ? 'jdbcsqlite3' : 'sqlite3', - :dbfile => 'test.sqlite3.db' + :adapter => jruby? ? 'jdbcsqlite3' :...
Add :database key for newer AR versions
diff --git a/spec/dummy/config/environments/development.rb b/spec/dummy/config/environments/development.rb index abc1234..def5678 100644 --- a/spec/dummy/config/environments/development.rb +++ b/spec/dummy/config/environments/development.rb @@ -11,7 +11,6 @@ # Show full error reports and disable caching config.c...
Fix dummy app for rails 3.1
diff --git a/spec/models/achievement/forever_alone_spec.rb b/spec/models/achievement/forever_alone_spec.rb index abc1234..def5678 100644 --- a/spec/models/achievement/forever_alone_spec.rb +++ b/spec/models/achievement/forever_alone_spec.rb @@ -2,17 +2,4 @@ describe Achievement::ForeverAlone do it_should_behave_li...
Fix specs for forever alone
diff --git a/spec/opsicle/question_asker/eip_asker_spec.rb b/spec/opsicle/question_asker/eip_asker_spec.rb index abc1234..def5678 100644 --- a/spec/opsicle/question_asker/eip_asker_spec.rb +++ b/spec/opsicle/question_asker/eip_asker_spec.rb @@ -7,18 +7,27 @@ let(:instance) do double(:instance, - elastic_i...
Fix the tests for eip_asker
diff --git a/mirrors.rb b/mirrors.rb index abc1234..def5678 100644 --- a/mirrors.rb +++ b/mirrors.rb @@ -13,9 +13,14 @@ $stderr.puts " %s"%text end -while !(mirror = gets).nil? - mirror = mirror.split +while !(line = gets).nil? + mirror = line.split next if mirror.empty? + + if mirror[0][0] == '#' #This l...
mirror: Handle lines that are comments
diff --git a/app/models/ability.rb b/app/models/ability.rb index abc1234..def5678 100644 --- a/app/models/ability.rb +++ b/app/models/ability.rb @@ -0,0 +1,37 @@+class Ability + include CanCan::Ability + + def initialize(user) + user ||= User.new # guest user (not logged in) + + can :read, :all + can [:robot...
Define abilities for admin, mod, user, and anonymous guests
diff --git a/lib/analyze_assessments.rb b/lib/analyze_assessments.rb index abc1234..def5678 100644 --- a/lib/analyze_assessments.rb +++ b/lib/analyze_assessments.rb @@ -0,0 +1,39 @@+require 'csv' + +class AnalyzeAssessments < Struct.new(:path) + + def contents + encoding_options = { + invalid: :replace, + ...
Add code for analyzing assessments data dump + Useful for asking questions about #16, #23
diff --git a/shanty.gemspec b/shanty.gemspec index abc1234..def5678 100644 --- a/shanty.gemspec +++ b/shanty.gemspec @@ -8,8 +8,8 @@ spec.version = Shanty::VERSION spec.authors = ["Andrew De Ponte"] spec.email = ["cyphactor@gmail.com"] - spec.summary = %q{TODO: Write a short summary. ...
Set gem summary & description. I did this for a couple of reasons. First so that I could bundle install without bundler complaining about the TODO items in the gemspec. Second, I did this so that people would be able to see the description of the gem and understand what it is.
diff --git a/app/controllers/letter_bomb/mailers_controller.rb b/app/controllers/letter_bomb/mailers_controller.rb index abc1234..def5678 100644 --- a/app/controllers/letter_bomb/mailers_controller.rb +++ b/app/controllers/letter_bomb/mailers_controller.rb @@ -10,7 +10,7 @@ @action = params[:mailer_action] ...
Check message content type to determine default rendered format.
diff --git a/lib/factory_girl/rails2.rb b/lib/factory_girl/rails2.rb index abc1234..def5678 100644 --- a/lib/factory_girl/rails2.rb +++ b/lib/factory_girl/rails2.rb @@ -1 +1,7 @@-Rails.configuration.after_initialize { FactoryGirl.find_definitions } +Rails.configuration.after_initialize do + FactoryGirl.definition_file...
Add support back in for subdirectory requires. Poor old rails 2.x was forgotten about in fc8ce3ab7. Closes #65
diff --git a/lib/generators/derail/layout/layout_generator.rb b/lib/generators/derail/layout/layout_generator.rb index abc1234..def5678 100644 --- a/lib/generators/derail/layout/layout_generator.rb +++ b/lib/generators/derail/layout/layout_generator.rb @@ -24,5 +24,9 @@ copy_file "application.html.haml", "app/vie...
Add default layout to ApplicationController
diff --git a/lib/gitlab/satellite/files/delete_file_action.rb b/lib/gitlab/satellite/files/delete_file_action.rb index abc1234..def5678 100644 --- a/lib/gitlab/satellite/files/delete_file_action.rb +++ b/lib/gitlab/satellite/files/delete_file_action.rb @@ -0,0 +1,43 @@+require_relative 'file_action' + +module Gitlab + ...
Delete file action for satellites Signed-off-by: Dmitriy Zaporozhets <be23d75b156792e5acab51b196a2deb155d35d6a@gmail.com>
diff --git a/spec/payload/base_spec.rb b/spec/payload/base_spec.rb index abc1234..def5678 100644 --- a/spec/payload/base_spec.rb +++ b/spec/payload/base_spec.rb @@ -34,4 +34,14 @@ expect { Magnum::Payload::Base.new(nil) }.to raise_error "String or Hash required" end end + + describe '#skip' do + befor...
Add test for default skip value
diff --git a/Ashton.podspec b/Ashton.podspec index abc1234..def5678 100644 --- a/Ashton.podspec +++ b/Ashton.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "Ashton" - s.version = "0.1.2" + s.version = "0.1.5" s.summary = "Converts NSAttributedStrings between AppKit, CoreText, UIKit...
Fix podspec to not use FileList and bump to 0.1.5
diff --git a/spec/support/overrides.rb b/spec/support/overrides.rb index abc1234..def5678 100644 --- a/spec/support/overrides.rb +++ b/spec/support/overrides.rb @@ -14,7 +14,9 @@ RSpec.configure do |config| config.before(:suite) do - TestResponse.send(:include, TestResponseStringOverride) + if define...
Fix bug with TestResponse override outside Rails When loading spec_helper instead of rails_helpers, ActionController::TestResponse is not defined.
diff --git a/lib/ey-core/cli/servers.rb b/lib/ey-core/cli/servers.rb index abc1234..def5678 100644 --- a/lib/ey-core/cli/servers.rb +++ b/lib/ey-core/cli/servers.rb @@ -4,20 +4,20 @@ module Core module Cli class Servers < Subcommand - title "servers" - summary "List servers you have access t...
Fix account and environment filters The previous iteration returned an error when specifying an account. Furthermore, when a user has access to multiple accounts with multiple environments of the same name, the environments toggle would return only return the environment for the main account—and since the account coul...
diff --git a/lib/literate_randomizer.rb b/lib/literate_randomizer.rb index abc1234..def5678 100644 --- a/lib/literate_randomizer.rb +++ b/lib/literate_randomizer.rb @@ -42,7 +42,7 @@ end # correctly mirrors method_missing - def respond_to?(method) + def respond_to?(method, include_private = false) ...
Fix wrong number of arguments when trying to stub methods with rspec
diff --git a/lib/regaliator/response.rb b/lib/regaliator/response.rb index abc1234..def5678 100644 --- a/lib/regaliator/response.rb +++ b/lib/regaliator/response.rb @@ -1,3 +1,6 @@+require 'json' +require 'net/http' + module Regaliator class Response attr_reader :success @@ -20,4 +23,4 @@ !success? ...
Add missing requirements in Response. [ci skip]
diff --git a/lib/smitty/smtp_connect.rb b/lib/smitty/smtp_connect.rb index abc1234..def5678 100644 --- a/lib/smitty/smtp_connect.rb +++ b/lib/smitty/smtp_connect.rb @@ -0,0 +1,21 @@+require 'net/smtp' + +module Smitty + def self.smtp_connect(server, port, ssl, username, password) + begin + smtp_server = server...
Put smtp connection login in separate function
diff --git a/lib/static-data/tasks.rake b/lib/static-data/tasks.rake index abc1234..def5678 100644 --- a/lib/static-data/tasks.rake +++ b/lib/static-data/tasks.rake @@ -27,7 +27,7 @@ StaticData.static_data_classes(Rails.root) do |static_data_class| StaticData.report_duration("== #{static_data_class}: updat...
Fix typo in progress messages
diff --git a/lib/toy_robot/direction.rb b/lib/toy_robot/direction.rb index abc1234..def5678 100644 --- a/lib/toy_robot/direction.rb +++ b/lib/toy_robot/direction.rb @@ -53,11 +53,9 @@ return unless facing? self.facing = (@facing + (t * TURN)) % TURN end + + directions.each_with_index do |d, i| + ...
Move constant creation into module
diff --git a/lib/simple_check_runner.rb b/lib/simple_check_runner.rb index abc1234..def5678 100644 --- a/lib/simple_check_runner.rb +++ b/lib/simple_check_runner.rb @@ -5,9 +5,15 @@ class << self def run_check(config, check, &block) - uri = URI(check[:url]) + uri = URI(check.url) start_time = ...
Fix bug in Simple Checker and add POST support to it.
diff --git a/attributes/default.rb b/attributes/default.rb index abc1234..def5678 100644 --- a/attributes/default.rb +++ b/attributes/default.rb @@ -1,4 +1,4 @@-default["collectd"]["version"] = "5.1.1" +default["collectd"]["version"] = "5.4.0" default["collectd"]["dir"] = "/opt/col...
Update collectd version to 5.4.0
diff --git a/kpeg.gemspec b/kpeg.gemspec index abc1234..def5678 100644 --- a/kpeg.gemspec +++ b/kpeg.gemspec @@ -12,7 +12,10 @@ s.summary = %q{Peg-based Code Generator} s.description = %q{A tool for generating parsers using PEG} - s.files = ["LICENSE", "README.md", "Rakefile", "kpeg.gemspec", "Gemfile", "{l...
Fix files going into gemspec
diff --git a/effective_orders.gemspec b/effective_orders.gemspec index abc1234..def5678 100644 --- a/effective_orders.gemspec +++ b/effective_orders.gemspec @@ -18,7 +18,7 @@ s.add_dependency 'rails', '>= 4.0.0' s.add_dependency 'coffee-rails' s.add_dependency 'devise' - s.add_dependency 'sass-rails' + s.add_...
Drop sass-rails dependency, so sites can use sassc-rails or sass-rails.
diff --git a/tty-cursor.gemspec b/tty-cursor.gemspec index abc1234..def5678 100644 --- a/tty-cursor.gemspec +++ b/tty-cursor.gemspec @@ -6,13 +6,15 @@ spec.name = 'tty-cursor' spec.version = TTY::Cursor::VERSION spec.authors = ["Piotr Murach"] - spec.email = [""] + spec.email ...
Change to load files directly
diff --git a/lib/active_scaffold/config/nested.rb b/lib/active_scaffold/config/nested.rb index abc1234..def5678 100644 --- a/lib/active_scaffold/config/nested.rb +++ b/lib/active_scaffold/config/nested.rb @@ -18,7 +18,10 @@ # Add a nested ActionLink def add_link(label, models, options = {}) - @core.acti...
Allow to set html_options in add_link call
diff --git a/lib/dnsimple/struct/domain_record.rb b/lib/dnsimple/struct/domain_record.rb index abc1234..def5678 100644 --- a/lib/dnsimple/struct/domain_record.rb +++ b/lib/dnsimple/struct/domain_record.rb @@ -0,0 +1,40 @@+module Dnsimple + module Struct + + class DomainRecord < Base + # @return [Fixnum] The re...
Add the DomainRecord result type
diff --git a/lib/docile/fallback_context_proxy.rb b/lib/docile/fallback_context_proxy.rb index abc1234..def5678 100644 --- a/lib/docile/fallback_context_proxy.rb +++ b/lib/docile/fallback_context_proxy.rb @@ -21,8 +21,8 @@ # Special case to allow proxy instance variables def instance_variables - # Ruby ...
Modify 1.8.x compatibility fix to preserve original return type On 1.8.x, Object#instance_variables returns an array of strings, whereas it is an array of symbols on later versions. This minor change preserves that it is strings on 1.8.x
diff --git a/lib/komonjo/gateways/messages_gateway.rb b/lib/komonjo/gateways/messages_gateway.rb index abc1234..def5678 100644 --- a/lib/komonjo/gateways/messages_gateway.rb +++ b/lib/komonjo/gateways/messages_gateway.rb @@ -25,8 +25,8 @@ Komonjo::Model::Message.create(e).tap do |message| message...
Rename a local variable which covers another
diff --git a/lib/generators/devise/orm_helpers.rb b/lib/generators/devise/orm_helpers.rb index abc1234..def5678 100644 --- a/lib/generators/devise/orm_helpers.rb +++ b/lib/generators/devise/orm_helpers.rb @@ -4,7 +4,8 @@ def model_contents <<-CONTENT # Include default devise modules. Others available are: - ...
Apply the 80 chars per-line rule
diff --git a/lib/immortal/singular_association.rb b/lib/immortal/singular_association.rb index abc1234..def5678 100644 --- a/lib/immortal/singular_association.rb +++ b/lib/immortal/singular_association.rb @@ -12,6 +12,9 @@ private def deleted_reader(how, force_reload = false) + reset + ...
Reset scope before calling deleted finder
diff --git a/spec/lib/i18n/hygiene/key_usage_checker_spec.rb b/spec/lib/i18n/hygiene/key_usage_checker_spec.rb index abc1234..def5678 100644 --- a/spec/lib/i18n/hygiene/key_usage_checker_spec.rb +++ b/spec/lib/i18n/hygiene/key_usage_checker_spec.rb @@ -10,8 +10,6 @@ it 'finds usage of pluralized key' - it 'd...
Mark this example as pending, ack/ag isn't happy
diff --git a/bin/utilities/output.rb b/bin/utilities/output.rb index abc1234..def5678 100644 --- a/bin/utilities/output.rb +++ b/bin/utilities/output.rb @@ -6,7 +6,7 @@ if raw or not $stdout.isatty @pager = nil elsif Shell.command_exist? 'less' - @pager = 'less -R -F' + @pager = 'les...
Add X option to `less` Allows `less` to act like `cat` if the contents fit in one screen.
diff --git a/lib/tasks/fix_dangling_comments.rake b/lib/tasks/fix_dangling_comments.rake index abc1234..def5678 100644 --- a/lib/tasks/fix_dangling_comments.rake +++ b/lib/tasks/fix_dangling_comments.rake @@ -0,0 +1,20 @@+desc 'Removes comments with missing targets' +task :fix_dangling_comments do + [MergeRequest, Mer...
Add task which removes dangling comments
diff --git a/mute.gemspec b/mute.gemspec index abc1234..def5678 100644 --- a/mute.gemspec +++ b/mute.gemspec @@ -20,4 +20,5 @@ spec.add_development_dependency 'bundler', '~> 1.5' spec.add_development_dependency 'rake', '~> 10.1.1' + spec.add_development_dependency 'rspec', '~> 2.14.1' end
Add rspec as development dependency
diff --git a/totem.gemspec b/totem.gemspec index abc1234..def5678 100644 --- a/totem.gemspec +++ b/totem.gemspec @@ -16,6 +16,4 @@ gem.executables = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) } gem.test_files = gem.files.grep(%r{^(test|spec|features)/}) gem.require_paths = ["lib"] - - gem.add_dep...
Remove dependency on raad gem.
diff --git a/Casks/atom.rb b/Casks/atom.rb index abc1234..def5678 100644 --- a/Casks/atom.rb +++ b/Casks/atom.rb @@ -1,6 +1,6 @@ cask :v1 => 'atom' do - version '1.0.4' - sha256 '90cd22f9e6dfbfdfaa1bc79307c3abf1cf0ef4c07da31199f6e7ced11e0add8a' + version '1.0.5' + sha256 'ed4c55e059195111d9d12ec379849d8d3509062496f...
Upgrade Atom to version 1.0.5.
diff --git a/Casks/epic.rb b/Casks/epic.rb index abc1234..def5678 100644 --- a/Casks/epic.rb +++ b/Casks/epic.rb @@ -7,7 +7,7 @@ name 'Epic Privacy Browser' appcast 'https://updates.epicbrowser.com/mac_updates/appcast.xml', :sha256 => '4249b7347d6edd78f8b421c8838c006731ab03477a6d17bd459cadb9519f4dc5' - ...
Fix homepage to use SSL in Epic Privacy Browser Cask The HTTP URL is already getting redirected to HTTPS. Using the HTTPS URL directly makes it more secure and saves a HTTP round-trip.
diff --git a/gatherer-scraper.gemspec b/gatherer-scraper.gemspec index abc1234..def5678 100644 --- a/gatherer-scraper.gemspec +++ b/gatherer-scraper.gemspec @@ -4,9 +4,12 @@ Gem::Specification.new do |gem| gem.authors = ["bigwheel"] gem.email = ["k.bigwheel+eng@gmail.com"] - gem.description = %q{...
Add description to the gemspec file
diff --git a/kata2_ruby/bowling_game.rb b/kata2_ruby/bowling_game.rb index abc1234..def5678 100644 --- a/kata2_ruby/bowling_game.rb +++ b/kata2_ruby/bowling_game.rb @@ -15,21 +15,26 @@ def score total_score = 0 - is_spare = false - is_strike = false - @frames.each do |frame| + @frames.each_with_ind...
Refactor - 4 examples now failing
diff --git a/lib/intercode/import/intercode1/tables.rb b/lib/intercode/import/intercode1/tables.rb index abc1234..def5678 100644 --- a/lib/intercode/import/intercode1/tables.rb +++ b/lib/intercode/import/intercode1/tables.rb @@ -9,6 +9,8 @@ autoload :Con autoload :Events autoload :GMs, 'intercode/import/interco...
Load the new table importers
diff --git a/lib/lobbyist/v2/social_network_profile.rb b/lib/lobbyist/v2/social_network_profile.rb index abc1234..def5678 100644 --- a/lib/lobbyist/v2/social_network_profile.rb +++ b/lib/lobbyist/v2/social_network_profile.rb @@ -21,6 +21,10 @@ create_from_response(put("/v2/social-network-profiles/reset-facebook...
CA-4094: Add call to reset twitter connection
diff --git a/lib/cocoapods-core/http.rb b/lib/cocoapods-core/http.rb index abc1234..def5678 100644 --- a/lib/cocoapods-core/http.rb +++ b/lib/cocoapods-core/http.rb @@ -38,10 +38,14 @@ # @return [REST::response] # def self.validate_url(url) + if not url =~ /^#{URI.regexp}$/ + return nil + ...
Validate URIs before making requests, only catch SocketErrors. This at least makes sure we do not mask errors (see #117).
diff --git a/spec/features/create_match_spec.rb b/spec/features/create_match_spec.rb index abc1234..def5678 100644 --- a/spec/features/create_match_spec.rb +++ b/spec/features/create_match_spec.rb @@ -0,0 +1,21 @@+require 'spec_helper' + +feature 'Create match' do + background do + @project = create(:project, state...
Add acceptance spec for match creation
diff --git a/spec/features/registration_spec.rb b/spec/features/registration_spec.rb index abc1234..def5678 100644 --- a/spec/features/registration_spec.rb +++ b/spec/features/registration_spec.rb @@ -2,31 +2,43 @@ describe 'RegistrationForm' do feature 'Navigates Registration Form', js: true do + let!(:user) {...
Test for registering with email already taken
diff --git a/lib/podio/models/stream_activity_group.rb b/lib/podio/models/stream_activity_group.rb index abc1234..def5678 100644 --- a/lib/podio/models/stream_activity_group.rb +++ b/lib/podio/models/stream_activity_group.rb @@ -1,6 +1,7 @@ # @see https://developers.podio.com/doc/stream class Podio::StreamActivityGrou...
Add method for getting group by data ref