diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -9,6 +9,13 @@ DAY = Time.utc(2010, 3, 1) WEDNESDAY = Time.utc(2010, 6, 23, 5, 0, 0) +WORLD_TIME_ZONES = [ + 'Pacific/Midway', # -1100 + 'America/Adak', # -1000 / -09...
Add helper for system environment TZ testing
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,3 +1,5 @@+require 'backports' + require 'dm-core/spec/setup' require 'dm-core/spec/lib/adapter_helpers'
Add backports to spec helper to allow specs to run under 1.8.7
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,27 +1,15 @@ require 'serverspec' -require 'net/ssh' - -include SpecInfra::Helper::DetectOS -include SpecInfra::Helper::Exec -include SpecInfra::Helper::Ssh if ENV['RAKE_ANS...
Update integration testing to work with Serverspec 2.N
diff --git a/lib/file_data/formats/exif/exif_data.rb b/lib/file_data/formats/exif/exif_data.rb index abc1234..def5678 100644 --- a/lib/file_data/formats/exif/exif_data.rb +++ b/lib/file_data/formats/exif/exif_data.rb @@ -16,6 +16,7 @@ end end + # Hash with convenience methods for accessing known Exif tag valu...
Clean up the if/else block in method_missing for ExifHash and add a class comment
diff --git a/lib/mongomodel/support/configuration.rb b/lib/mongomodel/support/configuration.rb index abc1234..def5678 100644 --- a/lib/mongomodel/support/configuration.rb +++ b/lib/mongomodel/support/configuration.rb @@ -4,7 +4,12 @@ module MongoModel class Configuration def initialize(options) - @options ...
Add support for connection string
diff --git a/lib/processor/metric_results_checker.rb b/lib/processor/metric_results_checker.rb index abc1234..def5678 100644 --- a/lib/processor/metric_results_checker.rb +++ b/lib/processor/metric_results_checker.rb @@ -1,22 +1,29 @@ module Processor class MetricResultsChecker < ProcessingStep protected + + ...
Fix metric checker adding defaults even if results existed
diff --git a/lib/puppet/provider/yumgroup/default.rb b/lib/puppet/provider/yumgroup/default.rb index abc1234..def5678 100644 --- a/lib/puppet/provider/yumgroup/default.rb +++ b/lib/puppet/provider/yumgroup/default.rb @@ -10,7 +10,7 @@ groups = [] # get list of all groups - yum_content = yum('grouplist') +...
Fix bug in yumgroup provider
diff --git a/db/migrate/20120506041011_create_radio_assignments.rb b/db/migrate/20120506041011_create_radio_assignments.rb index abc1234..def5678 100644 --- a/db/migrate/20120506041011_create_radio_assignments.rb +++ b/db/migrate/20120506041011_create_radio_assignments.rb @@ -3,6 +3,7 @@ create_table :radio_assignm...
Fix a migration that breaks a clean install
diff --git a/PathMenu.podspec b/PathMenu.podspec index abc1234..def5678 100644 --- a/PathMenu.podspec +++ b/PathMenu.podspec @@ -4,7 +4,7 @@ s.summary = "Path 4.2 menu using CoreAnimation in Swift." s.homepage = 'https://github.com/pixyzehn/PathMenu' s.license = { :type => 'MIT', :file => 'LICENSE' } - s.autho...
Update podspec for correct author
diff --git a/config/initializers/airbrake.rb b/config/initializers/airbrake.rb index abc1234..def5678 100644 --- a/config/initializers/airbrake.rb +++ b/config/initializers/airbrake.rb @@ -1,19 +1,23 @@-require 'airbrake/sidekiq/error_handler' +if ENV['AIRBRAKE_PROJECT_ID'].present? && ENV['AIRBRAKE_API_KEY'].present? ...
Allow apps to run without Airbrake
diff --git a/config/initializers/rummager.rb b/config/initializers/rummager.rb index abc1234..def5678 100644 --- a/config/initializers/rummager.rb +++ b/config/initializers/rummager.rb @@ -5,7 +5,12 @@ Whitehall.government_search_client = GdsApi::Rummager.new(Rummageable.rummager_host + Whitehall.government_search_in...
Connect to two Rummager endpoints We need to continue to access both 'whitehall-search' and 'search' Rummager instances until mainstream's Rummager is using Elastic Search, at which point we should be able to migrate to a single instance.
diff --git a/lib/troo.rb b/lib/troo.rb index abc1234..def5678 100644 --- a/lib/troo.rb +++ b/lib/troo.rb @@ -45,12 +45,11 @@ @kernel.exit(0) rescue Troo::InvalidAccessToken - @stderr.puts 'Your Trello access credentials have expired, ' \ - ' please renew and try again.' + @stder...
Reset stdin, stdout and stderr before exiting.
diff --git a/spec/ci/yarn_pnp_spec.rb b/spec/ci/yarn_pnp_spec.rb index abc1234..def5678 100644 --- a/spec/ci/yarn_pnp_spec.rb +++ b/spec/ci/yarn_pnp_spec.rb @@ -5,7 +5,7 @@ app = Hatchet::Runner.new( "spec/fixtures/repos/yarn-pnp-zero-install", config: { "NODE_MODLES_CACHE": "false" } - } + ) ...
Fix pnp spec syntax error
diff --git a/workers/command_runner.rb b/workers/command_runner.rb index abc1234..def5678 100644 --- a/workers/command_runner.rb +++ b/workers/command_runner.rb @@ -23,6 +23,7 @@ result = socket.gets("\n") logger.info "[CommandRunner] Result: #{result}" $redis.set("dda:#{command_id}", result) ...
Add closing the socket after received result
diff --git a/lib/ardes/response_for/bc.rb b/lib/ardes/response_for/bc.rb index abc1234..def5678 100644 --- a/lib/ardes/response_for/bc.rb +++ b/lib/ardes/response_for/bc.rb @@ -0,0 +1,16 @@+module Ardes + module ResponseFor + module Bc + def self.included(base) + base.class_eval do + alias_meth...
Add BC module with tmeplate_exists? stuff
diff --git a/lib/hotdog/commands/hosts.rb b/lib/hotdog/commands/hosts.rb index abc1234..def5678 100644 --- a/lib/hotdog/commands/hosts.rb +++ b/lib/hotdog/commands/hosts.rb @@ -7,11 +7,6 @@ if args.empty? result = execute("SELECT DISTINCT host_id FROM hosts_tags").to_a.reduce(:+) else - ...
Remove useless `IGNORE INTO` queries
diff --git a/lib/pxcbackup/remote_repo.rb b/lib/pxcbackup/remote_repo.rb index abc1234..def5678 100644 --- a/lib/pxcbackup/remote_repo.rb +++ b/lib/pxcbackup/remote_repo.rb @@ -35,7 +35,7 @@ def stream_command(backup) verify(backup) - "#{@which.s3cmd.shellescape} get #{backup.path.shellescape} -" + ...
Add workaround for broken s3cmd
diff --git a/lib/rubycritic/turbulence.rb b/lib/rubycritic/turbulence.rb index abc1234..def5678 100644 --- a/lib/rubycritic/turbulence.rb +++ b/lib/rubycritic/turbulence.rb @@ -13,9 +13,9 @@ def data @paths.zip(churn, complexity).map do |path_info| { - name: path_info[0], - x: path...
Use Ruby 1.8's hash syntax Consistency is important
diff --git a/lib/syoboi_calendar/agent.rb b/lib/syoboi_calendar/agent.rb index abc1234..def5678 100644 --- a/lib/syoboi_calendar/agent.rb +++ b/lib/syoboi_calendar/agent.rb @@ -1,3 +1,5 @@+require "uri" + module SyoboiCalendar module Agent extend self @@ -34,7 +36,7 @@ # change hash into URL query string...
Fix bug: encode uri query
diff --git a/app/models/feed.rb b/app/models/feed.rb index abc1234..def5678 100644 --- a/app/models/feed.rb +++ b/app/models/feed.rb @@ -10,7 +10,7 @@ def favicon url = URI.parse(self.url) - "#{url.scheme}://plus.google.com/_/favicon?domain=#{url.host}" + "#{url.scheme||"http"}://plus.google.com/_/favico...
Set default value in-case url can not be parsed
diff --git a/app/models/plot.rb b/app/models/plot.rb index abc1234..def5678 100644 --- a/app/models/plot.rb +++ b/app/models/plot.rb @@ -1,9 +1,9 @@ class Plot < ApplicationRecord validates :plot_id, presence: true - validates :latitude, presence: true, numericality: { greater_than: 0 } - validates :longitude, pre...
Undo validation changes, it broke too many tests and should be a different issue at this point
diff --git a/app/models/span.rb b/app/models/span.rb index abc1234..def5678 100644 --- a/app/models/span.rb +++ b/app/models/span.rb @@ -14,7 +14,7 @@ belongs_to :trace belongs_to :platform - has_many :traces, foreign_key: :origin_id, dependent: :destroy, inverse_of: :spans + has_many :traces, foreign_key: :or...
Fix wrong inverse_of resulting in wrongly preloaded data The wrong inverse_of resulted in the following issue when preloaded relations on spans: irb(main):005:0> t.spans.map(&:trace_id).uniq => [<UUID4:3b25610a-145c-49d6-bedf-b0e10b86b174>] irb(main):006:0> t.spans.includes(:traces).map(&:trace_id).uniq ...
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -8,6 +8,11 @@ has_many :questions has_many :answers has_many :likes + + has_attached_file :avatar, styles: { thumb: "100x100>" }, default_url: "/images/users/:id/:style/:bas...
Add validations to User model
diff --git a/test/helper.rb b/test/helper.rb index abc1234..def5678 100644 --- a/test/helper.rb +++ b/test/helper.rb @@ -5,20 +5,20 @@ require 'minitest/autorun' require 'usesthis' +require 'json' require 'little-fixtures' -require 'yaml' def test_configuration - Dimples::Configuration.new( - 'source_path' =...
Switch test_configuration to return a hash with symbols.
diff --git a/test/helper.rb b/test/helper.rb index abc1234..def5678 100644 --- a/test/helper.rb +++ b/test/helper.rb @@ -11,6 +11,9 @@ class Dbt::TestCase < Minitest::Test def setup + Dbt::Config.default_search_dirs = nil + Dbt::Config.default_no_create = nil + Dbt::Config.config_filename = nil end ...
Reset state at the start of the run
diff --git a/test/helper.rb b/test/helper.rb index abc1234..def5678 100644 --- a/test/helper.rb +++ b/test/helper.rb @@ -8,4 +8,5 @@ body.each { |line| arr << line } flunk "#{arr.inspect} != #{expected.inspect}" unless arr == expected + print "." end
Add a print for assert_response success.
diff --git a/test/helper.rb b/test/helper.rb index abc1234..def5678 100644 --- a/test/helper.rb +++ b/test/helper.rb @@ -16,7 +16,7 @@ @config ||= Dimples::Configuration.new( 'source_path' => File.join(__dir__, 'source'), 'destination_path' => site_destination, - 'categories' => [{ 'slug' => 'a', 'name' ...
Fix the category name configuration, change render_template to read_fixture.
diff --git a/lib/bigcommerce/resources/store/store_information.rb b/lib/bigcommerce/resources/store/store_information.rb index abc1234..def5678 100644 --- a/lib/bigcommerce/resources/store/store_information.rb +++ b/lib/bigcommerce/resources/store/store_information.rb @@ -7,28 +7,32 @@ include Bigcommerce::Request....
Add attributes to store information endpoint
diff --git a/lib/active_model/serializer/railtie.rb b/lib/active_model/serializer/railtie.rb index abc1234..def5678 100644 --- a/lib/active_model/serializer/railtie.rb +++ b/lib/active_model/serializer/railtie.rb @@ -1,10 +1,9 @@ module ActiveModel class Railtie < Rails::Railtie initializer 'generators' do |app...
Make sure generator hooks get run Use Rails::Engine#load_generators instead of require + Rails::Generators::configure!.
diff --git a/lib/acts_as_notifiable/notification.rb b/lib/acts_as_notifiable/notification.rb index abc1234..def5678 100644 --- a/lib/acts_as_notifiable/notification.rb +++ b/lib/acts_as_notifiable/notification.rb @@ -1,18 +1,31 @@ module ActsAsNotifiable - class Notification < ActiveRecord::Base - include ActsAsNot...
Use composition instead of inheritance for base ActsAsNotifiable::Notification
diff --git a/spec/elasticsearch/motd_product_spec.rb b/spec/elasticsearch/motd_product_spec.rb index abc1234..def5678 100644 --- a/spec/elasticsearch/motd_product_spec.rb +++ b/spec/elasticsearch/motd_product_spec.rb @@ -4,6 +4,6 @@ describe file('/etc/product') do it { should be_file } - it { should contain "Bas...
Update for latest version of serverspec
diff --git a/spec/features/admin/newsletters_spec.rb b/spec/features/admin/newsletters_spec.rb index abc1234..def5678 100644 --- a/spec/features/admin/newsletters_spec.rb +++ b/spec/features/admin/newsletters_spec.rb @@ -0,0 +1,22 @@+require 'rails_helper' + +feature 'Admin newsletters emails' do + + let(:download_but...
Add feature scenario for Newsletter admin section, including email zip download
diff --git a/spec/helpers/application_helper_spec.rb b/spec/helpers/application_helper_spec.rb index abc1234..def5678 100644 --- a/spec/helpers/application_helper_spec.rb +++ b/spec/helpers/application_helper_spec.rb @@ -0,0 +1,9 @@+require 'rails_helper' + +RSpec.describe ApplicationHelper do + describe 'markdown' do...
Test that markdown helper works
diff --git a/lib/vagrant-proxyconf/cap/linux/docker_proxy_conf.rb b/lib/vagrant-proxyconf/cap/linux/docker_proxy_conf.rb index abc1234..def5678 100644 --- a/lib/vagrant-proxyconf/cap/linux/docker_proxy_conf.rb +++ b/lib/vagrant-proxyconf/cap/linux/docker_proxy_conf.rb @@ -17,6 +17,21 @@ "/etc/sysconfig/#{...
Use the coreOS style configuration for systemd-based Ubuntu/Deb hosts.
diff --git a/spec/locotimezone/configuration_spec.rb b/spec/locotimezone/configuration_spec.rb index abc1234..def5678 100644 --- a/spec/locotimezone/configuration_spec.rb +++ b/spec/locotimezone/configuration_spec.rb @@ -0,0 +1,73 @@+require 'spec_helper' + +describe 'Configuring Locotimezone' do + let :default_attrib...
Convert configuration test to spec
diff --git a/Casks/order-of-twilight.rb b/Casks/order-of-twilight.rb index abc1234..def5678 100644 --- a/Casks/order-of-twilight.rb +++ b/Casks/order-of-twilight.rb @@ -0,0 +1,10 @@+class OrderOfTwilight < Cask + version :latest + sha256 :no_check + + url 'http://stabyourself.net/dl.php?file=orderoftwilight/orderoft...
Add Order of Twilight cask
diff --git a/Casks/you-need-a-budget.rb b/Casks/you-need-a-budget.rb index abc1234..def5678 100644 --- a/Casks/you-need-a-budget.rb +++ b/Casks/you-need-a-budget.rb @@ -0,0 +1,6 @@+class YouNeedABudget < Cask + url 'http://www.youneedabudget.com/CDNOrigin/download/ynab4/liveCaptive/Mac/YNAB4_LiveCaptive_4.1.553.dmg' +...
Add You Need A Budget
diff --git a/UPnAtom.podspec b/UPnAtom.podspec index abc1234..def5678 100644 --- a/UPnAtom.podspec +++ b/UPnAtom.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = 'UPnAtom' - s.version = '0.0.1.beta.2' + s.version = '0.0.1.beta.3' s.license = { :type => 'MIT', :file => 'LICENSE' } ...
Update cocoa pod version for release.
diff --git a/Casks/gog-galaxy.rb b/Casks/gog-galaxy.rb index abc1234..def5678 100644 --- a/Casks/gog-galaxy.rb +++ b/Casks/gog-galaxy.rb @@ -0,0 +1,15 @@+cask :v1 => 'gog-galaxy' do + version '1.0.0.836' + sha256 '878319173e0f157981fd3d5009e451653024bdb8e3b4f0ff5565c491ba815f4d' + + url "http://cdn.gog.com/open/gala...
Add GOG.com Galaxy Client v1.0.0.836 Fix trailing whitespace in GOG.com Galaxy Client Cask
diff --git a/Casks/opera-beta.rb b/Casks/opera-beta.rb index abc1234..def5678 100644 --- a/Casks/opera-beta.rb +++ b/Casks/opera-beta.rb @@ -1,6 +1,6 @@ cask :v1 => 'opera-beta' do - version '29.0.1795.35' - sha256 '0b6ee1cad2b335bd95c1c77c24e13fabad80419f430a91e10ea62a4574064cac' + version '29.0.1795.41' + sha256 ...
Upgrade Opera Beta.app to v29.0.1795.41
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -12,3 +12,4 @@ supports 'ubuntu' supports 'centos', '~> 6.0' +supports 'amazon'
Add support for Amazon Linux
diff --git a/DBCamera.podspec b/DBCamera.podspec index abc1234..def5678 100644 --- a/DBCamera.podspec +++ b/DBCamera.podspec @@ -9,7 +9,7 @@ s.platform = :ios, '6.0' s.requires_arc = true - s.dependency 'CLImageEditor/AllTools', '0.0.8' + s.dependency 'CLImageEditor/AllTools', '0.0.9' s.so...
Use new version of CLImageEditor Option to set black theme Signed-off-by: Ross Gallagher <43dae9a5c38ae5bc7931494ec65ea7b344ce97f5@rossgallagher.co.uk>
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -3,6 +3,6 @@ maintainer_email 'ops@simple.com' license 'Apache 2.0' description 'Installs RabbitMQ, an Erlang message queue application' -version '1.0.0' +version '1.1.0' ...
[1.1.0] Allow hashes as values/input to config parameters
diff --git a/lib/kafka/protocol/produce_response.rb b/lib/kafka/protocol/produce_response.rb index abc1234..def5678 100644 --- a/lib/kafka/protocol/produce_response.rb +++ b/lib/kafka/protocol/produce_response.rb @@ -45,7 +45,7 @@ partition: decoder.int32, error_code: decoder.int16, ...
Convert the timestamp to a Time object
diff --git a/spec/qb_integration/service/account_spec.rb b/spec/qb_integration/service/account_spec.rb index abc1234..def5678 100644 --- a/spec/qb_integration/service/account_spec.rb +++ b/spec/qb_integration/service/account_spec.rb @@ -12,7 +12,7 @@ account = subject.find_by_name "Inventory Asset" expec...
Use new quickbooks-ruby api for booleans
diff --git a/AppController.rb b/AppController.rb index abc1234..def5678 100644 --- a/AppController.rb +++ b/AppController.rb @@ -34,8 +34,18 @@ @webview_controller.load_url "http://127.0.0.1:3301/?q=#{search_field.stringValue.to_s}" end + def webViewFinishedLoading(aNotification) + @searchProgressIndicat...
Stop the progress indicator when the webview posts a "done loading" notification. git-svn-id: f20da03e3c54bdd0425edde46a83a0733af7cd3b@18 7a99d2f0-d533-0410-96fe-f25cb2755c1e
diff --git a/lib/swagger_docs_generator/metadata.rb b/lib/swagger_docs_generator/metadata.rb index abc1234..def5678 100644 --- a/lib/swagger_docs_generator/metadata.rb +++ b/lib/swagger_docs_generator/metadata.rb @@ -14,7 +14,7 @@ def construct_swagger_file hash = {} SwaggerDocsGenerator::Metadata.pro...
Test if element is empty
diff --git a/form_object_model.gemspec b/form_object_model.gemspec index abc1234..def5678 100644 --- a/form_object_model.gemspec +++ b/form_object_model.gemspec @@ -4,8 +4,8 @@ Gem::Specification.new do |gem| gem.authors = ["Sean Geoghegan", "Aaron Beckerman"] gem.email = ["sean@seangeo.me", "aaron@...
Fix typo in gem description and summary.
diff --git a/lib/outbrain/api/promoted_link_performance_report.rb b/lib/outbrain/api/promoted_link_performance_report.rb index abc1234..def5678 100644 --- a/lib/outbrain/api/promoted_link_performance_report.rb +++ b/lib/outbrain/api/promoted_link_performance_report.rb @@ -4,8 +4,8 @@ module Api class PromotedLin...
Fix path method for promoted links preformance report
diff --git a/Folklore.podspec b/Folklore.podspec index abc1234..def5678 100644 --- a/Folklore.podspec +++ b/Folklore.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = 'Folklore' - s.version = '0.3.0' + s.version = '0.4.0' s.license = 'MIT' s.summary = 'League of Legends chat service library for i...
Set the version number to 0.4.0.
diff --git a/Formula/exult.rb b/Formula/exult.rb index abc1234..def5678 100644 --- a/Formula/exult.rb +++ b/Formula/exult.rb @@ -1,32 +1,31 @@ require 'formula' -# TODO we shouldn't be installing .apps if there is an option +class Exult <Formula + head 'http://exult.svn.sourceforge.net/svnroot/exult/exult/trunk', + ...
Update Exult and use vorbis.
diff --git a/Formula/maven.rb b/Formula/maven.rb index abc1234..def5678 100644 --- a/Formula/maven.rb +++ b/Formula/maven.rb @@ -1,7 +1,7 @@ require 'formula' class Maven <Formula - @url='http://apache.mirrors.timporter.net/maven/binaries/apache-maven-2.2.1-bin.tar.gz' + @url='http://www.apache.org/dist/maven/bina...
Use the backup Apache mirrors instead of another mirror that might go down unnoticed. Signed-off-by: Adam Vandenberg <34c2b6407fd5a10249a15d699d40f9ed1782e98c@gmail.com>
diff --git a/stripe.gemspec b/stripe.gemspec index abc1234..def5678 100644 --- a/stripe.gemspec +++ b/stripe.gemspec @@ -24,5 +24,10 @@ lib/stripe.rb lib/stripe/version.rb lib/data/ca-certificates.crt + vendor/stripe-json/lib/json/pure.rb + vendor/stripe-json/lib/json/common.rb + vendor/stripe-js...
Add vendored JSON to gemspec
diff --git a/spec/requests/users_spec.rb b/spec/requests/users_spec.rb index abc1234..def5678 100644 --- a/spec/requests/users_spec.rb +++ b/spec/requests/users_spec.rb @@ -0,0 +1,12 @@+require 'spec_helper' + +feature 'Users' do + background do + 1.upto(100) {|i| User.create! :name => "user#{'%03d' % i}" } + end ...
Make sure that kaminari works inside a Grape app
diff --git a/test/assets_test.rb b/test/assets_test.rb index abc1234..def5678 100644 --- a/test/assets_test.rb +++ b/test/assets_test.rb @@ -0,0 +1,34 @@+require 'test_helper' +require 'coffee-rails' + +class AssetsTest < ActiveSupport::TestCase + def setup + require "rails" + require "action_controller/railtie"...
Add test for inclusion of coffee-script.js in asset pipeline
diff --git a/test/helper.rb b/test/helper.rb index abc1234..def5678 100644 --- a/test/helper.rb +++ b/test/helper.rb @@ -1,8 +1,8 @@ require 'bundler/setup' require 'test/unit' -$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib')) -$LOAD_PATH.unshift(File.dirname(__FILE__)) +$LOAD_PATH.unshift(File.joi...
Use `__dir__` instead of `File.dirname(__FILE__)`
diff --git a/test/helper.rb b/test/helper.rb index abc1234..def5678 100644 --- a/test/helper.rb +++ b/test/helper.rb @@ -15,7 +15,7 @@ def test_configuration @config ||= Dimples::Configuration.new( 'source_path' => File.join(__dir__, 'source'), - 'destination_path' => File.join('tmp', "dimples-#{Time.new.to_...
Switch back to using /tmp.
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -6,6 +6,23 @@ require 'knapsack_pro' # CUSTOM_CONFIG_GOES_HERE +KnapsackPro::Hooks::Queue.before_queue do |queue_id| + print '-'*20 + print 'Before Queue Hook - run before tes...
Add queue mode hooks to minitest test helper
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -2,6 +2,8 @@ require 'minitest/unit' require 'purdytest' require 'did_you_mean' + +puts "DidYouMean version: #{DidYouMean::VERSION}" module DidYouMean::TestHelper def asser...
Print out the version of did you mean to test against
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -21,3 +21,11 @@ end end end + +class ActionView::TestCase + teardown :clear_html_cache + + def clear_html_cache + AssetHat.html_cache = {} + end +end
Clear AssetHat.html_cache after every test
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -18,10 +18,8 @@ def self.should_serialize_to_wire_format(*expected_bytes) should "serialize to the byte string [#{expected_bytes.map { |b| sprintf("%02X", b) }.join(' ')}]...
Make sure the shoulda macro is checking the entire 'actual' array, not just the bytes that appear in the 'expected' value
diff --git a/tests/proxy_test.rb b/tests/proxy_test.rb index abc1234..def5678 100644 --- a/tests/proxy_test.rb +++ b/tests/proxy_test.rb @@ -24,13 +24,15 @@ timeout -= 1 end + response = nil + Net::HTTP.start('localhost', 8080) do |http| req = Net::HTTP::Get.new('/') req.basic_auth 'U...
[TEST] Fix test for the Nginx proxy failing on Elasticsearch 1.0
diff --git a/db/migrate/20151211135032_create_heartbeats.rb b/db/migrate/20151211135032_create_heartbeats.rb index abc1234..def5678 100644 --- a/db/migrate/20151211135032_create_heartbeats.rb +++ b/db/migrate/20151211135032_create_heartbeats.rb @@ -3,8 +3,7 @@ create_table :heartbeats do |t| t.integer :devic...
Remove updated_at column from heartbeats table
diff --git a/db/migrate/20160513160206_initial_migration.rb b/db/migrate/20160513160206_initial_migration.rb index abc1234..def5678 100644 --- a/db/migrate/20160513160206_initial_migration.rb +++ b/db/migrate/20160513160206_initial_migration.rb @@ -9,7 +9,7 @@ end create_table :tags do |t| - t.string :n...
Add index to tags table in InitialMigration
diff --git a/mrbgem.rake b/mrbgem.rake index abc1234..def5678 100644 --- a/mrbgem.rake +++ b/mrbgem.rake @@ -4,11 +4,7 @@ spec.add_test_dependency 'mruby-io', :mgem => 'mruby-io' def maxminddb_origin_path - if File.exist?("../test/fixtures/GeoLite2-City.mmdb.gz") - "#{build.build_dir}/../../../test/fixtu...
Use `dir` method intead to get fixture path.
diff --git a/Kickflip.podspec b/Kickflip.podspec index abc1234..def5678 100644 --- a/Kickflip.podspec +++ b/Kickflip.podspec @@ -10,7 +10,7 @@ s.platform = :ios, '7.0' s.source = { :git => "https://github.com/Kickflip/kickflip-ios-sdk.git", :tag => "0.9" } - s.source_files = 'Kickflip', 'Kickflip/**/...
Make sure to add all the source files
diff --git a/thinreports.gemspec b/thinreports.gemspec index abc1234..def5678 100644 --- a/thinreports.gemspec +++ b/thinreports.gemspec @@ -16,8 +16,10 @@ s.required_ruby_version = '>= 2.4.0' - s.files = `git ls-files`.split($\) - s.require_path = 'lib' + s.files = Dir.chdir(File.expand_path('..', __FILE__)) ...
Reduce size of the package file
diff --git a/spec/lib/rory/route_spec.rb b/spec/lib/rory/route_spec.rb index abc1234..def5678 100644 --- a/spec/lib/rory/route_spec.rb +++ b/spec/lib/rory/route_spec.rb @@ -5,4 +5,11 @@ expect(route.name).to eq 'pigeons_index' end end + + describe "#path_params" do + it "extracts params from path into...
Add a missing Route spec
diff --git a/spec/models/contact_spec.rb b/spec/models/contact_spec.rb index abc1234..def5678 100644 --- a/spec/models/contact_spec.rb +++ b/spec/models/contact_spec.rb @@ -0,0 +1,40 @@+require "spec_helper" + +describe Contact do + it "is valid with a firstname, lastname and email" do + contact = Contact.new( + ...
Write specs of Contact model
diff --git a/lib/brain.rb b/lib/brain.rb index abc1234..def5678 100644 --- a/lib/brain.rb +++ b/lib/brain.rb @@ -21,8 +21,11 @@ end response = http.request req json_response = JSON.parse(response.body, symbolize_names: true) - yield response, json_response if block_given? - return response, json_res...
Return yield result if block was given
diff --git a/puppet-lint-duplicate_class_parameters-check.gemspec b/puppet-lint-duplicate_class_parameters-check.gemspec index abc1234..def5678 100644 --- a/puppet-lint-duplicate_class_parameters-check.gemspec +++ b/puppet-lint-duplicate_class_parameters-check.gemspec @@ -22,7 +22,7 @@ spec.add_development_dependency...
Update rubocop requirement from ~> 0.83.0 to ~> 0.84.0 Updates the requirements on [rubocop](https://github.com/rubocop-hq/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop-hq/rubocop/releases) - [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md) - [Commits](h...
diff --git a/config/initializers/kaminari_config.rb b/config/initializers/kaminari_config.rb index abc1234..def5678 100644 --- a/config/initializers/kaminari_config.rb +++ b/config/initializers/kaminari_config.rb @@ -1,5 +1,5 @@ Kaminari.configure do |config| - config.default_per_page = 2 + config.default_per_page = ...
Change default per page to something sensible other than 2... lol
diff --git a/db/seeds/expense_types.rb b/db/seeds/expense_types.rb index abc1234..def5678 100644 --- a/db/seeds/expense_types.rb +++ b/db/seeds/expense_types.rb @@ -1,2 +1,14 @@-ExpenseType.find_or_create_by(name: 'Travel') -ExpenseType.find_or_create_by(name: 'Hotel') +[ + 'Conference and View - Car', + 'Conference ...
Set up default expense types
diff --git a/pages/spec/lib/pages_spec.rb b/pages/spec/lib/pages_spec.rb index abc1234..def5678 100644 --- a/pages/spec/lib/pages_spec.rb +++ b/pages/spec/lib/pages_spec.rb @@ -26,7 +26,32 @@ describe ".default_parts_for" do context "with no view template" do it "returns the default page parts" do -...
Implement failing tests that demonstrate the desired behaviour
diff --git a/spec/controllers/activity_streams/photos_controller_spec.rb b/spec/controllers/activity_streams/photos_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/activity_streams/photos_controller_spec.rb +++ b/spec/controllers/activity_streams/photos_controller_spec.rb @@ -0,0 +1,30 @@+requir...
Add in photoscontroller spec for as
diff --git a/homebrew/terraform-inventory.rb b/homebrew/terraform-inventory.rb index abc1234..def5678 100644 --- a/homebrew/terraform-inventory.rb +++ b/homebrew/terraform-inventory.rb @@ -3,8 +3,8 @@ head "https://github.com/adammck/terraform-inventory.git" # Update these when a new version is released - url "...
Update homebrew script to download version 0.5
diff --git a/app/models/web_hook.rb b/app/models/web_hook.rb index abc1234..def5678 100644 --- a/app/models/web_hook.rb +++ b/app/models/web_hook.rb @@ -9,7 +9,7 @@ validates :url, presence: true, format: { - with: /(^$)|(^(http|https):\/\/[a-z0-9]+([\-\.]{1}[a-z0-9]+)*\.[a-z]{2...
Use URI::regexp for validating WebHook urls
diff --git a/lib/active_merchant/billing/integrations/ipay88.rb b/lib/active_merchant/billing/integrations/ipay88.rb index abc1234..def5678 100644 --- a/lib/active_merchant/billing/integrations/ipay88.rb +++ b/lib/active_merchant/billing/integrations/ipay88.rb @@ -21,14 +21,14 @@ self.merch_key = key ...
Swap service_url and entry_url to play nice with ActiveMerchant's payment_service_for view helper
diff --git a/lib/active_support/cache/memcached_snappy_store.rb b/lib/active_support/cache/memcached_snappy_store.rb index abc1234..def5678 100644 --- a/lib/active_support/cache/memcached_snappy_store.rb +++ b/lib/active_support/cache/memcached_snappy_store.rb @@ -32,8 +32,6 @@ def deserialize_entry(compressed_va...
Remove no longer necessary rescue Snappy::Error.
diff --git a/guideline.gemspec b/guideline.gemspec index abc1234..def5678 100644 --- a/guideline.gemspec +++ b/guideline.gemspec @@ -7,10 +7,10 @@ gem.name = "guideline" gem.version = Guideline::VERSION gem.authors = ["Ryo NAKAMURA"] - gem.email = ["ryo-nakamura@cookpad.com"] - ge...
Write the detail of gemspec
diff --git a/lib/fog/hp/requests/compute_v2/list_servers.rb b/lib/fog/hp/requests/compute_v2/list_servers.rb index abc1234..def5678 100644 --- a/lib/fog/hp/requests/compute_v2/list_servers.rb +++ b/lib/fog/hp/requests/compute_v2/list_servers.rb @@ -4,6 +4,9 @@ class Real # List all servers (IDs and nam...
[hp|compute_v2] Add filter options to query for servers.
diff --git a/spec/features/fluentd/setting/out_stdout_spec.rb b/spec/features/fluentd/setting/out_stdout_spec.rb index abc1234..def5678 100644 --- a/spec/features/fluentd/setting/out_stdout_spec.rb +++ b/spec/features/fluentd/setting/out_stdout_spec.rb @@ -2,6 +2,6 @@ describe "out_stdout", stub: :daemon do before...
Use `pattern` instead of `match` Signed-off-by: Kenji Okimoto <7a4b90a0a1e6fc688adec907898b6822ce215e6c@clear-code.com>
diff --git a/cocoaseeds.gemspec b/cocoaseeds.gemspec index abc1234..def5678 100644 --- a/cocoaseeds.gemspec +++ b/cocoaseeds.gemspec @@ -23,7 +23,7 @@ s.executables = %w{ seed } s.require_paths = %w{ lib } - s.add_runtime_dependency "xcodeproj", "~> 1.0.0" + s.add_runtime_dependency "xcodeproj", ">= 0.28" ...
Make the version check more liberal
diff --git a/cookbooks/lib/features/mongodb_spec.rb b/cookbooks/lib/features/mongodb_spec.rb index abc1234..def5678 100644 --- a/cookbooks/lib/features/mongodb_spec.rb +++ b/cookbooks/lib/features/mongodb_spec.rb @@ -24,8 +24,9 @@ before :all do sh("sudo service #{mongodb_service_name} start") procwai...
Add even more sleepies to the mongo specs
diff --git a/core/app/mailers/spree/order_mailer.rb b/core/app/mailers/spree/order_mailer.rb index abc1234..def5678 100644 --- a/core/app/mailers/spree/order_mailer.rb +++ b/core/app/mailers/spree/order_mailer.rb @@ -1,26 +1,35 @@ module Spree class OrderMailer < BaseMailer def confirm_email(order, resend = fal...
Refactor order mailer for code reuse Conflicts: core/app/mailers/spree/order_mailer.rb
diff --git a/lib/bulk_processor/job.rb b/lib/bulk_processor/job.rb index abc1234..def5678 100644 --- a/lib/bulk_processor/job.rb +++ b/lib/bulk_processor/job.rb @@ -18,11 +18,9 @@ end end handler_class.complete(payload, successes, failures, nil) - rescue => error - handler_class.complete(p...
Simplify exception handling in Job
diff --git a/lib/cooperator/context.rb b/lib/cooperator/context.rb index abc1234..def5678 100644 --- a/lib/cooperator/context.rb +++ b/lib/cooperator/context.rb @@ -29,7 +29,7 @@ end def failure? - _failure + self[:_failure] end def include?(key)
Use new accessor for failure predicate
diff --git a/vendor/rspec_on_rails/lib/tasks/bootstrap_rspec.rake b/vendor/rspec_on_rails/lib/tasks/bootstrap_rspec.rake index abc1234..def5678 100644 --- a/vendor/rspec_on_rails/lib/tasks/bootstrap_rspec.rake +++ b/vendor/rspec_on_rails/lib/tasks/bootstrap_rspec.rake @@ -1,4 +1,8 @@-task :pre_commit => [:clobber_sqlit...
Make sure we load the rspec above, not the gem git-svn-id: f1a1267e29db6ed751edc5bdb54cf7d87c16124a@852 410327ef-2207-0410-a325-f78bbcb22a5a
diff --git a/lib/catarse_stripe/engine.rb b/lib/catarse_stripe/engine.rb index abc1234..def5678 100644 --- a/lib/catarse_stripe/engine.rb +++ b/lib/catarse_stripe/engine.rb @@ -7,13 +7,13 @@ class Mapper def mount_catarse_stripe_at(catarse_stripe) scope :payment do - get '/stripe/:id/review' => 'ca...
Change route to share application
diff --git a/lib/ettu/configuration.rb b/lib/ettu/configuration.rb index abc1234..def5678 100644 --- a/lib/ettu/configuration.rb +++ b/lib/ettu/configuration.rb @@ -45,7 +45,7 @@ class LateLoadAssets < LateLoad def defaults - Array.new(::ActionView::Base.assets_manifest.assets.keys) + ::Actio...
Fix recursion error in JRuby and RBX
diff --git a/lib/frecon/base/object.rb b/lib/frecon/base/object.rb index abc1234..def5678 100644 --- a/lib/frecon/base/object.rb +++ b/lib/frecon/base/object.rb @@ -8,5 +8,9 @@ # <http://opensource.org/licenses/MIT>. class Object + + # Alias #is_a? to #is_an?. This allows us to write more + # proper-English-y code. ...
Add a little bit of explanation for the Object class (and whitespace)
diff --git a/lib/ice_cube/null_i18n.rb b/lib/ice_cube/null_i18n.rb index abc1234..def5678 100644 --- a/lib/ice_cube/null_i18n.rb +++ b/lib/ice_cube/null_i18n.rb @@ -7,13 +7,19 @@ base = base[options[:count] == 1 ? "one" : "other"] if options[:count] - if base.is_a?(Hash) - return base.each_with_ob...
Use % string interpolation for translations Instead of traversing the string to replace multiple options, use built-in ruby methods to interpolate string templates in a single pass.
diff --git a/lib/iridium/dev_server.rb b/lib/iridium/dev_server.rb index abc1234..def5678 100644 --- a/lib/iridium/dev_server.rb +++ b/lib/iridium/dev_server.rb @@ -11,6 +11,8 @@ def app Rack::Builder.new do + use Middleware::RackLintCompatibility + Iridium.application.config.middleware.eac...
Use rack lint campat in dev
diff --git a/lib/factory_girl/strategy.rb b/lib/factory_girl/strategy.rb index abc1234..def5678 100644 --- a/lib/factory_girl/strategy.rb +++ b/lib/factory_girl/strategy.rb @@ -9,38 +9,6 @@ class Strategy #:nodoc: include Observable - # Generates an association using the current build strategy. - # - ...
Remove comment since the behavior it describes has been moved
diff --git a/rubicure_fuzzy_match.gemspec b/rubicure_fuzzy_match.gemspec index abc1234..def5678 100644 --- a/rubicure_fuzzy_match.gemspec +++ b/rubicure_fuzzy_match.gemspec @@ -22,7 +22,7 @@ spec.add_dependency "rubicure", "~> 0.4.7" spec.add_dependency "fuzzy_match", "~> 2.1.0" - spec.add_development_dependenc...
Upgrade bundler version to "~> 1.12"
diff --git a/db/data_migration/20130408135638_detailed_guidance_categories_for_defra.rb b/db/data_migration/20130408135638_detailed_guidance_categories_for_defra.rb index abc1234..def5678 100644 --- a/db/data_migration/20130408135638_detailed_guidance_categories_for_defra.rb +++ b/db/data_migration/20130408135638_detai...
Add detailed guidance categories for defra
diff --git a/db/migrate/20200730144201_remove_fk_constraints_for_asset_user_accesses.rb b/db/migrate/20200730144201_remove_fk_constraints_for_asset_user_accesses.rb index abc1234..def5678 100644 --- a/db/migrate/20200730144201_remove_fk_constraints_for_asset_user_accesses.rb +++ b/db/migrate/20200730144201_remove_fk_co...
Remove RA id FK constraint on asset_user_accesses Although we're not sure why, there are lots of asset_user_accesses with a cross-shard context and thus would have a cross-shard root account ID. flag=none closes INTEROP-6042 Test plan: - run migration and make sure you can set root_account_id to a global ID e.g. 1...
diff --git a/Casks/ccmenu.rb b/Casks/ccmenu.rb index abc1234..def5678 100644 --- a/Casks/ccmenu.rb +++ b/Casks/ccmenu.rb @@ -2,7 +2,7 @@ version '1.7' sha256 '974a2022dbc9494958334ee8f02e08df7ed184e1f421a53d623dfbeaadf08a2c' - url 'https://downloads.sourceforge.net/project/ccmenu/CCMenu/1.7/ccmenu-1.7-b.dmg' + ...
Update CCMenu: version number in url stanza Updated to [facilitate future updates][ref]. [ref]: https://github.com/caskroom/homebrew-cask/pull/4910
diff --git a/Casks/itrash.rb b/Casks/itrash.rb index abc1234..def5678 100644 --- a/Casks/itrash.rb +++ b/Casks/itrash.rb @@ -0,0 +1,24 @@+cask :v1 => 'itrash' do + + if MacOS.version <= :leopard + version '1.5.5' + sha256 'e45ba193c93e3ddf7ac439d035a82f0e9fde5630a308a490d456f0eef6277e6b' + + url "http://www.o...
Add iTrash.app v3.0.2 and versions for older OS X versions
diff --git a/Casks/tg-pro.rb b/Casks/tg-pro.rb index abc1234..def5678 100644 --- a/Casks/tg-pro.rb +++ b/Casks/tg-pro.rb @@ -1,6 +1,6 @@ cask :v1 => 'tg-pro' do - version '2.7.4' - sha256 '94df19f67316c900929542445d7d0b86a97c6605bb353b492b12306663d0cd58' + version '2.8' + sha256 '6fd5902c492b8ae5e547b69f68325e22489...
Update TG Pro.app to v2.8