html_url
stringlengths
51
51
comments
stringlengths
67
24.7k
title
stringlengths
6
280
body
stringlengths
51
36.2k
comment_length
int64
16
1.45k
text
stringlengths
190
38.3k
embeddings
list
https://github.com/huggingface/datasets/issues/1973
Thanks @ioana-blue for pointing out this problem (and thanks also @justin-yan). You are right that current implementation of the datasets caching files take too much memory. We are definitely changing this and optimizing the defaults, so that the file sizes are considerably reduced. I will come back to you as soon as t...
Question: what gets stored in the datasets cache and why is it so huge?
I'm running several training jobs (around 10) with a relatively large dataset (3M samples). The datasets cache reached 178G and it seems really large. What is it stored in there and why is it so large? I don't think I noticed this problem before and seems to be related to the new version of the datasets library. Any in...
55
Question: what gets stored in the datasets cache and why is it so huge? I'm running several training jobs (around 10) with a relatively large dataset (3M samples). The datasets cache reached 178G and it seems really large. What is it stored in there and why is it so large? I don't think I noticed this problem before ...
[ -0.083351269364357, 0.012125179171562195, -0.12917551398277283, 0.5186681747436523, 0.14931663870811462, 0.24268411099910736, -0.07578988373279572, 0.30196478962898254, -0.08773332834243774, -0.03593554347753525, -0.029559383168816566, -0.2534342408180237, -0.09368433058261871, -0.20080336...
https://github.com/huggingface/datasets/issues/1973
Thank you! Also I noticed that the files don't seem to be cleaned after the jobs finish. Last night I had only 3 jobs running, but the cache was still at 180GB.
Question: what gets stored in the datasets cache and why is it so huge?
I'm running several training jobs (around 10) with a relatively large dataset (3M samples). The datasets cache reached 178G and it seems really large. What is it stored in there and why is it so large? I don't think I noticed this problem before and seems to be related to the new version of the datasets library. Any in...
32
Question: what gets stored in the datasets cache and why is it so huge? I'm running several training jobs (around 10) with a relatively large dataset (3M samples). The datasets cache reached 178G and it seems really large. What is it stored in there and why is it so large? I don't think I noticed this problem before ...
[ -0.16135650873184204, 0.07331600785255432, -0.1333290934562683, 0.5806113481521606, 0.07841743528842926, 0.2742607295513153, -0.05600647255778313, 0.2457103431224823, -0.12449808418750763, -0.08306530117988586, -0.040894266217947006, -0.27977681159973145, -0.10303002595901489, -0.178574115...
https://github.com/huggingface/datasets/issues/1973
Hi ! As Albert said they can sometimes take more space that expected but we'll fix that soon. Also, to give more details about caching: computations on a dataset are cached by default so that you don't have to recompute them the next time you run them. So by default the cache files stay on your disk when you job ...
Question: what gets stored in the datasets cache and why is it so huge?
I'm running several training jobs (around 10) with a relatively large dataset (3M samples). The datasets cache reached 178G and it seems really large. What is it stored in there and why is it so large? I don't think I noticed this problem before and seems to be related to the new version of the datasets library. Any in...
95
Question: what gets stored in the datasets cache and why is it so huge? I'm running several training jobs (around 10) with a relatively large dataset (3M samples). The datasets cache reached 178G and it seems really large. What is it stored in there and why is it so large? I don't think I noticed this problem before ...
[ -0.06116240471601486, -0.03349564969539642, -0.12972283363342285, 0.5127941370010376, 0.11739452183246613, 0.24730423092842102, -0.01042349822819233, 0.24276427924633026, -0.07567548751831055, -0.03844780474901199, -0.05764545500278473, -0.28561240434646606, -0.06284116208553314, -0.138533...
https://github.com/huggingface/datasets/issues/1973
Hi @ioana-blue, we have optimized Datasets' disk usage in the latest release v1.5. Feel free to update your Datasets version ```shell pip install -U datasets ``` and see if it better suits your needs.
Question: what gets stored in the datasets cache and why is it so huge?
I'm running several training jobs (around 10) with a relatively large dataset (3M samples). The datasets cache reached 178G and it seems really large. What is it stored in there and why is it so large? I don't think I noticed this problem before and seems to be related to the new version of the datasets library. Any in...
34
Question: what gets stored in the datasets cache and why is it so huge? I'm running several training jobs (around 10) with a relatively large dataset (3M samples). The datasets cache reached 178G and it seems really large. What is it stored in there and why is it so large? I don't think I noticed this problem before ...
[ -0.12553682923316956, -0.03367792069911957, -0.14823266863822937, 0.5212607979774475, 0.1614958941936493, 0.24268440902233124, -0.0925321877002716, 0.2584301233291626, -0.08027980476617813, -0.022632092237472534, -0.0793154388666153, -0.19939672946929932, -0.08902513980865479, -0.193706363...
https://github.com/huggingface/datasets/issues/1965
Hi ! As far as I know not all faiss indexes can be computed in parallel and then merged. For example [here](https://github.com/facebookresearch/faiss/wiki/Special-operations-on-indexes#splitting-and-merging-indexes) is is mentioned that only IndexIVF indexes can be merged. Moreover faiss already works using multith...
Can we parallelized the add_faiss_index process over dataset shards ?
I am thinking of making the **add_faiss_index** process faster. What if we run the add_faiss_index process on separate dataset shards and then combine them before (dataset.concatenate) saving the faiss.index file ? I feel theoretically this will reduce the accuracy of retrieval since it affects the indexing process...
79
Can we parallelized the add_faiss_index process over dataset shards ? I am thinking of making the **add_faiss_index** process faster. What if we run the add_faiss_index process on separate dataset shards and then combine them before (dataset.concatenate) saving the faiss.index file ? I feel theoretically this wil...
[ -0.2789406478404999, -0.06273186951875687, -0.15734592080116272, 0.11061215400695801, -0.3771446943283081, 0.2478516399860382, 0.20978881418704987, 0.10627029836177826, 0.13710227608680725, 0.17192494869232178, -0.17660266160964966, -0.13538452982902527, 0.34148725867271423, 0.113996379077...
https://github.com/huggingface/datasets/issues/1965
Actually, you are right. I also had the same idea. I am trying this in the context of end-ton-end retrieval training in RAG. So far I have parallelized the embedding re-computation within the training loop by using datasets shards. Then I was thinking of can I calculate the indexes for each shard and combined them...
Can we parallelized the add_faiss_index process over dataset shards ?
I am thinking of making the **add_faiss_index** process faster. What if we run the add_faiss_index process on separate dataset shards and then combine them before (dataset.concatenate) saving the faiss.index file ? I feel theoretically this will reduce the accuracy of retrieval since it affects the indexing process...
60
Can we parallelized the add_faiss_index process over dataset shards ? I am thinking of making the **add_faiss_index** process faster. What if we run the add_faiss_index process on separate dataset shards and then combine them before (dataset.concatenate) saving the faiss.index file ? I feel theoretically this wil...
[ -0.2849659323692322, -0.16969680786132812, -0.09126099199056625, 0.16800282895565033, -0.3235112428665161, 0.3758886456489563, 0.33479973673820496, 0.06972001492977142, -0.03588647022843361, 0.1546953022480011, -0.08760654181241989, 0.06187278777360916, 0.3824174404144287, -0.0200757905840...
https://github.com/huggingface/datasets/issues/1965
@lhoestq As you mentioned faiss is already using multiprocessing. I tried to do the add_index with faiss for a dataset object inside a RAY actor and the process became very slow... if fact it takes so much time. It is because a ray actor comes with a single CPU core unless we assign it more. I also tried assigning mor...
Can we parallelized the add_faiss_index process over dataset shards ?
I am thinking of making the **add_faiss_index** process faster. What if we run the add_faiss_index process on separate dataset shards and then combine them before (dataset.concatenate) saving the faiss.index file ? I feel theoretically this will reduce the accuracy of retrieval since it affects the indexing process...
72
Can we parallelized the add_faiss_index process over dataset shards ? I am thinking of making the **add_faiss_index** process faster. What if we run the add_faiss_index process on separate dataset shards and then combine them before (dataset.concatenate) saving the faiss.index file ? I feel theoretically this wil...
[ -0.4054989814758301, -0.1552562415599823, -0.12579795718193054, 0.1830274760723114, -0.30512383580207825, 0.25111350417137146, 0.33917713165283203, 0.07270124554634094, 0.13479046523571014, 0.17686857283115387, -0.14357319474220276, 0.19608797132968903, 0.35047605633735657, 0.0879317745566...
https://github.com/huggingface/datasets/issues/1964
Hi ! To fix 1, an you try to run this code ? ```python from datasets import load_dataset load_dataset("squad", download_mode="force_redownload") ``` Maybe the file your downloaded was corrupted, in this case redownloading this way should fix your issue 1. Regarding your 2nd point, you're right that loading...
Datasets.py function load_dataset does not match squad dataset
### 1 When I try to train lxmert,and follow the code in README that --dataset name: ```shell python examples/question-answering/run_qa.py --model_name_or_path unc-nlp/lxmert-base-uncased --dataset_name squad --do_train --do_eval --per_device_train_batch_size 12 --learning_rate 3e-5 --num_train_epochs 2 --max_seq_len...
170
Datasets.py function load_dataset does not match squad dataset ### 1 When I try to train lxmert,and follow the code in README that --dataset name: ```shell python examples/question-answering/run_qa.py --model_name_or_path unc-nlp/lxmert-base-uncased --dataset_name squad --do_train --do_eval --per_device_train_batc...
[ -0.3537203371524811, 0.06250801682472229, 0.0333654023706913, 0.3963988423347473, 0.5554531216621399, 0.005721107125282288, 0.5457586050033569, 0.3404688835144043, -0.09830991178750992, -0.12162333726882935, -0.1650662124156952, 0.4508377015590668, 0.10841506719589233, -0.07741951197385788...
https://github.com/huggingface/datasets/issues/1964
Thks for quickly answering! ### 1 I try the first way,but seems not work ``` Traceback (most recent call last): File "examples/question-answering/run_qa.py", line 503, in <module> main() File "examples/question-answering/run_qa.py", line 218, in main datasets = load_dataset(data_args.dataset_name, d...
Datasets.py function load_dataset does not match squad dataset
### 1 When I try to train lxmert,and follow the code in README that --dataset name: ```shell python examples/question-answering/run_qa.py --model_name_or_path unc-nlp/lxmert-base-uncased --dataset_name squad --do_train --do_eval --per_device_train_batch_size 12 --learning_rate 3e-5 --num_train_epochs 2 --max_seq_len...
434
Datasets.py function load_dataset does not match squad dataset ### 1 When I try to train lxmert,and follow the code in README that --dataset name: ```shell python examples/question-answering/run_qa.py --model_name_or_path unc-nlp/lxmert-base-uncased --dataset_name squad --do_train --do_eval --per_device_train_batc...
[ -0.3537203371524811, 0.06250801682472229, 0.0333654023706913, 0.3963988423347473, 0.5554531216621399, 0.005721107125282288, 0.5457586050033569, 0.3404688835144043, -0.09830991178750992, -0.12162333726882935, -0.1650662124156952, 0.4508377015590668, 0.10841506719589233, -0.07741951197385788...
https://github.com/huggingface/datasets/issues/1964
## I have fixed it, @lhoestq ### the first section change as you said and add ["id"] ```python def process_squad(examples): """ Process a dataset in the squad format with columns "title" and "paragraphs" to return the dataset with columns "context", "question" and "answers". """ # print(exa...
Datasets.py function load_dataset does not match squad dataset
### 1 When I try to train lxmert,and follow the code in README that --dataset name: ```shell python examples/question-answering/run_qa.py --model_name_or_path unc-nlp/lxmert-base-uncased --dataset_name squad --do_train --do_eval --per_device_train_batch_size 12 --learning_rate 3e-5 --num_train_epochs 2 --max_seq_len...
569
Datasets.py function load_dataset does not match squad dataset ### 1 When I try to train lxmert,and follow the code in README that --dataset name: ```shell python examples/question-answering/run_qa.py --model_name_or_path unc-nlp/lxmert-base-uncased --dataset_name squad --do_train --do_eval --per_device_train_batc...
[ -0.3537203371524811, 0.06250801682472229, 0.0333654023706913, 0.3963988423347473, 0.5554531216621399, 0.005721107125282288, 0.5457586050033569, 0.3404688835144043, -0.09830991178750992, -0.12162333726882935, -0.1650662124156952, 0.4508377015590668, 0.10841506719589233, -0.07741951197385788...
https://github.com/huggingface/datasets/issues/1964
I'm glad you managed to fix run_qa.py for your case :) Regarding the checksum error, I'm not able to reproduce on my side. This errors says that the downloaded file doesn't match the expected file. Could you try running this and let me know if you get the same output as me ? ```python from datasets.utils.info_...
Datasets.py function load_dataset does not match squad dataset
### 1 When I try to train lxmert,and follow the code in README that --dataset name: ```shell python examples/question-answering/run_qa.py --model_name_or_path unc-nlp/lxmert-base-uncased --dataset_name squad --do_train --do_eval --per_device_train_batch_size 12 --learning_rate 3e-5 --num_train_epochs 2 --max_seq_len...
69
Datasets.py function load_dataset does not match squad dataset ### 1 When I try to train lxmert,and follow the code in README that --dataset name: ```shell python examples/question-answering/run_qa.py --model_name_or_path unc-nlp/lxmert-base-uncased --dataset_name squad --do_train --do_eval --per_device_train_batc...
[ -0.3537203371524811, 0.06250801682472229, 0.0333654023706913, 0.3963988423347473, 0.5554531216621399, 0.005721107125282288, 0.5457586050033569, 0.3404688835144043, -0.09830991178750992, -0.12162333726882935, -0.1650662124156952, 0.4508377015590668, 0.10841506719589233, -0.07741951197385788...
https://github.com/huggingface/datasets/issues/1964
I run the code,and it show below: ``` >>> from datasets.utils.info_utils import get_size_checksum_dict >>> from datasets import cached_path >>> get_size_checksum_dict(cached_path("https://rajpurkar.github.io/SQuAD-explorer/dataset/train-v1.1.json")) Downloading: 30.3MB [04:13, 120kB/s] {'num_bytes': 30288272, 'ch...
Datasets.py function load_dataset does not match squad dataset
### 1 When I try to train lxmert,and follow the code in README that --dataset name: ```shell python examples/question-answering/run_qa.py --model_name_or_path unc-nlp/lxmert-base-uncased --dataset_name squad --do_train --do_eval --per_device_train_batch_size 12 --learning_rate 3e-5 --num_train_epochs 2 --max_seq_len...
29
Datasets.py function load_dataset does not match squad dataset ### 1 When I try to train lxmert,and follow the code in README that --dataset name: ```shell python examples/question-answering/run_qa.py --model_name_or_path unc-nlp/lxmert-base-uncased --dataset_name squad --do_train --do_eval --per_device_train_batc...
[ -0.3537203371524811, 0.06250801682472229, 0.0333654023706913, 0.3963988423347473, 0.5554531216621399, 0.005721107125282288, 0.5457586050033569, 0.3404688835144043, -0.09830991178750992, -0.12162333726882935, -0.1650662124156952, 0.4508377015590668, 0.10841506719589233, -0.07741951197385788...
https://github.com/huggingface/datasets/issues/1964
Alright ! So in this case redownloading the file with `download_mode="force_redownload"` should fix it. Can you try using `download_mode="force_redownload"` again ? Not sure why it didn't work for you the first time though :/
Datasets.py function load_dataset does not match squad dataset
### 1 When I try to train lxmert,and follow the code in README that --dataset name: ```shell python examples/question-answering/run_qa.py --model_name_or_path unc-nlp/lxmert-base-uncased --dataset_name squad --do_train --do_eval --per_device_train_batch_size 12 --learning_rate 3e-5 --num_train_epochs 2 --max_seq_len...
34
Datasets.py function load_dataset does not match squad dataset ### 1 When I try to train lxmert,and follow the code in README that --dataset name: ```shell python examples/question-answering/run_qa.py --model_name_or_path unc-nlp/lxmert-base-uncased --dataset_name squad --do_train --do_eval --per_device_train_batc...
[ -0.3537203371524811, 0.06250801682472229, 0.0333654023706913, 0.3963988423347473, 0.5554531216621399, 0.005721107125282288, 0.5457586050033569, 0.3404688835144043, -0.09830991178750992, -0.12162333726882935, -0.1650662124156952, 0.4508377015590668, 0.10841506719589233, -0.07741951197385788...
https://github.com/huggingface/datasets/issues/1963
Hi ! The labels -1 correspond to the examples without gold labels in the original snli dataset. Feel free to remove these examples if you don't need them by using ```python data = data.filter(lambda x: x["label"] != -1) ```
bug in SNLI dataset
Hi There is label of -1 in train set of SNLI dataset, please find the code below: ``` import numpy as np import datasets data = datasets.load_dataset("snli")["train"] labels = [] for d in data: labels.append(d["label"]) print(np.unique(labels)) ``` and results: `[-1 0 1 2]` version of datas...
39
bug in SNLI dataset Hi There is label of -1 in train set of SNLI dataset, please find the code below: ``` import numpy as np import datasets data = datasets.load_dataset("snli")["train"] labels = [] for d in data: labels.append(d["label"]) print(np.unique(labels)) ``` and results: `[-1 0 1 ...
[ 0.17582231760025024, -0.28252556920051575, -0.10357320308685303, 0.34963300824165344, 0.22197790443897247, 0.04719807207584381, 0.38742125034332275, 0.11834355443716049, 0.08081860095262527, 0.2969245910644531, -0.20272843539714813, 0.6121096611022949, -0.14272040128707886, 0.0958903580904...
https://github.com/huggingface/datasets/issues/1959
Hi, try `skiprows` instead. This part is not properly documented in the docs it seems. @lhoestq I'll fix this as part of a bigger PR that fixes typos in the docs.
Bug in skip_rows argument of load_dataset function ?
Hello everyone, I'm quite new to Git so sorry in advance if I'm breaking some ground rules of issues posting... :/ I tried to use the load_dataset function, from Huggingface datasets library, on a csv file using the skip_rows argument described on Huggingface page to skip the first row containing column names `t...
31
Bug in skip_rows argument of load_dataset function ? Hello everyone, I'm quite new to Git so sorry in advance if I'm breaking some ground rules of issues posting... :/ I tried to use the load_dataset function, from Huggingface datasets library, on a csv file using the skip_rows argument described on Huggingface p...
[ 0.11845922470092773, -0.5157742500305176, -0.00026070326566696167, 0.13413408398628235, 0.2405337244272232, 0.31625938415527344, 0.39962196350097656, 0.11639025062322617, 0.1897607445716858, 0.27678850293159485, 0.35766708850860596, 0.31011396646499634, 0.05233965441584587, 0.1391008347272...
https://github.com/huggingface/datasets/issues/1956
You can pass the same `experiment_id` for all the metrics of the same group, and use another `experiment_id` for the other groups. Maybe we can add an environment variable that sets the default value for `experiment_id` ? What do you think ?
[distributed env] potentially unsafe parallel execution
``` metric = load_metric('glue', 'mrpc', num_process=num_process, process_id=rank) ``` presumes that there is only one set of parallel processes running - and will intermittently fail if you have multiple sets running as they will surely overwrite each other. Similar to https://github.com/huggingface/datasets/issu...
42
[distributed env] potentially unsafe parallel execution ``` metric = load_metric('glue', 'mrpc', num_process=num_process, process_id=rank) ``` presumes that there is only one set of parallel processes running - and will intermittently fail if you have multiple sets running as they will surely overwrite each othe...
[ -0.33885788917541504, -0.4435221552848816, -0.012153439223766327, 0.02591429091989994, -0.0003199847415089607, -0.11885195970535278, 0.41917434334754944, -0.022088225930929184, 0.6945430636405945, 0.33475685119628906, -0.07045724987983704, 0.25758615136146545, 0.020857609808444977, 0.09218...
https://github.com/huggingface/datasets/issues/1956
Ah, you're absolutely correct, @lhoestq - it's exactly the equivalent of the shared secret. Thank you!
[distributed env] potentially unsafe parallel execution
``` metric = load_metric('glue', 'mrpc', num_process=num_process, process_id=rank) ``` presumes that there is only one set of parallel processes running - and will intermittently fail if you have multiple sets running as they will surely overwrite each other. Similar to https://github.com/huggingface/datasets/issu...
16
[distributed env] potentially unsafe parallel execution ``` metric = load_metric('glue', 'mrpc', num_process=num_process, process_id=rank) ``` presumes that there is only one set of parallel processes running - and will intermittently fail if you have multiple sets running as they will surely overwrite each othe...
[ -0.2438625693321228, -0.5634173154830933, -0.025240328162908554, -0.07892368733882904, -0.08833131194114685, -0.046587489545345306, 0.4310416579246521, -0.09473548829555511, 0.6884130239486694, 0.338245153427124, -0.032446619123220444, 0.24160611629486084, 0.029499240219593048, 0.065107576...
https://github.com/huggingface/datasets/issues/1954
Hi not sure how change the lable after creation, but this is an issue not dataset request. thanks
add a new column
Hi I'd need to add a new column to the dataset, I was wondering how this can be done? thanks @lhoestq
18
add a new column Hi I'd need to add a new column to the dataset, I was wondering how this can be done? thanks @lhoestq Hi not sure how change the lable after creation, but this is an issue not dataset request. thanks
[ -0.23425175249576569, -0.05491122603416443, -0.1812906265258789, -0.052450791001319885, 0.016532830893993378, 0.03545776754617691, 0.33985984325408936, -0.03660150617361069, 0.07984986901283264, 0.14450690150260925, 0.010777730494737625, 0.19783428311347961, 0.03063609078526497, 0.37192064...
https://github.com/huggingface/datasets/issues/1954
Hi ! Currently you have to use `map` . You can see an example of how to do it in this comment: https://github.com/huggingface/datasets/issues/853#issuecomment-727872188 In the future we'll add support for a more native way of adding a new column ;)
add a new column
Hi I'd need to add a new column to the dataset, I was wondering how this can be done? thanks @lhoestq
40
add a new column Hi I'd need to add a new column to the dataset, I was wondering how this can be done? thanks @lhoestq Hi ! Currently you have to use `map` . You can see an example of how to do it in this comment: https://github.com/huggingface/datasets/issues/853#issuecomment-727872188 In the future we'll ...
[ -0.26750531792640686, -0.3267516493797302, -0.22937515377998352, -0.030696872621774673, 0.07127964496612549, 0.1932583898305893, 0.2296765148639679, 0.09861139953136444, 0.22823941707611084, 0.14503580331802368, -0.15576067566871643, 0.1634855419397354, 0.0027358699589967728, 0.51192307472...
https://github.com/huggingface/datasets/issues/1949
Hi @gchhablani :) Thanks for proposing your help ! I'll be doing a refactor of some parts related to filtering in the scope of https://github.com/huggingface/datasets/issues/1877 So I would first wait for this refactor to be done before working on the filtering. In particular because I plan to make things simpler ...
Enable Fast Filtering using Arrow Dataset
Hi @lhoestq, As mentioned in Issue #1796, I would love to work on enabling fast filtering/mapping. Can you please share the expectations? It would be great if you could point me to the relevant methods/files involved. Or the docs or maybe an overview of `arrow_dataset.py`. I only ask this because I am having trouble...
113
Enable Fast Filtering using Arrow Dataset Hi @lhoestq, As mentioned in Issue #1796, I would love to work on enabling fast filtering/mapping. Can you please share the expectations? It would be great if you could point me to the relevant methods/files involved. Or the docs or maybe an overview of `arrow_dataset.py`....
[ -0.060965437442064285, -0.2426416426897049, -0.17645573616027832, -0.05401565507054329, 0.03825158625841141, -0.23882737755775452, -0.10741263628005981, 0.20392486453056335, 0.22310425341129303, -0.1845400631427765, -0.28573060035705566, 0.4401741623878479, -0.1111106425523758, 0.381757497...
https://github.com/huggingface/datasets/issues/1949
Sure! I don't mind waiting. I'll check the refactor and try to understand what you're trying to do :)
Enable Fast Filtering using Arrow Dataset
Hi @lhoestq, As mentioned in Issue #1796, I would love to work on enabling fast filtering/mapping. Can you please share the expectations? It would be great if you could point me to the relevant methods/files involved. Or the docs or maybe an overview of `arrow_dataset.py`. I only ask this because I am having trouble...
19
Enable Fast Filtering using Arrow Dataset Hi @lhoestq, As mentioned in Issue #1796, I would love to work on enabling fast filtering/mapping. Can you please share the expectations? It would be great if you could point me to the relevant methods/files involved. Or the docs or maybe an overview of `arrow_dataset.py`....
[ -0.14752593636512756, -0.08898866176605225, -0.2098284214735031, -0.09189742803573608, 0.062438592314720154, -0.23314449191093445, -0.04701155051589012, 0.25649842619895935, 0.14091703295707703, -0.16528522968292236, -0.2117002308368683, 0.5572014451026917, -0.1610824465751648, 0.234077394...
https://github.com/huggingface/datasets/issues/1948
These warnings are showed when there's a call to `.map` to say to the user that a dataset is reloaded from the cache instead of being recomputed. They are warnings since we want to make sure the users know that it's not recomputed.
dataset loading logger level
on master I get this with `--dataset_name wmt16 --dataset_config ro-en`: ``` WARNING:datasets.arrow_dataset:Loading cached processed dataset at /home/stas/.cache/huggingface/datasets/wmt16/ro-en/1.0.0/9dc00622c30446e99c4c63d12a484ea4fb653f2f37c867d6edcec839d7eae50f/cache-2e01bead8cf42e26.arrow WARNING:datasets.arr...
43
dataset loading logger level on master I get this with `--dataset_name wmt16 --dataset_config ro-en`: ``` WARNING:datasets.arrow_dataset:Loading cached processed dataset at /home/stas/.cache/huggingface/datasets/wmt16/ro-en/1.0.0/9dc00622c30446e99c4c63d12a484ea4fb653f2f37c867d6edcec839d7eae50f/cache-2e01bead8cf42...
[ -0.1510903537273407, -0.36360716819763184, -0.017067182809114456, 0.3475189805030823, 0.40035152435302734, 0.4622993767261505, 0.4706435203552246, 0.14328472316265106, 0.25232356786727905, -0.004766695201396942, 0.02437867969274521, -0.016878560185432434, -0.24817007780075073, -0.197533100...
https://github.com/huggingface/datasets/issues/1948
Thank you for explaining the intention, @lhoestq 1. Could it be then made more human-friendly? Currently the hex gibberish tells me nothing of what's really going on. e.g. the following is instructive, IMHO: ``` WARNING: wmt16/ro-en/train dataset was loaded from cache instead of being recomputed WARNING: wmt16...
dataset loading logger level
on master I get this with `--dataset_name wmt16 --dataset_config ro-en`: ``` WARNING:datasets.arrow_dataset:Loading cached processed dataset at /home/stas/.cache/huggingface/datasets/wmt16/ro-en/1.0.0/9dc00622c30446e99c4c63d12a484ea4fb653f2f37c867d6edcec839d7eae50f/cache-2e01bead8cf42e26.arrow WARNING:datasets.arr...
351
dataset loading logger level on master I get this with `--dataset_name wmt16 --dataset_config ro-en`: ``` WARNING:datasets.arrow_dataset:Loading cached processed dataset at /home/stas/.cache/huggingface/datasets/wmt16/ro-en/1.0.0/9dc00622c30446e99c4c63d12a484ea4fb653f2f37c867d6edcec839d7eae50f/cache-2e01bead8cf42...
[ -0.1465868055820465, -0.20244276523590088, 0.012918993830680847, 0.31020987033843994, 0.4003244936466217, 0.3999481201171875, 0.49052000045776367, 0.23117125034332275, 0.12436021864414215, 0.028232943266630173, 0.009334634989500046, -0.14726310968399048, -0.24832086265087128, -0.1882983148...
https://github.com/huggingface/datasets/issues/1948
Hey, any news about the issue? So many warnings when I'm really ok with the dataset not being recomputed :)
dataset loading logger level
on master I get this with `--dataset_name wmt16 --dataset_config ro-en`: ``` WARNING:datasets.arrow_dataset:Loading cached processed dataset at /home/stas/.cache/huggingface/datasets/wmt16/ro-en/1.0.0/9dc00622c30446e99c4c63d12a484ea4fb653f2f37c867d6edcec839d7eae50f/cache-2e01bead8cf42e26.arrow WARNING:datasets.arr...
20
dataset loading logger level on master I get this with `--dataset_name wmt16 --dataset_config ro-en`: ``` WARNING:datasets.arrow_dataset:Loading cached processed dataset at /home/stas/.cache/huggingface/datasets/wmt16/ro-en/1.0.0/9dc00622c30446e99c4c63d12a484ea4fb653f2f37c867d6edcec839d7eae50f/cache-2e01bead8cf42...
[ -0.20182105898857117, -0.2147749662399292, -0.01915048062801361, 0.4123525619506836, 0.4625154733657837, 0.41485950350761414, 0.46870338916778564, 0.12743055820465088, 0.12400504946708679, -0.009558700025081635, 0.01883823424577713, -0.08164338767528534, -0.26261836290359497, -0.1146502718...
https://github.com/huggingface/datasets/issues/1942
Hi ! The cache at `~/.cache/huggingface/metrics` stores the users data for metrics computations (hence the arrow files). However python modules (i.e. dataset scripts, metric scripts) are stored in `~/.cache/huggingface/modules/datasets_modules`. In particular the metrics are cached in `~/.cache/huggingface/mod...
[experiment] missing default_experiment-1-0.arrow
the original report was pretty bad and incomplete - my apologies! Please see the complete version here: https://github.com/huggingface/datasets/issues/1942#issuecomment-786336481 ------------ As mentioned here https://github.com/huggingface/datasets/issues/1939 metrics don't get cached, looking at my local `~/...
84
[experiment] missing default_experiment-1-0.arrow the original report was pretty bad and incomplete - my apologies! Please see the complete version here: https://github.com/huggingface/datasets/issues/1942#issuecomment-786336481 ------------ As mentioned here https://github.com/huggingface/datasets/issues/19...
[ -0.035873740911483765, -0.0009468942880630493, 0.07417140156030655, 0.11846079677343369, 0.08373984694480896, -0.10975294560194016, 0.1720350682735443, 0.23171842098236084, 0.26387184858322144, 0.1391705572605133, 0.06787896156311035, 0.17331816256046295, -0.28547459840774536, -0.012177981...
https://github.com/huggingface/datasets/issues/1942
Thank you for clarifying that the metrics files are to be found elsewhere, @lhoestq > The cache at ~/.cache/huggingface/metrics stores the users data for metrics computations (hence the arrow files). could it be renamed to reflect that? otherwise it misleadingly suggests that it's the metrics. Perhaps `~/.cache/...
[experiment] missing default_experiment-1-0.arrow
the original report was pretty bad and incomplete - my apologies! Please see the complete version here: https://github.com/huggingface/datasets/issues/1942#issuecomment-786336481 ------------ As mentioned here https://github.com/huggingface/datasets/issues/1939 metrics don't get cached, looking at my local `~/...
93
[experiment] missing default_experiment-1-0.arrow the original report was pretty bad and incomplete - my apologies! Please see the complete version here: https://github.com/huggingface/datasets/issues/1942#issuecomment-786336481 ------------ As mentioned here https://github.com/huggingface/datasets/issues/19...
[ 0.24744877219200134, 0.05092683434486389, 0.054808519780635834, 0.21402336657047272, 0.11529041826725006, 0.18768949806690216, 0.22765082120895386, 0.33815863728523254, 0.24619963765144348, 0.10040487349033356, 0.16332606971263885, 0.12003037333488464, -0.3513065278530121, -0.1723560988903...
https://github.com/huggingface/datasets/issues/1942
The lock files come from an issue with filelock (see comment in the code [here](https://github.com/benediktschmitt/py-filelock/blob/master/filelock.py#L394-L398)). Basically on unix there're always .lock files left behind. I haven't dove into this issue
[experiment] missing default_experiment-1-0.arrow
the original report was pretty bad and incomplete - my apologies! Please see the complete version here: https://github.com/huggingface/datasets/issues/1942#issuecomment-786336481 ------------ As mentioned here https://github.com/huggingface/datasets/issues/1939 metrics don't get cached, looking at my local `~/...
30
[experiment] missing default_experiment-1-0.arrow the original report was pretty bad and incomplete - my apologies! Please see the complete version here: https://github.com/huggingface/datasets/issues/1942#issuecomment-786336481 ------------ As mentioned here https://github.com/huggingface/datasets/issues/19...
[ 0.09786514937877655, 0.0017493367195129395, 0.1070125550031662, 0.1418972611427307, -0.0015060333535075188, 0.035928577184677124, 0.24486035108566284, 0.2713266909122467, 0.20910906791687012, 0.12138563394546509, 0.16886939108371735, 0.13612022995948792, -0.3981265723705292, -0.04132807627...
https://github.com/huggingface/datasets/issues/1942
are you sure you need an external lock file? if it's a single purpose locking in the same scope you can lock the caller `__file__` instead, e.g. here is how one can `flock` the script file itself to ensure atomic printing: ``` import fcntl def printflock(*msgs): """ print in multiprocess env so that the outpu...
[experiment] missing default_experiment-1-0.arrow
the original report was pretty bad and incomplete - my apologies! Please see the complete version here: https://github.com/huggingface/datasets/issues/1942#issuecomment-786336481 ------------ As mentioned here https://github.com/huggingface/datasets/issues/1939 metrics don't get cached, looking at my local `~/...
75
[experiment] missing default_experiment-1-0.arrow the original report was pretty bad and incomplete - my apologies! Please see the complete version here: https://github.com/huggingface/datasets/issues/1942#issuecomment-786336481 ------------ As mentioned here https://github.com/huggingface/datasets/issues/19...
[ -0.0958080068230629, -0.09423503279685974, 0.12555718421936035, 0.09274052828550339, -0.08685502409934998, -0.02963242679834366, 0.23172231018543243, 0.23752246797084808, 0.23480701446533203, 0.1782364398241043, 0.0034627914428710938, 0.1474098563194275, -0.23789221048355103, -0.0178871750...
https://github.com/huggingface/datasets/issues/1942
OK, this issue is not about caching but some internal conflict/race condition it seems, I have just run into it on my normal env: ``` Traceback (most recent call last): File "/mnt/nvme1/code/huggingface/datasets-master/src/datasets/metric.py", line 356, in _finalize self.data = Dataset(**reader.read_files([...
[experiment] missing default_experiment-1-0.arrow
the original report was pretty bad and incomplete - my apologies! Please see the complete version here: https://github.com/huggingface/datasets/issues/1942#issuecomment-786336481 ------------ As mentioned here https://github.com/huggingface/datasets/issues/1939 metrics don't get cached, looking at my local `~/...
409
[experiment] missing default_experiment-1-0.arrow the original report was pretty bad and incomplete - my apologies! Please see the complete version here: https://github.com/huggingface/datasets/issues/1942#issuecomment-786336481 ------------ As mentioned here https://github.com/huggingface/datasets/issues/19...
[ -0.05769076198339462, -0.002504408359527588, 0.10634616017341614, 0.3295958936214447, -0.073061004281044, 0.029177948832511902, 0.14746293425559998, 0.24182790517807007, 0.30566680431365967, 0.15990355610847473, 0.2047881782054901, 0.07196033000946045, -0.3148394525051117, -0.1378428041934...
https://github.com/huggingface/datasets/issues/1942
When you're using metrics in a distributed setup, there are two cases: 1. you're doing two completely different experiments (two evaluations) and the 2 metrics jobs have nothing to do with each other 2. you're doing one experiment (one evaluation) but use multiple processes to feed the data to the metric. In case ...
[experiment] missing default_experiment-1-0.arrow
the original report was pretty bad and incomplete - my apologies! Please see the complete version here: https://github.com/huggingface/datasets/issues/1942#issuecomment-786336481 ------------ As mentioned here https://github.com/huggingface/datasets/issues/1939 metrics don't get cached, looking at my local `~/...
173
[experiment] missing default_experiment-1-0.arrow the original report was pretty bad and incomplete - my apologies! Please see the complete version here: https://github.com/huggingface/datasets/issues/1942#issuecomment-786336481 ------------ As mentioned here https://github.com/huggingface/datasets/issues/19...
[ -0.05989833176136017, 0.006814852356910706, 0.08448436111211777, 0.1580616533756256, 0.01994118094444275, -0.03207594156265259, 0.2774339020252228, 0.22076499462127686, 0.3088779151439667, 0.16024130582809448, 0.01775214821100235, 0.10314176231622696, -0.22572368383407593, -0.0206122361123...
https://github.com/huggingface/datasets/issues/1942
Thank you for explaining that in a great way, @lhoestq So the bottom line is that the `transformers` examples are broken since they don't do any of that. At least `run_seq2seq.py` just does `metric = load_metric(metric_name)` What test would you recommend to reliably reproduce this bug in `examples/seq2seq/run_s...
[experiment] missing default_experiment-1-0.arrow
the original report was pretty bad and incomplete - my apologies! Please see the complete version here: https://github.com/huggingface/datasets/issues/1942#issuecomment-786336481 ------------ As mentioned here https://github.com/huggingface/datasets/issues/1939 metrics don't get cached, looking at my local `~/...
48
[experiment] missing default_experiment-1-0.arrow the original report was pretty bad and incomplete - my apologies! Please see the complete version here: https://github.com/huggingface/datasets/issues/1942#issuecomment-786336481 ------------ As mentioned here https://github.com/huggingface/datasets/issues/19...
[ 0.07509259134531021, -0.15114611387252808, 0.15680891275405884, 0.18094371259212494, -0.0645124688744545, -0.012127801775932312, 0.3743317723274231, 0.2074543833732605, 0.20335929095745087, 0.06371428817510605, 0.23238079249858856, 0.10928809642791748, -0.3682083785533905, -0.2463027238845...
https://github.com/huggingface/datasets/issues/1942
To give more context, we are just using the metrics for the `comput_metric` function and nothing else. Is there something else we can use that just applies the function to the full arrays of predictions and labels? Because that's all we need, all the gathering has already been done because the datasets Metric multiproc...
[experiment] missing default_experiment-1-0.arrow
the original report was pretty bad and incomplete - my apologies! Please see the complete version here: https://github.com/huggingface/datasets/issues/1942#issuecomment-786336481 ------------ As mentioned here https://github.com/huggingface/datasets/issues/1939 metrics don't get cached, looking at my local `~/...
85
[experiment] missing default_experiment-1-0.arrow the original report was pretty bad and incomplete - my apologies! Please see the complete version here: https://github.com/huggingface/datasets/issues/1942#issuecomment-786336481 ------------ As mentioned here https://github.com/huggingface/datasets/issues/19...
[ 0.036068111658096313, 0.03790454566478729, 0.09435877203941345, 0.12535876035690308, 0.17602407932281494, 0.05072297155857086, 0.18199415504932404, 0.25301533937454224, 0.20254598557949066, 0.2519219219684601, 0.0820867121219635, 0.18000075221061707, -0.37511253356933594, 0.066590324044227...
https://github.com/huggingface/datasets/issues/1942
OK, it definitely leads to a race condition in how it's used right now. Here is how you can reproduce it - by injecting a random sleep time different for each process before the locks are acquired. ``` --- a/src/datasets/metric.py +++ b/src/datasets/metric.py @@ -348,6 +348,16 @@ class Metric(MetricInfoMixin): ...
[experiment] missing default_experiment-1-0.arrow
the original report was pretty bad and incomplete - my apologies! Please see the complete version here: https://github.com/huggingface/datasets/issues/1942#issuecomment-786336481 ------------ As mentioned here https://github.com/huggingface/datasets/issues/1939 metrics don't get cached, looking at my local `~/...
452
[experiment] missing default_experiment-1-0.arrow the original report was pretty bad and incomplete - my apologies! Please see the complete version here: https://github.com/huggingface/datasets/issues/1942#issuecomment-786336481 ------------ As mentioned here https://github.com/huggingface/datasets/issues/19...
[ -0.08441560715436935, -0.06571947038173676, 0.06521785259246826, 0.27223727107048035, -0.08708636462688446, -0.03266456723213196, 0.1643523871898651, 0.26979658007621765, 0.3311938941478729, 0.08320550620555878, 0.09826107323169708, 0.19418516755104065, -0.358064740896225, -0.0889754444360...
https://github.com/huggingface/datasets/issues/1942
I tried to adjust `run_seq2seq.py` and trainer to use the suggested dist env: ``` import torch.distributed as dist metric = load_metric(metric_name, num_process=dist.get_world_size(), process_id=dist.get_rank()) ``` and in `trainer.py` added to call just for rank 0: ``` if self.is_world_process_z...
[experiment] missing default_experiment-1-0.arrow
the original report was pretty bad and incomplete - my apologies! Please see the complete version here: https://github.com/huggingface/datasets/issues/1942#issuecomment-786336481 ------------ As mentioned here https://github.com/huggingface/datasets/issues/1939 metrics don't get cached, looking at my local `~/...
302
[experiment] missing default_experiment-1-0.arrow the original report was pretty bad and incomplete - my apologies! Please see the complete version here: https://github.com/huggingface/datasets/issues/1942#issuecomment-786336481 ------------ As mentioned here https://github.com/huggingface/datasets/issues/19...
[ 0.08813989162445068, -0.10928656905889511, 0.11583006381988525, 0.28568312525749207, 0.08457314968109131, 0.08065587282180786, 0.23499712347984314, 0.23771563172340393, 0.23479096591472626, 0.2356439232826233, 0.07886265963315964, 0.1667121797800064, -0.37396055459976196, -0.22426535189151...
https://github.com/huggingface/datasets/issues/1942
But no, since ` metric = load_metric(metric_name) ` is called for each process, the race condition is still there. So still getting: ``` ValueError: Error in finalize: another metric instance is already using the local cache file. Please specify an experiment_id to avoid colision between distributed metric in...
[experiment] missing default_experiment-1-0.arrow
the original report was pretty bad and incomplete - my apologies! Please see the complete version here: https://github.com/huggingface/datasets/issues/1942#issuecomment-786336481 ------------ As mentioned here https://github.com/huggingface/datasets/issues/1939 metrics don't get cached, looking at my local `~/...
76
[experiment] missing default_experiment-1-0.arrow the original report was pretty bad and incomplete - my apologies! Please see the complete version here: https://github.com/huggingface/datasets/issues/1942#issuecomment-786336481 ------------ As mentioned here https://github.com/huggingface/datasets/issues/19...
[ -0.07438235729932785, 0.018933147192001343, 0.09862568974494934, 0.2385595738887787, 0.0015655439347028732, 0.02108946442604065, 0.1744566708803177, 0.29972144961357117, 0.36625856161117554, 0.12155461311340332, 0.02722800523042679, 0.1309891641139984, -0.31445831060409546, -0.013783730566...
https://github.com/huggingface/datasets/issues/1942
OK, here is a workaround that works. The onus here is absolutely on the user: ``` diff --git a/examples/seq2seq/run_seq2seq.py b/examples/seq2seq/run_seq2seq.py index 2a060dac5..c82fd83ea 100755 --- a/examples/seq2seq/run_seq2seq.py +++ b/examples/seq2seq/run_seq2seq.py @@ -520,7 +520,11 @@ def main(): ...
[experiment] missing default_experiment-1-0.arrow
the original report was pretty bad and incomplete - my apologies! Please see the complete version here: https://github.com/huggingface/datasets/issues/1942#issuecomment-786336481 ------------ As mentioned here https://github.com/huggingface/datasets/issues/1939 metrics don't get cached, looking at my local `~/...
233
[experiment] missing default_experiment-1-0.arrow the original report was pretty bad and incomplete - my apologies! Please see the complete version here: https://github.com/huggingface/datasets/issues/1942#issuecomment-786336481 ------------ As mentioned here https://github.com/huggingface/datasets/issues/19...
[ -0.06407048553228378, -0.07876445353031158, 0.0965641587972641, 0.25347909331321716, -0.005687774159014225, -0.02128676325082779, 0.3123219609260559, 0.263801634311676, 0.2110244631767273, 0.2581808567047119, 0.045173682272434235, 0.36246827244758606, -0.35260722041130066, -0.1786395758390...
https://github.com/huggingface/datasets/issues/1942
I don't see how this could be the responsibility of `Trainer`, who hasn't the faintest idea of what a `datasets.Metric` is. The trainer takes a function `compute_metrics` that goes from predictions + labels to metric results, there is nothing there. That computation is done on all processes The fact a `datasets.Me...
[experiment] missing default_experiment-1-0.arrow
the original report was pretty bad and incomplete - my apologies! Please see the complete version here: https://github.com/huggingface/datasets/issues/1942#issuecomment-786336481 ------------ As mentioned here https://github.com/huggingface/datasets/issues/1939 metrics don't get cached, looking at my local `~/...
144
[experiment] missing default_experiment-1-0.arrow the original report was pretty bad and incomplete - my apologies! Please see the complete version here: https://github.com/huggingface/datasets/issues/1942#issuecomment-786336481 ------------ As mentioned here https://github.com/huggingface/datasets/issues/19...
[ -0.09867683053016663, 0.08746449649333954, 0.0754723846912384, 0.12414443492889404, 0.14742745459079742, -0.07018423080444336, 0.35259363055229187, 0.23563410341739655, 0.1611238420009613, 0.2098139375448227, 0.00042147934436798096, 0.21405579149723053, -0.34553542733192444, 0.193588808178...
https://github.com/huggingface/datasets/issues/1942
Right, to clarify, I meant it'd be good to have it sorted on the library side and not requiring the user to figure it out. This is too complex and error-prone and if not coded correctly the bug will be intermittent which is even worse. Oh I guess I wasn't clear in my message - in no way I'm proposing that we use thi...
[experiment] missing default_experiment-1-0.arrow
the original report was pretty bad and incomplete - my apologies! Please see the complete version here: https://github.com/huggingface/datasets/issues/1942#issuecomment-786336481 ------------ As mentioned here https://github.com/huggingface/datasets/issues/1939 metrics don't get cached, looking at my local `~/...
139
[experiment] missing default_experiment-1-0.arrow the original report was pretty bad and incomplete - my apologies! Please see the complete version here: https://github.com/huggingface/datasets/issues/1942#issuecomment-786336481 ------------ As mentioned here https://github.com/huggingface/datasets/issues/19...
[ 0.0017204061150550842, 0.048333555459976196, 0.07416580617427826, 0.05186332389712334, 0.003217451274394989, -0.08906735479831696, 0.27334892749786377, 0.3028242588043213, 0.2559511661529541, 0.15783792734146118, 0.09535101801156998, 0.18284198641777039, -0.3078092634677887, 0.119295746088...
https://github.com/huggingface/datasets/issues/1942
> The fact a datasets.Metric object cannot be used as a simple compute function in a multi-process environment is, in my opinion, a bug in datasets Yes totally, this use case is supposed to be supported by `datasets`. And in this case there shouldn't be any collision between the metrics. I'm looking into it :) My g...
[experiment] missing default_experiment-1-0.arrow
the original report was pretty bad and incomplete - my apologies! Please see the complete version here: https://github.com/huggingface/datasets/issues/1942#issuecomment-786336481 ------------ As mentioned here https://github.com/huggingface/datasets/issues/1939 metrics don't get cached, looking at my local `~/...
85
[experiment] missing default_experiment-1-0.arrow the original report was pretty bad and incomplete - my apologies! Please see the complete version here: https://github.com/huggingface/datasets/issues/1942#issuecomment-786336481 ------------ As mentioned here https://github.com/huggingface/datasets/issues/19...
[ -0.13352280855178833, 0.03711962699890137, 0.09259753674268723, 0.216525137424469, 0.11556136608123779, 0.0259055495262146, 0.289228230714798, 0.2465747594833374, 0.24306681752204895, 0.14857986569404602, 0.022333383560180664, 0.1771804541349411, -0.23990541696548462, 0.11342409998178482, ...
https://github.com/huggingface/datasets/issues/1942
I just opened #1966 to fix this :) @stas00 if have a chance feel free to try it !
[experiment] missing default_experiment-1-0.arrow
the original report was pretty bad and incomplete - my apologies! Please see the complete version here: https://github.com/huggingface/datasets/issues/1942#issuecomment-786336481 ------------ As mentioned here https://github.com/huggingface/datasets/issues/1939 metrics don't get cached, looking at my local `~/...
19
[experiment] missing default_experiment-1-0.arrow the original report was pretty bad and incomplete - my apologies! Please see the complete version here: https://github.com/huggingface/datasets/issues/1942#issuecomment-786336481 ------------ As mentioned here https://github.com/huggingface/datasets/issues/19...
[ 0.05026748776435852, -0.030785545706748962, 0.05852583795785904, 0.16687795519828796, 0.034458503127098083, 0.03031504899263382, 0.18300701677799225, 0.2939567565917969, 0.23588106036186218, 0.10173691809177399, 0.10235768556594849, 0.18876944482326508, -0.3214573264122009, 0.0011921226978...
https://github.com/huggingface/datasets/issues/1941
Works great 👍 I just put a minor comment on the commit, I think you meant to pass the `train_size` from the one obtained from the config. Thanks for a quick response!
Loading of FAISS index fails for index_name = 'exact'
Hi, It looks like loading of FAISS index now fails when using index_name = 'exact'. For example, from the RAG [model card](https://huggingface.co/facebook/rag-token-nq?fbclid=IwAR3bTfhls5U_t9DqsX2Vzb7NhtRHxJxfQ-uwFT7VuCPMZUM2AdAlKF_qkI8#usage). Running `transformers==4.3.2` and datasets installed from source o...
32
Loading of FAISS index fails for index_name = 'exact' Hi, It looks like loading of FAISS index now fails when using index_name = 'exact'. For example, from the RAG [model card](https://huggingface.co/facebook/rag-token-nq?fbclid=IwAR3bTfhls5U_t9DqsX2Vzb7NhtRHxJxfQ-uwFT7VuCPMZUM2AdAlKF_qkI8#usage). Running `t...
[ -0.08892602473497391, -0.11038333177566528, 0.010998383164405823, 0.05400155112147331, 0.4101669490337372, -0.05691791698336601, 0.29681292176246643, 0.25089752674102783, 0.2696114182472229, 0.19975534081459045, -0.22171977162361145, 0.13984401524066925, 0.1363164782524109, -0.137647747993...
https://github.com/huggingface/datasets/issues/1940
Thanks for the report ! Currently we don't have a way to let the user easily disable this behavior. However I agree that we should support stateful processing functions, ideally by removing `does_function_return_dict`. We needed this function in order to know whether the `map` functions needs to write data or no...
Side effect when filtering data due to `does_function_return_dict` call in `Dataset.map()`
Hi there! In my codebase I have a function to filter rows in a dataset, selecting only a certain number of examples per class. The function passes a extra argument to maintain a counter of the number of dataset rows/examples already selected per each class, which are the ones I want to keep in the end: ```python ...
123
Side effect when filtering data due to `does_function_return_dict` call in `Dataset.map()` Hi there! In my codebase I have a function to filter rows in a dataset, selecting only a certain number of examples per class. The function passes a extra argument to maintain a counter of the number of dataset rows/examples...
[ -0.42141175270080566, 0.028957799077033997, -0.15750375390052795, 0.018457571044564247, -0.08442586660385132, -0.32018494606018066, 0.20511837303638458, 0.1946578323841095, 0.2660331130027771, 0.12066253274679184, 0.20738402009010315, 0.5199101567268372, -0.07889807224273682, 0.09672678261...
https://github.com/huggingface/datasets/issues/1939
Thanks for reporting and for all the details and suggestions. I'm totally in favor of having a HF_DATASETS_OFFLINE env variable to disable manually all the connection checks, remove retries etc. Moreover you may know that the use case that you are mentioning is already supported from `datasets` 1.3.0, i.e. you al...
[firewalled env] OFFLINE mode
This issue comes from a need to be able to run `datasets` in a firewalled env, which currently makes the software hang until it times out, as it's unable to complete the network calls. I propose the following approach to solving this problem, using the example of `run_seq2seq.py` as a sample program. There are 2 pos...
156
[firewalled env] OFFLINE mode This issue comes from a need to be able to run `datasets` in a firewalled env, which currently makes the software hang until it times out, as it's unable to complete the network calls. I propose the following approach to solving this problem, using the example of `run_seq2seq.py` as a...
[ -0.4748803675174713, 0.1685332953929901, -0.06255339831113815, 0.10505624115467072, 0.04431166127324104, -0.22849176824092865, 0.4647971987724304, 0.07167980074882507, 0.25459128618240356, 0.04853060096502304, 0.01843962073326111, 0.06361503899097443, 0.08450675755739212, 0.199304148554801...
https://github.com/huggingface/datasets/issues/1939
I'm on master, so using all the available bells and whistles already. If you look at the common issues - it for example tries to look up files if they appear in `_PACKAGED_DATASETS_MODULES` which it shouldn't do. -------------- Yes, there is a nuance to it. As I mentioned it's firewalled - that is it has a net...
[firewalled env] OFFLINE mode
This issue comes from a need to be able to run `datasets` in a firewalled env, which currently makes the software hang until it times out, as it's unable to complete the network calls. I propose the following approach to solving this problem, using the example of `run_seq2seq.py` as a sample program. There are 2 pos...
257
[firewalled env] OFFLINE mode This issue comes from a need to be able to run `datasets` in a firewalled env, which currently makes the software hang until it times out, as it's unable to complete the network calls. I propose the following approach to solving this problem, using the example of `run_seq2seq.py` as a...
[ -0.4748803675174713, 0.1685332953929901, -0.06255339831113815, 0.10505624115467072, 0.04431166127324104, -0.22849176824092865, 0.4647971987724304, 0.07167980074882507, 0.25459128618240356, 0.04853060096502304, 0.01843962073326111, 0.06361503899097443, 0.08450675755739212, 0.199304148554801...
https://github.com/huggingface/datasets/issues/1939
Ok understand better the hanging issue. I guess catching connection errors is not enough, we should also avoid all the hangings. Currently the offline mode tests are only done by simulating an instant connection fail that returns an error, let's have another connection mock that hangs instead. I'll also take a loo...
[firewalled env] OFFLINE mode
This issue comes from a need to be able to run `datasets` in a firewalled env, which currently makes the software hang until it times out, as it's unable to complete the network calls. I propose the following approach to solving this problem, using the example of `run_seq2seq.py` as a sample program. There are 2 pos...
61
[firewalled env] OFFLINE mode This issue comes from a need to be able to run `datasets` in a firewalled env, which currently makes the software hang until it times out, as it's unable to complete the network calls. I propose the following approach to solving this problem, using the example of `run_seq2seq.py` as a...
[ -0.4748803675174713, 0.1685332953929901, -0.06255339831113815, 0.10505624115467072, 0.04431166127324104, -0.22849176824092865, 0.4647971987724304, 0.07167980074882507, 0.25459128618240356, 0.04853060096502304, 0.01843962073326111, 0.06361503899097443, 0.08450675755739212, 0.199304148554801...
https://github.com/huggingface/datasets/issues/1939
FWIW, I think instant failure on the behalf of a network call is the simplest solution to correctly represent the environment and having the caller to sort it out is the next thing to do, since here it is the case of having no functional network, it's just that the software doesn't know this is the case, because there ...
[firewalled env] OFFLINE mode
This issue comes from a need to be able to run `datasets` in a firewalled env, which currently makes the software hang until it times out, as it's unable to complete the network calls. I propose the following approach to solving this problem, using the example of `run_seq2seq.py` as a sample program. There are 2 pos...
88
[firewalled env] OFFLINE mode This issue comes from a need to be able to run `datasets` in a firewalled env, which currently makes the software hang until it times out, as it's unable to complete the network calls. I propose the following approach to solving this problem, using the example of `run_seq2seq.py` as a...
[ -0.4748803675174713, 0.1685332953929901, -0.06255339831113815, 0.10505624115467072, 0.04431166127324104, -0.22849176824092865, 0.4647971987724304, 0.07167980074882507, 0.25459128618240356, 0.04853060096502304, 0.01843962073326111, 0.06361503899097443, 0.08450675755739212, 0.199304148554801...
https://github.com/huggingface/datasets/issues/1939
Update on this: I managed to create a mock environment for tests that makes the connections hang until timeout. I managed to reproduce the issue you're having in this environment. I'll update the offline test cases to also test the robustness to connection hangings, and make sure we set proper timeouts where it...
[firewalled env] OFFLINE mode
This issue comes from a need to be able to run `datasets` in a firewalled env, which currently makes the software hang until it times out, as it's unable to complete the network calls. I propose the following approach to solving this problem, using the example of `run_seq2seq.py` as a sample program. There are 2 pos...
65
[firewalled env] OFFLINE mode This issue comes from a need to be able to run `datasets` in a firewalled env, which currently makes the software hang until it times out, as it's unable to complete the network calls. I propose the following approach to solving this problem, using the example of `run_seq2seq.py` as a...
[ -0.4748803675174713, 0.1685332953929901, -0.06255339831113815, 0.10505624115467072, 0.04431166127324104, -0.22849176824092865, 0.4647971987724304, 0.07167980074882507, 0.25459128618240356, 0.04853060096502304, 0.01843962073326111, 0.06361503899097443, 0.08450675755739212, 0.199304148554801...
https://github.com/huggingface/datasets/issues/1939
I lost access to the firewalled setup, but I emulated it with: ``` sudo ufw enable sudo ufw default deny outgoing ``` (thanks @mfuntowicz) I was able to test `HF_DATASETS_OFFLINE=1` and it worked great - i.e. didn't try to reach out with it and used the cached files instead. Thank you!
[firewalled env] OFFLINE mode
This issue comes from a need to be able to run `datasets` in a firewalled env, which currently makes the software hang until it times out, as it's unable to complete the network calls. I propose the following approach to solving this problem, using the example of `run_seq2seq.py` as a sample program. There are 2 pos...
51
[firewalled env] OFFLINE mode This issue comes from a need to be able to run `datasets` in a firewalled env, which currently makes the software hang until it times out, as it's unable to complete the network calls. I propose the following approach to solving this problem, using the example of `run_seq2seq.py` as a...
[ -0.4748803675174713, 0.1685332953929901, -0.06255339831113815, 0.10505624115467072, 0.04431166127324104, -0.22849176824092865, 0.4647971987724304, 0.07167980074882507, 0.25459128618240356, 0.04853060096502304, 0.01843962073326111, 0.06361503899097443, 0.08450675755739212, 0.199304148554801...
https://github.com/huggingface/datasets/issues/1924
Hi ! I guess you can add a dataset without the fields that must be kept anonymous, and then update those when the anonymity period is over. You can also make the PR from an anonymous org. Pinging @yjernite just to make sure it's ok
Anonymous Dataset Addition (i.e Anonymous PR?)
Hello, Thanks a lot for your librairy. We plan to submit a paper on OpenReview using the Anonymous setting. Is it possible to add a new dataset without breaking the anonimity, with a link to the paper ? Cheers @eusip
45
Anonymous Dataset Addition (i.e Anonymous PR?) Hello, Thanks a lot for your librairy. We plan to submit a paper on OpenReview using the Anonymous setting. Is it possible to add a new dataset without breaking the anonimity, with a link to the paper ? Cheers @eusip Hi ! I guess you can add a dataset without th...
[ -0.2978556752204895, 0.5536887645721436, -0.023817511275410652, -0.19032123684883118, -0.07589468359947205, -0.10795879364013672, 0.5019996762275696, 0.008097099140286446, 0.06429596245288849, 0.05346936360001564, 0.07121018320322037, 0.10383328050374985, 0.004155635833740234, 0.1634859591...
https://github.com/huggingface/datasets/issues/1924
Hello, I would prefer to do the reverse: adding a link to an anonymous paper without the people names/institution in the PR. Would it be conceivable ? Cheers
Anonymous Dataset Addition (i.e Anonymous PR?)
Hello, Thanks a lot for your librairy. We plan to submit a paper on OpenReview using the Anonymous setting. Is it possible to add a new dataset without breaking the anonimity, with a link to the paper ? Cheers @eusip
28
Anonymous Dataset Addition (i.e Anonymous PR?) Hello, Thanks a lot for your librairy. We plan to submit a paper on OpenReview using the Anonymous setting. Is it possible to add a new dataset without breaking the anonimity, with a link to the paper ? Cheers @eusip Hello, I would prefer to do the reverse: addi...
[ -0.20116716623306274, 0.4423332214355469, 0.020197030156850815, -0.07657147943973541, -0.09471510350704193, -0.09441262483596802, 0.4387368857860565, -0.00272270105779171, 0.03627808392047882, 0.0934399664402008, -0.05074608325958252, 0.06698282808065414, 0.0037660151720046997, 0.087434552...
https://github.com/huggingface/datasets/issues/1922
Hi @JieyuZhao ! You can edit the dataset card of wino_bias to update the URL via a Pull Request. This would be really appreciated :) The dataset card is the README.md file you can find at https://github.com/huggingface/datasets/tree/master/datasets/wino_bias Also the homepage url is also mentioned in the wino_bi...
How to update the "wino_bias" dataset
Hi all, Thanks for the efforts to collect all the datasets! But I think there is a problem with the wino_bias dataset. The current link is not correct. How can I update that? Thanks!
89
How to update the "wino_bias" dataset Hi all, Thanks for the efforts to collect all the datasets! But I think there is a problem with the wino_bias dataset. The current link is not correct. How can I update that? Thanks! Hi @JieyuZhao ! You can edit the dataset card of wino_bias to update the URL via a Pul...
[ -0.3595494031906128, 0.16637496650218964, -0.0910966694355011, 0.10533393919467926, 0.0010984940454363823, 0.17919564247131348, -0.03932597488164902, 0.0637114867568016, 0.062265098094940186, -0.12878219783306122, -0.26217564940452576, -0.0001707226037979126, 0.2578839659690857, 0.15930891...
https://github.com/huggingface/datasets/issues/1919
Hi thanks for reporting and for proposing a fix :) I just merged a fix, feel free to try it from the master branch !
Failure to save with save_to_disk
When I try to save a dataset locally using the `save_to_disk` method I get the error: ```bash FileNotFoundError: [Errno 2] No such file or directory: '/content/squad/train/squad-train.arrow' ``` To replicate: 1. Install `datasets` from master 2. Run this code: ```python from datasets import load...
25
Failure to save with save_to_disk When I try to save a dataset locally using the `save_to_disk` method I get the error: ```bash FileNotFoundError: [Errno 2] No such file or directory: '/content/squad/train/squad-train.arrow' ``` To replicate: 1. Install `datasets` from master 2. Run this code: ```p...
[ -0.04368682578206062, 0.1429486721754074, 0.05701150372624397, 0.1895618885755539, 0.5194173455238342, 0.2885243892669678, 0.1922130584716797, 0.2388131022453308, -0.13136422634124756, 0.1859048306941986, 0.14157792925834656, 0.3680594265460968, -0.31961071491241455, -0.2508211135864258, ...
https://github.com/huggingface/datasets/issues/1915
Thanks for reporting ! This is a bug. For now feel free to set `ignore_verifications=False` in `load_dataset`. I'm working on a fix
Unable to download `wiki_dpr`
I am trying to download the `wiki_dpr` dataset. Specifically, I want to download `psgs_w100.multiset.no_index` with no embeddings/no index. In order to do so, I ran: `curr_dataset = load_dataset("wiki_dpr", embeddings_name="multiset", index_name="no_index")` However, I got the following error: `datasets.utils.i...
22
Unable to download `wiki_dpr` I am trying to download the `wiki_dpr` dataset. Specifically, I want to download `psgs_w100.multiset.no_index` with no embeddings/no index. In order to do so, I ran: `curr_dataset = load_dataset("wiki_dpr", embeddings_name="multiset", index_name="no_index")` However, I got the fol...
[ -0.35910794138908386, -0.3630984425544739, -0.0504426434636116, 0.3148261606693268, 0.3717033267021179, 0.42704886198043823, 0.31989502906799316, 0.0625339224934578, 0.23852169513702393, 0.18049922585487366, 0.16470152139663696, -0.020608635619282722, 0.09541131556034088, -0.02109100297093...
https://github.com/huggingface/datasets/issues/1915
I just merged a fix :) We'll do a patch release soon. In the meantime feel free to try it from the master branch Thanks again for reporting !
Unable to download `wiki_dpr`
I am trying to download the `wiki_dpr` dataset. Specifically, I want to download `psgs_w100.multiset.no_index` with no embeddings/no index. In order to do so, I ran: `curr_dataset = load_dataset("wiki_dpr", embeddings_name="multiset", index_name="no_index")` However, I got the following error: `datasets.utils.i...
29
Unable to download `wiki_dpr` I am trying to download the `wiki_dpr` dataset. Specifically, I want to download `psgs_w100.multiset.no_index` with no embeddings/no index. In order to do so, I ran: `curr_dataset = load_dataset("wiki_dpr", embeddings_name="multiset", index_name="no_index")` However, I got the fol...
[ -0.35910794138908386, -0.3630984425544739, -0.0504426434636116, 0.3148261606693268, 0.3717033267021179, 0.42704886198043823, 0.31989502906799316, 0.0625339224934578, 0.23852169513702393, 0.18049922585487366, 0.16470152139663696, -0.020608635619282722, 0.09541131556034088, -0.02109100297093...
https://github.com/huggingface/datasets/issues/1911
am suspicious of this thing? what's the purpose of this? pickling and unplickling `self = pickle.loads(pickle.dumps(self))` ``` def save_to_disk(self, dataset_path: str, fs=None): """ Saves a dataset to a dataset directory, or in a filesystem using either :class:`datasets.filesystem.S3FileSys...
Saving processed dataset running infinitely
I have a text dataset of size 220M. For pre-processing, I need to tokenize this and filter rows with the large sequence. My tokenization took roughly 3hrs. I used map() with batch size 1024 and multi-process with 96 processes. filter() function was way to slow, so I used a hack to use pyarrow filter table func...
103
Saving processed dataset running infinitely I have a text dataset of size 220M. For pre-processing, I need to tokenize this and filter rows with the large sequence. My tokenization took roughly 3hrs. I used map() with batch size 1024 and multi-process with 96 processes. filter() function was way to slow, so ...
[ -0.21761900186538696, 0.1967647671699524, -0.11508182436227798, 0.26369524002075195, 0.14856961369514465, -0.07311950623989105, 0.19137287139892578, 0.23337428271770477, -0.19323313236236572, -0.08382947742938995, 0.06877244263887405, 0.3565652072429657, -0.10871390253305435, 0.26353397965...
https://github.com/huggingface/datasets/issues/1911
Tried finding the root cause but was unsuccessful. I am using lazy tokenization with `dataset.set_transform()`, it works like a charm with almost same performance as pre-compute.
Saving processed dataset running infinitely
I have a text dataset of size 220M. For pre-processing, I need to tokenize this and filter rows with the large sequence. My tokenization took roughly 3hrs. I used map() with batch size 1024 and multi-process with 96 processes. filter() function was way to slow, so I used a hack to use pyarrow filter table func...
26
Saving processed dataset running infinitely I have a text dataset of size 220M. For pre-processing, I need to tokenize this and filter rows with the large sequence. My tokenization took roughly 3hrs. I used map() with batch size 1024 and multi-process with 96 processes. filter() function was way to slow, so ...
[ -0.35619664192199707, 0.1683889776468277, -0.0956779271364212, 0.2705768048763275, 0.28090640902519226, -0.05556663125753403, 0.2274562418460846, 0.2229018211364746, -0.31085845828056335, -0.1395980268716812, 0.1082136482000351, 0.1759864240884781, -0.14385350048542023, 0.234498530626297, ...
https://github.com/huggingface/datasets/issues/1911
Hi ! This very probably comes from the hack you used. The pickling line was added an a sanity check because save_to_disk uses the same assumptions as pickling for a dataset object. The main assumption is that memory mapped pyarrow tables must be reloadable from the disk. In your case it's not possible since you alte...
Saving processed dataset running infinitely
I have a text dataset of size 220M. For pre-processing, I need to tokenize this and filter rows with the large sequence. My tokenization took roughly 3hrs. I used map() with batch size 1024 and multi-process with 96 processes. filter() function was way to slow, so I used a hack to use pyarrow filter table func...
191
Saving processed dataset running infinitely I have a text dataset of size 220M. For pre-processing, I need to tokenize this and filter rows with the large sequence. My tokenization took roughly 3hrs. I used map() with batch size 1024 and multi-process with 96 processes. filter() function was way to slow, so ...
[ -0.3835667371749878, 0.2207915186882019, -0.07534848898649216, 0.252421498298645, 0.16763338446617126, -0.08597233146429062, 0.09959078580141068, 0.24253198504447937, -0.16498231887817383, -0.058490946888923645, 0.033023402094841, 0.40208277106285095, -0.08487106114625931, 0.23195770382881...
https://github.com/huggingface/datasets/issues/1907
Hi ! :) This looks like the same issue as https://github.com/huggingface/datasets/issues/1856 Basically google drive has quota issues that makes it inconvenient for downloading files. If the quota of a file is exceeded, you have to wait 24h for the quota to reset (which is painful). The error says that the c...
DBPedia14 Dataset Checksum bug?
Hi there!!! I've been using successfully the DBPedia dataset (https://huggingface.co/datasets/dbpedia_14) with my codebase in the last couple of weeks, but in the last couple of days now I get this error: ``` Traceback (most recent call last): File "./conditional_classification/basic_pipeline.py", line 178, i...
75
DBPedia14 Dataset Checksum bug? Hi there!!! I've been using successfully the DBPedia dataset (https://huggingface.co/datasets/dbpedia_14) with my codebase in the last couple of weeks, but in the last couple of days now I get this error: ``` Traceback (most recent call last): File "./conditional_classificati...
[ -0.24835604429244995, 0.350805401802063, -0.1227644830942154, 0.26245275139808655, 0.10466556251049042, -0.004844531416893005, 0.320569783449173, 0.5194305181503296, -0.08774194121360779, -0.04135894030332565, 0.07762559503316879, -0.1982267200946808, 0.003129672259092331, 0.34741139411926...
https://github.com/huggingface/datasets/issues/1906
We already have a ClassLabel type that does this kind of mapping between the label ids (integers) and actual label values (strings). I wonder if actually we should use the DictionaryType from Arrow and the Categorical type from pandas for the `datasets` ClassLabel feature type. Currently ClassLabel corresponds to `...
Feature Request: Support for Pandas `Categorical`
``` from datasets import Dataset import pandas as pd import pyarrow df = pd.DataFrame(pd.Series(["a", "b", "c", "a"], dtype="category")) pyarrow.Table.from_pandas(df) Dataset.from_pandas(df) # Throws NotImplementedError # TODO(thom) this will need access to the dictionary as well (for labels). I.e. to the py_...
69
Feature Request: Support for Pandas `Categorical` ``` from datasets import Dataset import pandas as pd import pyarrow df = pd.DataFrame(pd.Series(["a", "b", "c", "a"], dtype="category")) pyarrow.Table.from_pandas(df) Dataset.from_pandas(df) # Throws NotImplementedError # TODO(thom) this will need access to ...
[ 0.023009322583675385, -0.01027362048625946, -0.14260587096214294, 0.20766466856002808, 0.23701293766498566, 0.16727852821350098, 0.12674063444137573, 0.2487182915210724, -0.07384254038333893, -0.21550771594047546, 0.16739961504936218, 0.28240713477134705, -0.20351165533065796, 0.4252622723...
https://github.com/huggingface/datasets/issues/1906
Now that I've heard you explain ClassLabel, that makes a lot of sense! While DictionaryType for Arrow (I think) can have arbitrarily typed keys, so it won't cover all potential cases, pandas' Category is *probably* the most common use for that pyarrow type, and ClassLabel should match that perfectly? Other thoughts...
Feature Request: Support for Pandas `Categorical`
``` from datasets import Dataset import pandas as pd import pyarrow df = pd.DataFrame(pd.Series(["a", "b", "c", "a"], dtype="category")) pyarrow.Table.from_pandas(df) Dataset.from_pandas(df) # Throws NotImplementedError # TODO(thom) this will need access to the dictionary as well (for labels). I.e. to the py_...
319
Feature Request: Support for Pandas `Categorical` ``` from datasets import Dataset import pandas as pd import pyarrow df = pd.DataFrame(pd.Series(["a", "b", "c", "a"], dtype="category")) pyarrow.Table.from_pandas(df) Dataset.from_pandas(df) # Throws NotImplementedError # TODO(thom) this will need access to ...
[ 0.023009322583675385, -0.01027362048625946, -0.14260587096214294, 0.20766466856002808, 0.23701293766498566, 0.16727852821350098, 0.12674063444137573, 0.2487182915210724, -0.07384254038333893, -0.21550771594047546, 0.16739961504936218, 0.28240713477134705, -0.20351165533065796, 0.4252622723...
https://github.com/huggingface/datasets/issues/1906
I think we can first keep the int64 precision but with an arrow Dictionary for ClassLabel, and focus on the connection with arrow and pandas. In this scope, I really like the idea of checking for the dictionary type: > Another idea that just occurred to me: add a branch in here to generate a ClassLabel if the dic...
Feature Request: Support for Pandas `Categorical`
``` from datasets import Dataset import pandas as pd import pyarrow df = pd.DataFrame(pd.Series(["a", "b", "c", "a"], dtype="category")) pyarrow.Table.from_pandas(df) Dataset.from_pandas(df) # Throws NotImplementedError # TODO(thom) this will need access to the dictionary as well (for labels). I.e. to the py_...
260
Feature Request: Support for Pandas `Categorical` ``` from datasets import Dataset import pandas as pd import pyarrow df = pd.DataFrame(pd.Series(["a", "b", "c", "a"], dtype="category")) pyarrow.Table.from_pandas(df) Dataset.from_pandas(df) # Throws NotImplementedError # TODO(thom) this will need access to ...
[ 0.023009322583675385, -0.01027362048625946, -0.14260587096214294, 0.20766466856002808, 0.23701293766498566, 0.16727852821350098, 0.12674063444137573, 0.2487182915210724, -0.07384254038333893, -0.21550771594047546, 0.16739961504936218, 0.28240713477134705, -0.20351165533065796, 0.4252622723...
https://github.com/huggingface/datasets/issues/1898
I just merged a fix, we'll do a patch release soon. Thanks again for reporting, and sorry for the inconvenience. In the meantime you can load `ALT` using `datasets` from the master branch
ALT dataset has repeating instances in all splits
The [ALT](https://huggingface.co/datasets/alt) dataset has all the same instances within each split :/ Seemed like a great dataset for some experiments I wanted to carry out, especially since its medium-sized, and has all splits. Would be great if this could be fixed :) Added a snapshot of the contents from `exp...
33
ALT dataset has repeating instances in all splits The [ALT](https://huggingface.co/datasets/alt) dataset has all the same instances within each split :/ Seemed like a great dataset for some experiments I wanted to carry out, especially since its medium-sized, and has all splits. Would be great if this could be fi...
[ -0.25304487347602844, -0.7312532663345337, -0.055595606565475464, 0.4320773780345917, 0.3174535930156708, -0.1736772358417511, 0.3799058794975281, 0.14246971905231476, 0.27942490577697754, 0.33198970556259155, -0.16143034398555756, 0.09805242717266083, 0.07770608365535736, -0.0084828212857...
https://github.com/huggingface/datasets/issues/1895
Thanks for reporting ! You're right, `string_to_arrow` should be able to take `"timestamp[ns]"` as input and return the right pyarrow timestamp type. Feel free to suggest a fix for `string_to_arrow` and open a PR if you want to contribute ! This would be very appreciated :) To give you more context: As you ma...
Bug Report: timestamp[ns] not recognized
Repro: ``` from datasets import Dataset import pandas as pd import pyarrow df = pd.DataFrame(pd.date_range("2018-01-01", periods=3, freq="H")) pyarrow.Table.from_pandas(df) Dataset.from_pandas(df) # Throws ValueError: Neither timestamp[ns] nor timestamp[ns]_ seems to be a pyarrow data type. ``` The fact...
159
Bug Report: timestamp[ns] not recognized Repro: ``` from datasets import Dataset import pandas as pd import pyarrow df = pd.DataFrame(pd.date_range("2018-01-01", periods=3, freq="H")) pyarrow.Table.from_pandas(df) Dataset.from_pandas(df) # Throws ValueError: Neither timestamp[ns] nor timestamp[ns]_ seems ...
[ -0.1527937799692154, 0.3287227153778076, 0.004078298807144165, 0.0871679037809372, 0.09477338194847107, -0.07733038067817688, 0.45133110880851746, 0.36234837770462036, -0.49170026183128357, -0.2842444181442261, 0.2675410509109497, 0.5988477468490601, -0.18037529289722443, 0.018187589943408...
https://github.com/huggingface/datasets/issues/1895
Thanks for the clarification @lhoestq ! This may be a little bit of a stupid question, but I wanted to clarify one more thing before I took a stab at this: When the features get inferred, I believe they already have a pyarrow schema (https://github.com/huggingface/datasets/blob/master/src/datasets/arrow_dataset.p...
Bug Report: timestamp[ns] not recognized
Repro: ``` from datasets import Dataset import pandas as pd import pyarrow df = pd.DataFrame(pd.date_range("2018-01-01", periods=3, freq="H")) pyarrow.Table.from_pandas(df) Dataset.from_pandas(df) # Throws ValueError: Neither timestamp[ns] nor timestamp[ns]_ seems to be a pyarrow data type. ``` The fact...
100
Bug Report: timestamp[ns] not recognized Repro: ``` from datasets import Dataset import pandas as pd import pyarrow df = pd.DataFrame(pd.date_range("2018-01-01", periods=3, freq="H")) pyarrow.Table.from_pandas(df) Dataset.from_pandas(df) # Throws ValueError: Neither timestamp[ns] nor timestamp[ns]_ seems ...
[ -0.07395335286855698, 0.26339054107666016, 0.023429065942764282, 0.11723296344280243, 0.06972910463809967, -0.1028006374835968, 0.3482515811920166, 0.2648754417896271, -0.5368145108222961, -0.2700381875038147, 0.23996159434318542, 0.4913213849067688, -0.14977118372917175, -0.08162836730480...
https://github.com/huggingface/datasets/issues/1895
The objective in terms of design is to make it easy to create Features in a pythonic way. So for example we use a string to define a Value type. That's why when inferring the Features from an arrow schema we have to find the right string definitions for Value types. I guess we could also have a constructor `Value.from...
Bug Report: timestamp[ns] not recognized
Repro: ``` from datasets import Dataset import pandas as pd import pyarrow df = pd.DataFrame(pd.date_range("2018-01-01", periods=3, freq="H")) pyarrow.Table.from_pandas(df) Dataset.from_pandas(df) # Throws ValueError: Neither timestamp[ns] nor timestamp[ns]_ seems to be a pyarrow data type. ``` The fact...
116
Bug Report: timestamp[ns] not recognized Repro: ``` from datasets import Dataset import pandas as pd import pyarrow df = pd.DataFrame(pd.date_range("2018-01-01", periods=3, freq="H")) pyarrow.Table.from_pandas(df) Dataset.from_pandas(df) # Throws ValueError: Neither timestamp[ns] nor timestamp[ns]_ seems ...
[ -0.11467473953962326, 0.19220730662345886, 0.044961392879486084, 0.14448221027851105, -0.02857380546629429, -0.12259776890277863, 0.4444707930088043, 0.2822771668434143, -0.5322679877281189, -0.3254835903644562, 0.32812491059303284, 0.565228283405304, -0.20688390731811523, 0.08838329464197...
https://github.com/huggingface/datasets/issues/1895
OK I think I understand now: Features are datasets' internal representation of a schema type, distinct from pyarrow's schema. Value() corresponds to pyarrow's "primitive" types (e.g. `int` or `string`, but not things like `list` or `dict`). `get_nested_type()` (https://github.com/huggingface/datasets/blob/master/s...
Bug Report: timestamp[ns] not recognized
Repro: ``` from datasets import Dataset import pandas as pd import pyarrow df = pd.DataFrame(pd.date_range("2018-01-01", periods=3, freq="H")) pyarrow.Table.from_pandas(df) Dataset.from_pandas(df) # Throws ValueError: Neither timestamp[ns] nor timestamp[ns]_ seems to be a pyarrow data type. ``` The fact...
96
Bug Report: timestamp[ns] not recognized Repro: ``` from datasets import Dataset import pandas as pd import pyarrow df = pd.DataFrame(pd.date_range("2018-01-01", periods=3, freq="H")) pyarrow.Table.from_pandas(df) Dataset.from_pandas(df) # Throws ValueError: Neither timestamp[ns] nor timestamp[ns]_ seems ...
[ -0.14257371425628662, 0.32469579577445984, -0.00011890009045600891, 0.11998894065618515, 0.0674353614449501, -0.07652750611305237, 0.3947216868400574, 0.27701976895332336, -0.475416362285614, -0.2832736372947693, 0.2034531831741333, 0.5407941341400146, -0.16183915734291077, 0.0006554424762...
https://github.com/huggingface/datasets/issues/1894
Hi sam ! Indeed we can expect the performances to be very close since both MMapIndexedDataset and the `datasets` implem use memory mapping. With memory mapping what determines the I/O performance is the speed of your hard drive/SSD. In terms of performance we're pretty close to the optimal speed for reading text, e...
benchmarking against MMapIndexedDataset
I am trying to benchmark my datasets based implementation against fairseq's [`MMapIndexedDataset`](https://github.com/pytorch/fairseq/blob/master/fairseq/data/indexed_dataset.py#L365) and finding that, according to psrecord, my `datasets` implem uses about 3% more CPU memory and runs 1% slower for `wikitext103` (~1GB o...
141
benchmarking against MMapIndexedDataset I am trying to benchmark my datasets based implementation against fairseq's [`MMapIndexedDataset`](https://github.com/pytorch/fairseq/blob/master/fairseq/data/indexed_dataset.py#L365) and finding that, according to psrecord, my `datasets` implem uses about 3% more CPU memory an...
[ -0.38104215264320374, -0.030588731169700623, -0.18135754764080048, 0.25040581822395325, -0.2935996651649475, -0.04670792818069458, 0.03982244431972504, 0.1909920871257782, -0.15054993331432343, -0.09039342403411865, -0.16343781352043152, 0.3356113135814667, 0.031131166964769363, -0.4226371...
https://github.com/huggingface/datasets/issues/1894
Also I would be interested to know what data types `MMapIndexedDataset` supports. Is there some documentation somewhere ?
benchmarking against MMapIndexedDataset
I am trying to benchmark my datasets based implementation against fairseq's [`MMapIndexedDataset`](https://github.com/pytorch/fairseq/blob/master/fairseq/data/indexed_dataset.py#L365) and finding that, according to psrecord, my `datasets` implem uses about 3% more CPU memory and runs 1% slower for `wikitext103` (~1GB o...
18
benchmarking against MMapIndexedDataset I am trying to benchmark my datasets based implementation against fairseq's [`MMapIndexedDataset`](https://github.com/pytorch/fairseq/blob/master/fairseq/data/indexed_dataset.py#L365) and finding that, according to psrecord, my `datasets` implem uses about 3% more CPU memory an...
[ -0.26232051849365234, -0.0587807297706604, -0.18960949778556824, 0.27778807282447815, -0.22772571444511414, -0.07376205921173096, 0.011163502931594849, 0.13576093316078186, -0.2933737635612488, -0.15680250525474548, -0.15320037305355072, 0.377422034740448, 0.0027405470609664917, -0.3709000...
https://github.com/huggingface/datasets/issues/1894
no docs haha, it's written to support integer numpy arrays. You can build one in fairseq with, roughly: ```bash wget https://s3.amazonaws.com/research.metamind.io/wikitext/wikitext-103-raw-v1.zip unzip wikitext-103-raw-v1.zip export dd=$HOME/fairseq-py/wikitext-103-raw export mm_dir=$HOME/mmap_wikitext2 mk...
benchmarking against MMapIndexedDataset
I am trying to benchmark my datasets based implementation against fairseq's [`MMapIndexedDataset`](https://github.com/pytorch/fairseq/blob/master/fairseq/data/indexed_dataset.py#L365) and finding that, according to psrecord, my `datasets` implem uses about 3% more CPU memory and runs 1% slower for `wikitext103` (~1GB o...
249
benchmarking against MMapIndexedDataset I am trying to benchmark my datasets based implementation against fairseq's [`MMapIndexedDataset`](https://github.com/pytorch/fairseq/blob/master/fairseq/data/indexed_dataset.py#L365) and finding that, according to psrecord, my `datasets` implem uses about 3% more CPU memory an...
[ -0.24320238828659058, 0.023352637887001038, -0.16917647421360016, 0.18205098807811737, -0.1022191047668457, -0.022615551948547363, 0.1294507384300232, 0.2604651153087616, -0.20882689952850342, -0.06991688907146454, -0.1556989699602127, 0.5033262372016907, -0.07024998962879181, -0.418856203...
https://github.com/huggingface/datasets/issues/1893
This was also mentioned in https://github.com/huggingface/datasets/issues/488 The bucket where is data was stored seems to be unavailable now. Maybe we can change the URL to the ones in https://conferences.unite.un.org/uncorpus/en/downloadoverview ?
wmt19 is broken
1. Check which lang pairs we have: `--dataset_name wmt19`: Please pick one among the available configs: ['cs-en', 'de-en', 'fi-en', 'gu-en', 'kk-en', 'lt-en', 'ru-en', 'zh-en', 'fr-de'] 2. OK, let's pick `ru-en`: `--dataset_name wmt19 --dataset_config "ru-en"` no cookies: ``` Traceback (most recent c...
30
wmt19 is broken 1. Check which lang pairs we have: `--dataset_name wmt19`: Please pick one among the available configs: ['cs-en', 'de-en', 'fi-en', 'gu-en', 'kk-en', 'lt-en', 'ru-en', 'zh-en', 'fr-de'] 2. OK, let's pick `ru-en`: `--dataset_name wmt19 --dataset_config "ru-en"` no cookies: ``` Traceb...
[ -0.3531681299209595, -0.45960521697998047, -0.04126087576150894, 0.3225635886192322, 0.17832496762275696, -0.03620505332946777, 0.1937316358089447, 0.23352697491645813, 0.06609702110290527, 0.060678880661726, 0.01479630172252655, 0.10903225839138031, -0.12556132674217224, 0.570747792720794...
https://github.com/huggingface/datasets/issues/1892
Yes that would be awesome. Not only the download speeds are awful, but also some files are missing. We list all the URLs in the datasets/wmt19/wmt_utils.py so we can make a script to download them all and host on S3. Also I think most of the materials are under the CC BY-NC-SA 3.0 license (must double check) so it sh...
request to mirror wmt datasets, as they are really slow to download
Would it be possible to mirror the wmt data files under hf? Some of them take hours to download and not because of the local speed. They are all quite small datasets, just extremely slow to download. Thank you!
78
request to mirror wmt datasets, as they are really slow to download Would it be possible to mirror the wmt data files under hf? Some of them take hours to download and not because of the local speed. They are all quite small datasets, just extremely slow to download. Thank you! Yes that would be awesome. Not onl...
[ -0.19423821568489075, -0.3241640329360962, 0.0704934224486351, 0.2124052792787552, 0.010060219094157219, 0.0652930736541748, 0.1663087010383606, 0.4544948935508728, 0.056202247738838196, -0.11427632719278336, -0.25184166431427, -0.07385167479515076, -0.06027544289827347, 0.3107830882072449...
https://github.com/huggingface/datasets/issues/1892
Yeah, the scripts are pretty ugly! A big refactor would make sense here...and I also remember that the datasets were veeery slow to download
request to mirror wmt datasets, as they are really slow to download
Would it be possible to mirror the wmt data files under hf? Some of them take hours to download and not because of the local speed. They are all quite small datasets, just extremely slow to download. Thank you!
24
request to mirror wmt datasets, as they are really slow to download Would it be possible to mirror the wmt data files under hf? Some of them take hours to download and not because of the local speed. They are all quite small datasets, just extremely slow to download. Thank you! Yeah, the scripts are pretty ugly!...
[ -0.38050833344459534, -0.17535437643527985, 0.007587600499391556, 0.103769950568676, -0.010469107888638973, 0.059977948665618896, 0.16703125834465027, 0.507707417011261, 0.2716601490974426, -0.030725672841072083, -0.25061967968940735, -0.22163119912147522, 0.03399687260389328, 0.2432684302...
https://github.com/huggingface/datasets/issues/1892
I'm downloading them. I'm starting with the ones hosted on http://data.statmt.org which are the slowest ones
request to mirror wmt datasets, as they are really slow to download
Would it be possible to mirror the wmt data files under hf? Some of them take hours to download and not because of the local speed. They are all quite small datasets, just extremely slow to download. Thank you!
16
request to mirror wmt datasets, as they are really slow to download Would it be possible to mirror the wmt data files under hf? Some of them take hours to download and not because of the local speed. They are all quite small datasets, just extremely slow to download. Thank you! I'm downloading them. I'm startin...
[ -0.4048577547073364, -0.31400907039642334, 0.03699664771556854, 0.1695626676082611, -0.01398396585136652, 0.1483641266822815, 0.09767122566699982, 0.44067156314849854, 0.2012498676776886, -0.026052609086036682, -0.34671705961227417, -0.2557104527950287, 0.08942714333534241, 0.1072439178824...
https://github.com/huggingface/datasets/issues/1892
@lhoestq better to use our new git-based system than just raw S3, no? (that way we have built-in CDN etc.)
request to mirror wmt datasets, as they are really slow to download
Would it be possible to mirror the wmt data files under hf? Some of them take hours to download and not because of the local speed. They are all quite small datasets, just extremely slow to download. Thank you!
20
request to mirror wmt datasets, as they are really slow to download Would it be possible to mirror the wmt data files under hf? Some of them take hours to download and not because of the local speed. They are all quite small datasets, just extremely slow to download. Thank you! @lhoestq better to use our new git...
[ -0.2889099717140198, -0.33067786693573, 0.012011975049972534, 0.1093231737613678, 0.05256720632314682, -0.08142578601837158, 0.16152256727218628, 0.42713236808776855, 0.09387074410915375, -0.019033662974834442, -0.3289593458175659, -0.08687067031860352, 0.009227637201547623, 0.314523905515...
https://github.com/huggingface/datasets/issues/1892
Hi there! What about mirroring other datasets like [CCAligned](http://www.statmt.org/cc-aligned/) as well? All of them are really slow to download...
request to mirror wmt datasets, as they are really slow to download
Would it be possible to mirror the wmt data files under hf? Some of them take hours to download and not because of the local speed. They are all quite small datasets, just extremely slow to download. Thank you!
19
request to mirror wmt datasets, as they are really slow to download Would it be possible to mirror the wmt data files under hf? Some of them take hours to download and not because of the local speed. They are all quite small datasets, just extremely slow to download. Thank you! Hi there! What about mirroring oth...
[ -0.4533650875091553, -0.29872921109199524, 0.02584023028612137, 0.09535181522369385, 0.06331180036067963, 0.13061189651489258, 0.17009225487709045, 0.3957924544811249, 0.1734647899866104, -0.0313711017370224, -0.3652694821357727, -0.2737770080566406, 0.08896150439977646, 0.1364363878965377...
https://github.com/huggingface/datasets/issues/1891
This is the current error thrown for missing datasets: ``` FileNotFoundError: Couldn't find a dataset script at C:\Users\Mario\Desktop\projects\datasets\missing_dataset\missing_dataset.py or any data file in the same directory. Couldn't find 'missing_dataset' on the Hugging Face Hub either: FileNotFoundError: Dataset...
suggestion to improve a missing dataset error
I was using `--dataset_name wmt19` all was good. Then thought perhaps wmt20 is out, so I tried to use `--dataset_name wmt20`, got 3 different errors (1 repeated twice), none telling me the real issue - that `wmt20` isn't in the `datasets`: ``` True, predict_with_generate=True) Traceback (most recent call last): ...
74
suggestion to improve a missing dataset error I was using `--dataset_name wmt19` all was good. Then thought perhaps wmt20 is out, so I tried to use `--dataset_name wmt20`, got 3 different errors (1 repeated twice), none telling me the real issue - that `wmt20` isn't in the `datasets`: ``` True, predict_with_gene...
[ -0.05974513664841652, -0.29434734582901, -0.0008304305374622345, 0.3394809663295746, 0.3252504765987396, -0.03403729200363159, 0.14375101029872894, 0.2369765192270279, 0.17242750525474548, 0.18000997602939606, 0.13413912057876587, -0.0948793888092041, -0.019390786066651344, 0.1371475756168...
https://github.com/huggingface/datasets/issues/1877
I started working on this. My idea is to first add the pyarrow Table wrappers InMemoryTable and MemoryMappedTable that both implement what's necessary regarding copy/pickle. Then have another wrapper that takes the concatenation of InMemoryTable/MemoryMappedTable objects. What's important here is that concatenating ...
Allow concatenation of both in-memory and on-disk datasets
This is a prerequisite for the addition of the `add_item` feature (see #1870). Currently there is one assumption that we would need to change: a dataset is either fully in memory (dataset._data_files is empty), or the dataset can be reloaded from disk (using the dataset._data_files). This assumption is used for pickl...
55
Allow concatenation of both in-memory and on-disk datasets This is a prerequisite for the addition of the `add_item` feature (see #1870). Currently there is one assumption that we would need to change: a dataset is either fully in memory (dataset._data_files is empty), or the dataset can be reloaded from disk (using...
[ -0.36328086256980896, 0.1712486743927002, -0.016625747084617615, 0.19440211355686188, 0.09919460862874985, 0.031043782830238342, -0.22403459250926971, 0.2879289984703064, -0.2779928743839264, 0.16979941725730896, -0.014143228530883789, 0.6244734525680542, -0.007651632651686668, 0.361230760...
https://github.com/huggingface/datasets/issues/1877
Hi @lhoestq @albertvillanova, I checked the linked issues and PR, this seems like a great idea. Would you mind elaborating on the in-memory and memory-mapped datasets? Based on my understanding, it is something like this, please correct me if I am wrong: 1. For in-memory datasets, we don't have any dataset files ...
Allow concatenation of both in-memory and on-disk datasets
This is a prerequisite for the addition of the `add_item` feature (see #1870). Currently there is one assumption that we would need to change: a dataset is either fully in memory (dataset._data_files is empty), or the dataset can be reloaded from disk (using the dataset._data_files). This assumption is used for pickl...
129
Allow concatenation of both in-memory and on-disk datasets This is a prerequisite for the addition of the `add_item` feature (see #1870). Currently there is one assumption that we would need to change: a dataset is either fully in memory (dataset._data_files is empty), or the dataset can be reloaded from disk (using...
[ -0.3151938319206238, 0.02398143708705902, -0.009147141128778458, 0.3324132561683655, -0.09299767017364502, -0.016001366078853607, -0.14156554639339447, 0.051388584077358246, -0.12341327220201492, -0.03432539105415344, 0.012674696743488312, 0.5089060664176941, 0.015509005635976791, 0.430679...
https://github.com/huggingface/datasets/issues/1877
Hi ! Yes you're totally right about your two points :) And in the case of a concatenated dataset, then we should reload each sub-table depending on whether it's in-memory or memory mapped. That means the dataset will be made of several blocks in order to keep track of what's from memory and what's memory mapped. Thi...
Allow concatenation of both in-memory and on-disk datasets
This is a prerequisite for the addition of the `add_item` feature (see #1870). Currently there is one assumption that we would need to change: a dataset is either fully in memory (dataset._data_files is empty), or the dataset can be reloaded from disk (using the dataset._data_files). This assumption is used for pickl...
62
Allow concatenation of both in-memory and on-disk datasets This is a prerequisite for the addition of the `add_item` feature (see #1870). Currently there is one assumption that we would need to change: a dataset is either fully in memory (dataset._data_files is empty), or the dataset can be reloaded from disk (using...
[ -0.33088982105255127, 0.08096610009670258, -0.08752967417240143, 0.12888085842132568, 0.10378753393888474, 0.02138318121433258, -0.09534378349781036, 0.26424840092658997, -0.09941363334655762, 0.19631227850914001, -0.006662741303443909, 0.5743993520736694, -0.027389489114284515, 0.47451505...
https://github.com/huggingface/datasets/issues/1877
Hi @lhoestq Thanks, that sounds nice. Can you explain where the issue of the double memory may arise? Also, why is the existing `concatenate_datasets` not sufficient for this purpose?
Allow concatenation of both in-memory and on-disk datasets
This is a prerequisite for the addition of the `add_item` feature (see #1870). Currently there is one assumption that we would need to change: a dataset is either fully in memory (dataset._data_files is empty), or the dataset can be reloaded from disk (using the dataset._data_files). This assumption is used for pickl...
29
Allow concatenation of both in-memory and on-disk datasets This is a prerequisite for the addition of the `add_item` feature (see #1870). Currently there is one assumption that we would need to change: a dataset is either fully in memory (dataset._data_files is empty), or the dataset can be reloaded from disk (using...
[ -0.3921349346637726, 0.10951589047908783, -0.010248284786939621, 0.369924396276474, 0.02555113658308983, 0.16483339667320251, -0.24442538619041443, 0.19942812621593475, -0.18210311233997345, 0.13663962483406067, 0.049568019807338715, 0.46666792035102844, 0.020092438906431198, 0.36172944307...
https://github.com/huggingface/datasets/issues/1877
Hi @lhoestq, Will the `add_item` feature also help with lazy writing (or no caching) during `map`/`filter`?
Allow concatenation of both in-memory and on-disk datasets
This is a prerequisite for the addition of the `add_item` feature (see #1870). Currently there is one assumption that we would need to change: a dataset is either fully in memory (dataset._data_files is empty), or the dataset can be reloaded from disk (using the dataset._data_files). This assumption is used for pickl...
16
Allow concatenation of both in-memory and on-disk datasets This is a prerequisite for the addition of the `add_item` feature (see #1870). Currently there is one assumption that we would need to change: a dataset is either fully in memory (dataset._data_files is empty), or the dataset can be reloaded from disk (using...
[ -0.47655874490737915, 0.06083659827709198, -0.07072305679321289, 0.052182652056217194, 0.07561103999614716, 0.015053540468215942, -0.22261087596416473, 0.3435710370540619, 0.07333220541477203, 0.08777456730604172, 0.02977297455072403, 0.6137644052505493, -0.01331658847630024, 0.47291123867...
https://github.com/huggingface/datasets/issues/1877
> Can you explain where the issue of the double memory may arise? We have to keep each block (in-memory vs memory mapped) separated in order to be able to reload them with pickle. On the other hand we also need to have the full table from mixed in-memory and memory mapped data in order to iterate or extract data co...
Allow concatenation of both in-memory and on-disk datasets
This is a prerequisite for the addition of the `add_item` feature (see #1870). Currently there is one assumption that we would need to change: a dataset is either fully in memory (dataset._data_files is empty), or the dataset can be reloaded from disk (using the dataset._data_files). This assumption is used for pickl...
188
Allow concatenation of both in-memory and on-disk datasets This is a prerequisite for the addition of the `add_item` feature (see #1870). Currently there is one assumption that we would need to change: a dataset is either fully in memory (dataset._data_files is empty), or the dataset can be reloaded from disk (using...
[ -0.4205480217933655, 0.11777955293655396, -0.013511057943105698, 0.282938152551651, 0.07213005423545837, 0.09398015588521957, -0.14943663775920868, 0.2320159524679184, -0.1620396077632904, 0.1522655189037323, 0.020632945001125336, 0.5102050304412842, -0.024801410734653473, 0.35775241255760...
https://github.com/huggingface/datasets/issues/1876
Thanks for reporting ! This is due to the changes made in the data files in the multiwoz repo: https://github.com/budzianowski/multiwoz/pull/59 I'm opening a PR to update the checksums of the data files.
load_dataset("multi_woz_v22") NonMatchingChecksumError
Hi, it seems that loading the multi_woz_v22 dataset gives a NonMatchingChecksumError. To reproduce: `dataset = load_dataset('multi_woz_v22','v2.2_active_only',split='train')` This will give the following error: ``` raise NonMatchingChecksumError(error_msg + str(bad_urls)) datasets.utils.info_utils.N...
32
load_dataset("multi_woz_v22") NonMatchingChecksumError Hi, it seems that loading the multi_woz_v22 dataset gives a NonMatchingChecksumError. To reproduce: `dataset = load_dataset('multi_woz_v22','v2.2_active_only',split='train')` This will give the following error: ``` raise NonMatchingChecksumErr...
[ -0.22443658113479614, 0.17647062242031097, -0.028719555586576462, 0.14957265555858612, 0.1895725280046463, 0.0018985792994499207, 0.3650577962398529, 0.4820294976234436, 0.25148963928222656, 0.16660648584365845, -0.09703469276428223, 0.17815923690795898, -0.08224464952945709, 0.09920148551...
https://github.com/huggingface/datasets/issues/1876
I just merged the fix. It will be available in the new release of `datasets` later today. You'll be able to get the new version with ``` pip install --upgrade datasets ```
load_dataset("multi_woz_v22") NonMatchingChecksumError
Hi, it seems that loading the multi_woz_v22 dataset gives a NonMatchingChecksumError. To reproduce: `dataset = load_dataset('multi_woz_v22','v2.2_active_only',split='train')` This will give the following error: ``` raise NonMatchingChecksumError(error_msg + str(bad_urls)) datasets.utils.info_utils.N...
32
load_dataset("multi_woz_v22") NonMatchingChecksumError Hi, it seems that loading the multi_woz_v22 dataset gives a NonMatchingChecksumError. To reproduce: `dataset = load_dataset('multi_woz_v22','v2.2_active_only',split='train')` This will give the following error: ``` raise NonMatchingChecksumErr...
[ -0.22443658113479614, 0.17647062242031097, -0.028719555586576462, 0.14957265555858612, 0.1895725280046463, 0.0018985792994499207, 0.3650577962398529, 0.4820294976234436, 0.25148963928222656, 0.16660648584365845, -0.09703469276428223, 0.17815923690795898, -0.08224464952945709, 0.09920148551...
https://github.com/huggingface/datasets/issues/1876
Hi, I still meet the error when loading the datasets after upgradeing datasets. raise NonMatchingChecksumError(error_msg + str(bad_urls)) datasets.utils.info_utils.NonMatchingChecksumError: Checksums didn't match for dataset source files: ['https://github.com/budzianowski/multiwoz/raw/master/data/MultiWOZ_2.2/dial...
load_dataset("multi_woz_v22") NonMatchingChecksumError
Hi, it seems that loading the multi_woz_v22 dataset gives a NonMatchingChecksumError. To reproduce: `dataset = load_dataset('multi_woz_v22','v2.2_active_only',split='train')` This will give the following error: ``` raise NonMatchingChecksumError(error_msg + str(bad_urls)) datasets.utils.info_utils.N...
27
load_dataset("multi_woz_v22") NonMatchingChecksumError Hi, it seems that loading the multi_woz_v22 dataset gives a NonMatchingChecksumError. To reproduce: `dataset = load_dataset('multi_woz_v22','v2.2_active_only',split='train')` This will give the following error: ``` raise NonMatchingChecksumErr...
[ -0.22443658113479614, 0.17647062242031097, -0.028719555586576462, 0.14957265555858612, 0.1895725280046463, 0.0018985792994499207, 0.3650577962398529, 0.4820294976234436, 0.25148963928222656, 0.16660648584365845, -0.09703469276428223, 0.17815923690795898, -0.08224464952945709, 0.09920148551...
https://github.com/huggingface/datasets/issues/1876
This must be related to https://github.com/budzianowski/multiwoz/pull/72 Those files have changed, let me update the checksums for this dataset. For now you can use `ignore_verifications=True` in `load_dataset` to skip the checksum verification.
load_dataset("multi_woz_v22") NonMatchingChecksumError
Hi, it seems that loading the multi_woz_v22 dataset gives a NonMatchingChecksumError. To reproduce: `dataset = load_dataset('multi_woz_v22','v2.2_active_only',split='train')` This will give the following error: ``` raise NonMatchingChecksumError(error_msg + str(bad_urls)) datasets.utils.info_utils.N...
31
load_dataset("multi_woz_v22") NonMatchingChecksumError Hi, it seems that loading the multi_woz_v22 dataset gives a NonMatchingChecksumError. To reproduce: `dataset = load_dataset('multi_woz_v22','v2.2_active_only',split='train')` This will give the following error: ``` raise NonMatchingChecksumErr...
[ -0.22443658113479614, 0.17647062242031097, -0.028719555586576462, 0.14957265555858612, 0.1895725280046463, 0.0018985792994499207, 0.3650577962398529, 0.4820294976234436, 0.25148963928222656, 0.16660648584365845, -0.09703469276428223, 0.17815923690795898, -0.08224464952945709, 0.09920148551...
https://github.com/huggingface/datasets/issues/1872
Hi ! Indeed if you add a column to a formatted dataset, then the new dataset gets a new formatting in which: ``` new formatted columns = (all columns - previously unformatted columns) ``` Therefore the new column is going to be formatted using the `torch` formatting. If you want your new column to be unformatted...
Adding a new column to the dataset after set_format was called
Hi, thanks for the nice library. I'm in the process of creating a custom dataset, which has a mix of tensors and lists of strings. I stumbled upon an error and want to know if its a problem on my side. I load some lists of strings and integers, then call `data.set_format("torch", columns=["some_integer_column1"...
67
Adding a new column to the dataset after set_format was called Hi, thanks for the nice library. I'm in the process of creating a custom dataset, which has a mix of tensors and lists of strings. I stumbled upon an error and want to know if its a problem on my side. I load some lists of strings and integers, th...
[ -0.16383753716945648, -0.17487572133541107, -0.04017322510480881, -0.049234017729759216, 0.4729720950126648, 0.26253455877304077, 0.6921061873435974, 0.41775843501091003, 0.1687507927417755, -0.2805865705013275, 0.14210663735866547, 0.3377908170223236, -0.23404023051261902, -0.025900427252...
https://github.com/huggingface/datasets/issues/1872
Ok cool :) Also I just did a PR to mention this behavior in the documentation
Adding a new column to the dataset after set_format was called
Hi, thanks for the nice library. I'm in the process of creating a custom dataset, which has a mix of tensors and lists of strings. I stumbled upon an error and want to know if its a problem on my side. I load some lists of strings and integers, then call `data.set_format("torch", columns=["some_integer_column1"...
16
Adding a new column to the dataset after set_format was called Hi, thanks for the nice library. I'm in the process of creating a custom dataset, which has a mix of tensors and lists of strings. I stumbled upon an error and want to know if its a problem on my side. I load some lists of strings and integers, th...
[ -0.16383753716945648, -0.17487572133541107, -0.04017322510480881, -0.049234017729759216, 0.4729720950126648, 0.26253455877304077, 0.6921061873435974, 0.41775843501091003, 0.1687507927417755, -0.2805865705013275, 0.14210663735866547, 0.3377908170223236, -0.23404023051261902, -0.025900427252...
https://github.com/huggingface/datasets/issues/1867
Hi @alejandrocros it looks like an incompatibility with the current Trainer @sgugger Indeed currently the Trainer of `transformers` doesn't support a dataset with a transform It looks like it comes from this line: https://github.com/huggingface/transformers/blob/f51188cbe74195c14c5b3e2e8f10c2f435f9751a/src/transfo...
ERROR WHEN USING SET_TRANSFORM()
Hi, I'm trying to use dataset.set_transform(encode) as @lhoestq told me in this issue: https://github.com/huggingface/datasets/issues/1825#issuecomment-774202797 However, when I try to use Trainer from transformers with such dataset, it throws an error: ``` TypeError: __init__() missing 1 required positional arg...
139
ERROR WHEN USING SET_TRANSFORM() Hi, I'm trying to use dataset.set_transform(encode) as @lhoestq told me in this issue: https://github.com/huggingface/datasets/issues/1825#issuecomment-774202797 However, when I try to use Trainer from transformers with such dataset, it throws an error: ``` TypeError: __init__...
[ -0.18261897563934326, -0.27325117588043213, 0.13930322229862213, 0.18474005162715912, 0.7292688488960266, 0.11970525234937668, 0.6009584665298462, 0.22877633571624756, -0.32278475165367126, 0.054477497935295105, 0.2355116754770279, 0.03332699090242386, -0.08834050595760345, -0.023404855281...
https://github.com/huggingface/datasets/issues/1867
FYI that option can be removed with `remove_unused_columns = False` in your `TrainingArguments`, so there is a workaround @alexvaca0 while the fix in `Trainer` is underway. @lhoestq I think I will just use the line you suggested and if someone is using the columns that are removed in their transform they will need t...
ERROR WHEN USING SET_TRANSFORM()
Hi, I'm trying to use dataset.set_transform(encode) as @lhoestq told me in this issue: https://github.com/huggingface/datasets/issues/1825#issuecomment-774202797 However, when I try to use Trainer from transformers with such dataset, it throws an error: ``` TypeError: __init__() missing 1 required positional arg...
75
ERROR WHEN USING SET_TRANSFORM() Hi, I'm trying to use dataset.set_transform(encode) as @lhoestq told me in this issue: https://github.com/huggingface/datasets/issues/1825#issuecomment-774202797 However, when I try to use Trainer from transformers with such dataset, it throws an error: ``` TypeError: __init__...
[ -0.18261897563934326, -0.27325117588043213, 0.13930322229862213, 0.18474005162715912, 0.7292688488960266, 0.11970525234937668, 0.6009584665298462, 0.22877633571624756, -0.32278475165367126, 0.054477497935295105, 0.2355116754770279, 0.03332699090242386, -0.08834050595760345, -0.023404855281...
https://github.com/huggingface/datasets/issues/1867
I've tried your solutions @sgugger @lhoestq and the good news is that it throws no error. However, TPU training is taking forever, in 1 hour it has only trained 1 batch of 8192 elements, which doesn't make much sense... Is it possible that "on the fly" tokenization of batches is slowing down TPU training to that extent...
ERROR WHEN USING SET_TRANSFORM()
Hi, I'm trying to use dataset.set_transform(encode) as @lhoestq told me in this issue: https://github.com/huggingface/datasets/issues/1825#issuecomment-774202797 However, when I try to use Trainer from transformers with such dataset, it throws an error: ``` TypeError: __init__() missing 1 required positional arg...
57
ERROR WHEN USING SET_TRANSFORM() Hi, I'm trying to use dataset.set_transform(encode) as @lhoestq told me in this issue: https://github.com/huggingface/datasets/issues/1825#issuecomment-774202797 However, when I try to use Trainer from transformers with such dataset, it throws an error: ``` TypeError: __init__...
[ -0.18261897563934326, -0.27325117588043213, 0.13930322229862213, 0.18474005162715912, 0.7292688488960266, 0.11970525234937668, 0.6009584665298462, 0.22877633571624756, -0.32278475165367126, 0.054477497935295105, 0.2355116754770279, 0.03332699090242386, -0.08834050595760345, -0.023404855281...
https://github.com/huggingface/datasets/issues/1867
I don't know what the value of `padding` is in your lines of code pasted above so I can't say for sure. The first batch will be very slow on TPU since it compiles everything, so that's normal (1 hour is long but 8192 elements is also large). Then if your batches are not of the same lengths, it will recompile everything...
ERROR WHEN USING SET_TRANSFORM()
Hi, I'm trying to use dataset.set_transform(encode) as @lhoestq told me in this issue: https://github.com/huggingface/datasets/issues/1825#issuecomment-774202797 However, when I try to use Trainer from transformers with such dataset, it throws an error: ``` TypeError: __init__() missing 1 required positional arg...
92
ERROR WHEN USING SET_TRANSFORM() Hi, I'm trying to use dataset.set_transform(encode) as @lhoestq told me in this issue: https://github.com/huggingface/datasets/issues/1825#issuecomment-774202797 However, when I try to use Trainer from transformers with such dataset, it throws an error: ``` TypeError: __init__...
[ -0.18261897563934326, -0.27325117588043213, 0.13930322229862213, 0.18474005162715912, 0.7292688488960266, 0.11970525234937668, 0.6009584665298462, 0.22877633571624756, -0.32278475165367126, 0.054477497935295105, 0.2355116754770279, 0.03332699090242386, -0.08834050595760345, -0.023404855281...
https://github.com/huggingface/datasets/issues/1867
I have tried now on a GPU and it goes smooth! Amazing feature .set_transform() instead of .map()! Now I can pre-train my model without the hard disk limitation. Thanks for your work all HuggingFace team!! :clap:
ERROR WHEN USING SET_TRANSFORM()
Hi, I'm trying to use dataset.set_transform(encode) as @lhoestq told me in this issue: https://github.com/huggingface/datasets/issues/1825#issuecomment-774202797 However, when I try to use Trainer from transformers with such dataset, it throws an error: ``` TypeError: __init__() missing 1 required positional arg...
36
ERROR WHEN USING SET_TRANSFORM() Hi, I'm trying to use dataset.set_transform(encode) as @lhoestq told me in this issue: https://github.com/huggingface/datasets/issues/1825#issuecomment-774202797 However, when I try to use Trainer from transformers with such dataset, it throws an error: ``` TypeError: __init__...
[ -0.18261897563934326, -0.27325117588043213, 0.13930322229862213, 0.18474005162715912, 0.7292688488960266, 0.11970525234937668, 0.6009584665298462, 0.22877633571624756, -0.32278475165367126, 0.054477497935295105, 0.2355116754770279, 0.03332699090242386, -0.08834050595760345, -0.023404855281...
https://github.com/huggingface/datasets/issues/1867
In the end, to make it work I turned to A-100 gpus instead of TPUS, among other changes. Set_transform doesn't work as expected and slows down training very much even in GPUs, and applying map destroys the disk, as it multiplies by 100 the size of the data passed to it (due to inefficient implementation converting stri...
ERROR WHEN USING SET_TRANSFORM()
Hi, I'm trying to use dataset.set_transform(encode) as @lhoestq told me in this issue: https://github.com/huggingface/datasets/issues/1825#issuecomment-774202797 However, when I try to use Trainer from transformers with such dataset, it throws an error: ``` TypeError: __init__() missing 1 required positional arg...
179
ERROR WHEN USING SET_TRANSFORM() Hi, I'm trying to use dataset.set_transform(encode) as @lhoestq told me in this issue: https://github.com/huggingface/datasets/issues/1825#issuecomment-774202797 However, when I try to use Trainer from transformers with such dataset, it throws an error: ``` TypeError: __init__...
[ -0.18261897563934326, -0.27325117588043213, 0.13930322229862213, 0.18474005162715912, 0.7292688488960266, 0.11970525234937668, 0.6009584665298462, 0.22877633571624756, -0.32278475165367126, 0.054477497935295105, 0.2355116754770279, 0.03332699090242386, -0.08834050595760345, -0.023404855281...
https://github.com/huggingface/datasets/issues/1867
Great comment @alexvaca0 . I think that we could re-open the issue as a reformulation of why it takes so much space to save the arrow. Saving a 1% of oscar corpus takes more thank 600 GB (it breaks when it pass 600GB because it is the free memory that I have at this moment) when the full dataset is 1,3 TB. I have a 1TB...
ERROR WHEN USING SET_TRANSFORM()
Hi, I'm trying to use dataset.set_transform(encode) as @lhoestq told me in this issue: https://github.com/huggingface/datasets/issues/1825#issuecomment-774202797 However, when I try to use Trainer from transformers with such dataset, it throws an error: ``` TypeError: __init__() missing 1 required positional arg...
93
ERROR WHEN USING SET_TRANSFORM() Hi, I'm trying to use dataset.set_transform(encode) as @lhoestq told me in this issue: https://github.com/huggingface/datasets/issues/1825#issuecomment-774202797 However, when I try to use Trainer from transformers with such dataset, it throws an error: ``` TypeError: __init__...
[ -0.18261897563934326, -0.27325117588043213, 0.13930322229862213, 0.18474005162715912, 0.7292688488960266, 0.11970525234937668, 0.6009584665298462, 0.22877633571624756, -0.32278475165367126, 0.054477497935295105, 0.2355116754770279, 0.03332699090242386, -0.08834050595760345, -0.023404855281...
https://github.com/huggingface/datasets/issues/1859
Hi @corticalstack ! Thanks for reporting. Indeed in the recent versions of Faiss we must use `getDevice` to check if the index in on GPU. I'm opening a PR
Error "in void don't know how to serialize this type of index" when saving index to disk when device=0 (GPU)
Error serializing faiss index. Error as follows: `Error in void faiss::write_index(const faiss::Index*, faiss::IOWriter*) at /home/conda/feedstock_root/build_artifacts/faiss-split_1612472484670/work/faiss/impl/index_write.cpp:453: don't know how to serialize this type of index` Note: `torch.cuda.is_availabl...
29
Error "in void don't know how to serialize this type of index" when saving index to disk when device=0 (GPU) Error serializing faiss index. Error as follows: `Error in void faiss::write_index(const faiss::Index*, faiss::IOWriter*) at /home/conda/feedstock_root/build_artifacts/faiss-split_1612472484670/work/faiss/...
[ -0.07123847305774689, -0.3793421983718872, -0.012639451771974564, 0.12429007142782211, 0.32503005862236023, 0.14406675100326538, 0.30142107605934143, 0.5358148217201233, 0.47758638858795166, 0.3618175983428955, 0.068253293633461, -0.03206411749124527, 0.17395083606243134, -0.08485031872987...
https://github.com/huggingface/datasets/issues/1859
I fixed this issue. It should work fine now. Feel free to try it out by installing `datasets` from source. Otherwise you can wait for the next release of `datasets` (in a few days)
Error "in void don't know how to serialize this type of index" when saving index to disk when device=0 (GPU)
Error serializing faiss index. Error as follows: `Error in void faiss::write_index(const faiss::Index*, faiss::IOWriter*) at /home/conda/feedstock_root/build_artifacts/faiss-split_1612472484670/work/faiss/impl/index_write.cpp:453: don't know how to serialize this type of index` Note: `torch.cuda.is_availabl...
34
Error "in void don't know how to serialize this type of index" when saving index to disk when device=0 (GPU) Error serializing faiss index. Error as follows: `Error in void faiss::write_index(const faiss::Index*, faiss::IOWriter*) at /home/conda/feedstock_root/build_artifacts/faiss-split_1612472484670/work/faiss/...
[ -0.2384788691997528, -0.24059055745601654, -0.038640569895505905, 0.1195869892835617, 0.3427583575248718, 0.15249226987361908, 0.34448951482772827, 0.5221386551856995, 0.4608199894428253, 0.2513043284416199, -0.07914189994335175, 0.14128589630126953, 0.12161272764205933, -0.057059057056903...
https://github.com/huggingface/datasets/issues/1859
Thanks for such a quick fix and merge to master, pip installed git master, tested all OK
Error "in void don't know how to serialize this type of index" when saving index to disk when device=0 (GPU)
Error serializing faiss index. Error as follows: `Error in void faiss::write_index(const faiss::Index*, faiss::IOWriter*) at /home/conda/feedstock_root/build_artifacts/faiss-split_1612472484670/work/faiss/impl/index_write.cpp:453: don't know how to serialize this type of index` Note: `torch.cuda.is_availabl...
17
Error "in void don't know how to serialize this type of index" when saving index to disk when device=0 (GPU) Error serializing faiss index. Error as follows: `Error in void faiss::write_index(const faiss::Index*, faiss::IOWriter*) at /home/conda/feedstock_root/build_artifacts/faiss-split_1612472484670/work/faiss/...
[ -0.11467615514993668, -0.33902156352996826, -0.02119097113609314, 0.11056134104728699, 0.3648001253604889, 0.15794029831886292, 0.29336315393447876, 0.5287508368492126, 0.5046117901802063, 0.3331742584705353, 0.019372709095478058, 0.07134965807199478, 0.11176559329032898, -0.06300191581249...
https://github.com/huggingface/datasets/issues/1857
Hi ! We're in the process of switching the community datasets to git repos, exactly like what we're doing for models. You can find an example here: https://huggingface.co/datasets/lhoestq/custom_squad/tree/main We'll update the CLI in the coming days and do a new release :) Also cc @julien-c maybe we can make i...
Unable to upload "community provided" dataset - 400 Client Error
Hi, i'm trying to a upload a dataset as described [here](https://huggingface.co/docs/datasets/v1.2.0/share_dataset.html#sharing-a-community-provided-dataset). This is what happens: ``` $ datasets-cli login $ datasets-cli upload_dataset my_dataset About to upload file /path/to/my_dataset/dataset_infos.json to S3...
54
Unable to upload "community provided" dataset - 400 Client Error Hi, i'm trying to a upload a dataset as described [here](https://huggingface.co/docs/datasets/v1.2.0/share_dataset.html#sharing-a-community-provided-dataset). This is what happens: ``` $ datasets-cli login $ datasets-cli upload_dataset my_dataset...
[ -0.09157092869281769, -0.03636619448661804, 0.03441682457923889, 0.06724180281162262, 0.3649703860282898, -0.04928518086671829, 0.1734047532081604, 0.0044843535870313644, -0.2230454981327057, -0.14681154489517212, -0.14883771538734436, -0.020599722862243652, 0.005085591226816177, 0.3581643...
https://github.com/huggingface/datasets/issues/1856
Hi ! This issue may be related to #996 This comes probably from the Quota Exceeded error from Google Drive. Can you try again tomorrow and see if you still have the error ? On my side I didn't get any error today with `load_dataset("amazon_polarity")`
load_dataset("amazon_polarity") NonMatchingChecksumError
Hi, it seems that loading the amazon_polarity dataset gives a NonMatchingChecksumError. To reproduce: ``` load_dataset("amazon_polarity") ``` This will give the following error: ``` --------------------------------------------------------------------------- NonMatchingChecksumError Traceback ...
45
load_dataset("amazon_polarity") NonMatchingChecksumError Hi, it seems that loading the amazon_polarity dataset gives a NonMatchingChecksumError. To reproduce: ``` load_dataset("amazon_polarity") ``` This will give the following error: ``` ----------------------------------------------------------------------...
[ -0.14463502168655396, 0.11810770630836487, -0.12130692601203918, 0.24109309911727905, 0.12806236743927002, -0.003592096269130707, 0.34435251355171204, 0.0652998760342598, 0.2865489423274994, 0.23939195275306702, 0.02812202274799347, -0.06478912383317947, 0.009715661406517029, 0.15067994594...