hash
stringlengths
40
40
authorName
stringclasses
42 values
authorEmail
stringclasses
41 values
date
timestamp[ms]date
2021-07-26 09:52:55
2025-07-18 10:19:56
subject
stringlengths
11
116
diff
stringlengths
0
987k
673fd5b2cdce29644027cea1c3e60d75f52a48cb
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-03-17T10:43:15
feat: 🎸 reduce log level to INFO in prod (#954)
diff --git a/chart/env/prod.yaml b/chart/env/prod.yaml index abbcf823..77bd813b 100644 --- a/chart/env/prod.yaml +++ b/chart/env/prod.yaml @@ -71 +71 @@ common: - logLevel: "DEBUG" + logLevel: "INFO"
d597db6aaa417647681f1991ebef03189570760a
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-03-17T10:32:39
feat: 🎸 increase the timeout to Hub from 200ms to 1.5s (#952)
diff --git a/chart/env/prod.yaml b/chart/env/prod.yaml index 66b202df..abbcf823 100644 --- a/chart/env/prod.yaml +++ b/chart/env/prod.yaml @@ -146,0 +147,2 @@ admin: + # the timeout in seconds for the requests to the Hugging Face Hub. + hfTimeoutSeconds: "1.5" @@ -165,0 +168,2 @@ api: + # the timeout in seconds for ...
9b7f5ab80771a1979dae0086fd02e5b4abba2bbd
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-03-17T10:23:44
feat: 🎸 add logs in case of error in /webhook (#951)
diff --git a/chart/env/prod.yaml b/chart/env/prod.yaml index 6ef19d95..66b202df 100644 --- a/chart/env/prod.yaml +++ b/chart/env/prod.yaml @@ -71 +71 @@ common: - logLevel: "INFO" + logLevel: "DEBUG" diff --git a/services/api/src/api/routes/webhook.py b/services/api/src/api/routes/webhook.py index caa9b17e..8c5498b6 ...
a2b67d629c0e7ba85851c7e7cea05af76d4e52c6
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-03-16T15:25:40
Try to fix the e2e tests in the CI (#944)
diff --git a/.github/workflows/_e2e_tests.yml b/.github/workflows/_e2e_tests.yml index 4112de64..90852c97 100644 --- a/.github/workflows/_e2e_tests.yml +++ b/.github/workflows/_e2e_tests.yml @@ -27,2 +27,9 @@ jobs: - WORKER_SLEEP_TIME: "1" - # hard coded, see e2e/tests/fixtures/hub.py + ADMIN...
1d917ebbc3e895103a7fb04bb1ca8c515baf7b4a
Andrea Francis Soria Jimenez
andrea@huggingface.co
2023-03-16T14:34:41
dataset-level split names from dataset info (#937)
diff --git a/libs/libcommon/src/libcommon/config.py b/libs/libcommon/src/libcommon/config.py index 583bf2c1..a511b792 100644 --- a/libs/libcommon/src/libcommon/config.py +++ b/libs/libcommon/src/libcommon/config.py @@ -117,0 +118,4 @@ class ProcessingGraphConfig: + "dataset-split-names-from-dataset-info": { ...
648f5114df5fc7879d13e60f088ef6839dab304a
Andrea Francis Soria Jimenez
andrea@huggingface.co
2023-03-16T14:01:57
dataset-level split names from streaming (#936)
diff --git a/libs/libcommon/src/libcommon/config.py b/libs/libcommon/src/libcommon/config.py index ca702637..583bf2c1 100644 --- a/libs/libcommon/src/libcommon/config.py +++ b/libs/libcommon/src/libcommon/config.py @@ -113,0 +114,4 @@ class ProcessingGraphConfig: + "dataset-split-names-from-streaming": { + ...
e1e602f66c1d31d2438b145c60a05ea92ecec1d2
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-03-16T13:35:22
ci: 🎡 use the public key of the CI Hub (#941)
diff --git a/.github/workflows/_e2e_tests.yml b/.github/workflows/_e2e_tests.yml index 75e4bf11..4112de64 100644 --- a/.github/workflows/_e2e_tests.yml +++ b/.github/workflows/_e2e_tests.yml @@ -75 +75,2 @@ jobs: - API_HF_JWT_PUBLIC_KEY_URL: "https://huggingface.co/api/keys/jwt" + # JWT: it's not test...
caca20fbc0dbe799dd83f0c89f73a6175990aa93
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-03-16T10:17:05
feat: 🎸 revert log level to INFO (#940)
diff --git a/chart/env/prod.yaml b/chart/env/prod.yaml index 66b202df..6ef19d95 100644 --- a/chart/env/prod.yaml +++ b/chart/env/prod.yaml @@ -71 +71 @@ common: - logLevel: "DEBUG" + logLevel: "INFO"
d6d5a64996230880d45c5d34fd19ad2578ff1b69
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-03-16T09:39:13
Increase logs to debug jwt issue (#939)
diff --git a/chart/env/prod.yaml b/chart/env/prod.yaml index 6ef19d95..66b202df 100644 --- a/chart/env/prod.yaml +++ b/chart/env/prod.yaml @@ -71 +71 @@ common: - logLevel: "INFO" + logLevel: "DEBUG" diff --git a/services/api/src/api/authentication.py b/services/api/src/api/authentication.py index 029276ca..fadabe51 ...
cd58e8e26ce51016258eb030f1b7437219b2f3cb
Quentin Lhoest
42851186+lhoestq@users.noreply.github.com
2023-03-15T11:03:47
Config-level parquet (#931)
diff --git a/chart/env/prod.yaml b/chart/env/prod.yaml index 7c5571e4..6ef19d95 100644 --- a/chart/env/prod.yaml +++ b/chart/env/prod.yaml @@ -278 +278 @@ workers: - workerOnlyJobTypes: "/parquet" + workerOnlyJobTypes: "dataset-parquet,config-parquet" diff --git a/chart/values.yaml b/chart/values.yaml index 0deb1...
2ead70d394f785db4977a19a6d1dff11df3285c6
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-03-15T09:54:15
fix: 🐛 take the algorithm into account in config (#933)
diff --git a/services/api/src/api/config.py b/services/api/src/api/config.py index 1ebfb379..45e31c0e 100644 --- a/services/api/src/api/config.py +++ b/services/api/src/api/config.py @@ -66,0 +67 @@ class ApiConfig: + hf_jwt_algorithm=env.str(name="HF_JWT_ALGORITHM", default=API_HF_JWT_ALGORITHM),
e3fb17cf1b00e42acd6d8dc32fc5b33b8c56a95d
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-03-15T09:46:10
refactor: 💡 fix type of the public key: str, not Any (#932)
diff --git a/services/api/src/api/authentication.py b/services/api/src/api/authentication.py index 3ab735e3..029276ca 100644 --- a/services/api/src/api/authentication.py +++ b/services/api/src/api/authentication.py @@ -5 +5 @@ import logging -from typing import Any, Literal, Optional +from typing import Literal, Option...
b1f7d0003bbad349bd6def7acf53b5c4eaeeb036
Andrea Francis Soria Jimenez
andrea@huggingface.co
2023-03-14T15:37:32
Remove worker version (#927)
diff --git a/jobs/mongodb_migration/src/mongodb_migration/collector.py b/jobs/mongodb_migration/src/mongodb_migration/collector.py index 5a6feeb7..ec2d79f7 100644 --- a/jobs/mongodb_migration/src/mongodb_migration/collector.py +++ b/jobs/mongodb_migration/src/mongodb_migration/collector.py @@ -28,0 +29,3 @@ from mongod...
e58240944787657439dadeb256fcf2a8eb7134fc
Quentin Lhoest
42851186+lhoestq@users.noreply.github.com
2023-03-14T15:36:10
Config-level size (#926)
diff --git a/chart/env/prod.yaml b/chart/env/prod.yaml index 54f1b731..7c5571e4 100644 --- a/chart/env/prod.yaml +++ b/chart/env/prod.yaml @@ -323 +323 @@ workers: - workerOnlyJobTypes: "/sizes" + workerOnlyJobTypes: "config-size,dataset-size" diff --git a/chart/values.yaml b/chart/values.yaml index cdc95256..0de...
57b49e14f051ca0ef108a28f83554b4c405973ff
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-03-14T14:48:52
Fix jwt decoding (#929)
diff --git a/services/api/src/api/app.py b/services/api/src/api/app.py index 96ccf8d8..5d594000 100644 --- a/services/api/src/api/app.py +++ b/services/api/src/api/app.py @@ -75,0 +76 @@ def create_app_with_config(app_config: AppConfig, endpoint_config: EndpointConfi + hf_jwt_algorithm=app_config.api.hf_...
e24942d637cd6d46116caf73c67af670ba1ba756
Andrea Francis Soria Jimenez
andrea@huggingface.co
2023-03-13T20:34:14
Change worker_version to int job_runner_version (#916)
diff --git a/jobs/mongodb_migration/src/mongodb_migration/collector.py b/jobs/mongodb_migration/src/mongodb_migration/collector.py index fa9fe261..5a6feeb7 100644 --- a/jobs/mongodb_migration/src/mongodb_migration/collector.py +++ b/jobs/mongodb_migration/src/mongodb_migration/collector.py @@ -25,0 +26,3 @@ from mongod...
958ef26a19991b01c09dba78e2456780a09eccd0
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-03-13T19:48:43
Fix access to gated datasets, and forbid access to private datasets! (#925)
diff --git a/libs/libcommon/src/libcommon/dataset.py b/libs/libcommon/src/libcommon/dataset.py index 362bc3bd..83d3e642 100644 --- a/libs/libcommon/src/libcommon/dataset.py +++ b/libs/libcommon/src/libcommon/dataset.py @@ -103,0 +104,5 @@ class GatedExtraFieldsError(DatasetError): +DOES_NOT_EXIST_OR_PRIVATE_DATASET_ERR...
1cb8049f1a4f3bd2ba1a0a00c90d50c3ffd66734
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-03-13T19:36:01
Add jwt to bypass auth (#898)
diff --git a/.github/workflows/_e2e_tests.yml b/.github/workflows/_e2e_tests.yml index 952bf02c..75e4bf11 100644 --- a/.github/workflows/_e2e_tests.yml +++ b/.github/workflows/_e2e_tests.yml @@ -74,0 +75,2 @@ jobs: + API_HF_JWT_PUBLIC_KEY_URL: "https://huggingface.co/api/keys/jwt" + API_HF_JWT_ALGORIT...
d9545543b881e0f1232f0c1ea6c2f6217272ac62
Quentin Lhoest
42851186+lhoestq@users.noreply.github.com
2023-03-13T18:00:41
Don't rebuild dev images (#923)
diff --git a/.github/workflows/_e2e_tests.yml b/.github/workflows/_e2e_tests.yml index c6ab2b65..952bf02c 100644 --- a/.github/workflows/_e2e_tests.yml +++ b/.github/workflows/_e2e_tests.yml @@ -9 +9 @@ env: - poetry-version: 1.3.2 + poetry-version: 1.4.0 diff --git a/.github/workflows/_quality-python.yml b/.github/w...
ec38d5f2378c9c7e99aa95b9b79bf24e0b63cb6d
Quentin Lhoest
42851186+lhoestq@users.noreply.github.com
2023-03-13T09:52:30
Add partial cache entries for fan-in jobs (#909)
diff --git a/jobs/mongodb_migration/src/mongodb_migration/collector.py b/jobs/mongodb_migration/src/mongodb_migration/collector.py index 18857e50..fa9fe261 100644 --- a/jobs/mongodb_migration/src/mongodb_migration/collector.py +++ b/jobs/mongodb_migration/src/mongodb_migration/collector.py @@ -22,0 +23,3 @@ from mongod...
745a83b5d9c9f43465e0950da69396c6faa39b96
Quentin Lhoest
42851186+lhoestq@users.noreply.github.com
2023-03-10T18:40:47
Fix gated (gated=True -> gated="auto") (#920)
diff --git a/e2e/tests/fixtures/hub.py b/e2e/tests/fixtures/hub.py index 5f6a3af8..4d960ac7 100644 --- a/e2e/tests/fixtures/hub.py +++ b/e2e/tests/fixtures/hub.py @@ -8 +8,11 @@ from contextlib import contextmanager, suppress -from typing import Any, Callable, Iterator, Literal, Mapping, Optional, TypedDict +from typin...
a80ba4ff6801ee38df3137c76798986ac605f103
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-03-10T11:37:41
Revert "feat: 🎸 change log level to DEBUG (#917)" (#918)
diff --git a/chart/env/prod.yaml b/chart/env/prod.yaml index 7323baca..54f1b731 100644 --- a/chart/env/prod.yaml +++ b/chart/env/prod.yaml @@ -71 +71 @@ common: - logLevel: "DEBUG" + logLevel: "INFO" diff --git a/libs/libcommon/src/libcommon/log.py b/libs/libcommon/src/libcommon/log.py index e5b99911..c531c5dd 100644...
6643f943619a6b8c2b4449c12eafc883db1873fe
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-03-10T10:13:15
feat: 🎸 change log level to DEBUG (#917)
diff --git a/chart/env/prod.yaml b/chart/env/prod.yaml index 54f1b731..7323baca 100644 --- a/chart/env/prod.yaml +++ b/chart/env/prod.yaml @@ -71 +71 @@ common: - logLevel: "INFO" + logLevel: "DEBUG" diff --git a/libs/libcommon/src/libcommon/log.py b/libs/libcommon/src/libcommon/log.py index c531c5dd..e5b99911 100644...
1e5064e2ef711741bdf7ec579898ce63495a5c43
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-03-09T18:59:54
Add some profiling (#915)
diff --git a/services/api/src/api/authentication.py b/services/api/src/api/authentication.py index d7303b0c..e2b06d19 100644 --- a/services/api/src/api/authentication.py +++ b/services/api/src/api/authentication.py @@ -3,0 +4 @@ +import logging @@ -10,0 +12 @@ from starlette.requests import Request +from api.prometheus...
11ea7d077e9e34a7d709a4bfd8dbbd78bdcb2107
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-03-09T16:41:02
Add "context" label to filter the metrics on the endpoint (#914)
diff --git a/.github/workflows/_e2e_tests.yml b/.github/workflows/_e2e_tests.yml index cdc7ea4d..c6ab2b65 100644 --- a/.github/workflows/_e2e_tests.yml +++ b/.github/workflows/_e2e_tests.yml @@ -73,0 +74 @@ jobs: + API_HF_TIMEOUT_SECONDS: "10" diff --git a/services/admin/Makefile b/services/admin/Makefile inde...
077f369eb31f77a9ccd5519f03c6196b509e7db1
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-03-09T10:10:19
Instrument api service (#911)
diff --git a/e2e/tests/test_21_api_metrics.py b/e2e/tests/test_21_api_metrics.py index 67cadb1a..a3f88ab9 100644 --- a/e2e/tests/test_21_api_metrics.py +++ b/e2e/tests/test_21_api_metrics.py @@ -23 +23,6 @@ def test_metrics() -> None: - metrics = {line.split(" ")[0]: float(line.split(" ")[1]) for line in lines if li...
98182c29720554abb51ec13b6dcdf38926cf2c5a
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-03-08T15:48:05
Add timeout to calls to hub (#910)
diff --git a/chart/templates/services/api/_container.tpl b/chart/templates/services/api/_container.tpl index c86609ac..40214e51 100644 --- a/chart/templates/services/api/_container.tpl +++ b/chart/templates/services/api/_container.tpl @@ -15,2 +15,2 @@ - - name: API_HF_AUTH_TIMEOUT_SECONDS - value: {{ .Values.api.h...
d95b9716587ad862a17b1c40937ecea2e1c4a24f
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-03-08T09:14:52
feat: 🎸 add timeout when requesting Hub authentication check (#896)
diff --git a/chart/templates/services/api/_container.tpl b/chart/templates/services/api/_container.tpl index 196695fc..c86609ac 100644 --- a/chart/templates/services/api/_container.tpl +++ b/chart/templates/services/api/_container.tpl @@ -14,0 +15,2 @@ + - name: API_HF_AUTH_TIMEOUT_SECONDS + value: {{ .Values.api.h...
1b3c02007caa6ad285de5419a9132af9bb3eba58
Andrea Francis Soria Jimenez
andrea@huggingface.co
2023-03-07T15:52:13
Renaming duplicated name (#906)
diff --git a/chart/env/prod.yaml b/chart/env/prod.yaml index 2f1b18e6..54f1b731 100644 --- a/chart/env/prod.yaml +++ b/chart/env/prod.yaml @@ -306 +306 @@ workers: - deployName: "split-names-from-streaming" + deployName: "split-names-from-dataset-info" @@ -308 +308 @@ workers: - workerOnlyJobTypes: "/split-nam...
d148931e8462b6e48f0475c3f015d8e7b72df72a
Andrea Francis Soria Jimenez
andrea@huggingface.co
2023-03-07T15:37:46
Adding deploy for missing JobRunners (#904)
diff --git a/chart/env/prod.yaml b/chart/env/prod.yaml index b253edaf..2f1b18e6 100644 --- a/chart/env/prod.yaml +++ b/chart/env/prod.yaml @@ -216 +216 @@ workers: - deployName: "split-names" + deployName: "split-names-from-streaming" @@ -218 +218 @@ workers: - workerOnlyJobTypes: "/split-names" + workerOnl...
727d11d817e08a7ee10a5fd3a3ddaab1495f7b3b
Rémy
remy.trompier@gmail.com
2023-03-07T14:51:03
fix: chart dependencies (#905)
diff --git a/chart/.gitignore b/chart/.gitignore deleted file mode 100644 index 1326c841..00000000 --- a/chart/.gitignore +++ /dev/null @@ -1,2 +0,0 @@ -# we don't version the Helm dependencies charts -charts/ diff --git a/chart/Chart.lock b/chart/Chart.lock index ea38003d..dd641516 100644 --- a/chart/Chart.lock +++ b/...
4291a0688bf36ce2a8ebb960cbb010ca7a5fa911
Rémy
remy.trompier@gmail.com
2023-03-06T20:56:06
ci: update dependencies before lint (#895)
diff --git a/.github/workflows/cd.yml b/.github/workflows/cd.yml index e8821b61..d2c0f629 100644 --- a/.github/workflows/cd.yml +++ b/.github/workflows/cd.yml @@ -70,0 +71,3 @@ jobs: + - name: Update dependencies + run: helm dependencies update + working-directory: chart diff --git a/.github/workflow...
bccbe848454d20e9479cb360e24d6f3f75e92459
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-03-06T13:06:51
fix: 🐛 ensure the dataset parameter is provided in endpoints (#893)
diff --git a/services/api/src/api/routes/endpoint.py b/services/api/src/api/routes/endpoint.py index 29044b51..84e3e891 100644 --- a/services/api/src/api/routes/endpoint.py +++ b/services/api/src/api/routes/endpoint.py @@ -228,0 +229,4 @@ def create_endpoint( + # for now, dataset is always required in the en...
bb2eb334e3c4c4a8985c201b02a2c35e3cb1c2a2
Rémy
remy.trompier@gmail.com
2023-03-06T10:28:02
feat: allow to use service nodeport & use common chart (#890)
diff --git a/.github/workflows/chart-pr.yml b/.github/workflows/chart-pr.yml index 606db1a5..08c206fe 100644 --- a/.github/workflows/chart-pr.yml +++ b/.github/workflows/chart-pr.yml @@ -15,0 +16,7 @@ jobs: + - name: Tailscale + uses: tailscale/github-action@v1 + with: + authkey: ${{ secrets...
0539fbd1950bfbe89605ddd40db1aaebfc757438
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-03-03T09:42:40
feat: 🎸 add an index to the jobs collection (#888)
diff --git a/libs/libcommon/src/libcommon/queue.py b/libs/libcommon/src/libcommon/queue.py index 79a57eed..b50bd11b 100644 --- a/libs/libcommon/src/libcommon/queue.py +++ b/libs/libcommon/src/libcommon/queue.py @@ -137,0 +138 @@ class Job(Document): + ("priority", "status", "created_at", "namespace", "unicit...
3f74aeb3c8df7e7dfee6db798318c79c666b172a
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-03-02T14:24:32
feat: 🎸 add an index (#883)
diff --git a/libs/libcommon/src/libcommon/queue.py b/libs/libcommon/src/libcommon/queue.py index 0243d36c..79a57eed 100644 --- a/libs/libcommon/src/libcommon/queue.py +++ b/libs/libcommon/src/libcommon/queue.py @@ -137,0 +138 @@ class Job(Document): + ("priority", "status", "created_at", "type", "namespace")...
f13ec97bae4ac886c21402fc6135c7377dd6c56d
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-03-02T14:04:15
feat: 🎸 reduce the requests (and limits) in k8s resources (#886)
diff --git a/chart/env/dev.yaml b/chart/env/dev.yaml index a3cd9aef..57ff300e 100644 --- a/chart/env/dev.yaml +++ b/chart/env/dev.yaml @@ -92,2 +92,2 @@ storageAdmin: - cpu: 100m - memory: "256Mi" + cpu: 50m + memory: "64Mi" @@ -105 +105 @@ reverseProxy: - memory: "256Mi" + memory: "64Mi" ...
f44ee34c07ba9009b847bfb9e16919d46b94a15c
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-03-02T12:44:54
Publish /healthcheck again (#885)
diff --git a/chart/Chart.yaml b/chart/Chart.yaml index 21fe769a..2064a137 100644 --- a/chart/Chart.yaml +++ b/chart/Chart.yaml @@ -21 +21 @@ type: application -version: 1.3.1 +version: 1.4.0 diff --git a/chart/nginx-templates/default.conf.template b/chart/nginx-templates/default.conf.template index 04858d50..3c8d9d89 1...
fb48ed36cd41b13fba88b6b18072faf1bbd1fb62
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-03-02T11:15:17
chore: 🤖 use other nodes for the workers (#884)
diff --git a/chart/env/prod.yaml b/chart/env/prod.yaml index 3efdfed3..36455b12 100644 --- a/chart/env/prod.yaml +++ b/chart/env/prod.yaml @@ -181 +181 @@ workers: - role-datasets-server: "true" + role-datasets-server-worker: "true" @@ -196 +196 @@ workers: - role-datasets-server: "true" + role-data...
405f64c12460df3dbb5bd5918aa6ca1218263a02
Andrea Francis Soria Jimenez
andrea@huggingface.co
2023-03-01T17:47:31
Increase version of workers (#879)
diff --git a/services/worker/src/worker/job_runners/split_names_from_dataset_info.py b/services/worker/src/worker/job_runners/split_names_from_dataset_info.py index 1705c64e..2eb8c100 100644 --- a/services/worker/src/worker/job_runners/split_names_from_dataset_info.py +++ b/services/worker/src/worker/job_runners/split_...
23945ca8189026f17a8cf49164f1b6de0f38c5cf
Andrea Francis Soria Jimenez
andrea@huggingface.co
2023-03-01T16:28:41
Renaming split-names response to splits (#878)
diff --git a/e2e/tests/test_12_splits.py b/e2e/tests/test_12_splits.py index 20d8715d..26017ae7 100644 --- a/e2e/tests/test_12_splits.py +++ b/e2e/tests/test_12_splits.py @@ -78 +78 @@ def test_splits_with_config_using_openapi(status: int, dataset: str, config: str - assert all(split["config"] == config for spli...
b61a1ce1426b665cea4604abcce3fe3daa3b128a
Andrea Francis Soria Jimenez
andrea@huggingface.co
2023-03-01T14:37:43
Endpoint respond by input type (#834)
diff --git a/chart/static-files/openapi.json b/chart/static-files/openapi.json index 356e24a8..e21190e1 100644 --- a/chart/static-files/openapi.json +++ b/chart/static-files/openapi.json @@ -1874 +1874 @@ - "error": "Parameter 'dataset' is required" + "error": "Parameters 'spli...
dae20a72b8c8d923ffefd3cb3130bb948f30c5c9
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-03-01T09:48:03
feat: 🎸 reduce a lot the resources used in production (#874)
diff --git a/chart/env/prod.yaml b/chart/env/prod.yaml index 39cde838..3efdfed3 100644 --- a/chart/env/prod.yaml +++ b/chart/env/prod.yaml @@ -178 +178 @@ workers: - maxJobsPerNamespace: 4 + maxJobsPerNamespace: 20 @@ -182 +182 @@ workers: - replicas: 20 + replicas: 12 @@ -186 +186 @@ workers: - memo...
ae19dfb828415927e331109962018d983f7b3e6e
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-03-01T09:19:01
fix: 🐛 manage duplicates in cache entries migration (#873)
diff --git a/jobs/mongodb_migration/src/mongodb_migration/migrations/_20230216112500_cache_split_names_from_streaming.py b/jobs/mongodb_migration/src/mongodb_migration/migrations/_20230216112500_cache_split_names_from_streaming.py index b1e7774d..e10637ff 100644 --- a/jobs/mongodb_migration/src/mongodb_migration/migrat...
ae635fd0cdd6f773d587384b4e2b2f401c12d6dc
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-02-28T20:09:21
fix: 🐛 set the list of supported job types as a csv string (#871)
diff --git a/chart/Chart.yaml b/chart/Chart.yaml index 14a66117..21fe769a 100644 --- a/chart/Chart.yaml +++ b/chart/Chart.yaml @@ -21 +21 @@ type: application -version: 1.3.0 +version: 1.3.1 diff --git a/chart/env/dev.yaml b/chart/env/dev.yaml index e7ef62d0..a3cd9aef 100644 --- a/chart/env/dev.yaml +++ b/chart/env/dev...
d034d83cd8b08e29f8f77e1930d793ed350a55e7
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-02-28T16:15:25
ci: 🎡 add missing step to get the source code (#869)
diff --git a/.github/workflows/cd.yml b/.github/workflows/cd.yml index e3bfb380..e8821b61 100644 --- a/.github/workflows/cd.yml +++ b/.github/workflows/cd.yml @@ -86,0 +87,2 @@ jobs: + - name: Checkout sources + uses: actions/checkout@v3
7e9aa1dd89ff19c0d866987cf9e222a5fbb15f0d
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-02-28T14:48:17
Add doc, simplify docker, update chart (#868)
diff --git a/chart/Chart.yaml b/chart/Chart.yaml index 218b9243..14a66117 100644 --- a/chart/Chart.yaml +++ b/chart/Chart.yaml @@ -21 +21 @@ type: application -version: 1.2.0 +version: 1.3.0 diff --git a/chart/templates/_envWorker.tpl b/chart/templates/_envWorker.tpl index 22a93428..11b01b55 100644 --- a/chart/template...
d55cbcc6f92564f042a4dafdbb3bb5e919099a15
Quentin Lhoest
42851186+lhoestq@users.noreply.github.com
2023-02-28T09:49:12
Reorganize executor (#850)
diff --git a/jobs/mongodb_migration/poetry.lock b/jobs/mongodb_migration/poetry.lock index d5902509..ab45a3bb 100644 --- a/jobs/mongodb_migration/poetry.lock +++ b/jobs/mongodb_migration/poetry.lock @@ -562,0 +563 @@ pymongo = {version = "^3.13.0", extras = ["srv"]} +pytz = "^2020.1" @@ -1284,0 +1286,12 @@ cli = ["clic...
912199fe63265dd67d6f34bc02e20a087086b92d
Andrea Francis Soria Jimenez
andrea@huggingface.co
2023-02-27T18:51:08
POC: Adding mongo TTL index to Jobs (#851)
diff --git a/libs/libcommon/src/libcommon/constants.py b/libs/libcommon/src/libcommon/constants.py index 7b707218..a9ea4c95 100644 --- a/libs/libcommon/src/libcommon/constants.py +++ b/libs/libcommon/src/libcommon/constants.py @@ -6,0 +7 @@ QUEUE_MONGOENGINE_ALIAS = "queue" +QUEUE_TTL_SECONDS = 604_800 # 7 days diff -...
d5b5ebf52cd46b9df53eb0be6c34d79b40861be6
Andrea Francis Soria Jimenez
andrea@huggingface.co
2023-02-27T16:19:24
Fix typos in split-names-from-streaming (#837)
diff --git a/jobs/mongodb_migration/src/mongodb_migration/collector.py b/jobs/mongodb_migration/src/mongodb_migration/collector.py index 7ba24295..18857e50 100644 --- a/jobs/mongodb_migration/src/mongodb_migration/collector.py +++ b/jobs/mongodb_migration/src/mongodb_migration/collector.py @@ -43 +43 @@ class Migration...
391cf55e831dab8aee7989e69d99973955244062
Andrea Francis Soria Jimenez
andrea@huggingface.co
2023-02-24T20:30:38
Adding missing function on split-names-from-dataset-info worker (#839)
diff --git a/services/worker/src/worker/job_runners/split_names_from_dataset_info.py b/services/worker/src/worker/job_runners/split_names_from_dataset_info.py index be24011f..2147358a 100644 --- a/services/worker/src/worker/job_runners/split_names_from_dataset_info.py +++ b/services/worker/src/worker/job_runners/split_...
fcde0bb3f1669f80355dc0fa3768e5b39bc309e4
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-02-24T15:32:32
Setup argocd action (#848)
diff --git a/.github/workflows/build_push_docker_hub.yml b/.github/workflows/cd.yml similarity index 50% rename from .github/workflows/build_push_docker_hub.yml rename to .github/workflows/cd.yml index dd1ac06e..e3bfb380 100644 --- a/.github/workflows/build_push_docker_hub.yml +++ b/.github/workflows/cd.yml @@ -4 +4 @@...
6f35d61f2225dcc487d06dde5c54d0d26e691ea7
Albert Villanova del Moral
8515462+albertvillanova@users.noreply.github.com
2023-02-24T14:40:50
Update datasets dependency to 2.10.0 version (#829)
diff --git a/services/worker/poetry.lock b/services/worker/poetry.lock index 56a2060f..e113ba65 100644 --- a/services/worker/poetry.lock +++ b/services/worker/poetry.lock @@ -966 +966 @@ name = "datasets" -version = "2.9.0" +version = "2.10.0" @@ -972,2 +972,2 @@ files = [ - {file = "datasets-2.9.0-py3-none-any.whl"...
af31a82b6b34cdf56e8ad18bbd317230620d7029
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-02-24T13:55:19
chore: 🤖 upgrade dependencies to fix vulnerability (#845)
diff --git a/e2e/poetry.lock b/e2e/poetry.lock index a611e9bd..210871b4 100644 --- a/e2e/poetry.lock +++ b/e2e/poetry.lock @@ -241 +241 @@ name = "coverage" -version = "7.1.0" +version = "7.2.0" @@ -247,51 +247,51 @@ files = [ - {file = "coverage-7.1.0-cp310-cp310-macosx_10_9_x86_64.whl", hash = "sha256:3b946bbcd5a8...
af839dd68c70197123949a11e47bc72ac73edeb3
Albert Villanova del Moral
8515462+albertvillanova@users.noreply.github.com
2023-02-24T13:22:28
Improve error messages (#754)
diff --git a/chart/static-files/openapi.json b/chart/static-files/openapi.json index d27575e6..356e24a8 100644 --- a/chart/static-files/openapi.json +++ b/chart/static-files/openapi.json @@ -43 +43 @@ - "summary": "The dataset does not exist, or is not accessible without authentication (private or gated). Pl...
e5d7abed2d7568723c2eb7a8310bc13a5f4c92da
Adrien
adrien@huggingface.co
2023-02-24T10:21:20
Add pdb to avoid disruption when we update kubernetes (#843)
diff --git a/chart/templates/reverse-proxy/pdb.yaml b/chart/templates/reverse-proxy/pdb.yaml new file mode 100644 index 00000000..84a5aa30 --- /dev/null +++ b/chart/templates/reverse-proxy/pdb.yaml @@ -0,0 +1,10 @@ +apiVersion: policy/v1 +kind: PodDisruptionBudget +metadata: + labels: {{ include "labels.reverseProxy" ...
ce7ebdfcecbe2980c9d04d72847ae0a1735d71a4
Polina Kazakova
polina@huggingface.co
2023-02-22T18:49:24
Delete extracted downloaded files of a dataset (#794)
diff --git a/services/worker/src/worker/job_runners/first_rows.py b/services/worker/src/worker/job_runners/first_rows.py index bc498e71..221da844 100644 --- a/services/worker/src/worker/job_runners/first_rows.py +++ b/services/worker/src/worker/job_runners/first_rows.py @@ -25,0 +26 @@ from datasets import ( + Downl...
176a81fdab7ddf58d6e79d65ab0abaef279c4010
Quentin Lhoest
42851186+lhoestq@users.noreply.github.com
2023-02-22T13:59:49
Set error response when zombie job is killed (#827)
diff --git a/services/worker/src/worker/main.py b/services/worker/src/worker/main.py index 623ef954..7996438f 100644 --- a/services/worker/src/worker/main.py +++ b/services/worker/src/worker/main.py @@ -7,0 +8 @@ from datetime import timedelta +from http import HTTPStatus @@ -11,0 +13 @@ from filelock import FileLock +...
8128ec5b131511e7a0b4755f2e2455ce96f7d179
Quentin Lhoest
42851186+lhoestq@users.noreply.github.com
2023-02-17T18:15:05
Kill zombies (#826)
diff --git a/services/worker/src/worker/config.py b/services/worker/src/worker/config.py index b7ae5cc1..53a36969 100644 --- a/services/worker/src/worker/config.py +++ b/services/worker/src/worker/config.py @@ -22,0 +23,2 @@ WORKER_HEARTBEAT_TIME_INTERVAL_SECONDS = 60 +WORKER_MAX_MISSING_HEARTBEATS = 5 +WORKER_KILL_ZOM...
61947cfe5bf92dde001d7345353315594db2b590
Andrea Francis Soria Jimenez
andrea@huggingface.co
2023-02-17T15:38:40
Separate endpoint from processing step logic (#817)
diff --git a/libs/libcommon/src/libcommon/operations.py b/libs/libcommon/src/libcommon/operations.py index 43a2a6c4..db2f97a4 100644 --- a/libs/libcommon/src/libcommon/operations.py +++ b/libs/libcommon/src/libcommon/operations.py @@ -18 +18 @@ class PreviousStepError(LoggedError): - f"Response for {step.end...
ec6bbedca73b1a24b8502fb55c611b0ffd214c93
Andrea Francis Soria Jimenez
andrea@huggingface.co
2023-02-17T14:33:40
Renaming split-names to split-names-from-streaming (#825)
diff --git a/e2e/tests/test_11_auth.py b/e2e/tests/test_11_auth.py index aff84ea2..f4e0df3b 100644 --- a/e2e/tests/test_11_auth.py +++ b/e2e/tests/test_11_auth.py @@ -43 +43,2 @@ def test_auth_e2e( - f"/split-names?dataset={dataset}&config={config}", + f"/split-names-from-streaming?dataset={dataset}&confi...
3a27146498c67ea9dc6dd8d8092005f55c6c961f
Quentin Lhoest
42851186+lhoestq@users.noreply.github.com
2023-02-16T22:54:14
Add heartbeat (#824)
diff --git a/libs/libcommon/src/libcommon/queue.py b/libs/libcommon/src/libcommon/queue.py index 10c6abb3..884e9474 100644 --- a/libs/libcommon/src/libcommon/queue.py +++ b/libs/libcommon/src/libcommon/queue.py @@ -40 +40 @@ class QuerySetManager(Generic[U]): -class Status(enum.Enum): +class Status(str, enum.Enum): @@ ...
502386edbf6edd63465cc8a6759e4239d35b7cad
Andrea Francis Soria Jimenez
andrea@huggingface.co
2023-02-15T17:03:32
Adding new job runner for split names based on dataset info cached response (#820)
diff --git a/libs/libcommon/src/libcommon/config.py b/libs/libcommon/src/libcommon/config.py index d13466d7..251f8c68 100644 --- a/libs/libcommon/src/libcommon/config.py +++ b/libs/libcommon/src/libcommon/config.py @@ -105,0 +106 @@ class ProcessingGraphConfig: + "/split-names-from-dataset-info": {"input_typ...
c12637e5eb8ee2765ff7d0da651a22a00ccadfee
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-02-15T15:32:56
Update dependencies (#823)
diff --git a/e2e/poetry.lock b/e2e/poetry.lock index c426e46f..a611e9bd 100644 --- a/e2e/poetry.lock +++ b/e2e/poetry.lock @@ -238,0 +239,64 @@ files = [ +[[package]] +name = "coverage" +version = "7.1.0" +description = "Code coverage measurement for Python" +category = "dev" +optional = false +python-versions = ">=3.7...
4f66f176117711580db0d82daabcb5d4a4eabc97
Quentin Lhoest
42851186+lhoestq@users.noreply.github.com
2023-02-15T14:10:18
Ignore big datasets from external files (#809)
diff --git a/services/worker/src/worker/config.py b/services/worker/src/worker/config.py index fcfec3ca..b0ae7cda 100644 --- a/services/worker/src/worker/config.py +++ b/services/worker/src/worker/config.py @@ -99,0 +100 @@ PARQUET_AND_DATASET_INFO_MAX_DATASET_SIZE = 100_000_000 +PARQUET_AND_DATASET_INFO_MAX_EXTERNAL_D...
c7869e7417aea924c69f927437d163b305bf57aa
dependabot[bot]
49699333+dependabot[bot]@users.noreply.github.com
2023-02-15T14:00:51
chore(deps): bump starlette from 0.23.1 to 0.25.0 in /front/admin_ui (#821)
diff --git a/front/admin_ui/poetry.lock b/front/admin_ui/poetry.lock index f090ec88..94eba3e0 100644 --- a/front/admin_ui/poetry.lock +++ b/front/admin_ui/poetry.lock @@ -458 +458 @@ name = "fastapi" -version = "0.90.1" +version = "0.92.0" @@ -464,2 +464,2 @@ files = [ - {file = "fastapi-0.90.1-py3-none-any.whl", ha...
f8eb4fb3f5267a34237f18d739390da5037bbb5a
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-02-15T08:40:47
feat: 🎸 add a new admin endpoint: /dataset-status (#815)
diff --git a/libs/libcommon/src/libcommon/queue.py b/libs/libcommon/src/libcommon/queue.py index 2f16c5c2..10c6abb3 100644 --- a/libs/libcommon/src/libcommon/queue.py +++ b/libs/libcommon/src/libcommon/queue.py @@ -586,0 +587,12 @@ class Queue: + def get_dataset_pending_jobs_for_type(self, dataset: str, job_type: st...
276e2734f59e4f359c19a1c89c50f8243b3c24fc
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-02-14T16:12:23
refactor: 💡 factorize the workers templates (#814)
diff --git a/.github/workflows/chart.yml b/.github/workflows/chart.yml index 0876bcce..0a2ff9d0 100644 --- a/.github/workflows/chart.yml +++ b/.github/workflows/chart.yml @@ -23 +23 @@ jobs: - - name: Lint chart + - name: Lint chart with default values @@ -25,0 +26,6 @@ jobs: + - name: Lint chart with de...
ded9a8ca8a1ec7be2d271078397c5abb393ffd83
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-02-14T09:52:09
fix: 🐛 add missing config (#813)
diff --git a/chart/templates/worker/config-names/_container.tpl b/chart/templates/worker/config-names/_container.tpl index 1f2a97fe..6a6fb063 100644 --- a/chart/templates/worker/config-names/_container.tpl +++ b/chart/templates/worker/config-names/_container.tpl @@ -11,0 +12 @@ + {{ include "envAssets" . | nindent 2 }...
03eb5738e63385a95020a4dd21a76f6607771591
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-02-14T09:22:02
fix: 🐛 add missing volumes (#812)
diff --git a/chart/templates/worker/dataset-info/deployment.yaml b/chart/templates/worker/dataset-info/deployment.yaml index 62130353..753f1143 100644 --- a/chart/templates/worker/dataset-info/deployment.yaml +++ b/chart/templates/worker/dataset-info/deployment.yaml @@ -28,0 +29 @@ spec: + volumes: {{ include "vol...
70b90f49527006b1c0637e44263b2dcc79bae0c1
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-02-14T07:54:56
fix: 🐛 ensure all the workers have the same access to the disk (#811)
diff --git a/chart/Chart.yaml b/chart/Chart.yaml index 9b04759e..eb0ccede 100644 --- a/chart/Chart.yaml +++ b/chart/Chart.yaml @@ -21 +21 @@ type: application -version: 1.1.0 +version: 1.1.1 diff --git a/chart/templates/worker/dataset-info/_container.tpl b/chart/templates/worker/dataset-info/_container.tpl index 026535...
760538a4d82049208ee12467339d35abbf28809a
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-02-13T18:16:07
Update chart (#808)
diff --git a/chart/Chart.yaml b/chart/Chart.yaml index 2b4e2f76..9b04759e 100644 --- a/chart/Chart.yaml +++ b/chart/Chart.yaml @@ -21,3 +21 @@ type: application -# -# We don't increment it, as it will not be distributed. -version: 1.0.0 +version: 1.1.0 @@ -31 +29 @@ version: 1.0.0 -appVersion: "0.20.2" +appVersion: "0....
1621a71f4b677e215529ce4a622f9a7894d408aa
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-02-13T18:15:34
chore: 🤖 add VERSION file (#807)
diff --git a/VERSION b/VERSION new file mode 100644 index 00000000..88541566 --- /dev/null +++ b/VERSION @@ -0,0 +1 @@ +0.21.0
fb3399aa3a96abe0f46b1c6a9ee8ac9f3358f394
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-02-13T15:29:23
Generic worker (#802)
diff --git a/chart/env/dev.yaml b/chart/env/dev.yaml index 6f1a775d..46a976ca 100644 --- a/chart/env/dev.yaml +++ b/chart/env/dev.yaml @@ -241,0 +242,10 @@ sizes: + +genericWorker: + replicas: 1 + resources: + requests: + cpu: 100m + memory: "512Mi" + limits: + cpu: 1 + memory: "4Gi" diff --...
69ce0faf0c3ea69990d707bbfde664a9f71df785
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-02-13T14:40:09
Rename obsolete mentions to datasets_based (#805)
diff --git a/DEVELOPER_GUIDE.md b/DEVELOPER_GUIDE.md index d80c95b8..d446e6d0 100644 --- a/DEVELOPER_GUIDE.md +++ b/DEVELOPER_GUIDE.md @@ -158 +158 @@ GITHUB_TOKEN=xxx -To install the [datasets based worker](./services/worker) on Mac OS, you can follow the next steps. +To install the [worker](./services/worker) on Mac ...
f43a0d23c2d84e22c18547ec002c2d6160e9d9e8
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-02-13T08:30:34
Move workers/datasets_based to services/worker (#800)
diff --git a/.github/workflows/build_push_docker_hub.yml b/.github/workflows/build_push_docker_hub.yml index 19e91ad7..dd1ac06e 100644 --- a/.github/workflows/build_push_docker_hub.yml +++ b/.github/workflows/build_push_docker_hub.yml @@ -23,2 +23,2 @@ jobs: - - directory: workers - project: dataset...
67c2eee52b595f51005e6448722b0ac586cd64b5
Quentin Lhoest
42851186+lhoestq@users.noreply.github.com
2023-02-10T22:12:27
add admin ui url (#801)
diff --git a/front/admin_ui/README.md b/front/admin_ui/README.md index 2d88a546..e4eddbb6 100644 --- a/front/admin_ui/README.md +++ b/front/admin_ui/README.md @@ -2,0 +3,2 @@ +Deployed at (internal) https://huggingface.co/spaces/datasets-maintainers/datasets-server-admin-ui +
6666942a0d1194d6d48fdca42377d09359bd0a21
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-02-10T17:20:41
Check dataset connection before migration job (and other apps) (#792)
diff --git a/jobs/mongodb_migration/src/mongodb_migration/main.py b/jobs/mongodb_migration/src/mongodb_migration/main.py index 82b362e6..0f15ca0c 100644 --- a/jobs/mongodb_migration/src/mongodb_migration/main.py +++ b/jobs/mongodb_migration/src/mongodb_migration/main.py @@ -3,0 +4 @@ +import logging @@ -14 +15,2 @@ fro...
f0d048e67f94fdfd422f5c31dbde2fe591ef68a8
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-02-10T16:31:03
Upgrade dependencies, fix kenlm (#803)
diff --git a/front/admin_ui/.python-version b/front/admin_ui/.python-version new file mode 100644 index 00000000..b326afbc --- /dev/null +++ b/front/admin_ui/.python-version @@ -0,0 +1 @@ +3.9.15 diff --git a/front/admin_ui/poetry.lock b/front/admin_ui/poetry.lock index 49b44cd7..f090ec88 100644 --- a/front/admin_ui/po...
6023542baef3b66e06a93c3c99b3183280cf8aec
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-02-10T16:29:42
use classmethod for factories instead of staticmethod (#791)
diff --git a/jobs/mongodb_migration/src/mongodb_migration/config.py b/jobs/mongodb_migration/src/mongodb_migration/config.py index 8047c2a4..dcecb7a6 100644 --- a/jobs/mongodb_migration/src/mongodb_migration/config.py +++ b/jobs/mongodb_migration/src/mongodb_migration/config.py @@ -18,2 +18,2 @@ class DatabaseMigration...
a7f3ecd180bc556a8389511c936a96817bbdd82d
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-02-10T16:07:28
feat: 🎸 ensure immutability of the configs (#790)
diff --git a/jobs/mongodb_migration/src/mongodb_migration/config.py b/jobs/mongodb_migration/src/mongodb_migration/config.py index 98cfea0a..8047c2a4 100644 --- a/jobs/mongodb_migration/src/mongodb_migration/config.py +++ b/jobs/mongodb_migration/src/mongodb_migration/config.py @@ -13 +13 @@ DATABASE_MIGRATIONS_MONGO_U...
761d16a6a0a87517f8a754f37d965f900f3323d7
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-02-10T15:08:39
feat: 🎸 add concept of Resource (#784)
diff --git a/.github/workflows/_unit-tests-python.yml b/.github/workflows/_unit-tests-python.yml index 6b29be44..446d3046 100644 --- a/.github/workflows/_unit-tests-python.yml +++ b/.github/workflows/_unit-tests-python.yml @@ -51,0 +52 @@ jobs: + DATABASE_MIGRATIONS_MONGO_URL: mongodb://localhost:${{ env.mongo...
afd2e49fbc27d000df96b771e753796dc5ade981
Andrea Francis Soria Jimenez
andrea@huggingface.co
2023-02-09T17:55:34
Dataset info big content error (#780)
diff --git a/chart/env/dev.yaml b/chart/env/dev.yaml index 502ebdfc..7ff95ac6 100644 --- a/chart/env/dev.yaml +++ b/chart/env/dev.yaml @@ -242,0 +243,4 @@ sizes: + +# --- datasets_based --- +datasetsBased: + contentMaxBytes: "10_000_000" diff --git a/chart/env/prod.yaml b/chart/env/prod.yaml index b5e0f2f2..337db015 1...
7121f536c693bd4cc06f05929efde6872424ad37
Rémy
remy.trompier@gmail.com
2023-02-09T12:47:35
ci: use shared action to publish helm chart (#799)
diff --git a/.github/workflows/publish-helm.yml b/.github/workflows/publish-helm.yml index dc643bf1..fe9b8997 100644 --- a/.github/workflows/publish-helm.yml +++ b/.github/workflows/publish-helm.yml @@ -15,3 +14,0 @@ jobs: - env: - HELM_REPO_USERNAME: ${{ secrets.REGISTRY_USERNAME }} - HELM_REPO_PASSWORD: ...
447a126911ddd94346a5daa8b76a61d1f9949201
Rémy
remy.trompier@gmail.com
2023-02-09T08:33:14
feat: allow to use http instead of https (#798)
diff --git a/chart/templates/_helpers.tpl b/chart/templates/_helpers.tpl index 0a7e2486..3efacf03 100644 --- a/chart/templates/_helpers.tpl +++ b/chart/templates/_helpers.tpl @@ -182,0 +183,11 @@ Datasets Server base url +{{/* +Return the ingress scheme +*/}} +{{- define "datasetsServer.ingress.scheme" -}} +{{- if .Val...
eb78f501a35b7b7f9f5043238ed30198d38d3a14
Rémy
remy.trompier@gmail.com
2023-02-08T15:46:44
feat: remove job after 5 minutes (#788)
diff --git a/chart/templates/jobs/mongodb-migration/job.yaml b/chart/templates/jobs/mongodb-migration/job.yaml index 68ea3bd5..a5dc5343 100644 --- a/chart/templates/jobs/mongodb-migration/job.yaml +++ b/chart/templates/jobs/mongodb-migration/job.yaml @@ -15,0 +16 @@ spec: + ttlSecondsAfterFinished: 300
3ca72c65f658e66333abf6c1540653a032287864
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-02-08T14:49:31
feat: 🎸 add logs when an unexpected error occurs (#789)
diff --git a/services/admin/src/admin/routes/backfill.py b/services/admin/src/admin/routes/backfill.py index 1b449929..95ca237d 100644 --- a/services/admin/src/admin/routes/backfill.py +++ b/services/admin/src/admin/routes/backfill.py @@ -57,2 +57,2 @@ def create_backfill_endpoint( - except Exception: - ...
4ce53338431558945d670ee4c51497680ece5b23
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-02-08T11:57:23
Fix dockerfiles (#787)
diff --git a/jobs/mongodb_migration/Dockerfile b/jobs/mongodb_migration/Dockerfile index beaa8270..3b83aa7e 100644 --- a/jobs/mongodb_migration/Dockerfile +++ b/jobs/mongodb_migration/Dockerfile @@ -8 +8 @@ ENV PYTHONFAULTHANDLER=1 \ - PIP_NO_CACHE_DIR=off \ + PIP_NO_CACHE_DIR=1 \ @@ -14 +14,2 @@ ENV PYTHONFAULTH...
d00a6201af457f326b1eaef30fa02ca460842bf7
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-02-08T11:56:14
ci: 🎡 run e2e tests only once for a push or pull-request (#786)
diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 78089370..8ba34a94 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -11,0 +12,3 @@ on: + - 'libs/**' + - 'services/**' + - 'workers/**' @@ -20,0 +24,3 @@ on: + - 'libs/**' + - 'services/**' + ...
556c2370f44a292dd9018962ae99a9ef946e9098
Jatin Kumar
99121557+JatinKumar001@users.noreply.github.com
2023-02-08T10:41:39
Remove first rows fallback variable (#771)
diff --git a/chart/templates/worker/first-rows/_container.tpl b/chart/templates/worker/first-rows/_container.tpl index 7fee8754..9c2cc318 100644 --- a/chart/templates/worker/first-rows/_container.tpl +++ b/chart/templates/worker/first-rows/_container.tpl @@ -27,2 +26,0 @@ - - name: FIRST_ROWS_FALLBACK_MAX_DATASET_SIZE...
5251f9ac2538c9ebe11c42a7731f181c0d02823d
Andrea Soria Jimenez
andrea@huggingface.co
2023-02-07T19:56:05
Updating docker image hash (#783)
diff --git a/chart/env/dev.yaml b/chart/env/dev.yaml index 4d6bbe76..502ebdfc 100644 --- a/chart/env/dev.yaml +++ b/chart/env/dev.yaml @@ -29 +29 @@ images: - tag: sha-25ff490 + tag: sha-27ad2f7 @@ -35 +35 @@ images: - tag: sha-25ff490 + tag: sha-27ad2f7 @@ -40 +40 @@ images: - tag: sha-25ff490...
27ad2f7f555cce350785219e19423e23362c56f6
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-02-07T15:45:39
ci: 🎡 the e2e tests must now be run on any code change (#775)
diff --git a/.github/workflows/l-libcommon.yml b/.github/workflows/l-libcommon.yml index 3ba6a069..476a5211 100644 --- a/.github/workflows/l-libcommon.yml +++ b/.github/workflows/l-libcommon.yml @@ -31,0 +32,2 @@ jobs: + e2e-tests: + uses: ./.github/workflows/_e2e_tests.yml diff --git a/.github/workflows/s-admin.ym...
763a6a2d727902bf34efcfda2224003b32b8041f
Albert Villanova del Moral
8515462+albertvillanova@users.noreply.github.com
2023-02-07T14:04:02
Make workers' errors derive from WorkerError (#772)
diff --git a/workers/datasets_based/src/datasets_based/worker.py b/workers/datasets_based/src/datasets_based/worker.py index 6c5e968f..73f5a765 100644 --- a/workers/datasets_based/src/datasets_based/worker.py +++ b/workers/datasets_based/src/datasets_based/worker.py @@ -25 +25 @@ from packaging import version -WorkerEr...
769bc3aae554ed28d0d49dea314b8a9aad0dd6fa
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-02-07T12:35:50
Pass processing step to worker (#779)
diff --git a/libs/libcommon/README.md b/libs/libcommon/README.md index c5996a7d..53027901 100644 --- a/libs/libcommon/README.md +++ b/libs/libcommon/README.md @@ -34,10 +33,0 @@ Set environment variables to configure the job queues to precompute API response - -## Worker loop configuration - -Set environment variables ...
91837d71befc13458b90df29588e614ed2b5665f
Albert Villanova del Moral
8515462+albertvillanova@users.noreply.github.com
2023-02-07T12:25:40
Fix CI mypy error: "WorkerFactory" has no attribute "app_config" (#778)
diff --git a/workers/datasets_based/src/datasets_based/worker_loop.py b/workers/datasets_based/src/datasets_based/worker_loop.py index 3d03d207..0c27d5c3 100644 --- a/workers/datasets_based/src/datasets_based/worker_loop.py +++ b/workers/datasets_based/src/datasets_based/worker_loop.py @@ -100 +99,0 @@ class WorkerLoop...
2e920f6f2241aedda244c2802fb53a6b7b0dafb2
Quentin Lhoest
42851186+lhoestq@users.noreply.github.com
2023-02-06T13:56:37
Use hub-ci locally (#774)
diff --git a/Makefile b/Makefile index b375e873..bc174bb0 100644 --- a/Makefile +++ b/Makefile @@ -11 +11 @@ dev-start: export COMPOSE_PROJECT_NAME := dev-datasets-server -dev-stop: export COMPOSE_PROJECT_NAME = dev-datasets-server +dev-stop: export COMPOSE_PROJECT_NAME := dev-datasets-server diff --git a/front/admin_u...
7188c0a4b84b10b88e39ff9f3ad88ae04843402e
Sylvain Lesage
sylvain.lesage@huggingface.co
2023-02-06T11:24:57
refactor: 💡 hard-code the value of the fallback (#773)
diff --git a/workers/datasets_based/src/datasets_based/workers/first_rows.py b/workers/datasets_based/src/datasets_based/workers/first_rows.py index 5426a2b3..6c657913 100644 --- a/workers/datasets_based/src/datasets_based/workers/first_rows.py +++ b/workers/datasets_based/src/datasets_based/workers/first_rows.py @@ -7...
3bb80b725c361bb5072e14ffc82ab4838ad12405
Quentin Lhoest
42851186+lhoestq@users.noreply.github.com
2023-02-03T11:09:14
Locally use volumes for workers code (#766)
diff --git a/DEVELOPER_GUIDE.md b/DEVELOPER_GUIDE.md index 1073d9cd..dc0be457 100644 --- a/DEVELOPER_GUIDE.md +++ b/DEVELOPER_GUIDE.md @@ -16 +16,3 @@ Install docker (see https://docs.docker.com/engine/install/ubuntu/#install-using -``` +Run the project locally: + +```bash @@ -19,0 +22,9 @@ make start +Run the project ...
7b2ef4d3ea0a1facb7789c3a959602279c8e932a
Quentin Lhoest
42851186+lhoestq@users.noreply.github.com
2023-02-03T11:04:53
create doc for every pr (#768)
diff --git a/.github/workflows/doc-pr-build.yml b/.github/workflows/doc-pr-build.yml index f962ada5..44de5eca 100644 --- a/.github/workflows/doc-pr-build.yml +++ b/.github/workflows/doc-pr-build.yml @@ -8,3 +7,0 @@ on: - paths: - - 'docs/**' - - '.github/workflows/doc-pr-build.yml'
c199a3f19a5866d2540790e57510ee5f6cfd48a6
Quentin Lhoest
42851186+lhoestq@users.noreply.github.com
2023-02-02T19:41:17
Add refresh dataset ui (#760)
diff --git a/front/admin_ui/app.py b/front/admin_ui/app.py index 571d717b..e5724f67 100644 --- a/front/admin_ui/app.py +++ b/front/admin_ui/app.py @@ -1,0 +2,2 @@ import os +import urllib.parse +from itertools import product @@ -25 +27,4 @@ def healthcheck(): - response = requests.head(f"{DSS_ENDPOINT}/admin/pending...