id
int64
393k
2.82B
repo
stringclasses
68 values
title
stringlengths
1
936
body
stringlengths
0
256k
โŒ€
labels
stringlengths
2
508
priority
stringclasses
3 values
severity
stringclasses
3 values
2,525,319,931
flutter
Request clarification on `flutter/tests` definitions
> You will also need to land your change in two parts, so that people have time to migrate How much time is afforded to migrate? > the people listed as contacts for the test are not responsive (within 72 hours). Define `responsive`. Is this an `ack` to recognize the request. It is an acceptance of bug? In my opinion, we should have crisper definitions and timelines so flutter and customer engineers aren't guessing.
a: tests,team,framework,P1,team-framework,triaged-framework
medium
Critical
2,525,320,065
vscode
[json] builtin json formatter doesn't support format-on-paste
<!-- โš ๏ธโš ๏ธ Do Not Delete This! bug_report_template โš ๏ธโš ๏ธ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- ๐Ÿ•ฎ Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions --> <!-- ๐Ÿ”Ž Search existing issues to avoid creating duplicates. --> <!-- ๐Ÿงช Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ --> <!-- ๐Ÿ’ก Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --> <!-- ๐Ÿ”ง Launch with `code --disable-extensions` to check. --> Does this issue occur when all extensions are disabled?: Yes <!-- ๐Ÿช“ If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --> <!-- ๐Ÿ“ฃ Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. --> - VS Code Version: 1.94.0-insider (Universal) - OS Version: Darwin x64 23.6.0 Steps to Reproduce: 1. Enable `editor.formatOnPaste` and `editor.formatOnSave` and set `editor.defaultFormatter` to "vscode.json-language-features" for json files. 2. Paste a line into a json file that is not indented correctly. Result: The pasted line is not formatted on paste, but is formatted once the file is saved. If the same steps are tried with another file type such as TypeScript the pasted line is formatted as expected. https://github.com/user-attachments/assets/3dc9499a-4288-49ce-848c-5300b7d99293
help wanted,feature-request,json,formatting
low
Critical
2,525,340,354
bitcoin
Use IPv4-encoded IPv6 address to get IPv4 node address with port number from DNS seeds
### Please describe the feature you'd like to see added. Use the IPv4-encoded IPv6 addresses that start with a reserved prefix to support nodes with non-default ports in bootstrapping process. There are 7k IPv4 reachable nodes and some of them use non-default ports: ![image](https://github.com/user-attachments/assets/1135ce50-0c43-4da6-af37-4c2ee2bfe5bc) Example: Port 39388 is used by more than [1000 nodes](https://bitnodes.io/nodes/all/ports/) The scripts used in this testing guide can be helpful to discover more nodes with non-default ports: https://web.archive.org/web/20230129111013/https://github.com/bitcoin-core/bitcoin-devwiki/wiki/23.0-Release-Candidate-Testing-Guide ### Is your feature related to a problem, if so please describe it. Non-default ports are supported in automatic connections since v23.0: https://github.com/bitcoin/bitcoin/pull/23542. However, DNS seeds cannot return port numbers in DNS queries. So, the nodes with non-default port will never be a part of bootstrapping. Related discussion: https://github.com/bitcoin/bitcoin/pull/23542#issuecomment-1036384792 https://delvingbitcoin.org/t/hardcoded-seeds-dns-seeds-and-darknet-nodes/1123/8 https://njump.me/nevent1qqst405e4jwg9fwufrqrmjczxdc6desc8xsqlhzsvk7w5wk3lrlmqlczyq9288j6a7v6qq98hkctfxg43jftcj4zp7m9jvd995z4kh4kmlmns9h6j6q ### Describe the solution you'd like IPv4 address and port number can be encoded in an IPv6 address by DNS seeds. IPv6 address format: ``` | 80 bits | 32 bits | 16 bits | |----------------------------------|-----------------|---------| | 0000 0000 0000 0000 abcd (prefix)| IPv4 Address | Port | ``` Python script to encode and decode: https://gitlab.com/-/snippets/3746764 ``` 1. Encode 2. Decode 3. Exit Enter your choice: 1 Enter IPv4 address: 127.0.0.1 Enter port number: 8080 Encoded IPv6: 0000:0000:0000:0000:abcd:7f00:0001:1f90 1. Encode 2. Decode 3. Exit Enter your choice: 2 Enter the encoded IPv6 address: ::abcd:7f00:1:1f90 Decoded Data (IPv4, Port): 127.0.0.1, 8080 ``` I am using clouflare for DNS and tested this on a domain: ![image](https://github.com/user-attachments/assets/372c0359-8b1d-4935-a456-65524038b19c) IPv6 addresses are valid, AAAA for domain is resolved successfully by `getaddrinfo` and Google DNS: https://dns.google/resolve?name=test.joinstr.xyz&type=AAAA&cd=true ### Describe any alternatives you've considered - IPv4 mapped IPv6 addresses are supported based on RFC 4291 and I tested it on Cloudflare. However, you cannot add anything more than IPv4 address. https://datatracker.ietf.org/doc/html/rfc4291#section-2.5.5.2 - NULL and TXT records Related issues: https://delvingbitcoin.org/t/hardcoded-seeds-dns-seeds-and-darknet-nodes/1123/6 https://njump.me/nevent1qqsp9v4jxynf8k93erdl2ku3nh92ng7fwr695lvwmh0tek8k2r6fvscpp4mhxue69uhkummn9ekx7mqpz3mhxue69uhhyetvv9ujuerpd46hxtnfdupzqz4rnedwlxdqqznmmv95ny2cey4uf23qldjexxjj6p2mt6mdlaeceaxu3t
Feature
low
Minor
2,525,369,922
go
net/http: TestOmitHTTP2 failures
``` #!watchflakes default <- pkg == "net/http" && test == "TestOmitHTTP2" ``` Issue created automatically to collect these failures. Example ([log](https://ci.chromium.org/b/8736892677800322273)): === RUN TestOmitHTTP2 === PAUSE TestOmitHTTP2 === CONT TestOmitHTTP2 http_test.go:93: go test -short failed: exit status 1, --- FAIL: TestOptions (0.00s) --- FAIL: TestOptions/h1 (0.00s) serve_test.go:3682: Get "http://127.0.0.1:43171/second": net/http: HTTP/1.x transport connection broken: http: CloseIdleConnections called FAIL FAIL net/http 2.204s FAIL --- FAIL: TestOmitHTTP2 (7.93s) โ€” [watchflakes](https://go.dev/wiki/Watchflakes)
NeedsInvestigation
low
Critical
2,525,401,926
rust
Number types' `FromStr` impl should recognize Unicode minus
You can say the following about the character currently exclusively recognized as minus by `FromStr` impls: - Its official Unicode name is [`U+002D HYPHEN-MINUS : hyphen, dash, minus sign`](https://en.wikipedia.org/wiki/Hyphen-minus) (copied from [BabelMap](https://www.babelstone.co.uk/Software/BabelMap.html)). - The general typographical reality of font designs is that it's a hyphen and not a minus sign. - The usage-wise reality is that it's widely used as a replacement character for a real minus sign. In comparison, U+2212 is a dedicated minus sign: - Official Unicode name: `U+2212 MINUS SIGN` - Matches the horizontal bar of a plus sign. - GitHub, e.g., uses it to display the red ["lines deleted" values](https://github.com/rust-lang/rust/pull/128511). Wikipedia and LaTeX equation renderings also use it. - In HTML, you have the entity `&minus;` for it. Benefits of adding support: - If the `FromStr` implementations of number types (`i32`, `f64` etc.) would support `U+2212 MINUS SIGN` in addition to `U+002D HYPHEN-MINUS` as a minus sign, UI frameworks, e.g., would have an easier time implementing text boxes that display the typographically more pleasing real minus sign, simply converting the text content to the corresponding number. - App implementations not further checking user input, but directly trying to parse it as a number, and banking on the returned `Result`, wouldn't confuse end users anymore when they pasted a number with Unicode minus into the app and the app showed an error. - Also, since it's a dedicated minus sign, and not just a common replacement character, it logically follows in my opinion that it should be supported. I'm not familiar with this, but I want to point out that the Wikipedia article ["Plus and minus signs"](https://en.wikipedia.org/wiki/Plus_and_minus_signs) also talks about โ’ as a minus sign (`U+2052 COMMERCIAL MINUS SIGN`). Perhaps, this should also be supported. But I don't know whether it's regularly set off from the number with some space character.
A-Unicode,T-libs-api,C-discussion
low
Critical
2,525,419,173
rust
Trait inference is broken for unnamed structs
<!-- Thank you for filing a bug report! ๐Ÿ› Please provide a short summary of the bug, along with any information you feel relevant to replicating the bug. --> I tried this code: https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=f985f43df2ad05edfb593d23248e46f3 I expected to see this happen: That this works both for structs with named fields as with structs with anonymous fields Instead, this happened: Works as expected for named fields, but fails to compile for anonymous structs <!-- TRIAGEBOT_START --> <!-- TRIAGEBOT_ASSIGN_START --> <!-- TRIAGEBOT_ASSIGN_DATA_START$${"user":"maxcabrajac"}$$TRIAGEBOT_ASSIGN_DATA_END --> <!-- TRIAGEBOT_ASSIGN_END --> <!-- TRIAGEBOT_END -->
A-trait-system,A-associated-items,T-lang,T-compiler,E-help-wanted,C-bug,S-has-mcve
low
Critical
2,525,420,402
ui
[bug]: Duplicate / in imports of the code in the blocks documentation
### Describe the bug Whenever viewing the code of blocks using the "New York" style, there are multiple slashes in the UI route in the import statements of the components. For example: `import { Separator } from "@/components//ui/separator"` ![Screenshot from 2024-09-13 14-21-30](https://github.com/user-attachments/assets/a18043ae-afa4-4f4b-9c25-fdbc0a10e05c) ### Affected component/components Documentation ### How to reproduce 1. Go to the Shadcn website 2. Navigate to the blocks route 3. Select New York style if not selected 4. Click on code 5. Scroll to the imports to see the multiple slashes ### Codesandbox/StackBlitz link n/a ### Logs ```bash n/a ``` ### System Info ```bash Firefox, Chrome ``` ### Before submitting - [X] I've made research efforts and searched the documentation - [X] I've searched for existing issues
bug
low
Critical
2,525,431,012
next.js
In dev mode, "incrementalCache missing in unstable_cache" when using unstable_cache in middleware
### Link to the code that reproduces this issue https://github.com/tom-sherman/next-missing-incrementalcache-bug ### To Reproduce 1. `next dev` 2. Open `/` ### Current vs. Expected behavior ``` unhandledRejection: Error: Invariant: incrementalCache missing in unstable_cache ()=>Promise.resolve() at cachedCb (webpack-internal:///(middleware)/./node_modules/.pnpm/next@15.0.0-canary.150_react-dom@19.0.0-rc-7771d3a7-20240827_react@19.0.0-rc-7771d3a7-2024082_2ydu7yowbuals2jgbmseymwiiq/node_modules/next/dist/esm/server/web/spec-extension/unstable-cache.js:64:19) at middleware (webpack-internal:///(middleware)/./middleware.ts:12:5) at Object.eval [as handler] (webpack-internal:///(middleware)/./node_modules/.pnpm/next@15.0.0-canary.150_react-dom@19.0.0-rc-7771d3a7-20240827_react@19.0.0-rc-7771d3a7-2024082_2ydu7yowbuals2jgbmseymwiiq/node_modules/next/dist/build/webpack/loaders/next-middleware-loader.js?absolutePagePath=%2Fhome%2Ftom%2Fcode%2Fnext-missing-incrementalcache-bug%2Fmiddleware.ts&page=%2Fmiddleware&rootDir=%2Fhome%2Ftom%2Fcode%2Fnext-missing-incrementalcache-bug&matchers=&preferredRegion=&middlewareConfig=e30%3D!:26:26) at eval (webpack-internal:///(middleware)/./node_modules/.pnpm/next@15.0.0-canary.150_react-dom@19.0.0-rc-7771d3a7-20240827_react@19.0.0-rc-7771d3a7-2024082_2ydu7yowbuals2jgbmseymwiiq/node_modules/next/dist/esm/server/web/adapter.js:215:35) at AsyncLocalStorage.run (node:async_hooks:346:14) at withRequestStore (webpack-internal:///(middleware)/./node_modules/.pnpm/next@15.0.0-canary.150_react-dom@19.0.0-rc-7771d3a7-20240827_react@19.0.0-rc-7771d3a7-2024082_2ydu7yowbuals2jgbmseymwiiq/node_modules/next/dist/esm/server/async-storage/with-request-store.js:106:20) at eval (webpack-internal:///(middleware)/./node_modules/.pnpm/next@15.0.0-canary.150_react-dom@19.0.0-rc-7771d3a7-20240827_react@19.0.0-rc-7771d3a7-2024082_2ydu7yowbuals2jgbmseymwiiq/node_modules/next/dist/esm/server/web/adapter.js:201:118) at eval (webpack-internal:///(middleware)/./node_modules/.pnpm/next@15.0.0-canary.150_react-dom@19.0.0-rc-7771d3a7-20240827_react@19.0.0-rc-7771d3a7-2024082_2ydu7yowbuals2jgbmseymwiiq/node_modules/next/dist/esm/server/lib/trace/tracer.js:142:36) at NoopContextManager.with (webpack-internal:///(middleware)/./node_modules/.pnpm/next@15.0.0-canary.150_react-dom@19.0.0-rc-7771d3a7-20240827_react@19.0.0-rc-7771d3a7-2024082_2ydu7yowbuals2jgbmseymwiiq/node_modules/next/dist/compiled/@opentelemetry/api/index.js:2:7062) at ContextAPI.with (webpack-internal:///(middleware)/./node_modules/.pnpm/next@15.0.0-canary.150_react-dom@19.0.0-rc-7771d3a7-20240827_react@19.0.0-rc-7771d3a7-2024082_2ydu7yowbuals2jgbmseymwiiq/node_modules/next/dist/compiled/@opentelemetry/api/index.js:2:518) ``` ### Provide environment information ```bash Operating System: Platform: linux Arch: x64 Version: #1 SMP Fri Mar 29 23:14:13 UTC 2024 Available memory (MB): 7841 Available CPU cores: 16 Binaries: Node: 20.12.1 npm: 10.5.0 Yarn: 1.22.22 pnpm: 9.9.0 Relevant Packages: next: 15.0.0-canary.150 // There is a newer canary version (15.0.0-canary.154) available, please upgrade! eslint-config-next: N/A react: 19.0.0-rc-7771d3a7-20240827 react-dom: 19.0.0-rc-7771d3a7-20240827 typescript: 5.3.3 Next.js Config: output: N/A ``` ### Which area(s) are affected? (Select all that apply) Middleware, Turbopack, Webpack ### Which stage(s) are affected? (Select all that apply) next dev (local) ### Additional context This is reproducible with and without `--turbo`. Related to #51397 and #60336
bug,Middleware,Webpack,Turbopack
low
Critical
2,525,435,324
material-ui
[docs-infra] Fix font best practice
### Steps to reproduce - [ ] 1. We use Google Font to load some of the font of the docs: https://github.com/mui/material-ui/blob/a4876336bedd35d342a83eb081b0c1fc456b2339/docs/pages/_document.js#L81 However, this doesn't seem to be a best practice, see https://www.debugbear.com/blog/website-font-performance#self-host-your-web-fonts for why. The problem really boils down to having to make a CSS network request to then be able to load the font. Since 2021, all browsers have implemented [cache partitioning](https://developers.google.com/web/updates/2020/10/http-cache-partitioning), so there are no more CDN performance benefits. - [ ] 2. We should likely warn about this problem in the docs, e.g. https://mui.com/material-ui/react-typography/#google-web-fonts is nice when you want a quick and easy way to test stuff, e.g. for bug reproductions, visual regression tests environment, but not really for production. There is a reason why https://nextjs.org/docs/app/building-your-application/optimizing/fonts and https://docs.astro.build/en/guides/fonts/ don't mention it. - [ ] 3. We are missing the correct font fallback. Either we should use something like https://nextjs.org/docs/app/building-your-application/optimizing/fonts or set font-display: fallback https://web.dev/articles/font-best-practices#choose_an_appropriate_font-display_strategy to be coherence. For example, compare https://dashboard.tremor.so/overview load to https://mui.com/material-ui/getting-started/templates/dashboard/. What we do is not at the quality level, we need to set.
docs,performance,enhancement,scope: docs-infra
low
Critical
2,525,444,194
pytorch
Inductor generates redundant assignments
### ๐Ÿš€ The feature, motivation and pitch Connected to PR https://github.com/pytorch/pytorch/pull/132755 If to comment in lowerings.py: torch.ops.higher_order.with_effects short circuit for wait_tensor: ``` if op == torch.ops._c10d_functional.wait_tensor.default: assert len(args) == 1 return token, _wait_tensor(args[0]) ``` And run ``` TORCH_LOGS="output_code" python test/distributed/test_c10d_functional_native.py -k test_inductor_all_reduce_single ``` Inductor generates: ``` buf2 = empty_strided_cuda((4, 4), (4, 1), torch.float32) buf9 = empty_strided_cuda((4, 4), (4, 1), torch.float32) # Topologically Sorted Source Nodes: [buf0, tensor_1], Original ATen: [aten.add, _c10d_functional.all_reduce] stream0 = get_raw_stream(0) triton_poi_fused_add_all_reduce_0.run(arg1_1, buf2, buf9, 16, grid=grid(16), stream=stream0) del arg1_1 # Topologically Sorted Source Nodes: [buf0, tensor], Original ATen: [aten.add, _c10d_functional.all_reduce] torch.ops._c10d_functional.all_reduce_.default(buf2, 'avg', '0') # Topologically Sorted Source Nodes: [ar0], Original ATen: [] buf5 = torch.ops._c10d_functional.wait_tensor.default(buf2) del buf2 buf6 = buf5 # Topologically Sorted Source Nodes: [ar0_1], Original ATen: [] buf7 = torch.ops._c10d_functional.wait_tensor.default(buf6) del buf5 del buf6 buf8 = buf7 # Topologically Sorted Source Nodes: [tensor_1], Original ATen: [_c10d_functional.all_reduce] torch.ops._c10d_functional.all_reduce_.default(buf9, 'avg', '0') # Topologically Sorted Source Nodes: [ar1], Original ATen: [] buf12 = torch.ops._c10d_functional.wait_tensor.default(buf9) del buf7 del buf9 buf13 = buf12 # Topologically Sorted Source Nodes: [ar1_1], Original ATen: [] buf14 = torch.ops._c10d_functional.wait_tensor.default(buf13) del buf12 del buf13 buf15 = buf14 return (buf8, buf15, ) ``` Assignments like `buf15 = buf14` are not regressing perf, but adding complications for tests logic. ### Alternatives _No response_ ### Additional context _No response_ cc @ezyang @chauhang @penguinwu @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire
triaged,oncall: pt2,module: inductor,internal ramp-up task
low
Minor
2,525,456,358
pytorch
Conv vs. Scipy tests fail on MacOS
### ๐Ÿ› Describe the bug `vs_scipy` tests in `test/nn/test_convolution.py` fail on Mac ``` __ TestConvolutionNNDeviceTypeMPS.test_conv3d_vs_scipy_mode_same_mps_float32 ___ Traceback (most recent call last): File "/Users/ec2-user/runner/_work/pytorch/pytorch/test/nn/test_convolution.py", line 2076, in test_conv3d_vs_scipy _test(t, weight_odd, mode) File "/Users/ec2-user/runner/_work/pytorch/pytorch/test/nn/test_convolution.py", line 2069, in _test self.assertEqual(actual, expected, rtol=2e-5, atol=5e-6) File "/Users/ec2-user/runner/_work/_temp/conda_environment_10845817884/lib/python3.9/site-packages/torch/testing/_internal/common_utils.py", line 3885, in assertEqual raise error_metas.pop()[0].to_error( AssertionError: Tensor-likes are not close! Mismatched elements: 1 / 250 (0.4%) Greatest absolute difference: 8.262693881988525e-06 at index (2, 0, 4) (up to 5e-06 allowed) Greatest relative difference: 8.1622478319332e-05 at index (2, 0, 4) (up to 2e-05 allowed) To execute this test, run the following from the base repo dir: python test/nn/test_convolution.py TestConvolutionNNDeviceTypeMPS.test_conv3d_vs_scipy_mode_same_mps_float32 ``` ### Versions (torch) sidk@mac-907256 pytorch % python collect_env.py Collecting environment information... PyTorch version: 2.5.0a0+git65bab4e Is debug build: False CUDA used to build PyTorch: None ROCM used to build PyTorch: N/A OS: macOS 15.1 (arm64) GCC version: Could not collect Clang version: 16.0.0 (clang-1600.0.21.4) CMake version: version 3.26.4 Libc version: N/A Python version: 3.10.14 (main, May 6 2024, 14:42:37) [Clang 14.0.6 ] (64-bit runtime) Python platform: macOS-15.1-arm64-arm-64bit Is CUDA available: False CUDA runtime version: No CUDA CUDA_MODULE_LOADING set to: N/A GPU models and configuration: No CUDA Nvidia driver version: No CUDA cuDNN version: No CUDA HIP runtime version: N/A MIOpen runtime version: N/A Is XNNPACK available: True CPU: Apple M2 Max Versions of relevant libraries: [pip3] executorch==0.3.0a0+9b7a6d9 [pip3] flake8==6.1.0 [pip3] flake8-bugbear==23.3.23 [pip3] flake8-comprehensions==3.15.0 [pip3] flake8-executable==2.1.3 [pip3] flake8-logging-format==0.9.0 [pip3] flake8-pyi==23.3.1 [pip3] flake8-simplify==0.19.3 [pip3] functorch==2.0.0 [pip3] mypy==1.10.0 [pip3] mypy-extensions==1.0.0 [pip3] numpy==1.26.0 [pip3] optree==0.12.1 [pip3] torch==2.5.0.dev20240806 [pip3] torchao==0.1 [pip3] torchaudio==2.5.0.dev20240902 [pip3] torchsr==1.0.4 [pip3] torchutils==0.0.4 [pip3] torchvision==0.20.0.dev20240902 [conda] executorch 0.3.0a0+9b7a6d9 pypi_0 pypi [conda] functorch 2.0.0 pypi_0 pypi [conda] numpy 1.26.0 pypi_0 pypi [conda] optree 0.12.1 pypi_0 pypi [conda] torch 2.5.0a0+git8a166ae pypi_0 pypi [conda] torchao 0.1 pypi_0 pypi [conda] torchaudio 2.5.0.dev20240902 pypi_0 pypi [conda] torchfix 0.4.0 pypi_0 pypi [conda] torchsr 1.0.4 pypi_0 pypi [conda] torchutils 0.0.4 pypi_0 pypi [conda] torchvision 0.20.0.dev20240902 pypi_0 pypi cc @kulinseth @albanD @malfet @DenisVieriu97 @jhavukainen
triaged,module: correctness (silent),module: mps
low
Critical
2,525,464,156
godot
[4.3.stable][4.1.1.stable] Renaming an animation does not change its resource name on disk.
### Tested versions - Reproducible in: 4.3.stable, 4.1.1.stable ### System information - Godot v4.3.stable - Windows 10.0.22000 - GLES3 (Compatibility) - Intel(R) UHD Graphics (Intel Corporation; 30.0.101.1298) - 12th Gen Intel(R) Core(TM) i5-1235U (12 Threads) ### Issue description When an animation is saved on disk as a .res file, its resource name is set as the original name when created in the AnimationPlayer. No matter whether you modify it in the "Manage Animations" window or overwrite the file by re-saving it, this name will never change. ### Steps to reproduce 1. Create an AnimationPlayer node. 2. In the Animation panel, click "Animation > New...". 3. In the "Create New Animation" window, change nothing and click "OK". 4. In the Animation panel, click "Animation > Manage Animations...". 5. In the "Edit Animation Libraries..." window, click the floppy disk icon. 6. In the dropdown menu, click "Save". 7. In the "Save Animation" window, set the file name to "file_name.res" and click "Save". 8. In the "Edit Animation Libraries..." window, click the floppy disk icon. 9. When the label changes to an input field, select all and enter "new_name". 10. Press enter to apply changes and click "OK" to close the "Edit Animation Libraries..." window. 11. Write a tiny script to print Animation.resource_name Expected result: **"new_name" or "file_name" is printed on the console.** Actual result: **"new_animation" is printed on the console** ### Minimal reproduction project (MRP) [[mrp][v4.3.stable]-renaming-an-animation-does-not-change-its-resource-name-on-disk.zip](https://github.com/user-attachments/files/16998207/mrp.v4.3.stable.-renaming-an-animation-does-not-change-its-resource-name-on-disk.zip)
discussion,topic:editor,topic:animation
low
Minor
2,525,500,743
rust
No diagnostics for `cfg`-ed out methods
### Code compile with `--target thumbv6m-none-eabi` or see https://godbolt.org/z/nEjfqMP5v ```Rust #![no_std] use core::sync::atomic::{AtomicBool, Ordering}; fn test(){ AtomicBool::new(false).fetch_not(Ordering::Relaxed); } ``` ### Current output ```Shell error[E0599]: no method named `fetch_not` found for struct `AtomicBool` in the current scope --> <source>:6:28 | 6 | AtomicBool::new(false).fetch_not(Ordering::Relaxed); | ^^^^^^^^^ method not found in `AtomicBool` ``` ### Desired output ```Shell Add this: note: `AtomicBool` has a method named `fetch_not` but it is inactive because its cfg predicate evaluated to false ``` ### Rationale and extra context https://github.com/rust-lang/rust/pull/109005/ added very helpful diagnostics for a similar case ### Other cases _No response_ ### Rust Version ```Shell rustc 1.81.0 (eeb90cda1 2024-09-04) binary: rustc commit-hash: eeb90cda1969383f56a2637cbd3037bdf598841c commit-date: 2024-09-04 host: x86_64-unknown-linux-gnu release: 1.81.0 LLVM version: 18.1.7 Compiler returned: 0 ``` ### Anything else? _No response_
A-diagnostics,T-compiler
low
Critical
2,525,510,163
rust
stdlib code size increase in nightly-2024-09-01 for aarch64-linux-android
We keep track of our code size on Android to keep our overall download size down. In updating our pinned nightly compiler (from nightly-2024-06-21; we're due for it), our CI turned up a code size increase of ~120KB in a library that's overall about 4.6MBโ€”not huge, but not expected either. Bisecting on Rust toolchains turned up that the regression was introduced in nightly-2024-09-01 (as in, nightly-2024-08-30 does not have this extra code size, and there was no nightly-2024-08-31), and moreover I discovered that using -Zbuild-std recovered the additional code size. So something changed in how the prebuilt standard library is built, in a way that may not have been intended. Unfortunately, our Android build process does a whole bunch of work at once, so I don't have a minimal example for you. My reproduction has been 1. Install the Android NDK (27.0.12077973 is the one we're currently using) 2. Check out https://github.com/signalapp/libsignal/releases/tag/v0.57.1 3. `ANDROID_NDK_HOME=path/to/ndk/27.0.12077973 java/build_jni.sh android-arm64` 4. Save the resulting library, then repeat with `RUSTUP_TOOLCHAIN=nightly-2024-09-01`. 5. Compare the libraries' post-stripped sizes, or use a tool like `bloaty` to measure VM size only It's possible this change was expected, in which case please close the issue; I understand code sizes go up sometimes! @rustbot modify labels: +regression-from-stable-to-nightly -regression-untriaged
O-android,P-medium,regression-from-stable-to-nightly,C-bug,T-libs
medium
Major
2,525,516,567
deno
Different results when code is ran directly vs ran as a task
Version: Deno 1.46.3 When I run a command as a task, it completes without an issue, but when I run it directly, the same code gives me an access denied error: `deno run x` vs `deno run -RW=./things example.ts` The issue is the same when I ran it with `deno run --prompt -RW=./things example.ts`. โš ๏ธ But also, if I flip the order to `deno run -RW=./things --prompt example.ts` I get another type of error, it not recognising `--prompt`. Current [docs](https://docs.deno.com/runtime/getting_started/command_line_interface/#other-runtime-flags) mention the existence of this flag. ![image](https://github.com/user-attachments/assets/ef89ce33-fe7e-4473-9dc1-c687bd65b588)
windows,needs investigation
low
Critical
2,525,527,149
pytorch
Dump bytecode of resumption frames in tlparse
### ๐Ÿ› Describe the bug Since resumption frames don't exist in the source code, having access to their bytecode can be useful for diagnosing Dynamo bytecode problems. ### Versions main cc @chauhang @penguinwu @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @amjames @rec
good first issue,module: logging,triaged,oncall: pt2,module: dynamo
low
Critical
2,525,534,265
ui
[bug]: tailwind.config.ts malformed after installing components
### Describe the bug after a clean project setup I added many of the shadcn components and the resulting `tailwind.config.ts` file was slightly malformed. - `theme.extend.fontFamily` has some escaped newlines (and I'm not sure but `'Inter "'` as a font also looks a bit wrong) - (not that big of a deal, but I'll list it anyway) config was created with mixed spaces and tabs ``` import type { Config } from "tailwindcss"; export default { darkMode: ["class"], content: ["./app/**/{**,.client,.server}/**/*.{js,jsx,ts,tsx}"], theme: { extend: { fontFamily: { sans: [\\n 'Inter"',\\n "ui-sans-serif",\\n "system-ui",\\n "sans-serif",\\n 'Apple Color Emoji"',\\n 'Segoe UI Emoji"',\\n 'Segoe UI Symbol"',\\n 'Noto Color Emoji"',\\n ] }, borderRadius: { lg: 'var(--radius)', md: 'calc(var(--radius) - 2px)', sm: 'calc(var(--radius) - 4px)' }, colors: { background: 'hsl(var(--background))', foreground: 'hsl(var(--foreground))', card: { DEFAULT: 'hsl(var(--card))', foreground: 'hsl(var(--card-foreground))' }, popover: { DEFAULT: 'hsl(var(--popover))', foreground: 'hsl(var(--popover-foreground))' }, primary: { DEFAULT: 'hsl(var(--primary))', foreground: 'hsl(var(--primary-foreground))' }, secondary: { DEFAULT: 'hsl(var(--secondary))', foreground: 'hsl(var(--secondary-foreground))' }, muted: { DEFAULT: 'hsl(var(--muted))', foreground: 'hsl(var(--muted-foreground))' }, accent: { DEFAULT: 'hsl(var(--accent))', foreground: 'hsl(var(--accent-foreground))' }, destructive: { DEFAULT: 'hsl(var(--destructive))', foreground: 'hsl(var(--destructive-foreground))' }, border: 'hsl(var(--border))', input: 'hsl(var(--input))', ring: 'hsl(var(--ring))', chart: { '1': 'hsl(var(--chart-1))', '2': 'hsl(var(--chart-2))', '3': 'hsl(var(--chart-3))', '4': 'hsl(var(--chart-4))', '5': 'hsl(var(--chart-5))' } }, keyframes: { 'accordion-down': { from: { height: '0' }, to: { height: 'var(--radix-accordion-content-height)' } }, 'accordion-up': { from: { height: 'var(--radix-accordion-content-height)' }, to: { height: '0' } } }, animation: { 'accordion-down': 'accordion-down 0.2s ease-out', 'accordion-up': 'accordion-up 0.2s ease-out' } } }, plugins: [require("tailwindcss-animate")], } satisfies Config; ``` ### Affected component/components can't say for sure if it's just one, or a combination of many ### How to reproduce 1. Create remix app from template `npx create-remix@2.11.2` 1.1. name: <whatever> 1.2. git repository: no 1.3. "install dependencies": yes 2. `npx shadcn@2.0.3 init` 2.1. style: default 2.2. base color: slate 2.3. css variables: yes 3. add components (happens both inline and interactive) 3.1. `npx shadcn@2.0.3 add accordion alert-dialog avatar badge button calendar card carousel checkbox dialog drawer input input-otp label pagination progress radio-group scroll-area select separator sheet skeleton slider switch table tabs textarea toast toggle toggle-group tooltip` 3.2. skip/decline both button and toggle overwrite messages ### Codesandbox/StackBlitz link https://codesandbox.io/p/devbox/43jndj ### Logs _No response_ ### System Info ```bash OS: Windows 10 Pro x64; Version 22H2; Build 19045.4894 Bun 1.1.27-canary.33+6faf657e3 `npx shadcn@latest --version` is `2.0.3` (pinned in reproduction) `npx create-remix@latest --version` is `2.11.2` (pinned in reproduction) ``` ### Before submitting - [X] I've made research efforts and searched the documentation - [X] I've searched for existing issues
bug
low
Critical
2,525,552,567
vscode
Chat: Next File Tree does not work
Reported by @jooyoungseo
bug,accessibility
low
Minor
2,525,580,603
vscode
Consider how we might improve navigation to chat response content for screen reader users
@jooyoungseo has been interacting with the rendered HTML version of our chat responses more recently because of the introduction of the helpful hyperlinks. He mentioned that there are several tab stops that are encountered before a screen reader user reaches the content of a chat response: 1) the header 2) the toolbar 3) the references (if any) He suggested that at least for windows/linux users, adding the `role=document` would help here. This wouldn't help macOS users and we probably want a solution that solves this for all platforms. Another idea he had was to add a heading to the content so when a user enters a mode of their screen reader, they can go to it directly. I mentioned that we're thinking about moving the toolbar (not sure about the references) to the bottom of the response. He raised concerns about the discoverability of the toolbar in that case for screen reader users but suggested that he has long thought a right click context menu would be advantageous and discoverable for users. @roblourens or @rperez030 any thoughts?
bug,accessibility,under-discussion
low
Minor
2,525,583,969
electron
[Bug]: net.fetch fails on manual redirect
### Preflight Checklist - [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project. - [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to. - [x] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success. ### Electron Version 30.4.0, 32.1.0 ### What operating system(s) are you using? macOS ### Operating System Version Sonoma ### What arch are you using? arm64 (including Apple Silicon) ### Last Known Working Electron version unknown ### Expected Behavior using redirect: 'manual' net.fetch should return with the redirect response. ### Actual Behavior using redirect: 'manual' net.fetch fails with an 'Error: Redirect was cancelled' ### Testcase Gist URL https://gist.github.com/510aba6af66a8bbecf31682d8098cf25 ### Additional Information _No response_
platform/macOS,bug :beetle:,component/net,has-repro-gist
low
Critical
2,525,585,228
rust
rustdoc: reexports of hidden items are not hidden, and look confusing
I tried [searching](https://doc.rust-lang.org/nightly/std/?search=Receiver) for the (unstable) `Receiver` trait in the standard library. The only result it links to is [this](https://doc.rust-lang.org/nightly/core/ops/index.html#reexport.Receiver): ![image](https://github.com/user-attachments/assets/5cdd3fe5-ed17-48ce-9177-c2ca388170fa) I would expect this to be clickable or have some other way for me to look at the actual definition of this trait. But nothing, the story just ends here. Looking at the trait, I noticed this: ```rust #[doc(hidden)] pub trait Receiver { // Empty. } ``` So probably the `doc(hidden)` is why we don't get a link. But shouldn't rustdoc then also hide the reexport?
T-rustdoc,C-bug,A-rustdoc-search,A-local-reexports,S-has-mcve
low
Minor
2,525,593,843
godot
When using a SubViewport to show 2D scenes the normal map information is lost.
### Tested versions 4.3.stable ### System information Windows 11 - 4.3.stable.official Vulkan 1.3.280 - Forward+ - Using Device #0: NVIDIA - NVIDIA GeForce RTX 3060 Laptop GPU ### Issue description When using a SubViewport to show 2D scenes the normal map information is lost. SubViewport.get_texture() returns a ViewportTexture that does not contain the information regarding normal maps. For example, if I wanted to project a scene containing some Sprite2D and related textures (CanvasTexture containing diffuse_texture and normal_texture) onto a PlaneMesh using a SubViewport, currently there is no way to make it interact properly with the light coming on the mesh in the 3D environment, because the data about the normal maps is lost. Here I am projecting a 2D scene on a SubViewport rendered on a mesh, there is no way to retrieve the normal map informations to make it react to the light in the 3D environment (the relative Sprite2D in the 2D scene has a normal map): ![image](https://github.com/user-attachments/assets/0d55f5be-7d2d-49cb-a7ba-8fb8e0c3a033) On the contrary using a 3D scene it is possible to see its normal information and use it throught Rendering > Debug Draw > Normal Buffer: ![image](https://github.com/user-attachments/assets/8aabb4f1-3d3b-488a-b596-5dbe0330901a) I have thought of a few solutions: - Set the diffuse_texture and normal_texture properties to ViewportTexture, mimicking the behavior of CanvasTexture. - Add the get_normal() method to SubViewport. - Make the SubViewport Rendering > Debug Draw > Normal Buffer feature that already works with 3D scenes work for 2D scenes as well. ### Steps to reproduce - Create a 2D scene with one or more Sprite2D with a CanvasTexture and relative diffuse_texture and normal_texture. - Create a 3D scene with a MeshInstance3D and a shape. - Add a SubViewport node to the 3D scene and instantiate the 2D scene as a child of the SubViewport. - Add a material to the mesh, and add the SubViewport as a ViewportTexture in the albedo property. - From here there is no way to retrieve the normal map from the 2D scene and use it as a normal map for the material. Did not found any workaround. ### Minimal reproduction project (MRP) Here there is a little project with a SubViewport where both 3D and 2D scenes projection can be experimented. I animated the lights so that the results can be seen easily. [bug_sub_viewport_normals.zip](https://github.com/user-attachments/files/16998791/bug_sub_viewport_normals.zip)
topic:rendering
low
Critical
2,525,609,291
rust
wasip2 target should not conditionally feature gate stdlib APIs
This was introduced in https://github.com/rust-lang/rust/pull/119616 (cc @rylev) Currently, any crate using `std::os::wasi` stuff needs to add a `#![feature(wasip2)]` if it is to be compiled with `--target=wasm32-wasip2`. This is due to this line: https://github.com/rust-lang/rust/blob/0307e401c26699656ae08e3809e7d272f5c103f4/library/std/src/os/wasi/mod.rs#L32 This puts library authors targeting stable wasm stuff in an annoying situation of needing to add a feature gate to support downstream users who wish to use unstable wasm stuff (see https://github.com/servo/rust-url/pull/960). This isn't really how feature gates should work: the entity using the feature should be the one opting in. I don't think any of the benefits of feature gates apply if every wasi-using dep in the ecosystem just slaps on a `#![cfg_attr(all(target_os = "wasi", target_env = "p2"), feature(wasip2))]`, which seems likely here. A somewhat legitimate reason I could see for having such a feature is if the wasip2 target is stable, but certain stdlib things are unstable under that target. It still has the same problems, and I'd argue a target with specially unstable stdlib APIs should not be considered stable, but at least there appears to be a meaningful thing that the stdlib feature gate is gating. However, it appears to me that wasip2 is just unstable: what's the purpose of gating the stdlib API? If the goal is to gate the target, why not require `-Zunstable-options` as we do for other CLI-level unstable things?
T-libs-api,O-wasm,C-bug,O-wasi,F-wasip2
low
Major
2,525,628,386
flutter
[Android] Delay on first input
There is a slight delay on my first input when tapping on a button on android: https://github.com/user-attachments/assets/9135ba7d-93ca-4a7c-9569-4274bdc01985 It isn't super easy to see in the video? But feels noticeable when interacting with the app. <details> <summary>lib/main.dart</summary> ```dart import 'package:flutter/material.dart'; void main() { runApp(const MyApp()); } class MyApp extends StatelessWidget { const MyApp({super.key}); @override Widget build(BuildContext context) { return MaterialApp( debugShowCheckedModeBanner: false, home: Scaffold( body: Center( child: MenuAnchor( builder: (context, controller, child) => TextButton( onPressed: () { controller.isOpen ? controller.close() : controller.open(); }, child: Text('Press here'), ), menuChildren: [ SubmenuButton(menuChildren: [ MenuItemButton( onPressed: () {}, child: Text('Menu item'), ), ], child: Text('Submenu')), ], ), ), ), ); } } ``` </details> <details> <summary>flutter doctor -v</summary> ```console [!] Flutter (Channel [user-branch], 3.26.0-1.0.pre.89, on macOS 14.6.1 23G93 darwin-arm64, locale en) ! Flutter version 3.26.0-1.0.pre.89 on channel [user-branch] at /Users/mackall/development/flutter/flutter Currently on an unknown channel. Run `flutter channel` to switch to an official channel. If that doesn't fix the issue, reinstall Flutter by following instructions at https://flutter.dev/setup. ! Upstream repository unknown source is not a standard remote. Set environment variable "FLUTTER_GIT_URL" to unknown source to dismiss this error. โ€ข Framework revision 04e1b174ea (2 days ago), 2024-09-11 23:30:50 +0530 โ€ข Engine revision 4eb729b7a5 โ€ข Dart version 3.6.0 (build 3.6.0-239.0.dev) โ€ข DevTools version 2.39.0 โ€ข If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades. [โœ“] Android toolchain - develop for Android devices (Android SDK version 35.0.0-rc4) โ€ข Android SDK at /Users/mackall/Library/Android/sdk โ€ข Platform android-35, build-tools 35.0.0-rc4 โ€ข Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java โ€ข Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314) โ€ข All Android licenses accepted. [!] Xcode - develop for iOS and macOS (Xcode 15.0.1) โ€ข Xcode at /Applications/Xcode.app/Contents/Developer โ€ข Build 15A507 โœ— Unable to get list of installed Simulator runtimes. ! CocoaPods 1.11.3 out of date (1.13.0 is recommended). CocoaPods is a package manager for iOS or macOS platform code. Without CocoaPods, plugins will not work on iOS or macOS. For more info, see https://flutter.dev/to/platform-plugins To update CocoaPods, see https://guides.cocoapods.org/using/getting-started.html#updating-cocoapods [โœ“] Chrome - develop for the web โ€ข Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome [โœ“] Android Studio (version 2024.1) โ€ข Android Studio at /Applications/Android Studio.app/Contents โ€ข Flutter plugin can be installed from: ๐Ÿ”จ https://plugins.jetbrains.com/plugin/9212-flutter โ€ข Dart plugin can be installed from: ๐Ÿ”จ https://plugins.jetbrains.com/plugin/6351-dart โ€ข Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314) [โœ“] VS Code (version 1.71.2) โ€ข VS Code at /Users/mackall/Downloads/Visual Studio Code.app/Contents โ€ข Flutter extension version 3.60.0 [โœ“] Connected device (4 available) โ€ข Pixel 7 Pro (mobile) โ€ข 34011FDH3001H9 โ€ข android-arm64 โ€ข Android 13 (API 33) โ€ข macOS (desktop) โ€ข macos โ€ข darwin-arm64 โ€ข macOS 14.6.1 23G93 darwin-arm64 โ€ข Mac Designed for iPad (desktop) โ€ข mac-designed-for-ipad โ€ข darwin โ€ข macOS 14.6.1 23G93 darwin-arm64 โ€ข Chrome (web) โ€ข chrome โ€ข web-javascript โ€ข Google Chrome 129.0.6668.42 [โœ“] Network resources โ€ข All expected network resources are available. ! Doctor found issues in 2 categories. ``` </details> Noticed when testing https://github.com/flutter/engine/pull/55157, but occurs on master.
platform-android,perf: speed,P2,team-android,triaged-android
low
Critical
2,525,685,425
go
runtime: "some test left a core file behind" failure
``` #!watchflakes default <- `some test left a core file behind` ``` Issue created automatically to collect these failures. Example ([log](https://ci.chromium.org/b/8736891617620242513)): PASS runtime.test: some test left a core file behind FAIL runtime 394.801s โ€” [watchflakes](https://go.dev/wiki/Watchflakes)
NeedsInvestigation,compiler/runtime
low
Critical
2,525,693,185
yt-dlp
[TikTok] Login with password is not supported for this website.
### DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE - [X] I understand that I will be **blocked** if I *intentionally* remove or skip any mandatory\* field ### Checklist - [X] I'm reporting that yt-dlp is broken on a **supported** site - [X] I've verified that I have **updated yt-dlp to nightly or master** ([update instructions](https://github.com/yt-dlp/yt-dlp#update-channels)) - [X] I've checked that all provided URLs are playable in a browser with the same IP and same login details - [X] I've checked that all URLs and arguments with special characters are [properly quoted or escaped](https://github.com/yt-dlp/yt-dlp/wiki/FAQ#video-url-contains-an-ampersand--and-im-getting-some-strange-output-1-2839-or-v-is-not-recognized-as-an-internal-or-external-command) - [X] I've searched [known issues](https://github.com/yt-dlp/yt-dlp/issues/3766) and the [bugtracker](https://github.com/yt-dlp/yt-dlp/issues?q=) for similar issues **including closed ones**. DO NOT post duplicates - [X] I've read the [guidelines for opening an issue](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#opening-an-issue) - [X] I've read about [sharing account credentials](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#are-you-willing-to-share-account-details-if-needed) and I'm willing to share it if required ### Region _No response_ ### Provide a description that is worded well enough to be understood I tried to download a link from tiktok with user and password and I got a warning message. ### Provide verbose output that clearly demonstrates the problem - [X] Run **your** yt-dlp command with **-vU** flag added (`yt-dlp -vU <your command line>`) - [ ] If using API, add `'verbose': True` to `YoutubeDL` params instead - [X] Copy the WHOLE output (starting with `[debug] Command-line config`) and insert it below ### Complete Verbose Output ```shell yt-dlp -vU --username "user" --password 'pass' https://vm.tiktok.com/ZMhdWxvaW [debug] Command-line config: ['-vU', '--username', 'PRIVATE', '--password', 'PRIVATE', 'https://vm.tiktok.com/ZMhdWxvaW'] [debug] Encodings: locale cp1251, fs utf-8, pref cp1251, out utf-8, error utf-8, screen utf-8 [debug] yt-dlp version stable@2024.08.06 from yt-dlp/yt-dlp [4d9231208] (pip) [debug] Python 3.11.1 (CPython AMD64 64bit) - Windows-10-10.0.22000-SP0 (OpenSSL 1.1.1q 5 Jul 2022) [debug] exe versions: none [debug] Optional libraries: Cryptodome-3.20.0, brotli-1.1.0, certifi-2023.07.22, mutagen-1.47.0, requests-2.32.3, sqlite3-3.39.4, urllib3-2.0.5, websockets-12.0 [debug] Proxy map: {} [debug] Request Handlers: urllib, requests, websockets [debug] Loaded 1830 extractors [debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest Latest version: stable@2024.08.06 from yt-dlp/yt-dlp yt-dlp is up to date (stable@2024.08.06 from yt-dlp/yt-dlp) WARNING: [vm.tiktok] Login with password is not supported for this website. Use --cookies-from-browser or --cookies for the authentication. See https://github.com/yt-dlp/yt-dlp/wiki/FAQ#how-do-i-pass-cookies-to-yt-dlp for how to manually pass cookies [vm.tiktok] Extracting URL: https://vm.tiktok.com/ZMhdWxvaW [vm.tiktok] ZMhdWxvaW: Downloading webpage WARNING: [TikTok] Login with password is not supported for this website. Use --cookies-from-browser or --cookies for the authentication. See https://github.com/yt-dlp/yt-dlp/wiki/FAQ#how-do-i-pass-cookies-to-yt-dlp for how to manually pass cookies [TikTok] Extracting URL: https://www.tiktok.com/@speedsongss_md/video/7384116858380766469?_t=8ph5V1uK6ar&_r=1 [TikTok] 7384116858380766469: Downloading webpage [debug] [TikTok] Found universal data for rehydration [debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), channels, acodec, size, br, asr, proto, vext, aext, hasaud, source, id [debug] Default format spec: best/bestvideo+bestaudio [info] 7384116858380766469: Downloading 1 format(s): bytevc1_720p_235083-2 [debug] Invoking http downloader on "https://api16-normal-c-useast1a.tiktokv.com/aweme/v1/play/?video_id=v09044g40000cpsqcb7og65kehttkn40&line=0&is_play_url=1&file_id=ae74a638595d41f6a018371a3a8b2042&item_id=7384116858380766469&signaturev3=dmlkZW9faWQ7ZmlsZV9pZDtpdGVtX2lkLjZmMzA3ODc5NmYyMjc2MTYyMWY3OWFjNWFjYjhjMTBh&shp=9e36835a&shcp=280c9438" [debug] File locking is not supported. Proceeding without locking [download] Destination: THE URS, SHIFT- APA #fyp [7384116858380766469].mp4 [download] 100% of 754.92KiB in 00:00:00 at 1.41MiB/s ```
site-enhancement,triage
low
Critical
2,525,693,263
pytorch
[export] Export CIA preservation doesn't work well with prim decomposition as custom decomp.
``` import torch class M(torch.nn.Module): def forward(self, x): torch.ops.aten._assert_async(torch.tensor(True), "f") return x torch.export.export(M(), (torch.tensor(True),)).run_decompositions(torch._decomp.decomposition_table) ``` cc @ezyang @chauhang @penguinwu @avikchaudhuri @gmagogsfm @zhxchen17 @angelayi @suo @ydwu4 @zou3519 @bdhirsh
triaged,oncall: pt2,export-triaged,oncall: export,module: pt2-dispatcher
low
Major
2,525,695,762
PowerToys
Restore Settings
### Description of the new feature / enhancement I would restore all the settings ### Scenario when this would be used? When you modify/delete something that now you can't reverse. For example: Delete a color format of the Color Picker. ### Supporting information I don't have any supporting information other than my story of how my dumb head decide to delete the color formats without backing it up first.
Needs-Triage
low
Minor
2,525,714,981
vscode
Show breakpoint hit count
<!-- โš ๏ธโš ๏ธ Do Not Delete This! feature_request_template โš ๏ธโš ๏ธ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Describe the feature you'd like. --> While debugging it sometimes is helpfull to see how often a breakpoint is already hit in the current debug session. So it would be nice to have the hit count in the breakpoint view as a quickinfo. Best regards, Frank
feature-request,debug
low
Critical
2,525,740,930
TypeScript
Move to File does not generate imports in the same way that autoimports does
In https://github.com/microsoft/TypeScript/blob/89e004f632323a276b67649e118e78f39a7dc429/src/compiler/expressionToTypeNode.ts#L66 under `} from "./_namespaces/ts.js";` (the last import), add ``` export interface Foo { foo: number; } export function f(): Foo { return { foo: 1 }; } ``` select `export interface Foo { ... }` and using `moveToFile`, move it to `compiler/types.ts` **Actual behavior:** `// @Filename compiler/expressionToTypeNode.ts` ```typescript } from "./_namespaces/ts.js"; import { Foo } from "./types.js"; export function f(): Foo { return { foo: 1 }; } ``` **Expected behavior:** `Foo` is imported from the namespace. Note this correct behavior is the current behavior that happens through calling autoimports directly. If I delete the wrong import above and then auto-import on `Foo`, we get the following as well. ```typescript ... Foo, ... } from "./_namespaces/ts.js"; export function f(): Foo { return { foo: 1 }; } ``` tags: moveToFile, moveToNewFile, move to new file, auto imports
Bug,Domain: Refactorings
low
Minor
2,525,750,752
vscode
Quick text search exclude files
<!-- โš ๏ธโš ๏ธ Do Not Delete This! feature_request_template โš ๏ธโš ๏ธ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Describe the feature you'd like. --> The quick text search is great, but it should be possible to exclude certain files. In a javascript project it is common to have a local build output that is usually not intended to be searched. Quick text search currently search it, resulting in a bunch of useless results. I think it would make sense to respect my search settings "files to exclude" or include.
feature-request,search
low
Minor
2,525,752,533
rust
Assignment into Deref is allowed and creates irrelevant errors
### Code ```Rust fn main() { let i_am_sized = String::new(); *i_am_sized = String::new(); } ``` I thought I've had `&mut String`, not `String`, so `*` was unnecessary here. Because the lvalue has been dereferenced anyway, it caused confusing type error about a type that is not relevant, and assigning to an unsized type that is not at fault here. ~~But the root cause was unexpectedly triggering `Deref` instead of a dereference on `&mut` or `DerefMut`.~~ ### Current output ```text error[E0308]: mismatched types --> src/main.rs:3:19 | 3 | *i_am_sized = String::new(); | ----------- ^^^^^^^^^^^^^ expected `str`, found `String` | | | expected due to the type of this binding error[E0277]: the size for values of type `str` cannot be known at compilation time --> src/main.rs:3:5 | 3 | *i_am_sized = String::new(); | ^^^^^^^^^^^ doesn't have a size known at compile-time | = help: the trait `Sized` is not implemented for `str` ``` ### Desired output Something that `*i_am_sized` due to `Deref` is can't be assigned to, and suggest removing `*` instead. ### Rust Version ```Shell rustc 1.83.0-nightly (8d6b88b16 2024-09-11) binary: rustc commit-hash: 8d6b88b168e45ee1624699c19443c49665322a91 commit-date: 2024-09-11 host: aarch64-apple-darwin release: 1.83.0-nightly LLVM version: 19.1.0 ```
A-diagnostics,T-compiler,D-confusing,D-verbose
low
Critical
2,525,758,909
TypeScript
Move To File makes extra spaces when moving jsdoc comments
In https://github.com/microsoft/TypeScript/blob/89e004f632323a276b67649e118e78f39a7dc429/src/compiler/expressionToTypeNode.ts#L66 under `} from "./_namespaces/ts.js";` (the last import), add ``` /** @internal */ export interface Foo { foo: number; } /** @internal */ export function f(): Foo { return { foo: 1 }; } ``` select `/** @internal */ export interface Foo { ... }` and using `moveToFile`, move it to `compiler/types.ts` **Actual behavior:** `// @Filename types.ts`, end of file: ```typescript }/** @internal */ export interface Foo { foo: number; } ``` **Expected behavior:** ```typescript } /** @internal */ export interface Foo { foo: number; } ``` The comment appearing immediately after the closing bracket is probably related to `https://github.com/microsoft/TypeScript/issues/54306`, as `types.ts` has a trailing newline. This may be related to https://github.com/microsoft/TypeScript/issues/54375, but #54375 adds statements in two stages, since the new lines are added between the generated imports and the moved code, while these lines appear within the moved code. tags: moveToFile, moveToNewFile, move to new file, auto imports, formatting, formatter
Bug,Domain: Refactorings
low
Minor
2,525,772,267
pytorch
capture_triton gets skipped by dynamo
### ๐Ÿ› Describe the bug Instead of just capturing the triton kernel, dynamo skips capture_triton. Repro below: ```python import torch import triton import triton.language as tl @triton.jit def triton_(out, inp, numel, BLOCK_SIZE: tl.constexpr): pid = tl.program_id(0) offsets = pid * BLOCK_SIZE + tl.arange(0, BLOCK_SIZE) mask = offsets < numel vals = tl.load(inp + offsets, mask) result = vals * vals tl.store(out + offsets, vals, mask) def call_triton(inp): out = torch.empty_like(inp) BLOCK_SIZE = 256 numel = inp.numel() def grid(META): return (triton.cdiv(numel, META["BLOCK_SIZE"]),) torch._library.capture_triton(triton_)[grid](out, inp, numel, BLOCK_SIZE) return inp x = torch.randn(15, device="cuda") call_triton(x) torch.compile(call_triton, fullgraph=True)(x) ``` Error message: ``` File "/home/dberard/local/scripts/capture_triton_skipped.py", line 29, in <module> 15:08:41 [40/10111] torch.compile(call_triton, fullgraph=True)(x) File "/home/dberard/local/pytorch/torch/_dynamo/eval_frame.py", line 465, in _fn return fn(*args, **kwargs) File "/home/dberard/local/pytorch/torch/_dynamo/convert_frame.py", line 1278, in __call__ return self._torchdynamo_orig_callable( File "/home/dberard/local/pytorch/torch/_dynamo/convert_frame.py", line 526, in __call__ return _compile( File "/home/dberard/local/pytorch/torch/_dynamo/convert_frame.py", line 924, in _compile guarded_code = compile_inner(code, one_graph, hooks, transform) File "/home/dberard/local/pytorch/torch/_dynamo/convert_frame.py", line 666, in compile_inner return _compile_inner(code, one_graph, hooks, transform) File "/home/dberard/local/pytorch/torch/_utils_internal.py", line 87, in wrapper_function return function(*args, **kwargs) File "/home/dberard/local/pytorch/torch/_dynamo/convert_frame.py", line 699, in _compile_inner out_code = transform_code_object(code, transform) File "/home/dberard/local/pytorch/torch/_dynamo/bytecode_transformation.py", line 1322, in transform_code_object transformations(instructions, code_options) File "/home/dberard/local/pytorch/torch/_dynamo/convert_frame.py", line 219, in _fn return fn(*args, **kwargs) File "/home/dberard/local/pytorch/torch/_dynamo/convert_frame.py", line 634, in transform tracer.run() File "/home/dberard/local/pytorch/torch/_dynamo/symbolic_convert.py", line 2796, in run super().run() File "/home/dberard/local/pytorch/torch/_dynamo/symbolic_convert.py", line 983, in run while self.step(): File "/home/dberard/local/pytorch/torch/_dynamo/symbolic_convert.py", line 895, in step self.dispatch_table[inst.opcode](self, inst) File "/home/dberard/local/pytorch/torch/_dynamo/symbolic_convert.py", line 582, in wrapper return inner_fn(self, inst) File "/home/dberard/local/pytorch/torch/_dynamo/symbolic_convert.py", line 1602, in CALL_FUNCTION self.call_function(fn, args, {}) File "/home/dberard/local/pytorch/torch/_dynamo/symbolic_convert.py", line 830, in call_function self.push(fn.call_function(self, args, kwargs)) # type: ignore[arg-type] File "/home/dberard/local/pytorch/torch/_dynamo/variables/functions.py", line 729, in call_function unimplemented(msg) File "/home/dberard/local/pytorch/torch/_dynamo/exc.py", line 297, in unimplemented raise Unsupported(msg, case_name=case_name) torch._dynamo.exc.Unsupported: 'skip function capture_triton in file /home/dberard/local/pytorch/torch/_library/triton.py' from user code: File "/home/dberard/local/scripts/capture_triton_skipped.py", line 24, in call_triton torch._library.capture_triton(triton_)[grid](out, inp, numel, BLOCK_SIZE) ``` ### Versions main branch ~sep 11, H100 cc @ezyang @chauhang @penguinwu @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @amjames @rec @oulgen @aakhundov @zou3519
triaged,actionable,oncall: pt2,module: dynamo,module: user triton
low
Critical
2,525,843,839
TypeScript
(JSDoc, JavaScript) Imported class types by require() are unresolved
Type: <b>Bug</b> <!-- โš ๏ธโš ๏ธ Do Not Delete This! bug_report_template โš ๏ธโš ๏ธ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- ๐Ÿ•ฎ Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions --> <!-- ๐Ÿ”Ž Search existing issues to avoid creating duplicates. --> <!-- ๐Ÿงช Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ --> <!-- ๐Ÿ’ก Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --> <!-- ๐Ÿ”ง Launch with `code --disable-extensions` to check. --> Does this issue occur when all extensions are disabled?: Yes <!-- ๐Ÿช“ If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --> <!-- ๐Ÿ“ฃ Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. --> - VS Code version: Code 1.93.1 (38c31bc77e0dd6ae88a4e9cc93428cc27a56ba40, 2024-09-11T17:20:05.685Z) - OS version: Linux x64 6.5.0-44-generic Steps to Reproduce: With source code below (`a.js` & `b.js`), there are two issues present in `b.js`, A and B. 1. Issue.B is triggered without modification. TS server reports `a.Foo` as alias of class Foo, but `Foo` as unresolved. 2. Issue.A is triggered if any of `value`/`obj` field or `prop` getter line is enabled in `a.js` exports. TS server reports `a.Foo` as unresolved. The only pattern to make TS server happy is `localObj` line. IMO diagnostics information should be presented other than the casual `/* unresolved */ any` message. ``` // a.js class Foo { constructor() { this.fprop = 123; } } const localObj = { prop: 456 }; exports = module.exports = { Foo, // value: 123, // obj: { prop: 456 }, // get prop() { return 789 }, // localObj, }; ``` ``` // b.js const a = require('./a'); const { Foo, } = a; class Bar { /** @param {a.Foo} foo */ constructor(foo) { this.bprop = foo.fprop; } } // Issue.A: a.Foo unresolved, .fprop is any /** @param {a.Foo} foo */ function bar1(foo) { foo.fprop; } // Issue.B: Foo unresolved, .fprop is any /** @param {Foo} foo */ function bar2(foo) { foo.fprop; } ``` VS Code version: Code 1.93.1 (38c31bc77e0dd6ae88a4e9cc93428cc27a56ba40, 2024-09-11T17:20:05.685Z) OS version: Linux x64 6.5.0-44-generic Modes: <details> <summary>A/B Experiments</summary> ``` vsliv368:30146709 vspor879:30202332 vspor708:30202333 vspor363:30204092 vscoreces:30445986 vscod805cf:30301675 binariesv615:30325510 vsaa593:30376534 py29gd2263:31024239 c4g48928:30535728 azure-dev_surveyone:30548225 a9j8j154:30646983 962ge761:30959799 pythongtdpath:30769146 welcomedialogc:30910334 pythonnoceb:30805159 asynctok:30898717 pythonregdiag2:30936856 pythonmypyd1:30879173 2e7ec940:31000449 pythontbext0:30879054 accentitlementst:30995554 dsvsc016:30899300 dsvsc017:30899301 dsvsc018:30899302 cppperfnew:31000557 dsvsc020:30976470 pythonait:31006305 dsvsc021:30996838 9c06g630:31013171 pythoncenvpt:31062603 a69g1124:31058053 dvdeprecation:31068756 dwnewjupyter:31046869 impr_priority:31102340 refactort:31101459 ccplti:31098112 ``` </details> <!-- generated by issue reporter -->
Needs Investigation
low
Critical
2,525,880,722
pytorch
xpu: set of aten ops are missing for Huggingface Transformers
With: * https://github.com/pytorch/pytorch/commit/cd472bb1e368a711a2bd34d5671c77dab336d312 * Plus this applied: https://github.com/pytorch/pytorch/pull/135567 * https://github.com/intel/torch-xpu-ops/commit/c6981a238cdaf93774b1c6a3550a436f530f4736 * https://github.com/huggingface/accelerate/commit/4b4c036933f7c50fe3a7027b0380fcec53c6975e * https://github.com/huggingface/transformers/commit/d70347726577e9823e35c11883e98c5b2c520b37 I was running Huggingface transformers models tests, i.e.: ``` TRANSFORMERS_TEST_DEVICE_SPEC=spec.py PYTORCH_DEBUG_XPU_FALLBACK=1 python3 -m pytest --pspec tests/models ``` Overall: * **Few aten ops not implemented for XPU (this issue is about this)** * `PYTORCH_ENABLE_XPU_FALLBACK=1` was not needed at all (which is good) * https://github.com/pytorch/pytorch/issues/136007 - hang happens in levit tests on Intel PVC (only in levit, other models ran fine) * https://github.com/huggingface/transformers/pull/33485 - few HF tests were not enabled for HW devices (cuda/xpu wise), this PR adds support The following aten ops are not yet implemented for XPU and affect HF tests. Please, implement: - [x] `aten::_ctc_loss`, https://github.com/intel/torch-xpu-ops/pull/925 - [x] `aten::_ctc_loss_backward`, https://github.com/intel/torch-xpu-ops/pull/925 - [ ] `aten::_fft_c2c`, https://github.com/intel/torch-xpu-ops/pull/526 - [ ] `aten::_fft_c2r` - [ ] `aten::_fft_r2c` - [x] `aten::index_copy.out`, https://github.com/intel/torch-xpu-ops/pull/793 - [x] `aten::linspace.out`, https://github.com/intel/torch-xpu-ops/pull/850 - [x] `aten::take`, https://github.com/intel/torch-xpu-ops/pull/868 - [x] `aten::upsample_bicubic2d_backward.grad_input`, https://github.com/intel/torch-xpu-ops/pull/914 - [x] `aten::xlogy.OutTensor`, https://github.com/intel/torch-xpu-ops/pull/697 CC: @gujinghui @EikanWang @fengyuan14 @guangyey @jgong5 cc @gujinghui @EikanWang @fengyuan14 @guangyey
triaged,module: xpu
low
Critical
2,525,886,154
rust
unnamed_fields allows unnamed enum variants which behave oddly
Example: ```rust enum E { _, _ = 1, _(), _ {}, } ``` I don't think this is intended; unnamed fields are described for `struct` and `union`, but not for `enum`. A built-in derived trait implementation appears to work as long as only a single unnamed variant exists, but more than one unnamed variant usually (but not always) results in errors (e.g. non-exhaustive patterns or attempting to use the wrong kind of variant). These should probably just be forbidden. There's probably no harm in allowing the syntax, but semantically unnamed variants don't make any real sense. *Maybe* they could in an โ€œinline the variantsโ€ manner, but that very much isn't the currently observed behavior. ### Meta rustc 1.83.0-nightly (2024-09-12 adaff5368b0c7b328a03) @rustbot label: +F-unnamed-fields +requires-incomplete-features
T-compiler,C-bug,requires-incomplete-features,F-unnamed_fields
low
Critical
2,525,916,157
pytorch
DOT/SVG Generation of Quantization Annotated FX Graphs Broken on 2.5.0.dev20240901
### ๐Ÿ› Describe the bug During our FX based workflows, we generate DOT/SVG outputs of FX graphs during every stage of the process. On the latest PyTorch releases, the DOT generation of quantization annotated graphs seem to be broken. Here's a simple example code to reproduce this issue: ```python import torch import torch.nn as nn from torch.ao.quantization.quantize_pt2e import prepare_pt2e from torch.ao.quantization.quantizer.xnnpack_quantizer import ( XNNPACKQuantizer, get_symmetric_quantization_config ) from torch.fx.passes.graph_drawer import FxGraphDrawer # author a model. class MLPNet(nn.Module): def __init__(self): super(MLPNet, self).__init__() self.conv1 = nn.Conv1d(2,4,3,padding=(1,1)) self.relu1 = nn.ReLU() self.fc1 = nn.Linear(64, 64) self.relu1 = nn.ReLU() self.fc2 = nn.Linear(64, 32) self.relu2 = nn.ReLU() def forward(self, x, y): layer10 = self.relu1(self.fc1(x)) layer11 = self.relu1(self.fc1(y)) out = self.relu2(self.fc2(layer10 + layer11)) return out def name(self): return "MLP" model = MLPNet().eval() # generate a uniform distribution of data. n_batches = 100 # generate some example input. x_in = torch.distributions.uniform.Uniform(-1, 1).sample([n_batches, 64, 64]) # export the model. m_pre = torch.export.export(model, (x_in[0,:], x_in[0,:])).module() # prepare annotated graph. quantizer = XNNPACKQuantizer() quantizer.set_global(get_symmetric_quantization_config()) m_annot = prepare_pt2e(m_pre, quantizer) # generate DOT/SVG graphs. g_dot = FxGraphDrawer(m_annot, "Model") g_dot.get_dot_graph().write_raw("annotated_graph{}.dot".format(torch.__version__)) g_dot.get_dot_graph().write_svg("annotated_graph{}.svg".format(torch.__version__)) ``` This produces the following error: ``` $ python3 tests/repro/etorch_example.py "dot" with args ['-Tsvg', '/tmp/tmphnnemdsx'] returned code: 1 stdout, stderr: b'' b"Error: /tmp/tmphnnemdsx: syntax error in line 5 near '.'\n" Traceback (most recent call last): File "/<...>/tests/repro/etorch_example.py", line 49, in <module> g_dot.get_dot_graph().write_svg("annotated_graph{}.svg".format(torch.__version__)) File "/opt/conda/envs/executorch/lib/python3.10/site-packages/pydot/core.py", line 177, in __write_method self.write(path, format=f, prog=prog, encoding=encoding) File "/opt/conda/envs/executorch/lib/python3.10/site-packages/pydot/core.py", line 1708, in write s = self.create(prog, format, encoding=encoding) File "/opt/conda/envs/executorch/lib/python3.10/site-packages/pydot/core.py", line 1825, in create assert process.returncode == 0, ( AssertionError: "dot" with args ['-Tsvg', '/tmp/tmphnnemdsx'] returned code: 1 ``` When I compare the version of `.dot` files produced between the working (`2.5.0.dev20240618+cpu`) and not-working (`2.5.0.dev20240901`) versions, I see that the not-working version is missing quotes which the dot program doesn't seem to like. Working: ```dot "activation_post_process_1.eps" -> activation_post_process_1; "activation_post_process_1.min_val" [fillcolor=Salmon, fontcolor="#000000", label="{buffer\ltorch.float32[]\n}", shape=record, style="filled,rounded"]; ``` Not-Working: ```dot activation_post_process_1.eps -> activation_post_process_1; activation_post_process_1.min_val [label="{buffer\ltorch.float32[]\n}", fillcolor=Salmon, style="filled,rounded", fontcolor="#000000", shape=record]; ``` My dot version is `12.0.0 (20240803.0821)`. Please let me know if I can provide more information. ### Versions PyTorch version: 2.5.0.dev20240901+cpu Is debug build: False CUDA used to build PyTorch: None ROCM used to build PyTorch: N/A OS: Debian GNU/Linux 11 (bullseye) (x86_64) GCC version: (Debian 10.2.1-6) 10.2.1 20210110 Clang version: 11.0.1-2 CMake version: version 3.30.3 Libc version: glibc-2.31 Python version: 3.10.0 | packaged by conda-forge | (default, Nov 20 2021, 02:24:10) [GCC 9.4.0] (64-bit runtime) Python platform: Linux-4.12.14-122.183-default-x86_64-with-glibc2.31 Is CUDA available: False CUDA runtime version: No CUDA CUDA_MODULE_LOADING set to: N/A GPU models and configuration: No CUDA Nvidia driver version: No CUDA cuDNN version: No CUDA HIP runtime version: N/A MIOpen runtime version: N/A Is XNNPACK available: True Versions of relevant libraries: [pip3] executorch==0.4.0a0+6328d41 [pip3] numpy==1.26.4 [pip3] onnx==1.16.2 [pip3] torch==2.5.0.dev20240901+cpu [pip3] torchaudio==2.5.0.dev20240901+cpu [pip3] torchsr==1.0.4 [pip3] torchvision==0.20.0.dev20240901+cpu [conda] executorch 0.4.0a0+6328d41 pypi_0 pypi [conda] numpy 1.26.4 pypi_0 pypi [conda] torch 2.5.0.dev20240901+cpu pypi_0 pypi [conda] torchaudio 2.5.0.dev20240901+cpu pypi_0 pypi [conda] torchsr 1.0.4 pypi_0 pypi [conda] torchvision 0.20.0.dev20240901+cpu pypi_0 pypi cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv @avikchaudhuri @gmagogsfm @zhxchen17 @tugsbayasgalan @angelayi @suo @ydwu4 @penguinwu @chauhang
triaged,module: fx,oncall: pt2,oncall: fx,oncall: export
low
Critical
2,525,926,014
PowerToys
Mouse cursor anomaly
### Microsoft PowerToys version 0.84.1 ### Installation method PowerToys auto-update ### Running as admin Yes ### Area(s) with issue? Mouse Without Borders ### Steps to reproduce Mouse without borders, sometimes the pointer disappears or the cursor jumps here and there. With the stand-alone Mouse without borders, which is not Power Toys, such an event has not occurred. Please investigate and address the cause. ### โœ”๏ธ Expected Behavior _No response_ ### โŒ Actual Behavior _No response_ ### Other Software _No response_
Issue-Bug,Needs-Triage
low
Minor
2,525,929,546
PowerToys
Keyboard shortcut for moving windows in FancyZones doesn't work when Windows key is remapped in Keyboard Manager
### Microsoft PowerToys version 0.84.1 ### Installation method GitHub ### Running as admin No ### Area(s) with issue? FancyZones ### Steps to reproduce 1. Configure Keyboard Manager as below. ![image](https://github.com/user-attachments/assets/6dbb8462-6982-4802-8775-11c0f8c0821d) 2. Press Win + arrow keys ### โœ”๏ธ Expected Behavior Active window will be moved and reshaped according to the layout settngs. ### โŒ Actual Behavior Active window is moved but doesn't follow the layout settings. It seems that windows default snap function works instead of fancyzones. ### Other Software _No response_
Issue-Bug,Needs-Triage
low
Minor
2,525,942,020
godot
RigidBody3D and CharacterBody3D do not register collision
### Tested versions Tested in: v4.3.stable.official [77dcf97d8] v4.0.stable.official [92bee43ad] ### System information Godot v4.3.stable - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3060 (NVIDIA; 31.0.15.5134) - AMD Ryzen 5 5600G with Radeon Graphics (12 Threads) ### Issue description When a RigidBody collides with a CharacterBody (e.g. an object falls on top of the player) the RigidBody will register its `_on_body_entered` event. However, if the CharacterBody collides with the RigidBody (e.g. the player walks into an obstacle), said RigidBody will not have its `_on_body_entered` event triggered. In both cases the CharacterBody does register the collision since move_and_slide returns True (as seen in the minimal reproduction project) ### Steps to reproduce Create a RigidBody3D or 2D with a collision shape. Create a CharacterBody 3D or 2D (matching the RigidBody) with a collision shape. Create a ground-plane for the RigidBody to sit on, or set RigidBody gravity to 0 to keep it in case (in MRP a ground-plane is added). Drop the RigidBody on top of the Character by placing it above the CharacterBody. Note how this will trigger a `_on_body_entered` event. When the CharacterBody is given a script to move into the RigidBody, the even is not triggered. ### Minimal reproduction project (MRP) [MRP.zip](https://github.com/user-attachments/files/17000663/MRP.zip)
topic:physics,needs testing
low
Minor
2,525,944,402
godot
Controller vibration not working in HTML5
### Tested versions 4.3 and earlier ### System information Windows / OSX, Chrome ### Issue description Input.start_joy_vibration() does nothing in HTML exports. May be related to #73446 . ### Steps to reproduce Export a game to HTML5 that runs Input.start_joy_vibration() and upload it to a webserver. No vibration. ### Minimal reproduction project (MRP) N/A
bug,platform:web,topic:input
low
Minor
2,525,954,669
pytorch
Setting wrong type values to `stride`, `padding`, `output_padding` and `dilation` argument of `nn.ConvTranspose1d()` gets the wrong error messages saying only `tuple of ints`
### ๐Ÿ› Describe the bug [The doc](https://pytorch.org/docs/stable/generated/torch.nn.ConvTranspose1d.html) of `nn.ConvTranspose1d()` says `stride`, `padding`, `output_padding` and `dilation` argument are (`int` or `tuple`, optional) as shown below: > Parameters > - ... > - stride ([int](https://docs.python.org/3/library/functions.html#int) or [tuple](https://docs.python.org/3/library/stdtypes.html#tuple), optional) โ€“ Stride of the convolution. Default: 1 > - padding ([int](https://docs.python.org/3/library/functions.html#int) or [tuple](https://docs.python.org/3/library/stdtypes.html#tuple), optional) โ€“ dilation * (kernel_size - 1) - padding zero-padding will be added to both sides of the input. Default: 0 > - output_padding ([int](https://docs.python.org/3/library/functions.html#int) or [tuple](https://docs.python.org/3/library/stdtypes.html#tuple), optional) โ€“ Additional size added to one side of the output shape. Default: 0 > - ... > - dilation ([int](https://docs.python.org/3/library/functions.html#int) or [tuple](https://docs.python.org/3/library/stdtypes.html#tuple), optional) โ€“ Spacing between kernel elements. Default: 1 But setting wrong type values to them gets the wrong error messages saying only `tuple of ints` as shown below. *It also happens with [nn.ConvTranspose2d()](https://pytorch.org/docs/stable/generated/torch.nn.ConvTranspose2d.html) and [nn.ConvTranspose3d()](https://pytorch.org/docs/stable/generated/torch.nn.ConvTranspose3d.html): ```python import torch from torch import nn my_tensor = torch.tensor([[8., -3., 0., 1., 5., -2.]]) # โ†“โ†“ convtran1d = nn.ConvTranspose1d(in_channels=1, out_channels=3, kernel_size=1, stride=1.) convtran1d(input=my_tensor) # Error # โ†“โ†“ convtran1d = nn.ConvTranspose1d(in_channels=1, out_channels=3, kernel_size=1, padding=0.) convtran1d(input=my_tensor) # Error # โ†“โ†“ convtran1d = nn.ConvTranspose1d(in_channels=1, out_channels=3, kernel_size=1, output_padding=0.) convtran1d(input=my_tensor) # Error # โ†“โ†“ convtran1d = nn.ConvTranspose1d(in_channels=1, out_channels=3, kernel_size=1, dilation=1.) convtran1d(input=my_tensor) # Error ``` > TypeError: conv_transpose1d(): argument 'stride' (position 4) must be tuple of ints, but found element of type float at pos 0 > TypeError: conv_transpose1d(): argument 'padding' (position 5) must be tuple of ints, but found element of type float at pos 0 > TypeError: conv_transpose1d(): argument 'output_padding' (position 6) must be tuple of ints, but found element of type float at pos 0 > TypeError: conv_transpose1d(): argument 'dilation' (position 8) must be tuple of ints, but found element of type float at pos 0 So, they should be something like as shown below. *`list` of `int` also works so `list` of `int` can also be added: > TypeError: conv_transpose1d(): argument 'stride' (position 4) must be `int` or `tuple` of `int`, but found element of type float at pos 0 > TypeError: conv_transpose1d(): argument 'padding' (position 5) must be `int` or `tuple` of `int`, but found element of type float at pos 0 > TypeError: conv_transpose1d(): argument 'output_padding' (position 6) must be `int` or `tuple` of `int`, but found element of type float at pos 0 > TypeError: conv_transpose1d(): argument 'dilation' (position 8) must be `int` or `tuple` of `int`, but found element of type float at pos 0 ### Versions ```python import torch torch.__version__ # '2.3.0' ``` cc @albanD @mruberry @jbschlosser @walterddr @mikaylagawarecki
module: nn,triaged
low
Critical
2,525,964,110
pytorch
`padding_mode` parameter of `nn.ConvTranspose1d()`, `nn.ConvTranspose2d()` and `nn.ConvTranspose3d()` is not explained in the docs
### ๐Ÿ“š The doc issue [nn.ConvTranspose1d()](https://pytorch.org/docs/stable/generated/torch.nn.ConvTranspose1d.html), [nn.ConvTranspose2d()](https://pytorch.org/docs/stable/generated/torch.nn.ConvTranspose2d.html) and [nn.ConvTranspose3d()](https://pytorch.org/docs/stable/generated/torch.nn.ConvTranspose3d.html) has `padding_mode` parameter according to the docs as shown below: > CLASS torch.nn.ConvTranspose1d(in_channels, out_channels, kernel_size, stride=1, padding=0, output_padding=0, groups=1, bias=True, dilation=1, padding_mode='zeros', device=None, dtype=None) > CLASS torch.nn.ConvTranspose2d(in_channels, out_channels, kernel_size, stride=1, padding=0, output_padding=0, groups=1, bias=True, dilation=1, padding_mode='zeros', device=None, dtype=None) > CLASS torch.nn.ConvTranspose3d(in_channels, out_channels, kernel_size, stride=1, padding=0, output_padding=0, groups=1, bias=True, dilation=1, padding_mode='zeros', device=None, dtype=None) `padding_mode` parameter is not explained in the docs as shown below: > Parameters > - in_channels ([int](https://docs.python.org/3/library/functions.html#int)) โ€“ Number of channels in the input image > - out_channels ([int](https://docs.python.org/3/library/functions.html#int)) โ€“ Number of channels produced by the convolution > - kernel_size ([int](https://docs.python.org/3/library/functions.html#int) or [tuple](https://docs.python.org/3/library/stdtypes.html#tuple)) โ€“ Size of the convolving kernel > - stride ([int](https://docs.python.org/3/library/functions.html#int) or [tuple](https://docs.python.org/3/library/stdtypes.html#tuple), optional) โ€“ Stride of the convolution. Default: 1 > - padding ([int](https://docs.python.org/3/library/functions.html#int) or [tuple](https://docs.python.org/3/library/stdtypes.html#tuple), optional) โ€“ dilation * (kernel_size - 1) - padding zero-padding will be added to both sides of the input. Default: 0 > - output_padding ([int](https://docs.python.org/3/library/functions.html#int) or [tuple](https://docs.python.org/3/library/stdtypes.html#tuple), optional) โ€“ Additional size added to one side of the output shape. Default: 0 > - groups ([int](https://docs.python.org/3/library/functions.html#int), optional) โ€“ Number of blocked connections from input channels to output channels. Default: 1 > - bias ([bool](https://docs.python.org/3/library/functions.html#bool), optional) โ€“ If True, adds a learnable bias to the output. Default: True > - dilation ([int](https://docs.python.org/3/library/functions.html#int) or [tuple](https://docs.python.org/3/library/stdtypes.html#tuple), optional) โ€“ Spacing between kernel elements. Default: 1 ### Suggest a potential alternative/fix So `padding_mode` parameter should be explained in the docs as shown below: > Parameters > ... > - dilation ([int](https://docs.python.org/3/library/functions.html#int) or [tuple](https://docs.python.org/3/library/stdtypes.html#tuple), optional) โ€“ Spacing between kernel elements. Default: 1 > - padding_mode ([str](https://docs.python.org/3/library/stdtypes.html#str), optional) โ€“ Only `'zeros'` can be selected. Default: 'zeros' cc @albanD @mruberry @jbschlosser @walterddr @mikaylagawarecki
module: nn,triaged
low
Minor
2,525,968,889
ant-design
antd Cascader็บง่”้€‰ๆ‹ฉๆก†ๅฑ•ๅผ€่งฆๅ‘ๆ”นๆˆhoverๆ—ถ๏ผŒๅฎนๆ˜“่ฏฏๆ“ไฝœใ€‚
### What problem does this feature solve? ๅทฒ็ปๆœ‰ไบบๆ่ฟ‡issue๏ผšhttps://github.com/ant-design/ant-design/issues/1065 ้‡็Žฐ๏ผš่ฎพ็ฝฎ10ๅ‡ ๆกๆ•ฐๆฎ๏ผŒๅ…ˆ้€‰ๆ‹ฉไธ€็บง้ ไธ‹็š„้กน๏ผŒๅ†้€‰ไบŒ็บง้ ไธŠ็š„้กน๏ผŒ่ฟ™ๆ—ถๅ€™ๅพˆๅคงๆฆ‚็އๅˆ’่ฟ‡ๅ…ถๅฎƒไธ€็บง้กน๏ผŒๅฏผ่‡ดไบŒ็บง้กนๅ˜ๆˆไธๆ˜ฏไฝ ่ฆ้€‰ๆ‹ฉ็š„ๆ•ฐๆฎใ€‚ ### What does the proposed API look like? ๆœ‰ไธ€ไธชๅปถๆ—ถๅฑ•ๅผ€็š„apiไพ›็ป™็”จๆˆท่ฎพ่ฎก๏ผŒๆˆ–่€…ๆœ‰ๆฒกๆœ‰ๅ…ถไป–ๆ–นๅผๅฏไปฅ่งฃๅ†ณๆ€Žไนˆ้—ฎ้ข˜ใ€‚ <!-- generated by ant-design-issue-helper. DO NOT REMOVE -->
Inactive,improvement
low
Minor
2,525,971,686
flutter
ToggleButton border radius and fill gets inverted only in Flutter Web with HTML renderer
### Steps to reproduce 1. Create a Flutter project with web enabled 2. Use the provided code in the project as a widget 3. Run the app with following: `flutter run -d web-server --web-renderer html --web-port 3000 --debug` 4. Open browser in `localhost:3000` and see the result ### Expected results The radius and fill should be symmetric. ### Actual results The radius is inwards and the fill is inverted resulting in a asymmetric radius and fill ### Code sample <details open><summary>Code sample</summary> ```dart class Example extends StatefulWidget { const Example({super.key}); @override State<Example> createState() => _ExampleState(); } class _ExampleState extends State<Example> { List<bool> isSelected = [true, false]; @override Widget build(BuildContext context) { final ThemeData(:textTheme) = Theme.of(context); return ToggleButtons( borderRadius: BorderRadius.circular(30), textStyle: textTheme.bodySmall, constraints: const BoxConstraints(maxHeight: 40), isSelected: isSelected, onPressed: (index) { setState(() { for (var i = 0; i < isSelected.length; i++) { isSelected[i] = i == index; } }); }, children: const [ Padding( padding: EdgeInsets.all(8.0), child: Text("Asset (e.g. bank account)"), ), Padding( padding: EdgeInsets.all(8.0), child: Text("Liability (e.g. credit card)"), ), ], ); } } ``` </details> ### Screenshots or Video <details open> <summary>Screenshots / Video demonstration</summary> <img width="491" alt="image" src="https://github.com/user-attachments/assets/76f8b18a-05c8-4c32-bf6d-4ea60f09506a"> </details> ### Flutter Doctor output <details open><summary>Doctor output</summary> ```console [โœ“] Flutter (Channel stable, 3.22.3, on macOS 14.6.1 23G93 darwin-arm64, locale en-BD) โ€ข Flutter version 3.22.3 on channel stable at /Users/krtirtho/fvm/versions/3.22.3 โ€ข Upstream repository https://github.com/flutter/flutter.git โ€ข Framework revision b0850beeb2 (8 weeks ago), 2024-07-16 21:43:41 -0700 โ€ข Engine revision 235db911ba โ€ข Dart version 3.4.4 โ€ข DevTools version 2.34.3 [โœ“] Android toolchain - develop for Android devices (Android SDK version 34.0.0) โ€ข Android SDK at /Users/krtirtho/Library/Android/sdk โ€ข Platform android-34, build-tools 34.0.0 โ€ข Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java โ€ข Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314) โ€ข All Android licenses accepted. [โœ“] Xcode - develop for iOS and macOS (Xcode 15.4) โ€ข Xcode at /Applications/Xcode.app/Contents/Developer โ€ข Build 15F31d โ€ข CocoaPods version 1.15.2 [โœ“] Chrome - develop for the web โ€ข CHROME_EXECUTABLE = /Applications/Brave Browser.app/Contents/MacOS/Brave Browser [โœ“] Android Studio (version 2024.1) โ€ข Android Studio at /Applications/Android Studio.app/Contents โ€ข Flutter plugin can be installed from: ๐Ÿ”จ https://plugins.jetbrains.com/plugin/9212-flutter โ€ข Dart plugin can be installed from: ๐Ÿ”จ https://plugins.jetbrains.com/plugin/6351-dart โ€ข Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314) [โœ“] VS Code (version 1.93.0) โ€ข VS Code at /Applications/Visual Studio Code.app/Contents โ€ข Flutter extension version 3.84.0 [โœ“] Connected device (3 available) โ€ข macOS (desktop) โ€ข macos โ€ข darwin-arm64 โ€ข macOS 14.6.1 23G93 darwin-arm64 โ€ข Mac Designed for iPad (desktop) โ€ข mac-designed-for-ipad โ€ข darwin โ€ข macOS 14.6.1 23G93 darwin-arm64 โ€ข Chrome (web) โ€ข chrome โ€ข web-javascript โ€ข Brave Browser 128.1.69.168 [โœ“] Network resources โ€ข All expected network resources are available. โ€ข No issues found! ``` </details>
engine,platform-web,c: rendering,e: web_html,has reproducible steps,P3,team-web,triaged-web,found in release: 3.24,found in release: 3.26
low
Critical
2,525,972,355
neovim
Out of bounds memory access in large `:term` sessions.
### Problem If you use the neovim terminal and zoom the terminal out too far. Then when you run a command with a large horizontal output, you will get a SIGSEGV (out of bounds memory access). I'm gonna take a stab at diving into this issue to see if I can fix it this weekend but I wanted to report it too. ### Steps to reproduce ``` nvim --clean :term # Zoom all the way out in alacritty with ctrl&- (Any terminal with far enough zoomout) # In any posix-ish compliant shell (You just need to generate long enough horizontal lines) for i in $(seq 1 10000); do echo -n $i; done # This reliably causes a SIGSEGV (out of bounds memory access) independent of shell. ``` ### Expected behavior I would expect nvim to not segfault (even just killing the term instead of all of nvim would be better). Also, this may seem like a niche edge case, but I frequently do this when logging buffers while debugging. ### Neovim version (nvim -v) NVIM v0.10.1 Build type: Release LuaJIT 2.1.1723675123 ### Vim (not Nvim) behaves the same? no, 9.1.707 (It seems like vim just limits term size) ### Operating system/version Arch Linux ### Terminal name/version Alacritty ### $TERM environment variable alacritty ### Installation pacman (release version)
terminal,needs:repro,bug-crash
low
Critical
2,525,972,438
pytorch
The real AttributeError information
### ๐Ÿ› Describe the bug subclass of nn.Module can't show correct attribute error message. Just see the code: ```python import torch.nn as nn class ModelOptions: def __init__(self, idx, name): self.idx = idx self._name = name MODEL_OPT = ModelOptions(1, "unet") class SomeModel(nn.Module): def __init__(self): super(SomeModel, self).__init__() self.model1 = None self.model2 = None @property def inner_model(self): if MODEL_OPT.idx == 1: print("Using Model {}".format(MODEL_OPT.name)) # Note: here i typed wrong `name` on purpose return self.model1 model = SomeModel() print(model.inner_model) # Note: the bug is here, it should print 'MODEL_OPT' object has no attribute 'name', NOT AttributeError: 'SomeModel' object has no attribute 'inner_model' ``` ### Versions PyTorch version: 2.3.1+cu121 Is debug build: False CUDA used to build PyTorch: 12.1 ROCM used to build PyTorch: N/A OS: Microsoft Windows 11 ไธ“ไธš็‰ˆ GCC version: (Rev5, Built by MSYS2 project) 13.2.0 Clang version: 17.0.6 CMake version: version 3.28.3 Libc version: N/A Python version: 3.11.8 | packaged by Anaconda, Inc. | (main, Feb 26 2024, 21:34:05) [MSC v.1916 64 bit (AMD64)] (64-bit runtime) Python platform: Windows-10-10.0.22631-SP0 Is CUDA available: True CUDA runtime version: 12.3.107 CUDA_MODULE_LOADING set to: LAZY GPU models and configuration: GPU 0: NVIDIA GeForce RTX 4070 Ti SUPER Nvidia driver version: 560.70 cuDNN version: C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v12.3\bin\cudnn_ops_train64_8.dll HIP runtime version: N/A MIOpen runtime version: N/A Is XNNPACK available: True CPU: Architecture=9 CurrentClockSpeed=3400 DeviceID=CPU0 Family=198 L2CacheSize=24576 L2CacheSpeed= Manufacturer=GenuineIntel MaxClockSpeed=3400 Name=13th Gen Intel(R) Core(TM) i7-13700K ProcessorType=3 Revision= Versions of relevant libraries: [pip3] clip-anytorch==2.6.0 [pip3] dctorch==0.1.2 [pip3] ema-pytorch==0.5.1 [pip3] numpy==1.26.2 [pip3] onnx==1.15.0 [pip3] onnxruntime-gpu==1.17.1 [pip3] open-clip-torch==2.20.0 [pip3] optree==0.12.1 [pip3] pytorch-fid==0.3.0 [pip3] pytorch-lightning==1.9.4 [pip3] torch==2.3.1+cu121 [pip3] torchaudio==2.3.1+cu121 [pip3] torchdiffeq==0.2.3 [pip3] torchmetrics==1.3.1 [pip3] torchsde==0.2.6 [pip3] torchvision==0.18.1 [conda] blas 1.0 mkl [conda] clip-anytorch 2.6.0 pypi_0 pypi [conda] dctorch 0.1.2 pypi_0 pypi [conda] ema-pytorch 0.5.1 pypi_0 pypi [conda] mkl 2021.4.0 pypi_0 pypi [conda] mkl-service 2.4.0 py311h2bbff1b_1 [conda] mkl_fft 1.3.8 py311h2bbff1b_0 [conda] mkl_random 1.2.4 py311h59b6b97_0 [conda] numpy 1.26.2 pypi_0 pypi [conda] open-clip-torch 2.20.0 pypi_0 pypi [conda] optree 0.12.1 pypi_0 pypi [conda] pytorch-cuda 12.1 hde6ce7c_5 pytorch [conda] pytorch-fid 0.3.0 pypi_0 pypi [conda] pytorch-lightning 1.9.4 pypi_0 pypi [conda] pytorch-mutex 1.0 cuda pytorch [conda] torch 2.3.1+cu121 pypi_0 pypi [conda] torchaudio 2.3.1+cu121 pypi_0 pypi [conda] torchdiffeq 0.2.3 pypi_0 pypi [conda] torchmetrics 1.3.1 pypi_0 pypi [conda] torchsde 0.2.6 pypi_0 pypi [conda] torchvision 0.18.1 pypi_0 pypi cc @albanD @mruberry @jbschlosser @walterddr @mikaylagawarecki
module: nn,triaged
low
Critical
2,525,984,029
ui
[bug]: `globals.css` contains default NextJS CSS variables that interfere with the theme
### Describe the bug **Issue:** After running `npx shadcn@latest init -d`, the resulting `globals.css` contains both the default NextJS setup as well as the themed css variables. These variables overlap and cause issues with the tailwind setup created via the shadcn command. As a concrete example, the `tailwind.config.ts` background looks like this: `background: "hsl(var(--background))"` (note that it expects `--background` to be a hsl value. The problem is that the default NextJS setup uses hex for the themed colors. These override the ones specified by the shadcn theme and effectively corrupt the theme. The resulting style given to the browser looks like: ```css .bg-background { background-color: hsl(#ffffff); } ``` Note that it is trying to use a hex value as an hsl value. Since the value passed to the browser is not valid, it renders the background color as transparent which messes with all of the components that rely on this background theming (read: practically all of them). I noticed this initially on the slider component as the thumb was entirely transparent. **Expected:** The resulting `globals.css` file should not contain the default NextJS setup. **Workaround:** If others face this issue and notice that their components look a little funny, simply remove the default NextJS theming (first `:root` block through to the first `@layer utilities` block See the first part of the resulting `globals.css` file below: ```css @tailwind base; @tailwind components; @tailwind utilities; :root { --background: #ffffff; --foreground: #171717; } @media (prefers-color-scheme: dark) { :root { --background: #0a0a0a; --foreground: #ededed; } } body { color: var(--foreground); background: var(--background); font-family: Arial, Helvetica, sans-serif; } @layer utilities { .text-balance { text-wrap: balance; } } @layer base { :root { --background: 0 0% 100%; --foreground: 0 0% 3.9%; ... ``` ### Affected component/components All ### How to reproduce 1. Run `npx shadcn@latest init -d` 2. Install slider `npx shadcn@latest add slider` 3. Add slider to component and observe transparent slider thumb. ### Codesandbox/StackBlitz link _No response_ ### Logs _No response_ ### System Info ```bash Shadcn: 2.0.6 ``` ### Before submitting - [X] I've made research efforts and searched the documentation - [X] I've searched for existing issues
bug
low
Critical
2,525,984,272
transformers
Clarify what kwargs can be accepted by "AutoModelForCausalLM.from_pretrained()"
### Feature request i saw in the doc saying:If a configuration is not provided, kwargs will be first passed to the configuration class initialization function ([from_pretrained()](https://huggingface.co/docs/transformers/main/en/main_classes/configuration#transformers.PretrainedConfig.from_pretrained)). Each key of kwargs that corresponds to a configuration attribute will be used to override said attribute with the supplied kwargs value. Remaining keys that do not correspond to any configuration attribute will be passed to the underlying modelโ€™s __init__ function. but I can't seem to find the __init__(I found 3 lines with __init__, but no useful info). I saw some one added "use_cache:Ture" but don't know how this got handled and set,maybe it's discarded. ### Motivation i checked the doc and source code but still confused. ### Your contribution I'll keep looking
Feature request
low
Minor
2,525,988,550
kubernetes
Possible dereferencing a nil pointer in pkg/registry/generic/registry/store.go
Hello, colleagues! After having been compared to a _nil value_ at store.go:1398,1402,1408, pointer 'options' is dereferenced at store.go:1412. https://github.com/kubernetes/kubernetes/blob/f0f7ff989a948389247e628c4c5a43e915f51daa/staging/src/k8s.io/apiserver/pkg/registry/generic/registry/store.go#L1398 https://github.com/kubernetes/kubernetes/blob/f0f7ff989a948389247e628c4c5a43e915f51daa/staging/src/k8s.io/apiserver/pkg/registry/generic/registry/store.go#L1402 https://github.com/kubernetes/kubernetes/blob/f0f7ff989a948389247e628c4c5a43e915f51daa/staging/src/k8s.io/apiserver/pkg/registry/generic/registry/store.go#L1408 It seems you've just missed add a "nill-deref check" here when make this [commit](https://github.com/kubernetes/kubernetes/commit/e1537fc41b9eecb0e5026bfc72b27e4a07d771ba). https://github.com/kubernetes/kubernetes/blob/f0f7ff989a948389247e628c4c5a43e915f51daa/staging/src/k8s.io/apiserver/pkg/registry/generic/registry/store.go#L1412-L1412 Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE. Author E. Bykhanova ([e.bykhanova@fobos-nt.ru](mailto:e.bykhanova@fobos-nt.ru)).
sig/api-machinery,triage/accepted
medium
Major
2,525,991,676
pytorch
torch._dynamo.exc.Unsupported: builtin: bool [<class 'torch._dynamo.variables.tensor.SymNodeVariable'>] False
### ๐Ÿ› Describe the bug ``` import torch from torch.export import export import torch._functorch.config class Foo(torch.nn.Module): def forward(self, x): return bool(x.eq(0.1).any().item()) model = Foo() inputs = (torch.randn(64),) with torch._functorch.config.patch(fake_tensor_propagate_real_tensors=True): ep = export(model, inputs, strict=True) ``` WAR is to convert to int first before bool lol. Maybe it shouldn't spec though... ### Versions main cc @penguinwu @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @rec
good first issue,triaged,oncall: pt2,module: dynamic shapes,module: dynamo
low
Critical
2,525,997,633
ant-design
TabsๆŽงไปถไพ่ต–็š„resize-observer-polyfill้‡Œ้ขๆœ‰ไธ€ไธชๅŠจๆ€ไปฃ็ ๆ‰ง่กŒ ๅฏผ่‡ดNextJS 14็ผ–่ฏ‘npm run buildๆŠฅๅ‘ŠๅŠจๆ€ไปฃ็ ๆ‰ง่กŒ้”™่ฏฏ Dynamic Code Evaluation (e. g. 'eval', 'new Function', 'WebAssembly.compile') not allowed in Edge Runtime
### Reproduction link [![Edit on StackBlitz](https://developer.stackblitz.com/img/open_in_stackblitz.svg)](https://stackblitz.com/edit/antd-reproduce-5x-1iybka?file=demo.tsx) ### Steps to reproduce /* Antd็š„Tabs็ฉบ้—ดไพ่ต–็š„resize-observer-polyfill็š„ๆ–‡ไปถ node_modules\resize-observer-polyfill\dist\ResizeObserver.es.js ้‡Œ้ขๆœ‰ไธ€ๆฎตๅŠจๆ€ๆ‰ง่กŒ็š„ไปฃ็ ๏ผŒๅฏผ่‡ดnextjs npm run build ๆŠฅ้”™ ๆŠฅ้”™ไฟกๆฏๅฆ‚ไธ‹๏ผš ./node_modules\resize-observer-polyfill\dist\ResizeObserver.es.js Dynamic Code Evaluation (e. g. 'eval', 'new Function', 'WebAssembly.compile') not allowed in Edge Runtime Learn More: https://nextjs.org/docs/messages/edge-dynamic-code-evaluation ้‚ฃไธชResizeObserver.es.jsๆ–‡ไปถๅ‡บ้”™็š„ๅœฐๆ–นๅœจ่ฟ™้‡Œ var global$1 = (function () { if (typeof global !== 'undefined' && global.Math === Math) { return global; } if (typeof self !== 'undefined' && self.Math === Math) { return self; } if (typeof window !== 'undefined' && window.Math === Math) { return window; } // eslint-disable-next-line no-new-func return Function('return this')(); <----- ใ€ใ€ใ€ใ€ใ€่ฟ™ไธชๅ‡บ้”™ใ€‘ใ€‘ใ€‘ใ€‘ใ€‘ })(); */ ### What is expected? nextjs่ถŠๆฅ่ถŠ็ซ๏ผŒๅบ”่ฏฅๅ…ผๅฎนnextjs ### What is actually happening? nextjs่ถŠๆฅ่ถŠ็ซ๏ผŒๅบ”่ฏฅๅ…ผๅฎนnextjs | Environment | Info | | --- | --- | | antd | 5.20.5 | | React | 18 | | System | nodejs 20 | | Browser | chrome | <!-- generated by ant-design-issue-helper. DO NOT REMOVE -->
Inactive,๐Ÿงถ Low Priority
low
Minor
2,526,004,787
rust
Tracking Issue for `abort_unwind`
Feature gate: `#![feature(abort_unwind)]` This is a tracking issue for `core::panic::abort_unwind`. `abort_unwind` is similar to `catch_unwind`, except that it aborts the process if it unwinds instead of catching the unwind. Prior to the abort, the panic hook is called in the same way that it is for other functions that cannot unwind (e.g. `extern "C" fn`). ### Public API ```rust // in core::panic (and std::panic) fn abort_unwind<F: FnOnce() -> R, R>(f: F) -> R; ``` ### Steps / History <!-- For larger features, more steps might be involved. If the feature is changed later, please add those PRs here as well. --> - [x] ACP: https://github.com/rust-lang/libs-team/issues/441 - [x] Implementation: https://github.com/rust-lang/rust/pull/130339 - [ ] Final naming (`abort_on_unwind`)? - [ ] Improve documentation (add example)? - [ ] Expose a better `fn abort() -> !` in `core`? - [ ] Final comment period (FCP)[^1] - [ ] Stabilization PR <!-- Once the feature has gone through a few release cycles and there are no unresolved questions left, the feature might be ready for stabilization. If this feature didn't go through the RFC process, a final comment period (FCP) is always needed before stabilization. This works as follows: A library API team member can kick off the stabilization process, at which point the rfcbot will ask all the team members to verify they agree with stabilization. Once enough members agree and there are no concerns, the final comment period begins: this issue will be marked as such and will be listed in the next This Week in Rust newsletter. If no blocking concerns are raised in that period of 10 days, a stabilization PR can be opened by anyone. --> ### Unresolved Questions <!-- Include any open questions that need to be answered before the feature can be stabilised. If multiple (unrelated) big questions come up, it can be a good idea to open a separate issue for each, to make it easier to keep track of the discussions. It's useful to link any relevant discussions and conclusions (whether on GitHub, Zulip, or the internals forum) here. --> - None yet. [^1]: https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html
T-libs-api,C-tracking-issue
low
Major
2,526,009,993
deno
TypeError: Failed to execute 'writeBuffer' on 'GPUQueue': Argument 3 is a view on a SharedArrayBuffer, which is not allowed
Version: Deno 1.46.3 in [spce](https://www.w3.org/TR/webgpu/#dom-gpuqueue-writebuffer) , it should be ok to use sharedArrayBuffer in device.queue.writeBuffer. ## Reproduce main.ts: ```ts const worker = new Worker(import.meta.resolve("./worker.ts"), { type: "module", }); worker.postMessage({ buffer: new SharedArrayBuffer(64) }); ``` worker.ts: ```ts const adapter = await navigator.gpu.requestAdapter(); const device = await adapter!.requestDevice(); const gpuBuffer = device.createBuffer({ size: 32, usage: GPUBufferUsage.STORAGE | GPUBufferUsage.COPY_SRC, }); self.addEventListener("message", (event) => { const data = (event as any).data; const view = new DataView(data.buffer); device.queue.writeBuffer(gpuBuffer, 0, view, 0, 4); }); ``` run `deno run --unstable-webgpu main.ts` then get error: <img width="1134" alt="ๆˆชๅฑ2024-09-14 13 40 10" src="https://github.com/user-attachments/assets/15d41ceb-4fb9-4e60-9460-2d7c46000168">
bug,webgpu
low
Critical
2,526,040,534
ant-design
Datepicker.Range ๅฆ‚ไฝ•ๅ•้ขๆฟ้€‰ๆ‹ฉ่Œƒๅ›ด๏ผŸ
### What problem does this feature solve? ๅœจไธ€ไบ›ไธšๅŠกๅœบๆ™ฏไธ‹๏ผŒๅฎขๆˆทๅธŒๆœ›ๅœจไธ€ไธช้ขๆฟ้‡Œ้ข้€š่ฟ‡ๅทฆๅณ็งปๅŠจๅนดๆœˆๆฅ้€‰ๆ‹ฉ่Œƒๅ›ด ### What does the proposed API look like? <DatePicker.Range multiplePanel="single" /> <!-- generated by ant-design-issue-helper. DO NOT REMOVE -->
๐Ÿ’ก Feature Request,Inactive
low
Minor
2,526,044,209
go
crypto/x509: no support for BitString
### Go version 1.23.1 ### Output of `go env` in your module/workspace: ```shell - ``` ### What did you do? Read x509 cert containing a BitString ### What did you see happen? unsupported string type: 3 BitString ### What did you expect to see? Support for bitstring https://go.dev/src/crypto/x509/parser.go line 60
NeedsInvestigation
low
Major
2,526,061,931
ant-design
SpinๅตŒๅฅ—ไฝฟ็”จไธ‹๏ผŒๅฝ“ๅ†…ๅฑ‚spinๆฒกๆœ‰childrenๅฏผ่‡ดๅค–ๅฑ‚Spin children่ขซ้ฎๆŒก
### Reproduction link [![Edit on StackBlitz](https://developer.stackblitz.com/img/open_in_stackblitz.svg)](https://stackblitz.com/edit/react-4nut3m?file=demo.tsx) ### Steps to reproduce ็›ดๆŽฅๅฏไปฅๅ‘็Žฐ้กต้ขไธŠ็š„helloๆŒ‰้’ฎ่ขซ้ฎๆŒกไบ†๏ผŒๆ— ๆณ•็‚นๅ‡ป ### What is expected? ๆœŸๆœ›ๅฏไปฅๆญฃๅธธ็‚นๅ‡ป ### What is actually happening? ๆ— ๆณ•็‚นๅ‡ป | Environment | Info | | --- | --- | | antd | 5.20.6 | | React | ไธŽreact็‰ˆๆœฌๆ— ๅ…ณ | | System | ็ณป็ปŸๆ— ๅ…ณ | | Browser | ๆต่งˆๅ™จ็‰ˆๆœฌๆ— ๅ…ณ | --- ๆˆ‘ๆŸฅๆ‰พไบ†ไธ€ไธ‹ๅŽŸๅ› ๅ’Œ้˜…่ฏปไบ†ไธ€ไธ‹ๆบ็ ๏ผŒ่ฟ™ไธชBUGไบง็”ŸๅŽŸๅ› ๆ˜ฏ็”ฑไบŽ่ฟ™ไธชๆ ทๅผ &-nested-loading > div > .@{spin-prefix-cls}ใ€‚่€Œๅฝ“Spinๆฒกๆœ‰childrenๆธฒๆŸ“ๆˆ ๏ผš const spinElement: React.ReactNode = ( <div {...restProps} style={mergedStyle} className={spinClassName} aria-live="polite" aria-busy={spinning} > <Indicator prefixCls={prefixCls} indicator={mergedIndicator} percent={mergedPercent} /> {tip && (isNestedPattern || fullscreen) ? ( <div className={`${prefixCls}-text`}>{tip}</div> ) : null} </div> ); ่€Œไธๆ˜ฏ null ็š„ๅŽŸๅ› ๆˆ‘็Œœๆต‹ๆ˜ฏไธบไบ†่ฟ™ๆ ทๅ†™ <Spin spinning={true}></Spin> ๅฏไปฅๅฎž็Žฐ loading ๆ•ˆๆžœใ€‚ ่ฟ™ไธชBUGๆˆ‘็›ฎๅ‰็Ÿฅ้“ไบ†ๅŽŸๅ› ๏ผŒๅธŒๆœ›ๅฏไปฅ่ฏ•่ฏ•ใ€‚ <!-- generated by ant-design-issue-helper. DO NOT REMOVE -->
Inactive,improvement
low
Critical
2,526,089,975
flutter
[YearPicker] Hover/Splash goes out of clipped bounds
### Steps to reproduce 1. Run the code sample for DatePicker 2. Go to change year 3. Scroll and hover over the year that is clipped ### Expected results Not sure. I believe it should be clipped ### Actual results The hover goes out of bounds. Screenshots included for clarity. ### Code sample <details open><summary>Code sample</summary> ```dart import 'package:flutter/material.dart'; /// Flutter code sample for [showDatePicker]. void main() => runApp(const DatePickerApp()); class DatePickerApp extends StatelessWidget { const DatePickerApp({super.key}); @override Widget build(BuildContext context) { return const MaterialApp( restorationScopeId: 'app', home: DatePickerExample(restorationId: 'main'), ); } } class DatePickerExample extends StatefulWidget { const DatePickerExample({super.key, this.restorationId}); final String? restorationId; @override State<DatePickerExample> createState() => _DatePickerExampleState(); } /// RestorationProperty objects can be used because of RestorationMixin. class _DatePickerExampleState extends State<DatePickerExample> with RestorationMixin { // In this example, the restoration ID for the mixin is passed in through // the [StatefulWidget]'s constructor. @override String? get restorationId => widget.restorationId; final RestorableDateTime _selectedDate = RestorableDateTime(DateTime(2021, 7, 25)); late final RestorableRouteFuture<DateTime?> _restorableDatePickerRouteFuture = RestorableRouteFuture<DateTime?>( onComplete: _selectDate, onPresent: (NavigatorState navigator, Object? arguments) { return navigator.restorablePush( _datePickerRoute, arguments: _selectedDate.value.millisecondsSinceEpoch, ); }, ); @pragma('vm:entry-point') static Route<DateTime> _datePickerRoute( BuildContext context, Object? arguments, ) { return DialogRoute<DateTime>( context: context, builder: (BuildContext context) { return DatePickerDialog( restorationId: 'date_picker_dialog', initialEntryMode: DatePickerEntryMode.calendarOnly, initialDate: DateTime.fromMillisecondsSinceEpoch(arguments! as int), firstDate: DateTime(2021), lastDate: DateTime(2022), ); }, ); } @override void restoreState(RestorationBucket? oldBucket, bool initialRestore) { registerForRestoration(_selectedDate, 'selected_date'); registerForRestoration( _restorableDatePickerRouteFuture, 'date_picker_route_future'); } void _selectDate(DateTime? newSelectedDate) { if (newSelectedDate != null) { setState(() { _selectedDate.value = newSelectedDate; ScaffoldMessenger.of(context).showSnackBar(SnackBar( content: Text( 'Selected: ${_selectedDate.value.day}/${_selectedDate.value.month}/${_selectedDate.value.year}'), )); }); } } @override Widget build(BuildContext context) { return Scaffold( body: Center( child: OutlinedButton( onPressed: () { _restorableDatePickerRouteFuture.present(); }, child: const Text('Open Date Picker'), ), ), ); } } ``` </details> ### Screenshots or Video <details open> <summary>Screenshots / Video demonstration</summary> ![bug1](https://github.com/user-attachments/assets/929d4a74-e27c-4ef6-8583-56307bb1f054) ![bug2](https://github.com/user-attachments/assets/76aac18d-a8cd-45df-be08-90e10864117a) </details> ### Logs <details open><summary>Logs</summary> ```console [Paste your logs here] ``` </details> ### Flutter Doctor output <details open><summary>Doctor output</summary> ```console [Paste your output here] ``` </details>
framework,f: material design,f: date/time picker,has reproducible steps,P2,team-design,triaged-design,found in release: 3.24,found in release: 3.26
low
Critical
2,526,095,654
TypeScript
JSDoc typed function comments inside functions
### ๐Ÿ” Search Terms "JSDoc inside functions", "JSDoc comments inside", "typed function comments" ### โœ… Viability Checklist - [X] This wouldn't be a breaking change in existing TypeScript/JavaScript code - [X] This wouldn't change the runtime behavior of existing JavaScript code - [X] This could be implemented without emitting different JS based on the types of the expressions - [X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.) - [X] This isn't a request to add a new utility type: https://github.com/microsoft/TypeScript/wiki/No-New-Utility-Types - [X] This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals ### โญ Suggestion Are we able add support for adding JSDoc typed function comments inside functions, either natively or by a setting? ### ๐Ÿ“ƒ Motivating Example Personally, I find it easier to read JSDoc typed function comments when they are indented nicely inside functions, similar to Python, which would also pair really well with code folding. ```js function arrayMove(index) { /** * @param {Number} index * @return {Array} */ // ... } ``` I enquired about [this](https://stackoverflow.com/questions/75955461/how-can-i-add-jsdoc-comments-inside-functions) on Stackoverflow last year ### ๐Ÿ’ป Use Cases .
Suggestion,Awaiting More Feedback
low
Minor
2,526,115,342
rust
ICE with `feature(non_lifetime_binders)` for trait generic that is constrained equal to supertrait associated type.
<!-- Thank you for finding an Internal Compiler Error! ๐ŸงŠ If possible, try to provide a minimal verifiable example. You can read "Rust Bug Minimization Patterns" for how to create smaller examples. http://blog.pnkfx.org/blog/2019/11/18/rust-bug-minimization-patterns/ --> ### Code ```Rust #![feature(non_lifetime_binders)] #![allow(unused)] trait A<T>: Iterator<Item = T> {} fn demo(x: &mut impl for<U> A<U>) { let _: Option<u32> = x.next(); // Removing this line stops the ICE } ``` ### Meta <!-- If you're using the stable version of the compiler, you should also check if the bug also exists in the beta or nightly versions. --> `rustc --version --verbose`: ``` rustc 1.83.0-nightly (0609062a9 2024-09-13) binary: rustc commit-hash: 0609062a91c8f445c3e9a0de57e402f9b1b8b0a7 commit-date: 2024-09-13 host: x86_64-unknown-linux-gnu release: 1.83.0-nightly LLVM version: 19.1.0 ``` ### Error output ``` thread 'rustc' panicked at compiler/rustc_borrowck/src/type_check/relate_tys.rs:343:9: unexpected inference var std::option::Option<?0t> ``` <!-- Include a backtrace in the code block by setting `RUST_BACKTRACE=1` in your environment. E.g. `RUST_BACKTRACE=1 cargo build`. --> <details><summary><strong>Backtrace</strong></summary> <p> ```rs $ RUST_BACKTRACE=full cargo build Compiling non-lifetime-binders-ice v0.1.0 (/home/zachary/Programming/rusttesting/non-lifetime-binders-ice) warning: the feature `non_lifetime_binders` is incomplete and may not be safe to use and/or cause compiler crashes --> src/lib.rs:1:12 | 1 | #![feature(non_lifetime_binders)] | ^^^^^^^^^^^^^^^^^^^^ | = note: see issue #108185 <https://github.com/rust-lang/rust/issues/108185> for more information = note: `#[warn(incomplete_features)]` on by default thread 'rustc' panicked at compiler/rustc_borrowck/src/type_check/relate_tys.rs:343:9: unexpected inference var std::option::Option<?0t> stack backtrace: 0: 0x7df233a7701a - <std::sys::backtrace::BacktraceLock::print::DisplayBacktrace as core::fmt::Display>::fmt::h85a9257eb6c41e04 1: 0x7df234203257 - core::fmt::write::hcc8bee8d21353e39 2: 0x7df23515c4b3 - std::io::Write::write_fmt::h70ac935b0c89b059 3: 0x7df233a76e72 - std::sys::backtrace::BacktraceLock::print::hd262bc6f83870824 4: 0x7df233a795f1 - std::panicking::default_hook::{{closure}}::h1ac01a4d50ceb64f 5: 0x7df233a79424 - std::panicking::default_hook::h7c4ba54603c1d0b3 6: 0x7df232b7ccff - std[b495ad0c4617e146]::panicking::update_hook::<alloc[a0425571c9a9acf]::boxed::Box<rustc_driver_impl[f22662736fcaf763]::install_ice_hook::{closure#0}>>::{closure#0} 7: 0x7df233a79d18 - std::panicking::rust_panic_with_hook::h0dd05eda4407feb9 8: 0x7df233a79ae7 - std::panicking::begin_panic_handler::{{closure}}::hff4951198a9049be 9: 0x7df233a774c9 - std::sys::backtrace::__rust_end_short_backtrace::hae232f20e82e2c44 10: 0x7df233a797b4 - rust_begin_unwind 11: 0x7df230894523 - core::panicking::panic_fmt::h6dddd3310fdcb8b7 12: 0x7df23443ca7f - <rustc_borrowck[a2299cf35e33e6d2]::type_check::relate_tys::NllTypeRelating as rustc_type_ir[a35413f6f42f08]::relate::TypeRelation<rustc_middle[7cca7f2870ea52e7]::ty::context::TyCtxt>>::tys 13: 0x7df234447572 - <rustc_borrowck[a2299cf35e33e6d2]::type_check::TypeChecker>::typeck_mir 14: 0x7df235302842 - rustc_borrowck[a2299cf35e33e6d2]::type_check::type_check 15: 0x7df2342c4549 - rustc_borrowck[a2299cf35e33e6d2]::nll::compute_regions 16: 0x7df2352b18c8 - rustc_borrowck[a2299cf35e33e6d2]::do_mir_borrowck 17: 0x7df2352a3f87 - rustc_query_impl[484dcaccf014b2f3]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[484dcaccf014b2f3]::query_impl::mir_borrowck::dynamic_query::{closure#2}::{closure#0}, rustc_middle[7cca7f2870ea52e7]::query::erase::Erased<[u8; 8usize]>> 18: 0x7df2344925d4 - rustc_query_system[a8532041af820499]::query::plumbing::try_execute_query::<rustc_query_impl[484dcaccf014b2f3]::DynamicConfig<rustc_query_system[a8532041af820499]::query::caches::VecCache<rustc_span[45f656ad9ccc3ab8]::def_id::LocalDefId, rustc_middle[7cca7f2870ea52e7]::query::erase::Erased<[u8; 8usize]>>, false, false, false>, rustc_query_impl[484dcaccf014b2f3]::plumbing::QueryCtxt, true> 19: 0x7df234497434 - rustc_query_impl[484dcaccf014b2f3]::query_impl::mir_borrowck::get_query_incr::__rust_end_short_backtrace 20: 0x7df234a7e278 - rustc_interface[1ce9087adc29d20e]::passes::run_required_analyses 21: 0x7df2350b4b9e - rustc_interface[1ce9087adc29d20e]::passes::analysis 22: 0x7df2350b4b71 - rustc_query_impl[484dcaccf014b2f3]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[484dcaccf014b2f3]::query_impl::analysis::dynamic_query::{closure#2}::{closure#0}, rustc_middle[7cca7f2870ea52e7]::query::erase::Erased<[u8; 1usize]>> 23: 0x7df2350bdc4d - rustc_query_system[a8532041af820499]::query::plumbing::try_execute_query::<rustc_query_impl[484dcaccf014b2f3]::DynamicConfig<rustc_query_system[a8532041af820499]::query::caches::SingleCache<rustc_middle[7cca7f2870ea52e7]::query::erase::Erased<[u8; 1usize]>>, false, false, false>, rustc_query_impl[484dcaccf014b2f3]::plumbing::QueryCtxt, true> 24: 0x7df2350bd8fa - rustc_query_impl[484dcaccf014b2f3]::query_impl::analysis::get_query_incr::__rust_end_short_backtrace 25: 0x7df234f3aafc - rustc_interface[1ce9087adc29d20e]::interface::run_compiler::<core[7f44e8b513577cf8]::result::Result<(), rustc_span[45f656ad9ccc3ab8]::ErrorGuaranteed>, rustc_driver_impl[f22662736fcaf763]::run_compiler::{closure#0}>::{closure#1} 26: 0x7df23503fc50 - std[b495ad0c4617e146]::sys::backtrace::__rust_begin_short_backtrace::<rustc_interface[1ce9087adc29d20e]::util::run_in_thread_with_globals<rustc_interface[1ce9087adc29d20e]::util::run_in_thread_pool_with_globals<rustc_interface[1ce9087adc29d20e]::interface::run_compiler<core[7f44e8b513577cf8]::result::Result<(), rustc_span[45f656ad9ccc3ab8]::ErrorGuaranteed>, rustc_driver_impl[f22662736fcaf763]::run_compiler::{closure#0}>::{closure#1}, core[7f44e8b513577cf8]::result::Result<(), rustc_span[45f656ad9ccc3ab8]::ErrorGuaranteed>>::{closure#0}, core[7f44e8b513577cf8]::result::Result<(), rustc_span[45f656ad9ccc3ab8]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[7f44e8b513577cf8]::result::Result<(), rustc_span[45f656ad9ccc3ab8]::ErrorGuaranteed>> 27: 0x7df2350402ba - <<std[b495ad0c4617e146]::thread::Builder>::spawn_unchecked_<rustc_interface[1ce9087adc29d20e]::util::run_in_thread_with_globals<rustc_interface[1ce9087adc29d20e]::util::run_in_thread_pool_with_globals<rustc_interface[1ce9087adc29d20e]::interface::run_compiler<core[7f44e8b513577cf8]::result::Result<(), rustc_span[45f656ad9ccc3ab8]::ErrorGuaranteed>, rustc_driver_impl[f22662736fcaf763]::run_compiler::{closure#0}>::{closure#1}, core[7f44e8b513577cf8]::result::Result<(), rustc_span[45f656ad9ccc3ab8]::ErrorGuaranteed>>::{closure#0}, core[7f44e8b513577cf8]::result::Result<(), rustc_span[45f656ad9ccc3ab8]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[7f44e8b513577cf8]::result::Result<(), rustc_span[45f656ad9ccc3ab8]::ErrorGuaranteed>>::{closure#1} as core[7f44e8b513577cf8]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0} 28: 0x7df2350406ab - std::sys::pal::unix::thread::Thread::new::thread_start::hdd18e2f9323a466b 29: 0x7df22f29ca94 - start_thread at ./nptl/pthread_create.c:447:8 30: 0x7df22f329c3c - clone3 at ./misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S:78 31: 0x0 - <unknown> error: the compiler unexpectedly panicked. this is a bug. note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md note: please make sure that you have updated to the latest nightly note: please attach the file at `/home/zachary/Programming/rusttesting/non-lifetime-binders-ice/rustc-ice-2024-09-14T08_33_54-96527.txt` to your bug report note: compiler flags: --crate-type lib -C embed-bitcode=no -C debuginfo=2 -C incremental=[REDACTED] note: some of the compiler flags provided by cargo are hidden query stack during panic: #0 [mir_borrowck] borrow-checking `demo` #1 [analysis] running analysis passes on this crate end of query stack warning: `non-lifetime-binders-ice` (lib) generated 1 warning error: could not compile `non-lifetime-binders-ice` (lib); 1 warning emitted Caused by: process didn't exit successfully: `/home/zachary/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/bin/rustc --crate-name non_lifetime_binders_ice --edition=2021 src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --diagnostic-width=180 --crate-type lib --emit=dep-info,metadata,link -C embed-bitcode=no -C debuginfo=2 --check-cfg 'cfg(docsrs)' --check-cfg 'cfg(feature, values())' -C metadata=f19fe47f3fdd4a9f -C extra-filename=-f19fe47f3fdd4a9f --out-dir /home/zachary/opt_mount/zachary/cargo-target/debug/deps -C incremental=/home/zachary/opt_mount/zachary/cargo-target/debug/incremental -L dependency=/home/zachary/opt_mount/zachary/cargo-target/debug/deps` (exit status: 101) ``` `/.../non-lifetime-binders-ice/rustc-ice-2024-09-14T08_33_54-96527.txt`: ```rs thread 'rustc' panicked at compiler/rustc_borrowck/src/type_check/relate_tys.rs:343:9: unexpected inference var std::option::Option<?0t> stack backtrace: 0: 0x7df23543dbe5 - std::backtrace::Backtrace::create::h47c5ac21bc5295ff 1: 0x7df233a62695 - std::backtrace::Backtrace::force_capture::h22d7360fb10c606e 2: 0x7df232b7d337 - std[b495ad0c4617e146]::panicking::update_hook::<alloc[a0425571c9a9acf]::boxed::Box<rustc_driver_impl[f22662736fcaf763]::install_ice_hook::{closure#0}>>::{closure#0} 3: 0x7df233a79d18 - std::panicking::rust_panic_with_hook::h0dd05eda4407feb9 4: 0x7df233a79ae7 - std::panicking::begin_panic_handler::{{closure}}::hff4951198a9049be 5: 0x7df233a774c9 - std::sys::backtrace::__rust_end_short_backtrace::hae232f20e82e2c44 6: 0x7df233a797b4 - rust_begin_unwind 7: 0x7df230894523 - core::panicking::panic_fmt::h6dddd3310fdcb8b7 8: 0x7df23443ca7f - <rustc_borrowck[a2299cf35e33e6d2]::type_check::relate_tys::NllTypeRelating as rustc_type_ir[a35413f6f42f08]::relate::TypeRelation<rustc_middle[7cca7f2870ea52e7]::ty::context::TyCtxt>>::tys 9: 0x7df234447572 - <rustc_borrowck[a2299cf35e33e6d2]::type_check::TypeChecker>::typeck_mir 10: 0x7df235302842 - rustc_borrowck[a2299cf35e33e6d2]::type_check::type_check 11: 0x7df2342c4549 - rustc_borrowck[a2299cf35e33e6d2]::nll::compute_regions 12: 0x7df2352b18c8 - rustc_borrowck[a2299cf35e33e6d2]::do_mir_borrowck 13: 0x7df2352a3f87 - rustc_query_impl[484dcaccf014b2f3]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[484dcaccf014b2f3]::query_impl::mir_borrowck::dynamic_query::{closure#2}::{closure#0}, rustc_middle[7cca7f2870ea52e7]::query::erase::Erased<[u8; 8usize]>> 14: 0x7df2344925d4 - rustc_query_system[a8532041af820499]::query::plumbing::try_execute_query::<rustc_query_impl[484dcaccf014b2f3]::DynamicConfig<rustc_query_system[a8532041af820499]::query::caches::VecCache<rustc_span[45f656ad9ccc3ab8]::def_id::LocalDefId, rustc_middle[7cca7f2870ea52e7]::query::erase::Erased<[u8; 8usize]>>, false, false, false>, rustc_query_impl[484dcaccf014b2f3]::plumbing::QueryCtxt, true> 15: 0x7df234497434 - rustc_query_impl[484dcaccf014b2f3]::query_impl::mir_borrowck::get_query_incr::__rust_end_short_backtrace 16: 0x7df234a7e278 - rustc_interface[1ce9087adc29d20e]::passes::run_required_analyses 17: 0x7df2350b4b9e - rustc_interface[1ce9087adc29d20e]::passes::analysis 18: 0x7df2350b4b71 - rustc_query_impl[484dcaccf014b2f3]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[484dcaccf014b2f3]::query_impl::analysis::dynamic_query::{closure#2}::{closure#0}, rustc_middle[7cca7f2870ea52e7]::query::erase::Erased<[u8; 1usize]>> 19: 0x7df2350bdc4d - rustc_query_system[a8532041af820499]::query::plumbing::try_execute_query::<rustc_query_impl[484dcaccf014b2f3]::DynamicConfig<rustc_query_system[a8532041af820499]::query::caches::SingleCache<rustc_middle[7cca7f2870ea52e7]::query::erase::Erased<[u8; 1usize]>>, false, false, false>, rustc_query_impl[484dcaccf014b2f3]::plumbing::QueryCtxt, true> 20: 0x7df2350bd8fa - rustc_query_impl[484dcaccf014b2f3]::query_impl::analysis::get_query_incr::__rust_end_short_backtrace 21: 0x7df234f3aafc - rustc_interface[1ce9087adc29d20e]::interface::run_compiler::<core[7f44e8b513577cf8]::result::Result<(), rustc_span[45f656ad9ccc3ab8]::ErrorGuaranteed>, rustc_driver_impl[f22662736fcaf763]::run_compiler::{closure#0}>::{closure#1} 22: 0x7df23503fc50 - std[b495ad0c4617e146]::sys::backtrace::__rust_begin_short_backtrace::<rustc_interface[1ce9087adc29d20e]::util::run_in_thread_with_globals<rustc_interface[1ce9087adc29d20e]::util::run_in_thread_pool_with_globals<rustc_interface[1ce9087adc29d20e]::interface::run_compiler<core[7f44e8b513577cf8]::result::Result<(), rustc_span[45f656ad9ccc3ab8]::ErrorGuaranteed>, rustc_driver_impl[f22662736fcaf763]::run_compiler::{closure#0}>::{closure#1}, core[7f44e8b513577cf8]::result::Result<(), rustc_span[45f656ad9ccc3ab8]::ErrorGuaranteed>>::{closure#0}, core[7f44e8b513577cf8]::result::Result<(), rustc_span[45f656ad9ccc3ab8]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[7f44e8b513577cf8]::result::Result<(), rustc_span[45f656ad9ccc3ab8]::ErrorGuaranteed>> 23: 0x7df2350402ba - <<std[b495ad0c4617e146]::thread::Builder>::spawn_unchecked_<rustc_interface[1ce9087adc29d20e]::util::run_in_thread_with_globals<rustc_interface[1ce9087adc29d20e]::util::run_in_thread_pool_with_globals<rustc_interface[1ce9087adc29d20e]::interface::run_compiler<core[7f44e8b513577cf8]::result::Result<(), rustc_span[45f656ad9ccc3ab8]::ErrorGuaranteed>, rustc_driver_impl[f22662736fcaf763]::run_compiler::{closure#0}>::{closure#1}, core[7f44e8b513577cf8]::result::Result<(), rustc_span[45f656ad9ccc3ab8]::ErrorGuaranteed>>::{closure#0}, core[7f44e8b513577cf8]::result::Result<(), rustc_span[45f656ad9ccc3ab8]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[7f44e8b513577cf8]::result::Result<(), rustc_span[45f656ad9ccc3ab8]::ErrorGuaranteed>>::{closure#1} as core[7f44e8b513577cf8]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0} 24: 0x7df2350406ab - std::sys::pal::unix::thread::Thread::new::thread_start::hdd18e2f9323a466b 25: 0x7df22f29ca94 - start_thread at ./nptl/pthread_create.c:447:8 26: 0x7df22f329c3c - clone3 at ./misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S:78 27: 0x0 - <unknown> rustc version: 1.83.0-nightly (0609062a9 2024-09-13) platform: x86_64-unknown-linux-gnu query stack during panic: #0 [mir_borrowck] borrow-checking `demo` #1 [analysis] running analysis passes on this crate end of query stack ``` </p> </details> @rustbot label +F-non-lifetime-binders +requires-nightly
I-ICE,T-compiler,C-bug,S-bug-has-test,T-types,F-non_lifetime_binders,requires-incomplete-features
low
Critical
2,526,138,841
PowerToys
ๅธŒๆœ›ๆทปๅŠ ไฟฎๆ”น็ช—ๅฃ้€ๆ˜Žๅบฆ็š„ๅŠŸ่ƒฝ
### Description of the new feature / enhancement ๅฏไปฅ้€š่ฟ‡ๅฟซๆท้”ฎ่ฐƒๆ•ดๅฝ“ๅ‰็ช—ๅฃ็š„้€ๆ˜Žๅบฆไปฅ็œ‹ๅˆฐ็ช—ๅฃไธ‹้ข็š„ๅ†…ๅฎน ### Scenario when this would be used? ๅญฆไน ไธญ่พน็œ‹้ข˜็›ฎ่พนๅ†™ไปฃ็ ๏ผŒๅทฅไฝœๆ—ถๅฏน็…งๆๆ–™ๅ†™ๆ–‡ๆกฃ็ญ‰ใ€‚ ### Supporting information _No response_
Needs-Triage
low
Minor
2,526,147,302
TypeScript
Error when accessing CSS property value using kebab case in `CSSStyleDeclaration` object
### ๐Ÿ”Ž Search Terms "CSS property value kebab case dash", "CSSStyleDeclaration", "getComputedStyle", "getPropertyValue" ### ๐Ÿ•— Version & Regression Information - This is the behavior in every version I tried, and I reviewed the FAQ for entries about "CSSStyleDeclaration", "getComputedStyle" ### โฏ Playground Link https://www.typescriptlang.org/play/?ts=5.7.0-dev.20240914#code/OYUwLgwg9gtgDgVzCAJgZTATwDYgBQpQDGCMIAdmAHQBGUKmAlANoDkNAhkQNbABOUBORQBaIlGxQ+rALpA ### ๐Ÿ’ป Code ```ts getComputedStyle(document.body)['background-color'] ``` ### ๐Ÿ™ Actual behavior TypeScript reports following error: > Element implicitly has an 'any' type because index expression is not of type 'number'. ### ๐Ÿ™‚ Expected behavior TypeScript should not report any error. ### Additional information about the issue If I update the file `node_modules/typescript/lib/lib.dom.d.ts` to include `background-color` as follows: ```ts interface CSSStyleDeclaration { // ... 'background-color': string; // ... } ``` the error does not occur for `background-color` property.
Bug,Help Wanted,Domain: lib.d.ts
low
Critical
2,526,151,181
electron
[Feature Request]: Turn off Efficiency Mode in win11
### Preflight Checklist - [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project. - [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to. - [X] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success. ### Electron Version 32.1.0 ### What operating system(s) are you using? Windows ### Operating System Version 23H2 ### What arch are you using? x64 ### Last Known Working Electron version _No response_ ### Expected Behavior Don't enable Efficiency Mode! ### Actual Behavior Efficiency Mode is on, but I want my software to run at high priority. ### Testcase Gist URL _No response_ ### Additional Information https://devblogs.microsoft.com/performance-diagnostics/reduce-process-interference-with-task-manager-efficiency-mode/ _No response_
enhancement :sparkles:,platform/windows,32-x-y
low
Critical
2,526,171,419
stable-diffusion-webui
[Bug]: ./webui.sh line 304: 10524 Segmentation fault
### Checklist - [ ] The issue exists after disabling all extensions - [X] The issue exists on a clean installation of webui - [ ] The issue is caused by an extension, but I believe it is caused by a bug in the webui - [ ] The issue exists in the current version of the webui - [X] The issue has not been reported before recently - [ ] The issue has been reported before but has not been fixed yet ### What happened? While using: Windows 10 WSL Ubuntu 20.24 WSL version: 2.3.17.0 Kernel version: 5.15.153.1-2 WSLg version: 1.0.64 MSRDC version: 1.2.5326 Direct3D version: 1.611.1-81528511 DXCore version: 10.0.26100.1-240331-1435.ge-release Windows version: 10.0.22635.4145 PRETTY_NAME="Ubuntu 22.04.5 LTS" Commit hash: 82a973c04367123ae98bd9abdf80d9eda9b910e2 webui.sh preformed a segment fault on line 304 @ 10524 ### Steps to reproduce the problem git clone https://github.com/AUTOMATIC1111/stable-diffusion-webui ./webui.sh ################################################################ Install script for stable-diffusion + Web UI Tested on Debian 11 (Bullseye), Fedora 34+ and openSUSE Leap 15.4 or newer. ################################################################ ################################################################ Running on gjdunga user ################################################################ ################################################################ Repo already cloned, using it as install directory ################################################################ ################################################################ Create and activate python venv ################################################################ ################################################################ Launching launch.py... ################################################################ glibc version is 2.35 Check TCMalloc: libtcmalloc_minimal.so.4 ./webui.sh: line 258: bc: command not found ./webui.sh: line 258: [: -eq: unary operator expected libtcmalloc_minimal.so.4 is linked with libc.so,execute LD_PRELOAD=/lib/x86_64-linux-gnu/libtcmalloc_minimal.so.4 Python 3.11.0rc1 (main, Apr 21 2024, 22:33:16) [GCC 11.4.0] Version: v1.10.1 Commit hash: 82a973c04367123ae98bd9abdf80d9eda9b910e2 Launching Web UI with arguments: ./webui.sh: line 304: 10524 Segmentation fault (core dumped) "${python_cmd}" -u "${LAUNCH_SCRIPT}" "$@" ### What should have happened? It should not have seg faulted? ### What browsers do you use to access the UI ? Google Chrome ### Sysinfo System will not spit out a debug or sysinfo file. it segfaults before this. ### Console logs ```Shell ################################################################ Install script for stable-diffusion + Web UI Tested on Debian 11 (Bullseye), Fedora 34+ and openSUSE Leap 15.4 or newer. ################################################################ ################################################################ Running on gjdunga user ################################################################ ################################################################ Repo already cloned, using it as install directory ################################################################ ################################################################ Create and activate python venv ################################################################ ################################################################ Launching launch.py... ################################################################ glibc version is 2.35 Check TCMalloc: libtcmalloc_minimal.so.4 ./webui.sh: line 258: bc: command not found ./webui.sh: line 258: [: -eq: unary operator expected libtcmalloc_minimal.so.4 is linked with libc.so,execute LD_PRELOAD=/lib/x86_64-linux-gnu/libtcmalloc_minimal.so.4 Python 3.11.0rc1 (main, Apr 21 2024, 22:33:16) [GCC 11.4.0] Version: v1.10.1 Commit hash: 82a973c04367123ae98bd9abdf80d9eda9b910e2 Launching Web UI with arguments: ./webui.sh: line 304: 10524 Segmentation fault (core dumped) "${python_cmd}" -u "${LAUNCH_SCRIPT}" "$@" gjdunga@Splash:~/stable-diffusion-webui$ ``` ### Additional information No other information I can report at this moment. Ask for info I will report.
bug-report
low
Critical
2,526,174,306
PowerToys
CAPTURAR JANELA
### Microsoft PowerToys version Release v0.84.1 ### Installation method Microsoft Store ### Running as admin Yes ### Area(s) with issue? Workspaces ### Steps to reproduce IN PT-BR, TRANSLATE PLS OK ( A NOVIDADE DO WORKSPACES NรƒO CAPTURA, MESMO COM O POWERTOYS EM ADMIN, A JANELA DO CLIENTE DO LEAGUE OF LEGENDS E DO GS AUTO CLICKER 3.1.4) ### โœ”๏ธ Expected Behavior IN PT-BR, TRANSLATE PLS OK ( A NOVIDADE DO WORKSPACES NรƒO CAPTURA, MESMO COM O POWERTOYS EM ADMIN, A JANELA DO CLIENTE DO LEAGUE OF LEGENDS E DO GS AUTO CLICKER 3.1.4) ### โŒ Actual Behavior IN PT-BR, TRANSLATE PLS OK ( A NOVIDADE DO WORKSPACES NรƒO CAPTURA, MESMO COM O POWERTOYS EM ADMIN, A JANELA DO CLIENTE DO LEAGUE OF LEGENDS E DO GS AUTO CLICKER 3.1.4) ### Other Software IN PT-BR, TRANSLATE PLS OK ( A NOVIDADE DO WORKSPACES NรƒO CAPTURA, MESMO COM O POWERTOYS EM ADMIN, A JANELA DO CLIENTE DO LEAGUE OF LEGENDS E DO GS AUTO CLICKER 3.1.4)
Issue-Bug,Needs-Triage,Product-Workspaces
low
Minor
2,526,184,056
go
cmd/link: function "decodetypeGcmask" read gcdata from shared object file may not correct when use `lld` link in linux/arm64
### Go version go version go1.23.1 linux/arm64 ### Output of `go env` in your module/workspace: ```shell GO111MODULE='auto' GOARCH='arm64' GOBIN='' GOCACHE='/usr1/GOCACHE' GOENV='/root/.config/go/env' GOEXE='' GOEXPERIMENT='' GOFLAGS='' GOHOSTARCH='arm64' GOHOSTOS='linux' GOINSECURE='' GOMODCACHE='/usr1/GOPATH/pkg/mod' GOOS='linux' GOPATH='/usr1/GOPATH' GOROOT='/usr1/GoRelease/go1.23.1' GOSUMDB='off' GOTMPDIR='' GOTOOLCHAIN='auto' GOTOOLDIR='/usr1/GoRelease/go1.23.1/pkg/tool/linux_arm64' GOVCS='' GOVERSION='go1.23.1' GODEBUG='' GOTELEMETRY='local' GOTELEMETRYDIR='/root/.config/go/telemetry' GCCGO='gccgo' GOARM64='v8.0' AR='ar' CC='gcc' CXX='g++' CGO_ENABLED='1' GOMOD='' GOWORK='' CGO_CFLAGS='-O2 -g' CGO_CPPFLAGS='' CGO_CXXFLAGS='-O2 -g' CGO_FFLAGS='-O2 -g' CGO_LDFLAGS='-O2 -g' PKG_CONFIG='pkg-config' GOGCCFLAGS='-fPIC -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/usr1/tmp/go-build503891466=/tmp/go-build -gno-record-gcc-switches' ``` ### What did you do? `temp.go` file: ```go package main import ( "errors" "runtime" ) var err error func main() { err = errors.New("111") runtime.GC() runtime.GC() runtime.GC() if err == nil { panic("err == nil") } if s := err.Error(); s != "111" { println(err) println(s) panic("s!=111") } } ``` ```bash LLVM=/your_llvm_path CC=$LLVM/bin/clang CXX=$LLVM/bin/clang++ go install -a -ldflags="-extldflags=-fuse-ld=lld" -buildmode=shared runtime sync/atomic CC=$LLVM/bin/clang CXX=$LLVM/bin/clang++ go build -a -ldflags="-extldflags=-fuse-ld=lld" -linkshared temp.go GODEBUG=clobberfree=1 ./temp ``` ### What did you see happen? ```bash (0xaaaacd007078,0x400011c010) panic: s!=111 goroutine 1 [running]: main.main() /usr1/temp/temp.go:22 +0x14c ``` or ```bash (0xaaaae0687078,0x4000196010) fatal error: unexpected signal during runtime execution [signal SIGSEGV: segmentation violation code=0x2 addr=0x4000400000 pc=0xffff93014fe8] goroutine 1 gp=0x40000041c0 m=5 mp=0x4000100008 [running]: runtime.throw({0xffff92f353d7?, 0x0?}) /usr1/GoRelease/go1.23.1/src/runtime/panic.go:1067 +0x38 fp=0x40000be5c0 sp=0x40000be590 pc=0xffff92fcade8 runtime.sigpanic() /usr1/GoRelease/go1.23.1/src/runtime/signal_unix.go:884 +0x378 fp=0x40000be620 sp=0x40000be5c0 pc=0xffff92fee308 runtime.memmove() /usr1/GoRelease/go1.23.1/src/runtime/memmove_arm64.s:159 +0x168 fp=0x40000be630 sp=0x40000be630 pc=0xffff93014fe8 runtime.recordForPanic({0x4000180000, 0x3915fe458886ea, 0x3915fe458886ea}) /usr1/GoRelease/go1.23.1/src/runtime/print.go:45 +0x124 fp=0x40000be670 sp=0x40000be630 pc=0xffff92fce5f4 runtime.gwrite({0x4000180000, 0x3915fe458886ea, 0x1?}) /usr1/GoRelease/go1.23.1/src/runtime/print.go:89 +0x2c fp=0x40000be6b0 sp=0x40000be670 pc=0xffff92fce76c runtime.printstring({0x4000180000?, 0x4000196010?}) /usr1/GoRelease/go1.23.1/src/runtime/print.go:246 +0x4c fp=0x40000be700 sp=0x40000be6b0 pc=0xffff92fcef3c main.main() /usr1/temp/temp.go:21 +0x130 fp=0x40000be740 sp=0x40000be700 pc=0xaaaae0673a30 runtime.main() /usr1/GoRelease/go1.23.1/src/runtime/proc.go:272 +0x2e4 fp=0x40000be7d0 sp=0x40000be740 pc=0xffff92fcf694 runtime.goexit({}) /usr1/GoRelease/go1.23.1/src/runtime/asm_arm64.s:1223 +0x4 fp=0x40000be7d0 sp=0x40000be7d0 pc=0xffff93013f24 ``` ### What did you expect to see? no crash.
NeedsInvestigation,compiler/runtime
low
Critical
2,526,211,709
neovim
":read :cmd" reads :cmd output into a buffer
### Problem Vims' internal pager 'more' sucks: can't search when neovim opens output in it. ### Expected behavior ability to search when paging with neovims internal pager 'more'
enhancement,complexity:low,editor
medium
Major
2,526,213,852
angular
Add "delay" parameter to the "idle" trigger
### Which @angular/* package(s) are relevant/related to the feature request? compiler ### Description Please add the "delay" parameter to the "idle" trigger. We could use it like this: ``` @defer (on hover(container); on idle(2000)) { <heavy-component/> } ``` or this: ``` @defer (on idle({delay: 2000})) { <heavy-component/> } ``` That would load the HeavyComponent either on hover or after a 2s delay after โ€œidleโ€. There are just components that are far enough from the userโ€™s path, and heavy enough to load them not on just โ€œidleโ€, but with a small delay - because more important components will take a chance to be loaded on โ€œidleโ€. ### Proposed solution Please add the "delay" parameter to the "idle" trigger. ### Alternatives considered We can do this, but it is [considered a bad practice by Angular.dev](https://angular.dev/guide/templates/defer#avoid-cascading-loads-with-nested-defer-blocks): ``` @defer (on idle) { @defer(on timer(2000)) { <heavy-component/> } } ``` Also, this way we can't combine triggers with "or" logic.
area: core,core: defer
low
Major
2,526,220,044
godot
Building with Visual Studio does not work if Scons is not on the path
### Tested versions 74de05a01c8716a42d4e3427f607d7bea76b35e5 ### System information Windows 11 ### Issue description The solution generated with `scons platform=windows vsproj=yes dev_build=yes` will not build unless `scons` is available on the path. I am using conda environments with python as is recommended. I only have scons installed in one of the virtual environments. Building normally with scons this way works fine, however if I generate an sln file and try to build it using Visual Studio the build fails because it can't find scons. Adding scons to the path solves the issue but that is more a workaround than an actual solution. ### Steps to reproduce - run `scons platform=windows vsproj=yes dev_build=yes` in a conda venv - try to build ### Minimal reproduction project (MRP) -
discussion,topic:buildsystem
low
Major
2,526,244,635
PowerToys
Reach out to devs of software that enhances / fixes Windows 10/11 issues to join the PowerToys project
### Description of the new feature / enhancement For many users, certain software is essential when installing Windows 10 in order to restore missing / lacking functionality. The software includes: * [7+ Taskbar Tweaker](https://ramensoftware.com/7-taskbar-tweaker) - fixes multiple lack of features within the taskbar; requires additional mods to work with Windows 11 ([see this blog post by the dev](https://ramensoftware.com/7-taskbar-tweaker-on-windows-11-with-windows-10s-taskbar) * [PersistentWindows](https://github.com/kangyu-california/PersistentWindows) - fixes a long-standing issue with Windows 10/11 where program windows don't remember their location when using multiple monitors * [StartIsBack](https://www.startisback.com/) - gives users full control over their start bar, allowing them to have it however they want; dev may not want to contribute without compensation though, as it's not freeware * Search [Everything](https://www.voidtools.com/) - is **SO** much faster and better than any search functionality built into Windows 10/11 * [TagSpaces Lite](https://github.com/tagspaces/tagspaces) - allows much easier tagging of files in Windows and searching for them far better than Windows can * [OldNewExplorer](https://msfn.org/board/topic/170375-oldnewexplorer-119/) - restores missing functionality that should never have been taken away after Windows 7 This is my personal OldNewExplorer setup, and is absolutely essential for me, along with having the "Preview pane" off. ![image](https://github.com/user-attachments/assets/f91e43c3-2f52-4b02-828d-4b37ca22bc8f) ### Scenario when this would be used? Pretty much all the time. All of this software is because Microsoft changed user interfaces, removed functionality, or newer incorporated it into Windows in the first place. Many pro users are neurodivergent, especially autistic, ADHD, or both (AuDHD), so this kind of stuff really, really, irritates us to the core. Literally to the point where users will look for **any** workarounds to add in missing functionality. These are all Quality Of Life (QOL) issues that should at least be incorporated into PowerToys where possible, even if Microsoft won't allow them to be incorporated fully into Windows 10, 11, or whatever version comes next. (I was about to make a joke about it being Windows 365, but just found out that's an actual thing that exists!!!) ### Supporting information I can't think of anything else to add here, other than linking you to [Embrace Autism](https://embrace-autism.com/), which explains a lot about neurodivergence in general. You should probably also be aware that a lot of programmers (even ones coding for Microsoft environments) fall somewhere under the trans umbrella (which is how the meme about "programmer socks" got started), so maybe link some of your colleagues to the [GDB](https://genderdysphoria.fyi/), just in case you've got a few programmers whose eggs haven't cracked yet. (If it's not obvious from my profile, yes, I'm a trans woman.)
Needs-Triage
low
Minor
2,526,272,469
deno
Support type definition packages
Let's say I install a package from npm by adding this to my deno.json imports (Any package, just as example) ``` "@types/yargs": "npm:@types/yargs", "yargs": "npm:yargs" ``` Now in my code where I use the import I always have to add the types comment to it in order to have correct IDE complition and properly understand what method and what arguments and what types it takes ``` // @deno-types="@types/yargs" import yargs from 'yargs' ``` My proposal is, may be to support something like that in the imports statements: ``` imports: { "yargs": { "types": "npm:@types/yargs", "package": "npm:yargs" } } ``` At least this) ideally Deno should resolve the type definitions as Node js does, an not have to do all these workasounds But at least something rather than adding comments in the code
suggestion,config
low
Major
2,526,286,245
pytorch
ONNX Export Fails with Dynamic Slicing on Data-Dependent Value
### ๐Ÿ› Describe the bug Hello, I am encountering an error when trying to export a PyTorch model to ONNX using torch.onnx.dynamo_export. The error suggests that dynamic slicing on a data-dependent value is not supported. Environment: Python version: 3.8 PyTorch version: 2.4.1 Error Trace: <img width="766" alt="ๅฑๅน•ๆˆชๅ›พ 2024-09-14 192450" src="https://github.com/user-attachments/assets/1ba07e41-3845-468f-b9c1-5fb8b2285de2"> The issue seems to arise when slicing with data-dependent values, specifically in the following line: <img width="342" alt="ๅฑๅน•ๆˆชๅ›พ 2024-09-14 192649" src="https://github.com/user-attachments/assets/834cf900-9771-456b-bf0e-204dc773cad6"> Any guidance on how to handle dynamic slicing or suggestions to resolve this would be greatly appreciated. Let me know if you need any modifications or additional details! ### Versions torch==2.4.1 python==3.8
module: onnx,triaged
low
Critical
2,526,326,266
PowerToys
I think Find My Mouse doesn't need on the pen/digitizer
### Description of the new feature / enhancement Find My Mouse also triggered by shaking the pen. I think it's not necessary behavior becuase the pen/digitizer points exactly to the screen we want to touch/hover/and any interact ### Scenario when this would be used? using the pen or digitizer especially drawing and painting. was annoying every time I use brush and did should exclude several apps every I meet it I can't remember it triggered even I I'm toucing/clicking ### Supporting information _No response_
Needs-Triage
low
Minor
2,526,368,025
TypeScript
Type 'never' incorrectly inferred for mixed primitive type properties assignment with strictNullChecks disabled
### ๐Ÿ”Ž Search Terms strictNullChecks false assign never ### ๐Ÿ•— Version & Regression Information - typescript 3.6.0-dev.20190612, 3.6.0, and every version on TS Playground between 3.6.1 and nightly (5.7.0-dev.20240914) - This changed between versions 3.6.0-dev.20190611 and 3.6.0-dev.20190612 - This changed in commit or PR 74c6bc1f85c2ab36fdb789aa0ef6ee5dbde5afdd (#31708) - No error in da2aa9781e582bebd531750a4b8a81d9f8be2906 ### โฏ Playground Link https://www.typescriptlang.org/play/?strictNullChecks=false&ts=5.6.2#code/C4TwDgpgBA8gRgKygXigbwFBSmATgezAEYB+ALigGdhcBLAOwHMBuLHAsAJnKpoZbZ5CAZh70ArgFs4EXK2xCwAFh4ARAIbAIrAL6sMAegNQAwusrQiFAIIAbW+0KzgtCJSgALdQDdowD9CU6pJ+4NAAFNR0TACUGADG+PTUUABmRChQ4fiIFPAIADRQANYQIBQARIpEFVAAPlBVHJwVMSgAfOhsOQgA2qUgALqZ4vQAJhCpDBBjzFBGUABq6ra0Y92I-WXDqBL2cwvLq2NQAO4B9Lx08cAAcuL2JgHxxe607qkrFhh6GIbGZgsUE4FAAChxnK53F5fFAxrRUqlZBB6MB2LRJLQXLDQJB3JE+Ex6lAJNJZHFEsk0alOJlsrlYIgigNKtVag0miJWh0utgelshiNxpNprN5sYAKK4Ai4M4XK60G73R7PV5Qd5pL4QAB0UAlAA9IDcZlBgPgoDIoN4VmsNn0BjsSQ9bAdJdL8LhdQajVoTmaLdBrcc5SiFUrnU8IC83h8tWxKSkg5l+Q7XUsbSdwrjoBqovxiaSZLg4mwFgB1D3FdQEUbrbAJtE9WmoHpQczoao8Wsi+gzIqKUQUbtTXtjX58xCcAWO4eitNHW0ThBTh2ZPYu8Xp4PnUN58MqqNqjWfWzfbCHDNQCC+S6nLEeKAAAwg+vUNxgYBcSRW4KcuFAAAqYSUBQNDiBAj5FP4+DiIwD4yDCtAenCCJIrglBsBMtgQFoUAptsuj6AsgLQMIYIQv+ULqvQ8S2OIEwWvg-jopi2LQOo4x4YgUZotm+J5kSDQaFoFJJCkqTCHSPR5EyJRlKyHA1MSnLKNyyCdJgS7TkKEwjjM84Zna2m7M6BnbvKe53BGqoxpqp4QD8zBAA ### ๐Ÿ’ป Code ```ts type Obj = { prop1?: string; prop2?: string; prop3?: number; prop4?: Date; }; // Case 1: All properties have the same type (string) const f1 = (obj: Obj, key: "prop1" | "prop2") => { obj[key] = undefined; // Valid obj[key] = null; // Valid when strictNullChecks is false }; // Case 2: Properties have different primitive types (string | number) const f2 = (obj: Obj, key: "prop1" | "prop3") => { obj[key] = undefined; // Error when strictNullChecks is false. Expected to be valid obj[key] = null; // Error. Expected to be valid when strictNullChecks is false const val = obj[key]; // Valid (type is string | number) // Workaround const obj2 = obj as {prop1?: undefined, prop3?: undefined}; obj2[key] = undefined; // Valid obj2[key] = null; // Valid when strictNullChecks is false // Valid even with `exactOptionalPropertyTypes: true`, though behavior differs delete obj[key]; }; // Case 3: Properties include both primitive and object types (string | Date) const f3 = (obj: Obj, key: "prop1" | "prop4") => { obj[key] = undefined; // Valid obj[key] = null; // Valid when strictNullChecks is false }; ``` ### ๐Ÿ™ Actual behavior 1. In Case 2, when `strictNullChecks` is false: - Assigning `undefined` results in an error: "Type 'undefined' is not assignable to type 'never'.(TS2322)" - Assigning `null` always results in an error: "Type 'null' is not assignable to type 'never'.(TS2322)" 2. The behavior is inconsistent across different combinations of property types. ### ๐Ÿ™‚ Expected behavior Since all properties in `Obj` are optional, it should be possible to assign `undefined` to `obj[key]` regardless of the `strictNullChecks` setting, unless `exactOptionalPropertyTypes` is true (which cannot be used with `strictNullChecks: false`). Additionally, when `strictNullChecks` is false, assigning `null` should be allowed for all cases. ### Additional information about the issue _No response_
Bug,Help Wanted
low
Critical
2,526,386,246
rust
Tracking Issue for strict_provenance_lints
This tracks the two lints associated with the [strict provenance](https://github.com/rust-lang/rust/issues/95228) feature: - fuzzy_provenance_casts: detects an `as` cast from an integer to a pointer. It is better to use `with_exposed_provenance` instead to make explicit what happens. - lossy_provenance_casts: detects an `as` cast from a pointer to an integer. It is better to use `expose_provenance` instead to make explicit what happens. I am not sure if having two lints here is really justified, IMO they could be merged into one -- not sure what that one should be called, though. Other than that, this seems like a useful lint to ensure the codebase follows strict provenance (or opts-out explicitly, via the methods mentioned above). I am also not sure if this shouldn't maybe be a clippy lint instead of a rustc lint? Cc @rust-lang/opsem
T-lang,C-tracking-issue,A-strict-provenance
low
Major
2,526,392,977
TypeScript
Array of object unions not working as expected
### ๐Ÿ”Ž Search Terms "array of object unions", "array union narrowing", "union narrowing", "object union operator in" ### ๐Ÿ•— Version & Regression Information - This changed between versions `5.2.2` and the latest `5.6.2` ### โฏ Playground Link [Playground](https://www.typescriptlang.org/play/?#code/JYOwLgpgTgZghgYwgAgKLigTwEJwM4oDeAUMmcgPQBUVp5yVyAKpgA4qgwD2AdH3eSoUByMGwgB+AFzIA5ABMI8AK4AbMLOQAfOYoSq4UOGGBcQmkdVr0GyAPLKwrR8gBG+DiG58eIhsPouR2cwaWQ8MChQAHNLGj9GADEuKABbYzcPZE5efhshEW404zCIqJBY+isE5AA5OFSUdwJsr1zffIDyEAbJGTKY4gBfYmJQSFhEFAAFVWVo0DwAESU4NTBkEir4-LQ8V2VgVXlkVjmFkFbvPPpGGoABRRV1ZGUQJ9AIeQSusgh9w7HMIAJQgCBS8gAPAMKgAaV4gADWIC4AHcQAA+YajcbQeBINAYTArZ4bCAAD0g7zwhMiOCyW3I1V2AEkQCFkE81i8cj4fiJQCF+pFBttrLc6r1Oat1ld2vz6D1GqURRU4uLBMhZvNFtLSXK+bsHlzZW8PiAvgryGcdSA8GFtRdljL1NixuA8VMtedFit9IZjKZLoyyMyJUswDSbRcDTdNcaXRszUpPt9OiJ5JGQWCIdDVdF4W9kWjMW7cZMCeg6X6DEYTGZkBSqfIaVWsLgWiHKDtw2Da4GG7y42QCvQ9P36yBheVKkye5rHbrxwHJ7GOhKE-rkzBU1ayNHFg6fXaayug26xOxaVF-nZWJOaQBea-ExPaF+nuvn0bgu0bLj3kGeAyG2wC3oBZh4AA2gAusgz5QeqNQABJmP8YCqJgyAABbQCgLLIKiQTHI25LsAgGwsOwADKCBRPeohcG4KB4OkUBkii8zYTUYBMWsvHpCYCBwKomFXDA0CiOINLNF8yANmYYlocgUAQAAjocqknKwUAAdAYjIAAFAABoKjjGQAlDUcDvKcwAIIiNLglAqkUa0Ez4v8yA2ScImqNKeB0cAEF2m4LgEcJlz4HgyiNDx2EZGA2HADSKXIKkKQoOCqRnBSogJZcwAbHgQS2Xumx+OQZlgDIsg8BQeBQAgFCgIo5I8JGsjwpVZBBE4ji1fV8gpWALXvBSPCpAAVngXXID1lAUMgKIBUFIXyVA3mOFw2W5ZA802Nax7AZsjYAkc8gyIQQzIEMsILRQS0rYogX0auKRbbxu2qBA+0LUqEC1SaLwA11C2XoDuiJrIIh3aMYo1AAgqoJXedEcCgPJIBKRaKnqZpck6Xp7FYcZy5fmYmio0VhHEScrgoCA9kcDAB0SlREC0W9yDgmovnbYJ9l+VhnCSUlKCothXA-e5noEs5rkYZgPxs2QXZjn2Z5mINDVNRQEN4B1s33YdvXBANchDSN+vSWNbU8PIRtg6byBFIJtX-Kkzum49y1MS9a3vZt-E7VwOU-X9LsHnaV2cpGV03XDLu+89-yB0GG2faH4e-Sg-29EDmsU5coMm6bEOF-6xcw-QIwwaMzKMARBCGAguG+cgqhcP+lzi8tv3ebZwmNN5dFcHgNJJWlFINLlOFgE4wGPREiCIlwABueJd6iPDZRQGnoUBFAAOwAMwAIwAKyXwATAAbOfFBS6iAC0vEvz0Lloi-8gli-cAv2iBAC0UQEBv3EC-WS8gX5mBga4KaYIwAvyJuwEm4D2CkEYJLPCyBjJTWEqoAAXmTNOUQGY0h8sgBYm8KGXBnjnHCaJGLLUMLpVE+UUAG0yAQE4Cl4GIOQIiCAmA8DdVsAcDYBFojKH+JPZKqU5FZWUC5YBGwiJQERDEcI0tHAZ0ob-f45g1EpERK0byokeYeFEQdJu5jUZEXGptZ+zDf7ZDUbhXuuFBHCNOLpVBBk0oAUnCJQeJwUTFXIsAHcclMZcH4RRCQmDhDEAhmgSkRgKJ2BANMPxkImDwgANKkWbDSIRmAuCs3ycgAAahieCIgmDFOAS2BExZ0TIAkDUpp1JmBQQKXBRJ9BCDICgtMMxZSKnMBgjIMZTZmk0iKZ0pgoy4IADIukyGWdMOCIx6AyAtJvTa+yICHNGKk0C4EHzTGgDkgC8E0mREQGALJtzWCQjbK+Uk8JZAQzmgoaGdSdAPIyc87JuSPmfgHCAb5vzvnkyhbIOpowYBvAohnc0EAADCZgdzREMkEoCIEMBgTwHeK5Ny-GwQskSkUlygLXKgK82CFV6CqTAMoy4BLILDHmsQDF2KvDADxYhIZC1qo60as1VqE1OpiNNn1IUlsKDDQiHbCa01jYLWjidYZ-wDgXQTrdMuh0AaF31KXcG4gzXcg0LDY1LLTbwsnBKvWBsnb2sCObGqSqVWjQNmq9qjtZULTdsYD2rFvaHW1bHTMOrE4eu6AXKGVcoUsMaJGmwFdk0TiDDXcgScmRLQMTScJtMNHZFZsZCGxlsglu7nqXcoqXbiqVZKgN7rVY2AVRbOqyrrbSvahqjN9Bo2nT1YCS6mx4350aNa2UFra73RghZIAA) ### ๐Ÿ’ป Code ```ts interface EntryBase { /** * Type info... */ type?: 'default' | 'declaration' /** * Output base info... */ output?: string /** * Format base info... */ format?: string /** * Name base info... */ name?: string } interface PluginsDefault { /** * Esbuild plugin info... * * @default undefined */ esbuild?: Record<string, unknown> } interface EntryDefault extends EntryBase { /** * Input default info... */ input: string /** * Name default info... */ name?: string /** * Plugins default info... * * @default undefined */ plugins?: PluginsDefault } interface PluginsDeclaration { /** * Dts plugin info... * * @default undefined */ dts?: Record<string, unknown> } interface EntryDeclaration extends EntryBase { /** * Declaration info... */ declaration: string /** * Plugins declaration info... * * @default undefined */ plugins?: PluginsDeclaration } type EntriesOptions = EntryDefault | EntryDeclaration const options: EntriesOptions[] = [ /** * Honestly here I would expect TypeScript to be smart enough * to automatically inffer types based on only one required property (`input`) * and picks correct interfaces and all descriptions but I can assume * that this is more complex than it sound */ { input: './src/index.ts', output: './dist/index.mjs', // no description or autocomplete plugins: { esbuild: {} }, // no description or autocomplete name: 'default name', type: 'default' }, /** * Also again only one required property `declaration' so it would be nice if * TypeScript could automatically infer the whole interface correctly */ { declaration: './src/types.ts', output: './dist/types/index.d.ts', format: 'esm', // no description or autocomplete plugins: { dts: {} }, // no description or autocomplete name: 'declaration name', type: 'declaration' } ] /** * I searched a lot on the net and came across this example https://stackoverflow.com/questions/73155261/how-to-narrow-down-a-generic-type-based-on-object-property-type * where `jcalz`describes and gives an example how to narrow the types based on object keys, * but I guess this is the current working solution and doesn't work in all cases, * I also wonder how to do it when the key property is optional and not specified in object? */ type ExtractOnProp<T, K extends keyof T, V> = T extends unknown ? V extends T[K] ? { [P in keyof T]: P extends K ? T[P] & V : T[P] } : never : never type EntriesOptionsPerProp = ExtractOnProp<EntryDefault, 'type', 'default'> | ExtractOnProp<EntryDeclaration, 'type', 'declaration'> function defineConfig(options: EntriesOptionsPerProp[]): EntriesOptionsPerProp[] { return options } defineConfig([ { input: './src/index.ts', output: './dist/index.mjs', plugins: { esbuild: {} }, name: 'default name', type: 'default' }, { declaration: './src/types.ts', output: './dist/types/index.d.ts', format: 'esm', plugins: { dts: {} }, name: 'declaration name', type: 'declaration' }, // does not work if `type` is not defined { input: './src/index.ts', output: './dist/index.mjs', plugins: { esbuild: {} }, name: 'default name', }, ]) ``` ### ๐Ÿ™ Actual behavior Hi, as discussed in previous issue [#56082](https://github.com/microsoft/TypeScript/issues/56082) and the merged [PR](https://github.com/microsoft/TypeScript/pull/56088), it seems like this area could use some internal improvements. When we have multiple interfaces that extend the base interface, then the types are not picked up correctly when defining a new array of object unions. Also, properties from the object do not get description information or offer correct auto-completion which can be confusing. ### ๐Ÿ™‚ Expected behavior I expect it to offer the correct auto-completion for each object and give the right information when I hover over a property to see the type or description of what that option does. ### Additional information about the issue I mentioned some examples and expectations of behavior in the playground.
Needs More Info
low
Minor
2,526,405,454
pytorch
gesvda driver of svd returns nan for zero matrix
### ๐Ÿ› Describe the bug ```python import torch torch.linalg.svd(torch.zeros(3,3).cuda(), full_matrices=False, driver='gesvda') ``` ![image](https://github.com/user-attachments/assets/97b7876a-3a95-442b-a523-f568b8d39e50) ### Versions PyTorch version: 2.3.1 Is debug build: False CUDA used to build PyTorch: 12.1 ROCM used to build PyTorch: N/A OS: Ubuntu 22.04.3 LTS (x86_64) GCC version: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0 Clang version: Could not collect CMake version: Could not collect Libc version: glibc-2.35 Python version: 3.10.14 | packaged by conda-forge | (main, Mar 20 2024, 12:45:18) [GCC 12.3.0] (64-bit runtime) Python platform: Linux-5.15.0-94-generic-x86_64-with-glibc2.35 Is CUDA available: True CUDA runtime version: 12.2.140 CUDA_MODULE_LOADING set to: LAZY GPU models and configuration: GPU 0: NVIDIA H100 80GB HBM3 GPU 1: NVIDIA H100 80GB HBM3 GPU 2: NVIDIA H100 80GB HBM3 GPU 3: NVIDIA H100 80GB HBM3 GPU 4: NVIDIA H100 80GB HBM3 GPU 5: NVIDIA H100 80GB HBM3 GPU 6: NVIDIA H100 80GB HBM3 GPU 7: NVIDIA H100 80GB HBM3 Nvidia driver version: 535.154.05 cuDNN version: Could not collect HIP runtime version: N/A MIOpen runtime version: N/A Is XNNPACK available: True CPU: Architecture: x86_64 CPU op-mode(s): 32-bit, 64-bit Address sizes: 46 bits physical, 57 bits virtual Byte Order: Little Endian CPU(s): 176 On-line CPU(s) list: 0-175 Vendor ID: GenuineIntel Model name: Intel(R) Xeon(R) Platinum 8468V CPU family: 6 Model: 143 Thread(s) per core: 2 Core(s) per socket: 44 Socket(s): 2 Stepping: 8 BogoMIPS: 4800.00 Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc arch_perfmon rep_good nopl xtopology nonstop_tsc cpuid tsc_known_freq pni pclmulqdq vmx ssse3 fma cx16 pdcm pcid sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch cpuid_fault invpcid_single ssbd ibrs ibpb stibp ibrs_enhanced tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid avx512f avx512dq rdseed adx smap avx512ifma clflushopt clwb avx512cd sha_ni avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves avx_vnni avx512_bf16 wbnoinvd arat avx512vbmi umip pku ospke waitpkg avx512_vbmi2 gfni vaes vpclmulqdq avx512_vnni avx512_bitalg avx512_vpopcntdq la57 rdpid bus_lock_detect cldemote movdiri movdir64b fsrm md_clear serialize tsxldtrk avx512_fp16 arch_capabilities Virtualization: VT-x Hypervisor vendor: KVM Virtualization type: full L1d cache: 4.1 MiB (88 instances) L1i cache: 2.8 MiB (88 instances) L2 cache: 176 MiB (88 instances) L3 cache: 195 MiB (2 instances) NUMA node(s): 2 NUMA node0 CPU(s): 0-87 NUMA node1 CPU(s): 88-175 Vulnerability Gather data sampling: Not affected Vulnerability Itlb multihit: Not affected Vulnerability L1tf: Not affected Vulnerability Mds: Not affected Vulnerability Meltdown: Not affected Vulnerability Mmio stale data: Not affected Vulnerability Retbleed: Not affected Vulnerability Spec rstack overflow: Not affected Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl and seccomp Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization Vulnerability Spectre v2: Mitigation; Enhanced IBRS, IBPB conditional, RSB filling, PBRSB-eIBRS SW sequence Vulnerability Srbds: Not affected Vulnerability Tsx async abort: Mitigation; TSX disabled Versions of relevant libraries: [pip3] numpy==1.26.4 [pip3] torch==2.3.1 [pip3] torchaudio==2.3.1 [pip3] torchvision==0.18.1 [pip3] triton==2.3.1 [conda] blas 2.116 mkl conda-forge [conda] blas-devel 3.9.0 16_linux64_mkl conda-forge [conda] libblas 3.9.0 16_linux64_mkl conda-forge [conda] libcblas 3.9.0 16_linux64_mkl conda-forge [conda] liblapack 3.9.0 16_linux64_mkl conda-forge [conda] liblapacke 3.9.0 16_linux64_mkl conda-forge [conda] libopenvino-pytorch-frontend 2024.2.0 he02047a_1 conda-forge [conda] mkl 2022.1.0 h84fe81f_915 conda-forge [conda] mkl-devel 2022.1.0 ha770c72_916 conda-forge [conda] mkl-include 2022.1.0 h84fe81f_915 conda-forge [conda] numpy 1.26.4 py310hb13e2d6_0 conda-forge [conda] pytorch 2.3.1 py3.10_cuda12.1_cudnn8.9.2_0 pytorch [conda] pytorch-cuda 12.1 ha16c6d3_5 pytorch [conda] pytorch-mutex 1.0 cuda pytorch [conda] torchaudio 2.3.1 py310_cu121 pytorch [conda] torchtriton 2.3.1 py310 pytorch [conda] torchvision 0.18.1 py310_cu121 pytorch cc @jianyuh @nikitaved @pearu @mruberry @walterddr @xwang233 @Lezcano
triaged,module: linear algebra
low
Critical
2,526,430,394
godot
POT translation genaration ignores `TranslationServer.translate()`
### Tested versions Any 4.x ### System information Windows 11 ### Issue description POT generator ignores strings that are translated via `TranslationServer.translate()` or `TranslationServer.translate_plural()`. ### Steps to reproduce * Add following script to be translated: ``` extends Node func _ready(): print(tr("Hello")) static func test(): print(TranslationServer.translate("World")) ``` * Run the generator * Inspect resulting file. There's no data point for "World". ### Minimal reproduction project (MRP) [POT-MRP.zip](https://github.com/user-attachments/files/17002645/POT-MRP.zip)
enhancement,discussion,topic:gdscript,topic:gui
low
Minor
2,526,447,498
opencv
change condition of CV_DbgAssert from _DEBUG to NDEBUG
--- to make it's precondition same as `CV_DbgCheckXX`. Or further, replace all `#if defined _DEBUG` with `#if !defined NDEBUG`. The C++ standard only mentions `NDEBUG` as the condition of `assert` macro, no `_DEBUG`. https://github.com/opencv/opencv/blob/e1fec1562714eb41ae48f97310b254618a26d248/modules/core/include/opencv2/core/base.hpp#L389-L394 https://github.com/opencv/opencv/blob/e1fec1562714eb41ae48f97310b254618a26d248/modules/core/include/opencv2/core/check.hpp#L153-L169
feature,category: core,category: build/install
low
Critical
2,526,448,103
pytorch
Same token different output from `Conv1d`
### ๐Ÿ› Describe the bug As can be seen from the following example, the output of `Conv1d` is different when it process the same token in a sequence. There is a small difference, although the result should be the same since the tokens are the same. Please note that this seems to be machine-dependent. I have tried it in a different system (different CPU) and the results are identical. ```python import torch torch.manual_seed(1) torch.set_printoptions(10) conv = torch.nn.Conv1d(7, 64, kernel_size=1) conv.eval() # Shape (N, C). foo = torch.randn(10, 7) bar = torch.cat((foo, foo)) # Shape (B, C, N). out_foo = conv(foo.T.unsqueeze(0)) out_bar = conv(bar.T.unsqueeze(0)) # Print the first feature of all tokens. print(out_foo[0, 0], end='\n\n') print(out_bar[0, 0], end='\n\n') # Expexted to be True. print(out_foo[0, 0, -2] == out_bar[0, 0, -2]) ``` The output is: ```bash tensor([-0.1154084802, -0.8093891740, -0.3866646290, 0.2218701988, -0.5008030534, -1.0073745251, 0.2361510843, -0.8011215925, **0.3446169496**, -0.4761531949], grad_fn=<SelectBackward0>) tensor([-0.1154084802, -0.8093891740, -0.3866646290, 0.2218701988, -0.5008030534, -1.0073745251, 0.2361510843, -0.8011215925, 0.3446169496, -0.4761531949, -0.1154084802, -0.8093891740, -0.3866646290, 0.2218701988, -0.5008030534, -1.0073745251, 0.2361510545, -0.8011215925, **0.3446168900**, -0.4761531949], grad_fn=<SelectBackward0>) tensor(False) ``` ### Versions PyTorch version: 2.2.1+cu121 Is debug build: False CUDA used to build PyTorch: 12.1 ROCM used to build PyTorch: N/A OS: Fedora Linux 39 (Workstation Edition) (x86_64) GCC version: (GCC) 13.3.1 20240522 (Red Hat 13.3.1-1) Clang version: Could not collect CMake version: Could not collect Libc version: glibc-2.38 Python version: 3.12.5 (main, Aug 7 2024, 00:00:00) [GCC 13.3.1 20240522 (Red Hat 13.3.1-1)] (64-bit runtime) Python platform: Linux-6.10.7-100.fc39.x86_64-x86_64-with-glibc2.38 Is CUDA available: False CUDA runtime version: No CUDA CUDA_MODULE_LOADING set to: N/A GPU models and configuration: No CUDA Nvidia driver version: No CUDA cuDNN version: No CUDA HIP runtime version: N/A MIOpen runtime version: N/A Is XNNPACK available: True CPU: Architecture: x86_64 CPU op-mode(s): 32-bit, 64-bit Address sizes: 39 bits physical, 48 bits virtual Byte Order: Little Endian CPU(s): 8 On-line CPU(s) list: 0-7 Vendor ID: GenuineIntel Model name: Intel(R) Core(TM) i5-8250U CPU @ 1.60GHz CPU family: 6 Model: 142 Thread(s) per core: 2 Core(s) per socket: 4 Socket(s): 1 Stepping: 10 CPU(s) scaling MHz: 28% CPU max MHz: 3400.0000 CPU min MHz: 400.0000 BogoMIPS: 3600.00 Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb pti ssbd ibrs ibpb stibp tpr_shadow flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid mpx rdseed adx smap clflushopt intel_pt xsaveopt xsavec xgetbv1 xsaves dtherm ida arat pln pts hwp hwp_notify hwp_act_window hwp_epp vnmi md_clear flush_l1d arch_capabilities Virtualization: VT-x L1d cache: 128 KiB (4 instances) L1i cache: 128 KiB (4 instances) L2 cache: 1 MiB (4 instances) L3 cache: 6 MiB (1 instance) NUMA node(s): 1 NUMA node0 CPU(s): 0-7 Vulnerability Gather data sampling: Mitigation; Microcode Vulnerability Itlb multihit: KVM: Mitigation: VMX disabled Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable Vulnerability Mds: Mitigation; Clear CPU buffers; SMT vulnerable Vulnerability Meltdown: Mitigation; PTI Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable Vulnerability Reg file data sampling: Not affected Vulnerability Retbleed: Mitigation; IBRS Vulnerability Spec rstack overflow: Not affected Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization Vulnerability Spectre v2: Mitigation; IBRS; IBPB conditional; STIBP conditional; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected Vulnerability Srbds: Mitigation; Microcode Vulnerability Tsx async abort: Not affected Versions of relevant libraries: [pip3] numpy==1.26.4 [pip3] pytorch-lightning==2.2.0.post0 [pip3] torch==2.2.1 [pip3] torchmetrics==1.3.1 [pip3] torchvision==0.17.1 [pip3] torchviz==0.0.2 [conda] Could not collect
module: convolution,triaged
low
Critical
2,526,448,577
ant-design
Collapse design token is bugged with ConfigProvider
### Reproduction link [![Edit on StackBlitz](https://developer.stackblitz.com/img/open_in_stackblitz.svg)](https://stackblitz.com/edit/antd-reproduce-5x-sy1mss?file=demo.tsx) ### Steps to reproduce 1- Add ConfigProvider with custom theme for Collapse component. 2- Add Collapse component ### What is expected? Header background should be #CCD2E3 while content background should be #fff ### What is actually happening? The entire collapse component background is #CCD2E3 | Environment | Info | | --- | --- | | antd | 5.20.6 | | React | 18.0.0 | | System | Windows 10 | | Browser | Chrome version 126.0.6478.127 | <!-- generated by ant-design-issue-helper. DO NOT REMOVE -->
๐Ÿ› Bug,Inactive
low
Critical
2,526,456,953
storybook
[Bug]: Rendering of MDX documentation fails when the imported stories file changes
### Describe the bug When adding a new story to a stories file that is imported in a .mdx file, the following error is thrown: ``` Invalid value passed to the 'of' prop. The value was resolved to a 'component or unknown' type but the only types for this block are: story. ``` It happens when the imported story files is modified in other ways as well, but this is the most simple case to replicate this bug. ### Reproduction link https://stackblitz.com/edit/github-unrkza-3cuztn?file=src%2Fstories%2FButton.stories.ts ### Reproduction steps 1. Go to the link above 2. Open "Buttons documentation" doc in the preview pane 3. Open `src/stories/Button.stories.tsx` file 4. Duplicate e.g. the `Secondary` story and rename it to e.g. `Tertiary` Expected behavior: The doc is still rendered correctly. Actual behavior: The error mentioned above it thrown. ### System ```bash I'm not sure how to run `npx storybook@latest info` on StackBlitz, as the terminal does not seem to work for me. I am using the React 18 Webpack template, which uses Storybook 8.4.0-alpha.0. ``` ### Additional context It makes writing documentation using MDX files a bit frustrating ;)
bug,needs triage
low
Critical
2,526,479,067
godot
Inconsistent setter invocation in inherited scene without changed script and with overridden script
### Tested versions v4.3.stable.official [77dcf97d8] ### System information Macos Sonoma 14.6.1 (23G93) ### Issue description Instantiating the inherited scene (Test3), which inherits from the base scene (Test1), triggers the setter for an exported variable, even though it is not triggered in the inherited scene that doesnโ€™t override the script (Test2). In the base scene (Test1), there is an exported variable with a setter that accesses a property of an object (e.g., val.name). When the script is overridden in the inherited scene (Test3), the setter is triggered, but in the inherited scene without the script override (Test2), the setter is not triggered. This leads to inconsistent behavior. Expected result: The behavior should be the same in both inherited scenes (Test2 and Test3). Actual result: In the inherited scene (Test3), the setter is triggered, whereas in the inherited scene without the script override (Test2), the setter is not triggered. This leads to inconsistent behavior in how setters are invoked across inherited scenes. ### Steps to reproduce Create a base scene (Test1) with a class extending Node2D and a script: ``` extends Node2D class_name Test1 @export var my_export_var: Resource set = _my_setter func _my_setter(val): my_export_var = val print(val.name) ``` Create an inherited scene (Test2) that inherits from the base scene (Test1) without changing the script. Create another inherited scene (Test3), also inheriting from the base scene (Test1), but with an overridden script: `extends Test1` Instantiate the inherited scene (Test3). ### Minimal reproduction project (MRP) [godotbuginstantiateexportsetter.zip](https://github.com/user-attachments/files/17002963/godotbuginstantiateexportsetter.zip)
topic:gdscript,confirmed
low
Critical
2,526,512,894
go
x/telemetry/internal/upload: TestRun_Basic failures
``` #!watchflakes default <- pkg == "golang.org/x/telemetry/internal/upload" && test == "TestRun_Basic" ``` Issue created automatically to collect these failures. Example ([log](https://ci.chromium.org/b/8736804516105437489)): === RUN TestRun_Basic run_test.go:68: 18:38:27.762138 findwork.go:35: Finding work: mode on asof 2023-09-15 00:00:00 +0000 UTC run_test.go:68: 18:38:27.762675 findwork.go:50: Collecting count file upload.test@devel-devel-netbsd-arm64-2024-09-06.v1.count run_test.go:68: 18:38:27.763190 reports.go:34: Last week: , today: 2024-09-14 run_test.go:68: 18:38:27.764060 reports.go:268: Created 2024-09-08.json, deleting 1 count files run_test.go:68: 18:38:27.764333 reports.go:68: Ready to upload: 2024-09-08.json run_test.go:68: 18:38:27.764372 run.go:172: Uploading 1 reports run_test.go:68: 18:38:27.766345 upload.go:115: Uploaded 2024-09-08.json to "http://127.0.0.1:55828/2024-09-08" run_test.go:153: Mismatching uploaded report: got: ... "GOARCH": "arm64", "Counters": { "knownCounter": 1 }, "Stacks": {} } ], "Config": "v1.2.3" } --- FAIL: TestRun_Basic (0.07s) โ€” [watchflakes](https://go.dev/wiki/Watchflakes)
NeedsInvestigation,telemetry
low
Critical
2,526,516,048
rust
rustdoc: tracking issue for improved path handling
looking through old rustdoc issue, there's a common theme of wanting to display or act on an item's canonical path instead of just its name. unfortunately, this information is not easily available to the librustdoc render logic. * [ ] https://github.com/rust-lang/rust/issues/105307 * [ ] https://github.com/rust-lang/rust/issues/45260 * [ ] https://github.com/rust-lang/rust/issues/130189 * [ ] https://github.com/rust-lang/rust/issues/84367 (has more to do with canon names than paths, but still related)
T-rustdoc,C-tracking-issue
low
Minor
2,526,517,794
rust
Make E0277 on `Sized` its own error code with more focused explanation
### Code ```Rust // inspired by https://github.com/rust-lang/rust/issues/130326 fn main() { let mut a = String::new(); let b = String::new(); *a = *b; } fn other_fn(x: str) { _ = x; } ``` ### Current output ```Shell error[E0277]: the size for values of type `str` cannot be known at compilation time --> src/main.rs:4:5 | 4 | *a = *b; | ^^ doesn't have a size known at compile-time | = help: the trait `Sized` is not implemented for `str` = note: the left-hand-side of an assignment must have a statically known size error[E0277]: the size for values of type `str` cannot be known at compilation time --> src/main.rs:7:13 | 7 | fn other_fn(x: str) { | ^ doesn't have a size known at compile-time | = help: the trait `Sized` is not implemented for `str` help: function arguments must have a statically known size, borrowed types always have a known size | 7 | fn other_fn(x: &str) { | + ``` ### Desired output ```Shell error[E0SOME_DEDICATED_ERROR_CODE]: cannot assign a value of type `str` because it does not have a size known at compile time --> src/main.rs:4:5 | 4 | *a = *b; | ^^ doesn't have a size known at compile time | = note: the assignment operator can only be used with values of a statically known size, which implement `Sized` = note: the trait `Sized` is not implemented for `str` = help: consider assigning to a `String` or `&str` instead of `str` error[E0SOME_DEDICATED_ERROR_CODE]: a value of type `str` cannot be a function argument because it does not have a size known at compile time --> src/main.rs:7:13 | 7 | fn other_fn(x: str) { | ^ doesn't have a size known at compile-time | = note: function arguments must have a statically known size; they must implement `Sized` = note: the trait `Sized` is not implemented for `str` help: consider passing the argument by reference: | 7 | fn other_fn(x: &str) { | + ``` ### Rationale and extra context Beginners are frequently confused by this error; I believe this most often results in asking the question โ€œhow do I implement `Sized`โ€. As I see it, there are several problems with the error text: * [E0277](https://doc.rust-lang.org/error_codes/E0277.html) is the general โ€œtrait not implementedโ€ error code. But teaching users about trait implementations in general is not helpful here, because users cannot implement `Sized`. (It might be relevant if the type in question is a generic parameter, in which case adding a bound would be useful.) And, it would be a good time to introduce the specific idea of dynamically sized types. * The specific problemย in the first case, that an _assignment_ must be of a `Sized` type, is left down at the fourth part of the message; until they get there, the user cannot see what the error has to do with what they are trying to do. * The existing message for the assignment doesn't give actionable advice, but could, by mentioning the common `Sized` containers for `!Sized` types. * The existing message for the function declaration, โ€œhelp: function arguments mustโ€ฆโ€, is making a suggestion, but it isn't phrased to make it clear it's making a suggestion ### Rust Version Stable 1.81.0 (playground)
A-diagnostics,T-compiler,D-terse,T-libs,A-error-codes
low
Critical
2,526,520,234
pytorch
Have a way to mark that particular buffers can be reused for Inductor
### ๐Ÿš€ The feature, motivation and pitch Let's say we want to benchmark a function where the inputs are reused (say a pointwise op). This is quite annoying to do today in Inductor For example, for this function, there's no easy way to make this function inplace. ``` import torch from torch import Tensor from torch import nn from typing import Optional, List, Tuple, Union torch.set_default_device('cuda') from triton.testing import do_bench class RMSNorm(nn.Module): """Root mean square normalization. Computes x -> w * x / sqrt(E[x^2] + eps) where w is the learned weight. Refer to https://arxiv.org/abs/1910.07467 """ def __init__( self, hidden_size: int, eps: float = 1e-6, ) -> None: super().__init__() self.weight = nn.Parameter(torch.ones(hidden_size)) self.variance_epsilon = eps self.cuda = False def forward( self, x: torch.Tensor, residual: Optional[torch.Tensor] = None, ) -> Union[torch.Tensor, Tuple[torch.Tensor, torch.Tensor]]: """PyTorch-native implementation equivalent to forward().""" orig_dtype = x.dtype x = x.to(torch.float32) if residual is not None: x = x + residual.to(torch.float32) residual = x.to(orig_dtype) variance = x.pow(2).mean(dim=-1, keepdim=True) x = x * torch.rsqrt(variance + self.variance_epsilon) x = x.to(orig_dtype) * self.weight if residual is None: return x else: return x, residual def bench_mod(mod, inp, residual): torch.cuda.reset_peak_memory_stats() with torch.no_grad(): ms = do_bench(lambda: mod(inp, residual)) print("ms: ", ms) print("Bandwidth: ", (1e3/ms) * inp.numel() * inp.dtype.itemsize * 3 / 1e9, " GB/s") print("peak mem: ", torch.cuda.max_memory_allocated()/1e9, "GB") mod = RMSNorm(8192).to(dtype=torch.bfloat16) inp = torch.randn(8192, 8192, dtype=torch.bfloat16) residual = torch.randn(8192, 8192, dtype=torch.bfloat16) bench_mod(torch.compile(mod), inp, residual) ``` ### Alternatives _No response_ ### Additional context _No response_ cc @ezyang @chauhang @penguinwu @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire
triaged,oncall: pt2,module: inductor
low
Minor
2,526,521,465
rust
rustdoc::clean is missing glob re-exports
### Location https://doc.rust-lang.org/nightly/nightly-rustc/rustdoc/clean/index.html ### Summary items like `clean::Item` should show up here, but they do not, they only show up at their original definition site, `clean::types::Item`. possibly related: https://github.com/rust-lang/rust/issues/53724
T-rustdoc,C-discussion,A-local-reexports
low
Minor
2,526,532,645
pytorch
Setting wrong type values to `kernel_size`, `stride`, `padding` and `dilation` argument of `nn.MaxPool1d()` gets the wrong error messages saying only `tuple of ints`
### ๐Ÿ› Describe the bug [The doc](https://pytorch.org/docs/stable/generated/torch.nn.MaxPool1d.html) of `nn.MaxPool1d()` says `kernel_size`, `stride`, `padding` and `dilation` argument are `int` or `tuple` of `int`) as shown below: > Parameters > - kernel_size ([Union](https://docs.python.org/3/library/typing.html#typing.Union)[[int](https://docs.python.org/3/library/functions.html#int), [Tuple](https://docs.python.org/3/library/typing.html#typing.Tuple)[[int](https://docs.python.org/3/library/functions.html#int)]]) โ€“ The size of the sliding window, must be > 0. > - stride ([Union](https://docs.python.org/3/library/typing.html#typing.Union)[[int](https://docs.python.org/3/library/functions.html#int), [Tuple](https://docs.python.org/3/library/typing.html#typing.Tuple)[[int](https://docs.python.org/3/library/functions.html#int)]]) โ€“ The stride of the sliding window, must be > 0. Default value is kernel_size. > - padding ([Union](https://docs.python.org/3/library/typing.html#typing.Union)[[int](https://docs.python.org/3/library/functions.html#int), [Tuple](https://docs.python.org/3/library/typing.html#typing.Tuple)[[int](https://docs.python.org/3/library/functions.html#int)]]) โ€“ Implicit negative infinity padding to be added on both sides, must be >= 0 and <= kernel_size / 2. > - dilation ([Union](https://docs.python.org/3/library/typing.html#typing.Union)[[int](https://docs.python.org/3/library/functions.html#int), [Tuple](https://docs.python.org/3/library/typing.html#typing.Tuple)[[int](https://docs.python.org/3/library/functions.html#int)]]) โ€“ The stride between elements within a sliding window, must be > 0. But setting wrong type values to them gets the wrong error messages saying only `tuple of ints` as shown below. *It also happens with [nn.MaxPool2d()](https://pytorch.org/docs/stable/generated/torch.nn.MaxPool2d.html) and [nn.MaxPool3d()](https://pytorch.org/docs/stable/generated/torch.nn.MaxPool3d.html): ```python import torch from torch import nn my_tensor = torch.tensor([[8., -3., 0., 1., 5., -2.]]) # โ†“โ†“ maxpool1d = nn.MaxPool1d(kernel_size=1.) maxpool1d(input=my_tensor) # Error # โ†“โ†“ maxpool1d = nn.MaxPool1d(kernel_size=1, stride=1.) maxpool1d(input=my_tensor) # Error # โ†“โ†“ maxpool1d = nn.MaxPool1d(kernel_size=1, padding=0.) maxpool1d(input=my_tensor) # Error # โ†“โ†“ maxpool1d = nn.MaxPool1d(kernel_size=1, dilation=1.) convtran1d(input=my_tensor) # Error ``` > TypeError: max_pool1d(): argument 'kernel_size' (position 2) must be tuple of ints, not float > TypeError: max_pool1d(): argument 'stride' (position 3) must be tuple of ints, not float > TypeError: max_pool1d(): argument 'padding' (position 4) must be tuple of ints, not float > TypeError: max_pool1d(): argument 'dilation' (position 5) must be tuple of ints, not float So, they should be something like as shown below. *`list` of `int` also works so `list` of `int` can also be added: > TypeError: conv_transpose1d(): argument 'stride' (position 4) must be `int` or `tuple` of `int`, but found element of type float at pos 0 > TypeError: conv_transpose1d(): argument 'padding' (position 5) must be `int` or `tuple` of `int`, but found element of type float at pos 0 > TypeError: conv_transpose1d(): argument 'output_padding' (position 6) must be `int` or `tuple` of `int`, but found element of type float at pos 0 > TypeError: conv_transpose1d(): argument 'dilation' (position 8) must be `int` or `tuple` of `int`, but found element of type float at pos 0 ### Versions ```python import torch torch.__version__ # '2.3.0' ``` cc @malfet @albanD
low priority,module: error checking,triaged,actionable,module: python frontend
low
Critical
2,526,535,422
pytorch
Quantized model is way slower than regular model.
## Issue description Quantized model is way slower than regular model. Log: > model: LSTM( (lstm): LSTM(1, 50, batch_first=True) (fc): Linear(in_features=50, out_features=1, bias=True) ) quantized_model: LSTM( (lstm): DynamicQuantizedLSTM(1, 50, batch_first=True) (fc): DynamicQuantizedLinear(in_features=50, out_features=1, dtype=torch.qint8, qscheme=torch.per_tensor_affine) ) Size (MB): 0.04497 Size (MB): 0.015388 (quantized) loss: 0.0001180 elapsed time (seconds): 10.2846 loss: 0.0001596 elapsed time (seconds): 33.8518 (quantized) ` ## Code example [link](https://gist.github.com/Eugene29/71428f93fce97ad9af00f8c59e8d2eb7) ## System Info Pytorch: 2.3.1 cc @jerryzh168 @jianyuh @raghuramank100 @jamesr66a @vkuzo @jgong5 @Xia-Weiwen @leslie-fang-intel @msaroufim
oncall: quantization
low
Major
2,526,539,114
pytorch
Each parameter of `nn.MaxPool1d()`, `nn.MaxPool2d()` and `nn.MaxPool3d()` should have `required` or `optional`
### ๐Ÿ“š The doc issue The docs of [nn.MaxPool1d()](https://pytorch.org/docs/stable/generated/torch.nn.MaxPool1d.html), [nn.MaxPool2d()](https://pytorch.org/docs/stable/generated/torch.nn.MaxPool2d.html) and [nn.MaxPool3d()](https://pytorch.org/docs/stable/generated/torch.nn.MaxPool3d.html) don't say which parameters are required or optional as shown below: > Parameters > - kernel_size ([Union](https://docs.python.org/3/library/typing.html#typing.Union)[[int](https://docs.python.org/3/library/functions.html#int), [Tuple](https://docs.python.org/3/library/typing.html#typing.Tuple)[[int](https://docs.python.org/3/library/functions.html#int)]]) โ€“ The size of the sliding window, must be > 0. > - stride ([Union](https://docs.python.org/3/library/typing.html#typing.Union)[[int](https://docs.python.org/3/library/functions.html#int), [Tuple](https://docs.python.org/3/library/typing.html#typing.Tuple)[[int](https://docs.python.org/3/library/functions.html#int)]]) โ€“ The stride of the sliding window, must be > 0. Default value is kernel_size. > - padding ([Union](https://docs.python.org/3/library/typing.html#typing.Union)[[int](https://docs.python.org/3/library/functions.html#int), [Tuple](https://docs.python.org/3/library/typing.html#typing.Tuple)[[int](https://docs.python.org/3/library/functions.html#int)]]) โ€“ Implicit negative infinity padding to be added on both sides, must be >= 0 and <= kernel_size / 2. > - dilation ([Union](https://docs.python.org/3/library/typing.html#typing.Union)[[int](https://docs.python.org/3/library/functions.html#int), [Tuple](https://docs.python.org/3/library/typing.html#typing.Tuple)[[int](https://docs.python.org/3/library/functions.html#int)]]) โ€“ The stride between elements within a sliding window, must be > 0. > - return_indices ([bool](https://docs.python.org/3/library/functions.html#bool)) โ€“ if True, will return the max indices along with the outputs. Useful for [torch.nn.MaxUnpool2d](https://pytorch.org/docs/stable/generated/torch.nn.MaxUnpool2d.html#torch.nn.MaxUnpool2d) later > - ceil_mode ([bool](https://docs.python.org/3/library/functions.html#bool)) โ€“ when True, will use ceil instead of floor to compute the output shape ### Suggest a potential alternative/fix So, each parameter should have `required` or `optional` something like as shown below: > Parameters > - kernel_size ([Union](https://docs.python.org/3/library/typing.html#typing.Union)[[int](https://docs.python.org/3/library/functions.html#int), [Tuple](https://docs.python.org/3/library/typing.html#typing.Tuple)[[int](https://docs.python.org/3/library/functions.html#int)]], required) โ€“ The size of the sliding window, must be > 0. > - stride ([Union](https://docs.python.org/3/library/typing.html#typing.Union)[[int](https://docs.python.org/3/library/functions.html#int), [Tuple](https://docs.python.org/3/library/typing.html#typing.Tuple)[[int](https://docs.python.org/3/library/functions.html#int)]], optional) โ€“ The stride of the sliding window, must be > 0. Default value is kernel_size. > - padding ([Union](https://docs.python.org/3/library/typing.html#typing.Union)[[int](https://docs.python.org/3/library/functions.html#int), [Tuple](https://docs.python.org/3/library/typing.html#typing.Tuple)[[int](https://docs.python.org/3/library/functions.html#int)]], optional) โ€“ Implicit negative infinity padding to be added on both sides, must be >= 0 and <= kernel_size / 2. > - dilation ([Union](https://docs.python.org/3/library/typing.html#typing.Union)[[int](https://docs.python.org/3/library/functions.html#int), [Tuple](https://docs.python.org/3/library/typing.html#typing.Tuple)[[int](https://docs.python.org/3/library/functions.html#int)]], optional) โ€“ The stride between elements within a sliding window, must be > 0. > - return_indices ([bool](https://docs.python.org/3/library/functions.html#bool), optional) โ€“ if True, will return the max indices along with the outputs. Useful for [torch.nn.MaxUnpool2d](https://pytorch.org/docs/stable/generated/torch.nn.MaxUnpool2d.html#torch.nn.MaxUnpool2d) later > - ceil_mode ([bool](https://docs.python.org/3/library/functions.html#bool), optional) โ€“ when True, will use ceil instead of floor to compute the output shape cc @albanD @mruberry @jbschlosser @walterddr @mikaylagawarecki
module: nn,triaged
low
Minor
2,526,542,194
transformers
add `private` parameter to trainer.push_to_hub
### Feature request Adding another parameter to the `trainer.push_to_hub` called `private` ### Motivation a user at https://discuss.huggingface.co/t/how-to-push-trained-models-and-save-it-privately-on-hub/25538/10 has requested this, and although setting `hub_private_repo` training argument to True is a good alternative, but I agree with them on the basis that we need a unified `push_to_hub` method. ### Your contribution I can submit a PR
Feature request
low
Minor
2,526,547,115
rust
Tracking Issue for `box_vec_non_null`
<!-- Thank you for creating a tracking issue! Tracking issues are for tracking a feature from implementation to stabilization. Make sure to include the relevant RFC for the feature if it has one. If the new feature is small, it may be fine to skip the RFC process. In that case, you can use `issue = "none"` in your initial implementation PR. The reviewer will ask you to open a tracking issue if they agree your feature can be added without an RFC. --> Feature gate: `#![feature(box_vec_non_null)]` This is a tracking issue for convenience methods for conversion between `NonNull` and `Vec`/`Box`. <!-- Include a short description of the feature. --> ### Public API <!-- For most library features, it'd be useful to include a summarized version of the public API. (E.g. just the public function signatures without their doc comments or implementation.) --> ```rust impl<T: ?Sized> Box<T> { pub unsafe fn from_non_null(ptr: NonNull<T>) -> Self { .... } } impl<T: ?Sized, A: Allocator> Box<T, A> { pub const unsafe fn from_non_null_in(raw: NonNull<T>, alloc: A) -> Self { .... } pub fn into_non_null(b: Self) -> NonNull<T> { .... } pub fn into_non_null_with_allocator(b: Self) -> (NonNull<T>, A) { .... } } impl<T> Vec<T> { pub unsafe fn from_parts(ptr: NonNull<T>, length: usize, capacity: usize) -> Self { .... } } impl<T, A: Allocator> Vec<T, A> { pub unsafe fn from_parts_in(ptr: NonNull<T>, length: usize, capacity: usize, alloc: A) -> Self { .... } pub fn into_parts(self) -> (NonNull<T>, usize, usize) { .... } pub fn into_parts_with_alloc(self) -> (NonNull<T>, usize, usize, A) { .... } pub fn as_non_null(&mut self) -> NonNull<T> { .... } } ``` ### Steps / History <!-- For larger features, more steps might be involved. If the feature is changed later, please add those PRs here as well. --> - [x] Implementation: - ACP: https://github.com/rust-lang/libs-team/issues/418 - Implementation PR: https://github.com/rust-lang/rust/pull/130061 - ACP 2: https://github.com/rust-lang/libs-team/issues/440 - Implementation PR 2: https://github.com/rust-lang/rust/pull/130624 - [ ] Final comment period (FCP)[^1] - [ ] Stabilization PR <!-- Once the feature has gone through a few release cycles and there are no unresolved questions left, the feature might be ready for stabilization. If this feature didn't go through the RFC process, a final comment period (FCP) is always needed before stabilization. This works as follows: A library API team member can kick off the stabilization process, at which point the rfcbot will ask all the team members to verify they agree with stabilization. Once enough members agree and there are no concerns, the final comment period begins: this issue will be marked as such and will be listed in the next This Week in Rust newsletter. If no blocking concerns are raised in that period of 10 days, a stabilization PR can be opened by anyone. --> ### Unresolved Questions <!-- Include any open questions that need to be answered before the feature can be stabilised. If multiple (unrelated) big questions come up, it can be a good idea to open a separate issue for each, to make it easier to keep track of the discussions. It's useful to link any relevant discussions and conclusions (whether on GitHub, Zulip, or the internals forum) here. --> - None yet. [^1]: https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html
T-libs-api,C-tracking-issue,A-box
low
Minor
2,526,547,942
pytorch
`int`, `float` and `complex` type with `return_indices` of `nn.MaxPool1d()` also work
### ๐Ÿ› Describe the bug The doc of [nn.MaxPool1d()](https://pytorch.org/docs/stable/generated/torch.nn.MaxPool1d.html) says `return_indices` is `bool` as shown below: > - return_indices ([bool](https://docs.python.org/3/library/functions.html#bool)) โ€“ If True, will return the argmax along with the max values. Useful for [torch.nn.MaxUnpool1d](https://pytorch.org/docs/stable/generated/torch.nn.MaxUnpool1d.html#torch.nn.MaxUnpool1d) later But `int`, `float` and `complex` type with `return_indices` also work as shown below. *It also happens with [nn.MaxPool2d()](https://pytorch.org/docs/stable/generated/torch.nn.MaxPool2d.html) and [nn.MaxPool2d()](https://pytorch.org/docs/stable/generated/torch.nn.MaxPool3d.html): ```python import torch from torch import nn my_tensor = torch.tensor([[8., -3., 0., 1., 5., -2.]]) # โ†“ maxpool1d = nn.MaxPool1d(kernel_size=1, return_indices=5) maxpool1d(input=my_tensor) # (tensor([[8.,-3., 0., 1., 5., -2.]]), tensor([[0, 1, 2, 3, 4, 5]])) # โ†“โ†“ maxpool1d = nn.MaxPool1d(kernel_size=1, return_indices=5.) maxpool1d(input=my_tensor) # (tensor([[8., -3., 0., 1., 5., -2.]]), tensor([[0, 1, 2, 3, 4, 5]])) # โ†“โ†“โ†“โ†“โ†“โ†“ maxpool1d = nn.MaxPool1d(kernel_size=1, return_indices=5.+0.j) maxpool1d(input=my_tensor) # (tensor([[8., -3., 0., 1., 5., -2.]]), tensor([[0, 1, 2, 3, 4, 5]])) ``` In addition, the doc of [nn.MaxPool1d()](https://pytorch.org/docs/stable/generated/torch.nn.MaxPool1d.html) says `ceil_mode` is `bool` as shown below: > - ceil_mode ([bool](https://docs.python.org/3/library/functions.html#bool)) โ€“ If True, will use ceil instead of floor to compute the output shape. This ensures that every element in the input tensor is covered by a sliding window. Then, `int`, `float` and `complex` type with `return_indices` get the errors properly as shown below: ```python import torch from torch import nn my_tensor = torch.tensor([[8., -3., 0., 1., 5., -2.]]) # โ†“ maxpool1d = nn.MaxPool1d(kernel_size=1, ceil_mode=5) maxpool1d(input=my_tensor) # Error # โ†“โ†“ maxpool1d = nn.MaxPool1d(kernel_size=1, ceil_mode=5.) maxpool1d(input=my_tensor) # Error # โ†“โ†“โ†“โ†“โ†“โ†“ maxpool1d = nn.MaxPool1d(kernel_size=1, ceil_mode=5.+0.j) maxpool1d(input=my_tensor) # Error ``` > TypeError: max_pool1d(): argument 'ceil_mode' (position 6) must be bool, not int > TypeError: max_pool1d(): argument 'ceil_mode' (position 6) must be bool, not float > TypeError: max_pool1d(): argument 'ceil_mode' (position 6) must be bool, not complex ### Versions ```python import torch torch.__version__ # '2.3.0' ``` cc @albanD @mruberry @jbschlosser @walterddr @mikaylagawarecki
module: nn,triaged
low
Critical
2,526,562,467
ollama
Slow setup download from Pakistan
### What is the issue? The ollama exe and curl both are downloading super slow. My internet is find becuase I download 2gb file in parallel and it downloaded very fast. ### OS Windows ### GPU Nvidia ### CPU Intel ### Ollama version _No response_
ollama.com,networking
low
Major
2,526,563,862
PowerToys
[Enhancement Request] Keyboard Manager: Disable Individual Remaps + Add "Target app" for "Remap a Key"
### Description of the new feature / enhancement - Add On/Off toggle to each remap under "Remap a key" and "Remap a shortcut" - Add the same "Target app" setting as "Remap a shortcut" to "Remap a key" ### Scenario when this would be used? - Add On/Off toggle to each remap under "Remap a key" and "Remap a shortcut" When wanting to disable remaps without having to completely disable Keyboard Manager or deleting remaps. - Add the same "Target app" setting as "Remap a shortcut" to "Remap a key" When wanting to set key remaps to only work on specific apps, instead of the whole system. ### Supporting information Mockup: ![image](https://github.com/user-attachments/assets/3d1eb298-caad-4b68-b95f-75b0cbae552f)
Needs-Triage
low
Major
2,526,565,101
godot
[4.3 stable] Animation player editor: Keys get inserted at wrong timeline positions
### Tested versions Reproducable in 4.3 stable. Redproducable in 4.4-dev2 ### System information Godot v4.3.stable - Windows 10.0.19045 - GLES3 (Compatibility) - NVIDIA GeForce RTX 3070 (NVIDIA; 31.0.15.3623) - Intel(R) Core(TM) i5-4670K CPU @ 3.40GHz (4 Threads) ### Issue description I have an animation with keys every 0.15 seconds. I've noticed that when I click in the animation editor to insert new keys, they don't get added at the right position. Instead of 0.15, 0.3, 0.45 etc. they are always bit off, 0.1429, 0.2857, 0.4286 etc. I've tried some other snap values. 0.1 works, but for instance 0.6 does not. I click at 0.6 in the timeline and right click "Insert key here", and it is inserted at 0.5. ### Steps to reproduce Create a new project. Add an AnimationPlayer, create an animation track. Set snap length to value 0.15 and click in the editor to add keys. Notice how they are not at the right positions. ### Minimal reproduction project (MRP) Not necessary.
bug,discussion,topic:editor,confirmed,usability,topic:animation
low
Minor
2,526,574,231
godot
Calling `VisualServer.canvas_item_add_clip_ignore()` does not ignore clipping on `CanvasItem`s
### Tested versions - Reproducible in 3.5.stable, 4.2.2.stable ### System information Windows 10 ### Issue description The documentation for `VisualServer.canvas_item_add_clip_ignore()` states that it will cause the given `CanvasItem` to not be clipped by the VisualServer. The 4.x equivalent of `RenderingServer.canvas_item_add_clip_ignore()` even states that this only needs to be called once to cause it to ignore clipping completely. However, when calling/setting this in any CanvasItem that is being clipped with `rect_clip_content = true`/`clip_contents = true` or with ``` # 3.5 VisualServer.canvas_item_set_custom_rect(get_canvas_item(), true, cliprect) VisualServer.canvas_item_set_clip(get_canvas_item(), true) # 4.x RenderingServer.canvas_item_set_custom_rect(get_canvas_item(), true, cliprect) RenderingServer.canvas_item_set_clip(get_canvas_item(), true) ``` this has no effect at all. The CanvasItem is still completely or partially clipped when it extends the bounds of a parent that is clipping it's content. Below is the MRP in action. The red outlines are a visual representation of the `Rect2()`s that are being used to clip the content. **3.5** ![canvas_item_add_rect_ignore_3](https://github.com/user-attachments/assets/eaadc722-63a0-4db3-b93e-85da4178bb3f) **4.x** ![canvas_item_add_rect_ignore_4](https://github.com/user-attachments/assets/86d8dc69-b788-4b5a-b395-07a158c091f7) In both examples the `PanelContainer` with the `Label` that reads **Ignores Clipping** has a script with the following: ``` func _ready() -> void: VisualServer.canvas_item_add_clip_ignore(get_canvas_item(), true) func _draw(): VisualServer.canvas_item_add_clip_ignore(get_canvas_item(), true) ``` But despite that the PanelContainer and the label are still invisible when outside of the given rect. Seeing as the PanelContainer with the script behaves the exact same as the PanelContainers without the `canvas_item_add_clip_ignore()` call, it seems the `add_clip_ignore()` doesn't work, or potentially works completely differently than it's documentation indicates. I really thought I must have misunderstood how this function works, but after multiple hours of attempting different setups, the only reasonable explanation is that it doesn't have any effect and might be bugged. ### Steps to reproduce 1. Start the MRP 2. _(Optional) Drag the window to cause the nodes to call `_draw()`_ 3. _(Optional) The `_draw()` call will cause the custom rect to update_ 4. The PanelContainer with the text `Ignores Clipping` will be clipped when it is outside of the visiblity rect of the main `Control` node that has `rect_clip_content` enabled or has the custom_rect script, even though it calls `canvas_item_add_clip_ignore()` on itself. ### Minimal reproduction project (MRP) [ClipIgnore3.x.zip](https://github.com/user-attachments/files/17003530/ClipIgnore3.x.zip) [ClipIgnore4.x.zip](https://github.com/user-attachments/files/17003509/ClipIgnore4.x.zip)
bug,topic:rendering,documentation,topic:2d
low
Critical
2,526,576,100
pytorch
Flex Attention: Calculates Gradients Even if Input Has requires_grad=False
### ๐Ÿ› Describe the bug This is a feature request for flex attention to not calculate the gradient of a input if it has `requires_grad=False` I've looking into the kernel and seems like flex attention might actually might make this quite simple compared to other implementations like flash attention, it just might require an additional kernel option. Let me know you'd like help with this and I can take a stab at it. It seems like it might be easier to start by not calculating the query gradient and then later add support for calculating key and value gradient separately. ### Versions 2.5.0.dev20240912+cu124 cc @ezyang @chauhang @penguinwu @zou3519 @ydwu4 @bdhirsh @Chillee @drisspg @yanboliang @BoyuanFeng
triaged,oncall: pt2,module: higher order operators,module: pt2-dispatcher,module: flex attention
low
Critical