id int64 393k 2.82B | repo stringclasses 68
values | title stringlengths 1 936 | body stringlengths 0 256k ⌀ | labels stringlengths 2 508 | priority stringclasses 3
values | severity stringclasses 3
values |
|---|---|---|---|---|---|---|
2,588,433,172 | ui | [bug]: error occurring while installing the components | ### Describe the bug
npx shadcn@latest add avatar
⠴ Checking registry.
Something went wrong. Please check the error below for more details.
If the problem persists, please open an issue on GitHub.
request to https://ui.shadcn.com/r/index.json failed, reason: self-signed certificate in certificate chain
### Affected component/components
all
### How to reproduce
1. Go to terminal
2. Try to install any component(eg: button, textarea, input ...)
### Codesandbox/StackBlitz link
_No response_
### Logs
_No response_
### System Info
```bash
windows 11 pro
```
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues | bug | low | Critical |
2,588,446,767 | tensorflow | TypeError: true_fn and false_fn arguments to tf.cond must have the same number, type, and overall structure of return values | ### Issue type
Bug
### Have you reproduced the bug with TensorFlow Nightly?
No
### Source
binary
### TensorFlow version
2.17.0
### Custom code
Yes
### OS platform and distribution
Linux CentOS 7.9
### Mobile device
_No response_
### Python version
3.12.4
### Bazel version
_No response_
### GCC/compiler version
_No response_
### CUDA/cuDNN version
_No response_
### GPU model and memory
_No response_
### Current behavior?
We used tensorflow for 3 class classifications. The code worked well on existed environment: Python 3.8.3 + tensorflow 2.13.1.
But when we tried on new enviroment: Python 3.12.4 + tensorflow 2.17.0, several errors blocked.
### Standalone code to reproduce the issue
Here are the simple code to reproduce the issue.
```
import tensorflow as tf
from tensorflow.keras.layers import Dense
import numpy as np
def build_model():
metrics = ['accuracy', tf.keras.metrics.AUC(multi_label=True)]
loss = tf.keras.losses.sparse_categorical_crossentropy
num_class = 3
inputs = tf.keras.layers.Input(shape=(40, 36))
lstm_out = tf.keras.layers.LSTM(32, return_sequences=False)(inputs)
output = Dense(num_class, activation='softmax')(lstm_out)
model = tf.keras.Model(inputs, output)
model.compile(loss=loss, optimizer=tf.keras.optimizers.Adam(), metrics=metrics)
model.summary()
return model
def data_gen():
while True:
yield np.random.rand(128, 40, 36), np.random.randint(0, 3, (128, 1))
model = build_model()
cw = {0: 0.3, 1:2.5, 2:3.2}
model.fit(data_gen(), epochs=2, steps_per_epoch=10, class_weight=cw)
```
The first error we met:
```
Traceback (most recent call last):
File "/data/release/infinity_stock2/tf_model.py", line 25, in <module>
model.fit(data_gen(), epochs=2, steps_per_epoch=10, class_weight=cw)
File "/root/.virtualenvs/new_stock/lib/python3.12/site-packages/keras/src/utils/traceback_utils.py", line 122, in error_handler
raise e.with_traceback(filtered_tb) from None
File "/root/.virtualenvs/new_stock/lib/python3.12/site-packages/keras/src/trainers/data_adapters/__init__.py", line 108, in get_data_adapter
raise ValueError(
ValueError: Argument `class_weight` is not supported for Python generator inputs. Received: class_weight={0: 0.3, 1: 2.5, 2: 3.2}
```
To solve the issue, we used tf dataset to wrap the generator.
```
import tensorflow as tf
from tensorflow.keras.layers import Dense
import numpy as np
def build_model():
metrics = ['accuracy', tf.keras.metrics.AUC(multi_label=True)]
loss = tf.keras.losses.sparse_categorical_crossentropy
num_class = 3
inputs = tf.keras.layers.Input(shape=(40, 36))
lstm_out = tf.keras.layers.LSTM(32, return_sequences=False)(inputs)
output = Dense(num_class, activation='softmax')(lstm_out)
model = tf.keras.Model(inputs, output)
model.compile(loss=loss, optimizer=tf.keras.optimizers.Adam(), metrics=metrics)
model.summary()
return model
def data_gen():
while True:
yield np.random.rand(128, 40, 36), np.random.randint(0, 3, (128, 1))
model = build_model()
cw = {0: 0.3, 1:2.5, 2:3.2}
data = tf.data.Dataset.from_generator(data_gen, output_types=(tf.float32, tf.float32), output_shapes=((None, 40, 36), (None, None)))
model.fit(data, epochs=2, steps_per_epoch=10, class_weight=cw)
```
And another error happened:
```
Traceback (most recent call last):
File "/data/release/infinity_stock2/tf_model.py", line 26, in <module>
model.fit(data, epochs=2, steps_per_epoch=10, class_weight=cw)
File "/root/.virtualenvs/new_stock/lib/python3.12/site-packages/keras/src/utils/traceback_utils.py", line 122, in error_handler
raise e.with_traceback(filtered_tb) from None
File "/root/.virtualenvs/new_stock/lib/python3.12/site-packages/tensorflow/python/ops/cond_v2.py", line 876, in error
raise TypeError(
TypeError: true_fn and false_fn arguments to tf.cond must have the same number, type, and overall structure of return values.
true_fn output: Tensor("cond/Identity:0", shape=(None,), dtype=int64)
false_fn output: Tensor("cond/Identity:0", shape=(None,), dtype=int32)
Error details:
Tensor("cond/Identity:0", shape=(None,), dtype=int64) and Tensor("cond/Identity:0", shape=(None,), dtype=int32) have different types
```
It looks like class weight might not work well.
### Relevant log output
_No response_ | type:bug,2.17 | medium | Critical |
2,588,477,705 | material-ui | [TextField][a11y] Add aria-describedby in the input assosiated with the id of the start/end adornment | ### Summary
When using start/end adornment the input needs to be well associated with the description they provide, by adding an aria-describedby to have the value of the adornment id so that the unsighted users can get the same hint as sighted users.
As a first step, we can likely start with improving this demo, and later we can provide this as a feature out of the box.
### Examples
Check https://mui.com/material-ui/react-text-field/#input-adornments as an example.
### Motivation
_No response_
**Search keywords**: textfield adonrment | accessibility,component: text field | low | Minor |
2,588,514,972 | opencv | GRU parsing is not implemented in the new ONNX parser | ### System Information
The implementation is just commented. The old parser makes several preliminary steps to extract constant blobs. The solution should be reworked with the new one.
Reference: https://github.com/opencv/opencv/pull/26056
### Detailed description
-
### Steps to reproduce
-
### Issue submission checklist
- [X] I report the issue, it's not a question
- [ ] I checked the problem with documentation, FAQ, open issues, forum.opencv.org, Stack Overflow, etc and have not found any solution
- [ ] I updated to the latest OpenCV version and the issue is still there
- [ ] There is reproducer code and related data files (videos, images, onnx, etc) | bug,category: dnn (onnx) | low | Minor |
2,588,522,582 | opencv | QLinear* layers are not implemented in the new DNN engine | ### System Information
Platform: any
Reference: https://github.com/opencv/opencv/pull/26056
### Detailed description
-
### Steps to reproduce
-
### Issue submission checklist
- [X] I report the issue, it's not a question
- [ ] I checked the problem with documentation, FAQ, open issues, forum.opencv.org, Stack Overflow, etc and have not found any solution
- [ ] I updated to the latest OpenCV version and the issue is still there
- [ ] There is reproducer code and related data files (videos, images, onnx, etc) | bug,category: dnn (onnx) | low | Minor |
2,588,578,446 | go | cmd/compile: should delete loops without side-effects | As of `go1.24-cbdb3545ad`, none of the following loops get optimized away:
```
package main
func main() {
for range 10 {
// Just an empty loop
}
var x int
for range 20 {
// x never gets read after the loop
x++
}
var y [30]int
for i := range y {
// The bounds check gets optimized out, turning this into an empty loop
_ = y[i]
}
for range "13 characters" {
// An empty loop that parses UTF-8
}
const debugFoo = false
const debugBar = false
for range 40 {
// Loop body is dead and gets optimized out
if debugFoo {
println()
}
if debugBar {
println()
}
}
}
```
```
main.main STEXT size=152 args=0x0 locals=0x20 funcid=0x0 align=0x0
0x0000 00000 (...../foo.go:3) TEXT main.main(SB), ABIInternal, $32-0
0x0000 00000 (...../foo.go:3) CMPQ SP, 16(R14)
0x0004 00004 (...../foo.go:3) PCDATA $0, $-2
0x0004 00004 (...../foo.go:3) JLS 142
0x000a 00010 (...../foo.go:3) PCDATA $0, $-1
0x000a 00010 (...../foo.go:3) PUSHQ BP
0x000b 00011 (...../foo.go:3) MOVQ SP, BP
0x000e 00014 (...../foo.go:3) SUBQ $24, SP
0x0012 00018 (...../foo.go:3) FUNCDATA $0, gclocals·M83szM6+gDKfH9vuf1h0yw==(SB)
0x0012 00018 (...../foo.go:3) FUNCDATA $1, gclocals·M83szM6+gDKfH9vuf1h0yw==(SB)
0x0012 00018 (...../foo.go:3) XORL AX, AX
0x0014 00020 (...../foo.go:4) JMP 25
0x0016 00022 (...../foo.go:4) INCQ AX
0x0019 00025 (...../foo.go:4) CMPQ AX, $10
0x001d 00029 (...../foo.go:4) JLT 22
0x001f 00031 (...../foo.go:4) XORL AX, AX
0x0021 00033 (...../foo.go:4) JMP 38
0x0023 00035 (...../foo.go:9) INCQ AX
0x0026 00038 (...../foo.go:9) CMPQ AX, $20
0x002a 00042 (...../foo.go:9) JLT 35
0x002c 00044 (...../foo.go:9) XORL AX, AX
0x002e 00046 (...../foo.go:15) JMP 51
0x0030 00048 (...../foo.go:15) INCQ AX
0x0033 00051 (...../foo.go:15) CMPQ AX, $30
0x0037 00055 (...../foo.go:15) JLT 48
0x0039 00057 (...../foo.go:15) XORL AX, AX
0x003b 00059 (...../foo.go:15) JMP 64
0x003d 00061 (...../foo.go:20) MOVQ SI, AX
0x0040 00064 (...../foo.go:20) CMPQ AX, $13
0x0044 00068 (...../foo.go:20) JGE 123
0x0046 00070 (...../foo.go:20) LEAQ go:string."13 characters"(SB), DX
0x004d 00077 (...../foo.go:20) MOVBLZX (DX)(AX*1), SI
0x0051 00081 (...../foo.go:20) CMPL SI, $128
0x0057 00087 (...../foo.go:20) JGE 95
0x0059 00089 (...../foo.go:20) LEAQ 1(AX), SI
0x005d 00093 (...../foo.go:20) JMP 61
0x005f 00095 (...../foo.go:20) MOVL $13, BX
0x0064 00100 (...../foo.go:20) MOVQ AX, CX
0x0067 00103 (...../foo.go:20) MOVQ DX, AX
0x006a 00106 (...../foo.go:20) PCDATA $1, $0
0x006a 00106 (...../foo.go:20) CALL runtime.decoderune(SB)
0x006f 00111 (...../foo.go:20) LEAQ go:string."13 characters"(SB), DX
0x0076 00118 (...../foo.go:20) MOVQ BX, SI
0x0079 00121 (...../foo.go:20) JMP 61
0x007b 00123 (...../foo.go:20) XORL AX, AX
0x007d 00125 (...../foo.go:20) JMP 130
0x007f 00127 (...../foo.go:26) INCQ AX
0x0082 00130 (...../foo.go:26) CMPQ AX, $40
0x0086 00134 (...../foo.go:26) JLT 127
0x0088 00136 (...../foo.go:35) ADDQ $24, SP
0x008c 00140 (...../foo.go:35) POPQ BP
0x008d 00141 (...../foo.go:35) RET
0x008e 00142 (...../foo.go:35) NOP
0x008e 00142 (...../foo.go:3) PCDATA $1, $-1
0x008e 00142 (...../foo.go:3) PCDATA $0, $-2
0x008e 00142 (...../foo.go:3) CALL runtime.morestack_noctxt(SB)
0x0093 00147 (...../foo.go:3) PCDATA $0, $-1
0x0093 00147 (...../foo.go:3) JMP 0
``` | Performance,help wanted,NeedsInvestigation,compiler/runtime | low | Critical |
2,588,635,065 | electron | [Bug]: 'login' event is not emitted when the HTTP request is sent from the 'main' process using 'net.fetch()' on Windows and MacOS | ### Preflight Checklist
- [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [x] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
32.1.2
### What operating system(s) are you using?
Other (specify below)
### Operating System Version
MacOS Sonoma, Windows 11, Debian (Docker)
### What arch are you using?
Other (specify below)
### Last Known Working Electron version
_No response_
### Expected Behavior
I have developed some tests to validate the behaviour of `net.fetch()` / `fetch()` on Windows, MacOS and Linux when sending HTTP(S) requests from the `main` process, from a `renderer` process and from a `utility` process. More specifically, I wanted to check the integration with the OS network settings and trust store when dealing with web proxies and self-signed certificates. See [@hackolade/fetch](https://github.com/hackolade/fetch) for more details about my approach.
I expected `net.fetch()` / `fetch()` to behave consistently whatever the process and the operating system.
### Actual Behavior
When sending HTTP requests through a web proxy that requires basic authentication, I observed the following:
- On Linux, [the 'login' event](https://www.electronjs.org/docs/latest/api/app#event-login) is properly emitted for all processes: `main`, `renderer` and `utility`. As a consequence, the request reaches the server in all cases.
- On MacOS and Windows, [the 'login' event](https://www.electronjs.org/docs/latest/api/app#event-login) is only emitted for a `renderer` process and a `utility` process. It is not emitted when sending the request using `net.fetch()` from the `main` process. As a consequence, that request fails with `HTTP 407 Proxy Authentication Required`.
So how am I supposed to deal with that case?
Note that I created a separate issue for the problem with setCertificateVerifyProc(): see #44264.
### Testcase Gist URL
https://gist.github.com/thomas-jakemeyn/035c6494d80b3250b992d70584f4c13c
https://github.com/hackolade/fetch/tree/develop
### Additional Information
_No response_ | bug :beetle:,component/net,has-repro-gist,component/utilityProcess,32-x-y | low | Critical |
2,588,653,034 | rust | target_feature leads to confusing note in rustdoc | I tried this code:
```rust
#[target_feature(enable = "avx2")]
pub unsafe fn f() {}
```
I expected to see this happen:
Rustdoc says something along the lines of:
> Requires target feature avx2 at runtime.
Instead, this happened:
Rustdoc says:
> Available with target feature avx2 only.
It is not clear what “available” means here. I initially thought it meant the function would not be defined if not compiled with `--codegen target-feature=+avx2` (and concluded it was always safe to call if the calling program compiles). Instead it means the function is always defined but must not be called if the target feature is not available at runtime. Rustdoc gives no other indication that the `target_feature` attribute is used, and the note looks a lot like the “available on create feature … only” notes.
### Meta
<!--
If you're using the stable version of the compiler, you should also check if the
bug also exists in the beta or nightly versions.
-->
`rustc --version --verbose`:
```
rustc 1.81.0 (eeb90cda1 2024-09-04)
binary: rustc
commit-hash: eeb90cda1969383f56a2637cbd3037bdf598841c
commit-date: 2024-09-04
host: x86_64-unknown-linux-gnu
release: 1.81.0
LLVM version: 18.1.7
``` | T-rustdoc,C-bug,A-rustdoc-ui,T-rustdoc-frontend | low | Critical |
2,588,755,160 | react | [Compiler Bug]: false positive when accessing `window.location` from the props object | ### What kind of issue is this?
- [ ] React Compiler core (the JS output is incorrect, or your app works incorrectly after optimization)
- [ ] babel-plugin-react-compiler (build issue installing or using the Babel plugin)
- [X] eslint-plugin-react-compiler (build issue installing or using the eslint plugin)
- [ ] react-compiler-healthcheck (build issue installing or using the healthcheck script)
### Link to repro
https://github.com/iamakulov/react-compiler-bug-repro
### Repro steps
1. Clone the repo
2. `yarn && yarn eslint --ext .js,.ts,.tsx src/*`
3. Observe ESLint logging the following (false positive) error:
4. Open `src/Component.jsx` and inline the `miniCarouselProps` object:
```diff
- const miniCarouselProps = {
- ...props,
- cards: cardListTransformed,
- slug: props.locationSlug,
- onCardClick: (card) => {
- location.pathname = card.slug;
- },
- forceAnchorTag: false,
- };
-
- return <MiniCarousel {...miniCarouselProps} />;
+ return (
+ <MiniCarousel
+ {...props}
+ cards={cardListTransformed}
+ slug={props.locationSlug}
+ onCardClick={(card) => {
+ location.pathname = card.slug;
+ }}
+ forceAnchorTag={false}
+ />
);
```
5. `yarn eslint --ext .js,.ts,.tsx src/*`
6. Observe ESLint not logging the error anymore
### How often does this bug happen?
Every time
### What version of React are you using?
19 | Type: Bug,Status: Unconfirmed,Component: Optimizing Compiler | medium | Critical |
2,588,801,396 | pytorch | Inductor's require_stride_order and require_exact_strides should pull from the graph sent to inductor | Custom operators and triton kernels can be marked with "require_stride_order" or "require_exact_strides". This means that during lowering, Inductor will ensure that the inputs to the custom operator have the same strides as observed in the post_grad Inductor graph.
However, Inductor passes are able to muck around with the strides of inputs to custom operators and triton kernels. See https://github.com/pytorch/pytorch/issues/137437 for an example where an mm padding pass changed the strides!
At the very beginning of inductor, we should record the strides of all inputs to nodes that may require_stride_order and require_exact_strides and store that information somewhere (on the node). Later on, during lowering, we should make use of those strides.
https://github.com/pytorch/pytorch/pull/136732 seems like a WIP version of this
cc @ezyang @chauhang @penguinwu @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @bdhirsh | triaged,module: custom-operators,oncall: pt2,module: inductor,module: pt2-dispatcher | low | Minor |
2,588,820,412 | go | proposal: crypto: support 3rd-party hash algorithms | ### Proposal Details
`crypto/rsa.SignPSS()` and similar packages take a `crypto.Hash`, which is hard-coded to only support known-to-Go hash algorithms.
This is a total show-stopper for me, because I need to be able to support new, not-yet-existing hash algorithms.
I propose a new implementation for `src/crypto/crypto.go`:
```go
// ...
type customImplementation struct {
name string
// int is used rather than uint8 of digestSizes in order to support future
// hash functions with large digests.
digestSize int
f func() hash.Hash
}
var customImplementations = make(map[Hash]customImplementation)
func (h Hash) String() string {
switch h {
// ...
default:
if implementation, exists := customImplementations[h]; exists {
return implementation.name
}
return "unknown hash value " + strconv.Itoa(int(h))
}
}
// ...
// Defines the limit of 1st-party hash functions.
const boundaryFirstParty Hash = 101
// ...
// Size returns the length, in bytes, of a digest resulting from the given hash
// function. It doesn't require that the hash function in question be linked
// into the program for hash functions known to Go authors. It does require
// that the hash function in question be linked into the program for 3rd-party
// hash functions.
func (h Hash) Size() int {
if h < 1 || h == maxHash {
panic("crypto: Size of unknown hash function")
}
if h < maxHash {
return int(digestSizes[h])
}
if implementation, exists := customImplementations[h]; exists {
return implementation.digestSize
}
panic("crypto: Size of unknown hash function")
}
// ...
// New returns a new hash.Hash calculating the given hash function. New panics
// if the hash function is not linked into the binary.
func (h Hash) New() hash.Hash {
if h < 1 || h == maxHash {
panic("crypto: requested hash function #" + strconv.Itoa(int(h)) + " is unavailable")
}
if h < maxHash {
f := hashes[h]
if f != nil {
return f()
}
}
if implementation, exists := customImplementations[h]; exists {
return implementation.f()
}
panic("crypto: requested hash function #" + strconv.Itoa(int(h)) + " is unavailable")
}
// Available reports whether the given hash function is linked into the binary.
func (h Hash) Available() bool {
if h < maxHash && hashes[h] != nil {
return true
}
if _, exists := customImplementations[h]; exists {
return true
}
return false
}
// ...
// RegisterCustomHash registers a function that returns a new instance of the given
// 3rd-party hash function. This is intended to be called from the init function in
// packages that implement hash functions. Registering hash functions outside of an
// init function can cause thread-unsafe behaviors.
func RegisterCustomHash(h Hash, name string, digestSize int, f func() hash.Hash) error {
if h <= boundaryFirstParty {
return errors.New("crypto: RegisterCustomHash within 1st-party region")
}
if len(name) == 0 {
return errors.New("crypto: RegisterCustomHash of hash function without a name")
}
if digestSize < 1 {
return errors.New("crypto: RegisterCustomHash of hash function with empty digests")
}
if f == nil {
return errors.New("crypto: RegisterCustomHash of hash function without an allocator")
}
if _, exists := customImplementations[h]; exists {
return errors.New("crypto: RegisterCustomHash of an existing hash function")
}
customImplementations[h] = customImplementation{
name: name,
digestSize: digestSize,
f: f,
}
return nil
}
// ...
```
(note that I would submit a pull request, but I am currently on a very shoddy hotspot internet connection that prevents me from performing the necessary tasks to do so.)
There is of course an issue with this proposal: 3rd-party hash algorithms might use the same value for `crypto.Hash`, which would lead to errors.
Ideally we would change the type definition of `crypto.Hash` to something more sensible than a `uint`, but this would break packages that use the `uint` to identify hash algorithms.
Perhaps a checksum of the hash algorithm's name to produce a `uint` would be better? | Proposal,Proposal-Crypto | low | Critical |
2,588,830,461 | flutter | LayoutBuilder throwing assertion on hot reload, when parent is dynamically determining the children during the build phase | ### Steps to reproduce
1. create a new project with "flutter create bug"
2. paste the minimal reproducible sample in the main.dart
3. resize the window, so the container doesnt fit the constrains
4. perform a hot reload or hot restart
### Expected results
No assertion is thrown,.
The use of AppChildFitter is to determine, if the child would need the builder to fit the constrains. In the real application, there is also custom ui added, that change the constrains of the child, because they take up space. Because this Widget needs to be used multiple times, build-in solutions like Intrinsics/ LayoutBuilder/ TextRenderer dont work for me. I have also tried the [boxy package](https://pub.dev/packages/boxy) with no succes. I didn't encounter any issues with "normal" building. Only hot reload/ restart seemed to trigger the exception.
### Actual results
`assert(element._inDirtyList);` evaluates to false and an exception is thrown.
### Code sample
<details open><summary>Code sample</summary>
```dart
import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';
void main() => runApp(const MyApp());
final ScrollController _scrollController = ScrollController();
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return Directionality(
textDirection: TextDirection.ltr,
child: AppChildFitter(
childFitter: (child) {
// return Scrollbar(
// controller: _scrollController,
// child: SingleChildScrollView(
// controller: _scrollController,
// child: child,
// ));
return LayoutBuilder(builder: (context, constraints) {
return Scrollbar(
controller: _scrollController,
child: SingleChildScrollView(
controller: _scrollController,
child: child,
));
});
},
child: const Test1(),
),
);
}
}
class Test1 extends StatefulWidget {
const Test1({
super.key,
});
@override
State<Test1> createState() => _Test1State();
}
class _Test1State extends State<Test1> {
Color color = const Color.fromARGB(255, 134, 26, 116);
@override
Widget build(BuildContext context) {
return Align(
child: Container(
width: 200,
height: 200,
color: color,
child: Align(
child: ElevatedButton(
onPressed: changeColor,
child: const Text('Change color'),
),
),
),
);
}
void changeColor() {
setState(() {
color = color == const Color.fromARGB(255, 134, 26, 116)
? const Color.fromARGB(255, 61, 80, 252)
: const Color.fromARGB(255, 134, 26, 116);
});
}
}
/// A Widget with a custom Element and RenderObject, that builds the [child] with the supplied [childFitter]
/// The [Element] relies internally on [GlobalKey]s, so that the subtree can be cached and the state of the child and fitter can be preserved over a frame
/// The [RenderObject] checks if the child fits the constraints, and if not, applies the fitter and re-layouts
/// Using this widget nested or with intrinsic widgets (such as [IntrinsicWidth]) can result in a long build time, as the build time goes up exponentially with amount of intrinsics/ AppChildFitter in the tree
/// Also some Widgets might cause exceptions, when their underlying renderbox does not support getMinIntrinsicHeight, such as [LayoutBuilder] or [GridView]/[ListView]
class AppChildFitter extends RenderObjectWidget {
final Widget child;
final Widget Function(Widget child) childFitter;
const AppChildFitter({
super.key,
required this.child,
required this.childFitter,
});
@override
RenderObject createRenderObject(BuildContext context) =>
AppChildFitterRenderObject();
@override
RenderObjectElement createElement() => AppChildFitterElement(this);
}
class AppChildFitterElement extends RenderObjectElement {
AppChildFitterElement(AppChildFitter super.widget);
late final GlobalKey childKey;
late final GlobalKey childFitterKey;
@override
AppChildFitterRenderObject get renderObject =>
super.renderObject as AppChildFitterRenderObject;
@override
void mount(Element? parent, Object? newSlot) {
super.mount(parent, newSlot);
// Link this element to the render box
renderObject.element = this;
childKey = GlobalKey();
childFitterKey = GlobalKey();
debugPrint("childKey: $childKey");
debugPrint("childFitterKey: $childFitterKey");
}
@override
void update(RenderObjectWidget newWidget) {
renderObject.markNeedsLayout();
super.update(newWidget);
}
@override
void unmount() {
// Clean up when unmounting
renderObject.element = null;
super.unmount();
}
Element? _currentChildElement;
set currentChildElement(Element? value) {
if (_currentChildElement == value) {
return;
}
_currentChildElement = value;
}
Element? get currentChildElement => _currentChildElement;
@override
void visitChildren(ElementVisitor visitor) {
if (_currentChildElement != null) {
visitor(_currentChildElement!);
}
}
@override
void forgetChild(Element child) {
if (child == _currentChildElement) {
_currentChildElement = null;
} else {
assert(false,
"Forget child called with child that is not a child. At $this");
}
super.forgetChild(child);
}
RenderBox? generateWidgetsDuringLayout({bool useFittedChild = false}) {
//TODO: Sometimes error on hot reload when child changes params
Widget newChildWidget = KeyedSubtree(
key: childKey,
child: (widget as AppChildFitter).child,
);
// Use the childFitter if required
if (useFittedChild) {
//TODO: assert, that old child is in subtree
try {
//forgetChild(currentChildElement!);
newChildWidget = KeyedSubtree(
key: childFitterKey,
child: (widget as AppChildFitter).childFitter(newChildWidget),
);
} catch (e) {
FlutterError.reportError(
FlutterErrorDetails(exception: e, stack: StackTrace.current),
);
rethrow;
}
}
owner!.buildScope(this, () {
// Dynamically generate or update child widgets
currentChildElement =
updateChild(currentChildElement, newChildWidget, null)!;
});
// return the render object of the child
//TODO: add checks
return currentChildElement!.renderObject as RenderBox?;
}
@override
void insertRenderObjectChild(
covariant RenderObject child, covariant Object? slot) {
renderObject.box = child as RenderBox;
}
@override
void moveRenderObjectChild(covariant RenderObject child,
covariant Object? oldSlot, covariant Object? newSlot) {
renderObject.box = child as RenderBox;
}
@override
void removeRenderObjectChild(
covariant RenderObject child, covariant Object? slot) {
if (renderObject.box == child) {
renderObject.box = null;
}
}
}
class AppChildFitterRenderObject extends RenderBox {
AppChildFitterElement? element;
RenderBox? _box;
RenderBox? get box => _box;
set box(RenderBox? value) {
if (_box == value) return;
if (_box != null) {
dropChild(_box!);
}
_box = value;
if (_box != null) {
adoptChild(_box!);
}
}
@override
void performLayout() {
invokeLayoutCallback<BoxConstraints>((constraints) {
if (element == null) {
size = constraints.smallest;
return;
}
// First, try to lay out the child normally
box = element!.generateWidgetsDuringLayout();
if (box == null) {
size = constraints.smallest;
return;
}
// Test if the child will fit the height of constraints
final minIntrinsicHeight =
box!.getMinIntrinsicHeight(constraints.maxWidth);
if (minIntrinsicHeight <= constraints.maxHeight) {
// Child fits, so lay it out normally
box!.layout(constraints, parentUsesSize: true);
} else {
// Child doesn't fit, apply childFitter and re-layout
box = element!.generateWidgetsDuringLayout(useFittedChild: true);
box!.layout(constraints, parentUsesSize: true);
assert(box!.size.width <= constraints.maxWidth,
"Width overflow in AppChildFitter");
}
size = constraints.constrain(box!.size);
});
}
@override
void paint(PaintingContext context, Offset offset) {
// Ensure the box (child) is not null before painting
if (box == null) return;
context.paintChild(box!, offset);
}
@override
void visitChildren(RenderObjectVisitor visitor) {
if (box == null) return;
visitor(box!);
}
@override
bool hitTestChildren(BoxHitTestResult result, {required Offset position}) {
if (box == null) return false;
return box!.hitTest(result, position: position);
}
@override
void attach(PipelineOwner owner) {
super.attach(owner);
if (_box != null) {
_box!.attach(owner);
}
}
@override
void detach() {
super.detach();
if (_box != null) {
_box!.detach();
}
}
@override
void redepthChildren() {
if (_box != null) {
redepthChild(_box!);
}
super.redepthChildren();
}
}
```
</details>
### Screenshots or Video
_No response_
### Logs
<details open><summary>Logs</summary>
```console
Launching lib/main.dart on Linux in debug mode...
✓ Built build/linux/x64/debug/bundle/bug
Connecting to VM Service at ws://127.0.0.1:37633/JCFZASEUYn8=/ws
Connected to the VM Service.
flutter: childKey: [GlobalKey#562e4]
flutter: childFitterKey: [GlobalKey#65ea6]
════════ Exception caught by rendering library ═════════════════════════════════
The following assertion was thrown during performLayout():
'package:flutter/src/widgets/framework.dart': Failed assertion: line 2703 pos 12: 'element._inDirtyList': is not true.
Either the assertion indicates an error in the framework itself, or we should provide substantially more information in this error message to help you determine and fix the underlying cause.
In either case, please report this assertion by filing a bug on GitHub:
https://github.com/flutter/flutter/issues/new?template=2_bug.yml
The relevant error-causing widget was:
LayoutBuilder LayoutBuilder:file:///<path-to-repos>/repos/test/bug/lib/main.dart:23:18
When the exception was thrown, this was the stack:
#2 BuildScope._tryRebuild (package:flutter/src/widgets/framework.dart:2703:12)
#3 BuildScope._flushDirtyElements (package:flutter/src/widgets/framework.dart:2783:11)
#4 BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:3090:18)
#5 _LayoutBuilderElement._rebuildWithConstraints (package:flutter/src/widgets/layout_builder.dart:247:12)
#6 RenderObject.invokeLayoutCallback.<anonymous closure> (package:flutter/src/rendering/object.dart:2719:59)
#7 PipelineOwner._enableMutationsToDirtySubtrees (package:flutter/src/rendering/object.dart:1098:15)
#8 RenderObject.invokeLayoutCallback (package:flutter/src/rendering/object.dart:2719:14)
#9 RenderConstrainedLayoutBuilder.rebuildIfNecessary (package:flutter/src/widgets/layout_builder.dart:299:5)
#10 _RenderLayoutBuilder.performLayout (package:flutter/src/widgets/layout_builder.dart:397:5)
#11 RenderObject.layout (package:flutter/src/rendering/object.dart:2608:7)
#12 AppChildFitterRenderObject.performLayout.<anonymous closure> (package:bug/main.dart:254:14)
#13 RenderObject.invokeLayoutCallback.<anonymous closure> (package:flutter/src/rendering/object.dart:2719:59)
#14 PipelineOwner._enableMutationsToDirtySubtrees (package:flutter/src/rendering/object.dart:1098:15)
#15 RenderObject.invokeLayoutCallback (package:flutter/src/rendering/object.dart:2719:14)
#16 AppChildFitterRenderObject.performLayout (package:bug/main.dart:233:5)
#17 RenderObject.layout (package:flutter/src/rendering/object.dart:2608:7)
#18 RenderView.performLayout (package:flutter/src/rendering/view.dart:281:14)
#19 RenderObject._layoutWithoutResize (package:flutter/src/rendering/object.dart:2446:7)
#20 PipelineOwner.flushLayout (package:flutter/src/rendering/object.dart:1052:18)
#21 PipelineOwner.flushLayout (package:flutter/src/rendering/object.dart:1065:15)
#22 RendererBinding.drawFrame (package:flutter/src/rendering/binding.dart:602:23)
#23 WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:1164:13)
#24 RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:468:5)
#25 SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1397:15)
#26 SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1318:9)
#27 SchedulerBinding.scheduleWarmUpFrame.<anonymous closure> (package:flutter/src/scheduler/binding.dart:1040:9)
#28 PlatformDispatcher.scheduleWarmUpFrame.<anonymous closure> (dart:ui/platform_dispatcher.dart:837:16)
#32 _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:184:12)
(elided 5 frames from class _AssertionError, class _Timer, and dart:async-patch)
The following RenderObject was being processed when the exception was fired: _RenderLayoutBuilder#096db NEEDS-LAYOUT NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
needs compositing
parentData: offset=Offset(0.0, 0.0) (can use size)
constraints: BoxConstraints(w=1280.0, h=138.0)
size: Size(1280.0, 138.0)
child: RenderRepaintBoundary#48338 NEEDS-LAYOUT NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
needs compositing
parentData: offset=Offset(0.0, 0.0) (can use size)
constraints: BoxConstraints(w=1280.0, h=138.0)
layer: OffsetLayer#b90bb
engine layer: OffsetEngineLayer#a8d40
handles: 2
offset: Offset(0.0, 0.0)
size: Size(1280.0, 138.0)
metrics: 91.7% useful (1 bad vs 11 good)
diagnosis: this is an outstandingly useful repaint boundary and should definitely be kept
child: RenderPointerListener#8c8fb NEEDS-LAYOUT NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
needs compositing
parentData: <none> (can use size)
constraints: BoxConstraints(w=1280.0, h=138.0)
size: Size(1280.0, 138.0)
behavior: deferToChild
listeners: signal
child: RenderSemanticsGestureHandler#5729c NEEDS-LAYOUT NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
needs compositing
parentData: <none> (can use size)
constraints: BoxConstraints(w=1280.0, h=138.0)
size: Size(1280.0, 138.0)
behavior: deferToChild
gestures: <none>
child: RenderPointerListener#97316 NEEDS-LAYOUT NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
needs compositing
parentData: <none> (can use size)
constraints: BoxConstraints(w=1280.0, h=138.0)
size: Size(1280.0, 138.0)
behavior: deferToChild
listeners: down, panZoomStart
RenderObject: _RenderLayoutBuilder#096db NEEDS-LAYOUT NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
needs compositing
parentData: offset=Offset(0.0, 0.0) (can use size)
constraints: BoxConstraints(w=1280.0, h=138.0)
size: Size(1280.0, 138.0)
child: RenderRepaintBoundary#48338 NEEDS-LAYOUT NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
needs compositing
parentData: offset=Offset(0.0, 0.0) (can use size)
constraints: BoxConstraints(w=1280.0, h=138.0)
layer: OffsetLayer#b90bb
engine layer: OffsetEngineLayer#a8d40
handles: 2
offset: Offset(0.0, 0.0)
size: Size(1280.0, 138.0)
metrics: 91.7% useful (1 bad vs 11 good)
diagnosis: this is an outstandingly useful repaint boundary and should definitely be kept
child: RenderPointerListener#8c8fb NEEDS-LAYOUT NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
needs compositing
parentData: <none> (can use size)
constraints: BoxConstraints(w=1280.0, h=138.0)
size: Size(1280.0, 138.0)
behavior: deferToChild
listeners: signal
child: RenderSemanticsGestureHandler#5729c NEEDS-LAYOUT NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
needs compositing
parentData: <none> (can use size)
constraints: BoxConstraints(w=1280.0, h=138.0)
size: Size(1280.0, 138.0)
behavior: deferToChild
gestures: <none>
child: RenderPointerListener#97316 NEEDS-LAYOUT NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
needs compositing
parentData: <none> (can use size)
constraints: BoxConstraints(w=1280.0, h=138.0)
size: Size(1280.0, 138.0)
behavior: deferToChild
listeners: down, panZoomStart
════════════════════════════════════════════════════════════════════════════════
Reloaded 1 of 709 libraries in 191ms (compile: 11 ms, reload: 73 ms, reassemble: 84 ms).
```
</details>
### Flutter Doctor output
<details open><summary>Doctor output</summary>
```console
[✓] Flutter (Channel stable, 3.24.3, on Fedora Linux 40 (Workstation Edition) 6.10.12-200.fc40.x86_64, locale en_US.UTF-8)
• Flutter version 3.24.3 on channel stable at <path-to-flutter>/flutter/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 2663184aa7 (5 weeks ago), 2024-09-11 16:27:48 -0500
• Engine revision 36335019a8
• Dart version 3.5.3
• DevTools version 2.37.3
[✗] Android toolchain - develop for Android devices
✗ Unable to locate Android SDK.
Install Android Studio from: https://developer.android.com/studio/index.html
On first launch it will assist you in installing the Android SDK components.
(or visit https://flutter.dev/to/linux-android-setup for detailed instructions).
If the Android SDK has been installed to a custom location, please use
`flutter config --android-sdk` to update to that location.
[✗] Chrome - develop for the web (Cannot find Chrome executable at google-chrome)
! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.
[✓] Linux toolchain - develop for Linux desktop
• clang version 18.1.8 (Fedora 18.1.8-1.fc40)
• cmake version 3.28.2
• ninja version 1.12.1
• pkg-config version 2.1.1
[!] Android Studio (not installed)
• Android Studio not found; download from https://developer.android.com/studio/index.html
(or visit https://flutter.dev/to/linux-android-setup for detailed instructions).
[✓] VS Code (version 1.94.1)
• VS Code at /usr/share/code
• Flutter extension version 3.98.0
[✓] Connected device (1 available)
• Linux (desktop) • linux • linux-x64 • Fedora Linux 40 (Workstation Edition) 6.10.12-200.fc40.x86_64
[✓] Network resources
• All expected network resources are available.
! Doctor found issues in 3 categories.
```
</details>
| c: crash,framework,t: hot reload,a: desktop,a: error message,has reproducible steps,P2,team-framework,triaged-framework,found in release: 3.24,found in release: 3.27 | low | Critical |
2,588,849,617 | TypeScript | Certain homomorphic mappings break assignability with exactOptionalPropertyTypes | ### 🔎 Search Terms
eopt exactOptionalPropertyTypes homomorphic Omit unassignable
### 🕗 Version & Regression Information
- This is the behavior in every version I tried
### ⏯ Playground Link
https://tsplay.dev/w28Qzm
### 💻 Code
```ts
// @exactOptionalPropertyTypes
type T = {
foo?: true;
bar?: true;
};
type WrappedT<t extends T> = [t];
// Since Omit is normally treated as homomorphic, should work but errors with:
// Type 'true | undefined' is not assignable to type 'true'.
type OmitBarFromWrapped<t> =
t extends WrappedT<infer inner> ? WrappedT<Omit<inner, "bar">> : never;
// Even if we directly rewrite Omit to be homomorphic, we still lose assignability with EOPT
type OmitHomomorphicFromWrapped<t> =
t extends WrappedT<infer inner>
? WrappedT<HomomorphicOmit<inner, "bar">>
: never;
type HomomorphicOmit<t, keyToOmit> = {
[k in keyof t as k extends keyToOmit ? never : k]: t[k];
};
// Normally in this situation, I have a conform utility to force TS to allow the type
// but this is maybe the first time I've also seen that not work?
type OmitHomomorphicFromWrappedConformed<t> =
t extends WrappedT<infer inner>
? WrappedT<conform<HomomorphicOmit<inner, "bar">, T>>
: never;
type conform<t, base> = t extends base ? t : base;
```
### 🙁 Actual behavior
Applying a homomorphic mapping to a type can break property assignability with EOPT
### 🙂 Expected behavior
Should preserve assignability
### Additional information about the issue
_No response_ | Help Wanted,Possible Improvement | low | Critical |
2,588,882,334 | rust | Tracking issue for wasm32-emscripten ui test failures | These are the tests that are failing after #131705:
- [ ] `abi/numbers-arithmetic/return-float.rs` -- adding `-Cpanic=abort` fixes the failure. [The upstream bug report](https://github.com/emscripten-core/emscripten/issues/22743) has a C++ reproducer. More reason it would be nice to resolve #112195.
- [x] `async-await/issue-60709.rs` -- [Emscripten bug](https://github.com/emscripten-core/emscripten/issues/22742) that occurs when `-lc` and `-Oz` are passed to the linker, can be reproduced with
```sh
echo "fn main(){}" > a.rs
rustc -Copt-level=z a.rs -o a.js --target=wasm32-unknown-emscripten
```
- [x] backtrace/dylib-dep.rs -- "Not supported", xfailed in https://github.com/rust-lang/rust/pull/131776
- [x] backtrace/line-tables-only.rs -- "Not supported", xfailed in https://github.com/rust-lang/rust/pull/131776
- [ ] no_std/no-std-unwind-binary.rs -- compiler says error: lang item required, but not found: eh_catch_typeinfo
- [ ] structs-enums/enum-rec/issue-17431-6.rs -- One of the two compiler errors is missing
- [ ] test-attrs/test-passed.rs | A-testsuite,C-bug,C-tracking-issue,O-emscripten | low | Critical |
2,588,885,385 | flutter | DecoratedSliver could benefit from example that turns off clip behavior on parent scrollview | ### Steps to reproduce
1. flutter create bug
2. Paste the code sample
3. flutter run -d chrome
4. Make the window bigger and smaller, so that the scrollbar appears/disappears on the sliver
5. When the scrollbar is shown, the decoration is clipped on _all_ sides, which makes the shadows disappear in the sample.
6. In case the effect is hard to see, changing the shadow color to something easy to see, like `Colors.red` makes the effect way more apparent.
### Expected results
I expect the visible parts of the decoration to be painted, regardless of whether the sliver is currently scrollable.
I.e. like how a nine-patch rect draws its corners and the sides between the corners can be infinitely long.
### Actual results
The decoration is only properly painted when the sliver fits entirely on the screen.
If I set `Clip.none` for the `CustomScrollView`, it seems to be fixed. I would expect the clip to only happen on the trailing edge of the scroll axis, so that the visible decoration is not clipped when the scrollbar is shown.
In this sample, that would be clipping the bottom and not the top/left/right of the decoration.
However, the docs tell you that the child isn't clipped, despite there is _some_ clipping going on, which feels misleading?
https://github.com/flutter/flutter/blob/2b36701456d25d48e5c923d115d719e691c3f9b7/packages/flutter/lib/src/widgets/decorated_sliver.dart#L28-L29
### Code sample
<details open><summary>Code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Flutter Demo',
theme: ThemeData(
colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
useMaterial3: true,
),
home: const MyHomePage(title: 'Flutter Demo Home Page'),
);
}
}
class MyHomePage extends StatefulWidget {
const MyHomePage({super.key, required this.title});
final String title;
@override
State<MyHomePage> createState() => _MyHomePageState();
}
class _MyHomePageState extends State<MyHomePage> {
@override
Widget build(BuildContext context) {
return Scaffold(
body: Center(
child: Padding(
padding: const EdgeInsets.all(8.0),
child: CustomScrollView(
slivers: [
DecoratedSliver(
decoration: const ShapeDecoration(
color: Colors.white,
shape: RoundedRectangleBorder(
borderRadius: BorderRadius.all(Radius.circular(6)),
),
shadows: <BoxShadow>[
BoxShadow(
color: Color(0x1A79858C),
offset: Offset(3, 3),
blurRadius: 24,
),
],
),
sliver: SliverList.builder(
itemCount: 10,
itemBuilder: (_, int index) => Padding(
padding: const EdgeInsets.all(8.0),
child: Row(
children: <Widget>[
const Icon(Icons.abc),
Flexible(child: Text('Item $index')),
],
),
),
),
),
],
),
),
),
);
}
}
```
</details>
### Screenshots or Video
<details open>
<summary>Screenshots / Video demonstration</summary>
https://github.com/user-attachments/assets/fb77546c-01b0-4122-9911-445e5562b1d5
</details>
### Logs
<details open><summary>Logs</summary>
```console
navaronbracke@MacBook-Pro-van-Navaron decorated_sliver_bug % flutter run -d chrome
Resolving dependencies...
Downloading packages...
> collection 1.19.0 (was 1.18.0)
flutter_lints 4.0.0 (5.0.0 available)
> leak_tracker 10.0.7 (was 10.0.5)
> leak_tracker_flutter_testing 3.0.8 (was 3.0.5)
lints 4.0.0 (5.1.0 available)
material_color_utilities 0.11.1 (0.12.0 available)
meta 1.15.0 (1.16.0 available)
< sky_engine 0.0.0 from sdk flutter (was 0.0.99 from sdk flutter)
> stack_trace 1.12.0 (was 1.11.1)
> string_scanner 1.3.0 (was 1.2.0)
> test_api 0.7.3 (was 0.7.2)
> vm_service 14.3.0 (was 14.2.5)
Changed 8 dependencies!
4 packages have newer versions incompatible with dependency constraints.
Try `flutter pub outdated` for more information.
Launching lib/main.dart on Chrome in debug mode...
Waiting for connection from debug service on Chrome... 16.2s
This app is linked to the debug service: ws://127.0.0.1:57227/tiIHHuiVJps=/ws
Debug service listening on ws://127.0.0.1:57227/tiIHHuiVJps=/ws
🔥 To hot restart changes while running, press "r" or "R".
For a more detailed help message, press "h". To quit, press "q".
A Dart VM Service on Chrome is available at: http://127.0.0.1:57227/tiIHHuiVJps=
The Flutter DevTools debugger and profiler on Chrome is available at:
http://127.0.0.1:9101?uri=http://127.0.0.1:57227/tiIHHuiVJps=
Performing hot restart... 162ms
Restarted application in 164ms.
```
</details>
### Flutter Doctor output
<details open><summary>Doctor output</summary>
```console
[✓] Flutter (Channel master, 3.27.0-1.0.pre.50, on macOS 14.6.1 23G93 darwin-x64, locale en-BE)
• Flutter version 3.27.0-1.0.pre.50 on channel master at /Users/navaronbracke/Documents/flutter
• Upstream repository git@github.com:navaronbracke/flutter.git
• FLUTTER_GIT_URL = git@github.com:navaronbracke/flutter.git
• Framework revision 2b36701456 (77 minutes ago), 2024-10-15 08:42:42 -0400
• Engine revision 107ea8baa4
• Dart version 3.6.0 (build 3.6.0-334.2.beta)
• DevTools version 2.40.1
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
• Android SDK at /Users/navaronbracke/Library/Android/sdk
• Platform android-34, build-tools 34.0.0
• ANDROID_HOME = /Users/navaronbracke/Library/Android/sdk
• Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 16.0)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 16A242d
• CocoaPods version 1.15.2
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2024.1)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)
[✓] VS Code (version 1.94.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.98.0
[✓] Connected device (2 available)
• macOS (desktop) • macos • darwin-x64 • macOS 14.6.1 23G93 darwin-x64
• Chrome (web) • chrome • web-javascript • Google Chrome 129.0.6668.91
[✓] Network resources
• All expected network resources are available.
• No issues found!
```
</details>
| framework,f: scrolling,d: api docs,good first issue,has reproducible steps,P2,team-framework,triaged-framework,found in release: 3.24,found in release: 3.27 | low | Critical |
2,588,949,461 | react | [DevTools Bug]: v6.0.0 (9/26/2024) of devtools makes a page extremely slow in dev (even when devtools are closed) | ### Website or app
difficult to build a repor for now, since
### Repro steps
I'm unsure what's the best way to reproduce the issue, but I'm loading a page with React Router v6 with React@19.0.0-rc-6cf85185-20241014 (using the latest version of the compiler), and v6.0.0 of devtools. Chrome version 129.0.6668.101 (Official Build) (arm64) on MacOS.
Even with devtools closed, page loads become very sluggish in development. If I run a Chrome performance profiler, it completely stalls on opening a new page for 5 seconds (albeit we're not running the React profiler):
<img width="1249" alt="Screenshot 2024-10-15 at 15 52 16" src="https://github.com/user-attachments/assets/8a61346e-fb56-4611-adab-36b2c0567111">
When I turn off React Developer tools, page loads become instant when devtools are closed, and Chrome profiler is also 10x faster.
The problem is so bad that we thought we had a memory leak in our app somewhere, but it was all good in the built version of the app. Turns out devtools had updated in the background and everything became sluggish in development as a result. After we disabled the extensions, everything became supper snappy in development again.
Would love to provide a repro, but I'm not exactly sure what conditions trigger the issue, as a barebones react router setup doesn't seem to do the trick.
### How often does this bug happen?
Every time
### DevTools package (automated)
_No response_
### DevTools version (automated)
_No response_
### Error message (automated)
_No response_
### Error call stack (automated)
_No response_
### Error component stack (automated)
_No response_
### GitHub query string (automated)
_No response_ | Type: Bug,Status: Unconfirmed,Component: Developer Tools | low | Critical |
2,588,950,027 | godot | BoneAttachment3D signal error after re-set the external skeleton during gameplay | ### Tested versions
Reproductible in: v4.3.stable.mono.official [77dcf97d8]
### System information
Windows 10 Godot V4.3 Forward+
### Issue description
BoneAttachment3D signal error after re-set the external skeleton during gameplay.
The Script is pretty simple, just change the skeleton during gameplay using C# script. The game is keep running, but showing error about the Signal: ‘skeleton_updated’, callable: ‘BoneAttachment3D::on_skeleton_update’.
Here is full error note :
```
E 0:00:03:0261 NativeCalls.cs:366 @ void Godot.NativeCalls.godot_icall_1_41(nint, nint, Godot.NativeInterop.godot_bool): Attempt to disconnect a nonexistent connection from 'GeneralSkeleton:<Skeleton3D#63065556757>'. Signal: 'skeleton_updated', callable: 'BoneAttachment3D::on_skeleton_update'.
<C++ Error> Condition "signal_is_valid" is true. Returning: false
<C++ Source> core/object/object.cpp:1458 @ _disconnect()
<Stack Trace> NativeCalls.cs:366 @ void Godot.NativeCalls.godot_icall_1_41(nint, nint, Godot.NativeInterop.godot_bool)
BoneAttachment3D.cs:150 @ void Godot.BoneAttachment3D.SetUseExternalSkeleton(bool)
MechSelectionMenu.cs:65 @ void MechSelectionMenu.OnItemButtonPressed(string)
ItemSelectionButton_ScriptSignals.generated.cs:40 @ void ItemSelectionButton.RaiseGodotClassSignalCallbacks(Godot.NativeInterop.godot_string_name&, Godot.NativeInterop.NativeVariantPtrArgs)
ScriptManagerBridge.cs:455 @ void Godot.Bridge.ScriptManagerBridge.RaiseEventSignal(nint, Godot.NativeInterop.godot_string_name*, Godot.NativeInterop.godot_variant**, int, Godot.NativeInterop.godot_bool*)
Godot.NativeInterop.NativeFuncs.generated.cs:367 @ Godot.NativeInterop.godot_variant Godot.NativeInterop.NativeFuncs.godotsharp_method_bind_call(nint, nint, Godot.NativeInterop.godot_variant**, int, Godot.NativeInterop.godot_variant_call_error&)
NativeCalls.cs:7026 @ int Godot.NativeCalls.godot_icall_2_778(nint, nint, Godot.NativeInterop.godot_string_name, Godot.Variant[], Godot.NativeInterop.godot_string_name)
GodotObject.cs:638 @ Godot.Error Godot.GodotObject.EmitSignal(Godot.StringName, Godot.Variant[])
ItemSelectionButton.cs:26 @ void ItemSelectionButton.OnButtonPressed()
Callable.generics.cs:39 @ void Godot.Callable.<From>g__Trampoline|1_0(object, Godot.NativeInterop.NativeVariantPtrArgs, Godot.NativeInterop.godot_variant&)
DelegateUtils.cs:86 @ void Godot.DelegateUtils.InvokeWithVariantArgs(nint, System.Void*, Godot.NativeInterop.godot_variant**, int, Godot.NativeInterop.godot_variant*)
```
### Steps to reproduce
- .QueueFree() current skeleton and add new skeleton trough script.
- And reset the SetExternalSkeleton(NewSkeleton.GetPath()) at this point all still works fine, but the bone location is not updated to new skeleton
- The error comes when I run the function SetUseExternalSkeleton(true)
### Minimal reproduction project (MRP)
I don't provide project because it is easy to replicate | needs testing,topic:dotnet,topic:animation | low | Critical |
2,588,985,508 | storybook | [Bug]: hash navigation does not work | ### Describe the bug
If you click on the anchor tag next to a story title in the autodocs page, it adds a hash parameter to the page url. However, this hash parameter cannot be used again to go to the same story.
### Reproduction link
https://stackblitz.com/github/storybookjs/sandboxes/tree/next/react-webpack/18-ts/after-storybook?file=.storybook%2Fpreview.ts
### Reproduction steps
1. Open the reproduction link
2. Open preview in a new tab
3. Visit /?path=/docs/example-button--docs#secondary
4. See that it doesn't go directly to the `Secondary` story
### System
Storybook Environment Info:
System:
OS: Linux 5.0 undefined
CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
Shell: 1.0 - /bin/jsh
Binaries:
Node: 18.20.3 - /usr/local/bin/node
Yarn: 1.22.19 - /usr/local/bin/yarn
npm: 10.2.3 - /usr/local/bin/npm <----- active
pnpm: 8.15.6 - /usr/local/bin/pnpm
npmPackages:
@storybook/addon-essentials: ^8.4.0-alpha.7 => 8.4.0-alpha.7
@storybook/addon-interactions: ^8.4.0-alpha.7 => 8.4.0-alpha.7
@storybook/addon-onboarding: ^8.4.0-alpha.7 => 8.4.0-alpha.7
@storybook/addon-webpack5-compiler-swc: ^1.0.5 => 1.0.5
@storybook/blocks: ^8.4.0-alpha.7 => 8.4.0-alpha.7
@storybook/react: ^8.4.0-alpha.7 => 8.4.0-alpha.7
@storybook/react-webpack5: ^8.4.0-alpha.7 => 8.4.0-alpha.7
@storybook/test: ^8.4.0-alpha.7 => 8.4.0-alpha.7
storybook: ^8.4.0-alpha.7 => 8.4.0-alpha.7
### Additional context
I just used a brand new react 18/webpack5 storybook via storybook.new. No configuration changes were made. | bug,addon: docs | low | Critical |
2,589,000,414 | stable-diffusion-webui | [Bug]: Unable to create venv in directrory | ### Checklist
- [X] The issue exists after disabling all extensions
- [X] The issue exists on a clean installation of webui
- [ ] The issue is caused by an extension, but I believe it is caused by a bug in the webui
- [X] The issue exists in the current version of the webui
- [X] The issue has not been reported before recently
- [ ] The issue has been reported before but has not been fixed yet
### What happened?
After cloning the repository using the command line, this error occurs when launching the bat file. Manually creating a venv does not help.
### Steps to reproduce the problem
1. Copying the repository using the command line according to the instructions from the wiki for amd processors
2. Launching the webui-user.bat file
### What should have happened?
Successful launch of webui
### What browsers do you use to access the UI ?
Google Chrome
### Sysinfo
--dump-sysinfo doesnt work
### Console logs
```Shell
Creating venv in directory E:\stable\stable-diffusion-webui-directml\venv using python "C:\Users\└эфЁхщ\AppData\Local\Microsoft\WindowsApps\PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0\python.exe"
Unable to create venv in directory "E:\stable\stable-diffusion-webui-directml\venv"
exit code: 3
stderr:
Системе не удается найти указанный путь.
Launch unsuccessful. Exiting.
Для продолжения нажмите любую клавишу . . .
```
### Additional information
I can't find the sysinfo file.
I have Windows 11.
Python of the latest version from the Microsoft Store is installed | bug-report | low | Critical |
2,589,125,881 | rust | with_exposed_provenance(0).with_addr(addr) is compiled as gep null | Miri executes this program without error, but I believe our lowering to LLVM IR adds UB:
```rust
#![feature(strict_provenance, exposed_provenance)]
#[no_mangle]
pub fn from_exposed_null(addr: usize) -> *const u8 {
let ptr = 0x0 as *const u8;
ptr.with_addr(addr)
}
// Main for Miri
fn main() {
let data = 0u8;
let addr = std::ptr::addr_of!(data).expose_provenance();
let ptr = from_exposed_null(addr);
unsafe {
println!("{}", *ptr);
}
}
```
With optimizations enabled, LLVM cleans up `from_exposed_null` to
```llvm
define noalias noundef ptr @from_exposed_null(i64 noundef %addr) unnamed_addr #0 !dbg !7 {
%0 = getelementptr i8, ptr null, i64 %addr, !dbg !12
ret ptr %0, !dbg !28
}
```
With `-Cno-prepopulate-passes` I believe the codegen also returns a pointer that definitely has no provenance, though it's just harder to read.
godbolt: https://godbolt.org/z/s414rfK44
I *think* this happens because codegen is implicitly const-propagating through the int-to-pointer cast via `OperandValue`. At least I don't see any other way to get from this MIR:
```
bb0: {
_2 = const 0_usize as *const u8 (PointerWithExposedProvenance);
StorageLive(_3);
StorageLive(_5);
StorageLive(_6);
StorageLive(_4);
_4 = copy _2 as usize (Transmute);
_3 = move _4 as isize (IntToInt);
StorageDead(_4);
_5 = copy _1 as isize (IntToInt);
_6 = Sub(copy _5, copy _3);
_0 = arith_offset::<u8>(move _2, move _6) -> [return: bb1, unwind unreachable];
}
bb1: {
StorageLive(_7);
_7 = copy _0 as *const () (PtrToPtr);
StorageDead(_7);
StorageDead(_6);
StorageDead(_5);
StorageDead(_3);
return;
}
```
To this LLVM IR
```
define noundef ptr @from_exposed_null(i64 noundef %addr) unnamed_addr #0 !dbg !7 {
start:
%0 = alloca [8 x i8], align 8, !dbg !12
%offset = sub i64 %addr, 0, !dbg !12
call void @llvm.lifetime.start.p0(i64 8, ptr %0), !dbg !28
%1 = getelementptr i8, ptr null, i64 %offset, !dbg !28
store ptr %1, ptr %0, align 8, !dbg !28
%self = load ptr, ptr %0, align 8, !dbg !28
call void @llvm.lifetime.end.p0(i64 8, ptr %0), !dbg !28
ret ptr %self, !dbg !34
}
```
godbolt: https://godbolt.org/z/MjPvcdj9h | T-compiler,C-bug,A-strict-provenance,T-opsem | low | Critical |
2,589,128,280 | next.js | Redirect from Server Action takes precedence over the Redirect from Middleware when they are sequential | ### Link to the code that reproduces this issue
https://codesandbox.io/p/devbox/dqqhy7
### To Reproduce
1. Visit the [demo](https://dqqhy7-3000.csb.app/)
2. Click the Trigger A redirect button
3. You'll be redirected. The search params you'll see have hello='xyz' (This was expected to be hello=xyz&identifier=yolo)
4. Refresh the page, you'll see the expected params
### Current vs. Expected behavior
Current Behavior:
Triggering a redirect from a server action to another route results in the invocation of the middleware, which processes the request and has the ability to redirect again depending on how the request is handled. In this case, search parameters attached to the redirect URL from the server action are being received in the middleware. I’m trying to append an additional search parameter and redirect again, and although the generated URL with the newly added search param appears correct, the page served to the client does not include the newly appended parameter.
Expected Behavior:
I expect the parameter I appended to be available to the client because I attached it and triggered the redirect in the middleware.
In my actual codebase, the server action signs the user in (using signIn from [authjs](https://authjs.dev/) with redirect: false) and then redirects them (using next/navigation) to another route. This route is supposed to generate a temporary identifier and append it to the search parameters. I use middleware to achieve this, as the middleware intercepts the request to the target route (from the server action), checks for the search parameters, and if the identifier is missing, calls my custom backend (using the auth token it just received). The middleware then appends the identifier from the backend response to the search parameters and redirects the request again. The middleware is invoked once more, but this time with the search parameter included in the URL.
The issue is that the client is still being served a page without the appended query parameter.
I’ve found a workaround by avoiding the redirect in the server action and using router.push in the client component that triggered the workflow.
Could someone help me understand why this issue is happening?
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 23.5.0: Wed May 1 20:14:59 PDT 2024; root:xnu-10063.121.3~5/RELEASE_ARM64_T8122
Available memory (MB): 16384
Available CPU cores: 8
Binaries:
Node: 18.20.3
npm: 10.7.0
Yarn: 1.22.22
pnpm: 9.12.1
Relevant Packages:
next: 14.2.6 // There is a newer version (14.2.15) available, upgrade recommended!
eslint-config-next: 14.2.6
react: 18.3.1
react-dom: 18.3.1
typescript: 5.5.4
Next.js Config:
output: standalone
```
### Which area(s) are affected? (Select all that apply)
Middleware
### Which stage(s) are affected? (Select all that apply)
next dev (local), next start (local), Other (Deployed)
### Additional context
Tested on v14.2.5, v14.2.6, v14.2.15. Happens locally as well deployed on gcloud with a docker image. | bug,Middleware | low | Minor |
2,589,168,511 | deno | Add "ignore" to Deno.watchFs | Hey,
been using Deno for a while now.
For a cli tool I'm using Deno.watchFs, which works fine.
My use case is the following: I want to watch a whole directory recursively and then have different actions depending on what files have changed. This allows me do dynamically listen for new folder creations etc. in one place.
The problem: Attaching the watcher to the project root directory (with e.g. the .git folder) takes a long time, sometimes seconds. It would be very convenient to have something like "ignore" alongside with the "recursive" option in order to initially exclude some folders or files from being watched, but still watch all the files and folders that are present recursively.
I know that I could restructure the project, maybe put everything that needs "watching" into a separate sub directory, but I think this would be a great and convenient addition to the file watcher.
Also I'm happy to contribute and add this to the watcher, if it's something that will be adopted. So this would be cool:
```ts
using watcher = Deno.watchFs(rootDir, { recursive: true, ignore: [".git", "some-other-file"] });
// or
using watcher = Deno.watchFs(rootDir, { recursive: true, ignore: ".git" });
```
As I understand it we would just need to add a filter to the loop of the files and simply skip it if it's in the ignore list:
https://github.com/denoland/deno/blob/e4b52f5a7684cfb6754f2531e51f833a64d97d7b/runtime/ops/fs_events.rs#L125-L130
But maybe I'm wrong and this change needs to happen in the inotify crate. Or maybe there is even a better solution that works with the current setup?
| feat,public API,ext/fs | low | Minor |
2,589,241,136 | electron | [Bug]: powerMonitor on resume event fires twice | ### Preflight Checklist
- [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [x] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
33.0.0 (tried on 31.2.0 as well)
### What operating system(s) are you using?
Windows
### Operating System Version
Windows 10 22H2
### What arch are you using?
x64
### Last Known Working Electron version
Not sure, but seems this is a regression
### Expected Behavior
When waking up the device, the powerMonitor on resume event should only fire once.
### Actual Behavior
When waking up the device, the powerMonitor on resume event fires twice
### Testcase Gist URL
_No response_
### Additional Information
Can be easily reproduced using the electron-react-boilerplate setup and adding the on resume code as such:
```
app
.whenReady()
.then(() => {
createWindow();
app.on('activate', () => {
// On macOS it's common to re-create a window in the app when the
// dock icon is clicked and there are no other windows open.
if (mainWindow === null) createWindow();
});
// using a typescript import also has the same effect as this
const { powerMonitor } = require('electron');
powerMonitor.on('resume', () => {
console.log('The system is resuming');
});
})
.catch(console.log);
```
Upon resuming the device, two logs are recorded:
```
[1] The system is resuming
[1] The system is resuming
``` | platform/windows,bug :beetle:,component/powerMonitor,31-x-y,32-x-y,33-x-y | low | Critical |
2,589,280,429 | rust | `get_unchecked()` is never inlined on armv7-unknown-linux-gnueabihf in functions with `#[target_feature(enable = "neon")]` | While working on armv7 neon support for [simdutf8](https://github.com/rusticstuff/simdutf8) I ran across inlining problems for functions with `#[target_feature(enable = "neon")]`. One of them is that `get_unchecked()` is never inlined in such functions.
More info:
* It also is not inlined with the armv7-linux-androideabi target
* It is inlined with the thumbv7neon-unknown-linux-gnueabihf target
* It is inlined if compiled with RUSTFLAGS="-Ctarget_feature=+neon"
```rust
#![feature(arm_target_feature)]
#[target_feature(enable = "neon")]
pub unsafe fn get_unchecked_range(x: &[u8]) -> &[u8] {
// do more neon stuff
unsafe { x.get_unchecked(3..)}
// do more neon stuff
}
#[target_feature(enable = "neon")]
pub unsafe fn get_unchecked_one(x: &[u8]) -> &u8 {
// do more neon stuff
unsafe { x.get_unchecked(3)}
// do more neon stuff
}
```
[Godbolt](https://godbolt.org/z/8sdbhG8Y9)
The root cause might be the same as for #102220. | A-LLVM,I-slow,A-codegen,O-Arm,T-compiler,A-SIMD,C-bug,A-target-feature | low | Minor |
2,589,297,392 | godot | [DX12] RenderingDeviceDriverD3D12 does not correctly check minimum supported shader model | ### Tested versions
Still present in current master.
### System information
Windows DirectX
### Issue description
The loop implemented in [rendering_device_driver_d3d12.cpp:6394](https://github.com/godotengine/godot/blob/master/drivers/d3d12/rendering_device_driver_d3d12.cpp#L6394)
```C++
shader_model.HighestShaderModel = SMS_TO_CHECK[i];
res = device->CheckFeatureSupport(D3D12_FEATURE_SHADER_MODEL, &shader_model, sizeof(shader_model));
if (SUCCEEDED(res)) {
```
does not match the official documentation in
https://learn.microsoft.com/en-us/windows/win32/api/d3d12/ns-d3d12-d3d12_feature_data_shader_model
basically as long as an DirectX 12 capable device is present it will always accept even if the highest supported shader model is 5.1.
Sadly there are a lot of older Nvidia and Intel GPUs out there where this is the case exactly and instead of printing an error messages in these cases the engine will simply crash later on.
### Steps to reproduce
Run Godot with --rendering-driver d3d12 with an old GPU installed (e.g. Intel HD 4000/ Nvidia GTX 620)
### Minimal reproduction project (MRP)
None needed | bug,platform:windows,topic:rendering | low | Critical |
2,589,345,618 | pytorch | cprofile on compiler should trigger on backwards | ### 🐛 Describe the bug
Right now they don't:
<img width="784" alt="image" src="https://github.com/user-attachments/assets/c41d12f2-96f6-4b37-a7df-55f6c895963b">
### Versions
main
cc @chauhang @penguinwu | triaged,oncall: pt2 | low | Critical |
2,589,369,860 | flutter | Accidental Dismissals of ListView Items During Scroll | ### Steps to reproduce
1.Create a ListView with 35 items.
2.Use a Dismissible widget for each item inside the ListView.
3.Scroll the list up and down.
4.Observe that when starting the scroll with a diagonal swipe motion, **_sometimes_** items get dismissed unintentionally.
5. Tested on Android with Samsung A33.
### Expected results
When using a ListView with Dismissible items, the user should be able to scroll freely without unintentionally dismissing items, even when using a diagonal swipe motion. The sensitivity for scrolling should be greater than that for dismissing items, similar to the behavior observed in the Gmail app.
### Actual results
When starting the scroll with a diagonal swipe motion, some items get dismissed unintentionally.
### Code sample
```dart
import 'package:flutter/material.dart';
void main() {
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({Key? key}) : super(key: key);
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Flutter Demo',
theme: ThemeData(
colorScheme: ColorScheme.fromSwatch(primarySwatch: Colors.deepPurple),
),
home: const MyHomePage(title: 'Flutter Demo Home Page'),
);
}
}
class MyHomePage extends StatefulWidget {
const MyHomePage({Key? key, required this.title}) : super(key: key);
final String title;
@override
State<MyHomePage> createState() => _MyHomePageState();
}
class _MyHomePageState extends State<MyHomePage> {
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
title: Text(widget.title),
),
body: ListView.builder(
itemCount: 35,
itemBuilder: (context, index) {
return Dismissible(
key: UniqueKey(),
background: Container(
color: Colors.red,
alignment: Alignment.centerRight,
padding: const EdgeInsets.symmetric(horizontal: 20),
child: const Icon(Icons.delete, color: Colors.white),
),
onDismissed: (direction) {
setState(() {
// Remove the item from the data source
});
ScaffoldMessenger.of(context).showSnackBar(
const SnackBar(content: Text('Item dismissed')),
);
},
child: ListTile(
title: Text('Item $index'),
onTap: () {
// Handle tap
},
),
);
},
),
);
}
}
```
### Screenshots or Video
<details open>
<summary>Screenshots / Video demonstration</summary>
[Upload media here]
</details>
https://github.com/user-attachments/assets/248c080c-0379-40f7-a568-7f5abacdd959
### Logs
<details open><summary>Logs</summary>
```console
[Paste your logs here]
```
</details>
### Flutter Doctor output
```
[√] Flutter (Channel stable, 3.16.5, on Microsoft Windows [Version 10.0.22631.4317], locale he-IL)
• Flutter version 3.16.5 on channel stable at C:\flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 78666c8dc5 (10 months ago), 2023-12-19 16:14:14 -0800
• Engine revision 3f3e560236
• Dart version 3.2.3
• DevTools version 2.28.4
[√] Windows Version (Installed version of Windows is version 10 or higher)
[!] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
• Android SDK at C:\Users\david.somekh\AppData\Local\Android\sdk
X cmdline-tools component is missing
Run `path/to/sdkmanager --install "cmdline-tools;latest"`
See https://developer.android.com/studio/command-line for more details.
X Android license status unknown.
Run `flutter doctor --android-licenses` to accept the SDK licenses.
See https://flutter.dev/docs/get-started/install/windows#android-setup for more details.
[√] Chrome - develop for the web
• Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe
[√] Visual Studio - develop Windows apps (Visual Studio Professional 2022 17.3.4)
• Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Professional
• Visual Studio Professional 2022 version 17.3.32901.215
• Windows 10 SDK version 10.0.19041.0
[√] Android Studio (version 2021.1)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.11+9-b60-7590822)
[√] VS Code (version 1.94.2)
• VS Code at C:\Users\david.somekh\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 3.98.0
[√] Connected device (3 available)
• Windows (desktop) • windows • windows-x64 • Microsoft Windows [Version 10.0.22631.4317]
• Chrome (web) • chrome • web-javascript • Google Chrome 129.0.6668.90
• Edge (web) • edge • web-javascript • Microsoft Edge 129.0.2792.89
[√] Network resources
• All expected network resources are available.
! Doctor found issues in 1 category.
``` | framework,f: scrolling,f: gestures,has reproducible steps,P3,team-framework,triaged-framework,found in release: 3.24,found in release: 3.27 | low | Major |
2,589,380,153 | godot | SteamInput can fail on Windows | ### Tested versions
4.dev [6699ae7]
### System information
Godot v4.3 - Windows 10 D3D12 (Forward+)
### Issue description
There are multiple bugs when using Steam Input with Godot under Windows currently.
- Godot will not always use XInput for these controller even tough Steam will provide a XInput API for them.
[joypad_windows.cpp#L101](https://github.com/godotengine/godot/blob/4.3/platform/windows/joypad_windows.cpp#L101)
Does use a fixed list of inputs for which XInput is enabled. Nintendo Switch controllers are missing from this list for example.
(There are probably more of these as the list passed from steam via SDL_GAMECONTROLLER_IGNORE_DEVICES contains a lot of different pid & vid values).
Additionally, at least when using the joy-con charger via USB, the pid variable reported in this function by using the GUIID is different from the one steam provides (0x200e vs 0x2007).
Using Steam Input for some controllers is mandatory at the moment until SDL will be used within Godot, as DirectInput will not only not work for these controllers but provide random garbage inputs and smashing random buttons.
#81191. Which if not handled will create a lot of issues for players which may not even notice that a Switch controller is connected. (E.g. for us its was quite quick in selecting the "Exit Game" option in the menu)
- [```JoypadWindows::process_joypads()```](https://github.com/godotengine/godot/blob/6699ae7897658e44efc3cfb2cba91c11a8f5aa6a/platform/windows/joypad_windows.cpp#L347C21-L347C36)
may be called to late or not often enough when using Steam Input. This issue is for some reason only present in the D3D12 backend and results in duplicate controllers as well as missing ones. While adding a removal option here is relatively easy the doc explicitly states that one should not call this api too often when no controller is connected on a specific slot [MicrosoftDocs](https://github.com/MicrosoftDocs/win32/blob/docs/desktop-src/xinput/getting-started-with-xinput.md?test#:~:text=For%20performance%20reasons%2C%20)
Both of these will probably be obsolete when using SDL for controllers instead of XInput/DirectInput so I'm not sure if worth it to be fixed. But as a lot of games will be using Steam on Windows for distribution and may run into this issue aswell.
### Steps to reproduce
For Steam Input to be active the game needs to be run via Steam (either as a game on Steam or using the "Add a Non-Steam Game to My Library" functionality.
### Minimal reproduction project (MRP)
Any recent Godot game will do. If needed I can provide a Steam App with a special branch for this issue. | bug,platform:windows,needs testing,topic:input | low | Critical |
2,589,435,070 | rust | Tracking Issue for `-Zregparm` | This is a tracking issue for the `-Zregparm` flag for x86. It is the equivalent of Clang's/GCC's `-mregparm=3`. The kernel needs it to support the x86 32-bit architecture, together with [`-Zreg-struct-return`](https://github.com/rust-lang/rust/issues/116972).
It could potentially be a ["global target feature"](https://github.com/rust-lang/rust/issues/121970#issuecomment-1978605782), i.e. a target feature that is required to be set the same way for all compilation units.
- https://gcc.gnu.org/onlinedocs/gcc/x86-Function-Attributes.html#index-regparm-function-attribute_002c-x86
- https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-clang-mregparm
### About tracking issues
Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
Discussion comments will get marked as off-topic or deleted.
Repeated discussions on the tracking issue may lead to the tracking issue getting locked.
### Steps
- [x] Implementation:
- https://github.com/rust-lang/rust/pull/130432
- [ ] Adjust documentation ([see instructions on rustc-dev-guide](https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#documentation-prs))
- [ ] Stabilization PR ([see instructions on rustc-dev-guide](https://rustc-dev-guide.rust-lang.org/stabilization_guide.html#stabilization-pr))
### Unresolved Questions & Answers
- [ ] Q: Should it affect the Rust ABI? It cannot be documented as doing such, because the Rust ABI is unstable, but should it do so anyways as a quality-of-implementation matter?
- **Currently**: No.
- **Alternatives**:
- Maybe yes?
- Maybe we want to have a modification equivalent to `"fastcall"` or `-Zregparm=3` apply to the Rust ABI implicitly, without `-Zregparm` affecting it?
- [ ] Q: Should it affect *any* other ABIs than `"C"`, `"cdecl"`, and `"stdcall"`?
- **Currently**: No.
- **Alternatives**: It's not yet clear what ABIs this affects for gcc and clang.
- [ ] Q: Should it be accepted on any other architecture than x86_32?
- **Currently**: No.
- [ ] Q: Does MSVC code use this? `extern "fastcall"` does something equivalent to `-Zregparm=2`, so do MSVC targets even use it, or do they just use `fastcall`? | T-compiler,C-tracking-issue,A-ABI,A-CLI,O-x86_32,A-rust-for-linux | low | Critical |
2,589,463,849 | godot | Editor prints infinite errors while an opened LightOccluder2D polygon is in view of a GPUParticles2D with collision mode | ### Tested versions
Reproducible in 4.3 stable
### System information
Godot v4.3.stable - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3060 Laptop GPU (NVIDIA; 32.0.15.6081) - Intel(R) Core(TM) i7-10870H CPU @ 2.20GHz (16 Threads)
### Issue description
Opening a LightOccluder2D polygon seems to be accumulating a large amount of errors while it's in the editor's viewport, if there is also a GPUParticle2D with a collision mode set to anything but disabled in view. This seems to be an issue with the editor only and both the particle emitter and the opened occluder are behaving as expected during runtime, and don't produce errors.
The issue seems to occur with any shape and number of points as long as closed is set to false (no concave/overlapping points in the polygon), regardless of whether the polygon was closed or not when creating it, but seems to be resolved in most cases if the position of a point in the polygon is changed later (however returns again if the number of points is changed again, or if the editor is restarted). The issue appears regardless of the occluder and the particle emitter interacting with each other at all.
### Steps to reproduce
1. Set up a new GPUParticles2D node
2. Set the ParticleProcessMaterial's collision mode to anything but disabled.
1. Create a new LightOccluder2D node
3. Assign a new OccluderPolygon2D
4. Set closed property to false
5. Errors only print while both nodes are visible within the editor's viewport, either due to zoom/scroll or with their visibilities set to true
### Minimal reproduction project (MRP)
[occluder-bug-report.zip](https://github.com/user-attachments/files/17382526/occluder-bug-report.zip)
| bug,topic:editor,topic:2d | low | Critical |
2,589,465,076 | PowerToys | Keyboard Manager: make `Remap key` Multiple Letters support | ### Description of the new feature / enhancement
Feature like **GBoard Distionary** word suggestions
Like this
when type `my-bio` then write `my bio text`
### Scenario when this would be used?
when type `my-bio` then write `my bio text`
### Supporting information
_No response_ | Needs-Triage | low | Minor |
2,589,504,778 | pytorch | torch/nn/modules/conv.py torch.OutOfMemoryError: HIP out of memory | ### 🐛 Describe the bug
I have a similar error with workloads that i hear anecdotally should be much less taxing on the VRAM.
this particular example is deigned for **10GB. it utilizes CogXVideo at 5B with a q4_0 quantization**: https://github.com/kijai/ComfyUI-CogVideoXWrapper/blob/main/examples/cogvidex_fun_5b_GGUF_10GB_VRAM_example_01.json
**i am on 20GB**
```bash
Closest bucket size: 672x384
!!! Exception during processing !!! HIP out of memory. Tried to allocate 6.64 GiB. GPU 0 has a total capacity of 19.92 GiB of which 6.22 GiB is free. Of the allocated memory 5.34 GiB is allocated by PyTorch, and 7.10 GiB is reserved by PyTorch but unallocated. If reserved but unallocated memory is large try setting PYTORCH_HIP_ALLOC_CONF=expandable_segments:True to avoid fragmentation. See documentation for Memory Management (https://pytorch.org/docs/stable/notes/cuda.html#environment-variables)
Traceback (most recent call last):
File "/home/musclez/ComfyUI/execution.py", line 323, in execute
output_data, output_ui, has_subgraph = get_output_data(obj, input_data_all, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/musclez/ComfyUI/execution.py", line 198, in get_output_data
return_values = _map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/musclez/ComfyUI/custom_nodes/ComfyUI-0246/utils.py", line 353, in new_func
res_value = old_func(*final_args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/musclez/ComfyUI/execution.py", line 169, in _map_node_over_list
process_inputs(input_dict, i)
File "/home/musclez/ComfyUI/execution.py", line 158, in process_inputs
results.append(getattr(obj, func)(**inputs))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/musclez/ComfyUI/custom_nodes/ComfyUI-CogVideoXWrapper/nodes.py", line 1125, in process
latents = pipe(
^^^^^
File "/home/musclez/.venv/lib/python3.11/site-packages/torch/utils/_contextlib.py", line 116, in decorate_context
return func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "/home/musclez/ComfyUI/custom_nodes/ComfyUI-CogVideoXWrapper/cogvideox_fun/pipeline_cogvideox_inpaint.py", line 812, in __call__
_, masked_video_latents = self.prepare_mask_latents(
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/musclez/ComfyUI/custom_nodes/ComfyUI-CogVideoXWrapper/cogvideox_fun/pipeline_cogvideox_inpaint.py", line 398, in prepare_mask_latents
mask_pixel_values_bs = self.vae.encode(mask_pixel_values_bs)[0]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/musclez/.venv/lib/python3.11/site-packages/diffusers/utils/accelerate_utils.py", line 46, in wrapper
return method(self, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/musclez/ComfyUI/custom_nodes/ComfyUI-CogVideoXWrapper/cogvideox_fun/autoencoder_magvit.py", line 1114, in encode
z_intermediate = self.encoder(z_intermediate)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/musclez/.venv/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1553, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/musclez/.venv/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1562, in _call_impl
return forward_call(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/musclez/ComfyUI/custom_nodes/ComfyUI-CogVideoXWrapper/cogvideox_fun/autoencoder_magvit.py", line 733, in forward
hidden_states = down_block(hidden_states, temb, None)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/musclez/.venv/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1553, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/musclez/.venv/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1562, in _call_impl
return forward_call(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/musclez/ComfyUI/custom_nodes/ComfyUI-CogVideoXWrapper/cogvideox_fun/autoencoder_magvit.py", line 409, in forward
hidden_states = resnet(hidden_states, temb, zq)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/musclez/.venv/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1553, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/musclez/.venv/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1562, in _call_impl
return forward_call(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/musclez/ComfyUI/custom_nodes/ComfyUI-CogVideoXWrapper/cogvideox_fun/autoencoder_magvit.py", line 291, in forward
hidden_states = self.conv1(hidden_states)
^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/musclez/.venv/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1553, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/musclez/.venv/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1562, in _call_impl
return forward_call(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/musclez/ComfyUI/custom_nodes/ComfyUI-CogVideoXWrapper/cogvideox_fun/autoencoder_magvit.py", line 144, in forward
output = self.conv(inputs)
^^^^^^^^^^^^^^^^^
File "/home/musclez/.venv/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1553, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/musclez/.venv/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1562, in _call_impl
return forward_call(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/musclez/ComfyUI/custom_nodes/ComfyUI-CogVideoXWrapper/cogvideox_fun/autoencoder_magvit.py", line 64, in forward
return super().forward(input)
^^^^^^^^^^^^^^^^^^^^^^
File "/home/musclez/.venv/lib/python3.11/site-packages/torch/nn/modules/conv.py", line 608, in forward
return self._conv_forward(input, self.weight, self.bias)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/musclez/.venv/lib/python3.11/site-packages/torch/nn/modules/conv.py", line 603, in _conv_forward
return F.conv3d(
^^^^^^^^^
**torch.OutOfMemoryError: HIP out of memory. Tried to allocate 6.64 GiB. GPU 0 has a total capacity of 19.92 GiB of which 6.22 GiB is free. Of the allocated memory 5.34 GiB is allocated by PyTorch, and 7.10 GiB is reserved by PyTorch but unallocated. If reserved but unallocated memory is large try setting PYTORCH_HIP_ALLOC_CONF=expandable_segments:True to avoid fragmentation. See documentation for Memory Management (https://pytorch.org/docs/stable/notes/cuda.html#environment-variables)**
Got an OOM, unloading all loaded models.
Prompt executed in 98.44 seconds
```
### Versions
```bash
ROCM_PATH=/opt/rocm python collect_env.py
Collecting environment information...
/home/musclez/.venv/lib/python3.11/site-packages/torch/cuda/__init__.py:641: UserWarning: Can't initialize amdsmi - Error code: 34
warnings.warn(f"Can't initialize amdsmi - Error code: {e.err_code}")
PyTorch version: 2.4.1+rocm6.1
Is debug build: False
CUDA used to build PyTorch: N/A
ROCM used to build PyTorch: 6.1.40091-a8dbc0c19
OS: Ubuntu 22.04.5 LTS (x86_64)
GCC version: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
Clang version: Could not collect
CMake version: version 3.30.4
Libc version: glibc-2.35
Python version: 3.11.10 (main, Sep 7 2024, 18:35:41) [GCC 11.4.0] (64-bit runtime)
Python platform: Linux-5.15.153.1-microsoft-standard-WSL2-x86_64-with-glibc2.35
Is CUDA available: True
CUDA runtime version: 11.8.89
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration: AMD Radeon RX 7900 XT (gfx1100)
Nvidia driver version: Could not collect
cuDNN version: Could not collect
HIP runtime version: 6.1.40091
MIOpen runtime version: 3.1.0
Is XNNPACK available: True
CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 48 bits physical, 48 bits virtual
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: AuthenticAMD
Model name: AMD Ryzen 7 7800X3D 8-Core Processor
CPU family: 25
Model: 97
Thread(s) per core: 2
Core(s) per socket: 8
Socket(s): 1
Stepping: 2
BogoMIPS: 8384.10
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl tsc_reliable nonstop_tsc cpuid extd_apicid pni pclmulqdq ssse3 fma cx16 sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm cmp_legacy svm cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw topoext perfctr_core ssbd ibrs ibpb stibp vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid avx512f avx512dq rdseed adx smap avx512ifma clflushopt clwb avx512cd sha_ni avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves avx512_bf16 clzero xsaveerptr arat npt nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold v_vmsave_vmload avx512vbmi umip avx512_vbmi2 gfni vaes vpclmulqdq avx512_vnni avx512_bitalg avx512_vpopcntdq rdpid fsrm
Virtualization: AMD-V
Hypervisor vendor: Microsoft
Virtualization type: full
L1d cache: 256 KiB (8 instances)
L1i cache: 256 KiB (8 instances)
L2 cache: 8 MiB (8 instances)
L3 cache: 96 MiB (1 instance)
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Mitigation; safe RET
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl and seccomp
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Retpolines, IBPB conditional, IBRS_FW, STIBP conditional, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Not affected
Versions of relevant libraries:
[pip3] alias-free-torch==0.0.6
[pip3] audio-diffusion-pytorch==0.1.3
[pip3] clip-anytorch==2.6.0
[pip3] dctorch==0.1.2
[pip3] ema-pytorch==0.2.3
[pip3] mypy-extensions==1.0.0
[pip3] numpy==1.26.4
[pip3] onnx==1.16.0
[pip3] onnxruntime==1.19.2
[pip3] onnxruntime-gpu==1.19.2
[pip3] open_clip_torch==2.26.1
[pip3] pytorch-lightning==2.1.0
[pip3] pytorch-triton==3.0.0
[pip3] pytorch-triton-rocm==3.0.0
[pip3] rapidocr-onnxruntime==1.3.24
[pip3] sensevoice-onnx==1.1.0
[pip3] torch==2.4.1+rocm6.1
[pip3] torch-stoi==0.2.2
[pip3] torchaudio==2.4.1+rocm6.1
[pip3] torchdiffeq==0.2.4
[pip3] torchlibrosa==0.1.0
[pip3] torchmetrics==1.4.0
[pip3] torchsde==0.2.6
[pip3] torchvision==0.19.1+rocm6.1
[pip3] triton==3.0.0
[pip3] v-diffusion-pytorch==0.0.2
[pip3] vector-quantize-pytorch==1.9.14
[conda] Could not collect
```
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd | module: rocm,module: memory usage,triaged | low | Critical |
2,589,536,724 | PowerToys | CTRL key stops working periodically | ### Microsoft PowerToys version
0.85.1
### Installation method
PowerToys auto-update
### Running as admin
No
### Area(s) with issue?
Keyboard Manager
### Steps to reproduce
[PowerToysReport_2024-10-15-19-09-17.zip](https://github.com/user-attachments/files/17382827/PowerToysReport_2024-10-15-19-09-17.zip)
Sometimes after using a while typing 30 min to 1 hour, the CTRL key stops to work properly. You press CTRL S to save, and the S character is printed in the screen. CTRL A does not select all text, and prints a A character in the screen. Any CTRL combination stops working.
The workaround seems to be turn off keyboard manager and turn on again.
current settings 👇
It is not related to my keyboard, I tested in two different laptops and two different keyboards, the issue happens periodically.
### ✔️ Expected Behavior
CTRL + any key should perform its corresponding action in a chosen software
### ❌ Actual Behavior
The CTRL is ignored and the next key is sent to the software
### Other Software
Any software, including this form in Edge browser. You can also check this in Visual Code.
[Window Title]
Visual Studio Code
[Main Instruction]
Visual Studio Code
[Content]
Version: 1.94.2 (user setup)
Commit: 384ff7382de624fb94dbaf6da11977bba1ecd427
Date: 2024-10-09T16:08:44.566Z (6 days ago)
Electron: 30.5.1
ElectronBuildId: 10262041
Chromium: 124.0.6367.243
Node.js: 20.16.0
V8: 12.4.254.20-electron.0
OS: Windows_NT x64 10.0.22631
[Copy] [OK] | Issue-Bug,Needs-Triage | low | Minor |
2,589,539,971 | pytorch | Make SkipFiles graph breaks actionable | internal x-ref: https://fb.workplace.com/groups/1075192433118967/posts/1520479595256913/
If a user hits a graph break due to a skipfiles thing, they don't know what to do. We should (1) make the error message better, and (2) maybe we can even give the users an API that forces dynamo to trace through a function (instead of skipping it).
cc @ezyang @chauhang @penguinwu @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @amjames @rec | triaged,oncall: pt2,module: dynamo | low | Critical |
2,589,565,846 | Python | Hollow diamond alphabets pattern | ### Feature description
Add the hollow_diamond_alphabet function, which prints a hollow diamond pattern using uppercase alphabet characters based on the specified size. The parameter n determines the number of rows in the diamond. This function uses spaces for alignment and hollow spaces within the diamond structure, creating a visually appealing output.
Please assigned to me. I want to add this pattern in this repo and also please give the tags gccos and hactoberfest | enhancement | medium | Minor |
2,589,602,797 | material-ui | Pigment CSS is 16.2KB gzipped JavaScript in MUI’s example app | ### Steps to reproduce
[Link to live example](https://github.com/o-alexandrov/material-ui-pigment-css-vite-ts)
Steps:
1. Clone the repo (it's exactly the same as the vite [example from this repo](https://github.com/mui/material-ui/tree/master/apps/pigment-css-vite-app))
- I just added `rollup-plugin-visualizer` so you could visualize the resulting bundle
2. Bundle `npm run build`
3. Your browser will open automatically with the result from `rollup-plugin-visualizer` (see example below)
<img width="1728" alt="Screenshot 2024-10-15 at 1 41 25 PM" src="https://github.com/user-attachments/assets/f0cecc4a-2d4f-4d10-b61d-0de7ab0c6fb4">
### Current behavior
- emotion is still in the final bundle, but takes less space (as expected) 2.32KB gzipped
- `zero-runtime-theme.js` is 7.16KB gzipped
- `@pigment-css/react/build` is 6.74KB gzipped
Total: 16.22KB gzipped
### Expected behavior
Smaller JavaScript footprint
### Context
We should evaluate the runtime implications of some PigmentCSS' API usage, such as: `styled` that results in extra JS output
### Your environment
<details>
<summary><code>npx @mui/envinfo</code></summary>
```
System:
OS: macOS 15.0.1
Binaries:
Node: 22.9.0 - /opt/homebrew/bin/node
npm: 10.8.3 - /opt/homebrew/bin/npm
pnpm: 9.9.0 - /opt/homebrew/bin/pnpm
Browsers:
Chrome: 129.0.6668.91
Edge: 112.0.1722.39
Safari: 18.0.1
npmPackages:
@emotion/react: 11.13.3
@emotion/styled: 11.13.0
@mui/core-downloads-tracker: 6.1.3
@mui/material: latest => 6.1.3
@mui/material-pigment-css: latest => 6.1.3
@mui/private-theming: 6.1.3
@mui/styled-engine: 6.1.3
@mui/system: 6.1.3
@mui/types: 7.2.18
@mui/utils: 6.1.3
@pigment-css/react: 0.0.24
@pigment-css/vite-plugin: latest => 0.0.24
@types/react: latest => 18.3.11
react: latest => 18.3.1
react-dom: latest => 18.3.1
typescript: latest => 5.6.3
```
</details>
**Search keywords**: pigmentcss, pigment, bundling, final, emotion, zero runtime | performance,package: pigment-css | low | Major |
2,589,620,116 | three.js | LineSegments2 raycast bug | ### Description
When a `LineSegments2` object is rendered off the screen, the `LineMaterial.resolution` variable doesn't get updated until the `onBeforeRender` function is run. This causes raycasters to intersect with the lines incorrectly even when they are not on the screen. It gets resolved once you pan to the line since the `resolution` gets updated.
### Reproduction steps
1. Render a line outside of camera view
2. If your app has some picking logic that highlights a line that is selected, click anywhere on the screen.
3. Once you pan to the line, you will see that it is highlighted.
### Code
```js
// code goes here
```
### Live example
* [jsfiddle-latest-release WebGLRenderer](https://jsfiddle.net/3mrkqyea/)
* [jsfiddle-dev WebGLRenderer](https://jsfiddle.net/gcqx26jv/)
* [jsfiddle-latest-release WebGPURenderer](https://jsfiddle.net/8L2jkmx7/)
* [jsfiddle-dev WebGPURenderer](https://jsfiddle.net/L3n1w4yh/)
Don't have a live example I can provide
### Screenshots
_No response_
### Version
0.168.0
### Device
_No response_
### Browser
_No response_
### OS
_No response_ | Addons | low | Critical |
2,589,684,454 | flutter | CupertinoNumericTransition Widget | ### Use case
Since iOS 17, SwiftUI has a built-in way to animate numbers.
This is what it looks like.
There is no built-in way to achieve this in flutter.
### Proposal
Having this transition built into Flutter would be huge for a good UX/UI boost while also easing the switch to Flutter for SwiftUI developers.
Having this as a built in widget will also provide developers a way for their apps to fit even more inside the Apple ecosystem - ensuring apps have the correct fidelity. | c: new feature,framework,a: animation,f: cupertino,c: proposal,P3,team-design,triaged-design | low | Major |
2,589,708,624 | kubernetes | Unable to SSA remove array entry containing nested field with "foreign" owner | ### What happened?
We are in the process of removing a long-time deprecated API version in one of our internal operators. We have done this process before, and are familiar with how it should be done. But since then, we have migrated all our code to use SSA. While this in general has been a pleasant experience, we hit a major issue when our CI/CD pipeline attempted to delete obsolete webhooks from our webhook configuration resources (using SSA). We have both validating and mutating webhooks. The same error was reported for both, and I will use the validating webhook in the following description.
When the pipeline attempts to SSA the webhook configuration, we got the following error:
````
Error from server (Invalid): ValidatingWebhookConfiguration.admissionregistration.k8s.io "application-operator-validating-webhook-configuration" is invalid: [webhooks[2].sideEffects: Required value: must specify one of None, NoneOnDryRun, webhooks[2].clientConfig: Required value: exactly one of url or service is required, webhooks[2].admissionReviewVersions: Required value: must specify one of v1, v1beta1]
````
Pretty cryptic error message, but I am pretty sure this is caused by "foreign" ownership to selected nested fields in the array item that the pipeline is trying to remove, making the item retain with invalid configuration and thus rejected by the SSA. Looking at the managed fields confirms my suspicion:
````yaml
managedFields:
- manager: cert-manager-cainjector
operation: Apply
apiVersion: admissionregistration.k8s.io/v1
time: '2024-09-03T08:00:49Z'
fieldsType: FieldsV1
fieldsV1:
'f:webhooks':
'k:{"name":"v1alpha1-stasjob-validator.stas.statnett.no"}':
.: {}
'f:clientConfig':
'f:caBundle': {}
'f:name': {}
'k:{"name":"v1beta2-application-validator.stas.statnett.no"}':
.: {}
'f:clientConfig':
'f:caBundle': {}
'f:name': {}
'k:{"name":"v1beta2-stasjob-validator.stas.statnett.no"}':
.: {}
'f:clientConfig':
'f:caBundle': {}
'f:name': {}
````
As we use cert-manager to inject the webhook CA bundle, it owns a single nested field in each array item as expected. Note: We have enabled the ServerSideApply feature gate in cert-manager, if that matters.
### What did you expect to happen?
I would expect the obsolete/removed webhook to be removed without error from the array of webhooks in the webhook configuration resource.
### How can we reproduce it (as minimally and precisely as possible)?
There are probably many ways to reproduce this issue. But to reproduce the issue in the same context as us, I would suggest the following:
1. Install cert-manager with mostly default options. We have enabled the c-m ServerSideApply feature gate, but I don't think it matters.
2. Add/update a ValidatingWebhookConfiguration containing at least two webhooks **using SSA**.
3. Create a cert-manager `Certificate` for your webhook.
4. Request injection of webhook CA bundle by cert-manager ca-injector adding an annotation to the VWC: `cert-manager.io/inject-ca-from: $(CERTIFICATE_NAMESPACE)/$(CERTIFICATE_NAME)`
5. Wait for cert-manager to reconcile the VWC (`caBundle` should be injected)
6. Attempt to remove one of the webhooks from the VMC, still **using SSA**:
### Anything else we need to know?
This issue was initially raised on sig-api-machinery Slack: https://kubernetes.slack.com/archives/C0EG7JC6T/p1728996348284339
It is also worth mentioning that a temporary rollback to use client-side apply (a.k.a. Update) in our pipeline appears as a workaround for this issue. We successfully used this approach to finalize our removal of the obsolete API version.
### Kubernetes version
<details>
```console
$ kubectl version
Client Version: v1.29.7
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.29.8+632b078
```
</details>
### Cloud provider
<details>
N/A OpenShift on VMWare
</details>
### OS version
<details>
N/A RCOS (OpenShift)
</details>
### Install tools
<details>
N/A
</details>
### Container runtime (CRI) and version (if applicable)
<details>
N/A
</details>
### Related plugins (CNI, CSI, ...) and versions (if applicable)
<details>
N/A
</details>
| kind/bug,sig/api-machinery,triage/accepted | low | Critical |
2,589,737,097 | Python | Add Ridge Regression to Machine Learning | ### Feature description
###Feature: Ridge Regression with Regularization
### **Description**:
The program implements Ridge Regression, a type of linear regression that includes an L2 regularization term to prevent overfitting and improve generalization. It uses gradient descent to optimize the feature vector (weights) while adjusting for a regularization parameter (λλ). The program collects a dataset containing Average Damage per Round (ADR) and player ratings from a CSV file, processes the data, and fits a ridge regression model to find the best-fit line that predicts ADR based on player ratings.
### Key Components:
- **Data Collection:**
- The program fetches a dataset from a remote CSV file containing player ratings and their corresponding Average Damage per Round (ADR).
- **Feature Vector Initialization:**
- Initializes a feature vector (θθ) to zero, representing the weights for the regression model.
- Gradient Descent Optimization:
- Implements steep gradient descent to update the feature vector based on the calculated gradients, ensuring convergence to the optimal weights.
- Regularization:
- Applies L2 regularization to the gradient updates to penalize larger weights, enhancing model robustness against overfitting.
- Error Calculation:
- Computes the sum of square errors to evaluate model performance and adjusts the feature vector iteratively.
- Mean Absolute Error Calculation:
- Adds a utility to compute mean absolute error between predicted and actual outcomes, providing insight into model accuracy.
-Result Output:
- Displays the resultant feature vector, which represents the optimized weights for predicting ADR based on player ratings.
### Benefits:
- **Improved Generalization:** By incorporating regularization, the model can generalize better to unseen data
- **Flexibility:** Users can adjust the regularization parameter (λλ) to balance between fitting the training data and avoiding overfitting.
This feature enhances the program's capability to predict player performance metrics while providing a clear mechanism for controlling overfitting through regularization. | enhancement | medium | Critical |
2,589,737,903 | godot | Labels with Emojis | ### Tested versions
Reproducible in 4.4 dev 3 (mono), 4.3 stable (mono), 4.0 stable (standard)
### System information
Godot v4.3.stable.mono - Windows 10.0.22631 - GLES3 (Compatibility) - NVIDIA GeForce RTX 4070 (NVIDIA; 32.0.15.6094) - 13th Gen Intel(R) Core(TM) i5-13600K (20 Threads)
### Issue description
Labels that only contain emojis are shifted upwards by some amount. When including some normal characters like "a" or "this is good :)", it goes back to the expected behaviour.
### Steps to reproduce
1. Create a label as a child of a control and only include emojis. Notice how the text is not centred as expected.
2. Add a character on your keyboard. It will go back down!
### Minimal reproduction project (MRP)
[label-issue.zip](https://github.com/user-attachments/files/17384205/label-issue.zip)
| discussion,topic:gui | low | Minor |
2,589,764,282 | flutter | [web] The future of `flutter_service_worker.js` | ### Document Link
https://flutter.dev/go/web-cleanup-service-worker
### What problem are you solving?
The current default service worker implementation is one of (several) approaches that can be used by Flutter web, however it's not a good fit for all use-cases.
This confuses users when it doesn't behave as they expect.
Having a default service worker implementation sends the message that it is *necessary* or *recommended* by Flutter web to function correctly, but that is not the case.
This design doc discusses how the current implementation of `flutter_service_worker.js` is going to be phased out (TL;DR: with a cleanup service worker for those currently using the default one), and how the flutter tools and flutter.js will eventually stop generating (or loading) a default service worker, allowing web app developers to do what's best for their specific apps. | platform-web,P1,design doc,team-web,triaged-web,:scroll: | medium | Critical |
2,589,779,158 | PowerToys | [PowerRename] Indicate when search field includes leading whitespace | ### Description of the new feature / enhancement
In a recent bug report, the user had accidentally copied in a string with a leading space, resulting in no matches being shown (see #35325). This sort of error is very difficult to spot, so it may be useful to show an informational message in the results area when there are no matches and there is leading whitespace in the search term.
There could be some nuance here. For example, should the message always be shown if there is leading whitespace, or only where there would be matches without it being present?
### Scenario when this would be used?
This would prevent copy-and-paste issues and would be especially useful for those unfamiliar with the tool.
### Supporting information
_No response_ | Needs-Triage | low | Critical |
2,589,792,491 | material-ui | PigmentCSS `createTheme`. Invalid typings in `styleOverrides` | ### Steps to reproduce
[Link to live example](https://github.com/o-alexandrov/material-ui-pigment-css-vite-ts)
Steps:
1. Clone
2. Refer to `vite.config.ts`
### Current behavior
`components[string].styleOverrides` has invalid typings.
No typings errors are presented to the user.
### Expected behavior
There should be an error for `styleOverrides.extended` usage in `vite.config.ts` file from the repro.
### Context
- https://github.com/mui/pigment-css/issues/170#issuecomment-2245310638
### Your environment
<details>
<summary><code>npx @mui/envinfo</code></summary>
```
System:
OS: macOS 15.0.1
Binaries:
Node: 22.9.0 - /opt/homebrew/bin/node
npm: 10.8.3 - /opt/homebrew/bin/npm
pnpm: 9.9.0 - /opt/homebrew/bin/pnpm
Browsers:
Chrome: 129.0.6668.91
Edge: 112.0.1722.39
Safari: 18.0.1
npmPackages:
@emotion/react: 11.13.3
@emotion/styled: 11.13.0
@mui/core-downloads-tracker: 6.1.3
@mui/material: latest => 6.1.3
@mui/material-pigment-css: latest => 6.1.3
@mui/private-theming: 6.1.3
@mui/styled-engine: 6.1.3
@mui/system: 6.1.3
@mui/types: 7.2.18
@mui/utils: 6.1.3
@pigment-css/react: 0.0.24
@pigment-css/vite-plugin: latest => 0.0.24
@types/react: latest => 18.3.11
react: latest => 18.3.1
react-dom: latest => 18.3.1
typescript: latest => 5.6.3
```
</details>
**Search keywords**: pigment, styleOverrides, typings, invalid, createTheme | typescript,package: pigment-css | low | Critical |
2,589,829,167 | pytorch | `_disable_byteorder_record` parameter should be added to the doc of `save()` | ### 📚 The doc issue
[The doc](https://pytorch.org/docs/stable/generated/torch.save.html) of `save()` shows its parameters as shown below:
> torch.save(obj, f, pickle_module=pickle, pickle_protocol=DEFAULT_PROTOCOL, _use_new_zipfile_serialization=True)
But `save()` also has `_disable_byteorder_record` parameter according to [the source code](https://pytorch.org/docs/stable/_modules/torch/serialization.html) as shown below:
```python
...
[[docs]](https://pytorch.org/docs/stable/generated/torch.save.html#torch.save)def save(
obj: object,
f: FILE_LIKE,
pickle_module: Any = pickle,
pickle_protocol: int = DEFAULT_PROTOCOL,
_use_new_zipfile_serialization: bool = True,
_disable_byteorder_record: bool = False
) -> None:
...
```
Then, `save()` with `disable_byteorder_record` works as shown below:
```python
import torch
torch.save(obj="Hello World", f="my_project/file1",
_disable_byteorder_record=False)
# ↑ ↑ ↑ ↑ ↑ ↑ ↑ ↑ ↑ ↑ ↑ ↑ ↑ ↑ ↑ ↑
torch.load(f="my_project/file1", weights_only=True)
# 'Hello World'
```
### Suggest a potential alternative/fix
So, `_disable_byteorder_record` parameter should be added to [the doc](https://pytorch.org/docs/stable/generated/torch.save.html) of `save()` as shown below:
> torch.save(obj, f, pickle_module=pickle, pickle_protocol=DEFAULT_PROTOCOL, _use_new_zipfile_serialization=True, _disable_byteorder_record=False)
cc @svekars @brycebortree @sekyondaMeta @mruberry @mikaylagawarecki | module: docs,module: serialization,triaged | low | Minor |
2,589,834,961 | vscode | Make scrolling chat keyboard accessible | Repro:
1. Ask copilot a question with a long response, eg. `explain in detail how a red black tree works`
2. Try scroll to the bottom of the answer with the keyboard only
I wasn't able to figure it out. Here's me trying to with what I intuitively tried:
@meganrogge did you say there a duplicate issue of this? Or just a discussion? | feature-request,panel-chat | low | Minor |
2,589,837,464 | rust | ICE: `encountered type variable` | <!--
[31mICE[0m: Rustc ./a.rs '-Zcrate-attr=feature(unboxed_closures) -ooutputfile -Zdump-mir-dir=dir' 'error: internal compiler error: encountered type variable', 'error: internal compiler error: encountered type variable'
File: /tmp/im/a.rs
-->
auto-reduced (treereduce-rust):
````rust
#![feature(unboxed_closures)]
trait Foo {}
impl<T: Fn<(i32,)>> Foo for T {}
fn baz<T: Foo>(_: T) {}
fn main() {
baz(|x| ());
}
````
original:
````rust
trait Foo {}
impl<T: Fn<(i32,)>> Foo for T {}
fn baz<T: Foo>(_: T) {}
fn main() {
baz(|_| ());
//~^ ERROR implementation of `FnOnce` is not general enough
//~| ERROR implementation of `Fn` is not general enough
baz(|x| ());
//~^ ERROR implementation of `FnOnce` is not general enough
//~| ERROR implementation of `Fn` is not general enough
}
````
Version information
````
rustc 1.84.0-nightly (a0c2aba29 2024-10-15)
binary: rustc
commit-hash: a0c2aba29aa9ea50a7c45c3391dd446f856bef7b
commit-date: 2024-10-15
host: x86_64-unknown-linux-gnu
release: 1.84.0-nightly
LLVM version: 19.1.1
````
Command:
`/home/matthias/.rustup/toolchains/master/bin/rustc -Zcrate-attr=feature(unboxed_closures)`
<!--
Include a backtrace in the code block by setting `RUST_BACKTRACE=1` in your
environment. E.g. `RUST_BACKTRACE=1 cargo build`.
-->
<details><summary><strong>Program output</strong></summary>
<p>
```
warning: unused variable: `x`
--> /tmp/icemaker_global_tempdir.qRMnYYI19Q4z/rustc_testrunner_tmpdir_reporting.nQT3i3c5eog1/mvce.rs:8:10
|
8 | baz(|x| ());
| ^ help: if this is intentional, prefix it with an underscore: `_x`
|
= note: `#[warn(unused_variables)]` on by default
warning: 1 warning emitted
note: no errors encountered even though delayed bugs were created
note: those delayed bugs will now be shown as internal compiler errors
error: internal compiler error: encountered type variable
--> /tmp/icemaker_global_tempdir.qRMnYYI19Q4z/rustc_testrunner_tmpdir_reporting.nQT3i3c5eog1/mvce.rs:8:10
|
8 | baz(|x| ());
| ^
|
note: delayed at compiler/rustc_hir_typeck/src/expr_use_visitor.rs:174:20 - disabled backtrace
--> /tmp/icemaker_global_tempdir.qRMnYYI19Q4z/rustc_testrunner_tmpdir_reporting.nQT3i3c5eog1/mvce.rs:8:10
|
8 | baz(|x| ());
| ^
note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md
note: please make sure that you have updated to the latest nightly
note: rustc 1.84.0-nightly (a0c2aba29 2024-10-15) running on x86_64-unknown-linux-gnu
note: compiler flags: -Z crate-attr=feature(unboxed_closures) -Z dump-mir-dir=dir
query stack during panic:
end of query stack
```
</p>
</details>
<!--
query stack:
-->
@rustbot label +F-unboxed_closures | I-ICE,A-closures,T-compiler,C-bug,F-unboxed_closures,S-bug-has-test | low | Critical |
2,589,844,830 | vscode | Extension detail content escapes editor | See the red part - the scroll bar escapes the editor:
| help wanted,polish,good first issue,extensions | low | Major |
2,589,850,140 | vscode | The chat scroll to bottom button doesn't align with the extension detail scroll to top button | Similar idea but the icon in particular is a different style:
| ux,panel-chat,extensions-editor | low | Major |
2,589,942,900 | flutter | Unpin google_mobile_ads | # Background
`google_mobile_ads` 5.2.0 breaks the builds of Flutter apps: https://github.com/googleads/googleads-mobile-flutter/issues/1193
As a result, the pub autoroller broke the tree (https://github.com/flutter/flutter/issues/156606) until we pinned `google_mobile_ads` to version 5.1.0 (https://github.com/flutter/flutter/pull/156911).
Known problems:
1. `google_mobile_ads` version 5.2.0 [raised the required version of Xcode to 15.3](https://github.com/googleads/googleads-mobile-flutter/issues/1185#issuecomment-2407498420)
2. `google_mobile_ads` version 5.2.0 now contains Swift code. The `platform_views_layout` benchmark app is Objective-C, which causes issues like: https://github.com/flutter/flutter/issues/16049#issuecomment-532476842.
# Work
* [ ] Wait until Flutter CI's Xcode is raised to 15.3 or higher: https://github.com/flutter/flutter/issues/148870
* [ ] Add `use_frameworks!` to `dev/benchmarks/platform_views_layout/ios/Podfile` so that the Objective-C app can use a Swift plugin
* [ ] Unpin `google_mobile_ads`. | platform-ios,P2,team-ios,triaged-ios | low | Minor |
2,589,944,015 | tauri | [bug] multiwebview appears to only render the last child. | ### Describe the bug
Running the multiwebview example with `cargo run --example multiwebview --features unstable` presents me with an application window where only the last child is rendered.
<img width="803" alt="Screenshot 2024-10-15 at 2 58 44 PM" src="https://github.com/user-attachments/assets/9dafa3a9-a41b-4475-b8cd-6ae730f4a05c">
### Reproduction
- `git clone git@github.com:tauri-apps/tauri.git && cd tauri`
- `cargo run --example multiwebview --features unstable`
### Expected behavior
It to render as in the PR: https://github.com/tauri-apps/tauri/pull/8280
### Full `tauri info` output
```text
[✔] Environment
- OS: Mac OS 14.6.1 arm64 (X64)
✔ Xcode Command Line Tools: installed
✔ rustc: 1.81.0 (eeb90cda1 2024-09-04)
✔ cargo: 1.81.0 (2dbb1af80 2024-08-20)
✔ rustup: 1.27.1 (54dd3d00f 2024-04-24)
✔ Rust toolchain: stable-aarch64-apple-darwin (default)
- node: 18.20.3
- pnpm: 9.9.0
- npm: 10.7.0
[-] Packages
- tauri 🦀: 2.0.4
- tauri-build 🦀: 2.0.1
- wry 🦀: 0.46.1
- tao 🦀: 0.30.2
- @tauri-apps/api : not installed!
- @tauri-apps/cli : 2.0.3
[-] Plugins
- tauri-plugin-log 🦀: 2.0.0-rc.2
- @tauri-apps/plugin-log : not installed!
[-] App
- build-type: bundle
- CSP: default-src 'self'; connect-src ipc: http://ipc.localhost
- frontendDist: ["index.html"]
- bundler: Rollup
```
### Stack trace
_No response_
### Additional context
_No response_ | type: bug,status: needs triage,scope: unstable flag | low | Critical |
2,589,952,465 | ollama | Model change hash detection feature | When I download a model and then manually flip a bit or two in the blob, there is no apparent check or complaint that the hash has changed. I've tried both quitting a running ollama prompt that uses the model and restarting it, and stopping and restarting the service. I can of course confirm that the SHA256 does indeed change. This leads me to believe that there is no checksum tests to ensure that the model has not been changed on disk, either accidentally or maliciously, so protection or detection of malicious or compromised models. | feature request | low | Minor |
2,589,988,815 | rust | ICE: `underline_start >= 0 && underline_end >= 0` | <!--
Thank you for finding an Internal Compiler Error! 🧊 If possible, try to provide
a minimal verifiable example. You can read "Rust Bug Minimization Patterns" for
how to create smaller examples.
http://blog.pnkfx.org/blog/2019/11/18/rust-bug-minimization-patterns/
-->
### Code
```Rust
#![feature(generic_assert)]
struct FloatWrapper(f64);
fn main() {
assert!((0.0 / 0.0 >= 0.0) == (FloatWrapper(0.0 / 0.0) >= FloatWrapper(size_of::<u8>, size_of::<u16>, size_of::<usize> as fn() -> usize)))
}
```
### Meta
<!--
If you're using the stable version of the compiler, you should also check if the
bug also exists in the beta or nightly versions.
-->
`rustc --version --verbose`:
```
rustc 1.84.0-nightly (9322d183f 2024-10-14)
binary: rustc
commit-hash: 9322d183f45e0fd5a509820874cc5ff27744a479
commit-date: 2024-10-14
host: x86_64-unknown-linux-gnu
release: 1.84.0-nightly
LLVM version: 19.1.1
```
### Error output
```
error[E0061]: this struct takes 1 argument but 3 arguments were supplied
--> a.rs:5:63
|
5 | assert!((0.0 / 0.0 >= 0.0) == (FloatWrapper(0.0 / 0.0) >= FloatWrapper(size_of::<u8>, size_of::<u16>, size_of::<usize> as fn() -> usize)))
| ^^^^^^^^^^^^ -------------- --------------------------------- unexpected argument #3 of type `fn() -> usize`
| |
| unexpected argument #2 of type `fn() -> usize {std::mem::size_of::<u16>}`
|
note: expected `f64`, found fn item
--> a.rs:5:5
|
5 | assert!((0.0 / 0.0 >= 0.0) == (FloatWrapper(0.0 / 0.0) >= FloatWrapper(size_of::<u8>, size_of::<u16>, size_of::<usize> as fn() -> usize)))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: expected type `f64`
found fn item `fn() -> usize {std::mem::size_of::<u8>}`
note: tuple struct defined here
--> a.rs:2:8
|
2 | struct FloatWrapper(f64);
| ^^^^^^^^^^^^
= note: this error originates in the macro `assert` (in Nightly builds, run with -Z macro-backtrace for more info)
```
<!--
Include a backtrace in the code block by setting `RUST_BACKTRACE=1` in your
environment. E.g. `RUST_BACKTRACE=1 cargo build`.
-->
<details><summary><strong>Backtrace</strong></summary>
<p>
```
thread 'rustc' panicked at compiler/rustc_errors/src/emitter.rs:2074:21:
assertion failed: underline_start >= 0 && underline_end >= 0
stack backtrace:
0: 0x7439ed035e8a - <std::sys::backtrace::BacktraceLock::print::DisplayBacktrace as core::fmt::Display>::fmt::h9d42d62719d070d7
1: 0x7439ed8038ca - core::fmt::write::he7a421eb4c9a9d75
2: 0x7439eea24e11 - std::io::Write::write_fmt::h567af23beaa18959
3: 0x7439ed035ce2 - std::sys::backtrace::BacktraceLock::print::h0f6e88707316b8f0
4: 0x7439ed0381c6 - std::panicking::default_hook::{{closure}}::h51c0a9b7a1b27603
5: 0x7439ed038010 - std::panicking::default_hook::h97535dc250d97546
6: 0x7439ec07ff1f - std[c5cfba72dffabd2d]::panicking::update_hook::<alloc[4954ba58ed17d890]::boxed::Box<rustc_driver_impl[a8f60622b3234adb]::install_ice_hook::{closure#0}>>::{closure#0}
7: 0x7439ed0388d8 - std::panicking::rust_panic_with_hook::h43f7938156b6bea8
8: 0x7439ed038676 - std::panicking::begin_panic_handler::{{closure}}::hdd2070c285bd1cc7
9: 0x7439ed036339 - std::sys::backtrace::__rust_end_short_backtrace::hfdc9b232972de0bd
10: 0x7439ed03836c - rust_begin_unwind
11: 0x7439ea9edb00 - core::panicking::panic_fmt::h283601b5555cf015
12: 0x7439ea59e6bc - core::panicking::panic::hd6ba05c5efd2c5a1
13: 0x7439ee4bcbf0 - <rustc_errors[de2df449d029e931]::emitter::HumanEmitter>::emit_messages_default
14: 0x7439ee4aff87 - <rustc_errors[de2df449d029e931]::emitter::HumanEmitter as rustc_errors[de2df449d029e931]::emitter::Emitter>::emit_diagnostic
15: 0x7439ee4ccc4f - <rustc_errors[de2df449d029e931]::DiagCtxtInner>::emit_diagnostic::{closure#3}
16: 0x7439ee4f7e2c - rustc_interface[fc73b2d9c9b6253e]::callbacks::track_diagnostic::<core[7b8e24222d1ccc75]::option::Option<rustc_span[fc5c94e8eafc8ab3]::ErrorGuaranteed>>
17: 0x7439ee4f6965 - <rustc_errors[de2df449d029e931]::DiagCtxtInner>::emit_diagnostic
18: 0x7439ee4f681f - <rustc_errors[de2df449d029e931]::DiagCtxtHandle>::emit_diagnostic
19: 0x7439ee9f884b - <rustc_span[fc5c94e8eafc8ab3]::ErrorGuaranteed as rustc_errors[de2df449d029e931]::diagnostic::EmissionGuarantee>::emit_producing_guarantee
20: 0x7439ec3b1733 - <rustc_hir_typeck[14722519427fb7a4]::fn_ctxt::FnCtxt>::report_arg_errors
21: 0x7439e9fb7139 - <rustc_hir_typeck[14722519427fb7a4]::fn_ctxt::FnCtxt>::confirm_builtin_call
22: 0x7439ee283639 - <rustc_hir_typeck[14722519427fb7a4]::fn_ctxt::FnCtxt>::check_expr_with_expectation_and_args
23: 0x7439ed8cacc7 - <rustc_hir_typeck[14722519427fb7a4]::fn_ctxt::FnCtxt>::check_overloaded_binop
24: 0x7439ee285882 - <rustc_hir_typeck[14722519427fb7a4]::fn_ctxt::FnCtxt>::check_expr_with_expectation_and_args
25: 0x7439ed8ca467 - <rustc_hir_typeck[14722519427fb7a4]::fn_ctxt::FnCtxt>::check_overloaded_binop
26: 0x7439ee285882 - <rustc_hir_typeck[14722519427fb7a4]::fn_ctxt::FnCtxt>::check_expr_with_expectation_and_args
27: 0x7439ee286b58 - <rustc_hir_typeck[14722519427fb7a4]::fn_ctxt::FnCtxt>::check_expr_with_expectation_and_args
28: 0x7439e9fb013f - <rustc_hir_typeck[14722519427fb7a4]::fn_ctxt::FnCtxt>::confirm_builtin_call
29: 0x7439ee283639 - <rustc_hir_typeck[14722519427fb7a4]::fn_ctxt::FnCtxt>::check_expr_with_expectation_and_args
30: 0x7439ee285fb2 - <rustc_hir_typeck[14722519427fb7a4]::fn_ctxt::FnCtxt>::check_expr_with_expectation_and_args
31: 0x7439ee285a43 - <rustc_hir_typeck[14722519427fb7a4]::fn_ctxt::FnCtxt>::check_expr_with_expectation_and_args
32: 0x7439ee27ddca - <rustc_hir_typeck[14722519427fb7a4]::fn_ctxt::FnCtxt>::check_block_with_expected
33: 0x7439ee283f68 - <rustc_hir_typeck[14722519427fb7a4]::fn_ctxt::FnCtxt>::check_expr_with_expectation_and_args
34: 0x7439ee27ddca - <rustc_hir_typeck[14722519427fb7a4]::fn_ctxt::FnCtxt>::check_block_with_expected
35: 0x7439ee283f68 - <rustc_hir_typeck[14722519427fb7a4]::fn_ctxt::FnCtxt>::check_expr_with_expectation_and_args
36: 0x7439ee24dd84 - rustc_hir_typeck[14722519427fb7a4]::check::check_fn
37: 0x7439ee242257 - rustc_hir_typeck[14722519427fb7a4]::typeck
38: 0x7439ee241bd3 - rustc_query_impl[d7a38008b76d7199]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[d7a38008b76d7199]::query_impl::typeck::dynamic_query::{closure#2}::{closure#0}, rustc_middle[7cb4f182f827e3bf]::query::erase::Erased<[u8; 8usize]>>
39: 0x7439edc6cf3a - rustc_query_system[65a76ee4bff6a1cf]::query::plumbing::try_execute_query::<rustc_query_impl[d7a38008b76d7199]::DynamicConfig<rustc_query_system[65a76ee4bff6a1cf]::query::caches::VecCache<rustc_span[fc5c94e8eafc8ab3]::def_id::LocalDefId, rustc_middle[7cb4f182f827e3bf]::query::erase::Erased<[u8; 8usize]>>, false, false, false>, rustc_query_impl[d7a38008b76d7199]::plumbing::QueryCtxt, false>
40: 0x7439edc6bc8d - rustc_query_impl[d7a38008b76d7199]::query_impl::typeck::get_query_non_incr::__rust_end_short_backtrace
41: 0x7439edc6b907 - <rustc_middle[7cb4f182f827e3bf]::hir::map::Map>::par_body_owners::<rustc_hir_analysis[d2a803a74dc0eae7]::check_crate::{closure#4}>::{closure#0}
42: 0x7439edc6981b - rustc_hir_analysis[d2a803a74dc0eae7]::check_crate
43: 0x7439edc66257 - rustc_interface[fc73b2d9c9b6253e]::passes::run_required_analyses
44: 0x7439ee67e99e - rustc_interface[fc73b2d9c9b6253e]::passes::analysis
45: 0x7439ee67e971 - rustc_query_impl[d7a38008b76d7199]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[d7a38008b76d7199]::query_impl::analysis::dynamic_query::{closure#2}::{closure#0}, rustc_middle[7cb4f182f827e3bf]::query::erase::Erased<[u8; 1usize]>>
46: 0x7439ee6d7bee - rustc_query_system[65a76ee4bff6a1cf]::query::plumbing::try_execute_query::<rustc_query_impl[d7a38008b76d7199]::DynamicConfig<rustc_query_system[65a76ee4bff6a1cf]::query::caches::SingleCache<rustc_middle[7cb4f182f827e3bf]::query::erase::Erased<[u8; 1usize]>>, false, false, false>, rustc_query_impl[d7a38008b76d7199]::plumbing::QueryCtxt, false>
47: 0x7439ee6d78cf - rustc_query_impl[d7a38008b76d7199]::query_impl::analysis::get_query_non_incr::__rust_end_short_backtrace
48: 0x7439ee5818de - rustc_interface[fc73b2d9c9b6253e]::interface::run_compiler::<core[7b8e24222d1ccc75]::result::Result<(), rustc_span[fc5c94e8eafc8ab3]::ErrorGuaranteed>, rustc_driver_impl[a8f60622b3234adb]::run_compiler::{closure#0}>::{closure#1}
49: 0x7439ee630294 - std[c5cfba72dffabd2d]::sys::backtrace::__rust_begin_short_backtrace::<rustc_interface[fc73b2d9c9b6253e]::util::run_in_thread_with_globals<rustc_interface[fc73b2d9c9b6253e]::util::run_in_thread_pool_with_globals<rustc_interface[fc73b2d9c9b6253e]::interface::run_compiler<core[7b8e24222d1ccc75]::result::Result<(), rustc_span[fc5c94e8eafc8ab3]::ErrorGuaranteed>, rustc_driver_impl[a8f60622b3234adb]::run_compiler::{closure#0}>::{closure#1}, core[7b8e24222d1ccc75]::result::Result<(), rustc_span[fc5c94e8eafc8ab3]::ErrorGuaranteed>>::{closure#0}, core[7b8e24222d1ccc75]::result::Result<(), rustc_span[fc5c94e8eafc8ab3]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[7b8e24222d1ccc75]::result::Result<(), rustc_span[fc5c94e8eafc8ab3]::ErrorGuaranteed>>
50: 0x7439ee6306a8 - <<std[c5cfba72dffabd2d]::thread::Builder>::spawn_unchecked_<rustc_interface[fc73b2d9c9b6253e]::util::run_in_thread_with_globals<rustc_interface[fc73b2d9c9b6253e]::util::run_in_thread_pool_with_globals<rustc_interface[fc73b2d9c9b6253e]::interface::run_compiler<core[7b8e24222d1ccc75]::result::Result<(), rustc_span[fc5c94e8eafc8ab3]::ErrorGuaranteed>, rustc_driver_impl[a8f60622b3234adb]::run_compiler::{closure#0}>::{closure#1}, core[7b8e24222d1ccc75]::result::Result<(), rustc_span[fc5c94e8eafc8ab3]::ErrorGuaranteed>>::{closure#0}, core[7b8e24222d1ccc75]::result::Result<(), rustc_span[fc5c94e8eafc8ab3]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[7b8e24222d1ccc75]::result::Result<(), rustc_span[fc5c94e8eafc8ab3]::ErrorGuaranteed>>::{closure#1} as core[7b8e24222d1ccc75]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
51: 0x7439ee63116b - std::sys::pal::unix::thread::Thread::new::thread_start::h1588e535d4be38db
52: 0x7439efd8a39d - <unknown>
53: 0x7439efe0f49c - <unknown>
54: 0x0 - <unknown>
error: the compiler unexpectedly panicked. this is a bug.
note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md
note: please make sure that you have updated to the latest nightly
note: please attach the file at `/tmp/im/rustc-ice-2024-10-15T21_38_35-464516.txt` to your bug report
query stack during panic:
#0 [typeck] type-checking `main`
#1 [analysis] running analysis passes on this crate
end of query stack
error: aborting due to 1 previous error
For more information about this error, try `rustc --explain E0061`.
```
</p>
</details>
| A-diagnostics,I-ICE,T-compiler,C-bug,S-bug-has-test,F-generic_assert | low | Critical |
2,589,999,825 | three.js | Postprocessing: Add SSILVB GI and AO | ## [Current Demo](https://raw.githack.com/zalo/three.js/feat-ssilvb-gtvbao/examples/webgl_postprocessing_ssilvb.html)
### Description
Recent advances in screen-space global illumination have yielded exceptional improvements to the realism and quality of real-time scenes, even over GTAO. One particular advancement is SSILVB, a screen-space global illumination technique that eases the computational burden by keeping track of the occluded horizon via a bitmask (allowing elements in the scene to have finite thickness and for more samples to be collected).
### Solution
There are three MIT-Licensed implementations:
- https://github.com/cdrinmatane/SSRT3
- - [Blog Post](https://cdrinmatane.github.io/posts/ssaovb-code/)
- - [Slides here](https://cdrinmatane.github.io/cgspotlight-slides/ssilvb_slides.pdf)
- https://cybereality.com/screen-space-indirect-lighting-with-visibility-bitmask-improvement-to-gtao-ssao-real-time-ambient-occlusion-algorithm-glsl-shader-implementation/
- https://www.shadertoy.com/view/dsGBzW
I have a flawed attempt at porting @cybereality 's here onto @Rabbid76's GTAO ( it's flawed because the samples seem unbalanced; AO-only, no illumination):
https://raw.githack.com/zalo/three.js/feat-ssilvb/examples/webgl_postprocessing_ssilvb.html
### Alternatives
For reference, compare to [the existing GTAO algorithm](https://threejs.org/examples/?q=ao#webgl_postprocessing_gtao), which exhibits:
- Short range / Garish contrast
- No indirect illumination
- No shadows
### Additional context
These noisy GI techniques may benefit from screen-space temporal accumulation as well... But this is a request for another issue 😄 | Post-processing | medium | Critical |
2,590,011,779 | TypeScript | Infinite type instantiation around recursive conditional types | ### 🔎 Search Terms
infinite type instantiation excessively deep recursive conditional
### 🕗 Version & Regression Information
- This is the behavior in every version I tried, and I reviewed the FAQ for entries about infinite and recursive types.
### ⏯ Playground Link
https://www.typescriptlang.org/play/?ts=5.6.3#code/C4TwDgpgBAggPARQDRQMoD4oF4oKhAD2AgDsATAZygG8oBDALnpJCgF8oB+WRAbQCI6-ALooMUJiQgA3CACcA3ACglASxLE5AMzoBjaACE4AFUzUlUKFsToAFAEcmCAJRN4yKKeVsVoSFABhbCgjajZMQmJyKiN1LXkoAA1MbkSJKClZRV9waDScIMjSSmZWbmA5AFdoJh0AGwoIZSA
### 💻 Code
```ts
type A<Q, S> = Q extends { a: any } ? A<Q["a"], S> : never;
interface B<T> {
f<Q>(q: Q): A<Q, T>;
}
type C = B<{}> extends B<infer X> ? X : never;
type X = C extends any ? true : false;
// ~ Type instantiation is excessively deep and possibly infinite.(2589)
```
### 🙁 Actual behavior
The last line errors out.
### 🙂 Expected behavior
The code should pass the type check.
### Additional information about the issue
An alternative way to get the same error: https://www.typescriptlang.org/play/?ts=5.6.3#code/C4TwDgpgBAggPARQDRQMoD4oF4oKhAD2AgDsATAZygG8oBDALnpJCgF8oB+WRAbQCI6-ALooMUJiQgA3CACcA3ACglASxLE5AMzoBjaACE4AFUzUlUKFsToAFAEcmCAJRN4yKKeVsVZCLoAbOjloLQBXEl1gVQB7EigAWzoAawgjU1tgJmNXKHT0ZSU-QODQiKjY+OsMrM9c6RjVMkLrI2o2dDsk1INbEjCAgPoqOhZhmjZnZ2UgA | Bug,Help Wanted | low | Critical |
2,590,015,924 | vscode | Allow terminal links to be opened in a web browser | <!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Describe the feature you'd like. -->
In the integrated terminal, links to files can be clickable (ctrl + click) and the respective file will open in the editor. If a link points to a webpage, it will open that page in a web browser. I would like to have the option to choose to open a file in a web browser.
## example
I'm writing a book using jupyter-book and when the build is done, the following is outputted in the terminal:
```
===============================================================================
Finished generating HTML for book.
Your book's HTML pages are here:
book/_build/html/
You can look at your book by opening this file in a browser:
book/_build/html/index.html
Or paste this line directly into your browser bar:
file:///home/rsoko/book/book/_build/html/index.html
===============================================================================
```
if I ctrl+click the last two links, they open in the editor. But I would prefer `file:///home/rsoko/private/IR_book/IR_book/_build/html/index.html` to open in my web browser instead.
## desired outcome
Perhaps an option in `settings.json` with a regex pattern to override the default behavior of choosing between opening in browser or in editor. e.g. `"openFileInBrowser": ["*.html"]`
I'm also okay with interpreting this ticket as a bug, and claiming that all URLs that start with `file://` should be treated as links to be opened in the web browser, rather than in the editor.
| feature-request,terminal-links | low | Critical |
2,590,058,536 | pytorch | Error while exporting `keypointrcnn_resnet50_fpn` | ### 🐛 Describe the bug
Code for reproducing the problem
```
from torchvision.models.detection import keypointrcnn_resnet50_fpn, KeypointRCNN_ResNet50_FPN_Weights
import torch
model = keypointrcnn_resnet50_fpn(weights=KeypointRCNN_ResNet50_FPN_Weights.DEFAULT)
model.eval()
input_frame = torch.randn(1,3, 4898, 3265)
exported_program: torch.export.ExportedProgram= torch.export.export(model, args=(input_frame,), strict=False)
```
Error logs
```
W1015 22:00:17.836165 3292 site-packages/torch/fx/experimental/symbolic_shapes.py:6061] failed during evaluate_expr(4*u1 > 4000, hint=None, size_oblivious=False, forcing_spec=False
E1015 22:00:17.836511 3292 site-packages/torch/fx/experimental/recording.py:298] failed while running evaluate_expr(*(4*u1 > 4000, None), **{'fx_node': False})
Traceback (most recent call last):
File "/home/ubuntu/experiments/export/keyrcnn_pose.py", line 9, in <module>
exported_program: torch.export.ExportedProgram= torch.export.export(model, args=(input_frame,), strict=False)
File "/home/ubuntu/anaconda3/envs/export/lib/python3.10/site-packages/torch/export/__init__.py", line 366, in export
return _export(
File "/home/ubuntu/anaconda3/envs/export/lib/python3.10/site-packages/torch/export/_trace.py", line 1014, in wrapper
raise e
File "/home/ubuntu/anaconda3/envs/export/lib/python3.10/site-packages/torch/export/_trace.py", line 987, in wrapper
ep = fn(*args, **kwargs)
File "/home/ubuntu/anaconda3/envs/export/lib/python3.10/site-packages/torch/export/exported_program.py", line 116, in wrapper
return fn(*args, **kwargs)
File "/home/ubuntu/anaconda3/envs/export/lib/python3.10/site-packages/torch/export/_trace.py", line 1964, in _export
export_artifact = export_func( # type: ignore[operator]
File "/home/ubuntu/anaconda3/envs/export/lib/python3.10/site-packages/torch/export/_trace.py", line 1754, in _non_strict_export
aten_export_artifact = _to_aten_func( # type: ignore[operator]
File "/home/ubuntu/anaconda3/envs/export/lib/python3.10/site-packages/torch/export/_trace.py", line 643, in _export_to_aten_ir
gm, graph_signature = transform(aot_export_module)(
File "/home/ubuntu/anaconda3/envs/export/lib/python3.10/site-packages/torch/export/_trace.py", line 1684, in _aot_export_non_strict
gm, sig = aot_export(wrapped_mod, args, kwargs=kwargs, **flags)
File "/home/ubuntu/anaconda3/envs/export/lib/python3.10/site-packages/torch/_functorch/aot_autograd.py", line 1262, in aot_export_module
fx_g, metadata, in_spec, out_spec = _aot_export_function(
File "/home/ubuntu/anaconda3/envs/export/lib/python3.10/site-packages/torch/_functorch/aot_autograd.py", line 1497, in _aot_export_function
fx_g, meta = create_aot_dispatcher_function(
File "/home/ubuntu/anaconda3/envs/export/lib/python3.10/site-packages/torch/_functorch/aot_autograd.py", line 524, in create_aot_dispatcher_function
return _create_aot_dispatcher_function(
File "/home/ubuntu/anaconda3/envs/export/lib/python3.10/site-packages/torch/_functorch/aot_autograd.py", line 625, in _create_aot_dispatcher_function
fw_metadata = run_functionalized_fw_and_collect_metadata(
File "/home/ubuntu/anaconda3/envs/export/lib/python3.10/site-packages/torch/_functorch/_aot_autograd/collect_metadata_analysis.py", line 194, in inner
flat_f_outs = f(*flat_f_args)
File "/home/ubuntu/anaconda3/envs/export/lib/python3.10/site-packages/torch/_functorch/_aot_autograd/utils.py", line 184, in flat_fn
tree_out = fn(*args, **kwargs)
File "/home/ubuntu/anaconda3/envs/export/lib/python3.10/site-packages/torch/_functorch/_aot_autograd/traced_function_transforms.py", line 863, in functional_call
out = mod(*args[params_len:], **kwargs)
File "/home/ubuntu/anaconda3/envs/export/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1736, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/home/ubuntu/anaconda3/envs/export/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1747, in _call_impl
return forward_call(*args, **kwargs)
File "/home/ubuntu/anaconda3/envs/export/lib/python3.10/site-packages/torch/export/_trace.py", line 1671, in forward
tree_out = mod(*args, **kwargs)
File "/home/ubuntu/anaconda3/envs/export/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1736, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/home/ubuntu/anaconda3/envs/export/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1747, in _call_impl
return forward_call(*args, **kwargs)
File "/home/ubuntu/anaconda3/envs/export/lib/python3.10/site-packages/torchvision/models/detection/generalized_rcnn.py", line 104, in forward
proposals, proposal_losses = self.rpn(images, features, targets)
File "/home/ubuntu/anaconda3/envs/export/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1736, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/home/ubuntu/anaconda3/envs/export/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1747, in _call_impl
return forward_call(*args, **kwargs)
File "/home/ubuntu/anaconda3/envs/export/lib/python3.10/site-packages/torchvision/models/detection/rpn.py", line 373, in forward
boxes, scores = self.filter_proposals(proposals, objectness, images.image_sizes, num_anchors_per_level)
File "/home/ubuntu/anaconda3/envs/export/lib/python3.10/site-packages/torchvision/models/detection/rpn.py", line 289, in filter_proposals
keep = box_ops.batched_nms(boxes, scores, lvl, self.nms_thresh)
File "/home/ubuntu/anaconda3/envs/export/lib/python3.10/site-packages/torchvision/ops/boxes.py", line 72, in batched_nms
if boxes.numel() > (4000 if boxes.device.type == "cpu" else 20000) and not torchvision._is_tracing():
File "/home/ubuntu/anaconda3/envs/export/lib/python3.10/site-packages/torch/__init__.py", line 686, in __bool__
return self.node.bool_()
File "/home/ubuntu/anaconda3/envs/export/lib/python3.10/site-packages/torch/fx/experimental/sym_node.py", line 511, in bool_
return self.guard_bool("", 0)
File "/home/ubuntu/anaconda3/envs/export/lib/python3.10/site-packages/torch/fx/experimental/sym_node.py", line 449, in guard_bool
r = self.shape_env.evaluate_expr(self.expr, self.hint, fx_node=self.fx_node)
File "/home/ubuntu/anaconda3/envs/export/lib/python3.10/site-packages/torch/fx/experimental/recording.py", line 262, in wrapper
return retlog(fn(*args, **kwargs))
File "/home/ubuntu/anaconda3/envs/export/lib/python3.10/site-packages/torch/fx/experimental/symbolic_shapes.py", line 6057, in evaluate_expr
return self._evaluate_expr(
File "/home/ubuntu/anaconda3/envs/export/lib/python3.10/site-packages/torch/fx/experimental/symbolic_shapes.py", line 6207, in _evaluate_expr
raise self._make_data_dependent_error(
torch.fx.experimental.symbolic_shapes.GuardOnDataDependentSymNode: Could not guard on data-dependent expression 4*u1 > 4000 (unhinted: 4*u1 > 4000). (Size-like symbols: u1)
Caused by: (torchvision/ops/boxes.py:72 in batched_nms)
```
### Versions
```
PyTorch version: 2.6.0.dev20241015+cpu
Is debug build: False
CUDA used to build PyTorch: Could not collect
ROCM used to build PyTorch: N/A
OS: Ubuntu 20.04.6 LTS (x86_64)
GCC version: (Ubuntu 9.4.0-1ubuntu1~20.04.2) 9.4.0
Clang version: Could not collect
CMake version: version 3.16.3
Libc version: glibc-2.31
Python version: 3.10.0 | packaged by conda-forge | (default, Nov 20 2021, 02:24:10) [GCC 9.4.0] (64-bit runtime)
Python platform: Linux-5.15.0-1063-aws-x86_64-with-glibc2.31
Is CUDA available: False
CUDA runtime version: 12.1.105
CUDA_MODULE_LOADING set to: N/A
GPU models and configuration: GPU 0: NVIDIA A10G
Nvidia driver version: 535.183.01
cuDNN version: Could not collect
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True
CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 48 bits physical, 48 bits virtual
CPU(s): 8
On-line CPU(s) list: 0-7
Thread(s) per core: 2
Core(s) per socket: 4
Socket(s): 1
NUMA node(s): 1
Vendor ID: AuthenticAMD
CPU family: 23
Model: 49
Model name: AMD EPYC 7R32
Stepping: 0
CPU MHz: 2800.000
BogoMIPS: 5600.00
Hypervisor vendor: KVM
Virtualization type: full
L1d cache: 128 KiB
L1i cache: 128 KiB
L2 cache: 2 MiB
L3 cache: 16 MiB
NUMA node0 CPU(s): 0-7
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Retbleed: Mitigation; untrained return thunk; SMT enabled with STIBP protection
Vulnerability Spec rstack overflow: Mitigation; safe RET
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl and seccomp
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Retpolines; IBPB conditional; STIBP always-on; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Not affected
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl nonstop_tsc cpuid extd_apicid aperfmperf tsc_known_freq pni pclmulqdq ssse3 fma cx16 sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm cmp_legacy cr8_legacy abm sse4a misalignsse 3dnowprefetch topoext ssbd ibrs ibpb stibp vmmcall fsgsbase bmi1 avx2 smep bmi2 rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 clzero xsaveerptr rdpru wbnoinvd arat npt nrip_save rdpid
Versions of relevant libraries:
[pip3] numpy==2.0.2
[pip3] torch==2.6.0.dev20241015+cpu
[pip3] torchvision==0.20.0.dev20241015+cpu
[conda] numpy 2.0.2 pypi_0 pypi
[conda] torch 2.6.0.dev20241015+cpu pypi_0 pypi
[conda] torchvision 0.20.0.dev20241015+cpu pypi_0 pypi
```
cc @ezyang @chauhang @penguinwu @avikchaudhuri @gmagogsfm @zhxchen17 @tugsbayasgalan @angelayi @suo @ydwu4 | oncall: pt2,oncall: export | low | Critical |
2,590,064,658 | godot | AnimationPlayer Node Doesn't Function Correctly with Negative Speed Scale | ### Tested versions
- Found in v4.3.stable.official [77dcf97d8]
- Reproducible in v4.2.2.stable.official [15073afe3]
### System information
Godot v4.3.stable - Linux Mint 22 (Wilma) - X11 - Vulkan (Mobile) - dedicated NVIDIA GeForce RTX 3080 (nvidia; 535.183.01) - AMD Ryzen 9 5900X 12-Core Processor (24 Threads)
### Issue description
The engine documentation states [here](https://docs.godotengine.org/en/stable/classes/class_animationplayer.html#class-animationplayer-property-speed-scale) that setting an AnimationPlayer's speed scale to -1 will play animations in reverse. However, the AnimationPlayer node doesn't utilize speed scale correctly in-editor or at runtime.
While in editor, trying to hit play on an animation within the AnimationPlayer node will do nothing. At runtime, any played animation will snap to its last keyframe.
Potentially related to #88518, but unsure.
### Steps to reproduce
1.) Create new project, and create a 3D scene.
2.) Under the scene root node, add a CSGBox3D and an AnimationPlayer
3.) Create an animation called "move" and set it to autoplay on load.
4.) Animate the CSGBox3D's transformation to move however you wish over one second.
5.) In editor, hit play on "move". Animation will play.
6.) Create a Camera3D node and move it back so it is able to see the CSGBox3D + its move animation.
7.) Run project. Animation should play immediately as long as you enabled autoplay on load.
8.) Stop running project. Select AnimationPlayer and set Speed Scale to -1.
9.) In editor, hit play on "move". Animation will not play.
10.) Run project. CSGBox3D snaps to the last keyframe of "move" instead of playing it in reverse.
### Minimal reproduction project (MRP)
N/A | discussion,documentation,topic:animation | low | Minor |
2,590,214,699 | TypeScript | Changes in JSON files cause stale TS error squiggles in ts/tsx files |
Type: <b>Bug</b>
1. Configure a TS project to allow JSON imports
2. Import a JSON file into a TS/TSX file.
3. Use the type information from the JSON file to infer different types.
4. Change the contents of the JSON file.
5. Navigate back to the TS file.
6. Observe that any TS errors become stale/new errors are not visible. Only restarting the server helps.
VS Code version: Code 1.94.2 (Universal) (384ff7382de624fb94dbaf6da11977bba1ecd427, 2024-10-09T16:08:44.566Z)
OS version: Darwin arm64 24.0.0
Modes:
Remote OS version: Linux arm64 6.8.0-45-generic
<details>
<summary>System Info</summary>
|Item|Value|
|---|---|
|CPUs|Apple M1 (8 x 2400)|
|GPU Status|2d_canvas: enabled<br>canvas_oop_rasterization: enabled_on<br>direct_rendering_display_compositor: disabled_off_ok<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>opengl: enabled_on<br>rasterization: enabled<br>raw_draw: disabled_off_ok<br>skia_graphite: disabled_off<br>video_decode: enabled<br>video_encode: enabled<br>webgl: enabled<br>webgl2: enabled<br>webgpu: enabled<br>webnn: disabled_off|
|Load (avg)|3, 3, 3|
|Memory (System)|16.00GB (0.04GB free)|
|Process Argv|--crash-reporter-id 9e5b74d3-969a-40a2-b2e5-561acacb1e0a|
|Screen Reader|no|
|VM|0%|
|Item|Value|
|---|---|
|Remote|Dev Container: Node.js & GitHub Actions @ 172.16.44.136|
|OS|Linux arm64 6.8.0-45-generic|
|CPUs|unknown (4 x 0)|
|Memory (System)|7.74GB (1.45GB free)|
|VM|0%|
</details><details><summary>Extensions (27)</summary>
Extension|Author (truncated)|Version
---|---|---
better-comments|aar|3.0.2
remote-containers|ms-|0.389.0
remote-ssh|ms-|0.115.0
remote-ssh-edit|ms-|0.87.0
vscode-remote-extensionpack|ms-|0.25.0
remote-explorer|ms-|0.4.3
remote-server|ms-|1.5.2
vscode-speech|ms-|0.10.0
vscode-eslint|dba|3.0.10
gitlens|eam|15.6.1
effect-vscode|eff|0.1.6
auto-run-command|gab|1.6.0
copilot|Git|1.238.0
copilot-chat|Git|0.21.2
vscode-github-actions|git|0.27.0
vscode-pull-request-github|Git|0.98.0
todo-tree|Gru|0.0.226
vscode-docker|ms-|1.29.3
vscode-kubernetes-tools|ms-|1.3.18
resourcemonitor|mut|1.0.7
vscode-yaml|red|1.15.0
preview-vscode|sea|2.3.7
vscode-styled-components|sty|1.7.8
vscode-stylelint|sty|1.4.0
explorer|vit|1.6.0
vscode-css-variables|vun|2.7.1
pretty-ts-errors|Yoa|0.6.0
</details><details>
<summary>A/B Experiments</summary>
```
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805cf:30301675
binariesv615:30325510
vsaa593:30376534
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
962ge761:30959799
pythongtdpath:30769146
pythonnoceb:30805159
asynctok:30898717
pythonmypyd1:30879173
h48ei257:31000450
pythontbext0:30879054
accentitlementst:30995554
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
f3je6385:31013174
a69g1124:31058053
dvdeprecation:31068756
dwnewjupyter:31046869
impr_priority:31102340
nativerepl2:31139839
refactort:31108082
pythonrstrctxt:31112756
wkspc-onlycs-t:31132770
wkspc-ranged-t:31151552
cf971741:31144450
autoexpandse:31146404
iacca2:31156134
notype1:31157159
5fd0e150:31155592
iconenabled:31158251
```
</details>
<!-- generated by issue reporter --> | Bug,Help Wanted | low | Critical |
2,590,264,465 | pytorch | `Calculate Docker Image` step times out if run on LF runners | ### 🐛 Describe the bug
See https://github.com/pytorch/pytorch/actions/runs/11354238493/job/31581094669?pr=137992
Have no idea how to debug something like that, but it finishes in 50 min on our own runners
### Versions
CI
cc @seemethere @pytorch/pytorch-dev-infra | module: ci,triaged | low | Critical |
2,590,277,799 | godot | Lots of errors, temporary file flooding, and unable to create scenes when running Godot through Steam on Steam Deck. | ### Tested versions
v4.3.stable.steam [77dcf97d8]
### System information
Godot v4.3.stable - SteamOS holo - X11 - Vulkan (Forward+) - integrated AMD Custom GPU 0405 (RADV VANGOGH) - AMD Custom APU 0405 (8 Threads)
### Issue description
When I use Godot downloaded through the Steam on Steam Deck (Linux) it floods my project folder with lots of temporary files, is unable to run, and gives errors: [https://pastebin.com/VFttvqcf](https://pastebin.com/VFttvqcf). This doesn't happen when running the Godot Linux download on the website.
### Steps to reproduce
Run the Steam downloaded version of Godot on Steam Deck and create a new project.
### Minimal reproduction project (MRP)
N/A. | platform:linuxbsd,topic:editor,needs testing | low | Critical |
2,590,285,553 | stable-diffusion-webui | [Bug]: wrong Python version for Ubuntu 24.04 | ### Checklist
- [ ] The issue exists after disabling all extensions
- [ ] The issue exists on a clean installation of webui
- [ ] The issue is caused by an extension, but I believe it is caused by a bug in the webui
- [ ] The issue exists in the current version of the webui
- [ ] The issue has not been reported before recently
- [ ] The issue has been reported before but has not been fixed yet
### What happened?
The installation directions say:
sudo apt install python3.10-venv -y
But Python 3.10 is not available through apt for Ubuntu 24.04; the Python version for 24.04 is 3.12. (There is online comment suggesting retro-installing 3.10, but I simply will not do that. If it's important I think you should distribute your own version of Python.)
### Steps to reproduce the problem
N/A
### What should have happened?
N/A
### What browsers do you use to access the UI ?
_No response_
### Sysinfo
N/A
### Console logs
```Shell
N/A
```
### Additional information
_No response_ | bug-report | low | Critical |
2,590,348,775 | go | proposal: x/crypto/x509roots/fallback: export certificate bundle | ### Proposal Details
The `x/crypto/x509roots` package was added in https://github.com/golang/go/issues/43958 and https://github.com/golang/go/issues/57792 (cc @rolandshoemaker @rsc @FiloSottile who were involved in prior discussion).
One feature was discussed in issue https://github.com/golang/go/issues/43958 but did not make it into the package as currently released: accessing the x509 fallback root certificate bundle programmatically, i.e. not just using it for verification in the current process, but e.g. exporting it to a file for later usage by a different process on a different machine.
## Motivation / use-case
In my case, the [gokrazy](https://gokrazy.org/) packer (a Go program) creates a self-contained root file system image to be run (with the Linux kernel) on a Raspberry Pi (or similar), PC or (Cloud or on-prem) VM that only contains other Go programs. A gokrazy root file system contains no C runtime or similar — similar to `FROM scratch` Docker containers.
The gokrazy packer can easily be run on Linux, where we just [copy the system root file](https://github.com/gokrazy/tools/blob/a889f31ae4650cca1db08476a6c879e95beef949/cmd/gokr-packer/cacerts.go#L16) into the resulting image. But on macOS and Windows, we don’t have a system root file that we can copy. That’s where we currently use github.com/breml/rootcerts.
Ideally, we would programmatically create a roots file (at “gokrazy packer time”) that the Go runtime would then load (at “Raspberry Pi run time”).
## Background: Why is the [`x/crypto/x509roots/nss`](https://pkg.go.dev/golang.org/x/crypto/x509roots/nss) parser not sufficient?
One might wonder: Why is the [`x/crypto/x509roots/nss`](https://pkg.go.dev/golang.org/x/crypto/x509roots/nss) parser not sufficient for this use-case?
I originally thought that using nss.Parse might actually make implementing breml/rootcerts easier, but it turns out that breml/rootcerts already uses an approach that does not require nss.Parse: https://github.com/breml/rootcerts/blob/7000414306b0b352acb0de167dc22ebe5a584085/generate_data.go#L34
I considered doing the http.Get in the gokrazy packer, but then my program requires internet access (undesirable, especially when running in isolated CI/CD environments) and can fail when the source is slow or unavailable. So, I’ll need a cached copy and then have to deal with keeping it up-to-date.
Instead of dealing with cache management on my user’s disk, it might be better to obtain the root certs at go:generate time and embed them into my application. But then I’m effectively doing myself the work that breml/rootcerts is currently doing for me, and have not gained anything.
I think the key observation is: *obtaining* the root certs is not the tricky part, but *updating/distributing* the root certs is an annoying problem to solve. If I could just access the fallback store that the x/crypto module already contains, GitHub’s dependabot would from time to time submit a PR to update the x/crypto dependency, and that would be the easiest solution in terms of how much infrastructure I would need to maintain.
## Proposal
Add the following code to x509roots/fallback/fallback.go:
```go
// Bundle returns the fallback X.509 trusted roots as a certificate bundle.
//
// This function is primarily useful for programs that build environments in
// which Go programs should have access to the fallback roots, such as Docker
// containers.
func Bundle() []*x509.Certificate {
return bundle
}
```
https://go.dev/cl/506840 is an implementation of this proposal.
## Open Questions
One open question that came up during the review of https://go.dev/cl/506840:
> > I'm not sure "Bundle() []*x509.Certificate" is the right API for this, for example because of https://go.dev/issue/57178: in the future the bundle in fallback might include constrained roots.
>
> We could rename to UnconstrainedRoots(). Are constrained roots going to be vital to have a functioning certificate store?
>
> (The whole subject of constrained roots is something I’ll need to consider when working with the generator, too, which makes it less appealing to integrate at the generator level.)
| Proposal,Proposal-Crypto | low | Major |
2,590,357,301 | deno | Error when trying to run a jest set of tests panicked at ext\node\global.rs:286:56: called `Option::unwrap()` on a `None` value | Hi guys,
I was trying to run the jest tests of a solution we have at work and I keep getting this consistently.
PS C:\git\wtg\Glow\Glow\DotNet\HTML\Client\Client> deno run test
Task test jest
============================================================
Deno has panicked. This is a bug in Deno. Please report this
at https://github.com/denoland/deno/issues/new.
If you can reliably reproduce this panic, include the
reproduction steps and re-run with the RUST_BACKTRACE=1 env
var set and include the backtrace in your report.
Platform: windows x86_64
Version: 2.0.0
Args: ["C:\\Users\\Jd.Merino\\.deno\\bin\\deno.exe", "run", "--ext=js", "-A", "C:\\git\\wtg\\Glow\\Glow\\DotNet\\HTML\\Client\\Client\\node_modules\\.bin\\../jest/bin/jest.js"]
thread 'main' panicked at ext\node\global.rs:286:56:
called `Option::unwrap()` on a `None` value
stack backtrace:
0: 0x7ff69e01a20d - node_api_get_module_file_name
1: 0x7ff69c7fbee9 - node_api_get_module_file_name
2: 0x7ff69dff7321 - node_api_get_module_file_name
3: 0x7ff69e01e0c6 - node_api_get_module_file_name
4: 0x7ff69e01d98a - node_api_get_module_file_name
5: 0x7ff69e01d541 - node_api_get_module_file_name
6: 0x7ff69c659a13 - uv_close
7: 0x7ff69e01e467 - node_api_get_module_file_name
8: 0x7ff69e01e2c9 - node_api_get_module_file_name
9: 0x7ff69e01e24f - node_api_get_module_file_name
10: 0x7ff69e01e238 - node_api_get_module_file_name
11: 0x7ff69fb56dc4 - tree_sitter_javascript
12: 0x7ff69fb56f5d - tree_sitter_javascript
13: 0x7ff69fb5739e - tree_sitter_javascript
14: 0x7ff69cf503fc - node_api_get_module_file_name
15: 0x7ff69cf4dd45 - node_api_get_module_file_name
16: 0x7ff69e42c5bf - node_api_get_module_file_name
17: 0x7ff69e4222e4 - node_api_get_module_file_name
18: 0x7ff69e42a44f - node_api_get_module_file_name
19: 0x7ff69e4020bc - node_api_get_module_file_name
20: 0x7ff69e9c9d4a - CrashForExceptionInNonABICompliantCodeRange
21: 0x7ff69e9d21c1 - CrashForExceptionInNonABICompliantCodeRange
22: 0x7ff69f7fee7a - CrashForExceptionInNonABICompliantCodeRange
23: 0x7ff69f8ea184 - CrashForExceptionInNonABICompliantCodeRange
24: 0x7ff69f75db9e - CrashForExceptionInNonABICompliantCodeRange
25: 0x7ff69f75db9e - CrashForExceptionInNonABICompliantCodeRange
26: 0x7ff69f75db9e - CrashForExceptionInNonABICompliantCodeRange
27: 0x7ff69f75db9e - CrashForExceptionInNonABICompliantCodeRange
28: 0x7ff61f9cbb31 - <unknown>
29: 0x7ff61f9cbf63 - <unknown>
30: 0x7ff61f9cc251 - <unknown>
31: 0x7ff61f9ca2af - <unknown>
32: 0x7ff61f9c2c85 - <unknown>
33: 0x7ff61f9c2e4f - <unknown>
34: 0x7ff69f75db9e - CrashForExceptionInNonABICompliantCodeRange
35: 0x7ff69f75db9e - CrashForExceptionInNonABICompliantCodeRange
36: 0x7ff61f9cbb31 - <unknown>
37: 0x7ff61f9cbf63 - <unknown>
38: 0x7ff61f9cc251 - <unknown>
39: 0x7ff61f9ca2af - <unknown>
40: 0x7ff61f9c2c85 - <unknown>
41: 0x7ff61f9c2e4f - <unknown>
42: 0x7ff69f75db9e - CrashForExceptionInNonABICompliantCodeRange
43: 0x7ff69f75db9e - CrashForExceptionInNonABICompliantCodeRange
44: 0x7ff61f9cbb31 - <unknown>
45: 0x7ff61f9cbf63 - <unknown>
46: 0x7ff61f9cc251 - <unknown>
47: 0x7ff61f9ca2af - <unknown>
48: 0x7ff61f9c2c85 - <unknown>
49: 0x7ff61f9c2e4f - <unknown>
50: 0x7ff69f75db9e - CrashForExceptionInNonABICompliantCodeRange
51: 0x7ff69f75db9e - CrashForExceptionInNonABICompliantCodeRange
52: 0x7ff69f75db9e - CrashForExceptionInNonABICompliantCodeRange
53: 0x7ff69f75db9e - CrashForExceptionInNonABICompliantCodeRange
54: 0x7ff69f833b4a - CrashForExceptionInNonABICompliantCodeRange
55: 0x7ff69f75db9e - CrashForExceptionInNonABICompliantCodeRange
56: 0x7ff69f83812c - CrashForExceptionInNonABICompliantCodeRange
57: 0x7ff69f75db9e - CrashForExceptionInNonABICompliantCodeRange
58: 0x7ff69f75db9e - CrashForExceptionInNonABICompliantCodeRange
59: 0x7ff69f79e777 - CrashForExceptionInNonABICompliantCodeRange
60: 0x7ff69f87ea75 - CrashForExceptionInNonABICompliantCodeRange
61: 0x7ff69f78d14f - CrashForExceptionInNonABICompliantCodeRange
62: 0x7ff69f75b5ef - CrashForExceptionInNonABICompliantCodeRange
63: 0x7ff69e5299f4 - node_api_get_module_file_name
64: 0x7ff69e52a605 - node_api_get_module_file_name
65: 0x7ff69e52a80b - node_api_get_module_file_name
66: 0x7ff69e6bab95 - CrashForExceptionInNonABICompliantCodeRange
67: 0x7ff69e6ba991 - CrashForExceptionInNonABICompliantCodeRange
68: 0x7ff69e4a8d45 - node_api_get_module_file_name
69: 0x7ff69e3b1f10 - node_api_get_module_file_name
70: 0x7ff69e3b1abd - node_api_get_module_file_name
71: 0x7ff69e39e460 - node_api_get_module_file_name
72: 0x7ff69cff2fae - node_api_get_module_file_name
73: 0x7ff69c624f4d - uv_close
74: 0x7ff69c5c867c - uv_close
75: 0x7ff69c643aa4 - uv_close
76: 0x7ff69c005e0d - uv_mutex_destroy
77: 0x7ff69c7267b5 - node_api_get_module_file_name
78: 0x7ff69c1598df - uv_mutex_destroy
79: 0x7ff69c65c07c - uv_close
80: 0x7ff69bfd221f - uv_mutex_destroy
81: 0x7ff69c726896 - node_api_get_module_file_name
82: 0x7ff69faf8c8c - tree_sitter_javascript
83: 0x7ff9f41f257d - BaseThreadInitThunk
84: 0x7ff9f5a4af08 - RtlUserThreadStart | bug,node:vm | low | Critical |
2,590,440,608 | deno | Ability to use deno_node without deno_kv. | # I want to use deno_node without using deno_kv
The problem:
- **deno_node** relies on **deno_runtime**
- **deno_runtime** relies on **deno_kv** and **deno_cron**
- Therefore I can't use **deno_node** without adding **deno_runtime** to my project
## The good solution (I think/hope)
- deno_node relies on `import { kNeedsNpmProcessState } from "ext:runtime/40_process.js";`, from what I can tell the only time this file is consumed is from deno_node. Therefore, I believe it can be extracted from deno_runtime, potentially added to deno_node.
## My current solution
I've added **deno_kv** and **deno_cron** as extensions to my setup, and just configured them with backends that don't do anything.
| suggestion,custom runtime | low | Minor |
2,590,532,360 | godot | Spatial Shader ALPHA makes mesh draw over NavigationMesh3D nav mesh and other visual nodes | ### Tested versions
- Reproducible in 4.3.stable
### System information
Windows 10 64 bit - Godot 4.3.stable - Vulkan (Forward+)
### Issue description
While APLHA is changed in the 3D mesh's shader, the mesh(es) with the shader will draw over other nodes, eg. NavigationRegion3D's nav mesh.
Here's what it looks like with ALPHA disabled:
and with ALPHA enabled:
### Steps to reproduce
- add NavigationRegion3D to scene
- Import a model from blender
- add collision to mesh (for navigation region 3D)
- Add a spatial shader with ALPHA set to 1.0 (as example) to the model
### Minimal reproduction project (MRP)
[example-project.zip](https://github.com/user-attachments/files/17388928/example-project.zip)
| topic:rendering,needs testing,topic:3d | low | Minor |
2,590,553,492 | opencv | cv::cuda::transpose does not change dst mat at all | ### System Information
`cv::cuda::transpose(src, dst)` does not change dst value at all.
OpenCV: 4.10.0
compiler: clang 17.0.6
Platform: almalinux9
cuda sdk: 12.3
### Detailed description
if I have cv::cuda::GpuMat src and dst, after `cv::cuda::transpose(src, dst)` we would expect the value in src gets mapped into dst, but it doesn't. The content in dst remains unchanged.
### Steps to reproduce
```cpp
cv::cuda::GpuMat in{1108992, 4, CV_8U, cv::Scalar{20}};
cudaDeviceSynchronize();
auto in_sum = cv::cuda::sum(in)[0];
cv::cuda::GpuMat in_trans{in.cols, in.rows, in.type(), cv::Scalar{10}};
auto in_trans_sum1 = cv::cuda::sum(in_trans)[0];
cudaDeviceSynchronize();
cv::cuda::transpose(in, in_trans);
cudaDeviceSynchronize();
auto in_trans_sum2 = cv::cuda::sum(in_trans)[0];
if (in_sum != in_trans_sum2 && in_trans_sum1 == in_trans_sum2) {
throw std::runtime_error("transpose did not change dst value");
}
```
run above code:
```
exception message: transpose did not change dst value
```
### Issue submission checklist
- [X] I report the issue, it's not a question
- [X] I checked the problem with documentation, FAQ, open issues, forum.opencv.org, Stack Overflow, etc and have not found any solution
- [X] I updated to the latest OpenCV version and the issue is still there
- [X] There is reproducer code and related data files (videos, images, onnx, etc) | bug,category: gpu/cuda (contrib) | low | Critical |
2,590,660,919 | rust | Overly restrictive lifetime in `std::panic::Location::file` | # The problem
The signature of [`std::panic::Location::file`](https://doc.rust-lang.org/std/panic/struct.Location.html#method.file) is currently:
```rs
pub struct Location<'a> {
file: &'a str,
// ...
}
impl<'a> Location<'a> {
pub const fn file(&self) -> &str
}
```
which, with lifetimes expanded, is:
```rs
pub const fn file<'b>(self: &'b Location<'a>) -> &'b str
```
This makes the following impossible:
```rs
let location: Location<'static> = unimplemented!();
let file: &'static str = location.file();
// ------------ ^^^^^^^^ borrowed value does not live long enough
// |
// type annotation requires that `location` is borrowed for `'static`
```
# The solution
As far as I can tell, this should be a trivial fix - literally just adding the `'a` lifetime to the return type:
```rs
impl<'a> Location<'a> {
pub const fn file(&self) -> &'a str
}
```
Unfortunately, I also believe this is technically a breaking change ([playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=4802a383b11314d8e3fb3a0accac5600)):
```rs
fn uh_oh<'x>() {
let _: for<'a> fn(&'a Location<'x>) -> &'a str = Location::<'x>::file;
}
```
```
error: lifetime may not live long enough
--> src/lib.rs:22:12
|
21 | fn uh_oh<'x>() {
| -- lifetime `'x` defined here
22 | let _: for<'a> fn(&'a Location<'x>) -> &'a str = Location::<'x>::file;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ type annotation requires that `'x` must outlive `'static`
```
# Looking for mentor
I would love to get more experience contributing to rust, so if someone would be willing to guide me through the process, I'd love to implement the fix myself, and go through the whole merge + review process to get more comfortable contributing.
I imagine the first step would be to consult the library or library API team on the path forward considering potential breakage ("crater run"? deprecate and make a `file2`?), then implementation, review, and merge - but I'm new to this, and would appreciate a mentor to guide me through the process 😄 | A-lifetimes,T-libs-api,A-panic | low | Critical |
2,590,682,488 | kubernetes | [Flaking Test] [NodeFeature:SidecarContainers] Containers Lifecycle when A pod with restartable init containers is terminating | ### Which jobs are flaking?
29 ci-cos-cgroupv1-containerd-node-e2e-features ►
11 ci-cos-cgroupv2-containerd-node-e2e-features ►
5 ci-cos-containerd-node-e2e-features ►
3 ci-kubernetes-node-swap-fedora ▼
### Which tests are flaking?
E2eNode Suite.[It] [sig-node] [NodeFeature:SidecarContainers] Containers Lifecycle when A pod with restartable init containers is terminating when The PreStop hooks don't exit should terminate sidecars simultaneously if prestop doesn't exit
### Since when has it been flaking?
NA
### Testgrid link
- https://storage.googleapis.com/k8s-triage/index.html?test=Containers%20Lifecycle%20when%20A%20pod%20with%20restartable%20init%20containers%20is
- 5 clusters of 85 failures (11 in last day)
- https://testgrid.k8s.io/sig-node-kubelet#kubelet-gce-e2e-swap-fedora&show-stale-tests=
- 3 failures in last week
### Reason for failure (if possible)
probably those flakes can be fixed by tweak the simulToleration.
https://github.com/kubernetes/kubernetes/blob/55b83c92b3b69cd53d5bf22b8ccff859a005241a/test/e2e_node/container_lifecycle_test.go#L3283-L3285
```
Expected
<int64>: 30708
to be within 1000 of ~
<int>: 32000
In [It] at: k8s.io/kubernetes/test/e2e_node/container_lifecycle_test.go:3294 @ 10/13/24 19:55:14.386
```
```
[FAILED] should delete in < 5 seconds, took 6.112737
Expected
<float64>: 6.112736517
to be <
<int64>: 5
In [It] at: k8s.io/kubernetes/test/e2e_node/container_lifecycle_test.go:3548 @ 10/11/24 15:58:43.609
```
```
Expected
<int64>: -912
to be within 500 of ~
<int>: 0
In [It] at: k8s.io/kubernetes/test/e2e_node/container_lifecycle_test.go:3285 @ 10/15/24 18:03:02.718
}
```
### Anything else we need to know?
_No response_
### Relevant SIG(s)
/sig node
sidecar related | sig/node,kind/flake,priority/important-longterm,triage/accepted | low | Critical |
2,590,725,343 | kubernetes | [Flaking Test][NodeFeature:DevicePlugin] [Serial] [Disruptive] Keeps device plugin assignments after kubelet restart and device plugin restart (no pod restart) | ### Which jobs are flaking?
- ci-kubernetes-node-swap-fedora-serial
### Which tests are flaking?
- E2eNode Suite.[It] [sig-node] Device Plugin [NodeFeature:DevicePlugin] [Serial] DevicePlugin [Serial] [Disruptive] Keeps device plugin assignments after kubelet restart and device plugin restart (no pod restart)
### Since when has it been flaking?
https://github.com/kubernetes/kubernetes/issues/121220 is an old issue which include this flake there last year.
/cc @kannon92
### Testgrid link
https://testgrid.k8s.io/sig-node-kubelet#kubelet-gce-e2e-swap-fedora-serial
### Reason for failure (if possible)
```
{ failed [FAILED] inconsistent device assignment after pod restart: no resources found for device-plugin-errors-3704/device-plugin-test-4a0b7496-f40b-43f8-a726-d2d3a6ab3bcb/device-plugin-test-4a0b7496-f40b-43f8-a726-d2d3a6ab3bcb
In [It] at: k8s.io/kubernetes/test/e2e_node/device_plugin_test.go:613 @ 10/15/24 15:50:21.431
}
```
### Anything else we need to know?
_No response_
### Relevant SIG(s)
/sig node | priority/backlog,sig/node,kind/flake,triage/accepted | low | Critical |
2,590,813,477 | flutter | [video_player] Native Stack trace crashes when putting the app in inactive state while video is playing on Android | ### Steps to reproduce
1. Run the [video_player](https://pub.dev/packages/video_player) example code
2. Click on play on the Bee video
3. Put the app in background while the video is playing
4. See the Stack Traces
### Expected results
The behavior that i thought was fixed by #156451 is unfortunately still not correct under `video_player_android: ^2.7.12`
### Actual results
You can see a native Stack Trace (see logs below) if playing around with putting the app repeatedly in the background while the video is playing, same as described in #156451
I am using `video_player_android: ^2.7.12`
### Code sample
<details open><summary>Code sample</summary>
```dart
// Copyright 2013 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// ignore_for_file: public_member_api_docs
/// An example of using the plugin, controlling lifecycle and playback of the
/// video.
library;
import 'package:flutter/material.dart';
import 'package:video_player/video_player.dart';
void main() {
runApp(
MaterialApp(
home: _App(),
),
);
}
class _App extends StatelessWidget {
@override
Widget build(BuildContext context) {
return DefaultTabController(
length: 3,
child: Scaffold(
key: const ValueKey<String>('home_page'),
appBar: AppBar(
title: const Text('Video player example'),
actions: <Widget>[
IconButton(
key: const ValueKey<String>('push_tab'),
icon: const Icon(Icons.navigation),
onPressed: () {
Navigator.push<_PlayerVideoAndPopPage>(
context,
MaterialPageRoute<_PlayerVideoAndPopPage>(
builder: (BuildContext context) => _PlayerVideoAndPopPage(),
),
);
},
)
],
bottom: const TabBar(
isScrollable: true,
tabs: <Widget>[
Tab(
icon: Icon(Icons.cloud),
text: 'Remote',
),
Tab(icon: Icon(Icons.insert_drive_file), text: 'Asset'),
Tab(icon: Icon(Icons.list), text: 'List example'),
],
),
),
body: TabBarView(
children: <Widget>[
_BumbleBeeRemoteVideo(),
_ButterFlyAssetVideo(),
_ButterFlyAssetVideoInList(),
],
),
),
);
}
}
class _ButterFlyAssetVideoInList extends StatelessWidget {
@override
Widget build(BuildContext context) {
return ListView(
children: <Widget>[
const _ExampleCard(title: 'Item a'),
const _ExampleCard(title: 'Item b'),
const _ExampleCard(title: 'Item c'),
const _ExampleCard(title: 'Item d'),
const _ExampleCard(title: 'Item e'),
const _ExampleCard(title: 'Item f'),
const _ExampleCard(title: 'Item g'),
Card(
child: Column(children: <Widget>[
Column(
children: <Widget>[
const ListTile(
leading: Icon(Icons.cake),
title: Text('Video video'),
),
Stack(
alignment: FractionalOffset.bottomRight +
const FractionalOffset(-0.1, -0.1),
children: <Widget>[
_ButterFlyAssetVideo(),
Image.asset('assets/flutter-mark-square-64.png'),
]),
],
),
])),
const _ExampleCard(title: 'Item h'),
const _ExampleCard(title: 'Item i'),
const _ExampleCard(title: 'Item j'),
const _ExampleCard(title: 'Item k'),
const _ExampleCard(title: 'Item l'),
],
);
}
}
/// A filler card to show the video in a list of scrolling contents.
class _ExampleCard extends StatelessWidget {
const _ExampleCard({required this.title});
final String title;
@override
Widget build(BuildContext context) {
return Card(
child: Column(
mainAxisSize: MainAxisSize.min,
children: <Widget>[
ListTile(
leading: const Icon(Icons.airline_seat_flat_angled),
title: Text(title),
),
Padding(
padding: const EdgeInsets.all(8.0),
child: OverflowBar(
alignment: MainAxisAlignment.end,
spacing: 8.0,
children: <Widget>[
TextButton(
child: const Text('BUY TICKETS'),
onPressed: () {
/* ... */
},
),
TextButton(
child: const Text('SELL TICKETS'),
onPressed: () {
/* ... */
},
),
],
),
),
],
),
);
}
}
class _ButterFlyAssetVideo extends StatefulWidget {
@override
_ButterFlyAssetVideoState createState() => _ButterFlyAssetVideoState();
}
class _ButterFlyAssetVideoState extends State<_ButterFlyAssetVideo> {
late VideoPlayerController _controller;
@override
void initState() {
super.initState();
_controller = VideoPlayerController.asset('assets/Butterfly-209.mp4');
_controller.addListener(() {
setState(() {});
});
_controller.setLooping(true);
_controller.initialize().then((_) => setState(() {}));
_controller.play();
}
@override
void dispose() {
_controller.dispose();
super.dispose();
}
@override
Widget build(BuildContext context) {
return SingleChildScrollView(
child: Column(
children: <Widget>[
Container(
padding: const EdgeInsets.only(top: 20.0),
),
const Text('With assets mp4'),
Container(
padding: const EdgeInsets.all(20),
child: AspectRatio(
aspectRatio: _controller.value.aspectRatio,
child: Stack(
alignment: Alignment.bottomCenter,
children: <Widget>[
VideoPlayer(_controller),
_ControlsOverlay(controller: _controller),
VideoProgressIndicator(_controller, allowScrubbing: true),
],
),
),
),
],
),
);
}
}
class _BumbleBeeRemoteVideo extends StatefulWidget {
@override
_BumbleBeeRemoteVideoState createState() => _BumbleBeeRemoteVideoState();
}
class _BumbleBeeRemoteVideoState extends State<_BumbleBeeRemoteVideo> {
late VideoPlayerController _controller;
Future<ClosedCaptionFile> _loadCaptions() async {
final String fileContents = await DefaultAssetBundle.of(context)
.loadString('assets/bumble_bee_captions.vtt');
return WebVTTCaptionFile(
fileContents); // For vtt files, use WebVTTCaptionFile
}
@override
void initState() {
super.initState();
_controller = VideoPlayerController.networkUrl(
Uri.parse(
'https://flutter.github.io/assets-for-api-docs/assets/videos/bee.mp4'),
closedCaptionFile: _loadCaptions(),
videoPlayerOptions: VideoPlayerOptions(mixWithOthers: true),
);
_controller.addListener(() {
setState(() {});
});
_controller.setLooping(true);
_controller.initialize();
}
@override
void dispose() {
_controller.dispose();
super.dispose();
}
@override
Widget build(BuildContext context) {
return SingleChildScrollView(
child: Column(
children: <Widget>[
Container(padding: const EdgeInsets.only(top: 20.0)),
const Text('With remote mp4'),
Container(
padding: const EdgeInsets.all(20),
child: AspectRatio(
aspectRatio: _controller.value.aspectRatio,
child: Stack(
alignment: Alignment.bottomCenter,
children: <Widget>[
VideoPlayer(_controller),
ClosedCaption(text: _controller.value.caption.text),
_ControlsOverlay(controller: _controller),
VideoProgressIndicator(_controller, allowScrubbing: true),
],
),
),
),
],
),
);
}
}
class _ControlsOverlay extends StatelessWidget {
const _ControlsOverlay({required this.controller});
static const List<Duration> _exampleCaptionOffsets = <Duration>[
Duration(seconds: -10),
Duration(seconds: -3),
Duration(seconds: -1, milliseconds: -500),
Duration(milliseconds: -250),
Duration.zero,
Duration(milliseconds: 250),
Duration(seconds: 1, milliseconds: 500),
Duration(seconds: 3),
Duration(seconds: 10),
];
static const List<double> _examplePlaybackRates = <double>[
0.25,
0.5,
1.0,
1.5,
2.0,
3.0,
5.0,
10.0,
];
final VideoPlayerController controller;
@override
Widget build(BuildContext context) {
return Stack(
children: <Widget>[
AnimatedSwitcher(
duration: const Duration(milliseconds: 50),
reverseDuration: const Duration(milliseconds: 200),
child: controller.value.isPlaying
? const SizedBox.shrink()
: const ColoredBox(
color: Colors.black26,
child: Center(
child: Icon(
Icons.play_arrow,
color: Colors.white,
size: 100.0,
semanticLabel: 'Play',
),
),
),
),
GestureDetector(
onTap: () {
controller.value.isPlaying ? controller.pause() : controller.play();
},
),
Align(
alignment: Alignment.topLeft,
child: PopupMenuButton<Duration>(
initialValue: controller.value.captionOffset,
tooltip: 'Caption Offset',
onSelected: (Duration delay) {
controller.setCaptionOffset(delay);
},
itemBuilder: (BuildContext context) {
return <PopupMenuItem<Duration>>[
for (final Duration offsetDuration in _exampleCaptionOffsets)
PopupMenuItem<Duration>(
value: offsetDuration,
child: Text('${offsetDuration.inMilliseconds}ms'),
)
];
},
child: Padding(
padding: const EdgeInsets.symmetric(
// Using less vertical padding as the text is also longer
// horizontally, so it feels like it would need more spacing
// horizontally (matching the aspect ratio of the video).
vertical: 12,
horizontal: 16,
),
child: Text('${controller.value.captionOffset.inMilliseconds}ms'),
),
),
),
Align(
alignment: Alignment.topRight,
child: PopupMenuButton<double>(
initialValue: controller.value.playbackSpeed,
tooltip: 'Playback speed',
onSelected: (double speed) {
controller.setPlaybackSpeed(speed);
},
itemBuilder: (BuildContext context) {
return <PopupMenuItem<double>>[
for (final double speed in _examplePlaybackRates)
PopupMenuItem<double>(
value: speed,
child: Text('${speed}x'),
)
];
},
child: Padding(
padding: const EdgeInsets.symmetric(
// Using less vertical padding as the text is also longer
// horizontally, so it feels like it would need more spacing
// horizontally (matching the aspect ratio of the video).
vertical: 12,
horizontal: 16,
),
child: Text('${controller.value.playbackSpeed}x'),
),
),
),
],
);
}
}
class _PlayerVideoAndPopPage extends StatefulWidget {
@override
_PlayerVideoAndPopPageState createState() => _PlayerVideoAndPopPageState();
}
class _PlayerVideoAndPopPageState extends State<_PlayerVideoAndPopPage> {
late VideoPlayerController _videoPlayerController;
bool startedPlaying = false;
@override
void initState() {
super.initState();
_videoPlayerController =
VideoPlayerController.asset('assets/Butterfly-209.mp4');
_videoPlayerController.addListener(() {
if (startedPlaying && !_videoPlayerController.value.isPlaying) {
Navigator.pop(context);
}
});
}
@override
void dispose() {
_videoPlayerController.dispose();
super.dispose();
}
Future<bool> started() async {
await _videoPlayerController.initialize();
await _videoPlayerController.play();
startedPlaying = true;
return true;
}
@override
Widget build(BuildContext context) {
return Material(
child: Center(
child: FutureBuilder<bool>(
future: started(),
builder: (BuildContext context, AsyncSnapshot<bool> snapshot) {
if (snapshot.data ?? false) {
return AspectRatio(
aspectRatio: _videoPlayerController.value.aspectRatio,
child: VideoPlayer(_videoPlayerController),
);
} else {
return const Text('waiting for video to load');
}
},
),
),
);
}
}
```
</details>
### Screenshots or Video
<details open>
<summary>Screenshots / Video demonstration</summary>
[Upload media here]
</details>
### Logs
<details open><summary>Logs</summary>
Too long for github so i am attaching as a txt file.
[logs.txt](https://github.com/user-attachments/files/17390541/logs.txt)
</details>
### Flutter Doctor output
<details open><summary>Doctor output</summary>
```console
[✓] Flutter (Channel stable, 3.24.3, on macOS 15.0.1 24A348 darwin-x64, locale fr-FR)
• Flutter version 3.24.3 on channel stable at /Users/foxtom/Desktop/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 2663184aa7 (5 weeks ago), 2024-09-11 16:27:48 -0500
• Engine revision 36335019a8
• Dart version 3.5.3
• DevTools version 2.37.3
[✓] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
• Android SDK at /Users/foxtom/Library/Android/sdk
• Platform android-35, build-tools 35.0.0
• Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 21.0.3+-79915915-b509.11)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 16.0)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 16A242d
• CocoaPods version 1.15.2
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2024.2)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 21.0.3+-79915915-b509.11)
[✓] VS Code (version 1.94.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension can be installed from:
🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter
[✓] Connected device (4 available)
• moto g 8 power (mobile) • adb-ZY22BNDW2C-yyjDO7._adb-tls-connect._tcp • android-arm64 • Android 11 (API 30)
• Now You See Me (mobile) • 00008020-001204401E78002E • ios • iOS 18.0.1 22A3370
• macOS (desktop) • macos • darwin-x64 • macOS 15.0.1 24A348 darwin-x64
• Chrome (web) • chrome • web-javascript • Google Chrome 130.0.6723.58
[✓] Network resources
• All expected network resources are available.
• No issues found!
```
</details>
| c: crash,platform-android,p: video_player,package,has reproducible steps,P2,team-android,triaged-android,found in release: 3.24,found in release: 3.27 | low | Critical |
2,590,816,254 | pytorch | DISABLED test_dynamo_export_retains_readable_parameter_and_buffer_names (__main__.TestFxToOnnx) | Platforms: linux
This test was disabled because it is failing in CI. See [recent examples](https://hud.pytorch.org/flakytest?name=test_dynamo_export_retains_readable_parameter_and_buffer_names&suite=TestFxToOnnx&limit=100) and the most recent trunk [workflow logs](https://github.com/pytorch/pytorch/runs/31586854408).
Over the past 3 hours, it has been determined flaky in 7 workflow(s) with 7 failures and 7 successes.
**Debugging instructions (after clicking on the recent samples link):**
DO NOT ASSUME THINGS ARE OKAY IF THE CI IS GREEN. We now shield flaky tests from developers so CI will thus be green but it will be harder to parse the logs.
To find relevant log snippets:
1. Click on the workflow logs linked above
2. Click on the Test step of the job so that it is expanded. Otherwise, the grepping will not work.
3. Grep for `test_dynamo_export_retains_readable_parameter_and_buffer_names`
4. There should be several instances run (as flaky tests are rerun in CI) from which you can study the logs.
<details><summary>Sample error message</summary>
```
Traceback (most recent call last):
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/onnx/_internal/_exporter_legacy.py", line 796, in dynamo_export
return Exporter(
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/onnx/_internal/_exporter_legacy.py", line 560, in export
graph_module = self.options.fx_tracer.generate_fx(
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/onnx/_internal/fx/dynamo_graph_extractor.py", line 217, in generate_fx
return self.pre_export_passes(options, model, graph_module, updated_model_args) # type: ignore[return-value]
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/onnx/_internal/fx/dynamo_graph_extractor.py", line 226, in pre_export_passes
return _exporter_legacy.common_pre_export_passes(
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/onnx/_internal/_exporter_legacy.py", line 837, in common_pre_export_passes
module = passes.Functionalize(
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/onnx/_internal/diagnostics/infra/decorator.py", line 146, in wrapper
ctx.log_and_raise_if_error(diag)
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/onnx/_internal/diagnostics/infra/context.py", line 355, in log_and_raise_if_error
raise diagnostic.source_exception
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/onnx/_internal/diagnostics/infra/decorator.py", line 130, in wrapper
return_values = fn(*args, **kwargs)
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/onnx/_internal/fx/_pass.py", line 275, in run
module = self._run(*args, **kwargs)
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/onnx/_internal/fx/passes/functionalization.py", line 120, in _run
graph_module = proxy_tensor.make_fx(
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/fx/experimental/proxy_tensor.py", line 2151, in wrapped
return make_fx_tracer.trace(f, *args)
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/fx/experimental/proxy_tensor.py", line 2089, in trace
return self._trace_inner(f, *args)
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/fx/experimental/proxy_tensor.py", line 2060, in _trace_inner
t = dispatch_trace(
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/_compile.py", line 32, in inner
return disable_fn(*args, **kwargs)
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/_dynamo/eval_frame.py", line 654, in _fn
return fn(*args, **kwargs)
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/fx/experimental/proxy_tensor.py", line 1137, in dispatch_trace
graph = tracer.trace(root, concrete_args) # type: ignore[arg-type]
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/_dynamo/eval_frame.py", line 654, in _fn
return fn(*args, **kwargs)
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/fx/_symbolic_trace.py", line 827, in trace
(self.create_arg(fn(*args)),),
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/fx/experimental/proxy_tensor.py", line 1192, in wrapped
out = f(*tensors)
File "<string>", line 1, in <lambda>
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/onnx/_internal/fx/passes/functionalization.py", line 84, in wrapped
out = function(*inputs_functional)
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/onnx/_internal/fx/passes/_utils.py", line 28, in wrapped
return torch.fx.Interpreter(graph_module).run(*args)
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/fx/interpreter.py", line 146, in run
self.env[node] = self.run_node(node)
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/fx/interpreter.py", line 203, in run_node
return getattr(self, n.op)(n.target, args, kwargs)
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/fx/interpreter.py", line 275, in call_function
return target(*args, **kwargs)
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/_ops.py", line 723, in __call__
return self._op(*args, **kwargs)
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/fx/experimental/proxy_tensor.py", line 1240, in __torch_function__
return func(*args, **kwargs)
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/_ops.py", line 723, in __call__
return self._op(*args, **kwargs)
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/utils/_stats.py", line 21, in wrapper
return fn(*args, **kwargs)
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/fx/experimental/proxy_tensor.py", line 1333, in __torch_dispatch__
return proxy_call(self, func, self.pre_dispatch, args, kwargs)
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/fx/experimental/proxy_tensor.py", line 911, in proxy_call
out = func(*args, **kwargs)
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/_ops.py", line 723, in __call__
return self._op(*args, **kwargs)
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/utils/_stats.py", line 21, in wrapper
return fn(*args, **kwargs)
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/_subclasses/fake_tensor.py", line 1254, in __torch_dispatch__
return self.dispatch(func, types, args, kwargs)
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/_subclasses/fake_tensor.py", line 1799, in dispatch
return self._cached_dispatch_impl(func, types, args, kwargs)
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/_subclasses/fake_tensor.py", line 1364, in _cached_dispatch_impl
output = self._dispatch_impl(func, types, args, kwargs)
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/_subclasses/fake_tensor.py", line 2128, in _dispatch_impl
op_impl_out = op_impl(self, func, *args, **kwargs)
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/_subclasses/fake_impls.py", line 147, in dispatch_to_op_implementations_dict
return op_implementations_dict[func](fake_mode, func, *args, **kwargs)
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/_subclasses/fake_impls.py", line 741, in conv
out = func(**kwargs)
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/_ops.py", line 723, in __call__
return self._op(*args, **kwargs)
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/_meta_registrations.py", line 2257, in meta_conv
shape_out = calc_conv_nd_return_shape(
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/_meta_registrations.py", line 2174, in calc_conv_nd_return_shape
kernel_size = weight.shape[2:]
AttributeError: 'NoneType' object has no attribute 'shape'
While executing %convolution : [num_users=1] = call_function[target=torch.ops.aten.convolution.default](args = (%l_tensor_x_, %_param_constant0, None, [1, 1], [0, 0], [1, 1], False, [0, 0], 1), kwargs = {})
Original traceback:
File "/var/lib/jenkins/workspace/test/onnx/test_fx_to_onnx.py", line 139, in forward
tensor_x = self.conv1(tensor_x)
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/var/lib/jenkins/workspace/test/onnx/test_fx_to_onnx.py", line 149, in test_dynamo_export_retains_readable_parameter_and_buffer_names
onnx_program = torch.onnx.dynamo_export(model, tensor_x)
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/onnx/__init__.py", line 517, in dynamo_export
return dynamo_export(
File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/onnx/_internal/_exporter_legacy.py", line 812, in dynamo_export
raise errors.OnnxExporterError(message) from e
torch.onnx.OnnxExporterError: Failed to export the model to ONNX. Generating SARIF report at 'report_dynamo_export.sarif'. SARIF is a standard format for the output of static analysis tools. SARIF logs can be loaded in VS Code SARIF viewer extension, or SARIF web viewer (https://microsoft.github.io/sarif-web-component/). Please report a bug on PyTorch Github: https://github.com/pytorch/pytorch/issues
To execute this test, run the following from the base repo dir:
python test/onnx/test_fx_to_onnx.py TestFxToOnnx.test_dynamo_export_retains_readable_parameter_and_buffer_names
This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0
```
</details>
Test file path: `onnx/test_fx_to_onnx.py`
cc @clee2000 | module: onnx,triaged,module: flaky-tests,skipped | low | Critical |
2,590,829,417 | godot | Godot Editor crashes when creating a pck file with a deleted .godot directory and adding fonts | ### Tested versions
- Reproducible in: 4.3.stable
### System information
Ubuntu 22.04.5 LTS - Godot Editor 4.3.stable
### Issue description
If fonts are added to the project, and the **pck** file is created using **Godot Editor**, with the **".godot"** directory removed before that, then sometimes the **pck** file creation occurs with an error and Godot Editor crashes:
```reimport: begin: (Re)Importing Assets steps: 22
reimport: step 0: DejaVuSerifCondensed.ttf
reimport: step 10: DejaVuSansMono-BoldOblique.ttf
reimport: step 14: DejaVuSansCondensed-BoldOblique.ttf
ERROR: Caller thread can't call this function in this node (/root). Use call_deferred() or call_thread_group() instead.
at: propagate_notification (scene/main/node.cpp:2422)
=================================================================
handle_crash: Program crashed with signal 11
```
Example of a test project new-game-project, to reproduce:
[new-game-project.zip](https://github.com/user-attachments/files/17390277/new-game-project.zip)
Example of a script for playback:
[editor_loop_bug.zip](https://github.com/user-attachments/files/17390291/editor_loop_bug.zip)
The script input is the path to the Godot Editor executable file and the path to the new-game-project:
```
editor_loop_bug.sh -e <path godot.linuxbsd.editor.x86_64> -d <path new-game-project>
```
The script performs a loop deleting the ".godot" directory and creating a pck file:
```
for i in {0..100000}; do
clear
rm -rf $RESOURCE_DIR/.godot
${GODOT_EDITOR_BIN} --headless --path ${RESOURCE_DIR} --export-pack ${EXPORT_TEMPLATE} ${PCK_FILE}
if [[ $? -ne 0 ]]; then
echo "step failed"
exit 1
fi
done
```
### Steps to reproduce
1) Unpack the archive with the test project:
[new-game-project.zip](https://github.com/user-attachments/files/17390277/new-game-project.zip)
into a convenient directory
2) Run the editor_loop_bug.sh script:
[editor_loop_bug.zip](https://github.com/user-attachments/files/17390291/editor_loop_bug.zip)
specifying the path to the Godot Editor executable file and the path to the new-game-project as input:
```
editor_loop_bug.sh -e <path godot.linuxbsd.editor.x86_64> -d <path new-game-project>
```
3) Monitor the output
At the Nth iteration, Godot Editor will crash.
On my machine, sometimes the crash lasts for one minute, and sometimes 10 minutes or more
### Minimal reproduction project (MRP)
Example of a test project new-game-project, to reproduce:
[new-game-project.zip](https://github.com/user-attachments/files/17390277/new-game-project.zip)
Example of a script for playback:
[editor_loop_bug.zip](https://github.com/user-attachments/files/17390291/editor_loop_bug.zip)
The script input is the path to the Godot Editor executable file and the path to the new-game-project:
```
editor_loop_bug.sh -e <path godot.linuxbsd.editor.x86_64> -d <path new-game-project>
``` | bug,needs testing,crash,topic:export | low | Critical |
2,590,848,135 | deno | Turbo/ core pack support | I am liking Deno but I have one thing before I can switch, the ability to work with Turbo and put Deno as the package manager in my existing package.json | question | low | Major |
2,590,916,887 | excalidraw | Option to disable the add text function on double tap in mobile | I understand this isn't a bug, but it would be great if there were an option to disable the double-tap add text function in mobile view. The current behavior isn't very user-friendly, as when I'm adjusting elements on the canvas, an accidental double tap frequently triggers the text input mode and opens the keyboard. This disrupts the workflow and makes it harder to interact with the canvas smoothly. Disabling this feature would significantly improve the user experience on mobile devices. | enhancement | low | Critical |
2,590,916,929 | PowerToys | Workspaces tabbed browsers and documents | ### Microsoft PowerToys version
0.85.1
### Installation method
GitHub
### Running as admin
None
### Area(s) with issue?
Workspaces
### Steps to reproduce
1. Open multiple browsers (Brave) with TidyTabs and each tabbed browser window with multiple tabbed documents open.
2. Create workspace with PowerToys
3. Save workspace
### ✔️ Expected Behavior
Open workspace should recreates the originals multiple tabbed browsers and within the multiple tabbed documents.
### ❌ Actual Behavior
Open workspace recreates the originals multiple browsers and multiple tabbed documents and additionally fully empty multipe browsers with within empty tabbed documents and also many browsers windows are minimized and have totally different screen positions.
### Other Software
TidyTabs Pro 1.19.1 | Issue-Bug,Needs-Triage,Product-Workspaces | low | Minor |
2,591,015,349 | next.js | I get the error when I use handlebars with next.js server actions. | ### Verify canary release
- [X] I verified that the issue exists in the latest Next.js canary release
### Provide environment information
```bash
Operating System:
Platform: win32
Arch: x64
Version: Windows 10 Pro
Available memory (MB): 32660
Available CPU cores: 8
Binaries:
Node: 20.17.0
npm: N/A
Yarn: N/A
pnpm: N/A
Relevant Packages:
next: 15.0.0-rc.0 // Latest available version is detected (15.0.0-rc.0).
eslint-config-next: 15.0.0-rc.0
react: 19.0.0-rc-2d16326d-20240930
react-dom: 19.0.0-rc-2d16326d-20240930
typescript: 5.5.4
Next.js Config:
output: N/A
```
### Which example does this report relate to?
handlebars
### What browser are you using? (if relevant)
Chrome, Safari
### How are you deploying your application? (if relevant)
Vercel
### Describe the Bug
I am using handlebars to use html template and I use resend to send the email by the imported html file.
It is working in production and development mode in my pc but not working in only vercel.
This is my code
```
"use server";
import fs from "fs";
import Handlebars from "handlebars";
import path from "path";
import { Resend } from "resend";
import { BASE_URL } from "@/constants";
const resendClient = new Resend(process.env.RESEND_API_KEY);
export const sendEmail = async (
token: string,
email: string,
method: "password"
) => {
const link = `${BASE_URL}/reset-psw?email_token=${token}&email=${email}`;
const html = renderTemplate("reset-psw-req", {
link,
domainName: process.env.RESEND_DOMAIN_NAME
});
try {
const result = await resendClient.emails.send({
from: `MomoReis10 Support <support@${process.env.RESEND_DOMAIN_NAME}>`,
to: [email],
subject: "Reset your password",
html
});
return result;
} catch (err) {
throw new Error(err as string);
}
};
const renderTemplate = (templateName: string, data: any) => {
const filePath = path.join(
process.env.NODE_ENV === "development" ? process.cwd() : __dirname,
process.env.NODE_ENV === "development" ? "lib/emails/" : "./lib/emails",
`${templateName}.handlebars`
);
const source = fs.readFileSync(filePath, "utf8");
const template = Handlebars.compile(source);
return template(data);
};
```
### Expected Behavior
I expected to send the email to user's email for resetting password.
### To Reproduce
https://momoreis.vercel.app
You can see the "Giriş Yap" button in the navbar and there is the link named "Şifreni mi Unuttun?".
If you click it and see the console, there is an error.
| examples | low | Critical |
2,591,021,462 | vscode | Zen mode does not exit when leaving fullscreen after restart | Steps to Reproduce:
1. go fullscreen
2. enable zen mode
3. quit
4. leave fullscreen
=> 🐛 zen mode is not exit because `zenModeExitInfo.transitionedToFullScreen` is not remembered correctly between restarts
| bug,workbench-zen | low | Minor |
2,591,048,486 | go | x/crypto/ssh/test: TestRunCommandSuccess failures | ```
#!watchflakes
default <- pkg == "golang.org/x/crypto/ssh/test" && test == "TestRunCommandSuccess"
```
Issue created automatically to collect these failures.
Example ([log](https://ci.chromium.org/b/8734348983558033425)):
=== RUN TestRunCommandSuccess
session_test.go:40: session failed: EOF
test_unix_test.go:246: sshd:
Error reading managed configuration (2: No such file or directory). Proceeding with default configuration.
/Users/swarming/.swarming/w/ir/x/t/sshtest3004567004/sshd_config line 10: Deprecated option KeyRegenerationInterval
/Users/swarming/.swarming/w/ir/x/t/sshtest3004567004/sshd_config line 11: Deprecated option ServerKeyBits
/Users/swarming/.swarming/w/ir/x/t/sshtest3004567004/sshd_config line 17: Deprecated option RSAAuthentication
/Users/swarming/.swarming/w/ir/x/t/sshtest3004567004/sshd_config line 22: Deprecated option RhostsRSAAuthentication
debug1: inetd sockets after dupping: 4, 5
BSM audit: getaddrinfo failed for UNKNOWN: nodename nor servname provided, or not known
...
debug1: auth_activate_options: setting new authentication options
Accepted publickey for swarming from UNKNOWN port 65535 ssh2: ECDSA SHA256:DbuSF5a8c3JMmpZ5WiK8oLAx97Uu8zIAFReb/NyTPuo
debug1: monitor_child_preauth: user swarming authenticated by privileged process
debug1: auth_activate_options: setting new authentication options [preauth]
debug2: userauth_pubkey: authenticated 1 pkalg ecdsa-sha2-nistp256 [preauth]
debug1: monitor_read_log: child log fd closed
BSM audit: bsm_audit_session_setup: setaudit_addr failed: Invalid argument
Could not create new audit session
debug1: do_cleanup
--- FAIL: TestRunCommandSuccess (0.12s)
— [watchflakes](https://go.dev/wiki/Watchflakes)
| NeedsInvestigation | low | Critical |
2,591,083,714 | electron | [Bug]: 'setCertificateVerifyProc()' is ignored when the HTTP request is sent from a 'utility' process using 'net.fetch()' on Windows and MacOS | ### Preflight Checklist
- [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project.
- [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to.
- [x] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success.
### Electron Version
32.1.2
### What operating system(s) are you using?
Other (specify below)
### Operating System Version
MacOS Sonoma, Windows 11, Debian (Docker)
### What arch are you using?
Other (specify below)
### Last Known Working Electron version
_No response_
### Expected Behavior
I have developed some tests to validate the behaviour of `net.fetch()` / `fetch()` on Windows, MacOS and Linux when sending HTTP(S) requests from the `main` process, from a `renderer` process and from a `utility` process. More specifically, I wanted to check the integration with the OS network settings and trust store when dealing with web proxies and self-signed certificates. See [@hackolade/fetch](https://github.com/hackolade/fetch) for more details about my approach.
I expected `net.fetch()` / `fetch()` to behave consistently whatever the process and the operating system.
### Actual Behavior
When using [setCertificateVerifyProc()](https://www.electronjs.org/docs/latest/api/session#sessetcertificateverifyprocproc) in order for `net.fetch()` / `fetch()` to consider valid a certificate authority file provided by the user (but not installed in the trust store of her/his OS), I observed the following:
- On Linux, the certificate verification procedure that I set is invoked for all processes: `main`, `renderer` and `utility`. As a consequence, the application can reach the server that uses a self-signed certificate.
- On MacOS and Windows, the certificate verification procedure that I set is not invoked for the `utility` process. As a consequence, the application fails to reach the server that uses a self-signed certificate from that process.
So how am I supposed to deal with that case?
Note that I created a separate issue for the problem with the 'login' event: see #44249.
### Testcase Gist URL
https://gist.github.com/thomas-jakemeyn/663f6c648f42bb988aaeee9ba5a697b2
https://github.com/hackolade/fetch/tree/develop
### Additional Information
_No response_ | bug :beetle:,component/net,has-repro-gist,component/utilityProcess,32-x-y | low | Critical |
2,591,152,528 | terminal | Wired scrollbar click behaviour | ### Windows Terminal version
1.20.11781.0
### Windows build number
10.0.22631.4317
### Other Software
_No response_
### Steps to reproduce
Typically when mouse click the scrollbar(not the thumb), hold the mouse button down. The scrollbar will:
page up, <wait some time>, page up, page up, page up, page up,...
Then thumb will stop at the mouse pointer position.
But in the current terminal. There are 3 random behavior.
1. Page up/down once and stop.
2. Thumb not stop. And reach the top/bottom position.
3. Thumb move across the mouse pointer position.
### Expected Behavior
Not random.
### Actual Behavior
see above. | Resolution-External,Issue-Bug,Product-Terminal,Tracking-External | low | Minor |
2,591,196,654 | PowerToys | feat: PowerToys Run: Unit Converter convert multiple units | ### Description of the new feature / enhancement
# PowerToys Run: Unit Converter
**Unit Converter able to convert multiple units**
like
`5ft 9in to in` 5 feet 9 inches -> inches
### Scenario when this would be used?
PowerToys Run: Unit Converter
### Supporting information
make sure handle different types of unts
Mass Units -> Mass Units
handle error
`5ft 6g to in` 5feet 6grams -> grams 😂
| Needs-Triage | low | Critical |
2,591,197,929 | vscode | TypeError: Cannot read properties of undefined (reading 'implicitContext') | I am seeing this stack after installing the Copilot extension without being signed in:
```
Cannot read properties of undefined (reading 'implicitContext'): TypeError: Cannot read properties of undefined (reading 'implicitContext')
at ChatImplicitContextContribution.updateImplicitContext (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/chat/browser/contrib/chatImplicitContext.js:49:26)
at UniqueContainer.value (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/chat/browser/contrib/chatImplicitContext.js:38:72)
at Emitter._deliver (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/event.js:966:22)
at Emitter.fire (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/event.js:995:18)
at ChatWidgetService.register (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/chat/browser/chatWidget.js:1008:30)
at new ChatWidget (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/chat/browser/chatWidget.js:164:42)
at InstantiationService._createInstance (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/platform/instantiation/common/instantiationService.js:130:24)
at InstantiationService.createInstance (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/platform/instantiation/common/instantiationService.js:101:27)
at ChatViewPane.renderBody (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/chat/browser/chatViewPane.js:129:70)
at ChatViewPane.render (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/browser/ui/splitview/paneview.js:202:18)
``` | debt,chat | low | Critical |
2,591,209,868 | flutter | [Web] Text selection, and tooltip interactions seems broken on iOS | ### Steps to reproduce
Build the sample code for the **web**, then launch the website on a physical iOS device, or in a simulator.
When the website is up and running, interact with the TextField, by trying to select text in various scenarios.
### Expected results
The behavior should be the same as when we select text in an iOS application.
### Actual results
There are a few issues:
- First, there is a weird "double overlay" on the selected text
<img width="105" alt="Screenshot 2024-10-16 at 11 12 01" src="https://github.com/user-attachments/assets/c2c38137-3caa-48ec-8d10-507a156a25bb">
In the screenshot above we can see a grey overlay, and a purple overlay for the selected text.
- Then after a few manipulations, the contextual tooltip menu can be placed in the wrong place like at the very top of the screen
I tested this on `3.24.3` and on `master` with little to no improvement on `master`
### Code sample
<details open><summary>Code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() {
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({super.key});
// This widget is the root of your application.
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Flutter Demo',
theme: ThemeData(
// This is the theme of your application.
//
// TRY THIS: Try running your application with "flutter run". You'll see
// the application has a purple toolbar. Then, without quitting the app,
// try changing the seedColor in the colorScheme below to Colors.green
// and then invoke "hot reload" (save your changes or press the "hot
// reload" button in a Flutter-supported IDE, or press "r" if you used
// the command line to start the app).
//
// Notice that the counter didn't reset back to zero; the application
// state is not lost during the reload. To reset the state, use hot
// restart instead.
//
// This works for code too, not just values: Most code changes can be
// tested with just a hot reload.
colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
useMaterial3: true,
),
home: const MyHomePage(title: 'Flutter Demo Home Page'),
);
}
}
class MyHomePage extends StatefulWidget {
const MyHomePage({super.key, required this.title});
// This widget is the home page of your application. It is stateful, meaning
// that it has a State object (defined below) that contains fields that affect
// how it looks.
// This class is the configuration for the state. It holds the values (in this
// case the title) provided by the parent (in this case the App widget) and
// used by the build method of the State. Fields in a Widget subclass are
// always marked "final".
final String title;
@override
State<MyHomePage> createState() => _MyHomePageState();
}
class _MyHomePageState extends State<MyHomePage> {
int _counter = 0;
void _incrementCounter() {
setState(() {
// This call to setState tells the Flutter framework that something has
// changed in this State, which causes it to rerun the build method below
// so that the display can reflect the updated values. If we changed
// _counter without calling setState(), then the build method would not be
// called again, and so nothing would appear to happen.
_counter++;
});
}
@override
Widget build(BuildContext context) {
// This method is rerun every time setState is called, for instance as done
// by the _incrementCounter method above.
//
// The Flutter framework has been optimized to make rerunning build methods
// fast, so that you can just rebuild anything that needs updating rather
// than having to individually change instances of widgets.
return Scaffold(
appBar: AppBar(
// TRY THIS: Try changing the color here to a specific color (to
// Colors.amber, perhaps?) and trigger a hot reload to see the AppBar
// change color while the other colors stay the same.
backgroundColor: Theme.of(context).colorScheme.inversePrimary,
// Here we take the value from the MyHomePage object that was created by
// the App.build method, and use it to set our appbar title.
title: Text(widget.title),
),
body: Center(
// Center is a layout widget. It takes a single child and positions it
// in the middle of the parent.
child: Column(
// Column is also a layout widget. It takes a list of children and
// arranges them vertically. By default, it sizes itself to fit its
// children horizontally, and tries to be as tall as its parent.
//
// Column has various properties to control how it sizes itself and
// how it positions its children. Here we use mainAxisAlignment to
// center the children vertically; the main axis here is the vertical
// axis because Columns are vertical (the cross axis would be
// horizontal).
//
// TRY THIS: Invoke "debug painting" (choose the "Toggle Debug Paint"
// action in the IDE, or press "p" in the console), to see the
// wireframe for each widget.
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
const TextField(),
const Text(
'You have pushed the button this many times:',
),
Text(
'$_counter',
style: Theme.of(context).textTheme.headlineMedium,
),
],
),
),
floatingActionButton: FloatingActionButton(
onPressed: _incrementCounter,
tooltip: 'Increment',
child: const Icon(Icons.add),
), // This trailing comma makes auto-formatting nicer for build methods.
);
}
}
```
</details>
### Screenshots or Video
<details open>
<summary>Screenshots / Video demonstration</summary>
https://github.com/user-attachments/assets/0e16cd4f-20d6-4bdc-9fcd-43d4aca020e0
</details>
### Logs
<details open><summary>Logs</summary>
```console
[Paste your logs here]
```
</details>
### Flutter Doctor output
<details open><summary>Doctor output</summary>
```console
[✓] Flutter (Channel stable, 3.24.3, on macOS 14.5 23F79 darwin-arm64, locale en-FR)
• Flutter version 3.24.3 on channel stable at /Users/adrien.padol/fvm/versions/3.24.3
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 2663184aa7 (5 weeks ago), 2024-09-11 16:27:48 -0500
• Engine revision 36335019a8
• Dart version 3.5.3
• DevTools version 2.37.3
[✓] Android toolchain - develop for Android devices (Android SDK version 35.0.0-rc3)
• Android SDK at /Users/adrien.padol/Library/Android/sdk
• Platform android-34, build-tools 35.0.0-rc3
• Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 15F31d
• CocoaPods version 1.15.2
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2023.3)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
[✓] VS Code (version 1.94.0)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.98.0
[✓] Connected device (6 available)
• iPad de Adrien (mobile) • 00008101-001805211128801E • ios • iOS 17.6.1 21G93
• iPhone de Adrien (mobile) • 00008101-0015250C3A82001E • ios • iOS 18.0.1 22A3370
• iPhone 15 Pro Max (mobile) • 9933FEE3-416B-40DC-8B91-5646B2E3B364 • ios • com.apple.CoreSimulator.SimRuntime.iOS-17-0 (simulator)
• macOS (desktop) • macos • darwin-arm64 • macOS 14.5 23F79 darwin-arm64
• Mac Designed for iPad (desktop) • mac-designed-for-ipad • darwin • macOS 14.5 23F79 darwin-arm64
• Chrome (web) • chrome • web-javascript • Google Chrome 129.0.6668.101
! Error: Browsing on the local area network for iPhone de Remi. Ensure the device is unlocked and attached with a cable or associated with the same local
area network as this Mac.
The device must be opted into Developer Mode to connect wirelessly. (code -27)
[✓] Network resources
• All expected network resources are available.
• No issues found!
```
</details>
| a: text input,platform-web,has reproducible steps,P2,browser: safari-ios,team-web,triaged-web,found in release: 3.24,found in release: 3.27 | low | Critical |
2,591,225,862 | flutter | TextFormField autofill not working for password with obscureText true on iOS 17.5+ | ### Steps to reproduce
You need an app with apple associated domain to be able to test iOS autofill password.
1. Launch app.
2. Click on "Login with obscureText".
3. Click on password.
4. Click on the suggested password from your keyboard
5. See that TextFormField is not autofilled
6. Click on the suggested password from your keyboard
7. See that TextFormField is autofilled
8. Go back to home page
9. Click on "Login without obscureText"
10. Click on password.
11. Click on the suggested password from your keyboard
12. See that TextFormField is autofilled
### Expected results
In Step 5, inputs should be autofilled.
### Actual results
In Step 5, inputs are not autofilled
### Code sample
<details open><summary>Code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() {
runApp(
const MaterialApp(
home: Home(),
),
);
}
class Home extends StatelessWidget {
const Home({super.key});
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
title: const Text('Textfield autofill issue'),
),
body: Center(
child: SingleChildScrollView(
child: Column(
mainAxisSize: MainAxisSize.min,
children: <Widget>[
ElevatedButton(
onPressed: () {
Navigator.of(context).push(
MaterialPageRoute<void>(
builder: (BuildContext context) {
return const Login(obscureText: true);
},
),
);
},
child: const Text('Login with obscureText'),
),
const SizedBox(height: 16),
ElevatedButton(
onPressed: () {
Navigator.of(context).push(
MaterialPageRoute<void>(
builder: (BuildContext context) {
return const Login(obscureText: false);
},
),
);
},
child: const Text('Login without obscureText'),
),
],
),
),
),
);
}
}
class Login extends StatelessWidget {
const Login({
required this.obscureText,
super.key,
});
final bool obscureText;
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(),
body: SingleChildScrollView(
child: Padding(
padding: const EdgeInsets.all(16),
child: AutofillGroup(
child: Column(
children: <Widget>[
TextFormField(
autofillHints: const <String>[
// Order is important, username must be first
AutofillHints.username,
AutofillHints.email,
],
keyboardType: TextInputType.emailAddress,
decoration: const InputDecoration(
hintText: 'Username',
contentPadding: EdgeInsets.only(left: 13, right: 7),
filled: true,
focusedBorder: OutlineInputBorder(
borderSide: BorderSide(
width: 1,
color: Colors.grey,
),
),
enabledBorder: OutlineInputBorder(
borderSide: BorderSide(
width: 1,
color: Colors.grey,
),
),
border: OutlineInputBorder(
borderSide: BorderSide(
width: 1,
color: Colors.grey,
),
),
),
),
const SizedBox(height: 16),
TextFormField(
autofillHints: const <String>[AutofillHints.password],
cursorColor: Theme.of(context).primaryIconTheme.color,
obscureText: obscureText,
keyboardType: TextInputType.visiblePassword,
decoration: const InputDecoration(
hintText: 'Password',
contentPadding: EdgeInsets.only(left: 13, right: 7),
filled: true,
focusedBorder: OutlineInputBorder(
borderSide: BorderSide(
width: 1,
color: Colors.grey,
),
),
enabledBorder: OutlineInputBorder(
borderSide: BorderSide(
width: 1,
color: Colors.grey,
),
),
border: OutlineInputBorder(
borderSide: BorderSide(
width: 1,
color: Colors.grey,
),
),
),
),
],
),
),
),
),
);
}
}
```
</details>
### Screenshots or Video
<details open>
<summary>Screenshots / Video demonstration</summary>
Login & password used are fake :)
https://github.com/user-attachments/assets/0a75ea9e-0e6d-4c6e-a9f8-95b8e7fdd713
</details>
### Logs
<details open><summary>Logs</summary>
```console
No logs
```
</details>
### Flutter Doctor output
<details open><summary>Doctor output</summary>
```console
[✓] Flutter (Channel stable, 3.24.3, on macOS 15.0.1 24A348 darwin-arm64, locale fr-FR)
• Flutter version 3.24.3 on channel stable at /Users/earminjon/fvm/versions/3.24.3
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 2663184aa7 (5 weeks ago), 2024-09-11 16:27:48 -0500
• Engine revision 36335019a8
• Dart version 3.5.3
• DevTools version 2.37.3
[✓] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
• Android SDK at /Users/earminjon/Library/Android/Sdk
• Platform android-35, build-tools 35.0.0
• ANDROID_HOME = /Users/earminjon/Library/Android/Sdk
• Java binary at: /Users/earminjon/Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 16.0)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 16A242d
• CocoaPods version 1.14.3
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2024.1)
• Android Studio at /Users/earminjon/Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)
[✓] Android Studio (version 2023.2)
• Android Studio at /Users/perso/Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)
[✓] IntelliJ IDEA Ultimate Edition (version 2024.2.3)
• IntelliJ at /Users/earminjon/Applications/IntelliJ IDEA Ultimate.app
• Flutter plugin version 82.0.3
• Dart plugin version 242.22855.32
[✓] Connected device (5 available)
• iPhone d’Enguerrand (mobile) • 00008030-0012646A21E3802E • ios • iOS 18.0.1 22A3370
• macOS (desktop) • macos • darwin-arm64 • macOS 15.0.1 24A348 darwin-arm64
• Mac Designed for iPad (desktop) • mac-designed-for-ipad • darwin • macOS 15.0.1 24A348 darwin-arm64
[✓] Network resources
• All expected network resources are available.
• No issues found!
```
</details>
| a: text input,c: regression,platform-ios,e: OS-version specific,P2,team-text-input,triaged-text-input | low | Major |
2,591,232,549 | deno | Bug: `dns.lookupService` is not a function | The `node:dns` module exports a `.lookupService()` function that we seem to be missing. See https://nodejs.org/api/dns.html#dnslookupserviceaddress-port-callback
## Steps to reproduce:
Run this snippet:
```ts
import dns from "node:dns";
dns.lookupService("127.0.0.1", 22, (err, hostname, service) => {
console.log(hostname, service);
// Prints: localhost ssh
});
```
Version: Deno 2.0.0
| bug,node compat | low | Critical |
2,591,310,441 | react-native | Issue with rendering a list of elements in React Native FlatList or using the array mapping method. | ### Description
Hi,
I’m encountering an issue with the FlatList in React Native (or when using the array mapping method). The rendered items are stacking on top of the previous ones. Below is the code I'm working with. Could you please help me resolve this behavior?
Thank you!
### Steps to reproduce
`import { useState } from 'react';
import {
Text,
SafeAreaView,
StyleSheet,
FlatList,
View,
TouchableOpacity,
} from 'react-native';
export default function App() {
const [showOptions, setShowOptions] = useState(false);
const [activeCard, setActiveCard] = useState(null);
return (
<SafeAreaView style={styles.container}>
<FlatList
data={[0, 1, 2, 3, 4, 5]}
renderItem={({ item, index }) => (
<View style={styles.card}>
<TouchableOpacity
style={styles.button}
onPress={() => {
setShowOptions(true);
setActiveCard(index);
}}
>
<Text style={styles.buttonText}>Click me</Text>
</TouchableOpacity>
{showOptions && activeCard === index && (
<View style={styles.optionsContainer}></View>
)}
</View>
)}
ItemSeparatorComponent={() => <View style={styles.separator} />}
contentContainerStyle={styles.listContent}
/>
</SafeAreaView>
);
}
const styles = StyleSheet.create({
container: {
flex: 1,
justifyContent: 'center',
backgroundColor: '#ecf0f1',
padding: 8,
},
card: {
height: 100,
width: '100%',
backgroundColor: 'green',
borderRadius: 8,
position: 'relative',
},
button: {
position: 'absolute',
bottom: 10,
right: 10,
},
buttonText: {
color: '#fff',
fontWeight: 'bold',
},
optionsContainer: {
backgroundColor: 'yellow',
borderRadius: 8,
height: 80,
width: '50%',
position: 'absolute',
top: 80,
},
separator: {
height: 20,
},
listContent: {
padding: 20,
paddingBottom: 100,
},
});
`
This is the code
### React Native Version
0.73.0
### Affected Platforms
Runtime - Android, Runtime - iOS, Runtime - Web
### Output of `npx react-native info`
```text
NA
```
### Stacktrace or Logs
```text
NA
```
### Reproducer
https://snack.expo.dev/nGlFBl-YeXppULXrGhsy9
### Screenshots and Videos
https://github.com/user-attachments/assets/141325b0-1851-4067-8328-ce2b5a5f26d8
| Issue: Author Provided Repro,Component: FlatList,Needs: Author Feedback,Newer Patch Available,Type: Old Architecture | medium | Major |
2,591,318,564 | godot | [Editor] Disabling `JSON` Feature Stops `.json` Files from Showing in the FileSystem | ### Tested versions
v4.3.stable.official [77dcf97d8] & latest master
### System information
Godot v4.4.dev.mono (af77100e3) - Windows 10.0.17763 - Multi-window, 4 monitors - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4060 Ti (NVIDIA; 32.0.15.6109) - AMD Ryzen 9 5900X 12-Core Processor (24 threads)
### Issue description
When the `JSON` feature is turned off in `Editor/Managed Editor Feature Profiles` windows, Godot Editor also stops showing the `*.json` files in `FileSystemDock`, even if the `json` extension is set from the `EditorSettings/Docks/FileSystem/TextFile Extensions`.
Such behavior should be documented if intended.
Or, when the JSON feature is off, the JSON file should be imported as plain text files (as opposed to Resource).
### Steps to reproduce
1. Create a new Project
2. Create a JSON file in the FileSystem
3. Goto `Editor/Managed Editor Feature Profiles` and disable the `JSON` feature
https://github.com/user-attachments/assets/97e2929b-82b5-4163-b6ff-687c7cbdedf2
### Minimal reproduction project (MRP)
N/A | discussion,topic:editor | low | Minor |
2,591,323,421 | ollama | How to add support for RWKV? | Hi! I would like to try to make RWKV v6 models working with ollama.
llama.cpp has it supported already.
- Currently ollama fails to load the model due to a bug in llama.cpp. Here's the fix PR: https://github.com/ggerganov/llama.cpp/pull/9907
- Another issue is the chat template. I wonder how should a chat template be added for a new model? Specifically, how does ollama decide which template to use when loading a modelfile?
Thanks!
| model request | low | Critical |
2,591,339,294 | flutter | Wrong dateHelpText in MaterialLocalizationIt - flutter_localizations | ### Steps to reproduce
The current value for `dataHelpText` used in `MaterialLocalizationIt` is `"mm/gg/aaaa"` but it should be `"gg/mm/aaaa"`, as the standard order for dates in Italian is day/month/year (giorno/mese/anno in Italian)
### Expected results
`String get dateHelpText => `gg/mm/aaaa';`
### Actual results
`String get dateHelpText => 'mm/gg/aaaa';`
### Code sample
Permalink to the line of code: https://github.com/flutter/flutter/blob/2430f00a01a72c6d80085e1afdf179374e06355f/packages/flutter_localizations/lib/src/l10n/generated_material_localizations.dart#L21192
### Screenshots or Video
<details open>
<summary>Screenshots / Video demonstration</summary>
[Upload media here]
</details>
### Logs
<details open><summary>Logs</summary>
```console
[Paste your logs here]
```
</details>
### Flutter Doctor output
Not applicable | framework,a: internationalization,P2,team-design,triaged-design | low | Minor |
2,591,369,098 | neovim | LSP: disable wrapping in hover window | ### Problem
Context: https://github.com/juanfranblanco/vscode-solidity/issues/467.
Some LSPs display the hover text wrapped:
The solution would be to do `set nowrap` automatically, as mentioned here https://github.com/juanfranblanco/vscode-solidity/issues/467#issuecomment-2416302302.
### Expected behavior
The text should not wrap, the window should instead have dynamic calculated dimensions according to the text. | enhancement,lsp,floatwin | low | Major |
2,591,425,484 | godot | Huge performance regression using Tr() when moving project from 3.5.3 to 3.6 (.net) | ### Tested versions
- Reproducible in 3.6 .net C# and all beta/rc .net builds
- Not reproducible in 3.5.3 .net C#
### System information
Windows 11 - Godot 3.5.3 .net - GLES 3 - RTX4080 - 14900k
### Issue description
For my existing project I noticed a huge performance regression when switching from 3.5.3 .net to 3.6 .net
When updating multiple tooltips (~20-30) at once that have multiple text fragments (~20) that are all translated using the Tr() translation server I notice huge frame drops from 60 fps down to 15 fps. We have 6 translation files that together have ~6000 lines in 13 languages. The exact same project ran at stable 60 frames in 3.5.3.
### Steps to reproduce
Run the MRP in 3.5.3 .net and 3.6 .net. Check cpu load and fps. Update multiple labels with multiple longer translation tags utilising 6 translation files with ~6000 lines in total with 13 languages.
### Minimal reproduction project (MRP)
Run this project in 3.5.3 .net and in 3.6 .net and check cpu load and fps.
[Godot3.6PerformanceIssue.zip](https://github.com/user-attachments/files/17394079/Godot3.6PerformanceIssue.zip) | bug,regression,topic:gui,performance | low | Major |
2,591,451,617 | next.js | Page is not rendered if router.push({static path with query params}) | ### Link to the code that reproduces this issue
https://codesandbox.io/p/devbox/nostalgic-butterfly-m4yqwg?file=%2Fpackage.json
### To Reproduce
1. I use static export and app routes, all my components are client components
2. Reproduse in production env
3. Example: router.push("/login?firstVisit=true") -> login page is not rendered, router.push("/login") -> works
4. I also do prefetch for router.push("/login")
If I have query params in url the page is not rendered.
### Current vs. Expected behavior
Login page should render for router.push("/login?firstVisit=true")
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 23.6.0: Mon Jul 29 21:14:30 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_T6000
Available memory (MB): 32768
Available CPU cores: 10
Binaries:
Node: 20.11.1
npm: 10.2.4
Yarn: 1.22.19
pnpm: 7.25.1
Relevant Packages:
next: 14.2.10
eslint-config-next: 14.2.5
react: 18.3.1
react-dom: 18.3.1
typescript: 5.5.4
Next.js Config:
output: export
```
### Which area(s) are affected? (Select all that apply)
Navigation
### Which stage(s) are affected? (Select all that apply)
Other (Deployed)
### Additional context
_No response_ | bug,Navigation | low | Minor |
2,591,459,502 | ui | [bug]: `CarouselContent` should be `overflow-hidden w-full h-full` not `overflow-hidden` | ### Describe the bug
In a scenario where carousel size is determined by the container, not the content (item) passing
```tsx
<CarouselContent className="w-full h-full">
```
won't work since the className is accepted by the second child
```tsx
const CarouselContent = React.forwardRef<
HTMLDivElement,
React.HTMLAttributes<HTMLDivElement>
>(({ className, ...props }, ref) => {
const { carouselRef, orientation } = useCarousel()
return (
<div ref={carouselRef} className="overflow-hidden">
<div
ref={ref}
className={cn(
"flex",
orientation === "horizontal" ? "-ml-4" : "-mt-4 flex-col",
className
)}
{...props}
/>
</div>
)
})
```
I am trying to use carousel in a definitive grid, and grid area, where content should follow the sizing, as the size is overriden (ignored by CarouselContent, I think its a wrong design. (or at least make it more atomic or allow className separation)
### Affected component/components
Carousel
### How to reproduce
```tsx
<CarouselContent className="w-full h-full">
```
### Codesandbox/StackBlitz link
_No response_
### Logs
_No response_
### System Info
```bash
MacOS
```
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues | bug | low | Critical |
2,591,532,639 | deno | `deno remove` doesn't remove the package from node_modules folder | Version: Deno 2.0.0 | bug,node compat | low | Major |
2,591,625,624 | material-ui | InfoOutlineRounded | ### Summary
I saw that almost all Icons for warnings have a Rounded Outline Version only the one for the Info Icon is missing.
Can you please add the InfoOutlineRounded Icon?
import InfoRoundedIcon from '@mui/icons-material/InfoRounded';
import HelpOutlineRoundedIcon from '@mui/icons-material/HelpOutlineRounded';
### Examples
https://mui.com/material-ui/material-icons/?theme=Rounded&query=Info
### Motivation
_No response_
**Search keywords**: material-icons | package: icons,enhancement | low | Minor |
2,591,676,482 | ui | [feat]: Drawer Component: Auto-Adjust Handle Position to Match Swipe Direction | ### Feature description
I would a small improvement to the drawer component when we change the direction. i think that small div at the top should move automatically to the right and becomes vertical in the case where the `direction == 'left'`, same goes for other directions, it should adapt to reflect the current swiping direction
here is a figure that illustrate the idea
### Affected component/components
drawer
### Additional Context
Additional details here...
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues and PRs | area: request | low | Minor |
2,591,686,724 | next.js | Unable to use imported objects from client components in server components | ### Link to the code that reproduces this issue
https://stackblitz.com/edit/stackblitz-starters-xotxrf?file=app%2Fpage.tsx
### To Reproduce
1. Start the application in Development
1. Check the logs for a log of test string that gets imported from the `ClientComponent.tsx`
1. Notice that instead of seeing the string, you see `null`
2. Notice that, if the `console.log` on line 4 of `page.tsx` is commented and then uncommented, you do see the test string in the logs on the first render
### Current vs. Expected behavior
Currently, It looks like imports from client components into server component are proxied. I would expect to be able to import and use an object or other primitive from a client component, in any other component.
This bug was previously reported in https://github.com/vercel/next.js/issues/66212, and supposedly fixed in https://github.com/vercel/next.js/pull/66990, but from testing it seems to still be a problem, both with and without turbopack.
From the issue that previously reported this:
>This used to work prior to Next.js 14 (13.5.6) but for some reason doesn't work now. I have an inkling as to why (bundling and wanting to separate the interweaving of client and server components) but this break a pattern we use for colocating queries (GraphQL, GROQ etc.) with our components.
>
>If anybody can point me to somewhere in the Next.js documentation explaining this behavior I would appreciate it as right now this type of bundling breaks everything I expect out of ES Modules.
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 24.0.0: Mon Aug 12 20:52:12 PDT 2024; root:xnu-11215.1.10~2/RELEASE_ARM64_T6020
Available memory (MB): 32768
Available CPU cores: 10
Binaries:
Node: 20.18.0
npm: 10.8.2
Yarn: 1.22.22
pnpm: 9.12.1
Relevant Packages:
next: 15.0.0-rc.1
eslint-config-next: 15.0.0-rc.1
react: 19.0.0-rc-83825814-20241015
react-dom: 19.0.0-rc-83825814-20241015
typescript: 5.6.3
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Runtime, Turbopack
### Which stage(s) are affected? (Select all that apply)
next dev (local), next build (local), Vercel (Deployed)
### Additional context
I understand the fix has been reverted from 14 due to it being a breaking change, but I'm expecting it to be there in canary. | bug,Runtime,Turbopack | low | Critical |
2,591,730,962 | vscode | debug.onDidChangeActiveDebugSession not always fired when active session implicitly changes after old active session terminated | <!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions -->
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
<!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. -->
<!-- 🔧 Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes
<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. -->
<!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->
- VS Code Version: 1.94.1 (Universal)
- OS Version: Sequoia 15.0.1
Version: 1.94.1 (Universal)
Commit: e10f2369d0d9614a452462f2e01cdc4aa9486296
Date: 2024-10-05T05:44:32.189Z
Electron: 30.5.1
ElectronBuildId: 10262041
Chromium: 124.0.6367.243
Node.js: 20.16.0
V8: 12.4.254.20-electron.0
OS: Darwin arm64 24.0.0
Steps to Reproduce:
1. Subscribe to `debug.onDidTerminateDebugSession` and `debug.onDidChangeActiveDebugSession`
2. Start two debug sessions.
3. Click on the second one in the call stack view to make it active.
4. Press terminate on the second session via the popup button in the call stack view
Correctly receive the `terminate` event but not always a `active session changed` event.
When the second session is killed, the UI correctly reverts to show the state of the first session - so it is now de facto the active one. E.g. variables and buttons update. The combo box in the toolbar updates to reflect the only remaining session (but doesn't disappear, despite there being only one session to show).
It causes us a problem as we have our own custom debug type and a UI panel that we update to reflect the active debug session, showing a diagram relevant to the active session (if one of ours). When the second session is terminated and the first one becomes active by default, we should update the UI as well, but we don't get the event. And because the vscode UI has de facto changed to have the first one active (but without firing an event), there isn't anything the user can do that will trigger that event to fire.
I'm running our extension from vscode in the extension host.
| bug,debug | low | Critical |
2,591,738,819 | deno | Deno compile could not resolve `fork` in a right way maybe? | # Version
```
deno 2.0.0 (stable, release, x86_64-unknown-linux-gnu)
v8 12.9.202.13-rusty
typescript 5.6.2
```
# Problem Description
Suppose there are two files main.js and echo.js
I use `fork` of `node:child_process` to fork `echo.js` in `main.js` and then use
`createServer` of `node:net` to create a socket server and listen at `127.0.0.1:7788`,
=== 1. It will be working well if I just run `deno run -A main.js`
```bash
cus :: ~/app/tttttttttttt » deno run -A main.js
Listening on 127.0.0.1:7788
hello
hello
```
=== 2. But if I use `deno compile -A` and then run the executable file, `EADDRINUSE` will happen.
server
```
cus :: ~/app/tttttttttttt » ./main
Listening on 127.0.0.1:7788
error: Uncaught Error: listen EADDRINUSE: address already in use 127.0.0.1:7788
at __node_internal_captureLargerStackTrace (ext:deno_node/internal/errors.ts:93:9)
at __node_internal_uvExceptionWithHostPort (ext:deno_node/internal/errors.ts:124:10)
at Server._setupListenHandle [as _listen2] (node:net:1180:16)
at _listenInCluster (node:net:1012:12)
at doListen (node:net:1022:7)
at Array.processTicksAndRejections (ext:deno_node/_next_tick.ts:39:15)
at eventLoopTick (ext:core/01_core.js:172:29)
error: Uncaught Error: Channel closed
at ChildProcess.target.send (ext:deno_node/internal/child_process.ts:1185:19)
at Server.<anonymous> (file:///tmp/deno-compile-main/tttttttttttt/main.js:12:9)
at Server.emit (ext:deno_node/_events.mjs:393:28)
at TCP._onconnection (node:net:1127:8)
at TCP.#accept (ext:deno_node/internal_binding/tcp_wrap.ts:356:12)
at eventLoopTick (ext:core/01_core.js:175:7)
cus :: ~/app/tttttttttttt 1 »
```
client
```
~ » telnet 127.0.0.1 7788
Trying 127.0.0.1...
Connected to 127.0.0.1.
Escape character is '^]'.
Connection closed by foreign host.
```
It looks that `deno compile` could not make fork and listen work together.
# Minimal Reproducible Implementation
echo.js
```js
import process from 'node:process';
let shouldQuit = false;
process.on('message', (data) => {
if (data.action === 'quit') {
shouldQuit = true;
return;
}
if (data.action === 'request') {
process.send({ action: 'response', data: data.data });
}
});
(async () => {
while (true) {
if (shouldQuit) {
break;
}
await new Promise((rs) => {
setTimeout(() => {
rs();
}, 1004);
});
}
})();
```
main.js
```js
import { fork } from 'node:child_process';
import { createServer } from 'node:net';
const child = fork('./echo.js');
child.on('message', (data) => {
if (data.action === 'response') {
console.log(data.data);
}
});
const server = createServer((localSocket) => {
child.send({ action: 'request', data: 'hello' });
localSocket.write('You connected, and you disconnect now.\n');
localSocket.destroy();
});
const LOCAL_PORT = 7788;
server.listen(LOCAL_PORT, '127.0.0.1', () => {
console.log(`Listening on 127.0.0.1:${LOCAL_PORT}`);
});
```
| bug,needs info,compile | low | Critical |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.