id int64 393k 2.82B | repo stringclasses 68
values | title stringlengths 1 936 | body stringlengths 0 256k ⌀ | labels stringlengths 2 508 | priority stringclasses 3
values | severity stringclasses 3
values |
|---|---|---|---|---|---|---|
2,635,966,422 | tensorflow | [TFLite/LiteRT] Conv3D does not support acceleration | **System information**
- TensorFlow Python version: 2.17.
- TensorFlow Android versions:
```
implementation 'org.tensorflow:tensorflow-lite:2.16.1'
implementation 'org.tensorflow:tensorflow-lite-select-tf-ops:2.16.1'
implementation 'org.tensorflow:tensorflow-lite-gpu:2.16.1'
implementation 'org.tensorflow:tensorflow-lite-gpu-api:2.16.1'
```
**Summary**
I am trying to speed up a model which is mostly made up of `Conv3D` operators on Android (for video classification). As far as I understand, neither the GPU delegate nor the quantization mechanism support `Conv3D`, so I am stuck with just running the full-precision model on CPU.
Am I missing some other ways I could use to accelerate this? If not, could this be a feature request for supporting a way?
Some performance numbers from my tests (one model pass):
* LiteRT, CPU-only, Android (Galaxy S10+): ~1400ms
* LiteRT, CPU-only, iOS (iPhone 13 Pro): ~700ms
* CoreML, accelerated, iOS, `float32` (same phone): ~160ms
* CoreML, accelerated, iOS, `float16`) (same phone): ~15ms | stat:awaiting tensorflower,type:feature,comp:lite,2.17 | medium | Major |
2,635,967,726 | yt-dlp | 增加网站支持/Enhance website compatibility：http://www.docuchina.cn/ | ### DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE
- [X] I understand that I will be **blocked** if I *intentionally* remove or skip any mandatory\* field
### Checklist
- [X] I'm reporting a new site support request
- [X] I've verified that I have **updated yt-dlp to nightly or master** ([update instructions](https://github.com/yt-dlp/yt-dlp#update-channels))
- [X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
- [X] I've checked that none of provided URLs [violate any copyrights](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#is-the-website-primarily-used-for-piracy) or contain any [DRM](https://en.wikipedia.org/wiki/Digital_rights_management) to the best of my knowledge
- [x] I've searched [known issues](https://github.com/yt-dlp/yt-dlp/issues/3766) and the [bugtracker](https://github.com/yt-dlp/yt-dlp/issues?q=) for similar issues **including closed ones**. DO NOT post duplicates
- [X] I've read the [guidelines for opening an issue](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#opening-an-issue)
- [X] I've read about [sharing account credentials](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#are-you-willing-to-share-account-details-if-needed) and am willing to share it if required
### Region
中国China
### Example URLs
http://www.docuchina.cn/
http://www.docuchina.cn/2014/01/21/VIDE1390293257217732.shtml
### Provide a description that is worded well enough to be understood
无法从这个网站下载视频，希望增加对这个网站的支持
Unable to download videos from this website; please consider adding support for it.
http://www.docuchina.cn/
### Provide verbose output that clearly demonstrates the problem
- [X] Run **your** yt-dlp command with **-vU** flag added (`yt-dlp -vU <your command line>`)
- [X] If using API, add `'verbose': True` to `YoutubeDL` params instead
- [X] Copy the WHOLE output (starting with `[debug] Command-line config`) and insert it below
### Complete Verbose Output
```shell
[debug] Command-line config: ['-vU', 'http://www.docuchina.cn/2014/01/21/VIDE1390293257217732.shtml']
[debug] Encodings: locale cp936, fs utf-8, pref cp936, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version stable@2024.11.04 from yt-dlp/yt-dlp [197d0b03b] (win_exe)
[debug] Python 3.10.11 (CPython AMD64 64bit) - Windows-10-10.0.19041-SP0 (OpenSSL 1.1.1t 7 Feb 2023)
[debug] exe versions: ffmpeg 7.0-full_build-www.gyan.dev (setts), ffprobe 7.0-full_build-www.gyan.dev
[debug] Optional libraries: Cryptodome-3.21.0, brotli-1.1.0, certifi-2024.08.30, curl_cffi-0.5.10, mutagen-1.47.0, requests-2.32.3, sqlite3-3.40.1, urllib3-2.2.3, websockets-13.1
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests, websockets, curl_cffi
[debug] Loaded 1838 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version: stable@2024.11.04 from yt-dlp/yt-dlp
yt-dlp is up to date (stable@2024.11.04 from yt-dlp/yt-dlp)
[generic] Extracting URL: http://www.docuchina.cn/2014/01/21/VIDE1390293257217732.shtml
[generic] VIDE1390293257217732: Downloading webpage
WARNING: [generic] Falling back on generic information extractor
[generic] VIDE1390293257217732: Extracting information
[debug] Looking for embeds
ERROR: Unsupported URL: http://www.docuchina.cn/2014/01/21/VIDE1390293257217732.shtml
Traceback (most recent call last):
File "yt_dlp\YoutubeDL.py", line 1625, in wrapper
File "yt_dlp\YoutubeDL.py", line 1760, in __extract_info
File "yt_dlp\extractor\common.py", line 742, in extract
File "yt_dlp\extractor\generic.py", line 2553, in _real_extract
yt_dlp.utils.UnsupportedError: Unsupported URL: http://www.docuchina.cn/2014/01/21/VIDE1390293257217732.shtml
```
| site-enhancement,patch-available | low | Critical |
2,635,984,391 | rust | Add a `dont-check-error-annotations` to compiletest | cc @jieyouxu
It would be nice if compiletest could support a `//@ dont-check-error-annotations` annotation that would not require you to annotate your file with `//~^ ERROR:` anywhere. This would be useful for cases where I only care that the test doesn't start ICEing. Ideally we'd never need this but sometimes I wind up with hundreds of errors with useless spans and it's just not realistic (or helpful) to annotate it all. See for example [this test](https://gist.github.com/BoxyUwU/fcb293a503e1b577a0c05d4094093de2), all the error annotations are in the wrong place as macro diagnostics emit the error on the *macro definition* not the *caller*. This means that we'd wind up with ~100 error annotations on the insides of the macros which is not a helpful assertion whatsoever. | T-bootstrap,C-feature-request,A-compiletest | low | Critical |
2,635,987,407 | rust | 'Expected <function pointer>, found <function item>' diagnostic could explicitly suggest casting | ### Code
```rs
fn foo() -> usize {
0
}
fn bar() -> usize {
1
}
fn main() {
let _x: Vec<(&str, fn() -> usize)> = [("foo", foo)].into_iter().collect();
}
```
### Current output
```rs
error[E0277]: a value of type `Vec<(&str, fn() -> usize)>` cannot be built from an iterator over elements of type `(&str, fn() -> usize {foo})`
--> src/main.rs:10:69
|
10 | let _x: Vec<(&str, fn() -> usize)> = [("foo", foo)].into_iter().collect();
| ^^^^^^^ value of type `Vec<(&str, fn() -> usize)>` cannot be built from `std::iter::Iterator<Item=(&str, fn() -> usize {foo})>`
|
= help: the trait `FromIterator<(&str, fn() -> usize {foo})>` is not implemented for `Vec<(&str, fn() -> usize)>`
= help: the trait `FromIterator<(&str, fn() -> usize)>` is implemented for `Vec<(&str, fn() -> usize)>`
= help: for that trait implementation, expected `fn() -> usize`, found `fn() -> usize {foo}`
```
### Desired output
```rs
error[E0277]: a value of type `Vec<(&str, fn() -> usize)>` cannot be built from an iterator over elements of type `(&str, fn() -> usize {foo})`
--> src/main.rs:10:69
|
10 | let _x: Vec<(&str, fn() -> usize)> = [("foo", foo)].into_iter().collect();
| ^^^^^^^ value of type `Vec<(&str, fn() -> usize)>` cannot be built from `std::iter::Iterator<Item=(&str, fn() -> usize {foo})>`
|
= help: the trait `FromIterator<(&str, fn() -> usize {foo})>` is not implemented for `Vec<(&str, fn() -> usize)>`
= help: the trait `FromIterator<(&str, fn() -> usize)>` is implemented for `Vec<(&str, fn() -> usize)>`
= help: for that trait implementation, expected `fn() -> usize`, found `fn() -> usize {foo}`
= help: consider casting the fn item to a fn pointer using `as fn() -> usize`
```
### Rationale and extra context
If we add a second entry in the array, we get a type check error suggesting this:
```rs
--> src/main.rs:10:65
|
10 | let _x: Vec<(&str, fn() -> usize)> = [("foo", foo), ("bar", bar)].into_iter().collect();
| ^^^ expected fn item, found a different fn item
|
= note: expected fn item `fn() -> _ {foo}`
found fn item `fn() -> _ {bar}`
= note: different fn items have unique types, even if their signatures are the same
= help: consider casting both fn items to fn pointers using `as fn() -> usize`
```
This can lead to a confusing diagnostic if one is not aware of the distinction between fn items and pointers
### Other cases
_No response_
### Rust Version
$ rustc 1.84.0-nightly (662180b34 2024-10-20)
binary: rustc
commit-hash: 662180b34d95f72d05b7c467b0baf4d23d36b1e1
commit-date: 2024-10-20
host: x86_64-unknown-linux-gnu
release: 1.84.0-nightly
LLVM version: 19.1.1
### Anything else?
_No response_
<!-- TRIAGEBOT_START -->
<!-- TRIAGEBOT_ASSIGN_START -->
<!-- TRIAGEBOT_ASSIGN_DATA_START$${"user":"mu001999"}$$TRIAGEBOT_ASSIGN_DATA_END -->
<!-- TRIAGEBOT_ASSIGN_END -->
<!-- TRIAGEBOT_END --> | A-diagnostics,T-compiler,D-confusing | low | Critical |
2,635,996,230 | kubernetes | :elephant: Switch away from obsolete package `github.com/grpc-ecosystem/go-grpc-prometheus` | See note on the package
```
⚠️ This project is depreacted and archived as the functionality moved to [go-grpc-middleware](https://github.com/grpc-ecosystem/go-grpc-middleware) repo
since [provider/prometheus@v1.0.0-rc.0](https://github.com/grpc-ecosystem/go-grpc-middleware/releases/tag/providers%2Fprometheus%2Fv1.0.0-rc.0) release.
You can pull it using go get github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus. The API is simplified and morernized, yet functionality
is similar to what v1.2.0 offered. All questions and issues you can submit [here](https://github.com/grpc-ecosystem/go-grpc-middleware/issues).
```
/sig instrumentation | sig/instrumentation,area/code-organization,needs-triage | low | Minor |
2,636,000,323 | rust | Tracking issue for release notes of #132515: Fix and undeprecate home_dir() |
This issue tracks the release notes text for #132515.
### Steps
- [x] Proposed text is drafted by PR author (or team) making the noteworthy change.
- [ ] Issue is nominated for release team review of clarity for wider audience.
- [ ] Release team includes text in release notes/blog posts.
### Release notes text
The responsible team for the underlying change should edit this section to replace the automatically generated link with a succinct description of what changed, drawing upon text proposed by the author (either in discussion or through direct editing).
````markdown
# Libraries
- [Fix and undeprecate home_dir()](https://github.com/rust-lang/rust/pull/132515)
# Compatibility Notes
- `std::env::home_dir()` has been deprecated for years, because it can give surprising results in some Windows configurations if the `HOME` environment variable is set (which is not the normal configuration on Windows). We had previously changed its behavior, out of concern for compatibility with code depending on this non-standard configuration. Given how long this function has been deprecated, we're now fixing its behavior as a bugfix, and the next version will undeprecate it. (We deferred undeprecating it on nightly until today's stable release, to avoid potential confusion between the fixed version on nightly and the previously unfixed version on stable.)
````
> [!TIP]
> Use the [previous releases](https://doc.rust-lang.org/nightly/releases.html) categories to help choose which one(s) to use.
> The category will be de-duplicated with all the other ones by the release team.
>
> *More than one section can be included if needed.*
### Release blog section
If the change is notable enough for inclusion in the blog post, the responsible team should add content to this section.
*Otherwise leave it empty.*
````markdown
`std::env::home_dir()` has been deprecated for years, because it can give surprising results in some Windows configurations if the `HOME` environment variable is set (which is not the normal configuration on Windows). We had previously changed its behavior, out of concern for compatibility with code depending on this non-standard configuration. Given how long this function has been deprecated, we're now fixing its behavior as a bugfix, and the next version will undeprecate it. (We deferred undeprecating it on nightly until today's stable release, to avoid potential confusion between the fixed version on nightly and the previously unfixed version on stable.)
````
cc @kornelski, @jhpratt -- origin issue/PR authors and assignees for starting to draft text
| O-windows,T-libs-api,relnotes,relnotes-tracking-issue | low | Critical |
2,636,034,066 | godot | Auto insert keys loses node focus after rotation via handle | ### Tested versions
- Reproducible in v4.3.stable.official [77dcf97d8]
### System information
Godot v4.3.stable - Ubuntu 22.04.4 LTS 22.04 - X11 - GLES3 (Compatibility) - NVIDIA GeForce GTX 860M (nvidia; 535.183.01) - Intel(R) Core(TM) i7-4710HQ CPU @ 2.50GHz (8 Threads)
### Issue description
When recording an animation uses auto insert key (red "rec" button active), and registering rotation changes (diamond "rot" button active), every time user rotates a node using the Rotate handle (E), user loses focus of the nodes, and need to click again on the node for further operations. This prevents repeatedly changing rotation to see what the animation will look like.
### Steps to reproduce
- Create an Animation Player with some dummy nodes to rotate
- Create a dummy animation
- Enable auto insert key (red rec button) and rotation mask (diamond rot button)
- Select a node and enter Rotate mode (E)
- Drag mouse to rotate the node
Expected: user keeps focus of node
Actual: user loses focus of node, clicking once more on the scene view will not rotate node and will drag select a rectangle instead
### Minimal reproduction project (MRP)
N/A | bug,topic:animation | low | Minor |
2,636,059,879 | flutter | CI has misconfigured Android emulators | https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8733083598586544001/+/u/start_avd/Start_Android_emulator__android_35_google_apis_x64.textpb_/raw_io.output_text
```
I1025 11:14:42.233939 48863 IniFile.cpp:450] Malformed int value 96M for key hw.ramSize
I1025 11:14:42.234009 48863 IniFile.cpp:450] Malformed int value 32M for key vm.heapSize
```
That's bad for 2 reasons.
First, the ramSize and heapSize should be Integer, and size in MegaBytes. Putting "96M" will not be correct, hence the error message.
Second, 96MB of Ram and 32MB of Vm Heap will be very low.
On the other hand, because of this misconfiguration, the system will use default values. We can see later in the log
```
I1025 11:14:42.243638 48863 main-common.c:1280] Increasing RAM size to 2048MB
D1025 11:14:42.243644 48863 main-common.c:1312] VM heap size 0MB is below hardware specified minimum of 512MB,setting it to that value
```
hence having those wrong values shouldn't be a problem.
In this log sent, did the emulator crashed ? | P3,team-android,triaged-android | low | Critical |
2,636,076,342 | flutter | [Impeller] libImpeller: Find default font files on Android. | Today, the font files need to be explicitly specified. The mechanism exists but needs to be wired up. | P2,e: impeller,team-engine,triaged-engine,e: libimpeller | low | Minor |
2,636,088,975 | rust | Misleading error messages when using the wrong macro fragment specifiers | Issue:
```rust
#[rustfmt::skip]
mod issue {
struct SomeType<T>(std::marker::PhantomData<T>);
macro_rules! test {
($ty:ty) => {
impl<$ty,> SomeType<$ty> {}
};
}
// Works fine
impl<T,> SomeType<T> {}
// error: expected one of `>` or `as`, found `,`
// --> src\lib.rs:7:21
// |
// 7 | impl<$ty,> SomeType<$ty> {}
// | ^ expected one of `>` or `as`
// ...
// 12 | test!(T);
// | -------- in this macro invocation
test!(T);
macro_rules! test2 {
($ty:ty) => {
impl<$ty> SomeType<$ty> {}
};
}
// Works fine
impl<T> SomeType<T> {}
// error: expected `::`, found `SomeType`
// --> src\lib.rs:17:23
// |
// 17 | impl<$ty> SomeType<$ty> {}
// | ^^^^^^^^ expected `::`
// ...
// 22 | test2!(T);
// | --------- in this macro invocation
test2!(T);
}
```
The macro should behave exactly like its manual expansion would; I've inlined the reported problems into the code.
### Meta
The error happens in both stable and nightly toolchains, on linux and windows
`rustc --version --verbose`:
```
rustc 1.82.0 (f6e511eec 2024-10-15)
binary: rustc
commit-hash: f6e511eec7342f59a25f7c0534f1dbea00d01b14
commit-date: 2024-10-15
host: x86_64-pc-windows-msvc
release: 1.82.0
LLVM version: 19.1.1
```
| A-diagnostics,A-macros,D-confusing | low | Critical |
2,636,131,290 | flutter | Make `ErrorWidget`'s text selectable | # Problem
When an assertion is triggered, it is displayed using the `ErrorWidget`.
Unfortunately, its text is unselectable - I cannot copy it to search the internet for help.
# Solution
Ideas:
1. Make the `ErrorWidget`'s text selectable
2. Add a link to Google that searches for the error
# Example scenario
This app has a bad container that provides both a `color` and a `decoration` in a `Container`:
```dart
import 'package:flutter/material.dart';
void main() => runApp(MyApp());
class MyApp extends StatelessWidget {
@override
Widget build(BuildContext context) {
return Container(
color: Colors.blue,
decoration: BoxDecoration(
color: Colors.blue,
),
);
}
}
```
Result:
| c: new feature,framework,c: proposal,P3,team-framework,triaged-framework | low | Critical |
2,636,137,354 | angular | Invalid check in router/url_tree/parseParens | ### Which @angular/* package(s) are the source of the bug?
router
### Is this a regression?
No
### Description
The `parseParens` method in url_tree.ts has a sanity check that checks if segment group is properly closed or not.
https://github.com/angular/angular/blob/c22b5accdd083f3bdc4141431cece196f0e33112/packages/router/src/url_tree.ts#L711-L718
This check does not pass when the segment group is defining an outlet with a path and children. For example:
```
/Home(app:Welcome//dock:left(1:One;pinned//2:Two;below=1//3:Three;pinned;above=2//4:Four))
```
In this case, after matching the outlet and its segments (`dock:left`), the next character is a `(` to specify the children.
### Please provide a link to a minimal reproduction of the bug
_No response_
### Please provide the exception or error you saw
_No response_
### Please provide the environment you discovered this bug in (run `ng version`)
_No response_
### Anything else?
_No response_ | area: router,router: aux routes | low | Critical |
2,636,187,696 | next.js | tsconfigPath is not supported by Turbopack | ### Link to the code that reproduces this issue
https://github.com/seanparmelee/nextjs-tsconfigpath
### To Reproduce
1. Run `npm run dev:turbo`
2. Navigate to http://localhost:3000/
3. You should see the error `Module not found: Can't resolve '@/components/Hello'`
4. Stop the server
5. Run `npm run dev`
6. Navigate to http://localhost:3000/
7. Confirm the page renders successfully
### Current vs. Expected behavior
When using Turbopack (`npm run dev:turbo`), modules referenced via the configured path alias cannot be found; presumably because Turbopack doesn't support the `typescript.tsconfigPath` Next.js config option.
When not using Turbopack (`npm run dev`), the aliased modules are resolved successfully.
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 23.6.0: Wed Jul 31 20:49:39 PDT 2024; root:xnu-10063.141.1.700.5~1/RELEASE_ARM64_T6000
Available memory (MB): 32768
Available CPU cores: 10
Binaries:
Node: 22.11.0
npm: 10.9.0
Yarn: N/A
pnpm: 8.15.2
Relevant Packages:
next: 15.0.3-canary.6 // Latest available version is detected (15.0.3-canary.6).
eslint-config-next: N/A
react: 19.0.0-rc-7c8e5e7a-20241101
react-dom: 19.0.0-rc-7c8e5e7a-20241101
typescript: 5.3.3
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Turbopack
### Which stage(s) are affected? (Select all that apply)
next dev (local)
### Additional context
_No response_ | bug,Turbopack,linear: turbopack | low | Critical |
2,636,226,780 | vscode | Add support for adding `svg` as attachments | 
| feature-request,panel-chat | low | Minor |
2,636,230,609 | flutter | Feature Request: Add Parameter to Control Tooltip Dismissal Behavior | ### Use case
**Description:** I would like to propose an enhancement to the existing Tooltip widget in Flutter to provide developers with the ability to control the dismissal behavior of tooltips more effectively.
**Current Behavior:** The default behavior of the Tooltip widget is that it remains visible even when the mouse hovers over the tooltip itself. This can lead to situations where the tooltip persists longer than desired, especially when the user moves the cursor from the target widget directly to the tooltip.
### Proposal
**Proposed Enhancement:** Add a parameter to the Tooltip widget that allows developers to specify whether the tooltip should dismiss immediately when the mouse leaves the target widget, even if the mouse enters the tooltip. This could be achieved by introducing a boolean parameter such as dismissOnHoverExit:
```dart
Tooltip(
message: 'This is a tooltip',
dismissOnHoverExit: true, // New parameter to control dismissal behavior
)
```
**Use Case:** This enhancement would be particularly useful for applications where tooltips are used for short instructions or contextual help, improving user experience by avoiding unnecessary delays in tooltip dismissal.
**Example Scenario:** When the user hovers over a button with a tooltip, the tooltip appears as expected. However, if the user then moves the mouse away from the button and onto the tooltip, the tooltip should disappear immediately rather than remaining visible.
**Conclusion:** I believe that this enhancement would provide developers with greater flexibility in how tooltips are used within their applications, ultimately leading to a better user experience. Thank you for considering this feature request! | c: new feature,framework,f: material design,c: proposal,P3,team-design,triaged-design | low | Major |
2,636,247,183 | terminal | Copilot chat loses input when dismissed and reloaded | ### Windows Terminal version
1.23.3091.0
### Windows build number
10.0.26100.0
### Other Software
_No response_
### Steps to reproduce
@DHowett told me to bind copilot chat to <kbd>shift</kbd>+<kbd>/</kbd> which I thought was an alright idea.
That is... until I tried to type a question mark at the end of my query for Copilot to answer... which rightfully dismissed the input box.
However, when I brought it back up again.... everything I typed was gone.
### Expected Behavior
I would have expected the box to preserve and keep my input through to reopening the dialog.
### Actual Behavior
The input on Copilot chat is empty on every launch, even if it was dismissed with content inside it. | Issue-Bug,Product-Terminal,Needs-Tag-Fix,Area-Chat | low | Minor |
2,636,268,520 | godot | Script sidepanel toggle is permanent with ctrl + \ but only temporary with the bottom left arrow | ### Tested versions
v4.4.dev3.official [f4af8201b]
### System information
Godot v4.4.dev3 - Windows 10.0.19045 - Multi-window, 9 monitors - OpenGL 3 (Compatibility) - NVIDIA GeForce RTX 3070 (NVIDIA; 32.0.15.6590) - 11th Gen Intel(R) Core(TM) i9-11900K @ 3.50GHz (16 threads)
### Issue description
Using ctrl + \ to toggle the script panel or right clicking to toggle/hide it is a permanent state change upon reloads.
The bottom left arrow to show or hide the panel is a temporary change across reloads.
### Steps to reproduce
Click bottom left arrow to hide panel, reload the project, it will be visible again
Ctrl + \ to hide the panel, reload the project, and it will stay hidden
https://github.com/user-attachments/assets/e3eb7c2d-8078-4992-b1b4-a77fbd6c7d3b
### Minimal reproduction project (MRP)
[mrp_script_sidepanel_state.zip](https://github.com/user-attachments/files/17637369/mrp_script_sidepanel_state.zip)
| bug,topic:editor | low | Minor |
2,636,269,771 | flutter | Give a non-nullable context to ContextAction's invoke() | ### Use case
The Actions API introduced `ContextAction` a few years ago: https://docs.google.com/document/d/1A9yald55O_C6Weqp4tOtyMisfOC1ZC0UMq7Yc-pNfVQ/edit?tab=t.0
The API is:
```
@override
bool isEnabled(T intent, [BuildContext? context]) => super.isEnabled(intent);
@protected
@override
Object? invoke(T intent, [BuildContext? context]);
```
There are three possible cases for the usage of a context in an action:
1. An `Action` doesn't use a `BuildContext`, (and can subclass `Action` if this is the case)
2. An `Action` requires a `BuildContext` to do its function
3. An `Action` may use a `BuildContext` but can fall back somehow without it
In practice case 3 seems rare, but the ergonomics of the common case 2 are hampered by needing to work around the nullable `BuildContext` when the `BuildContext` is required for the action to do its primary function. Implementations need an out-of-band error handling mechanism. It appears that a `BuildContext` is always provided, but it isn't clear if it's safe to assume that or if rare bugs could be introduced.
We could introduce a convention of marking the action as disabled when the context is null, then use '!' on the context argument, but this isn't ideal.
### Proposal
* Make clear in API docs if and when a context can actually be missing
* Introduce a new API something like `RequiredContextAction` which has a non-nullable Context and make it impossible to invoke those actions without one (and/or schedule a breaking API change to update `ContextAction`)
| c: new feature,framework,d: api docs,c: proposal,P3,team-framework,triaged-framework | low | Critical |
2,636,303,581 | TypeScript | VSCode auto-import ignores typescript.preferences.importModuleSpecifierEnding when using a path from the package.json imports | <!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions -->
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
<!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. -->
<!-- 🔧 Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes
<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. -->
<!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->
- VS Code Version: 1.95.1
- OS Version: MacOS 14.7
---------
I have these settings in VSCode:
```
{
"javascript.preferences.importModuleSpecifierEnding": "minimal",
"typescript.preferences.importModuleSpecifierEnding": "minimal"
}
```
I have these setting in my package.json:
```
"imports": {
"#src": ["./src/index.ts", "./src/index/tsx"],
"#src/*": [
"./src/*",
"./src/*.ts",
"./src/*.tsx",
"./src/*/index.ts",
"./src/*/index.tsx"
]
},
```
I have these settings in my tsconfig.json
```
"target": "esnext",
"module": "esnext",
"moduleResolution": "bundler",
```
However, when I auto-import something that starts with `#src/`, it automatically appends a `.js` to the import (or a `.ts` if I have `allowImportingTsExtensions` on. This is ignoring my settings to use the minimum module specifier ending I set in VSCode.
It looks like the addition of the `.ts` functionality was added in this bugfix: https://github.com/microsoft/TypeScript/issues/52167. I'm not sure why it wasn't set to respect the vscode settings. | Needs More Info | low | Critical |
2,636,308,242 | go | compress/flate: TestBestSpeed failures | ```
#!watchflakes
default <- pkg == "compress/flate" && test == "TestBestSpeed"
```
Issue created automatically to collect these failures.
Example ([log](https://ci.chromium.org/b/8732086649999571185)):
=== RUN TestBestSpeed
=== PAUSE TestBestSpeed
=== CONT TestBestSpeed
— [watchflakes](https://go.dev/wiki/Watchflakes)
| NeedsInvestigation | low | Critical |
2,636,339,065 | go | x/tools/gopls: recognize templ user agent in telemetry | Templ language server uses gopls to process go syntax.
Currently, gopls spawned by Templ language server is not distinguishable from gopls editors manage directly.
As Templ is getting popular, I think it is beneficial for both gopls and templ teams to track templ's gopls usage more closely. Hopefully, this information can help when we need to track the protocol compatibility and minimize accidental breakages like in https://github.com/golang/vscode-go/issues/3435#issuecomment-2192862723.
In https://github.com/a-h/templ/pull/966 I am proposing to adjust the client info so we can record the chain of lsp participants. I use `;` but I am open to other characters. Or even other fields if there are.
Whatever format is chosen, we also need to adjust gopls side to process this format. For example,
https://github.com/golang/tools/blob/f1f7c26696be8f94198beafd05b36843515ac2ba/gopls/internal/cache/snapshot.go#L950
and telemetry. | gopls,Tools | low | Major |
2,636,350,554 | pytorch | compiling "input mutation" followed by "input mutation + aliasing" does not properly recompile | Noticed this after some discussion from https://github.com/pytorch/pytorch/pull/139555#discussion_r1828455360. Here is a small repro:
```
import torch
def f(x, y):
x.mul_(2)
return x + y
x1 = torch.ones(4)
y1 = torch.ones(4)
f_compiled = torch.compile(f, backend="aot_eager")
out1 = f_compiled(x1, y1)
base = torch.ones(8)
x2 = base[:4]
y2 = base[2:6]
# None of the inputs alias
out2 = f_compiled(x2, y2)
base_ref = torch.ones(8)
x2_ref = base_ref[:4]
y2_ref = base_ref[2:6]
# This should re-compile, since inputs now alias!
# But it does not
out2_ref = f(x2_ref, y2_ref)
print(out2_ref)
print(out2)
```
The problem is that on the second invocation, we have two inputs that alias each other, and are also mutated. We have some special logic in AOTAutograd to handle this case, by generating a "shared base" graph input, and regenerating the views inside of the graph so we can functionalize the mutations properly.
The problem though, is that we end up re-using the first graph (which does not have any aliasing), when we should be recompiling.
cc @ezyang @gchanan @zou3519 @kadeng @msaroufim @chauhang @penguinwu | high priority,triaged,oncall: pt2,module: guards | low | Minor |
2,636,390,535 | ui | [bug]: `init`/`add` commands break `tailwind.config.js` | ### Describe the bug
```
fontFamily: {
sans: [
'Work Sans',
'sans-serif',
'Calibri',
'Candara',
'Segoe',
'Segoe UI',
'Optima',
'Arial',
],
},
```
Becomes
```
fontFamily: {
sans: [\n 'Work Sans',\n 'sans-serif',\n 'Calibri',\n 'Candara',\n 'Segoe',\n 'Segoe UI',\n 'Optima',\n 'Arial',\n ]
},
```
### Affected component/components
CLI
### How to reproduce
Have multiple lines in your tw config and use the CLI
```
fontFamily: {
sans: [
// This breaks
'Work Sans',
],
},
```
```
fontFamily: {
sans: [
'Work Sans',
'Or this',
],
},
```
### Codesandbox/StackBlitz link
_No response_
### Logs
_No response_
### System Info
```bash
next 14/15
```
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues | bug | low | Critical |
2,636,395,209 | ui | [bug]: CLI breaks tailwind.config.ts | ### Describe the bug
```
fontFamily: {
sans: [
'Work Sans',
'sans-serif',
'Calibri',
'Candara',
'Segoe',
'Segoe UI',
'Optima',
'Arial',
],
},
```
Becomes
```
fontFamily: {
sans: [\n 'Work Sans',\n 'sans-serif',\n 'Calibri',\n 'Candara',\n 'Segoe',\n 'Segoe UI',\n 'Optima',\n 'Arial',\n ]
},
```
### Affected component/components
CLI
### How to reproduce
Have multiple lines in your tw config and use the CLI
```
fontFamily: {
sans: [
// This breaks
'Work Sans',
],
},
```
```
fontFamily: {
sans: [
'Work Sans',
'Or this',
],
},
```
### Affected component/components
CLI
### How to reproduce
Have multiple lines in your tw config and use the CLI
```
fontFamily: {
sans: [
// This breaks
'Work Sans',
],
},
```
```
fontFamily: {
sans: [
'Work Sans',
'Or this',
],
},
```
### Codesandbox/StackBlitz link
_No response_
### Logs
_No response_
### System Info
```bash
Next 14/15
```
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues | bug | low | Critical |
2,636,406,886 | pytorch | Speed up `DataLoader` worker start time for large datasets | ### 🚀 The feature, motivation and pitch
Startup time for `DataLoader` workers can be very slow when using a `Dataset` object of even moderate size. The reason is that each worker process is started serially in a loop, and for each worker we have to:
1. pickle the dataset
2. wait while we pipe the data to the worker
I've found we can greatly improve both of these issues by:
1. pre-pickling the dataset once before starting the workers
2. create all the worker processes first, then start them in threads, because `Process.start` is non-blocking
### Alternatives
(2) seems quite safe, (1) I haven't thought through the implications of incorporating this into the `DataLoader` itself, and is not that hard to implement on your own `Dataset` class with a manual method and `__setstate__`.
### Additional context
My use case is handling geospatial data (`pip install xarray dask zarr`):
```python
import pickle
import time
import xarray as xr
import torch
from torch.utils.data import Dataset, DataLoader
class XarrayDataset(Dataset):
def __init__(self, data):
self.data = data
self._len = data.time.size
def __len__(self):
return self._len
def __getitem__(self, idx):
sample = self.data.isel(time=idx)
temperature = torch.tensor(sample["2m_temperature"].values)
return temperature
if __name__ == "__main__":
ds = xr.open_zarr("gs://gcp-public-data-arco-era5/ar/1959-2022-6h-1440x721.zarr")
dataset = XarrayDataset(ds)
loader = DataLoader(
dataset,
multiprocessing_context="spawn",
num_workers=16,
)
start = time.time()
iterator = loader._get_iterator()
print(f"Time to start DataLoader: {time.time() - start:.2f}")
```
The pickled representation of the `xarray.Dataset` here is about 13MB, almost all of it in the `dask` graph representing the arrays.
On `main`, this takes **38s to start 16 workers**, but I've seen much worse with more complex dask graphs.
If we modify the dataloader to pickle the data once up front and then unpickle in each worker, this goes down to **20s**.
If we modify the dataloader to start the workers in separate threads, I get this down to **7s** without pre-pickling the data, and **3.5s** with it.
cc @andrewkho @divyanshk @SsnL @VitalyFedyunin @dzhulgakov | module: dataloader,triaged | medium | Major |
2,636,414,488 | next.js | redirect does not work when using multiple root layouts | ### Link to the code that reproduces this issue
https://github.com/llipengda/next-redirect-bug
### To Reproduce
1. next dev
2. click `/test-a`
3. click `redirect to /`
4. the page is navigated to /
5. click `/test-b`
6. click `redirect to /`
7. this does not work
### Current vs. Expected behavior
current: when clicking `redirect to /` in `/test-b`, `redirect` does not work.
expected: redirect to /
### Provide environment information
```bash
Operating System:
Platform: win32
Arch: x64
Version: Windows 11 Home China
Available memory (MB): 16164
Available CPU cores: 16
Binaries:
Node: 20.18.0
npm: 10.8.3
Yarn: 1.22.22
pnpm: 9.12.2
Relevant Packages:
next: 15.0.3-canary.6 // Latest available version is detected (15.0.3-canary.6).
eslint-config-next: N/A
react: 19.0.0-rc-7c8e5e7a-20241101
react-dom: 19.0.0-rc-7c8e5e7a-20241101
typescript: 5.3.3
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Navigation
### Which stage(s) are affected? (Select all that apply)
next dev (local), next start (local)
### Additional context
_No response_ | bug,Navigation | low | Critical |
2,636,428,946 | vscode | The "Source Control" panel is often out of sync with my git repo |
Type: <b>Bug</b>
Since upgrading, I've noticed that the "Source Control" panel does not stay in sync with my git repo. I find myself invoking "reload window" a lot throughout the day to fix the problem. This wasn't an issue before, but now I run into it constantly.
Example repro:
1. Add/modify files (through vscode or externally)
2. Source Control panel updates to show changes
3. Commit (from the command line)
4. Source Control panel still shows modified files until I "reload window"
VS Code version: Code 1.95.1 (65edc4939843c90c34d61f4ce11704f09d3e5cb6, 2024-10-31T05:14:54.222Z)
OS version: Windows_NT x64 10.0.22631
Modes:
<details>
<summary>System Info</summary>
|Item|Value|
|---|---|
|CPUs|11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz (8 x 2995)|
|GPU Status|2d_canvas: enabled<br>canvas_oop_rasterization: enabled_on<br>direct_rendering_display_compositor: disabled_off_ok<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>opengl: enabled_on<br>rasterization: enabled<br>raw_draw: disabled_off_ok<br>skia_graphite: disabled_off<br>video_decode: enabled<br>video_encode: enabled<br>vulkan: disabled_off<br>webgl: enabled<br>webgl2: enabled<br>webgpu: enabled<br>webnn: disabled_off|
|Load (avg)|undefined|
|Memory (System)|15.71GB (2.63GB free)|
|Process Argv|--log trace --crash-reporter-id 4c14e0ab-6323-4be2-8ea1-b8ae8d1b35aa|
|Screen Reader|no|
|VM|0%|
</details><details><summary>Extensions (10)</summary>
Extension|Author (truncated)|Version
---|---|---
copy-relative-path|ale|0.0.2
turbo-console-log|Cha|2.10.5
githistory|don|0.6.20
prettier-vscode|esb|11.0.0
gc-excelviewer|Gra|4.2.62
jenkins-declarative-support|jmM|0.1.0
code-groovy|mar|0.1.2
better-folding|Moh|0.5.1
color-highlight|nau|2.8.0
material-icon-theme|PKi|5.12.0
(1 theme extensions excluded)
</details><details>
<summary>A/B Experiments</summary>
```
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805:30301674
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
vscrpc:30673769
962ge761:30959799
pythongtdpath:30769146
pythonnoceb:30805159
asynctok:30898717
pythonmypyd1:30879173
h48ei257:31000450
pythontbext0:30879054
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
jg8ic977:31013176
dvdeprecation:31068756
dwnewjupytercf:31046870
impr_priority:31102340
nativerepl2:31139839
refactort:31108082
pythonrstrctxt:31112756
cf971741:31144450
iacca1:31171482
notype1cf:31157160
5fd0e150:31155592
dwcopilot:31170013
```
</details>
<!-- generated by issue reporter --> | bug,git | medium | Critical |
2,636,441,366 | godot | Reverb predelay does not separate dry from wet. | ### Tested versions
4.3 .Net , 4.4 Dev3 .Net
### System information
Win10 x64 22H2
### Issue description
Predelay in reverb means the time difference between the start of the audio sample (dry), and the start of the reverb effect (wet).
In reverb settings, assign Predelay to 0ms and Feedback to 0. Playing an audio source will have wet and dry play at the same time. Ok, good so far.
Assigning Predelay to the max value of 500ms STILL has wet and dry play at the same time, instead of playing wet 500ms after dry starts.
Maybe Feedback is the issue? Turn up Feedback to 0.5 and keep Predelay at 500ms. Play the sound again, and notice
1) Wet and dry still play at the same time instead of having 500ms delay between the two.
2) But now the whole reverb effect is repeated every Predelay time.
### Steps to reproduce
1) Open Godot, go to go to Audio tab and assign Reverb to the Master bus.
2) Crank up `room size` to 1 for reverb emphasis.
3) Set `damp` to 0 for clean reverb.
4) Set `wet` to 1 and `dry` to 0.5 to hear reverb better.
4) Set `predelay` to 0ms, and `feedback` to 0.
5) Add an audio source to the scene and play it.
6) Notice Wet and Dry play at the same time. This is correct since there is 0ms predelay between the two.
7) Set 500ms predelay, and play the audio again.
8) Notice Wet and Dry still play at the same time. This is wrong because there should be 500ms delay between Wet and Dry. Perhaps `feedback` needs to be non-zero?
9) Set `feedback` to 0.5, and replay audio.
10) Notice Wet and Dry still play at the same time, but the reverb effect repeats every predelay time. This is also wrong.
### Minimal reproduction project (MRP)
n/a | bug,topic:audio | low | Major |
2,636,475,875 | pytorch | Support scalar tensor in `value` arg of foreach op | ### 🚀 The feature, motivation and pitch
In https://github.com/pytorch/pytorch/pull/134171/files#r1805348159 there is a limitation with supporting scalar tensors in the `value` arg of foreach ops, and this results in an unnecessary copy of all grads in the optimizer. Ideally, the foreach op can support scalar tensors as the value arg, since they can be transferred to the requisite device/passed as an arg to the kernel. This would permit the foreach ops to be more flexible.
### Alternatives
The current status quo is to separate out the value arg into a separate foreach op, which is worse for perf.
### Additional context
Overall this only matters if eager performance is paramount for the desired scenario. In this case, torch.compile will remove any of the additional overhead. This isn't urgent for any of my scenarios since all of them will utilize torch.compile to remove the additional overhead. However if in the future this is needed for some code in eager, there is no workaround to remove the overhead other than the alternative listed above.
cc @vincentqb @jbschlosser @albanD @janeyx99 @crcrpar @mcarilli | module: optimizer,triaged,module: mta | low | Major |
2,636,486,736 | ui | [feat]: Implement with browser-level APIs for better performance | ### Feature description
There are a few browser-level APIs that could deliver better page and user interaction performance compared to a JS implementation. Please consider adopting these APIs:
Popover (also used on this exact GitHub page you're viewing):
[https://developer.mozilla.org/en-US/docs/Web/API/Popover_API](https://developer.mozilla.org/en-US/docs/Web/API/Popover_API)
Anchor positioning:
[https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_anchor_positioning](https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_anchor_positioning)
Scroll-driven animations:
[https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_scroll-driven_animations](https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_scroll-driven_animations)
View transitions:
[https://developer.mozilla.org/en-US/docs/Web/API/View_Transitions_API](https://developer.mozilla.org/en-US/docs/Web/API/View_Transitions_API)
Customizable select element:
[https://open-ui.org/components/customizableselect/](https://open-ui.org/components/customizableselect/)
details element
[https://developer.mozilla.org/en-US/docs/Web/HTML/Element/details](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/details)
dialog element
[https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog)
### Affected component/components
popups, menus, buttons, etc.
### Additional Context
Additional details here...
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues and PRs | area: request | low | Major |
2,636,489,798 | flutter | Improve error if `BoxDecoration` has both a circle shape and a border radius | ### Use case
The following `BoxDecoration` is invalid:
```dart
BoxDecoration(
shape: BoxShape.circle,
borderRadius: BorderRadius.circular(3.0),
)
```
Using this decoration in a `DecoratedBox` widget will result in errors like:
```
════════ Exception caught by rendering library ═════════════════════════════════
'package:flutter/src/painting/box_decoration.dart': Failed assertion: line 419 pos 16: '_decoration.borderRadius == null': is not true.
The relevant error-causing widget was:
DecoratedBox ContainerDecorators|decoratedBox:file:///Users/loicsharma/Code/tmp/decorators_study/lib/sunflower/decorator.dart:121:8
The following RenderObject was being processed when the exception was fired: RenderDecoratedBox#a007e relayoutBoundary=up2
RenderObject: RenderDecoratedBox#a007e relayoutBoundary=up2
════════════════════════════════════════════════════════════════════════════════
````
It's not clear from this error what needs to be changed.
### Proposal
Add an assertion to `BoxDecoration`'s constructor that gives a helpful error like:
```
A circle cannot have a border radius. Remove either the shape or the borderRadius argument.
```
| framework,c: proposal,a: error message,P3,team-framework,triaged-framework | low | Critical |
2,636,516,946 | PowerToys | Surface Pro Slim Pen2 (and other similar Devices) | ### Description of the new feature / enhancement
Option to use it as presenter with using back side and side button as well as pen tip as buttons and the gyro to highlight and mouse pointer
### Scenario when this would be used?
Immediately in Powerpoint and other apps like video control (playback...)
### Supporting information
_No response_ | Needs-Triage | low | Minor |
2,636,517,556 | flutter | Migrate api 26 and 27 to arm based firebase test lab emulators | Notes here go/flutter-android-omni-lab-2024-11-05
TLDR forward looking migration that should have speed benefits
Needs to happen before End of q1 2025. | platform-android,P2,team-android,triaged-android,fyi-infra | low | Major |
2,636,520,699 | godot | Using load_threaded_request with sub_threads raises errors when requesting multiple scenes with scripts that access the same autoloaded node | ### Tested versions
Godot 4.3.stable
### System information
Mac OS Sequoia (15.1)
### Issue description
I was trying to implement a node that loads several scenes in the ResourceLoader's cache before the game starts, and I managed to get a crude implementation of what I wanted by following the documentation for ResourceLoader's `load_threaded_request` and `load_threaded_get_status` method.
However, when I tried to set`load_thread_request`'s third parameter (`use_sub_threads`) to true, several errors popped up on the console complaining that I was trying to call a function from a thread.
Trying to narrow down what was causing the issue, I noticed that it only happened under these circumstances:
- Registered some node as an autoload in the project's settings
- Started the threaded loading logic for more than 1 resource
- Said loaded resources tried to call a method from the global inside their scripts
- The errors pop up when the resources are loading, regardless of whether I instantiate them or not.
<img width="1087" alt="Screenshot 2024-11-05 at 4 23 32 PM" src="https://github.com/user-attachments/assets/5dc80fad-8d0a-4282-8cef-7d22fc1778c6">
While the game doesn't crash, I'm not sure if those errors would cause further problems down the road, or if a compiled version of the game would indeed start crashing.
Another issue I noticed is that only the first call of `load_threaded_get` returns the actual resource, any subsequent call returns `null`. Not sure if this is truly a bug or if there are some additional steps I need to take to query that resource again.
### Steps to reproduce
Just run the attached project, I've hooked the loading logic to the main scene's `_ready` call, you should see the errors pop up on the debugger, and the text `"finished loading"` should be printed on the console.
For the second issue: after that text appears, pressing the button on the screen prints the loaded resource for one specific scene, but any subsequent button press will instead print null.
### Minimal reproduction project (MRP)
[TestResourceLoader.zip](https://github.com/user-attachments/files/17638784/TestResourceLoader.zip)
This project tires to load all the scenes located inside the `Scenes` subfolder, and both `ChildScene.tscn` and `SecondChildScene.tscn` contain a script that tries to call a method from an autoloaded node called `RandomGlobal.tscn` | bug,topic:core | low | Critical |
2,636,521,831 | kubernetes | Query param decoding fails to default when query string is entirely unset | This was noticed by @knight42 and @thockin: https://github.com/kubernetes/kubernetes/pull/127360#discussion_r1828554485 | sig/api-machinery,triage/accepted | low | Minor |
2,636,524,711 | go | x/mobile/cmd/gobind: TestGobind/GOPATH failures | ```
#!watchflakes
default <- pkg == "golang.org/x/mobile/cmd/gobind" && test == "TestGobind/GOPATH"
```
Issue created automatically to collect these failures.
Example ([log](https://ci.chromium.org/b/8732529201876720369)):
=== RUN TestGobind/GOPATH
gobind_test.go:128: stat ../../.git/index.lock: no such file or directory
--- FAIL: TestGobind/GOPATH (0.16s)
— [watchflakes](https://go.dev/wiki/Watchflakes)
| NeedsInvestigation,mobile | low | Critical |
2,636,552,346 | vscode | Terminal: failed link detection on WSL filesystem when wordSeparators contains slashes |
Type: <b>Bug</b>
1. Add slashes to `"terminal.integrated.wordSeparators"`, e.g. ``" ()[]{}',\"`─‘’“”|//\\"``
2. Create some files *on a WSL drive*, e.g. `src/foo/bar/bim.ts`, `src/foo/bar/baz.ts`
3. Create a build task that produces filepath-like outputs that should link to those files, e.g.
```jsonc
{
"version": "2.0.0",
"tasks": [
{
"type": "shell",
"command": "echo $SHELL; echo $0; echo 'Problem: src/foo/bar/xyz.ts'",
"problemMatcher": [],
"group": {
"kind": "build",
"isDefault": true
},
"label": "print a Unixy filepath"
},
{
"type": "shell",
"command": "echo $SHELL; echo $0; echo 'Problem: src\\foo\\bar\\xyz.ts'",
"problemMatcher": [],
"group": {
"kind": "build",
"isDefault": true
},
"label": "print a Windows filepath"
}
]
}
```
4. Run the task(s)
5. Try to Ctrl-click one of the files (particularly on the directories like `foo`/`bar`).
Most likely related to the cause of #179972 or the same issue resurfacing.
Additional trace details for link parsing:
```
2024-11-05 16:59:19.756 [trace] [d9b2eed] terminalLocalLinkDetector#detect text ["/usr/bin/bash"]
2024-11-05 16:59:19.756 [trace] [d9b2eed] terminalLocalLinkDetector#detect parsedLinks [[{"path":{"index":0,"text":"/usr/bin/bash"}}]]
2024-11-05 16:59:19.757 [trace] [d9b2eed] terminalLocalLinkDetector#detect linkCandidates [["/usr/bin/bash"]]
2024-11-05 16:59:19.757 [trace] [d9b2eed] terminalUriLinkDetector#detect computedLinks [[]]
2024-11-05 16:59:20.023 [trace] [d9b2eed] terminalMultiLineLinkDetector#detect text ["Problem: src/foo/bar/xyz.ts"]
2024-11-05 16:59:20.023 [trace] [d9b2eed] terminalLocalLinkDetector#detect text ["Problem: src/foo/bar/xyz.ts"]
2024-11-05 16:59:20.024 [trace] [d9b2eed] terminalLocalLinkDetector#detect parsedLinks [[{"path":{"index":9,"text":"src/foo/bar/xyz.ts"}}]]
2024-11-05 16:59:20.024 [trace] [d9b2eed] terminalLinkHelpers#updateLinkWithRelativeCwd cwd ["\\wsl.localhost\\NixOS\\home\\ian\\Documents\\Development\\vscode-sandbox"]
2024-11-05 16:59:20.024 [trace] [d9b2eed] terminalLocalLinkDetector#detect linkCandidates [["C:\\wsl.localhost\\NixOS\\home\\ian\\Documents\\Development\\vscode-sandbox\\src\\foo\\bar\\xyz.ts"]]
2024-11-05 16:59:20.024 [trace] [d9b2eed] terminalUriLinkDetector#detect computedLinks [[]]
2024-11-05 16:59:20.334 [debug] [d9b2eed] Opening link [{"text":"foo","bufferRange":{"start":{"x":14,"y":5},"end":{"x":16,"y":5}},"type":"Search","contextLine":"Problem: src/foo/bar/xyz.ts"}]
2024-11-05 16:59:20.335 [trace] [d9b2eed] terminalLinkHelpers#updateLinkWithRelativeCwd cwd ["\\wsl.localhost\\NixOS\\home\\ian\\Documents\\Development\\vscode-sandbox"]
2024-11-05 16:59:20.624 [trace] [d9b2eed] terminalMultiLineLinkDetector#detect text [" * Terminal will be reused by tasks, press any key to close it. "]
2024-11-05 16:59:20.624 [trace] [d9b2eed] terminalLocalLinkDetector#detect text [" * Terminal will be reused by tasks, press any key to close it. "]
2024-11-05 16:59:20.624 [trace] [d9b2eed] terminalLocalLinkDetector#detect parsedLinks [[]]
2024-11-05 16:59:20.624 [trace] [d9b2eed] terminalUriLinkDetector#detect computedLinks [[]]
```
VS Code version: Code 1.95.1 (65edc4939843c90c34d61f4ce11704f09d3e5cb6, 2024-10-31T05:14:54.222Z)
OS version: Windows_NT x64 10.0.19045
Modes:
Remote OS version: Linux x64 5.15.153.1-microsoft-standard-WSL2
Also tested on Windows without using WSL-remote, and the same problem occurs as long as the filesystem itself is WSL. Plain Windows seems to work okay.
<details>
<summary>System Info</summary>
|Item|Value|
|---|---|
|CPUs|13th Gen Intel(R) Core(TM) i9-13950HX (32 x 2419)|
|GPU Status|2d_canvas: unavailable_software<br>canvas_oop_rasterization: disabled_off<br>direct_rendering_display_compositor: disabled_off_ok<br>gpu_compositing: disabled_software<br>multiple_raster_threads: enabled_on<br>opengl: disabled_off<br>rasterization: disabled_software<br>raw_draw: disabled_off_ok<br>skia_graphite: disabled_off<br>video_decode: disabled_software<br>video_encode: disabled_software<br>vulkan: disabled_off<br>webgl: unavailable_software<br>webgl2: unavailable_software<br>webgpu: unavailable_software<br>webnn: unavailable_software|
|Load (avg)|undefined|
|Memory (System)|63.61GB (18.41GB free)|
|Process Argv|--file-uri vscode-remote://wsl%2Bnixos/home/ian/Documents/Development/scuttle.code-workspace --log asvetliakov.vscode-neovim=info|
|Screen Reader|no|
|VM|0%|
|Item|Value|
|---|---|
|Remote|WSL: NixOS|
|OS|Linux x64 5.15.153.1-microsoft-standard-WSL2|
|CPUs|13th Gen Intel(R) Core(TM) i9-13950HX (32 x 0)|
|Memory (System)|31.15GB (16.84GB free)|
|VM|0%|
|Item|Value|
|---|---|
|Remote|WSL: NixOS|
|OS|Linux x64 5.15.153.1-microsoft-standard-WSL2|
|CPUs|13th Gen Intel(R) Core(TM) i9-13950HX (32 x 0)|
|Memory (System)|31.15GB (16.84GB free)|
|VM|0%|
</details>Extensions disabled
<!-- generated by issue reporter --> | bug,WSL,terminal-links | low | Critical |
2,636,570,499 | go | runtime/pprof: flaky TestGenericsHashKeyInPprofBuilder | ```
#!watchflakes
default <- pkg == "runtime/pprof" && test == "TestGenericsHashKeyInPprofBuilder"
```
This test failed in CI: https://ci.chromium.org/ui/p/golang/builders/try/gotip-linux-amd64-staticlockranking/b8732088109106960193/test-results?sortby=&groupby=
The problem is we got
```
testing.tRunner;runtime/pprof.TestGenericsHashKeyInPprofBuilder;runtime/pprof.genericAllocFunc[go.shape.uint32] [1 128 1 128]
```
but want
```
testing.tRunner;runtime/pprof.TestGenericsHashKeyInPprofBuilder;runtime/pprof.genericAllocFunc[go.shape.uint32] [1 128 0 0]
```
I think this is saying that the allocation is unexpectedly live. The 128 one at https://cs.opensource.google/go/go/+/master:src/runtime/pprof/protomem_test.go;l=132;drc=6f59c11155d75024985d4827a7fe155cd6561df9.
This test isn't intending to test liveness at all, so ignoring that field likely makes the most sense.
cc @golang/runtime | NeedsFix,compiler/runtime | low | Critical |
2,636,574,000 | PowerToys | [Advanced Paste] Enhance Clipboard History | ### Description of the new feature / enhancement
Enhance the support for the Clipboard History adding parity with the Windows built-in one.
- Add a "Clear all" action to clear the entire history
- Add support for pinning https://github.com/microsoft/PowerToys/issues/33715
- Improve pasting an item from the history
Current behavior of item click is that the item get copied (moved on top) and the user need to paste a second time
### Scenario when this would be used?
- Allow PowerToys users to use Advanced Paste instead of the Windows Clipboard History.
- Override WIN+V and configure a single shortcut/tool to rule the clipboard. | Idea-Enhancement,Product-Advanced Paste | low | Minor |
2,636,580,104 | terminal | In tmux 3.4, ZSH does not work correctly either locally or by SSH | ### Windows Terminal version
1.22.2912.0
### Windows build number
10.0.22631.4391
### Other Software
* Git for Windows 2.47.0.windows.2
* zsh 5.9
* tmux 3.4
* OpenSSH_9.9p1, OpenSSL 3.2.3 3 Sep 2024
### Steps to reproduce
There are two issues that appear related as they are rendering problems that *only* occur when using ZSH. In order to reproduce the issues, either of the following is required:
* A Git bash installation with ZSH
* Connecting to a remote Linux server through SSH (via Git Bash) that is running ZSH.
## Issue 1 Steps
1. Start a terminal with ZSH using either of the aforementioned setups.
2. Start typing any command. Longer commands will display the issue more clearly.
3. Delete the command.
## Issue 2 Steps
This specific issue only occurs on Linux servers with `tmux` and ZSH:
1. Connect to a server using SSH. The terminal *must* be ZSH.
2. Open `tmux`
3. Open a new vertical split.
4. Switch to the right-side split and enter any command.
5. Now switch back to the original split and enter a different command.
## Note
The flickering issue is not present in version 1.18.10301. The `tmux` issue however is present on any version since.
### Expected Behavior
For both issues, the terminal should render the text correctly and the cursor should not flicker.
### Actual Behavior
## Issue 1
When entering or deleting text, the cursor jumps to the beginning of the current line and then back to the end rapidly. This is easier to see when deleting a command. Unfortunately it appears that screen recording doesn't showcase the issue properly so I can't show it.
## Issue 2
See that the `~/Documents >` should've appeared on the right pane, and there's a gap on the right side before the cursor where `~/Documents` should've appeared. | Help Wanted,Issue-Bug,Product-Terminal,Needs-Tag-Fix,Priority-3 | low | Minor |
2,636,586,271 | pytorch | [export] `strict=True` and `strict=False` behavior inconsistent when the sample inputs are aliases | Consider the following model and export where we use the same tensor as the sample input
```python
import torch
from typing import List
class ListAdd(torch.nn.Module):
def __init__(self):
super().__init__()
def forward(
self, x: List[torch.Tensor], y: torch.Tensor, z: torch.Tensor, bs: float = float(0.1)
):
y1 = y.clone()
z1 = z + y
for xi in x:
y1 = y1 + xi + bs
return y1 + z1
device = torch.device("cpu")
model = ListAdd().to(device)
x = torch.rand(1024, 20, 16).to(device)
ep_1 = torch.export.export(model, args=([x, x, x], x, x, 0.2), strict=True)
print(ep_1)
ep_2= torch.export.export(model, args=([x, x, x], x, x, 0.2), strict=False)
print(ep_2)
```
We get
(1)
```python
ExportedProgram:
class GraphModule(torch.nn.Module):
def forward(self, x_0: "f32[1024, 20, 16]", x_1: "f32[1024, 20, 16]", x_2: "f32[1024, 20, 16]", y: "f32[1024, 20, 16]", z: "f32[1024, 20, 16]", bs):
# File: /workspace/ONNXConverter/alias_test.py:12 in forward, code: y1 = y.clone()
clone: "f32[1024, 20, 16]" = torch.ops.aten.clone.default(z)
# File: /workspace/ONNXConverter/alias_test.py:13 in forward, code: z1 = z + y
add: "f32[1024, 20, 16]" = torch.ops.aten.add.Tensor(z, z)
# File: /workspace/ONNXConverter/alias_test.py:15 in forward, code: y1 = y1 + xi + bs
add_1: "f32[1024, 20, 16]" = torch.ops.aten.add.Tensor(clone, z); clone = None
add_2: "f32[1024, 20, 16]" = torch.ops.aten.add.Tensor(add_1, 0.2); add_1 = None
add_3: "f32[1024, 20, 16]" = torch.ops.aten.add.Tensor(add_2, z); add_2 = None
add_4: "f32[1024, 20, 16]" = torch.ops.aten.add.Tensor(add_3, 0.2); add_3 = None
add_5: "f32[1024, 20, 16]" = torch.ops.aten.add.Tensor(add_4, z); add_4 = z = None
add_6: "f32[1024, 20, 16]" = torch.ops.aten.add.Tensor(add_5, 0.2); add_5 = None
# File: /workspace/ONNXConverter/alias_test.py:16 in forward, code: return y1 + z1
add_7: "f32[1024, 20, 16]" = torch.ops.aten.add.Tensor(add_6, add); add_6 = add = None
return (add_7,)
Graph signature: ExportGraphSignature(input_specs=[InputSpec(kind=<InputKind.USER_INPUT: 1>, arg=TensorArgument(name='x_0'), target=None, persistent=None), InputSpec(kind=<InputKind.USER_INPUT: 1>, arg=TensorArgument(name='x_1'), target=None, persistent=None), InputSpec(kind=<InputKind.USER_INPUT: 1>, arg=TensorArgument(name='x_2'), target=None, persistent=None), InputSpec(kind=<InputKind.USER_INPUT: 1>, arg=TensorArgument(name='y'), target=None, persistent=None), InputSpec(kind=<InputKind.USER_INPUT: 1>, arg=TensorArgument(name='z'), target=None, persistent=None), InputSpec(kind=<InputKind.USER_INPUT: 1>, arg=ConstantArgument(name='bs', value=0.2), target=None, persistent=None)], output_specs=[OutputSpec(kind=<OutputKind.USER_OUTPUT: 1>, arg=TensorArgument(name='add_7'), target=None)])
Range constraints: {}
```
and (2)
```python
ExportedProgram:
class GraphModule(torch.nn.Module):
def forward(self, x_0: "f32[1024, 20, 16]", x_1: "f32[1024, 20, 16]", x_2: "f32[1024, 20, 16]", y: "f32[1024, 20, 16]", z: "f32[1024, 20, 16]", bs):
# File: /workspace/ONNXConverter/alias_test.py:12 in forward, code: y1 = y.clone()
clone: "f32[1024, 20, 16]" = torch.ops.aten.clone.default(y)
# File: /workspace/ONNXConverter/alias_test.py:13 in forward, code: z1 = z + y
add: "f32[1024, 20, 16]" = torch.ops.aten.add.Tensor(z, y); z = y = None
# File: /workspace/ONNXConverter/alias_test.py:15 in forward, code: y1 = y1 + xi + bs
add_1: "f32[1024, 20, 16]" = torch.ops.aten.add.Tensor(clone, x_0); clone = x_0 = None
add_2: "f32[1024, 20, 16]" = torch.ops.aten.add.Tensor(add_1, 0.2); add_1 = None
add_3: "f32[1024, 20, 16]" = torch.ops.aten.add.Tensor(add_2, x_1); add_2 = x_1 = None
add_4: "f32[1024, 20, 16]" = torch.ops.aten.add.Tensor(add_3, 0.2); add_3 = None
add_5: "f32[1024, 20, 16]" = torch.ops.aten.add.Tensor(add_4, x_2); add_4 = x_2 = None
add_6: "f32[1024, 20, 16]" = torch.ops.aten.add.Tensor(add_5, 0.2); add_5 = None
# File: /workspace/ONNXConverter/alias_test.py:16 in forward, code: return y1 + z1
add_7: "f32[1024, 20, 16]" = torch.ops.aten.add.Tensor(add_6, add); add_6 = add = None
return (add_7,)
Graph signature: ExportGraphSignature(input_specs=[InputSpec(kind=<InputKind.USER_INPUT: 1>, arg=TensorArgument(name='x_0'), target=None, persistent=None), InputSpec(kind=<InputKind.USER_INPUT: 1>, arg=TensorArgument(name='x_1'), target=None, persistent=None), InputSpec(kind=<InputKind.USER_INPUT: 1>, arg=TensorArgument(name='x_2'), target=None, persistent=None), InputSpec(kind=<InputKind.USER_INPUT: 1>, arg=TensorArgument(name='y'), target=None, persistent=None), InputSpec(kind=<InputKind.USER_INPUT: 1>, arg=TensorArgument(name='z'), target=None, persistent=None), InputSpec(kind=<InputKind.USER_INPUT: 1>, arg=ConstantArgument(name='bs', value=0.2), target=None, persistent=None)], output_specs=[OutputSpec(kind=<OutputKind.USER_OUTPUT: 1>, arg=TensorArgument(name='add_7'), target=None)])
Range constraints: {}
```
In (1) only input z is used in the graph; in (2) all inputs are used. So the model exported is inconsistent when `strict=True` and `strict=False`.
cc @ezyang @chauhang @penguinwu @avikchaudhuri @gmagogsfm @zhxchen17 @tugsbayasgalan @angelayi @suo @ydwu4 | module: onnx,oncall: export | low | Major |
2,636,597,735 | TypeScript | Syntactic checks against comparing to null/undefined in strictNullChecks mode | ### 🔍 Search Terms
nullish, strictNullChecks, equals, undefined, null
### ✅ Viability Checklist
- [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
- [x] This wouldn't change the runtime behavior of existing JavaScript code
- [x] This could be implemented without emitting different JS based on the types of the expressions
- [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
- [x] This isn't a request to add a new utility type: https://github.com/microsoft/TypeScript/wiki/No-New-Utility-Types
- [x] This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals
### ⭐ Suggestion
When strictNullChecks are enabled, disallow `==` and `===` comparisons to null/undefined for expressions that are syntactically known to not be undefined.
I'd imagine the definition of syntactically not null/undefined expressions would be similar to that from https://github.com/microsoft/TypeScript/pull/59217.
This is similar to https://github.com/microsoft/TypeScript/issues/11920, but I think would be easier to land because it won't error on defensive programming null checks.
### 📃 Motivating Example
TypeScript's `typeof` operator always returns a string, but it can be hard to spot the difference between checking `"undefined"` and just `undefined` in code like this:
``` ts
if (typeof foo === undefined) {
```
In strictNullChecks mode, TypeScript will catch unnecessary comparisons like this, for expressions that at runtime it knows can never be null or undefined.
### 💻 Use Cases
1. What do you want to use this for? catch user errors
2. What shortcomings exist with current approaches? there's the https://typescript-eslint.io/rules/no-unnecessary-condition/, but that's type-based so does have the problem of flagging defensive programming. it's also nice to have things be in the compiler instead of a separate tool.
3. What workarounds are you using in the meantime? nothing at the moment, if this is infeasible will probably create a custom lint check. | Suggestion,Experimentation Needed | low | Critical |
2,636,634,653 | ollama | Support for # of completions? (for loom obsidian plugin) | I'm trying to adapt the loom obsidian plugin to use ollama.
now it seems to work fine, except I only ever get 1 completion. where settings.n is the number of completions I would like to generate.
https://github.com/cosmicoptima/loom/blob/master/main.ts
```javascript
async completeOpenAICompat(prompt: string) {
prompt = this.trimOpenAIPrompt(prompt);
// @ts-expect-error TODO
let url = getPreset(this.settings).url;
if (!(url.startsWith("http://") || url.startsWith("https://")))
url = "https://" + url;
if (!url.endsWith("/")) url += "/";
url = url.replace(/v1\//, "");
url += "v1/completions";
let body: any = {
prompt,
model: getPreset(this.settings).model,
max_tokens: this.settings.maxTokens,
n: this.settings.n,
temperature: this.settings.temperature,
top_p: this.settings.topP,
best_of:
this.settings.bestOf > this.settings.n
? this.settings.bestOf
: this.settings.n,
};
``` | feature request | low | Critical |
2,636,635,307 | flutter | [impeller] implement golden image tests for linux | Currently, all golden image tests are run on CI on mac bots. Swiftshader is used for Vulkan and ANGLE is used for OpenGLES.
In https://github.com/flutter/flutter/issues/157951 it was shown that the OpenGLES tests don't have antialiasing because ANGLE never implemented it for Metal.
The idea here is to get the golden tests running on linux CI so that:
1) We have anti-aliasing for our opengles golden tests
1) Running the golden tests locally on linux will make it easier to develop for linux developers | P3,e: impeller,team-engine,triaged-engine,e: opengl | low | Minor |
2,636,687,264 | TypeScript | Design Meeting Notes, 11/5/2024 |
# `tsc --init`
https://github.com/microsoft/TypeScript/issues/58420
* Discussed previously
* https://github.com/microsoft/TypeScript/issues/58417
* Example `tsconfig.json`.
* https://github.com/microsoft/TypeScript/issues/58420#issuecomment-2458300636
* `"rootDir": "src"`
* Automatically sets `include`...right?
* Probably not.
* `"target": "es2022"`
* Feels modern enough.
* Maybe just do `esnext`
* `"lib": ["dom", "esnext"]`
* Need all the other `dom.*` libraries like `dom.iterable`.
* Or just use `"esnext.full"`
* `"module": "nodenext"`
* But `bundler`?
* `"skipLibCheck": true`
* Disagreement about whether this is best practice, or even necessary for most projects.
* Node vs. browser?
* Link to https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping when targeting Node.js.
| Design Notes | low | Minor |
2,636,695,776 | next.js | Next.js 15 - Unsupported "BinaryExpression" error in "revalidate" field for math expressions | ### Link to the code that reproduces this issue
https://github.com/GitDevla/next_my_app
### To Reproduce
1. Create a new Next.js 15 project or use an existing one upgraded to Next.js 15.
2. Define a revalidate field with a mathematical expression in one of the route handlers. For example:
``` javascript
export const revalidate = 60 * 5;
```
3. Attempt to run or build the project.
### Current vs. Expected behavior
**Current**:
```sh
npm run build
> build
> next build
▲ Next.js 15.0.3-canary.6
Creating an optimized production build ...
⨯ Next.js can't recognize the exported `config` field in route "/page":
Unsupported node type "BinaryExpression" at "revalidate".
Read More - https://nextjs.org/docs/messages/invalid-page-config
✓ Compiled successfully
✓ Linting and checking validity of types
⨯ Invalid config value exports detected, these can cause unexpected behavior from the configs not being applied. Please fix them to continue
```
**Expected**: The mathematical expression to be evaluated
### Provide environment information
```bash
Operating System:
Platform: linux
Arch: x64
Version: #1 SMP Fri Mar 29 23:14:13 UTC 2024
Available memory (MB): 3921
Available CPU cores: 4
Binaries:
Node: 20.16.0
npm: 10.8.1
Yarn: N/A
pnpm: N/A
Relevant Packages:
next: 15.0.3-canary.6 // Latest available version is detected (15.0.3-canary.6).
eslint-config-next: N/A
react: 19.0.0-rc-7c8e5e7a-20241101
react-dom: 19.0.0-rc-7c8e5e7a-20241101
typescript: 5.3.3
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Not sure
### Which stage(s) are affected? (Select all that apply)
next build (local)
### Additional context
In Next.js 15, the revalidate field in route handlers does not support mathematical expressions (e.g. 60 * 5). This behavior was supported in Next.js 14, which accepted expressions that evaluated to integers.
Instead, Next.js 15 only supports direct integer values for revalidate.
eg.
```js
export const revalidate = 300; // 60*5
``` | bug | low | Critical |
2,636,711,353 | godot | Revert icons in the Inspector don't show up for @export properties when using @tool scripts on Editor launch | ### Tested versions
I tested this in 4.3 stable and 4.2 stable
### System information
Godot v4.3.stable - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1050 (NVIDIA; 31.0.15.3713) - Intel(R) Core(TM) i5-8300H CPU @ 2.30GHz (8 Threads)
### Issue description
Revert icons in the Inspector tab, those round arrows that sit on the left side of every property with a different value from default, is missing on startup for nodes that has scripts attached to them with `@tool` annotation. So scripts that run in the Editor. It is only missing for custom properties defined by the script. Anything that starts with `@export`. What solves the missing icons is a simple save of literally ANY scene. Keep in mind, I'm not talking about editing a script and having to save to show results, I'm talking about freshly launched Editor with literally no changes made to either 2D, 3D or Script. After saving and res-electing a node, all the revert icons appear. Not just in the saved scene, but in all scenes and all nodes, even the ones opened afterwards.
### Steps to reproduce
- Create a new Godot project
- Add a Node
- Attach Script
- Write "`@tool`" on the first line
- Write "Extends Node" on the second line
- Write "`@export var example: int = 5`" on the third line
- Save everything
- Reload scene
- Select the Node
- In the inspector set exported property "example" to 10
- Save everything
- Reload project
- Select the Node
- NO REVERT ICON in the Inspector
- Save scene
- Un-select and re-select the Node
- REVERT ICON
### Minimal reproduction project (MRP)
[revert_icon_bug.zip](https://github.com/user-attachments/files/17639760/revert_icon_bug.zip)
| topic:gdscript,topic:editor,needs testing | low | Critical |
2,636,716,437 | TypeScript | Detect Typescript in Javascript editors opened and inform developer, that he is writing different syntax and it will silently fail (probably) | <!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Describe the feature you'd like. -->
It would be super helpful to have something like:
```
Warning: TypeScript syntax detected in .jsx file.
Would you like to:
[ ] Rename to .tsx
[ ] Remove TypeScript syntax
[ ] Ignore warning
```
This kind of UX improvement could save developers (especially those transitioning between JS and TS projects) a lot of time and frustration. It seems like a relatively straightforward detection that could help a lot of people!
VSCode already does similar helpful suggestions for other cases (like offering to create files that don't exist when you import them), so this would fit right in with that philosophy.
What it would solve?
It's the classic .jsx vs .tsx gotcha! 😄
This is such a common issue that even experienced developers run into it regularly. The file extension makes all the difference because:
- `.jsx` files are treated as regular JavaScript/React files
- `.tsx` files are treated as TypeScript/React files
So TypeScript typing just "silently fails" to work in .jsx files without any obvious error message about why the types aren't working.
It's one of those "spend an hour debugging only to realize it's a file extension" moments that every developer has experienced!
- `.CJS` -> `.TS`, `.JS` -> `.TS`, `.JSX` -> `.TSX`
(Similar functionality could be created for `CSS` -> `SCSS`, ... .) | Needs More Info | low | Critical |
2,636,720,200 | go | internal/trace: TestTraceStressStartStop/Default failures | ```
#!watchflakes
default <- pkg == "internal/trace" && test == "TestTraceStressStartStop/Default"
```
Issue created automatically to collect these failures.
Example ([log](https://ci.chromium.org/b/8732073282291103857)):
=== RUN TestTraceStressStartStop/Default
reader_test.go:112: unexpected error while reading the trace: broken trace: failed to advance: frontier:
[gen=5]
M 3764 [ProcStart time=16122150543994 p=4 p_seq=22]
M 12168 [GoUnblock time=16122151264173 g=22 g_seq=2 stack=0]
G 4 [status=Waiting seq=2 (gen=5)]
G 5 [status=Waiting seq=0 (gen=5)]
G 57 [status=Waiting seq=0 (gen=5)]
...
String id=193
data="C:/Users/swarming/.swarming/w/ir/x/w/goroot/src/net/tcpsockopt_posix.go"
String id=194
data="net.setKeepAlive"
String id=195
data="C:/Users/swarming/.swarming/w/ir/x/w/goroot/src/net/sockopt_posix.go"
String id=196
data="runtime.forcegchelper"
--- FAIL: TestTraceStressStartStop/Default (3.36s)
— [watchflakes](https://go.dev/wiki/Watchflakes)
| NeedsInvestigation,compiler/runtime | low | Critical |
2,636,726,616 | pytorch | DISABLED test_dtensor_mm (__main__.DistMatrixOpsTest) | Platforms: rocm
This test was disabled because it is failing on main branch ([recent examples](https://torch-ci.com/failure?failureCaptures=%5B%22distributed%2F_tensor%2Ftest_matrix_ops.py%3A%3ADistMatrixOpsTest%3A%3Atest_dtensor_mm%22%5D)).
distributed/_tensor/test_matrix_ops.py::DistMatrixOpsTest::test_dtensor_mm [GH job link](https://github.com/pytorch/pytorch/actions/runs/11692278898/job/32562714444) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/59b66944d4287ca154508c25691fde95b5cecb36)
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd | module: rocm,triaged,skipped | low | Critical |
2,636,727,747 | pytorch | DISABLED test_tracker_with_activation_checkpointing (__main__.TestTrackerFullyShard1DTrainingCompose) | Platforms: rocm
This test was disabled because it is failing on main branch ([recent examples](https://torch-ci.com/failure?failureCaptures=%5B%22distributed%2F_tools%2Ftest_fsdp2_mem_tracker.py%3A%3ATestTrackerFullyShard1DTrainingCompose%3A%3Atest_tracker_with_activation_checkpointing%22%5D)).
distributed/_tools/test_fsdp2_mem_tracker.py::TestTrackerFullyShard1DTrainingCompose::test_tracker_with_activation_checkpointing [GH job link](https://github.com/pytorch/pytorch/actions/runs/11692278898/job/32562714664) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/59b66944d4287ca154508c25691fde95b5cecb36)
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd | module: rocm,triaged,skipped | low | Critical |
2,636,734,086 | rust | Double same-bound `where` clause causes failed type inference | I came across this scenario where having two functions with the same `where`-bounds causes type inference failure:
```rust
pub fn foo<S>(_: S) where String: From<S> {}
pub fn bar<S>(s: S) where String: From<S> {
// Mismatched types error!
foo(String::from(s));
}
```
I would expect the type inference to hold up and allow for calling `foo` with a `String` constructed in `bar`. Instead it fails with a mismatched types error (E0308) saying ``` expected type parameter `S`, found `String` ```
Notably, *ANY* `String` or `&str` constructed in `bar` and passed to `foo` will fail type inference. For example:
```rust
pub fn baz<S>(_: S) where String: From<S> {
// Mismatched types error!
foo("");
}
pub fn bam<S>(_: S) where String: From<S> {
// Mismatched types error!
let s: String = "".to_owned();
foo(s);
}
```
Some examples of similar scenarios that work, but show that there shouldn't be anything wrong with the actual operation (particularly `bap`):
```rust
pub fn bam<S>(s: S) where String: From<S> {
// OK!
foo(s);
}
pub fn bap<S>(s: S) where String: From<S> {
// OK!
foo::<String>(String::from(s));
}
pub fn bao() {
// OK!
let s: String = "".to_owned();
foo(s);
}
// Strangely, inverting the From bound to an Into bound fixes things
pub fn foo2<S>(_: S) where S: Into<String> {}
pub fn bar2<S>(s: S) where String: From<S> {
// OK!
foo2(String::from(s));
}
```
### Meta
This occurs on stable (1.82.0), beta (1.83.0-beta.4 // 2024-11-02 67512dee7a470ea7cdd6), and nightly (1.83.0-nightly // 2024-11-03 b8c8287a229cd79604aa) in debug and release modes.
[Full Playground Link](https://play.rust-lang.org/?version=stable&mode=release&edition=2021&gist=87fc83acfd704c0cdacd4e60d073f1c9)
| A-trait-system,T-compiler,C-bug,T-types,E-needs-investigation | low | Critical |
2,636,737,687 | PowerToys | PowerToys Run history only includes calculations if you have copied or pressed Enter | ### Microsoft PowerToys version
0.85.1
### Installation method
PowerToys auto-update
### Running as admin
None
### Area(s) with issue?
PowerToys Run
### Steps to reproduce
1. type in a sum in PowerToys Run
2. do NOT select the result or press Enter
3. use !! to get a history list
4. notice that the sum does not appear despite this text in the documentation. "If you recently did some math like = 1245+6789, and you need to recall it, it will be in the history. You can find it with !! 678 or even !! 8034."
### ✔️ Expected Behavior
The documentation leads me to expect that all calculations will be accessible in history even if I didn't copy them.
### ❌ Actual Behavior
the calculation is not shown in the history.
If this is the intended behaviour then it's an issue with the documentation rather than with PowerToys Run but it would be really useful to be able to get back to a calculation I did earlier in the day and need to look back at **because** I didn't remember to copy it at the time!
### Other Software
_No response_ | Issue-Bug,Issue-Docs,Needs-Triage | low | Minor |
2,636,751,875 | next.js | Enum in types.d.ts used in useState hook crashes turbopack | ### Link to the code that reproduces this issue
https://github.com/TijanaMazinjanin/nextjs_enum_bug
### To Reproduce
1. Clone the linked repository
2. pnpm install && pnpm run dev-turbo
3. Open localhost:3000
You will see turbopack crashing.
### Current vs. Expected behavior
The code should work the same with or without the --turbo flag. However, it currently crashes when --turbo is enabled, while it runs as expected without it.
### Provide environment information
```bash
Operating System:
Platform: win32
Arch: x64
Version: Windows 11 Pro
Available memory (MB): 15707
Available CPU cores: 16
Binaries:
Node: 22.6.0
npm: N/A
Yarn: N/A
pnpm: 9.7.0
Relevant Packages:
next: 14.2.16 // An outdated version detected (latest is 15.0.2), upgrade is highly recommended!
eslint-config-next: N/A
react: 18.3.1
react-dom: 18.3.1
typescript: 5.6.3
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Turbopack
### Which stage(s) are affected? (Select all that apply)
next dev (local)
### Additional context
When I define enum in any other file except types.d.ts it's working. Latest nextjs 15.0.2 has the same issue. Linux distributions also have this issue. | bug,Turbopack,linear: turbopack | low | Critical |
2,636,768,574 | nvm | zsh commands output by install.sh have syntax issues | <!-- Thank you for being interested in nvm! Please help us by filling out the following form if you‘re having trouble. If you have a feature request, or some other question, please feel free to clear out the form. Thanks! -->
#### Operating system and version:
Linux 6.11.3-200.fc40.x86_64 # 1 SMP PREEMPT_DYNAMIC Thu Oct 10 22:31:19 UTC 2024 x86_64 GNU/Linux
#### `nvm debug` output:
<details>
<!-- do not delete the following blank line -->
```sh
> nvm debug
nvm --version: v0.40.1
$SHELL: /bin/zsh
$SHLVL: 1
whoami: 'vernica'
${HOME}: /home/vernica
${NVM_DIR}: '${HOME}/.nvm'
${PATH}: ${HOME}/local/bin:${HOME}/.local/bin:${HOME}/go/bin:/usr/local/bin:/usr/local/sbin:/usr/bin:/usr/sbin
$PREFIX: ''
${NPM_CONFIG_PREFIX}: ''
$NVM_NODEJS_ORG_MIRROR: ''
$NVM_IOJS_ORG_MIRROR: ''
shell version: 'zsh 5.9 (x86_64-redhat-linux-gnu)'
uname -a: 'Linux 6.11.3-200.fc40.x86_64 #1 SMP PREEMPT_DYNAMIC Thu Oct 10 22:31:19 UTC 2024 x86_64 GNU/Linux'
checksum binary: 'sha256sum'
OS version: Fedora Linux 40 (Workstation Edition)
awk: /usr/bin/awk, GNU Awk 5.3.0, API 4.0, PMA Avon 8-g1, (GNU MPFR 4.2.1, GNU MP 6.2.1)
curl: /usr/bin/curl, curl 8.6.0 (x86_64-redhat-linux-gnu) libcurl/8.6.0 OpenSSL/3.2.2 zlib/1.3.1.zlib-ng brotli/1.1.0 libidn2/2.3.7 libpsl/0.21.5 libssh/0.10.6/openssl/zlib nghttp2/1.59.0 OpenLDAP/2.6.7
wget: /usr/bin/wget, GNU Wget2 2.1.0 - multithreaded metalink/file/website downloader
git: /usr/bin/git, git version 2.47.0
ls: cannot access 'grep='\''grep'$'\n''/usr/bin/grep': No such file or directory
grep: grep='grep --color=auto'
/usr/bin/grep (grep --color=auto), grep (GNU grep) 3.11
sed: /usr/bin/sed, sed (GNU sed) 4.9
cut: /usr/bin/cut, cut (GNU coreutils) 9.4
basename: /usr/bin/basename, basename (GNU coreutils) 9.4
ls: cannot access 'rm='\''rm'$'\n''/usr/bin/rm': No such file or directory
rm: rm='rm -i'
/usr/bin/rm (rm -i), rm (GNU coreutils) 9.4
mkdir: /usr/bin/mkdir, mkdir (GNU coreutils) 9.4
xargs: /usr/bin/xargs, xargs (GNU findutils) 4.9.0
nvm current: system
which node: /usr/bin/node
which iojs: iojs not found
which npm: /usr/bin/npm
npm config get prefix: /usr/local
npm root -g: /usr/local/lib/node_modules
```
</details>
#### `nvm ls` output:
<details>
<!-- do not delete the following blank line -->
```sh
> nvm ls
-> system
iojs -> N/A (default)
node -> stable (-> N/A) (default)
unstable -> N/A (default)
```
</details>
#### How did you install `nvm`?
<!-- (e.g. install script in readme, Homebrew) -->
```
> curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.1/install.sh | bash
```
#### What steps did you perform?
```
> curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.1/install.sh | bash
```
#### What happened?
I copied and pasted the lines as the install script instructed and they show errors in ZSH:
```
> curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.1/install.sh | bash
...
=> Downloading nvm from git to '/home/vernica/.nvm'
=> Cloning into '/home/vernica/.nvm'...
...
=> Compressing and cleaning up git repository
=> Appending nvm source string to /home/vernica/.zshrc
=> Appending bash_completion source string to /home/vernica/.zshrc
=> Close and reopen your terminal to start using nvm or run the following to use it now:
export NVM_DIR="$HOME/.nvm"
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" # This loads nvm
[ -s "$NVM_DIR/bash_completion" ] && \. "$NVM_DIR/bash_completion" # This loads nvm bash_completion
> export NVM_DIR="$HOME/.nvm"
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" # This loads nvm
[ -s "$NVM_DIR/bash_completion" ] && \. "$NVM_DIR/bash_completion" # This loads nvm bash_completion
zsh: bad pattern: #
```
#### What did you expect to happen?
The commands output by the script should not have syntax errors.
#### Is there anything in any of your profile files that modifies the `PATH`?
<!-- (e.g. `.bashrc`, `.bash_profile`, `.zshrc`, etc) -->
```
> grep -i PATH ~/.zshrc
fpath=(~/local/completion $fpath)
## -- - PATH - --
path=("$HOME/local/bin" "$HOME/.local/bin" "$HOME/go/bin" $path)
export NODE_PATH=$HOME/usr/lib/node_modules
# export PATH="/home/vernica/miniforge3/bin:$PATH"
``` | shell: zsh,needs followup | low | Critical |
2,636,789,008 | go | x/build: adjust LUCI load at openbsd-ppc64 builder | As agreed with @dmitshur and Michael K, add GOMAXPROCS to try reducing the load average on the builder machine. | Builders,NeedsFix | low | Minor |
2,636,790,420 | flutter | [in_app_purchase_storekit] Add `latestTransaction` for the iOS wrapper | ### Use case
As a convenience method, it would be useful to have the [latestTransaction](https://developer.apple.com/documentation/storekit/product/3803206-latesttransaction) method added to the package. This allows us to get the most recent transaction for a giving product, and quickly evaluate it. For example, if we are evaluating if a subscription is still valid and how long for it to renew.
### Proposal
Add latestTransaction. | c: new feature,platform-ios,p: in_app_purchase,package,P2,team-ios,triaged-ios | low | Minor |
2,636,798,173 | pytorch | DISABLED test_comprehensive_pca_lowrank_cuda_float32 (__main__.TestInductorOpInfoCUDA) | Platforms: linux, slow, rocm
This test was disabled because it is failing in CI. See [recent examples](https://hud.pytorch.org/flakytest?name=test_comprehensive_pca_lowrank_cuda_float32&suite=TestInductorOpInfoCUDA&limit=100) and the most recent trunk [workflow logs](https://github.com/pytorch/pytorch/runs/32563864539).
Over the past 3 hours, it has been determined flaky in 16 workflow(s) with 16 failures and 16 successes.
**Debugging instructions (after clicking on the recent samples link):**
DO NOT ASSUME THINGS ARE OKAY IF THE CI IS GREEN. We now shield flaky tests from developers so CI will thus be green but it will be harder to parse the logs.
To find relevant log snippets:
1. Click on the workflow logs linked above
2. Click on the Test step of the job so that it is expanded. Otherwise, the grepping will not work.
3. Grep for `test_comprehensive_pca_lowrank_cuda_float32`
4. There should be several instances run (as flaky tests are rerun in CI) from which you can study the logs.
<details><summary>Sample error message</summary>
```
Traceback (most recent call last):
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/testing/_internal/common_device_type.py", line 1152, in test_wrapper
return test(*args, **kwargs)
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/testing/_internal/common_device_type.py", line 1434, in only_fn
return fn(self, *args, **kwargs)
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/testing/_internal/common_utils.py", line 2199, in wrapper
fn(*args, **kwargs)
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/testing/_internal/common_device_type.py", line 1229, in dep_fn
return fn(slf, *args, **kwargs)
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/testing/_internal/common_device_type.py", line 1229, in dep_fn
return fn(slf, *args, **kwargs)
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/testing/_internal/common_device_type.py", line 1229, in dep_fn
return fn(slf, *args, **kwargs)
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/testing/_internal/common_utils.py", line 1592, in wrapper
fn(*args, **kwargs)
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/testing/_internal/common_utils.py", line 1528, in wrapper
fn(*args, **kwargs)
File "/opt/conda/envs/py_3.10/lib/python3.10/unittest/mock.py", line 1379, in patched
return func(*newargs, **newkeywargs)
File "/opt/conda/envs/py_3.10/lib/python3.10/contextlib.py", line 79, in inner
return func(*args, **kwds)
File "/var/lib/jenkins/workspace/test/inductor/test_torchinductor_opinfo.py", line 955, in inner
raise e
File "/var/lib/jenkins/workspace/test/inductor/test_torchinductor_opinfo.py", line 947, in inner
fn(self, device, dtype, op)
File "/var/lib/jenkins/workspace/test/inductor/test_torchinductor_opinfo.py", line 1193, in test_comprehensive
raise e
File "/var/lib/jenkins/workspace/test/inductor/test_torchinductor_opinfo.py", line 1153, in test_comprehensive
self.check_model_gpu(
File "/opt/conda/envs/py_3.10/lib/python3.10/contextlib.py", line 79, in inner
return func(*args, **kwds)
File "/var/lib/jenkins/workspace/test/inductor/test_torchinductor.py", line 606, in check_model_gpu
check_model(
File "/var/lib/jenkins/workspace/test/inductor/test_torchinductor.py", line 557, in check_model
actual_grad = compute_grads(example_inputs, kwargs, actual, grads)
File "/var/lib/jenkins/workspace/test/inductor/test_torchinductor.py", line 344, in compute_grads
return torch.autograd.grad(
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/autograd/__init__.py", line 496, in grad
result = _engine_run_backward(
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/autograd/graph.py", line 825, in _engine_run_backward
return Variable._execution_engine.run_backward( # Calls into the C++ engine to run the backward pass
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/autograd/function.py", line 307, in apply
return user_fn(self, *args)
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/_functorch/_aot_autograd/runtime_wrappers.py", line 1705, in backward
return impl_fn()
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/_functorch/_aot_autograd/runtime_wrappers.py", line 1695, in impl_fn
out = CompiledFunction._backward_impl(ctx, all_args)
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/_functorch/_aot_autograd/runtime_wrappers.py", line 2006, in _backward_impl
CompiledFunction.compiled_bw = aot_config.bw_compiler(
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/_dynamo/backends/common.py", line 51, in _wrapped_bw_compiler
return disable(disable(bw_compiler)(*args, **kwargs))
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/_dynamo/eval_frame.py", line 721, in _fn
return fn(*args, **kwargs)
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/_utils_internal.py", line 95, in wrapper_function
return function(*args, **kwargs)
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/_inductor/compile_fx.py", line 1650, in bw_compiler
return inner_compile(
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/_inductor/compile_fx.py", line 587, in compile_fx_inner
return wrap_compiler_debug(_compile_fx_inner, compiler_name="inductor")(
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/_dynamo/repro/after_aot.py", line 100, in debug_wrapper
inner_compiled_fn = compiler_fn(gm, example_inputs)
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/_inductor/compile_fx.py", line 744, in _compile_fx_inner
compiled_graph = FxGraphCache.load(
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/_inductor/codecache.py", line 1512, in load
compiled_graph = compile_fx_fn(
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/_inductor/compile_fx.py", line 651, in codegen_and_compile
compiled_graph = fx_codegen_and_compile(gm, example_inputs, **fx_kwargs)
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/_inductor/compile_fx.py", line 1015, in fx_codegen_and_compile
compiled_graph = CompiledFxGraph(
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/_inductor/codecache.py", line 1655, in __init__
with open(graph.cache_path) as f:
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpjhnij71z/uv/cuvrglhsawj5hchejqsla3dp6oggzvxlqkcmdqfviylaldxayxhu.py'
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/testing/_internal/common_utils.py", line 3057, in wrapper
method(*args, **kwargs)
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/testing/_internal/common_utils.py", line 3057, in wrapper
method(*args, **kwargs)
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/testing/_internal/common_device_type.py", line 460, in instantiated_test
result = test(self, **param_kwargs)
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/testing/_internal/common_cuda.py", line 243, in wrapped
return f(*args, **kwargs)
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/testing/_internal/common_device_type.py", line 1229, in dep_fn
return fn(slf, *args, **kwargs)
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/testing/_internal/common_device_type.py", line 1229, in dep_fn
return fn(slf, *args, **kwargs)
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/testing/_internal/common_utils.py", line 1592, in wrapper
fn(*args, **kwargs)
File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/testing/_internal/common_device_type.py", line 1164, in test_wrapper
raise e_tracked from e
Exception: Caused by sample input at index 1: SampleInput(input=Tensor[size=(3, 2), device="cuda:0", dtype=torch.float32], args=TensorList[Tensor[size=(4, 2), device="cuda:0", dtype=torch.float32]], kwargs={'q': '2', 'center': 'True'}, broadcasts_input=False, name='')
To execute this test, run the following from the base repo dir:
PYTORCH_OPINFO_SAMPLE_INPUT_INDEX=1 python test/inductor/test_torchinductor_opinfo.py TestInductorOpInfoCUDA.test_comprehensive_pca_lowrank_cuda_float32
This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0
```
</details>
Test file path: `inductor/test_torchinductor_opinfo.py`
cc @clee2000 @ezyang @chauhang @penguinwu @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @aakhundov | triaged,module: flaky-tests,skipped,oncall: pt2,module: inductor | low | Critical |
2,636,817,519 | langchain | Supabase vectorstore does not support $in in a filter to match to a list of ids | ### Checked other resources
- [X] I added a very descriptive title to this issue.
- [X] I searched the LangChain documentation with the integrated search.
- [X] I used the GitHub search to find a similar question and didn't find it.
- [X] I am sure that this is a bug in LangChain rather than my code.
- [X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).
### Example Code
``` python
from langchain_community.vectorstores import SupabaseVectorStore
vector_store = SupabaseVectorStore(table_name="documents",
query_name="match_documents",
embedding=cached_embedding,
client=supabase
)
policy_ids = ['20bac4b3-5964-47cf-a2a9-06e888c14add', '6004585c-624a-417c-91b5-ff4b9374b0fd']
vector_store.similarity_search_with_relevance_scores(
question,
filter = {"file_id": {"$in": policy_ids}},
)
### Error Message and Stack Trace (if applicable)
None
### Description
I'm using Superbase as a vector store. I want to filter the similarity search to just the rows where metadata-> file_id is in a list of file_ids
According to the documentation I should be able to use filter = {"file_id": {"$in": policy_ids}}, however this results in no rows being returned.
If I use filter = {"file_id": policy_ids[0} I get the match for the first policy_id
The issue seems to be $in is not supported in Superbase
### System Info
System Information
------------------
> OS: Linux
> OS Version: #1 SMP PREEMPT_DYNAMIC Wed, 23 Oct 2024 21:23:44 +0000
> Python Version: 3.11.2 (main, Aug 26 2024, 07:20:54) [GCC 12.2.0]
Package Information
-------------------
> langchain_core: 0.3.10
> langchain: 0.3.3
> langchain_community: 0.3.2
> langsmith: 0.1.134
> langchain_anthropic: 0.2.3
> langchain_openai: 0.2.2
> langchain_text_splitters: 0.3.0
Optional packages not installed
-------------------------------
> langgraph
> langserve
Other Dependencies
------------------
> aiohttp: 3.10.10
> anthropic: 0.36.0
> async-timeout: Installed. No version info available.
> dataclasses-json: 0.6.7
> defusedxml: 0.7.1
> httpx: 0.27.2
> jsonpatch: 1.33
> numpy: 1.26.4
> openai: 1.51.2
> orjson: 3.10.7
> packaging: 24.1
> pydantic: 2.9.2
> pydantic-settings: 2.5.2
> PyYAML: 6.0.2
> requests: 2.32.3
> requests-toolbelt: 1.0.0
> SQLAlchemy: 2.0.35
> tenacity: 8.5.0
> tiktoken: 0.8.0
> typing-extensions: 4.12.2 | Ɑ: vector store | low | Critical |
2,636,821,354 | go | crypto/tls: should apply default NextProtos to the result of GetConfigForClient | ### Go version
go version go1.22.8 darwin/amd64
### Output of `go env` in your module/workspace:
```shell
GO111MODULE='on'
GOARCH='arm64'
GOBIN='/Users/jack/src/bin'
GOCACHE='/Users/jack/Library/Caches/go-build'
GOENV='/Users/jack/Library/Application Support/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='arm64'
GOHOSTOS='darwin'
GOMODCACHE='/Users/jack/src/pkg/mod'
GOOS='darwin'
GOPATH='/Users/jack/src'
GOPROXY='https://goproxy.cn,direct'
GOROOT='/Users/jack/go/go1.22.8'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/Users/jack/go/go1.22.8/pkg/tool/darwin_arm64'
GOVCS=''
GOVERSION='go1.22.8'
GCCGO='gccgo'
AR='ar'
CC='clang'
CXX='clang++'
CGO_ENABLED='1'
GOMOD='/dev/null'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
```
### What did you do?
I start a service with multiple domains, use **GetConfigForClient** function for providing TLS certificates dynamically depends on the request's servername. Start go1.6 has enable http2 by default, and it will add supported application level protocols,such as "h2","http/1.1", but the tls.Config from **GetConfigForClient** did not do this.
```go
// readClientHello reads a ClientHello message and selects the protocol version.
func (c *Conn) readClientHello(ctx context.Context) (*clientHelloMsg, error) {
// clientHelloMsg is included in the transcript, but we haven't initialized
// it yet. The respective handshake functions will record it themselves.
msg, err := c.readHandshake(nil)
if err != nil {
return nil, err
}
clientHello, ok := msg.(*clientHelloMsg)
if !ok {
c.sendAlert(alertUnexpectedMessage)
return nil, unexpectedMessageError(clientHello, msg)
}
var configForClient *Config
originalConfig := c.config
if c.config.**GetConfigForClient** != nil {
chi := clientHelloInfo(ctx, c, clientHello)
if configForClient, err = c.config.**GetConfigForClient**(chi); err != nil {
c.sendAlert(alertInternalError)
return nil, err
} else if configForClient != nil {
c.config = configForClient
}
}
```
this leads to the client request offers h2,http/1.1, but server only accepted http/1.1 only
### What did you see happen?
```bash
IPv4: xx.xx.xxx.xx
* Trying xx.xx.xxx.xx:443...
* ALPN: curl offers h2,http/1.1
} [5 bytes data]
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
} [512 bytes data]
* CAfile: ca.pem
* CApath: none
{ [5 bytes data]
* TLSv1.3 (IN), TLS handshake, Server hello (2):
{ [122 bytes data]
* TLSv1.3 (IN), TLS change cipher, Change cipher spec (1):
{ [1 bytes data]
* TLSv1.3 (IN), TLS handshake, Encrypted Extensions (8):
{ [25 bytes data]
* TLSv1.3 (IN), TLS handshake, Request CERT (13):
{ [229 bytes data]
* TLSv1.3 (IN), TLS handshake, Certificate (11):
{ [1035 bytes data]
* TLSv1.3 (IN), TLS handshake, CERT verify (15):
{ [264 bytes data]
* TLSv1.3 (IN), TLS handshake, Finished (20):
{ [52 bytes data]
* TLSv1.3 (OUT), TLS change cipher, Change cipher spec (1):
} [1 bytes data]
* TLSv1.3 (OUT), TLS handshake, Certificate (11):
} [2087 bytes data]
* TLSv1.3 (OUT), TLS handshake, CERT verify (15):
} [264 bytes data]
* TLSv1.3 (OUT), TLS handshake, Finished (20):
} [52 bytes data]
* SSL connection using TLSv1.3 / TLS_AES_256_GCM_SHA384 / x25519 / RSASSA-PSS
* ALPN: server accepted http/1.1
```
### What did you expect to see?
if the NextProtos of tls.Config is empty, should copy from originalConfig, It should be consistent with the default | NeedsInvestigation | low | Critical |
2,636,849,091 | ant-design | TreeSelect组件单选模式添加与Select组件labelRender类似的功能 | ### What problem does this feature solve?
在TreeSelect组件单选模式中选中节点后，不想直接展示node所对应的title，想要加工一下。
### What does the proposed API look like?
与Select组件labelRender函数类似，或者与TreeSelect tagRender一致。
<!-- generated by ant-design-issue-helper. DO NOT REMOVE --> | Inactive | low | Major |
2,636,860,502 | next.js | Issues creating web workers `SecurityError: Failed to construct 'Worker'` | ### Link to the code that reproduces this issue
https://github.com/pantoninho/nextjs-worker-bug
### To Reproduce
(I'm getting errors creating a next-app with `reproduction-template`, so I created a regular next-app instead)
I'm able to create web workers inside a component, but a `SecurityError` is thrown when instantiating them inside a hook.
1. run `npm run dev`
2. open `localhost:3000`
3. assert there's no issues with the created webworker by clicking `send message` button
4. open `localhost:3000/issue` (or click the link in the root page) and a `SecurityError` is thrown (attached below)
5. check the code differences between `app/page.tsx` and `app/issue/page.tsx`:
```js
// this works
function Component() {
const workerRef = React.useRef();
React.useEffect(() => {
workerRef.current = new Worker(new URL("./worker.ts", import.meta.url)); // <-- works
return () => {
workerRef.current?.terminate();
};
}, []);
return <div />
}
```
```js
// this doesn't work
function Component() {
const worker = useWorker('./worker.ts');
return <div/>
}
function useWorker(path) {
const workerRef = React.useRef();
React.useEffect(() => {
workerRef.current = new Worker(new URL(path, import.meta.url)); // <-- SecurityError is thrown
return () => {
workerRef.current?.terminate();
};
}, [path]);
return workerRef;
}
```
<img width="1019" alt="image" src="https://github.com/user-attachments/assets/52e6dd5c-7ce1-40f8-b792-5d15efb54dd9">
### Current vs. Expected behavior
I expected to be able to create web workers inside hooks.
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 23.5.0: Wed May 1 20:12:58 PDT 2024; root:xnu-10063.121.3~5/RELEASE_ARM64_T6000
Available memory (MB): 16384
Available CPU cores: 10
Binaries:
Node: 20.18.0
npm: 10.8.2
Yarn: N/A
pnpm: 9.12.2
Relevant Packages:
next: 15.0.2 // Latest available version is detected (15.0.2).
eslint-config-next: 15.0.2
react: 19.0.0-rc-02c0e824-20241028
react-dom: 19.0.0-rc-02c0e824-20241028
typescript: 5.6.3
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Not sure, Runtime, Webpack
### Which stage(s) are affected? (Select all that apply)
next dev (local), next build (local), next start (local)
### Additional context
_No response_ | bug,Webpack,Runtime | low | Critical |
2,636,874,205 | rust | Hang after encountering overflow errors for huge types | ### Code
```rs
fn main() {
let mut x = None;
let y = x;
let z = Default::default();
let mut w = (&mut x, z, z);
let a = (&mut None::<fn(&())>, y, None::<fn(&'static ())>);
w = z;
}
```
### Affected release channels
- [ ] Previous Stable
- [ ] Current Stable
- [ ] Current Beta
- [x] Current Nightly
### Rust Version
rustc 1.84.0-nightly (bc5cf994d 2024-11-05)
binary: rustc
commit-hash: bc5cf994db9fb46712cefd89f78ad7fc51f184a2
commit-date: 2024-11-05
host: x86_64-unknown-linux-gnu
release: 1.84.0-nightly
LLVM version: 19.1.3
### Current error output
_No response_
### Backtrace
### Anything else?
| A-diagnostics,P-high,T-compiler,regression-from-stable-to-stable,C-bug,I-hang,S-has-mcve | low | Critical |
2,636,877,956 | vscode | An error is displayed after the notebook line height is modified |
Type: <b>Bug</b>
When I use jupyter notebook, after changing the notebook's line height, the markdown cell gets an overlap error.
VS Code version: Code 1.95.1 (65edc4939843c90c34d61f4ce11704f09d3e5cb6, 2024-10-31T05:14:54.222Z)
OS version: Windows_NT x64 10.0.19045
Modes:
<details>
<summary>System Info</summary>
|Item|Value|
|---|---|
|CPUs|AMD Ryzen 5 5600H with Radeon Graphics (12 x 3294)|
|GPU Status|2d_canvas: enabled<br>canvas_oop_rasterization: enabled_on<br>direct_rendering_display_compositor: disabled_off_ok<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>opengl: enabled_on<br>rasterization: enabled<br>raw_draw: disabled_off_ok<br>skia_graphite: disabled_off<br>video_decode: enabled<br>video_encode: enabled<br>vulkan: disabled_off<br>webgl: enabled<br>webgl2: enabled<br>webgpu: enabled<br>webnn: disabled_off|
|Load (avg)|undefined|
|Memory (System)|31.86GB (20.61GB free)|
|Process Argv|--crash-reporter-id 272d59d0-41a5-4431-b818-35228202384d|
|Screen Reader|no|
|VM|44%|
</details><details><summary>Extensions (19)</summary>
Extension|Author (truncated)|Version
---|---|---
vscode-jetbrains-icon-theme|cha|2.23.0
Fitten-Code|Fit|0.10.96
vscode-jetbrains-keybindings|isu|0.1.9
rainbow-csv|mec|3.12.0
vscode-language-pack-zh-hans|MS-|1.95.2024103009
debugpy|ms-|2024.12.0
python|ms-|2024.18.0
vscode-pylance|ms-|2024.11.1
jupyter|ms-|2024.10.0
jupyter-keymap|ms-|1.1.2
jupyter-renderers|ms-|1.0.21
vscode-jupyter-cell-tags|ms-|0.1.9
vscode-jupyter-slideshow|ms-|0.1.6
cmake-tools|ms-|1.19.52
cpptools|ms-|1.22.10
cpptools-extension-pack|ms-|1.3.0
cmake|twx|0.0.17
markdown-all-in-one|yzh|3.6.2
material-theme|zhu|3.17.5
(4 theme extensions excluded)
</details><details>
<summary>A/B Experiments</summary>
```
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805cf:30301675
binariesv615:30325510
vsaa593:30376534
py29gd2263:31024239
vscaat:30438848
c4g48928:30535728
azure-dev_surveyone:30548225
a9j8j154:30646983
962ge761:30959799
pythongtdpath:30769146
pythonnoceb:30805159
asynctok:30898717
pythonmypyd1:30879173
h48ei257:31000450
pythontbext0:30879054
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
f3je6385:31013174
dvdeprecation:31068756
dwnewjupytercf:31046870
impr_priority:31102340
nativerepl1:31139838
refactort:31108082
pythonrstrctxt:31112756
nativeloc2:31134642
cf971741:31144450
iacca1:31171482
notype1:31157159
5fd0e150:31155592
dwcopilot:31170013
```
</details>
<!-- generated by issue reporter --> | bug,info-needed,notebook-layout | low | Critical |
2,636,882,077 | ant-design | Modal Overlay scroll blocking is not compatible with the overflow-y scroll style of html elements | ### Reproduction link
[](https://codesandbox.io/p/sandbox/antd-reproduction-template-forked-5j3xtp)
### Steps to reproduce
1. Set html style `overflow-y: scroll`
2. Open Modal with scroll bars
### What is expected?
1. Scrollbar is hidden
2. Keep current view position unchanged
### What is actually happening?
1. First the scroll bar flashes
2. Then the view position is reset to the top
| Environment | Info |
| --- | --- |
| antd | 5.21.6 |
| React | 18.3.1 |
| System | MacOS 13.3 (22E252) |
| Browser | Google Chrome 130.0.6723.92（正式版本） (arm64) |
<!-- generated by ant-design-issue-helper. DO NOT REMOVE --> | Inactive,unconfirmed | low | Minor |
2,636,895,481 | godot | Editable Children's exported Dictionary property can not be saved to .tscn file via script | ### Tested versions
- Reproducible in v4.4.dev3.official [f4af8201b]
### System information
Windows 11, Vulkan API 1.3.280 - Forward+ - Using Vulkan Device #0: NVIDIA - NVIDIA GeForce RTX 3060 Ti
### Issue description
I use an @export_tool_button to modify a sub-scene's exported Dictionary property, but it turns out that new value can't be saved in outer scene's `.tscn` file. It's interesting that the Dictionary's changed value can be show correctly in EditorInspector but not saved in file. If use the EditorInspector to modify sub-scene's exported Dictionary property and save, the new value can correctlly be saved in outer scene's `.tscn` file.
<img width="1346" alt="屏幕截图 2024-11-06 103609" src="https://github.com/user-attachments/assets/6c3adf6b-f749-4ee5-ac67-731143e19090">
<img width="1346" alt="屏幕截图 2024-11-06 103252" src="https://github.com/user-attachments/assets/a2b3db87-ef12-4a2d-837f-46f217df8c38">
BTW, sub-scene's exported Int property can be successfully saved in outer scenes's `.tscn` file by the same way.
### Steps to reproduce
In the MRP,
- `test1.tscn` has a property: `@export var map: Dictionary = {}`,
- `test2.tscn` contains a `test1.tscn`
- `test3.tscn` contains a `test2.tscn` with a modification of `test1.tscn`'s map and the value is `{"fff": 121, "ggg": 666}`
- `test4.tscn` contains a `test3.tscn`, which means the sub-scene `test3/test2/test1`'s maps default value is inherited from `test3.tscn`'s
- click the test4's @export_tool_button `add element` will set a new pair of Key/Value to the `test3/test2/test1`'s map and you can click on the sub-scene test1 to see it's property by EditorInspector to confirm that the map is surly modified.
- save scenes and open `test4.tscn` with other text editor and you will find the value is not saved in file.
- If you click on the sub-scene test1 and do some little modifcation by EditorInspector and save, you will find out the new value is saved in `test4.tscn`.
### Minimal reproduction project (MRP)
[test_export_dictionary.zip](https://github.com/user-attachments/files/17641026/test_export_dictionary.zip)
| bug,topic:core,needs testing | low | Minor |
2,636,907,019 | ui | [bug]: Unnecessary Double Spaces in DialogPrimitive Overlay Class for Dialog Component | ### Describe the bug
There is extra space in part of the style for the dialog component.
There are two extra spaces before the class `data-[state=open]:animate-in`.
https://github.com/shadcn-ui/ui/blob/f7c42169a6c7daa5821a033eed5928f26e565f38/apps/www/registry/default/ui/dialog.tsx#L21C1-L28C5
https://github.com/shadcn-ui/ui/blob/f7c42169a6c7daa5821a033eed5928f26e565f38/apps/www/registry/new-york/ui/dialog.tsx#L24
```
<DialogPrimitive.Overlay
ref={ref}
className={cn(
"fixed inset-0 z-50 bg-black/80 data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0",
className
)}
{...props}
/>
```
### Affected component/components
dialog
### How to reproduce
At the very least, the components generated when running npx shadcn@latest add dialog included this issue. I’ve also confirmed that it’s present in the New York theme.
### Codesandbox/StackBlitz link
https://github.com/shadcn-ui/ui/blob/f7c42169a6c7daa5821a033eed5928f26e565f38/apps/www/registry/default/ui/dialog.tsx#L21C1-L28C5
### Logs
_No response_
### System Info
```bash
MacBook Air macOS m3 sonoma 14.5
```
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues | bug | low | Critical |
2,636,916,954 | PowerToys | Add hotkeys for focus assist and do not disturb | ### Description of the new feature / enhancement
Currently there is no way to use these features with one's keyboard rather than clicking windows. I have these clicks behind hotkeys configured with AutoHotkey.
### Scenario when this would be used?
1. Activate a focus assist session using a default timer
2. Turn on/off do not disturb
### Supporting information
_No response_ | Needs-Triage | low | Minor |
2,636,952,217 | flutter | [Web] flutter web has returned to the starting page, canGoBack is still true | ### Steps to reproduce
1. Open a flutter web application
2. Enter the second level page
3. Use flutter web’s own navigation to return
### Expected results
canGoBack is false
### Actual results
canGoBack is true
safari Also have this problem
### Code sample
<details open><summary>Code sample</summary>
```dart
return WillPopScope(
onWillPop: ()=> Future.value(true),
child: Scaffold(
appBar: AppBar(
backgroundColor: Theme.of(context).colorScheme.inversePrimary,
title: Text('canGoBack: $_canPop'),
),
body: Column(
children: [
Row(
children: [
InkWell(
onTap: () {
_controller.goBack();
},
child: Container(
width: 200,
height: 56,
alignment: Alignment.center,
child: Text("controller.goBack()"),
),
),
InkWell(
onTap: () {
_controller.canGoBack().then((value) {
print("是否可以返回: $value");
setState(() {
_canPop = value;
});
});
},
child: Container(
width: 200,
height: 56,
alignment: Alignment.center,
child: Text("controller.canGoBack()"),
),
),
],
),
Expanded(child: WebViewWidget(controller: _controller))
],
),
),
);
```
</details>
### Screenshots or Video
<details open>
<summary>Screenshots / Video demonstration</summary>
https://github.com/user-attachments/assets/96879e58-e356-49d8-98b2-66a5830ea243
https://github.com/user-attachments/assets/b89488de-5054-4c81-b1d5-8951244c8355
</details>
### Logs
<details open><summary>Logs</summary>
```console
[Paste your logs here]
```
</details>
### Flutter Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, 3.27.0-1.0.pre.351, on macOS 14.0 23A344 darwin-arm64, locale zh-Hans-CN)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2023.2)
[✓] VS Code (version 1.94.2)
[✓] Connected device (6 available)
[✓] Network resources | platform-web,has reproducible steps,P2,team-web,triaged-web,found in release: 3.24,found in release: 3.27 | low | Minor |
2,636,983,819 | flutter | When manually setting the value of AnimationController, the status is always forward. | ### Use case
In the source code, when setting a new `value`, `_direction` is used to change `_status`. If `_direction` is not changed by other means, `_direction` defaults to `_AnimationDirection.forward`, resulting in `status` also being `AnimationStatus.forward`. In some cases, I need `status` to be `AnimationStatus.reverse` when manually setting `value`, which is not possible at this time.
https://github.com/flutter/flutter/blob/5a3fd44aec1ff9c8d57fd7ddfd27e97099a05c13/packages/flutter/lib/src/animation/animation_controller.dart#L431-L434
### Proposal
Hope to provide similar methods:
```dart
void setValue(double value, [AnimationDirection? direction]);
```
### Usage scenarios
When you manually slide back, `reverseBuilder` cannot be triggered, but `forwardBuilder` is called. The root cause is that `status` is `forward` when `AnimationController.value = x`
```dart
class FooRoute<T> extends PageRoute<T> {
@override
Widget buildTransitions(
BuildContext context,
Animation<double> animation,
Animation<double> secondaryAnimation,
Widget child,
) {
return DualTransitionBuilder(
animation: animation,
forwardBuilder: (context, animation, child) {
return FadeTransition(opacity: animation, child: child);
},
reverseBuilder: (context, animation, child) {
return CupertinoRouteTransitionMixin.buildPageTransitions(
this,
context,
ReverseAnimation(animation),
secondaryAnimation,
child!,
);
},
child: child,
);
}
}
``` | c: new feature,framework,a: animation,c: proposal,P2,team-framework,triaged-framework | low | Major |
2,637,001,516 | vscode | [WSL2] Use relative paths when linking to files | <!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions -->
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
<!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. -->
<!-- 🔧 Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes
<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. -->
<!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->
- VS Code Version: 1.95.1
- OS Version: Win 11 10.0.26100
Steps to Reproduce:
1. Open VSCode in WSL2
2. Create `foo.ts` and `bar.ts` file
3. Open `foo.ts` file and add `// file://./bar.ts`
4. Ctrl + Click on file link.
This should take the window to the `bar.ts` file. Instead it's saying
This works on Windows just fine. But not on WSL2.
Related https://github.com/microsoft/vscode/issues/90848#issuecomment-588159214
| bug,editor-contrib | low | Critical |
2,637,002,473 | PowerToys | Translation Errors | ### Microsoft PowerToys version
0.86.0
### Installation method
PowerToys auto-update
### Running as admin
Yes
### Area(s) with issue?
General
### Steps to reproduce
When it ask me to turn on the diagnostic data and I select "Yes", the Chinese translation is
```
We are glad for you to help us to improve PowerToys!
You can always change this from Password.
```
It seems that the translator translated `Settings` to `Password`.
### ✔️ Expected Behavior
Translation:
```
We are glad for you to help us to improve PowerToys!
You can always change this from Settings.
```
### ❌ Actual Behavior
Translation:
```
We are glad for you to help us to improve PowerToys!
You can always change this from Password.
```
It seems that the translator translated `Settings` to `Password`.
### Other Software
_No response_ | Issue-Bug,Needs-Triage,Issue-Translation | low | Critical |
2,637,042,503 | ollama | Build instructions in https://github.com/ollama/ollama/blob/main/llama/README.md are outdated or non-functional | ### What is the issue?
Following the build instructions in [README.md](https://github.com/ollama/ollama/blob/main/llama/README.md#cuda) for Linux/CUDA results in an error when running `make ggml_cuda.so`. The error is:
```bash
make: *** No rule to make target 'ggml_cuda.so'. Stop.
```
Could you please confirm if the documentation needs to be updated?
### OS
Linux
### GPU
Other
### CPU
Intel
### Ollama version
main branch | documentation,build | low | Critical |
2,637,121,478 | deno | Can't read from a file with `{ write: true }` | Version: Deno 2.0.5
I need to open a file, lock it, read from it, and then write to it. But no configuration of `Deno.open` lets me read and write to the same `Deno.FsFile` instance.
```ts
const file = await Deno.open('README.md', { write: true });
const bytes = await new Response(file.readable).arrayBuffer();
console.log(new TextEncoder().encode(bytes));
```
It says:
```
Uncaught Error: Bad file descriptor (os error 9)
at async readableStreamCollectIntoUint8Array (ext:deno_web/06_streams.js:1066:19)
at async consumeBody (ext:deno_fetch/22_body.js:254:9)
at async <anonymous>:4:15
```
If I set `{ read: true }` it works. But then I cannot write to it. With `{ read: true, write: true }` I can read but not write to it:
```
Uncaught BadResource: Bad resource ID
at write (ext:deno_io/12_io.js:52:15)
at FsFile.write (ext:deno_fs/30_fs.js:585:12)
> at <anonymous>:1:27
```
I need to lock the file. The only way to lock is with an instance of `Deno.FsFile`, which I can only get from `Deno.open`. But it's impossible to do it. | bug | low | Critical |
2,637,130,627 | flutter | [camera_windows] initializeCamera is stuck on 4K camera | ### Steps to reproduce
Camera_Windows: ^ 0.2.6 and https://github.com/flutter/packages/tree/main/packages/camera/camera_windows ，
I have tried it all, and when clicking the Create camera button, the program can be executed normally with a 1080p camera, as shown in the following picture:
But when I switch to a 4K camera, the code will
`await CameraPlatform.instance.initializeCamera(
cameraId,
);`
Stuck, do not execute downwards, The terminal has no error message，as shown in the following figure:
On Windows 10 system, I can call the built-in camera program in Windows to obtain images of AF12MP 4K Camera
### Expected results
I hope to obtain images from the Windows camera normally
### Actual results
when clicking the Create camera button, the code will
`await CameraPlatform.instance.initializeCamera(
cameraId,
);`
Stuck, do not execute downwards
### Code sample
<details open><summary>Code sample</summary>
```dart
[Paste your code here]
```
</details>
### Screenshots or Video
<details open>
<summary>Screenshots / Video demonstration</summary>
[Upload media here]
</details>
### Logs
<details open><summary>Logs</summary>
```console
[Paste your logs here]
```
</details>
### Flutter Doctor output
<details open><summary>Doctor output</summary>
```console
flutter doctor -v
Flutter assets will be downloaded from https://storage.flutter-io.cn. Make sure you trust this source!
[√] Flutter (Channel stable, 3.22.2, on Microsoft Windows [版本 10.0.19041.1415], locale zh-CN)
• Flutter version 3.22.2 on channel stable at D:\Flutter\flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 761747bfc5 (5 months ago), 2024-06-05 22:15:13 +0200
• Engine revision edd8546116
• Dart version 3.4.3
• DevTools version 2.34.3
• Pub download mirror https://pub.flutter-io.cn
• Flutter download mirror https://storage.flutter-io.cn
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
• Android SDK at D:\Android\Local\Sdk
• Platform android-34, build-tools 34.0.0
• ANDROID_HOME = C:\Users\Admin\AppData\Local\Android\Sdk
• Java binary at: D:\Program Files\Android\Android Studio\jbr\bin\java
• Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-10027231)
• All Android licenses accepted.
[√] Chrome - develop for the web
• Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe
[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.5.5)
• Visual Studio at D:\Microsoft Visual Studio\2022\Community
• Visual Studio Community 2022 version 17.5.33627.172
• Windows 10 SDK version 10.0.22000.0
[√] Android Studio (version 2022.3)
• Android Studio at D:\Program Files\Android\Android Studio
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-10027231)
[√] IntelliJ IDEA Ultimate Edition (version 2021.1)
• IntelliJ at D:\Program Files\JetBrains\IntelliJ IDEA 2021.1.3
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
[√] Connected device (3 available)
• Windows (desktop) • windows • windows-x64 • Microsoft Windows [版本 10.0.19041.1415]
• Chrome (web) • chrome • web-javascript • Google Chrome 130.0.6723.92
• Edge (web) • edge • web-javascript • Microsoft Edge 130.0.2849.68
[√] Network resources
• All expected network resources are available.
• No issues found!
```
</details>
| e: device-specific,platform-windows,p: camera,package,a: desktop,P3,team-windows,triaged-windows | low | Critical |
2,637,151,630 | vscode | Illegal value for lineNumber | ```javascript
Error: Illegal value for lineNumber
at Ew.getLineMaxColumn in src/vs/editor/common/model/textModel.ts:860:10
at Va.getBottomForLineNumber in out-vscode/vs/editor/browser/widget/codeEditor/vs/editor/browser/widget/codeEditor/codeEditorWidget.ts:583:40
at <anonymous> in src/vs/editor/browser/widget/diffEditor/utils/editorGutter.ts:124:38
at fn in src/vs/base/common/observableInternal/base.ts:303:3
at $be in src/vs/editor/browser/widget/diffEditor/utils/editorGutter.ts:93:5
at Cte._runFn in src/vs/editor/browser/widget/diffEditor/utils/editorGutter.ts:54:81
at Cte.k in src/vs/base/common/observableInternal/autorun.ts:197:11
at Cte.endUpdate in src/vs/base/common/observableInternal/autorun.ts:244:11
at j4.finish in src/vs/base/common/observableInternal/base.ts:371:13
at Vi in src/vs/base/common/observableInternal/base.ts:305:6
```
[Go to Errors Site](https://errors.code.visualstudio.com/card?ch=65edc4939843c90c34d61f4ce11704f09d3e5cb6&bH=551871d4-b60c-ef6c-4593-a9839a6d3b53) | error-telemetry,diff-editor | low | Critical |
2,637,152,142 | vscode | TextModel got disposed before DiffEditorWidget model got reset | ```javascript
Error: TextModel got disposed before DiffEditorWidget model got reset
at vZ.value in src/vs/editor/browser/widget/diffEditor/diffEditorWidget.ts:329:24
at x.B in src/vs/base/common/event.ts:1243:13
at x.C in src/vs/base/common/event.ts:1254:9
at x.fire in src/vs/base/common/event.ts:1278:9
at Ew.dispose in src/vs/editor/common/model/textModel.ts:394:23
at pWe.destroyModel in src/vs/editor/common/services/modelService.ts:464:19
at Lz.dispose in out-vscode/vs/workbench/common/editor/vs/workbench/common/editor/textEditorModel.ts:234:22
at <anonymous> in src/vs/workbench/services/textmodelResolver/common/textModelResolverService.ts:141:11
```
[Go to Errors Site](https://errors.code.visualstudio.com/card?ch=65edc4939843c90c34d61f4ce11704f09d3e5cb6&bH=4894b40b-0399-b450-6de7-85b9a81356ce) | error-telemetry,diff-editor | low | Critical |
2,637,153,860 | vscode | Cannot read properties of undefined (reading 'getViewLineMinColumn') | ```javascript
TypeError: Cannot read properties of undefined (reading 'getViewLineMinColumn')
at rLi.getViewLineMinColumn in src/vs/editor/common/viewModel/viewModelLines.ts:735:62
at dLi.getLineMinColumn in src/vs/editor/common/viewModel/viewModelImpl.ts:687:22
at dLi.getVisibleRangesPlusViewportAboveBelow in src/vs/editor/common/viewModel/viewModelImpl.ts:533:30
at Va.getVisibleRangesPlusViewportAboveBelow in out-vscode/vs/editor/browser/widget/codeEditor/vs/editor/browser/widget/codeEditor/codeEditorWidget.ts:537:36
at iV.F in src/vs/editor/contrib/inlayHints/browser/inlayHintsController.ts:436:38
at Jt.a in src/vs/editor/contrib/inlayHints/browser/inlayHintsController.ts:217:119
at Jt.h in out/vs/workbench/workbench.desktop.main.js:31:76680
at Jt.g in src/vs/base/common/async.ts:1059:9
```
[Go to Errors Site](https://errors.code.visualstudio.com/card?ch=65edc4939843c90c34d61f4ce11704f09d3e5cb6&bH=e69353d3-2767-c222-1db9-4c6acce1b8f5) | error-telemetry | low | Critical |
2,637,154,428 | vscode | Cannot read properties of undefined (reading 'e') | ```javascript
TypeError: Cannot read properties of undefined (reading 'e')
at <anonymous> in src/vs/editor/contrib/snippet/browser/snippetSession.ts:302:27
at callback in src/vs/editor/common/model/textModel.ts:1623:13
at Ew.changeDecorations in src/vs/editor/common/model/textModel.ts:1593:16
at Va.changeDecorations in out-vscode/vs/editor/browser/widget/codeEditor/vs/editor/browser/widget/codeEditor/codeEditorWidget.ts:1262:32
at IE.merge in src/vs/editor/contrib/snippet/browser/snippetSession.ts:294:16
at <anonymous> in src/vs/editor/contrib/snippet/browser/snippetSession.ts:679:14
at cursorStateComputer in src/vs/editor/common/cursor/cursor.ts:490:23
at cursorStateComputer in out-vscode/vs/editor/common/model/vs/editor/common/model/editStack.ts:444:33
at Rli.pushEditOperation in out-vscode/vs/editor/common/model/vs/editor/common/model/editStack.ts:430:38
at Ew.wb in src/vs/editor/common/model/textModel.ts:1371:31
```
[Go to Errors Site](https://errors.code.visualstudio.com/card?ch=65edc4939843c90c34d61f4ce11704f09d3e5cb6&bH=87ec4ab9-f214-b6a6-eddc-a4d223538b45) | error-telemetry,snippets | low | Critical |
2,637,154,592 | vscode | Cannot read properties of null (reading 'startLineNumber') | ```javascript
TypeError: Cannot read properties of null (reading 'startLineNumber')
at <anonymous> in src/vs/editor/contrib/snippet/browser/snippetSession.ts:149:41
at callback in src/vs/editor/common/model/textModel.ts:1623:13
at Ew.changeDecorations in src/vs/editor/common/model/textModel.ts:1593:16
at IE.move in src/vs/editor/contrib/snippet/browser/snippetSession.ts:136:49
at m1.j in src/vs/editor/contrib/snippet/browser/snippetSession.ts:707:33
at <anonymous> in src/vs/editor/contrib/snippet/browser/snippetSession.ts:685:17
at cursorStateComputer in src/vs/editor/common/cursor/cursor.ts:490:23
at cursorStateComputer in out-vscode/vs/editor/common/model/vs/editor/common/model/editStack.ts:444:33
at Rli.pushEditOperation in out-vscode/vs/editor/common/model/vs/editor/common/model/editStack.ts:430:38
at Ew.wb in src/vs/editor/common/model/textModel.ts:1371:31
```
[Go to Errors Site](https://errors.code.visualstudio.com/card?ch=65edc4939843c90c34d61f4ce11704f09d3e5cb6&bH=ac945490-421c-2294-cc3f-e851365545da) | error-telemetry,snippets | low | Critical |
2,637,197,245 | godot | Editor Shader Include Debugger: Incorrect type error when using Canvas Item built-ins | ### Tested versions
v4.3.stable.arch_linux
v.4.0.stable
### System information
Godot v4.3.stable unknown - Arch Linux ZEN SMP PREEMPT_DYNAMIC Fri, 01 Nov 2024 03:30:35 +0000 - Wayland - GLES3 (Compatibility) - Mesa Intel(R) HD Graphics 3000 (SNB GT2) - Intel(R) Core(TM) i7-2670QM CPU @ 2.20GHz (8 Threads)
### Issue description
By default, shader include type is *spatial*, which change the type of *built-ins*
However, it is not possible to change the *shader_type* of shader include file.
The shader does complie with no error and works correctly. But still show as an error in the editor:
### Steps to reproduce
Create a shader include file.
Try to use some canvas-item built-in.
### Minimal reproduction project (MRP)
[shaderincludeissue.zip](https://github.com/user-attachments/files/17646895/shaderincludeissue.zip) | discussion,topic:shaders | low | Critical |
2,637,209,442 | deno | Logging out webgpu adapater causes an assertion error | Version: Deno 2.0.5
On Windows, Linux, and Mac OS trying to log out the WebGPU adapter causes an assertion error which is unexpected and was rather difficult to debug, interestingly enough logging out the actual adapter device works as expected it prints out an object.
I'm not sure if the assertion error is expected behaviour or not but I've not found any documentation that specifies this behaviour, so I'm thinking it's a bug.
> Note: when running the script on Windows it doesn't always print the assertion error, sometimes it just causes the script to crash with no errors, making it basically impossible to debug.
```ts
const adapter = await navigator.gpu.requestAdapter();
const device = await adapter?.requestDevice();
console.log({
adapter,
})
```
Assertion Error:
```
❯ deno run --unstable-webgpu -A main.ts
[Internal Formatting Error] AssertionError: Assertion failed
at assert (ext:deno_console/01_console.js:199:11)
at getKeys (ext:deno_console/01_console.js:1294:7)
at formatRaw (ext:deno_console/01_console.js:761:14)
at formatValue (ext:deno_console/01_console.js:545:10)
at inspect (ext:deno_console/01_console.js:3469:10)
at GPUAdapter.[Deno.privateCustomInspect] (ext:deno_webgpu/01_webgpu.js:542:12)
at formatValue (ext:deno_console/01_console.js:487:48)
at formatProperty (ext:deno_console/01_console.js:1647:11)
at formatRaw (ext:deno_console/01_console.js:957:9)
at formatValue (ext:deno_console/01_console.js:545:10)
``` | bug,webgpu | low | Critical |
2,637,215,692 | vscode | Support comment toggling for languages that do not support content on the first column | Please have a look at this link
[https://github.com/microsoft/vscode-discussions/discussions/2363](Issue)
Kindly add a feature to fix such type of issues
Summary:
The user has a language where the first column is always empty.
The user is encountering an issue with the comment toggling feature where the comment indicator is placed in the first column, which is invalid for their language.
This is a feature request to improve comment toggling, so it also works for such a language. | feature-request,editor-comments | medium | Major |
2,637,216,258 | next.js | Hard Navigation On Client side Navigation (using Link component) in Nextjs 15 | ### Link to the code that reproduces this issue
https://codesandbox.io/p/devbox/musing-lalande-js9nmq?file=%2Fapp%2Fpage.tsx%3A5%2C1
### To Reproduce
1. Create a new page in the starter project.
2. Add a link to that page on the home page.
3. Run the app locally.
4. Click on the link.
5. A hard navigation occurs, causing the window to reload and the page document to be downloaded.
In Next.js v14, this behavior wouldn’t occur. Navigations were handled as soft navigations, resulting in the document not being downloaded on every navigation and requested only once.
### Current vs. Expected behavior
In Next.js v15, clicking on internal links leads to full page reloads (hard navigations), resulting in the entire page document being downloaded each time. This behavior differs from Next.js v14, where navigations were handled as soft navigations (client-side transitions), allowing for faster and more efficient page changes without reloading the entire document.
### Provide environment information
```bash
Operating System:
Platform: macos
Arch: x64
Binaries:
Node: 20.9.0
npm: 10.1.0
Yarn: 1.22.19
pnpm: 9.9.0
Relevant Packages:
next: 15.0.2
react: 18.3.0,
react-dom": 18.3.0,
typescript: 5.1.6
```
### Which area(s) are affected? (Select all that apply)
Navigation
### Which stage(s) are affected? (Select all that apply)
next dev (local), next start (local), Other (Deployed)
### Additional context
https://github.com/user-attachments/assets/5fd95c4d-3f0d-4bd5-9849-4c35575b3872
| bug,Navigation | low | Major |
2,637,238,567 | pytorch | [Compiled Autograd] unnecessasy Memcpy DtoD in backward graph | ### 🐛 Describe the bug
We are using compiled autograd to get the backward graph through this way:
```
loss = model(**inputs).loss
torch.cuda.synchronize()
time1 = time.time()
with torch._dynamo.compiled_autograd.enable(torch.compile(backend=my_compiler, fullgraph=True)):
loss.backward()
```
However, the timeline shows that there are many unnecessary Memcpy D2D in the graph:
<img width="1059" alt="截屏2024-11-06 下午3 10 16" src="https://github.com/user-attachments/assets/b2a83b10-a42b-4943-9936-2044a3bf69c7">
The expected timeline without compiled autograd is as follows:
<img width="800" alt="截屏2024-11-06 下午3 12 14" src="https://github.com/user-attachments/assets/473667b7-3145-443e-a301-7416749cdb1a">
### Versions
[pip3] mypy-extensions==1.0.0
[pip3] numpy==1.26.4
[pip3] nvidia-cublas-cu12==12.1.3.1
[pip3] nvidia-cuda-cupti-cu12==12.1.105
[pip3] nvidia-cuda-nvrtc-cu12==12.1.105
[pip3] nvidia-cuda-runtime-cu12==12.1.105
[pip3] nvidia-cudnn-cu12==8.9.2.26
[pip3] nvidia-cufft-cu12==11.0.2.54
[pip3] nvidia-curand-cu12==10.3.2.106
[pip3] nvidia-cusolver-cu12==11.4.5.107
[pip3] nvidia-cusparse-cu12==12.1.0.106
[pip3] nvidia-nccl-cu12==2.19.3
[pip3] nvidia-nvjitlink-cu12==12.6.20
[pip3] nvidia-nvtx-cu12==12.1.105
[pip3] optree==0.13.0
[pip3] torch==2.6.0a0+git0c525b6
[pip3] torchaudio==2.5.0.dev20241024+cpu
[pip3] torchdistx==0.3.0.dev0+cu121
[pip3] torchvision==0.20.0.dev20241024+cpu
[pip3] triton==3.0.0+gitebce7f3a
[pip3] triton-nightly==3.0.0.post20240716052845
cc @msaroufim @ezyang @chauhang @penguinwu @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @aakhundov @xmfan | needs reproduction,module: performance,triaged,oncall: pt2 | low | Critical |
2,637,275,785 | flutter | Calling go after pop using GoRouter with a StatefulShellRoute breaks navigation | ### Steps to reproduce
1. Use provided sample code
2. Launch App
3. Tap on "Page B"
4. Tap on "Details…" button
5. Tab on "Home" button
6. Tab on "Page B"
7. Tab on "Details…" button
### Expected results
I would expect the details page to appear again after step 7.
### Actual results
No navigation occurs. The app stays on "Page B".
### Code sample
<details open><summary>Code sample</summary>
```dart
import 'dart:async';
import 'package:flutter/material.dart';
import 'package:go_router/go_router.dart';
void main() {
runApp(const MyApp());
}
final GoRouter routerConfig = GoRouter(
initialLocation: '/a',
debugLogDiagnostics: true,
routes: [
StatefulShellRoute.indexedStack(
builder: (_, __, StatefulNavigationShell navigationShell) =>
HomePage(navigationShell: navigationShell),
branches: [
StatefulShellBranch(
routes: [
GoRoute(
path: '/a',
builder: (context, state) => const PageA(),
)
],
),
StatefulShellBranch(
routes: [
GoRoute(
path: '/b',
builder: (context, state) => const PageB(),
routes: [
GoRoute(
path: 'detail',
builder: (context, state) => const DetailPage(),
)
],
),
],
),
],
)
],
);
class MyApp extends StatelessWidget {
const MyApp({super.key});
// This widget is the root of your application.
@override
Widget build(BuildContext context) {
return MaterialApp.router(
title: 'Test',
routerConfig: routerConfig,
);
}
}
class HomePage extends StatelessWidget {
final StatefulNavigationShell navigationShell;
const HomePage({
super.key,
required this.navigationShell,
});
@override
Widget build(BuildContext context) {
return Scaffold(
body: navigationShell,
bottomNavigationBar: BottomNavigationBar(
items: const [
BottomNavigationBarItem(icon: Icon(Icons.home), label: 'Page A'),
BottomNavigationBarItem(icon: Icon(Icons.person), label: 'Page B'),
],
onTap: (value) {
navigationShell.goBranch(value);
},
currentIndex: navigationShell.currentIndex,
),
);
}
}
class PageA extends StatelessWidget {
const PageA({super.key});
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
title: const Text('Page A'),
),
body: const Center(
child: Text('…'),
),
);
}
}
class PageB extends StatelessWidget {
const PageB({super.key});
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
title: const Text('Page B'),
),
body: Center(
child: Column(
mainAxisSize: MainAxisSize.min,
children: [
const Text('…'),
ElevatedButton(
child: const Text('Details…'),
onPressed: () {
GoRouter.of(context).go('/b/detail');
},
)
],
),
),
);
}
}
class DetailPage extends StatelessWidget {
const DetailPage({super.key});
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
title: const Text('Detail'),
),
body: Center(
child: Column(
mainAxisSize: MainAxisSize.min,
children: [
const Text('…'),
ElevatedButton(
child: const Text('Home'),
onPressed: () {
final router = GoRouter.of(context);
router.pop();
router.go('/a');
},
)
],
),
),
);
}
}
```
</details>
### Screenshots or Video
<details open>
<summary>Screenshots / Video demonstration</summary>
[Upload media here]
</details>
### Logs
<details open><summary>Logs</summary>
```console
[GoRouter] Full paths for routes:
└─ (ShellRoute)
├─/a (PageA)
└─/b (PageB)
└─/b/detail (DetailPage)
[GoRouter] setting initial location /a
2
[GoRouter] Using MaterialApp configuration
D/EGL_emulation(18322): app_time_stats: avg=252.32ms min=11.35ms max=8030.31ms count=34
D/EGL_emulation(18322): app_time_stats: avg=1745.91ms min=1745.91ms max=1745.91ms count=1
[GoRouter] going to /b
[GoRouter] Using MaterialApp configuration
D/EGL_emulation(18322): app_time_stats: avg=28.74ms min=7.09ms max=403.04ms count=35
[GoRouter] going to /b/detail
W/WindowOnBackDispatcher(18322): OnBackInvokedCallback is not enabled for the application.
W/WindowOnBackDispatcher(18322): Set 'android:enableOnBackInvokedCallback="true"' in the application manifest.
D/EGL_emulation(18322): app_time_stats: avg=50.57ms min=5.31ms max=850.70ms count=25
[GoRouter] popping /b/detail
[GoRouter] going to /a
D/EGL_emulation(18322): app_time_stats: avg=58.27ms min=7.41ms max=848.80ms count=20
[GoRouter] restoring /b/detail
D/EGL_emulation(18322): app_time_stats: avg=31.18ms min=12.00ms max=582.96ms count=39
[GoRouter] going to /b/detail
```
</details>
### Flutter Doctor output
<details open><summary>Doctor output</summary>
```console
[✓] Flutter (Channel stable, 3.24.0, on macOS 15.1 24B83 darwin-arm64, locale en-US)
• Flutter version 3.24.0 on channel stable at /Users/dirkmika/projects/SDKs/Flutter/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 80c2e84975 (3 months ago), 2024-07-30 23:06:49 +0700
• Engine revision b8800d88be
• Dart version 3.5.0
• DevTools version 2.37.2
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
• Android SDK at /Users/dirkmika/Library/Android/sdk
• Platform android-34, build-tools 34.0.0
• Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 16.0)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 16A242d
• CocoaPods version 1.15.2
[✗] Chrome - develop for the web (Cannot find Chrome executable at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome)
! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.
[✓] Android Studio (version 2023.1)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)
[✓] VS Code (version 1.95.0)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.98.0
[✓] Connected device (5 available)
• sdk gphone64 arm64 (mobile) • emulator-5554 • android-arm64 • Android 14 (API 34) (emulator)
• Mein 13 Pro (mobile) • 00008110-000A34300C62801E • ios • iOS 18.1 22B83
• iPhone 15 Pro (mobile) • ED1976BA-F0CC-4A90-BE74-25A9E49D110D • ios • com.apple.CoreSimulator.SimRuntime.iOS-17-2 (simulator)
• macOS (desktop) • macos • darwin-arm64 • macOS 15.1 24B83 darwin-arm64
• Mac Designed for iPad (desktop) • mac-designed-for-ipad • darwin • macOS 15.1 24B83 darwin-arm64
[✓] Network resources
• All expected network resources are available.
! Doctor found issues in 1 category.
```
</details>
| package,has reproducible steps,P2,p: go_router,team-go_router,triaged-go_router,found in release: 3.24,found in release: 3.27 | low | Critical |
2,637,317,989 | ui | [bug]: pictures height inconsistancy and unalingment in firefox browser | ### Describe the bug
pictures of album component in music section of examples are unaligned(desktop view). but in chrome every thing is aligned.
### Affected component/components
AlbumArtwork
### How to reproduce
1-Open fire fox
2- Go to [https://ui.shadcn.com/examples/music](https://ui.shadcn.com/examples/music)
### Codesandbox/StackBlitz link
_No response_
### Logs
_No response_
### System Info
```bash
windows 11 64bit - firefox Version 132.0.1 (64-bit)
```
### Before submitting
- [X] I've searched for existing issues
- [X] I've made research efforts and searched the documentation
| bug | low | Critical |
2,637,342,532 | go | x/tools/gopls: feature: offer a quickfix to define a struct field on "has no field or method" error | ### gopls version
v0.16.2
### go env
```shell
-
```
### What did you do?
Having a cursor on a non defined field doesn't suggest a quickfix to declare a new struct field.
Recently a similar feature was merged https://github.com/golang/go/issues/69692 to define a missing method.
However, the ability to make a field is missing.
<img width="653" alt="Screenshot 2024-11-06 at 09 07 37" src="https://github.com/user-attachments/assets/154988e6-013c-4ce9-a2a7-184fb461ee05">
### What did you see happen?
no action suggested
<img width="761" alt="Screenshot 2024-11-06 at 09 07 48" src="https://github.com/user-attachments/assets/3baaede0-8508-4783-99bb-bfc7719f81bc">
### What did you expect to see?
A suggested quick fix "Define a struct field" exists and create a field
<img width="338" alt="Screenshot 2024-11-06 at 09 08 09" src="https://github.com/user-attachments/assets/fe3e4128-ded4-4198-935e-1479a42ea56f">
### Editor and settings
-
### Logs
- | FeatureRequest,gopls,Tools | low | Critical |
2,637,347,423 | ollama | Error: could not connect to ollama app, is it running? | ### What is the issue?
Tried versions v0.4.0, v0.3.14, and v0.3.13, all yielded the same exact results.
Attempted to start the app through start menu, file explorer, and the ollama serve command (in separate windows), all yielded the same results.
I checked the app.log, and every single launch was showing the same thing:
"time=2024-11-06T03:02:50.988-05:00 level=WARN source=server.go:163 msg="server crash 1 - exit code 2 - respawning""
And it'd go so on for server crash 1 - 30 so and so.
I hate making my own issue posts if I can help it but I've spent all night trying to fix this so I'd like some help.
### OS
Windows
### GPU
Nvidia
### CPU
Intel
### Ollama version
0.4.0-rc8 | bug,windows,nvidia,needs more info | medium | Critical |
2,637,388,989 | next.js | `response.body?.cancel()` of `fetch` causes unexpected behaviors in App Router | ### Link to the code that reproduces this issue
https://codesandbox.io/p/devbox/lucid-cohen-8r5tyq?workspaceId=cf95a29a-9e60-48fa-8cf5-0d217db0d3c6
### To Reproduce
1. Build and start server (`npm run build && npm run start`)
2. Access `/`
### Current vs. Expected behavior
### Expected:
- The `ReadableStream` (`response.body`) is successfully cancelled.
### Current:
- `response.body?.cancel()` does not resolve, causing the page to not return.
- Once `response.body?.cancel()` is called, the Next.js server does not terminate when `Ctrl + C` is pressed in the terminal.
### Provide environment information
```bash
Operating System:
Platform: linux
Arch: x64
Version: #1 SMP Fri Mar 29 23:14:13 UTC 2024
Available memory (MB): 39993
Available CPU cores: 20
Binaries:
Node: 22.11.0
npm: 10.9.0
Yarn: 1.22.15
pnpm: 9.10.0
Relevant Packages:
next: 15.0.2 // Latest available version is detected (15.0.2).
eslint-config-next: 15.0.2
react: 19.0.0-rc-02c0e824-20241028
react-dom: 19.0.0-rc-02c0e824-20241028
typescript: 5.6.3
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Not sure
### Which stage(s) are affected? (Select all that apply)
next start (local), Other (Deployed)
### Additional context
Reproduced with not only Next.js v15.0.2 but also v14.2.17 at least.
I know the way to get only header or consume body in other way. This issue focuses on the bug with `response.body.cancel`. | bug | low | Critical |
2,637,396,059 | ui | [bug]: Sidebar on mobile requires a DialogTitle | ### Describe the bug
When I open the sidebar on mobile I get this error:
```
hook.js:608 `DialogContent` requires a `DialogTitle` for the component to be accessible for screen reader users.
If you want to hide the `DialogTitle`, you can wrap it with our VisuallyHidden component.
```
### Affected component/components
Sidebar
### How to reproduce
Add a sidebar, implement a trigger, emulate a mobile device and open the sidebar. The console log should display this error.
### Codesandbox/StackBlitz link
_No response_
### Logs
_No response_
### System Info
```bash
MacOS, Chrome
```
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues | bug | medium | Critical |
2,637,412,268 | ui | [feat]: Custom breakpoint for mobile sidebar | ### Feature description
It would be nice to be able to use a different breakpoint than the hardcoded 768px value. I'm building a dashboard and the current breakpoint is too small for my use cases.
### Affected component/components
Sidebar
### Additional Context
Additional details here...
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues and PRs | area: request | low | Minor |
2,637,520,089 | PowerToys | Honour SHORTCUTS documents in the AppData\Local\Microsoft\PowerToys\NewPlus\Templates | ### Description of the new feature / enhancement
This is a brilliantly useful thing!
Just one key suggestion from me...
I think that if a SHORTCUT to a document is placed in the `AppData\Local\Microsoft\PowerToys\NewPlus\Templates` then that shortcut should be honoured and the **linked document should be instantiated**, not the shortcut.
### Scenario when this would be used?
The current version essentially requires you manage a separate set of templates from those that you may have around your system in a variety of different places.
So, currently, if you update one of your templates you then have to COPY it over to the `AppData\Local\Microsoft\PowerToys\NewPlus\Templates` folder all over again. | Needs-Triage,Product-New+ | low | Minor |
2,637,530,805 | PowerToys | Would love to personalise notifications | ### Description of the new feature / enhancement
I would love to be able to make notifications more personalized. For example making the UI more round or cute, something like that. Also a way to choose where to see the notification would be nice. Being able to not have the mesage box be 100% opacity so it's less intrusive, as well as more sound options to better work with notifications.
### Scenario when this would be used?
I have adhd/autism and need constant reminders to drink (and sometimes eat), but the main notifications of W11 are very intrusive. It could be usable on a daily basis for pretty much anyone I'd think. I now pretty much avoid the main notification feature of W11 as I find it really intrusive.
### Supporting information
_No response_ | Needs-Triage | low | Minor |
2,637,588,157 | storybook | [Tracking]: Unified a11y tests | ## 🧑🤝🧑 Who: @kasperpeulen and @valentinpalkovic
This is a tracking issue for the Unified a11y tests project. Its purpose is to keep track of the overall status of the project and tasks and plan everything around it.
## ⚠️ Problem
Accessibility (a11y) is increasingly required in modern UIs. This is already enforced for many government services around the world, and is also becoming mandated for private services as well, e.g. [European accessibility act](https://ec.europa.eu/social/main.jsp?catId=1202) which goes into law in June 2025.
Today, Storybook’s accessibility addon addon-a11y is one of the most popular addons not bundled with Storybook at 1.6M weekly npm dl’s. It provides a way to interactively test and debug a11y violations in stories
The biggest a11y product gap today is that you have to manually click on each story to see the a11y violations for that specific story. There is no way to do this across all stories in batch.
If we can solve this problem in the context of our Unified UI Testing project, it will go a long way towards improving support for A11y workflows in Storybook AND make our unified testing UI that much more compelling.
## 🏁 Goals
1. As a Storybook user, I want to be able to run a11y tests across all the stories in my Storybook, so that I can see the full a11y status of my project.
## 🚩 Milestones
```[tasklist]
## Finalize API's - Deadline: 13th Nov
- [x] Finalize Reporting API specification - Event name and payload conventions | capabilities
- [x] Finalize afterEach specification
- [x] Investigate discrepancy cases and how to deal with them
```
```[tasklist]
## Technical Preparations - Deadline: 22th Nov
- [ ] https://github.com/storybookjs/storybook/pull/29584
- [ ] https://github.com/storybookjs/storybook/pull/29608
```
```[tasklist]
## A11y Implementations - Deadline: 6th Dec
- [x] Register a11y Sub Test Provider (Batch run and single story run)
- [x] Change a11y reporting mechanism - Use Reporting API
- [x] Implement Vitest report proxy of a11y test results
- [x] https://github.com/storybookjs/storybook/pull/29682
- [x] https://github.com/storybookjs/storybook/pull/29661
- [x] [Scope increase]: Support a11y tags to enable/disable automatic a11y runs
- [x] [Scope increase]: Automigration: Automatically add `addon-a11y` to `.storybook/vitest.setup.ts` when upgrading to > 8.5.0
- [x] [Scope increase]: Addon-Test postinstall script: Consider addon-a11y if it is already installed
- [x] Documentation
- [x] Refactor status handling in frontend (Remove https://github.com/storybookjs/storybook/pull/29643/files#diff-0912d15d65479bd34f1802061483276d04484fdf7359fd9f9a53b1decd323b8eR147-R186 and sync with Gert)
- [ ] Adjust version range for automigration (https://github.com/storybookjs/storybook/pull/29643/files#diff-f0bd0ad5176683fc69b35a8f3d857e7e901b8a1d439d6aa65dad42dd8efbb071R25-R26)
- [ ] Merge https://github.com/storybookjs/storybook/pull/29643
```
```[tasklist]
## After QA
- [ ] https://github.com/storybookjs/storybook/issues/29644
- [x] Release @storybook/csf and update its version in monorepo
- [x] Update "init" components to be accessible for each framework
- [x] Adjust CI to adjust sandbox generation to include addon-a11y + writing E2E tests
```
```[tasklist]
## Bugs
- [x] @storybook/addon-a11y/preview -> Typescript reports error in certain configurations
- [x] The a11y addon panel's tab doesn't show the violation number anymore
- [ ] preview.js file is cached aggressively by vitest - restart of Storybook necessary
- [ ] In Vitest 2.1.4 and later, the status of Accessibility in the Testing module remains unknown
```
```[tasklist]
## Nice to have
- [ ] Add postinstall script to @storybook/addon-a11y to update vitest.setup.<ts|js> file if @storybook/experimental-addon-test is installed
- [ ] A11y addon improvements. Rework addon experience per Accessibility addon V2 design
- [ ] Investigate: Optimize accessibility testing to manage inherited violations in Storybook components
- [ ] https://github.com/storybookjs/storybook/pull/29552
- [ ] Improve accessibility of our own Storybook components
```
## 🚩 Out of scope
- Create a unified API to replace Status API, Testing Module API and Reporting API. | feature request,Tracking,addon: test | low | Critical |
2,637,602,922 | tailwindcss | The `theme()` function from the Tailwind config is not expanded in arbitrary values | **What version of Tailwind CSS are you using?**
3.4.14
**Reproduction URL**
https://play.tailwindcss.com/jhNKe63ed5
**Describe your issue**
`tailwind.config.js`
```
module.exports = {
theme: {
boxShadow: {
base: '0 0 0 theme(spacing.2) green inset',
},
},
}
```
`HTML`
```
<div class="[box-shadow:_theme(boxShadow.base)]">❌</div>
<div class="shadow-base">✅</div>
```
<img width="958" alt="image" src="https://github.com/user-attachments/assets/d2283f1f-f97f-46da-a4c5-27ee76edb8fd">
The `theme()` function does not expand to its actual value when an arbitrary property is used with `theme()`. | v3 | low | Minor |
2,637,608,427 | PowerToys | UI binding with `EnableDataDiagnostics` is buggy between Settings and OOBE pages | ### Microsoft PowerToys version
0.86
### Installation method
GitHub
### Running as admin
None
### Area(s) with issue?
Settings
### Steps to reproduce
- Open Settings > General > Diagnostics
- Also open OOBE > Diagnostics
- alternately switch both of the ToggleSwitches
### ✔️ Expected Behavior
Both ToggleSwitches reacting, following the setting in the background
### ❌ Actual Behavior
Switching in Settings isn't reflected in OOBE
https://github.com/user-attachments/assets/f39ed557-7fe4-447a-ad7f-b5b9cb1d32f3
After closing and re-opening OOBE window, toggleswitch _is_ correct state
### Other Software
_No response_ | Issue-Bug,Needs-Triage | low | Critical |
2,637,612,629 | pytorch | Modify CMake files to support Clang for Windows when building Libtorch-dependent apps | ### 🚀 The feature, motivation and pitch
I'm using Clang for MSVC on Windows with Ninja to build a Libtorch app. Although I do not see any mention of Clang for Windows in the install instructions of LibTorch, everything should work fine because Clang is ABI compatible with MSVC. The only issue is that some compilation flags are set for the Windows platform which are not recognized by Clang (/Z7, /EHsc, /bigobj), so it's not possible to compile unless I change some lines in the Caffe2Targets.cmake file. What I did was to change from
```
set_target_properties(torch_cpu PROPERTIES
INTERFACE_COMPILE_DEFINITIONS "USE_DISTRIBUTED;USE_C10D_GLOO"
INTERFACE_COMPILE_OPTIONS "\$<\$<COMPILE_LANGUAGE:CXX>:;\$<\$<OR:\$<CONFIG:Debug>,\$<CONFIG:RelWithDebInfo>>:/Z7>;/EHsc;/bigobj>"
INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include"
INTERFACE_LINK_LIBRARIES "protobuf::libprotobuf;c10;caffe2::mkl"
)
```
to
```
if (MSVC)
set_target_properties(torch_cpu PROPERTIES
INTERFACE_COMPILE_DEFINITIONS "USE_DISTRIBUTED;USE_C10D_GLOO"
INTERFACE_COMPILE_OPTIONS "\$<\$<COMPILE_LANGUAGE:CXX>:;\$<\$<OR:\$<CONFIG:Debug>,\$<CONFIG:RelWithDebInfo>>:/Z7>;/EHsc;/bigobj>"
INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include"
INTERFACE_LINK_LIBRARIES "protobuf::libprotobuf;c10;caffe2::mkl"
)
else()
set_target_properties(torch_cpu PROPERTIES
INTERFACE_COMPILE_DEFINITIONS "USE_DISTRIBUTED;USE_C10D_GLOO"
INTERFACE_COMPILE_OPTIONS "-fexceptions"
INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include"
INTERFACE_LINK_LIBRARIES "protobuf::libprotobuf;c10;caffe2::mkl"
)
endif()
```
Then it works perfectly. I think it could be beneficial to Windows users if the Pytorch team added support for the Clang compiler on Windows (which *I think* only requires the above fix ?).
Thanks in advance.
### Alternatives
Right now a Clang-for-Windows user has to manually modify the Caffe2Targets.cmake file to be able to compile an app that links to Libtorch.
### Additional context
_No response_
cc @malfet @seemethere @peterjc123 @mszhanyi @skyline75489 @nbcsm @iremyux @Blackhex | module: build,module: windows,triaged | low | Critical |
2,637,631,121 | PowerToys | Fancy Zones vertical pixel limit lower than 2 vertical screens height | ### Microsoft PowerToys version
0.86
### Installation method
PowerToys auto-update
### Running as admin
No
### Area(s) with issue?
FancyZones Editor
### Steps to reproduce
Fancy zones editor don't allow to use full height of 2 screens positioned vertically.
### ✔️ Expected Behavior
Zone editor should utilise full combined screen size.
### ❌ Actual Behavior
Editor limit of 3040px is below my setup. You can't drag or expand the zone below 3040px point so you end up with bottom screen zone covering half of the screen.
### Other Software
_No response_ | Issue-Bug,Needs-Triage | low | Minor |
2,637,631,879 | angular | bug(timepicker): Timepicker integration with datepicker does not work when Reactive forms are used | ### Is this a regression?
- [ ] Yes, this behavior used to work in the previous version
### The previous version in which this bug was not present was
_No response_
### Description
The new timepicker component does not integrate well with datepicker when Reactive forms are used because of Angular's bad support of binding a FormControl to multiple inputs.
Related issues:
https://github.com/angular/angular/issues/58300
https://github.com/angular/angular/issues/51239
https://github.com/angular/angular/issues/50957
### Reproduction
[StackBlitz link](https://stackblitz.com/edit/7zqfws)
Steps to reproduce:
1. Set time input in the "Reactive" fieldset and blur it.
2. Date does not update
### Expected Behavior
Should behave like the `[(ngModel)]` version.
### Actual Behavior
Date input does not update.
### Environment
Angular CLI: 19.0.0-rc.0
Node: 18.20.3
Package Manager: npm 10.2.3
OS: linux x64
Angular: 19.0.0-rc.0
... animations, cdk, cli, common, compiler, compiler-cli, core
... forms, localize, material, material-moment-adapter
... platform-browser, platform-browser-dynamic, router
Package Version
---------------------------------------------------------
@angular-devkit/architect 0.1900.0-rc.0
@angular-devkit/build-angular 19.0.0-rc.0
@angular-devkit/core 19.0.0-rc.0 (cli-only)
@angular-devkit/schematics 19.0.0-rc.0
@schematics/angular 19.0.0-rc.0
rxjs 7.4.0
typescript 5.5.4
zone.js 0.15.0 | area: forms | low | Critical |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.