id
int64
393k
2.82B
repo
stringclasses
68 values
title
stringlengths
1
936
body
stringlengths
0
256k
labels
stringlengths
2
508
priority
stringclasses
3 values
severity
stringclasses
3 values
512,010,315
go
x/text: potential Ineffective Assignments in a few packages
Background: I'm a Software Security consultant, but not a Go expert. Just learning Go. ### What version of Go are you using (`go version`)? <pre> $ go version go version go1.13.1 darwin/amd64 (i.e., MacOS) </pre> ### Does this issue reproduce with the latest release? I believe I'm using the latest version of Go. ### What did you do? I ran a free Go tool called ineffassign (from: https://github.com/gordonklaus/ineffassign) and noticed it pointed out some issues in the go libraries themselves. I asked Gordon Klaus to review them and his response was: "Some of those are harmless (if sloppy), but others look like they might be real bugs. I think they're worth reporting at golang.org/issues." ### What did you expect to see? No issues pointed out in Go libraries by this tool. ### What did you see instead? I ran ineffassign on a Go app I'm doing a security review for and noticed these results as part of the output: mpapp/vendor/golang.org/x/text/collate/build/colelem.go:205:5: ineffectual assignment to p mpapp/vendor/golang.org/x/text/collate/maketables.go:449:4: ineffectual assignment to d mpapp/vendor/golang.org/x/text/transform/transform.go:146:5: ineffectual assignment to err mpapp/vendor/golang.org/x/text/unicode/bidi/core.go:489:5: ineffectual assignment to preceedingCharacterType mpapp/vendor/golang.org/x/text/unicode/bidi/core.go:565:4: ineffectual assignment to i mpapp/vendor/golang.org/x/text/unicode/bidi/core.go:644:4: ineffectual assignment to i mpapp/vendor/golang.org/x/text/unicode/cldr/resolve.go:486:7: ineffectual assignment to err These look like part of Go itself, so I find them interesting. Do you think these are real issues that need to be reported to the maintainers of Go? Or false positives? (Gordon said report them, so here they are.)
help wanted,NeedsInvestigation
low
Critical
512,021,357
pytorch
[BUG] Can't Deepcopy module with weightnorm
## 🐛 Bug A module with `weight_norm` applied cannot be deep copied. ## To Reproduce Steps to reproduce the behavior: Example: ```python import torch import torch.nn as nn from copy import deepcopy net = nn.Sequential(nn.utils.weight_norm(nn.Linear(2, 3)), nn.Linear(3, 10)) net2 = deepcopy(net) # error out here ```` Result: ```bash RuntimeError: Only Tensors created explicitly by the user (graph leaves) support the deepcopy protocol at the moment ``` ## Expected behavior Proper deepcopy of nn.Module ## Environment PyTorch version: 1.3.0 Is debug build: No CUDA used to build PyTorch: None OS: Mac OSX 10.15 GCC version: Could not collect CMake version: version 3.15.2 Python version: 3.7 Is CUDA available: No CUDA runtime version: No CUDA GPU models and configuration: No CUDA Nvidia driver version: No CUDA cuDNN version: No CUDA Versions of relevant libraries: [pip] numpy==1.17.2 [pip] torch==1.3.0 [pip] torchvision==0.4.1a0+d94043a [conda] blas 1.0 mkl [conda] mkl 2019.4 233 [conda] mkl-service 2.3.0 py37hfbe908c_0 [conda] mkl_fft 1.0.14 py37h5e564d8_0 [conda] mkl_random 1.1.0 py37ha771720_0 [conda] pytorch 1.3.0 py3.7_0 pytorch [conda] torchvision 0.4.1 py37_cpu pytorch ## Additional context N/A
module: nn,triaged
medium
Critical
512,024,035
terminal
Tab bar flickers to a large size momentarily when hitting "enter" with zsh
# Environment ```none Windows 10.0.18362.0 ``` # Steps to reproduce 1) Launch WSL zsh shell 3) Hit enter # Expected behavior Tab size remains consistent # Actual behavior Tab size flickers in response to input in shell. In other shells, the tab resizes frequently in response to a change in the title text to adapt to the size of it. It seems like zsh has some way to detect a maximum size and truncates it, but not before WSL has rendered the update. Even in other shells that don't flicker, the "adaptive" behavior seems very strange; e.g. when I change directories it resizes the tab, causing frequent visual distraction as the UX is reorganized each time the shell title changes. I am not sure if this behavior is intentional, but I think having a fixed, consistent tab size is a much better user experience then trying to adapt to the title as it changes. For example the way Chrome works is pretty sensible; use a larger size until there are too many tabs then shrink them all, but each tab should probably always be the same size -- or at least not change while someone's actively using the shell, as would be common when someone has a title that reflects the current directory which changes often. ![windows-terminal-flicker](https://user-images.githubusercontent.com/573056/67501081-a73baa80-f651-11e9-8aa8-dd37043458d3.gif)
Issue-Bug,Area-UserInterface,Product-Terminal,Priority-3
low
Minor
512,027,415
TypeScript
Auto-import shouldn't work on `undefined`
Via #34666 **TypeScript Version:** ? <!-- Search terms you tried before logging this (so others can find this issue more easily) --> **Search Terms:** auto import undefined **Code** Some file ```ts export undefined = 10; ``` Some other file ```ts undefin| (tab) ``` **Expected behavior:** Should complete to `undefined` **Actual behavior:** Auto-imports `undefined` **Playground Link:** N/A, need modules **Related Issues:** Nope
Bug
low
Major
512,071,286
flutter
paginated_data_table_test.dart large text test times out on the Web
`packages/flutter/test/material/paginated_data_table_test.dart` times out and crashes on Cirrus CI. We should fix it.
a: tests,framework,platform-web,has reproducible steps,P2,c: tech-debt,team: skip-test,found in release: 3.3,found in release: 3.7,team-web,triaged-web
low
Critical
512,082,655
terminal
Add more abstracted VT render tests
> I've had a mind to add a test where we just make a Renderer with a Xterm256 engine, then trigger callbacks on the IRenderTarget, and make sure the frame is what we want for a while now that the pieces are tossed apart a bit nicer now, but I've never had the time The VTRenderTests are _not great_. I think it'd be better if we could have a test that more simulated "something happened in the console, did we render the right thing?". In the past, the render engines, threads and Renderer were all too coupled to make a easy unittest of it, but as the code's gotten, better, this seems more resonable. I imagine a test suite that's authored like this: 1. Create a `Renderer` with a Xterm256 engine (preferably in the `TEST_METHOD_SETUP`) 2. Grab a handle to it's `IRenderTarget` (preferably in the `TEST_METHOD_SETUP`) 3. Do some stuff to the `IRenderTarget` 4. Call `PaintFrame` on the render 5. Check that the frame painted is what we expected ###### (from conversation with @DHowett-MSFT)
Product-Conpty,Issue-Task,Area-CodeHealth
low
Minor
512,122,590
opencv
Make window resizable in samples
Feature request according to https://github.com/opencv/opencv/pull/13289 I've always liked the ability to fullscreen/resize my OpenCV windows (it helps a lot with teaching), so I would be happy to go through and make all the sample windows resizable if that's something others would be interested in.
feature,category: highgui-gui
low
Minor
512,131,146
vscode
[folding] Auto re-fold a region after the cursor leaves it.
Feature Request: Option to automatically re-fold a region after the cursor leaves it. Say if you're skipping through "Find Next" matches, it will unfold all the code it passes through. It's annoying to have to keep refolding stuff manually.
feature-request,editor-folding
low
Minor
512,144,733
flutter
flutter config --clear-ios-signing-cert does not clear out the cert
## Steps to Reproduce I had an iOS cert already set up with `flutter config`, then tried to clear it out. The next time I ran `flutter build ios` on a newly created app with default (no) signing settings, it still used the old cert. ``` $ flutter config --clear-ios-signing-cert Removing "ios-signing-cert" value. $ flutter config Configure Flutter settings. To remove a setting, configure it to an empty string. ... Settings: No settings have been configured. $ flutter build ios Building com.example.testSigning for device (ios-release)... Signing iOS app for device deployment using developer identity: "iPhone Developer: <My Identity> (ABCDEFG)" Running Xcode build... ``` ## Logs ``` $ flutter doctor -v [✓] Flutter (Channel unknown, v1.10.15-pre.202, on Mac OS X 10.14.6 18G87, locale en-US) • Flutter version 1.10.15-pre.202 at /Users/m/Projects/flutter • Framework revision 69066c88b6 (20 hours ago), 2019-10-23 17:14:34 -0700 • Engine revision 8882bf3c73 • Dart version 2.6.0 (build 2.6.0-dev.8.0 a61c775db8) [✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3) • Android SDK at /Users/m/Library/Android/sdk • Android NDK location not configured (optional; useful for native profiling support) • Platform android-28, build-tools 28.0.3 • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405) • All Android licenses accepted. [✓] Xcode - develop for iOS and macOS (Xcode 11.2) • Xcode at /Users/m/Applications/Xcode-11_2.app/Contents/Developer • Xcode 11.2, Build version 11B41 • CocoaPods version 1.8.3 [✓] Android Studio (version 3.5) • Android Studio at /Applications/Android Studio.app/Contents • Flutter plugin version 40.2.2 • Dart plugin version 191.8593 • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405) [✓] VS Code (version 1.39.2) • VS Code at /Applications/Visual Studio Code.app/Contents • Flutter extension version 3.5.1 [✓] Connected device (2 available) • Flutter iOS Device • d83d5bc53967baa0ee18626ba87b6254b2ab5418 • ios • iOS 13.1.3 • macOS • macOS • darwin-x64 • Mac OS X 10.14.6 18G87 • No issues found! ```
platform-ios,tool,P2,team-ios,triaged-ios
low
Major
512,150,148
TypeScript
Probabilistic Types
## Search Terms Probabilistic, union, supertypes ## Suggestion If a union type contains a member which is a supertype of one or more other members, the supertype subsumes those other members, but the information isn't lost. Tooling can then use that information as a hint about the expected distribution of possible values within that type. ``` type MetaSyntacticVar = 'foo' | 'bar' | 'baz' | string; ``` For the purposes of type safety, the above type is simply `string`. However, tools may consider `'foo' | 'bar' | 'baz'` to be the most likely values for `MetaSyntacticVar`. An IDE might use them for autocomplete. A linter (i.e. not tsc) might flag other values as a warning. Etc. ## Use Cases A backend service offers a range of options, and I want to statically model them as a union type. Sometimes, the service adds a new option. I must either generalize the type to a string, do a type cast and tolerate some type unsafety, or release code updates in sync with all backend updates. ## Examples ``` type MetaSyntacticVar = 'foo' | 'bar' | 'baz' | string; const name: MetaSyntacticVar = 'qux'; ================================^ IDE suggests foo, bar, or baz as I type this ================================^^^ eslint flags this as a warning (if I opt in) ``` ## Checklist My suggestion meets these guidelines: * [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code * [x] This wouldn't change the runtime behavior of existing JavaScript code * [x] This could be implemented without emitting different JS based on the types of the expressions * [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.) * [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Suggestion,In Discussion
low
Major
512,182,443
godot
Material used as next pass on multiple objects only affects one at a time
**Godot version:** 3.1 and 3.2 alpha1 **OS/device including version:** Windows 10; 10.0.18362 Build 18362 **Issue description:** ![example](https://user-images.githubusercontent.com/52017025/67524472-5f7b4a00-f676-11e9-94e6-742a6d050403.gif) I have a pair of MeshInstances, each with their own separate material to start with (green sphere, blue cube) and a SpatialMaterial with the color red. When I put this spatial material into the next pass slot of each MeshInstance's material, only one of them appears red at a time. Giving multiple objects the same material resource behaves just fine normally, its just using next pass where this behavior appears... Maybe this is some kind of intentional limitation, but it seems inconsistent to me, and is a hassle to deal with. For example, I want to apply the same shader material, with the same uniform settings, to several different objects as an additional pass, but can't do so conveniently because of this. I would have to duplicate the material and individually set the uniforms for each of them. 😢 The example project puts the materials in the material slot of the MeshInstance, but the same thing occurs when placed in the mesh itself's material slot as well. Only the editor view is necessary to show this, but it does happen when using a camera in the running game as well. **Minimal reproduction project:** [minimalrepro.zip](https://github.com/godotengine/godot/files/3769425/minimalrepro.zip)
bug,topic:rendering
low
Minor
512,187,688
pytorch
Channels Last (NHWC) support plan.
Release goals: - Support ResNet50, AlexNet, ResNeXt and proof performance gain on mixed precision models + Volta GPUs. - Unlock developers to extend channels last operators coverage. Tasks: - [x] Change factory functions (`_like` and similars) to optionally preserve format (#28839) and land with docs. - [x] Switch factory functions to preserve memory format by default (BC breaking) and fix all call sites (link tracking issue). - [x] Fix TensorIterator to preserve memory format (#28291). - [x] Land CudNN changes to support channels last (#23861). - [x] Land `adaptive_avg_pool2d` (CUDA) changes to support channels last (#24396). - [x] Add `torch.memory_format` support to the TorchScript (#28544). - [ ] Add model developer document how to check if model propagates NHWC forward and backward. Add documentation how to debug if model loosing channels last. - [ ] Add TorchVision transformer and loader PRs (need to avoid additional memory copies on loading). - [ ] Add developer docs how to write NHWC operators (https://github.com/pytorch/pytorch/wiki/Writing-memory-format-aware-operators) - [ ] Add dev docs how to check if operator support memory formats. - [ ] Documentation describing what is channels last, overlapping tensors, dense tensors, contiguous and when tensor can be both. - [x] Add channels last support to `cuda.comm.scatter` and `cuda.comm.gather` (#28077) - [x] Add model level .to_channels_last operator to convert weights. - [x] Fix max_pool2d bug (#28714). - [x] Revoke mutually exclusive requirement on channels last and contiguous memory formats (#28466). - [x] Figure out if we can ship binaries with CudNN >= 7.4 - [ ] Update site docs for `*_like`, `clone`, `to` Stretch goals: - [ ] 1d and 3d support. cc @VitalyFedyunin
triaged,module: memory format
low
Critical
512,204,337
flutter
Allow embedders to specify the AOT dylib path directly.
Currently, the only stable way to specify the AOT buffers to the engine via the Embedder API is to fetch pointer to the four blobs manually (`vm_snapshot_data`, `vm_snapshot_instructions`, `isolate_snapshot_data` and `isolate_snapshot_instructions`). The tools package these blobs in a single dynamic library. Embedders may find it more convenient if they could specify this single library to the engine during engine initialization. https://github.com/flutter/engine/pull/13324 is a potential use case.
engine,platform-mac,e: embedder,a: desktop,P2,team-macos,triaged-macos
low
Major
512,238,054
flutter
Linter false negative on a NewAPI warning for Android
When attempting to add a new flag to the Android accessibility bridge (https://github.com/flutter/engine/pull/13262): ```java // Heading support if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) { result.setHeading(semanticsNode.hasFlag(Flag.IS_HEADER)); } ``` The linter complained that the `setHeading` API required version 28 (Pie). However, there is an if guard that should protect for this case. This is also odd given that there are other similar guards in this same function that don't cause warnings. To work around the issue, I suppressed the warning with a `@SuppressLint("NewApi") annotation. However, if we can fix this bug we should remove the suppression, as this is a rather large function and I don't want to miss something else because we turned off the lint because of this one instance.
team,platform-android,engine,dependency: android,P2,team-android,triaged-android
low
Critical
512,354,999
PowerToys
Move Hidden Windows to active screen
# Move Hidden Windows to active screen Some applications do not play nicely with multiple monitor scenarios. They mainly the ones which remember their screen position. Scenario Laptop with additional monitor. Start an affected application when you have two monitors connected and move it to monitor two, shut PC down. Disconnect the second monitor, then start up PC and run the affected application. All you see is a task bar icon becuse the application has blisfully unaware thet the second monitor is not preset jumped to the monitor which does not now exist. I know there is a documented way to move such windows to an available screen, but it requires quite a bit of faffing arround. I invariably end up googling for the required key chord each time I need it becuase it does not happed that often, but often enough to cause irritation. A hook that allowed the user to right click the task bar icon and "move to screen n" would be very much appreciated. Some of the code in https://github.com/MikeWilliams-UK/SSMS-Window-Fixer may be of use in this.
Idea-New PowerToy,Product-Window Manager
medium
Critical
512,374,147
godot
Mesh gets deformed when running animation
**Godot version:** 3.2 Alphas 1,2,3 **OS/device including version:** WIN 10 **Issue description:** Mesh gets deformed when running animation **Steps to reproduce:** Open attached Godot project Open scene rat_grey.escn Run animation 'rat_sits_down_scratchinh' Mesh is deformed during animation: ![image](https://user-images.githubusercontent.com/7196697/67555230-b181a580-f732-11e9-87cf-edcb84596202.png) **Minimal reproduction project:** [test2.zip](https://github.com/godotengine/godot/files/3771086/test2.zip)
bug,confirmed,topic:import
medium
Major
512,375,115
go
syscall: ReadLink() & Utimes() arguments for access-mode & share-mode are wrong
A search for CreateFile() finds the following read-only functions with a zero share-mode argument. I think their share-mode should be `FILE_SHARE_READ`, and in some cases also `FILE_SHARE_WRITE`. EDIT: They would also need `FILE_SHARE_DELETE` in apps that expect to rename or remove a file concurrently with any of these ops. ``` readlink() os/file_windows.go: h, err := syscall.CreateFile(p, 0, 0, nil, stat() os/stat_windows.go: h, err := syscall.CreateFile(namep, 0, 0, nil, loadFileId() os/types_windows.go: h, err := syscall.CreateFile(pathp, 0, 0, nil, ReadLink() syscall/syscall_windows.go: fd, err := CreateFile(StringToUTF16Ptr(path), GENERIC_READ, 0 ``` EDIT: these should probably get `| FILE_SHARE_READ` ``` Utimes() syscall/syscall_windows.go: h, e := CreateFile(pathp, FILE_WRITE_ATTRIBUTES, FILE_SHARE_WRITE UtimesNano() syscall/syscall_windows.go: h, e := CreateFile(pathp, FILE_WRITE_ATTRIBUTES, FILE_SHARE_WRITE ``` This simple patch adds `FILE_SHARE_DELETE` in syscall.Open(), but it doesn't help the above cases: ``` diff --git a/src/syscall/syscall_windows.go b/src/syscall/syscall_windows.go index de05840..e1455d5 100644 --- a/src/syscall/syscall_windows.go +++ b/src/syscall/syscall_windows.go @@ -245,6 +245,8 @@ func makeInheritSa() *SecurityAttributes { return &sa } +var Open_FileShareDelete = false + func Open(path string, mode int, perm uint32) (fd Handle, err error) { if len(path) == 0 { return InvalidHandle, ERROR_FILE_NOT_FOUND @@ -270,6 +272,9 @@ func Open(path string, mode int, perm uint32) (fd Handle, err error) { access |= FILE_APPEND_DATA } sharemode := uint32(FILE_SHARE_READ | FILE_SHARE_WRITE) + if Open_FileShareDelete { + sharemode |= FILE_SHARE_DELETE + } var sa *SecurityAttributes if mode&O_CLOEXEC == 0 { sa = makeInheritSa() ``` cc @alexbrainman @zx2c4 @mattn @gopherbot add OS-Windows
OS-Windows,NeedsInvestigation
medium
Critical
512,422,259
rust
Clarify guarantees for `Vec` and `String` allocation
Similar to what https://github.com/rust-lang/rust/pull/58183 did for `Box`, I think we should document a guarantee that `Vec<T>` and `String` are allocated through the standard library’s global allocator. Namely: * It is valid (under some conditions) to pass a pointer allocated with `std::alloc::Global` (or corresponding free functions in `std::alloc`) to `Vec::from_raw_parts`. * It is valid (under some conditions) to deallocate or reallocate with `std::alloc::Global` (or corresponding free functions in `std::alloc`) a pointer from [`Vec::into_raw_parts`](https://github.com/rust-lang/rust/pull/65705) (or from `ManuallyDrop` + `Vec::as_mut_ptr`). Conditions include using the appropriate `std::alloc::Layout`, properly transferring ownership, etc. Perhaps the documented guarantees should also extend to using `NonNull<T>::dangling` for zero-size allocations. (And similarly for `Box`.) @rust-lang/libs, any throughts?
C-enhancement,A-allocators,A-collections,T-libs-api
low
Minor
512,422,398
flutter
CupertinoAlertDialog has blurry lines
The lines to separate the action buttons are blurry. In `cupertiono/dialog.dart` the `dividerThickness` is callculated this way: ``` dividerThickness: _kDividerThickness / MediaQuery.of(context).devicePixelRatio ``` But do we need the `devicePixelRatio` to do so? When I just use `dividerThickness: _kDividerThickness` the lines are perfect. On the left side, you can see the divider with `dividerThickness: _kDividerThickness / MediaQuery.of(context).devicePixelRatio`. On the right side, you can see the divider with `dividerThickness: _kDividerThickness`. ![Screen Shot 2019-10-25 at 11 38 54 png 2019-10-25 11-47-29](https://user-images.githubusercontent.com/1191649/67562207-9147eb80-f71e-11e9-9036-3f4c08cb322c.png)
framework,engine,a: fidelity,f: cupertino,a: quality,has reproducible steps,P2,found in release: 3.7,found in release: 3.8,team-design,triaged-design
low
Major
512,445,298
vscode
Web: allow to use Fira Code in editor (Safari)
Open web in Safari with `"editor.fontFamily": "Fira Code"`. the font is not being loaded it seems. Works fine in other browsers. ![image](https://user-images.githubusercontent.com/900690/67565531-f3581f00-f725-11e9-878f-1b53ad9b4685.png) The only workaround that helped as to directly import the font into the HTML (https://cdn.rawgit.com/tonsky/FiraCode/1.205/distr/fira_code.css). Maybe related to how they define a `src` for the font and we don't?
feature-request,font-rendering,web,safari
medium
Major
512,452,766
pytorch
Can't successfully install pytorch with python3.6 on my pi 4
**my pi info:** Linux raspberrypi 4.19.50-v7l+ #895 SMP Thu Jun 20 16:03:42 BST 2019 armv7l GNU/Linux It gets to this point in the installation and I get this err: ``` [ 44%] Built target c10_LeftRight_test /usr/bin/ld: ../../../lib/libprotobuf.a(arena.cc.o): in function `google::protobuf::internal::ArenaImpl::Init()': arena.cc:(.text+0x24): undefined reference to `__atomic_fetch_add_8' collect2: error: ld returned 1 exit status make[2]: *** [third_party/protobuf/cmake/CMakeFiles/protoc.dir/build.make:87: bin/protoc] Error 1 make[1]: *** [CMakeFiles/Makefile2:241: third_party/protobuf/cmake/CMakeFiles/protoc.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs.... [ 44%] Built target c10_bfloat16_test [ 44%] Built target sleefdetpurecfma_scalar [ 44%] Built target sleefdetpurec_scalar make: *** [Makefile:141: all] Error 2 Traceback (most recent call last): File "setup.py", line 751, in <module> build_deps() File "setup.py", line 310, in build_deps cmake=cmake) File "/home/pi/Desktop/pytorch/tools/build_pytorch_libs.py", line 59, in build_caffe2 cmake.build(my_env) File "/home/pi/Desktop/pytorch/tools/setup_helpers/cmake.py", line 334, in build self.run(build_args, my_env) File "/home/pi/Desktop/pytorch/tools/setup_helpers/cmake.py", line 142, in run check_call(command, cwd=self.build_dir, env=env) File "/home/pi/miniconda3/envs/mimicVoice/lib/python3.6/subprocess.py", line 291, in check_call raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['cmake', '--build', '.', '--target', 'install', '--config', 'Release', '--', '-j', '4']' returned non-zero exit status 2. ``` I need it to run on python3.6 Is this enough info to get some advice?
module: build,triaged,has workaround
low
Critical
512,463,137
kubernetes
Ephemeral Containers: Automatically taint pods with ephemeral containers
**What would you like to be added**: Automatically adding an annotation to pods in which an ephemeral container has been added. **Why is this needed**: A common usage pattern for ephemeral containers is to perform some debugging action in a pod that changes its state in some fashion. Since the pod is no longer pristine, it should be marked as such so it could automatically be deleted.
area/kubelet,sig/node,kind/feature,priority/important-longterm,lifecycle/frozen,needs-triage
medium
Critical
512,463,348
rust
impl Trait does not capture lifetime of generic argument
According to [RFC 1951](https://github.com/rust-lang/rfcs/blob/master/text/1951-expand-impl-trait.md), `impl Trait` in return position should capture the lifetime of any associated generic parameters. However, in this code, that logic appears not to work ([playground](https://play.rust-lang.org/?version=beta&mode=debug&edition=2018&gist=62d220b0533fcb9530ee5f2c75ac31c4)): ```rust use std::future::Future; use std::pin::Pin; struct A; impl A { fn a<T>(&self, t: T) -> impl Future<Output = ()> { let _ = t; async {} } } struct B(A); impl B { fn works<'a, T: 'a>( self, t: T, ) -> impl Future<Output = (Self, impl Future<Output = ()> + 'a)> + 'a { async move { let f = Pin::from(Box::new(self.0.a(t)) as Box<dyn Future<Output = _>>); (self, f) } } fn doesnt_work<T>(self, t: T) -> impl Future<Output = (Self, impl Future<Output = ()>)> { async move { let f = Pin::from(Box::new(self.0.a(t)) as Box<dyn Future<Output = _>>); (self, f) } } } ``` Specifically, the compiler gives two _almost_ identical errors for the `doesnt_work` method: ``` error[E0310]: the parameter type `T` may not live long enough --> src/lib.rs:28:31 | 26 | fn doesnt_work<T>(self, t: T) -> impl Future<Output = (Self, impl Future<Output = ()>)> { | - help: consider adding an explicit lifetime bound `T: 'static`... 27 | async move { 28 | let f = Pin::from(Box::new(self.0.a(t)) as Box<dyn Future<Output = _>>); | ^^^^^^^^^^^^^^^^^^^^^ | note: ...so that the type `impl std::future::Future` will meet its required lifetime bounds --> src/lib.rs:28:31 | 28 | let f = Pin::from(Box::new(self.0.a(t)) as Box<dyn Future<Output = _>>); | ^^^^^^^^^^^^^^^^^^^^^ ``` and ``` error[E0310]: the parameter type `T` may not live long enough --> src/lib.rs:28:31 | 26 | fn doesnt_work<T>(self, t: T) -> impl Future<Output = (Self, impl Future<Output = ()>)> { | - help: consider adding an explicit lifetime bound `T: 'static`... 27 | async move { 28 | let f = Pin::from(Box::new(self.0.a(t)) as Box<dyn Future<Output = _>>); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: ...so that it can be closed over into an object --> src/lib.rs:28:31 | 28 | let f = Pin::from(Box::new(self.0.a(t)) as Box<dyn Future<Output = _>>); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ``` I was (perhaps mistakenly) under the impression that the semantics of `impl Trait` in return position should be as the explicit lifetimes on the `works` method indicate, but that doesn't seem to be the case? When the lifetimes are explicitly annotated, as in the `works` method, the method compiles just fine.
A-type-system,A-lifetimes,T-lang,A-impl-trait,T-types
low
Critical
512,469,538
go
x/mobile: `go test golang.org/x/mobile/bind/objc` failed with Xcode 11.1
<!-- Please answer these questions before submitting your issue. Thanks! --> ### What version of Go are you using (`go version`)? <pre> $ go version go version go1.13.1 darwin/amd64 </pre> ### Does this issue reproduce with the latest release? Yes ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env GO111MODULE="" GOARCH="amd64" GOBIN="" GOCACHE="/Users/hajimehoshi/Library/Caches/go-build" GOENV="/Users/hajimehoshi/Library/Application Support/go/env" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="darwin" GONOPROXY="" GONOSUMDB="" GOOS="darwin" GOPATH="/Users/hajimehoshi/go" GOPRIVATE="" GOPROXY="https://proxy.golang.org,direct" GOROOT="/usr/local/go" GOSUMDB="sum.golang.org" GOTMPDIR="" GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64" GCCGO="gccgo" AR="ar" CC="clang" CXX="clang++" CGO_ENABLED="1" GOMOD="" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/ht/ky_bwgzs4bd5z1hh02k34x_h0000gn/T/go-build920015374=/tmp/go-build -gno-record-gcc-switches -fno-common" </pre></details> ### What did you do? <!-- If possible, provide a recipe for reproducing the error. A complete runnable program is good. A link on play.golang.org is best. --> ``` cd $(go env GOPATH)/src/golang.org/x/mobile go test ./bind/objc/ ``` ### What did you expect to see? The test passes ### What did you see instead? The test fails for example ``` --- FAIL: TestObjcCustomPkg (49.76s) seq_test.go:116: tmpdir = /var/folders/ht/ky_bwgzs4bd5z1hh02k34x_h0000gn/T/bind-objc-seq-test-201072910 seq_test.go:149: User defaults from command line: IDETestRunOnlyIdentifiers = ( xcodetestTests ) xcodebuild: error: Unable to find a destination matching the provided destination specifier: { platform:iOS Simulator, OS:latest, name:iPhone 6s Plus } The requested device could not be found because no available devices matched the request. Available destinations for the "xcodetest" scheme: { platform:iOS Simulator, id:1FBDEEDC-D891-47EE-A4E4-C9B5E902110C, OS:13.1, name:iPad Air (3rd generation) } { platform:iOS Simulator, id:30824713-61F9-4BA7-A1EE-248DA40E4E27, OS:13.1, name:iPad Pro (9.7-inch) } { platform:iOS Simulator, id:AF88039D-79C0-4483-8BBD-C30CC066DBEF, OS:13.1, name:iPad Pro (11-inch) } { platform:iOS Simulator, id:0E1C991D-11C6-482A-B9E9-A053C7E91525, OS:13.1, name:iPad Pro (12.9-inch) (3rd generation) } { platform:iOS Simulator, id:E0DB1DB4-2F99-44FA-8DC8-EDB96140E527, OS:13.1, name:iPhone 8 } { platform:iOS Simulator, id:70D15E50-999C-4DAA-8C4A-1EBD680C0A2F, OS:13.1, name:iPhone 8 Plus } { platform:iOS Simulator, id:22A966A1-9AE5-4BFE-9B1A-F7CAB1FACC37, OS:13.1, name:iPhone 11 } { platform:iOS Simulator, id:8E935EFC-97B6-449A-B589-1B0ED3972246, OS:13.1, name:iPhone 11 Pro } { platform:iOS Simulator, id:5F62606E-C1E5-4918-8930-4FCFA9CC8B19, OS:13.1, name:iPhone 11 Pro Max } Ineligible destinations for the "xcodetest" scheme: { platform:iOS, id:dvtdevice-DVTiPhonePlaceholder-iphoneos:placeholder, name:Generic iOS Device } { platform:iOS Simulator, id:dvtdevice-DVTiOSDeviceSimulatorPlaceholder-iphonesimulator:placeholder, name:Generic iOS Simulator Device } seq_test.go:150: failed to run xcodebuild: exit status 70 FAIL FAIL golang.org/x/mobile/bind/objc 206.323s FAIL ``` ``` $ xcodebuild -version Xcode 11.1 Build version 11A1027 ``` CC @hyangah
NeedsInvestigation,mobile
low
Critical
512,519,508
terminal
Alt+Numpad input is broken (since Windows 7)
<!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> Prior to Windows 7 it was possible to enter any "Unicode" (UCS-2 0-65535 range) character into a console app using Alt + Numpad keys. This feature has been broken since Windows 7 (probably due to moving some console code into conhost.exe). # Environment ```none Any OS version since Windows 7. Any other software? No. ``` # Steps to reproduce Run the attached app: [readkey.zip](https://github.com/microsoft/terminal/files/3772212/readkey.zip) - Press and hold the Alt key - Type any large enough decimal number on the numeric keyboard, say, 8888 or 65535. - Release the Alt key - Press and hold the Alt key - Type any small enough decimal number on the numeric keyboard, say, 1 or 7. - Release the Alt key <!-- A description of how to trigger this bug. --> # Expected behavior <!-- A description of what you're expecting, possibly containing screenshots or reference material. --> ## Windows 2000 / XP / 2003 / Vista / 2008 The release of the Alt key generates a KEY_EVENT_RECORD with wVirtualKeyCode = VK_MENU and uChar.UnicodeChar = <the number you've entered>. The expected output of the app for Alt+8888: `KEY_EVENT_RECORD: Up, Count=1, Vk=VK_MENU [18/0x12], Scan=56, uChar=[U='⊸'(0x22b8) A='¸'(0xb8)], Control=0x04000020 (casac - ecNs)` The expected output of the app for Alt+1: `KEY_EVENT_RECORD: Up, Count=1, Vk=VK_MENU [18/0x12], Scan=56, uChar=[U='☺'(0x0001) A='☺'(0x01)], Control=0x04000020 (casac - ecNs)` # Actual behavior <!-- What's actually happening? --> ## Windows 7 / 8 / 10 classic / 10 new The release of the Alt key generates a KEY_EVENT_RECORD with wVirtualKeyCode = VK_MENU and some rubbish in uChar.UnicodeChar. The actual output of the app for Alt+8888: `KEY_EVENT_RECORD: Up, Count=1, Vk=VK_MENU [18/0x12], Scan=56, uChar=[U='©'(0x00a9) A='©'(0xa9)], Control=0x00000020 (casac - ecNs)` The actual output of the app for Alt+1: `KEY_EVENT_RECORD: Up, Count=1, Vk=VK_MENU [18/0x12], Scan=56, uChar=[U='☺'(0x263a) A=':'(0x3a)], Control=0x00000020 (casac - ecNs)` It looks like the host performs some dodgy internal conversions on the entered Unicode character. And it's especially mental in the case of Alt+1 (and other "control" characters below 0x20): instead of setting both UnicodeChar and AsciiChar to 0x1, it somehow takes a Unicode "replacement" for \1 - '☺'(0x263a), as if the wollowing code has been executed somewhere: ```C++ wchar_t W; MultiByteToWideChar(CP_OEMCP, MB_USEGLYPHCHARS, "\1", 1, &W, 1); assert(W == 0x263a); ``` Is it possible to stop doing those weird conversions and return to the pre-Windows 7 behaviour? Thanks.
Product-Conhost,Area-Input,Issue-Bug
medium
Critical
512,529,315
node
symlink out/Release/lib.target → out/Release/lib needs to be created manually before “make install”
On my Linux from Scratch system, building node 12.13.0 with `./configure --gdb --enable-lto --ninja --shared --openssl-use-def-ca-store` and python 3 creates the file `out/Release/lib/libnode.so.72` but “make install” looks for the file `out/Release/lib.target/libnode.so.72`. So I have to create symlink out/Release/lib.target → out/Release/lib. Moreover, `./configure --ninja` suggests, that after ./configure has finished, one can call `ninja`, but this does not work. I know the Makefile calls ninja, but running direct `ninja` shall also work.
build
low
Major
512,574,996
rust
Tracking issue for `vec_into_raw_parts`
https://github.com/rust-lang/rust/pull/65705 adds: ```rust impl String { pub fn into_raw_parts(self) -> (*mut u8, usize, usize) {…} } impl<T> Vec<T> { pub fn into_raw_parts(self) -> (*mut T, usize, usize) {…} } ``` # Things to evaluate before stabilization - [ ] [Should they return `NonNull<* mut T>`](https://github.com/rust-lang/rust/issues/65816#issuecomment-546405936)? - [ ] [Should they be associated functions](https://github.com/rust-lang/rust/issues/65816#issuecomment-546448429)?
A-collections,T-libs-api,B-unstable,C-tracking-issue,Libs-Tracked,A-raw-pointers
high
Critical
512,577,150
terminal
Add comprehensive XAML "theming" functionality
As I mentioned in https://github.com/microsoft/terminal/issues/3322#issuecomment-546391285, we've been dancing around the idea of "XAML theming" for a while in a bunch of issues, but never had one place to track all the requested functionality. This will serve as the master thread for those requests. > It looks to me like we've danced around the idea in #1963, #1337, #3061/#3062, #2994, but never had a comprehensive answer. Ideally, these are something that's more powerful than just setting the "color scheme". This would control sizing, coloration of UI elements of the app itself, not just the colors of the terminal _contents_. Consider things like themes in VsCode, Sublime Text, where there are _schemes_ that can control the colorization of the buffer, and **themes** that can change the appearance of the app itself. UI elements to be able to control: * [ ] #3061 Pane Border colors (both the background, and the "focused" color) * [ ] #3063 Pane border width * [x] #702 👀 Tab Background color - also: #1337 - also: #2994 * [x] #13684 * [x] #3774 👀 Tab row BG color - [x] #1963 👀 users should be able to set it to the system accent color - Users want the tab row to match the BG color of the focused pane/terminal. This is the inverse of #702 * [x] #3335 👀 Feature Request: Setting to hide/remove close ("x") button from tabs * [x] #4862 👀 Support using different colors in the titlebar for focused/unfocused windows * [ ] #5911 Support for `compact`, `default`, and `touch` friendly tab row sizes * [ ] #7213 - Also used for setting the corner radius - Also tracking "get rid of the bottom, outwards corner radius" * [ ] #16114 Other ideas: * [ ] #5155 Tab row height * [ ] Tab row font size, font face * [ ] Margin between tabs? * [ ] Padding within the tab? * [ ] Control colors for light vs dark vs high-contrast modes * [ ] Enable/disable a shadow underneath the tab row, between tabs and content - **more relevant after #12916** which added the shadow to the whole row * [ ] Enable/disable a shadow cast by terminals on pane borders or a shadow cast by pane borders on Terminal panes * [ ] Similarly to the tabs, styling the Status Bar (#3459) - Maybe enable it to have the same color as the active TermControl, causing the same "seamless" effect (https://github.com/microsoft/terminal/issues/3459#issuecomment-550501577) - Change font size, face, colors - Control the borders on the status bar - no top border would give the impression it's "seamless" * [ ] Enable hiding the tab icon altogether (#8157) * [ ] Enable forcing tab icons to monochrome * [ ] Force a colorscheme? This seems weird, and probably not what people want. * [ ] Allow color fields to refer back to the active color scheme (like `cursorColor = yellow`) (#7522) * [ ] Please provide a new setting: verticalScrollBarWidth #9218 * [ ] Light mode in settings UI only #9231 * [ ] #13991 * [ ] #12632 Currently we don't have all that many UI elements, but in a hypothetical world with a command palette (#2046) and a search box (#605), there'll be even more UI elements to be able to control. I know @cinnamon-msft had some mockups of "themes". I imagine that these would be something that would be easier to control with XAML resources somehow, though I'm not sure how technically possible it would be to have the user specify a XAML file and have us load it into our resources at runtime. But that might be an option to pursue as an alternative to adding tons of new settings that will need to be parsed and applied manually at runtime. Potential solution design: <details> This is a real showerthought of a design, which needs real spec'ing, but here's what I came up with this (06 Dec 2019) morning ```json { "applicationTheme": "My Boxy Theme", "themes": [ { "name": "My Boxy Theme", "requestedTheme": "dark", "tab.radius": 0, "tab.padding": 5, "tab.background": "terminalBackground", "tab.textColor": "key:SystemAccentColorLight3", "tab.icon": "monochrome", "tab.closeButton": "hidden", "tabRow.background": "accent", "tabRow.shadows": false }, { "name": "My small light theme", "tabBackground": "#80ff0000", "tabRowBackground": "#ffffffff", "tabHeight": 16, "requestedTheme": "light", "colorSheme": "Solarized Light", "tabIcon": "hidden", "tabCloseButton": "hover" } ] } ``` I've given both a `tab.<property>` and a `tab<Property>` style here, for comparison. Unsure of which is better. Colors can be one of: * an `#aarrggbb` color * `accent` for the accent color * `terminalBackground` to use the default background color of the focused terminal * `terminalForeground` to use the default foreground color of the focused terminal - does anyone want this? * `key:SomeXamlKey` to try and look `SomeXamlKey` up from our resources as a `Color`, and use that color for the value. - Does anyone want this? - is `accent` just `key:SystemAccentColor`? Then we have a bunch of UI settings. We'll use these settings to set XAML resource values, like the `TabViewBackground`. Then, when they change, the UI should just respond to these values changing right? ### Open Questions: * For hot-reloading settings - does updating resources in xaml auto-relayout things? * For `"tabBackground": "terminalBackground"`, does changing the default background color from within the terminal automatically update this color for UI elements? (hopefully). * This design doesn't really have both light and dark variants, instead just sets a system theme it wants. What if the theme specifies `system`? could it support light and dark versions somehow? #### Tab Color Picker With the tab color picker that sets tab colors, how does that interact with this? We probably don't actually want the color to apply to the whole tab itself, we probably just want an overline. If we have an overline, people probably what to be able to set it. Manually setting the color with the menu should just be an override - "tabColorOverride", so that a settings reload doesn't blow it away. Presumably, there's a way to set the background color of a tab manually to override that of the theme - thet's probably how that PR works today. How would we make sure that `"tab.background": "terminalBackground"` works with manually overriding the tab color? </details> Terminal should be able to look [beautiful](https://github.com/microsoft/terminal/issues/3327#issuecomment-765493313), and also like this: ![image](https://user-images.githubusercontent.com/18356694/151258949-bcca7275-4be7-48a4-ab60-f60e917e0e62.png) #### Followup flow chart: ```mermaid flowchart TD subgraph Theming id_b[tabRow.background] id_c[ themeColor:accent ] id_d[ themeColor:terminalBackground ] %% id1[Theming #12992] end id2[tab.background<br>#702<br>PR #13178] id3[tabRow.inactiveBackground<br>#4862<br>PR 13049] id4(tab.inactiveBackground<br>#4862) tabclose[tab.closeButton<br>#3335<br>PR #13348] id15{{Terminal v1.16}} %% Initial theming support %% id_a-->id1 %% id_b-->id1 %% id_c-->id1 %% id_d-->id1 %% 1.16 features Theming --> id3 Theming --> id2 id2 --> id4 id3 --> id15 id4 --> id15 id2 --> tabclose --> id15 Theming --> id_transparent(Transparent titlebars<br>window.useMica<br>#10509) Theming --> id_acrylic_tabRow(Acrylic titlebar) --> id15 %% Etc features subgraph Pane direction TB pane.borderColor(pane.borderColor<br>#3061) pane.inactiveBorderColor(pane.inactiveBorderColor) pane.borderWidth(pane.borderWidth<br>#3063) pane.borderColor --> pane.inactiveBorderColor end subgraph Tab direction TB tabcorners(tab.corners<br>#7213) end subgraph Window direction TB window.background(window.background<br>#16114) window.frameColor(window.frameColor) --> rainbow(themeColor:rainbow<br>#12950) end id15 --> Pane id15 --> Tab id15 --> Window id15 --> lightDark(OS-theme sensitive theming) click id4 "http://www.github.com/microsoft/terminal/issues/4862" ```
Area-Settings,Product-Terminal,Issue-Scenario,Area-Theming
medium
Critical
512,578,745
pytorch
Cmake fails due to bad python call
## 🐛 Bug The call to python on [line 158](https://github.com/pytorch/pytorch/blob/e2125436817504794f5ecebec17adf233137d89c/cmake/Codegen.cmake#L158) in cmake/Codegen.cmake fails due to an undefined `PYTHON_EXECUTABLE` variable. ## To Reproduce Steps to reproduce the behavior: 1. Clone repo 2. `mkdir build; cd build` 3. `cmake -DBUILD_CUSTOM_PROTOBUF=OFF -DBUILD_TORCH=ON -DBUILD_SHARED_LIBS=ON -DBUILD_PYTHON=OFF -DCMAKE_INSTALL_PREFIX:=/usr/local/ ..` ``` Call Stack (most recent call first): CMakeLists.txt:373 (include) -- Looking for clock_gettime in rt -- Looking for clock_gettime in rt - found -- Looking for mmap -- Looking for mmap - found -- Looking for shm_open -- Looking for shm_open - found -- Looking for shm_unlink -- Looking for shm_unlink - found -- Looking for malloc_usable_size -- Looking for malloc_usable_size - found -- Performing Test C_HAS_THREAD -- Performing Test C_HAS_THREAD - Success -- GCC 7.4.0: Adding gcc and gcc_s libs to link line -- don't use NUMA -- Performing Test COMPILER_SUPPORTS_NO_AVX256_SPLIT -- Performing Test COMPILER_SUPPORTS_NO_AVX256_SPLIT - Success -- CMake Error at cmake/Codegen.cmake:172 (message): Failed to get generated_cpp list Call Stack (most recent call first): caffe2/CMakeLists.txt:2 (include) ``` ## Expected behavior Expect cmake to complete ## Environment ``` Collecting environment information... PyTorch version: N/A Is debug build: N/A CUDA used to build PyTorch: N/A OS: Linux Mint 19.2 Tina GCC version: (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0 CMake version: version 3.10.2 Python version: 2.7 Is CUDA available: N/A CUDA runtime version: Could not collect GPU models and configuration: Could not collect Nvidia driver version: Could not collect cuDNN version: Could not collect Versions of relevant libraries: [pip] numpy==1.16.5 [conda] Could not collect ``` ## Additional context Tested on Ubuntu 16, same behavior ``` Collecting environment information... PyTorch version: N/A Is debug build: N/A CUDA used to build PyTorch: N/A OS: Ubuntu 16.04.6 LTS GCC version: (Ubuntu 5.4.0-6ubuntu1~16.04.11) 5.4.0 20160609 CMake version: version 3.13.3 Python version: 2.7 Is CUDA available: N/A CUDA runtime version: Could not collect GPU models and configuration: Could not collect Nvidia driver version: Could not collect cuDNN version: Could not collect Versions of relevant libraries: [pip] numpy==1.13.1 [pip] torch==1.1.0a0+83cf947 [pip] torchvision==0.2.2.post3 [conda] Could not collect ```
module: build,triaged
low
Critical
512,580,274
node
suggested updates to the onboarding doc
This is a TODO list that I took during the onboarding of legendcas. Opening an issue in case I forget about them - but feel free to pick them up if you are interested to help! - [ ] Mention this trick `git remote set-url origin --push no_push` - [ ] Mention nodejs/help (when triaging issues) - [ ] It’s not necessary to explain everything in the on boarding document. The person doing the onboarding can ask whether the collaborator already knows about each point and skip if they already do. If they have questions, answer them. - [ ] Mention the new 7 day rule, or just add a link to the collaborator guide about the rules - [ ] Mention other commonly used CIs - [ ] micro benchmark - [ ] v8 - [ ] custom e.g. internet - [ ] stress test - [ ] citgm - [ ] Mention how to get a git ref to use in the Jenkins build parameters - [ ] The `what belongs in Node.js` seems a bit outdated? In general we just open issues and discuss on a case-by-case basis - [ ] Mention the travis CI - [ ] Mention the resume build button and the stop button in Jenkins - [ ] Mention how to report issues to the build team: with the machine id - [ ] TODO(joyee): Update node-core-utils recording, and just add a link to the recording to quickly demonstrate how to use it - [ ] Add the github-bot and node-core-utils repo to the "other repos" links, and explain what those are - [ ] Mention the Collboarator github team discussion page - [ ] Mention how security bugs are handled (or a link to SECURITY.md) - [ ] Mention that collaborators can nominate other collaborators (and add a link to GOVERNANCE.md)
doc,meta
low
Critical
512,587,860
rust
Using `include_bytes!` on large binary blobs compiles more slowly than expected
I've been playing around recently with compiling a crate that simply contains: ```rust pub const BYTES: &[u8] = include_bytes!("large-binary-blob"); ``` and I've been surprised that the compile time of this crate is pretty nontrivial! For example this crate: ```rust pub const BYTES: &[u8] = &[]; ``` takes 0.060 seconds to compile on nightly for me. If a multi-megabyte binary (such as `cargo` itself) is included: ```rust pub const BYTES: &[u8] = include_bytes!("/path/to/.cargo/bin/cargo"); ``` this crate takes 0.729 seconds to compile! There appear to be at least two major sources of slowdown: 1. In the [expansion of `include_bytes!`](https://github.com/rust-lang/rust/blob/770b9e3012bd58bdf6046d328dabfd57df163eb6/src/libsyntax_ext/source_util.rs#L171) the [`expr_lit` function](https://github.com/rust-lang/rust/blob/770b9e3012bd58bdf6046d328dabfd57df163eb6/src/libsyntax_expand/build.rs#L322-L325) calls [`from_lit_kind`](https://github.com/rust-lang/rust/blob/770b9e3012bd58bdf6046d328dabfd57df163eb6/src/libsyntax/parse/literal.rs#L215-L217) which calls [`to_lit_token`](https://github.com/rust-lang/rust/blob/770b9e3012bd58bdf6046d328dabfd57df163eb6/src/libsyntax/parse/literal.rs#L145-L149) that runs an operation per-byte, which is pretty expensive for multi-megabyte files. 2. Later in compilation while emitting metadata when we're [processing constants](https://github.com/rust-lang/rust/blob/770b9e3012bd58bdf6046d328dabfd57df163eb6/src/librustc_metadata/encoder.rs#L1074-L1077) we'll end up [pretty printing them](https://github.com/rust-lang/rust/blob/770b9e3012bd58bdf6046d328dabfd57df163eb6/src/librustc_metadata/encoder.rs#L1059) and pretty printing the byte string literal for a multi-megabyte file takes quite some time! There may be a few other sources of slowdown, but ideally usage of `include_bytes!` and large byte blobs in general should never iterate over the bytes and perform expensive operations, but rather the bytes should just be transferred as a whole in various contexts if absolutely necessary.
I-compiletime,T-compiler
medium
Major
512,601,681
rust
Footgun with const declarations of type Atomic*
I just got caught by a footgun where I'd declared a global counter as: ``` const COUNTER: AtomicUsize = AtomicUsize::new(0); ``` and incremented it using `COUNTER.fetch_add(1, Ordering::SeqCst)`. It took me a while to realize why I was always getting `0`! There are checks for `const` declarations not having interior mutability to catch these footguns, but they don't apply to atomics.
C-enhancement,A-lints,T-lang,T-compiler,A-const-eval,A-atomic
low
Major
512,602,411
pytorch
[docs] Unclear input/output format for TransformerEncoderLayer
https://pytorch.org/docs/master/nn.html?highlight=transformerencoderlayer#torch.nn.TransformerEncoderLayer does not mention the input/output tensor dimension order. Is it B(atch)T(ime)C(hannels)? Existing docs for torch.nn.GRU explain this more clear. Also RNNCell uses `nonlinearity` keyword whereas Transformer* uses `activation`. If this difference is not intentional, it would be nice to unify these for consistency.
module: nn,triaged
low
Major
512,618,812
flutter
Make FutureBuilder deliver pending snapshot on entering active lifecycle state
## Use case If the future completes after the screen times out, then the screen is turned back on, I would like a build to be triggered to deliver the future upon re-entering the active lifecycle state -- i.e. to ensure that the FutureBuilder does indeed build in the future so that I can show the results of the awaited future. ## Proposal FutureBuilder already receives notification of the completed future, but can't deliver it while the screen is off. What it could perhaps do instead is treat the delivery as pending, and hook into the lifecycle state callbacks so that on re-entering the active state (or even entering the active state for the first time*), the pending delivery can be triggered with markNeedsRebuild. Yes, this can be provided by a package on pub.dev, say, ReliableFutureBuilder, but it seems wasteful to have two versions of FutureBuilder. (*) I noticed this problem occurs if I use "flutter run" to start my app while the screen is turned off. The app uses a FutureBuilder while loading. If the screen is turned on after the future completes, the FutureBuilder holds the data snapshot but does not trigger a rebuild. This scenario is not realistically going to happen in the wild, but it seems correct to handle all cases.
c: new feature,framework,P3,team-framework,triaged-framework
low
Minor
512,618,987
go
runtime: fatal error: unknown caller pc (libfuzz)
### What version of Go are you using (`go version`)? <pre> go1.13.3.linux.amd64 </pre> Compiled through [go-fuzz/libfuzz](https://github.com/klauspost/compress/blob/master/fuzzit.sh#L17) ### Does this issue reproduce with the latest release? Yes. ### What operating system and processor architecture are you using (`go env`)? <details> Fuzz test run on https://fuzzit.dev/ Linux, AMD64 is as much as I know </details> ### What did you do? I have 3 crashes crash from "fuzzit.dev" where I am running continuous fuzz testing of my compression packages. Go 1.12.10 was used for 2 builds, Go 1.13.3 for one. There is no assembly or "unsafe" involved so there shouldn't be any reasonable way for memory corruption. This fuzzing is also strictly running in a single goroutine, so races also seems unlikely. That said I have no idea about the hardware stability of the servers running the tests. Also, a lot of new code has just been added here, so there is a chance of something bad, though I don't know how I would be able to trigger this error. Crash logs: https://gist.github.com/klauspost/d4ec7bd6ecefa1bec56dd8ca4ac8ec39 Go 1.12.10 on top and bottom. Go 1.13.3 in the middle. It is completely different functions that were pre-empted (`flate.(*fastGen).matchlenLong`) vs. `flate.(*decompressor).Read` - completely different code. All crashes were in `mgcmark.go:711`. Final crash was while executing `bytes.(*Buffer).grow`. Crashes have not reproduced locally, so this could be a libfuzz specific problem. Build script is here: https://github.com/klauspost/compress/blob/master/fuzzit.sh#L17 - all crashes have been in the same fuzzer (flate), so it seems something in there is triggering it. ### What did you expect to see? No crash, or more information. ### What did you see instead? Crash.
NeedsInvestigation,compiler/runtime
low
Critical
512,619,989
rust
Attribute macro helper attributes
[The reference](https://doc.rust-lang.org/reference/procedural-macros.html) states that custom derive macros support defined helper attributes: ```rust #[proc_macro_derive(HelperAttr, attributes(helper))] pub fn derive_helper_attr(_item: TokenStream) -> TokenStream { TokenStream::new() } ``` However, the same does not appear to apply to `proc_macro_attribute`. Please extend it to do so. ```rust #[proc_macro_attribute(attributes(helper))] pub fn my_attribute(attr: TokenStream, item: TokenStream) -> TokenStream { .. } ``` Motivation is limited, but this could provide simpler specification [here](https://github.com/dhardy/kas/blob/master/src/text.rs#L15-L17). Related: #53012
A-attributes,A-macros,T-lang,C-feature-request
medium
Major
512,641,724
flutter
Make it easier (or document how) to bring your own harfbuzz/ICU
See https://github.com/flutter/flutter/issues/40220#issuecomment-546327467 for more context Some customers would like to bring their own harfbuzz/ICU. Not clear if that would also require bringing their own freetype2. My own explorations around engine modularization have been more focused on networking and Skia - I'm not as famiilar with what it would take to split out some of the text rendering stack (or whether it would actually help things binary size wise). /cc @jason-simmons @GaryQian who know a lot more about this area.
c: new feature,engine,c: performance,d: api docs,a: typography,a: existing-apps,a: size,perf: app size,P3,team-engine,triaged-engine
low
Major
512,646,466
flutter
Bottom Navigation Bar Ripple Style
Hello. Overall the material design implementation and ripples are pretty good and smooth, on some places even better than native, but for sure not so good when it comes to bottom bar navigation. The BottomNavigationItem on press ripple is just disgusting and bothers me every time I see it. It should be bigger (wider) and the ripple effect should be faster and wider too. Native Android bottom navigation ripples look way better, for example Messenger navigation. Even no ripples (like YouTube did) at all would be better than three current animation.
c: new feature,framework,f: material design,P3,workaround available,team-design,triaged-design
low
Major
512,650,147
flutter
Animated ClipRRect
Currently, AnimatedContainer is beautiful and has many use cases, however it's children do NOT clip to its boundries (like Container), which would be a suggestion in itself, but the existence of ClipRRect makes me think the decision on this is final. So as a substitute, an AnimatedClipRRect is in order to animate clipping and border clipping of the widget's children. This would be incredibly useful for many use-cases. In fact, I found myself suggesting this because I needed it as a UI idea to transform a square to a circle when a download button is pressed. I'm sadly going to have to do something different. I know it's 100% possible to already do this with extrinsic animations, and I already tried it, but it's very bulky and inconvenient to use. It's why AnimatedContainer exists in the first place. Parameters for AnimatedClipRRect should all be animatable, perhaps even a shape decoration parameter like the one in Container where you can change it's shape from a square to a circle to any other shape you make.
c: new feature,framework,a: animation,P3,team-framework,triaged-framework
low
Major
512,653,678
flutter
Using an EagerGestureDetector on web doesn't appear to properly pass scroll wheel events
Sample code: ```dart class DebuggerScreenBody extends StatelessWidget { @override Widget build(BuildContext context) { // Don't build this in const because compile time const evaluation // will fail on non-web apps. return RawGestureDetector( gestures: { EagerGestureRecognizer: _EagerGestureFactory(PointerDeviceKind.mouse), }, // ignore:prefer_const_constructors child: HtmlElementView( viewType: 'DebuggerFlutterPlugin', ), ); } } ``` Mouse scroll events don't seem to be passing properly to the child view. I have worked around this by telling the plugin code to capture `onWheel` and `onMouseWheel` events, but ideally just the eager gesture detector would be sufficient. Doctor: ``` $ flutter doctor Doctor summary (to see all details, run flutter doctor -v): [✓] Flutter (Channel master, v1.10.15-pre.222, on Linux, locale en_US.UTF-8) [✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3) [✓] Chrome - develop for the web [✓] Linux toolchain - develop for Linux desktop [✓] Android Studio (version 3.4) [✓] IntelliJ IDEA Community Edition (version 2019.2) [✓] VS Code (version 1.39.2) [✓] Connected device (4 available) ``` See https://github.com/flutter/devtools/pull/1255 for more context.
framework,f: gestures,platform-web,a: desktop,customer: webeap,a: mouse,P2,team-framework,triaged-framework
low
Critical
512,654,608
vue
Computed properties with getter/setter do not provide expected Typescript type annotation
### Version 2.6.10 ### Reproduction link [https://codesandbox.io/s/quiet-glitter-qk7fy?fontsize=14](https://codesandbox.io/s/quiet-glitter-qk7fy?fontsize=14) ### Steps to reproduce 1) Create a computed property in a single file component that is lang="ts" - call it myComputedProp 2) Add a get() and set() method for that computed prop 3) Annotate the get() method (for example get(): string) 4) Annotate the set() method (for example set(myValue: number): void ) 5) Check the inferred types of myComputedProp - it looks like it will be string | number ### What is expected? When the get() method of a computed property is annotated with a type, the computed properties type will correspond to that annotation. ### What is actually happening? When the get() method of a computed property is annotated with a type (A), and the set() methods parameter has been annotated with a type as well (B), the computed property has a type of A | B --- This may very well be a user error on our part as well, and perhaps the community or Vue team has some suggestions for how to better handle this. We provide auto generated types from an api client, so having the "or" syntax with the computed annotation in this case means we need to use a type assertion to circumvent this. Thanks a ton! Happy to provide screenshots I took as well. <!-- generated by vue-issues. DO NOT REMOVE -->
typescript
low
Critical
512,732,445
flutter
flutter test --platform chrome not generating generated_plugin_registrants.dart
``` $ flutter test --platform chrome test/ Configuring `build_web_compilers:entrypoint` in target `devtools_app:devtools_app` but this is not a known Builder Unable to find modules for some sources, this is usually the result of either a bad import, a missing dependency in a package (or possibly a dev_dependency needs to move to a real dependency), or a build failure (if importing a generated file). Please check the following imports: `import 'generated_plugin_registrant.dart';` from devtools_app|lib/main_web_entrypoint.dart at 5:1 Unable to find modules for some sources, this is usually the result of either a bad import, a missing dependency in a package (or possibly a dev_dependency needs to move to a real dependency), or a build failure (if importing a generated file). Please check the following imports: `import 'generated_plugin_registrant.dart';` from devtools_app|lib/html_main_web_entrypoint.dart at 5:1 Failed after 313ms Failed to compile tests ``` Doctor: ``` $ flutter doctor Doctor summary (to see all details, run flutter doctor -v): [✓] Flutter (Channel master, v1.10.15-pre.222, on Linux, locale en_US.UTF-8) [✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3) [✓] Chrome - develop for the web [✓] Linux toolchain - develop for Linux desktop [✓] Android Studio (version 3.4) [✓] IntelliJ IDEA Community Edition (version 2019.2) [✓] VS Code (version 1.39.2) [✓] Connected device (4 available) ```
a: tests,c: new feature,platform-web,customer: webeap,P3,a: plugins,team-web,triaged-web
low
Critical
512,739,462
go
cmd/go: 'go get' should show requirement chains for inconsistent versions
<!-- Please answer these questions before submitting your issue. Thanks! --> ### What version of Go are you using (`go version`)? <pre> $ go version go version go1.13.1 darwin/amd64 </pre> ### Does this issue reproduce with the latest release? Yes. ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env GO111MODULE="" GOARCH="amd64" GOBIN="" GOCACHE="/Users/deklerk/Library/Caches/go-build" GOENV="/Users/deklerk/Library/Application Support/go/env" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="darwin" GONOPROXY="" GONOSUMDB="" GOOS="darwin" GOPATH="/Users/deklerk/go" GOPRIVATE="" GOPROXY="https://proxy.golang.org,direct" GOROOT="/usr/local/go" GOSUMDB="sum.golang.org" GOTMPDIR="" GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64" GCCGO="gccgo" AR="ar" CC="clang" CXX="clang++" CGO_ENABLED="1" GOMOD="/tmp/foo/go.mod" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/c2/cvxltzcd66v5lx14hm1j76q000h16k/T/go-build418507423=/tmp/go-build -gno-record-gcc-switches -fno-common" </pre></details> ### What did you do? ``` $ go get cloud.google.com/go/pubsub@v1.0.1-beta.ordered.keys go: finding cloud.google.com v1.0.1-beta.ordered.keys go: finding cloud.google.com/go v1.0.1-beta.ordered.keys go get: inconsistent versions: cloud.google.com/go/pubsub@v1.0.1-beta.ordered.keys requires cloud.google.com/go/pubsub@v1.0.1 (not cloud.google.com/go/pubsub@v1.0.1-beta.ordered.keys) $ ``` ### What did you expect to see? It works. ### What did you see instead? It does not work. I assume it's because there's a path from v1.0.1-beta to v1.0.1 (see below), but not sure why that's a problem. ``` deklerk at deklerk-macbookpro2 in ~/workspace/google-cloud-go/pubsub on pubsub-ordered-keys $ go mod graph | grep pubsub cloud.google.com/go/pubsub cloud.google.com/go@v0.46.3 cloud.google.com/go/pubsub cloud.google.com/go/storage@v1.0.0 cloud.google.com/go/pubsub github.com/golang/protobuf@v1.3.2 cloud.google.com/go/pubsub github.com/google/go-cmp@v0.3.0 cloud.google.com/go/pubsub github.com/googleapis/gax-go/v2@v2.0.5 cloud.google.com/go/pubsub go.opencensus.io@v0.22.0 cloud.google.com/go/pubsub golang.org/x/exp@v0.0.0-20190912063710-ac5d2bfcbfe0 cloud.google.com/go/pubsub golang.org/x/oauth2@v0.0.0-20190604053449-0f29369cfe45 cloud.google.com/go/pubsub golang.org/x/sync@v0.0.0-20190423024810-112230192c58 cloud.google.com/go/pubsub golang.org/x/time@v0.0.0-20190308202827-9d24e82272b4 cloud.google.com/go/pubsub golang.org/x/tools@v0.0.0-20190917162342-3b4f30a44f3b cloud.google.com/go/pubsub google.golang.org/api@v0.9.0 cloud.google.com/go/pubsub google.golang.org/genproto@v0.0.0-20190911173649-1774047e7e51 cloud.google.com/go/pubsub google.golang.org/grpc@v1.21.1 cloud.google.com/go/pubsub@v1.0.1 cloud.google.com/go@v0.45.1 cloud.google.com/go/pubsub@v1.0.1 google.golang.org/grpc@v1.21.1 cloud.google.com/go/pubsub@v1.0.1 google.golang.org/genproto@v0.0.0-20190819201941-24fa4b261c55 cloud.google.com/go/pubsub@v1.0.1 google.golang.org/api@v0.9.0 cloud.google.com/go/pubsub@v1.0.1 golang.org/x/time@v0.0.0-20190308202827-9d24e82272b4 cloud.google.com/go/pubsub@v1.0.1 golang.org/x/sync@v0.0.0-20190423024810-112230192c58 cloud.google.com/go/pubsub@v1.0.1 golang.org/x/oauth2@v0.0.0-20190604053449-0f29369cfe45 cloud.google.com/go/pubsub@v1.0.1 go.opencensus.io@v0.22.0 cloud.google.com/go/pubsub@v1.0.1 github.com/googleapis/gax-go/v2@v2.0.5 cloud.google.com/go/pubsub@v1.0.1 github.com/google/go-cmp@v0.3.0 cloud.google.com/go/pubsub@v1.0.1 github.com/golang/protobuf@v1.3.2 cloud.google.com/go@v0.46.3 cloud.google.com/go/pubsub@v1.0.1 ```
NeedsFix,GoCommand,modules
low
Critical
512,745,927
opencv
Calibrate camera without moving external parameters
It is then possible to add a flag to do not move the external parameter during the optimisation in the calibrate camera function? thanks
feature,category: calib3d
low
Major
512,755,470
rust
Tracking issue for future-incompatibility lint `unused_attributes`
> [!IMPORTANT] > This description needs to be fleshed out! Related pull request: https://github.com/rust-lang/rust/pull/65294#issuecomment-545418714.
A-attributes,A-lints,T-compiler,C-future-incompatibility,C-tracking-issue
low
Minor
512,756,244
pytorch
[docs] Improve docs of nn.MultiheadAttention
https://pytorch.org/docs/master/nn.html?highlight=multiheadattention#torch.nn.MultiheadAttention currently looks like this: - **Note** – if kdim and vdim are None, they will be set to embed_dim such that - **key, and value have the same number of features.** (*query,*) – i.e. formatting went badly. Also docs don't mention that `embed_dim` must be divisible by `nheads` and what's the reason for this requirement (it seems that the module assumes that the projection of the all heads is done prior to this module)
module: docs,triaged
low
Minor
512,758,604
flutter
Create plugin for loading Android assets
Create a plugin specifically for loading Android assets in Flutter. This plugin should include at least a Dart API that reflects Android's `AssetManager`. If desired, it can also include higher level tools, too, such as an `ImageProvider` that works with the Dart version of `AssetManager`.
platform-android,package,c: proposal,P3,team-android,triaged-android
low
Minor
512,759,955
rust
Removing bound from generic type causes an "overflow evaluating a requirement" error.
With the following code: ```rust pub trait Frogg<W: ?Sized> { fn frogg(&self, _with: &W){} } impl <T, W> Frogg<[W]> for T where T: Frogg<W> {} impl <T, W> Frogg<[W]> for [T] where T: Frogg<W> {} fn bar<T, W>(slice: &[T], other: &[W]) where T:Frogg<W> { slice.frogg(other) } ``` If I remove the where clause for `bar`,it prints this error: ``` error[E0275]: overflow evaluating the requirement `_: std::marker::Sized` --> src/lib.rs:16:11 | 16 | slice.frogg(other) | ^^^^^ | = help: consider adding a `#![recursion_limit="256"]` attribute to your crate = note: required because of the requirements on the impl of `Frogg<[_]>` for `T` = note: required because of the requirements on the impl of `Frogg<[[_]]>` for `T` = note: required because of the requirements on the impl of `Frogg<[[[_]]]>` for `T` = note: required because of the requirements on the impl of `Frogg<[[[[_]]]]>` for `T` = note: required because of the requirements on the impl of `Frogg<[[[[[_]]]]]>` for `T` = note: required because of the requirements on the impl of `Frogg<[[[[[[_]]]]]]>` for `T` = note: required because of the requirements on the impl of `Frogg<[[[[[[[_]]]]]]]>` for `T` = note: required because of the requirements on the impl of `Frogg<[[[[[[[[_]]]]]]]]>` for `T` = note: required because of the requirements on the impl of `Frogg<[[[[[[[[[_]]]]]]]]]>` for `T` = note: required because of the requirements on the impl of `Frogg<[[[[[[[[[[_]]]]]]]]]]>` for `T` = note: required because of the requirements on the impl of `Frogg<[[[[[[[[[[[_]]]]]]]]]]]>` for `T` = note: required because of the requirements on the impl of `Frogg<[[[[[[[[[[[[_]]]]]]]]]]]]>` for `T` = note: required because of the requirements on the impl of `Frogg<[[[[[[[[[[[[[_]]]]]]]]]]]]]>` for `T` [Ommited identical errors for length] error: aborting due to previous error ``` I expected to get an error mentioning how `slice` does not implement the `Frogg` trait instead.
A-trait-system,T-compiler,C-bug
low
Critical
512,773,504
pytorch
CPU MaxPool2d is very slow
## 🐛 Bug MaxPool2d is too slow, it is better to replace it with Conv2d and strides ## To Reproduce ```python import torch import time import torch.nn as nn model = nn.Conv2d(in_channels=16, out_channels=16, kernel_size=3, stride=2) net = nn.MaxPool2d(kernel_size=3, stride=2) blob = torch.randn(1, 16, 3000, 2000, device='cpu') t0 = time.time() with torch.no_grad(): outputs = model(blob) print("PyTorch Conv: {}".format(time.time() - t0)) t0 = time.time() with torch.no_grad(): pred = net(blob) print("PyTorch MaxPool: {}".format(time.time() - t0)) # compare with ONNX import onnxruntime as rt targets = ['result'] onnxfile = "/mnt/output/gr/conv.onnx" torch.onnx.export(model, blob, onnxfile, input_names=['data'], output_names=targets) onnxfile2 = "/mnt/output/gr/max.onnx" torch.onnx.export(net, blob, onnxfile2, input_names=['data'], output_names=targets) sess = rt.InferenceSession(onnxfile) t0 = time.time() outputs_ort = sess.run(targets, { 'data': blob.numpy() }) print("ONNX Conv: {}".format(time.time() - t0)) sess = rt.InferenceSession(onnxfile2) t0 = time.time() pred_ort = sess.run(targets, { 'data': blob.numpy() }) print("ONNX MaxPool: {}".format(time.time() - t0)) ``` > PyTorch Conv: 0.1909499168395996 > PyTorch MaxPool: 0.8006699085235596 > ONNX Conv: 0.3233060836791992 > ONNX MaxPool: 0.26441049575805664 ## Expected behavior For MaxPool2d to have performance that is within the same range as convolution ## Environment PyTorch version: 1.3.0 Is debug build: No CUDA used to build PyTorch: 10.1.243 OS: Ubuntu 16.04.6 LTS GCC version: (Ubuntu 5.4.0-6ubuntu1~16.04.11) 5.4.0 20160609 CMake version: version 3.14.0 Python version: 3.6 Is CUDA available: Yes CUDA runtime version: Could not collect GPU models and configuration: GPU 0: GeForce GTX 1070 Nvidia driver version: 418.40.04 cuDNN version: /usr/local/lib/libcudnn.so.5.1.10 Versions of relevant libraries: [pip] numpy==1.17.2 [pip] torch==1.3.0 [pip] torchvision==0.4.1a0+d94043a [conda] Could not collect cc @VitalyFedyunin @ngimel @mruberry
module: performance,module: bootcamp,module: cpu,triaged,module: pooling
low
Critical
512,775,927
TypeScript
Cannot find type definition file for ambient declaration module
<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨 Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section! Please help us by doing the following steps before logging an issue: * Search: https://github.com/Microsoft/TypeScript/search?type=Issues * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ Please fill in the *entire* template below. --> <!-- Please try to reproduce the issue with the latest published version. It may have already been fixed. For npm: `typescript@next` This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly --> **TypeScript Version:** 3.6 to 3.8.0-dev.20191025 <!-- Search terms you tried before logging this (so others can find this issue more easily) --> **Search Terms:** ambient module triple slash reference path declaration **Code** ```ts // A *self-contained* demonstration of the problem follows... [typings/somemodule/index.d.ts] declare module "somemodule" { export namespace common { export interface Foo { bar: string; fuzz: Number; } } } [src/index.ts] /// <reference path="../typings/somemodule/index.d.ts" /> ``` Typescript 3.5.3 works as expected, anything at or above 3.6 has the same issue.. When running tsc -d, for a manually created declaration file, the triple slash reference path file should be preserved in the output declaration file. This particular declaration file acts as a shim for an existing library whose type definitions are incomplete and is to be included as-is and without transpiler manipulation in the output declaration file. This provides accurate intellisense for package consumers and ensures build errors do not occur. **Expected behavior:** Maintain the same triple-slash reference path in the .d.ts file as was in the .ts file. ``` [dist/index.d.ts] /// <reference path="../typings/somemodule/index.d.ts" /> ``` **Actual behavior:** The reference path is changed to reference types and the relative path is also broken: ``` [dist/index.d.ts] /// <reference types="typings/somemodule" /> ``` This causes consuming applications of the package to receive the following build error: `Cannot find type definition file for 'typings/somemodule'.` I have been unsuccessful in manipulating the consuming application to build correctly or provide correct intellisense with the updated directive. The original directive must be preserved. **Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior --> **Related Issues:** I believe this is where the issue was introduced: #32878
Needs Investigation
low
Critical
512,784,957
PowerToys
[FancyZones] Change "Tab Index" of zones
# Summary of the new feature/enhancement as a user I would like to redefine index of each fancy zone so that they can set the order in which they switch using windows + left and right arrow hotkey. # Proposed technical implementation details (optional) Add a combo-box to CanvasZone.xaml that contains an enumeration of the current index length. OnChange execute a swapIndex() method in the CanvasLayoutModel. swapIndex() will trade positions of each zone in the Zones Array portion of the CanvasLayoutModel.
Idea-Enhancement,FancyZones-Editor,Product-FancyZones
low
Minor
512,798,729
vscode
Web: desktop-reserved keybindings non functional in fullscreen Firefox
Maybe we cannot get this to work, but: when I use Firefox and go fullscreen, hitting a key such as `Cmd+W` to close an editor is still closing the entire window. That makes it almost impossible to use VSCode in Firefox. To make matters worse: simply pressing `Esc`-key gets out of fullscreen instantly....
feature-request,upstream,web,upstream-issue-linked,firefox
low
Major
512,804,330
youtube-dl
I'm request kktv.me for supported sites
<!-- ###################################################################### WARNING! IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE ###################################################################### --> ## Checklist <!-- Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl: - First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2019.10.22. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED. - Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser. - Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights. - Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates. - Finally, put x into all relevant boxes (like this [x]) --> - [x] I'm reporting a new site support request - [x] I've verified that I'm running youtube-dl version **2019.10.22** - [x] I've checked that all provided URLs are alive and playable in a browser - [ ] I've checked that none of provided URLs violate any copyrights - [x] I've searched the bugtracker for similar site support requests including closed ones ## Example URLs <!-- Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours. --> https://www.kktv.me/play/01000337010001 ## Description <!-- Provide any additional information. If work on your issue requires account credentials please provide them or explain how one can obtain them. --> Just an info, need vpn through Taiwan to watch
site-support-request
low
Critical
512,811,732
rust
Extend rustdoc search
### First idea It'd be nice to write stuff like: `"avec"::Vec` or even `vec::`. In the first example, you look specifically into the "avec" module/type and look for "Vec" inside it. In the second example, you just look at everything inside the matching "vec" parent (so that maybe return a lot of things with a bad order). Of course, both features could be used at the same time like: `hello::"avec"::`. ### Second idea Another idea that came out was to be able to look at functions based on their arguments. ### Third idea Having reverse search: instead of looking for something, you'd look for anything that isn't this thing. However, it wouldn't be on the text search itself but on the items filtering. For example: "!struct:Vec". cc @rust-lang/rustdoc
T-rustdoc,A-type-based-search
low
Minor
512,813,323
pytorch
torch.as_tensor fails to create named tensors
## 🐛 Bug torch.as_tensor() fails to create named tensors ## To Reproduce 1. try to create a tensor from numpy ndarray using torch.as_tensor() image = cv2.imread(imgPath) image = cv2.cvtColor(image, cv2.COLOR_BGR2RGB) image = torch.as_tensor(image, dtype=torch.uint8, names=('H', 'W', 'C')).align_to('C', 'H', 'W') E TypeError: as_tensor() got an unexpected keyword argument 'names' ## Expected behavior torch.as_tensor() create a named tensor just like torch.tensor() ## Environment PyTorch version: 1.3.0 Is debug build: No CUDA used to build PyTorch: 10.1.243 OS: Ubuntu 16.04.6 LTS GCC version: (Ubuntu 5.4.0-6ubuntu1~16.04.11) 5.4.0 20160609 CMake version: Could not collect Python version: 3.6 Is CUDA available: Yes CUDA runtime version: 10.1.243 GPU models and configuration: GPU 0: GeForce GTX 1080 Ti Nvidia driver version: 418.87.01 cuDNN version: /usr/lib/x86_64-linux-gnu/libcudnn.so.7.4.1 Versions of relevant libraries: [pip3] numpy==1.17.3 [pip3] torch==1.3.0 [pip3] torchvision==0.4.1 [conda] Could not collect cc @zou3519
triaged,module: named tensor,module: tensor creation
low
Critical
512,823,979
flutter
[video_player] [Android] texture not updated while scrubbing when video is paused
Unlike on iOS, this never worked on Android. To reproduce: 1. run app 2. press pause 3. scrub on the progress bar Expected behaviour would be that it updates the texture while scrubbing. Current behaviour on Android is that the texture is not updated until you lift your finger. Tested with: ```dart import 'package:flutter/cupertino.dart'; import 'package:flutter/material.dart'; import 'package:video_player/video_player.dart'; /// Controls play and pause of [controller]. /// /// Toggles play/pause on tap (accompanied by a fading status icon). /// /// Plays (looping) on initialization, and mutes on deactivation. class VideoPlayPause extends StatefulWidget { VideoPlayPause(this.controller); final VideoPlayerController controller; @override State createState() { return _VideoPlayPauseState(); } } class _VideoPlayPauseState extends State<VideoPlayPause> { _VideoPlayPauseState() { listener = () { setState(() {}); }; } FadeAnimation imageFadeAnim = FadeAnimation(child: const Icon(Icons.play_arrow, size: 100.0)); VoidCallback listener; VideoPlayerController get controller => widget.controller; @override void initState() { super.initState(); controller.addListener(listener); controller.setVolume(1.0); controller.play(); } @override void deactivate() { controller.setVolume(0.0); controller.removeListener(listener); super.deactivate(); } @override Widget build(BuildContext context) { final List<Widget> children = <Widget>[ GestureDetector( child: VideoPlayer(controller), onTap: () { if (!controller.value.initialized) { return; } if (controller.value.isPlaying) { imageFadeAnim = FadeAnimation(child: const Icon(Icons.pause, size: 100.0)); controller.pause(); } else { imageFadeAnim = FadeAnimation(child: const Icon(Icons.play_arrow, size: 100.0)); controller.play(); } }, ), Align( alignment: Alignment.bottomCenter, child: VideoProgressIndicator( controller, allowScrubbing: true, padding: const EdgeInsets.symmetric(vertical: 48), ), ), Center(child: imageFadeAnim), Center( child: controller.value.isBuffering ? const CircularProgressIndicator() : null), ]; return Stack( fit: StackFit.passthrough, children: children, ); } } class FadeAnimation extends StatefulWidget { FadeAnimation( {this.child, this.duration = const Duration(milliseconds: 500)}); final Widget child; final Duration duration; @override _FadeAnimationState createState() => _FadeAnimationState(); } class _FadeAnimationState extends State<FadeAnimation> with SingleTickerProviderStateMixin { AnimationController animationController; @override void initState() { super.initState(); animationController = AnimationController(duration: widget.duration, vsync: this); animationController.addListener(() { if (mounted) { setState(() {}); } }); animationController.forward(from: 0.0); } @override void deactivate() { animationController.stop(); super.deactivate(); } @override void didUpdateWidget(FadeAnimation oldWidget) { super.didUpdateWidget(oldWidget); if (oldWidget.child != widget.child) { animationController.forward(from: 0.0); } } @override void dispose() { animationController.dispose(); super.dispose(); } @override Widget build(BuildContext context) { return animationController.isAnimating ? Opacity( opacity: 1.0 - animationController.value, child: widget.child, ) : Container(); } } typedef Widget VideoWidgetBuilder( BuildContext context, VideoPlayerController controller); abstract class PlayerLifeCycle extends StatefulWidget { PlayerLifeCycle(this.dataSource, this.childBuilder); final VideoWidgetBuilder childBuilder; final String dataSource; } /// A widget connecting its life cycle to a [VideoPlayerController] using /// a data source from the network. class NetworkPlayerLifeCycle extends PlayerLifeCycle { NetworkPlayerLifeCycle(String dataSource, VideoWidgetBuilder childBuilder) : super(dataSource, childBuilder); @override _NetworkPlayerLifeCycleState createState() => _NetworkPlayerLifeCycleState(); } /// A widget connecting its life cycle to a [VideoPlayerController] using /// an asset as data source class AssetPlayerLifeCycle extends PlayerLifeCycle { AssetPlayerLifeCycle(String dataSource, VideoWidgetBuilder childBuilder) : super(dataSource, childBuilder); @override _AssetPlayerLifeCycleState createState() => _AssetPlayerLifeCycleState(); } abstract class _PlayerLifeCycleState extends State<PlayerLifeCycle> { VideoPlayerController controller; @override /// Subclasses should implement [createVideoPlayerController], which is used /// by this method. void initState() { super.initState(); controller = createVideoPlayerController(); controller.addListener(() { if (controller.value.hasError) { print(controller.value.errorDescription); } }); controller.initialize(); controller.setLooping(true); controller.play(); } @override void deactivate() { super.deactivate(); } @override void dispose() { controller.dispose(); super.dispose(); } @override Widget build(BuildContext context) { return widget.childBuilder(context, controller); } VideoPlayerController createVideoPlayerController(); } class _NetworkPlayerLifeCycleState extends _PlayerLifeCycleState { @override VideoPlayerController createVideoPlayerController() { return VideoPlayerController.network(widget.dataSource); } } class _AssetPlayerLifeCycleState extends _PlayerLifeCycleState { @override VideoPlayerController createVideoPlayerController() { return VideoPlayerController.asset(widget.dataSource); } } class AspectRatioVideo extends StatefulWidget { AspectRatioVideo(this.controller); final VideoPlayerController controller; @override AspectRatioVideoState createState() => AspectRatioVideoState(); } class AspectRatioVideoState extends State<AspectRatioVideo> { VideoPlayerController get controller => widget.controller; bool initialized = false; VoidCallback listener; @override void initState() { super.initState(); listener = () { if (!mounted) { return; } if (initialized != controller.value.initialized) { initialized = controller.value.initialized; setState(() {}); } }; controller.addListener(listener); } @override Widget build(BuildContext context) { if (initialized) { return Center( child: AspectRatio( aspectRatio: controller.value.aspectRatio, child: VideoPlayPause(controller), ), ); } else { return Container(); } } } void main() { runApp( MaterialApp( home: Scaffold( appBar: AppBar( title: const Text('Video player example'), ), body: NetworkPlayerLifeCycle( 'https://flutter.github.io/assets-for-api-docs/assets/videos/bee.mp4', (BuildContext context, VideoPlayerController controller) => AspectRatioVideo(controller)), ), ), ); } ``` ``` [✓] Flutter (Channel beta, v1.10.7, on Mac OS X 10.15 19A582a, locale en-CH) • Flutter version 1.10.7 at /Users/ben/flutter • Framework revision e70236e36c (3 weeks ago), 2019-10-02 09:32:30 -0700 • Engine revision 9e6314d348 • Dart version 2.6.0 (build 2.6.0-dev.0.0 1103600280) [✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3) • Android SDK at /Users/ben/Library/Android/sdk • Android NDK location not configured (optional; useful for native profiling support) • Platform android-29, build-tools 28.0.3 • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405) • All Android licenses accepted. [✓] Xcode - develop for iOS and macOS (Xcode 11.1) • Xcode at /Applications/Xcode.app/Contents/Developer • Xcode 11.1, Build version 11A1027 • CocoaPods version 1.8.3 [✓] Android Studio (version 3.5) • Android Studio at /Applications/Android Studio.app/Contents • Flutter plugin version 40.2.2 • Dart plugin version 191.8593 • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405) [✓] VS Code (version 1.31.1) • VS Code at /Applications/Visual Studio Code.app/Contents • Flutter extension version 2.24.0 [✓] Connected device (1 available) • iPhone 11 Pro • 4318F8E4-22E5-4399-8A78-D755729F59DB • ios • com.apple.CoreSimulator.SimRuntime.iOS-13-1 (simulator) • No issues found! ```
platform-android,p: video_player,package,has reproducible steps,P2,found in release: 2.2,team-android,triaged-android
low
Critical
512,826,855
rust
"LLVM ERROR: Access past stack top!" when compiling without sse2
the following code produces the compilation error `LLVM ERROR: Access past stack top!` when compiling with `E:RUSTFLAGS="-Ctarget-feature=-sse2" cargo +nightly run` ``` fn main() { let (a, b) = get_pair(); } fn get_pair() -> (f64, f64) { (0.0, 0.0) } ``` only happens when the return values of `get_pair` are named. also when compiling an example to a library crate like this: `E:RUSTFLAGS="-Ctarget-feature=-sse2" cargo +nightly run --example bug` i get the following error instead: ``` process didn't exit successfully: `rustc --edition=2018 --crate-name bug examples/bug.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type bin --emit=dep-info,link -C debuginfo=2 -C metadata=6421b7fc9708c373 -C extra-filename=-6421b7fc9708c373 --out-dir /home/user/Documents/bug_lib/target/debug/examples -C incremental=/home/user/Documents/bug_lib/target/debug/incremental -L dependency=/home/user/Documents/bug_lib/target/debug/deps --extern bug_lib=/home/user/Documents/bug_lib/target/debug/deps/libbug_lib-f0c2fba934c178d2.rlib -Ctarget-feature=-sse2` (signal: 11, SIGSEGV: invalid memory reference) ``` rustc version: ``` rustc 1.40.0-nightly (246be7e1a 2019-10-25) binary: rustc commit-hash: 246be7e1a557b8ac8287c6842379a0db67770be6 commit-date: 2019-10-25 host: x86_64-unknown-linux-gnu release: 1.40.0-nightly LLVM version: 9.0 ```
I-crash,A-LLVM,O-x86_64,P-medium,T-compiler,C-bug,ICEBreaker-LLVM,A-target-feature
medium
Critical
512,830,736
godot
Generic6DOFJoint is behaving in a weird manner when rotating around the Y axis (it's working properly for the Z axis)
**Godot version:** 3.1.1 **OS/device including version:** Ubuntu 19.10 **Issue description:** I have joined two rigid bodies (two basic capsules) together with a Generic6DOFJoint, disabled the Angular Limit Y, enabled the Angular Motor Y. The capsules started rotating, but after doing so for about 90° they snap back approx. 15° and jump around a bit. Repeating the same procedure with the Z axis yields two properly rotating capsules without jumping and snapping. **Steps to reproduce:** Create two rigid bodies, join them with a Generic6DOFJoint, disable the Angular Limit Y, enable the Angular Motor Y, set Target Velocity to 1, observe the weirdness. **Minimal reproduction project:** [joints.zip](https://github.com/godotengine/godot/files/3774813/joints.zip)
bug,confirmed,topic:physics
low
Minor
512,831,921
pytorch
Sampler for IterableDataset
## 🚀 Feature The IterableDataset is too restrictive by not allowing the combination with samplers. Sampling from a stream is well understood and possible on the fly. IterableDataset should support these use cases. ## Motivation The IterableDataset abstraction is great for abstracting a stream of data we want to iterate over in a forward fashion. Right now it is not compatible with samplers, though. From the docs: > Neither sampler nor batch_sampler is compatible with iterable-style datasets, since such datasets have no notion of a key or an index. Here are two different use-cases where sampling from an IterableDataset is necessary: 1. The user knows the total size in advance For example I have one IterableDataset per video (yielding clips), and I know the number of frames for each video and the total number of videos in advance. I can sample `k` random clips with ``` pick = set(random.sample(range(self.total), k)) mask = [i in pick for i in range(self.total)] it = itertools.chain(*self.videos) it = itertools.compress(it, mask) ``` and abstract over this in an IterableDataset to only walk once through all videos. 2. The user does not know the total size in advance For example I have videos with clips but I don't want / can get the number of frames per video and therefore don't know the total size in advance. I can still sample `k` random clips out of an unknown `n` total clips e.g. via [reservoir sampling](https://en.wikipedia.org/wiki/Reservoir_sampling) and only walk once through all videos. What are your thoughts on this? cc @SsnL
module: dataloader,triaged
medium
Major
512,844,267
pytorch
Problem when installing Pytorch from source on CentOS 7.4
## 🐛 Bug [3171/3442] Building CXX object caffe2/torch/CMakeFiles/torch_python.dir/csrc/jit/init.cpp.o In file included from ../c10/core/Device.h:5:0, from ../c10/core/Allocator.h:6, from ../aten/src/ATen/ATen.h:3, from ../torch/csrc/utils/pybind.h:5, from ../torch/csrc/jit/init.cpp:2: ../torch/csrc/jit/pybind_utils.h: In function ‘torch::jit::Stack torch::jit::toTraceableStack(const pybind11::tuple&)’: ../c10/util/Exception.h:350:20: warning: ‘void c10::detail::deprecated_AT_CHECK()’ is deprecated [-Wdeprecated-declarations] ::c10::detail::deprecated_AT_CHECK(); \ ^ ../torch/csrc/jit/pybind_utils.h:299:3: note: in expansion of macro ‘AT_CHECK’ AT_CHECK( ^ In file included from ../c10/core/Device.h:5:0, from ../c10/core/Allocator.h:6, from ../aten/src/ATen/ATen.h:3, from ../torch/csrc/utils/pybind.h:5, from ../torch/csrc/jit/init.cpp:2: ../c10/util/Exception.h:325:13: note: declared here inline void deprecated_AT_CHECK() {} ^~~~~~~~~~~~~~~~~~~ In file included from ../c10/core/Device.h:5:0, from ../c10/core/Allocator.h:6, from ../aten/src/ATen/ATen.h:3, from ../torch/csrc/utils/pybind.h:5, from ../torch/csrc/jit/init.cpp:2: ../c10/util/Exception.h:350:40: warning: ‘void c10::detail::deprecated_AT_CHECK()’ is deprecated [-Wdeprecated-declarations] ::c10::detail::deprecated_AT_CHECK(); \ ^ ../torch/csrc/jit/pybind_utils.h:299:3: note: in expansion of macro ‘AT_CHECK’ AT_CHECK( ^ In file included from ../c10/core/Device.h:5:0, from ../c10/core/Allocator.h:6, from ../aten/src/ATen/ATen.h:3, from ../torch/csrc/utils/pybind.h:5, from ../torch/csrc/jit/init.cpp:2: ../c10/util/Exception.h:325:13: note: declared here inline void deprecated_AT_CHECK() {} ^~~~~~~~~~~~~~~~~~~ ninja: build stopped: subcommand failed. Building wheel torch-1.4.0a0+e96ea28 -- Building version 1.4.0a0+e96ea28 cmake -GNinja -DBUILD_PYTHON=True -DBUILD_TEST=True -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/data/stars/user/jhou/collection-stars/pytorch/torch -DCMAKE_PREFIX_PATH=/data/stars/user/jhou/collection-stars/anaconda3/condabin/../ -DCUDNN_INCLUDE_DIR=/misc/opt/cudnn/7.4-cuda-10.0/include -DCUDNN_LIBRARY=/misc/opt/cudnn/7.4-cuda-10.0/lib64/libcudnn.so -DNUMPY_INCLUDE_DIR=/data/stars/user/jhou/collection-stars/anaconda3/envs/pytorch_source/lib/python3.6/site-packages/numpy/core/include -DPYTHON_EXECUTABLE=/data/stars/user/jhou/collection-stars/anaconda3/envs/pytorch_source/bin/python -DPYTHON_INCLUDE_DIR=/data/stars/user/jhou/collection-stars/anaconda3/envs/pytorch_source/include/python3.6m -DPYTHON_LIBRARY=/data/stars/user/jhou/collection-stars/anaconda3/envs/pytorch_source/lib/libpython3.6m.so.1.0 -DTORCH_BUILD_VERSION=1.4.0a0+e96ea28 -DUSE_CUDA=True -DUSE_NUMPY=True /data/stars/user/jhou/collection-stars/pytorch cmake --build . --target install --config Release -- -j 32 Traceback (most recent call last): File "setup.py", line 751, in <module> build_deps() File "setup.py", line 310, in build_deps cmake=cmake) File "/data/stars/user/jhou/collection-stars/pytorch/tools/build_pytorch_libs.py", line 59, in build_caffe2 cmake.build(my_env) File "/data/stars/user/jhou/collection-stars/pytorch/tools/setup_helpers/cmake.py", line 334, in build self.run(build_args, my_env) File "/data/stars/user/jhou/collection-stars/pytorch/tools/setup_helpers/cmake.py", line 142, in run check_call(command, cwd=self.build_dir, env=env) File "/data/stars/user/jhou/collection-stars/anaconda3/envs/pytorch_source/lib/python3.6/subprocess.py", line 311, in check_call raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['cmake', '--build', '.', '--target', 'install', '--config', 'Release', '--', '-j', '32']' returned non-zero exit status 1. Full output log is here: https://drive.google.com/open?id=1oTNShMAE3QathF1B4seuBKIeFTDzx-d3 Thanks! ## To Reproduce Steps to reproduce the behavior: 1. conda create -n pytorch_source python=3.6 2. conda activate pytorch_source 3. conda install numpy ninja pyyaml mkl mkl-include setuptools cmake cffi typing 4. conda install -c pytorch magma-cuda100 5. git clone --recursive https://github.com/pytorch/pytorch 6. cd pytorch 7. export CMAKE_PREFIX_PATH="$(dirname $(which conda))/../" 8. python setup.py install <!-- If you have a code sample, error messages, stack traces, please provide it here as well --> ## Expected behavior ## Environment Collecting environment information... PyTorch version: N/A Is debug build: N/A CUDA used to build PyTorch: N/A OS: CentOS Linux release 7.4.1708 (Core) GCC version: (GCC) 7.3.0 CMake version: version 3.14.0 Python version: 3.6 Is CUDA available: N/A CUDA runtime version: 10.0.130 GPU models and configuration: GPU 0: GeForce GTX 1080 Ti Nvidia driver version: 410.79 cuDNN version: /misc/opt-7.4/cudnn/7.4-cuda-10.0/lib64/libcudnn.so.7.4.2 Versions of relevant libraries: [pip] numpy==1.17.2 [conda] blas 1.0 mkl [conda] magma-cuda100 2.5.1 1 pytorch [conda] mkl 2019.4 243 [conda] mkl-include 2019.4 243 [conda] mkl-service 2.3.0 py36he904b0f_0 [conda] mkl_fft 1.0.14 py36ha843d7b_0 [conda] mkl_random 1.1.0 py36hd6b4f25_0
module: build,triaged
low
Critical
512,845,890
pytorch
super().__init__() not called in torch.nn.Module.__init__
## 🐛 Bug `torch.nn.Module.__init__` doesn't call the `super().__init__()` , which will case troubles in multiple inheritance. ## To Reproduce For example, ```bash import torch class MyBase(object): def __init__(self): super().__init__() print('Base initialized!') class A(torch.nn.Module, MyBase): def __init__(self): super().__init__() print('A initialized!') class B(torch.nn.Module, MyBase): def __init__(self): super().__init__() print('B initialized!') class C(A, B): def __init__(self): super().__init__() print('C initialized!') c = C() ``` will only print ``` B initialized! A initialized! C initialized! ``` while `MyBase.__init__` is NOT called. ## Expected behavior print ``` Base initialized! B initialized! A initialized! C initialized! ``` ## Environment PyTorch 1.3.0 ## Additional context [Deep Thoughts by Raymond Hettinger](https://rhettinger.wordpress.com/2011/05/26/super-considered-super/) [super()](https://docs.python.org/3/library/functions.html#super)
module: nn,triaged
low
Critical
512,871,579
flutter
CupertinoTabView is not hot reload friendly
Hot reload won't apply changes made to the `builder` of a CupertinoTabView. A hot restart is required to see the effect of those changes. This was hit by participants in a UX study and no one had any clue about why hot reload stopped working. The code below can reproduce the issue: ```dart import 'package:flutter/cupertino.dart'; import 'package:flutter/material.dart'; void main() => runApp(MyApp()); class MyApp extends StatelessWidget { Widget build(BuildContext context) { return CupertinoApp( home: HomeScreen(), ); } } class HomeScreen extends StatelessWidget { @override Widget build(BuildContext context) { return CupertinoTabScaffold( tabBar: CupertinoTabBar(items: [ BottomNavigationBarItem( icon: Icon(CupertinoIcons.home), title: Text('Home'), ), BottomNavigationBarItem( icon: Icon(CupertinoIcons.settings), title: Text('Settings'), ), ]), tabBuilder: (context, index) { if (index == 0) { return Center( child: Text("Home Screen", style: Theme.of(context).textTheme.display1), ); } else { return CupertinoTabView( builder: (context) { return Center( // Changing the text style of the Text widget below requires a // hot restart to see its effect. child: Text("Settings Screen", style: Theme.of(context).textTheme.display1), ); }, ); } }, ); } } ``` Cc: @jacob314 @Hixie
framework,t: hot reload,from: study,f: cupertino,has reproducible steps,P2,found in release: 3.3,workaround available,found in release: 3.7,team-design,triaged-design
low
Major
512,878,733
flutter
[webview_flutter] evaluateJavascript encodes return value inconsistently across Android vs iOS
Internal: b/143189643 On Android, the result of evaluateJavascript is JSON encoded, with surrounding quotes for strings. On iOS, the result is a string literal (with no surrounding quotes). This means in dart, the result of evaluateJavascript must be parsed differently between iOS and Android.
p: webview,package,customer: quill (g3),team-ecosystem,P2,p: requires breaking change,triaged-ecosystem
low
Minor
512,889,104
rust
Suggestion: provide better report of function argument mismatch
While discussing #64915 with @estebank, I asked if it would make sense to also provide a more detailed report about how closures mismatched. For example, introspecting on the types to detect when types are in the wrong order, or when arguments are mismatched. He pointed out that we don't even do that for regular function calls right now. For example: https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=8288d94517c964071278be6833560f70 The above snippet could, in theory, provide a more detailed report which suggested that the arguments might be swapped in the first call, or that the second argument is missing in the second call. (Things like longest common subsequence could help here). @estebank said he's been thinking about something like this for a while, and offered to provide some mentorship if I wanted to tackle this as a slightly bigger contribution, since it'd be easier than closure comparison off the bat. <!-- TRIAGEBOT_START --> <!-- TRIAGEBOT_ASSIGN_START --> This issue has been assigned to @Quantumplation via [this comment](https://github.com/rust-lang/rust/issues/65853#issuecomment-546643811). <!-- TRIAGEBOT_ASSIGN_DATA_START$${"user":"Quantumplation"}$$TRIAGEBOT_ASSIGN_DATA_END --> <!-- TRIAGEBOT_ASSIGN_END --> <!-- TRIAGEBOT_END -->
C-enhancement,A-diagnostics,E-mentor,T-compiler,A-suggestion-diagnostics,D-papercut
low
Critical
512,890,174
godot
Large export integer loses precision when modified from the editor
**Godot version:** v3.1.1.stable.official **OS/device including version:** Ubuntu 18.04.3 LTS 64-bit Intel® Core™ i7-3930K CPU @ 3.20GHz × 12 GeForce GTX 1080 Ti/PCIe/SSE2 32GB ram **Issue description:** Large exported INT variables `export var a: int = 10000000000000` **If changed manually in the editor by typing or deleting a digit will become an unpredictable number.** If the number is edited to a float value that has a dot, it will round to a predictable int number When using the input arrows to modify the number incrementally everything seems to work fine. When dragging the mouse to modify the number incrementally it also seems to work fine. **Steps to reproduce:** add to a script: `export var a: int = 10000000000000` In the Script Variables section in the editor, delete the last digit and press enter.
bug,topic:core,topic:editor,confirmed,topic:gui
low
Major
512,891,922
opencv
app crashes due to igd11dxva64 (msmf backend)
<!-- If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses. If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute). Please: * Read the documentation to test with the latest developer build. * Check if other person has already created the same issue to avoid duplicates. You can comment on it if there already is an issue. * Try to be as detailed as possible in your report. * Report only one problem per created issue. This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library. --> ##### System information (version) <!-- Example - OpenCV => 3.1 - Operating System / Platform => Windows 64 Bit - Compiler => Visual Studio 2015 --> - OpenCV => 4.1.1 - Operating System / Platform => Win10 64 - Compiler => vc15 ##### Detailed description My app which uses opencv and its msmf backend to access webcam crashes sometimes without no error message silently. the crashpad handler send minidump with online one method in the active thread. "igd11dxva64" For what I could find or assume it would be something with directx, maybe the dxva hardware accelaration for msmf. but this bug also happens when I disable the msmf dxva. So I am quite confused. I also tried to disable build with directx. Maybe there is a bug in cmake script and the flag is not used while cmake generates the project with dxva support. Maybe it is a bug in msmf itself. It happens while opening a camera or receiving a frame, this I am not sure. It happens like one in a thousand camera use. Not so often, but still not pleasant for users. ##### Steps to reproduce <!-- to add code example fence it with triple backticks and optional file extension ```.cpp // C++ code example ``` or attach as .txt or .zip file -->
category: videoio(camera),platform: win32
low
Critical
512,897,213
vscode
Turn off RTL for syntactical characters in bidi lines
I am editing a document that has English, Hebrew, and Arabic in it. The cursor movement is based on the language the cursor is on so it jumps in different directions. Inserting and appending text is also unpredictable. For example, if a line is: `Peace | שלום | ` and I paste at the end of the line : `سلام` It will become: `Peace | שלום | سلام` I want it to be: `Peace | سلام | שלום ` Editing the line is also difficult. Here is a similar request on SO: https://stackoverflow.com/questions/54538844/disable-right-to-left-editing-in-vscode-in-mixed-language-files I'd like the ability to easily turn on and off RTL while I'm editing or have the ability to override RTL for the entire document.
feature-request,editor-RTL
medium
Critical
512,901,738
godot
Particles editor plugin generate emission point from mesh file broken
**Godot version:** 3.1.0 **OS/device including version:** Windows 10 (Irrelevant) **Issue description:** When creating emission points from a mesh they won't get generated and this error will appear: "core/object.cpp:1238 - Error calling method from signal 'file_selected': 'ParticlesEditor::_resource_seleted': Method not found." besides the method not being spelled correctly, from reading the source it looks like it doesn't even exist? **Steps to reproduce:** Create Particle node, select it, click on Create Emission Points From Mesh, select the mesh file and the error will appear. **Minimal reproduction project:** (Reproducing its simple and such is irrelevant) And yes, generating from a MeshInstance node works fine. So it would be a really low priority issue.
bug,topic:editor,topic:particles
low
Critical
512,931,382
rust
Re-land early syntax feature gating (was: Some features can no longer be controlled by conditional compilation)
https://github.com/rust-lang/rust/pull/66004 fixed the original issue; now this tracks re-landing those checks (possibly after some transition period). ### Original issue At https://github.com/RalfJung/miri-test-libstd/, I have set things up such that one can run the libcore and liballoc test suite against Miri. The basic idea is to have a `Cargo.toml` file like this (very close to the normal one for libcore): ``` [package] authors = ["The Rust Project Developers"] name = "core_miri_test" version = "0.0.0" autotests = false autobenches = false edition = "2018" [lib] name = "core_miri_test" path = "../libcore/lib.rs" test = false bench = false [[test]] name = "coretests" path = "../libcore/tests/lib.rs" [dev-dependencies] rand = "0.7" ``` Then I make `../libcore` a symlink to the actual libcore sources, cd into the dir with the above `Cargo.toml`, and run `cargo miri test`. This worked fine until recently (until nightly-2019-10-17, to be precise). But since then something broke, and now [I get lots of build failures](https://travis-ci.org/RalfJung/miri-test-libstd/builds/603417659?utm_medium=notification&utm_source=email): ``` error[E0658]: associated type bounds are unstable --> core_miri_test/../libcore/pin.rs:445:15 | 445 | impl<P: Deref<Target: Unpin>> Pin<P> { | ^^^^^^^^^^^^^ | = note: for more information, see https://github.com/rust-lang/rust/issues/52662 = help: add `#![feature(associated_type_bounds)]` to the crate attributes to enable error[E0658]: associated type bounds are unstable --> core_miri_test/../libcore/pin.rs:754:18 | 754 | impl<P: DerefMut<Target: Unpin>> DerefMut for Pin<P> { | ^^^^^^^^^^^^^ | = note: for more information, see https://github.com/rust-lang/rust/issues/52662 = help: add `#![feature(associated_type_bounds)]` to the crate attributes to enable ``` I tried adding these feature gates to every crate root I could think of (the `lib.rs` of both libcore and its test crate), but the errors are sticking. Unfortunately the error doesn't tell me which file *it* thinks is the crate root. Any idea what this could be caused by? Until this is fixed, we won't have Miri coverage of the libcore and liballoc test suite.
T-lang,T-compiler,A-ast
high
Critical
512,936,097
rust
Allow unused_must_use on result with never type
```rust #![feature(never_type)] fn will_not_fail() -> Result<i32, !> { Ok(5) } pub fn main() { will_not_fail(); } ``` This code yields a warning: ``` warning: unused `std::result::Result` that must be used --> main.rs:8:5 | 8 | will_not_fail(); | ^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_must_use)]` on by default = note: this `Result` may be an `Err` variant, which should be handled ``` However since a `Result<T, !>` can never have the `Err` branch, having to handle the resulting error seems kind of pointless. Would it be possible to disable the `unused_must_use` lint for this particular case?
C-enhancement,A-lints,T-lang,F-never_type
low
Critical
512,944,256
youtube-dl
Hi Appreciate if you help download videos from the site -https://olympus.greatlearning.in/courses/4971/pages/unstructured-data-course-introduction?module_item_id=250532
<!-- ###################################################################### WARNING! IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE ###################################################################### --> ## Checklist <!-- Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl: - First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2019.10.22. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED. - Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser. - Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights. - Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates. - Finally, put x into all relevant boxes (like this [x]) --> - [x ] I'm reporting a new site support request - [x ] I've verified that I'm running youtube-dl version **2019.10.22** - [x ] I've checked that all provided URLs are alive and playable in a browser - [x ] I've checked that none of provided URLs violate any copyrights - [x ] I've searched the bugtracker for similar site support requests including closed ones ## Example URLs <!-- Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours. --> - Single video: https://www.youtube.com/watch?v=BaW_jenozKc - Single video: https://youtu.be/BaW_jenozKc - Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc ## Description <!-- Hi i am trying to download videos for a course to watch these offline. the course site is : https://olympus.greatlearning.in/courses/4971/pages/unstructured-data-course-introduction?module_item_id=250532 userid : reddybharath.k@gmail.com password - Bharath@1 The video is a blob and streams as multiple .ts files generated from a java script. Is this possible using this software ? --> Hi i am trying to download videos for a course to watch these offline. the course site is : https://olympus.greatlearning.in/courses/4971/pages/unstructured-data-course-introduction?module_item_id=250532 userid : reddybharath.k@gmail.com password - Bharath@1 The video is a blob and streams as multiple .ts files generated from a java script. Is this possible using this software ?
site-support-request
low
Critical
512,958,946
tensorflow
What is the right way to use coverage.py with Tensorflow?
I apologize if this is the wrong way to ask this question. I'm the maintainer of coverage.py, for measuring code coverage in Python projects. A user wrote an issue for me: https://github.com/nedbat/coveragepy/issues/856 After digging into it, I see that his tf.keras.Model.call() function is not executed directly, but is transformed into a temporary file, and executed there. So coverage.py reports that his code is unexecuted, even though he can see the effects of its execution. I also see that the transformed code has an `ag_source_map__` parameter which can be used to map back from the transformed code to the original code. A coverage.py plugin could use that information to report coverage usefully. My questions are: 1. Is there a reason people haven't reported this to coverage.py before? Is there a existing known way to get coverage reports on this kind of code? 2. What is a stable public API for getting the transformation mapping? 3. Would TensorFlow be interested in maintaining a coverage.py plugin to make this work properly?
stat:awaiting tensorflower,type:feature,comp:core
medium
Critical
512,965,404
rust
Confusing "cannot infer an appropriate lifetime" error message
Consider example: ```rust trait Bar { fn bar(&self, r: &mut Re); } struct Re<'a> { data: &'a u16, } struct Foo; impl Bar for Foo { fn bar<'a, 'b>(&'a self, r: &'b mut Re<'a>){} } ``` ([Playground](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=5bd6ac9f31500a89c9f1fcf98b5ffa30)) Errors: ``` Compiling playground v0.0.1 (/playground) error[E0495]: cannot infer an appropriate lifetime for lifetime parameter 'a in generic type due to conflicting requirements --> src/lib.rs:12:5 | 12 | fn bar<'a, 'b>(&'a self, r: &'b mut Re<'a>){} | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: first, the lifetime cannot outlive the anonymous lifetime #1 defined on the method body at 12:5... --> src/lib.rs:12:5 | 12 | fn bar<'a, 'b>(&'a self, r: &'b mut Re<'a>){} | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ note: ...but the lifetime must also be valid for the anonymous lifetime #3 defined on the method body at 12:5... --> src/lib.rs:12:5 | 12 | fn bar<'a, 'b>(&'a self, r: &'b mut Re<'a>){} | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = note: ...so that the method type is compatible with trait: expected fn(&Foo, &mut Re<'_>) found fn(&Foo, &mut Re<'_>) error: aborting due to previous error For more information about this error, try `rustc --explain E0495`. error: could not compile `playground`. To learn more, run the command again with --verbose. ``` All 3 notes of this error message is confusing: note1, note2: Message not point where are the anonymous lifetime #1 and the anonymous lifetime #3. Also it's not obviously why there are two different anonymous lifetimes at one place (at 12:5). =note3: Expected result looks totally equal to founded. So it's not obviously why it considered as different. It is difficult to figure out what was going on. May be some change of this message needed.
C-enhancement,A-diagnostics,A-lifetimes,T-compiler,A-inference
low
Critical
512,966,864
pytorch
ABI backwards compatibility
## 🚀 Feature Add backwards compatibility to the ABI for LibTorch. ## Motivation At present LibTorch doesn't seem to have a backwards compatible ABI. For those of us writing LibTorch-dependent libraries, it would be beneficial if the binaries we distribute don't break when end users update their version of PyTorch. In particular tools such as `pip` are essentially ignorant of such concerns, and there aren't good ways to encode such concerns in a way that `pip` can understand. As such, resolving these issues largely falls into the lap of the end user. (Who will often only be familiar with Python, and will not have the expertise to resolve such issues themselves.) ## Pitch It would be great to develop an ecosystem around PyTorch similar to the ecosystem that has developed around NumPy! Adding backwards compatibility to the ABI would go a long way towards making this possible. ## Alternatives Alternatives at the moment require that LibTorch-dependent libraries provide versions compatible with all of the versions of PyTorch they wish to support. However, as the tooling is not set up around such expectations, this still leads to multiple thorny issues. - The first and simplest way to handle this issue is to simply provide source distributions of the dependent library (which will remain compatible provided the LibTorch API remains compatible). This of course requires the end user to have a compiler available, which is often not true on Windows. There exists a subtler issue, however. Once the source of the dependent library has been compiled, then `pip` will cache this compiled version - implicitly adding a dependence on the version of PyTorch that the dependent library was compiled against. Subsequent installs via `pip` will throw `ImportError`s about undefined symbols when used with new versions of PyTorch. The end user has to know to recognise this issue, and run `pip install dependent_library --no-cache-dir` to not use the cached version and thus force a recompilation. - The second possibility is to provide precompiled binaries of the dependent library for all versions of PyTorch that the dependent library wishes to support. This has obvious issues: the amount of work required increases as new versions of PyTorch are supported, and asks a lot of the library author to continue to provide these many versions into the future. However once again, there exists an issue with `pip` around this option. Namely, that there isn't a good way to specify this dependency on the version of PyTorch in a way that `pip` will understand. It is possible to adjust the version of the dependent library, e.g. from `1.1.4` to `1.1.4-compiled-with-pytorch-1.3.0` (either programmatically inside `setup.py` or by using its `egg_info` option). But now a simple `pip install dependent_library` command will likely download the wrong version. There's a few ways that this issue might be hacked around with `pip` (which I'll avoid discussing now to avoid writing an essay - I can express those in more detail later on if necessary), but they're all essentially unsatisfactory. In the end, the best current workaround seems to be the second option, and to tell end users to install specifically via `pip install dependent_library==<dependent_library_version>-compiled-with-pytorch-<version_of_pytorch_they_have_installed>`. ## Additional context I'm guessing that maintaining a backwards compatible ABI is likely to be hard work! I admit to ignorance as to how this is actually accomplished in practice, except to note that to the best of my knowledge, both Python and NumPy have accomplished this. Furthermore I admit to not being familiar with providing packages through `conda`, and whether they provide ways of handling the packaging issues discussed above.
module: abi,triaged
low
Critical
512,968,185
flutter
Flutter build fails when project source is located on a mapped Samba Share (Network Drive Letter)
<!-- Thank you for using Flutter! If you are looking for support, please check out our documentation or consider asking a question on Stack Overflow: * https://flutter.dev/ * https://api.flutter.dev/ * https://stackoverflow.com/questions/tagged/flutter?sort=frequent If you have found a bug or if our documentation doesn't have an answer to what you're looking for, then fill our the template below. Please read our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports --> ## Steps to Reproduce <!-- Please tell us exactly how to reproduce the problem you are running into. Please attach a small application (ideally just one main.dart file) that reproduces the problem. You could use https://gist.github.com/ for this. If the problem is with your application's rendering, then please attach a screenshot and explain what the problem is. --> 1. Map a Network dirve (in my case it's a samba share) to a UNC drive letter in this case U: 2. Create or copy a flutter project to a folder on UNC 3. IntelliJ & Android Studio now report previously working import lines of other dart lines for example "import 'package:splash_tokenauth/common/functions/saveCurrentLogin.dart';" as invalid 4. trying to run flutter -v fails with files (for example .packages) not beeing found <!-- Please tell us which target platform(s) the problem occurs (Android / iOS / Web / macOS / Linux / Windows) Which target OS version, for Web, browser, is the test system running? Does the problem occur on emulator/simulator as well as on physical devices? --> **Target Platform:** Android **Target OS version/browser:** Windows 10 Pro **Devices:** emulator & physical ## Logs <!-- Run your application with `flutter run --verbose` and attach all the log output below between the lines with the backticks. If there is an exception, please see if the error message includes enough information to explain how to solve the issue. --> ``` U:\medium_splash_tokenauth>flutter run --verbose [ +27 ms] executing: [C:\src\flutter\] git -c log.showSignature=false log -n 1 --pretty=format:%H [ +103 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H [ +1 ms] e70236e36ce1d32067dc68eb55519ec3e14b6b01 [ ] executing: [C:\src\flutter\] git describe --match v*.*.* --first-parent --long --tags [ +105 ms] Exit code 0 from: git describe --match v*.*.* --first-parent --long --tags [ ] v1.10.7-0-ge70236e36 [ +5 ms] executing: [C:\src\flutter\] git rev-parse --abbrev-ref --symbolic @{u} [ +85 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u} [ ] origin/beta [ ] executing: [C:\src\flutter\] git ls-remote --get-url origin [ +83 ms] Exit code 0 from: git ls-remote --get-url origin [ ] https://github.com/flutter/flutter.git [ +105 ms] executing: [C:\src\flutter\] git rev-parse --abbrev-ref HEAD [ +84 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD [ ] beta [ +112 ms] executing: C:\Users\marc\AppData\Local\Android\sdk\platform-tools\adb.exe devices -l [ +209 ms] Exit code 0 from: C:\Users\marc\AppData\Local\Android\sdk\platform-tools\adb.exe devices -l [ ] List of devices attached emulator-5554 device product:sdk_gphone_x86_64 model:Android_SDK_built_for_x86_64 device:generic_x86_64 transport_id:4 [ +13 ms] C:\Users\marc\AppData\Local\Android\sdk\platform-tools\adb.exe -s emulator-5554 shell getprop [ +238 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update. [ +6 ms] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update. [ ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update. [ ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update. [ +5 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update. [ ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update. [ +1 ms] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update. [ ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update. [ ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update. [ ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update. [ +79 ms] Found plugin shared_preferences at C:\Users\marc\AppData\Roaming\Pub\Cache\hosted\pub.dartlang.org\shared_preferences-0.4.2\ [ +21 ms] Found plugin url_launcher at C:\Users\marc\AppData\Roaming\Pub\Cache\hosted\pub.dartlang.org\url_launcher-3.0.3\ [ +122 ms] Found plugin shared_preferences at C:\Users\marc\AppData\Roaming\Pub\Cache\hosted\pub.dartlang.org\shared_preferences-0.4.2\ [ +19 ms] Found plugin url_launcher at C:\Users\marc\AppData\Roaming\Pub\Cache\hosted\pub.dartlang.org\url_launcher-3.0.3\ [ +71 ms] ro.hardware = ranchu [ +25 ms] Using hardware rendering with device Android SDK built for x86 64. If you get graphics artifacts, consider enabling software rendering with "--enable-software-rendering". [ +23 ms] Launching lib\main.dart on Android SDK built for x86 64 in debug mode... [ +17 ms] Initializing gradle... [ +7 ms] gradle.properties already sets `android.enableR8` [ +20 ms] Using gradle from U:\medium_splash_tokenauth\android\gradlew.bat. [ +6 ms] executing: C:\Program Files\Android\Android Studio1\jre\bin\java -version [ +233 ms] Exit code 0 from: C:\Program Files\Android\Android Studio1\jre\bin\java -version [ +1 ms] openjdk version "1.8.0_202-release" OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03) OpenJDK 64-Bit Server VM (build 25.202-b03, mixed mode) [ +3 ms] executing: U:\medium_splash_tokenauth\android\gradlew.bat -v [ +987 ms] ------------------------------------------------------------ Gradle 4.4 ------------------------------------------------------------ Build time: 2017-12-06 09:05:06 UTC Revision: cf7821a6f79f8e2a598df21780e3ff7ce8db2b82 Groovy: 2.4.12 Ant: Apache Ant(TM) version 1.9.9 compiled on February 2 2017 JVM: 1.8.0_202-release (JetBrains s.r.o 25.202-b03) OS: Windows 10 10.0 amd64 [ +6 ms] Initializing gradle... (completed in 1.3s) [ +8 ms] Resolving dependencies... [ ] executing: [U:\medium_splash_tokenauth\android\] U:\medium_splash_tokenauth\android\gradlew.bat app:properties [+3466 ms] :app:properties ------------------------------------------------------------ Project :app ------------------------------------------------------------ allprojects: [project ':app'] android: com.android.build.gradle.AppExtension_Decorated@785212e3 android.enableR8: true androidDependencies: task ':app:androidDependencies' ant: org.gradle.api.internal.project.DefaultAntBuilder@58bf8dbc antBuilderFactory: org.gradle.api.internal.project.DefaultAntBuilderFactory@1bc653 archivesBaseName: app artifacts: org.gradle.api.internal.artifacts.dsl.DefaultArtifactHandler_Decorated@933f8ec asDynamicObject: DynamicObject for project ':app' assemble: task ':app:assemble' assembleAndroidTest: task ':app:assembleAndroidTest' assembleDebug: task ':app:assembleDebug' assembleDebugAndroidTest: task ':app:assembleDebugAndroidTest' assembleDebugUnitTest: task ':app:assembleDebugUnitTest' assembleProfile: task ':app:assembleProfile' assembleProfileUnitTest: task ':app:assembleProfileUnitTest' assembleRelease: task ':app:assembleRelease' assembleReleaseUnitTest: task ':app:assembleReleaseUnitTest' baseClassLoaderScope: org.gradle.api.internal.initialization.DefaultClassLoaderScope@619e3623 buildDependents: task ':app:buildDependents' buildDir: U:\medium_splash_tokenauth\build\app buildFile: U:\medium_splash_tokenauth\android\app\build.gradle buildNeeded: task ':app:buildNeeded' buildOutputs: BaseVariantOutput container buildPath: : buildScriptSource: org.gradle.groovy.scripts.TextResourceScriptSource@45e885c1 buildscript: org.gradle.api.internal.initialization.DefaultScriptHandler@1b1fea71 bundleAppClassesDebug: task ':app:bundleAppClassesDebug' bundleAppClassesDebugAndroidTest: task ':app:bundleAppClassesDebugAndroidTest' bundleAppClassesDebugUnitTest: task ':app:bundleAppClassesDebugUnitTest' bundleAppClassesProfile: task ':app:bundleAppClassesProfile' bundleAppClassesProfileUnitTest: task ':app:bundleAppClassesProfileUnitTest' bundleAppClassesRelease: task ':app:bundleAppClassesRelease' bundleAppClassesReleaseUnitTest: task ':app:bundleAppClassesReleaseUnitTest' bundleDebugAndroidTestResources: task ':app:bundleDebugAndroidTestResources' bundleDebugResources: task ':app:bundleDebugResources' bundleProfileResources: task ':app:bundleProfileResources' bundleReleaseResources: task ':app:bundleReleaseResources' check: task ':app:check' checkDebugManifest: task ':app:checkDebugManifest' checkProfileManifest: task ':app:checkProfileManifest' checkReleaseManifest: task ':app:checkReleaseManifest' childProjects: {} class: class org.gradle.api.internal.project.DefaultProject_Decorated classLoaderScope: org.gradle.api.internal.initialization.DefaultClassLoaderScope@d7d8566 cleanBuildCache: task ':app:cleanBuildCache' compileDebugAidl: task ':app:compileDebugAidl' compileDebugAndroidTestAidl: task ':app:compileDebugAndroidTestAidl' compileDebugAndroidTestJavaWithJavac: task ':app:compileDebugAndroidTestJavaWithJavac' compileDebugAndroidTestKotlin: task ':app:compileDebugAndroidTestKotlin' compileDebugAndroidTestNdk: task ':app:compileDebugAndroidTestNdk' compileDebugAndroidTestRenderscript: task ':app:compileDebugAndroidTestRenderscript' compileDebugAndroidTestShaders: task ':app:compileDebugAndroidTestShaders' compileDebugAndroidTestSources: task ':app:compileDebugAndroidTestSources' compileDebugJavaWithJavac: task ':app:compileDebugJavaWithJavac' compileDebugKotlin: task ':app:compileDebugKotlin' compileDebugNdk: task ':app:compileDebugNdk' compileDebugRenderscript: task ':app:compileDebugRenderscript' compileDebugShaders: task ':app:compileDebugShaders' compileDebugSources: task ':app:compileDebugSources' compileDebugUnitTestJavaWithJavac: task ':app:compileDebugUnitTestJavaWithJavac' compileDebugUnitTestKotlin: task ':app:compileDebugUnitTestKotlin' compileDebugUnitTestSources: task ':app:compileDebugUnitTestSources' compileFlutterBuildDebugArm: task ':app:compileFlutterBuildDebugArm' compileFlutterBuildDebugArm64: task ':app:compileFlutterBuildDebugArm64' compileFlutterBuildProfileArm: task ':app:compileFlutterBuildProfileArm' compileFlutterBuildProfileArm64: task ':app:compileFlutterBuildProfileArm64' compileFlutterBuildReleaseArm: task ':app:compileFlutterBuildReleaseArm' compileFlutterBuildReleaseArm64: task ':app:compileFlutterBuildReleaseArm64' compileLint: task ':app:compileLint' compileProfileAidl: task ':app:compileProfileAidl' compileProfileJavaWithJavac: task ':app:compileProfileJavaWithJavac' compileProfileKotlin: task ':app:compileProfileKotlin' compileProfileNdk: task ':app:compileProfileNdk' compileProfileRenderscript: task ':app:compileProfileRenderscript' compileProfileShaders: task ':app:compileProfileShaders' compileProfileSources: task ':app:compileProfileSources' compileProfileUnitTestJavaWithJavac: task ':app:compileProfileUnitTestJavaWithJavac' compileProfileUnitTestKotlin: task ':app:compileProfileUnitTestKotlin' compileProfileUnitTestSources: task ':app:compileProfileUnitTestSources' compileReleaseAidl: task ':app:compileReleaseAidl' compileReleaseJavaWithJavac: task ':app:compileReleaseJavaWithJavac' compileReleaseKotlin: task ':app:compileReleaseKotlin' compileReleaseNdk: task ':app:compileReleaseNdk' compileReleaseRenderscript: task ':app:compileReleaseRenderscript' compileReleaseShaders: task ':app:compileReleaseShaders' compileReleaseSources: task ':app:compileReleaseSources' compileReleaseUnitTestJavaWithJavac: task ':app:compileReleaseUnitTestJavaWithJavac' compileReleaseUnitTestKotlin: task ':app:compileReleaseUnitTestKotlin' compileReleaseUnitTestSources: task ':app:compileReleaseUnitTestSources' components: SoftwareComponentInternal set configurationActions: org.gradle.configuration.project.DefaultProjectConfigurationActionContainer@1dc295c4 configurationTargetIdentifier: org.gradle.configuration.ConfigurationTargetIdentifier$1@1c85dd30 configurations: configuration container connectedAndroidTest: task ':app:connectedAndroidTest' connectedCheck: task ':app:connectedCheck' connectedDebugAndroidTest: task ':app:connectedDebugAndroidTest' consumeConfigAttr: task ':app:consumeConfigAttr' convention: org.gradle.api.internal.plugins.DefaultConvention@782de0b3 copyFlutterAssetsDebug: task ':app:copyFlutterAssetsDebug' copyFlutterAssetsProfile: task ':app:copyFlutterAssetsProfile' copyFlutterAssetsRelease: task ':app:copyFlutterAssetsRelease' createDebugCompatibleScreenManifests: task ':app:createDebugCompatibleScreenManifests' createProfileCompatibleScreenManifests: task ':app:createProfileCompatibleScreenManifests' createReleaseCompatibleScreenManifests: task ':app:createReleaseCompatibleScreenManifests' defaultArtifacts: org.gradle.api.internal.plugins.DefaultArtifactPublicationSet_Decorated@191a0c65 defaultTasks: [] deferredProjectConfiguration: org.gradle.api.internal.project.DeferredProjectConfiguration@107fd637 dependencies: org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler_Decorated@22a1e555 depth: 1 description: null deviceAndroidTest: task ':app:deviceAndroidTest' deviceCheck: task ':app:deviceCheck' displayName: project ':app' distsDir: U:\medium_splash_tokenauth\build\app\distributions distsDirName: distributions docsDir: U:\medium_splash_tokenauth\build\app\docs docsDirName: docs ext: org.gradle.api.internal.plugins.DefaultExtraPropertiesExtension@359ea1ca extensions: org.gradle.api.internal.plugins.DefaultConvention@782de0b3 extractProguardFiles: task ':app:extractProguardFiles' extractTryWithResourcesSupportJarDebug: task ':app:extractTryWithResourcesSupportJarDebug' extractTryWithResourcesSupportJarProfile: task ':app:extractTryWithResourcesSupportJarProfile' extractTryWithResourcesSupportJarRelease: task ':app:extractTryWithResourcesSupportJarRelease' fileOperations: org.gradle.api.internal.file.DefaultFileOperations@7c2eea38 fileResolver: org.gradle.api.internal.file.BaseDirFileResolver@120e45e4 flutter: FlutterExtension_Decorated@3f2891bd generateDebugAndroidTestAssets: task ':app:generateDebugAndroidTestAssets' generateDebugAndroidTestBuildConfig: task ':app:generateDebugAndroidTestBuildConfig' generateDebugAndroidTestResValues: task ':app:generateDebugAndroidTestResValues' generateDebugAndroidTestResources: task ':app:generateDebugAndroidTestResources' generateDebugAndroidTestSources: task ':app:generateDebugAndroidTestSources' generateDebugAssets: task ':app:generateDebugAssets' generateDebugBuildConfig: task ':app:generateDebugBuildConfig' generateDebugResValues: task ':app:generateDebugResValues' generateDebugResources: task ':app:generateDebugResources' generateDebugSources: task ':app:generateDebugSources' generateProfileAssets: task ':app:generateProfileAssets' generateProfileBuildConfig: task ':app:generateProfileBuildConfig' generateProfileResValues: task ':app:generateProfileResValues' generateProfileResources: task ':app:generateProfileResources' generateProfileSources: task ':app:generateProfileSources' generateReleaseAssets: task ':app:generateReleaseAssets' generateReleaseBuildConfig: task ':app:generateReleaseBuildConfig' generateReleaseResValues: task ':app:generateReleaseResValues' generateReleaseResources: task ':app:generateReleaseResources' generateReleaseSources: task ':app:generateReleaseSources' gradle: build 'android' group: android identityPath: :app inheritedScope: org.gradle.api.internal.ExtensibleDynamicObject$InheritedDynamicObject@7ff8f763 installDebug: task ':app:installDebug' installDebugAndroidTest: task ':app:installDebugAndroidTest' installProfile: task ':app:installProfile' installRelease: task ':app:installRelease' javaPreCompileDebug: task ':app:javaPreCompileDebug' javaPreCompileDebugAndroidTest: task ':app:javaPreCompileDebugAndroidTest' javaPreCompileDebugUnitTest: task ':app:javaPreCompileDebugUnitTest' javaPreCompileProfile: task ':app:javaPreCompileProfile' javaPreCompileProfileUnitTest: task ':app:javaPreCompileProfileUnitTest' javaPreCompileRelease: task ':app:javaPreCompileRelease' javaPreCompileReleaseUnitTest: task ':app:javaPreCompileReleaseUnitTest' kapt: org.jetbrains.kotlin.gradle.plugin.KaptExtension_Decorated@748cad8e kotlin: org.jetbrains.kotlin.gradle.dsl.KotlinProjectExtension_Decorated@144de79e kotlin_version: 1.2.30 layout: org.gradle.api.internal.file.DefaultProjectLayout@6f9329d3 libsDir: U:\medium_splash_tokenauth\build\app\libs libsDirName: libs lint: task ':app:lint' lintDebug: task ':app:lintDebug' lintProfile: task ':app:lintProfile' lintRelease: task ':app:lintRelease' lintVitalRelease: task ':app:lintVitalRelease' logger: org.gradle.internal.logging.slf4j.OutputEventListenerBackedLogger@62b670ed logging: org.gradle.internal.logging.services.DefaultLoggingManager@576898ad mainApkListPersistenceDebug: task ':app:mainApkListPersistenceDebug' mainApkListPersistenceDebugAndroidTest: task ':app:mainApkListPersistenceDebugAndroidTest' mainApkListPersistenceProfile: task ':app:mainApkListPersistenceProfile' mainApkListPersistenceRelease: task ':app:mainApkListPersistenceRelease' mergeDebugAndroidTestAssets: task ':app:mergeDebugAndroidTestAssets' mergeDebugAndroidTestJniLibFolders: task ':app:mergeDebugAndroidTestJniLibFolders' mergeDebugAndroidTestResources: task ':app:mergeDebugAndroidTestResources' mergeDebugAndroidTestShaders: task ':app:mergeDebugAndroidTestShaders' mergeDebugAssets: task ':app:mergeDebugAssets' mergeDebugJniLibFolders: task ':app:mergeDebugJniLibFolders' mergeDebugResources: task ':app:mergeDebugResources' mergeDebugShaders: task ':app:mergeDebugShaders' mergeProfileAssets: task ':app:mergeProfileAssets' mergeProfileJniLibFolders: task ':app:mergeProfileJniLibFolders' mergeProfileResources: task ':app:mergeProfileResources' mergeProfileShaders: task ':app:mergeProfileShaders' mergeReleaseAssets: task ':app:mergeReleaseAssets' mergeReleaseJniLibFolders: task ':app:mergeReleaseJniLibFolders' mergeReleaseResources: task ':app:mergeReleaseResources' mergeReleaseShaders: task ':app:mergeReleaseShaders' mockableAndroidJar: task ':app:mockableAndroidJar' modelRegistry: org.gradle.model.internal.registry.DefaultModelRegistry@4699af13 modelSchemaStore: org.gradle.model.internal.manage.schema.extract.DefaultModelSchemaStore@11898ac5 module: org.gradle.api.internal.artifacts.ProjectBackedModule@1da43a2f name: app normalization: org.gradle.normalization.internal.DefaultInputNormalizationHandler_Decorated@3d13c149 objects: org.gradle.api.internal.model.DefaultObjectFactory@4bb8ba89 org.gradle.jvmargs: -Xmx1536M packLibsflutterBuildDebug: task ':app:packLibsflutterBuildDebug' packLibsflutterBuildProfile: task ':app:packLibsflutterBuildProfile' packLibsflutterBuildRelease: task ':app:packLibsflutterBuildRelease' packageDebug: task ':app:packageDebug' packageDebugAndroidTest: task ':app:packageDebugAndroidTest' packageProfile: task ':app:packageProfile' packageRelease: task ':app:packageRelease' parent: root project 'android' parentIdentifier: root project 'android' path: :app platformAttrExtractor: task ':app:platformAttrExtractor' pluginManager: org.gradle.api.internal.plugins.DefaultPluginManager_Decorated@5806fea3 plugins: [org.gradle.api.plugins.HelpTasksPlugin@25eff4b5, com.android.build.gradle.api.AndroidBasePlugin@5599078, org.gradle.language.base.plugins.LifecycleBasePlugin@5110f7cf, org.gradle.api.plugins.BasePlugin@d3e31cb, org.gradle.api.plugins.ReportingBasePlugin@5c62601b, org.gradle.platform.base.plugins.ComponentBasePlugin@6e10e2dd, org.gradle.language.base.plugins.LanguageBasePlugin@21bd25bc, org.gradle.platform.base.plugins.BinaryBasePlugin@56f90ff8, org.gradle.api.plugins.JavaBasePlugin@1631fb9c, com.android.build.gradle.AppPlugin@77caecbd, org.jetbrains.kotlin.gradle.plugin.KotlinAndroidPluginWrapper@7d8cf34d, FlutterPlugin@6911594e] preBuild: task ':app:preBuild' preDebugAndroidTestBuild: task ':app:preDebugAndroidTestBuild' preDebugBuild: task ':app:preDebugBuild' preDebugUnitTestBuild: task ':app:preDebugUnitTestBuild' preProfileBuild: task ':app:preProfileBuild' preProfileUnitTestBuild: task ':app:preProfileUnitTestBuild' preReleaseBuild: task ':app:preReleaseBuild' preReleaseUnitTestBuild: task ':app:preReleaseUnitTestBuild' prepareLintJar: task ':app:prepareLintJar' preparePUBLISHED_DEXDebugAndroidTestForPublishing: task ':app:preparePUBLISHED_DEXDebugAndroidTestForPublishing' preparePUBLISHED_DEXDebugForPublishing: task ':app:preparePUBLISHED_DEXDebugForPublishing' preparePUBLISHED_DEXProfileForPublishing: task ':app:preparePUBLISHED_DEXProfileForPublishing' preparePUBLISHED_DEXReleaseForPublishing: task ':app:preparePUBLISHED_DEXReleaseForPublishing' preparePUBLISHED_JAVA_RESDebugAndroidTestForPublishing: task ':app:preparePUBLISHED_JAVA_RESDebugAndroidTestForPublishing' preparePUBLISHED_JAVA_RESDebugForPublishing: task ':app:preparePUBLISHED_JAVA_RESDebugForPublishing' preparePUBLISHED_JAVA_RESProfileForPublishing: task ':app:preparePUBLISHED_JAVA_RESProfileForPublishing' preparePUBLISHED_JAVA_RESReleaseForPublishing: task ':app:preparePUBLISHED_JAVA_RESReleaseForPublishing' preparePUBLISHED_NATIVE_LIBSDebugAndroidTestForPublishing: task ':app:preparePUBLISHED_NATIVE_LIBSDebugAndroidTestForPublishing' preparePUBLISHED_NATIVE_LIBSDebugForPublishing: task ':app:preparePUBLISHED_NATIVE_LIBSDebugForPublishing' preparePUBLISHED_NATIVE_LIBSProfileForPublishing: task ':app:preparePUBLISHED_NATIVE_LIBSProfileForPublishing' preparePUBLISHED_NATIVE_LIBSReleaseForPublishing: task ':app:preparePUBLISHED_NATIVE_LIBSReleaseForPublishing' processDebugAndroidTestJavaRes: task ':app:processDebugAndroidTestJavaRes' processDebugAndroidTestManifest: task ':app:processDebugAndroidTestManifest' processDebugAndroidTestResources: task ':app:processDebugAndroidTestResources' processDebugJavaRes: task ':app:processDebugJavaRes' processDebugManifest: task ':app:processDebugManifest' processDebugResources: task ':app:processDebugResources' processDebugUnitTestJavaRes: task ':app:processDebugUnitTestJavaRes' processOperations: org.gradle.api.internal.file.DefaultFileOperations@7c2eea38 processProfileJavaRes: task ':app:processProfileJavaRes' processProfileManifest: task ':app:processProfileManifest' processProfileResources: task ':app:processProfileResources' processProfileUnitTestJavaRes: task ':app:processProfileUnitTestJavaRes' processReleaseJavaRes: task ':app:processReleaseJavaRes' processReleaseManifest: task ':app:processReleaseManifest' processReleaseResources: task ':app:processReleaseResources' processReleaseUnitTestJavaRes: task ':app:processReleaseUnitTestJavaRes' project: project ':app' projectConfigurator: org.gradle.api.internal.project.BuildOperationCrossProjectConfigurator@536c3387 projectDir: U:\medium_splash_tokenauth\android\app projectEvaluationBroadcaster: ProjectEvaluationListener broadcast projectEvaluator: org.gradle.configuration.project.LifecycleProjectEvaluator@7056a92a projectPath: :app projectRegistry: org.gradle.api.internal.project.DefaultProjectRegistry@7e34395b properties: {...} providers: org.gradle.api.internal.provider.DefaultProviderFactory@6c068d46 reportBuildArtifactsDebug: task ':app:reportBuildArtifactsDebug' reportBuildArtifactsProfile: task ':app:reportBuildArtifactsProfile' reportBuildArtifactsRelease: task ':app:reportBuildArtifactsRelease' reporting: org.gradle.api.reporting.ReportingExtension_Decorated@112823d8 reportsDir: U:\medium_splash_tokenauth\build\app\reports repositories: repository container resolveConfigAttr: task ':app:resolveConfigAttr' resourceLoader: org.gradle.internal.resource.transfer.DefaultUriTextResourceLoader@23eaca71 resources: org.gradle.api.internal.resources.DefaultResourceHandler@663038df rootDir: U:\medium_splash_tokenauth\android rootProject: root project 'android' script: false scriptHandlerFactory: org.gradle.api.internal.initialization.DefaultScriptHandlerFactory@39112ba3 scriptPluginFactory: org.gradle.configuration.ScriptPluginFactorySelector@69f7e9ba serviceRegistryFactory: org.gradle.internal.service.scopes.ProjectScopeServices$4@1cbb1fb7 services: ProjectScopeServices signingReport: task ':app:signingReport' sourceCompatibility: 1.8 sourceSets: SourceSet container splitsDiscoveryTaskDebug: task ':app:splitsDiscoveryTaskDebug' splitsDiscoveryTaskProfile: task ':app:splitsDiscoveryTaskProfile' splitsDiscoveryTaskRelease: task ':app:splitsDiscoveryTaskRelease' standardOutputCapture: org.gradle.internal.logging.services.DefaultLoggingManager@576898ad state: project state 'EXECUTED' status: integration subprojects: [] targetCompatibility: 1.8 tasks: task set test: task ':app:test' testDebugUnitTest: task ':app:testDebugUnitTest' testProfileUnitTest: task ':app:testProfileUnitTest' testReleaseUnitTest: task ':app:testReleaseUnitTest' testReportDir: U:\medium_splash_tokenauth\build\app\reports\tests testReportDirName: tests testResultsDir: U:\medium_splash_tokenauth\build\app\test-results testResultsDirName: test-results transformClassesWithDesugarForDebug: task ':app:transformClassesWithDesugarForDebug' transformClassesWithDesugarForDebugAndroidTest: task ':app:transformClassesWithDesugarForDebugAndroidTest' transformClassesWithDesugarForProfile: task ':app:transformClassesWithDesugarForProfile' transformClassesWithDesugarForRelease: task ':app:transformClassesWithDesugarForRelease' transformClassesWithDexBuilderForDebug: task ':app:transformClassesWithDexBuilderForDebug' transformClassesWithDexBuilderForDebugAndroidTest: task ':app:transformClassesWithDexBuilderForDebugAndroidTest' transformClassesWithDexBuilderForProfile: task ':app:transformClassesWithDexBuilderForProfile' transformClassesWithDexBuilderForRelease: task ':app:transformClassesWithDexBuilderForRelease' transformClassesWithStackFramesFixerForDebug: task ':app:transformClassesWithStackFramesFixerForDebug' transformClassesWithStackFramesFixerForDebugAndroidTest: task ':app:transformClassesWithStackFramesFixerForDebugAndroidTest' transformClassesWithStackFramesFixerForProfile: task ':app:transformClassesWithStackFramesFixerForProfile' transformClassesWithStackFramesFixerForRelease: task ':app:transformClassesWithStackFramesFixerForRelease' transformDexArchiveWithDexMergerForDebug: task ':app:transformDexArchiveWithDexMergerForDebug' transformDexArchiveWithDexMergerForDebugAndroidTest: task ':app:transformDexArchiveWithDexMergerForDebugAndroidTest' transformDexArchiveWithDexMergerForProfile: task ':app:transformDexArchiveWithDexMergerForProfile' transformDexArchiveWithDexMergerForRelease: task ':app:transformDexArchiveWithDexMergerForRelease' transformDexArchiveWithExternalLibsDexMergerForDebug: task ':app:transformDexArchiveWithExternalLibsDexMergerForDebug' transformDexArchiveWithExternalLibsDexMergerForDebugAndroidTest: task ':app:transformDexArchiveWithExternalLibsDexMergerForDebugAndroidTest' transformDexArchiveWithExternalLibsDexMergerForProfile: task ':app:transformDexArchiveWithExternalLibsDexMergerForProfile' transformDexArchiveWithExternalLibsDexMergerForRelease: task ':app:transformDexArchiveWithExternalLibsDexMergerForRelease' transformNativeLibsWithMergeJniLibsForDebug: task ':app:transformNativeLibsWithMergeJniLibsForDebug' transformNativeLibsWithMergeJniLibsForDebugAndroidTest: task ':app:transformNativeLibsWithMergeJniLibsForDebugAndroidTest' transformNativeLibsWithMergeJniLibsForProfile: task ':app:transformNativeLibsWithMergeJniLibsForProfile' transformNativeLibsWithMergeJniLibsForRelease: task ':app:transformNativeLibsWithMergeJniLibsForRelease' transformResourcesWithMergeJavaResForDebug: task ':app:transformResourcesWithMergeJavaResForDebug' transformResourcesWithMergeJavaResForDebugAndroidTest: task ':app:transformResourcesWithMergeJavaResForDebugAndroidTest' transformResourcesWithMergeJavaResForDebugUnitTest: task ':app:transformResourcesWithMergeJavaResForDebugUnitTest' transformResourcesWithMergeJavaResForProfile: task ':app:transformResourcesWithMergeJavaResForProfile' transformResourcesWithMergeJavaResForProfileUnitTest: task ':app:transformResourcesWithMergeJavaResForProfileUnitTest' transformResourcesWithMergeJavaResForRelease: task ':app:transformResourcesWithMergeJavaResForRelease' transformResourcesWithMergeJavaResForReleaseUnitTest: task ':app:transformResourcesWithMergeJavaResForReleaseUnitTest' uninstallAll: task ':app:uninstallAll' uninstallDebug: task ':app:uninstallDebug' uninstallDebugAndroidTest: task ':app:uninstallDebugAndroidTest' uninstallProfile: task ':app:uninstallProfile' uninstallRelease: task ':app:uninstallRelease' validateSigningDebug: task ':app:validateSigningDebug' validateSigningDebugAndroidTest: task ':app:validateSigningDebugAndroidTest' validateSigningProfile: task ':app:validateSigningProfile' validateSigningRelease: task ':app:validateSigningRelease' version: unspecified writeDebugApplicationId: task ':app:writeDebugApplicationId' writeProfileApplicationId: task ':app:writeProfileApplicationId' writeReleaseApplicationId: task ':app:writeReleaseApplicationId' BUILD SUCCESSFUL in 3s 1 actionable task: 1 executed [ +12 ms] executing: [U:\medium_splash_tokenauth\android\] U:\medium_splash_tokenauth\android\gradlew.bat app:tasks --all --console=auto [+3485 ms] :app:tasks ------------------------------------------------------------ All tasks runnable from project :app ------------------------------------------------------------ Android tasks ------------- androidDependencies - Displays the Android dependencies of the project. signingReport - Displays the signing info for each variant. sourceSets - Prints out all the source sets defined in this project. Build tasks ----------- assemble - Assembles all variants of all applications and secondary packages. assembleAndroidTest - Assembles all the Test applications. assembleDebug - Assembles all Debug builds. assembleProfile - Assembles all Profile builds. assembleRelease - Assembles all Release builds. build - Assembles and tests this project. buildDependents - Assembles and tests this project and all projects that depend on it. buildNeeded - Assembles and tests this project and all projects it depends on. clean - Deletes the build directory. cleanBuildCache - Deletes the build cache directory. compileDebugAndroidTestSources compileDebugSources compileDebugUnitTestSources compileProfileSources compileProfileUnitTestSources compileReleaseSources compileReleaseUnitTestSources mockableAndroidJar - Creates a version of android.jar that's suitable for unit tests. Help tasks ---------- buildEnvironment - Displays all buildscript dependencies declared in project ':app'. components - Displays the components produced by project ':app'. [incubating] dependencies - Displays all dependencies declared in project ':app'. dependencyInsight - Displays the insight into a specific dependency in project ':app'. dependentComponents - Displays the dependent components of components in project ':app'. [incubating] help - Displays a help message. model - Displays the configuration model of project ':app'. [incubating] projects - Displays the sub-projects of project ':app'. properties - Displays the properties of project ':app'. tasks - Displays the tasks runnable from project ':app'. Install tasks ------------- installDebug - Installs the Debug build. installDebugAndroidTest - Installs the android (on device) tests for the Debug build. installProfile - Installs the Profile build. installRelease - Installs the Release build. uninstallAll - Uninstall all applications. uninstallDebug - Uninstalls the Debug build. uninstallDebugAndroidTest - Uninstalls the android (on device) tests for the Debug build. uninstallProfile - Uninstalls the Profile build. uninstallRelease - Uninstalls the Release build. Verification tasks ------------------ check - Runs all checks. connectedAndroidTest - Installs and runs instrumentation tests for all flavors on connected devices. connectedCheck - Runs all device checks on currently connected devices. connectedDebugAndroidTest - Installs and runs the tests for debug on connected devices. deviceAndroidTest - Installs and runs instrumentation tests using all Device Providers. deviceCheck - Runs all device checks using Device Providers and Test Servers. lint - Runs lint on all variants. lintDebug - Runs lint on the Debug build. lintProfile - Runs lint on the Profile build. lintRelease - Runs lint on the Release build. lintVitalRelease - Runs lint on just the fatal issues in the release build. test - Run unit tests for all variants. testDebugUnitTest - Run unit tests for the debug build. testProfileUnitTest - Run unit tests for the profile build. testReleaseUnitTest - Run unit tests for the release build. Other tasks ----------- assembleDebugAndroidTest assembleDebugUnitTest assembleProfileUnitTest assembleReleaseUnitTest bundleAppClassesDebug bundleAppClassesDebugAndroidTest bundleAppClassesDebugUnitTest bundleAppClassesProfile bundleAppClassesProfileUnitTest bundleAppClassesRelease bundleAppClassesReleaseUnitTest bundleDebugAndroidTestResources bundleDebugResources bundleProfileResources bundleReleaseResources checkDebugManifest checkProfileManifest checkReleaseManifest compileDebugAidl compileDebugAndroidTestAidl compileDebugAndroidTestJavaWithJavac compileDebugAndroidTestKotlin - Compiles the debugAndroidTest kotlin. compileDebugAndroidTestNdk compileDebugAndroidTestRenderscript compileDebugAndroidTestShaders compileDebugJavaWithJavac compileDebugKotlin - Compiles the debug kotlin. compileDebugNdk compileDebugRenderscript compileDebugShaders compileDebugUnitTestJavaWithJavac compileDebugUnitTestKotlin - Compiles the debugUnitTest kotlin. compileFlutterBuildDebugArm compileFlutterBuildDebugArm64 compileFlutterBuildProfileArm compileFlutterBuildProfileArm64 compileFlutterBuildReleaseArm compileFlutterBuildReleaseArm64 compileLint compileProfileAidl compileProfileJavaWithJavac compileProfileKotlin - Compiles the profile kotlin. compileProfileNdk compileProfileRenderscript compileProfileShaders compileProfileUnitTestJavaWithJavac compileProfileUnitTestKotlin - Compiles the profileUnitTest kotlin. compileReleaseAidl compileReleaseJavaWithJavac compileReleaseKotlin - Compiles the release kotlin. compileReleaseNdk compileReleaseRenderscript compileReleaseShaders compileReleaseUnitTestJavaWithJavac compileReleaseUnitTestKotlin - Compiles the releaseUnitTest kotlin. consumeConfigAttr copyFlutterAssetsDebug copyFlutterAssetsProfile copyFlutterAssetsRelease createDebugCompatibleScreenManifests createProfileCompatibleScreenManifests createReleaseCompatibleScreenManifests extractProguardFiles extractTryWithResourcesSupportJarDebug extractTryWithResourcesSupportJarProfile extractTryWithResourcesSupportJarRelease generateDebugAndroidTestAssets generateDebugAndroidTestBuildConfig generateDebugAndroidTestResources generateDebugAndroidTestResValues generateDebugAndroidTestSources generateDebugAssets generateDebugBuildConfig generateDebugResources generateDebugResValues generateDebugSources generateProfileAssets generateProfileBuildConfig generateProfileResources generateProfileResValues generateProfileSources generateReleaseAssets generateReleaseBuildConfig generateReleaseResources generateReleaseResValues generateReleaseSources javaPreCompileDebug javaPreCompileDebugAndroidTest javaPreCompileDebugUnitTest javaPreCompileProfile javaPreCompileProfileUnitTest javaPreCompileRelease javaPreCompileReleaseUnitTest mainApkListPersistenceDebug mainApkListPersistenceDebugAndroidTest mainApkListPersistenceProfile mainApkListPersistenceRelease mergeDebugAndroidTestAssets mergeDebugAndroidTestJniLibFolders mergeDebugAndroidTestResources mergeDebugAndroidTestShaders mergeDebugAssets mergeDebugJniLibFolders mergeDebugResources mergeDebugShaders mergeProfileAssets mergeProfileJniLibFolders mergeProfileResources mergeProfileShaders mergeReleaseAssets mergeReleaseJniLibFolders mergeReleaseResources mergeReleaseShaders packageDebug packageDebugAndroidTest packageProfile packageRelease packLibsflutterBuildDebug packLibsflutterBuildProfile packLibsflutterBuildRelease platformAttrExtractor preBuild preDebugAndroidTestBuild preDebugBuild preDebugUnitTestBuild prepareLintJar preparePUBLISHED_DEXDebugAndroidTestForPublishing preparePUBLISHED_DEXDebugForPublishing preparePUBLISHED_DEXProfileForPublishing preparePUBLISHED_DEXReleaseForPublishing preparePUBLISHED_JAVA_RESDebugAndroidTestForPublishing preparePUBLISHED_JAVA_RESDebugForPublishing preparePUBLISHED_JAVA_RESProfileForPublishing preparePUBLISHED_JAVA_RESReleaseForPublishing preparePUBLISHED_NATIVE_LIBSDebugAndroidTestForPublishing preparePUBLISHED_NATIVE_LIBSDebugForPublishing preparePUBLISHED_NATIVE_LIBSProfileForPublishing preparePUBLISHED_NATIVE_LIBSReleaseForPublishing preProfileBuild preProfileUnitTestBuild preReleaseBuild preReleaseUnitTestBuild processDebugAndroidTestJavaRes processDebugAndroidTestManifest processDebugAndroidTestResources processDebugJavaRes processDebugManifest processDebugResources processDebugUnitTestJavaRes processProfileJavaRes processProfileManifest processProfileResources processProfileUnitTestJavaRes processReleaseJavaRes processReleaseManifest processReleaseResources processReleaseUnitTestJavaRes reportBuildArtifactsDebug reportBuildArtifactsProfile reportBuildArtifactsRelease resolveConfigAttr splitsDiscoveryTaskDebug splitsDiscoveryTaskProfile splitsDiscoveryTaskRelease transformClassesWithDesugarForDebug transformClassesWithDesugarForDebugAndroidTest transformClassesWithDesugarForProfile transformClassesWithDesugarForRelease transformClassesWithDexBuilderForDebug transformClassesWithDexBuilderForDebugAndroidTest transformClassesWithDexBuilderForProfile transformClassesWithDexBuilderForRelease transformClassesWithStackFramesFixerForDebug transformClassesWithStackFramesFixerForDebugAndroidTest transformClassesWithStackFramesFixerForProfile transformClassesWithStackFramesFixerForRelease transformDexArchiveWithDexMergerForDebug transformDexArchiveWithDexMergerForDebugAndroidTest transformDexArchiveWithDexMergerForProfile transformDexArchiveWithDexMergerForRelease transformDexArchiveWithExternalLibsDexMergerForDebug transformDexArchiveWithExternalLibsDexMergerForDebugAndroidTest transformDexArchiveWithExternalLibsDexMergerForProfile transformDexArchiveWithExternalLibsDexMergerForRelease transformNativeLibsWithMergeJniLibsForDebug transformNativeLibsWithMergeJniLibsForDebugAndroidTest transformNativeLibsWithMergeJniLibsForProfile transformNativeLibsWithMergeJniLibsForRelease transformResourcesWithMergeJavaResForDebug transformResourcesWithMergeJavaResForDebugAndroidTest transformResourcesWithMergeJavaResForDebugUnitTest transformResourcesWithMergeJavaResForProfile transformResourcesWithMergeJavaResForProfileUnitTest transformResourcesWithMergeJavaResForRelease transformResourcesWithMergeJavaResForReleaseUnitTest validateSigningDebug validateSigningDebugAndroidTest validateSigningProfile validateSigningRelease writeDebugApplicationId writeProfileApplicationId writeReleaseApplicationId Rules ----- Pattern: clean<TaskName>: Cleans the output files of a task. Pattern: build<ConfigurationName>: Assembles the artifacts of a configuration. Pattern: upload<ConfigurationName>: Assembles and uploads the artifacts belonging to a configuration. BUILD SUCCESSFUL in 2s 1 actionable task: 1 executed [ +9 ms] Resolving dependencies... (completed in 7.0s) [ +4 ms] executing: C:\Users\marc\AppData\Local\Android\sdk\build-tools\29.0.2\aapt dump xmltree U:\medium_splash_tokenauth\build\app\outputs\apk\app.apk AndroidManifest.xml [ +100 ms] Exit code 0 from: C:\Users\marc\AppData\Local\Android\sdk\build-tools\29.0.2\aapt dump xmltree U:\medium_splash_tokenauth\build\app\outputs\apk\app.apk AndroidManifest.xml [ +1 ms] N: android=http://schemas.android.com/apk/res/android E: manifest (line=2) A: android:versionCode(0x0101021b)=(type 0x10)0x1 A: android:versionName(0x0101021c)="1.0.0" (Raw: "1.0.0") A: package="com.androidfactorem.splashtokenauth" (Raw: "com.androidfactorem.splashtokenauth") E: uses-sdk (line=7) A: android:minSdkVersion(0x0101020c)=(type 0x10)0x10 A: android:targetSdkVersion(0x01010270)=(type 0x10)0x1b E: uses-permission (line=16) A: android:name(0x01010003)="android.permission.INTERNET" (Raw: "android.permission.INTERNET") E: application (line=24) A: android:label(0x01010001)="splash_tokenauth" (Raw: "splash_tokenauth") A: android:icon(0x01010002)=@0x7f080000 A: android:name(0x01010003)="io.flutter.app.FlutterApplication" (Raw: "io.flutter.app.FlutterApplication") A: android:debuggable(0x0101000f)=(type 0x12)0xffffffff A: android:appComponentFactory(0x0101057a)="android.support.v4.app.CoreComponentFactory" (Raw: "android.support.v4.app.CoreComponentFactory") E: activity (line=30) A: android:theme(0x01010000)=@0x7f0a0000 A: android:name(0x01010003)="com.androidfactorem.splashtokenauth.MainActivity" (Raw: "com.androidfactorem.splashtokenauth.MainActivity") A: android:launchMode(0x0101001d)=(type 0x10)0x1 A: android:configChanges(0x0101001f)=(type 0x11)0x400035b4 A: android:windowSoftInputMode(0x0101022b)=(type 0x11)0x10 A: android:hardwareAccelerated(0x010102d3)=(type 0x12)0xffffffff E: meta-data (line=44) A: android:name(0x01010003)="io.flutter.app.android.SplashScreenUntilFirstFrame" (Raw: "io.flutter.app.android.SplashScreenUntilFirstFrame") A: android:value(0x01010024)=(type 0x12)0xffffffff E: intent-filter (line=48) E: action (line=49) A: android:name(0x01010003)="android.intent.action.MAIN" (Raw: "android.intent.action.MAIN") E: category (line=51) A: android:name(0x01010003)="android.intent.category.LAUNCHER" (Raw: "android.intent.category.LAUNCHER") E: activity (line=54) A: android:theme(0x01010000)=@0x01030007 A: android:name(0x01010003)="io.flutter.plugins.urllauncher.UrlLauncherPlugin$WebViewActivity" (Raw: "io.flutter.plugins.urllauncher.UrlLauncherPlugin$WebViewActivity") A: android:exported(0x01010010)=(type 0x12)0x0 [ +5 ms] executing: C:\Users\marc\AppData\Local\Android\sdk\platform-tools\adb.exe -s emulator-5554 shell -x logcat -v time -t 1 [ +149 ms] Exit code 0 from: C:\Users\marc\AppData\Local\Android\sdk\platform-tools\adb.exe -s emulator-5554 shell -x logcat -v time -t 1 [ +1 ms] --------- beginning of main 10-27 13:31:11.010 E/GnssHAL_GnssInterface( 1797): gnssSvStatusCb: b: input svInfo.flags is 8 [ +4 ms] executing: C:\Users\marc\AppData\Local\Android\sdk\platform-tools\adb.exe -s emulator-5554 shell -x logcat -v time [ +5 ms] executing: C:\Users\marc\AppData\Local\Android\sdk\platform-tools\adb.exe version [ +272 ms] Android Debug Bridge version 1.0.41 Version 29.0.4-5871666 Installed as C:\Users\marc\AppData\Local\Android\sdk\platform-tools\adb.exe [ +5 ms] executing: C:\Users\marc\AppData\Local\Android\sdk\platform-tools\adb.exe start-server [ +134 ms] Building APK [ +39 ms] Running Gradle task 'assembleDebug'... [ +1 ms] executing: [U:\medium_splash_tokenauth\android\] U:\medium_splash_tokenauth\android\gradlew.bat -Pverbose=true -Ptarget=U:\medium_splash_tokenauth\lib\main.dart -Ptrack-widget-creation=false -Pfilesystem-scheme=org-dartlang-root -Ptarget-platform=android-x64 assembleDebug [+8322 ms] :app:compileFlutterBuildDebugX64 [ +1 ms] [ +29 ms] executing: [C:\src\flutter\] git -c log.showSignature=false log -n 1 --pretty=format:%H [ +112 ms] [ +118 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H [ +1 ms] [ ] e70236e36ce1d32067dc68eb55519ec3e14b6b01 [ +1 ms] [ ] executing: [C:\src\flutter\] git describe --match v*.*.* --first-parent --long --tags [ +117 ms] [ +119 ms] Exit code 0 from: git describe --match v*.*.* --first-parent --long --tags [ +1 ms] [ ] v1.10.7-0-ge70236e36 [ +1 ms] [ +5 ms] executing: [C:\src\flutter\] git rev-parse --abbrev-ref --symbolic @{u} [ +95 ms] [ +98 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u} [ +1 ms] [ ] origin/beta [ +1 ms] [ ] executing: [C:\src\flutter\] git ls-remote --get-url origin [ +95 ms] [ +92 ms] Exit code 0 from: git ls-remote --get-url origin [ +1 ms] [ ] https://github.com/flutter/flutter.git [ +118 ms] [ +119 ms] executing: [C:\src\flutter\] git rev-parse --abbrev-ref HEAD [ +97 ms] [ +96 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD [ +1 ms] [ ] beta [ +20 ms] [ +21 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update. [ +4 ms] [ ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update. [ ] [ ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update. [ ] [ ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update. [ ] [ ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update. [ ] [ +5 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update. [ ] [ ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update. [ ] [ ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update. [ ] [ ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update. [ ] [ ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update. [ ] [ ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update. [ +99 ms] [ +113 ms] Found plugin shared_preferences at C:\Users\marc\AppData\Roaming\Pub\Cache\hosted\pub.dartlang.org\shared_preferences-0.4.2\ [ +32 ms] [ +23 ms] Found plugin url_launcher at C:\Users\marc\AppData\Roaming\Pub\Cache\hosted\pub.dartlang.org\url_launcher-3.0.3\ [ +120 ms] [ +124 ms] Found plugin shared_preferences at C:\Users\marc\AppData\Roaming\Pub\Cache\hosted\pub.dartlang.org\shared_preferences-0.4.2\ [ +21 ms] [ +20 ms] Found plugin url_launcher at C:\Users\marc\AppData\Roaming\Pub\Cache\hosted\pub.dartlang.org\url_launcher-3.0.3\ [ +109 ms] [ +106 ms] Initializing file store [ +21 ms] [ +22 ms] Done initializing file store [ +951 ms] [ +957 ms] Persisting file store [ +32 ms] [ +27 ms] Done persisting file store [ +1 ms] [ ] UNC\nuctux\cupboard_manager\medium_splash_tokenauth\.packages were declared as an inputs, but did not exist. Check the definition of target:kernel_snapshot for errors [ +1 ms] [ +1 ms] #0 Node.computeChanges (package:flutter_tools/src/build_system/build_system.dart:772:7) [ ] <asynchronous suspension> [ ] #1 _BuildInstance._invokeInternal (package:flutter_tools/src/build_system/build_system.dart:518:20) [ ] <asynchronous suspension> [ +2 ms] #2 _BuildInstance.invokeTarget.<anonymous closure> (package:flutter_tools/src/build_system/build_system.dart:482:35) [ ] #3 new Future.sync (dart:async/future.dart:224:31) [ ] #4 AsyncMemoizer.runOnce (package:async/src/async_memoizer.dart:43:45) [ ] #5 _BuildInstance.invokeTarget (package:flutter_tools/src/build_system/build_system.dart:482:21) [ +1 ms] <asynchronous suspension> [ ] <asynchronous suspension> [ +1 ms] #6 BuildSystem.build (package:flutter_tools/src/build_system/build_system.dart:420:36) [ ] #7 _AsyncAwaitCompleter.start (dart:async-patch/async_patch.dart:43:6) [ ] #8 BuildSystem.build (package:flutter_tools/src/build_system/build_system.dart:401:28) [ ] #9 buildWithAssemble (package:flutter_tools/src/bundle.dart:171:48) [ +1 ms] #10 _AsyncAwaitCompleter.start (dart:async-patch/async_patch.dart:43:6) [ ] #11 buildWithAssemble (package:flutter_tools/src/bundle.dart:147:31) [ ] #12 BundleBuilder.build (package:flutter_tools/src/bundle.dart:85:13) [ ] #13 _AsyncAwaitCompleter.start (dart:async-patch/async_patch.dart:43:6) [ ] #14 BundleBuilder.build (package:flutter_tools/src/bundle.dart:58:21) [ +1 ms] #15 BuildBundleCommand.runCommand (package:flutter_tools/src/commands/build_bundle.dart:126:25) [ +1 ms] #16 _AsyncAwaitCompleter.start (dart:async-patch/async_patch.dart:43:6) [ +2 ms] #17 BuildBundleCommand.runCommand (package:flutter_tools/src/commands/build_bundle.dart:97:42) [ ] #18 FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:553:18) [ ] #19 _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:71:64) [ ] #20 _rootRunUnary (dart:async/zone.dart:1132:38) [ ] #21 _CustomZone.runUnary (dart:async/zone.dart:1029:19) [ ] #22 _FutureListener.handleValue (dart:async/future_impl.dart:137:18) [ ] #23 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:678:45) [ ] #24 Future._propagateToListeners (dart:async/future_impl.dart:707:32) [ +2 ms] #25 Future._completeWithValue (dart:async/future_impl.dart:522:5) [ ] #26 Future._asyncComplete.<anonymous closure> (dart:async/future_impl.dart:552:7) [ +1 ms] #27 _rootRun (dart:async/zone.dart:1124:13) [ ] #28 _CustomZone.run (dart:async/zone.dart:1021:19) [ ] #29 _CustomZone.runGuarded (dart:async/zone.dart:923:7) [ ] #30 _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:963:23) [ ] #31 _microtaskLoop (dart:async/schedule_microtask.dart:41:21) [ ] #32 _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5) [ ] #33 _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:116:13) [ ] #34 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:173:5) [ ] Failed to build bundle. [ ] #0 throwToolExit (package:flutter_tools/src/base/common.dart:28:3) [ +2 ms] #1 buildWithAssemble (package:flutter_tools/src/bundle.dart:178:5) [ +1 ms] <asynchronous suspension> [ ] #2 BundleBuilder.build (package:flutter_tools/src/bundle.dart:85:13) [ ] <asynchronous suspension> [ ] #3 BuildBundleCommand.runCommand (package:flutter_tools/src/commands/build_bundle.dart:126:25) [ ] <asynchronous suspension> [ ] #4 FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:553:18) [ ] <asynchronous suspension> [ ] #5 FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:457:33) [ ] <asynchronous suspension> [ ] #6 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:157:29) [ ] <asynchronous suspension> [ +7 ms] [ +5 ms] "flutter bundle" took 1’523ms. [ +1 ms] #7 _rootRun (dart:async/zone.dart:1124:13) [ ] #8 _CustomZone.run (dart:async/zone.dart:1021:19) [ ] #9 _runZoned (dart:async/zone.dart:1516:10) [ ] #10 runZoned (dart:async/zone.dart:1463:12) [ +1 ms] #11 AppContext.run (package:flutter_tools/src/base/context.dart:156:18) [ ] <asynchronous suspension> [ +1 ms] #12 FlutterCommand.run (package:flutter_tools/src/runner/flutter_command.dart:446:20) [ ] #13 CommandRunner.runCommand (package:args/command_runner.dart:197:27) [ ] <asynchronous suspension> [ ] #14 FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:416:21) [ ] <asynchronous suspension> [ ] #15 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:157:29) [ ] <asynchronous suspension> [ ] #16 _rootRun (dart:async/zone.dart:1124:13) [ ] #17 _CustomZone.run (dart:async/zone.dart:1021:19) [ ] #18 _runZoned (dart:async/zone.dart:1516:10) [ ] #19 runZoned (dart:async/zone.dart:1463:12) [ ] #20 AppContext.run (package:flutter_tools/src/base/context.dart:156:18) [ +2 ms] <asynchronous suspension> [ ] #21 FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:367:19) [ +2 ms] <asynchronous suspension> [ ] #22 CommandRunner.run.<anonymous closure> (package:args/command_runner.dart:112:25) [ ] #23 new Future.sync (dart:async/future.dart:224:31) [ ] #24 CommandRunner.run (package:args/command_runner.dart:112:14) [ ] #25 FlutterCommandRunner.run (package:flutter_tools/src/runner/flutter_command_runner.dart:251:18) [ ] #26 run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:63:22) [ ] <asynchronous suspension> [ ] #27 _rootRun (dart:async/zone.dart:1124:13) [ ] #28 _CustomZone.run (dart:async/zone.dart:1021:19) [ +1 ms] #29 _runZoned (dart:async/zone.dart:1516:10) [ ] #30 runZoned (dart:async/zone.dart:1500:12) [ +1 ms] #31 run.<anonymous closure> (package:flutter_tools/runner.dart:61:18) [ ] <asynchronous suspension> [ ] #32 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:157:29) [ ] <asynchronous suspension> [ ] #33 _rootRun (dart:async/zone.dart:1124:13) [ ] #34 _CustomZone.run (dart:async/zone.dart:1021:19) [ ] #35 _runZoned (dart:async/zone.dart:1516:10) [ ] #36 runZoned (dart:async/zone.dart:1463:12) [ ] #37 AppContext.run (package:flutter_tools/src/base/context.dart:156:18) [ ] <asynchronous suspension> [ +3 ms] #38 runInContext (package:flutter_tools/src/context_runner.dart:63:24) [ ] <asynchronous suspension> [ +1 ms] #39 run (package:flutter_tools/runner.dart:50:10) [ ] #40 main (package:flutter_tools/executable.dart:65:9) [ ] <asynchronous suspension> [ ] #41 main (file:///C:/src/flutter/packages/flutter_tools/bin/flutter_tools.dart:8:3) [ ] #42 _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:303:32) [ ] #43 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:172:12) [ ] FAILURE: Build failed with an exception. [ ] * Where: [ ] Script 'C:\src\flutter\packages\flutter_tools\gradle\flutter.gradle' line: 787 [ ] * What went wrong: [ ] Execution failed for task ':app:compileFlutterBuildDebugX64'. [ +2 ms] :app:compileFlutterBuildDebugX64 FAILED [ ] 1 actionable task: 1 executed [ +1 ms] > Process 'command 'C:\src\flutter\bin\flutter.bat'' finished with non-zero exit value 1 [ ] * Try: [ ] Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights. [ +2 ms] * Get more help at https://help.gradle.org [ ] BUILD FAILED in 10s [ +460 ms] Running Gradle task 'assembleDebug'... (completed in 11.0s) [ +2 ms] "flutter run" took 20’996ms. Gradle task assembleDebug failed with exit code 1 #0 throwToolExit (package:flutter_tools/src/base/common.dart:28:3) #1 _buildGradleProjectV2 (package:flutter_tools/src/android/gradle.dart:896:5) <asynchronous suspension> #2 buildGradleProject (package:flutter_tools/src/android/gradle.dart:575:14) <asynchronous suspension> #3 _AndroidBuilderImpl.buildApk (package:flutter_tools/src/android/android_builder.dart:101:11) <asynchronous suspension> #4 AndroidDevice.startApp (package:flutter_tools/src/android/android_device.dart:513:28) <asynchronous suspension> #5 FlutterDevice.runHot (package:flutter_tools/src/resident_runner.dart:377:54) <asynchronous suspension> #6 HotRunner.run (package:flutter_tools/src/run_hot.dart:258:39) <asynchronous suspension> #7 RunCommand.runCommand (package:flutter_tools/src/commands/run.dart:481:37) <asynchronous suspension> #8 FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:553:18) <asynchronous suspension> #9 FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:457:33) <asynchronous suspension> #10 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:157:29) <asynchronous suspension> #11 _rootRun (dart:async/zone.dart:1124:13) #12 _CustomZone.run (dart:async/zone.dart:1021:19) #13 _runZoned (dart:async/zone.dart:1516:10) #14 runZoned (dart:async/zone.dart:1463:12) #15 AppContext.run (package:flutter_tools/src/base/context.dart:156:18) <asynchronous suspension> #16 FlutterCommand.run (package:flutter_tools/src/runner/flutter_command.dart:446:20) #17 CommandRunner.runCommand (package:args/command_runner.dart:197:27) <asynchronous suspension> #18 FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:416:21) <asynchronous suspension> #19 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:157:29) <asynchronous suspension> #20 _rootRun (dart:async/zone.dart:1124:13) #21 _CustomZone.run (dart:async/zone.dart:1021:19) #22 _runZoned (dart:async/zone.dart:1516:10) #23 runZoned (dart:async/zone.dart:1463:12) #24 AppContext.run (package:flutter_tools/src/base/context.dart:156:18) <asynchronous suspension> #25 FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:367:19) <asynchronous suspension> #26 CommandRunner.run.<anonymous closure> (package:args/command_runner.dart:112:25) #27 new Future.sync (dart:async/future.dart:224:31) #28 CommandRunner.run (package:args/command_runner.dart:112:14) #29 FlutterCommandRunner.run (package:flutter_tools/src/runner/flutter_command_runner.dart:251:18) #30 run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:63:22) <asynchronous suspension> #31 _rootRun (dart:async/zone.dart:1124:13) #32 _CustomZone.run (dart:async/zone.dart:1021:19) #33 _runZoned (dart:async/zone.dart:1516:10) #34 runZoned (dart:async/zone.dart:1500:12) #35 run.<anonymous closure> (package:flutter_tools/runner.dart:61:18) <asynchronous suspension> #36 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:157:29) <asynchronous suspension> #37 _rootRun (dart:async/zone.dart:1124:13) #38 _CustomZone.run (dart:async/zone.dart:1021:19) #39 _runZoned (dart:async/zone.dart:1516:10) #40 runZoned (dart:async/zone.dart:1463:12) #41 AppContext.run (package:flutter_tools/src/base/context.dart:156:18) <asynchronous suspension> #42 runInContext (package:flutter_tools/src/context_runner.dart:63:24) <asynchronous suspension> #43 run (package:flutter_tools/runner.dart:50:10) #44 main (package:flutter_tools/executable.dart:65:9) <asynchronous suspension> #45 main (file:///C:/src/flutter/packages/flutter_tools/bin/flutter_tools.dart:8:3) #46 _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:303:32) #47 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:172:12) ``` <!-- Run `flutter analyze` and attach any output of that command below. If there are any analysis errors, try resolving them before filing this issue. --> ``` Analyzing medium_splash_tokenauth... error - Target of URI doesn't exist: 'package:splash_tokenauth/common/functions/saveCurrentLogin.dart' - lib\common\apifunctions\requestLoginAPI.dart:5:8 - uri_does_not_exist error - Target of URI doesn't exist: 'package:splash_tokenauth/common/functions/showDialogSingleButton.dart' - lib\common\apifunctions\requestLoginAPI.dart:6:8 - uri_does_not_exist error - Target of URI doesn't exist: 'package:splash_tokenauth/model/json/loginModel.dart' - lib\common\apifunctions\requestLoginAPI.dart:9:8 - uri_does_not_exist error - The name 'LoginModel' isn't a type so it can't be used as a type argument - lib\common\apifunctions\requestLoginAPI.dart:11:8 - non_type_as_type_argument info - The value of the local variable 'user' isn't used - lib\common\apifunctions\requestLoginAPI.dart:26:9 - unused_local_variable error - Undefined class 'LoginModel.fromJson' - lib\common\apifunctions\requestLoginAPI.dart:26:20 - undefined_class error - The function 'saveCurrentLogin' isn't defined - lib\common\apifunctions\requestLoginAPI.dart:28:5 - undefined_function error - Undefined name 'LoginModel' - lib\common\apifunctions\requestLoginAPI.dart:31:12 - undefined_identifier error - The function 'saveCurrentLogin' isn't defined - lib\common\apifunctions\requestLoginAPI.dart:35:5 - undefined_function error - The function 'showDialogSingleButton' isn't defined - lib\common\apifunctions\requestLoginAPI.dart:36:5 - undefined_function error - Target of URI doesn't exist: 'package:splash_tokenauth/common/functions/getToken.dart' - lib\common\apifunctions\requestLogoutAPI.dart:7:8 - uri_does_not_exist error - Target of URI doesn't exist: 'package:splash_tokenauth/common/functions/saveLogout.dart' - lib\common\apifunctions\requestLogoutAPI.dart:8:8 - uri_does_not_exist error - Target of URI doesn't exist: 'package:splash_tokenauth/model/json/loginModel.dart' - lib\common\apifunctions\requestLogoutAPI.dart:9:8 - uri_does_not_exist error - The name 'LoginModel' isn't a type so it can't be used as a type argument - lib\common\apifunctions\requestLogoutAPI.dart:11:8 - non_type_as_type_argument error - The function 'getToken' isn't defined - lib\common\apifunctions\requestLogoutAPI.dart:16:9 - undefined_function error - The function 'saveLogout' isn't defined - lib\common\apifunctions\requestLogoutAPI.dart:26:5 - undefined_function error - The function 'saveLogout' isn't defined - lib\common\apifunctions\requestLogoutAPI.dart:29:5 - undefined_function info - 'await' applied to 'String', which is not a 'Future' - lib\common\functions\getToken.dart:8:21 - await_only_futures error - Target of URI doesn't exist: 'package:splash_tokenauth/model/json/loginModel.dart' - lib\common\functions\saveCurrentLogin.dart:4:8 - uri_does_not_exist info - Use `isNotEmpty` for Iterables and Maps - lib\common\functions\saveCurrentLogin.dart:11:32 - prefer_is_not_empty error - Undefined name 'LoginModel' - lib\common\functions\saveCurrentLogin.dart:12:12 - undefined_identifier info - Use `isNotEmpty` for Iterables and Maps - lib\common\functions\saveCurrentLogin.dart:16:40 - prefer_is_not_empty error - Undefined name 'LoginModel' - lib\common\functions\saveCurrentLogin.dart:16:65 - undefined_identifier info - Use `isNotEmpty` for Iterables and Maps - lib\common\functions\saveCurrentLogin.dart:17:40 - prefer_is_not_empty error - Undefined name 'LoginModel' - lib\common\functions\saveCurrentLogin.dart:17:65 - undefined_identifier info - Use `isNotEmpty` for Iterables and Maps - lib\common\functions\saveCurrentLogin.dart:18:37 - prefer_is_not_empty error - Undefined name 'LoginModel' - lib\common\functions\saveCurrentLogin.dart:18:62 - undefined_identifier error - Target of URI doesn't exist: 'package:splash_tokenauth/common/apifunctions/requestLogoutAPI.dart' - lib\common\widgets\basicDrawer.dart:3:8 - uri_does_not_exist error - The method 'requestLogoutAPI' isn't defined for the class '_BasicDrawerState' - lib\common\widgets\basicDrawer.dart:29:15 - undefined_method error - Target of URI doesn't exist: 'package:splash_tokenauth/ui/homeScreen.dart' - lib\main.dart:3:8 - uri_does_not_exist error - Target of URI doesn't exist: 'package:splash_tokenauth/ui/loginScreen.dart' - lib\main.dart:4:8 - uri_does_not_exist error - Target of URI doesn't exist: 'package:splash_tokenauth/ui/splashScreen.dart' - lib\main.dart:5:8 - uri_does_not_exist info - This class (or a class which this class inherits from) is marked as '@immutable', but one or more of its instance fields are not final: MyApp._splashShown - lib\main.dart:9:7 - must_be_immutable info - The value of the field '_splashShown' isn't used - lib\main.dart:11:7 - unused_field error - The method 'HomeScreen' isn't defined for the class 'MyApp' - lib\main.dart:18:50 - undefined_method error - The method 'LoginScreen' isn't defined for the class 'MyApp' - lib\main.dart:19:51 - undefined_method error - The method 'SplashScreen' isn't defined for the class 'MyApp' - lib\main.dart:22:7 - undefined_method info - Unused import: 'package:flutter/services.dart' - lib\ui\homeScreen.dart:2:8 - unused_import info - Unused import: 'dart:io' - lib\ui\homeScreen.dart:3:8 - unused_import error - Target of URI doesn't exist: 'package:splash_tokenauth/common/platform/platformScaffold.dart' - lib\ui\homeScreen.dart:6:8 - uri_does_not_exist error - Target of URI doesn't exist: 'package:splash_tokenauth/common/widgets/basicDrawer.dart' - lib\ui\homeScreen.dart:7:8 - uri_does_not_exist error - The method 'PlatformScaffold' isn't defined for the class '_HomeScreenState' - lib\ui\homeScreen.dart:30:12 - undefined_method error - The method 'BasicDrawer' isn't defined for the class '_HomeScreenState' - lib\ui\homeScreen.dart:38:7 - undefined_method error - Target of URI doesn't exist: 'package:splash_tokenauth/common/apifunctions/requestLoginAPI.dart' - lib\ui\loginScreen.dart:5:8 - uri_does_not_exist error - Target of URI doesn't exist: 'package:splash_tokenauth/common/functions/showDialogSingleButton.dart' - lib\ui\loginScreen.dart:6:8 - uri_does_not_exist error - Target of URI doesn't exist: 'package:splash_tokenauth/common/platform/platformScaffold.dart' - lib\ui\loginScreen.dart:7:8 - uri_does_not_exist error - Target of URI doesn't exist: 'package:splash_tokenauth/common/widgets/basicDrawer.dart' - lib\ui\loginScreen.dart:8:8 - uri_does_not_exist info - Unused import: 'package:http/http.dart' - lib\ui\loginScreen.dart:13:8 - unused_import info - The value of the field '_welcomeString' isn't used - lib\ui\loginScreen.dart:29:10 - unused_field error - The method 'showDialogSingleButton' isn't defined for the class 'LoginScreenState' - lib\ui\loginScreen.dart:35:7 - undefined_method info - The value of the local variable 'drawer' isn't used - lib\ui\loginScreen.dart:52:9 - unused_local_variable info - This function has a return type of 'Future<bool>', but doesn't end with a return statement - lib\ui\loginScreen.dart:54:18 - missing_return error - The method 'PlatformScaffold' isn't defined for the class 'LoginScreenState' - lib\ui\loginScreen.dart:64:7 - undefined_method error - The method 'BasicDrawer' isn't defined for the class 'LoginScreenState' - lib\ui\loginScreen.dart:65:17 - undefined_method error - The method 'requestLoginAPI' isn't defined for the class 'LoginScreenState' - lib\ui\loginScreen.dart:152:27 - undefined_method info - Unused import: 'dart:io' - lib\ui\splashScreen.dart:2:8 - unused_import error - Target of URI doesn't exist: 'package:splash_tokenauth/common/platform/platformScaffold.dart' - lib\ui\splashScreen.dart:5:8 - uri_does_not_exist error - The method 'PlatformScaffold' isn't defined for the class '_SplashScreenState' - lib\ui\splashScreen.dart:37:12 - undefined_method error - Target of URI doesn't exist: 'package:splash_tokenauth/main.dart' - test\widget_test.dart:10:8 - uri_does_not_exist error - The constructor returns type 'dynamic' that isn't of expected type 'Widget' - test\widget_test.dart:15:29 - invalid_cast_new_expr error - Undefined class 'MyApp' - test\widget_test.dart:15:33 - undefined_class 61 issues found. (ran in 17.2s) ``` <!-- Finally, paste the output of running `flutter doctor -v` here. --> ``` [√] Flutter (Channel beta, v1.10.7, on Microsoft Windows [Version 10.0.18362.418], locale de-CH) • Flutter version 1.10.7 at C:\src\flutter • Framework revision e70236e36c (4 weeks ago), 2019-10-02 09:32:30 -0700 • Engine revision 9e6314d348 • Dart version 2.6.0 (build 2.6.0-dev.4.0 1103600280) [√] Android toolchain - develop for Android devices (Android SDK version 29.0.2) • Android SDK at C:\Users\marc\AppData\Local\Android\sdk • Android NDK location not configured (optional; useful for native profiling support) • Platform android-29, build-tools 29.0.2 • Java binary at: C:\Program Files\Android\Android Studio1\jre\bin\java • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03) • All Android licenses accepted. [√] Android Studio (version 3.5) • Android Studio at C:\Program Files\Android\Android Studio1 • Flutter plugin version 40.2.2 • Dart plugin version 191.8593 • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03) [√] IntelliJ IDEA Community Edition (version 2017.3) • IntelliJ at C:\Users\marc\AppData\Local\JetBrains\Toolbox\apps\IDEA-C\ch-0\173.3622.25 • Flutter plugin version 29.0.1 • Dart plugin version 173.3622.29 [√] IntelliJ IDEA Community Edition (version 2019.2) • IntelliJ at C:\Users\marc\AppData\Local\JetBrains\Toolbox\apps\IDEA-C\ch-0\192.6262.9 • Flutter plugin version 40.2.3 • Dart plugin version 192.7402 [√] Connected device (1 available) • Android SDK built for x86 64 • emulator-5554 • android-x64 • Android 10 (API 29) (emulator) • No issues found! ```
tool,t: gradle,a: build,P2,team-tool,triaged-tool
low
Critical
512,969,228
rust
Slightly confusing grammar in pinning docs.
Hi, I've just read the `std::pin` docs as part of learning `std::future::Future` and attempting to write my own combinator. This section is pretty dense for my first read, and only at the very end, when it mentioned `Future` combinators did I realize I had a misunderstanding through the entire reading due to [this phrase](https://github.com/rust-lang/rust/blob/625451e376bb2e5283fc4741caa0a3e8a2ca4d54/src/libcore/pin.rs#L211) in the projections section ([link to rendered docs](https://doc.rust-lang.org/std/pin/#projections-and-structural-pinning)): > every field can be either projected to a pinned reference, or have pinning removed as part of the projection At the end, the sentence that made me realize I had a misunderstanding [is here](https://github.com/rust-lang/rust/blob/625451e376bb2e5283fc4741caa0a3e8a2ca4d54/src/libcore/pin.rs#L338-L341): > But if your combinator contains any other data that does not need to be pinned, you can make those fields not structural and hence freely access them with a mutable reference even when you just have Pin<&mut Self> (such as in your own poll implementation). My misunderstanding, on reading the first quote, was to believe that if any field is a pinned projection, then all other fields must also be pinned projections, or if any field is not, all other fields must not be. For me, if the first phrase said this instead, I think it would be clearer: > each field can either be projected to a pinned reference, or have pinning removed as part of the projection. I'm a native English speaker, and I'm still not sure if the difference between my suggestion and the current text implies the technical difference I intend here, and I'm not sure if other readers might encounter a similar confusion. (Technical writing is hard!) To really drive it home, maybe append the following sentence: > Fields may be projected to pinned or unpinned references independent of other fields. I hope this helps make it easier for first-time readers to understand the projections and structural pinning section a bit better. Thanks for your effort! ps: Rust is awesome, and the core/std docs are excellent. ;-)
C-enhancement,T-libs-api,A-docs
low
Minor
512,969,962
go
cmd/compile: no closure inlining even in the simple case?
I hesitate to call this an issue, since I know it's a complex topic, and I've read about half a dozen issue reports touching this topic, which kind-of sort-of fix some inlining cases, but not all of them. I'm using a simple pattern for avoiding lock leakage: ```go // WithRWMutex extends the RWMutex type with convenient .With(func) functions type WithRWMutex struct { sync.RWMutex } // WithRLock executes the given function with the mutex rlocked func (m *WithRWMutex) WithRLock(f func()) { m.RWMutex.RLock() f() m.RWMutex.RUnlock() } // WithWLock executes the given function with the mutex wlocked func (m *WithRWMutex) WithWLock(f func()) { m.RWMutex.Lock() f() m.RWMutex.Unlock() } ``` in practice it's used like this: ```go beforeCode() o.WithWLock(func() { doSomething(o) }) afterCode() ``` Full example here: https://go.godbolt.org/z/mkvMbZ I'd expect that when the closure passed to `WithWlock()` is simple enough (i.e. no need for a new stack), inlining would collapse all the scaffolding and compile it to something like: ```go beforeCode() m.RWMutex.Lock() doSomething(o) m.RWMutex.Unlock() afterCode() ``` But looking at the assembly code (https://go.godbolt.org/z/mkvMbZ), the inner function is compiled once, its address taken, passed to the `WithWLock()` function, i.e. a full closure call is being done. This is on go 1.13. It seems that a full closure call is an expensive choice for this particular pattern?
Performance,NeedsInvestigation,compiler/runtime
low
Major
512,974,863
flutter
[webview_flutter] Add option to allow mixed-mode content (http in https page)
Internal: b/292548371 webview_flutter how to load https and http mixed content?
c: new feature,customer: dream (g3),customer: crowd,p: webview,package,team-ecosystem,P2,triaged-ecosystem
low
Critical
512,988,529
pytorch
cmake allows both MKL and MKLDNN to be OFF; aten/src/ATen/CMakeLists.txt then ignores c++ sources
This file has ``` if(AT_MKL_ENABLED) set(all_cpu_cpp ${all_cpu_cpp} ${mkl_cpp}) endif() if(AT_MKLDNN_ENABLED) set(all_cpu_cpp ${all_cpu_cpp} ${mkldnn_cpp}) endif() ``` which ignores ```${all_cpu_cpp}``` when none of ```AT_MKL_ENABLED``` and ```AT_MKLDNN_ENABLED``` are defined. There are two bugs: 1. The above code should be ```if() ... else if() .... else ERROR(no mkll defined) endif``` 2. The top-level cmake file should disallow having both ```AT_MKL_ENABLED``` and ```AT_MKLDNN_ENABLED``` be ```OFF```.
module: build,triaged
low
Critical
512,989,275
rust
Missed optimization: fn f(a: &mut i32){ let b = *a; println!("{}", b); }
This Rust code: https://godbolt.org/z/HeLrx- gives more assembly than this: https://godbolt.org/z/Aji2U3
I-slow,C-enhancement,T-compiler,C-optimization
low
Minor
512,991,982
rust
wasm32-unknown-unknown target should not make output executable
The wasm32-unknown-unknown target sets the executable bit on the compiled `.wasm` file. Most uses of wasm don't execute the wasm file directly, and without special configuration (such as binfmt-misc on Linux), most operating systems can't directly run wasm files. Furthermore, the executable bit set on the output tends to get checked into git repositories. For the wasm32-unknown-unknown target, we should not set the executable bit on the output file.
C-enhancement,T-compiler,O-wasm
low
Minor
512,992,963
pytorch
[feature request] Docs for fuse_conv_bn_eval
Even if it is internal/experimental, it's quite useful for end users as well. Curently [`fuse_conv_bn_weights`](https://github.com/pytorch/pytorch/blob/master/torch/nn/utils/fusion.py#L22) assumes 2d convolution and hard-codes 4-dim weights, which is not true for Conv1d/Conv3d. However it's easy to support any dimension: ```python # conv_w = conv_w * (bn_w * bn_var_rsqrt).reshape([-1, 1, 1, 1]) conv_w = conv_w * (bn_w * bn_var_rsqrt).reshape([-1] + [1] * (len(conv_w.shape) - 1)) ```
module: docs,triaged
low
Minor
513,009,433
pytorch
torch.tensor() is very slow when it is passed an h5py Dataset.
## 🐛 Bug `torch.tensor()` is very slow when it is passed an h5py Dataset. ## To Reproduce Create a new HDF5 file with a 1000x1000 float32 dataset: ```python import h5py import numpy as np import torch testfile = h5py.File('testfile.h5', 'w') testfile['data'] = torch.eye(1000) ``` Then load it back into a Tensor: ``` >>> %timeit torch.tensor(testfile['data']) 421 ms ± 28.2 ms per loop (mean ± std. dev. of 7 runs, 1 loop each) ``` It's very slow. However, if the dataset is converted into a NumPy array first, it performs much faster: ``` >>> %timeit torch.tensor(np.array(testfile['data'])) 2.84 ms ± 162 µs per loop (mean ± std. dev. of 7 runs, 100 loops each) ``` The resulting tensors are equal. Perhaps the manual NumPy array conversion avoids an expensive conversion to a Python nested list of floats. cc @VitalyFedyunin @ngimel
module: performance,triaged,module: tensor creation
low
Critical
513,012,309
go
text/template: access to methods that are not part of interface
### What version of Go are you using (`go version`)? <pre> $ go version go version go1.13.3 linux/amd64 </pre> ### Does this issue reproduce with the latest release? Yes ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env GO111MODULE="" GOARCH="amd64" GOBIN="" GOCACHE="/home/vic/.cache/go-build" GOENV="/home/vic/.config/go/env" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="linux" GONOPROXY="" GONOSUMDB="" GOOS="linux" GOPATH="/home/vic/Go" GOPRIVATE="" GOPROXY="https://proxy.golang.org,direct" GOROOT="/usr/lib/go" GOSUMDB="sum.golang.org" GOTMPDIR="" GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64" GCCGO="gccgo" AR="ar" CC="gcc" CXX="g++" CGO_ENABLED="1" GOMOD="" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build611773016=/tmp/go-build -gno-record-gcc-switches" GOROOT/bin/go version: go version go1.13.3 linux/amd64 GOROOT/bin/go tool compile -V: compile version go1.13.3 uname -sr: Linux 5.3.6-arch1-1-ARCH LSB Version: 1.4 Distributor ID: Arch Description: Arch Linux Release: rolling Codename: n/a /usr/lib/libc.so.6: GNU C Library (GNU libc) stable release version 2.30. </pre></details> ### What did you do? I executed a `text/template.Template` with an interface as data. <details><summary>Example code</summary><br> ``` package main import ( "os" "text/template" ) type Foo struct { A int } func (f Foo) B() int { return 2 } func (f Foo) C() int { return 3 } type Bar interface { C() int } func main() { foo := Foo{A: 1} test(foo) } func test(bar Bar) { tpl := template.Must(template.New("template").Parse("{{ .A }} {{ .B }} {{ .C }}")) tpl.Execute(os.Stdout, bar) } ``` </details> On play: https://play.golang.org/p/YgMyBPie8kw ### What did you expect to see? My template is using functions that don't exist in the interface, thus I was expecting an error. ### What did you see instead? The template is able to execute functions on the underlying type, exposing functionality I don't want to expose. I believe the `text/template` package actually behaved as I would expect in the past. I think the functionality was changed in 167a7123997c42e91d69de2203fc4c156897f0a2.
NeedsInvestigation
low
Critical
513,027,058
react-native
Setting the value of a controlled TextInput breaks when autocorrect suggestion present
<!-- Please provide a clear and concise description of what the bug is. Include screenshots if needed. Please test using the latest React Native release to make sure your issue has not already been fixed: http://facebook.github.io/react-native/docs/upgrading.html --> On iOS, something wonky happens when the value of a `TextInput` is programmatically modified (via `setState` and the `value` property of said `TextInput`) and an autocorrect suggestion is present. The value of the text input ends up being set to the combination of the autocorrect suggestion and the programmatic value. ~This only happens when `multiline={true}`. When `multiline={false}`, all is fine.~ This seems only to be reproducible on iOS. ~I was not able to reproduce on the Snack iOS simulator.~ This can be reproduced using the software keyboard in the Snack iOS simulator with `multiline={true}`. The Snack iOS simulator does not reproduce with `multiline={false}`, but this does reproduce on a device. React Native version: 0.59-0.76 <!-- Run `react-native info` in your terminal and copy the results here. --> ## Steps To Reproduce 1. Start the reproducer: https://snack.expo.dev/@mhoran/trusting-peanut 2. Type "Yo mh" and wait for the auto-correct suggestion of "my" 3. Click "Bananas!" 5. Notice that the value set programmatically will become a combination of the autocorrect value and the programmatic value. <!-- Issues without reproduction steps or code are likely to stall. --> Describe what you expected to happen: I expected the value to be set to "Yo mhoran". Snack, code example, screenshot, or link to a repository: https://snack.expo.dev/@mhoran/trusting-peanut <!-- Please provide a Snack (https://snack.expo.io/), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem. You may provide a screenshot of the application if you think it is relevant to your bug report. Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve. -- -->
Platform: iOS,Issue: Author Provided Repro,Component: TextInput,Bug
medium
Critical
513,040,079
rust
Return value packing for Option<T> and Result<T,E> on WebAssembly
I'm looking at how `Result<T,E>` and `Option<T>` return values get handled on the WebAssembly target, using integral types as the `T` and small fieldless enums as the `E` type. It seems hard to predict when Rust will use stack allocation for the return value, and some optimizations that happen on native platforms like x86-64 Linux aren't happening where I expect them. (I'm aware that internal Rust ABIs are unstable, but it'd nice to be able to reason about performance on critical paths, so I'm checking this out in detail before building a pipeline that depends on Results or Options in a tight interpreter loop.) Tested some example code like: ```rust // A small enum to annotate error conditions #[derive(Copy, Clone, Debug)] pub enum MyErr { PageFault, IllegalInstruction, Halt } #[inline(never)] pub fn result_u16(i: u64) -> Result<u16, MyErr> { if i < 50 { Ok(i as u16) } else { Err(MyErr::IllegalInstruction) } } #[inline(never)] pub fn option_u16(i: u64) -> Option<u16> { if i < 50 { Some(i as u16) } else { None } } ``` with similar variants for u8, u16, u32, and u64 returns. The `MyErr` enum is small enough to fit in less than a byte itself for `Result` returns. On a Linux or macOS x86-64 build (with the benefit of having native support for two return values in registers) I get: * option_u8 returns two words in AL (discriminant) and EDX (payload) * option_u16 returns two words in AL (discriminant) and EDX (payload) * option_u32 returns two words in AL (discriminant) and EDX (payload) * option_u64 returns two words in AL (discriminant) and RDX (payload) * result_u8 returns two words in AL(discriminant) and EDX (payload) * result_u16 returns a packed 32-bit word in EAX, with Ok payload in the top 16 bits * result_u32 returns a packed 64-bit word in RAX, with Ok payload in the top 32 bits * result_u64 returns on stack On a WebAssembly build, I get: * option_u8 returns on stack * option_u16 returns on stack * option_u32 returns on stack * option_u64 returns on stack * result_u8 returns on stack * result_u16 returns a packed 32-bit word, with Ok payload in the top 16 bits * result_u32 returns on stack * result_u64 returns on stack Couple big things surprised me here. First, while on native x86-64 `Option<T>` is well optimized using two registers, `Result<T,E>` doesn't consistently get the same treatment. Perhaps because conceptually the enum payload is a separate data byte and it complicates things? Second, none of the Option types get optimized into integral values on WebAssembly, where there's no multiple return value handling yet but return types up to 64 bits are available. Third, while `Result<u16,MyErr>` gets packed into a 32-bit word on WebAssembly, the `u8` version is not though it would fit handily in a 32-bit word too, nor is the `u32` version packed into a 64-bit word like on native. (There might be something weird with my u8 version, like it's optimizing out the MyErr or something.) As for `Result<u64,MyErr>`, that's using stack as expected. In summary, on WebAssembly: * It's hard to predict when enum structures will get packed into a register versus transferred through stack memory, making it harder to reason about performance. * `Option<T>` is not getting "register"-packed at any size, causing transfer of data through memory. * `Result<u8, MyErr>` and `Result<u32, MyErr>` should be packable into 32-bit and 64-bit return values, but are not. It's unclear why. * `Result<u64, MyErr>` as stack transfer remains optimal until some future day when WebAssembly gains multiple return values. Thanks for any advice or explanations!
I-slow,C-enhancement,A-codegen,T-compiler,O-wasm
low
Critical
513,055,308
godot
FileSystem panel loses focus after Renaming or Duplicating files
**Godot version:** 3.2.alpha 35944aebdeb4c3b5869aaeedaaded02397b7ce92 **OS/device including version:** 5.3.7.arch1-1 **Issue description:** Deleting, renaming or duplicating a file in the FileSystem panel opens a prompt window. If you close this window while deleting a file (either by confirming the deletion or cancelling it) the FileSystem panel regains focus. This doesn't happen when duplicating or renaming a file. **edit:** [and it would be nice if it did.](https://github.com/godotengine/godot/issues/33126#issuecomment-547577403) **Steps to reproduce:** 1. Select a file in the FileSystem panel 2. Duplicate the file either by right-click -> Duplicate or the shortcut Ctrl+D 3. Type a new name and press Return(Enter) to confirm
bug,topic:editor,confirmed,usability
low
Major
513,059,365
kubernetes
for every huge page resource, we need to remove it from allocatable memory when Updating Node Allocatable limit across pods
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks! If the matter is security related, please disclose it privately via https://kubernetes.io/security/ --> **What happened**: In the code below, we remove huge page resource from allocatable memory when updating node status, but we doesn't remove huge page resource from allocatable memory when Updating Node Allocatable limit across pods we remove huge page resource from allocatable memory when updating node status. allocatableReservation := nodeAllocatableReservationFunc() for k, v := range node.Status.Capacity { value := *(v.Copy()) if res, exists := allocatableReservation[k]; exists { value.Sub(res) } if value.Sign() < 0 { // Negative Allocatable resources don't make sense. value.Set(0) } node.Status.Allocatable[k] = value } // for every huge page reservation, we need to remove it from allocatable memory for k, v := range node.Status.Capacity { if v1helper.IsHugePageResourceName(k) { allocatableMemory := node.Status.Allocatable[v1.ResourceMemory] value := *(v.Copy()) allocatableMemory.Sub(value) if allocatableMemory.Sign() < 0 { // Negative Allocatable resources don't make sense. allocatableMemory.Set(0) } node.Status.Allocatable[v1.ResourceMemory] = allocatableMemory } } we doesn't remove huge page resource from allocatable memory when Updating Node Allocatable limit across pods. // getNodeAllocatableAbsolute returns the absolute value of Node Allocatable which is primarily useful for enforcement. // Note that not all resources that are available on the node are included in the returned list of resources. // Returns a ResourceList. func (cm *containerManagerImpl) getNodeAllocatableAbsolute() v1.ResourceList { result := make(v1.ResourceList) for k, v := range cm.capacity { value := *(v.Copy()) if cm.NodeConfig.SystemReserved != nil { value.Sub(cm.NodeConfig.SystemReserved[k]) } if cm.NodeConfig.KubeReserved != nil { value.Sub(cm.NodeConfig.KubeReserved[k]) } if value.Sign() < 0 { // Negative Allocatable resources don't make sense. value.Set(0) } result[k] = value } return result } **What you expected to happen**: we should remove huge page resource from allocatable memory when Updating Node Allocatable limit across pods. **How to reproduce it (as minimally and precisely as possible)**: **Anything else we need to know?**: **Environment**: - Kubernetes version (use `kubectl version`): k8s 1.13.0
kind/bug,sig/node,triage/accepted
medium
Critical
513,071,464
scrcpy
Mirror as second screen
Hi, Developers. The latest scrcpy is working really fast and I am really thanks for that. Is it possible the mirrored screen in PC to act as second screen rather than exact copy of phone screen? I mean something like Miracast where some feature will be enabled when Android device connected to Miracast device. The example of apps is like VLC where phone screen become a remote control when connected to miracast device and show the movie on the second screen. The other is Google Presentation where phone screen become presenter display and the second screen shows the actual presentation. Best regards, Ryan
feature request,multiscreen
low
Major
513,083,997
rust
Replacing sentences for references by a Bibliography section for keywords
In the stdlib, at the end of each keyword description, authors add a small sentence with links to reference material. Here are the six first ones appearing in the keyword file: https://github.com/rust-lang/rust/blob/9733b0f122db7eb7662799b164bc02b0f54cb84a/src/libstd/keyword_docs.rs#L26 https://github.com/rust-lang/rust/blob/9733b0f122db7eb7662799b164bc02b0f54cb84a/src/libstd/keyword_docs.rs#L150 https://github.com/rust-lang/rust/blob/9733b0f122db7eb7662799b164bc02b0f54cb84a/src/libstd/keyword_docs.rs#L293 https://github.com/rust-lang/rust/blob/9733b0f122db7eb7662799b164bc02b0f54cb84a/src/libstd/keyword_docs.rs#L336 https://github.com/rust-lang/rust/blob/9733b0f122db7eb7662799b164bc02b0f54cb84a/src/libstd/keyword_docs.rs#L411 https://github.com/rust-lang/rust/blob/9733b0f122db7eb7662799b164bc02b0f54cb84a/src/libstd/keyword_docs.rs#L486 Beside the fact that they are inconsistent ("for more information", "for more details", "more details on", "see", "take a look", "check", "can be seen at"), the style itself feels heavy and goes against publishing standards. References are typically listed either in a "Reference list" or a "Bibliography". See https://intranet.birmingham.ac.uk/as/libraryservices/library/referencing/icite/harvard/referencelist.aspx. The two advantages of adopting this style immediately obvious: * consistent style, not only between keywords, but with sites widely used such as Wikipedia * reduce cognitive load for athors, trying to make up a small sentence to introduce references, especially when wanting to quote more than one. I propose that we use a "Bibliography" section and use it for bot references and additional material pertinant to the subject. Here's an example of an existing page, in its current version: ![current](https://user-images.githubusercontent.com/3446051/67650609-46d39400-f903-11e9-99c7-a278efeda62a.png) Replacing the "For more information..." sentence with a Blbliography section: ![with_bibliography](https://user-images.githubusercontent.com/3446051/67650608-463afd80-f903-11e9-9204-b1fab5909df2.png) Comments will be appreciated.
C-enhancement,T-libs-api,A-docs
low
Major
513,091,715
pytorch
cudnn.determinstic=True causes dilated convolution to be >10x slower
## 🐛 Bug If you set `torch.backends.cudnn.deterministic=True`, and then create and use a Conv2d layer, it's MUCH slower than if you use `torch.backends.cudnn.deterministic=False`. My tests found it to be between 10-80x slower. ## To Reproduce I wrote a timing script to see how much slower: ```python # dilated_test.py import time import torch import torch.nn as nn import sys B = int(sys.argv[1]) or 32 C = int(sys.argv[2]) or 64 det = bool(int(sys.argv[3])) or False dilation = int(sys.argv[4]) or 0 torch.backends.cudnn.deterministic=det inp = torch.rand((B, C, 32, 32), device='cuda:0') if dilation == 0: conv = nn.Conv2d(C, 64, 3, padding=1, stride=1).cuda() else: conv = nn.Conv2d(C, 64, 3, padding=dilation, dilation=dilation, stride=1).cuda() # Warmup for x in range(10): outp = conv(inp) # Test a = time.perf_counter() for x in range(1000): outp = conv(inp) b = time.perf_counter() print(f'{b-a:8.4f}') ``` Which I coordinated with a bash script: ```bash # !/bin/bash AAAA=`python dilated_test.py 32 64 0 0` AAAB=`python dilated_test.py 32 64 0 2` AABA=`python dilated_test.py 32 64 1 0` AABB=`python dilated_test.py 32 64 1 2` ABAA=`python dilated_test.py 32 512 0 0` ABAB=`python dilated_test.py 32 512 0 2` ABBA=`python dilated_test.py 32 512 1 0` ABBB=`python dilated_test.py 32 512 1 2` BAAA=`python dilated_test.py 4 64 0 0` BAAB=`python dilated_test.py 4 64 0 2` BABA=`python dilated_test.py 4 64 1 0` BABB=`python dilated_test.py 4 64 1 2` CAAA=`python dilated_test.py 128 64 0 0` CAAB=`python dilated_test.py 128 64 0 2` CABA=`python dilated_test.py 128 64 1 0` CABB=`python dilated_test.py 128 64 1 2` echo ' deterministic deterministic' echo ' false true ' echo ' not dil dil not dil dil ' echo "B= 32, C= 64: ${AAAA} | ${AAAB} | ${AABA} | ${AABB} " echo "B= 32, C=512: ${ABAA} | ${ABAB} | ${ABBA} | ${ABBB} " echo "B= 4, C= 64: ${BAAA} | ${BAAB} | ${BABA} | ${BABB} " echo "B=128, C= 64: ${CAAA} | ${CAAB} | ${CABA} | ${CABB} " ``` Which gives: ``` deterministic deterministic false true not dil dil not dil dil B= 32, C= 64: 0.2016 | 0.4260 | 0.3227 | 24.2022 B= 32, C=512: 0.9506 | 3.1413 | 2.1431 | 31.4578 B= 4, C= 64: 0.0472 | 0.0606 | 0.0633 | 3.2975 B=128, C= 64: 0.7815 | 1.6887 | 1.2011 | 97.4557 ``` ## Expected behavior Although I expect it to be a little slower, I would expect that the difference in speed would be at most 2x. ## Environment ``` PyTorch version: 1.3.0 Is debug build: No CUDA used to build PyTorch: 10.0.130 OS: Ubuntu 18.04.3 LTS GCC version: (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0 CMake version: version 3.10.2 Python version: 3.6 Is CUDA available: Yes CUDA runtime version: 10.0.130 GPU models and configuration: GPU 0: GeForce GTX 1080 Nvidia driver version: 410.104 cuDNN version: Could not collect Versions of relevant libraries: [pip] numpy==1.17.2 [pip] torch==1.3.0 [conda] blas 1.0 mkl [conda] mkl 2019.4 243 [conda] mkl-service 2.3.0 py36he904b0f_0 [conda] mkl_fft 1.0.14 py36ha843d7b_0 [conda] mkl_random 1.1.0 py36hd6b4f25_0 [conda] pytorch 1.3.0 py3.6_cuda10.0.130_cudnn7.6.3_0 pytorch ``` ## Additional context Built with Dockerfile: ```Dockerfile FROM nvidia/cuda:10.0-devel-ubuntu18.04 RUN apt-get update \ && apt-get install -y curl cmake \ && rm -rf /var/lib/apt/lists/* # Install Miniconda and Python 3.6.5 ENV CONDA_AUTO_UPDATE_CONDA=false ENV PATH=/root/miniconda/bin:$PATH RUN curl -so ~/miniconda.sh https://repo.continuum.io/miniconda/Miniconda3-4.7.10-Linux-x86_64.sh \ && chmod +x ~/miniconda.sh \ && ~/miniconda.sh -b -p ~/miniconda \ && rm ~/miniconda.sh \ && conda install -y python==3.6.5 \ && conda clean -ya RUN conda install pytorch cudatoolkit=10.0 -c pytorch ``` But I observe similar results if I replace the last line with: ```Dockerfile RUN conda install pytorch==1.2.0 ``` I do NOT observe these slow-downs with: ```Dockerfile RUN conda install pytorch==1.1.0 ```
module: cudnn,triaged
low
Critical
513,098,602
neovim
improve Vimscript <=> Lua interface: v:lua
`luaeval()` and `:lua` are clunky. In Lua we have `vim.fn`, which allows calling a Vimscript function. There should be a similar thing for calling a Lua function from Vimscript. # ✅ Idea 1: `v:lua` (done: #11338) Add a `lua` member to the Vim `v:` namespace, which acts like a list of all Lua global variables and functions. let rv = v:lua['foo'](arg1, arg2, ...) - Allows Lua functions to be used directly by options like `tagfunc`, `operatorfunc`, `:help :command-complete`, etc. - Example: `:set tagfunc=v:lua.foo` - Example: `:command Foo -complete=custom,v:lua.complete_stuff ...` # Idea 2: Lua _expression strings_ Vim 8.1 introduced `:h literal-Dict` which adds the `#{}` syntax. Similarly we could add a new syntax like `#()` for inline Lua expressions in Vimscript. Example: :echo #(return foo() and "ok" or "something else") # Idea 3: Assignment with `=#` - Introduce `=#` for both `:let` and `:set` single-line assignment: ``` set foldtext=#FoldText() let &foldtext=#FoldText() ``` - Note different semantics: `let` is evaluated on assignment, `set` is stored as a string and evaluated later. - See also https://github.com/neovim/neovim/pull/23471#issuecomment-1537079979 > these Vim patches improve the performance of calling a simple function: > * [vim/vim@87b4e5c](https://github.com/vim/vim/commit/87b4e5c5db9d1cfd6f2e79656e1a6cff3c69d15f) > * [vim/vim@a4e0b97](https://github.com/vim/vim/commit/a4e0b9785e409e9e660171cea76dfcc5fdafad9b) # Idea 4: `:let` assignment from Lua heredoc Vim 8.1 introduced `help :let=<<` which acts like a "heredoc" for assigning multiline strings: ```vim let text =<< trim END line1 line2 line3 END ``` Using a similar approach as the `trim` special case, we could have a `lua` special case which assigns the result of a Lua block: ```vim let text =<< lua END local foo = 42 return 42 END ```
enhancement,vimscript,lua,options
low
Major
513,106,678
pytorch
'import torch` fails with Illegal instruction
While trying to create a FreeBSD port for ```PyTorch```. The port builds, but crashes with ```Illegal instruction```: https://people.freebsd.org/~yuri/py-pytorch.shar Not sure where to go from here.
module: build,triaged
low
Critical
513,174,388
opencv
cvtColor perf test and Haar face detector failed with OpenCV.js+simd
<!-- If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses. If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute). Please: * Read the documentation to test with the latest developer build. * Check if other person has already created the same issue to avoid duplicates. You can comment on it if there already is an issue. * Try to be as detailed as possible in your report. * Report only one problem per created issue. This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library. --> ##### System information (version) <!-- Example - OpenCV => 3.1 - Operating System / Platform => Windows 64 Bit - Compiler => Visual Studio 2015 --> - OpenCV => OpenCV master - Operating System / Platform => Ubuntu 16.04 - Compiler => Emscripten: 1.39.0, LLVM upstream backend ##### Detailed description ``` Test Time: 2019/10/24 ``` ``` Test Environment: OS: Ubuntu 16.04 Emscripten: 1.39.0, LLVM upstream backend Browser: Chrome, Version 79.0.3941.4 (Official Build) dev (64-bit) Hardware: Intel(R) Core(TM) i7-8700K CPU @ 3.70GHz with 12 logical cores ``` In my test, cvtColor with param `YUV2BGR` made chrome crash with OpenCV.js+simd. And the same situation came to haar face detector, too. <!-- your description -->
bug,category: javascript (js)
low
Critical
513,195,087
flutter
Scoped WidgetBindings
## Use case I started developing a tool named [device_preview](https://github.com/aloisdeniel/flutter_device_preview) which simulates various devices and render them as widgets. To achieve this, a `MediaQuery` instance is inserted in the `onGenerateRoute` method of the user's app widget. The simulated locale should also be inserted by the user. It would be a lot more convenient to override the `WidgetBindings` instance for this user's wrapped app. This way media query, locale and even system events could be simulated gracefully. Unfortunately this instance is a global instance, and I can't have a specific instance for the wrapped widget. ## Proposal An ideal solution would be that instead of using `WidgetBindings.instance`, an inherited widget would allow to override the instance. If no inherited widget is present in the tree, then the default instance is used. ```dart final preview = DeviceFrame( child: WidgetBindingsProvider( widgetBindings: MyCustomWidgetBindings(), child: MaterialApp(...), ), );
c: new feature,framework,P3,team-framework,triaged-framework
low
Minor
513,247,942
vscode
Add custom QuickPick highlighting
It would be nice to have a bit more control over highlighting in QuickPick. I'm using QuickPick as a search field using regex and the existing fuzzy matching doesn't make sense in this context. I'd like to be able to provide my own highlights for the detail field and avoid highlighting elsewhere, although for completion I think it makes sense to allow custom highlighting on all three fields. The API could be similar to the proposed highlighted `TreeItemLabel` in #61482 for backward compatibility. A more general `HighlightedString` could be a good fit across the board. The implementation can then skip the fuzzy matching if the label type is `HighlightedString` and apply the highlights in there. I feel that this would complement #77297 nicely and make for a more versatile QuickPick API.
feature-request,api,quick-pick
medium
Critical
513,251,977
vscode
Expose QuickPick.matchOnLabel publicly
`matchOnLabel` already exists as an internal API. It makes sense to apply it externally too. It could maintain the same semantics and would allow users to have a better control over the display of quickpick results. This was already suggested in https://github.com/microsoft/vscode/issues/73904#issuecomment-506662578.
feature-request,api,quick-pick
low
Minor
513,313,439
terminal
Add keybinding command to kill current process
# Description of the new feature/enhancement > I'm copying this feature from ConEmu. In Python development on Windows, if you run an `asyncio` loop then Python can't be stopped using regular `KeyboardInterrupt Exception`. This leaves me forced to have to close the current tab and open new one. In ConEmu this is resolved by the ability to bind keys combination to command that results in killing current `PID`, like: ![image](https://user-images.githubusercontent.com/316734/67683312-991bc000-f9aa-11e9-8ca0-bafa39217b2f.png) # Proposed technical implementation details (optional) Terminal should be able to detect current running process in the current tab and gets its `PID` and offer the user the ability to force stop it using low-level Windows commands. Resulting in the process running to be killed, but the shell used to start the process kept alive and back in focus for the user to continue using the current tab using the current shell.
Area-UserInterface,Product-Terminal,Issue-Task
low
Minor
513,340,126
go
cmd/go: loops without output when a module fetch via `git+ssh` fails to authenticate
### What version of Go are you using (`go version`)? _go version go1.13.3 darwin/amd64_ ### Does this issue reproduce with the latest release? This is the latest release available to me at time of writing. ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> GO111MODULE="" GOARCH="amd64" GOBIN="" GOCACHE="/Users/seh/Library/Caches/go-build" GOENV="/Users/seh/Library/Application Support/go/env" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="darwin" GONOPROXY="" GONOSUMDB="" GOOS="darwin" GOPATH="/Users/seh/go" GOPRIVATE="" GOPROXY="https://proxy.golang.org,direct" GOROOT="/usr/local/Cellar/go/1.13.3/libexec" GOSUMDB="sum.golang.org" GOTMPDIR="" GOTOOLDIR="/usr/local/Cellar/go/1.13.3/libexec/pkg/tool/darwin_amd64" GCCGO="gccgo" AR="ar" CC="clang" CXX="clang++" CGO_ENABLED="1" GOMOD="" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/d5/r0rch5j95zjcjmh12gzb7lfc0000gn/T/go-build882545304=/tmp/go-build -gno-record-gcc-switches -fno-common" </pre></details> ### What did you do? As described previously in https://github.com/golang/go/issues/33568#issuecomment-546947364, I added a few new packages to an existing Go module. Let's call one of the new modules `dependency`, and another that imports the first one `dependent`. In file _go.mod_: ```go module example.com/repo.git go 1.13 ``` In file _dependency/greet.go_: ```go package dependency const Place = "world" ``` In file _dependent/main.go_: ```go package main import "example.com/repo.git/dependency" import "fmt" func main() { fmt.Printf("Hello, %s!\n", dependency.Place) } ``` Now, say that I decide that I don't need the _dependency_ module anymore, and I delete the _dependency_ directory, but I edit the _dependency/main.go_ file such that I mistakenly leave that `import` statement in place: ```go package main // Note that this now refers to a nonexistent package. import "example.com/repo.git/dependency" import "fmt" func main() { fmt.Println("Hello, world!") } ``` Now, try to run _go build_ to build the program in _dependency_. _[Aside]_ In the _main.go_ file above, the first import statement is no longer used, which is a problem that arises so frequently that our tools like _goimports_ automatically remove such statements. I can't recall now whether triggering this problem required leaving use of that missing package in place. ### What did you expect to see? _go build_ should fail quickly and print a message complaining that this _dependency_ package does not exist within this module, ideally not looking anything up over the network, since the module is already defined locally in this source tree. ### What did you see instead? _go build_ hangs, producing no output. Running _go build -v_ instead, we see output like the following: <details><summary><i>go build -v</i> output</summary> ``` # cd .; git ls-remote https://example.com/repo fatal: unable to access 'https://example.com/repo/': The requested URL returned error: 403 # cd .; git ls-remote https://example.com/repo fatal: unable to access 'https://example.com/repo/': The requested URL returned error: 403 # cd .; git ls-remote https://example.com/repo fatal: unable to access 'https://example.com/repo/': The requested URL returned error: 403 # cd .; git ls-remote https://example.com/repo fatal: unable to access 'https://example.com/repo/': The requested URL returned error: 403 # cd .; git ls-remote git+ssh://example.com/repo Received disconnect from 1.2.3.4 port 22:2: Too many authentication failures Disconnected from 1.2.3.4 port 22 fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. # cd .; git ls-remote git+ssh://example.com/repo Received disconnect from 2.3.4.5 port 22:2: Too many authentication failures Disconnected from 2.3.4.5 port 22 fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. # cd .; git ls-remote git+ssh://example.com/repo Received disconnect from 2.3.4.5 port 22:2: Too many authentication failures Disconnected from 2.3.4.5 port 22 fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. # cd .; git ls-remote git+ssh://example.com/repo Received disconnect from 1.2.3.4 port 22:2: Too many authentication failures Disconnected from 1.2.3.4 port 22 fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. # cd .; git ls-remote ssh://example.com/repo Received disconnect from 2.3.4.5 port 22:2: Too many authentication failures Disconnected from 2.3.4.5 port 22 fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. # cd .; git ls-remote ssh://example.com/repo Received disconnect from 2.3.4.5 port 22:2: Too many authentication failures Disconnected from 2.3.4.5 port 22 fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. # cd .; git ls-remote ssh://example.com/repo Received disconnect from 2.3.4.5 port 22:2: Too many authentication failures Disconnected from 2.3.4.5 port 22 fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. # cd .; git ls-remote ssh://example.com/repo Received disconnect from 2.3.4.5 port 22:2: Too many authentication failures Disconnected from 2.3.4.5 port 22 fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. ^C ``` </details> In this case, it turns out that the SSH server requires a particular user name to authenticate, requiring an entry like the following in my _~/.gitconfig_ file: ``` [url "ssh://sentinel@example.com/"] insteadOf = https://example.com/ ``` With that in place, _go build_ is able to complete its fetch attempt, and conclude that the _dependency_ package truly does not exist, and prints a message like this: > build example.com/repo.git/dependent: cannot load example.com/repo.git/dependency: no matching versions for query "latest" More clear to me would be if _go build_ had noted that there's no directory here called _dependency_, but we referred to it via that import path from that file.
NeedsInvestigation,modules
low
Critical
513,413,008
pytorch
RPC couldn't match torch.ones with requires_grad=True
## 🐛 Bug I was trying to use `rpc.remote` to create a tensor with `requires_grad=True`, but hit the following error: ``` Couldn't match schema: aten::ones(int[] size, *, int? dtype=None, int? layout=None, Device? device=None, bool? pin_memory=None) -> (Tensor) to args: ((3, 3),) and kwar gs: {'requires_grad': True}, reason: Unknown keyword argument 'requires_grad' for operator 'aten::ones'. Schema: aten::ones(int[] size, *, int? dtype=None, int? layout =None, Device? device=None, bool? pin_memory=None) -> (Tensor) ``` ### To Reproduce ```python rpc.remote(dst, torch.ones, args=((3, 3),), kwargs={"requires_grad":True}) ``` ### Work Around Wrap `torch.ones` into a user function can pass that user function to remote, e.g., ```python def _torch_ones(sizes, requires_grad=False): return torch.ones(sizes, requires_grad=requires_grad) rpc.remote(dst, _torch_ones, args=((2, 2), ), kwargs={"requires_grad":True}) ``` cc @ezyang @gchanan @zou3519 @bdhirsh @bhosmer @smessmer @ljk53 @ailzhang @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @rohan-varma @jjlilley @osalpekar @jiayisuse @agolynski @SciPioneer @H-Huang @mrzzd @xush6528
high priority,triage review,oncall: distributed,module: internals,triaged,better-engineering,module: rpc
low
Critical