id
int64
393k
2.82B
repo
stringclasses
68 values
title
stringlengths
1
936
body
stringlengths
0
256k
labels
stringlengths
2
508
priority
stringclasses
3 values
severity
stringclasses
3 values
236,862,100
go
x/perf/benchstat: Return status code 1 when benchmarks change significantly
Running benchstat on a CI server to detect anomalies relies on the user to parse the output from the command in order to pick up any deltas. To make this process simpler I propose benchstat would return a status code 1 when any of the benchmarks have significant change. In the event that backwards compatibility is r...
NeedsDecision
low
Major
236,948,884
rust
Error message when using non-derived constants from another crate in pattern matching is confusing
The error message is perfectly fine when inside the crate that has the type, because changing or adding a `derive(PartialEq, Eq)` is something you can control. ``` error: to use a constant of type `mime::Mime` in a pattern, `mime::Mime` must be annotated with `#[derive(PartialEq, Eq)]` --> src/main.rs:187:39 ...
C-enhancement,A-diagnostics,T-compiler,D-confusing,D-newcomer-roadblock,A-patterns
low
Critical
236,956,408
flutter
Make Table accessible
Tables are not very accessible. A simple example can be seen in the "recipe details" screen if the Pesto demo app: In the table of ingredients at the bottom you should be able to select an entire row when in accessibility node. Currently, you can only select one cell at a time, making accessibility navigation aw...
framework,f: material design,a: accessibility,P2,team-design,triaged-design
low
Major
236,975,494
flutter
Stack overflows in tests under package:flutter/
## Steps to Reproduce Add a stack overflow bug to test/widgets/sliver_fill_viewport_test.dart I would hope running the test with a stack overflow would return a stack trace providing some indication of where the stack overflow occurred but does not. Instead the vm appears to hard crash. Output running test with...
c: crash,engine,platform-mac,dependency: dart,P2,team-engine,triaged-engine
low
Critical
237,000,695
youtube-dl
.netrc file: add support for passwords containing spaces
- [X] I've **verified** and **I assure** that I'm running youtube-dl **2017.06.18** ``` $ youtube-dl --version 2017.06.18 ``` - [X] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github...
external-bugs
low
Critical
237,030,245
rust
Confusing lifetime error with closure
```rust struct Foo<'a> { foo: &'a str } fn main() { let foo = Foo { foo: "foo" }; let closure = |foo: Foo| foo; closure(foo); } ``` Intuitively I don't quite see why this shouldn't compile, but: ``` error[E0495]: cannot infer an appropriate lifetime due to conflicting requirements --> <ano...
C-enhancement,A-lifetimes,A-closures
low
Critical
237,084,377
rust
Rust will memmov |self| when passed by value to inline function
See the assembly for https://is.gd/0Owhgw . Note that you'll need to explicitly specify Release, because I can't link to Release code for some reason. Note this bit here: > movl $400, %edx > movq %rbx, %rsi > callq memcpy@PLT That looks like a very unnecessary and large copy. I ran into this working on rust...
A-LLVM,I-slow,C-enhancement,P-medium,T-compiler,C-optimization
medium
Major
237,248,340
TypeScript
Bad automatic formatting when filling in type argument as object literal
**TypeScript Version:** nightly (2.5.0-dev.20170619) **Code** Type: ```ts declare function f<T>(): void; f<{}>(); ``` **Expected behavior:** Get what you typed. **Actual behavior:** Get: ```ts declare function f<T>(): void; f < {}>(); ```
Bug,Help Wanted,Domain: Formatter
low
Minor
237,312,656
TypeScript
Boolean() cannot be used to perform a null check
**TypeScript Version:** 2.4.0 Apologies for today's issue raising binge. **Code** ```ts // Compiles const nullCheckOne = (value?: number) => { if (!!value) { return value.toFixed(0); } return ''; } const nullCheckTwo = (value?: number) => { if (Boolean(value)) { /...
Suggestion,Awaiting More Feedback
high
Critical
237,318,127
TypeScript
suggestion: explicit "tuple" syntax
### Problem I'm writing this after encountering (what I think is) #3369. I'm a noob to TS, so I apologize for any misunderstandings on my part. The behavior the lack of type inference here: ```typescript interface Foo { bar: [number, number]; } interface McBean { baz: Foo; } // error: McMonkey do...
Suggestion,In Discussion
medium
Critical
237,362,225
go
go/format: hasUnsortedImports should also test grouped imports (TODO)
Reminder to resolve TODO in go/format/format.go:hasUnsortedImports: This function always returns true if there are grouped imports, which causes a lot of extra work even if those imports are sorted.
NeedsInvestigation
low
Minor
237,378,819
flutter
PageStorageKeys might benefit from a way to identify their primary client
Internal: b/292548528 Customer Leafy ran into a confusing problem: ExpansionTiles were asserting in initState(): ``` Error: type 'double' is not a subtype of type 'bool' of 'value' ... #0 _ExpansionTileState._isExpanded= (package:flutter/src/material/expansion_tile.dart:81) #1 _ExpansionTileState.initState (pac...
c: crash,framework,f: scrolling,c: proposal,customer: leafy (g3),P2,team-framework,triaged-framework
low
Critical
237,384,921
TypeScript
Include Default Parameter Values in Signature Help
<!-- BUGS: Please use this template. --> <!-- QUESTIONS: This is not a general support forum! Ask Qs at http://stackoverflow.com/questions/tagged/typescript --> <!-- SUGGESTIONS: See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md --> From https://github.com/Microsoft/vsco...
Suggestion,Awaiting More Feedback,VS Code Tracked,Domain: Signature Help,Domain: Quick Info
high
Critical
237,400,698
youtube-dl
"HTTP Error 401: Unauthorized" if passing in creds or useragent\cookies
## Please follow the guide below - You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly - Put an `x` into all the boxes [ ] relevant to your *issue* (like that [x]) - Use *Preview* tab to see how your issue will actually look like --- ...
geo-restricted,account-needed
low
Critical
237,400,900
vscode
[folding] Allow to show amount of lines folded
Hi people! I would like to see vscode folding with info about lines folded like Netbeans. Looks like this: ![screenshot_20170620_215124](https://user-images.githubusercontent.com/3067335/27364923-e9a04724-5602-11e7-8c29-4eb09044544a.png) BTW: Thank you for this awesome code editor! :smile:
feature-request,editor-folding
low
Minor
237,428,516
TypeScript
Imported const enum is not inlined in generated code
**TypeScript Version:** 2.4.0 **Code** ```ts // a.ts export const enum Foo { Bar = 'bar' } // b.ts import { Foo } from './a' Foo.Bar // TypeError or ReferenceError, depending on how it's compiled ``` **Expected behavior:** `Foo.Bar` to be replaced with `'bar'` **Actual behavior:** The impor...
Bug
medium
Critical
237,453,341
pytorch
Factorized Output Layer
Does PyTorch provide a [factorized output layer](https://arxiv.org/pdf/1412.7091.pdf) in `nn` module? It computes the gradient much faster in sparse output space. This will benefit a lot in NLP experiments. I can propose such a layer if there isn't one.
todo,feature,triaged
low
Minor
237,479,192
go
x/net/html: readRawOrRCDATA() parsing issue when text ends with '<'
### What version of Go are you using (`go version`)? `go version go1.8.3` `golang.org/x/net/html: 057a25b06247e0c51ba15d8ae475feb2fcb72164` ### What operating system and processor architecture are you using (`go env`)? `linux/amd64` ### What did you do? Tried to parse HTML that contains a textarea that ends w...
NeedsInvestigation
low
Critical
237,536,881
youtube-dl
[sohu] Support playlists on tv.sohu.com
## Please follow the guide below - You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly - Put an `x` into all the boxes [ ] relevant to your *issue* (like that [x]) - Use *Preview* tab to see how your issue will actually look like --- ...
request,geo-restricted
low
Critical
237,547,430
go
x/image/tiff: package does not support image resolution
Please answer these questions before submitting your issue. Thanks! ### What version of Go are you using (`go version`)? `go1.8 darwin/amd64` ### What operating system and processor architecture are you using (`go env`)? `Darwin/amd64` ### What did you do? Take a tiff image and attempt to decode it with t...
NeedsInvestigation
low
Critical
237,547,778
rust
debuginfo: Subroutine types are not ABI-adjusted
Arguments of a type like `[u8; 4]` are actually passed as a single `u32` to a function. At the moment, the debuginfo code does not try to reflect this transformation in any way. This is not important for inspecting function arguments, since they are copied into a local alloca of the correct type, but it might be a prob...
A-debuginfo,T-compiler,C-bug
low
Critical
237,557,833
opencv
Ptr<DescriptorExtractor> unsupported by Java wrappers generator
##### System information (version) - OpenCV => 3.2.0-813-g16368a2 - Operating System / Platform => Ubuntu 16.04, 64 bits - Compiler => cmake, g++ 5.4.0 ##### Detailed description The type Ptr&lt;DescriptorExtractor&gt; is unrecognized by the Java wrappers generator. In particular, the class BOWImgDescriptorE...
feature,category: java bindings
low
Minor
237,629,147
kubernetes
Port-forward for UDP
Kubernetes currently supports port forwarding only for TCP ports. However, Pod/service might expose UDP port too.
area/kubectl,sig/node,kind/feature,sig/cli,priority/important-longterm,lifecycle/frozen,triage/accepted
high
Critical
237,630,119
go
go/ast: Free-floating comments are single-biggest issue when manipulating the AST
Reminder issue. The original design of the go/ast makes it very difficult to update the AST and retain correct comment placement for printing. The culprit is that the comments are "free-floating" and printed based on their positions relative to the AST nodes. (The go/ast package is one of the earliest Go packages in...
Refactoring
high
Critical
237,634,072
opencv
Need ability to control bitrate in VideoWriter with H264 codec
<!-- If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses. If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute). This is a template helping you to create an issue which can be...
feature,category: videoio,RFC
medium
Critical
237,652,486
rust
Doc block ignored for `pub extern crate`
Looks like doc blocks for `pub extern crate` are ignored and don't show up anywhere in the generated documents. So, this code ``` /// Unicode Character Database. pub extern crate unic_ucd as ucd; /// Unicode Bidirectional Algorithm (USA\#9). pub extern crate unic_bidi as bidi; /// Unicode Normalization For...
T-rustdoc,E-mentor,C-bug
low
Minor
237,665,439
react
Feature request: Add a "module" entry in package.json to export ES2015 version of React
**Do you want to request a *feature* or report a *bug*?** Request a feature **What is the current behavior?** React ecosystem was promoting ES6 classes and modules since 2014 and many packages like react-router, redux and so on, have an "es" folder in the npm package with source code in ES2015 modules. Unless I am...
Component: Build Infrastructure,Type: Feature Request
high
Critical
237,670,027
flutter
Document how to download an image in the dartdocs for Image.network
Today, to get an image from an image widget, you have to jump through a few steps: ```dart Image image = new Image.network('https://i.stack.imgur.com/lkd0a.png'); Completer<ui.Image> completer = new Completer<ui.Image>(); image.image .resolve(new ImageConfiguration()) .addListener((Image...
framework,d: api docs,has reproducible steps,P2,found in release: 3.3,found in release: 3.5,team-framework,triaged-framework
low
Major
237,682,090
go
runtime: signal handling: sighandler crash due to race with signal.Ignore
In reviewing @ianlancetaylor's [CL 46003](https://golang.org/cl/46003) (addressing #14571), I noticed what I believe to be a rare race-condition that could result in unexpected termination of a Go program. I attempted to write a reproducer for the race in question, which would cause the program to erroneously exit i...
NeedsInvestigation,compiler/runtime
low
Critical
237,737,480
flutter
Flutter should respect proxy settings on Windows during Dart SDK download
I met errors when running flutter doctor. It's related with proxy settings. ## Flutter Doctor ``` Microsoft Windows [Version 6.1.7601] Copyright (c) 2009 Microsoft Corporation. All rights reserved. C:\Users\CNFEHU1>flutter doctor Checking Dart SDK version... Downloading Dart SDK 1.24.0-dev.6.7... Start-Bit...
tool,platform-windows,P2,team-tool,triaged-tool
low
Critical
237,861,648
go
encoding/xml: unmarshal only processes first XML element
If you Marshal []int{1,2} you get `<int>1</int><int>2</int>`, but then if you Unmarshal it back into a new slice, you get just []int{1}. Unmarshal simply stops after the first top-most XML element, because it is implemented as NewDecoder(bytes.NewReader(data)).Decode(v). When v is not a slice, this makes sense. But if ...
NeedsDecision,early-in-cycle
low
Critical
237,887,325
three.js
Soft particles
Hi guys, I was looking for soft particles for my project, but I did not find anything on that. Having spent a little time and energy, I still managed to make soft particles and decided to suggest introducing it into the library as a plug-in or something like that. All the code and how it works I wrote here. http...
Suggestion
low
Minor
237,923,563
go
proposal: time/v2: make Duration safer to use
`time.Duration` is currently very prone to accidental misuse, especially when interoperating with libraries and/or wire formats external to Go (c.f. http://golang.org/issue/20678). Some common errors include: * Unchecked conversions from floating-point seconds. * Unchecked overflow when multiplying `time.Duration`...
v2,Proposal
medium
Critical
237,924,377
flutter
Flutter doctor should tell you that updates to the Android SDK are available
Currently, it's hard for Flutter users to learn about updates to the Android SDK. This can get them into strange error situations: E.g. if they pull in a plugin that depends on the latest SDK, building your Flutter app will fail with the unhelpful error message: `Could not find com.google.firebase:firebase-auth:11.0.1`...
platform-android,tool,P3,a: plugins,team-android,triaged-android
low
Critical
237,952,325
TypeScript
ThisType for Ember.computed and Ember.observer
**TypeScript Version:** 2.3.4 Thanks for your work on this great project :) **Context** _We are experimenting with TypeScript 2.x in Ember, and the new TypeScript 2.x features really enable us to type most of our Ember code. There is however one thing we came across that doesn't seem like something we can solve...
Suggestion,Needs Proposal
low
Major
237,960,303
rust
macro_rules! macros do not backtrack
I'm mainly filing this to be able to close other issues whose problems come down to this. I don't know if we want to fix this or will fix this, but at least there will be a single issue for it.
A-macros,C-feature-request
low
Major
237,965,934
go
proposal: net/http/httputil/v2: split into focused subpackages
This proposal builds on https://github.com/golang/go/issues/7907 (remove deprecated stuff) and https://github.com/golang/go/issues/19660 (refactor `ioutil` to provide a coherent abstraction). `httputil` currently contains: * `Dump{Request,RequestOut,Response}`: "It should only be used by servers to debug client r...
v2,Proposal
low
Critical
237,978,617
rust
Peer credentials on Unix socket
https://github.com/tokio-rs/tokio-uds/pull/13 was recently merged, so I'd like to open an issue of adding same thing to stdlib. TL;DR It allows one to get effective UID and GID of the process which created the remote socket. I suggest to test it with Tokio now and when there is consensus, we can merge similar change...
T-libs-api,C-tracking-issue
medium
Critical
237,995,375
kubernetes
Extract application-based upgrade tests to examples repo
These are the tests that verify real app connectivity during node upgrades. It's testing a confluence of features, but it's also testing that a particular arrangement of StatefulSet/ReplicaSet and PodDisruptionBudget is actually correct for the app in question. This was brought up during the review of #47200. Th...
priority/important-soon,kind/cleanup,sig/apps,sig/testing,lifecycle/frozen
low
Critical
238,014,320
rust
*const T has quite a few methods that seem like they don't need to require T: Sized
Not sure which exactly, but we should evaluate and relax bounds where possible. See also https://github.com/rust-lang/rust/issues/24794, https://github.com/rust-lang/rust/issues/36952.
C-enhancement,T-libs-api
low
Major
238,033,584
bitcoin
listsinceblock incorrectly showing some conflicted transactions
Normally when a transaction is conflicted, listsinceblock will show it as having negative confirmations, representing how long ago it conflicted. However, looking at the results of my listsinceblock shows dozens of conflicted transactions with 0 confirmations (as well as transactions whos parents have long been forgott...
Wallet,RPC/REST/ZMQ
low
Major
238,038,730
rust
Add drain_filter for BinaryHeap
`std::collections::BinaryHeap` is missing a `drain_filter` method (rust-lang/rfcs#2140). <!-- TRIAGEBOT_START --> <!-- TRIAGEBOT_ASSIGN_START --> <!-- TRIAGEBOT_ASSIGN_DATA_START$${"user":null}$$TRIAGEBOT_ASSIGN_DATA_END --> <!-- TRIAGEBOT_ASSIGN_END --> <!-- TRIAGEBOT_END -->
A-collections,T-libs-api,E-help-wanted,C-feature-accepted
high
Critical
238,042,956
nvm
Can't run `npm run test/fast` locally
Since 7f3145bc98b9355d26ee5da730fb9c4df7201b18, there is a new unit test called `nvm_default_packages` that I can never pass, both on Ubuntu and Mac Error message: ``` ✗ nvm_default_packages touch: cannot touch '/default-packages': Permission denied ./nvm_default_packages: line 26: /default-packages: Permi...
testing,bugs,pull request wanted
low
Critical
238,095,629
flutter
Document template files in README.md
Excerpt from #9882 (by @Hixie): Before we add more files to the template, I think we should make sure the template contains a README that documents, for each file in the template: - What the file is for - Why you would edit that file - How to verify that the edits are valid - How to test the file The templa...
framework,d: api docs,P2,team-framework,triaged-framework
low
Minor
238,111,976
angular
ExpressionChangedAfterItHasBeenCheckedError on ngSubmit
<!-- PLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION. ISSUES MISSING IMPORTANT INFORMATION MIGHT BE CLOSED WITHOUT INVESTIGATION. --> ## I'm submitting a ... <!-- Check one of the following options with "x" --> <pre><code> [ ] Regression (behavior that used to work and stop...
type: bug/fix,freq2: medium,area: forms,state: confirmed,forms: change detection,P4
low
Critical
238,211,315
go
html/template: parse failures lack sufficient context for debugging
Please answer these questions before submitting your issue. Thanks! ### What version of Go are you using (`go version`)? Unsure; this is in the Blaze version of "go_binary", "go_library", etc. (I'm having difficulty understanding which particular version of Go that is invoking). ### What operating system and pro...
NeedsInvestigation
low
Critical
238,223,293
vscode
[Feature request] Hide cursor while typing
https://superuser.com/questions/928839/what-does-the-hide-pointer-while-typing-feature-actually-do Can we get this as an option in VS Code?
feature-request,editor-core
high
Critical
238,264,229
rust
Tracking issue for future-incompatibility lint `late_bound_lifetime_arguments`
#### What is this lint about In functions not all lifetime parameters are created equal. For example, if you have a function like ```rust fn f<'a, 'b>(arg: &'a u8) -> &'b u8 { .... } ``` both `'a` and `'b` are listed in the same parameter list, but when stripped from the surface syntax the function looks more l...
A-lints,A-lifetimes,T-compiler,C-future-incompatibility,C-tracking-issue,T-types
medium
Critical
238,267,909
rust
std::fs::canonicalize returns UNC paths on Windows, and a lot of software doesn't support UNC paths
Hi, I hope this is the right forum/format to register this problem, let me know if it's not. Today I tried to use `std::fs::canonicalize` to make a path absolute so that I could execute it with `std::process::Command`. `canonicalize` returns so-called "UNC paths", which look like this: `\\?\C:\foo\bar\...` (sometime...
O-windows,T-libs-api,C-bug,A-io
high
Critical
238,290,783
go
net: default dialer should accept list of IPs with fallback included
Please answer these questions before submitting your issue. Thanks! ### What version of Go are you using (`go version`)? master ### What did you do? 1. In case you want to implement/extend your own dialer you might want to use the original dialer to handle all the TCP/UDP connection, but to still resolve the ...
FeatureRequest
low
Critical
238,301,351
rust
Field pattern shorthand can be interpreted as an item reference
`B { X }` is a shorthand for `B { X: X }` and `X` here can be intepreted as an item reference, rather than a binding. I don't know if this is actually a bug or not. Possible fixes are: - Leave it as is. - Leave it as is with some warning. - Force `X` be interpreted as a binding and let it fail to compile (due to l...
A-lints,T-lang,C-feature-request
low
Critical
238,302,145
rust
Tracking issue for unsized tuple coercion
This is a part of #18469. This is currently feature-gated behind `#![feature(unsized_tuple_coercion)]` to avoid insta-stability. Related issues/PRs: #18469, #32702, #34451, #37685, #42527 This is needed for unsizing the last field in a tuple: ```rust #![feature(unsized_tuple_coercion)] fn main() { let _:...
T-lang,B-unstable,C-tracking-issue,S-tracking-design-concerns,S-tracking-needs-summary
low
Critical
238,361,815
go
proposal: cmd/trace: add 'greedy goroutine diagnosis' option
(Maybe helpful to bypass the issue #10958 in a quite different but probably better and more clean way. Coming from this [thread](https://groups.google.com/forum/#!topic/golang-nuts/8KYER1ALelg), many thanks to the participants of this discussion) Hi all :) I have implemented a sub-option in the `go tool trace` ...
Proposal,Proposal-Hold
medium
Critical
238,494,841
angular
Feature: @Directive should support styles and styleUrls properties
## I'm submitting a ... <!-- Check one of the following options with "x" --> <pre><code> [ ] Regression (behavior that used to work and stopped working in a new release) [ ] Bug report <!-- Please search github for a similar issue or PR before submitting --> [x] Feature request [ ] Documentation issue or request ...
feature,area: core,core: stylesheets,feature: under consideration
high
Critical
238,495,828
go
time: time.Local is always UTC on iOS
Local timezone is hardcoded to UTC on iOS. https://github.com/golang/go/blob/master/src/time/zoneinfo_ios.go#L39-L42 ```go func initLocal() { // TODO(crawshaw): [NSTimeZone localTimeZone] localLoc = *UTC } ``` As mentioned in the code it should use [NSTimeZone localTimeZone](https://developer.apple.com/docu...
NeedsFix,mobile
low
Major
238,554,237
flutter
PageStorageKey with TabBarView causes PageController and TabController to get out of sync
`TabBarView` uses the `index` of its `tabController` to set the `initialPage` of its `PageController`. However, the `PageController` can later determine a different `_pageToUseOnStartup` using its `PageStorage`. There's no mechanism currently in place for the `TabBarView` to notify its `tabController` that the `PageCon...
framework,f: material design,has reproducible steps,P2,found in release: 3.7,found in release: 3.9,team-design,triaged-design
low
Critical
238,563,315
kubernetes
Environment variables are not re-interpolated when re-applying deployment
/kind bug **What happened**: The environment variables were not interpolated **What you expected to happen**: **How to reproduce it (as minimally and precisely as possible)**: create environment variable like this ``` - name: REDIS_URL value: redis://:$(REDIS_PASSWORD)@redis...
kind/bug,sig/apps,lifecycle/frozen,needs-triage
medium
Critical
238,563,845
opencv
locale dependencies
<!-- If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses. If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute). This is a template helping you to create an issue which can be...
bug,category: core,category: ocl,incomplete
low
Critical
238,592,859
rust
Add lint for u8 as *mut cast
This is an easy error to make: #42901 #42827 A cast from u8 to a pointer is probably always an error. In the rare case that you're creating a pointer into the first 256 bytes of address space, `u8 as usize as *mut` is more clear, or you can be troubled to `#[allow(u8_to_ptr)]`.
A-lints,C-feature-request
low
Critical
238,624,767
angular
Change detection is not triggered by an Observable whose values are emitted from an ErrorHandler
<!-- PLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION. ISSUES MISSING IMPORTANT INFORMATION MIGHT BE CLOSED WITHOUT INVESTIGATION. --> ## I'm submitting a ... <!-- Check one of the following options with "x" --> <pre><code> [ ] Regression (behavior that used to work and stop...
type: bug/fix,freq2: medium,area: core,core: change detection,core: error handling,P3
low
Critical
238,632,243
go
proposal: spec: consider more strict "declared and not used" check (go/vet or even spec)
The following code ``` func f(i interface{}) *T { x, ok := i.(*T) if !ok { x := new(T) x.f = 0 } return x } ``` compiles without errors even though it is obviously incorrect: Inside the block of the `if` statement, the `:=` operator should have been `=` instead. The compiler doesn't complain because ...
LanguageChange,Proposal,LanguageChangeReview
low
Critical
238,633,109
flutter
Factor out deep linking logic
The deep linking functionality that landed last week has a few side effects. (Videos sent in an email). Starting from a position where the app is closed (nothing to restore) I get the following: 1. If the route passed has the format `/blah/this/thing` then the `Navigator` (as designed) will attempt to push to the...
framework,customer: posse (eap),f: routes,P3,team-framework,triaged-framework
medium
Critical
238,652,991
go
proposal: spec: require return values to be explicitly used or ignored (Go 2)
Today, if a Go function returns both a value and an error, the user must either assign the error to a variable ```go v, err := computeTheThing() ``` or explicitly ignore it ```go v, _ := computeTheThing() ``` However, errors that are the only return value (as from `io.Closer.Close` or [`proto.Unmarshal`](https...
LanguageChange,Proposal,error-handling,LanguageChangeReview
high
Critical
238,668,073
TypeScript
TypeScript complains about overwriting .d.ts files that are potentially known outputs
<!-- BUGS: Please use this template. --> Using tsc at the command line, I got ``` error TS5055: Cannot write file '/Users/alexamil/WebstormProjects/oresoftware/ldap-pool/index.d.ts' because it would overwrite input file. ``` why? :) my tsconfig.json file is as follows ```json { "compilerOptions": { ...
Suggestion,Awaiting More Feedback
medium
Critical
238,696,506
go
image/gif: decoding gif returns `unknown block type: 0x01` error
Please answer these questions before submitting your issue. Thanks! ### What version of Go are you using (`go version`)? ``` go version go1.8.3 darwin/amd64 ``` ### What operating system and processor architecture are you using (`go env`)? ``` GOARCH="amd64" GOBIN="" GOEXE="" GOHOSTARCH="amd64" GOHOSTOS=...
NeedsInvestigation
low
Critical
238,706,123
go
x/build/cmd/coordinator: use maintner to start trybots, not polling gerrit API
Currently Trybots start by a goroutine loop in the coordinator (findTryWorkLoop) running a Gerrit query every 60 seconds: ```go func findTryWorkLoop() { if errTryDeps != nil { return } ticker := time.NewTicker(60 * time.Second) for { if er...
Builders,NeedsInvestigation
low
Critical
238,803,732
vscode
Selection of problem matcher is not very intuitive when running a task
Testing the following in #29442: > Task > Run Build Task: shows the list again with the task run last listed under recently used tasks. This time select a problem matcher: Enusre that problems are detected (2) and that the tasks.json file opens with a configuration like this... I was presented with a list that cont...
feature-request,tasks
low
Minor
238,831,784
vscode
Auto indent on pasting does not satisfy indentation for braces in JS/TS
Testing #29494 Copy the following code into into an editor file of type JavaScript, indented with tabs (4): ``` function makeSub(a,b) { subsent = sent.substring(a,b); return subsent; } ``` **Result**: ![image](https://user-images.githubusercontent.com/2239563/27587148-7f5d2e86-5b43-11e7-997c-37c6fb4e2519...
typescript,javascript,editor-autoindent,under-discussion,on-unit-test
low
Major
238,848,793
angular
Disabling form controls leads to changed-after-checked errors
<!-- PLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION. ISSUES MISSING IMPORTANT INFORMATION MIGHT BE CLOSED WITHOUT INVESTIGATION. --> ## I'm submitting a ... <!-- Check one of the following options with "x" --> <pre><code> [ ] Regression (behavior that used to work and stop...
type: bug/fix,hotlist: components team,freq2: medium,area: forms,state: confirmed,forms: disabling controls,P4
low
Critical
238,909,739
opencv
Documentation for reduce() function does not match its CV2 implementation in python
For Python programmers who have OpenCV v3.xxx installed (aka the cv2 library in Python-world), the only OpenCV online documentation available for the **reduce()** function shows incorrect info that makes the function impossible to use. When searching for usage info for this function (eg, search: "python open cv reduce...
feature,category: documentation,category: features2d
low
Critical
238,956,416
go
x/tools/cmd/goimports: support repairing import grouping/ordering
I'm working on a tool to fix up non-conventional or incorrect imports grouping/ordering, but I'd much rather have this be part of goimports. Would it be welcome? ### What goimports does now When goimports adds or removes an import, it heuristically attempts to find a good place for it. So if I add an `os.Open()` ...
Proposal,Proposal-Accepted,NeedsFix,Tools
high
Critical
238,964,241
rust
impl-trait return type is bounded by all input type parameters, even when unnecessary
``` rustc 1.20.0-nightly (f590a44ce 2017-06-27) binary: rustc commit-hash: f590a44ce61888c78b9044817d8b798db5cd2ffd commit-date: 2017-06-27 host: x86_64-pc-windows-msvc release: 1.20.0-nightly LLVM version: 4.0 ``` ```rust trait Future {} impl<F> Future for Box<F> where F: Future + ?Sized {} struct SomeFuture<'a>(&'...
A-lifetimes,T-compiler,A-impl-trait,C-bug,WG-async,F-precise_capturing
medium
Critical
238,972,883
vscode
auto indenting issues with C# files
testing #29493 ![image](https://user-images.githubusercontent.com/1487073/27608238-894db968-5b3b-11e7-8cc8-8b204721c1cf.png) 1. Create a simple C# file that looks like this: ``` c# using System; namespace ConsoleApplication { public class Program { public static void Main(string[] args)...
feature-request,editor-autoindent,c#
low
Minor
238,994,469
go
runtime: TestGdbPython* fails on solaris
On a development build of Solaris, TestGdbPythonCgo fails: ``` $ uname -a SunOS darwin-sunw 5.12 s12_127 i86pc i386 i86pc ``` ``` $ gdb --version GNU gdb (GDB) 7.12.1 ``` ``` $ go version go version devel +33b3cc1568 Tue Jun 27 20:45:38 2017 +0000 solaris/amd64 ``` ``` $ go env GOARCH="amd64" GOBI...
Testing,OS-Solaris,NeedsFix,compiler/runtime
medium
Critical
239,033,995
go
runtime: add test for syscall failing to create new OS thread during syscall.Exec
Please answer these questions before submitting your issue. Thanks! ### What version of Go are you using (`go version`)? `go version go1.8 linux/amd64` (same behavior with 1.8.3) ### What operating system and processor architecture are you using (`go env`)? ``` GOARCH="amd64" GOBIN="" ...
Testing,NeedsFix
low
Critical
239,050,098
vue
Callback refs as additional alternative to "named" refs
### What problem does this feature solve? Currently if you want to use refs to elements (DOM elements or Vue components - see attribute/prop "ref") you have to provide a string as "ref" attribute. A callback function as "ref" attribute like in React is currently not supported in Vue. It would be great if also callbac...
feature request
low
Major
239,079,493
go
x/mobile: SIGABRT when trying to call Go functions on Android
Please answer these questions before submitting your issue. Thanks! ### What version of Go are you using (`go version`)? go version go1.8.3 darwin/amd64 ### What operating system and processor architecture are you using (`go env`)? OSX Sierra 10.12.5 GOARCH="amd64" GOOS="darwin" ### What did you do? 1. Cr...
mobile
low
Critical
239,079,924
TypeScript
Generic functon doesn't resolve type property when accept this as a parameter ?
**TypeScript Version:** 2.4.0 **Code** ```ts function getValue<T, TK extends keyof T>(obj: T, key: TK): T[TK] { return obj[key]; } class TestClass { z: number; testtest1(): number { return getValue(this as TestClass, 'z') + 1; // ok } testtest2(): number { return ...
Bug
low
Critical
239,096,387
rust
Closure arguments are inferred monomorphically
Without an explicit annotation, closure arguments are inferred to have a concrete lifetime. You must manually annotate the argument in order to satisfy a HRTB. ```rust #[derive(PartialEq)] struct Foo; fn use_a_foo(_: &Fn(&Foo)) {} fn main() -> () { // This doesn't compile // let function = |foo_arg...
C-enhancement,A-inference
low
Minor
239,155,747
pytorch
[feature request] time-distributed layers for application of normal layers to sequence data
As we move from images to videos, it seems imperative to feed sequential data into common image layers. However, the problem of dealing sequential data with such layers is not clears on Pytorch. I suggest here to devise something like -time-distributed layers for wrapping normal layers and aligning them for sequential ...
module: nn,triaged
medium
Major
239,275,725
pytorch
Feature Request: ReLU on LSTMs and GRUs
Hello, I would really like the functionality to use a different activation function on the output of the RNNs. I have found ReLU more useful in classification models because, for instance, tanh output from an LSTM makes it easy for a subsequent softmax-linear layer to produce values near .999. Just throwing the idea ou...
feature,module: nn,module: rnn,triaged
low
Major
239,334,944
flutter
Consider migrating AccessibilityNodeProvider to ExploreByTouchHelper
According to the Android Accessibility folks `ExploreByTouchHelper` would be better suitable for our use case as it supposedly already implements much of the logic we need. https://github.com/flutter/engine/blob/1009e9c0977d266c3af7eea3148f855e34006450/shell/platform/android/io/flutter/view/AccessibilityBridge.java#...
platform-android,engine,a: accessibility,P3,team-android,triaged-android
low
Minor
239,481,893
opencv
cv::cudacodec::VideoReaderImpl cannot correctly catch several RTP streams
##### System information (version) - OpenCV => 3.2 - Operating System / Platform => Ubuntu 16.04, x86_64 - Compiler => gcc-5 - Cuda => 8.0 - NVidia Card => GTX 1070 ##### Detailed description When I try to show videos from multiple IP-cameras in one application, I see that all streams is "broken" like here...
bug,priority: low,category: videoio,category: gpu/cuda (contrib)
low
Critical
239,548,740
flutter
Detect incompatible plugin Maven/CocoaPod dependencies
If a developer is using multiple plugins that depend on mutually incompatible Maven or CocoaPods dependencies, it would be nice to detect this and help them resolve it (ideally automatically, but that would require teaching pub to do dependency resolution across both CocoaPods and Maven, which seems hard or even imposs...
tool,t: gradle,t: xcode,P2,a: plugins,team-tool,triaged-tool
low
Minor
239,571,210
go
image: Decode drops interfaces
### What version of Go are you using (`go version`)? 1.8 Background: I am trying to register an image decoder for Webm (to make thumbnails). Commonly the reader passed to `image.Decode()` is an `*os.File` or a `multipart.File`. ### What did you see instead? The Reader passed to the decoder function (register...
NeedsDecision,early-in-cycle
low
Major
239,627,525
TypeScript
2.4: Readonly<Map<k,v>> vs. ReadonlyMap<k,v>
**TypeScript Version:** 2.4.1 **Code** ```ts function GenMap() : ReadonlyMap<string, number> { const theMap = new Map<string, number>(); theMap.set("one", 1); theMap.set("two", 2); return Object.freeze(theMap); } ``` **Expected behavior:** Compiles without error in tsc@<2.4.0 **Act...
Bug,Help Wanted,Domain: lib.d.ts
low
Critical
239,630,869
go
image/gif: decoding gif returns `frame bounds larger than image bounds` error
Please answer these questions before submitting your issue. Thanks! ### What version of Go are you using (`go version`)? ``` go version go1.8.3 darwin/amd64 ``` ### What operating system and processor architecture are you using (`go env`)? ``` GOARCH="amd64" GOBIN="" GOEXE="" GOHOSTARCH="amd64" GOHOSTOS=...
NeedsInvestigation
low
Critical
239,672,855
go
cmd/compile: generate same code regardless of whether return values are named
There's an article at the top of Hacker News right now, https://blog.minio.io/golang-internals-part-2-nice-benefits-of-named-return-values-1e95305c8687 https://news.ycombinator.com/item?id=14668323 ... which advocates for naming return values for the benefit of better generated code. It concludes: > So we ...
NeedsFix,compiler/runtime
high
Critical
239,681,006
TypeScript
`--globalPlugins` and `--pluginProbeLocations` default to list with empty string
**TypeScript Version:** 2.5.0-dev.20170629 **Code** src/server/server.ts, line 758: ```ts const globalPlugins = (findArgument("--globalPlugins") || "").split(","); const pluginProbeLocations = (findArgument("--pluginProbeLocations") || "").split(","); ``` **Expected behavior:** `--globalPlugins...
Bug
low
Critical
239,694,939
vscode
CLI proxy support
- VSCode Version: Code 1.13.1 (379d2efb5539b09112c793d3d9a413017d736f89, 2017-06-14T18:21:47.485Z) - OS Version: Windows_NT ia32 6.1.7601 - Extensions: none --- Steps to Reproduce: Without http.proxy set 1. run "code --install-extension HookyQR.beautify" in CLI 2. Error: getaddrinfo ENOTFOUND marketplace.visua...
feature-request,proxy
low
Critical
239,770,733
opencv
VideoCapture::set (CAP_PROP_POS_FRAMES, frameNumber) not exact in opencv 3.2 with ffmpeg
Example and confirmed effect: http://answers.opencv.org/question/162781/videocaptureset-cap_prop_pos_frames-framenumber-not-exact-in-opencv-32-with-ffmpeg/
bug,priority: low,category: videoio,category: 3rdparty
low
Critical
239,811,810
go
math/big: underflow panic in roundShortest
```go f := new(big.Float).SetPrec(big.MaxPrec).SetFloat64(1) b := f.Append(nil, 'g', -1) ``` panics with the following stack trace: ``` panic: underflow goroutine 1 [running]: math/big.nat.sub(0x0, 0x0, 0x0, 0x104402c0, 0x0, 0x6, 0x180010, 0x1, 0x1, 0x0, ...) /usr/local/go/src/math/big/nat.go:129 +0...
help wanted,NeedsFix
low
Major
239,812,209
TypeScript
HTMLCanvasElement.getContext() wrong typings when used with attributes.
<!-- BUGS: Please use this template. --> <!-- QUESTIONS: This is not a general support forum! Ask Qs at http://stackoverflow.com/questions/tagged/typescript --> <!-- SUGGESTIONS: See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md --> **TypeScript Version:** 2.4.1 **Code...
Bug
low
Critical
239,905,595
go
cmd/compile: add OpAMD64CMPptr and friends?
amd64.rules contains a fair number of rules that are conditional on config.PtrSize, to support amd64p32. See CL 46870 for a recent example. To reduce duplication, I suggest we add ops whose lowering depends on pointer size. So for example, instead of: ``` (IsInBounds idx len) && config.PtrSize == 8 -> (SETB (CMPQ i...
NeedsDecision,compiler/runtime
low
Minor
239,909,828
go
testing: consider calling ReadMemStats less during benchmarking
https://golang.org/cl/36791 reduced the number of times benchmarks call ReadMemStats. However, the implementation was incorrect (#20590, #20863), and it was rolled back (https://golang.org/cl/46612 and https://golang.org/cl/47350). The rationale for the rollback is that ReadMemStats is now fast (https://golang.org/c...
Performance,NeedsFix
medium
Major
239,935,161
opencv
Non-ASCII symbols in source code files
Example (marked by `--> <--`): ``` 202:In the figure below, the Delaunay-->’<<--s triangulation is marked with black lines and the Voronoi 856://! Guil, N., Gonz-->á<--lez-Linares, J.M. and Zapata, E.L. (1999). Bidimensional shape detection using an invariant approach. Pattern Recognition 32 (6): 1025-1038. 958: ...
bug
low
Minor
239,949,568
go
cmd/compile: []byte(string) incurs allocation even when it does not escape
The following Go program reports that the function makes an allocation to do the string to []byte conversion, even though the compiler reports the conversion as non-escaping. https://play.golang.org/p/y2d2RiYqK5 It prints: 48 B/op 1 allocs/op Given that the compiler has marked it as non-escapin...
Performance,help wanted,NeedsFix
low
Major
239,996,755
rust
Confusing error message: the trait `std::ops::Fn<(char,)>` is not implemented for `T`
Hey I am a newbie trying to learn rust following th rust-book(2nd edition). So, I was trying to implement the greps project and I am stuck at the search function. fn search<'a, T>(query: &T, contents: &'a str) -> Vec<&'a str> { let mut results = Vec::new(); for line in contents.lines() {...
C-enhancement,A-diagnostics,T-compiler,D-confusing
low
Critical
240,010,284
flutter
Use a more resilient mechanism for showing the icons on the Icons page
The source code for `icons.dart` looks like this: ```dart /// <p><i class="material-icons md-36">4k</i> &#x2014; material icon named "4k".</p> static const IconData four_k = const IconData(0xe072, fontFamily: 'MaterialIcons'); /// <p><i class="material-icons md-36">ac_unit</i> &#x2014; material icon named...
framework,f: material design,d: api docs,c: proposal,P2,team-design,triaged-design
low
Major
240,013,824
flutter
Flutter tool fails to build on macOS if "gnu-tar" is installed
## Steps to Reproduce Follow the steps from the website: ``` $ git clone -b alpha https://github.com/flutter/flutter.git $ export PATH=`pwd`/flutter/bin:$PATH ``` Then, an error message is produced: ``` Building flutter tool... gzip: (stdin): trailing garbage ignored gzip: (stdin): trailing garbage ignored ...
c: crash,tool,a: first hour,P2,team-tool,triaged-tool
low
Critical