showvikdbz/code-reviews · Datasets at Hugging Face

text stringlengths 1 5.2k	labels listlengths 1 1
maybe a stupid question but why swapping nxadvance and nyadvance does not do the trick more to the point if nxadvance is wrong in this case how come nyadvance is right	[ 0 ]
these seem big enough to warrant factoring out now or just have this overload call the other one that does not cost anything the other way round would cost a useless strlen	[ 0 ]
typo irovic should be ironic	[ 0 ]
i chatted with dale he is on board with moving lines to ffmpeg demuxer tests can you take that on it sounds like you have created a new channel for the decoder to inform the demuxer of a config change if so one thing to be aware of assuming you are still using our decoder stream is that signalling kconfigchanged from the demuxer will result in a flush of the decoder many config changes actually require a different decoder so this makes sense but in your case this is probably wasteful for videos that change size mid way through we just signal the new size to the upper layers and avoid the heavy decoder flush	[ 0 ]
Now it's getting ridiculous. Want a per-item-setting as well?	[ 1 ]
please place private members at the end of the class prefer to use explicit widths int t uint t or size t	[ 0 ]
worth noting you coulda used initial(that_shit_that_killed_sadam.name), it's how you access non list vars off typepaths	[ 1 ]
real application not needed use dummies	[ 0 ]
Spamming the chat is running scripts to ensure the onky thing people see is some stupid bullshit. This would be a good suit for a Disturbing the Peace charge in game.	[ 1 ]
this is a bit too generic is this an hproffielddescriptor	[ 0 ]
Crap I forgot to change this...	[ 1 ]
fake clients fakes fakeclients fake clients keystone fakes fakeclient fake clients keystone services create mock magicmock return value service	[ 0 ]
pidtid pidtid std make pair pid tid	[ 0 ]
LoadMuonNexus is in current use LoadAscii Version 1 used a rubbish format for 2D data, and can be discarded / removed As to wether LoadPreEventNexus v1 can be removed we need to get an answer from @peterfpeterson or @stuartcampbell	[ 1 ]
extra space should be removed	[ 0 ]
may i ask a stupid question who is using this function i did not find any usage of this so instead of reworking it i would suggest to delete it	[ 0 ]
Oh crap, I committed the suggestion from github, then overwrote with my local copy I think, sorry about that	[ 1 ]
Add a joke mod that turns everyone's skin into a random ""femboy"" skin"	[ 1 ]
this should be for obj content in matching ds objects	[ 0 ]
nit useless blank line	[ 0 ]
discovery should be an extension api get os federated providers	[ 0 ]
Nevermind, Im an absolute idiot, the sheep type starting_ammo is valid, I got my checks mixed up, knew it was weird that was happening.	[ 1 ]
iirc u is useful if we want to get output promptly especially on programs like goofy py or tools that open generates logs i do not remember exactly what would break if we do not have u though	[ 0 ]
maybe we should do something to make this backwards compatible instead i use run tests sh so it does not directly affect me	[ 0 ]
should we kill as well mysqld safe see	[ 0 ]
you should call fprintf stderr va args first	[ 0 ]
execution fail here you will need to enclose the string with double quotes also please fix this one as well your you are	[ 0 ]
i think we should talk a bit about this one it could make for some really nasty output on devstack also my devstack logs are already murdering my system	[ 0 ]
fat fingers i guess	[ 0 ]
requesting a smidgen of a buff to `sprayDistance`, which is what i apparently fucked up code failing to do the first time around.	[ 1 ]
of course sorry i am such a dunce today	[ 0 ]
This issue sounds ridiculous. We've got jQuery external script working on angular 5 iirc :))	[ 1 ]
do you need it given setenabled false below or maybe you do not need setenabled	[ 0 ]
Damn it, forgot this, will do in debt week	[ 1 ]
use neutron segment types and cluster net providers from consts py	[ 0 ]
vsql command should be replaced by exec vsql command	[ 0 ]
It's the 'trash can' or 'rubbish bin' to the right of the heap snapshot button at the top left of the screenshot above.	[ 1 ]
yeah it was the only way i could see to allow different providers to set different defaults especially if they do not support the default proposed by the reference implementation btw there is an error in uts which i do not see locally where the service driver is mocked out but validator is not set will push another patch today	[ 0 ]
+100 for lazy load, that's just ridiculous without it.	[ 1 ]
Very imminently time to abandon the nightmare year of Rancher. Ridiculous.	[ 1 ]
Wait wtf is this shit?	[ 1 ]
turns out vehiclecode is still ass anyways > \\<Qustinnus\\> ill eat someones ass before i touch vehicle code again	[ 1 ]
can haz since is a pointless bashism	[ 0 ]
that is really silly coding	[ 0 ]
and of course this should be interpreted in german as the ddr freq the the i am not a murderer you know	[ 0 ]
please use l for retries	[ 0 ]
This is doubly redundant since you already call this in the proc that calls this one, you also check for some shit for some reason while there you just call it without care Remove it all	[ 1 ]
I am confused if I pay the fee will u load the coin. I am not paying the fee if you are still unable to load the coin Also I feel this is ridiculous 1000TWT is a lot to ask because your app does not have this coin.	[ 1 ]
nit we should probably change this to log info just because we are going to trigger a warning here each time through the code otherwise	[ 0 ]
This just happened to me today, ridiculous. I did nothing to prompt it either. This needs to be fixed	[ 1 ]
Can we stack_trace here just in case we're dealing with a shitty `return null` or something else stupid?	[ 1 ]
Damn code generation... fixed it	[ 1 ]
after cleanup parent with no child then only secret should be removed since secret does have a child	[ 0 ]
nyadvance is since it is ltr horizontal duh i knew that was a stupid question	[ 0 ]
The ratios were already loose as fuck anyway	[ 1 ]
do you really need to eval this at make time this is going to execute bash pwd many times maybe you want obj pwd util cbfstool	[ 0 ]
may i suggest solum common yamlutils for consistent behavior wrt load and dump	[ 0 ]
this is wrong as the code is not run from gnocchi but from ceilometer you should ceilometer s prepare service	[ 0 ]
this test is useless sorry you should check that apply all tasks makes a proper exception handling before reraising e q check that error was logged	[ 0 ]
This is weird to read, which in Ruby is upsetting, so put a comment. It's dead clever, no denial, but on a quick pass, my grandmother wouldn't have a clue what this does.	[ 1 ]
vnics r get vnics you could then remove the if statement in the next line	[ 0 ]
i think you are overloading the get items implementation above with the get items x calls below in which case the actual impl of get items does not matter if pass can be used though that would be cleaner imho	[ 0 ]
dammit you found it :(	[ 1 ]
kill too	[ 0 ]
formatting messed up a little.	[ 1 ]
this backslash is unnecessary and should be eliminated	[ 0 ]
missing accessibilitycontroller accessibility controller shell get accessibility controller	[ 0 ]
F**k... Again? \U0001f603	[ 1 ]
Here ya go butch	[ 1 ]
bnextch false achieve the same goal i think cheaper if it is not a space the current character is deemed not consumed yet right bnextch is used to that at the end of the loop	[ 0 ]
bug lp description if you create a custom repository called rabbitmq it will not appear on the openstack or fuel slave nodes after you deploy the environment workaround do not use the rabbitmq name for new repositories in fuel ui isn t it true for all reserved names can we get a list of reserved names that cannot be used for the names of repositories	[ 0 ]
dummy sample mmc values mentioning daisy will probably just confuse people	[ 0 ]
missed doc stings for other than node params	[ 0 ]
indentation happens, but how the fuck and why are braceless ifs discouraged	[ 1 ]
couldn t you just dereference the unique ptrs e g expiration times dictionary i might be missing something though	[ 0 ]
i actually think this space removal might do badness also might be nice to collapse this giant or into a regex	[ 0 ]
remove get allowed nic networkgroups here	[ 0 ]
Broken English once again, but I am beyond giving a fuck.	[ 1 ]
Oh boy, the copypaste is fucking real in here.	[ 1 ]
ur mum is true lol	[ 1 ]
you should rise nose skiptest in setupclass	[ 0 ]
routerinterface router id	[ 0 ]
it should be db api autonested transaction	[ 0 ]
Good fucking riddance, god damn.	[ 1 ]
Fuck off goof, nobody enjoys your memery.	[ 1 ]
How to kill Vox 101. We don\u2019t even need players for shitcurity. Might want to add checks in case they are races that need air tanks to live.	[ 1 ]
this is not testing anything a mocked object mock client init can be called in arbitrary ways and will pass it is not actually running the object s code what you want to do is params param list here with mock patch object client client init as mock client init mock client init return value none neutron neutronapi get client my context mock client init assertcalledoncewith params	[ 0 ]
This bug is ridiculous and ignoring my pull request is quite incomprehensible	[ 1 ]
And these lines are bullshit too :)	[ 1 ]
get everything cache the results and filter them afterwards based on issue entity s last updated field	[ 0 ]
Well crap, now one more test is failing :/	[ 1 ]
God this file is ridiculous \U0001f606. So many Importants! I am still hoping in the future we can write our own search.	[ 1 ]
passive voice must die install the heat cloudfoundry cfn tools with these installed heat will take control of the machine during first boot	[ 0 ]
I've seen CWs for the most ridiculous things (one was literally "repeating patterns") to the point I start questioning the mental health of the one posting it. People clearly abuse it.	[ 1 ]
wtf? dudes, don't you have more important things to do ?? ^^ https://www.odoo.com/survey/start/fiscalyear-or-fiscal-year-157	[ 1 ]
> HOMEBREW_NO_DEVELOPER I haven't tried this branch so I'm probably not entitled to comment, but `HOMEBREW_NO_DEVELOPER` sounds pretty ridiculous and I bet no one will ever set it.	[ 1 ]
sceneresult error timeout	[ 0 ]
Fixed. Damn you, copy/paste.	[ 1 ]
i think the sequence above could be formatted so if not self is repo initialized elif self is out of date else	[ 0 ]
is this matching against the jobname if so we should change it to tripleo ci so it does not match the gate puppet tripleo puppet lint jobs	[ 0 ]

maybe a stupid question but why swapping nxadvance and nyadvance does not do the trick more to the point if nxadvance is wrong in this case how come nyadvance is right

[ 0 ]

these seem big enough to warrant factoring out now or just have this overload call the other one that does not cost anything the other way round would cost a useless strlen

[ 0 ]

typo irovic should be ironic

[ 0 ]

i chatted with dale he is on board with moving lines to ffmpeg demuxer tests can you take that on it sounds like you have created a new channel for the decoder to inform the demuxer of a config change if so one thing to be aware of assuming you are still using our decoder stream is that signalling kconfigchanged from the demuxer will result in a flush of the decoder many config changes actually require a different decoder so this makes sense but in your case this is probably wasteful for videos that change size mid way through we just signal the new size to the upper layers and avoid the heavy decoder flush

[ 0 ]

Now it's getting ridiculous. Want a per-item-setting as well?

[ 1 ]

please place private members at the end of the class prefer to use explicit widths int t uint t or size t

[ 0 ]

worth noting you coulda used initial(that_shit_that_killed_sadam.name), it's how you access non list vars off typepaths

[ 1 ]

real application not needed use dummies

[ 0 ]

Spamming the chat is running scripts to ensure the onky thing people see is some stupid bullshit. This would be a good suit for a Disturbing the Peace charge in game.

[ 1 ]

this is a bit too generic is this an hproffielddescriptor

[ 0 ]

Crap I forgot to change this...

[ 1 ]

fake clients fakes fakeclients fake clients keystone fakes fakeclient fake clients keystone services create mock magicmock return value service

[ 0 ]

pidtid pidtid std make pair pid tid

[ 0 ]

LoadMuonNexus is in current use LoadAscii Version 1 used a rubbish format for 2D data, and can be discarded / removed As to wether LoadPreEventNexus v1 can be removed we need to get an answer from @peterfpeterson or @stuartcampbell

[ 1 ]

extra space should be removed

[ 0 ]

may i ask a stupid question who is using this function i did not find any usage of this so instead of reworking it i would suggest to delete it

[ 0 ]

Oh crap, I committed the suggestion from github, then overwrote with my local copy I think, sorry about that

[ 1 ]

Add a joke mod that turns everyone's skin into a random ""femboy"" skin"

[ 1 ]

this should be for obj content in matching ds objects

[ 0 ]

nit useless blank line

[ 0 ]

discovery should be an extension api get os federated providers

[ 0 ]

Nevermind, Im an absolute idiot, the sheep type starting_ammo is valid, I got my checks mixed up, knew it was weird that was happening.

[ 1 ]

iirc u is useful if we want to get output promptly especially on programs like goofy py or tools that open generates logs i do not remember exactly what would break if we do not have u though

[ 0 ]

maybe we should do something to make this backwards compatible instead i use run tests sh so it does not directly affect me

[ 0 ]

should we kill as well mysqld safe see

[ 0 ]

you should call fprintf stderr va args first

[ 0 ]

execution fail here you will need to enclose the string with double quotes also please fix this one as well your you are

[ 0 ]

i think we should talk a bit about this one it could make for some really nasty output on devstack also my devstack logs are already murdering my system

[ 0 ]

fat fingers i guess

[ 0 ]

requesting a smidgen of a buff to `sprayDistance`, which is what i apparently fucked up code failing to do the first time around.

[ 1 ]

of course sorry i am such a dunce today

[ 0 ]

This issue sounds ridiculous. We've got jQuery external script working on angular 5 iirc :))

[ 1 ]

do you need it given setenabled false below or maybe you do not need setenabled

[ 0 ]

Damn it, forgot this, will do in debt week

[ 1 ]

use neutron segment types and cluster net providers from consts py

[ 0 ]

vsql command should be replaced by exec vsql command

[ 0 ]

It's the 'trash can' or 'rubbish bin' to the right of the heap snapshot button at the top left of the screenshot above.

[ 1 ]

yeah it was the only way i could see to allow different providers to set different defaults especially if they do not support the default proposed by the reference implementation btw there is an error in uts which i do not see locally where the service driver is mocked out but validator is not set will push another patch today

[ 0 ]

+100 for lazy load, that's just ridiculous without it.

[ 1 ]

Very imminently time to abandon the nightmare year of Rancher. Ridiculous.

[ 1 ]

Wait wtf is this shit?

[ 1 ]

turns out vehiclecode is still ass anyways > \\<Qustinnus\\> ill eat someones ass before i touch vehicle code again

[ 1 ]

can haz since is a pointless bashism

[ 0 ]

that is really silly coding

[ 0 ]

and of course this should be interpreted in german as the ddr freq the the i am not a murderer you know

[ 0 ]

please use l for retries

[ 0 ]

This is doubly redundant since you already call this in the proc that calls this one, you also check for some shit for some reason while there you just call it without care Remove it all

[ 1 ]

I am confused if I pay the fee will u load the coin. I am not paying the fee if you are still unable to load the coin Also I feel this is ridiculous 1000TWT is a lot to ask because your app does not have this coin.

[ 1 ]

nit we should probably change this to log info just because we are going to trigger a warning here each time through the code otherwise

[ 0 ]

This just happened to me today, ridiculous. I did nothing to prompt it either. This needs to be fixed

[ 1 ]

Can we stack_trace here just in case we're dealing with a shitty `return null` or something else stupid?

[ 1 ]

Damn code generation... fixed it

[ 1 ]

after cleanup parent with no child then only secret should be removed since secret does have a child

[ 0 ]

nyadvance is since it is ltr horizontal duh i knew that was a stupid question

[ 0 ]

The ratios were already loose as fuck anyway

[ 1 ]

do you really need to eval this at make time this is going to execute bash pwd many times maybe you want obj pwd util cbfstool

[ 0 ]

may i suggest solum common yamlutils for consistent behavior wrt load and dump

[ 0 ]

this is wrong as the code is not run from gnocchi but from ceilometer you should ceilometer s prepare service

[ 0 ]

this test is useless sorry you should check that apply all tasks makes a proper exception handling before reraising e q check that error was logged

[ 0 ]

This is weird to read, which in Ruby is upsetting, so put a comment. It's dead clever, no denial, but on a quick pass, my grandmother wouldn't have a clue what this does.

[ 1 ]

vnics r get vnics you could then remove the if statement in the next line

[ 0 ]

i think you are overloading the get items implementation above with the get items x calls below in which case the actual impl of get items does not matter if pass can be used though that would be cleaner imho

[ 0 ]

dammit you found it :(

[ 1 ]

kill too

[ 0 ]

formatting messed up a little.

[ 1 ]

this backslash is unnecessary and should be eliminated

[ 0 ]

missing accessibilitycontroller accessibility controller shell get accessibility controller

[ 0 ]

F**k... Again? \U0001f603

[ 1 ]

Here ya go butch

[ 1 ]

bnextch false achieve the same goal i think cheaper if it is not a space the current character is deemed not consumed yet right bnextch is used to that at the end of the loop

[ 0 ]

bug lp description if you create a custom repository called rabbitmq it will not appear on the openstack or fuel slave nodes after you deploy the environment workaround do not use the rabbitmq name for new repositories in fuel ui isn t it true for all reserved names can we get a list of reserved names that cannot be used for the names of repositories

[ 0 ]

dummy sample mmc values mentioning daisy will probably just confuse people

[ 0 ]

missed doc stings for other than node params

[ 0 ]

indentation happens, but how the fuck and why are braceless ifs discouraged

[ 1 ]

couldn t you just dereference the unique ptrs e g expiration times dictionary i might be missing something though

[ 0 ]

i actually think this space removal might do badness also might be nice to collapse this giant or into a regex

[ 0 ]

remove get allowed nic networkgroups here

[ 0 ]

Broken English once again, but I am beyond giving a fuck.

[ 1 ]

Oh boy, the copypaste is fucking real in here.

[ 1 ]

ur mum is true lol

[ 1 ]

you should rise nose skiptest in setupclass

[ 0 ]

routerinterface router id

[ 0 ]

it should be db api autonested transaction

[ 0 ]

Good fucking riddance, god damn.

[ 1 ]

Fuck off goof, nobody enjoys your memery.

[ 1 ]

How to kill Vox 101. We don\u2019t even need players for shitcurity. Might want to add checks in case they are races that need air tanks to live.

[ 1 ]

this is not testing anything a mocked object mock client init can be called in arbitrary ways and will pass it is not actually running the object s code what you want to do is params param list here with mock patch object client client init as mock client init mock client init return value none neutron neutronapi get client my context mock client init assertcalledoncewith params

[ 0 ]

This bug is ridiculous and ignoring my pull request is quite incomprehensible

[ 1 ]

And these lines are bullshit too :)

[ 1 ]

get everything cache the results and filter them afterwards based on issue entity s last updated field

[ 0 ]

Well crap, now one more test is failing :/

[ 1 ]

God this file is ridiculous \U0001f606. So many Importants! I am still hoping in the future we can write our own search.

[ 1 ]

passive voice must die install the heat cloudfoundry cfn tools with these installed heat will take control of the machine during first boot

[ 0 ]

I've seen CWs for the most ridiculous things (one was literally "repeating patterns") to the point I start questioning the mental health of the one posting it. People clearly abuse it.

[ 1 ]

wtf? dudes, don't you have more important things to do ?? ^^ https://www.odoo.com/survey/start/fiscalyear-or-fiscal-year-157

[ 1 ]

> HOMEBREW_NO_DEVELOPER I haven't tried this branch so I'm probably not entitled to comment, but `HOMEBREW_NO_DEVELOPER` sounds pretty ridiculous and I bet no one will ever set it.

[ 1 ]

sceneresult error timeout

[ 0 ]

Fixed. Damn you, copy/paste.

[ 1 ]

i think the sequence above could be formatted so if not self is repo initialized elif self is out of date else

[ 0 ]

is this matching against the jobname if so we should change it to tripleo ci so it does not match the gate puppet tripleo puppet lint jobs

[ 0 ]