showvikdbz/code-reviews · Datasets at Hugging Face

text stringlengths 1 5.2k	labels listlengths 1 1
these should be disposed in dispose right	[ 0 ]
@NanoXD : well that's rubbish :( Oddly it seems to work ok using wget, it only does this with curl? A	[ 1 ]
remove operator useless here	[ 0 ]
unrelated to your change but this should be one line dobin factory setup update firmware vars py die	[ 0 ]
bool built fixed codes false here no need to set it in constructor i think you could also do the same for all the vector resizes	[ 0 ]
for what purpose we want that fk	[ 0 ]
please get rid of trailing white space	[ 0 ]
curse you english language!!!	[ 1 ]
thanks for renaming all those it is really a place to make dumb mistakes	[ 0 ]
i do not get why you are adding a novaobject directly in the test why are not you mocking what you want and play with these fake objects	[ 0 ]
egor i think the registry container is not on master node it is on each minion slave node	[ 0 ]
oh i missed that you were calling getpackage joiner does not need to operate on strings it will call tostring on objects etc but that is not right here so scratch my comment	[ 0 ]
Awful idea, death is a fact of life on space station 13.	[ 1 ]
sometimes auto-formatting sucks :-)	[ 1 ]
> Why the hell is it that I click "Add comment" instead of "Review" but it gets listed as a review anyways? Ignore it. It is a comment, we understand, GitHub just has funny language.	[ 1 ]
In freeform, this does not make any sense. free form should allow a user to type whatever they want in the textbox. Not allowing a space is ridiculous in this case.	[ 1 ]
I have slept on the ground before with nothing but a coat, as have many other people. It sucks but it is certainly possible. @Night-Pryanik why is this not a bug? If it wasn't supposed to be possible to sleep on the ground it wouldn't be an option.	[ 1 ]
let s assume i am an idiot shouldn t be hard what if i am using neutron recognize this is likely a section wide issue	[ 0 ]
iface transport name	[ 0 ]
put str split instead of str replace	[ 0 ]
Gosh damn Bay and their snowflake.	[ 1 ]
n jsonutils dumps must be used instead of json dumps	[ 0 ]
done yes those settings can be derived by executing syncontrol diag	[ 0 ]
no they don't you butt read all of spell code	[ 1 ]
Ah shit, forgot to remove some debugging.	[ 1 ]
Damn, I can't spell. Fixed.	[ 1 ]
this is not how traits are ordered, please dont fuck it more	[ 1 ]
Wtf is that stupid shit hahaha	[ 1 ]
can this be removed in favor of adding a autorequire in the type description like here l l	[ 0 ]
did you undef this? not sure if github is shitting itself viewing this file but i don't see it	[ 1 ]
Damn, this was not working earlier - https://github.com/astronomer/astro-sdk/actions/runs/3931016955/jobs/6721731345	[ 1 ]
STOP FUCKING THE LINE ENDINGS OF FILES fix your editor config please	[ 1 ]
> abcdefg420 on Windows 69. Cut that nonsense out. That requirement is not there to annoy people. Do you expect annoying us deliberately will help with anything?	[ 1 ]
I have fixed the bug. Damn implicit flag!	[ 1 ]
agree reported for this	[ 0 ]
it d totally be cached by id in sqlalchemy though if only we could convince people to just do a get instead of a freaking sql query every time	[ 0 ]
this should be a plog error and then return false see the failure is fatal handling in the mounts above	[ 0 ]
this is a hideous way of dealing with polymorphism	[ 0 ]
can you use alarm definition id here i would like to get rid of alarm definition id since it is redundant	[ 0 ]
you should rather nest the mocks that way with mock patch as a mock patch as b do	[ 0 ]
you still pollute the class with hook and post and whatnot please see below how to avoid it	[ 0 ]
that's fiiiine, just board that ship damnit we're on top of it (never had the case of it being 0) more seriously yeah that may be an issue, I'll fix it, well spotted	[ 1 ]
you need to make SURE that the wielder will return to a normal alpha value when this item gets unwielded, dropped, or destroyed, or else people are gonna abuse the shit outta this	[ 1 ]
That's the critical bug. to prevent it add lots of unnecessary conditions. That's totally ridiculous. ;(	[ 1 ]
i was not sure what you wanted to dcheck took a stab	[ 0 ]
> It is, buuuut..... it's also utter nonsense and should ALSO be removed or reigned in (mostly it's too fast and produces too much power). Metabolic Interchange is already king of power supply, so we're basically giving the players even fewer reasons to NOT use MI. I mean we could balance the systems that exist with gameplay constraints in mind, or we could go for full realism and just remove CBMs entirely.	[ 1 ]
that way a controllable guardian owned by an npc never gon have u on threatlist unless u attack him. this fucks up errythang else	[ 1 ]
We can continue talking about this change in details, but I find that a bit ridiculous because it's not a very large change in the end. I'm just waiting for #1340 to finally be merged in order to do it.	[ 1 ]
ok i get why you have got those print statements in there kill them and invoke the test with v it will give you better output making those prints unnecessary for debugging development of these unittests frankly unittest runner s default of being stupidly quiet is obnoxious	[ 0 ]
done changed to expect list and look for this error exactly before killing	[ 0 ]
More info: Basically, no matter how you close the integrated terminal, as long as you close it by terminating the task inside, or throw it away with the rubbish bin icon, or whatever other methods, the same error pops up	[ 1 ]
Alright, this is getting ridiculous, we've had to manually whitelist every PR from Qi...	[ 1 ]
a couple pep violations on this line	[ 0 ]
( i am of course talking about SECRET CONTENT and if you don't do this im going to shit and piss my pants like a jerk)	[ 1 ]
nit unneeded initialization	[ 0 ]
wait hold on no its just shitcode youre right	[ 1 ]
reserved percentage and max used ratio are both ignored here and this formula is the free virtual capacity we better change the weigher name to relfect this or should this weigher simply returns host state provsioned capacity gb directly	[ 0 ]
This is an obvious regression and the "arguments" calling it as a feature is nonsense. Holding shift is for waypoints and not for target lines.	[ 1 ]
these nopcode have of course to be efacopcode then	[ 0 ]
bauzas it seems you ar right just getting the services here filtering the disabled ones and then getting the compute nodes for those hosts would be what we want to do	[ 0 ]
seems that you do not need self clinet session and self node mocks in this test case	[ 0 ]
it seems that this lswitches is not being used	[ 0 ]
ABC order? people totally messed it up right above you	[ 1 ]
the code of this is awful, how did it get merged? hell, the ckey is being manually changed by a new proc	[ 1 ]
Closing this PR then. @jmacd I'm rubbish at benchmarking so would prefer you do it given you have a pretty clear idea of what you want to test, etc.\t	[ 1 ]
including uinput fd is useless	[ 0 ]
docstrings are absolutely hideous for this kind of thing if we have enough of these cases it might make sense to use a templating library like jinja	[ 0 ]
bool returns false why do not you just say self ecomnoverification false	[ 0 ]
This is completely ridiculous!! If the REST API is not supporting the creation of Visual Swatches with swatch options, you should write it down here!	[ 1 ]
Whoah guys, parrots may be able to dismember now, srs buff.	[ 1 ]
system pwr is tricky power status py should have exposed this make system pwr a constant	[ 0 ]
why create a function instead of just using readlink script dir readlink f dirname	[ 0 ]
instead of the export can we just do a return also probably be good citizen and set apache version to local so we do not pollute the namespace	[ 0 ]
LastAccess change is also not working on Catalina, currently I have tools I use almost daily on my main mac running Mojave. This issues is currently preventing me from upgrading to Catalina which sucks!	[ 1 ]
deprecated opts should be removed as there is no connect timeout in compute	[ 0 ]
it fires magazines? now that's badass	[ 1 ]
recommend changing stucked stuck	[ 0 ]
the neutron server is monkey patched for all the modules	[ 0 ]
a backquote looks a garbage	[ 0 ]
shouldn t it be class ironic common boot devices	[ 0 ]
i think that here should be fuel plugin example v group	[ 0 ]
le translators log error maybe we are right	[ 0 ]
this comment needs to be removed	[ 0 ]
oh my god what is this	[ 1 ]
yes i should remove this useless change	[ 0 ]
> duglin closed this on Sep 1, 2015 @duglin This is a ridiculous and infuriating issue and should not be closed. The `COPY` command behaves specifically in disagreement with the documented usage and examples.	[ 1 ]
i still prefer this returning a non valid client after all that client is the one still selected in the ui and if you want to know pid or something from it it is better to still keep it we could have an action that could still work on dead processes like analyze why it crashed or whatever for which this needs to return the dead client	[ 0 ]
ya..... fucking DM needs a spell check	[ 1 ]
makes sense but if that is the kind of restriction someone wants to enforce could not they just use the policies setting instead of the roles i do not mean to be a jerk i am just trying to understand what extending the semantics of the roles style property protections gets you that is not already available from the policies style property protections	[ 0 ]
we need the script to be executed here	[ 0 ]
leave the overlines in	[ 0 ]
I was keeping this pull request open as a reminder to implement this functionality, but realized that I won't do it any time soon, and it started to become ridiculous. So with heavy heart, I'm closing this... Sorry, @shayel.	[ 1 ]
>gunk soup >it's so thick you can eat it with a fork jesus christ how horrible	[ 1 ]
s vid vid s pid pid also the first occurrence of vid and pid should be spelled out	[ 0 ]
done	[ 0 ]
well why do not you just use instead of xf	[ 0 ]
...Did you really copypaste the code this literally? How the shit does `rand(...)` even compile? When I wrote that snippet for you I assumed you'd fill in the rand...	[ 1 ]
good catch stupid rebase i hate rebase thank you	[ 0 ]
could you remove this comment while you are here it s nonsense given line and only makes code harder to understand	[ 0 ]
Kinda sucks if you have this from an opsec perspective though. If incident responders come along and hit your URL, it'll just be a closed connection where every other URL will give a 200.. Kinda suspicious no?	[ 1 ]

these should be disposed in dispose right

[ 0 ]

@NanoXD : well that's rubbish :( Oddly it seems to work ok using wget, it only does this with curl? A

[ 1 ]

remove operator useless here

[ 0 ]

unrelated to your change but this should be one line dobin factory setup update firmware vars py die

[ 0 ]

bool built fixed codes false here no need to set it in constructor i think you could also do the same for all the vector resizes

[ 0 ]

for what purpose we want that fk

[ 0 ]

please get rid of trailing white space

[ 0 ]

curse you english language!!!

[ 1 ]

thanks for renaming all those it is really a place to make dumb mistakes

[ 0 ]

i do not get why you are adding a novaobject directly in the test why are not you mocking what you want and play with these fake objects

[ 0 ]

egor i think the registry container is not on master node it is on each minion slave node

[ 0 ]

oh i missed that you were calling getpackage joiner does not need to operate on strings it will call tostring on objects etc but that is not right here so scratch my comment

[ 0 ]

Awful idea, death is a fact of life on space station 13.

[ 1 ]

sometimes auto-formatting sucks :-)

[ 1 ]

> Why the hell is it that I click "Add comment" instead of "Review" but it gets listed as a review anyways? Ignore it. It is a comment, we understand, GitHub just has funny language.

[ 1 ]

In freeform, this does not make any sense. free form should allow a user to type whatever they want in the textbox. Not allowing a space is ridiculous in this case.

[ 1 ]

I have slept on the ground before with nothing but a coat, as have many other people. It sucks but it is certainly possible. @Night-Pryanik why is this not a bug? If it wasn't supposed to be possible to sleep on the ground it wouldn't be an option.

[ 1 ]

let s assume i am an idiot shouldn t be hard what if i am using neutron recognize this is likely a section wide issue

[ 0 ]

iface transport name

[ 0 ]

put str split instead of str replace

[ 0 ]

Gosh damn Bay and their snowflake.

[ 1 ]

n jsonutils dumps must be used instead of json dumps

[ 0 ]

done yes those settings can be derived by executing syncontrol diag

[ 0 ]

no they don't you butt read all of spell code

[ 1 ]

Ah shit, forgot to remove some debugging.

[ 1 ]

Damn, I can't spell. Fixed.

[ 1 ]

this is not how traits are ordered, please dont fuck it more

[ 1 ]

Wtf is that stupid shit hahaha

[ 1 ]

can this be removed in favor of adding a autorequire in the type description like here l l

[ 0 ]

did you undef this? not sure if github is shitting itself viewing this file but i don't see it

[ 1 ]

Damn, this was not working earlier - https://github.com/astronomer/astro-sdk/actions/runs/3931016955/jobs/6721731345

[ 1 ]

STOP FUCKING THE LINE ENDINGS OF FILES fix your editor config please

[ 1 ]

> abcdefg420 on Windows 69. Cut that nonsense out. That requirement is not there to annoy people. Do you expect annoying us deliberately will help with anything?

[ 1 ]

I have fixed the bug. Damn implicit flag!

[ 1 ]

agree reported for this

[ 0 ]

it d totally be cached by id in sqlalchemy though if only we could convince people to just do a get instead of a freaking sql query every time

[ 0 ]

this should be a plog error and then return false see the failure is fatal handling in the mounts above

[ 0 ]

this is a hideous way of dealing with polymorphism

[ 0 ]

can you use alarm definition id here i would like to get rid of alarm definition id since it is redundant

[ 0 ]

you should rather nest the mocks that way with mock patch as a mock patch as b do

[ 0 ]

you still pollute the class with hook and post and whatnot please see below how to avoid it

[ 0 ]

that's fiiiine, just board that ship damnit we're on top of it (never had the case of it being 0) more seriously yeah that may be an issue, I'll fix it, well spotted

[ 1 ]

you need to make SURE that the wielder will return to a normal alpha value when this item gets unwielded, dropped, or destroyed, or else people are gonna abuse the shit outta this

[ 1 ]

That's the critical bug. to prevent it add lots of unnecessary conditions. That's totally ridiculous. ;(

[ 1 ]

i was not sure what you wanted to dcheck took a stab

[ 0 ]

> It is, buuuut..... it's also utter nonsense and should ALSO be removed or reigned in (mostly it's too fast and produces too much power). Metabolic Interchange is already king of power supply, so we're basically giving the players even fewer reasons to NOT use MI. I mean we could balance the systems that exist with gameplay constraints in mind, or we could go for full realism and just remove CBMs entirely.

[ 1 ]

that way a controllable guardian owned by an npc never gon have u on threatlist unless u attack him. this fucks up errythang else

[ 1 ]

We can continue talking about this change in details, but I find that a bit ridiculous because it's not a very large change in the end. I'm just waiting for #1340 to finally be merged in order to do it.

[ 1 ]

ok i get why you have got those print statements in there kill them and invoke the test with v it will give you better output making those prints unnecessary for debugging development of these unittests frankly unittest runner s default of being stupidly quiet is obnoxious

[ 0 ]

done changed to expect list and look for this error exactly before killing

[ 0 ]

More info: Basically, no matter how you close the integrated terminal, as long as you close it by terminating the task inside, or throw it away with the rubbish bin icon, or whatever other methods, the same error pops up

[ 1 ]

Alright, this is getting ridiculous, we've had to manually whitelist every PR from Qi...

[ 1 ]

a couple pep violations on this line

[ 0 ]

( i am of course talking about SECRET CONTENT and if you don't do this im going to shit and piss my pants like a jerk)

[ 1 ]

nit unneeded initialization

[ 0 ]

wait hold on no its just shitcode youre right

[ 1 ]

reserved percentage and max used ratio are both ignored here and this formula is the free virtual capacity we better change the weigher name to relfect this or should this weigher simply returns host state provsioned capacity gb directly

[ 0 ]

This is an obvious regression and the "arguments" calling it as a feature is nonsense. Holding shift is for waypoints and not for target lines.

[ 1 ]

these nopcode have of course to be efacopcode then

[ 0 ]

bauzas it seems you ar right just getting the services here filtering the disabled ones and then getting the compute nodes for those hosts would be what we want to do

[ 0 ]

seems that you do not need self clinet session and self node mocks in this test case

[ 0 ]

it seems that this lswitches is not being used

[ 0 ]

ABC order? people totally messed it up right above you

[ 1 ]

the code of this is awful, how did it get merged? hell, the ckey is being manually changed by a new proc

[ 1 ]

Closing this PR then. @jmacd I'm rubbish at benchmarking so would prefer you do it given you have a pretty clear idea of what you want to test, etc.\t

[ 1 ]

including uinput fd is useless

[ 0 ]

docstrings are absolutely hideous for this kind of thing if we have enough of these cases it might make sense to use a templating library like jinja

[ 0 ]

bool returns false why do not you just say self ecomnoverification false

[ 0 ]

This is completely ridiculous!! If the REST API is not supporting the creation of Visual Swatches with swatch options, you should write it down here!

[ 1 ]

Whoah guys, parrots may be able to dismember now, srs buff.

[ 1 ]

system pwr is tricky power status py should have exposed this make system pwr a constant

[ 0 ]

why create a function instead of just using readlink script dir readlink f dirname

[ 0 ]

instead of the export can we just do a return also probably be good citizen and set apache version to local so we do not pollute the namespace

[ 0 ]

LastAccess change is also not working on Catalina, currently I have tools I use almost daily on my main mac running Mojave. This issues is currently preventing me from upgrading to Catalina which sucks!

[ 1 ]

deprecated opts should be removed as there is no connect timeout in compute

[ 0 ]

it fires magazines? now that's badass

[ 1 ]

recommend changing stucked stuck

[ 0 ]

the neutron server is monkey patched for all the modules

[ 0 ]

a backquote looks a garbage

[ 0 ]

shouldn t it be class ironic common boot devices

[ 0 ]

i think that here should be fuel plugin example v group

[ 0 ]

le translators log error maybe we are right

[ 0 ]

this comment needs to be removed

[ 0 ]

oh my god what is this

[ 1 ]

yes i should remove this useless change

[ 0 ]

> duglin closed this on Sep 1, 2015 @duglin This is a ridiculous and infuriating issue and should not be closed. The `COPY` command behaves specifically in disagreement with the documented usage and examples.

[ 1 ]

i still prefer this returning a non valid client after all that client is the one still selected in the ui and if you want to know pid or something from it it is better to still keep it we could have an action that could still work on dead processes like analyze why it crashed or whatever for which this needs to return the dead client

[ 0 ]

ya..... fucking DM needs a spell check

[ 1 ]

makes sense but if that is the kind of restriction someone wants to enforce could not they just use the policies setting instead of the roles i do not mean to be a jerk i am just trying to understand what extending the semantics of the roles style property protections gets you that is not already available from the policies style property protections

[ 0 ]

we need the script to be executed here

[ 0 ]

leave the overlines in

[ 0 ]

I was keeping this pull request open as a reminder to implement this functionality, but realized that I won't do it any time soon, and it started to become ridiculous. So with heavy heart, I'm closing this... Sorry, @shayel.

[ 1 ]

>gunk soup >it's so thick you can eat it with a fork jesus christ how horrible

[ 1 ]

s vid vid s pid pid also the first occurrence of vid and pid should be spelled out

[ 0 ]

done

[ 0 ]

well why do not you just use instead of xf

[ 0 ]

...Did you really copypaste the code this literally? How the shit does `rand(...)` even compile? When I wrote that snippet for you I assumed you'd fill in the rand...

[ 1 ]

good catch stupid rebase i hate rebase thank you

[ 0 ]

could you remove this comment while you are here it s nonsense given line and only makes code harder to understand

[ 0 ]

Kinda sucks if you have this from an opsec perspective though. If incident responders come along and hit your URL, it'll just be a closed connection where every other URL will give a 200.. Kinda suspicious no?

[ 1 ]