text
stringlengths 1
5.2k
| labels
listlengths 1
1
|
|---|---|
I\u2019d be more suspicious of the changes to stats, but I couldn\u2019t see anywhere that\u2019d matter. The LB code does a lot of wacky stuff though, so it\u2019s hard to tell.
|
[
1
] |
notifies that existing baseaudiocontext has been destroyed
|
[
0
] |
Damn, I though I fixed this.
|
[
1
] |
this is subclass of power test power test
|
[
0
] |
So if both the `translate` are removed, then `BrushItem` won't work.
|
[
1
] |
let s remove these two lines i do not see how they are being used
|
[
0
] |
it should be metadata secret
|
[
0
] |
Oh, I see... yucky code structure but it might be correct
|
[
1
] |
This is an awful way of dealing with telesci, arbitrary blocking an area without any justification in-game. Plus, this is a balance change and we are in a freeze.
|
[
1
] |
endif config lid angle tablet mode
|
[
0
] |
why not pci device updated at timeutils utcnow
|
[
0
] |
please remove a white space
|
[
0
] |
sLog->outDebug(LOG_FILTER_POOLSYS, "%u", mapId); // pussywizard: for crashlogs in end of func
|
[
1
] |
remove all of this audio init down to end of function
|
[
0
] |
live migration tunnelled
|
[
0
] |
I actually agree. Eating shit food should make you feel like shit.
|
[
1
] |
I can't follow basic instructions and everything is fucked now
|
[
1
] |
i fucked this up badly
|
[
1
] |
remove useless braces in this method
|
[
0
] |
pretty shitty quality also the whole spell is already a reference edti: I forgot there's already a much less awful za warudo sound for stoptime
|
[
1
] |
can you add a comment about why a pid would be less than
|
[
0
] |
SHOULD_NOT_SLEEP() is a weird lint. It is EXTREMELY aggressive and ignores `set waitfor = FALSE`, it would require an UNLINT() wrap which is uglier imo.
|
[
1
] |
wow this is amazing
|
[
0
] |
nullam quis risus eget urna mollis orare vel eu leo cum sociis natoque penatibus et magnis dis parturien montes nascetur ridiculus mus is shorter
|
[
0
] |
because i was being stupid the code is slightly less stupid now
|
[
0
] |
Did they not switch this one to `main`? They did it for the emscripten repo, but i don't know about emsdk. (Did I mention how much i fucking hate this branch-renaming braindeath?)
|
[
1
] |
thats ok worthless commented out code imho kill in fire
|
[
0
] |
you are not returning anything here you are raising a notimplemented exception
|
[
0
] |
well sweet
|
[
0
] |
wat is the point of if it means you produce dead code if the code is dead it should be removed
|
[
0
] |
to apronin s comment in case reading does not make it into gsctool but instead into some other command script per louiscollard s suggestion what happens while trunksd is stopped we need to check sn bits during chrome os startup too to provide a new key value pair to the session manager would stopping trunksd then if it is running and later restarting it risk breaking things now or later
|
[
0
] |
Because whitespace damnit.
|
[
1
] |
Wow, it's fucking nothing
|
[
1
] |
i do not think this field needs to be string i think is ok it will be dumps to string in self post json
|
[
0
] |
i apparently have gone through this idea but no base encoding is an internal implementation detail of syncprefs which of course makes the local variable above useless removed
|
[
0
] |
remove both of these they are completely redundant
|
[
0
] |
you missed indexer init py
|
[
0
] |
OMG, did you fucking not see the OP, mainly the final checkmark. Like holy shit if you aren't gonna read, don't fucking comment.
|
[
1
] |
blank line between bullets for consistency
|
[
0
] |
possibly dumb question iiuc this handlemessage should already bound to the instance just as a result of instantiating the class does this do something else or is that assumption not the case
|
[
0
] |
pkill kill dns
|
[
0
] |
Disgusting comment leftover
|
[
1
] |
sachi juno is end of life there should not be any project that you are touching that uses juno
|
[
0
] |
useless comment
|
[
0
] |
delete the vport to vporttag bindings
|
[
0
] |
crap man can you also change the indentation to tabs
|
[
1
] |
the annoying thing is that it pulls in a big pile of crap, EpochIncompleteSlots, and all the compression stuff
|
[
1
] |
you do not need the above for releases
|
[
0
] |
While having a bunch of strings that all say the same thing is rather ridiculous, in this case I think we should keep it that way since it allows for more customization (for instance, you can change the subject of the welcome email depending on the situation).
|
[
1
] |
how about we move this to setsensitive and maybe also rename it to msensitiveinitialized then we could potentially also remove all other calls to updatevetobutton from the outside to only have the update in here in this class that would be much cleaner the current code is so ugly d i proably even wrote part of it
|
[
0
] |
will using the extra l kill you protocol is so much better than proto
|
[
0
] |
You\u2019re right, it should. I think I screwed up the definition of auto_capitalization when I first wrote it. Fixing now.
|
[
1
] |
wow those getslice s are ugly
|
[
0
] |
This is darn cryptic for me.
|
[
1
] |
what the fuck are these checks?
|
[
1
] |
nit let s write bindrepeating ditto for other callbacks
|
[
0
] |
well the interface would be a jinja template on the controller but i feel pretty strongly that this is a centralize intelligence kind of issue octavia vms should be as dumb as possible so the ability to generate their own haproxy configurations is something i don t want them to have to do
|
[
0
] |
uniqueptrs are automatically nulled however it just occurred to me that if a kdf instance were reused and init ed again the salt would contain the previous value i will revert that bit
|
[
0
] |
use mocks why do you use object fake server mock magicmock
|
[
0
] |
bug is a bit extreme here just bail out instead same goes for the other uses of bug here
|
[
0
] |
have you looked at the rest of the methods in this this is how it is been done it is just a dumb logging noop driver and storing the parameters passed in as keys and if there are many parameters it stores them all since you cannot use a dictionary or object as a key you have to use a primitive type thats all this is doing it is not very complex and not very useful bc it is a logging noop driver
|
[
0
] |
danalbert made this unnecessary we have even started to remove them in places
|
[
0
] |
unfortunately that will not pass the linter cros src platform dev cros lint f apache l module dev apache log metrics c wrong continued indentation chromeos delta test bin bad continuation c wrong continued indentation chromeos full test bin bad continuation
|
[
0
] |
i begin with apologies because i do not know much about cassandra and it is client support but i have a proper stupid question for you why does not this class if not module exist in the client a lot of this seems to be ceilometer agnostic
|
[
0
] |
so they need to run mkdir p etc keystone domains before running puppet or is it that they need to have a file resource for the etc keystone domains directory in their puppet manifest
|
[
0
] |
Ah yeah, I forgot about that. I think we would need to do 1 then, and while it won't always be 100% accurate, someone would have to really screw things up and there are more likely to encounter a parse error in the compiler.
|
[
1
] |
did you write this code? or is it copied from somewhere?
|
[
1
] |
i thought it would make sense to guard a useless operation but i am fine with dropping it too
|
[
0
] |
if tenant id and c conf cisco n k restrict network profiles
|
[
0
] |
Being frank it looks gross.
|
[
1
] |
useless
|
[
0
] |
i do not thinks this is going to scale and looks odd should we change it so textitemcolorblack starts at we should be able to check if a color has been set or not any other ideas just as an fyi if the if else condition body has only one line you can skip the though i do not mind re adding them
|
[
0
] |
Ahh damn... good catch
|
[
1
] |
The bug is actually the var/current_type = parent_type line below this. src is null because of some fuckery
|
[
1
] |
would it make more sense to make this team domain dummy as well so users do not confuse it as being a valid string
|
[
0
] |
i would suggest attaching volume to iso instance results in failure like this
|
[
0
] |
aah, add_disease() calls combat text, yuck.
|
[
1
] |
you do not use expected attrs so it should be removed
|
[
0
] |
@lucasmichot Why? Do you think these little refactorings are rubbish ;)
|
[
1
] |
doins resolv conf die
|
[
0
] |
this is a shitpost pr gia, check out the one linked above.
|
[
1
] |
Yeah, kinda screwed up moving things around there. I'll fix it up.
|
[
1
] |
Because I don't want to fuck up things being animated on a person for no reason
|
[
1
] |
exceptions by utils execute should be handled
|
[
0
] |
These names are getting pretty long. Also, "home from house arrest" sounds weird.
|
[
1
] |
errno enomem
|
[
0
] |
you can probably kill this comment now
|
[
0
] |
Huh, I must've totally missed that in my reading. Damn
|
[
1
] |
gotcha perfect
|
[
0
] |
instead of passing every mock every time to this function you could do something like that def setup self patcher mock patch object someobjcet qwerty self mock request patcher start def configure mock self responses self mock request return value fake response remember to stop all mocks in teardown
|
[
0
] |
remove pyc
|
[
0
] |
self attributes schema cls facade attributes schema
|
[
0
] |
silly nit i would prefer snapshot instead of snap
|
[
0
] |
The `/datum/proc/Destroy()` is a DIRECT hard del, it would fuck up pooling. blame @eswordthecat
|
[
1
] |
instead of if else how about this if self ca file kwargs cert reqs ssl cert required ca certs self ca file else kwargs cert reqs ssl cert none self sock ssl wrap socket sock self key file self cert file kwargs
|
[
0
] |
according to file con s only sh is shell exec so vold can create this and execute it seems suspect
|
[
0
] |
skip test payloads should be dropped entirely the skip test payloads should actually be named disable tests
|
[
0
] |
nah its dumb, there is `FetchBlockMetadataResultsPool` and `FetchBlocksMetadataResultsPool` (note the `s`)
|
[
1
] |
add some way to interact with this, even if it's just getting your hand annihilated because you stuck it in the devil's mouth like a dumbass
|
[
1
] |
They should never be located in a locker or such. If this happens then something got fucked up majorly and it should cause a runtime
|
[
1
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.