text
stringlengths 1
5.2k
| labels
listlengths 1
1
|
|---|---|
it s better to call cls isolated creds get alt creds to keep consistency with cls isolated creds is multi tenant
|
[
0
] |
same here it should be a datetime datetime object
|
[
0
] |
Remove all the \\improper shit as well it breaks areas
|
[
1
] |
updated at should be nullable false because upon insertion it should and will be set
|
[
0
] |
did you mean to leave this comment in? lol
|
[
1
] |
This is kind of ridiculous as this point. The bug has been open for almost 8 months. Nobody seems to care.
|
[
1
] |
argparse is dirt simple you have already re implemented a bunch of the infrastructure at this point
|
[
0
] |
i think that delete orphan will be useless since the fk cannot be made null anyways so there is not a case where secret user metadata instance can be an orphan
|
[
0
] |
remove six and unnecessary outer for ret value
|
[
0
] |
monaudioinfochangedcalled should be false
|
[
0
] |
update i put up a new patchset with a protoappender interface which is used as the argument to appendtoproto instead it is a little bit more indirect but avoids the dependency ptal
|
[
0
] |
mea culpa of course we do not want these here i will remove them
|
[
0
] |
the hell? I'd say nerf plastic,
|
[
1
] |
done
|
[
0
] |
visualization py is an example i think it is better to add a colon i am not sure it is a correct sentence
|
[
0
] |
Its strange that this kind of sanity isn't like, way the fuck higher up.
|
[
1
] |
> Storybook has got a wacky diff. I checked the branch out locally and it looked fine. Please take a look before merging. Looks like it is due to the storybook comparing the diff to an earlier version of the pr instead of `main`.
|
[
1
] |
Oh nice find! When I was going through my transactions, I noticed that occasionally it was paying absolutely ridiculous fee rates. I had assumed it was a problem with the fee estimation, but I'm guessing I was hit by this.
|
[
1
] |
argh stupid mistake on my part thanks
|
[
0
] |
we were told to remove these from our cinder drivers as cinder team is not ready to adopt this yet just use x as before
|
[
0
] |
i see why you did it this way in just a straight removal of the tuskar stuff but it looks goofy outside of that context can we just use template name instead of this local var
|
[
0
] |
there is now a comment on the etherpad about whether we should stick with this approach for versioning will do this if we stick with that solution
|
[
0
] |
This is a fucking whitelist. Look at this monster, it even fucking uses the : operator.
|
[
1
] |
great catch
|
[
0
] |
remove initcap
|
[
0
] |
the above two lines are the ugly hack that fixes the weird offset with orbiting/transform.
|
[
1
] |
this logic manipulate json data as a string it is really a bad idea json is a string representation of a structured data so we should manipulate the data first and then dump it as json this means params request post copy cleanup params return json dumps params if post data is nested you need to use copy deepcopy
|
[
0
] |
Don't make two PRs in the same branch, god damnit
|
[
1
] |
die is like a logging command pass in the args and let it do the string formatting for you die foo s bar
|
[
0
] |
should be if not sample filter start timestamp or not sample filter end timestamp
|
[
0
] |
you should probably catch these as they just get wrapped in the wrapper method execute rpc with a clierror that collects the exception message though i do not feel strongly about this but it seems like you should either not catch any exceptions and raise exceptions instead of or catch them all and translate them into s
|
[
0
] |
Wanna try something for me? Change the `(if (faceup? ...` part of the msg to instead use `card-str` and see how that reads. If it reads like shit, leave this as is.
|
[
1
] |
I moved this from the .30 section for consistency. I forgot to add the "SA BR .20" shit.
|
[
1
] |
Ok, understood. Sorry for the clumsy lack of eloquence in describing what I thought was a bug. I am wondering if there is a timeline to clone the entire site to the .onion version, and also if having most of the site as a subdomain is a limiting factor?
|
[
1
] |
pls docstring
|
[
0
] |
The fact that before, these were initializing pref datums, is horrific.
|
[
1
] |
use contextlib nested for the mocks so they are in the same scope rather than nesting them explicitly like this
|
[
0
] |
what the fuuuuuuuuuuck
|
[
1
] |
this should not work it should be ap spec mode n which you need to import all of the self stuff should removed
|
[
0
] |
endif android
|
[
0
] |
Agreed, this behavior is ridiculous, and makes #8720 impossible (https://github.com/numpy/numpy/issues/8720#issuecomment-383198263)
|
[
1
] |
or the simpler if mrefreshprogressrunnable null removecallbacks mrefreshprogressrunnable mrefreshisposted false
|
[
0
] |
ditto albeit self stack resume
|
[
0
] |
might want to force this. Antidrop can probably fuck it up
|
[
1
] |
this should not be called every time check bw is called since check bw merely checks the bandwidth and should not handle the actual file s existance i suggest calling this before the wait until true you can even call this multiple times until the size is correct using another wait until true for this
|
[
0
] |
should this be uknownformfieldtypeexception or unknownformfieldtypeexception
|
[
0
] |
useless this is already done by the amqpdriver amqpdriverbase base class
|
[
0
] |
marking this as a good first BR was ridiculous
|
[
1
] |
It kinda sucks that we have multiple versions of these things. :/ I don't have a better idea rn though.
|
[
1
] |
You're an awful person
|
[
1
] |
this is such a nit i feel like an idiot even mentioning it if not x with an else always bugs me i always have to double take by the time you get to else because it is a double negative this pattern is below and not something you need to change just a rant
|
[
0
] |
there s no need for conditional import here subprocess should be monkey patched by eventlet at this point
|
[
0
] |
replication partners should not be hardcoded here
|
[
0
] |
nit condense this into a call to addgroup header
|
[
0
] |
not defined should be pick fuel settings ldap ca chain false
|
[
0
] |
this comment should be put in textcontrolelement h
|
[
0
] |
what does that mean again self bootloader params self bootloader params bootloader params
|
[
0
] |
comments of alembic should be removed
|
[
0
] |
fuck, how did I not notice this
|
[
1
] |
> Having "perverted" and "horny"-named underwear is absolute cringe. Rename or better yet, remove them. And no back briefs too because they are a crime against humanity really. got it.
|
[
1
] |
should this be remote path instead of final path
|
[
0
] |
vnics r get vnics you could then remove the if statement in the next line
|
[
0
] |
This looks like some clang-format insanity.
|
[
1
] |
tbh i sort of think this makes the notification agent too dumb
|
[
0
] |
i want to be sure that the cgroup is set before running the jailed process if it forks a child before it is in a cgroup then the child could escape the cgroup
|
[
0
] |
can you reword this a little also the bug report itself is a little confusing
|
[
0
] |
without this i get make no rule to make target linker needed by all modules stop an empty linker does not build the symlink at all
|
[
0
] |
Closing this is ridiculous, I'm reopening.
|
[
1
] |
it s better to check the existence of toolchain src dir first
|
[
0
] |
don t you mean kargo kult
|
[
0
] |
THERES THE LITTLE FUCKER!
|
[
1
] |
... damn, ofc I forgot that
|
[
1
] |
WHAT IS THAT WHAT. THE. FUCK. IS. THAT?
|
[
1
] |
This Windows hang is bizarre
|
[
1
] |
use language mask primary x ff instead of x ff
|
[
0
] |
just tried it, it would definitely be harder and more shitcode to do it like that then it is to do it like this, ahahahaha, gonna resolve this then
|
[
1
] |
you are not appending any new datasets in this class is this a wip
|
[
0
] |
i do not even know why idea inserted this here killing
|
[
0
] |
Damn, I misread the code and thought that this wasn't needed anymore...
|
[
1
] |
nit you do not need to set a return value
|
[
0
] |
i believe that imagecopyfailed should be raised here
|
[
0
] |
according to comment above all self client should be replaced on self barbican
|
[
0
] |
i am not sure how useful keeping track of changes is for objects that get saved as json so i propose to either add a flag that will allow novaobject subclasses to not track this at all if they do not care or additionally make obj reset changes recurse into subobjects like obj what changed does but having this code here for the sake of being pedantic seems wrong to me
|
[
0
] |
daemon user group attribute are currently useless i will finish the refactor in next ps
|
[
0
] |
Travis seems to be really wacky today... https://travis-ci.org/druid-io/druid/jobs/103683274
|
[
1
] |
I'm so used to bots merging, that it feels bizarre that only a handful of repos in @kubernetes use Tide. Manual merging seems like such a foreign concept lol. :upside_down_face:
|
[
1
] |
But that's weird, it should be compiling, such syntax is used in tons of other places already.
|
[
1
] |
Don't do this. Typecasting lists does nothing functionally, but makes them a pain in the ass to grep for.
|
[
1
] |
this looks odd you might write it like this instead to clean it up a bit from setuptools command sdist import sdist sdist run self
|
[
0
] |
amqp is already listed below
|
[
0
] |
I'm fucking wrong ``` if(M.health > M.maxHealth) M.health = M.maxHealth ```
|
[
1
] |
this was also kind of bugging me so i followed nova s tool conf as a convension
|
[
0
] |
sudo will reset path which will break in some cases especially outside the chroot i copied you on cl where this was discussed maintaining the path path from above will fix this
|
[
0
] |
should we do that even if we are not actually visible iow should we call getwidget startcompositor instead
|
[
0
] |
user id is resource id false will be needed here
|
[
0
] |
too homosexual, turn down the homosexuality a bit please
|
[
1
] |
It should lead to a compilation error normally, that's weird.
|
[
1
] |
this function and the pthread once t are not needed if you initialize the mutex with pthread mutex initializer
|
[
0
] |
urgh, we really need to fix that global thing
|
[
1
] |
no need to be root use
|
[
0
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.