text
stringlengths 1
5.2k
| labels
listlengths 1
1
|
|---|---|
Apart from the CI failure I identified as irrelevant, all CIs are happy at this point. That makes this PR ready for review. @hlandau, this touched a lot of code you're written, please take an extra look to see that I haven't screwed things up too badly...
|
[
1
] |
you have some white spaces at the end of this line
|
[
0
] |
I think this bug is real; I've seen too many bugs in kestrel where I/O errors get reported as other nonsense rather than bubbling up as the I/O errors they are and turning into 5xx HTTP error codes.
|
[
1
] |
hard to tell but this makes it seem like mapping was fucked up and the map wasn't properly paused?
|
[
1
] |
use die instead of echo exit
|
[
0
] |
What the actual fuck? This should just be `access_card.access = get_all_accesses()` You should never directly create a job datum.
|
[
1
] |
nit random full stop in the middle of a sentence
|
[
0
] |
re written this to be more explicit about the function causing the address flush done
|
[
0
] |
Cae is right on this one, ghosts are vindicative little bastards and often curators will make a oujia board on the holodeck so ghosts can reveal who the valids are, or what the round type is. Good riddance
|
[
1
] |
seems that u can not use delete router to delete the router created by admin client it will complain it does not find the router that is why i use delete router instead of the self delete router thanks
|
[
0
] |
i am not familiar with this sorry if this is dumb i see that some html resources have flattenhtml true allowexternalscript true type bindata see for example while others have type chrome html preprocess true or only type chrome html see line below is this normal
|
[
0
] |
fix missing period ,just merge it you giant faggot
|
[
1
] |
What do you mean by `fucky wiring`?
|
[
1
] |
sec profile serialization security profile gettext return value
|
[
0
] |
thanks looks like i am stupid p
|
[
0
] |
this creates the service tenant domain but not the admin user domain or admin tenant domain
|
[
0
] |
not related to your change what a terrible name this is not a constant
|
[
0
] |
please put your s o b on the line following the cherry picked from line
|
[
0
] |
you are missing cleaning constraint mask e constraints mask struct rprm constraints data data mask
|
[
0
] |
Dammit, I managed to miss this one.
|
[
1
] |
Holy shit finally, maybe once this gets merged new cult wont be as shit.
|
[
1
] |
This `dictionary_symptoms` list isn't even used anywhere...the hell.
|
[
1
] |
nit this needs spaces before obsolete like registering to devtools
|
[
0
] |
changed resp self ssh lsfcconsistgrp fc map id keep this function the same
|
[
0
] |
Ugh, gosh darn it, through no fault of yours master has an issue. Fixing in https://github.com/backstage/backstage/pull/6793 - you can rebase on top of that already to be proactive, if you are daring. That way you won't have to wait for it to be merged and _then_ rebase on master and _then_ wait for us to merge yours :)
|
[
1
] |
If you're going to do this, at least make cloning less awful beforehand. I think it was Razharas who made it take far longer than it used to and far longer than it needs to without upgrades. The addition of the defib by Paprika and the use of patches by the crew was simply a workaround for the fuck-awfulness of the cloner.
|
[
1
] |
add override for all methods implementing the interface also i like them in the same order as the interface declaration and if it makes sense have them together maybe it is easier to change icard order pick your poison
|
[
0
] |
this line of vws here breaks my mental parser i would keep the entire if block together
|
[
0
] |
i am not sure it makes sense to pause a shut off instance
|
[
0
] |
Damn, I thought we have this covered in our Eslint Config. Followup issue: https://github.com/adeira/universe/issues/2022
|
[
1
] |
this function may be more readable if there were comments with examples of what the expected inputs look like
|
[
0
] |
done and added this to my vimrc to avoid these silly mistakes autocmd filetype gitcommit set spell
|
[
0
] |
i wonder if we can put all these dirty magic stuff into something like lvsd py or edid py
|
[
0
] |
it looks like some chars get lost here also are not that pythonic but that is nitpicking
|
[
0
] |
is it simpler to leave master version def run ostf self args kwargs self fuel web run ostf self cluster id args kwargs
|
[
0
] |
consider adding id so that the pid of this script instead of the logger process is logged
|
[
0
] |
pathetic nit can you please align metadata default true help
|
[
0
] |
No link to the duplicate? Just a bald assertion that it is a duplicate, from a bot. Will not be wasting my time on this project any further. The text editor is an embarrassment, it can't even auto-indent an if statement correctly, what a ridiculous "programmer's" editor.
|
[
1
] |
Dang it, read the code wrong! I'll revert this line
|
[
1
] |
Finally the bastard has passed all verifications. Hitting the green button for a new release
|
[
1
] |
useless
|
[
0
] |
annoying nits weight properties
|
[
0
] |
That line is weird and redundant.
|
[
1
] |
remove these docstrings
|
[
0
] |
Damn it seems the database I linked to is not that up to date. You can make electronic scrap by disassembling circuits. Edit: and I did find the smalls storage batteries on a food cart, but they are pretty rare.
|
[
1
] |
nit i would suggest that exposing the zlib return values here is overkill the client of such a function is only concerned about uncompressing the whole file otherwise it would be using the gzx functions directly so just make it return a boolean true for success false for failure
|
[
0
] |
misformed or malformed or maybe just incorrect
|
[
0
] |
isn t it bluetooth device kerrorauthenticationcanceled here and the dbus error for failed should be convertsmpairerrortodbuserror change pairerr
|
[
0
] |
This allows me to both cleanup type-guards before calling `hasOwn` (I don't need to ensure it's a `'string'` type) and encourages callers to just pass in `any`thing. Because `any` _nonsense_ will get caught and/or filtered out.
|
[
1
] |
why the fuck is this a chem reaction and not an on_turf_apply
|
[
1
] |
is it possible that the current network will not have a key that matches if so then indexerror
|
[
0
] |
defining segment index becomes useless here comes useless
|
[
0
] |
yea nevermind I realized it would make no sense. Shit! I gotta figure something out for this then I guess!
|
[
1
] |
yeah, was gonna make it adjust fire stacks but then it becomes hellwater/burning spore toxin 2.0
|
[
1
] |
the product option does not seem to be used by this script probably a left over of experimentation
|
[
0
] |
should this be kwargs get os cert kwargs get cert file for backward compat
|
[
0
] |
done did you want me to remove the previously existing apple ifdefs
|
[
0
] |
pdb should be removed
|
[
0
] |
you handle a bad merge conflict this line should not exist
|
[
0
] |
dobin t clang sh die
|
[
0
] |
Righty-o. It is more obvious that it has to be reverse, since the difference between small values only comes out to a big value when they have different signs. I'm pleased with this patch, especially since it clearly states that you can't trust hardware worth a damn.
|
[
1
] |
must execute get python exec prefix
|
[
0
] |
remove std move
|
[
0
] |
those should probably be mock patch object instead
|
[
0
] |
we will refine to clean int cond and int type at end of wait event interruptible timeout
|
[
0
] |
do not you want the q flag otherwise it might output junk you do not want you probably also want to throw in c so no random ascii chars show up helps when output is dumped
|
[
0
] |
You made this pr because a borg dragged you to the brig, so you had somebody else write shove code into a borg module while you fucking signed the code and wrote salt comments into the actual fucking code itself and gave the pr a shitty title hoping nobody would read into just how awful it was.
|
[
1
] |
oh damn, sorry for that
|
[
1
] |
we could rewrite this with poll method net utils findusableethdevice condition lambda ret ret false
|
[
0
] |
I know the example is a bit rubbish (just importing a basic type from 1 project into another, and the other way around). My actual reason (in a private project) for needing recursive dependencies is because I use tRPC for 2-way connection between 2 programs and each project needs to import the AppRouter type from the other project.
|
[
1
] |
Wait... `GenerateRnd` can return a negative value? The hell....... I'll take a look.
|
[
1
] |
This is still a problem in 2023. PowerShell is a ridiculous joke at this point.
|
[
1
] |
extra fk
|
[
0
] |
i would prefer to not have ugly hacks here depend on the output of help seems very fragile
|
[
0
] |
yes i want to remove the asynccompilejob before the promise gets resolved however therefore i have to keep the job alive somewhere after the job gets removed here
|
[
0
] |
These are a weird one... `NAVI_ENEMY_MOBLIN` and `NAVI_ENEMY_MOBLIN_CLUB` are "used" but the dialogs just repeat the text id like most uninitialized dialogs.
|
[
1
] |
i think the race is here daemons stop gets called right after finalizerwatchdogdaemon wakeup we finalize the object but leave needtowork as true when we exit the running loop watchdog daemon begins sleeping then also gets interrupted by daemons stop however needtowork is still true which causes a false positive timeout maybe we should set needtowork to false before finalizerdaemon run exits
|
[
0
] |
you do not need subst here it s better to write it as ifneq use dex oat debug false dex oat dex oatd endif dex oat dependency dex oat
|
[
0
] |
Reworked the code in a more c++-idiomatic way.
|
[
1
] |
please kill this intermediate variable too just reference self libvirtconnection directly as the existing tests do
|
[
0
] |
Damn, this system is very useful :-)
|
[
1
] |
We don't want to fuck up the OPENSPACE_LAYER for everywhere else it's being used.
|
[
1
] |
yeah just like the one here below sorry i am dumb
|
[
0
] |
should be puppet ceilometer i think
|
[
0
] |
I promise we'll get to this one day :sob:
|
[
1
] |
This sucks! `createItems` should completely abstract this `data: {}` BS - this confuses so many people.
|
[
1
] |
this is an xtremio snapset not openstack object the name is correct
|
[
0
] |
its a reference to what the goggles are modeled after, fucking normie
|
[
1
] |
> ALL CHECKS HAVE PASSED LET THE MEMES BEGIN I am ready for this shitshow.
|
[
1
] |
a space is needed after failed le import pywbem failed
|
[
0
] |
these shemas shoudn t be deleted i think
|
[
0
] |
Damn, good catch! Will change.
|
[
1
] |
Hooray! This will feel like a victory every damn time I see or use it.
|
[
1
] |
we send x kill to process in while loop why send one more we should return ocf err generic here if kill not killed our process pacemaker should move resource to unmanaged stonith should kill node in current approach we will hide problem from pacemaker user which can lead to strange galera behavior data loss but this dosent mean that problem disappears
|
[
0
] |
If all the members are internal then it'll look rubbish :-)
|
[
1
] |
Hmm, well we can parse /proc/mounts to link these up. The next piece would be knowing when one of our filesystems was mounted, and I'm not aware how to do that yet, other than reading /proc/mounts periodically. (yuck)
|
[
1
] |
yes i mean test create instance is called only with vnuma enabled false i did not find other usages like test create instance vnuma enabled true
|
[
0
] |
updated i am shamed for the stupid mistake
|
[
0
] |
consider ipv pid s i honestly speaking it seems better to delegate dnsmasq process managment to externalprocess module
|
[
0
] |
this function is getting really ugly can you rewrite it to clean up the error handling and the above bug
|
[
0
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.