text
stringlengths 1
5.2k
| labels
listlengths 1
1
|
|---|---|
momre shitty comments
|
[
1
] |
Holy shit this is very burn Nice
|
[
1
] |
this should be moved into repositoryexternal mk and gb library use externals should be used here
|
[
0
] |
this should be for arm only which is actually a standing bug on my part i forgot to move this a while ago these really ought to be export includes of libunwind llvm do you want me to fix up the android mk first
|
[
0
] |
similarly here const updatemanifestresult result out
|
[
0
] |
i see you moved the datastore code into esx i guess i had it backwards
|
[
0
] |
can we call this current executor since we already have self executor and self executor
|
[
0
] |
probably a dumb question but is limits a feature of all apis to where it should be in the base
|
[
0
] |
move up in sort order and remove the blank line above
|
[
0
] |
yep time sleep gets monkey patched into eventlet sleep
|
[
0
] |
why the fuck is this 28 armour pen??
|
[
1
] |
every daemon should get it is own uid gid
|
[
0
] |
God how did I miss that.
|
[
1
] |
oh i see we cannot restorecon them because they are immediately unlinked after creation and we cannot label them at creation time because they precede policy load the tmpfs chr file rules for dev null in init fsck toolbox healthd and ueventd might be obsolete though due to the change to use sys fs selinux null had not noticed that change to init
|
[
0
] |
nit could you reorder this to be consistent with v utilities py
|
[
0
] |
I don't like these checks, isn't this proc runtiming because of changelings fuck ups with dna?
|
[
1
] |
return value assignment you reassing it in l iianm
|
[
0
] |
please do not use addcleanup with mocks set mocks either via decorators better or via context managers
|
[
0
] |
this promotes bad behavior of calling mocked objects during the test preparation or assertion making it hard to use mock clients assert called once with after this tl dr mocks are for the tested code to call not for the test itself
|
[
0
] |
the opposite of un scoped i will add a comment on next respin
|
[
0
] |
now that unittest is working for presenter you should also add it here test py goofy goofy presenter unittest py
|
[
0
] |
Please don't submit nonsense PRs, as it wastes time for the project maintainers.
|
[
1
] |
bad indentations
|
[
0
] |
It's not really an issue because they arent immune to rads so they need to get the fuck out. I'll add a prob check to reduce the amount of messages.
|
[
1
] |
Made this TURF_WET_LUBE since walking on oil is fucking hard even with boots.
|
[
1
] |
i am not sure that moving the copyright across causes any actual harm the reality is that these copyright lines are mostly useless anyways people should use git
|
[
0
] |
Who the fuck lands shots more than two screens away intentionally, prove it
|
[
1
] |
this function is useless
|
[
0
] |
Nothing else I can think of has a failure message when thrown, it's kinda weird; also it means someone can just spam this message with hotkeys. My suggestion would be to axe it.
|
[
1
] |
this does not capture distinguish the case where ssh fails because the host crashes during the update you should be able to catch that case with code like this result e args if result exit status this is an ssh failure not an update engine failure
|
[
0
] |
Fixme's are easy to search for. ```suggestion // XXX YUCK I don't know how else to get the keybindings // FIXME: Find a better way to get bound keys ```
|
[
1
] |
@thinkyhead the step loss was for junction deviation - traditional jerk is fine for step loss even at absurdly high values. One thing I'm wondering is whether the jerk and junction deviation values are in terms of the print head or the motors. Since my machine is a CoreXY it might explain the slower than normal cornering speeds. Also, I've noticed that in Klipper there's a feature that caps the speed during movements too short to reach nominal speed. Something like this could make for smoother movements in curves rather than constantly being accelerating/decelerating between vertices and would be interesting to look into.
|
[
1
] |
i know it is kind of stupid but there was a requirement that said that there should not be a period at the end of first line in commit messages not sure if it is still true
|
[
0
] |
so i think this target should run the generator with the fix flag so people just need to run a tox command to fill in missing uuids similar to what we do with genconfig sean is correct that we want the check to be part of the check of the pep target when we start enforcing this also in the future can we put python here my stupid distro made python python which will probably because me trouble here fwiw iirc there is a pep on only using python if it supports both python and python
|
[
0
] |
if you blindly kill all your worker threads then you loose all you rwork in progress and the only cleanup we have for that currently is in early manager startup we need to make this clean regarding work in progress else it is no better than kill restart
|
[
0
] |
why get rid of this die it seems good
|
[
0
] |
this newline should be removed to comply with hacking rules
|
[
0
] |
Either buff or make a multiblock that isn't trying to be biggus dickus with a trannie
|
[
1
] |
The machine cannot be broken, only admin fuckery can free then. Might still consider deleting the target and noting if they were alive
|
[
1
] |
Ya it kinda sucks lol https://developer.mozilla.org/en-US/docs/Web/API/Event/timeStamp
|
[
1
] |
Disregard this, brain fart.
|
[
1
] |
so this function will never throw an error that surprises me a bit just returning false here might result in wrong decisions in client code which sees the status success you set below
|
[
0
] |
Dammmnnn you were quite exhaustive for the "does nothing" cases as well. Did you end up writing code to specifically exclude those scenarios or were you trying to be just extra sure?
|
[
1
] |
this seems incongruous we should call them self nb ovn self sb ovn
|
[
0
] |
I use "stupid" of Japanse "\u99ac\u9e7f\u3052\u3066\u308b". Is "ridiculous" correct word?
|
[
1
] |
it will be killed when the screen exits
|
[
0
] |
Ok, got it, thanks. This is some wacky, yet documented edge case. > ... By default, '^' matches only at the beginning of the string, and '$' only at the end of the string and immediately before the newline (if any) at the end of the string.
|
[
1
] |
@mdo, that's not a good option. in fact that nav thing only work with "one line" text buttons, anything higher than 1 line will break things. I'm not trying to use a ridiculous amount of text, but in my use case it must have two lines.
|
[
1
] |
this is extremely evil code and most likely not necessary at all to get this pr working
|
[
1
] |
looks like the spacing got screwed up here
|
[
1
] |
sdkconstants attr translatable sdkconstants value false
|
[
0
] |
I suck at reading, carry on.
|
[
1
] |
Damnit I searched for old debug!! :see_no_evil:
|
[
1
] |
hooray for killing layout client after edge never understood that one
|
[
0
] |
what the hell is perl doing in here?
|
[
1
] |
the logic of clear astute logs and clear puppet logs can be done with one method i e def clear logs self astute false puppet false
|
[
0
] |
nah type errors happen when you try to assign compare dosomething with it this way it actually works as a pointless null statement as well if really want to do such a weird thing
|
[
0
] |
Damn this was quick, keep it up you awesome people :-)
|
[
1
] |
please remove whitespaces
|
[
0
] |
use int systemcodevalue and put checks below in try block
|
[
0
] |
why the move netaddr is party
|
[
0
] |
the dbusproperties proxy is created by and used by the modem object and that class has it is own set of unit tests to confirm the proxy is created and used correctly modemmanager s unit tests need to confirm only that the modem init is called it does that by making sure the task factory is not empty after the call we could go a step further and run the event loop but seems redundant ideally we would peek into the factory or the even loop and confirm that the pending task is inittask
|
[
0
] |
it will be good also describe available params for this mcollective agent in net probe ddl file as for example or
|
[
0
] |
useless comment
|
[
0
] |
what in the goddamn. what is this semicolom voodoo
|
[
1
] |
doesnt really make sense for a ship graveyard in this ass end of nowhere nullspace to be full of stations
|
[
1
] |
well i personnally prefer using explicit comparisons like if x is not none y z
|
[
0
] |
i think the futures of the classdefitemconsumers need to be handled
|
[
0
] |
this should probly be removed from here and use the rootwrapers since you are using this as root
|
[
0
] |
We just hit this now, this is ridiculous... So glad this issue exists because it's just bitten us big time... \U0001f616
|
[
1
] |
use mphonebase setsystemproperty instead don t import systemproperties
|
[
0
] |
Actually, the real problem is that our sequence/sprite loading code is a ridiculous mess. We should just revert #3130 for now so we can get the stable release out, and then aim to solve this properly in the next release cycle.
|
[
1
] |
...Ah, yes. Messed up there. Fixed now.
|
[
1
] |
sorry there is also a stupid bug i will fix this in next patch
|
[
0
] |
Note: the diff algo displays this a bit goofy.
|
[
1
] |
remove this left over from experimentation with std current exception that havn t worked
|
[
0
] |
it is harmless and we want them all dead anyway this will be called from unstack sh or clean sh and unfortunately localrc may have changed
|
[
0
] |
please remove std move here as this is now a repeatingcallback
|
[
0
] |
i see that s the error because you are trying to overwrite existing dir with symlink while rsync a was to fix symlink overwriting broken symlink probably better to write a python script to do the copy so you can select whatever to copy
|
[
0
] |
then let us fix nailgun agent i really don like to see that data assumptions so deep in the code boolean update by agent must die or used at least somewhere really near the http handler not so deep in the code
|
[
0
] |
nit istest
|
[
0
] |
table l agent fip rt tbl
|
[
0
] |
ok chatted in irc this is desired we want to kill the loop when you change the page
|
[
0
] |
nit it would be nice to have this rename ndb utils as db utils so that it is consistent across all the files in this patch
|
[
0
] |
Creepy json in our code 
|
[
1
] |
die
|
[
0
] |
gah none of this is mine please oslo just take it c
|
[
0
] |
thats ok worthless commented out code imho kill in fire
|
[
0
] |
fix this docstring docstrings
|
[
0
] |
Tests blue except for some unrelated nonsense.
|
[
1
] |
Crap, this ate some suicide messages for some reason - hold on
|
[
1
] |
i think die is appropriate here
|
[
0
] |
it's fucking awful, all other cases are tied with magic related files, if there's duplicate code elsewhere IT'S NOT AN EXCUSE TO KEEP ADDING MORE.
|
[
1
] |
nit please move inside trans
|
[
0
] |
can you annotate new load flags has new load flags
|
[
0
] |
Someone using a voice changer to impersonate someone else? Let me whip out my project mind real quick so I can instantly confirm there are 2 identical names on the list. Sure there are, let me call them a faggot real quick. Oh that's who they really are.
|
[
1
] |
Yeah, the edges are pretty shit But, at least in my opinion, even just the pure blue boxes look better than the AWFUL supermatter sea
|
[
1
] |
damn... next try ;-)
|
[
1
] |
i think you wnated osic
|
[
0
] |
the problem is here oslo config a tar gz egg oslo config a oslo config a tar gz egg oslo config a
|
[
0
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.