showvikdbz/code-reviews · Datasets at Hugging Face

text stringlengths 1 5.2k	labels listlengths 1 1
Note this sucks... but is the only way to test old XNA FBXs.	[ 1 ]
This is absolutely ridiculous the X-Forwarded-For field is not supported in IIS. I need to use grok patterns in Logstash because this isn't there and it's essentially double work every time I update my agents.	[ 1 ]
remove this thing you added, also we have a fucking config on the server. we don't use this config.	[ 1 ]
done super lame mistake from me	[ 0 ]
are you sure it should be uid not id with fk	[ 0 ]
Thanks for the review. I'm so tired from immigration nonsense I rushed this patch. I'll do my best to get it ready for another r? ASAP.	[ 1 ]
If you read the documentation every time, and aren't cocky enough to think you remember from the last time, a number of months earlier, yes...	[ 1 ]
Can you make this a define? I don't like SCREAMING_VARIABLES when they're just normal variables, confusing.	[ 1 ]
i would expect get by instance to take an instance object maybe a better name is get by instance uuid	[ 0 ]
you need to return here now execution continues to line where we would crash	[ 0 ]
This is ridiculous. Manually merging.	[ 1 ]
Nothing :fingerguns: I just copied the shit over. The SoundGunshot can be removed. I'm not too sure for the FireRateSelector (we don't have any weapons that can switch firerate yet)	[ 1 ]
I see. Crappy design.	[ 1 ]
If this exists it should be a strict downgrade, fireaxe bones are hellish enough as it is.	[ 1 ]
translation func should be used	[ 0 ]
oh dammit, how did I miss that?	[ 1 ]
subnet request subnet cidr is already an ipnetwork instance therefore the call at line will be useless even if harmless as well	[ 0 ]
Just did a bit of a wacky rebase. Could i get a set of \U0001f440 here?	[ 1 ]
Good change, invisible things that affect gameplay suck I'd suggest making a "holy" shiny/bright/hallelujah/blessed overlay over blessed floors, it would fix issues like the xenobio blueprints etc	[ 1 ]
clang-format did this? looks like crap	[ 1 ]
the first one is for failures during load prelink this one for spinfo link image failures	[ 0 ]
this javadoc seems out of date parentstyle is not there anymore and some other params are missing	[ 0 ]
well , there is no such thing as "Lightning Movement" , and hell is movement too long to use as a practical word , so i chose that	[ 1 ]
remove python specific boolean representations disabled	[ 0 ]
Why would REST be better than powershell? this is ridiculous. Powershell is so much better than REST API. Following your logic c# compiler is so much better then minesweeper. Ofc you can do more with c# compiler, but how much time and effort would that cost?	[ 1 ]
This is quite absurd. Blacklist is standard engineering terminology. Please read up on the etymology of the word before inserting your own misguided ideas into things. https://www.etymonline.com/word/blacklist	[ 1 ]
would this be more clear as os kill pidfile pid	[ 0 ]
if this fails do you want to return a model update with replication status ass error	[ 0 ]
self assertraises runtimeerror self batch ip cmd execute	[ 0 ]
feel free to put this into it is own bug patch i think it should go in asap	[ 0 ]
useless	[ 0 ]
put ALL the mining machines on this otherwise your belts will go fast but the machines will be hella slow FNR	[ 1 ]
Were you ever able to get resolution on this? I'm having the same issue... stuck between ridiculous relative paths or autocompletes that suggest filenames which don't compile properly.	[ 1 ]
ok reverted back to the older style just added a dummy top val in header for compilation to go through on	[ 0 ]
again, not a boolean, and will fuck up monkeys and plastic golems if they manage to get the mutation	[ 1 ]
those are useless anymore so we can get rid of them	[ 0 ]
you have lots of boilerplate additions for serialization and deserialization why not write a webtest wrapper that handles that for you	[ 0 ]
Damn. Who named that variable!	[ 1 ]
> No waiting shuttle requests sounds weird	[ 1 ]
default is useless in migrations use server default more information here difference between default and server default parameters for columns	[ 0 ]
Shit, I totally forgot I was using an arg-given entity also. will do.	[ 1 ]
must be dev ssh ssh host key to match sshd config	[ 0 ]
a backquote looks a garbage	[ 0 ]
The RebinToWorkspace for the container is deliberately there to prevent the User from using different energy ranges and producing a rubbish result. Also, there is an option to shift the energy for the container which again requires a rebin. Making it optional is not what I want for our use.	[ 1 ]
Oh, crap. I did not put it high enough. Will fix.	[ 1 ]
i think you can use try sync utils waitfor some func duration secs self args current sampling period secs return true except type utils timeouterror loging return false	[ 0 ]
useless	[ 0 ]
The code is nonsense so it makes sense for an error to be issued on it. 99% of the time this is a `\|\|` vs `&&` or `!=` vs `==` bug in the user code.	[ 1 ]
`::` is C++. Maybe just `Device.enumerated_found` ?	[ 1 ]
whoops this is junk that i missed if we re not doing authenticated encryption then we do not need to choose an authentication function at all i am just going to take this line out	[ 0 ]
you are setting self src elem unconditionally on line so this assignment is not needed	[ 0 ]
i suggest we kill that first sentence	[ 0 ]
That kind of nonsense? Why do I need this in Windows Explorer?	[ 1 ]
Damn. I just realized this is wrong.	[ 1 ]
Fixed bug where dickgirls & cuntboys got negative organs.	[ 1 ]
Can I feel depressed that I instantly see how that'll be meta'd like fuck?	[ 1 ]
Ok this is starting to be ridiculous \U0001f602 Please please please is there a way to entirely opt-out from ansibot? The `click here for bot help` link does not mention it.	[ 1 ]
This comment is weird, haha Also, indentation here looks a bit weird	[ 1 ]
argh lame pep issue gotta move this line up for alphabetical order	[ 0 ]
fileid and recordnum are not used why are you doing this	[ 0 ]
i would call this iommu struct rk iommu iommu	[ 0 ]
this should probably be removed and ensure package from stdlib should be used instead	[ 0 ]
let s do it in follow up btw one of follow ups will just kill it	[ 0 ]
why check physical address i think that is redundant	[ 0 ]
i do not see these happening in my testing of this i may be doing it wrong so i will keep my until i realize i am an idiot or it is not working	[ 0 ]
get rid of the FONT SIZE=+2 shit and the `</FONT>` `<FONT>` tags are outdated. `<span>` tags use CSS, which is more flexible. Should look like `<span class='danger'>Blah</span>`	[ 1 ]
uuid strategy utils generate uuid	[ 0 ]
i'm going to throw you and your linebreaks into the goddamn star you're trying to pr	[ 1 ]
@battaile I'm on your side! Prohibiting the use of a clearly better solution would be utterly nonsense.	[ 1 ]
Unfortunately, not working after reinstallation drivers. I didn't encounter any issue like this before on this PC, I will install older driver maybe there is a bug in this version. ATI always sucks, I can't use ubuntu because of ATI. I have to continue until my macbook is fixed. Thanks for your interest.	[ 1 ]
tests should go under osprofiler tests otherwise they are not even executed	[ 0 ]
fuck, this thing is so large it fails to load in my browser	[ 1 ]
in studio code we use assertions a lot assert blah null	[ 0 ]
nit put a space after in all comments below	[ 0 ]
clang-format screws up the copyright notice at the top, and adds those spaces. After comparing it with other files I noticed that they all have one space before the lines, so I left that change in.	[ 1 ]
Yeah kind of sucks but someway we have to expose some way to the presenter to handle the dismiss.	[ 1 ]
valentine shit? and what does the hand path do?	[ 1 ]
Or even go with `var/uses = 1` so bullshit tomes can be adminspawned.	[ 1 ]
can you make the text match a non admin user will not be able to execute actions	[ 0 ]
if you are going to put author and date why not use the javadocs i think the styleguide says you can leave them out if you want	[ 0 ]
die die die	[ 0 ]
this is something to do with detecting when kati needs to regenerate telling it to ignore dirty files anywhere under out dir it should not be affected by this patch these are output files from kati not input files so it will not check if they are dirty	[ 0 ]
ds browser should be property of the datastore	[ 0 ]
oops sorry i will kill that	[ 0 ]
Damian go to bed and come back tomorrow and look at how daft you're being	[ 1 ]
It looks almost like something happened with the executable. I redownloaded the application and it is working fine. Bizarre.	[ 1 ]
since jsonutils dumps takes care of invalid input it is better that we construct a raw faulty input here like this req body os update readonly flag readonly true self assertraises webob exc httpbadrequest req get response fakes wsgi app	[ 0 ]
afaik not currently but maybe in the future that s why i only remove dns sh	[ 0 ]
yeah I'll contact oranges+mso+pomf and get that shit implemented here	[ 1 ]
we really out to switch to boringssl i would love to kill mincrypt	[ 0 ]
my fault instead of sid jump to specific page use nslotid then the build error on macos will go away	[ 0 ]
I got sucked in by the type traits naming :)	[ 1 ]
Performance and saves improvement aside, waste incinerator sounds like a good idea, to eg. get rid of lots of rubbish and/or Z corpses quickly (and get something universally useful out of it unlike butchering)	[ 1 ]
that way when people fuck about with the underlying science points formula your shit doesn't get wacked.	[ 1 ]
because i am stupid	[ 0 ]
the breakpad tools are generally hostile you could do something like hide if breakpad dump syms c log then cat log false fi	[ 0 ]
I'll fix the clippy nonsense	[ 1 ]
Can this be fixed finally? The timeout is ridiculous and it is extremely annoying having to wait 10 seconds after every reset. Not to mention it makes waking up from deepsleep a bit stupid.	[ 1 ]
oh my these could clash we should prepend u r or h to every breakpoint id to avoid that	[ 0 ]
add global ignorance of foreing key during altering table ignore foreign checks globally in migration	[ 0 ]

Note this sucks... but is the only way to test old XNA FBXs.

[ 1 ]

This is absolutely ridiculous the X-Forwarded-For field is not supported in IIS. I need to use grok patterns in Logstash because this isn't there and it's essentially double work every time I update my agents.

[ 1 ]

remove this thing you added, also we have a fucking config on the server. we don't use this config.

[ 1 ]

done super lame mistake from me

[ 0 ]

are you sure it should be uid not id with fk

[ 0 ]

Thanks for the review. I'm so tired from immigration nonsense I rushed this patch. I'll do my best to get it ready for another r? ASAP.

[ 1 ]

If you read the documentation every time, and aren't cocky enough to think you remember from the last time, a number of months earlier, yes...

[ 1 ]

Can you make this a define? I don't like SCREAMING_VARIABLES when they're just normal variables, confusing.

[ 1 ]

i would expect get by instance to take an instance object maybe a better name is get by instance uuid

[ 0 ]

you need to return here now execution continues to line where we would crash

[ 0 ]

This is ridiculous. Manually merging.

[ 1 ]

Nothing :fingerguns: I just copied the shit over. The SoundGunshot can be removed. I'm not too sure for the FireRateSelector (we don't have any weapons that can switch firerate **yet**)

[ 1 ]

I see. Crappy design.

[ 1 ]

If this exists it should be a strict downgrade, fireaxe bones are hellish enough as it is.

[ 1 ]

translation func should be used

[ 0 ]

oh dammit, how did I miss that?

[ 1 ]

subnet request subnet cidr is already an ipnetwork instance therefore the call at line will be useless even if harmless as well

[ 0 ]

Just did a bit of a wacky rebase. Could i get a set of \U0001f440 here?

[ 1 ]

Good change, invisible things that affect gameplay suck I'd suggest making a "holy" shiny/bright/hallelujah/blessed overlay over blessed floors, it would fix issues like the xenobio blueprints etc

[ 1 ]

clang-format did this? looks like crap

[ 1 ]

the first one is for failures during load prelink this one for spinfo link image failures

[ 0 ]

this javadoc seems out of date parentstyle is not there anymore and some other params are missing

[ 0 ]

well , there is no such thing as "Lightning Movement" , and hell is movement too long to use as a practical word , so i chose that

[ 1 ]

remove python specific boolean representations disabled

[ 0 ]

Why would REST be better than powershell? this is ridiculous. Powershell is so much better than REST API. Following your logic c# compiler is so much better then minesweeper. Ofc you can do more with c# compiler, but how much time and effort would that cost?

[ 1 ]

This is quite absurd. Blacklist is standard engineering terminology. Please read up on the etymology of the word before inserting your own misguided ideas into things. https://www.etymonline.com/word/blacklist

[ 1 ]

would this be more clear as os kill pidfile pid

[ 0 ]

if this fails do you want to return a model update with replication status ass error

[ 0 ]

self assertraises runtimeerror self batch ip cmd execute

[ 0 ]

feel free to put this into it is own bug patch i think it should go in asap

[ 0 ]

useless

[ 0 ]

put ALL the mining machines on this otherwise your belts will go fast but the machines will be hella slow FNR

[ 1 ]

Were you ever able to get resolution on this? I'm having the same issue... stuck between ridiculous relative paths or autocompletes that suggest filenames which don't compile properly.

[ 1 ]

ok reverted back to the older style just added a dummy top val in header for compilation to go through on

[ 0 ]

again, not a boolean, and will fuck up monkeys and plastic golems if they manage to get the mutation

[ 1 ]

those are useless anymore so we can get rid of them

[ 0 ]

you have lots of boilerplate additions for serialization and deserialization why not write a webtest wrapper that handles that for you

[ 0 ]

Damn. Who named that variable!

[ 1 ]

> No waiting shuttle requests sounds weird

[ 1 ]

default is useless in migrations use server default more information here difference between default and server default parameters for columns

[ 0 ]

*Shit*, I totally forgot I was using an arg-given entity also. will do.

[ 1 ]

must be dev ssh ssh host key to match sshd config

[ 0 ]

a backquote looks a garbage

[ 0 ]

The RebinToWorkspace for the container is deliberately there to prevent the User from using different energy ranges and producing a rubbish result. Also, there is an option to shift the energy for the container which again requires a rebin. Making it optional is not what I want for our use.

[ 1 ]

Oh, crap. I did not put it high enough. Will fix.

[ 1 ]

i think you can use try sync utils waitfor some func duration secs self args current sampling period secs return true except type utils timeouterror loging return false

[ 0 ]

useless

[ 0 ]

The code is nonsense so it makes sense for an error to be issued on it. 99% of the time this is a `||` vs `&&` or `!=` vs `==` bug in the user code.

[ 1 ]

`::` is C++. Maybe just `Device.enumerated_found` ?

[ 1 ]

whoops this is junk that i missed if we re not doing authenticated encryption then we do not need to choose an authentication function at all i am just going to take this line out

[ 0 ]

you are setting self src elem unconditionally on line so this assignment is not needed

[ 0 ]

i suggest we kill that first sentence

[ 0 ]

That kind of nonsense? Why do I need this in Windows Explorer?

[ 1 ]

Damn. I just realized this is wrong.

[ 1 ]

Fixed bug where dickgirls & cuntboys got negative organs.

[ 1 ]

Can I feel depressed that I instantly see how that'll be meta'd like fuck?

[ 1 ]

Ok this is starting to be ridiculous \U0001f602 Please please please is there a way to entirely opt-out from ansibot? The `click here for bot help` link does not mention it.

[ 1 ]

This comment is weird, haha Also, indentation here looks a bit weird

[ 1 ]

argh lame pep issue gotta move this line up for alphabetical order

[ 0 ]

fileid and recordnum are not used why are you doing this

[ 0 ]

i would call this iommu struct rk iommu iommu

[ 0 ]

this should probably be removed and ensure package from stdlib should be used instead

[ 0 ]

let s do it in follow up btw one of follow ups will just kill it

[ 0 ]

why check physical address i think that is redundant

[ 0 ]

i do not see these happening in my testing of this i may be doing it wrong so i will keep my until i realize i am an idiot or it is not working

[ 0 ]

get rid of the FONT SIZE=+2 shit and the `` `` tags are outdated. `` tags use CSS, which is more flexible. Should look like `Blah`

[ 1 ]

uuid strategy utils generate uuid

[ 0 ]

i'm going to throw you and your linebreaks into the goddamn star you're trying to pr

[ 1 ]

@battaile I'm on your side! Prohibiting the use of a clearly better solution would be utterly nonsense.

[ 1 ]

Unfortunately, not working after reinstallation drivers. I didn't encounter any issue like this before on this PC, I will install older driver maybe there is a bug in this version. ATI always sucks, I can't use ubuntu because of ATI. I have to continue until my macbook is fixed. Thanks for your interest.

[ 1 ]

tests should go under osprofiler tests otherwise they are not even executed

[ 0 ]

fuck, this thing is so large it fails to load in my browser

[ 1 ]

in studio code we use assertions a lot assert blah null

[ 0 ]

nit put a space after in all comments below

[ 0 ]

clang-format screws up the copyright notice at the top, and adds those spaces. After comparing it with other files I noticed that they all have one space before the lines, so I left that change in.

[ 1 ]

Yeah kind of sucks but someway we have to expose some way to the presenter to handle the dismiss.

[ 1 ]

valentine shit? and what does the hand path do?

[ 1 ]

Or even go with `var/uses = 1` so bullshit tomes can be adminspawned.

[ 1 ]

can you make the text match a non admin user will not be able to execute actions

[ 0 ]

if you are going to put author and date why not use the javadocs i think the styleguide says you can leave them out if you want

[ 0 ]

die die die

[ 0 ]

this is something to do with detecting when kati needs to regenerate telling it to ignore dirty files anywhere under out dir it should not be affected by this patch these are output files from kati not input files so it will not check if they are dirty

[ 0 ]

ds browser should be property of the datastore

[ 0 ]

oops sorry i will kill that

[ 0 ]

Damian go to bed and come back tomorrow and look at how daft you're being

[ 1 ]

It looks almost like something happened with the executable. I redownloaded the application and it is working fine. Bizarre.

[ 1 ]

since jsonutils dumps takes care of invalid input it is better that we construct a raw faulty input here like this req body os update readonly flag readonly true self assertraises webob exc httpbadrequest req get response fakes wsgi app

[ 0 ]

afaik not currently but maybe in the future that s why i only remove dns sh

[ 0 ]

yeah I'll contact oranges+mso+pomf and get that shit implemented here

[ 1 ]

we really out to switch to boringssl i would love to kill mincrypt

[ 0 ]

my fault instead of sid jump to specific page use nslotid then the build error on macos will go away

[ 0 ]

I got sucked in by the type traits naming :)

[ 1 ]

Performance and saves improvement aside, waste incinerator sounds like a good idea, to eg. get rid of lots of rubbish and/or Z corpses quickly (and get something universally useful out of it unlike butchering)

[ 1 ]

that way when people fuck about with the underlying science points formula your shit doesn't get wacked.

[ 1 ]

because i am stupid

[ 0 ]

the breakpad tools are generally hostile you could do something like hide if breakpad dump syms c log then cat log false fi

[ 0 ]

I'll fix the clippy nonsense

[ 1 ]

Can this be fixed finally? The timeout is ridiculous and it is extremely annoying having to wait 10 seconds after every reset. Not to mention it makes waking up from deepsleep a bit stupid.

[ 1 ]

oh my these could clash we should prepend u r or h to every breakpoint id to avoid that

[ 0 ]

add global ignorance of foreing key during altering table ignore foreign checks globally in migration

[ 0 ]