showvikdbz/code-reviews · Datasets at Hugging Face

text stringlengths 1 5.2k	labels listlengths 1 1
I'm working on reproing this now. The config from @mikeyhill has a bunch of dependencies I'm trying to meet - @rubbish if you happen to have a simpler repro case let me know.	[ 1 ]
pthread create failed s strerror ret like always or use error h	[ 0 ]
executions extend	[ 0 ]
I think tinyXml2 would be an awful IR. Have you looked at its APIs? Yuck! Half of the crappiness of the current parsing code comes from using tinyXml in the first place. If XML is your one true god, then something like http://www.codesynthesis.com/products/xsd/ would be vastly superior to tinyXml.	[ 1 ]
Right, shit, give me a second	[ 1 ]
monkey see monkey do see netns cleanup py and ovs cleanup py	[ 0 ]
socat must remain it is not useless and actually required	[ 0 ]
i left rootwrap config parametes in ironic lib as empty so that whoever uses ironic lib to run disk partitioner code they have to set the correct values for these config parameters otherwise the underlying commands parted etc will run with the same user permission as that of the service ironic ipa so i would prefer to leave this code this way please let me know if you want to change this code	[ 0 ]
this should be a uuid i think all id s here id volumeid serverid are uuids	[ 0 ]
these are useless once again you should check that we have output data in bytesio object returned by io bytesio	[ 0 ]
done	[ 0 ]
I'd say put this assert back where it was. It shouldn't trigger any more, and if it does it means something was screwed up.	[ 1 ]
git has really screwed up and thinks this is a rename operation..	[ 1 ]
i see red eradicate deredify	[ 0 ]
7c8dd95bf6ab0abc43c6baddb29e9d341cff7f5a is a variant using a worker thread. It's a bit ridiculous, but maybe actually the better option? Avoids the CoInitialize on the main thread and never opens any temporary secondary threads.	[ 1 ]
my instnace should be my instance	[ 0 ]
a stupid decorator i like such notes btw this decorator is located at l of this module so you can change it a bit	[ 0 ]
nit you called it amt mgmt in fake py or use amt management to be consistent with the other management here	[ 0 ]
What the hell is this line for?	[ 1 ]
i would rename call on drivers to call drivers or call on all drivers or call method on drivers	[ 0 ]
needs to end on previous line no trailing comma necessary	[ 0 ]
but they print all this junk info building for peach pit info u boot board is chromeos peach	[ 0 ]
useless close release	[ 0 ]
replace this function with below one def test add remove router interface with port id self network created router port body self client create port network id network id add router interface to port created above resp interface self client add router interface with port id created router id port body port id self assertequal resp status self addcleanup self remove router interface with port id created router id port body port id self assertin subnet id interface keys self assertin port id interface keys verify router id is equal to device id in port details resp show port body self client show port interface port id self assertequal show port body port device id router id return show port body	[ 0 ]
damn, should be a lot faster	[ 1 ]
auth token auth uri tenant id username should be removed	[ 0 ]
null should never happen so i would use preconditions checknotnull instead otherwise an misconfiguration in touch name to enum may be masked	[ 0 ]
are you sure that you need slaves	[ 0 ]
SHITCODEEEEEEEEEEEEEEEERS	[ 1 ]
yes the test is stupid it is just to test unicode and and	[ 0 ]
warning message should be wrapped by lw	[ 0 ]
That seems odd as hell. It shouldn't fall back to difficulty randomly. At that point, you may want to consider just not sorting difficulties by length.	[ 1 ]
this seems odd now we should just be passing the migration object here	[ 0 ]
javadoc style for comments outside of methods	[ 0 ]
ha i am going to set up a pool on how many people will use this over the next years thinking it is some kind of pureretry as opposed to a vendor unique thing maybe you should have used purity	[ 0 ]
I know, it's a disgrace how long our lists have gotten. I've been trying to pack in the last few things for a release and then join you on the "pruning".	[ 1 ]
Damn, thanks for noticing	[ 1 ]
showing some hits already i have not dug into these yet to find out where they are coming from	[ 0 ]
we never use check dcheck in test code and we prefer expect unless the assert failing makes the rest of the test not make sense e g assert true test thread start in a multi threaded test here the token evaluating to true does not mean it is idiot ic to test initialize imo but i do not care strongly in general both should pass so this is a moot point definitely not check though	[ 0 ]
In GitLab by @cdm on Jul 10, 2019, 08:36 1 - will investigate and replicate locally 2 - Thats a pretty rubbish error message to receive back from the app on an API :thinking:	[ 1 ]
elasticsearch url self get elasticsearch url	[ 0 ]
let s use flavors format flavor id	[ 0 ]
pkg list is a string you want list packages instead and delete line	[ 0 ]
pythonic reduce indent by removing elses	[ 0 ]
Yes but that's a weird fucking syntax for adding a 0 as an element to a list really. stick a comment on it or something	[ 1 ]
You're using the funky, new `lambda` method of invoking/referring/creating functions to use with slot and signals aren't you! :open_mouth:	[ 1 ]
when do you get a name null probably add a comment about that	[ 0 ]
You shouldn't be adding edible components with 0 volume, period. Adding a flag is not the right solution for this. The problem isnt the edible component, its this broken-ass stomach change.	[ 1 ]
OMG. WTF. Always put spaces around operators.. except when you shouldn't.	[ 1 ]
There's also the whole backstory of them completely countering stun combat. You didn't powergame and bring a shotgun from the armory rounstart? Sucks for you and your taser/stunbaton.	[ 1 ]
What- that's jank as hell.	[ 1 ]
You arent doing it in this PR, so leave it in because it will fuck up the other maps.	[ 1 ]
good one this is open source so i should nuke the comment and link completely	[ 0 ]
why is this a fixme is there something left to do here	[ 0 ]
TextPos is already shited by `surface.DrawText`	[ 1 ]
source admin openrc sh	[ 0 ]
nit this could just be drawable drawable thumbnailgradient	[ 0 ]
i hate to jump in late here but why not just stick this in compositorframemetadata	[ 0 ]
input file will be undefined i believe you need pep input file	[ 0 ]
The message for the player, "You can't get any better shooting such a crappy gun.", can be confusing indeed. He might have great gun, just sucky ammo. Or he can have close range weapon (pistols, shotguns, SMGs) like Taurus Raging Bull, which have disp 12+8(13 reloaded) and is not meant to snipe with.	[ 1 ]
@iloveagent57 You're right. Dammit, I'll find a place to shoehorn it in!	[ 1 ]
Pushing around a highly used room for a rarely used admin toy is _disgusting_. Plus it's ugly	[ 1 ]
Same, TS/JS is wonky stuff	[ 1 ]
use mix(), this looks pretty weird.	[ 1 ]
globals yml	[ 0 ]
sorry i am an idiot somehow i was thinking you meant the launch api service line i now realize it is the wait line sorry done	[ 0 ]
Despite the yellow indicator, I'm just gonna go ahead and merge. Bizarre.	[ 1 ]
i guess this block should be removed	[ 0 ]
huge nit please insert a space after the colon	[ 0 ]
beyond ridiculous.	[ 1 ]
I've recreated the issue on my server, this is what I'm seeing: <img width="1425" alt="image" src="https://user-images.githubusercontent.com/1780369/189259906-0d8b2561-0a23-45ab-b674-fdb74bca63a9.png"> Note that there are 2 mistakes in this pictures that should cause an error: 1. the credentials 2. the "Columns" field, which I intentionally filled with rubbish. The BigQuery table has mandatory columns, BTW.	[ 1 ]
this class should implement tear down such as test l plugin	[ 0 ]
assertin	[ 0 ]
Mouahahahahah... Yup pushing in a sec, thanks a ton.	[ 1 ]
didn't people not want this to be a copy paste of the singlo? I get boosting its devastation but making it explode stuff pretty much every time it zaps would be kind of lame	[ 1 ]
only target device id will be printed now the other things you are including will be ignored	[ 0 ]
corrupt include user id in the exception message too	[ 0 ]
I can still remember the giant WTF moment when I found that adding `this.` fixed the issues that I was having, so i'm pretty sure, yeah.	[ 1 ]
oh stupid me using too many mocks does let you down sometimes thanks imre	[ 0 ]
cursed as hell brother, cursed as hell	[ 1 ]
Stop opening this rubbish in people's repos.	[ 1 ]
this will break if i authenticate by user id or if i rescope a token not sure this code should care about that scenario though	[ 0 ]
there should only be a single blank line here totally a nit	[ 0 ]
oh cffi how i loath thee	[ 0 ]
indentation looks screwed up...	[ 1 ]
no the destination register for the select pattern in quick can have any narrow type object r cond r r float f cond f f int i cond bool b cond false true	[ 0 ]
Why bother with this?	[ 1 ]
Fuck those four lines in particular.	[ 1 ]
>It looks a bit cleaner with the var tbh What the fuck am I reading `src.` is undeed first off, so it's `mob.name` vs `name` Secondly this is a variable for literally 4 letters	[ 1 ]
oh that reminds me you really do not need to prefix all of these with coreboot that s implied in this repository unless you explicitly say libpayload also please put a space after a colon	[ 0 ]
this should be ids to ignore router ids really	[ 0 ]
max bin count	[ 0 ]
holy fuck they do. Why the fuck	[ 1 ]
make this static i am guessing you did not kill the prev next fields of fdevent because fdevent h is also used by sysdeps win cpp which still uses the fields	[ 0 ]
You forgot "your mom is _"!	[ 1 ]
i highly dobut this softwareconfig works sine there is no os tools	[ 0 ]
That would be a poor use of time. Almost all of our repos have these notices. _Definition of ridiculous:_ A clean room implementation of a Microsoft-create type by another Microsoft team.	[ 1 ]
please change dummy to fake	[ 0 ]
i know i should have brought up this earlier but i wonder if we would benefit from moving these into it is own section we could do it in a clean up patch but because it is a time sensitive issue we d need to get it in before havana releases i wonder if it is worth doing it in another patchset in this review	[ 0 ]
what the fuck. why are you checking if something you've clicked on is an area. that should never happen. I know this was here before, but what the fuck, why is it still here?	[ 1 ]

I'm working on reproing this now. The config from @mikeyhill has a bunch of dependencies I'm trying to meet - @rubbish if you happen to have a simpler repro case let me know.

[ 1 ]

pthread create failed s strerror ret like always or use error h

[ 0 ]

executions extend

[ 0 ]

I think tinyXml2 would be an awful IR. Have you looked at its APIs? Yuck! Half of the crappiness of the current parsing code comes from using tinyXml in the first place. If XML is your one true god, then something like http://www.codesynthesis.com/products/xsd/ would be vastly superior to tinyXml.

[ 1 ]

Right, shit, give me a second

[ 1 ]

monkey see monkey do see netns cleanup py and ovs cleanup py

[ 0 ]

socat must remain it is not useless and actually required

[ 0 ]

i left rootwrap config parametes in ironic lib as empty so that whoever uses ironic lib to run disk partitioner code they have to set the correct values for these config parameters otherwise the underlying commands parted etc will run with the same user permission as that of the service ironic ipa so i would prefer to leave this code this way please let me know if you want to change this code

[ 0 ]

this should be a uuid i think all id s here id volumeid serverid are uuids

[ 0 ]

these are useless once again you should check that we have output data in bytesio object returned by io bytesio

[ 0 ]

done

[ 0 ]

I'd say put this assert back where it was. It shouldn't trigger any more, and if it does it means something was screwed up.

[ 1 ]

git has really screwed up and thinks this is a rename operation..

[ 1 ]

i see red eradicate deredify

[ 0 ]

7c8dd95bf6ab0abc43c6baddb29e9d341cff7f5a is a variant using a worker thread. It's a bit ridiculous, but maybe actually the better option? Avoids the CoInitialize on the main thread and never opens any temporary secondary threads.

[ 1 ]

my instnace should be my instance

[ 0 ]

a stupid decorator i like such notes btw this decorator is located at l of this module so you can change it a bit

[ 0 ]

nit you called it amt mgmt in fake py or use amt management to be consistent with the other management here

[ 0 ]

What the hell is this line for?

[ 1 ]

i would rename call on drivers to call drivers or call on all drivers or call method on drivers

[ 0 ]

needs to end on previous line no trailing comma necessary

[ 0 ]

but they print all this junk info building for peach pit info u boot board is chromeos peach

[ 0 ]

useless close release

[ 0 ]

replace this function with below one def test add remove router interface with port id self network created router port body self client create port network id network id add router interface to port created above resp interface self client add router interface with port id created router id port body port id self assertequal resp status self addcleanup self remove router interface with port id created router id port body port id self assertin subnet id interface keys self assertin port id interface keys verify router id is equal to device id in port details resp show port body self client show port interface port id self assertequal show port body port device id router id return show port body

[ 0 ]

damn, should be a lot faster

[ 1 ]

auth token auth uri tenant id username should be removed

[ 0 ]

null should never happen so i would use preconditions checknotnull instead otherwise an misconfiguration in touch name to enum may be masked

[ 0 ]

are you sure that you need slaves

[ 0 ]

SHITCODEEEEEEEEEEEEEEEERS

[ 1 ]

yes the test is stupid it is just to test unicode and and

[ 0 ]

warning message should be wrapped by lw

[ 0 ]

That seems odd as hell. It shouldn't fall back to difficulty randomly. At that point, you may want to consider just *not sorting difficulties* by length.

[ 1 ]

this seems odd now we should just be passing the migration object here

[ 0 ]

javadoc style for comments outside of methods

[ 0 ]

ha i am going to set up a pool on how many people will use this over the next years thinking it is some kind of pureretry as opposed to a vendor unique thing maybe you should have used purity

[ 0 ]

I know, it's a disgrace how long our lists have gotten. I've been trying to pack in the last few things for a release and then join you on the "pruning".

[ 1 ]

Damn, thanks for noticing

[ 1 ]

showing some hits already i have not dug into these yet to find out where they are coming from

[ 0 ]

we never use check dcheck in test code and we prefer expect unless the assert failing makes the rest of the test not make sense e g assert true test thread start in a multi threaded test here the token evaluating to true does not mean it is idiot ic to test initialize imo but i do not care strongly in general both should pass so this is a moot point definitely not check though

[ 0 ]

In GitLab by @cdm on Jul 10, 2019, 08:36 1 - will investigate and replicate locally 2 - Thats a pretty rubbish error message to receive back from the app on an API :thinking:

[ 1 ]

elasticsearch url self get elasticsearch url

[ 0 ]

let s use flavors format flavor id

[ 0 ]

pkg list is a string you want list packages instead and delete line

[ 0 ]

pythonic reduce indent by removing elses

[ 0 ]

Yes but that's a weird fucking syntax for adding a 0 as an element to a list really. stick a comment on it or something

[ 1 ]

You're using the funky, new `lambda` method of invoking/referring/creating functions to use with slot and signals aren't you! :open_mouth:

[ 1 ]

when do you get a name null probably add a comment about that

[ 0 ]

You shouldn't be adding edible components with 0 volume, period. Adding a flag is not the right solution for this. The problem isnt the edible component, its this broken-ass stomach change.

[ 1 ]

OMG. WTF. Always put spaces around operators.. except when you shouldn't.

[ 1 ]

There's also the whole backstory of them completely countering stun combat. You didn't powergame and bring a shotgun from the armory rounstart? Sucks for you and your taser/stunbaton.

[ 1 ]

What- that's jank as hell.

[ 1 ]

You arent doing it in this PR, so leave it in because it will fuck up the other maps.

[ 1 ]

good one this is open source so i should nuke the comment and link completely

[ 0 ]

why is this a fixme is there something left to do here

[ 0 ]

TextPos is already shited by `surface.DrawText`

[ 1 ]

source admin openrc sh

[ 0 ]

nit this could just be drawable drawable thumbnailgradient

[ 0 ]

i hate to jump in late here but why not just stick this in compositorframemetadata

[ 0 ]

input file will be undefined i believe you need pep input file

[ 0 ]

The message for the player, "You can't get any better shooting such a crappy gun.", can be confusing indeed. He might have great gun, just sucky ammo. Or he can have close range weapon (pistols, shotguns, SMGs) like Taurus Raging Bull, which have disp 12+8(13 reloaded) and is not meant to snipe with.

[ 1 ]

@iloveagent57 You're right. Dammit, I'll find a place to shoehorn it in!

[ 1 ]

Pushing around a highly used room for a rarely used admin toy is _disgusting_. Plus it's ugly

[ 1 ]

Same, TS/JS is wonky stuff

[ 1 ]

use mix(), this looks pretty weird.

[ 1 ]

globals yml

[ 0 ]

sorry i am an idiot somehow i was thinking you meant the launch api service line i now realize it is the wait line sorry done

[ 0 ]

Despite the yellow indicator, I'm just gonna go ahead and merge. Bizarre.

[ 1 ]

i guess this block should be removed

[ 0 ]

huge nit please insert a space after the colon

[ 0 ]

beyond ridiculous.

[ 1 ]

I've recreated the issue on my server, this is what I'm seeing: <img width="1425" alt="image" src="https://user-images.githubusercontent.com/1780369/189259906-0d8b2561-0a23-45ab-b674-fdb74bca63a9.png"> Note that there are 2 mistakes in this pictures that should cause an error: 1. the credentials 2. the "Columns" field, which I intentionally filled with rubbish. The BigQuery table has mandatory columns, BTW.

[ 1 ]

this class should implement tear down such as test l plugin

[ 0 ]

assertin

[ 0 ]

Mouahahahahah... Yup pushing in a sec, thanks a ton.

[ 1 ]

didn't people not want this to be a copy paste of the singlo? I get boosting its devastation but making it explode stuff pretty much every time it zaps would be kind of lame

[ 1 ]

only target device id will be printed now the other things you are including will be ignored

[ 0 ]

corrupt include user id in the exception message too

[ 0 ]

I can still remember the giant WTF moment when I found that adding `this.` fixed the issues that I was having, so i'm pretty sure, yeah.

[ 1 ]

oh stupid me using too many mocks does let you down sometimes thanks imre

[ 0 ]

cursed as hell brother, cursed as hell

[ 1 ]

Stop opening this rubbish in people's repos.

[ 1 ]

this will break if i authenticate by user id or if i rescope a token not sure this code should care about that scenario though

[ 0 ]

there should only be a single blank line here totally a nit

[ 0 ]

oh cffi how i loath thee

[ 0 ]

indentation looks screwed up...

[ 1 ]

no the destination register for the select pattern in quick can have any narrow type object r cond r r float f cond f f int i cond bool b cond false true

[ 0 ]

Why bother with this?

[ 1 ]

Fuck those four lines in particular.

[ 1 ]

>It looks a bit cleaner with the var tbh What the fuck am I reading `src.` is undeed first off, so it's `mob.name` vs `name` Secondly this is a variable for literally 4 letters

[ 1 ]

oh that reminds me you really do not need to prefix all of these with coreboot that s implied in this repository unless you explicitly say libpayload also please put a space after a colon

[ 0 ]

this should be ids to ignore router ids really

[ 0 ]

max bin count

[ 0 ]

holy fuck they do. Why the fuck

[ 1 ]

make this static i am guessing you did not kill the prev next fields of fdevent because fdevent h is also used by sysdeps win cpp which still uses the fields

[ 0 ]

You forgot "your mom is _"!

[ 1 ]

i highly dobut this softwareconfig works sine there is no os tools

[ 0 ]

That would be a poor use of time. Almost all of our repos have these notices. _Definition of ridiculous:_ A clean room implementation of a Microsoft-create type by another Microsoft team.

[ 1 ]

please change dummy to fake

[ 0 ]

i know i should have brought up this earlier but i wonder if we would benefit from moving these into it is own section we could do it in a clean up patch but because it is a time sensitive issue we d need to get it in before havana releases i wonder if it is worth doing it in another patchset in this review

[ 0 ]

what the fuck. why are you checking if something you've clicked on is an area. that should never happen. I know this was here before, but what the fuck, why is it still here?

[ 1 ]