showvikdbz/code-reviews · Datasets at Hugging Face

text stringlengths 1 5.2k	labels listlengths 1 1
or ret cyapa read byte if ret dev err goto out cyapa m bl ret	[ 0 ]
you could write this local d if d diff working dir properties orig new then die fi	[ 0 ]
yes i have tested it and it works as i intended, the problem is that i suck at balancing and should be tested by multiple setups/people to really grasp it better	[ 1 ]
Oh shit. You are correct	[ 1 ]
isn't this illegal in c++?	[ 1 ]
terminate calls thread pool clear so access to thread pool size needs to be synchronized to avoid races there right	[ 0 ]
useless	[ 0 ]
nsxpluginv testcase has more mocks than here is that ok to have those extra ones here	[ 0 ]
No don't add these back they're ugly	[ 1 ]
use datatableview instead of multitableview	[ 0 ]
from commit message it also updates grenade sh and check sanity to only dump databases that exist	[ 0 ]
kguidlength is the length of a single guid not the length of the array no i think you need a new kmicrosoftimeguidslength that is initialized to arraysize kmicrosoftimeguidslength somewhere	[ 0 ]
i will split this change in two one will leave lazy init and introduce new engine facade and the second to get rid of lazy init safely	[ 0 ]
rui these things happen because we merge code that has not enough unit tests i suggest to return here new data	[ 0 ]
needs a colon or a reformulation to be an actual sentence	[ 0 ]
it looks like this is a phony target but you do not touch it or mark it phony it will trigger a rebuild everytime which in turn causes the acp to run everytime	[ 0 ]
i see what you want to do but for image it seems unnecessary to reserve the space right after image and create oat map pointing there if image oat will be at the specified address maybe if oat begin is non null could we avoid reserving the space after the image also it seems that image s oat map and oat file do not actually point to the same location would it be possible to make them actually point to the same location is it possible to violate oat begin oat size oat end with the current interface maybe we could get rid of oat end in favor of oat size	[ 0 ]
re import all assets, it's not the brach, since I re imported all the assests before pushing	[ 1 ]
yes it is there by accident sean i think adding a line between eth and eth would make the draw more confusing	[ 0 ]
yes we need exactly slaves	[ 0 ]
Honestly with how fucked up an android gets with a full EMP its a good signifier of how crippled they're about to be.	[ 1 ]
trust id trust id	[ 0 ]
That sucks... This makes no sense, but let's not bother with it.	[ 1 ]
imho support gre should be die we workarounded it into just as temporary solution	[ 0 ]
there is a dumb calibration routine in magneticfieldmeasurementtestactivity would it be prudent to refactor it out so it can also be put at the beginning of this test as a way to guarantee that the magnetometer is calibrated before the test starts assuming that the operator did not follow any particular order while running ctsverifer tests	[ 0 ]
mmmmmm this is a bit weird	[ 1 ]
add metadata only to docstring params	[ 0 ]
why drain events here seems rather arbitrary	[ 0 ]
bod, that is a terrible log	[ 1 ]
there are two reasons i combined these classes this bp enables all current datasource drivers to use execute i do not imagine someone would make a subclass of just executiondriver because user does not have any way to handle executiondriver now imo in case of someone wants to create a new driver which does not need to have execute the developer writes the new driver directly inheriting datasoucedriver	[ 0 ]
not enough from the point of crap ngcaretposition is struct and never be null please have what the fuck optional ngcaretposition or definine ngcaretposition isnull	[ 0 ]
this comment is unnecessary after the refactor and should be removed	[ 0 ]
what the fuck is this	[ 1 ]
i think pep is freaking out about this	[ 0 ]
get rid of perf command line	[ 0 ]
I actually did this intentional, so people don't start screwing around with it (because usually people don't touch one liners) but I can change it everywhere I don't mind.	[ 1 ]
please take whichever approach you like software sync itself already violates this location independent policy because soft sync blindly sends ecrw image to update slot which can be slot a or b if we corrupt the active slot all the expectations and image manipulations have to be adjusted accordingly active and update instead of a and b so it may be simpler to fix the sequence boot a corrupt a reboot b corrupt b please note that fizz would not boot on type c adapter if both a and b are corrupted on a bj adapter the dut still boots just like other boards because software sync can fix one of the slots	[ 0 ]
please remove sleep here and use wait like you have done below	[ 0 ]
why only tries may it make sense to synchronize create or update agent	[ 0 ]
arrayutil tostringarray	[ 0 ]
we have rhel computes i guess we need rpm package too	[ 0 ]
@transitive-bullshit If we take a look at [Application Shells](https://pro.chakra-ui.com/components/application/shells) where `Sidebar Components` are applied, it still uses `Drawer` component so I doubt that'll solve things.	[ 1 ]
what s the difference between this and fk constrained columns columns	[ 0 ]
rot u	[ 0 ]
acknowledged kiss the issue is that data corruption can be sourced by the emmc and over time can turn into something serious a large number of small fixes each boot are better than a discovered perfects storm when one has both data corruption and an unclean shutdown android auto which boots often would have an issue with this we would want to institute one of the following if a full has not been done over some period of time eg days or over some number of reboots eg on shutdown request reboot into recovery fsck full the filesystem then shutdown periodically on boot do a full	[ 0 ]
Both options kinda suck. But the second probably sucks less (it's some indicaton that the filter didn't parse as a date filter).	[ 1 ]
This has absolutely no fucking place in this PR.	[ 1 ]
please memoize the lb id and listener id	[ 0 ]
Oooops. Should be 'add', not 'ass'. I fart fingered that one. ;)	[ 1 ]
on review orderedyaml is not in wide use in openstack changing the os case spec defintion slightly to make it a list rather than a dict as this is currently the only place where order can matter the script resources below are actually already in a list so yaml will treat them appropriately	[ 0 ]
this means openstack and fake can also match	[ 0 ]
:disappointed: I'm giving up soon, this is ridiculous	[ 1 ]
with the zero tier stuff it creates so much crap with the saves so it looks a lot nicer to me to save it in a save folder.	[ 1 ]
member count self projects page count members project name self projects page add member project name self assertequal self projects page count members project name member count instead of having constant	[ 0 ]
this backslash is unnecessary and should be eliminated	[ 0 ]
it was proposed to replace complete sentense part this fix is is useless	[ 0 ]
Who is that guy? Sounds like a jerk	[ 1 ]
I believe you can't liberate a civ you were at war with at the time when they were destroyed. Also I remember bonus for liberating a civ being ridiculously huge, making liberated civs basically your puppets.	[ 1 ]
The AIM code does some wacky linked list logic that's bugged for stacks. I'll refactor it completely when I get home in an hour.	[ 1 ]
zomg locals it be a hangin offense	[ 0 ]
you probably want to protect this with ifdef cplusplus	[ 0 ]
for better or worse i would argue worse your still not configuring ntp	[ 0 ]
You're telling me we don't even fucking need any part of it?	[ 1 ]
Restarted the whole test suite...something went wacky	[ 1 ]
this extra white space should be removed	[ 0 ]
that way arg can default to null and we do not need to specify it in most of the xml files	[ 0 ]
Partition keys are derived from the line-protocol timestamps the user submits to us (YMD of the timestamp) so we can expect some wacky values :+1:	[ 1 ]
why is this i think this will be expand to pid fio dev	[ 0 ]
YOU FUCKED UP BATHOS.	[ 1 ]
well how do i fricking do that	[ 1 ]
this is bigger than you can fit in a signed bit time t that is what the test was originally written for to show that we politely return rather than invoke our right to destroy the planet through undefined behavior	[ 0 ]
disabld disabled	[ 0 ]
This just seems to have been made for the memes. What does this contribute to the game, at all? It doesn't even do anything for 50 units, and that's a fucking beaker full	[ 1 ]
hi ed i have torn down my build system but i manually re created ext gw with what the script will have generated lo loopback up lower up mtu qdisc noqueue state unknown link loopback brd inet scope host lo valid lft forever preferred lft forever inet scope host valid lft forever preferred lft forever em broadcast multicast up lower up mtu qdisc mq state up qlen link ether e d c a brd ff ff ff ff ff ff inet brd scope global em valid lft forever preferred lft forever inet fe ae d ff fe ca scope link valid lft forever preferred lft forever em broadcast multicast mtu qdisc noop state down qlen link ether e d c a brd ff ff ff ff ff ff em broadcast multicast mtu qdisc noop state down qlen link ether e d c ae brd ff ff ff ff ff ff ovs system broadcast multicast mtu qdisc noop state down link ether a c brd ff ff ff ff ff ff ext gw broadcast up lower up mtu qdisc noqueue state unknown link ether a f ea brd ff ff ff ff ff ff inet scope global ext gw valid lft forever preferred lft forever inet fe f ff fe ea scope link valid lft forever preferred lft forever brbm broadcast up lower up mtu qdisc noqueue state unknown link ether e a f brd ff ff ff ff ff ff inet fe e f fee e scope link valid lft forever preferred lft forever virbr no carrier broadcast multicast up mtu qdisc noqueue state down link ether e e b brd ff ff ff ff ff ff inet brd scope global virbr valid lft forever preferred lft forever netstat rn kernel ip routing table destination gateway genmask flags mss window irtt iface ug em u em u virbr u ext gw	[ 0 ]
kill	[ 0 ]
LOL, that code is utter nonsense!	[ 1 ]
we need to dump data to yaml in uploadconfiguration task serialization	[ 0 ]
i think we should instead trigger this from renderframedevtoolsagenthost didstartnavigation	[ 0 ]
ra suspend should be rw for consistency with ra suspend	[ 0 ]
you should probably mark this as wip if you are still working on this	[ 0 ]
make this a proc on the griddle you vile animal, make it the same one a normal human uses.	[ 1 ]
Damn - i overlooked that bTriggerUpdateRes flag obviously.	[ 1 ]
WTH? If you are in PREPARE state you set the component to PREPARE? I call this a no-op...	[ 1 ]
byond pulled some weird branch shit I swear	[ 1 ]
cros build lib die again	[ 0 ]
since this is purely a data holder why not make it a struct get rid of all the inline getter setters and access data members directly this is ok for dumb classes and makes for less code and complexity	[ 0 ]
we need to execute walk versions with downgrade false as we want to check fully populated db	[ 0 ]
needless abbrv	[ 0 ]
i assume this fails horribly if the pid is already dead extend this to also add that tidbit of information so we know exactly what we are dealing with next time we hit this	[ 0 ]
Destroy is for handling refs and stuff, you dont want to empty contents on it no, stuff like rocks or tablets do it and its super messy and looks shit	[ 1 ]
ok will nuke it	[ 0 ]
kill this too	[ 0 ]
silly typo i can fix that with an additional patch for the next stage of the arp fix	[ 0 ]
Nope, this is why the GUI was such a bitch. Currently Titanium only has a TileEntity specific implementation. I had to do this implementation to get it working on an item :P	[ 1 ]
Oh damn good catch, lets fix that	[ 1 ]
drop the gitrepo import in your mocks below mock out revision control gitrepo instead of gitrepo	[ 0 ]
ha ha yeah this is stupid it s because if i put pragma no cover on the self fail line then it is more than characters i am thinking of using unittest assertraises as you suggest below and importing unittest for	[ 0 ]
Damn light grey on a dark background :shakesfist:	[ 1 ]
os brick encryptors use castellan and this bp will call the library os brick encryptors	[ 0 ]
here should be used following validators packstack installer validators validate multi regexp regexps are given as values of option list	[ 0 ]

or ret cyapa read byte if ret dev err goto out cyapa m bl ret

[ 0 ]

you could write this local d if d diff working dir properties orig new then die fi

[ 0 ]

yes i have tested it and it works as i intended, the problem is that i suck at balancing and should be tested by multiple setups/people to really grasp it better

[ 1 ]

Oh shit. You are correct

[ 1 ]

isn't this illegal in c++?

[ 1 ]

terminate calls thread pool clear so access to thread pool size needs to be synchronized to avoid races there right

[ 0 ]

useless

[ 0 ]

nsxpluginv testcase has more mocks than here is that ok to have those extra ones here

[ 0 ]

No don't add these back they're ugly

[ 1 ]

use datatableview instead of multitableview

[ 0 ]

from commit message it also updates grenade sh and check sanity to only dump databases that exist

[ 0 ]

kguidlength is the length of a single guid not the length of the array no i think you need a new kmicrosoftimeguidslength that is initialized to arraysize kmicrosoftimeguidslength somewhere

[ 0 ]

i will split this change in two one will leave lazy init and introduce new engine facade and the second to get rid of lazy init safely

[ 0 ]

rui these things happen because we merge code that has not enough unit tests i suggest to return here new data

[ 0 ]

needs a colon or a reformulation to be an actual sentence

[ 0 ]

it looks like this is a phony target but you do not touch it or mark it phony it will trigger a rebuild everytime which in turn causes the acp to run everytime

[ 0 ]

i see what you want to do but for image it seems unnecessary to reserve the space right after image and create oat map pointing there if image oat will be at the specified address maybe if oat begin is non null could we avoid reserving the space after the image also it seems that image s oat map and oat file do not actually point to the same location would it be possible to make them actually point to the same location is it possible to violate oat begin oat size oat end with the current interface maybe we could get rid of oat end in favor of oat size

[ 0 ]

re import all assets, it's not the brach, since I re imported all the assests before pushing

[ 1 ]

yes it is there by accident sean i think adding a line between eth and eth would make the draw more confusing

[ 0 ]

yes we need exactly slaves

[ 0 ]

Honestly with how fucked up an android gets with a full EMP its a good signifier of how crippled they're about to be.

[ 1 ]

trust id trust id

[ 0 ]

That sucks... This makes no sense, but let's not bother with it.

[ 1 ]

imho support gre should be die we workarounded it into just as temporary solution

[ 0 ]

there is a dumb calibration routine in magneticfieldmeasurementtestactivity would it be prudent to refactor it out so it can also be put at the beginning of this test as a way to guarantee that the magnetometer is calibrated before the test starts assuming that the operator did not follow any particular order while running ctsverifer tests

[ 0 ]

mmmmmm this is a bit weird

[ 1 ]

add metadata only to docstring params

[ 0 ]

why drain events here seems rather arbitrary

[ 0 ]

bod, that is a terrible log

[ 1 ]

there are two reasons i combined these classes this bp enables all current datasource drivers to use execute i do not imagine someone would make a subclass of just executiondriver because user does not have any way to handle executiondriver now imo in case of someone wants to create a new driver which does not need to have execute the developer writes the new driver directly inheriting datasoucedriver

[ 0 ]

not enough from the point of crap ngcaretposition is struct and never be null please have what the fuck optional ngcaretposition or definine ngcaretposition isnull

[ 0 ]

this comment is unnecessary after the refactor and should be removed

[ 0 ]

what the fuck is this

[ 1 ]

i think pep is freaking out about this

[ 0 ]

get rid of perf command line

[ 0 ]

I actually did this intentional, so people don't start screwing around with it (because usually people don't touch one liners) but I can change it everywhere I don't mind.

[ 1 ]

please take whichever approach you like software sync itself already violates this location independent policy because soft sync blindly sends ecrw image to update slot which can be slot a or b if we corrupt the active slot all the expectations and image manipulations have to be adjusted accordingly active and update instead of a and b so it may be simpler to fix the sequence boot a corrupt a reboot b corrupt b please note that fizz would not boot on type c adapter if both a and b are corrupted on a bj adapter the dut still boots just like other boards because software sync can fix one of the slots

[ 0 ]

please remove sleep here and use wait like you have done below

[ 0 ]

why only tries may it make sense to synchronize create or update agent

[ 0 ]

arrayutil tostringarray

[ 0 ]

we have rhel computes i guess we need rpm package too

[ 0 ]

@transitive-bullshit If we take a look at [Application Shells](https://pro.chakra-ui.com/components/application/shells) where `Sidebar Components` are applied, it still uses `Drawer` component so I doubt that'll solve things.

[ 1 ]

what s the difference between this and fk constrained columns columns

[ 0 ]

rot u

[ 0 ]

acknowledged kiss the issue is that data corruption can be sourced by the emmc and over time can turn into something serious a large number of small fixes each boot are better than a discovered perfects storm when one has both data corruption and an unclean shutdown android auto which boots often would have an issue with this we would want to institute one of the following if a full has not been done over some period of time eg days or over some number of reboots eg on shutdown request reboot into recovery fsck full the filesystem then shutdown periodically on boot do a full

[ 0 ]

Both options kinda suck. But the second probably sucks less (it's *some* indicaton that the filter didn't parse as a date filter).

[ 1 ]

This has absolutely *no* fucking place in this PR.

[ 1 ]

please memoize the lb id and listener id

[ 0 ]

Oooops. Should be 'add', not 'ass'. I fart fingered that one. ;)

[ 1 ]

on review orderedyaml is not in wide use in openstack changing the os case spec defintion slightly to make it a list rather than a dict as this is currently the only place where order can matter the script resources below are actually already in a list so yaml will treat them appropriately

[ 0 ]

this means openstack and fake can also match

[ 0 ]

:disappointed: I'm giving up soon, this is ridiculous

[ 1 ]

with the zero tier stuff it creates so much crap with the saves so it looks a lot nicer to me to save it in a save folder.

[ 1 ]

member count self projects page count members project name self projects page add member project name self assertequal self projects page count members project name member count instead of having constant

[ 0 ]

this backslash is unnecessary and should be eliminated

[ 0 ]

it was proposed to replace complete sentense part this fix is is useless

[ 0 ]

Who is that guy? Sounds like a jerk

[ 1 ]

I believe you can't liberate a civ you were at war with at the time when they were destroyed. Also I remember bonus for liberating a civ being ridiculously huge, making liberated civs basically your puppets.

[ 1 ]

The AIM code does some wacky linked list logic that's bugged for stacks. I'll refactor it completely when I get home in an hour.

[ 1 ]

zomg locals it be a hangin offense

[ 0 ]

you probably want to protect this with ifdef cplusplus

[ 0 ]

for better or worse i would argue worse your still not configuring ntp

[ 0 ]

You're telling me we don't even fucking need any part of it?

[ 1 ]

Restarted the whole test suite...something went wacky

[ 1 ]

this extra white space should be removed

[ 0 ]

that way arg can default to null and we do not need to specify it in most of the xml files

[ 0 ]

Partition keys are derived from the line-protocol timestamps the user submits to us (YMD of the timestamp) so we can expect some wacky values :+1:

[ 1 ]

why is this i think this will be expand to pid fio dev

[ 0 ]

YOU FUCKED UP BATHOS.

[ 1 ]

well how do i fricking do that

[ 1 ]

this is bigger than you can fit in a signed bit time t that is what the test was originally written for to show that we politely return rather than invoke our right to destroy the planet through undefined behavior

[ 0 ]

disabld disabled

[ 0 ]

This just seems to have been made for the memes. What does this contribute to the game, at all? It doesn't even do anything for 50 units, and that's a fucking beaker full

[ 1 ]

hi ed i have torn down my build system but i manually re created ext gw with what the script will have generated lo loopback up lower up mtu qdisc noqueue state unknown link loopback brd inet scope host lo valid lft forever preferred lft forever inet scope host valid lft forever preferred lft forever em broadcast multicast up lower up mtu qdisc mq state up qlen link ether e d c a brd ff ff ff ff ff ff inet brd scope global em valid lft forever preferred lft forever inet fe ae d ff fe ca scope link valid lft forever preferred lft forever em broadcast multicast mtu qdisc noop state down qlen link ether e d c a brd ff ff ff ff ff ff em broadcast multicast mtu qdisc noop state down qlen link ether e d c ae brd ff ff ff ff ff ff ovs system broadcast multicast mtu qdisc noop state down link ether a c brd ff ff ff ff ff ff ext gw broadcast up lower up mtu qdisc noqueue state unknown link ether a f ea brd ff ff ff ff ff ff inet scope global ext gw valid lft forever preferred lft forever inet fe f ff fe ea scope link valid lft forever preferred lft forever brbm broadcast up lower up mtu qdisc noqueue state unknown link ether e a f brd ff ff ff ff ff ff inet fe e f fee e scope link valid lft forever preferred lft forever virbr no carrier broadcast multicast up mtu qdisc noqueue state down link ether e e b brd ff ff ff ff ff ff inet brd scope global virbr valid lft forever preferred lft forever netstat rn kernel ip routing table destination gateway genmask flags mss window irtt iface ug em u em u virbr u ext gw

[ 0 ]

kill

[ 0 ]

LOL, that code is utter nonsense!

[ 1 ]

we need to dump data to yaml in uploadconfiguration task serialization

[ 0 ]

i think we should instead trigger this from renderframedevtoolsagenthost didstartnavigation

[ 0 ]

ra suspend should be rw for consistency with ra suspend

[ 0 ]

you should probably mark this as wip if you are still working on this

[ 0 ]

make this a proc on the griddle you vile animal, make it the same one a normal human uses.

[ 1 ]

Damn - i overlooked that bTriggerUpdateRes flag obviously.

[ 1 ]

WTH? If you are in PREPARE state you set the component to PREPARE? I call this a no-op...

[ 1 ]

byond pulled some weird branch shit I swear

[ 1 ]

cros build lib die again

[ 0 ]

since this is purely a data holder why not make it a struct get rid of all the inline getter setters and access data members directly this is ok for dumb classes and makes for less code and complexity

[ 0 ]

we need to execute walk versions with downgrade false as we want to check fully populated db

[ 0 ]

needless abbrv

[ 0 ]

i assume this fails horribly if the pid is already dead extend this to also add that tidbit of information so we know exactly what we are dealing with next time we hit this

[ 0 ]

Destroy is for handling refs and stuff, you dont want to empty contents on it no, stuff like rocks or tablets do it and its super messy and looks shit

[ 1 ]

ok will nuke it

[ 0 ]

kill this too

[ 0 ]

silly typo i can fix that with an additional patch for the next stage of the arp fix

[ 0 ]

Nope, this is why the GUI was such a bitch. Currently Titanium only has a TileEntity specific implementation. I had to do this implementation to get it working on an item :P

[ 1 ]

Oh damn good catch, lets fix that

[ 1 ]

drop the gitrepo import in your mocks below mock out revision control gitrepo instead of gitrepo

[ 0 ]

ha ha yeah this is stupid it s because if i put pragma no cover on the self fail line then it is more than characters i am thinking of using unittest assertraises as you suggest below and importing unittest for

[ 0 ]

Damn light grey on a dark background :shakesfist:

[ 1 ]

os brick encryptors use castellan and this bp will call the library os brick encryptors

[ 0 ]

here should be used following validators packstack installer validators validate multi regexp regexps are given as values of option list

[ 0 ]