text
stringlengths
1
5.2k
labels
listlengths
1
1
That is indeed an obvious fix. However, I feel like the bigger issue here is that the energy limit is 2147483647 mJ which is 2147 kJ. Which I feel is crippling when coupled with the fact that every single active bionic is powered by kJ of power and even the power capacity upgrades do things by kJ of power. So wouldn't it be simpler to figure out how to change the mJ to kj? Thus increasing the limit to 2147483647 kj? Which is honestly a bit absurd. Like that's a nuclear power plant at that point. However, wouldn't it also fit the changes to the unit of power that most bionics use?
[ 1 ]
method get keys has common cases you covered only two of them here is list of cases that should be covered by tests self extra specs is none and prefer resource data is true self extra specs is none and prefer resource data is false self extra specs is dict with data and prefer resource data is true self extra specs is dict with data and prefer resource data is false
[ 0 ]
Damn, not prettier again.. On it!)
[ 1 ]
keystone public port
[ 0 ]
yeah some rebasing stupidity on my part this stack does not need to be on top of cron anyway reparented
[ 0 ]
yeah let us kill it or still declare it with an underscore before it to denote that it is a private var and then do android mnc build targets android common build targets and then do not reference android common build targets in any of the other files
[ 0 ]
netapp legal can choose to have the code submitted or drop the copyright s they re useless git history shows clearly who comitted the code and provides an author tag as well
[ 0 ]
@gianm if you are ok with this wacky way, will update the corresponding docs and runtime property files.
[ 1 ]
@hartez will you reopen this pls? Or should we create a new issue and wait another year for a fix? This issue was first reported December 2019, the 'fix' released 10 months later. And we broke the 'fix' in 10 minutes which doesn't say much for your QA. I know that Maui is the new and shiny but come on, fix the nonsense we are currently using at least.
[ 1 ]
since get class is mocked and it ultimately return the utils class we may not need to mock these utils classes in the ops tests for example in test vmops in setup we have something like self vmops vmutils mock magicmock this will no longer be necessary is this change in the scope of this patch what do you say cbelu
[ 0 ]
this in particular suggests that this should not be a bionic test you re allowed to add your own gtests to cts
[ 0 ]
the pid would be useful here so that in case multiple migrations happen in the same time you could distinguish between them
[ 0 ]
i have difficulties in understanding this sentence the one starting with however were this not possible it s either me dumb or the sentence need a bit of rephrasing for dumb people like me
[ 0 ]
no cd dest ovn repo name
[ 0 ]
Please add a "FUCKING DISABLE THIS ON PRODUCTION SERVERS OR YOU WILL GET REKT" comment
[ 1 ]
is it better to add parentheses here qe neutronclientexception
[ 0 ]
you should replace tabulations with spaces
[ 0 ]
it may be a stupid question but could not those debug prints be better managed as log lines at debug level
[ 0 ]
perhaps now that we have dropped the fk would be better than after we drop fk
[ 0 ]
Hell, get rid of the ifs entirely. They should just be ex_whatever = Clamp(round(created_volume / #), 0, ex_max)
[ 1 ]
why do not you use utils add boolean argument
[ 0 ]
if anyone has any suggestions to where to put this shit please tell me, because `_misc.less` existing at all is annoying
[ 1 ]
this comment threw me because i did not understand that the via part was saying that there was an intermediate data structure i would instead say something like mapping of directories globs in the directory owners
[ 0 ]
what could i do to make it not ass?
[ 1 ]
should remove sslvxx from there as those are deprecated with the recent poodle attacks
[ 0 ]
Damn. You're right, that should be caught.
[ 1 ]
if you set block migration
[ 0 ]
think of it as generalization of it expands each member of the array postinst bios args separately as if it was surrounded by double quotes if the array is empty it expands to nothing at all
[ 0 ]
this cleanup probably does not belong here you leave similar garbage intact in other files
[ 0 ]
is it related to yes lucas imo this not a wsme bug in your example we have ok fake driver does not support pass deploy info method bad url admin can set api url option manually or in last case right should be stripped
[ 0 ]
russell are right will address this in next patch later
[ 0 ]
Yup it was literally flashing people twice
[ 1 ]
Oh lord I messed that up royally, guess that's what I get for not using the resolve editor properly
[ 1 ]
what test harness are you using for this why not use unittest it is already installed and has a consistent interface and output just curious i do not see from this commit how these tests are being executed so i thought i would ask
[ 0 ]
this should only be run conditionally if self conf enable metadata proxy
[ 0 ]
vendor name should be huawei
[ 0 ]
Oh shit, forgot to remove the commented out code
[ 1 ]
> resourceVersion semantics would be wacky It would be simplest not to support it. You get a watch of project-cache updates from the point in time at which you request it. ResourceVersions would match actual project resource versions.
[ 1 ]
i wanted to destroy the objects in the same order as the original code while looking back at the code i think my first patchset destroy them too early which could introduce other issues so instead in patchset i have used scopedclosurerunner to ensure objects are destroyed in reverse order of the declaration and get the same ordering as before your change
[ 0 ]
seems useless now
[ 0 ]
useless i think
[ 0 ]
i believe it is msan reporting problems i am not sure exactly what evan was seeing but i will mention we add this switch to a bunch of other suites views mus unittests ash unittests windowserverservicetestbase maybe evan is seeing the same issues as mentioned here
[ 0 ]
it is a bug that it does not error out when the generation fails though this line should be quiet src gen syscalls sh
[ 0 ]
Again. When you like to laser- **_cut**_ (not picture engrave) you'd like to have a constant energy per mm. The number of stepper pulses for the extruder is then directly proportional to the way and adjustable by the amount of extruded material. Routing the extruder step pulses to a MOSFET driven output (like the extruder heater) can be done via the pin-file. Using the stepper-drivers output will give you a AC - is rubbish.
[ 1 ]
Weird this isn't a struct copy.
[ 1 ]
between these recommendation i lean to join carlos because i think adduniqueurlstask should be run later to delete zombies the chances of chrome to be killed now is probably slim because supposedly this happens when chrome is in foreground
[ 0 ]
this overwrites the above local shared libraries libstlport
[ 0 ]
self repo schema return value self repo schema
[ 0 ]
Agreed the parentView thing is ridiculous and a fix is planned. Is it okay to close the original issue?
[ 1 ]
need a ban list to prevent runtimes, I would suggest excluding any anchored object. That way you can't teleport Apcs and shit and end up breaking stuff. Do you remember bluespace slimes?
[ 1 ]
i hate console programs eating random characters on my terminal but that is a question of personal taste
[ 0 ]
Yeah there are a lot of things where analysis is not good enough :) It's in the design of the analysis itself. So, just because the analysis currently sucks, it doesn't mean we should continue adding wrong algorithms on top of that
[ 1 ]
sdasfasd shit woops oops
[ 1 ]
i do not believe you need to mock cinder db snapshot metadata get since you already have the snapshot metadata in your dict here
[ 0 ]
could we git rid of query suffix feels like we can use base utf toutf features answerserverquerysuffix at l wdyt
[ 0 ]
no need to this validator as there is no not supported match
[ 0 ]
I am sorry but I think this goes way too far. This is trivial code spanning a zillion lines and being extracted to multiple functions. IMO that's ridiculous...
[ 1 ]
probably worth noting that this is copied out of reimager and that we should kill both once the todo bug is addressed
[ 0 ]
you re going to get a pep violation on this please see
[ 0 ]
Someone needs to make these damn things defines
[ 1 ]
Pipe building uses temporary pipes in nullspace to get the connection directions. Very ugly, but there's no simple alternative.
[ 1 ]
It might be the browser, but the indents are looking weird in this method.
[ 1 ]
should be uppercase f initfacets
[ 0 ]
We really need to clean up bad publicity, lol. This is ugly af
[ 1 ]
To work metal with circ. saw you need good blade and special "table" ( probably like this: http://www.csunitec.com/saws/dry-cutting-chop-saws.html or biger (unmovable) ). But, damn, I really want to see some metalworking workshops ingame.
[ 1 ]
By and large, changing argument names is a no-no as we need to maintain backward compatibility. Going from a positional argument to an optional one is probably not too bad, but still... Admittedly, the original name is clumsy as heck.
[ 1 ]
this is purely me being lazy i am not attached to this change i only did it for line of globname cxx
[ 0 ]
lame this is causing the failures x x
[ 0 ]
this is redudant this should be removed or the one in conductors yml should be removed
[ 0 ]
hmm does the end person want to know what state it was trying to be set to when it failed nostate seems somewhat useless
[ 0 ]
I knew I should have finished that damn spawn method fixing PR.... these will be not so fun to resolve conflicts on... but hey, that's what I get! \U0001f622
[ 1 ]
nit add a simple constructor so it is not possible to create one of these with garbage in the type member
[ 0 ]
can you get rid of the white space above
[ 0 ]
It seems that even traitors will have the innocent role. This is weird
[ 1 ]
no reason other than it was like lines less code no need to unwarp grpc responses b decode etc as a dumb proxy cbe is not going away anyways
[ 0 ]
the list should match hellfire, if we start mixing it gets reallly complicated
[ 1 ]
please use mock instead of mox
[ 0 ]
dirty business of mixin s in the context of where this is called this is going to be the l plugin so you do not need line and you can just do self
[ 0 ]
you need to add a dummy option here like default otherwise the first zone will always be sent to the scheduler whether the user selects it or not see the snapshot selector above for an example
[ 0 ]
will it just keep failing and eating users quota if the next try does not wait for a certain period of time as indicated by retry after field of overlimit
[ 0 ]
multiple hosts entry will require escape characters in the configuration is that intended
[ 0 ]
run tests sh should be run tests sh with an underscore instead of a dash
[ 0 ]
This is getting super annoying. Hacking inside shrinkwrap like this is unmaintainable. I will use beta webpack from now on, since it's just impossible to remember to rewrite the shrinkwrap all the damn time
[ 1 ]
i suggest to say copy the contents of the id rsa pub id dsa pub file and give the default location as file x in directory ssh in your home dir
[ 0 ]
i do not think we should delete jobs that have been abandoned since it looks like when a worker fails or is not able to complete a job it get s put back for other workers to claim see jobboard abandon
[ 0 ]
use syslog log facility savanna cuz syslog log facility is undef
[ 0 ]
this is really ugly, just replace it with `[]` template strings. i know it's copypasta or whatever but might as well
[ 1 ]
maundotext matext getstr should avoid teh allocation of a temp copy of oustring triggered by tostring although ti probably would be cleaner to add an overload of to support oustring oustringbuffer directly
[ 0 ]
Who the hell thought this was a good idea?
[ 1 ]
What an awful idea, sec should be powerful so antags actually have to put in effort
[ 1 ]
Wtf. First arg must be a constant string.
[ 1 ]
Ugh, to all of this udp-specific nonsense but also good that we fixed it...
[ 1 ]
does not matter really since sdk instance will get garbage collected so it will get collected too
[ 0 ]
update comment no longer excluding
[ 0 ]
Every. fucking. time.
[ 1 ]
Lmao yeah wtf out of all things why an actual cigarette
[ 1 ]
if msubjecttext null msubjecttext msubjecttexteditor gettext
[ 0 ]
>Dionae is a pretty shit race lets not lie. Yeah man regenerating through anything but burn damage So shit
[ 1 ]
i do not know it is probably ok the way it is as these execute during initialization and currently we log an error message clean up and exit the daemon when we hit these errors which is fine by me unless you feel strongly about this i will not change it
[ 0 ]
while you are here this should probably be const std string
[ 0 ]