showvikdbz/code-reviews · Datasets at Hugging Face

text stringlengths 1 5.2k	labels listlengths 1 1
hum s used with s is used to show errors on stdout but you redirect this output to dev null it is intended we can maybe curl on horizon just tested and we need to add this ln s etc hiera yaml etc puppet hiera yaml echo apache default vhost false var lib hiera defaults yaml add a test on the http return code on horizon path just the http code curl sl w http code url effective n o dev null wdyt	[ 0 ]
you could name it to something that sounds bad but doesn't exist in reality so doesn't need a proper recipe, like mindbreaker	[ 1 ]
This is a disgusting hacky approach and you can in fact delete the toxin. Define the `CheckParts()` proc on your soup to call `..()` and then delete any `"toxin"`. `/obj/item/reagent_containers/food/snacks/soup/toadlicksoup/CheckParts()`	[ 1 ]
these should be called something like `SPELL_SPECIALIZATION_DEFAULT` because macros are global and generic names suck	[ 1 ]
My point is consistency. Solar is great but making a solar car with only some panels here and there is ridiculous. Just because this game is full of bloat doesn't mean it has to be the norm.	[ 1 ]
I've realised this is nonsense \U0001f926 but I've tracked down the real thing	[ 1 ]
how many times have i made this comment? God mech code is so shitty	[ 1 ]
in the no wake i think logically this needs to be int ehw wake signal group	[ 0 ]
> Just to record for posterity: I hate the ISO `PRI*` macro nonsense with a fiery passion. Amen. I'm 100% with you.	[ 1 ]
oh, that's kind of annoying, I'll look into redoing it to be based off of other shit	[ 1 ]
what about not options comper and options compare options dump	[ 0 ]
> before you merge rubbish "One man's trash is another man's treasure."	[ 1 ]
oops, should have black screen and shit, lemme look into it oopsies	[ 1 ]
strictly speaking it does not belong to this patch i have uploaded a new one	[ 0 ]
here you are unpacking the list and creating a string then passing the string to ssh execute ssh execute then unpacks the string and creates a trash command	[ 0 ]
we should have same fk names for all backends	[ 0 ]
this seems a little roundabout to me why do these need to be json and why are they stored in yaml in the first place the commit message does not make it clear why this is needed these need a refreshonly true for each exec otherwise they will execute on every puppet run	[ 0 ]
use assertfalse instead of asserttrue not	[ 0 ]
bloodsuckers are a species	[ 1 ]
@danielkesselberg Thank you for your help so far. I did write a patch for "tests/Core/Controller/LoginControllerTest.php" using createMock. This is something I have never done before, so it might be total rubbish...	[ 1 ]
so this whole check is bunk i only have mocks here because i override the side effect on with one on so this actually fails properly when i check build req destroy called	[ 0 ]
i thought there was already a patch with a get document from search but i cannot find it in any case i would be fine with generalising this and moving it into helpers although i would prefer to file a bp with neutron to ask that the sec group id be included in rule delete notifications because that would be infinitely preferable	[ 0 ]
Ehhh, what the hell. Done.	[ 1 ]
I live in India and hate Pakistan. I met this hot tub twitch streamer ladyboy and sent her 50bits which is like arm and leg of holy cow (a lot). She was angry liek Shiva and called me retard. But I love her and I need to send her more money.	[ 1 ]
i am confused this is the tar process we are checking if it has exited why do we need to kill it it is already dead we already check the exit code in finish subprocess	[ 0 ]
we really need to kill this already	[ 0 ]
Damnit I was gonna rework bolas and you just did it before me, faster and better! Great work as always your a legend.	[ 1 ]
s hid hide also not sure what you mean by hide it how do you hide it exactly if it is just a dummy network it can also be created in the service tenant with some constant name and the cloud admin should know if he reads manuals that this network should not be touched i do not see any special reason why an empty tenant id should be used	[ 0 ]
nit the swap from single quotes at l to double here is killing my ocd	[ 0 ]
possibly a dumb question but how come we do not have lines here or are they not reachable	[ 0 ]
drop this method definition conf and local conf are now useless	[ 0 ]
execute this block before setting the state set to complte above	[ 0 ]
what the hell is ^M ?:D	[ 1 ]
this seems useless now as you already moved the function to ironic lib	[ 0 ]
how does the idp id get filled in i assume because it is a fk maybe add a comment saying that since it is not particularly obvious	[ 0 ]
i don't know, osu web is ridiculous. [look at this](https://imgur.com/a/Xes3E91), selecting HD gives HDDT but selecting HDDT gives NC?	[ 1 ]
I agree that creating buffers on demand sucks. But we can't add a fixed cost to every single project just to benefit users of a particular feature	[ 1 ]
i think the print should be removed	[ 0 ]
tmp dir should be empty at this point i think better raise exception from here if something wrong	[ 0 ]
Literally worse than ninja code. r u serious m8?	[ 1 ]
i think this word should be removed	[ 0 ]
what does this look like if you have a shitload of users	[ 1 ]
sudo launch sh to look as a inline code insert	[ 0 ]
this blank line should be eliminated	[ 0 ]
i propose kill s pid it looks fine d proc pid is also good and decreases numbers of forks	[ 0 ]
I think that either needs to be removed or made more obvious jeeze that is just awful	[ 1 ]
Hmm, weird. I changed my IDE so it uses tabs instead of spaces because Travis failed, and now the indentation is messed up in Github. I'll look into it.	[ 1 ]
this is a matter of data flow analysis should we perform dead code elimination on lir in future a missing reg use flag here would spell trouble	[ 0 ]
i hope you meant ipv pid instead of pid subnet	[ 0 ]
I confirm this from my tests. With or without T10 (2000 attack power), the gargoyle did 168 spell damage which is RIDICULOUS. Someone told she should be doing 3000 dmg per hit (it's the ultimate spell of the unholy DK)	[ 1 ]
let us remove volume id from function parameter	[ 0 ]
any reason we are not using drm ioctl virtgpu map defined in virtgpu drm h do we get lucky with the dumb map because in the host	[ 0 ]
you probably need unchecked cast because the map may already be dead at this point	[ 0 ]
without preventing curl really does not make any sense here dump it if it imo	[ 0 ]
if the mmap op fails mmap region will call unmap region on the region which zaps all the ptes	[ 0 ]
eliminate backslash	[ 0 ]
could you remove a white space	[ 0 ]
use matchers haslength	[ 0 ]
can we have a test case for this with mocks	[ 0 ]
never do this you are putting to scenario as clients admin client you can destroy everything	[ 0 ]
with the removal of disconnect is there tpm context handle leakage	[ 0 ]
Tests fails now - but the PR does not change any code, only comments. I do not understand why the CI is so wacky	[ 1 ]
fqdn onlys alphanumberic and dash only i will relpace with the following regex re sub a za z instance name strip	[ 0 ]
imo dirname readlink e is more robust	[ 0 ]
integration testing using local devstack results in the following exception info gbpservice neutron plugins ml plus drivers apic aim mechanism driver req ad d f d aa a cc b admin apic aim md extending dict for network status active subnets availability zone hints availability zones name u l p g provider physical network u physnet admin state up true tenant id u b e a f bdbc a c fc description none ipv address scope none ipv address scope none mtu router external false port security enabled true vlan transparent none shared false provider network type u opflex id e a c a b a c e provider segmentation id none debug keystoneclient auth identity v req ad d f d aa a cc b admin making authentication request to get auth ref usr local lib python dist packages keystoneclient auth identity v py debug keystoneclient session req ad d f d aa a cc b admin request returned failure status request usr local lib python dist packages keystoneclient session py debug keystoneclient v client req ad d f d aa a cc b admin authorization failed get raw token from identity service usr local lib python dist packages keystoneclient v client py error gbpservice neutron plugins ml plus drivers apic aim apic mapper req ad d f d aa a cc b admin the request you have made requires authentication http request id req f e b ec e f e c da de error gbpservice neutron plugins ml plus drivers apic aim apic mapper traceback most recent call last error gbpservice neutron plugins ml plus drivers apic aim apic mapper file opt stack gbp gbpservice neutron plugins ml plus drivers apic aim apic mapper py line in tenant error gbpservice neutron plugins ml plus drivers apic aim apic mapper auth url auth url error gbpservice neutron plugins ml plus drivers apic aim apic mapper file usr local lib python dist packages keystoneclient v client py line in init error gbpservice neutron plugins ml plus drivers apic aim apic mapper self authenticate error gbpservice neutron plugins ml plus drivers apic aim apic mapper file usr local lib python dist packages positional init py line in inner error gbpservice neutron plugins ml plus drivers apic aim apic mapper return func args kwargs error gbpservice neutron plugins ml plus drivers apic aim apic mapper file usr local lib python dist packages keystoneclient httpclient py line in authenticate error gbpservice neutron plugins ml plus drivers apic aim apic mapper resp self get raw token from identity service kwargs error gbpservice neutron plugins ml plus drivers apic aim apic mapper file usr local lib python dist packages keystoneclient v client py line in get raw token from identity service error gbpservice neutron plugins ml plus drivers apic aim apic mapper return plugin get auth ref self session error gbpservice neutron plugins ml plus drivers apic aim apic mapper file usr local lib python dist packages keystoneclient auth identity v py line in get auth ref error gbpservice neutron plugins ml plus drivers apic aim apic mapper authenticated false log false error gbpservice neutron plugins ml plus drivers apic aim apic mapper file usr local lib python dist packages keystoneclient session py line in post error gbpservice neutron plugins ml plus drivers apic aim apic mapper return self request url post kwargs error gbpservice neutron plugins ml plus drivers apic aim apic mapper file usr local lib python dist packages positional init py line in inner error gbpservice neutron plugins ml plus drivers apic aim apic mapper return func args kwargs error gbpservice neutron plugins ml plus drivers apic aim apic mapper file usr local lib python dist packages keystoneclient session py line in request error gbpservice neutron plugins ml plus drivers apic aim apic mapper raise exceptions from response resp method url error gbpservice neutron plugins ml plus drivers apic aim apic mapper unauthorized the request you have made requires authentication http request id req f e b ec e f e c da de error gbpservice neutron plugins ml plus drivers apic aim apic mapper	[ 0 ]
yes. I tested it. Was concerned as well. Was hard as hell to test because i can't spawn 2 abductors because for some reason it deletes the other abductor if it has no ckey attached to it.	[ 1 ]
damnit. :dancing_men:	[ 1 ]
you should ignore oserror with errno here i think this deserves a separate test you should mock popen kill to raise oserror with errno or permissionerror in py and see if this code handles it well	[ 0 ]
multi line comment should be blah blah blah	[ 0 ]
Sometimes i forget to add an Manifold but there is already air flowing through the pipe,so it sucks i can't unwrench the pipe to add a manifold and extend the line to another room	[ 1 ]
I'll deal with the appdirs nonsense.	[ 1 ]
i agree the onupdate trigger should be removed	[ 0 ]
WTF, should have been omitted - it's part of the frontend	[ 1 ]
with this change this todo is redundant and therefore should be removed	[ 0 ]
I've approved this now, because this PR does fix one issue, and needs to go in. It's ridiculous that this should be blocked because we have issues figuring out another issue. Let's take that to another PR.	[ 1 ]
stupid question no need to unregister in the catalog	[ 0 ]
this is a hack for sure we really need a more thorough cleanup of libbcc	[ 0 ]
Faggots are now called meatballs in the code, as they have the same meaning, just one also happens to be a slur.	[ 1 ]
noqa should be removed	[ 0 ]
use a dash as a bullet instead of o	[ 0 ]
oslosphinx should be used instead	[ 0 ]
please use trove testtools testcase as the base it will help you to discover leaked mocks like the ones below	[ 0 ]
no try finally for you zipfile	[ 0 ]
probably remove this bit about the working set of toolchain sources and download toolchain sources sh since they are now irrelevant	[ 0 ]
you could just delete these vars since they are empty	[ 0 ]
Thanks. I think the comment was a little bit clumsy so I rephrased it. I hope you don\u2019t mind!	[ 1 ]
better to put this on the stack once rather than temp on the stack and malloc and dup	[ 0 ]
you miss an unittest with host fakehost	[ 0 ]
can you use the dictionary from line above so that the build number is not hard coded here thanks m client getwsapiversion return value self wsapi version latest	[ 0 ]
boring comment consider making unit test names a bit more intuitive you ve already done a lot of effort in this way but let us make them dumb reviewer proof consider test specific flat segment is not partial spec test specific vlan segment is not partial spec or test partial vlan segment is partial spec as it pertains just naming things this comment too is totally optional	[ 0 ]
do we have anything like plugins depending on the corosync nodes if so i shall do this removal via the deprecation	[ 0 ]
Yeah, this sucks. I can't think of any way around it besides gchanan's idea, but I think it's not a good idea to have a big pile of zeros hanging around either. Maybe we should just add a `nograd_zero_` method just for this case, blegh.	[ 1 ]
This is weird and ugly.	[ 1 ]
@dnephin, still looks like an upstream build/ci issue. I give up. @aanand has already indicated the approach is rubbish... so I'll just go use https://github.com/rancher/rancher-compose instead, since they're not running around chasing their tails.	[ 1 ]
actually getfoundarraylength returns harraylength so this is not needed at one point in my change getfoundarraylength returns hinstruction but not anymore	[ 0 ]
i believe we can get rid of missing object by rewriting condition that way if sel fuck not in obj dict	[ 0 ]
just lower of the bulk price they are crappy spears	[ 1 ]
Copilot has fucked me.	[ 1 ]
Oh damn. Thanks for pointing it out. I meant to do 30 minutes, so `1800000`, but somehow messed up there :D	[ 1 ]
bro i actually have no damn idea how i messed that comment up this bad lmao. It must have been like 3am	[ 1 ]

hum s used with s is used to show errors on stdout but you redirect this output to dev null it is intended we can maybe curl on horizon just tested and we need to add this ln s etc hiera yaml etc puppet hiera yaml echo apache default vhost false var lib hiera defaults yaml add a test on the http return code on horizon path just the http code curl sl w http code url effective n o dev null wdyt

[ 0 ]

you could name it to something that sounds bad but doesn't exist in reality so doesn't need a proper recipe, like mindbreaker

[ 1 ]

This is a disgusting hacky approach and you can in fact delete the toxin. Define the `CheckParts()` proc on your soup to call `..()` and then delete any `"toxin"`. `/obj/item/reagent_containers/food/snacks/soup/toadlicksoup/CheckParts()`

[ 1 ]

these should be called something like `SPELL_SPECIALIZATION_DEFAULT` because macros are global and generic names suck

[ 1 ]

My point is consistency. Solar is great but making a solar car with only some panels here and there is ridiculous. Just because this game is full of bloat doesn't mean it has to be the norm.

[ 1 ]

I've realised this is nonsense \U0001f926 but I've tracked down the real thing

[ 1 ]

how many times have i made this comment? God mech code is so shitty

[ 1 ]

in the no wake i think logically this needs to be int ehw wake signal group

[ 0 ]

> Just to record for posterity: I hate the ISO `PRI*` macro nonsense with a fiery passion. Amen. I'm 100% with you.

[ 1 ]

oh, that's kind of annoying, I'll look into redoing it to be based off of other shit

[ 1 ]

what about not options comper and options compare options dump

[ 0 ]

> before you merge rubbish "One man's trash is another man's treasure."

[ 1 ]

oops, should have black screen and shit, lemme look into it oopsies

[ 1 ]

strictly speaking it does not belong to this patch i have uploaded a new one

[ 0 ]

here you are unpacking the list and creating a string then passing the string to ssh execute ssh execute then unpacks the string and creates a trash command

[ 0 ]

we should have same fk names for all backends

[ 0 ]

this seems a little roundabout to me why do these need to be json and why are they stored in yaml in the first place the commit message does not make it clear why this is needed these need a refreshonly true for each exec otherwise they will execute on every puppet run

[ 0 ]

use assertfalse instead of asserttrue not

[ 0 ]

bloodsuckers are a species

[ 1 ]

@danielkesselberg Thank you for your help so far. I did write a patch for "tests/Core/Controller/LoginControllerTest.php" using createMock. This is something I have never done before, so it might be total rubbish...

[ 1 ]

so this whole check is bunk i only have mocks here because i override the side effect on with one on so this actually fails properly when i check build req destroy called

[ 0 ]

i thought there was already a patch with a get document from search but i cannot find it in any case i would be fine with generalising this and moving it into helpers although i would prefer to file a bp with neutron to ask that the sec group id be included in rule delete notifications because that would be infinitely preferable

[ 0 ]

Ehhh, what the hell. Done.

[ 1 ]

I live in India and hate Pakistan. I met this hot tub twitch streamer ladyboy and sent her 50bits which is like arm and leg of holy cow (a lot). She was angry liek Shiva and called me retard. But I love her and I need to send her more money.

[ 1 ]

i am confused this is the tar process we are checking if it has exited why do we need to kill it it is already dead we already check the exit code in finish subprocess

[ 0 ]

we really need to kill this already

[ 0 ]

Damnit I was gonna rework bolas and you just did it before me, faster and better! Great work as always your a legend.

[ 1 ]

s hid hide also not sure what you mean by hide it how do you hide it exactly if it is just a dummy network it can also be created in the service tenant with some constant name and the cloud admin should know if he reads manuals that this network should not be touched i do not see any special reason why an empty tenant id should be used

[ 0 ]

nit the swap from single quotes at l to double here is killing my ocd

[ 0 ]

possibly a dumb question but how come we do not have lines here or are they not reachable

[ 0 ]

drop this method definition conf and local conf are now useless

[ 0 ]

execute this block before setting the state set to complte above

[ 0 ]

what the hell is ^M ?:D

[ 1 ]

this seems useless now as you already moved the function to ironic lib

[ 0 ]

how does the idp id get filled in i assume because it is a fk maybe add a comment saying that since it is not particularly obvious

[ 0 ]

i don't know, osu web is ridiculous. [look at this](https://imgur.com/a/Xes3E91), selecting HD gives HDDT but selecting HDDT gives NC?

[ 1 ]

I agree that creating buffers on demand sucks. But we can't add a fixed cost to every single project just to benefit users of a particular feature

[ 1 ]

i think the print should be removed

[ 0 ]

tmp dir should be empty at this point i think better raise exception from here if something wrong

[ 0 ]

Literally worse than ninja code. r u serious m8?

[ 1 ]

i think this word should be removed

[ 0 ]

what does this look like if you have a shitload of users

[ 1 ]

sudo launch sh to look as a inline code insert

[ 0 ]

this blank line should be eliminated

[ 0 ]

i propose kill s pid it looks fine d proc pid is also good and decreases numbers of forks

[ 0 ]

I think that either needs to be removed or made more obvious jeeze that is just awful

[ 1 ]

Hmm, weird. I changed my IDE so it uses tabs instead of spaces because Travis failed, and now the indentation is messed up in Github. I'll look into it.

[ 1 ]

this is a matter of data flow analysis should we perform dead code elimination on lir in future a missing reg use flag here would spell trouble

[ 0 ]

i hope you meant ipv pid instead of pid subnet

[ 0 ]

I confirm this from my tests. With or without T10 (2000 attack power), the gargoyle did 168 spell damage which is RIDICULOUS. Someone told she should be doing 3000 dmg per hit (it's the ultimate spell of the unholy DK)

[ 1 ]

let us remove volume id from function parameter

[ 0 ]

any reason we are not using drm ioctl virtgpu map defined in virtgpu drm h do we get lucky with the dumb map because in the host

[ 0 ]

you probably need unchecked cast because the map may already be dead at this point

[ 0 ]

without preventing curl really does not make any sense here dump it if it imo

[ 0 ]

if the mmap op fails mmap region will call unmap region on the region which zaps all the ptes

[ 0 ]

eliminate backslash

[ 0 ]

could you remove a white space

[ 0 ]

use matchers haslength

[ 0 ]

can we have a test case for this with mocks

[ 0 ]

never do this you are putting to scenario as clients admin client you can destroy everything

[ 0 ]

with the removal of disconnect is there tpm context handle leakage

[ 0 ]

Tests fails now - but the PR does not change any code, only comments. I do not understand why the CI is so wacky

[ 1 ]

fqdn onlys alphanumberic and dash only i will relpace with the following regex re sub a za z instance name strip

[ 0 ]

imo dirname readlink e is more robust

[ 0 ]

integration testing using local devstack results in the following exception info gbpservice neutron plugins ml plus drivers apic aim mechanism driver req ad d f d aa a cc b admin apic aim md extending dict for network status active subnets availability zone hints availability zones name u l p g provider physical network u physnet admin state up true tenant id u b e a f bdbc a c fc description none ipv address scope none ipv address scope none mtu router external false port security enabled true vlan transparent none shared false provider network type u opflex id e a c a b a c e provider segmentation id none debug keystoneclient auth identity v req ad d f d aa a cc b admin making authentication request to get auth ref usr local lib python dist packages keystoneclient auth identity v py debug keystoneclient session req ad d f d aa a cc b admin request returned failure status request usr local lib python dist packages keystoneclient session py debug keystoneclient v client req ad d f d aa a cc b admin authorization failed get raw token from identity service usr local lib python dist packages keystoneclient v client py error gbpservice neutron plugins ml plus drivers apic aim apic mapper req ad d f d aa a cc b admin the request you have made requires authentication http request id req f e b ec e f e c da de error gbpservice neutron plugins ml plus drivers apic aim apic mapper traceback most recent call last error gbpservice neutron plugins ml plus drivers apic aim apic mapper file opt stack gbp gbpservice neutron plugins ml plus drivers apic aim apic mapper py line in tenant error gbpservice neutron plugins ml plus drivers apic aim apic mapper auth url auth url error gbpservice neutron plugins ml plus drivers apic aim apic mapper file usr local lib python dist packages keystoneclient v client py line in init error gbpservice neutron plugins ml plus drivers apic aim apic mapper self authenticate error gbpservice neutron plugins ml plus drivers apic aim apic mapper file usr local lib python dist packages positional init py line in inner error gbpservice neutron plugins ml plus drivers apic aim apic mapper return func args kwargs error gbpservice neutron plugins ml plus drivers apic aim apic mapper file usr local lib python dist packages keystoneclient httpclient py line in authenticate error gbpservice neutron plugins ml plus drivers apic aim apic mapper resp self get raw token from identity service kwargs error gbpservice neutron plugins ml plus drivers apic aim apic mapper file usr local lib python dist packages keystoneclient v client py line in get raw token from identity service error gbpservice neutron plugins ml plus drivers apic aim apic mapper return plugin get auth ref self session error gbpservice neutron plugins ml plus drivers apic aim apic mapper file usr local lib python dist packages keystoneclient auth identity v py line in get auth ref error gbpservice neutron plugins ml plus drivers apic aim apic mapper authenticated false log false error gbpservice neutron plugins ml plus drivers apic aim apic mapper file usr local lib python dist packages keystoneclient session py line in post error gbpservice neutron plugins ml plus drivers apic aim apic mapper return self request url post kwargs error gbpservice neutron plugins ml plus drivers apic aim apic mapper file usr local lib python dist packages positional init py line in inner error gbpservice neutron plugins ml plus drivers apic aim apic mapper return func args kwargs error gbpservice neutron plugins ml plus drivers apic aim apic mapper file usr local lib python dist packages keystoneclient session py line in request error gbpservice neutron plugins ml plus drivers apic aim apic mapper raise exceptions from response resp method url error gbpservice neutron plugins ml plus drivers apic aim apic mapper unauthorized the request you have made requires authentication http request id req f e b ec e f e c da de error gbpservice neutron plugins ml plus drivers apic aim apic mapper

[ 0 ]

yes. I tested it. Was concerned as well. Was hard as hell to test because i can't spawn 2 abductors because for some reason it deletes the other abductor if it has no ckey attached to it.

[ 1 ]

damnit. :dancing_men:

[ 1 ]

you should ignore oserror with errno here i think this deserves a separate test you should mock popen kill to raise oserror with errno or permissionerror in py and see if this code handles it well

[ 0 ]

multi line comment should be blah blah blah

[ 0 ]

Sometimes i forget to add an Manifold but there is already air flowing through the pipe,so it sucks i can't unwrench the pipe to add a manifold and extend the line to another room

[ 1 ]

I'll deal with the appdirs nonsense.

[ 1 ]

i agree the onupdate trigger should be removed

[ 0 ]

WTF, should have been omitted - it's part of the frontend

[ 1 ]

with this change this todo is redundant and therefore should be removed

[ 0 ]

I've approved this now, because this PR does fix *one* issue, and needs to go in. It's ridiculous that this should be blocked because we have issues figuring out *another* issue. Let's take that to another PR.

[ 1 ]

stupid question no need to unregister in the catalog

[ 0 ]

this is a hack for sure we really need a more thorough cleanup of libbcc

[ 0 ]

Faggots are now called meatballs in the code, as they have the same meaning, just one also happens to be a slur.

[ 1 ]

noqa should be removed

[ 0 ]

use a dash as a bullet instead of o

[ 0 ]

oslosphinx should be used instead

[ 0 ]

please use trove testtools testcase as the base it will help you to discover leaked mocks like the ones below

[ 0 ]

no try finally for you zipfile

[ 0 ]

probably remove this bit about the working set of toolchain sources and download toolchain sources sh since they are now irrelevant

[ 0 ]

you could just delete these vars since they are empty

[ 0 ]

Thanks. I think the comment was a little bit clumsy so I rephrased it. I hope you don\u2019t mind!

[ 1 ]

better to put this on the stack once rather than temp on the stack and malloc and dup

[ 0 ]

you miss an unittest with host fakehost

[ 0 ]

can you use the dictionary from line above so that the build number is not hard coded here thanks m client getwsapiversion return value self wsapi version latest

[ 0 ]

boring comment consider making unit test names a bit more intuitive you ve already done a lot of effort in this way but let us make them dumb reviewer proof consider test specific flat segment is not partial spec test specific vlan segment is not partial spec or test partial vlan segment is partial spec as it pertains just naming things this comment too is totally optional

[ 0 ]

do we have anything like plugins depending on the corosync nodes if so i shall do this removal via the deprecation

[ 0 ]

Yeah, this sucks. I can't think of any way around it besides gchanan's idea, but I think it's not a good idea to have a big pile of zeros hanging around either. Maybe we should just add a `nograd_zero_` method just for this case, blegh.

[ 1 ]

This is weird and ugly.

[ 1 ]

@dnephin, still looks like an upstream build/ci issue. I give up. @aanand has already indicated the approach is rubbish... so I'll just go use https://github.com/rancher/rancher-compose instead, since they're not running around chasing their tails.

[ 1 ]

actually getfoundarraylength returns harraylength so this is not needed at one point in my change getfoundarraylength returns hinstruction but not anymore

[ 0 ]

i believe we can get rid of missing object by rewriting condition that way if sel fuck not in obj dict

[ 0 ]

just lower of the bulk price they are crappy spears

[ 1 ]

Copilot has fucked me.

[ 1 ]

Oh damn. Thanks for pointing it out. I meant to do 30 minutes, so `1800000`, but somehow messed up there :D

[ 1 ]

bro i actually have no damn idea how i messed that comment up this bad lmao. It must have been like 3am

[ 1 ]