text
stringlengths 1
5.2k
| labels
listlengths 1
1
|
|---|---|
It is a nice idea, a visual indicator telling admins they are invisible. This version is just shit.
|
[
1
] |
can we remove the die here
|
[
0
] |
The farther down the code I go the more OP it appears to be. Reflecting projectiles? What the fuck?
|
[
1
] |
should we kill as well mysqld safe see
|
[
0
] |
okie dokie we should probably note that in reflection docstring pretty sure thats because py x is dumb ha
|
[
0
] |
I'm not going to completely fix the epic shitcode that is the singularity switch statement but I'll move the icon check to its process so it updates dynamically
|
[
1
] |
ah silly cut and paste inheritance here i guess i must be blind to it s
|
[
0
] |
it should be slave
|
[
0
] |
you can create tmpfs up to the size of ram swap however tmpfs check would not pass if creating dib min tmpfs sized tmpfs would be bigger than ram the only thing this does is shrink tmpfs s to be only the size we presume them to need to be with dib min tmpfs
|
[
0
] |
done unfortunately a runloop does not allow multiple run calls which is why having a naked runloop member does not really work here i would like to be able to call waitforresult multiple times on the same testcallback instance this requires wrapping the runloop in either a std unique ptr or base optional to be able to replace it with a new instance
|
[
0
] |
if it is performance critical a single vector will have better cache locality so may be faster i agree pair syntax is ugly both of these arrays are stacks so i would indicate that in the name maybe something like mentrystack and mtypestack
|
[
0
] |
the nop functions are not necessary remove them though on second thought should we turn the amp off on suspend dunno how this is supposed to work
|
[
0
] |
add get info remove setup edge
|
[
0
] |
oh, damn it. brb fixing
|
[
1
] |
more pedantry this docstring makes sense only to people who are ware of the tail f ncs mech driver no need to address definetely not a blocker
|
[
0
] |
iife is malformed should be
|
[
0
] |
why we need this garbage collector will do the same
|
[
0
] |
Damn, reversed the conflict. Thanks @jdurgin
|
[
1
] |
seems cleanup network group method should be removed
|
[
0
] |
Oh, right. Whoops. Will fix.
|
[
1
] |
here is still bug with self cluster should be self cluster name
|
[
0
] |
the temporary assignment of d is pointless self assertequals none b allocate nbd
|
[
0
] |
just a comment no action requested if i was to go crazy which is not in fact in doubt you could also add empty checking here as well and you will find you can kiss strip out a few isempty calls that if around getintfield of course not all of them because an empty field is used to report an error whereas a zero return is not an error
|
[
0
] |
it s an unfortunate side effect of the module member of moduleenv being const i think that member is worth const ing to communicate clearly that consumers of moduleenvs that the wasmmodule is not mutable by them
|
[
0
] |
Holy crap this is awful
|
[
1
] |
damn I don't know why our eslint isn't catching this. I thought I specifically fixed this here https://github.com/getsentry/eslint-config-sentry/pull/117
|
[
1
] |
since jsonutils dumps takes care of invalid input it is better that we construct a raw faulty input here like this req body os update readonly flag readonly true self assertraises webob exc httpbadrequest req get response fakes wsgi app
|
[
0
] |
Craaaap, thanks for reporting it, I'll get to this if nobody beats me to it.
|
[
1
] |
and the naive me thought that there should not be an issue like this if i copy n paste these headers from other files will be corrected in the next version of the patch set
|
[
0
] |
addcleanup should be used instead of teardown
|
[
0
] |
we should probably extract those helpers in the relevant unittest py files
|
[
0
] |
i am slightly concerned that placing two params on the same line violates puppet style did you check this against puppet lint
|
[
0
] |
Ah! \U0001f926 No I got it, because of the match inside the super class. Yes thats totally nonsense.
|
[
1
] |
It was set to AllMask because legacy shitcode. It's still replacing shitcode with new shitcode. PreventCollide can already handle what singulo needs handling so update it.
|
[
1
] |
can we call this current executor since we already have self executor and self executor
|
[
0
] |
nit i think yuv is redundant here max width max height should be enough
|
[
0
] |
the rdo package name for pymysql is python pymysql but there is also a metapackage python pymysql pymysql does not exist
|
[
0
] |
volume type id fake volume type id see line
|
[
0
] |
oh damn `TROOT` inherits from `TDirectory`. my bad.
|
[
1
] |
u to wrapped dict is more appropriate here
|
[
0
] |
drifting code is shit so I wouldnt' force it onto anyone until kevinz00 fixes his shit
|
[
1
] |
why not disable irq and enable irq instead of free irq and request threaded irq
|
[
0
] |
does it apply to openstack neutron aas too
|
[
0
] |
Here is a video demonstrating the core bug. Edit: You'll be better served downloading it; the player kinda sucks. https://user-images.githubusercontent.com/13796683/104795780-d40c3e00-577e-11eb-9d99-39d7bd790031.mp4
|
[
1
] |
modaldialogmanager takes care of dismissing all dialog in destroy so i think we do not need to do anything here
|
[
0
] |
True. Hell, I haven't really thought much about proper packing anyway. That's not something we're ready for yet. :P
|
[
1
] |
this is redundant with mirror throwable dump actually i would change the whole message to os pending exception exception dump
|
[
0
] |
That's a pretty darn good reason!
|
[
1
] |
autospec false is redundant
|
[
0
] |
this change is useless
|
[
0
] |
no cd dest ovn repo name
|
[
0
] |
argument should be trust id trust id
|
[
0
] |
i have got something in the works to blow away this whole params require business just you wait
|
[
0
] |
Please get this fixed. Ridiculous that installing a VS update months ago created this issue and it still isn't resolved 3 updates later. What is going on here? (p.s. this first presented itself in 15.7.1, its now 15.7.4)
|
[
1
] |
put backticks on this one too please
|
[
0
] |
I just realized how fucking pointless this entire file is, it's not actually compiled
|
[
1
] |
i do not know if this should be removed now
|
[
0
] |
done sometimes i dislike pointless docstrings other times i am like meh
|
[
0
] |
The system before this PR was absurd. The system after this PR is less absurd. The PR states that there is an alternative - allowing but giving it severe penalties / gating behind high skills. to the people unhappy with the change. Incremental development works like this, we remove the absurd thing, so that we are left with something not yet perfect, but at least not ridiculous, someone else comes along with a different system thats less absurd than the original one, everbodys happy then. I say this because I intend to develop similar penalties for horseback archery/ranged combat, not disallow it entirely, and would then copy anything that someone has already implemented for bicycle ranged combat in the interim, so it is relatively consistent.
|
[
1
] |
Damn, it's merged already... We'll fix it here https://trello.com/c/fj2rk8NT/205-make-it-easier-to-maintain-the-placeholder-variables
|
[
1
] |
all of these projects are moving from stackforge to openstack the upstream field is poorly named and only needed for the initial import we should probably just remove the upstream fields in this change to prevent confusion
|
[
0
] |
dumb question what is http x service name and when is it used
|
[
0
] |
would help to add logging for adding reagents tbh but w/e if you dont im not going to throw a bitchfit lol.
|
[
1
] |
the idea is to keep as much code executing all the time as possible you are right that i could indent the entire block so it is under the if dedupe queue at the top of this finally block but i was trying to avoid that
|
[
0
] |
Double ternary is pretty cursed.
|
[
1
] |
nit revert this white space change
|
[
0
] |
Is there a difference between `mIsGoingDown` (hell, is that even used at the moment) and `mIsClosingDown`? If the former is not used perhaps it can be :recycle: (recycled) for this?
|
[
1
] |
and this check is useless since you do get start none in the next line
|
[
0
] |
and this also why it's so damn long to encrypt/decrypt key in Blockframes ^^
|
[
1
] |
done
|
[
0
] |
you re right i will get rid of it
|
[
0
] |
i did not know you could share the ipc namespace like this pretty cool
|
[
0
] |
Part of me feels like using `INITIALIZATION_INSSATOMS` here is gonna bite me and future coders in the butt in the future
|
[
1
] |
afaict using mux lock without defining mux gpio is incorrect and potentially useless
|
[
0
] |
similar to above can we use kwargs instead of pylint disable
|
[
0
] |
useless since they are already default values you can drop the params i guess
|
[
0
] |
yeah i think we can and should use these stl aids deymo do you have an objection
|
[
0
] |
it may be a stupid question but could not those debug prints be better managed as log lines at debug level
|
[
0
] |
let s have a comment about one of them is for the header and the other is for the body complete a write of headers complete a write of the body
|
[
0
] |
should now be test commit fsync
|
[
0
] |
insecure is probably the wrong name to use here insecure in tls is used to denote the fact host verification is turned off not that tls is turned off
|
[
0
] |
Oh right, the log confused me. Looks like you have multiple entries for JoJo's Bizarre Adventure (2012) in your DB. Can you upload your main.db to https://send.firefox.com and send me the link? So I can verify what's going on.
|
[
1
] |
sean a post jogo world is not a world i want to live in
|
[
0
] |
i am wondering if there is not a cleaner way to do this i am very much abusing jsonutils here
|
[
0
] |
this is entirely stupid but if one subclassed this and passed in additional apis you would be overwriting them here i am not gonna worry about it
|
[
0
] |
you can mock imagecache in the setup and have mock get cached image self vmops imagecache get cached image mock get cached image return value mock sentinel cached iso path
|
[
0
] |
should we just get rid of the brackets or are they actually useful
|
[
0
] |
why do not you use here openstack common importutils
|
[
0
] |
i want a false and true to show bool default flag true false mask bool default true bool default false would that do
|
[
0
] |
roger i was being very dumb i went and talked with bsimmonet and then ate all my words back burp
|
[
0
] |
The year is 2020 and yet you still fucked this up xd https://github.com/nullworks/cathook/blob/5b9af83d910e93ab95475059edce55b0a786ed93/src/PlayerTools.cpp#L42 is what you're looking for
|
[
1
] |
damn was sure I had removed it
|
[
1
] |
why are you typecasting this as living, when it's only ever `/mob/living/carbon/human` it leads to stuff like below.
|
[
1
] |
fcopy could fuck up here in case there's already some custom config_file matching this name already on the server, and BYOND could fail to overwrite it. Use `rustg_file_write()` instead.
|
[
1
] |
could we just eliminate this entirely by checking the volume object obtained from above if volume attach status attached or similar i hate to see us add a parameter like this where we can avoid it especially since we already have the do check attach method which is kind of similar anyways
|
[
0
] |
use neutron segment types and cluster net providers from consts py
|
[
0
] |
Damn, thats great news! I'm very interested in reading and commenting on it. @anjali411 please let me know when it is available (not sure if there is a way on github to track/read about new blog posts)
|
[
1
] |
This is absolutely ridiculous! Why can't you change the class of this element?!!! By what logic??
|
[
1
] |
This is ridiculous, how the tests passed on Windows, but failed on MacOS and Linux?
|
[
1
] |
these params should be nudged to the right a single space
|
[
0
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.