added
stringdate 2025-04-01 04:05:38
2025-04-01 07:14:06
| created
timestamp[us]date 2001-10-09 16:19:16
2025-01-01 03:51:31
| id
stringlengths 4
10
| metadata
dict | source
stringclasses 2
values | text
stringlengths 0
1.61M
|
|---|---|---|---|---|---|
2025-04-01T04:35:18.977444
| 2023-03-09T11:04:48
|
1616972991
|
{
"authors": [
"Memotech-Bill",
"kilograham"
],
"license": "BSD-3-Clause",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10165",
"repo": "raspberrypi/pico-extras",
"url": "https://github.com/raspberrypi/pico-extras/issues/60"
}
|
gharchive/issue
|
scanvideo.c claims fixed resources
scanvideo.c makes claims for fixed hardware resources, specifically PIO0, low numbered DMA channels and low numbered state machines. However these may have already been claimed for other services.
Ideally the code should be modified to use the claim_unused routines.
If that is not possible, at least used fixed high number DMA channels and state machines, which would be the last resources to be claimed by the claim_unused routines.
yeah, dynamic claiming would be a bit of a change, but we should at least allow the user to override all the #defines
|
2025-04-01T04:35:18.979103
| 2022-05-10T17:58:23
|
1231504277
|
{
"authors": [
"kilograham"
],
"license": "BSD-3-Clause",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10166",
"repo": "raspberrypi/pico-sdk",
"url": "https://github.com/raspberrypi/pico-sdk/pull/819"
}
|
gharchive/pull-request
|
Suppress false GCC 11 warning on TinyUSB
Note this should be undone when fixed in upstream TinyUSB
fixes #780
Note this will leave (non-fatal) warnings in pico-examples, as that uses the TinyUSB CMake build directly (TinyUSB will need to be fixed for those).
Users of our suppress_tinyusb_warnings CMake function however will build cleanly.
|
2025-04-01T04:35:18.991073
| 2022-10-18T14:22:09
|
1413319783
|
{
"authors": [
"uskrusader"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10168",
"repo": "raspibolt/raspibolt",
"url": "https://github.com/raspibolt/raspibolt/issues/1129"
}
|
gharchive/issue
|
Balance of Satoshis bonus guide problem
I'm stuck at the beginning of the BoS bonus guide.
as "admin" I can receive Alex Bosworth's keys to verify.
as "bos", it doesnt work.
No keyserver with user "bos" ?
simple problem?
weird, it fixed itself a few hours later with a second attempt.
?!
|
2025-04-01T04:35:18.999007
| 2023-11-13T08:07:01
|
1990087872
|
{
"authors": [
"blckbx",
"kristapsk"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10169",
"repo": "raspibolt/raspibolt",
"url": "https://github.com/raspibolt/raspibolt/pull/1374"
}
|
gharchive/pull-request
|
[UPDATE BONUS GUIDE] Circuitbreaker w/ webinterface
What
In this PR we update circuitbreaker to its latest version and configure the new webinterface on port 4005.
Why
Easier configuration and nicer overview of in-flight htlcs.
How
Following instructions from https://github.com/lightningequipment/circuitbreaker
Scope
[ ] significant change to core configuration
[x] updated independent bonus guide
[ ] simple bug fix
I see that CircuitBreaker has release tags, most recent is https://github.com/lightningequipment/circuitbreaker/releases/tag/v0.5.0. Any reason to use master instead of latest release?
I see that CircuitBreaker has release tags, most recent is https://github.com/lightningequipment/circuitbreaker/releases/tag/v0.5.0. Any reason to use master instead of latest release?
Nope. Pushed updates:
added tag
added pgp key import and verification of current tag
removed unnecessary go build command (go install is sufficient)
For some reason it looks installation fails for me... Any ideas?
$ go install
...
go: downloading github.com/remyoudompheng/bigfft v0.0.0-20200410134404-eec4a21b6bb0
# runtime/internal/sys
/usr/local/go/src/runtime/internal/sys/consts.go:13:7: StackGuardMultiplier redeclared in this block
/usr/local/go/src/runtime/internal/sys/arch.go:27:7: other declaration of StackGuardMultiplier
/usr/local/go/src/runtime/internal/sys/consts.go:16:7: DefaultPhysPageSize redeclared in this block
/usr/local/go/src/runtime/internal/sys/arch.go:36:7: other declaration of DefaultPhysPageSize
/usr/local/go/src/runtime/internal/sys/consts.go:20:7: PCQuantum redeclared in this block
/usr/local/go/src/runtime/internal/sys/arch.go:40:7: other declaration of PCQuantum
/usr/local/go/src/runtime/internal/sys/consts.go:23:7: Int64Align redeclared in this block
/usr/local/go/src/runtime/internal/sys/arch.go:43:7: other declaration of Int64Align
/usr/local/go/src/runtime/internal/sys/consts.go:30:7: MinFrameSize redeclared in this block
/usr/local/go/src/runtime/internal/sys/arch.go:50:7: other declaration of MinFrameSize
/usr/local/go/src/runtime/internal/sys/consts.go:34:7: StackAlign redeclared in this block
/usr/local/go/src/runtime/internal/sys/arch.go:54:7: other declaration of StackAlign
$ circuitbreaker
-bash: circuitbreaker: command not found
$ ls /home/circuitbreaker/go/bin/
ls: cannot access '/home/circuitbreaker/go/bin/': No such file or directory
$ go version
go version go1.19.3 linux/arm64
For some reason it looks installation fails for me... Any ideas?
Yeah this looks like it's not compiled successfully.
For comparison, my go version is go1.21.4 linux/amd64
For some reason it looks installation fails for me... Any ideas?
$ go install
...
go: downloading github.com/remyoudompheng/bigfft v0.0.0-20200410134404-eec4a21b6bb0
# runtime/internal/sys
/usr/local/go/src/runtime/internal/sys/consts.go:13:7: StackGuardMultiplier redeclared in this block
/usr/local/go/src/runtime/internal/sys/arch.go:27:7: other declaration of StackGuardMultiplier
/usr/local/go/src/runtime/internal/sys/consts.go:16:7: DefaultPhysPageSize redeclared in this block
/usr/local/go/src/runtime/internal/sys/arch.go:36:7: other declaration of DefaultPhysPageSize
/usr/local/go/src/runtime/internal/sys/consts.go:20:7: PCQuantum redeclared in this block
/usr/local/go/src/runtime/internal/sys/arch.go:40:7: other declaration of PCQuantum
/usr/local/go/src/runtime/internal/sys/consts.go:23:7: Int64Align redeclared in this block
/usr/local/go/src/runtime/internal/sys/arch.go:43:7: other declaration of Int64Align
/usr/local/go/src/runtime/internal/sys/consts.go:30:7: MinFrameSize redeclared in this block
/usr/local/go/src/runtime/internal/sys/arch.go:50:7: other declaration of MinFrameSize
/usr/local/go/src/runtime/internal/sys/consts.go:34:7: StackAlign redeclared in this block
/usr/local/go/src/runtime/internal/sys/arch.go:54:7: other declaration of StackAlign
$ circuitbreaker
-bash: circuitbreaker: command not found
$ ls /home/circuitbreaker/go/bin/
ls: cannot access '/home/circuitbreaker/go/bin/': No such file or directory
$ go version
go version go1.19.3 linux/arm64
Tried apt update and apt upgrade and fetching latest circuitbreaker, still having the same issue.
But if others report no problems with installation, I'm ok with merging this.
|
2025-04-01T04:35:19.036853
| 2021-03-15T02:20:29
|
831348860
|
{
"authors": [
"corndog2000"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10170",
"repo": "ratibor78/srvstatus",
"url": "https://github.com/ratibor78/srvstatus/issues/12"
}
|
gharchive/issue
|
How to setup telegraf?
Hello, I am new Telegraf and I'm a little confused with how I'm supposed to setup it up. Do I need to make a new influx database? When setting up the Grafana dashboard it asks me to choose an influx database. What do I do with the last piece of code in the readme?
Ok, I was able to piece it together using this website to help with installation. https://bist.be/2021/01/29/how-to-install-telegraf-and-raspberry-pi-dashboard-in-grafana/
|
2025-04-01T04:35:19.041137
| 2016-08-25T21:16:47
|
173312244
|
{
"authors": [
"OliverGrimsley",
"ratiw",
"westwick"
],
"license": "mit",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10171",
"repo": "ratiw/vue-table",
"url": "https://github.com/ratiw/vue-table/issues/75"
}
|
gharchive/issue
|
how to use templates properly?
I'm trying to format a cell and nothing is working. The documentation seems to be a little vague here. I think I need to use the templates key on the options, right? It seems nothing I put in there causes any change on the table. I used the example right out of the docs but it's not working. Is there another example of how to do this somewhere?
Here is some of the relevant code:
<v-client-table :data="payments" :columns="columns" v-ref:table v-if="!loading"></v-client-table>
var options = {
compileTemplates: true,
templates: {
edit: "<a href={id}><i class='fa fa-edit'></i></a>"
}
}
then on the $vm:
data () {
return {
payments: '',
columns: ['created_at', 'amount'],
}
}
I have tried changing the templates key from edit to amount, thinking it would override the value in the amount column. I've also tried adding 'edit' to the columns array in the data. Seems neither one has any effect. Am I doing it wrong?
In the vue component file, I had to delete everything in the tags and then do all my CSS in the regular css file. This is also a suggestion, to remove all style from the vue component. Because it gets loaded after the css, it controls and cannot be overridden. (In mine the table was way too big, way too much space, the actions aligned vertically in small grid areas etc)
hmm don't see what the css should have to do with anything. just trying to change the html using templates. I've tried for instance just creating a new key in the templates object, with the same name as one of my existing keys (thinking it would override it), or with a different name and adding that new name to the columns array. seems like the 2 most logical ways it would work based on the docs, but neither way works.
btw all I'm simply trying to do is use the {{ var | currency }} formatter in one of my cells, if anyone has any examples of that :)
wow just realized i'm on the wrong package x_x ... vue-table not vue-tables. ahh well maybe I will have to try your package if I can't get this other one working
@westwick No problem. Got that all the time. :)
|
2025-04-01T04:35:19.045714
| 2018-10-08T15:19:04
|
367839272
|
{
"authors": [
"Ronen-dev",
"jony89",
"willmeet"
],
"license": "mit",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10172",
"repo": "ratson/cordova-plugin-admob-free",
"url": "https://github.com/ratson/cordova-plugin-admob-free/issues/290"
}
|
gharchive/issue
|
Interstitial always fails to load
Here is the code I'm using to prepare the interstitial ad :
_showInterstitial() {
let interstitialConfig: AdMobFreeInterstitialConfig = {
isTesting: true,
autoShow: false,
// id: 'ca-app-pub-xxx'
};
this.adMobFree.interstitial.config(interstitialConfig);
this.adMobFree.interstitial.prepare().then(p => {
console.log('Intertistial prepared.');
console.log(p);
}).catch(e => console.log(e));
}
At this point, the interstitial is correctly prepared.
Then, two listener are setted to check if the ad correctly loaded, and another one if it failed :
// Listen when the Interstitial is loaded
this.admobLoad = this.adMobFree.on(this.adMobFree.events.INTERSTITIAL_LOAD).subscribe(() => {
console.log('Event interstitial loaded.');
this.adMobFree.interstitial.show().then(() => {
// Show successful
}).catch((errorShow) => {
console.log(errorShow);
});
this.admobLoad.unsubscribe();
});
// Listen when the Interstitial has failed to load
this.admobFail = this.adMobFree.on(this.adMobFree.events.INTERSTITIAL_LOAD_FAIL).subscribe(res => {
console.log('Interstitial load fail.');
console.log(res);
this.admobFail.unsubscribe();
});
In my case, it always failed. Here is the response from the listener :
Event {
adType: "interstitial"
bubbles: false
cancelBubble: false
cancelable: false
composed: false
currentTarget: null
defaultPrevented: false
error: 0
eventPhase: 0
isTrusted: false
path: (2) [document, Window]
reason: "Internal error"
returnValue: true
srcElement: document
target: document
timeStamp: 66483.19999995874
type: "admob.interstitial.events.LOAD_FAIL"
}
Thanks for your help.
@ratson
same as #184
In my case, ads are not showing even in test mode
So you probably have some other issue. I've reinstalled all from scratch and test is working without any issue.
This is my code :
window.admob.interstitial.config({
id: INTERSTITIAL_AD_ID,
});
// Create banner
await window.admob.interstitial.prepare();
document.addEventListener('admob.interstitial.events.LOAD', () => {
window.admob.interstitial.show();
});
That issue is clearly shown here how to solve admob failed to load ads
|
2025-04-01T04:35:19.105387
| 2020-04-17T03:00:53
|
601667171
|
{
"authors": [
"gcv",
"raxod502"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10173",
"repo": "raxod502/selectrum",
"url": "https://github.com/raxod502/selectrum/issues/52"
}
|
gharchive/issue
|
Support // and ~/ shortcuts in selectrum-read-file-name
find-file in vanilla Emacs has a neat feature, where typing // causes Emacs to ignore all input before the second slash (or really the last slash if several are typed). Also, everything before ~ is ignored. This allows really fast navigation outside the current working directory, either to home or somewhere near the root, and efficient entry of Tramp commands, since it means the command can be typed without erasing the current entry.
Details: https://www.gnu.org/software/emacs/manual/html_node/emacs/Minibuffer-File.html
It'd be cool for Selectrum to support this feature.
This is solved by #50.
Yup, I tried the unmerged branch. Looks good!
Super-cool to see how quickly Selectrum is improving. Nice work.
|
2025-04-01T04:35:19.111366
| 2022-08-31T22:58:28
|
1358004870
|
{
"authors": [
"Jeffwan"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10174",
"repo": "ray-project/kuberay",
"url": "https://github.com/ray-project/kuberay/issues/515"
}
|
gharchive/issue
|
[Bug] The README.md is not well-formatted
Search before asking
[X] I searched the issues and found no similar issues.
KubeRay Component
Others
What happened + What you expected to happen
Reproduction script
It's on the webpage and no need to reproduce.
Anything else
No response
Are you willing to submit a PR?
[ ] Yes I am willing to submit a PR!
/cc @Basasuya If you are interested in this issue, you can pick it up
|
2025-04-01T04:35:19.114551
| 2022-07-05T21:49:23
|
1294811449
|
{
"authors": [
"Jeffwan",
"pingsutw"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10175",
"repo": "ray-project/kuberay",
"url": "https://github.com/ray-project/kuberay/pull/340"
}
|
gharchive/pull-request
|
Update ray-operator version in the apiserver
Signed-off-by: Kevin Su<EMAIL_ADDRESS>Why are these changes needed?
Update ray-operator version in the apiserver, so we're able to import it from other repos. Otherwise, we'll get the below error.
go<EMAIL_ADDRESS>reading github.com/ray-project/kuberay/proto/proto/go.mod at revision proto/v0.0.0: unknown revision proto/v0.0.0
Related issue number
Checks
[ ] I've made sure the tests are passing.
Testing Strategy
[ ] Unit tests
[x] Manual tests
[ ] This PR is not tested :(
Sounds reasonable. Ideally, we should export the apis and client-go separately. This can be done later if we have other usages.
Thank you @Jeffwan
|
2025-04-01T04:35:19.231066
| 2024-12-03T13:15:32
|
2715007380
|
{
"authors": [
"robertshawjmark",
"thomaslombart"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10176",
"repo": "raycast/extensions",
"url": "https://github.com/raycast/extensions/issues/15667"
}
|
gharchive/issue
|
[Todoist] Allow a user to schedule a task for a specified duration
Extension
https://www.raycast.com/doist/todoist
Description
First of all, thank you for this great extension; it has significantly improved my workflow.
Currently, when creating a new task, the following fields are available:
Title
Description
Due date
Priority
Project
Labels
File
Parent Task
Users cannot specify how long they want to schedule the task.
Additionally, when editing a task, the following fields can be modified:
Title
Description
Users are unable to edit the due date or duration of the task after it has been created.
This limitation is inconvenient because users must either make these changes through the Todoist app or recreate the task with the updated fields.
Who will benefit from this feature?
All users
Anything else?
No response
The duration field appears only when you've selected a date with time, so it's already possible to do so π
|
2025-04-01T04:35:19.233647
| 2023-03-08T07:21:58
|
1614776396
|
{
"authors": [
"kynkos2",
"pernielsentikaer"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10177",
"repo": "raycast/extensions",
"url": "https://github.com/raycast/extensions/issues/5215"
}
|
gharchive/issue
|
[ChatGPT3 Prompt] ...
Extension
https://www.raycast.com/denizyoldas/chatgpt3-prompt
Description
Error:
Steps To Reproduce
No response
Current Behaviour
No response
Expected Behaviour
No response
Please open a new issue or fill the report π
|
2025-04-01T04:35:19.241173
| 2022-01-07T19:22:27
|
1096602022
|
{
"authors": [
"HenriChabrand",
"Ua01"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10178",
"repo": "raycast/extensions",
"url": "https://github.com/raycast/extensions/issues/629"
}
|
gharchive/issue
|
[Notion Extension Bug]
Extension β Notion
Author: @HenriChabrand
Description
The "create database" feature isn't working as intended, while the search function is. It keeps reporting an error
This
Raycast Error code.txt
π
Steps To Reproduce
Setup the extension by following the provided extension instructions
Attempt to use the "Create Database Page" Command
The current behavior
It shows the attached error
The expected behavior
It should open a menu to create a database pg in notion, as advertised
Raycast version
Version: latest - 1.26.3
Hello @Ua01 π
This issue has been identified and the fix is currently pending for review π
https://github.com/raycast/extensions/pull/617
Thank you for reporting this issue πͺ
That's great, looking forward to word on a fix βΊοΈ
It should have been fix β could you confirm? @Ua01
It should have been fix β could you confirm? @Ua01
There's no change on my end, it's still showing the same error unfortunately.
Hello @Ua01
Could you send over the error again?
Because in the detail of the error normally something has changed
Raycast error code 2.txt
Hi @HenriChabrand
No worries, here is the new error code. Hope it helps.
Hi @HenriChabrand
The issue seems to have been fixed, Thanks for all your help. βΊοΈ
|
2025-04-01T04:35:19.243692
| 2023-10-03T14:09:55
|
1924238226
|
{
"authors": [
"CyberDuck79",
"davidmatthewcoleman"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10179",
"repo": "raycast/extensions",
"url": "https://github.com/raycast/extensions/issues/8658"
}
|
gharchive/issue
|
[1Password] 2 Factor Authentication
Extension
https://www.raycast.com/khasbilegt/1password
Description
The extension should have the option to copy the 2FA code.
Who will benefit from this feature?
Anyone using 2FA.
Anything else?
No response
+1, this missing feature is the only reason I do not use the extension and still use the 1password prompt.
|
2025-04-01T04:35:19.248921
| 2023-10-24T11:10:50
|
1959018382
|
{
"authors": [
"lucymhdavies",
"thomaslombart"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10180",
"repo": "raycast/extensions",
"url": "https://github.com/raycast/extensions/issues/8930"
}
|
gharchive/issue
|
[Apple Reminders Beta] Menu Bar Reminders fails to fetch latest data
Extension
https://raycast.com/raycast/reminders
Description
Error:
Error: ENOENT: no such file or directory, chmod '/Users/strawb/.config/raycast/extensions/112ad714-bf10-4ccc-a70f-4232bb2241a5/assets/compiled_raycast_swift/reminders'
Steps To Reproduce
I configured access to reminders, and ran the "Menu Bar Reminders" command
Current Behaviour
The menu part part does not work, instead showing the error seen above.
In my case, the directory above does exist:
$ ls -lah /Users/strawb/.config/raycast/extensions/112ad714-bf10-4ccc-a70f-4232bb2241a5/assets/compiled_raycast_swift
total 0
drwxr-xr-x@ 2 strawb staff 64B 20 Oct 12:53 .
drwxr-xr-x@ 5 strawb staff 160B 20 Oct 12:53 ..
If I create the file it's complaining about...
$ touch /Users/strawb/.config/raycast/extensions/112ad714-bf10-4ccc-a70f-4232bb2241a5/assets/compiled_raycast_swift/reminders
then I get a different error
Error: spawn Unknown system error -8
at ChildProcess.spawn (node:internal/child_process:414:11)
at spawn (node:child_process:761:9)
at /Users/strawb/.config/raycast/extensions/112ad714-bf10-4ccc-a70f-4232bb2241a5/menu-bar.js:31:2719
at new Promise (<anonymous>)
at Object.FX (/Users/strawb/.config/raycast/extensions/112ad714-bf10-4ccc-a70f-4232bb2241a5/menu-bar.js:31:2561)
at async sw (/Users/strawb/.config/raycast/extensions/112ad714-bf10-4ccc-a70f-4232bb2241a5/menu-bar.js:31:3443)
Expected Behaviour
I have Reminders configured, and things like "My Reminders" works fine.
That's a curious one. This looks like a bug that should fail for all commands. Are you sure you didn't confuse the My Reminders command with the native extension?
Otherwise, do you have any kind of antivirus on your Mac? That could explain what's happening here.
Oh, fun times. This is one of those bugs which... after a bunch of restarts since I first noticed the issue, it's working fine now. Love those kind of bugs π
It was definitely the My Reminders command and the Menu Bar Reminders command.
If it happens again next time I reboot the laptop... is there a good place for me to gather some more error logs?
And if it doesn't happen again next time I reboot... I'm fine to just close this off for now.
Ah, that's frustrating π
But it's good to know that it's working out. If it happens again, feel free to reopen the issue and provide some more logs here.
|
2025-04-01T04:35:19.253619
| 2021-12-18T07:37:11
|
1083771597
|
{
"authors": [
"fe9lix",
"mattisssa",
"pernielsentikaer",
"sestanley13"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10181",
"repo": "raycast/extensions",
"url": "https://github.com/raycast/extensions/pull/546"
}
|
gharchive/pull-request
|
Add optional preference FORM_FIELDS
Description
Type of change
Improvement for somebody else's extension. Extension author: @honzatmn
Screencast
Checklist
[x] I read the extension guidelines
[x] I read the documentation about publishing
@honzatmn Would you mind also reviewing those changes?
@sestanley13 could you look into the suggestion above?
Hi @sestanley13 β are you able to look into the suggestions made by @honzatmn, so we can get this PR closed?
Hey @sestanley13! What is the status of this PR? It seems like it's been here for a long time unfinished. Shall we probably close this one and once you're ready β open another PR?
|
2025-04-01T04:35:19.262169
| 2023-01-15T05:13:34
|
1533660696
|
{
"authors": [
"ImazighenGhost",
"JeffM2501",
"raysan5"
],
"license": "Zlib",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10182",
"repo": "raysan5/raylib",
"url": "https://github.com/raysan5/raylib/issues/2859"
}
|
gharchive/issue
|
[core] Screen size origin issues, framebuffer offseted on Y axis from window
If you create a window with a height that is larger than the available size on them monitor then the origin of the OpenGL context is offset by this difference.
A simple way to duplicate this is the following code (run on a 1080p display)
#include "raylib.h"
void main()
{
InitWindow(2000, 1065, "test");
SetTargetFPS(144);
while (!WindowShouldClose())
{
Vector2 mousePos = GetMousePosition();
BeginDrawing();
ClearBackground(DARKGRAY);
DrawRectangle(200, 0, 100, 5, RED);
DrawRectangle(200, 5, 100, 5, BLUE);
DrawFPS(0, 0);
EndDrawing();
}
CloseWindow();
}
You can see that the FPS counter is cut in half and the RED bar is not visible.
I'm not sure what is going on, but should raylib be even creating a window that is larger that the monitor?
This has been duplicated in windows Visual Studio 2022 with C.
I do not think this is a major issue, mostly I just wanted to get the steps for reproduction stored in an issue.
Seems to work fine for me, what platform are you in?
This has happened on multiple Windows installs. I do believe it will be OS specific, possibly GLFW related.
Also of note, I don't think it's driver related, as one report is on an intel chipset and I can duplicate it on an nvidia card.
@JeffM2501 Wow! What an issue! Really weird... I tried with 1065 and it worked ok for me but I could reproduce it using 1080.
It seems related to OS and the way window is created... it seems the framebuffer is offseted to fit in the window to fit in the display... quite weird behaviour...
Yes it's very strange. I think the 1065 is due to the taskbar on windows (windows 11).
It may be a GLFW bug too and there is nothing we can do about it, I just don't know enough about how raylib creates the context to dig deeper.
Note that this is not blocking anything or causing any real problems. The one bit of code that had this issue (RPG example ) now has code to prevent creating a window that is too big.
I just don't know enough about how raylib creates the context to dig deeper.
Actually most of that work is not related to raylib but GLFW and the driver. raylib just calls glfwCreateWindow() with the framebuffer size to request it and afaik, no glfwWindowHint() has an influence on the window, only on the OpenGL capabilities.
Just reviewed it again, actually some glfwWindowHint() have an influence on the window (borderless, top-most, mouse pass-through...) but I can't see anything related to the issue.
@JeffM2501 I debugged this issue and it took me to the Win32 system call AdjustWindowRectEx(), from User32.lib Windows system library. The returned rectangle computes negative top-left corner values for provided inputs.
Call stack:
InitWindow(int width, int height, const char * title)
InitGraphicsDevice(int width, int height)
glfwCreateWindow(int width, int height, const char * title, GLFWmonitor * monitor, GLFWwindow * share)
_glfwCreateWindowWin32(_GLFWwindow * window, const _GLFWwndconfig * wndconfig, const _GLFWctxconfig * ctxconfig, const _GLFWfbconfig * fbconfig)
createNativeWindow(_GLFWwindow * window, const _GLFWwndconfig * wndconfig, const _GLFWfbconfig * fbconfig)
AdjustWindowRectEx(&rect, style, FALSE, exStyle);
I'm afraid this issue is out-of-scope of raylib, probably even out-of-scope for GLFW. I'm closing it.
Feel free to reopen it if required.
|
2025-04-01T04:35:19.324782
| 2024-10-29T16:16:50
|
2621744772
|
{
"authors": [
"MuskanSaxena6",
"rcallaby"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10183",
"repo": "rcallaby/Learn-Git",
"url": "https://github.com/rcallaby/Learn-Git/pull/764"
}
|
gharchive/pull-request
|
Translate lesson 03 into turkish
#732
Translate Lesson 03 into Turkish
Added 'BΓΆlΓΌm-03-Dallanma-ve-BirleΕtirme' directory inside 'tu'
Created 'dallanma ve birleΕtirme.md
Are you aware you can link your pull request to an open issue by using closing keywords?
https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue
|
2025-04-01T04:35:19.331523
| 2021-12-04T02:00:04
|
1071093192
|
{
"authors": [
"rcarriga",
"resolritter"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10184",
"repo": "rcarriga/nvim-notify",
"url": "https://github.com/rcarriga/nvim-notify/issues/40"
}
|
gharchive/issue
|
Allow for on_close callback during setup
On require("notify").setup, the user can provide an on_open callback for when windows are opened. This is a request to also allow for on_close.
Without the on_close callback, the user is forced to do manual bookkeeping on the windows, like so
windows = {}
require("notify").setup({
on_open = function(window)
table.insert(windows, window)
end
})
on_window_closed = function(window)
-- do something here if the window is one of the windows being tracked
end
vim.cmd [[ autocmd WinClosed * call v:lua.on_window_closed(expand("<afile>")) ]]
Not only suboptimal, it's also potentially unreliable since the nvim_win_close calls in the current code are wrapped in pcall, so there might be case where the autocommand is not fired for some reason (e.g. the window did not exist anymore).
Please try latest commit :smile:
Thanks for the feature!
I was expecting on_close to be called in the places where nvim_win_close is called, such as
https://github.com/rcarriga/nvim-notify/blob/ee79a5e2f8bde0ebdf99880a98d1312da83a3caa/lua/notify/service/init.lua#L58
And also
https://github.com/rcarriga/nvim-notify/blob/ee79a5e2f8bde0ebdf99880a98d1312da83a3caa/lua/notify/windows/init.lua#L114
Even more so because the on_open counterpart is called after nvim_win_open
https://github.com/rcarriga/nvim-notify/blob/280a08ca5d005b1f504fbc4906db69c23f109ccc/lua/notify/stages/util.lua#L48-L51
https://github.com/rcarriga/nvim-notify/blob/ee79a5e2f8bde0ebdf99880a98d1312da83a3caa/lua/notify/windows/init.lua#L55-L60
I might be missing something but it seems like https://github.com/rcarriga/nvim-notify/commit/ef027e34b618eac42fb0111c1db670ba01793039 will not be effective for what I am thinking of
During every frame of the animation loop there is a check for if the window is still open, if not then the WindowAnimator:remove_win function is called.
https://github.com/rcarriga/nvim-notify/blob/master/lua/notify/windows/init.lua#L148
This function is also called at the end of the window lifecycle. Therefore it will handle both the window closing normally as well as if another action closes it.
If you find otherwise then please let me know but I see no issue for what you need
I'll try it out!
Thanks for the explanation and the plugin as well.
|
2025-04-01T04:35:19.334065
| 2016-12-08T00:00:32
|
194210170
|
{
"authors": [
"alextricity25",
"rackernexus"
],
"license": "apache-2.0",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10185",
"repo": "rcbops/rpc-openstack",
"url": "https://github.com/rcbops/rpc-openstack/pull/1613"
}
|
gharchive/pull-request
|
Remote remote and filebeat checks
The maas team has asked us to run our maas plugins with
half the checks to debug some issues we are having
with our maas account. This commit disables remote and
filebeat checks, which constitues about half our checks.
Connects https://github.com/rcbops/u-suk-dev/issues/809
HULK PREVIEW
Your content preview is now ready. :bow:
|
2025-04-01T04:35:19.336276
| 2015-08-19T15:13:35
|
101917189
|
{
"authors": [
"Apsu",
"d34dh0r53",
"nrb"
],
"license": "apache-2.0",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10186",
"repo": "rcbops/rpc-openstack",
"url": "https://github.com/rcbops/rpc-openstack/pull/353"
}
|
gharchive/pull-request
|
Clean up MaaS and local scripts for Flake8 (kilo backport)
Fix all reported hacking errors
Addresses #240
Addresses #272
(cherry picked from commit e00db31c320e22627282c384eca6acd2d600040c)
A couple of nits but otherwise looks good, I'll give this a +1 and ignore my nits if this is time sensitive.
@d34dh0r53 While I agree with you, this is also a backport, so I'm hesitant to make the change in this PR. We can file a clean up issue for renaming the clients, though.
:+1:
:+1:
|
2025-04-01T04:35:19.390199
| 2024-07-31T18:57:47
|
2440717942
|
{
"authors": [
"piehld"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10187",
"repo": "rcsb/rcsb-mojave-model",
"url": "https://github.com/rcsb/rcsb-mojave-model/pull/10"
}
|
gharchive/pull-request
|
RO-4209: Update polymer instance features with ligand interaction enumerations
RO-4209
Hi @valasatava, now that I'm back from vacation, wanted to ask if you have a chance to look at this?
Thanks @valasatava! Is it OK to merge now, or should I wait until after the current weekly update completes tomorrow?
|
2025-04-01T04:35:19.413061
| 2016-08-05T22:19:16
|
169707109
|
{
"authors": [
"pathawks",
"rdanbrook"
],
"license": "bsd-3-clause",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10188",
"repo": "rdanbrook/cirugia",
"url": "https://github.com/rdanbrook/cirugia/issues/1"
}
|
gharchive/issue
|
Use bit field instead of bitwise operations
How do you feel about turning romheader into a bit field instead of using all the bitwise operations? This would make the code easier to read, and give the compiler a bit more freedom in optimizing the bitwise arithmetic.
Instead of
return romheader[6] & 0x04 ? 1 : 0;
this would allow us to instead write
return romheader.trainer;
I wouldn't mind working on a PR if this is something you are open to, but I wanted to check first as this would impact a lot of code.
Thanks for taking interest in this project.
The only concern I have with this really, is that it might cause headaches dealing with different versions of the header (iNES vs NES 2.0). I don't really find it hard to read, of course I wrote it so it came from my twisted brain in the first place.
One day (maybe soon when I take a vacation) I'll add tile import/export, and there will be a lot of restructuring done. I may restructure some of this header code as well at that time.
The only concern I have with this really, is that it might cause headaches dealing with different versions of the header (iNES vs NES 2.0).
I think it is ok because almost everything new in NES 2.0 should just be zeroed out in iNES.
Here is some rough sketching of what I had in mind, just for posterity. union this with romheader and Rock & Roll.
struct {
unsigned int magic_number : 32; // Bytes 0-3
unsigned int prom_size_low : 8; // Byte 4
unsigned int crom_size_low : 8; // Byte 5
unsigned int mirroring : 1; // Byte 6
unsigned int battery : 1;
unsigned int trainer : 1;
unsigned int four_screen_mode : 1;
unsigned int map_low : 4;
unsigned int sys : 2; // Byte 7
unsigned int version : 2;
unsigned int map_mid : 4;
unsigned int submapper : 4; // Byte 8
unsigned int map_high: 4;
unsigned int crom_size_high : 4;// Byte 9
unsigned int prom_size_high : 4;
unsigned int pram_battery : 4; // Byte 10
unsigned int pram_no_battery : 4;
unsigned int cram_battery : 4; // Byte 11
unsigned int cram_no_battery : 4;
unsigned int tvsystem : 2; // Byte 12
unsigned int : 6;
unsigned int vsmode : 4; // Byte 13
unsigned int vsppu : 4;
unsigned int reserved : 16; // Bytes 14-15
};
Closing this for now, but let me know if there is something I can do to help in the future :+1:
|
2025-04-01T04:35:19.429910
| 2021-11-01T16:18:50
|
1041351183
|
{
"authors": [
"erikhaandrikman",
"krackjack234"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10189",
"repo": "rdkcentral/Lightning-SDK",
"url": "https://github.com/rdkcentral/Lightning-SDK/issues/277"
}
|
gharchive/issue
|
Porting custom video player in Lightning SDK
Hi,
Is there anyway we can port a custom video player in Lightning SDK and use/augment the standard Videplayer apis (https://rdkcentral.github.io/Lightning-SDK/#/plugins/videoplayer)?
We want to add a custom player to enhance current Videoplayer capabilities like playing drm and ads and collecting custom metrics information.
Please let us know if this is achievable.
hi, anyone has any pointers about this?
This is highly achievable; The VideoPlayer plugin is nothing more then a bit of abstraction for the HTMLVideoElement https://github.com/rdkcentral/Lightning-SDK/blob/6d239403a40c4f53ea1054ebd79124e712102ea1/src/MediaPlayer/index.js#L94
If your app needs more advanced functionality like DRM protected content we highly encourage you to build (or port) your own player and where needed use VideoPlayer methods: https://rdkcentral.github.io/Lightning-SDK/#/plugins/videoplayer?id=available-methods
|
2025-04-01T04:35:19.435326
| 2021-12-29T06:54:51
|
1090309765
|
{
"authors": [
"bjornvanspengen",
"googleboy0"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10190",
"repo": "rdkcentral/Lightning-SDK",
"url": "https://github.com/rdkcentral/Lightning-SDK/issues/289"
}
|
gharchive/issue
|
Purchase Plug-in How we can use?
I am working on an app, where I need an in-app purchase. So, that users can buy the content. we have the csp URL that gives me the asset id and all. but after that what i need to do, or can someone has an example of Purchase Plug-in. it would be very helpful for us.
Thank you
@googleboy0 this is not very well documented. Sorry for that.
There are two ways of doing this.
Implement using configuration and using the buy function. see https://lightningjs.io/docs/#/lightning-sdk-reference/plugins/purchase?id=setup and https://lightningjs.io/docs/#/lightning-sdk-reference/plugins/purchase?id=buy
Implement the important parts manually.
CSP generates a secure payment object by signing the package with a SHA256-HMAC (secret can be generated on the Metrological dashboard)
Send signed payment object to Metrological billing server via payment function. See https://lightningjs.io/docs/#/lightning-sdk-reference/plugins/purchase?id=payment
Metrological billing server responds with a signed receipt. (If approved)
App updates the CSP of the purchase
App confirms the Metrological billing server that transaction has been completed using the confirm function. See https://lightningjs.io/docs/#/lightning-sdk-reference/plugins/purchase?id=confirm
If you need any further assistance or documentation of the payment object spec you can reach out to me directly<EMAIL_ADDRESS>
|
2025-04-01T04:35:19.437831
| 2020-07-28T14:47:54
|
667135229
|
{
"authors": [
"MFransen69",
"pwielders",
"svdmaar"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10191",
"repo": "rdkcentral/rdkservices",
"url": "https://github.com/rdkcentral/rdkservices/pull/150"
}
|
gharchive/pull-request
|
METROL-103: Updates WebKitBrowser
Copies over work on WebKitBrowser from ThunderNanoServices.
@emutavchi I think we now need to make sure all functionality gets together. Your pull request needs to be merged first than we need to "add" that functionality, in your pull request, to this pull request. As discussed I am expecting than that we can move the interface definitions into the interfaces directory of Thunder again (these definitions are used by the DIALServer and our private ProvisioingPlugin). The latter does not have a dependency on this repository, only on Thunder (interfaces) and we want to keep the dependecy graph as simple as possible.
After your merge request is merged, Sander or I will pick up the changes you did in your pull request and solve the issue I just raised here for revisiting the WebKitBrowser (https://github.com/rdkcentral/rdkservices/issues/175).
So please reach out if you are going to change anything beyond the pull request that is currently pending.
This PR is outdated, a new one was created in the mean time
|
2025-04-01T04:35:19.445092
| 2020-07-08T20:10:18
|
653564696
|
{
"authors": [
"greglandrum",
"jcminerlanl"
],
"license": "BSD-3-Clause",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10192",
"repo": "rdkit/rdkit",
"url": "https://github.com/rdkit/rdkit/issues/3280"
}
|
gharchive/issue
|
Missing some Boost libraries and unable to download maeparser.
I am trying to install RDKit version 2020 in order to have access to the necessary 3D descriptors that are not in earlier version.
I created a git clone of the rdkit package and ran the following commands.
cmake -DPy_ENABLE_SHARED=1 -DRDK_INSTALL_INTREE=ON -DRDK_INSTALL_STATIC_LIBS=OFF -DRDK_BUILD_CPP_TESTS=ON -DPYTHON_NUMPY_INCLUDE_PATH="$(python -c 'import numpy ; print(numpy.get_include())')" -DBOOST_ROOT="$CONDA_PREFIX" ..
-- Found Catch2 source in /home/jcminer/anaconda3/rdkit/External/catch/catch
CATCH: /home/jcminer/anaconda3/rdkit/External/catch/catch/single_include/catch2
PYTHON Py_ENABLE_SHARED: 1
PYTHON USING LINK LINE: -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro
-- Boost version: 1.63.0
-- Found the following Boost libraries:
-- serialization
== Using strict rotor definition
CMake Error at /home/jcminer/anaconda3/envs/p4dev/share/cmake-3.14/Modules/FindBoost.cmake:2132 (message):
Unable to find the requested Boost libraries.
Boost version: 1.63.0
Boost include path: /home/jcminer/anaconda3/envs/my-rdkit2020-env/include
Could not find the following Boost libraries:
boost_iostreams
Some (but not all) of the required Boost libraries were found. You may
need to install these additional Boost libraries. Alternatively, set
BOOST_LIBRARYDIR to the directory containing Boost libraries or BOOST_ROOT
to the location of Boost.
Call Stack (most recent call first):
External/CoordGen/CMakeLists.txt:13 (find_package)
-- maeparser include dir set as 'maeparser_INCLUDE_DIRS-NOTFOUND'
-- maeparser libraries set as 'maeparser_LIBRARIES-NOTFOUND'
-- Could NOT find maeparser (missing: maeparser_INCLUDE_DIRS maeparser_LIBRARIES)
Downloading https://github.com/schrodinger/maeparser/archive/v1.2.3.tar.gz...
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0curl: (35) error:1408F10B:SSL routines:ssl3_get_record:wrong version number
CMake Error at Code/cmake/Modules/RDKitUtils.cmake:213 (MESSAGE):
The md5 checksum for
/home/jcminer/anaconda3/rdkit/External/CoordGen/maeparser-v1.2.3.tar.gz is
incorrect; expected: 4ead02a0bf87110d1caae79ab42a5747, found:
d41d8cd98f00b204e9800998ecf8427e
Call Stack (most recent call first):
External/CoordGen/CMakeLists.txt:42 (downloadAndCheckMD5)
-- Configuring incomplete, errors occurred!
See also "/home/jcminer/anaconda3/rdkit/build/CMakeFiles/CMakeOutput.log".
See also "/home/jcminer/anaconda3/rdkit/build/CMakeFiles/CMakeError.log".
It appears that I am missing certain boost libraries, but beyond that it does not appear that I can download the appropriate maeparser.
Can anyone help correct this?
The resulting outputs are included in this message.
CMakeError.log
CMakeOutput.log
the maeparser problem is likely an intermittent one and it may be worth just trying again.
Which version of the RDKit are you trying to build?
Which boost packages do you have conda installed (and is there any particular reason you're using 1.63, which is pretty old)?
Do the boost libraries have to be installed with conda, or can they be installed with sudo?
I believe I was trying to build the version adf19f7. It was the version I pulled 2 days ago (~16:00 UTC).
You can definitely install the boost libraries yourself but it's important to be sure that they are built with the same python distribution that you are going to use later.
It's often easier to just use the conda (or conda-forge) boost installs.
I have done the conda boost installs, but the error now is 'catch':
rdkit/build$ cmake -DPy_ENABLE_SHARED=1 -DRDK_INSTALL_INTREE=ON -DRDK_INSTALL_STATIC_LIBS=OFF -DRDK_BUILD_CPP_TESTS=ON -DPYTHON_NUMPY_INCLUDE_PATHS="$(python -c 'import numpy ; print(numpy.get_include())')" -DBOOST_ROOT="$CONDA_PREFIX" ..
-- Catch not found in /home/jcminer/rdkit2020/rdkit/External/catch/catch
Downloading https://github.com/catchorg/Catch2/archive/v2.12.1.tar.gz...
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
curl: (35) error:1408F10B:SSL routines:ssl3_get_record:wrong version number
CMake Error at Code/cmake/Modules/RDKitUtils.cmake:213 (MESSAGE):
The md5 checksum for
/home/jcminer/rdkit2020/rdkit/External/catch/v2.12.1.tar.gz is incorrect;
expected: 05c1b743773e546db9cb65b3b9315b02, found:
d41d8cd98f00b204e9800998ecf8427e
Call Stack (most recent call first):
External/catch/CMakeLists.txt:16 (downloadAndCheckMD5)
-- Configuring incomplete, errors occurred!
See also "/home/jcminer/rdkit2020/rdkit/build/CMakeFiles/CMakeOutput.log".
CMakeOutput.log
@jcminerlanl that could be either a proxy problem or something intermittent.
If you try to run cmake again and have the same problem you can solve this by downloading the archive https://github.com/catchorg/Catch2/archive/v2.12.1.tar.gz manually, extracting it in $RDBASE/External/catch and then renaming the directory Catch2-2.12.1 to catch
|
2025-04-01T04:35:19.448988
| 2020-10-21T10:21:13
|
726344601
|
{
"authors": [
"NadineSchneider",
"bp-kelley"
],
"license": "BSD-3-Clause",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10193",
"repo": "rdkit/rdkit",
"url": "https://github.com/rdkit/rdkit/pull/3516"
}
|
gharchive/pull-request
|
[Contrib] Initial commit NIBR 2019 substructure filters
This implements a revised set of 444 SMARTS substructure filters to annotate, flag and exclude compounds. These filters were revised and developed in the course of the NIBR screening deck re-design. More details on this work can be found in a recent publication: Schuffenhauer, A. et al. Evolution of Novartis' small molecule screening deck design, J. Med. Chem. (2020), DOI. https://dx.doi.org/10.1021/acs.jmedchem.0c01332
Many thanks for the feedback @greglandrum!
It would be nice if we could integrate them into the Contrib for now (we added that link to the paper :)) and add them in addition at some point in the C++ FilterCatalog. What do you think?
@NadineSchneider @greglandrum Once they are merged I can add them to the filter catalog along with pat Walters collections as well.
This is great work!
Hi @bp-kelley , thanks for the feedback! We actually had a look at Pat's collection and included most of them in our review. Please let me know when you have more questions or need help.
|
2025-04-01T04:35:19.476623
| 2022-10-12T09:35:01
|
1405890007
|
{
"authors": [
"enjeeneer",
"rdnfn"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10194",
"repo": "rdnfn/bauwerk",
"url": "https://github.com/rdnfn/bauwerk/issues/17"
}
|
gharchive/issue
|
Float64 dtype incompatibility
bauwerk version: 0.21
Python version: 3.8
Operating System: macOS
Description
Bauwerk will throw an error when you pass an action array of dtype np.float64. I believe this is because you hardcode the env.action_space to be float32 dtype.
What I Did
action = np.array([0.16], dtype=np.float64)
obs, reward, _, _ = env.step(action)
---------------------------------------------------------------------------
AssertionError Traceback (most recent call last)
Input In [37], in <cell line: 1>()
----> 1 mean_reward, model_actions = rollout_with_prompt(model=model, env=env, eval_steps=24*30)
Input In [36], in rollout_with_prompt(model, env, eval_steps)
34 tokens, obs_mask, act_mask = tokenizer.update_sequences(tokens, obs_mask, act_mask, out_seq[:, -1], action=True)
37 action = np.array([0.16], dtype=np.float64)
---> 38 obs, reward, _, _ = env.step(action)
40 obs_tokens = tokenizer.tokenize(obs)
42 print(obs_tokens)
File ~/phd/research/elizabeth-homes/exp/enjeeneer/rl-exp2/utils/utils.py:14, in ObsWrapper.step(self, action)
13 def step(self, action):
---> 14 obs_dict, reward, done, info = self.env.step(action)
16 # modify obs
17 vals = []
File ~/miniforge3/envs/odes/lib/python3.8/site-packages/gym/wrappers/order_enforcing.py:11, in OrderEnforcing.step(self, action)
9 def step(self, action):
10 assert self._has_reset, "Cannot call env.step() before calling reset()"
---> 11 observation, reward, done, info = self.env.step(action)
12 return observation, reward, done, info
File ~/miniforge3/envs/odes/lib/python3.8/site-packages/bauwerk/utils/gym.py:48, in make_old_gym_api_compatible.<locals>.GymCompatEnv.step(self, action)
46 """Run one timestep of the environment's dynamics."""
47 if not GYM_NEW_STEP_API_ACTIVE:
---> 48 obs, reward, terminated, truncated, info = super().step(action)
49 done = terminated or truncated
50 return obs, reward, done, info
File ~/miniforge3/envs/odes/lib/python3.8/site-packages/bauwerk/envs/solar_battery_house.py:234, in SolarBatteryHouseCoreEnv.step(self, action)
216 def step(self, action: object) -> Tuple[object, float, bool, dict]:
217 """Run one timestep of the environment's dynamics.
218
219 When end of episode is reached, you are responsible for calling `reset()`
(...)
232 (helpful for debugging, and sometimes learning)
233 """
--> 234 assert self.action_space.contains(action), f"{action} ({type(action)}) invalid"
236 info = {}
238 action = float(action) # getting the float value
AssertionError: [0.16] (<class 'numpy.ndarray'>) invalid
Good point, there is no strong reason why the dtype should be restricted as it was. I have fixed it now (see 4e7cdf576369f8b6f782d334c3853dcb09646678) and it will be added to the next version.
Thanks for raising this!
|
2025-04-01T04:35:19.478511
| 2018-09-29T09:03:43
|
365113903
|
{
"authors": [
"rduldulao"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10195",
"repo": "rduldulao/tornado-swirl",
"url": "https://github.com/rduldulao/tornado-swirl/issues/1"
}
|
gharchive/issue
|
Support for Schema Properties
Add support for schema properties such as minimum:, maximum:, as well as example:
Schema properties can be specified in the docstrings
|
2025-04-01T04:35:19.480284
| 2019-02-07T14:24:27
|
407724495
|
{
"authors": [
"rduldulao",
"roman-telepathy-ai"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10196",
"repo": "rduldulao/tornado-swirl",
"url": "https://github.com/rduldulao/tornado-swirl/issues/15"
}
|
gharchive/issue
|
websockets docs
hi,
are there any activities to document websockets?
thx, r
Hi @roman-telepathy-ai . Sorry for the late reply. No activities re: websockets at the moment, will try to scope it out if it can be added for our next release. If you could provide a description of your requirements, that would be great. Thanks.
@rduldulao no worries, I describe them as kind of REST at the moment. WS docs is complicated topic.
thx!
|
2025-04-01T04:35:19.541959
| 2018-07-06T03:39:22
|
338794621
|
{
"authors": [
"aleixhub",
"danbopes",
"gretzky",
"julienben",
"michaelcuneo",
"nonotest"
],
"license": "mit",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10197",
"repo": "react-boilerplate/react-boilerplate",
"url": "https://github.com/react-boilerplate/react-boilerplate/issues/2269"
}
|
gharchive/issue
|
offline-plugin should install chunks as part of update process
Issue Type
[X] Bug
Description
When adding main chunks to additional assets in OfflinePlugin as below (webpack.prod.babel.js) it causes website to not load at all if the webserver is unavailable upon service worker activation. Additionally, even if the webserver is restarted, it will take another service worker download, closing the tab, and restarting it, for the website to load again.
caches: {
main: [':rest:'],
// All chunks marked as `additional`, loaded after main section
// and do not prevent SW to install. Change to `optional` if
// do not want them to be preloaded at all (cached only when first loaded)
additional: ['*.chunk.js'],
},
Steps to reproduce
git clone https://github.com/react-boilerplate/react-boilerplate.git
cd react-boilerplate
npm i && npm run build && npm run start:prod
Navigate to: http://localhost:3000 in chrome. (Verify service worker is installed on Application tab in devtools)
Stop the webserver, and build another update:
npm run build && npm run start:prod
Refresh http://localhost:3000. Service worker/application tab should now show, another one waiting to install:
Kill the webserver again, and close the http://localhost:3000 tab. Reopen http://localhost:3000 tab, website wont load (Just shows a white page). Because the chunks are not available at the time of the service worker initial load, the website just displays a white page. Rebuilding the site, will cause different chunks built, and this service worker will never load again. Only upon another installation (Which will require both the user to navigate to the page, trigger an update, and then close all website tabs, and reopen again.) will the site load again. Simple F5 refreshes will not work and restart the worker.
Hey @danbopes,
Thanks for reporting this. Is it an issue that arises only in react-boilerplate though or something that would happen on any project using offline-plugin? If it's the latter, please report it directly to that project.
Cheers,
Julien
This is due to the fact of the default react-boilerplate config requiring the chunks as additional assets, not downloading them until the service worker restarts.
I'm not sure I understand exactly but would this be fixed by updating the offline-plugin config?
From [the options], maybe a mix of caches: 'all' and responseStrategy: 'cache-first'?
Either way, we might be moving to sw-precache-webpack-plugin in a future update. Take a look at #2257.
I've been curious about it's status as well, developing a project in a large office situation, where I often go to peoples desk to demonstrate the latest version... the latest version is usually a mix of old caches and new caches, with no feedback on which is which... typically I have to hammer CACHE CLEAR, install various extensions to peoples browsers, and/or tell them to just keep hitting refresh until all chunks are the very latest version of the app. I know it won't be a huge concern later when I release a bug fix once every few weeks... (Hopefully)... but for now it's horrible.
Hello, I also have the white page issue.
Even using this branch: https://github.com/react-boilerplate/react-boilerplate/pull/2257 with unregistered
For some reason the browser keeps requesting the older version of the bundle which doesnβt exist anymore on the server
Usually go to a different url fixed it but not too sure what to do ..
Ok got this now.
I have the same issue in my apps. The best solution I could find (short of removing offline plugin) is described in this article.
All the links I use in my apps now look like this:
function UpdateLink({ children, className, to, ariaLabel }) {
return (
<Link
to={to}
className={className}
aria-label={ariaLabel}
onClick={e => {
if (e.metaKey || e.ctrlKey) return;
e.preventDefault();
if (window.swUpdate) window.location = to;
else history.push(to);
}}
>
{children}
</Link>
);
}
I even created an eslint rule to avoid accidentally using Link from react-router-dom.
I'll close this for now as @gretzky has a PR which replaces offline-plugin with something else. :)
(I just want to add that, since implementing this, I've almost never seen this issue again.)
If you have 2 tabs of the website open, that component will do nothing other than slow down the experience to users as all links will now cause full page loads, as no update will be triggered.
Additionally, this doesn't solve the problem (It may just mask the issue because clients gets updated faster). This issue shouldn't be closed until the PR gets officially merged in.
If you have 2 tabs of the website open, that component will do nothing other than slow down the experience to users as all links will now cause full page loads, as no update will be triggered.
This is an edge case and still not entirely true because, when you set autoUpdate to true, it checks for updates to the service worker only once every hour. Different story if you set it to once every minute though...
Additionally, this doesn't solve the problem (It may just mask the issue because clients gets updated faster). This issue shouldn't be closed until the PR gets officially merged in.
Not sure I follow your meaning but ok I'll reopen.
I did find this series on Medium:
Service Workers Break the Browserβs Refresh Button by Default; Hereβs Why
How to Fix the Refresh Button When Using Service Workers
The first article explains the issue while the second offers some solutions. They each have their upsides and downsides (I like the second one personally).
Either way, I wish this could be fixed in a simpler way even if with a small performance cost. For example, we could use: responseStrategy: 'network-first'? Would that work?
(@mxstbr I see you recently updated the offline-plugin options documentation. If you have any advice as to the best course of action here, we would be very interested to hear it.)
this issue might be related to offline-plugin itself, see the docs https://github.com/NekR/offline-plugin/blob/master/docs/updates.md if you have one tab opened and you hit the refresh it will downloads the new SW but won't activate until cmd+R.
@aleixhub is correct. Refer to their answer if this comes up again.
The steps described in the docs link provided by @aleixhub are also present in this article I linked to earlier in the thread. The difference is that, when a SW update is ready, one solution automatically reloads the page while the other triggers a reload on link click. I'm not confident that either of these solutions is complete or perfect though.
|
2025-04-01T04:35:19.565753
| 2021-01-12T16:16:15
|
784380189
|
{
"authors": [
"doteric",
"jfbahamondes"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10198",
"repo": "react-dnd/react-dnd",
"url": "https://github.com/react-dnd/react-dnd/issues/2964"
}
|
gharchive/issue
|
[FIXME] Dragging item on a drop layer that is over the item and will appear on dragging
Describe the bug
If we create a droppable layer that appears when dragging an element type, if the layer is over the drag item, we cannot actually drag the item. But, if it happens to not be overlapping the draggable item, there is no bug.
Reproduction
Create drop layer that is visible over the drag item when dragging.
bug link
This is the link with a patch fix.
patch fix
Steps to reproduce the behavior:
try to move the horse on the board (sandbox links)
Expected behavior
Big square overlapping the whole app should appear when dragging the horse.
Observed behavior
Cannot drag the horse
Desktop (please complete the following information):
OS: MacOs Catalina
Browser Chrome
Version 87.0.4280.88 (Official Build) (x86_64)
Additional context
This issue only happens when using HTML5 backend. It does not happen when using Touch backend. It is fixed when deferring the 'canDrop' variable from the monitor.
[VIDEO OF THE BUG AND PATCH FIX]
https://user-images.githubusercontent.com/17971547/104341367-7bb41280-54d8-11eb-8fcf-8b696899be07.mp4
+1
Even when doing some CSS styling so that the drop source is present only after the dragging starts (is marked as started by the monitor, but doesn't actually really start or just ends instantly) still prevents the element from being draggable for some reason. This ONLY seems to happen on the HTML5 backend. For example this case works fine on the touch backend.
|
2025-04-01T04:35:19.572006
| 2017-09-23T18:34:23
|
260029567
|
{
"authors": [
"heyimalex",
"ndbroadbent"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10199",
"repo": "react-dnd/react-dnd",
"url": "https://github.com/react-dnd/react-dnd/issues/890"
}
|
gharchive/issue
|
Ref is always called twice on the DropTargetConnector element (null, then the element)
Example code:
@DropTarget(dragTypes, target, connect => ({
connectDropTarget: connect.dropTarget(),
}))
export default class TestComponent extends PureComponent {
constructor(props) {
super(props)
this.setContainerRef = (ref) => {
console.log("setting container ref", ref)
this.container = ref
}
}
render() {
const { connectDropTarget } = this.props
return connectDropTarget(
<div ref={this.setContainerRef} />
)
}
}
Whenever the component is re-rendered, setContainerRef is called twice:
setting container ref, null
setting container ref, <div ... >
I just realized that this is explained in the DropTargetConnector docs:
Internally it works by attaching a callback ref to the React element you give it.
I'm assuming that it wraps the existing ref I passed, and returns a new function each time.
I know refs are ugly, but in this case I really need to calculate the scrollTop of that div
in a different component. My code is breaking because ref gets set to null during the state change, so I can't calculate the scroll.
It would be awesome if connectDropTarget could do some memoization for the ref callback (like what I'm doing in the constructor.) That would solve my issue.
(As a workaround, I know that the element is never going to be null, so I'll just ignore null for now.)
You can do it yourself, as connectDropTarget is really just a ref callback.
this.setContainerRef = (ref) => {
console.log("setting container ref", ref)
this.container = ref
this.props.connectDropTarget(ref);
}
Oh that's a great point, thanks!
On 21 Oct 2017, 12:27 AM +0700, Alex Guerra<EMAIL_ADDRESS>wrote:
You can do it yourself, as connectDropTarget is really just a ref callback.
this.setContainerRef = (ref) => {
console.log("setting container ref", ref)
this.container = ref
this.props.connectDropTarget(ref);
}
β
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
2025-04-01T04:35:19.611301
| 2017-01-12T15:02:59
|
200389691
|
{
"authors": [
"Jero786",
"MaxBuodnik",
"STRML",
"Zelenetska",
"antfenech",
"dmitriyK1",
"kumarharsh",
"matronator",
"snax4a",
"vladislavprokopenko",
"xtforgame"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10200",
"repo": "react-grid-layout/react-grid-layout",
"url": "https://github.com/react-grid-layout/react-grid-layout/issues/458"
}
|
gharchive/issue
|
Setting custom props to the Grid Item object
There is no ability to set custom props to the Grid Item object.
For example:
{i: 'somekey', w: 2, h:5, contentLink: 'http://google.com'}
Property 'contentLink' will be deleted after changing layout.
Thanks!
would love this feature, or to know how others are getting around this to set tile type.
+1
It would be convenient if the Grid Item object provide a data or customData property
+1 In the old versions, this feature was enabled :(
+1
My use case is that I'd like to restrict the sizing of different components on the grid depending upon the type of the component. I imagined that in the onResize callback, I'd be able to use the type property of each layout item to decide which layouts are possible (1x1, 2x2, not 3x1, etc).
@STRML is there a way to do this? Going through the library, I see that the cloneLayoutItem function discards any props not needed by it. Maybe we can allow a custom data prop on each layout entry to be cloned too, for consumption in the userland?
+1
I also need this feature
Would be useful to have it, because in my case ids of items of different types are not unique and I need to guarantee their uniqueness by storing some custom identifier in a custom property and also this will allow to map grid items to specific data models
I also need this. I need to store it in database each grid item need to have a type attribute so i can render it as different component when loading a layout
+1
I also need this feature
Wow, okay, so now we're closing unresolved issues automatically, just because they're ignored?
@matronator This is how we've been doing it for years. If you want to make a PR go for it. This is a volunteer project.
|
2025-04-01T04:35:19.633573
| 2023-12-31T20:09:32
|
2061158899
|
{
"authors": [
"JolianGof",
"chanthinh"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10201",
"repo": "react-hook-form/resolvers",
"url": "https://github.com/react-hook-form/resolvers/issues/657"
}
|
gharchive/issue
|
Issue with valibotResolver causing unexpected form submission behavior
I am using react-hook-form with valibotResolver to validate my form data. I have noticed an issue where only the lastName field is included in the form data when the form is submitted, even though I have firstName and age fields in my form.
Link to CodeSandbox Project: https://codesandbox.io/p/devbox/fkzp9q?file=%2Fmyapp%2Fvite-project%2Fsrc%2FApp.tsx%3A1%2C1-79%2C1
this is my code import React from "react";
import { useForm, Controller } from "react-hook-form";
import { valibotResolver } from "@hookform/resolvers/valibot";
import {
coerce,
maxLength,
maxValue,
minLength,
minValue,
number,
object,
Output,
safeInteger,
string,
} from "valibot";
// import { formSchema } from './schema';
export const formSchema = object({
lastName: string([
minLength(1, "This field is required."),
maxLength(5, "Please enter within 2 characters."),
]),
});
const App = () => {
const { handleSubmit, control, formState } = useForm({
mode: "onChange",
defaultValues: {
lastName: "fds",
firstName: "sdf",
age: "2",
},
resolver: valibotResolver(formSchema),
});
const handleOnSubmit = handleSubmit((formType) => {
alert(JSON.stringify(formType));
});
console.log("errors", formState.errors);
return (
Last Name
<Controller
name="lastName"
control={control}
render={({ field }) => <input {...field} />}
/>
{formState.errors?.lastName?.message?.toString() || ""}
<label>First Name</label>
<Controller
name="firstName"
control={control}
render={({ field }) => <input {...field} />}
/>
<span>{formState.errors?.firstName?.message?.toString() || ""}</span>
<label>Age</label>
<Controller
name="age"
control={control}
render={({ field }) => <input type="text" {...field} />}
/>
<span>{formState.errors?.age?.message?.toString() || ""}</span>
<button
type="submit"
disabled={!formState.isDirty || !formState.isValid}
>
execute
</button>
</form>
</div>
);
};
export default App;
And here's the output I get when I submit the form:
{
"lastName": "fds"
}
Hi @JolianGof,
Your form should be
ruby <form onSubmit={handleSubmit(handleOnSubmit)}>
And your handleOnSubmit should be
const handleOnSubmit = (formType) => {
alert(JSON.stringify(formType));
};
Hi @JolianGof,
You are missing firstName and age in your schema, add these to your schema and try again
export const formSchema = object({
lastName: string([
minLength(1, "This field is required."),
maxLength(5, "Please enter within 2 characters."),
]),
firstName: string(),
age: string()
});
Hi,
Thank you for the response. I understand that the valibotResolver requires all fields in the form to be defined in the validation schema. However, in my case, I have a large form and I only want to validate some of the fields.
For instance, if I have a form with fields firstName, lastName, age, and many others, and I only want to validate firstName and age, how would I go about doing that?
Should I include all fields in the schema and provide simple validation rules like string() or number() for the fields I don't want to validate? Or is there a better way to handle this scenario?
Thank you for your guidance.
@JolianGof,
I understand what you want, so you can try to use yupResolver
Check this one: https://codesandbox.io/p/sandbox/react-hook-form-yup-resolver-forked-4k44jg?file=%2Fsrc%2FcolorScheme.js%3A11%2C4
|
2025-04-01T04:35:19.643211
| 2019-03-16T18:48:09
|
421839985
|
{
"authors": [
"pvinis",
"thymikee"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10202",
"repo": "react-native-community/react-native-cli",
"url": "https://github.com/react-native-community/react-native-cli/pull/242"
}
|
gharchive/pull-request
|
test with pvinis repo with the two-dot diff
Summary:
This is in preparation of using the new branch structure of the purge repo, using one branch per version.
GitHub does not support getting a patch file from two-dot diffs by appending .diff in the url, so I keep them in https://github.com/pvinis/rn-diff-purge/tree/master/diffs.
Test Plan:
We just test it by upgrading a project.
@pvinis what's the status of adding diffs/ dir to https://github.com/react-native-community/rn-diff-purge?
planned for today :)
I came back from holidays yesterday evening and I'm just leaving the office.
Done. We now have the old list in old/master, that has the tags like version/x.y.z, and the new table in master, with all the diffs in the diffs branch, and purge-web pointing to rnc.
I'll close this issue since everything is in sync now, and we store the diffs ourselves.
|
2025-04-01T04:35:19.651832
| 2018-03-10T20:21:49
|
304101582
|
{
"authors": [
"AliRawash",
"biancaFarcas",
"icemancast",
"joshuamataaraya",
"piloulac",
"rborn",
"tierfour",
"tyjing",
"ujwal-setlur"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10203",
"repo": "react-native-community/react-native-maps",
"url": "https://github.com/react-native-community/react-native-maps/issues/2080"
}
|
gharchive/issue
|
CocoaPods could not find compatible versions for pod "GoogleMaps"
Is this a bug report?
Yes
Have you read the Installation Instructions?
Yes
Environment
react-native: ^0.51.0
react: ^16.2.0
react-native-maps: ^0.20.1
Target Platform: eg: iOS - 10.2 Simulator
Steps to Reproduce
I followed the steps for installation in the link. When I reach the part to execute the command pod install I get the following error:
[!] CocoaPods could not find compatible versions for pod "GoogleMaps":
In Podfile:
GoogleMaps
react-native-google-maps (from `../node_modules/react-native-maps`) was resolved to 0.20.1, which depends on
GoogleMaps (= 2.5.0)
Specs satisfying the `GoogleMaps, GoogleMaps (= 2.5.0)` dependency were found, but they required a higher minimum deployment target.
Note: Support for Xcode 7.3 has been dropped. The new minimum is Xcode 8.0. -> https://developers.google.com/maps/documentation/ios-sdk/releases
In other words your xcode project needs to have the target >=8.0
You might wanna try to uncomment this podfile line
# platform :ios, '9.0'
Same here,
using XCode 9.02and when uncommenting platform :ios, '9.0' it gives the same result :/
Try using the latest code from github. In you package.json:
"react-native-maps": "github:react-community/react-native-maps"
still the same issue
i had the same issue but running pod update fixed the problem.
Closing, see https://github.com/react-community/react-native-maps/issues/2080#issuecomment-374192549
I also had to define a global platform constant (uncomment platform line)
# platform :ios, '9.0'
github:react-community/react-native-maps
is there any issue if i using github:react-community/react-native-maps for react-native-maps versioning? issue like once the code is updated, my current running app will not working/functioning well?
@tyjing yes, if you point to master any change done to the repo will reflect in your code if you run npm install
An idea would be to point to a specific commit
"dependencies": {
"package": "git://github.com/username/package.git#commit"
}
or fork the repo and point to your fork (of course keeping in in sync with the master only when you are sure you can update safely)
Confirmed @biancaFarcas solution to pod update worked for me as well.
pod update still not worked for me.
cocoaPods couldn't find compitable versions for pod "GoogleMaps":
in podfile: GoogleMaps
|
2025-04-01T04:35:19.683035
| 2018-06-18T00:22:34
|
333104950
|
{
"authors": [
"EnclaveAnthony",
"KPS250",
"LionelLindt",
"ahaus",
"farhanaslam5151",
"gaganjot-singh01",
"iSaadSalman",
"jgcmarins",
"kkbhav",
"msaqlain",
"prajnarobo",
"shreyakupadhyay",
"tarbundiyahitesh21",
"tktdw"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10204",
"repo": "react-native-community/react-native-share",
"url": "https://github.com/react-native-community/react-native-share/issues/280"
}
|
gharchive/issue
|
Image Sharing for WhatsApp is not working
So I'm saving a screenshot locally and passing the URI to Share options. Its working fine for every platform except Whats App.
`let shareOptions = {
title: "Share",
url: this.state.cameraRollUri,
type: 'image/png',
message: "Here it is",
subject: "Share Link", // for email,
};
Share.open(shareOptions)`
Just message appears but no image
@iSaadSalman application is crashing?
Do you have a stack trace?
No itβs not crashing. Just the image is not being shared in WhatsApp. Check the description I wrote in op.
Is it happening on both platforms?
@jgcmarins Just testing on iOS right now. It's happening there.
@jgcmarins Do you have any idea what could be the problem?
Same problem
@iSaadSalman can you try master?
@jgcmarins I tried by overwriting the module in node_modules since I'm not able to update via npm.
I'm receiving this build error in Xcode:
Undefined symbols for architecture arm64: "_OBJC_CLASS_$_InstagramShare", referenced from: objc-class-ref in libRNShare.a(RNShare.o) ld: symbol(s) not found for architecture arm64 clang: error: linker command failed with exit code 1 (use -v to see invocation)
@jgcmarins any update?
@iSaadSalman I could not take a deeper look.
But if you want to help us, PRs are welcome.
@jgcmarins I tried by overwriting the module in node_modules since I'm not able to update via npm.
I'm receiving this build error in Xcode:
Undefined symbols for architecture arm64: "OBJC_CLASS$_InstagramShare", referenced from: objc-class-ref in libRNShare.a(RNShare.o) ld: symbol(s) not found for architecture arm64 clang: error: linker command failed with exit code 1 (use -v to see invocation)
Your link is wrong here.
I recommend to remove all node_modules, install lib again, following README and also link again.
@iSaadSalman can you please check after removing 'message' from options, if it is working or not. Whatsapp only allows one of them to be used, i.e. you can only use message or url at a time for whatsapp.
@kkbhav sorry for the very late reply. Yeah you are right if I remove the message image shows up
Is this a bug or what? Can we close this one?
@iSaadSalman what do you think? README must be updated?
@jgcmarins Well if the message overwriting URL is enforced, this but has been resolved
@jgcmarins If you can, maybe add a readme note about this so people know
The problem with message override still exists. Url does not work if I add a message field. Tested with version 1.1.3.
The issue is only on iOS. For Android it works well. Any update on this?
share image on WA work on my Device, and shareOption like this
let shareOptions = {
title: "",
url: this.state.cameraRollUri,
message: "",
subject: "", // for email,
}
then i add code
} else if ([options[@"url"] <EMAIL_ADDRESS>!= NSNotFound || [options[@"url"] <EMAIL_ADDRESS>!= NSNotFound || [options[@"url"] <EMAIL_ADDRESS>!= NSNotFound) {
NSLog(@"Sending whatsapp image");
documentInteractionController = [UIDocumentInteractionController interactionControllerWithURL:[NSURL fileURLWithPath:options[@"url"]]];
documentInteractionController.UTI = @"net.whatsapp.image";
documentInteractionController.delegate = self;
[documentInteractionController presentOpenInMenuFromRect:CGRectMake(0, 0, 0, 0) inView:[[[[[UIApplication sharedApplication] delegate] window] rootViewController] view] animated:YES];
NSLog(@"Done whatsapp image");
successCallback(@[]);
on file WhatsAppShare.m line 49
if ([options[@"url"] <EMAIL_ADDRESS>!= NSNotFound || [options[@"url"] <EMAIL_ADDRESS>!= NSNotFound) {
.....
successCallback(@[]);
// add code here
} else {
text = (NSString*)CFBridgingRelease(CFURLCreateStringByAddingPercentEscapes(NULL,(CFStringRef) text, NULL,CFSTR("!*'();:@&=+$,/?%#[]"),kCFStringEncodingUTF8));
......
}
}
url property will not work on android, try this
onSharePress = (image) => Share.share({
title: 'Pk Flyer offer',
message: 'your message here '+image,
url: Platform.OS === 'ios' ? image : '' //this will work only on android
subject: 'Offer'
});
url property will not work on android, try this
onSharePress = (image) => Share.share({
title: 'Pk Flyer offer',
message: 'your message here '+image,
url: Platform.OS === 'ios' ? image :"" //this will work only on ios
subject: 'Offer'
});
Share.share is a method from React Share, and not from this library, here it is open.
share image on WA work on my Device, and shareOption like this
let shareOptions = {
title: "",
url: this.state.cameraRollUri,
message: "",
subject: "", // for email,
}
then i add code
} else if ([options[@"url"] <EMAIL_ADDRESS>!= NSNotFound || [options[@"url"] <EMAIL_ADDRESS>!= NSNotFound || [options[@"url"] <EMAIL_ADDRESS>!= NSNotFound) {
NSLog(@"Sending whatsapp image");
documentInteractionController = [UIDocumentInteractionController interactionControllerWithURL:[NSURL fileURLWithPath:options[@"url"]]];
documentInteractionController.UTI = @"net.whatsapp.image";
documentInteractionController.delegate = self;
[documentInteractionController presentOpenInMenuFromRect:CGRectMake(0, 0, 0, 0) inView:[[[[[UIApplication sharedApplication] delegate] window] rootViewController] view] animated:YES];
NSLog(@"Done whatsapp image");
successCallback(@[]);
on file WhatsAppShare.m line 49
if ([options[@"url"] <EMAIL_ADDRESS>!= NSNotFound || [options[@"url"] <EMAIL_ADDRESS>!= NSNotFound) {
.....
successCallback(@[]);
// add code here
} else {
text = (NSString*)CFBridgingRelease(CFURLCreateStringByAddingPercentEscapes(NULL,(CFStringRef) text, NULL,CFSTR("!*'();:@&=+$,/?%#[]"),kCFStringEncodingUTF8));
......
}
}
Yes. It works. But we need sharing with a caption. Does anyone have a solution for this?
share image on WA work on my Device, and shareOption like this
let shareOptions = {
title: "",
url: this.state.cameraRollUri,
message: "",
subject: "", // for email,
}
then i add code
} else if ([options[@"url"] <EMAIL_ADDRESS>!= NSNotFound || [options[@"url"] <EMAIL_ADDRESS>!= NSNotFound || [options[@"url"] <EMAIL_ADDRESS>!= NSNotFound) {
NSLog(@"Sending whatsapp image");
documentInteractionController = [UIDocumentInteractionController interactionControllerWithURL:[NSURL fileURLWithPath:options[@"url"]]];
documentInteractionController.UTI = @"net.whatsapp.image";
documentInteractionController.delegate = self;
[documentInteractionController presentOpenInMenuFromRect:CGRectMake(0, 0, 0, 0) inView:[[[[[UIApplication sharedApplication] delegate] window] rootViewController] view] animated:YES];
NSLog(@"Done whatsapp image");
successCallback(@[]);
on file WhatsAppShare.m line 49
if ([options[@"url"] <EMAIL_ADDRESS>!= NSNotFound || [options[@"url"] <EMAIL_ADDRESS>!= NSNotFound) {
.....
successCallback(@[]);
// add code here
} else {
text = (NSString*)CFBridgingRelease(CFURLCreateStringByAddingPercentEscapes(NULL,(CFStringRef) text, NULL,CFSTR("!*'();:@&=+$,/?%#[]"),kCFStringEncodingUTF8));
......
}
}
Yes. It works. But we need sharing with a caption. Does anyone have a solution for this?
Any solution for this?
Facing same issue any update?
It is impossible. Just share only message or image. Not both.
@EnclaveAnthony Is there any way we can send two messages in one share. One for image and next for message.
from this latest release note for Whatsapp. Enclave is right
I have found a working workaround for this problem. Currently, I also use it in one of my applications. You can directly plug and play the below onClick function on a button press.
RNFS.downloadFile, downloads the remote image using URL and save it to a path.
RNFS.readFile, converts the locally saved file data to base64 which is supported directly by Whatsapp and other applications.
async onClick(url, id){
const path = `${RNFS.DocumentDirectoryPath}/${id}.jpg`;
await RNFS.downloadFile({ fromUrl: url, toFile: `file://${path}` }).promise
.then((res) => {
return res;
})
.catch((err) => {
return err;
});
RNFS.readFile(`file://${path}`, 'base64').then((res) => {
let shareOptionsUrl = {
title: 'My Application',
message: 'Use my application',
url: `data:image/jpeg;base64,${res}`, // use image/jpeg instead of image/jpg
subject: 'Share information from your application'
};
Share.open(shareOptionsUrl);
})
}
Url is the image remote URL and id is some unique identifier for that image.
Share.shareSingle(options) share image on whatsapp is not working while Share.open(options) working perfectly.
any solution ?
|
2025-04-01T04:35:19.685656
| 2019-05-13T18:42:27
|
443545218
|
{
"authors": [
"MateusAndrade",
"mikehardy"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10205",
"repo": "react-native-community/react-native-share",
"url": "https://github.com/react-native-community/react-native-share/pull/495"
}
|
gharchive/pull-request
|
Feature/improving-project-mds
Overview
I was having some difficulties regarding my GPS key in my commits from my last PR.
Because of this, I decided to create a new PR based on my changes and close the previous one. This PR includes the changes requested by @jgcmarins and @mikehardy .
Also, i must apologize for this because I had not used commits with sign until today. π
The PR #488 have been closed, and the changes applied to it are applied on this PR.
I'm late but I approve, and you are verified :clap: - getting that stuff right is super fiddly. Nice
|
2025-04-01T04:35:19.691362
| 2019-07-25T10:43:18
|
472794255
|
{
"authors": [
"MaxToyberman",
"Titozzz",
"adophper",
"httol",
"paldepind"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10206",
"repo": "react-native-community/react-native-webview",
"url": "https://github.com/react-native-community/react-native-webview/issues/742"
}
|
gharchive/issue
|
posting a message to webview doesnt work
Hi !
I was sending a message to my WebView like this :
this.myWebView.postMessage(
JSON.stringify({
messageType: "handleServerResponse",
responseData: json,
requestId
})
);
but after the upgrade it has stopped working, and now i'm trying to use the injectJavaScript instead.
This is what i am trying to do :
const injectedJS= `
window.postMessage("${JSON.stringify({
messageType: "handleServerResponse",
responseData: json,
requestId
})}");
true;`
this.myWebView.injectJavaScript(injectedJS)
but the message is not received on the WebView side,
communication from the WebView to the app it self by using
window.ReactNativeWebView.postMessage(data);
is working fine.
please help
ok, i have found a solution but i am not sure this is the best way.
this. myWebView.injectJavaScript(`
(function(){
window.postMessage('${data}','*');
})();
true;
`)
https://github.com/react-native-community/react-native-webview/issues/422#issuecomment-473268779
So what your question is?
https://github.com/react-native-community/react-native-webview/issues/422#issuecomment-473268779
@happy-thorny i'm not sure that this is the best way to do it.
@MaxToyberman this.myWebView.postMessage should still work? In the readme removing it is only listed as an upcoming change.
@MaxToyberman my web page did not receive the message sent by the app.
this. myWebView.injectJavaScript(`
(function(){
window.postMessage('${data}','*');
})();
true;
`)
@MaxToyberman Your method is the good one. Please note that the website you are trying to communicate with could also expose functions on the window to allow you manipulate it without using postMessage, (ofc only if you manage the website too) :)
|
2025-04-01T04:35:19.779365
| 2021-04-09T06:41:28
|
854217010
|
{
"authors": [
"Sid-Shanker",
"cj768025549",
"douglasjunior",
"fredmanxu",
"mikehardy",
"zoultrex"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10207",
"repo": "react-native-device-info/react-native-device-info",
"url": "https://github.com/react-native-device-info/react-native-device-info/issues/1212"
}
|
gharchive/issue
|
node_modules/react-native-device-info/src/index.ts: Unexpected token (12:12)
During npm start ... I get this error
error: bundling failed: SyntaxError: .../node_modules/react-native-device-info/src/index.ts: Unexpected token (12:12)
I have already updated it to the latest version (8.0.8), but it still has the error. And my typescript version is 3.9.7.
This smells like it was addressed in the v8 changelog area:
Note, if you use typescript, this requires a minimum version of typescript 3.8 This change was inadvertently released without realizing it was a breaking change, apologies. It is close enough to the 8.0.0 release that it will stand here though, without bumping to 9.0.0
You assert that your typescript version is 3.9.7. I would guess that the typescript version in actual use is not >= 3.8 somehow based on the error message
Got the same issue. Had to downgrade the version:
"react-native-device-info": "8.0.0"
It worked.
Better to upgrade typescript, but yes, 8.0.0 will work with stale typescript versions
I have a same problem.
"react-native": "^0.63.3"
"react-native-device-info": "^8.0.2",
My typescript version is 4.2.4,I try downgrade the version "react-native-device-info": "^8.0.0",.
It worked.
@fredmanxu the only explanation that fits those facts is that you think you are using a compatible version of typescript but somehow, somewhere in your build chain you are not
How to use without typescript?
Version 7.4.0 works for me on RN 0.61.5
@zoultrex
Should I keep trying to downgrade untill some version works?
I think you meant "Should I update all my packages so I'm running current stable versions?"
To which the answer is Yes! That's the best path, then everything will work and you can actually get support for any problems that come up
@zoultrex
Should I keep trying to downgrade untill some version works?
I think you meant "Should I update all my packages so I'm running current stable versions?"
To which the answer is Yes! That's the best path, then everything will work and you can actually get support for any problems that come up
Thats on my todo list, but I just don't have the time right now to upgrade React Native and everything else that comes after that change.
But I do totally agree, stay on the latest stable version is always the best approach
|
2025-04-01T04:35:19.785343
| 2018-10-08T11:41:55
|
367750801
|
{
"authors": [
"Bardiamist",
"NemanjaManot",
"kashishgrover",
"manuhook",
"mikehardy",
"roots-ai"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10208",
"repo": "react-native-device-info/react-native-device-info",
"url": "https://github.com/react-native-device-info/react-native-device-info/issues/511"
}
|
gharchive/issue
|
Detect Soft Navigation Keys in Android
Description
Implement something like DeviceInfo.areSoftwareKeysEnabled() or DeviceInfo.hasSoftNavigationKeysEnabled() to detect whether software keys are enabled in an android device.
Use Case
To detect whether a device has hardware keys enabled or software keys enabled. This can be a bit of an issue when it comes to designing for all kinds of devices. These days with the advent of notches and curved devices, handling this is super important
+1
https://github.com/Sunhat/react-native-extra-dimensions-android
ExtraDimensions.isSoftMenuBarEnabled()
This looks like a great find @manuhook - nice! I see no reason to duplicate the work in that package, as it seems very thorough and with recent updates. I'm closing this but please holler if you think I'm wrong
https://github.com/Sunhat/react-native-extra-dimensions-android wrong on Redmi Note 7 (isSoftMenuBarEnabled return false when it is should be true).
Would be good to have that feature in DeviceInfo. Now I need that for try to improve some bug workoround because got this.
When I looked at this last time, the referenced package seemed active. Now it seems dead, which is new information from my perspective. I don't want to duplicate work but I won't obstruct making things work, if that makes sense?
I would be open to ingesting that code if you posted an issue there saying "This repository appears dormant, any objections to hosting the functionality in react-native-device-info?" and proposed a PR here. I'd be happy to make any maintainers there maintainers here etc - the idea is friendly maintenance of features people need, not some icky power play in other words, we all have enough to do without maintaining more code and politics is not even on my list of things to dabble in :sweat_smile:
Any updates here?
|
2025-04-01T04:35:19.792969
| 2021-08-06T08:34:37
|
962526679
|
{
"authors": [
"Podlipny",
"brett-james-rocketlab",
"sreehari-kt",
"vaibhavcis2912"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10209",
"repo": "react-native-image-picker/react-native-image-picker",
"url": "https://github.com/react-native-image-picker/react-native-image-picker/issues/1793"
}
|
gharchive/issue
|
Picture take using launchCamera rotates in some devices and working fine in some devices[π]
Picture take using launchCamera rotates in some devices and working fine in some devices.
Find that it just happend with the samsung devices.
we have exactly the same problem. We've tried to fix it by rotation according to isVertical. But this does not work for images picked from the Android image gallery. They always return isVertical: false
I do have the same issue with Pixel 3 device, does anyone found a solution?
Got this problem as well, is there a work around?
|
2025-04-01T04:35:19.798028
| 2023-03-28T14:54:37
|
1644130159
|
{
"authors": [
"Simon-TechForm",
"artyom-ivanov"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10210",
"repo": "react-native-maps/react-native-maps",
"url": "https://github.com/react-native-maps/react-native-maps/issues/4651"
}
|
gharchive/issue
|
Request of user location not working when use default provider on ios
Summary
if I use the google maps provider, then the request for the user's location appears automatically. If I use apple maps (the default provider), then the request does not appear.
Reproducible sample code
<MapView
ref={(ref) => (map.current = ref)}
style={{ flex: 1 }}
provider={
settings.preferredMap === 'apple'
? PROVIDER_DEFAULT // REQUEST NOT APPEARS
: PROVIDER_GOOGLE // REQUEST APPEARS
}
showsUserLocation
onUserLocationChange={handleLocation}
initialRegion={INITIAL_REGION}
onRegionChange={changeLocation}
/>
Steps to reproduce
Run app on clean simulator with apple map by default and "showsUserLocation" prop on Map component.
Expected result
Request about user location appears
Actual result
Request not appears
React Native Maps Version
1.1.0
What platforms are you seeing the problem on?
iOS (Apple Maps)
React Native Version
0.69.1
What version of Expo are you using?
Not using Expo
Device(s)
iPhone 13 mini simulator, iPhone 12 pro max
Additional information
No response
Hello @artyom-ivanov π
This is the expected behaviour. Google decided to build it into the Google Maps SDK which is the only reason why it's there for Google Maps. I'm a firm believer that it isn't the responsibility of react-native-maps to request location permissions. The behaviour is documented in the docs.
|
2025-04-01T04:35:19.805435
| 2022-06-01T06:12:25
|
1255076172
|
{
"authors": [
"matt-oakes",
"mikehardy",
"namrog84"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10211",
"repo": "react-native-netinfo/react-native-netinfo",
"url": "https://github.com/react-native-netinfo/react-native-netinfo/pull/603"
}
|
gharchive/pull-request
|
Change WindowsTargetPlatformVersion to 10.0
Overview
Changed to general version for WindowsTargetPlatformVersion
Using an explicit version of WindowsTargetPlatformVersion requires that specific windows SDK version to be installed on the machine.
In Visual Studio 2017 (version 15 or build tools 141) and earlier it was required but as of Visual Studio 2019 (v16 or v142) and Visual Studio 2022(v17 or v143) you can simply specify "10.0". This allows a lot more flexibility to the developer or build machine as there is a growing number of different windows 10 SDK out there now.
Test Plan
You can now install/run on machines without needing as specific of a windows 10.0 version (think of this as saying using the latest version of windows 10 sdk you have installed, so long as it meets the WindowsTargetPlatformMinVersion.
Newer versions of azure hosted windows images have a different subset.
VS2022 Azure Window image has
10.0.17763.0, 10.0.19041.0, 10.0.20348.0, 10.0.22000.0
VS2019 Azure Window image had
10.0.14393.0, 10.0.16299.0, 10.0.17134.0, 10.0.17763.0, 10.0.18362.0, 10.0.19041.0, 10.0.20348.0, 10.0.22000.0
Just because url/links can die, copy pasting answer here too.
Am I correct in interpreting that this will actually break people that are using old tools?
That is correct this is technically a breaking change for people using old MSVC build tools that come with Visual Studio 2017 or Visual Studio 2015. It is non breaking for build tools that come with Visual Studio 2019 or 2022. Assuming other things don't break in RNW
Though to be super specific, it technically isn't Visual Studio that is breaking change but the underlying MSVC build tools that comes bundled with each of those visual studio versions (e.g. Visual Studio 2022 comes with MSVC v143), and it is possible to install older build tools with newer visual studio during 'transitional' periods.
I think it's fair to say most people doing react-native-windows related work should be on at least VS2019 (MSVC v142) as that's what RNW has been using/recommending for a number of years now. And VS2022 has been out for almost a year too.
BREAKING CHANGE: If you are using react-native-windows, and you have Visual Studio versions older than Visual Studio 2019 or using build tools older than MSVC v142, you must upgrade Visual Studio and/or your build tools to use at least MSVC v142 (Visual Studio 2019). No one else is affected.
FYI now that the other one landed, I'll make a few other changes here too before too then.
Great - honestly it's almost scary, on device-info it semantically releases just on the commit alone. Always nervous I got the commit message right, but I did that time...
:tada: This PR is included in version 9.0.0 :tada:
The release is available on:
npm package (@latest dist-tag)
GitHub release
Your semantic-release bot :package::rocket:
:boom: done
|
2025-04-01T04:35:19.817597
| 2023-11-20T13:25:43
|
2002205787
|
{
"authors": [
"kozhinas"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10212",
"repo": "react-native-video/react-native-video",
"url": "https://github.com/react-native-video/react-native-video/issues/3364"
}
|
gharchive/issue
|
ios 17.2 Invariant Violation: requireNativeComponent: "RCTVideo" was not found in the UIManager.
Platform
Which player are you experiencing the problem on:
iOS
Environment info
Library version: 6.0.0-alpha.11
Device: iphone 12
"react-native": "0.66.5",
Steps To Reproduce
Hello, cant play mp4 stream video, get a error Invariant Violation: requireNativeComponent: "RCTVideo" was not found in the UIManager. How fix it? thx
pods installed
I saw in the recommendations that you need rn 68+, Iβll try to update and let you know
updated, still the same error, but I had to install packages from rosetta
look like a linking issue. you should investigate around that. The best would be having a sample to re create the isssue
oh this will be difficult, I had to install vlc(
|
2025-04-01T04:35:19.824709
| 2021-11-07T22:40:58
|
1046869096
|
{
"authors": [
"Cogneter",
"gfaraj"
],
"license": "mit",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10213",
"repo": "react-native-web-community/react-native-web-webview",
"url": "https://github.com/react-native-web-community/react-native-web-webview/issues/55"
}
|
gharchive/issue
|
The onMessage prop is never triggered on react-native-web
I'm using this package to bring feature parity to my web and native apps, but I can't seem to communicate back to react native from the website.
My usage is:
const onMessage = useCallback((message: WebViewMessageEvent) => {
const data = JSON.parse(message.nativeEvent.data);
console.log('Getting a message from the game web view...');
console.log(data);
}, [foo]);
return (<WebView
style={styles.webView}
source={source}
javaScriptEnabled
domStorageEnabled
ref={() => {}}
onMessage={onMessage}
mixedContentMode={'always'}
onNavigationStateChange={onNavigationStateChange}
cacheEnabled={false} />);
The website I'm loading within the webview/iframe does this:
var payloadStr = JSON.stringify(payload);
var target = window.ReactNativeWebView || window.parent || window;
var postMessageFunction = target && target.postMessage;
if (postMessageFunction) {
postMessageFunction(payloadStr);
} else {
console.log('Did not find target to post message!');
}
The native webview works fine through window.ReactNativeWebView.postMessage but for web window.ReactNativeWebView is not defined and so I had to figure out where to post the message. This still doesn't trigger my onMessage though.
Any ideas?
I managed to get it to work by modifying the above code to this:
var payloadStr = JSON.stringify(payload);
if (window.ReactNativeWebView) {
window.ReactNativeWebView.postMessage(payloadStr);
} else if (window.parent) {
window.parent.postMessage(payloadStr, '*');
} else {
window.postMessage(payloadStr, '*');
}
It works on both native and web. I think adding something about this to the documentation would be great. Thanks for making this!
I managed to get it to work by modifying the above code to this:
var payloadStr = JSON.stringify(payload);
if (window.ReactNativeWebView) {
window.ReactNativeWebView.postMessage(payloadStr);
} else if (window.parent) {
window.parent.postMessage(payloadStr, '*');
} else {
window.postMessage(payloadStr, '*');
}
It works on both native and web. I think adding something about this to the documentation would be great. Thanks for making this!
I had the same problem and your solution worked. Thanks!
|
2025-04-01T04:35:19.863601
| 2019-11-05T13:38:10
|
517778091
|
{
"authors": [
"PeterKottas",
"macrozone"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10214",
"repo": "react-page/react-page",
"url": "https://github.com/react-page/react-page/issues/738"
}
|
gharchive/issue
|
deprecate "native plugins" and re-implement?
While working on the library, i see many extra apis around "native plugins", but personally, i don't understand fully what these do. I guess, it should allow to drag and drop OS-elements like files etc. into the editor.
But in my opinion, this is not worth the extra apis around it. There are a lot of exceptions just for these plugins. Instead, it would be better if every plugin could monitor native drop events, no matter if layout or content plugin.
I also think it would be worth to unify layout and content-plugins and no longer distinct between the two, at least not for the editor-user, but that's a differenet topic
Makes perfect sense, I think we can close here and continue on #777
i am about to refactor a lot and native plugins will be removed. i will add a way so that normal plugins can hook into drag&drop.
|
2025-04-01T04:35:19.871088
| 2019-07-23T12:26:57
|
471667440
|
{
"authors": [
"RUVATA",
"aleclarson"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10215",
"repo": "react-spring/react-spring",
"url": "https://github.com/react-spring/react-spring/issues/762"
}
|
gharchive/issue
|
Parallax & ParalaxLayer wrong typescript types (TS2322 on official example)
π Bug Report
In fact the ParallaxLayer and Parallax (wrapper) classes signature should implements HTMLDivElement and abstract HTMLElement.
Placed to them properties are provided to native element 'as is', realization talks thats it is intention of developer.
Another argument that the official example of usage of Parallax, actively used placement props as 'style', 'onClick' handler and other.
Steps to reproduce the behavior:
Link to repro (highly encouraged)
see fork of official example, where index file extension changed to TSX
React-Spring Prallax TS2322 Errors
Environment
react-spring v8.x.x
react v16.8.x
#761
The newest types are at @react-spring/parallax. Could you give those a try, and report back if you have any issues? Thanks π
|
2025-04-01T04:35:19.876266
| 2017-08-31T16:22:30
|
254392685
|
{
"authors": [
"Tsvetkovv",
"tannerlinsley"
],
"license": "mit",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10216",
"repo": "react-tools/react-table",
"url": "https://github.com/react-tools/react-table/pull/471"
}
|
gharchive/pull-request
|
Fix: no extra checking for toggleSort
I think the extra check doesn't make sense
This is a pretty standard check to make sure that the function is defined.
@tannerlinsley if you pass undefined, nothing happened. React always check it, elseways
|
2025-04-01T04:35:19.878604
| 2016-01-06T03:31:02
|
125103339
|
{
"authors": [
"Ratismal",
"ekmartin",
"lrabe"
],
"license": "mit",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10217",
"repo": "reactiflux/discord-irc",
"url": "https://github.com/reactiflux/discord-irc/issues/26"
}
|
gharchive/issue
|
Can't start discord-irc
Whenever I attempt to run discord-irc, it immediately crashes.
me@my-computer:~$ discord-irc --config /path/to/config.json
/usr/local/lib/node_modules/discord-irc/node_modules/discord.js/lib/Voice/StreamIntent.js:9
f (typeof superClass !== "function" && superClass !== null) { throw new TypeEr
^
TypeError: Super expression must either be null or a function, not object
at _inherits (/usr/local/lib/node_modules/discord-irc/node_modules/discord.js/lib/Voice/StreamIntent.js:9:113)
at /usr/local/lib/node_modules/discord-irc/node_modules/discord.js/lib/Voice/StreamIntent.js:16:2
at Object.<anonymous> (/usr/local/lib/node_modules/discord-irc/node_modules/discord.js/lib/Voice/StreamIntent.js:25:3)
at Module._compile (module.js:456:26)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
at Module.require (module.js:364:17)
at require (module.js:380:17)
at Object.<anonymous> (/usr/local/lib/node_modules/discord-irc/node_modules/discord.js/lib/Voice/VoiceConnection.js:38:21)
For future reference, I replaced my config path to /path/to/config.json for ticket purposes. I'm running Ubuntu 14.04.3 LTS. Help would be appreciated.
What's your output of node -v?
Ubuntu 14.04 LTS repos only have node 0.10 while 0.12 is required.
Updated node, and it works perfectly. Thanks!
Thanks @Irabe.
|
2025-04-01T04:35:19.887543
| 2023-07-17T06:13:09
|
1807055769
|
{
"authors": [
"Archmonger",
"rmorshea"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10218",
"repo": "reactive-python/reactpy",
"url": "https://github.com/reactive-python/reactpy/issues/1110"
}
|
gharchive/issue
|
ReactPy ASGI App and Middleware
Current Situation
Currently we perform ASGI routing via backend-specific APIs. However, it is much easier to do so via ASGI middleware. Additionally, we should have a "standalone" mode where ReactPy can run in a production configuration without any backend.
I originally pitched this concept a long time ago during our development of our configure() function.
Proposed Actions
Create a ReactPy ASGI application that can also function as middleware. It will look something like this:
import re
from asgiref.compatibility import guarantee_single_callable
class ReactPy:
def __init__(
self,
application=None,
dispatcher_url="reactpy/stream/${route}${query}",
modules_url="reactpy/modules",
static_url="reactpy/assets",
) -> None:
self.user_app = guarantee_single_callable(application)
self.urlpatterns = "|".join((dispatcher_url, modules_url, static_url))
async def __call__(self, scope, receive, send) -> None:
"""The ASGI callable. This determines whether ReactPy should route the the
request to our own ASGI application."""
if not self.user_app or re.match(self.urlpatterns, scope["path"]):
await self.reactpy_app(scope, receive, send)
else:
await self.user_app(scope, receive, send)
async def reactpy_app(self, scope, send, receive) -> None:
"""The ASGI application for ReactPy."""
# This will handle our component dispatcher, web modules, static files. and `index.html` view.
@rmorshea I can also develop a WSGI variant of this. However, it will only work with WSGI webservers that have official websocket support: werkzeug, gunicorn, eventlet, and gevent.
The design of this would be largely based on flask-sock.
If we could take a similar approach to simplifying the flask/tornado backends that would be good too. If not, doesn't seem necessary. Regardless, probably should be done in a separate PR.
WSGI middleware would grant us compatibility with the following frameworks: https://wsgi.readthedocs.io/en/latest/frameworks.html
Unfortunately tornado uses its own custom API, so we would either need to drop support for tornado or keep using configure() for it. To be honest, I'm leaning towards dropping support because tornado does not have built-in integration with Jinja template tags.
Plus WSGI and ASGI middleware would mean we have automatic support for like 30+ frameworks. That's already pretty overkill.
I'm realizing that tornado support should almost certainly be spun off into its own package, similar to ReactPy-Django.
|
2025-04-01T04:35:19.896277
| 2018-10-05T23:34:38
|
367399188
|
{
"authors": [
"ejether",
"endzyme"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10219",
"repo": "reactiveops/rok8s-scripts",
"url": "https://github.com/reactiveops/rok8s-scripts/pull/198"
}
|
gharchive/pull-request
|
Added more support for tagging
Added support to simply add new dockerfile bases without having to update CI files
Added support for release tagging of Major and Minor releases to help keep consumers up to date
The intended changes here allow for easier automatic update for consumers of rok8s-scripts by having a vX and a vX.Y tag in addition to the vX.Y.Z tags. This will help people keep up to date within the major and/or minor release without having to update their CI files. This DOES introduce some concern to see if we are truly backwards compatible so we should take extra care on changes in a minor and major version.
Note this has a failed CI job because I got too sneaky with trying to push a shadow release. It's actually a good thing that it failed, testing that you cannot just tag any ole branch
The PR looks reasonable to me.
What steps did you take for your "shadow release"
In my testing, I could tag any sha and it would do a release so I'm curious how it failed here? Had you rewritten history or anything?
The commit referred exists but no tag exists? Perhaps you pushed the tag to kick off the build but then deleted the tag before the release step?
So it's a little rubegoldbergy but I tracked down that the github release step looks at the master branch only so the job fails and said it cannot find any tags on this commit ID.
I don't think thats show the release script works. I've been using it in other projects and it has not need the commit to be in the master branch.
Glancing at the code a little more I think maybe https://github.com/reactiveops/release.sh/blob/v0.0.2/release#L18 failed. I am not at a laptop but that's my best guess.
The error in the ci run doesn't leave many hints and that script could use some trap err love to help isolate what line or command failed.
I did not make an annotated commit but don't think that's the issue. Although I think it's conflicting that set -e is set and there's an if testing the status code of the last command in the link above.
Perhaps Monday we can sit down and walk through the process of using this release.sh script.
Found that this needs to be an annotated tag and that's why the release.sh failed. There is a catch that gives context on what went wrong but the bash -e setting fails before it can hit that helpful echo.
|
2025-04-01T04:35:19.902839
| 2020-05-07T16:10:23
|
614176915
|
{
"authors": [
"RLittlesII",
"RolandPheasant",
"aguahombre"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10220",
"repo": "reactiveui/DynamicData",
"url": "https://github.com/reactiveui/DynamicData/issues/358"
}
|
gharchive/issue
|
Change in behaviour of ToObservableChangeSet with expireAfter in v6.14.*
The ToObservableChangeSet expireAfter no longer works in v6.14.* if the the source IObservable<IEnumerable> completes before the timeout occurs.
Using this example compiled with v6.13.21 using .netcore 3.1 console program on Windows 10
static void Main(string[] args)
{
Observable.Return(Enumerable.Range(0, 10).Select(i => new { A = i, B = 2 * i }))
.ToObservableChangeSet(x => x.A, _ => TimeSpan.FromSeconds(5))
.Subscribe(x => Console.WriteLine($"{DateTime.UtcNow} {x.Count}:\n {string.Join("\n ", x)}"));
Console.ReadKey();
}
produces the output
but with v6.14.18
I would expect the v6.13.21 behaviour to occur; i.e. the items to be removed from the change set after 5 seconds.
@aguahombre Thank you for providing this report. We will look into it and provide and update.
Also, is there a list of dependent libraries and their versions per test execution?
Here is the project file
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp3.1</TargetFramework>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="DynamicData" Version="6.14.18" />
</ItemGroup>
</Project>
and the using statements
using System;
using System.Linq;
using System.Reactive.Linq;
using DynamicData;
It's been long overdue for me looking at this. But the change which creates there error was introduced in the commit.
It's not obvious why this would be an issue but I'll take a look. Ideally it can be reproduced in a unit test.
|
2025-04-01T04:35:19.922502
| 2016-08-01T16:04:54
|
168682299
|
{
"authors": [
"CompuIves",
"claydiffrient",
"coveralls",
"diasbruno"
],
"license": "mit",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10221",
"repo": "reactjs/react-modal",
"url": "https://github.com/reactjs/react-modal/pull/205"
}
|
gharchive/pull-request
|
[changed] Don't render div on dom when isOpen is false
I noticed that when I wanted to animate the fadein of a modal it only worked for the first time. This was because the css animation of ReactModal__Overlay--after-open only works when a div is rendered for the first time. That's why I changed the logic to render nothing if there is no modal.
I'm aware that this can break a lot of things (like using a ref for ReactModal) for other people, so maybe we need to bump a major version if we want to have this.
Changes proposed:
When not open, render null instead of div
Upgrade Path (for changed or removed APIs):
When you want to use a ref on ReactModal and use it after it's rendered, you will have to place the call to the ref in a setTimeout so it's accessible after it's rendered.
Acceptance Checklist:
[ ] All commits have been squashed to one.
[ ] The commit message follows the guidelines in CONTRIBUTING.md.
[ ] Documentation (README.md) and examples have been updated as needed.
[x] If this is a code change, a spec testing the functionality has been added.
[ ] If the commit message has [changed] or [removed], there is an upgrade path above.
This allows users to add an animation for opening the modal.
@claydiffrient any thoughts? looks good.
@CompuIves Sorry for the delay on this. Could you change the commit message from [fixed] to [changed] ? I think that will make it easier to indicate that it's more of a breaking change vs. a simple bug fix. I believe this is a valuable change. I'd like to get it in for v2.
No problem! I changed it.
Hi @CompuIves, we have released v2.0.0. This will need a rebase.
Okay! Will do it today.
There were a lot of changes, I decided to just recreate the changes based on new master.
I wasn't able to reproduce the rendering of div instead of null in the tests anymore, maybe I'm doing something wrong or something has changed.
Coverage decreased (-13.5%) to 71.429% when pulling dc14e2d9b7b94b3828635e9704fa5a0f26972ff4 on CompuIves:master into 8f3898a6b613a6edb8c0d2b1a255f03fc9367d71 on reactjs:master.
Awesome, @CompuIves!
Perhaps after close the modal you can check if modal.portal == null.
Ah, that works, thanks! Added test.
yeah, that is correct.
Coverage remained the same at 84.956% when pulling 9f3fd854f229e83b8381e1747af43ccb88ecc888 on CompuIves:master into 8f3898a6b613a6edb8c0d2b1a255f03fc9367d71 on reactjs:master.
You can squash the commits and append [chore] at the begging of the commit message.
Done!
Coverage remained the same at 84.956% when pulling 1639de8e47c1dc58ae5ebd4813afc8b103097b50 on CompuIves:master into 8f3898a6b613a6edb8c0d2b1a255f03fc9367d71 on reactjs:master.
|
2025-04-01T04:35:19.927356
| 2016-10-08T14:20:20
|
181828536
|
{
"authors": [
"claydiffrient",
"diasbruno"
],
"license": "mit",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10222",
"repo": "reactjs/react-modal",
"url": "https://github.com/reactjs/react-modal/pull/243"
}
|
gharchive/pull-request
|
[added] Add contentLabel prop to put aria-label on modal content
Fixes #236.
Changes proposed:
Add a aria-label to the modal content
Upgrade Path (for changed or removed APIs):
Existing modals should add a contentLabel prop describing the modal content
Acceptance Checklist:
[x] All commits have been squashed to one.
[x] The commit message follows the guidelines in CONTRIBUTING.md.
[x] Documentation (README.md) and examples have been updated as needed.
[x] If this is a code change, a spec testing the functionality has been added.
[x] If the commit message has [changed] or [removed], there is an upgrade path above.
@diasbruno / @afercia would you mind reviewing this?
@claydiffrient Looks good! Ship it!
hmmmm, #230 would let people to choose what they want for data and aria attributes.
@diasbruno It doesn't look like #230 support all props just custom props. I think this is acceptable to make sure that the aria-label can be applied. I think once the merge conflicts are resolved on #230 then we can merge it as well.
|
2025-04-01T04:35:19.962952
| 2016-05-14T16:23:13
|
154862436
|
{
"authors": [
"gaearon",
"markerikson",
"sevenLee"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10223",
"repo": "reactjs/react-redux",
"url": "https://github.com/reactjs/react-redux/issues/379"
}
|
gharchive/issue
|
Why I can't bind state to this.props on component which is in iframe?
I have a specific scenario in my react/redux/express universal project (server-side rendering).
(1)First I defined my routes like so: [ routes.jsx ]
export default (
<Route component={App} path="/">
<Route component={MainView} path="main">
<IndexRoute component={ThemeIndex}></IndexRoute>
</Route>
<Route component={AnotherView} path="preview" />
</Route>
);
As you see, when url route is: localhost:3000/preview, react-router will use AnotherView component.
(2)Now focus on ThemeIndex component: [ ThemeIndex.jsx ]
export default class ThemeIndex extends Component {
render() {
return (
<div>
<h2>Index</h2>
<Frame />
<Control />
</div>
);
}
}
(3)Frame component like so: [ Frame.jsx ]
class Frame extends Component {
render() {
const { text, uid } = this.props.infos;
const themeUrl = `http://localhost:3000/preview?id=${uid}`;
//console.log('Frame theme:', text);
//console.log('Frame uid:', uid);
return (
<div className="col-md-8 panel panel-default">
<div className="embed-responsive embed-responsive-16by9 panel-body">
<iframe src={themeUrl}/></iframe>
</div>
<div className="details" >
{text}
</div>
</div>
);
}
}
export default connect(
(state) => {
return {
infos: state.infos
}
}
)(Frame);
Here I use iframe tag, its src is http://localhost:3000/preview?id=xxxx, so it means it will link AnotherView component to be iframe's page.
(4)AnotherView Component like so:
class AnotherView extends Component {
render() {
const { text, uid } = this.props.infos;
//console.log('AnotherView theme:', text);
//console.log('AnotherView uid:', uid);
return (
<div>
<div >Another View</div>
<div>
{text}
</div>
<div>{uid}</div>
</div>
);
}
}
export default connect(
(state) => {
console.log('another view trigger state:', state);
return {
infos: state.infos
}
}
)(AnotherView);
(5)And I have Control component for making dynamic value: [ Component.jsx ]
class Control extends Component {
render(){
var uid = () => Math.random().toString(34).slice(2);
return (
<input
onChange={(event) => this.props.addTodo({text:event.target.value, uid:uid()})
/>
)
}
}
export default connect(
(state) => {
return {
infos: state.infos
}
}
)(Control);
(6)List extra files, Action and Reducer:
[ action.js ]
export function addTodo (attrs) {
return {
type: 'ADD_TODO',
attrs
};
}
[ reducer.js ]
export default (state = {text:'', uid:''}, action) => {
switch(action.type) {
case 'ADD_TODO':
return Object.assign({}, state, action.attrs);
default:
return state;
}
}
Here is Store configuration on server.js:
app.use( (req, res) => {
console.log('server - reducers:', reducers);
const location = createLocation(req.url);
const reducer = combineReducers({infos: infosReducer});
const store = applyMiddleware(promiseMiddleware)(createStore)(reducer);
match({ routes, location }, (err, redirectLocation, renderProps) => {
.......
function renderView() {
const createElement = (Component, props) => (
<Component
{...props}
radiumConfig={{ userAgent: req.headers['user-agent'] }}
/>
);
const InitialView = (
<Provider store={store}>
<RoutingContext
{...renderProps}
createElement={createElement} />
</Provider>
);
const componentHTML = renderToString(InitialView);
const initialState = store.getState();
......
my application state is like :
{
infos:{
text: '',
uid: ''
}
}
(7)Now I key some words on input in Control component. When the input onChange will trigger addTodo action function to dispatch action in reducer, finally change the state. In common, the state changing will effect Frame component and AnotherView component, because I used react-redux connect, bind the state property to this.props on the component.
But in fact, there is a problem in AnotherView component. in Frame component, console.log value display the text you key in input correctly. In AnotherView component, even the connect callback will be trigger (console.log will print 'another view trigger state: ...') , the console.log in render is undefined, like:
console.log('AnotherView theme:', text); //return AnotherView theme: undefined
console.log('AnotherView uid:', uid); //return AnotherView uid: undefined
I found the main reason: AnotherView component is in iframe. Because if I remove iframe, put AnotherView component directly here, like so:
return (
<div className="col-md-8 panel panel-default">
<div className="embed-responsive embed-responsive-16by9 panel-body">
<AnotherView/>
</div>
<div className="details" >
{text}
</div>
</div>
);
then I can bind state properties on this.props in AnotherView component successfully, then insert {text} on JSX html, you can see the value changing real time when you key input value on Control component. if I use iframe to link AnotherView component be its page, you can't see any changing {text} value, because my text default value is empty string value.
How do I bind state properties to this.props in the component which is in iframe when state changing?
This is a usage question, and really should be asked on Stack Overflow instead of here. Github issues should be used for actual bugs or concerns with the library itself.
I can't get the latest state in iframe (source is React component), when I changing state in another component, and actually the mapStateToProps was triggered! but the state is not the latest in mapStateToProps function. it does not really concerns with the react-redux library?
I replied to the question.
For future reference, code samples in a question are fine on StackOverflow, but if you think you hit a bug, and raise an issue, please provide a full project so that maintainers donβt need to spend time copying and pasting your code and installing the corresponding libraries.
Cheers!
|
2025-04-01T04:35:19.965310
| 2019-02-19T17:59:48
|
412052548
|
{
"authors": [
"BartoszKlonowski",
"petetnt"
],
"license": "CC-BY-4.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10224",
"repo": "reactjs/react.dev",
"url": "https://github.com/reactjs/react.dev/pull/1711"
}
|
gharchive/pull-request
|
Update Fragment support section in a blogpost regarding Create React App
It's linked in for example in https://reactjs.org/docs/fragments.html#short-syntax and pretty confusing. We could consider just rewriting these whole "Many tools don't support support" section too.
Hello @petetnt!
Unfortunately the blog posts of this years are no longer maintained, so I will close this PR as outdated.
If you would still like to contribute please feel invited to create new PRs for other open issues.
Thank you!
|
2025-04-01T04:35:19.973789
| 2018-04-20T00:54:35
|
316088950
|
{
"authors": [
"gaearon",
"huarse",
"voliva"
],
"license": "CC-BY-4.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10225",
"repo": "reactjs/reactjs.org",
"url": "https://github.com/reactjs/reactjs.org/issues/828"
}
|
gharchive/issue
|
One scenarios of componentWillReceiveProps
class Editor extends React.Component {
constructor(props) {
super(props);
// ... init state ..
// init field
this.formField = new Field();
}
componentWillReceiveProps(nextProps) {
if (nextProps.visible && !this.props.visible) {
this.initData(nextProps);
}
}
initData(props) {
const {editData} = props;
// 1. setState by new editData
// ...
// 2. reset field values
this.formField.setValues({
username: editData.username,
// ...
});
}
}
The Field is a form manager component, it should reinit after Editor component shown.
In this case, I'm not sure how to migrate to new lifecycles
I think your case is this one: https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html#side-effects-on-props-change
So you would move your init logic on componentDidUpdate
@voliva But I think it's not a good practice to setState in componentDidUpdate lifecycle, and I'am afraid it's too late to reset form field in componentDidUpdate
Yep, this new lifecycle stuff is also confusing for me...
Taking a look at #819 diagram, maybe it'd be better to use getSnapshotBeforeUpdate(prevProps, prevState)? In there you have access to previous state/props + current state/props (through this), and looks suitable as long as you don't setState inside.
Wait, you mentioned
I think it's not a good practice to setState in componentDidUpdate
In the case you need to set the state based on props, it's getDerivedStateFromProps, but as it's a static method and you don't have access to previous props, you have to store those props you want to watch in your state. I know, it's also confusing for me. Something similar to this example: https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html#fetching-external-data-when-props-change
(Note that it's the first week I'm trying these new lifecycle methods, so please don't take my answer as someone with good experience....)
@voliva much thx for suggesting, I decision to use UNSAFE_componentWillReceiveProps, and replace it later.
The problem is the mutation.
Instead of having this.formField as a field you mutate in the instance, put it into the state, and treat it as immutable. When you want to change it, make a copy (and return it from getDerivedStateFromProps).
Itβs hard to say more without seeing the full code but thatβs the basic strategy. Mutation in componentWillReceiveProps will not work in async mode.
|
2025-04-01T04:35:19.976738
| 2019-05-18T03:23:50
|
445673480
|
{
"authors": [
"alexkrolick",
"tajammul-pasha",
"tajammul1996"
],
"license": "CC-BY-4.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10226",
"repo": "reactjs/reactjs.org",
"url": "https://github.com/reactjs/reactjs.org/pull/2010"
}
|
gharchive/pull-request
|
fixed svelte-js broken link in hooks intro page
Fixed svelte broken link in hooks intro page.
Before - it was redirecting to https://svelte.technology/
After - it's redirecting to https://svelte.dev/
Thanks
π
|
2025-04-01T04:35:19.979219
| 2023-04-24T22:08:41
|
1682113305
|
{
"authors": [
"gaearon",
"orama254"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10227",
"repo": "reactjs/translations.react.dev",
"url": "https://github.com/reactjs/translations.react.dev/pull/259"
}
|
gharchive/pull-request
|
Add Swahili sw to langs
Greetings @gaearon,
As advised earlier, here is a fresh attempt at translating the new React docs to Swahili. Swahili is a language that is used majorly in the Eastern Africa Region (Kenya, Uganda, Tanzania, Rwanda, Burundi) and widely accepted worldwide. I have previous experience with translating the previous docs to Swahili and I am a native speaker and also proficient in English. I also have experience with open source as both a maintainer and contributor on GitHub.
sw: Nina matarajio mema kwa safari ijayo
en: (Looking forward to the amazing journey ahead)
@orama254 Let's see if this works. If it doesn't, I'll check what's up.
Done: https://github.com/reactjs/sw.react.dev/issues/1.
|
2025-04-01T04:35:20.013338
| 2023-04-17T07:16:14
|
1670567414
|
{
"authors": [
"moizsheraz"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10228",
"repo": "reactplay/react-play",
"url": "https://github.com/reactplay/react-play/issues/1118"
}
|
gharchive/issue
|
Threads
What's the Play about?
Built a react app like threads in Twitter with a model allowing multiple threads,tweet size constraints and display them on the home page
What ReactJS concept will be used to create this play?
Components, Hooks, Routing, Styling,API
Are you willing to take it up for implementation?
Yes
Code of Conduct
[X] I agree to follow this project's Code of Conduct
Is there any deadline to complete it?
No community support from the maintainers I was unable to install dependencies
|
2025-04-01T04:35:20.019342
| 2016-03-26T11:55:30
|
143695219
|
{
"authors": [
"danielweck"
],
"license": "bsd-3-clause",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10229",
"repo": "readium/readium-shared-js",
"url": "https://github.com/readium/readium-shared-js/issues/278"
}
|
gharchive/issue
|
Link handler target=_BLANK, opened link can redirect window.opener, potentially malicious.
See:
https://mathiasbynens.github.io/rel-noopener/
See code:
https://github.com/readium/readium-shared-js/blob/develop/js/views/internal_links_support.js#L210
Example with "Accessible EPUB3", link http://my.safaribooksonline.com:
https://readium.firebaseapp.com/?epub=epub_content%2Faccessible_epub_3&goto={"idref"%3A"id-id2442754"%2C"elementCfi"%3A"%2F4%2F2[I_book_d1e1]%2F2%2C%2F1%3A0%2C%2F1%3A1"}
Note how the original link is authored with target="_top", but Readium redirects to _blank (new window / tab in the web browser). This works with both the online "cloud reader" and the offline Chrome extension.
This should also work just fine in native apps (webview control delegates to the "real" web browser on the device).
The issue is that window.opener can potentially be used by scripts in the link destination to load a different location / HTML page into the original browsing context. Probably only affects the cloud reader though. Needs further testing.
|
2025-04-01T04:35:20.024918
| 2022-08-17T18:31:38
|
1342131222
|
{
"authors": [
"agjohnson"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10230",
"repo": "readthedocs/sphinx_rtd_theme",
"url": "https://github.com/readthedocs/sphinx_rtd_theme/pull/1314"
}
|
gharchive/pull-request
|
Unbreak CI config
Build with Node 14 installed through orbs.
Fixes #1275
Error is unrelated. Build failure is:
ERROR in ./src/sass/theme.sass
Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
ModuleBuildError: Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
:not(kbd) > kbd,
^
Property "not" must be followed by a ':'
I won't fix that in this PR.
|
2025-04-01T04:35:20.031017
| 2018-01-30T01:27:37
|
292621619
|
{
"authors": [
"jfallows"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10231",
"repo": "reaktivity/reaktor.java",
"url": "https://github.com/reaktivity/reaktor.java/issues/31"
}
|
gharchive/issue
|
[zerocopy] implement memory manager
MemoryManager API now defined on feature/zerocopy branch of nukleus.java.
public interface MemoryManager
{
long acquire(int capacity);
void release(long offset, int capacity);
}
Note: if the offset can be an actual addressOffset, then we can use DirectBuffer.wrap(long addressOffset, int capacity) to access the region readonly and MutableDirectBuffer.wrap(long addressOffset, int capacity) to access the region for mutation, via UnsafeBuffer implementation.
See reaktivity/ignition#13.
|
2025-04-01T04:35:20.040703
| 2018-11-30T10:37:30
|
386131044
|
{
"authors": [
"bmunkholm",
"flytov"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10233",
"repo": "realm/realm-cocoa",
"url": "https://github.com/realm/realm-cocoa/issues/6026"
}
|
gharchive/issue
|
RLMSyncConfiguration
!!! MANDATORY TO FILL OUT !!!
Goals
Expected Results
Actual Results
Steps to Reproduce
Code Sample
Version of Realm and Tooling
Realm framework version: ?
Realm Object Server version: ?
Xcode version: ?
iOS/OSX version: ?
Dependency manager + version: ?
@flytov This issue doesn't seem useful :-) I'm deleting that.
|
2025-04-01T04:35:20.042119
| 2015-07-20T19:43:36
|
96142908
|
{
"authors": [
"jpsim",
"segiddins"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10234",
"repo": "realm/realm-cocoa",
"url": "https://github.com/realm/realm-cocoa/pull/2251"
}
|
gharchive/pull-request
|
Swift 2 installation examples
\c @jpsim
:+1: other than consolidating the code to get the Swift/Xcode versions.
@jpsim moved this swift versioning logic out into its own file
:+1: thanks for doing this, Sam.
|
2025-04-01T04:35:20.074181
| 2023-01-03T18:32:10
|
1517770956
|
{
"authors": [
"Navil",
"blagoev",
"nielsenko"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10235",
"repo": "realm/realm-dart",
"url": "https://github.com/realm/realm-dart/issues/1087"
}
|
gharchive/issue
|
[Bug]: non-zero custom status code considered fatal
What happened?
Our sentry reports a few fatal errors, when signing in:
AppException: non-zero custom status code considered fatal, link to server logs: null
We do not get this on our devices, it is visible to us in sentry. We could reproduce it on a GT-I9505 with Android Version 5.0.1. So maybe it is related to old versions of Android?
The error message does not help much to find the issue.
Repro steps
Sign in with Firebase (Phone Auth)
Sign in Realm (JWT)
Error
Version
Channel stable, 3.3.10, on Microsoft Windows [Version 10.0.19045.2364], locale de-AT
What Realm SDK flavor are you using?
MongoDB Atlas (i.e. Sync, auth, functions)
What type of application is this?
Flutter Application
Client OS and version
Android 5.0.1
Code snippets
debugPrint('Verifying phone code');
try {
// Sign the user in (or link) with the credential
firebase.UserCredential firebaseCredential =
await firebase.FirebaseAuth.instance.signInWithCredential(credential);
debugPrint('Signed in with Firebase');
String jwt = await firebaseCredential.user!.getIdToken();
user = await app.logIn(Credentials.jwt(jwt));
_verificationId = null;
notifyListeners();
debugPrint('Signed in with Realm');
} catch (error, stackTrace) {
Sentry.captureException(error, stackTrace: stackTrace);
}
Stacktrace of the exception/crash you're getting
AppException: AppException: non-zero custom status code considered fatal, link to server logs: null
Relevant log output
Verifying phone code
Signed in with Firebase
AppException: AppException: non-zero custom status code considered fatal, link to server logs: null
How does the jwt look?
I do not have those tokens in my logs so I have no token from the crashing device. I could however try to reproduce it on the development environment or provide a working jwt if this helps.
It might help. Remember to strip the signature part before posting the JWTs here.
I'm also interested in how you have setup Audience (aud claim) and Verification Method on the backend (https://www.mongodb.com/docs/atlas/app-services/authentication/custom-jwt/)
So, I can reproduce the issue with an emulator running on 5.0.1.
Here is the content of the jwt:
{
"alg": "RS256",
"kid": "ce9b880f8182dda557f7c70e20e4e370e3d12747",
"typ": "JWT"
}
{
"iss": "https://securetoken.google.com/myapp-dev",
"aud": "myapp-dev",
"auth_time":<PHONE_NUMBER>,
"user_id": "gmeTrLyWFOYGFZxKq1yeLZG8xZt1",
"sub": "gmeTrLyWFOYGFZxKq1yeLZG8xZt1",
"iat":<PHONE_NUMBER>,
"exp":<PHONE_NUMBER>,
"phone_number": "+16505550100",
"firebase": {
"identities": {
"phone": [
"+16505550100"
]
},
"sign_in_provider": "phone"
}
}
For safety reasons I changed the app name, as it is already on production. As said, in works on every modern device we have, and I can reproduce it on a Pixel 5 emulator with API level 22.
Is this information sufficient?
Thanks for the detailed information. This is enough for now. I will get back when I know more
This is more sinister than as such. It has to do with how older versions of android handles TLS certificates. The certificates from https://realm.mongodb.com are signed by lets-encrypt, which is dependent on the root certificate ISRG Root X1.
The list of platform that support the ISRG Root X1 root certificate can be seen here: https://letsencrypt.org/docs/certificate-compatibility/. In particular you need Android >= 7.1.1
There is a dirty work-around to make these certificates work with old Android apps (>= 2.3.6), that you can read about here: https://letsencrypt.org/docs/dst-root-ca-x3-expiration-september-2021/. Unfortunately I don't think this will work with BoringSSL that is used by Dart / Flutter.
Basically you need configure the http client used to trust the root certificate. It is getting a bit late here, so this is just from the top of my head.
final context = SecurityContext();
context.setTrustedCertificatesBytes(isrgRootX1Cert);
final client = HttpClient(context: context);
final appConfig = AppConfig(appId, httpClient: client);
...
Thank your for this throughout information. Strange that no one ran this on an Android verison older than 7.1.1 before apparently.
Is this something you will fix on the end of realm, or shall I build the workaround in my app?
@Navil Yes, I will pin the certificate in the default http client we create, so you don't have to yourself. But the next release is held up by some regressions in realm-core 13, so you might want to do the fix on your side until then.
Thank you very much for the fast help.
I just tested and can confirm, that it works with that change.
@desistefanova Pointed out that this is actually documented here: https://www.mongodb.com/docs/realm/sdk/flutter/app-services/connect-to-app/#connect-using-android-7-or-older. I wasn't aware myself.
There is some discussions wrt #1088, if it should land or not. Since there exists a workaround, so you may have to keep doing this after the next release as well.
closing this since there is a workaround and we have #1088 which is in discussion.
|
2025-04-01T04:35:20.100706
| 2023-08-15T18:21:10
|
1851910587
|
{
"authors": [
"deverlex",
"dotjon0",
"nirinchev"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10236",
"repo": "realm/realm-dart",
"url": "https://github.com/realm/realm-dart/issues/1377"
}
|
gharchive/issue
|
Korean and Japanese characters - queries / full text search
What happened?
We have questions regarding Korean and Japanese languages support around Realm queries / full text search if we may:
Question 1: We have tested Japanese characters in a standard Realm query and this works fine, so Korean and Japanese characters are supported - can you confirm if i.e. Korean and Japanese characters are officially supported (as the documentation does not cover this) or is this a loop hole?
Question 2: Does Realm full text search support Korean and Japanese characters? I.e. at https://www.mongodb.com/docs/realm/sdk/flutter/realm-database/read-and-write-data/#filter-with-full-text-search it states "Tokens can only consist of characters from ASCII and the Latin-1 supplement (western languages). All other characters are considered whitespace. Words split by a hyphen (-) like full-text are split into two tokens." - which suggests Korean and Japanese characters are treated as spaces which is obviously means Korean and Japanese characters are not support? Is this analysis correct? (we have not tested Korean and Japanese yet in full text search)
Question 3: If Realm Full Text Search (in question 2 above) does not support Korean and Japanese characters, are there plans to support this?
Question4: What languages are official supported for Realm (a) queries and (b) full text search? (& what languages work but are not official supported at or (or yet!))?
Many thanks as always!
Repro steps
n/a
Version
1.3
What Atlas Services are you using?
Atlas Device Sync
What type of application is this?
Flutter Application
Client OS and version
13.4.1 macOS
Code snippets
No response
Stacktrace of the exception/crash you're getting
No response
Relevant log output
No response
Realm strings (and queries by extension) use UTF-8, which is why Japanese and Korean characters are supported. When doing equality matches, strings are treated as sequences of bytes, so if you're looking for an exact match, we just compare the byte sequences. It's more complicated with capitalization and accents, but you're lucky that these just don't exist in Japanese and Korean.
Case insensitive queries as well as FTS queries are only supported for ASCII and Latin-1 supplement characters. This means that case insensitive and FTS queries won't produce expected results for languages with letters outside these character ranges. So no, Japanese and Korean are not supported with FTS unfortunately.
Finally, there are no short- or medium-term plans to extend FTS support to other languages unless we're talking about a commercial arrangement that needs to go through your company's account executive. Adding support for additional languages is quite time consuming and will have a non-negligible impact on the binary size, so we need to have a pretty solid business case to invest in this.
If you don't need to run offline queries on your local data, you could use Atlas Search and run queries on Atlas data and use the http-based MongoDB client. I have an example of how to do this in C# here: https://github.com/realm/realm-dotnet-samples/tree/ni/atlas-search/AtlasSearch. Note that this does not go through Realm/Sync at all, so the data you're fetching is a static snapshot and needs to be re-fetched to refresh it. Unfortunately, you won't be able to directly port that to flutter because we don't have a Remote MongoDB Client for Flutter - adding it is tracked in https://github.com/realm/realm-dart/issues/789 among others. That one is on our short-/medium-term plans though, so if using Atlas Search is a valid option for you, then we can take a look at more concrete timelines for when you want to go live vs when we expect that work to land.
I am so sorry @nirinchev I did not come back on this! I remember reading it! So thank you very very much for your feedback and will see what we can do given your very useful input! Thanks again!
It's too early right now, but if having it would be critical for your launch, definitely bring it up with your AE and let them know when you'd need it and they'll work with product and eng to prioritize it against other work.
Thanks @nirinchev we have raised with our AE, CS and product.
Don't support other languages without US, England. Haizzzz
@nirinchev Device Sync is marketed as "Apps that work on the go β online and offline" https://www.mongodb.com/atlas/app-services/device-sync - there are lots of huge gaps with the RQL and FTS of the Realm Flutter/Dart SDK, this being one of them... Atlas Search just does not work 'offline' so the 'app will not work on the go offline'. Just to feedback to the Realm team that it is very disappointing yet another RQL and FTS related feature is not planned in the short or long term.
As explained in the other issue, we don't feel there's sufficient demand for offline FTS functionality that would justify the increased library size and maintenance complexity of the Realm SDK. And as suggested, running FTS queries using Lucene or other 3rd party library outside of Realm would be the recommended workaround.
@nirinchev completely get re FTS, but can it not be supported via RQL as we could make this work?
re: "FTS queries using Lucene or other 3rd party library outside of Realm would be the recommended workaround" - would you kindly be able to give any pointers of any docs, examples, etc so we have some form of direction / staring point re FTS?
Not sure what you mean by "can it not be supported via RQL". Japanese/Korean are supported in RQL as strings in Realm are UTF8 encoded and so are the queries. Since both of these languages are case-insensitive and don't have diacritics, the regular contains/like queries would work just fine as I mentioned in my first reply in this issue. Perhaps I'm misunderstanding something - can you clarify what query you're trying to run against Japanese strings and what error/unexpected behavior you're getting there?
Thanks @nirinchev - perhaps let me rephrase, out of the languages supported by MongoDB Atlas Search at https://www.mongodb.com/docs/atlas/atlas-search/analyzers/language/, which of these languages are supported via (a) RQL, and (b) FTS, within the Realm Flutter/Dart SDK please? So this question is not just limited to Korean and Japanese languages/characters. You also mentioned "more complicated with capitalization and accents" in parsing, which suggests that certain languages are not supported by Realm RQL, thus our question above.
Diacritic-insensitive queries are not supported in any language, although the FTS tokenization process will remove diacritics from characters in the ASCII and Latin-1 supplement range, so for example the diacritic will be removed from Γ© turning it into e, but it won't be removed from Δ (the Turkish yumuΕak ge). So to give you an example
Text
Search term
Operator
Match
allΓ©
alle
TEXT
true
dΓΌΔΓΌn
dugun
TEXT
false
allΓ©
alle
CONTAINS
false
dΓΌΔΓΌn
dugun
CONTAINS
false
Similarly, case insensitive queries are only going to ignore the casing from letters from the ASCII and Latin-1 supplement character range:
Text
Search term
Operator
Match
Hello
hello
TEXT
true
ΠΠ΄ΡΠ°Π²Π΅ΠΉ
Π·Π΄ΡΠ°Π²Π΅ΠΉ
TEXT
false
Hello
hello
CONTAINS[c]
true
ΠΠ΄ΡΠ°Π²Π΅ΠΉ
Π·Π΄ΡΠ°Π²Π΅ΠΉ
CONTAINS[c]
false
ΠΠ΄ΡΠ°Π²Π΅ΠΉ
ΠΠ΄ΡΠ°Π²Π΅ΠΉ
CONTAINS[c]
true
Case-sensitive queries are supported fro all UTF-8 characters. So it's not really language-based, but rather character based and it's also not precise to talk about "supported" vs "not supported" languages since all characters can be stored and queried. It's only when it comes to ignoring the character case that we have limitations about the characters where this actually happens.
Thank you very much for your in-depth explanation @nirinchev, very useful to understand the challenge in front of us.
So effectively the missing parts to get RQL and FTS compatible with all characters from the 43 languages Atlas Search supports and with case-insensitive and case-sensitive support are listed below (i.e. so there is a basic RQL & FTS search function in Realm that both support all common languages globally regardless of case):
RQL: the tokenization process that removes diacritics from characters 'does not exist' (obviously all character sets for this process are missing in this case),
FTS: the tokenization process that removes diacritics from characters 'already exists', but only supports ASCII and Latin-1 character sets, so would need to be extended to support further character sets.
Is this right, hope ive understood correctly and is anything else missing? Just want to get this really clear for coms with our AE etc.
A further question if we may, so with Realm Flutter/Dart SDK around 'FTS': how does RQL differ to FTS? Are you automatically replicating data to a 2nd 'FTS search' Realm local database under the covers?
We don't have estimates for the time required to add additional language support to our query engine. Note that this is not just a matter of doing the work - while in and of itself it's not trivial, it's a problem that has been addressed in multiple products already, so it's not an unknown area. The main issue is related to the binary size of the Realm SDK. Since the Core database is a native module, there are no mechanisms right now for the flutter compiler to strip it from unused code. This means that every user gets the complete library, regardless of whether they use 1 feature or 100. Since app size negatively correlates with download rates we, as a library provider, need to be extra careful about the size of our SDK to ensure our customers don't unnecessarily lose business due to features they don't use.
Regarding how FTS works, Realm builds an index on the property that you define and uses it when executing FTS queries against the dataset. The index is stored alongside the data in the same Realm file.
@nirinchev thank you for further insight and completely get that 'app size negatively correlates with download rates' for 'B2C' mobile apps --- but for 'B2B' enterprise mobile/desktop (especially desktop) applications the app size will highly unlikely impact download/usage rates. Not having the 'enhanced RQL/FTS' for B2B enterprise use cases will likely block B2B enterprise SaaS vendors off from Realm entirely...
So to support both B2C and B2B use cases, perhaps an idea to explore would be to have a yaml configuration file to switch 'enhanced RQL/FTS' on or off? Then we have best of both worlds.
Thanks re insight on how FTS works.
|
2025-04-01T04:35:20.208828
| 2017-08-28T04:34:06
|
253224344
|
{
"authors": [
"Khady",
"freebroccolo"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10237",
"repo": "reasonml-editor/vscode-reasonml",
"url": "https://github.com/reasonml-editor/vscode-reasonml/issues/93"
}
|
gharchive/issue
|
Add option to not use merlin on all files of the project
I don't know if I should open this here or in ocaml-language-server. I think it is more related to this extension.
My problem is that I work on a pretty big ocaml project. And that the repository will become bigger and bigger if the company moves to a monorepo. And when using merlin on all the files of the repo, the memory consumption of merlin is getting very high. I would like to have a configuration option to say that in a given workspace, I want merlin to be launched only on the files that are opened. More like the behavior of emacs/vim/vscode-ocaml.
I can try to work on a PR for this next week if you can lead me to the good part of the code.
I think this is a dupe so I will close it.
You think that it is a duplicate of #94? The features I expect from those two issues are different.
This one is to have a behavior more like emacs/other editors. To not parse the whole workspace at once. But only parse a file when it is opened. Because I don't always need the types for the whole workspace and it would save me a few gigabytes of ram.
#94 is to exclude file that I know are causing problems or not supported by merlin.
Oh, I see. Yeah, I just read the description quickly and I guess I misunderstood what you were after. It would be possible to disable the current behavior where it loads the files all at once but unfortunately that will break the symbol indexing. I guess as long as it is explained somewhere it would be okay though.
|
2025-04-01T04:35:20.219637
| 2016-02-19T15:45:05
|
134896220
|
{
"authors": [
"ferd",
"talentdeficit",
"tsloughter"
],
"license": "apache-2.0",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10238",
"repo": "rebar/rebar3",
"url": "https://github.com/rebar/rebar3/pull/1065"
}
|
gharchive/pull-request
|
give top level plugin providers precedence over default providers
This change allows top level plugins to take the names of default providers. For example, the cuttlefish plugin, which requires control over the release building, will be {default, release} and {default, tar} in order to make this possible.
I have a tentative +1. I'd like to keep maybe 1 day or 2 before merging it just to think of ways this could be bad or good. I guess we can't have tests for that either, right?
What's the order of things if two top-level plugins try to take over the same command?
:( I wanted to write my cuttlefish blog post today.
Order is the order they are defined in rebar.config plugins.
Don't we usually use name order for conflict resolution? Would it make sense to use that here instead so we always pick the same rules?
I'd say no, since it is entirely up to the single rebar.config entry, so in the case like this that you can see all that can have an effect in one place i think using the order defined makes sense.
is the override only for the root app's context, or will redefining compile redefine it for all deps?
For all deps. There isn't a concept of providers per deps, the compile provider is the one that knows about deps, no the other way around.
so if i have an app that depends on a custom compile provider, it's unuseable as a dep if that compile provider doesn't also work with all my deps and the root project?
@talentdeficit yes, providers are not called for apps, they are run on the project. Only hooks may be run per-app/dep. So even if you could override {default, compile} in only that dep it wouldn't mean anything.
Well it does have the interesting side effect that it breaks composability then, no? What works in an app should work when that app is a dep, and this is no longer true?
Yea, that would be the case for for hooks. Someone could have a plugin that overrides some default provider and uses it as a hook and that hook would not use the plugin provider when run as a dep :( Why must people break things!
would it be possible to ignore deps plugins when it comes to downloading, but use them if the root project includes the plugins just in the context of deps that declare use of that plugin?
that way plugins in deps can't break other deps or your project, but a dep that depends on a plugin is still useable if you include the plugin in your project
I'm not sure what you are saying.
if a dep declares a plugin and the plugin is declared in the project rebar.config, use the plugin, otherwise fall back to the built in providers (or error or skip as appropriate if it's a plugin that doesn't attempt to change providers)
Ok, new idea. The issue has been that we can't differentiate a project that is an umbrella/release and one that is an app. The former can never be a dependency. So in this patch I add the option project_plugins. These are never looked at for a dependency, only for the currently being used project.
This can also be used by any plugin a user wants to have available when developing on their app but isn't needed when being used as a dependency. I may use this for neotoma plugin... Since for that I just build the erl file from the peg and commit it and had been placing it in dev profile but that is wonky since then you have a _build/dev/ which is unneeded, you just want the erl file from src.
i like the idea of differentiating between a project and an app
Yeah +1 on that idea. Makes a distinction between necessary and optional plugins.
so is this good to merge now then?
Yeah. We'll need to update docs about that too.
|
2025-04-01T04:35:20.229866
| 2023-07-20T19:42:44
|
1814689434
|
{
"authors": [
"elsid",
"grahamboree"
],
"license": "Zlib",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10239",
"repo": "recastnavigation/recastnavigation",
"url": "https://github.com/recastnavigation/recastnavigation/pull/648"
}
|
gharchive/pull-request
|
Update catch to v3.4.0
To get RangeEquals matcher making code for matching arrays simpler.
Files are copied from https://github.com/catchorg/Catch2/releases/tag/v3.4.0.
catch_amalgamated.hpp is renamed to catch_all.hpp to match existing file.
Thanks!
|
2025-04-01T04:35:20.250415
| 2024-01-24T15:28:21
|
2098520468
|
{
"authors": [
"oleksandr-danylchenko",
"rsimon"
],
"license": "BSD-3-Clause",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10240",
"repo": "recogito/text-annotator-js",
"url": "https://github.com/recogito/text-annotator-js/pull/20"
}
|
gharchive/pull-request
|
Added event listeners cleanup in the React example
Issue
I noticed that in the React example event listeners are only being added to the anno, but never cleaner. So it may lead to the memory leaks on MockStorage re-renders.
Changes made
Added cleanup function for the existing event listeners. Hopefully, it'll help other devs to immediately use the same pattern in their projects too
Oh-oh... The duplicated event listeners addition may be the issue not only for the example...
In my app that has 2 re-renders in the parent component of the TextAnnotator the selectstart event is being processed 2 times:
https://github.com/recogito/text-annotator-js/blob/054ca425b2957c9184565595ff40bfbd5c26a835/packages/text-annotator/src/SelectionHandler.ts#L64
So now, 2 annotations always painted over each other
I realized why it works that way in my app!
Which brings a questions, why the condition to call the createTextAnnotator is if (setAnno) and not the if (setAnno && !anno)?.. π€
I suppose it'll fix the issue with redundant creation of the duplicate annotator instances and event listeners
Good point. Although when the context (which provides setAnno) gets re-mounted, so should the annotation layer I guess. setAnno shouldn't normally change, because its from a state hook in the conetxt. Therefore I believe a cleaner fix would be to destroy anno in a cleanup function that gets returned in the effect hook?
I believe I added an anno.destroy() method meanwhile. That may not yet have existed at the time I started the React binding.
Yeah, destroying the might be the best solution on re-renders. But there's a nuance π
https://github.com/recogito/text-annotator-js/blob/054ca425b2957c9184565595ff40bfbd5c26a835/packages/text-annotator/src/TextAnnotator.ts#L86-L88
I think I can try to work on the destroy method tomorrow. As the creation of duplicated annotations blocks me from moving forward π€·π»ββοΈ
As I won't be able to predictably discard a highlight or delete it
Or, if you already have a vision of how the destroy method should look like for the TextAnnotator, I can proceed with just a ref hack:
You can take a look at what Annotorious does here: https://github.com/annotorious/annotorious/blob/main/packages/annotorious/src/Annotorious.ts
It's basically a matter of housekeeping (like destroying the undo stack, unregistering listeners) plus reverting the DOM manipulations that were made. (Mainly the inserted Canvas elements.) I think both the SelectionHandler and the Highlighter would need their own destroy methods, and then these would be called from the Annotator.
Anyway... I suppose this PR should be reviewed individually. As the change was only for the example and it fixes the duplicated events logs there
Great! And agreed - this PR looks good, independently of the discussion.
Just a quick heads-up: I need to make a few changes to the text annotator & will add a destroy method to the highlightLayer!
Ok, I believe most should be there now. Proper unregistering of listeners + destroying the highlight layer Canvases (not tested though ;-)
Just a quick heads-up: I need to make a few changes to the text annotator & will add a destroy method to the highlightLayer!
Thanks for the heads-up ππ»
Luckily, I haven't started working on the destroy method yet. Yesterday I got sworn into non-anno related tasks
Oh-oh... There might be some bug in the highlighter resing handler now. As the handler gets fired a bazillion time despite the page being fully stating and I'm not even touching anything ποΈ
All those resize calls were coming from the MutationObserver!
And it main issue is the attributes property in the observe config:
After I removed it - the constant handler calls stopper
Ah, I think I see what's going on. The mutation observer triggers a redraw (as it should). But that also resets the Canvas elements' width and height attributes. Yes, removing the attributes will work. But probably not the final solution. In my use case, I need to redraw the canvas as parent elements in the layout change their size due to style prop changes. So I assume the mutation observer has to listen to all events (incl. attribute changes) but then ignore changes to the drawing canvases. Will require a bit more work...
Quick update on this one: the infinite loop is fixed. (Turned out the solution was easier than thought. I didn't have to do a resize + canvas reset. A simple redraw was totally sufficient, and doesn't cause a DOM mutation which would then throw the observer into an infinite loop.)
Sounds great! Thanks!
|
2025-04-01T04:35:20.258437
| 2022-04-05T13:16:11
|
1193137328
|
{
"authors": [
"gano3s",
"santiagolizardo"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10241",
"repo": "reconmap/rest-api",
"url": "https://github.com/reconmap/rest-api/pull/42"
}
|
gharchive/pull-request
|
Added examples into reports
I one more time slightly enhanced the report.
I added a capability to load images from attachments to each vulnerability and also to the project.
1.1 Vulnerabilities and images
1.2 Project attachments (only images for now)
I updated how PoC of vulnerability is propagated into the ouput. I am using MD parser to generate the HTML, but I am not inserting it directly into the PHPWord as in case of description. Instead of it, I use XPath to extract all <code> elements and I parse these manually.
This approach has one benefit, PoC can have more examples and all of them are in the output and parsed differently. The con is, that it strips another elements.
generate doc and template
template.docx
test.docx
Great job @gano3s !
|
2025-04-01T04:35:20.261247
| 2021-07-18T19:33:20
|
947103301
|
{
"authors": [
"YanetABUC"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10242",
"repo": "reconness/reconness-frontend",
"url": "https://github.com/reconness/reconness-frontend/issues/302"
}
|
gharchive/issue
|
Integrate microservides for Marketplace features
Services are in repository https://github.com/reconness/reconness
[x] Install agent from Marketplace
[x] Unistall agent installed from the Marketplace
[x] List agents un Marketplace
List agents in Marketplace
Bug
Agents installed from Marketplace should display a different icon
|
2025-04-01T04:35:20.263129
| 2023-09-15T15:56:54
|
1898704665
|
{
"authors": [
"BrandonGillis",
"TomasVotruba"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10243",
"repo": "rectorphp/rector-doctrine",
"url": "https://github.com/rectorphp/rector-doctrine/pull/230"
}
|
gharchive/pull-request
|
[EventSubscriberInterfaceToAttributeRector] Add rule
Add a rule to fix EventSubscriberInterface deprecation and convert it to #[AsDoctrineListener] (https://github.com/doctrine/DoctrineBundle/pull/1664)
This is my first rector rule and contribution in this project, so this PR will probably need some changes.
Ci needs fixing
CI should be fixed now
Looks good, thank you :+1:
|
2025-04-01T04:35:20.273922
| 2022-06-27T10:30:19
|
1285595404
|
{
"authors": [
"bdattoma",
"jgarciao",
"pablofelix"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10244",
"repo": "red-hat-data-services/ods-ci",
"url": "https://github.com/red-hat-data-services/ods-ci/pull/432"
}
|
gharchive/pull-request
|
Verify Node Failures Are Handled
Signed-off-by: Pablo FΓ©lix EstΓ©vez Pico<EMAIL_ADDRESS>
can you attach the Jenkins job?
Can you test it in jenkins and, after that, run smoke in the same cluster to verify that the cluster's health hasn't been affected by this test?
https://opendatascience-jenkins-csb-rhods.apps.ocp-c1.prod.psi.redhat.com/job/rhods-ci-pr-test/1071
lgtm. Once the conflicts are solve I'll approve
|
2025-04-01T04:35:20.283432
| 2024-09-03T15:36:50
|
2503201000
|
{
"authors": [
"ezio-auditore",
"malayparida2000"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10245",
"repo": "red-hat-storage/ocs-operator",
"url": "https://github.com/red-hat-storage/ocs-operator/pull/2784"
}
|
gharchive/pull-request
|
Bug 2309489:[release-4.17] Fix noobaa-account name to be storageconsumer name
This is a cherry pick of #2777
/hold till #2783 is merged
/bugzilla refresh
/retest
closing in favor of https://github.com/red-hat-storage/ocs-operator/pull/2803
|
2025-04-01T04:35:20.285452
| 2022-05-25T17:07:22
|
1248410289
|
{
"authors": [
"BenamarMk",
"ShyamsundarR"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10246",
"repo": "red-hat-storage/ramen",
"url": "https://github.com/red-hat-storage/ramen/pull/39"
}
|
gharchive/pull-request
|
Bug 2090080: Ignore drpolicy validation when a managed cluster (hosting s3store) is down
This is a ODF 4.10 workaround for BZ-2090080.
In ODF 4.11, we will rework this to distinguish the DRPolicy validation errors.
So far we have two potential solutions:
Have the DRPolicy state to indicate whether a cluster is inaccessible, and another to indicate whether the s3 store is inaccessible.
Just validate that at least one s3store is valid and accessible instead of validating all
Ok, that's fine. It happens only on the failover anyway.
NOTE: Will wait for program ack before merging!
/bugzilla refresh
|
2025-04-01T04:35:20.317494
| 2023-11-29T09:41:27
|
2016188329
|
{
"authors": [
"Goodwillson",
"Seinuh",
"redakker"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10247",
"repo": "redakker/blecker",
"url": "https://github.com/redakker/blecker/issues/63"
}
|
gharchive/issue
|
Presence string is sometimes broken
It happened when the device sent a message like:
1>
{"st
Investigate why, and fix
I just got similar string in log
I just got similar string in log
Thanks for the confirmation.
I'll check this bug as soon as possible.
It looks like the related commit solved this issue.
I've updated the release binary.
@redakker i'm running version 1.11.190 .. wich version got this fix ?
|
2025-04-01T04:35:20.340704
| 2016-09-01T02:39:46
|
174423496
|
{
"authors": [
"jcredding",
"kellyredding"
],
"license": "mit",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10248",
"repo": "redding/mr",
"url": "https://github.com/redding/mr/pull/238"
}
|
gharchive/pull-request
|
Commonize eval'ing subquery blocks, cache built subqueries
This updates subqueries and subquery expressions to commonize the
eval'ing of a block so read models don't have to duplicate the
logic with from subqueries. This allows subqueries to no longer
need to know when they are "complete" because after they are
initialized they should be "complete" (have a read model class).
All Subquery classes now expect to be initialized with a block
which they will instance eval on themselves. This logic was
previously done in the SubqueryExpression but it will also be
needed when using a from subquery on a read model. By instance
eval'ing a block the subquery can now expect that it should have
a valid read model class after its finished initializing. A
subquery knowing its read model class after its initialized is
convenient for from subqueries because a read model will easily
be able to ask a FromSubquery for a record class via its read
model class.
As part of this, it was convenient to update subquery expressions
to cache their subqueries which is a minor performance improvement
for successive query calls on a read model. This makes it so
subqueries and their read model classes don't have to be redefined
on every query call. This required removing the passing of query
params when eval'ing the block to build a subquery. Params can
still be used with query expression blocks. This only removes the
ability to use the params to significantly change a subquery read
model or to modify its as or on sql strings.
@kellyredding - Ready for review.
@jcredding this looks great - I like it! π
|
2025-04-01T04:35:20.350940
| 2023-06-26T13:49:23
|
1774827341
|
{
"authors": [
"rhtap-qe-bots"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10249",
"repo": "redhat-appstudio-qe/devfile-sample-hello-world",
"url": "https://github.com/redhat-appstudio-qe/devfile-sample-hello-world/pull/11301"
}
|
gharchive/pull-request
|
Appstudio update test-component-pac-vmtr
Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization
Pipelines as Code CI/test-component-pac-vmtr-on-pull-request has successfully validated your commit.
StatusDurationName
β
Succeeded
7 seconds
init
β
Succeeded
15 seconds
clone-repository
β
Succeeded
31 seconds
build-container
β
Succeeded
29 seconds
inspect-image
β
Succeeded
27 seconds
deprecated-base-image-check
β
Succeeded
37 seconds
clamav-scan
β
Succeeded
12 seconds
clair-scan
β
Succeeded
20 seconds
sbom-json-check
β
Succeeded
31 seconds
label-check
β
Succeeded
6 seconds
show-sbom
β
Succeeded
6 seconds
show-summary
|
2025-04-01T04:35:20.370995
| 2023-04-21T05:40:44
|
1677848179
|
{
"authors": [
"rhtap-qe-bots"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10250",
"repo": "redhat-appstudio-qe/devfile-sample-hello-world",
"url": "https://github.com/redhat-appstudio-qe/devfile-sample-hello-world/pull/7218"
}
|
gharchive/pull-request
|
Appstudio update test-component-pac-tmuq
Pipelines as Code configuration proposal
Pipelines as Code CI/test-component-pac-tmuq-on-pull-request has successfully validated your commit.
StatusDurationName
β
Succeeded
7 seconds
init
β
Succeeded
16 seconds
clone-repository
β
Succeeded
30 seconds
build-container
β
Succeeded
3 minutes
clair-scan
β
Succeeded
22 seconds
inspect-image
β
Succeeded
23 seconds
deprecated-base-image-check
β
Succeeded
31 seconds
clamav-scan
β
Succeeded
1 minute
sbom-json-check
β
Succeeded
12 seconds
optional-label-check
β
Succeeded
12 seconds
label-check
β
Succeeded
6 seconds
show-summary
β
Succeeded
5 seconds
show-sbom
Pipelines as Code CI/test-component-pac-tmuq-on-pull-request has successfully validated your commit.
StatusDurationName
β
Succeeded
12 seconds
init
β
Succeeded
20 seconds
clone-repository
β
Succeeded
24 seconds
build-container
β
Succeeded
17 seconds
deprecated-base-image-check
β
Succeeded
18 seconds
inspect-image
β
Succeeded
32 seconds
clamav-scan
β
Succeeded
9 seconds
clair-scan
β
Succeeded
8 seconds
sbom-json-check
β
Succeeded
17 seconds
label-check
β
Succeeded
17 seconds
optional-label-check
β
Succeeded
7 seconds
show-summary
β
Succeeded
5 seconds
show-sbom
|
2025-04-01T04:35:20.390556
| 2023-04-28T07:04:31
|
1688018218
|
{
"authors": [
"rhtap-qe-bots"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10251",
"repo": "redhat-appstudio-qe/devfile-sample-hello-world",
"url": "https://github.com/redhat-appstudio-qe/devfile-sample-hello-world/pull/7630"
}
|
gharchive/pull-request
|
Appstudio update test-component-pac-xxji
Pipelines as Code configuration proposal
Pipelines as Code CI/test-component-pac-xxji-on-pull-request has successfully validated your commit.
StatusDurationName
β
Succeeded
7 seconds
init
β
Succeeded
22 seconds
clone-repository
β
Succeeded
1 minute
build-container
β
Succeeded
34 seconds
deprecated-base-image-check
β
Succeeded
3 minutes
clair-scan
β
Succeeded
33 seconds
inspect-image
β
Succeeded
1 minute
clamav-scan
β
Succeeded
37 seconds
sbom-json-check
β
Succeeded
9 seconds
label-check
β
Succeeded
9 seconds
optional-label-check
β
Succeeded
8 seconds
show-sbom
β
Succeeded
5 seconds
show-summary
Pipelines as Code CI/test-component-pac-xxji-on-pull-request has successfully validated your commit.
StatusDurationName
β
Succeeded
7 seconds
init
β
Succeeded
16 seconds
clone-repository
β
Succeeded
29 seconds
build-container
β
Succeeded
19 seconds
inspect-image
β
Succeeded
11 seconds
clair-scan
β
Succeeded
17 seconds
deprecated-base-image-check
β
Succeeded
49 seconds
clamav-scan
β
Succeeded
9 seconds
sbom-json-check
β
Succeeded
17 seconds
optional-label-check
β
Succeeded
18 seconds
label-check
β
Succeeded
7 seconds
show-summary
β
Succeeded
5 seconds
show-sbom
|
2025-04-01T04:35:20.400141
| 2023-04-11T21:10:51
|
1663219580
|
{
"authors": [
"rhtap-qe-bots"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10252",
"repo": "redhat-appstudio-qe/hacbs-test-project",
"url": "https://github.com/redhat-appstudio-qe/hacbs-test-project/pull/1007"
}
|
gharchive/pull-request
|
Appstudio update mvp-test-component
Pipelines as Code configuration proposal
Pipelines as Code CI/mvp-test-component-on-pull-request has successfully validated your commit.
StatusDurationName
β
Succeeded
7 seconds
init
β
Succeeded
17 seconds
clone-repository
β
Succeeded
1 minute
build-container
β
Succeeded
10 seconds
inspect-image
β
Succeeded
18 seconds
clair-scan
β
Succeeded
8 seconds
deprecated-base-image-check
β
Succeeded
1 minute
clamav-scan
β
Succeeded
10 seconds
sbom-json-check
β
Succeeded
10 seconds
optional-label-check
β
Succeeded
10 seconds
label-check
β
Succeeded
8 seconds
show-summary
|
2025-04-01T04:35:20.409980
| 2023-02-28T13:23:44
|
1603070307
|
{
"authors": [
"redhat-appstudio-qe-bot1"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10253",
"repo": "redhat-appstudio-qe/hacbs-test-project",
"url": "https://github.com/redhat-appstudio-qe/hacbs-test-project/pull/102"
}
|
gharchive/pull-request
|
Appstudio update mvp-test-component
Pipelines as Code configuration proposal
Pipelines as Code CI/mvp-test-component-on-pull-request has successfully validated your commit.
StatusDurationName
β
Succeeded
8 seconds
init
β
Succeeded
14 seconds
clone-repository
β
Succeeded
1 minute
build-container
β
Succeeded
12 seconds
deprecated-base-image-check
β
Succeeded
13 seconds
sanity-inspect-image
β
Succeeded
17 seconds
clair-scan
β
Succeeded
56 seconds
clamav-scan
β
Succeeded
11 seconds
sbom-json-check
β
Succeeded
6 seconds
sanity-label-check
β
Succeeded
6 seconds
sanity-optional-label-check
β
Succeeded
5 seconds
show-summary
|
2025-04-01T04:35:20.412092
| 2024-04-15T14:33:40
|
2243846301
|
{
"authors": [
"hugares"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10254",
"repo": "redhat-appstudio/infra-deployments",
"url": "https://github.com/redhat-appstudio/infra-deployments/pull/3568"
}
|
gharchive/pull-request
|
Move stone-stg-host authentication to rh-idp
RH sso is configured as an identity provider already on that cluster. Change the authentication component to use rh-idp folder instead of github which will sync the groups from rover instead of github.
Since all the clusters will use ldap connection to sync rover groups, move the ldap cert to base folder. Also change the default ldap URL to the external facing one and path the internal clusters to use the internal LDAP.
External LDAP requires authentication and internal does not but supports it. To make things more simple, configure both to use authentication.
KFLUXINFRA-132
This PR is not tested by e2e tests, I will by-pass CI
|
2025-04-01T04:35:20.413568
| 2024-11-07T04:25:47
|
2639827591
|
{
"authors": [
"bamachrn",
"manish-jangra"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10255",
"repo": "redhat-appstudio/infra-deployments",
"url": "https://github.com/redhat-appstudio/infra-deployments/pull/4866"
}
|
gharchive/pull-request
|
fix(KFLUXINFRA-777): Adding a readonly variable in install.sh script
Adding a readonly variable for a lock file
/lgtm
/lgtm
|
2025-04-01T04:35:20.415475
| 2022-12-02T11:37:59
|
1472730091
|
{
"authors": [
"amfred",
"bamachrn"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10256",
"repo": "redhat-appstudio/infra-deployments",
"url": "https://github.com/redhat-appstudio/infra-deployments/pull/999"
}
|
gharchive/pull-request
|
Fix monitoring deployment with ArgoCD
This PR is to address errors while monitoring is getting deployed using ArgoCD
Signed-off-by: Bama Charan Kundu<EMAIL_ADDRESS>
/lgtm
/retest
This didn't get into the merge pool; looks like a random timeout failure.
|
2025-04-01T04:35:20.416811
| 2023-09-05T13:27:45
|
1881985185
|
{
"authors": [
"mmalina"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10257",
"repo": "redhat-appstudio/release-service-bundles",
"url": "https://github.com/redhat-appstudio/release-service-bundles/pull/187"
}
|
gharchive/pull-request
|
docs(HACBS-2405): document mocking in task tests
This is the approach that has been agreed upon within the team.
could probably be docs instead of feat but not a big deal
good point, fixed
|
2025-04-01T04:35:20.421953
| 2020-07-08T09:47:26
|
653152695
|
{
"authors": [
"raffaelespazzoli",
"tylerauerbeck"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10258",
"repo": "redhat-cop/group-sync-operator",
"url": "https://github.com/redhat-cop/group-sync-operator/pull/27"
}
|
gharchive/pull-request
|
Update key used to validate keycloak password
It looks like while doing validation of the credentials for keycloak, that secretUsernameKey is used for validating both the username and password. This PR changes the password check to use secretPasswordKey which seems more appropriate.
LGTM
|
2025-04-01T04:35:20.423941
| 2022-06-01T08:51:49
|
1255407972
|
{
"authors": [
"garethahealy",
"jfilipcz"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10259",
"repo": "redhat-cop/helm-charts",
"url": "https://github.com/redhat-cop/helm-charts/pull/266"
}
|
gharchive/pull-request
|
Bump Gitops operator to v1.5.2
What is this PR About?
Version bump to the latest
How do we test this?
Provide commands/steps to test this PR.
cc: @redhat-cop/day-in-the-life
@jfilipcz ; chart version needs bumping for linting to pass
@jfilipcz ; chart version needs bumping for linting to pass
Right, I've just pushed chart version bump the very minute you posted a comment:)
|
2025-04-01T04:35:20.438097
| 2021-09-03T12:30:32
|
987724243
|
{
"authors": [
"chetan-rns",
"iam-veeramalla",
"wtam2018"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10260",
"repo": "redhat-developer/gitops-operator",
"url": "https://github.com/redhat-developer/gitops-operator/pull/210"
}
|
gharchive/pull-request
|
Update argocd-operator version
What type of PR is this?
/kind cleanup
What does this PR do / why we need it:
Pull the latest changes from argocd-operator. Since the upstream operator has a new directory layout, the import paths are updated. Also, the function signature of the Reconcile() is updated according to the latest version of controller-runtime
Bump k8s dependencies
Have you updated the necessary documentation?
[ ] Documentation update is required by this PR.
[ ] Documentation has been updated.
Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:
[x] Unit Test
[x] E2E Test
How to test changes / Special notes to the reviewer:
Run the operator locally make run
Check if the default instance, kam, and backend resources are created
Deploy a sample application
/test v4.7-e2e
LGTM !! @wtam2018 Can you please take a look at the PR ?
/lgtm
/approve
/approve
|
2025-04-01T04:35:20.453083
| 2020-11-23T08:57:30
|
748607591
|
{
"authors": [
"codecov-io",
"sudhirverma"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10261",
"repo": "redhat-developer/vscode-tekton",
"url": "https://github.com/redhat-developer/vscode-tekton/pull/460"
}
|
gharchive/pull-request
|
updated tkn version
Fix: #458
Codecov Report
Merging #460 (64c6624) into master (9d166d8) will not change coverage.
The diff coverage is n/a.
@@ Coverage Diff @@
## master #460 +/- ##
=======================================
Coverage 67.29% 67.29%
=======================================
Files 74 74
Lines 4904 4904
Branches 850 864 +14
=======================================
Hits 3300 3300
Misses 1604 1604
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 9d166d8...64c6624. Read the comment docs.
|
2025-04-01T04:35:20.482207
| 2022-04-14T09:07:16
|
1204255637
|
{
"authors": [
"mvalarh",
"yossig-aquasec"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10262",
"repo": "redhat-openshift-ecosystem/community-operators-prod",
"url": "https://github.com/redhat-openshift-ecosystem/community-operators-prod/issues/1089"
}
|
gharchive/issue
|
Failed to pull kind-registry:5000/test-operator/catalog:v4.10s
Hi, we are getting the following failure with our pr:
https://github.com/redhat-openshift-ecosystem/community-operators-prod/pull/1088
test orange / Deploy o7t (v4.10-db)
fatal: [localhost]: FAILED! => changed=true
cmd: podman pull kind-registry:5000/test-operator/catalog:v4.10s
delta: '0:00:00.121946'
end: '2022-04-14 05:56:25.753183'
msg: non-zero return code
rc: 125
start: '2022-04-14 05:56:25.631237'
stderr: |-
Trying to pull kind-registry:5000/test-operator/catalog:v4.10s...
Error: initializing source docker://kind-registry:5000/test-operator/catalog:v4.10s: reading manifest v4.10s in kind-registry:5000/test-operator/catalog: manifest unknown: manifest unknown
stderr_lines: <omitted>
stdout: ''
stdout_lines: <omitted>
PLAY RECAP *********************************************************************
localhost : ok=211 changed=27 unreachable=0 failed=1 skipped=278 rescued=0 ignored=1
Error: Process completed with exit code 2.```
Hi, any update?
This is fixed in production
|
2025-04-01T04:35:20.515505
| 2023-01-09T19:57:59
|
1526231601
|
{
"authors": [
"0xgeert",
"jsommer1738",
"leibale"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10264",
"repo": "redis/node-redis",
"url": "https://github.com/redis/node-redis/issues/2370"
}
|
gharchive/issue
|
Add option returnBuffers=true to the various ScanIterators
As asked here
it seems the various ScanIterators don't support returnBuffers: true
This would be a useful feature
I would like this to be added to the GET command as well. Why is the option to return buffers not globally available?
@0xgeert this feature is already implemented in v5, stay tuned.. ;)
@jsommer1738 you can use "return buffers" with any command:
await client.get(
commandOptions({ returnBuffers: true }),
'key'
); // Buffer | null
|
2025-04-01T04:35:20.537088
| 2018-10-23T14:46:37
|
373040770
|
{
"authors": [
"bkoroliuk-amplify",
"mrniko"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10265",
"repo": "redisson/redisson",
"url": "https://github.com/redisson/redisson/issues/1687"
}
|
gharchive/issue
|
Default values for local cache in RedissonSpringLocalCachedCacheManager
What are default values for the mentioned below properties?
Are these values from LocalCachedMapOptions::defaults()?
I see that local caches work, but only ttl, idle and maxSize are defined.
localCacheOptions:
evictionPolicy: "LRU"
reconnectionStrategy: "CLEAR"
syncStrategy: "UPDATE"
writeMode: "WRITE_THROUGH"
cacheSize: 1000
timeToLiveInMillis: 300000
maxIdleInMillis: 300000
What are default values for the mentioned below properties?
evictionPolicy = NONE,
reconnectionStrategy = NONE,
syncStrategy = INVALIDATE
writeMode = WRITE_THROUGH
cacheSize = 0
timeToLiveInMillis = 0
maxIdleInMillis = 0
Are these values from LocalCachedMapOptions::defaults()?
No, seems config instance had been changed further in code.
Oh, I see, found it
|
2025-04-01T04:35:20.550040
| 2020-02-07T10:05:43
|
561538994
|
{
"authors": [
"ouyangshixiong"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10266",
"repo": "redisson/redisson",
"url": "https://github.com/redisson/redisson/pull/2578"
}
|
gharchive/pull-request
|
PR for issue #2555
Follow this discussion
I create this PR. Keep APIs the same, modify the implementation of persist method.
pls review my code, thanks.
Test case for this feature is here.
Sure, I will try.
|
2025-04-01T04:35:20.567954
| 2015-04-02T21:14:03
|
66012675
|
{
"authors": [
"jeroenpraat"
],
"license": "mit",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:10267",
"repo": "redmatrix/redmatrix",
"url": "https://github.com/redmatrix/redmatrix/issues/120"
}
|
gharchive/issue
|
Clone-synchronizing of profile-information and -pictures not working.
From @jmankiewicz on April 20, 2014 13:8
As the title says:
When I change my profile or add a new one the changes don't get synced to the other hosts of my channel. Sychronisation of messages and connections work flawlessly.
Tested with current HEAD on multiple instances. As I'm not knee-deep into Zot and red's synchronisation, I would be gratefully for any hint were to start hunting for debug-information.
Regards
JΓΆrn
Copied from original issue: friendica/red#419
From @ghost on April 20, 2014 16:3
It doesn't look like a bug so much as being completely missing.
We build the sync packet in, well build_sync_packet() and then pick it up at the other end in process_channel_sync_delivery() both in include/zot.php. build_sync_packet() is called at the point any changes are made (see, eg, mod/settings.php).
After a quick look, there's no bug, that bit simply hasn't been written at all.
From @jmankiewicz on April 20, 2014 16:43
No prob. I'll have a look if its within my current scope of knowledge of Reds inner workings. If not, I'll bother you with question. Red is awsome, no kidding. I'd be glad to help out.
From @jmankiewicz on April 20, 2014 16:30
Ok. I assume correctly an implementation would be appreciated? I will be quite busy the next two weeks but I'll try to give it a shot.
From @friendica on April 20, 2014 21:14
This one was a close call. We don't synchronise all your content - we only synchronise the bits that are essential for your identity and communication with your connections. Profiles are easily regenerated if your hub provider goes down - though they are closely aligned with your identity.
We probably will synchronise all of your content at some point but there are some significant technical hurdles in doing this - and I doubt that it will be automatic. We'll need to fire off a long-running process to export/import files and photos. That said, profile and collections are relatively easy to pull off and those are the next logical things to work on in order to keep clones up to date.
From @ghost on April 20, 2014 16:32
Yeah, it seems to have been overlooked rather than deliberately missed. I meant "not a bug" as in "it needs writing rather than fixing" rather than "not desirable".
From @ghost on April 21, 2014 3:1
Just for the sake of getting it written down in an issue...
The first ever clone was created on 6th June last year. That's over ten months and this is the first time anyone has even noticed profiles aren't synced. I'm not saying it's not desirable, just people's expectations haven't been what you'd think.
The missing things people have noticed most often are bookmarks, webpages and filestorage (in that order by number of times they've been brought up).
That's probably not the best order to tackle these things in - because webpages and filestorage have got lots of gotchas - but from the issues people have raised so far, they're the ones that would have the biggest impact.
From @jmankiewicz on April 21, 2014 12:46
I think when we both talk of people, we have different groups in mind.
Currently, we are dealing with an audience mostly comprised of enthusiasts and technophilic. For these people setting up a profile is a task of mere minutes. And yes, in this scope you're totally right and I agree: They won't care. But these people are used to be at the frontier. What about the others?
I've administered several message-boards for ten years now and from my experience I dare say that the average day user will see things quite different. Take my word: It's amazing how many people today still need external help for the silliest, little changes in their profiles. Or how much people cannot operate the message-board anymore when you move a button one inch left and change the style a little.
And as far as I understood red is not exclusively developed for the technophile audience, so we will have to take this into consideration, too. It's surely no "implement this or we'll die"-feature but - in my opinion - it certainly is a "must have" at some point in near future if we want red to be a viable solution for the big audience.
That is what I meant, why Mr. John Doe might consider the feature broken. That red's working fine for my everyday use already is not the point. I want to spread it's usage to all of my friends not only the technically educated ones. ;-)
From @jmankiewicz on April 20, 2014 22:6
IMHO: For total synchronization we will have to revisit our DB storage/structure (to name it: get a uniform scheme for the essential id/guid/etc. information Zot needs) and take measures to ensure that we don't get overly redundant storage in the matrix and synchronize only the changed parts. And the methods in zot.php will need to become agnostic of the tables they transport, so we just use one well tested sync function for everything. Otherwise we'll end up with a huge and evergrowing mess of specialized sync-functions and their changing bugs and typos. So this is something for the future.
Right now, as you said, it should be possible to sync the profile-informations as it is somewhat unexpected that we loose all of that information. I would say most people would be okay with loosing their settings if they don't have to rebuild and reassign their carefully crafted profiles again to all of their contacts. The non-digital-natives out there will probably consider the feature broken until we at least preserve profile information.
From @ghost on April 21, 2014 13:24
Yeah, our present user base largely isn't technical, it just thinks it is. I have exactly the same problems with self-acclaimed "geeks" as I did back in the Ikonboard and Invision days of "normal" users, except it's worse when they think they're technical users. It's still a good sample.
90% of people don't have a profile at all nevermind one to clone.
But either way, we ultimately need to do it all, that's just the order they're noticing it in. Bookmarks, I think, are the odd one out - I suspect that one only gets noticed because some of them are incidentally (rather than explicitly) cloned, and having them partially there makes the absence of the others more glaring.
From @friendica on April 21, 2014 21:53
I'll put profiles and collections changes into the list of things to get done for clone syncing. As I said earlier - profiles was a close call and didn't make it in because it was a nice to have but not as urgent as some of the other things. Settings needed to be done earlier on because there were some settings related things that were critical to preserving basic channel configuration - I forget which ones at the moment. Once we had the framework for those critical settings, it took nothing extra to sync all of them.
While I'm thinking about the topic - we aren't doing a "sync" per se, we're pushing the most recent manually changed things. Ultimately we'll need timestamps on the pconfig table and provide a real sync instead of pushed manual changes. Else we could get into a situation where somebody loads a channel on a new site with a thumb drive from an old export file and this could adversely impact a channel which currently has much newer info.
We've got enough work overall to keep a few hundred devs busy but we don't have a few hundred devs, so we just keep picking off whatever bits we can.
@jmankiewicz This issue is closed because Redmatrix evolved into Hubzilla. When this is still an issue in the most recent version of Hubzilla, please recreate this issue over there. We're sorry for any inconvenience this will maybe give you.
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.