added
stringdate 2025-04-01 04:05:38
2025-04-01 07:14:06
| created
timestamp[us]date 2001-10-09 16:19:16
2025-01-01 03:51:31
| id
stringlengths 4
10
| metadata
dict | source
stringclasses 2
values | text
stringlengths 0
1.61M
|
|---|---|---|---|---|---|
2025-04-01T04:36:02.631949
| 2022-08-11T21:07:18
|
1336491631
|
{
"authors": [
"srerickson",
"zimeon"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12350",
"repo": "zimeon/ocfl-py",
"url": "https://github.com/zimeon/ocfl-py/issues/102"
}
|
gharchive/issue
|
good-storage-roots/reg-extension-dir-root is not valid
One of the fixtures, good-storage-roots/reg-extension-dir-root, is not valid as expected because the storage layout doesn't conform with the declared extension.
the sha256 of the object id ark:123/abc is a4781783dcec... not b02c71b67afe...
the declared layout extension requires lowercase hex strings but uppercase are used.
I think the correct storage location for ark:123/abc is a47/817/83d/cec/ark%3a123%2fabc
Thank you @srerickson ! I agree on both counts.
I think I got this digest wrong because I did:
> echo "ark:123/abc" | shasum -a 256
b02c71b67afeeb7adcf12259e94f909bdc9c95e29c9f180f466e10a96420f6f4 -
when I should have done:
> echo -n "ark:123/abc" | shasum -a 256
a4781783dceceffe7af9af3fc4299cc6c93dc87754d6353d31a9e44e8a2838a0 -
or
> python -c 'import hashlib; print(hashlib.sha256(b"ark:123/abc").hexdigest())'
a4781783dceceffe7af9af3fc4299cc6c93dc87754d6353d31a9e44e8a2838a0
Example file dir and name fixed but I note there isn't yet code in ocfl/store.py so that ocfl-validate.py will check any of this
|
2025-04-01T04:36:02.662524
| 2023-02-07T07:22:23
|
1573813324
|
{
"authors": [
"wasp604"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12351",
"repo": "zippity21/Stardew_Valley_Regression_Mod",
"url": "https://github.com/zippity21/Stardew_Valley_Regression_Mod/issues/78"
}
|
gharchive/issue
|
Ability to pee on plants instead of using watering can (enhancement request)
It would be cool to be able to water plants by peeing on them, and also possibly to add fertiliser by pooing on them.
Looks like peeing on the ground already waters it! Cool!
|
2025-04-01T04:36:02.672707
| 2023-06-28T10:31:56
|
1778668059
|
{
"authors": [
"muhlemmer"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12352",
"repo": "zitadel/zitadel",
"url": "https://github.com/zitadel/zitadel/pull/6111"
}
|
gharchive/pull-request
|
feat(v2): implement OIDC API
Definition of Ready
[ ] I am happy with the code
[ ] Short description of the feature/issue is added in the pr description
[ ] PR is linked to the corresponding user story
[ ] Acceptance criteria are met
[ ] All open todos and follow ups are defined in a new ticket and justified
[ ] Deviations from the acceptance criteria and design are agreed with the PO and documented.
[ ] No debug or dead code
[ ] My code has no repetitions
[ ] Critical parts are tested automatically
[ ] Where possible E2E tests are implemented
[ ] Documentation/examples are up-to-date
[ ] All non-functional requirements are met
[ ] Functionality of the acceptance criteria is checked manually on the dev system.
cc @livio-a
|
2025-04-01T04:36:02.673846
| 2021-09-10T12:23:24
|
993185809
|
{
"authors": [
"ziu1986"
],
"license": "CC-BY-4.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12353",
"repo": "ziu1986/CTSM-Norway-Documentation",
"url": "https://github.com/ziu1986/CTSM-Norway-Documentation/pull/1"
}
|
gharchive/pull-request
|
Include necessary information to build WRF-CTSM
An initial draft on how to set up WRF-CTSM on FRAM.
This also includes tips on ESMF setup and links to the experimental dotcime branch.
Related issues: #16 and #26
@irismuz and @gunnartl please have a look.
|
2025-04-01T04:36:02.682993
| 2024-04-29T15:15:21
|
2269309811
|
{
"authors": [
"skarab42",
"zkat"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12354",
"repo": "zkat/miette",
"url": "https://github.com/zkat/miette/pull/372"
}
|
gharchive/pull-request
|
fix(docs): alt attribut for single-line-example.png
The white line breaks in the alt attribute prevented the single-line-example.png image from being displayed.
you'll want to run cargo make readme to sync this up with readme.md
you'll want to run cargo make readme to sync this up with readme.md
thanks for the tip, I'm new to Rust
you're fine. Not everyone actually does things this way :)
|
2025-04-01T04:36:02.688159
| 2022-10-28T12:52:15
|
1427220831
|
{
"authors": [
"str4d",
"tarcieri"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12355",
"repo": "zkcrypto/ff",
"url": "https://github.com/zkcrypto/ff/pull/94"
}
|
gharchive/pull-request
|
Add associated constants of type Self to Field and PrimeField
We now require that the type implementing Field, and its particular values for these constants, can be constructed in a const context. Once upon a time this might have been onerous, but it should now be a reasonable requirement given our MSRV of 1.56.0.
Closes zkcrypto/ff#87.
Prior to merging this, I want to confirm that the major implementors of the Field trait are able to implement these associated constants. Here is the list of crates I know about, and which ones I have confirmed can migrate to providing associated constants:
[ ] bls12_381
[ ] jubjub
[x] pasta_curves
[ ] TODO: find more crates
@str4d the @RustCrypto crates are all fine. They support both const fn constructors and arithmetic on their respective FieldElement and Scalar types.
I confirmed that blstrs implements the current trait methods using constants, so can migrate to associated constants. And AFAICT ec-gpu-gen only uses the representation parts of the ff traits to shuttle field elements between CPU and GPU; it doesn't actually generate code that implements Field or PrimeField. So I think I'm satisfied that this PR is fine.
Rebased on main to fix merge conflicts and address @ebfull's comment.
Force-pushed to fix a documentation lint.
|
2025-04-01T04:36:02.728331
| 2015-11-11T18:31:44
|
116393218
|
{
"authors": [
"MaicomMR",
"culebron",
"glangford",
"zlsa"
],
"license": "mit",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12356",
"repo": "zlsa/atc",
"url": "https://github.com/zlsa/atc/issues/235"
}
|
gharchive/issue
|
[Feature Request] SID show/hide button
Hi all, I have been thinking about a SID button to enable or disable the dashed lines and names of SID, take a look on example.
SHOW:
HIDE:
I think it should be one of the buttons in the bottom row.
Probably should look like an aircraft taking off icon which is used in airports.
Here is a new test:
On bottom bar [test icon 1]:
icon[icon 1]:
On bottom bar [test icon 2]:
icon[icon 2]:
The airplane taking off icon looks great @MaicomMR - another possibility would be to create a button image for a group of settings (like a gear icon). @tedrek was experimenting with that idea.
That could contain additional things in the future like Variable wind (on/off), and any other options. eg.
https://commons.wikimedia.org/wiki/Category:Black_gear_icons
I like the look of the airplane taking off the best, but I'm not sure which is better long term.
If you ask my opinion, I would put this button on the left, and next to it I'd put all actions/switches that are related to ATC activities, and may be needed often. I guess ATC may quite often want to switch between clean view and "cluttered".
What's important is that these switches should be easy to switch back and forth without irreversible or expensive consequences. (E.g. change airport is irreversible.) STARs will come too, and should also be near SID toggle.
Other buttons are meta-game functions (change airport), actions that don't happen often but still need to be visible and easy accessible: multiple airports are what attracts a newcomer.
In #240 I added both buttons to toggle SIDs and restricted areas. Check that out :) Open that branch and see how it works. The canvas are redrawn not immediately, and this gives it a special analog device feeling. :)
This can be closed now.
|
2025-04-01T04:36:02.730269
| 2016-04-10T03:22:14
|
147188186
|
{
"authors": [
"Fechulo",
"jpeterson1346"
],
"license": "mit",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12357",
"repo": "zlsa/atc",
"url": "https://github.com/zlsa/atc/issues/435"
}
|
gharchive/issue
|
Help updating KJFK
I have updated the airport's SIDS, approaches, traffic, fixes, and some other things but when I go to test them locally, everything loads fine (as far as I know) except I cannot see anything other than range rings on the display. All other airports display fine.
The problem is that the altitude for the STAR's is not being specified. You need to add the altitude just like you did with the PARCH ONE arrival. Also, I don't see any point in keeping the NORTH, SOUTH, WEST and EAST departures, as these were only temporary.
Thank you, I can now continue working on it
|
2025-04-01T04:36:02.754185
| 2018-08-10T21:47:28
|
349666753
|
{
"authors": [
"QuentinPerez",
"keinohguchi",
"steeve"
],
"license": "apache-2.0",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12358",
"repo": "znly/docker-protobuf",
"url": "https://github.com/znly/docker-protobuf/pull/38"
}
|
gharchive/pull-request
|
Dockerfile: Add mwitkow/go-proto-validators
Add support for --govalidators_out option, as --govalidators_out=gogoimport=true:.
Thanks @QuentinPerez for :+1:. Looking forward to the merge as well as the docker image on dockerhub, so that I can replace the image from my local one to the public one on dockerhub.
Hi @QuentinPerez, I've added additional commit to include the validator protobuf file into the image.
By the way, here is the image I'm using for our build process, which contains those two commits:
https://hub.docker.com/r/keinohguchi/protoc/
Thx @keinohguchi, cc @steeve
Thanks @QuentinPerez and @steeve! I'll use my private docker image for our use but love to see it in your dockerhub, so that we're in sync with the upstream.
Thank you so much for sharing this usuful container!
Seems @steeve is busy with something. I'll go with my special image for now but looking forward to see the merge as well as the new image with the go-proto-validators support.
Great job, @QuentinPerez and @steeve!
Sorry for the lag, I was on vacation, thanks @QuentinPerez for keeping up !
|
2025-04-01T04:36:02.785767
| 2024-04-12T04:16:12
|
2239028593
|
{
"authors": [
"shaunco",
"zombiezen"
],
"license": "ISC",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12359",
"repo": "zombiezen/go-sqlite",
"url": "https://github.com/zombiezen/go-sqlite/issues/93"
}
|
gharchive/issue
|
INSERT multiple VALUES?
SQLite 3.7.11 added support for INSERT to have multiple rows via the VALUES clause, but I can't figure out how to that in this package.
When directly preparing a statement, the resulting Stmt has column-index based setters and Named arg based setters, but neither allow for specifying a row number (and the underlying structures are 1-dimensional).
When using sqlitex Execute or ExecuteTransient functions, the ExecOptions only has 1-dimensional Args and Named fields.
I can generate a giant SQL statement directly with no arguments that has multiple rows in VALUES and call ExecuteTransient, but it doesn't benefit from being a prepared statement and I need to do it millions of times.
Am I missing something here?
PS. Fantastic work on this! Really nice to not need CGO!
When directly preparing a statement, the resulting Stmt has column-index based setters and Named arg based setters, but neither allow for specifying a row number (and the underlying structures are 1-dimensional).
When using sqlitex Execute or ExecuteTransient functions, the ExecOptions only has 1-dimensional Args and Named fields.
Your understanding is correct and matches what SQLite provides.
I can generate a giant SQL statement directly with no arguments that has multiple rows in VALUES and call ExecuteTransient, but it doesn't benefit from being a prepared statement and I need to do it millions of times.
You can do an INSERT with parameters too:
INSERT INTO foo ( "id" ) VALUES (:row1_id), (:row2_id), (:row3_id);
Am I missing something here?
A couple things, perhaps:
You can reuse the same prepared statement with Stmt.Reset and Stmt.ClearBindings to run a single-row insert multiple times. This avoids having to re-parse the SQL statement, and is a fairly common way of inserting a lot of data at once.
If you are performing data modification outside of an explicit transaction (autocommit mode), SQLite will wrap each statement in an implicit transaction. By default, this has the side-effect of performing a full fsync on each commit, which will be very slow. You likely want to start a transaction, perform all your inserts, then commit the transaction.
Much appreciated! The INSERT example you provided would only work with a single column data, as far as I can see there is no way to replace :row1_id with multiple columns worth of data.
|
2025-04-01T04:36:02.801453
| 2022-09-14T21:27:46
|
1373606304
|
{
"authors": [
"JD-Robertson",
"zookzook"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12360",
"repo": "zookzook/elixir-mongodb-driver",
"url": "https://github.com/zookzook/elixir-mongodb-driver/issues/144"
}
|
gharchive/issue
|
Periodic timeouts if :timeout is less than or equal to the StreamingHelloMonitor heartbeat frequency
I've been debugging an issue where a microservice would periodically report an error like:
Mongo.MongoDBConnection (#PID<0.13156.11>) disconnected: ** (DBConnection.ConnectionError) client #PID<0.13152.11> timed out because it queued and checked out the connection for longer than 4000ms\n\n#PID<0.13152.11> was at location:\n\n :prim_inet.recv0/3\n (mongodb_driver 0.9.1) lib/mongo_db_connection/utils.ex:100: Mongo.MongoDBConnection.Utils.recv_data/3\n (mongodb_driver 0.9.1) lib/mongo_db_connection/utils.ex:20: Mongo.MongoDBConnection.Utils.post_request/3\n (stdlib 3.15) timer.erl:166: :timer.tc/1\n (mongodb_driver 0.9.1) lib/mongo/mongo_db_connection.ex:310: Mongo.MongoDBConnection.execute_action/4\n (mongodb_driver 0.9.1) lib/mongo/mongo_db_connection.ex:252: Mongo.MongoDBConnection.handle_execute/4\n (db_connection 2.4.2) lib/db_connection/holder.ex:354: DBConnection.Holder.holder_apply/4\n (db_connection 2.4.2) lib/db_connection.ex:1364: DBConnection.run_execute/5\n"
The service was specifying a timeout of 4000ms for all Mongo operations, but none of those operations was taking more than a few milliseconds to complete. Yet we were still seeing periodic timeouts, and operations that were in progress when one of those timeouts fired could fail with a connection closed exception.
Experimentation showed that a timeout >10s avoided the issue. After some more digging around I determined that the StreamingHelloMonitor module was using the timeout passed in from the service for its connection even though that timeout was smaller than the hardcoded heartbeat interval and would always result in a timeout.
I suspect I can just use a longer timeout for my use case to work around this, but long-term it would be good if the monitor either overrode the timeout for its connection or else made the heartbeat frequency configurable.
I think, it is time to refactor the timeout stuff. Thanks for reporting!
Thanks! I upped the timeouts we were using to a safe range today and if fixed the issue on our end.
We are 13 commits behind the head right now and entering a stabilization phase so I'm going to hold off on pulling in this change for a couple weeks. However, I hacked up a local build and verified that your fix solves the issue I was seeing in my test setup.
Ok, so we found an issue with increasing the timeout and I'm trying to pull in the latest driver changes. It looks like I can no longer connect to MongoDB 4.4. I get an error like:
"Mongo.MongoDBConnection (#PID<0.5740.0>) failed to connect: ** (Mongo.Error) \"helloOk\" had the wrong type. Expected bool, found int 14"
Things work fine with Mongo 5 or 6.
Is that expected? Is there a new setting I need to update?
Is that expected? Is there a new setting I need to update?
No, it isn't. I think it is a bug. I think the specification regarding the handshake is little confusing. The specification mixes helloOk: 1 and helloOk: true. I need to change the value to true.
I think I'm still seeing an issue. I'm not sure how I missed this with my initial validation, but there are two overloads of StreamingHelloMonitor.hello_command, one which takes a version and one which does not. The timeout is not modified in StreamingHelloMonitor.hello_command/3, and when that is called with the timeout set to 4s I still see timeouts.
Correction: The call to Mongo.exec_hello/2 which results in a timeout is coming from Monitor.get_server_description
Apologies, my initial assessment was incorrect. The issue I'm seeing is that after the initial hello command is sent the StreamingHelloMonitor.get_server_description function will call Mongo.exec_more_to_come. The opts bundle for this call has reverted back to the default timeout which is not sufficient for the long-running more_to_come operation, resulting in timeouts.
Thanks for the detailed reporting. I will check the more_to_come call as soon as possible and provide a fix. I wonder why you decrease the timeout to 4s? What was the rational for it?
I don't know why the timeout is 4s. This component pre-dates my time on the project and the responsible parties are no longer around. However, when we tried to increase it back to 15s a lot of things started failing with no clear explanation as to why. Unlocking that puzzle is on my todo list.
I fixed the timeout issue in the StreamingHelloMonitor.get_server_description function. Feel free to test it (master branch). If everything works like expected, then it is time to release a new version.
I've had the latest changes running for around an hour and everything looks good. Thanks for the help.
|
2025-04-01T04:36:02.808606
| 2016-09-01T07:45:35
|
174457703
|
{
"authors": [
"camallen",
"marten"
],
"license": "apache-2.0",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12361",
"repo": "zooniverse/Panoptes",
"url": "https://github.com/zooniverse/Panoptes/pull/1933"
}
|
gharchive/pull-request
|
unblock workers that counting changes introduced.
Temp for to skip long project counts and modified the rate limiting and the queue priorities to ensure high priority jobs run before the counts.
Review checklist
[ ] First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
[ ] If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
[ ] If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
[ ] Are all the changes covered by tests? Think about any possible edge cases that might be left untested.
Not sure about that test failure. Seems like I made something randomly fail with my last PR?
LGTM
Right - agree they should not be caused by this PR. I'll merge this to get the fix out right now.
I'll have a look at those weird tests.
|
2025-04-01T04:36:02.811712
| 2018-05-15T16:35:49
|
323295337
|
{
"authors": [
"camallen",
"marten"
],
"license": "apache-2.0",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12362",
"repo": "zooniverse/Panoptes",
"url": "https://github.com/zooniverse/Panoptes/pull/2765"
}
|
gharchive/pull-request
|
upgrade structure.sql with secure schema paths
Update the postgres structure doc from output of pgdump with a version post 9.4.17 (most of our dev envs).
This change reflects the comments i made in https://github.com/zooniverse/Panoptes/pull/2759#issuecomment-389215000 and may supersede #2759 if we want to keep the code and database version in sync.
Review checklist
[ ] First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
[ ] If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
[ ] If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
[ ] Are all the changes covered by tests? Think about any possible edge cases that might be left untested.
Okay, I've finally managed to get them running side by side. I get the same schema when I run db:migrate so let's merge this.
|
2025-04-01T04:36:02.814317
| 2018-05-21T12:29:43
|
324898618
|
{
"authors": [
"marten",
"shaunanoordin"
],
"license": "apache-2.0",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12363",
"repo": "zooniverse/Panoptes",
"url": "https://github.com/zooniverse/Panoptes/pull/2777"
}
|
gharchive/pull-request
|
Fix login submit
Fixes #2776
Review checklist
[ ] First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
[ ] If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
[ ] If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
[ ] Are all the changes covered by tests? Think about any possible edge cases that might be left untested.
Nice! This is a really simple fix, and I actually like this new design. π
|
2025-04-01T04:36:02.943753
| 2022-02-15T22:19:56
|
1139272919
|
{
"authors": [
"FlappiTomic"
],
"license": "CC-BY-4.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12364",
"repo": "zowe/docs-site",
"url": "https://github.com/zowe/docs-site/pull/2036"
}
|
gharchive/pull-request
|
1.27.2 Hotfix doc changes
Your checklist for this pull request
π¨Please review the guidelines for contributing to this repository.
[ ] If the changes in this PR is part of the next future release, make this pull request against the docs-staging branch which will be published at the next release boundary. If the changes in this PR are part of the current release, use the default base branch, master. For more information about branches, see https://github.com/zowe/docs-site/tree/master#understanding-the-doc-branches.
[ ] If this PR relates to GitHub issues in docs-site or other repositories, please list in Description, prefixed with close, fix or resolve keywords.
Description (including links to related git issues)
Please describe your pull request.
:heart:Thank you!
Sorry, caught a typo that I missed earlier
Good catch! I delivered the typo fixes.
|
2025-04-01T04:36:02.945313
| 2019-05-01T14:30:50
|
439184318
|
{
"authors": [
"hogstrom",
"jmertic"
],
"license": "CC-BY-4.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12365",
"repo": "zowe/zlc",
"url": "https://github.com/zowe/zlc/issues/97"
}
|
gharchive/issue
|
Acclaim badge for Zowe committers
We have the ability to issue badges under the LF's Acclaim account ( https://www.youracclaim.com/ ) and thought to help showcase community support the idea of issuing a 'Zowe Committer' badge might be a cool idea. Let me know if y'all are down with this and if so I can get this going.
Sounds good to me. You might have a separate OMP badge
Discussed at ZLC last week. Proceed
|
2025-04-01T04:36:02.953859
| 2022-09-21T17:51:10
|
1381289789
|
{
"authors": [
"LazuLitee",
"Lucamuh"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12366",
"repo": "zskarte/zskarte-v3",
"url": "https://github.com/zskarte/zskarte-v3/issues/99"
}
|
gharchive/issue
|
Pattern option for freehand drawing should be removed
Pattern option for freehand drawing should be removed
Also remove line settings for signatures which do not have a line (in selected-feature.component)
Pattern option is already removed with new implementation.
|
2025-04-01T04:36:03.020734
| 2024-08-03T00:03:30
|
2445898806
|
{
"authors": [
"alya",
"chrisbobbe",
"gnprice"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12367",
"repo": "zulip/zulip-flutter",
"url": "https://github.com/zulip/zulip-flutter/pull/867"
}
|
gharchive/pull-request
|
theme: Follow system setting for light/dark theme!
We now have dark-theme variants in all the styles that differ between light and dark, in all of the app we've implemented so far. It's time to let users benefit from that work!
We don't yet let the user choose between dark/light/system in the app -- that's #97 "Store some client settings" -- but the "system" behavior should be the default anyway, and this commit provides that.
The dark-theme colors come from various sources. For each color, I believe the source is clear either in the code or the Git history. Those sources are:
Flutter's library of Material Design widgets, for UI that's been using those (like the compose box)
the "ready for dev" parts of the new Figma, like this: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=2940-48987&m=dev
the web app (in its state when we wrote the zulip-flutter commit)
the table of variables in the new Figma, with a note that we're not sure if we chose the right variable (because that part of the UI doesn't have a "ready for dev" design in the Figma yet)
my brain and a quick check that it looked OK, as a last resort
We'll want to update the colors as Vlad's work on the new Figma progresses, and also incorporate his feedback from trying out the app in dark theme.
Fixes: #95
The theme change is supposed to animate, over 200ms, but I haven't managed to reproduce that on iOS yet. I think what's happening is:
When I change the system setting manually, the 200ms animation happens while I'm in the Settings app, so it's finished by the time I go back to Zulip.
When I set it to change automatically at some time in the near future, the change doesn't actually happen unless my screen is off, and I guess in this case too the animation happens before I can return to Zulip, while the screen is off. There's a note on the iOS settings page: "iPhone may wait to transition until you are not using the screen."
Ah well. The animation should show when we add the in-app setting, and I have seen it on Android upon returning to the app after changing the system setting manually.
When I set it to change automatically at some time in the near future, the change doesn't actually happen unless my screen is off, and I guess in this case too the animation happens before I can return to Zulip, while the screen is off. There's a note on the iOS settings page: "iPhone may wait to transition until you are not using the screen."
Fun. I guess if you're using the screen at the appointed time, and keep using it continuously, then at some point after two minutes or an hour or something it'll decide to stop holding out and will make the transition before your eyes. But that's a pain to demonstrate.
I have watched the app make the transition at previous stages of this work, just by editing the brightness used in zulipThemeData and doing a hot reload. It was nice and smooth.
I have watched the app make the transition at previous stages of this work, just by editing the brightness used in zulipThemeData and doing a hot reload. It was nice and smooth.
Oh yeah definitely; me too. If I hadn't seen that, I'd want to investigate more to see if the lack of animation was just a bug I wrote into the code :)
Just added a small commit:
theme: Use slightly more efficient `MediaQuery.platformBrightnessOf`
Cool, that change LGTM too.
Sounds like a good plan to me!
OK β merging!
I took a quick look at git log -p pr/867..origin -- lib/widgets to see if there's anything new that needs adjustment for a dark theme. The only thing that looks suspicious is MutedUnreadBadge, from #714. So @chrisbobbe please take a look and see if that needs a TODO(#95) comment and/or a quick fixup.
|
2025-04-01T04:36:03.037111
| 2019-02-27T17:43:25
|
415247251
|
{
"authors": [
"AdityaHirapara",
"anh2111htd",
"borisyankov",
"chrisbobbe",
"gnprice",
"timabbott"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12368",
"repo": "zulip/zulip-mobile",
"url": "https://github.com/zulip/zulip-mobile/issues/3372"
}
|
gharchive/issue
|
Provide UI to update own profile
Implement the functionality that exists on the web at:
https://chat.zulip.org/#settings/your-account
Important:
Email, Full name, Password
Upload new avatar
Secondary:
Deactivate account
Custom profile fields
@zulipbot claim
I would like to work on this issue
I am thinking of implementing it on profile tab like this:
Then pressing button will navigate to new screen like user status.
@borisyankov any suggestions?
@AdityaHirapara we have some problems with vertical space here - some phone screens might not be high enough to fit this. I have an idea for a different style of 'Edit profile' button, but it is perfectly fine to start working on this with this implementation and we can fix that before merging it.
We probably don't need to show local time for your own profile, so there may be some space optimization options available too.
We probably don't need to show local time for your own profile, so there may be some space optimization options available too.
Yes, That can be done.
We probably need this information somewhere though.
If there is a timezone set it is not necessarily what the actual time of the device is.
Also, I haven't had set this for myself so my concern for the space was even without that line.
Hi @AdityaHirapara, I've already been working on this issue :) I claimed 2 weeks ago but didn't update frequently as it took a while to learn the codebase and debug.
For now, user can edit their own full name, I'm working on allowing them to edit avatar and password. @borisyankov can you help me do a quick review for #3421 as it may relate to your PR #3403?
Oh okay, Let me know if I can help you with anything :)
We should be sure to disable the widget when changing a user's avatar is disabled (see zulip/zulip#12251) because the organization is syncing them from LDAP.
@timabbott should we introduce a capabilities or permissions object with flags on register?
The purpose will be to move the biz logic of determining what the client can do to the back-end.
So stuff like 'if ldap => canEditProfile: false, if admin => canDeleteStream: false` etc.
In this case, it is unnecessary... you can just check for the keys in the
register response, using false (not disabled) as the default if not present
-Tim Abbott (mobile)
On Fri, May 3, 2019, 3:28 PM Boris Yankov<EMAIL_ADDRESS>wrote:
@timabbott https://github.com/timabbott should we introduce a
capabilities or permissions object with flags on register?
The purpose will be to move the biz logic of determining what the client
can do to the back-end.
So stuff like 'if ldap => canEditProfile: false, if admin =>
canDeleteStream: false` etc.
β
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zulip/zulip-mobile/issues/3372#issuecomment-489259665,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAU6NWVSDUTEXWJR5VVMOCDPTS4CTANCNFSM4G2ULMQQ
.
We've had another report of this, here.
This will require #3397 and some other parts of #3408 -- when we get an update to this information from the server, we'll need to apply it.
In particular, I think, we'd want to get #5208 done, or else this will seem like a buggy experience, I think.
We've just had another report of this in a Play Store review: https://chat.zulip.org/#narrow/stream/48-mobile/topic/appfollow/near/1413737
This came up a couple of times recently. Both were specifically about setting the avatar:
in 2024-06: https://chat.zulip.org/#narrow/stream/137-feedback/topic/Favorite.20editor/near/1836540
and in 2024-08 indirectly: https://chat.zulip.org/#narrow/stream/137-feedback/topic/The.203.20top.20features.20of.20your.20dreams/near/1926811 (though I think in that case having this feature wouldn't have solved the user's needs β they'd still want to set the avatar for all users in their realm up front using the API)
|
2025-04-01T04:36:03.041602
| 2019-08-27T21:56:00
|
486053885
|
{
"authors": [
"chrisbobbe",
"gnprice"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12369",
"repo": "zulip/zulip-mobile",
"url": "https://github.com/zulip/zulip-mobile/issues/3599"
}
|
gharchive/issue
|
Eagerly fetch relevant conversation on getting notification
@zingmars writes on #3558:
A notification will show up, but when the app opens, assuming it doesn't have to load the whole conversation, it will take it's time to actually load the message, all the while showing the "new message" banner at the top.
This happens because the platform-native code that handles notifications doesn't interact closely with the JS code running on RN which drives the bulk of the app; and in particular, the notification doesn't cause the main app code in JS to wake up at all or to add anything to its storage. So if the app is in the background and not getting to regularly poll (or long-poll) the server for updates, then it won't learn anything about the notification-related messages until the app is launched and it goes and updates all its data.
It'd be good to take a notification as a prompt that we should go refresh our data. After all, it's likely the user will follow the notification.
Schematically, I think the solution will look something like:
When we get a notification, schedule a background task to wake the app and have it poll the server.
For a simple version, that task just causes a normal /events poll.
Better, it should also fetch messages in the particular conversation the notification was in.
The exact shape of "schedule a background task" will be based on the Android and iOS SDKs respectively, and we'll want to look up and follow the relevant upstream guidance for each platform.
Since this issue has the labels a-IOS and a-notifications, I'm marking it as blocked by https://github.com/zulip/zulip-mobile/issues/4115, so we only have to implement a solution once. The PR https://github.com/zulip/zulip-mobile/pull/4163 is currently open for that issue.
#4163 is merged!
|
2025-04-01T04:36:03.045002
| 2020-07-01T08:33:43
|
648784204
|
{
"authors": [
"Maskedman99",
"agrawal-d",
"gnprice"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12370",
"repo": "zulip/zulip-mobile",
"url": "https://github.com/zulip/zulip-mobile/pull/4176"
}
|
gharchive/pull-request
|
home screen: Use material tabs for bottom navigation.
Use createMaterialTopTabNavigator for bottom navigation. The
previously used createBottomTabNavigator gave no feedback on
tapping the icons, which is bad UX. Infact, on low end devices,
navigating to different screens can take a noticable amount of
time, and sometimes it feels that the touch didn't register. Using
these fixes the issue.
One thing I see in the screen recording (thanks for including that!) is that there's a highlight at the bottom edge of the selected tab. That's characteristic of Material top tabs, and it gives a sense that it's controlling something that comes below. When the tabs are at the bottom, below what they're controlling, that sense is inaccurate, so it'd be good to avoid.
That's a good reason to use createMaterialBottomTabNavigator instead. It's fine that it involves another library package. Want to try that?
react-native-paper provides many other customizable UI elements like button, lists, modals ...etc (https://callstack.github.io/react-native-paper/ ), adding it would increase the apk size significantly. Using this library just for the bottom-bar feels overkill to me.
|
2025-04-01T04:36:03.053356
| 2019-04-13T18:29:57
|
432883123
|
{
"authors": [
"refeed",
"showell"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12371",
"repo": "zulip/zulip",
"url": "https://github.com/zulip/zulip/issues/12116"
}
|
gharchive/issue
|
api docs: Add explicit -G for curl requests.
Some versions of curl will do a POST if you supply -d but don't supply -G.
Also, several endpoints in Zulip have the same name for two different endpoints. For example, "/messages" can POST messages or GET messages.
Newbies testing the API may think they're doing a GET when actually a POST occurs, and the error messages can be confusing.
We just need to sweep our docs to explicitly add -G to the curl examples for GET endpoints.
Discussion here: https://chat.zulip.org/#narrow/stream/127-integrations/topic/Curl.20bot.20help/near/732532
@zulipbot claim
|
2025-04-01T04:36:03.075741
| 2016-07-20T17:44:11
|
166640298
|
{
"authors": [
"sharmaeklavya2",
"timabbott",
"umkay"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12372",
"repo": "zulip/zulip",
"url": "https://github.com/zulip/zulip/issues/1331"
}
|
gharchive/issue
|
Upgrade our Python dependencies to modern versions
Now that Zulip is using a virtualenv rather than an apt repository for our Python dependencies, we're no longer pinned to what is running in Ubuntu Trusty. One can get a list of what's out of date using
$ pip list --outdated.
[x] boto (2.38.0) - Latest: 2.42.0 [wheel]
[x] certifi (2015.4.28) - Latest: 2016.2.28 [wheel]
[x] cffi (1.5.2) - Latest: 1.7.0 [wheel]
[ ] CommonMark (0.5.4) - Latest: 0.7.0 [wheel]
[x] coverage (4.0.3) - Latest: 4.1 [sdist]
[ ] Django (1.8) - Latest: 1.9.8 [wheel]
[ ] django-guardian (1.3) - Latest: 1.4.4 [sdist]
[x] docopt (0.4.0) - Latest: 0.6.2 [sdist]
[x] enum34 (1.0.4) - Latest: 1.1.6 [wheel]
[x] Flask (0.10.1) - Latest: 0.11.1 [wheel]
[ ] GitPython (<IP_ADDRESS>) - Latest: 2.0.7 [sdist]
[ ] google-api-python-client (1.4.0) - Latest: 1.5.1 [wheel]
[x] html2text (2015.6.6) - Latest: 2016.5.29 [sdist]
[x] httplib2 (0.9.1) - Latest: 0.9.2 [sdist]
[ ] httpretty (0.8.10) - Latest: 0.8.14 [wheel]
[x] idna (2.0) - Latest: 2.1 [wheel]
[x] ipaddress (1.0.7) - Latest: 1.0.16 [wheel]
[x] Jinja2 (2.7.2) - Latest: 2.8 [wheel]
[ ] Markdown (2.1.1) - Latest: 2.6.6 [sdist]
[x] MarkupSafe (0.18) - Latest: 0.23 [sdist]
[x] mock (1.0.1) - Latest: 2.0.0 [wheel]
[x] moto (0.4.23) - Latest: 0.4.25 [wheel]
[x] oauth2client (1.4.11) - Latest: 2.2.0 [sdist]
[x] Pillow (2.8.2) - Latest: 3.3.0 [wheel]
[x] psycopg2 (2.6) - Latest: 2.6.2 [sdist]
[x] pyasn1 (0.1.7) - Latest: 0.1.9 [wheel]
[x] pyasn1-modules (0.0.5) - Latest: 0.0.8 [wheel]
[ ] Pygments (2.0.2) - Latest: 2.1.3 [wheel]
[x] pylibmc (1.4.3) - Latest: 1.5.1 [sdist]
[x] pyOpenSSL (0.15.1) - Latest: 16.0.0 [wheel]
[x] python-ldap (2.4.19) - Latest: 2.4.25 [sdist]
[x] pytz (2015.4) - Latest: 2016.6.1 [wheel]
[x] redis (2.10.3) - Latest: 2.10.5 [wheel]
[x] regex (2016.6.19) - Latest: 2016.7.14 [sdist]
[x] setuptools (24.0.3) - Latest: 24.1.0 [wheel]
[x] simplejson (3.7.3) - Latest: 3.8.2 [sdist]
[ ] sockjs-tornado (1.0.1) - Latest: 1.0.3 [sdist]
[ ] sourcemap (0.1.8) - Latest: 0.2.0 [wheel]
[x] Sphinx (1.4.1) - Latest: 1.4.5 [wheel]
[ ] SQLAlchemy (0.7.8) - Latest: 1.0.14 [sdist]
[ ] talon (1.2.10) - Latest: 1.2.11 [sdist]
[ ] tornado (2.4.1) - Latest: 4.4 [sdist]
[x] transifex-client (0.11) - Latest: 0.12.1 [sdist]
[x] Twisted (15.2.1) - Latest: 16.3.0 [sdist]
[x] urllib3 (1.15.1) - Latest: 1.16 [wheel]
[ ] wal-e (0.6.8) - Latest: 0.9.2 [sdist]
[x] Werkzeug (0.11.8) - Latest: 0.11.10 [wheel]
[x] xmltodict (0.10.1) - Latest: 0.10.2 [sdist]
[x] zope.interface (4.1.2) - Latest: 4.2.0 [sdist]
Most of these we can probably just change the version and if the tests pass, merge the update. The ones I expect that to not be true for are:
Django (we integrate with Django closely; see #1135 )
tornado (#1282) -- probably tests won't pass.
Sphinx and the other things in requirements/docs.txt -- should confirm docs still look right (links work, etc.); see docs/README.md for instructions on building locally
Markdown/pygments -- we integrate with these closely so should audit for API changes
google-api-python-client -- we don't have good tests for this I think.
sourcemap -- don't have good tests for this
@sharmaeklavya2 this may be a project worth worth your spending a bit of time on, since I expect upgrading all these things will decrease risk of us running into Python 3 compatibility bugs that we don't see in testing but would see in production (when exercising a wider range of code paths).
I attempted to upgrade moto (a mock for boto's S3 integration) here: https://github.com/timabbott/zulip/commits/moto-upgrade but it is failing tests on Python 3 only: https://travis-ci.org/timabbott/zulip/builds/146171322
@sharmaeklavya2 probably worth your investigating.
Ok. I'll look into it.
I recently found out about requires.io. Here's the report on my fork of zulip: https://requires.io/github/sharmaeklavya2/zulip/requirements/?branch=master
It usually also shows which requirements support python 3.
Cool, yeah, we'll definitely want to integrate that sort of badge thing once we've fixed our out-of-date status :)
Along with moto I also updated boto and now tests pass.
Well actually I hadn't run the tests with the old version of boto. I tried that now and even that is passing.
I have found out the reason for the moto failure. moto relies on httpretty==0.8.10 but the latest version is httpretty==0.8.14. Upgrading to the latest version produces this traceback.
Ahh, OK, makes sense. Removed that upgrade and merged the moto upgrade. Thanks for tracking that down @sharmaeklavya2!
Also I subscribed to https://github.com/spulec/moto/issues/514 so I'll find out when we can safely upgrade.
Some things to keep in mind:
djang-guardian won't be updated
httpretty won't be updated; will cause errors with latest moto/boto
SQLAlchemy won't be updated; will cause errors with latest psycopg2
CommonMark won't be updated or will break the docs
Closing this (which is now quite cluttered) in favor of #1641, which is a cleaned-up explanation of what remains.
|
2025-04-01T04:36:03.078968
| 2016-07-30T23:06:52
|
168491408
|
{
"authors": [
"kkampardi",
"timabbott"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12373",
"repo": "zulip/zulip",
"url": "https://github.com/zulip/zulip/issues/1490"
}
|
gharchive/issue
|
CSS issue with line-wrapping of stream descriptions in narrow windows
If you set a stream description as something long like:
"For important announcement notices. Use the social streams for social announcements."
and then make the window narrow, the Susbcribe button gets line-wrapped incorrectly:
I could check this if nobody does :)
Sure, go for it!
OK working on this
Hey @timabbott do you think this should get fixed by changing css? Perhaps we could try build in filters for django's template tags instead. Something like {{ value|truncatechars:9 }}
This got fixed via 5840fef3b6a72dba61376ee06d2bcca4220dc3c0 today; ended up being a lot more complicated than a simple CSS change :/.
Thanks for looking at this @kkampardi!
|
2025-04-01T04:36:03.085744
| 2024-04-02T16:29:01
|
2220942263
|
{
"authors": [
"alya",
"ilyesskhayati",
"zecbfernandes"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12374",
"repo": "zulip/zulip",
"url": "https://github.com/zulip/zulip/issues/29568"
}
|
gharchive/issue
|
Long search query overflows in message feed when no results found
Expected Behavior:
When searching for an extremely long word, the error message should display "No search results. You searched for: [the long word]" without overflowing the screen. If the complete word does not fit the entire screen, it should be partially hidden.
Actual Behavior:
Upon searching for an extremely long word, the error message overflows the screen, making it difficult to read the complete message.
Steps to reproduce the buggy behaviour:
On the main view, click the search bar and type an extremely long word/sentence.
Searching for it will now show the word overflowing to the right.
I forked the software 2 days ago so I can only assume I'm on the latest Zulip version.
@zulipbot claim
I would like to personally fix this issue so if you could assign it to me I would appreciate it!
I just reproduced this Bug both on the main site and on the latest Zulip version that I forked, following the same steps:
click on the search bar
type a string with over 130 characters
It gave me this result:
Side note: I copied the string and counted with a simple code that gave me the desired string length.
a good expected output is less than 50 characters with 3 dots in the end (like this...) also for the "You searched for:" to not go on top of the result.
I can help with this, if you just add help-wanted.
Sure, assigning to you, @ilyesskhayati -- thanks!
Hi @ilyesskhayati, I just noticed your message! I wanted to bring to your attention that I've already made a commit addressing this issue that fixed the bug, but I didn't create the pull request as I wasn't assigned to it. Please take a look at my commits above, where I solved this issue. If you proceed with the pull request, could you please reference my commit? Also, I believe in my second commit, I inadvertently removed the tests I created for my fix so you might have to implement them again. Good luck with the pull request!
@zecbfernandes For what it's worth, you can create a pull request without being assigned to an issue.
Hello, sorry for the late reply, I was finishing up my Finals exams.
I think I will not work on it now, as I still have some things to do, so yeah!
@alya I did not know that, thanks for clearing that up! I will be submitting a pull request with my fix for the issue soon.
|
2025-04-01T04:36:03.098016
| 2017-01-05T19:26:53
|
199038045
|
{
"authors": [
"McpCyber",
"Shayan-To",
"mooeypoo",
"timabbott"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12375",
"repo": "zulip/zulip",
"url": "https://github.com/zulip/zulip/issues/3123"
}
|
gharchive/issue
|
Support right to left messages
Hello.
A good approach to implementing it (that is used in many chat applications) would be to check the first character of every line to see whether it belongs to a right-to-left language and switch the direction of that line if it does.
For simplicity, the check can also be made on the first character of every message so to switch the direction of the whole message. But this will cause some problems to the users as well.
The CSS for this is probably a fairly large project. #267 and #731 are related.
Yeah, that makes sense; we could without much technical difficulty add a right-to-left CSS class to messages that have this property; which means the real challenge is doing the CSS to support this nicely without a ton of duplicated work. Might not be too hard to get something basic working.
I can help doing something ifΒ you point me in the right direction. I have some experience doing such things.
And I think that the input text area should be acting the same way, switching directions when the first character on it is an RTL one.
I'm pitching in here, hoping it's not too much wall-of-text.
Supporting RTL can be a complicated endeavor, and it usually involves more than just the textbox itself; I would split this issue to several aspects if you really want to support RTL --
The interface is one aspect -- how to handle usernames in RTL, topics in RTL, etc. Do you want to allow for translation to the interface itself like the menu buttons, etc?)
The typing is another aspect -- do you use an autodetection for directionality (see below for concerns on that) or include a "flip directionality" button (like in word processors) and do you allow for paragraph-wide or inner directionality switch (for example, what happens when someone types a sentence in English with a name in Arabic followed by a number... try it, it's fun ;)
As for the auto-detection, I'd be careful about that, as it's not all that simple. Several other products online try to do that, some more successfully than others, but they all run into problems in some way or another.
Google Hangouts, for example, changes the directionality of a paragraph you type based on how many characters in RTL there are. That means that if you start writing in English, the direction is LTR, then switched to Farsi, it continues to be LTR until the number of characters surpasses the English ones, at which point it switches to RTL for the entire paragraph. If you then switch back to English and continue typing, it may actually flip back.
Facebook seems to normally go by the first strong character inserted ('strong' as in BiDi Algorithm definition) which can create a lot of frustration for those of us who type in English but have friends names in RTL language like Hebrew. If you type "@somethingInHebrew my address is 123 nowhere drive, apt 112, SF, CA" you'll get the entire sentence RTL'ed. Same goes for the other way around, mentioning a name in English but typing in Hebrew or Farsi or Arabic, etc.
Word processors usually avoid automatically recognizing your typing, and opt for letting you literally choose the directionality. This is also what we do in the Wikimedia Foundation with VisualEditor; you can type what you want, and then mark the section that is RTL and specifically isolate it. This prevents annoying issues like things that end with parentheses and brackets and numbers from getting mangled. But it is probably meant more for an article-writing process, and not very useful for a "chat-like" interface.
So my recommendation would be --
If we use auto detection, be aware that nothing is perfect; find a strategy (going by the first strong character is probably fine) and stick to it throughout the system - both in typing and in viewing.
Make sure that the input's direction (if it flips to RTL or stays LTR) is then reflected, consistently, in the way the message is viewed. (This isn't the case in Facebook, for example - sometimes the input would flip you around but then the resulting status shows inconsistent - which is the most frustrating action ever as you can't even try to correct or predict issues as you type)
Consider allowing a button to wrap something in bidi-isolation
Live with the fact that RTL users expect everything to be inconsolably broken, and that the mere fact we're trying is a huge deal ;)
We use a method to discover the directionality from content in MediaWiki, see reference to the code here: https://github.com/wikimedia/mediawiki/blob/master/languages/Language.php#L1958
With the (rather insane) regexp here: https://github.com/wikimedia/mediawiki/blob/master/languages/Language.php#L174
@mooeypoo awesome, thanks for the thoughts!
Attaching a hacky implementation that @Shayan-To has been using that may be a useful resource:
rtl.zip
This project still needs a volunteer to get it working in a mergable form.
Anyone interested in using my hacky implementation (that Tim attached above ^^^), here's the instructions (link to the conversation):
Extract it to /home/zulip/prod-static.
Run add_to_app.sh script (using bash).
After each deploy (server upgrade), run add_to_app.sh script again.
hi , i run this scripts , not happend
@McpCyber a built-in feature was merged into Zulip long after this thread; you should be able to just use RTL messages in Zulip directly.
@timabbott Thanks , in the web version that's fine . but in Mobile app ohhh No
|
2025-04-01T04:36:03.100076
| 2017-01-09T12:22:39
|
199539920
|
{
"authors": [
"anirudhjain75"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12376",
"repo": "zulip/zulip",
"url": "https://github.com/zulip/zulip/issues/3185"
}
|
gharchive/issue
|
Streams are greyed out even when not muted
Streams we are subscribed to are sometimes greyed out even when they are not muted
proof.zip
This zip file contains a screen recording
Verified that there is another reason for the streams to be greyed out
|
2025-04-01T04:36:03.108726
| 2015-12-03T08:17:45
|
120115883
|
{
"authors": [
"BornToBeRoot",
"Get-UserName",
"akashnimare",
"timabbott"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12377",
"repo": "zulip/zulip",
"url": "https://github.com/zulip/zulip/issues/350"
}
|
gharchive/issue
|
Desktop-Client Notification like Chrome
Hello,
i test Zulip since a few days and i noticed that the notifications in the desktop client really sucks. This bubble is good for a single notification from a programm... but not when you have a continuous conversation with some people...
Maybe it is possible to change the notification-bubble to something that looks like the notification of chrome/firefox or like in Outlook when you receive a new E-Mail.
Are there any plans for this? Is it possible to make is in the next release?
Greetings
There are no current plans for changing the notification bubbles in the desktop app.
I'm also not entirely sure what exactly you'd like to change; what platform are you using, and can you post screenshots explaining the change you'd like to see here?
I mean this Notificcation (Windows Client):
Change to something like this:
Ahh, OK. I'd be curious to hear whether anyone prefers the current model (in which case it might make sense to make an opton to control the notification style) or whether it'd be better to just change it for everyone.
In the meantime you may be able to get the Chrome experience while still having your Zulip window be easy to find by using a pinned tab in Chrome or a second browser...
Sure... but this feature would ne nice... only the IT-department has chrome or firefox as second brower....the rest is usin IE :/
@BornToBeRoot @timabbott by rebuilding the desktop client in Node-Webkit/Electron this can be easily done.
Yep @akashnimare, I'm hoping to have one of our GSOC students take on rebuilding the Zulip desktop app using Electron, which I think will make incremental improvements easier in the future (certainly it's a stack a lot more people know than the existing QT+webkit stack).
Oh. Awesome. Should I take part in this? Have been working in electron/nw
for a year.
On Mar 8, 2016 11:13, "Tim Abbott"<EMAIL_ADDRESS>wrote:
Yep @akashnimare https://github.com/akashnimare, I'm hoping to have one
of our GSOC students take on rebuilding the Zulip desktop app using
Electron, which I think will make incremental improvements easier in the
future (certainly it's a stack a lot more people know than the existing
QT+webkit stack).
β
Reply to this email directly or view it on GitHub
https://github.com/zulip/zulip/issues/350#issuecomment-193618069.
If you're interested, sure! See https://summerofcode.withgoogle.com/organizations/5197525313126400/ for the Zulip GSOC page.
For some background, the Zulip desktop app is actually a fairly small codebase, because it's a thin wrapper around the main Zulip web app (only ~2500 LOC that's not 3rd-party code). The goal of that project would be to replace the QT+webkit desktop app with an electron app implementing the same functionality; if that's completed with time the spare, there's improvements to the app that we could add onto the project like fixing this bug and making the desktop app support multiple teams at the same time nicely.
Since the bug tracker isn't a great discussion forum for this sort of thing, ping me off-list if you want to discuss more!
Closing this, since the old desktop application has been completely replaced by the electron app discussed here.
|
2025-04-01T04:36:03.112004
| 2017-08-08T21:54:27
|
248858064
|
{
"authors": [
"lonerz",
"shubhamdhama",
"shubhamgupta2956",
"timabbott"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12378",
"repo": "zulip/zulip",
"url": "https://github.com/zulip/zulip/issues/6061"
}
|
gharchive/issue
|
user list on left sidebar in narrow windows takes up majority of sidebar instead of streams
We should either make the middle region draggable between user and stream list or give more space to the stream list.
We should also consider changing it to a toggle rather than stacking things.
@zulipbot claim
still working
@shubhamdhama zulipbot doesn't recognize edited comments. I have removed you from the issue now.
@zulipbot claim
@zulipbot still working on it.
Closing as the setting in question was removed a few months ago.
|
2025-04-01T04:36:03.113373
| 2019-05-21T02:55:43
|
446393363
|
{
"authors": [
"andersk",
"timabbott"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12379",
"repo": "zulip/zulip",
"url": "https://github.com/zulip/zulip/pull/12366"
}
|
gharchive/pull-request
|
dependencies: Upgrade simplebar to 4.0.0
Fixes #12347.
Testing Plan: Dragged the settings scrollbar, releasing the mouse outside the modal; observed that the modal doesnβt spuriously close.
Great, merged, thanks @andersk!
|
2025-04-01T04:36:03.121071
| 2016-08-03T10:56:11
|
169103942
|
{
"authors": [
"smarx",
"timabbott",
"umairwaheed"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12380",
"repo": "zulip/zulip",
"url": "https://github.com/zulip/zulip/pull/1531"
}
|
gharchive/pull-request
|
Traceback starting server with the new APNS module
Fixes: #1480
Automated message from Dropbox CLA bot
@umairwaheed, it looks like you've already signed the Dropbox CLA. Thanks!
Posted a quick comment after skimming this. The other question I have is to make sure we've thought about the correct behavior to be in the various environments (and thus what the settings should be):
In production, with an APNS key configured: it should send APNS notifications :)
In production, if the server administrator has not configured APNS: probably we should do something reasonable when someone tries to connect an iOS app, that doesn't involve a traceback and logs a warning so the server admin knows?
In development, probably be default nothing happens, but maybe we also have a way to set it up to test with the APNS sandbox?
Idunno, would appreciate your thoughts on how this should work @umairwaheed, and once we figure out it I guess we should probably document it since I'm not sure what the right behavior is myself )
In production, with an APNS key configured: it should send APNS notifications :)
π. May be, I should add the APNS_SANDBOX setting in prod_settings_template?
In production, if the server administrator has not configured APNS: probably we should do something reasonable when someone tries to connect an iOS app, that doesn't involve a traceback and logs a warning so the server admin knows?
Yeah, we currently log in case of error. Some tests are also added that make sure that if connection is invalid then we don't crash.
In development, probably be default nothing happens, but maybe we also have a way to set it up to test with the APNS sandbox?
Yep, it will connect to sandbox by default. Admin will have to change the setting, APNS_SANDBOX, to False.
Hmm, is Redis available in Travis?
@timabbott, please review. Thanks.
This looks great, merged! Thanks @umairwaheed! I love that we now have tests for so much of this feature.
If you're interested, it'd also be awesome to add similar tests to the Android/GCM push notifications feature, so that we can get the push notifications system to full test coverage.
As a sidenote: it'd be great if you moved to a practice of adding mypy annotations for your new code (see http://zulip.readthedocs.io/en/latest/mypy.html and especially the cheat sheet linked there on how to add mypy annotations). We're pretty close to getting mypy to 100% coverage, and several of the files that aren't yet annotated are things you're an expert on: https://github.com/zulip/zulip/issues/733#issuecomment-236326005
I would certainly welcome a PR added annotations to things like zproject.jinja2, zerver.storage, etc., if you get a chance.
If you're interested, it'd also be awesome to add similar tests to the Android/GCM push notifications feature, so that we can get the push notifications system to full test coverage.
Sure.
I'll add the annotations to the files I worked on.
|
2025-04-01T04:36:03.128013
| 2022-01-24T15:12:02
|
1112774219
|
{
"authors": [
"YashRE42",
"alya",
"rodrickcalvin",
"timabbott"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12381",
"repo": "zulip/zulip",
"url": "https://github.com/zulip/zulip/pull/20900"
}
|
gharchive/pull-request
|
Fix for the issue 20753
Places Poll-question editing icon on the same line as the poll question from issues #20753 and #20757
Testing plan:
Made a poll in the #test stream where I added a multiline question so that I can observe the behaviour of the icon while I fixed the issue.
GIFs or screenshots:
Fixes: #20753.
@alya how can I work fix the failing text on the PR?
@rodrickcalvin please explain how your solution differs from #20757 and why.
@alya I took the approach of adding a CSS class to encapsulate the h4, .poll-please- wait and the icon itself. I switched the display: inline-block on the classes .poll-question-header and .poll-edit-question.
Then gave their parent class position: relative and page-break-inside: avoid this avoids the elements from taking a new-line as their normal flow usually does. But this only applies to elements inside the parent-class .
Reason for Approach:
The solution #20757 was advised to keep the HTML in the handlebar files.
I didn't want to affect the performance by altering any of the JavaScript.
@YashRE42 would you be up for taking a look, since you've been reviewing #20757?
You're still doing:
.poll-question-header {
- display: inline-block;
+ display: inline;
}
which we know from #20757 can fix the bug, independent from the other changes suggested here. The addition of the ::after is suspicious to me, page-break-inside has been replaced with break-inside according to MDN and I'm not convinced it's necessary.
I don't understand from your reasoning why this is better than #20757 because #20757 neither changes the html nor the JS.
@YashRE42 I don't think it is better reasoning. I took an alternative. I think #20757 is better than this solution.
Closing as this issue was resolved by https://github.com/zulip/zulip/pull/20757.
|
2025-04-01T04:36:03.136679
| 2022-03-29T19:55:37
|
1185345032
|
{
"authors": [
"alya",
"evykassirer",
"tatiPFernandes",
"timabbott"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12382",
"repo": "zulip/zulip",
"url": "https://github.com/zulip/zulip/pull/21595"
}
|
gharchive/pull-request
|
Updates for banner for mark-as-read-turned-off banner
Two changes: updated the x button to actually close the banner, and updated some styles.
Before:
(for some reason I wasn't able to reproduce this on CZO, but I can get it consistently locally)
After:
Tested manually since there's no current test suite for the banner.
Thanks!
For closing the banner, it reopens again when I resize the window without changing anything else, so something is not quite working right there.
For the positioning changes:
At some widths, the button is too close to the text:
The x position is certainly better, but I actually think it's still too low, both in the one-line and the two-line situation. I think it should feel like it's in the upper right corner, not aligned with the text.
By the way, there is an issue for the alignment problems: #19770.
Oh, I guess we closed that issue, but it seems like there are still problems.
@zulipbot claim
Oh whew thanks for testing and finding that! There's some stuff going on in the code making this tricky. I'll ask to see what the right thing to do here is :)
@alya ready for you again :)
Cool, thanks! Looks good to me -- ready for your review, @timabbott .
Thanks for working on this and sorry for the slow review @evykassirer! I pasted a batch of comments.
Comments addressed :)
Played with the PR again -- looks good to me!
@timabbott anything blocking this from being merged?
Merged, after removing , with these changes on top of https://github.com/zulip/zulip/pull/21595#discussion_r919516001 just to simplify the interface for how narrow.js is calling into this module:
diff --git a/static/js/narrow.js b/static/js/narrow.js
index 4e13fd3103..f05409311f 100644
--- a/static/js/narrow.js
+++ b/static/js/narrow.js
@@ -162,7 +162,6 @@ export function reset_ui_state() {
narrow_banner.hide_empty_narrow_message();
message_scroll.hide_top_of_narrow_notices();
message_scroll.hide_indicators();
- unread_ui.hide_mark_as_read_turned_off_banner();
unread_ui.reset_mark_as_read_turned_off_banner();
}
diff --git a/static/js/unread_ui.js b/static/js/unread_ui.js
index c8648a2339..4e3b563047 100644
--- a/static/js/unread_ui.js
+++ b/static/js/unread_ui.js
@@ -15,16 +15,17 @@ import {notify_server_messages_read} from "./unread_ops";
let last_mention_count = 0;
let user_closed_mark_as_read_turned_off_banner = false;
-export function reset_mark_as_read_turned_off_banner() {
- user_closed_mark_as_read_turned_off_banner = false;
-}
-
export function hide_mark_as_read_turned_off_banner() {
// Use visibility instead of hide() to prevent messages on the screen from
// shifting vertically.
$("#mark_as_read_turned_off_banner").toggleClass("invisible", true);
}
+export function reset_mark_as_read_turned_off_banner() {
+ hide_mark_as_read_turned_off_banner();
+ user_closed_mark_as_read_turned_off_banner = false;
+}
+
export function notify_messages_remain_unread() {
if (!user_closed_mark_as_read_turned_off_banner) {
$("#mark_as_read_turned_off_banner").toggleClass("invisible", false);
Thanks @evykassirer, and sorry that the review process took forever on this one.
Thanks Tim! Glad you're feeling better enough to be able to look through these π
|
2025-04-01T04:36:03.141548
| 2023-01-11T05:45:37
|
1528468262
|
{
"authors": [
"drrosa"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12383",
"repo": "zulip/zulip",
"url": "https://github.com/zulip/zulip/pull/24033"
}
|
gharchive/pull-request
|
help center: Document logo sizing and scaling.
Adds a tip to provide guidance on the size of organization logos that should be uploaded in the Organization Profile settings.
Fixes #22121.
Screenshots and screen captures:
https://zulip.com/help/create-your-organization-profile
Self-review checklist
[x] Self-reviewed the changes for clarity and maintainability
Communicate decisions, questions, and potential concerns.
[x] Calls out remaining decisions and concerns.
[x] Automated tests.
Individual commits are ready for review (see commit discipline).
[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.
Completed manual review and testing of the following:
[x] Visual appearance of the changes.
@alya This PR is ready for your review.
|
2025-04-01T04:36:03.150086
| 2023-05-02T17:34:29
|
1692818882
|
{
"authors": [
"karlstolley",
"timabbott"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12384",
"repo": "zulip/zulip",
"url": "https://github.com/zulip/zulip/pull/25397"
}
|
gharchive/pull-request
|
scheduled_message: Update count in lefthand sidebar
This PR adds a count to the "Scheduled messages" item in the lefthand sidebar.
Additionally, it hides the "Scheduled messages" item when the scheduled-message count is zero.
Fixes: #25101
TODO:
[x] Add test in web/tests/top_left_corner.test.js
Self-review checklist
[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.
Individual commits are ready for review (see commit discipline).
[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.
Completed manual review and testing of the following:
[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.
Let's put this at the end -- that's a convention we have for making it easy to find these methods.
Also, I was thinking this should just directly call update_scheduled_count with the count passed in. The main motivation for that is having clean abstractions; this module is an UI module responsible for rendering the UI component, and scheduled_message.js is a data module responsible for maintaining data structures. Structurally, we generally want to avoid import cycles, preserve data modules that are amenable to nice automated tests, and have a clear flow by having the UI modules do UI stuff and data modules do data stuff.
That said, actually, now that I think about it, we should probably redo this a bit more and not have this parameter after all. In particular, I propose that we have web/src/server_events_dispatch.js just call top_left_corner.update_scheduled_count directly, and have it just fetch the value from scheduled_messages.js -- this would remove the scheduled_messages data module calling into a UI module (something we're often having to remove to eliminate import cycles for typescript).
And then this initialize() method would just call update_scheduled_count().
The other thing we might want to tweak here is renaming update_scheduled_count to something like update_scheduled_messages_row -- we probably want a name that emcompasses the fact that this controls not just the count, but also visibility.
There's a line of missing coverage just because we never called initialize; fixed that so that this can be merged.
|
2025-04-01T04:36:03.152246
| 2017-01-11T20:21:35
|
200197308
|
{
"authors": [
"brockwhittaker",
"smarx",
"timabbott"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12385",
"repo": "zulip/zulip",
"url": "https://github.com/zulip/zulip/pull/3236"
}
|
gharchive/pull-request
|
Add deep link to unsubscribed streams list.
This adds a deep link behind a β+β icon above the streams list on the
left-sidebar which opens the subscriptions page and then also toggles
the tabs to go to the unsubscribed stream list.
Automated message from Dropbox CLA bot
@brockwhittaker, it looks like you've already signed the Dropbox CLA. Thanks!
This looks great! Merged, thanks @brockwhittaker!!
|
2025-04-01T04:36:03.159633
| 2024-12-13T17:05:58
|
2738827269
|
{
"authors": [
"karlstolley",
"timabbott"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12386",
"repo": "zulip/zulip",
"url": "https://github.com/zulip/zulip/pull/32704"
}
|
gharchive/pull-request
|
compose: Maintain circular shape for converation arrow.
At some point, the conversation arrow background became an egg. This ensures a scalable fix to keep the background circular.
CZO issue
Screenshots and screen captures:
Before
After
Self-review checklist
[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.
Individual commits are ready for review (see commit discipline).
[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.
Completed manual review and testing of the following:
[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.
Merged, thanks @karlstolley!
|
2025-04-01T04:36:03.161416
| 2017-02-28T13:52:57
|
210792821
|
{
"authors": [
"khantaalaman",
"timabbott"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12387",
"repo": "zulip/zulip",
"url": "https://github.com/zulip/zulip/pull/3847"
}
|
gharchive/pull-request
|
Drafts: Click on a message will open it for edit.
Now, clicking on any message from the list in Draft messages will open it for edit in the message compose box.
Fixes #3828
@timabbott Is this way of making the change desirable or you feel it could have been better if we had a separate javascript function for class message-content?
Merged, thanks @khantaalaman! I added 1656c04517f0fb650919608c3d9142b976cc4e4f on top, to clean up the labels.
I think we definitely want just 1 function; it might be cleaner to refactor it to use 2 selectors for the 2 different sections, though.
|
2025-04-01T04:36:03.169897
| 2016-01-14T07:15:51
|
126596370
|
{
"authors": [
"arthurzurb",
"shicholas"
],
"license": "mit",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12388",
"repo": "zurb/foundation-rails",
"url": "https://github.com/zurb/foundation-rails/issues/137"
}
|
gharchive/issue
|
undefined gutter variable when trying to include flex-grid
Hello,
Thanks for upgrading this gem to Foundation 6. I'm excited to implement this in my project. When trying to replace the @include foundation-grid with @include foundation-flex-grid in my foundation_and_overrides.scss file I get this error:
Showing /home/nick/stealth/web/app/views/layouts/application.haml where line #7 raised:
Undefined variable: "$gutter"
Is there an "official" way to include the flex grid instead of the regular one?!
Hey @shicholas,
I am going to be closing this, take a look at the issue here: https://github.com/zurb/foundation-sites/issues/7857
This is not a Rails Gem issue, but feel free to report them as you come across any issues installing the gem! Thanks! :smile:
|
2025-04-01T04:36:03.173521
| 2015-06-17T18:00:35
|
89083801
|
{
"authors": [
"bartoszhernas",
"rubenheymans",
"sarahkloth"
],
"license": "ISC",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12389",
"repo": "zurb/twentytwenty",
"url": "https://github.com/zurb/twentytwenty/issues/39"
}
|
gharchive/issue
|
Only loads on browser refresh
I have added the TwentyTwenty plugin for wordpress and it seems to only be loading on browser refresh. Anyone experience this? If you click into any of these you can see what I mean: http://preview.lhkruegerandson.com/before-after-gallery/
I have the same problem :/
same issue here, maybe use a plugin to load twentytwenty after all images are loaded?
I'll test this tomorrow
https://github.com/desandro/imagesloaded
Issue #31 is the same and they gave a fix in comments :)
Using imageloaded is slightly better than using a timeout, if the images are still not loaded after your timeout it still won't work
$('.before-after').imagesLoaded( function() {
$('.before-after').twentytwenty();
});
|
2025-04-01T04:36:03.178865
| 2021-08-29T14:15:39
|
982110865
|
{
"authors": [
"IamGideonIdoko",
"Olukeye",
"devteni"
],
"license": "BSD-3-Clause",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12390",
"repo": "zurichat/zc_plugin_company_goals",
"url": "https://github.com/zurichat/zc_plugin_company_goals/issues/307"
}
|
gharchive/issue
|
Implement a route to get a random member
This should be a route where a random user can be fetched
Assign this to me.
This should be a route where a random user can be fetched
Can you please explain the process to achieve this? Thanks
You'll create a query.type of user (i.e either the user is a mentor, intern or admin) .
So if(user type === mentor) you it fetches a random mentor in that array [ ] of mentors, and same goes to intern and admin.
Randomly, yes.
|
2025-04-01T04:36:03.181366
| 2024-05-06T14:00:31
|
2280953427
|
{
"authors": [
"dai-shi",
"grigorischristainas"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12391",
"repo": "zustandjs/zustand-slices",
"url": "https://github.com/zustandjs/zustand-slices/pull/13"
}
|
gharchive/pull-request
|
Set withActions return type to never in case of invalid actions
If you agree, I think it would be better to keep a consistent return type for withActions in case of invalid actions, similar to withSlices. So I made a small change in order to return never in case IsValidActions equals false.
Please feel free to close this PR if you find this change unnecessary.
Oh, yeah, I agree. That was my intention too. My bad. Thanks for the catch.
Would you be interested in implementing IsValidActions?
Sure, I would like to implement it. Should I open a separate PR for it ?
Sure, I would like to implement it. Should I open a separate PR for it ?
Yeah, that would be great. Let's merge this.
|
2025-04-01T04:36:03.183973
| 2023-11-09T16:45:08
|
1986021253
|
{
"authors": [
"zv800"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12392",
"repo": "zv800/rostats-gen1",
"url": "https://github.com/zv800/rostats-gen1/issues/286"
}
|
gharchive/issue
|
β οΈ Avatar API Endpoint has degraded performance
In 8739601, Avatar API Endpoint (https://avatar.roblox.com/v1/avatar-rules) experienced degraded performance:
HTTP code: 200
Response time: 1003 ms
Resolved: Avatar API Endpoint performance has improved in 5ec3ddb after 6 hours, 11 minutes.
|
2025-04-01T04:36:03.184874
| 2017-09-11T21:21:05
|
256846111
|
{
"authors": [
"omargda",
"zvonicek"
],
"license": "mit",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12393",
"repo": "zvonicek/ImageSlideshow",
"url": "https://github.com/zvonicek/ImageSlideshow/issues/188"
}
|
gharchive/issue
|
Image disappearing in black background
When I set the image slideshow backgroundColor as black or when I enter into FullScreenMode, the image doesn't show. How can I fix this? Thanks!
Can you share the specific code you added to the example project that reproduces the issue?
|
2025-04-01T04:36:03.195984
| 2022-01-24T16:24:50
|
1112866715
|
{
"authors": [
"JonLaliberte",
"blhoward2"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12394",
"repo": "zwave-js/node-zwave-js",
"url": "https://github.com/zwave-js/node-zwave-js/issues/4126"
}
|
gharchive/issue
|
NZW31S: Missing Config Parameters
Is your problem within Home Assistant (Core or Z-Wave JS Integration)?
NO, my problem is NOT within Home Assistant or the ZWave JS integration
Is your problem within ZWaveJS2MQTT?
NO, my problem is NOT within ZWaveJS2MQTT
Checklist
[X] I have checked the troubleshooting section and my problem is not described there.
[X] I have read the changelog and my problem was not mentioned there.
Describe the bug
Config file in zwave-js: https://github.com/zwave-js/node-zwave-js/blob/master/packages/config/config/devices/0x0312/nzw31s.json
Just has some missing config options.
Right now the parameters available in the zwave-js repo are 1,2,4,5. There are also 3,8,9. (Options 6 and 7 seem to deal with Association Groups, so I ignored them.)
3: LED Indicator Control (whether the led on the switch is on when the light is on or off)
8: Default value when the switch is turned on (at the switch)
9: Default value when the switch is turned on (via zwave)
Reference: https://github.com/InovelliUSA/OpenZWave/blob/master/config/inovelli/nzw31.xml
Device information
Manufacturer: INovelli
Model name: NZW31S
Node ID in your network:
How are you using node-zwave-js?
[ ] zwavejs2mqtt Docker image (latest)
[ ] zwavejs2mqtt Docker image (dev)
[ ] zwavejs2mqtt Docker manually built (please specify branches)
[ ] ioBroker.zwave2 adapter (please specify version)
[X] HomeAssistant zwave_js integration (please specify version)
[ ] pkg
[ ] node-red-contrib-zwave-js (please specify version, double click node to find out)
[ ] Manually built from GitHub (please specify branch)
[ ] Other (please describe)
Which branches or versions?
version:
node-zwave-js branch:
zwavejs2mqtt branch:
Did you change anything?
no
If yes, what did you change?
No response
Did this work before?
No, it never worked anywhere
If yes, where did it work?
No response
Attach Driver Logfile
NA
These parameters aren't in the manual, including references to the manual posted by Inovelli on their forum. How sure are you that these actually exist? Do they exist at every firmware version? Can you contact Inovelli and try to find out?
8 and 9 were added on Firmware 1.0.2 (must be 2-3 years ago at least). I was using them with OZW in HA previously (still using them now, just manually).
inovelli-nzw31.pdf
Just wanted to note this as well: https://github.com/OpenZWave/open-zwave/blob/master/config/inovelli/nzw31.xml
|
2025-04-01T04:36:03.200198
| 2020-01-08T15:03:29
|
546918346
|
{
"authors": [
"AlCalzone",
"raman325",
"robertsLando"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12395",
"repo": "zwave-js/node-zwave-js",
"url": "https://github.com/zwave-js/node-zwave-js/issues/552"
}
|
gharchive/issue
|
Rework the definition process for value IDs
Some thoughts:
There should be a central property of each CC that provides named access to all defined value IDs (or functions that return a value ID) as well as metadata
If possible, this property should be used in the decorators (think about this)
It should be possible to define if this value is always accessible (e.g. writeonly values #532) and/or private
This should replace or improve registerValue.
What about using msg-pack-lite to decode the valueId json and encode it back to valueId? We could use it's encoding as unique Id. Also we could provide a public getId(ValueID valueId) : String method to calcolate a the valueId unique id
Based on our slack conversation:
Is there a file where I can find all properties/ propertiesKeys of all command classes?
We could create a file with all properties/properties keys that actually are hardcoded in protected [SET_VALUE]:
Like https://github.com/zwave-js/node-zwave-js/blob/master/packages/zwave-js/src/lib/commandclass/MultilevelSwitchCC.ts#L249
As discussed in Discord, this could be used to auto generate CC documentation. Once you get there, please include whether the CC has stateless values
|
2025-04-01T04:36:03.208685
| 2021-11-27T23:55:02
|
1065145135
|
{
"authors": [
"CWSpear",
"mick1988"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12396",
"repo": "zwave-js/node-zwave-js",
"url": "https://github.com/zwave-js/node-zwave-js/pull/3801"
}
|
gharchive/pull-request
|
feat(config): additional Product ID for HS-WX300
I read in the changelog that the HomeSeer HS-WX300 had added support, and I got some new dimmer/switch combos for finishing the basement.
When I added it (via zwavejs2mqtt), it very much didn't look like it was supported. A little digging and it seemed my device had a different ID code. Not 100% sure this is how you add support for this, but thought I'd try to help.
@zwave-js-bot fix lint
After these changes my HS-WX300 do not automatically register in Home Assistant with zwavejs2mqtt. Is it a formatting error that it is picking up the new device ID code you added (4037) and it no longer sees the device ID of 4036 which is still the device ID of the HS-WX300's that I received in the mail today? When you view the page on devices.zwave-js.io, it only displays the 4037 ID.
I made a fork where I updated the zwave allaince ID and inclusion/exclusion details. I removed the 4037 device ID, but the correct fix would be to make sure both register. Can you have two device ID's or will it require two devices in the database?
0x4036 was the one that was added. It was only just merged a little over a day ago, so make sure your zwavejs2mqtt has the latest database.
I tested before the PR was merged and at least for me, my 0x4036 were able register with both entries there.
Sure enough, once I restarted the service, I got the notification for an update. Thanks for getting the 0x4036 in there.
Yep! No idea what's up with the different product IDs, but yay for open source and open code. I could get a local fix in a matter of hours and only another day or two before it was distributed to everyone else.
Since I have your attention... Did the 0.31.1 zwavejs2mqtt update break your HS-WX300? It says my database version is still 8.8.3, but they all show as unknown. Restoring 0.31.0 fixes it. Just seeing if you had the same issue or if it's with my install.
|
2025-04-01T04:36:03.210142
| 2024-08-02T19:47:26
|
2445664919
|
{
"authors": [
"AlCalzone"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12397",
"repo": "zwave-js/node-zwave-js",
"url": "https://github.com/zwave-js/node-zwave-js/pull/7080"
}
|
gharchive/pull-request
|
fix: try to handle non-implemented CCs
With this PR, non-implemented CCs will no longer be dropped immediately. Instead possible awaiters are invoked first, in case the application is waiting for them.
@zwave-js-bot automerge
|
2025-04-01T04:36:03.212286
| 2021-08-16T07:52:22
|
971464595
|
{
"authors": [
"AlCalzone",
"robertsLando"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12398",
"repo": "zwave-js/zwavejs2mqtt",
"url": "https://github.com/zwave-js/zwavejs2mqtt/issues/1571"
}
|
gharchive/issue
|
[feat] Try to look up manufacturer name if device doesn't have a config file
Instead of displaying "unknown manufacturer 0x1234", z2m should use this method to try and look up the manufacturer name first:
https://zwave-js.github.io/node-zwave-js/#/api/config-manager?id=lookupmanufacturer
which is exposed via the driver's configManager instance.
If that doesn't return anything, falling back to "unknown manufacturer" is fine IMO.
See commit comment. I don't think your fix does what it's supposed to.
Fixed now, sorry
|
2025-04-01T04:36:03.298248
| 2023-10-05T11:05:30
|
1928015350
|
{
"authors": [
"JoeKar",
"blunderful-scripts",
"dmaluka",
"grinapo"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12399",
"repo": "zyedidia/micro",
"url": "https://github.com/zyedidia/micro/issues/2950"
}
|
gharchive/issue
|
Binding raw escape sequences doesn't work
Description of the problem or steps to reproduce
I'm using MobaXterm on Windows to connect to my Debian machine via SSH. The default key bindings for SelectWordLeft and SelectWordRight (CtrlShiftLeft and CtrlShiftRight) don't work. I checked in the raw mode (in micro) what it receives when I'm pressing these combinations and it says:
EventKey: Left: "\x1bOD"
EventKey: Right: "\x1bOC"
So following the instructions for binding raw escape sequences, I added this to my ~/.config/micro/bindings.json:
"\x1bOC": "SelectWordRight",
"\x1bOD": "SelectWordLeft",
But after that, when launching micro, it says "Error reading bindings.json: invalid character 'x' in string escape code".
Exactly like in this older issue #1863 .
Specifications
Commit hash: c2cebaa3
OS: Debian Stretch (connecting from MobaXterm on Windows, through SSH)
Terminal: MobaXterm
My complete bindings.json file:
{
"Alt-/": "lua:comment.comment",
"\x1bOC": "SelectWordRight",
"\x1bOD": "SelectWordLeft",
"CtrlUnderscore": "lua:comment.comment"
}
From my perspective the problem is caused by the owners forked json5 (respective original json5). In the included scanner.go#L485 there is no reference to character x, which is injected as raw sequence here.
Furthermore we need to check, if the prefix of x1b in bindings.go#L155 is sufficient, since @zyedidia mentioned in keybindings.md the following:
The terminal sends these events in the form of escape sequences often (but not always) starting with 0x1b.
After some local hacking I assume, that the "\x1b" at bindings.go#L155 and inside the bindings.json needs the escape of \ and thus needs to be change to "\\x1b" and maybe we need to add further prefixes then to solve #1863 too.
But maybe someone proofs me wrong. My terminal doesn't involve these escaped sequences so far...
@JoeKar I tried to change the lines to:
"\\x1bOC": "SelectWordRight",
"\\x1bOD": "SelectWordLeft",
Now micro says at launch:
\x1bOC is not a bindable event
\x1bOD is not a bindable event
I'm not sure but maybe the cause is that micro already assigns these events to the Left and Right keys? Just guessing but this is what I gather from the initial check in raw mode which produced this output when I pressed the aforementioned key combinations:
EventKey: Left: "\x1bOD"
EventKey: Right: "\x1bOC"
@JoeKar I tried to change the lines to:
"\\x1bOC": "SelectWordRight",
"\\x1bOD": "SelectWordLeft",
Now micro says at launch:
\x1bOC is not a bindable event
\x1bOD is not a bindable event
Ah, you're right...so while changing the stuff locally I didn't realized, that escaping the backslash in the bindings.json is already enough to forward the correct string from the parsed json to micro.
Now the trick is, as already mentioned above (comment updated), that we need to adapt the bindings.go#L155 otherwise the strings.HasPrefix() fails due to unmatched prefix.
But at the end I've to ask the question, why not simply assign "Left" & "Right" to your actions?
Well, Left and Right are the arrow keys. I need to use them with the default actions to move around the text. My current workaround is to use AltRight and AltLeft for actions SelectWordRight and SelectWordLeft. So it's not a critical issue for me. But of course, I would prefer to use CtrlShiftRight etc because these are the defaults in most text editing applications.
When I understood tcell right, then it will try to handle the escaped sequence first, after no other event handling has matched. In case you now try to use more or less "known" key events then tcell will not create his raw event and thus micro wouldn't even receive a possible registered raw event.
Sorry, I didn't get what you mean by that last paragraph and I don't even know what tcell is.
But at the end I've to ask the question, why not simply assign "Left" & "Right" to your actions?
Well, Left and Right are the arrow keys. I need to use them with the default actions to move around the text. My current workaround is to use AltRight and AltLeft for actions SelectWordRight and SelectWordLeft. So it's not a critical issue for me. But of course, I would prefer to use CtrlShiftRight etc because these are the defaults in most text editing applications.
Ok, check, understood. Didn't read your description carefully enough, sorry for that.
Sorry, I didn't get what you mean by that last paragraph and I don't even know what tcell is.
No worries. According to my current understanding it looks like a bug of micro (doesn't treat the hard coded escape prefix as escaped escape) and tcell (which simply converts \x1b into a string instead of adding the same escaped escape as string in front of the sequence), at least in case the raw events shall really transport strings representing the printable escaped sequence.
But I'm currently unsure, if this is all, because with my tested raw sequences I had to move the escape sequence handling in front of the normal event handling in tcell.
So long story short, it's a bit tricky to solve this issue.
One of the problems here is that JSON does not support the \x notation, so in bindings.json the raw sequence bindings need to be specified slightly differently:
"\u001bOC": "SelectWordRight",
"\u001bOD": "SelectWordLeft",
(Yeah, arguably it is a bug: micro does not attempt to properly parse \x-escaped strings, instead it simply relies on the JSON parser which does not support \x either, so the resulting behavior is non-intuitive and undocumented.)
The bad news here is that it is not the only problem. With the above \u notation, micro does not print any errors, and I can see that micro does call screen.Screen.RegisterRawSeq(), however the bindings themselves still don't work (i.e. nothing happens when I press the corresponding keys). I remember it used to work for me some (rather long) time ago, so I think it is a regression, either in micro or in tcell.
@dmaluka I just tried binding this. I'm not getting any error either, and I don't get the assigned function either (SelectWordRight etc). What I get is the same as pressing the Left and Right arrow keys (which is also the behavior without the bindings).
@dmaluka
(Yeah, arguably it is a bug: micro does not attempt to properly parse \x-escaped strings, instead it simply relies on the JSON parser which does not support \x either, so the resulting behavior is non-intuitive and undocumented.)
Yep, but this is something which seems to be fixed easily (see below).
With the above \u notation, micro does not print any errors, and I can see that micro does call screen.Screen.RegisterRawSeq(), however the bindings themselves still don't work (i.e. nothing happens when I press the corresponding keys). I remember it used to work for me some (rather long) time ago, so I think it is a regression, either in micro or in tcell.
I was able with \\x to get them forwarded and registered to tcell (which needs a further improvement to not register the same raw event twice or more...) and after little dirty hacking to receive the expected callback via raw event (in \\x notation) too. As a result the configured action has been performed.
So I already assumed, that this seems to be a bug on both sides (see above) and especially tcell doesn't create the raw events in the actual situation. So in case it was working in the past then the regression has been introduced somehow introduced in tcell. Most probably with the \u or \\u notation we've a similar problem in tcell.
As far as I understood from different locations in the code it's intended to carry the escaped characters with a double \\ as prefix, to escape the single \ itself within a string. If so, then I already prepared the first steps towards and only need to find out, why tcell does the raw handling only as a fallback and not in case it's requested AND why the handling of further upcoming raw events is then a bit broken.
@dmaluka
Again I'd appreciate your feedback on this. ;)
I'll try to find time to take a close look into it.
In the meantime, I think I like the idea of adding \x support directly to the json parser (although it is non-standard, but hey).
...Actually there is one more thing that is not working: cannot bind raw sequences in micro via bind command.
@blunderful-scripts While micro's existing support for raw escape bindings is indeed not quite perfect and could be improved (e.g. with JoeKar's fixes), I think it would not help you with your specific problem. If you see this when pressing CtrlShiftLeft and CtrlShiftRight:
EventKey: Left: "\x1bOD"
EventKey: Right: "\x1bOC"
it means that your problem is that your terminal sends CtrlShiftLeft and CtrlShiftRight using the same escape sequences as for Left and Right. So micro treats them as Left and Right (it has no choice).
So, if these raw bindings worked:
"\x1bOC": "SelectWordRight",
"\x1bOD": "SelectWordLeft",
the result would be: CtrlShiftLeft and CtrlShiftRight select words, but Left and Right also select words, instead of simply moving the cursor. Which is probably not what you want.
So the only advice here: fix your terminal.
@JoeKar So IIUC, raw escape bindings generally work, they only don't work if the same escape is also recognized as a known key event (and your PR https://github.com/zyedidia/tcell/pull/25 fixes that), right?
So IIUC it is not a very critical issue (or even just a philosophical question about which of the two bindings should take precedence: the normal binding or the raw binding), since if it is recognized as a known key, the user can just use a normal keybinding. (The purpose of raw keybindings is actually to be a last resort for the cases when a sequence is not recognized as a known key.)
Still, it is probably worth fixing, at least to avoid the user's confusion when the user does use a raw keybinding (even though doesn't need to) and it doesn't work.
Quoting myself:
Yeah, arguably it is a bug: micro does not attempt to properly parse \x-escaped strings, instead it simply relies on the JSON parser which does not support \x either, so the resulting behavior is non-intuitive and undocumented.
I was a bit wrong: the documentation in help keybindings does mention the \u notation.
But users don't necessarily carefully read the documentation or are very familiar with json, so adding support for \x notation in bindings.json would still be nice.
it means that your problem is that your terminal sends CtrlShiftLeft and CtrlShiftRight using the same escape sequences as for Left and Right
It is not the same sequence though. I get this for LeftArror and Right Arror (checking in raw):
EventKey: Left: "\x1b[D"
EventKey: Right: "\x1b[C"
This for CtrlSfhitLeft and Right:
EventKey: Left: "\x1bOD"
EventKey: Right: "\x1bOC"
I really don't understand much about how the interpretation of escape sequences work, But I'd like to ask: maybe the way to go is detect the terminal more carefully and bind different sequences to different terminals? I don't know if there is a way for micro to know that I'm using Mobaxterm, so this may be a moot point, but I thought i'd ask it anyway.
It is not the same sequence though. I get this for LeftArror and Right Arror (checking in raw):
Got it. I've been assuming that if the event received by micro from tcell is the same, e.g. Left, it means that the terminal escape sequence that originated it is the same too. Apparently it's not always the case, i.e. tcell may convert different escape sequences (from the same terminal) to the same event.
So yeah, I was wrong, using raw escape keybindings should be a good workaround for this particular problem. (Only that it doesn't work, as you've found. But it should work with @JoeKar's PRs. I haven't tested them myself yet, but I'm going to.)
maybe the way to go is detect the terminal more carefully and bind different sequences to different terminals? I don't know if there is a way for micro to know that I'm using Mobaxterm, so this may be a moot point, but I thought i'd ask it anyway.
It's a moot topic. The tcell library (the library used by micro, in particular, for receiving events from the terminal) distinguishes between terminals via the TERM environment variable, and then it cares a lot to correctly interpret different sequences from different terminals (but it will never be perfect). But that is how it works on Unix systems. On Windows it works very differently, I have no idea how exactly.
It's a moot topic. The tcell library (the library used by micro, in particular, for receiving events from the terminal) distinguishes between terminals via the TERM environment variable, and then it cares a lot to correctly interpret different sequences from different terminals (but it will never be perfect). But that is how it works on Unix systems. On Windows it works very differently, I have no idea how exactly.
Ok, then another question: is there a way to manually communicate to tcell (or micro) the correct terminal so one of them knows to assign correct actions to correct sequences? I know that there is an option to launch micro with --xterm (or something similar) option, so maybe there is a way to add a similar option for other terminals (as the need arises)? or is this too complicated?
I mean, personally I'm fine with figuring out the correct escape sequences and manually changing the config. But then I'm not the only one using this software, and wouldn't it be nice to have this option so people don't need to figure all this out on their own?
@JoeKar So IIUC, raw escape bindings generally work, they only don't work if the same escape sequence is also recognized as a known key event (and your PR zyedidia/tcell#25 fixes that), right?
Yes, it was, but...
it helps testing raw events, because you can simply assign the raw event of a known key and all involved chains can be covered
according to your hint regarding the unbind command it now supports unregistering the raw sequences too :wink:.
Ok, then another question: is there a way to manually communicate to tcell (or micro) the correct terminal so one of them knows to assign correct actions to correct sequences?
On Linux and other Unix systems, the way you tell micro the correct terminal is by setting the TERM env variable (if the terminal itself hasn't properly set it already), and if a particular terminal is not properly supported by tcell yet, you are free to contribute. On Windows, I don't know.
...I've just realized that your situation is a bit peculiar: micro is running on Linux (via SSH), while the terminal is running on Windows, right? So, micro (and tcell) actually thinks that it is running in a Unix terminal, not a Windows one. And yet micro is working for you, so I guess MobaXTerm behaves like a Unix terminal, so it might be good news: you may not need to care about the fact that it is running on Windows, so you may try to add missing support for MobaXterm to https://github.com/zyedidia/tcell/tree/master/terminfo as a unix terminal, and then accordingly set e.g. TERM=mobaxterm (on your remote Debian machine) to tell micro and tcell that it is running in MobaXterm.
Or maybe the entire problem should be approached differently, e.g. maybe MobaXterm properly emulates xterm (so no need to add special support for MobaXterm) but there is some bug in tcell. So I would try debugging tcell, to figure out why exactly does it e.g. report the same Left key event for both \x1b[D and \x1bOD.
...I don't use Windows, but if I was you, I would maybe start with simple experiments like: try using other Windows terminals and compare the behavior (to see if this is an issue with MobaXterm or with Windows terminals in general), try running micro locally on Windows instead of SSH and compare the behavior, try running apps other than micro (e.g. vim) and compare the behavior, and so on.
if I was you, I would maybe start with simple experiments like: try using other Windows terminals
On Putty, it's exact same behavior as in MobaXterm, and exact same raw escape sequences.
on Kitty, CtrlShiftRight & Left work in micro correctly. Raw output:
(for CtrlShiftLeft & Right)
EventKey: Shift-Ctrl-Left: "\x1b[1;6D"
EventKey: Shift-Ctrl-Right: "\x1b[1;6C"
(for Left & Right)
EventKey: Left: "\x1b[D"
EventKey: Right: "\x1b[C"
I'm starting to wonder if the Putty escape sequences for CtrlShiftLeft & Right are specific to Putty and Putty-like terminals (which MobaXterm might be for this matter), in which case it would make sense to just map them to the correct commands in tcell (or in micro).
I can try to look at the tcell code but chances that I can figure this out are quite slim, since I really know nothing about Go.
One thing I'm noticing while trying to make some sense of the code is that some/all "import" commands in these files point to non-existing paths. e.g. import "github.com/zyedidia/tcell/v2/terminfo"
There is no v2 under tcell/
I did find some references to x1bOC and x1bOD being used by vt100 terminals or similar. References:
https://studmed.uio.no/elaring/voila/venv/lib/python3.9/site-packages/prompt_toolkit/input/ansi_escape_sequences.py
http://www.manmrk.net/tutorials/ISPF/XE/xehelp/html/HID00000594.htm
https://github.com/SDL-Hercules-390/hyperion/blob/master/hconsole.h
I may be wrong but I suspect that someone mistakenly copy-pasted these escape sequences into tcell without checking whether they indeed apply to xterm.
After some google-fu, I found this website which goes into (very much) detail about keyboard escape seqeunces. To say that I understand less than 5% of it is an understatement. However, this passage seems quite clear.
This is less clear [to me] but probably useful to someone here:
Here's the page, in case someone smarter than myself can decode what's written in it.
https://invisible-island.net/xterm/terminfo-contents.html#tic-xterm_with_cursor_keys_in_normal_mode
On Putty, it's exact same behavior as in MobaXterm, and exact same raw escape sequences.
on Kitty, CtrlShiftRight & Left work in micro correctly. Raw output:
It seems you already gave the answer by yourself between the lines:
https://superuser.com/questions/1223266/shift-arrow-keys-working-in-kitty-but-not-putty-for-nested-tmux-configuration
https://stackoverflow.com/questions/6202310/putty-shift-arrows
https://superuser.com/questions/1036283/mobaxterm-doesnt-correctly-pass-ctrl-shift-arrow-sequences
https://github.com/github/putty/blob/master/terminal.c#L6834
PuTTY isn't able to transmit the correct key code not matter if application mode is set or not and how TERM is set...tcell can't fix this, as long as it receives the same key code for e.g. left and c-s-left.
Now it seems that MobaXterm behaves like PuTTY or even uses the same code base:
Mobaxterm is based on PuTTY (starting with its source-code), and adds some key-bindings to imitate xterm, but the set of key-bindings is not complete.
What you can try to do is if cat reports exactly the same as the raw mode of micro or not, because this bypasses tcell:
https://superuser.com/questions/1536450/why-is-tmux-not-recognizing-ctrlshiftarrow-through-mobaxterm
tcell can't fix this, as long as it receives the same key code for e.g. left and c-s-left.
As I mentioned above, the actual escape codes are not the same for c-s-left and for left. The escape code MobaXterm transmits for c-s-left (as reported by cat) is ^[OD and for left it's ^[[D. It so happens that (as far as I understand) ^[OD is the same as some old VT100 terminals were using for 'left'. I couldn't really figure out whether any modern computer actually transmits this for 'left' but my impression is that it's a thing of the past that somehow made its way into xterm and consequently into tcell. That's (in my understanding) what this abovementioned passage says.
The original assignments from patch #94 for cursor-keys had some technical issues .... For these reasons, the original assignments were deprecated. For compatibility reasons, they are still available as a setting of xterm's modifyCursorKeys resource.
So what I'm saying is, perhaps there is no need to force anyone who uses Putty and Putty-based terminals to "live with it" or to modify the config file, if there is a simple solution of programmatically interpreting the (likely no-longer used) VT100 escape sequence for 'left' as (actually actively used by many people) Putty escape sequence for c-s-left.
As I mentioned above, the actual escape sequences are not the same for c-s-left and for left.
Ok, then we've at least the chance to handle this.
But before we go further into tcell please test some other stuff:
change switch between application and normale mode in PuTTY and/or MobaXterm and see if the respective code for your sequences changes
force with PuTTY and/or MobaXterm to indicate the TERM other than xterm (at least PuTTY should be able to do so) to something unknown to tcell (e.g. TERM=putty).
With the last hint tcell will fallback to a dynamical terminfo (best guess) setting and maybe this changes something. In case not it's a good point start hacking. But most probably a dedicated setting for PuTTY/MobaXterm in tcell is better approach.
I know that there is an option to launch micro with --xterm [...]
The option xterm set to true will only overwrite a possible set TERM with xterm, which is...as far as I read...the setting of PuTTY(-likes) too.
change switch between application and normale mode in PuTTY and/or MobaXterm and see if the respective code for your sequences changes
force with PuTTY and/or MobaXterm to indicate the TERM other than xterm (at least PuTTY should be able to do so) to something unknown to tcell (e.g. TERM=putty).
Tested in putty (because I don't know if it's even possible to switch between application mode and normal mode in mobaxterm".
Both settings don't affect transmitted/received escape sequences for c-s-left and c-s-right.
That said, reading the putty user manual, I became aware that the 2 modes (normal and application) seem to be still a thing, I'm not sure for what purpose.
https://documentation.help/PuTTY/config-appcursor.html
Now according to that manual, this is supposed to be set by the server, although the client (putty) can disable the application mode. I can't tell whether anybody or anything is still using the application mode, but if
Forgot to mention that also, changing both settings doesn't affect how micro reacts to c+s+left and c+s+right when editing (i.e. the result is still the same as pressing 'left' and 'right').
Ok, tried it myself and realized that PuTTY simply doesn't forward the Shift as a modifier key and therefore Left = Shift+Left and Ctrl+Left = Ctrl+Shift+Left. From my point of view this is a limitation/bug of PuTTY and can't be (simply) solved, without changing PuTTY itself.
Ok, tried it myself and realized that PuTTY simply doesn't forward the Shift as a modifier key and therefore Left = Shift+Left and Ctrl+Left = Ctrl+Shift+Left. From my point of view this is a limitation/bug of PuTTY and can't be (simply) solved, without changing PuTTY itself.
Interesting - I confirm that this is the behavior in putty. However, this is not the behavior in mobaxterm.
raw in micro:
pressing Left: EventKey: Left: "\x1b[D"
pressing Shift-Left: EventKey: Shift-Left: "\x1b[1;2D"
pressing Ctrl+Left: EventKey: Ctrl-Left: "\x1b[1;5D"
pressing Ctrl+Shift+Left: EventKey: Left: "\x1bOD"
That said, I don't want to waste your time on mobaxterm-specific solution, specifically for me. So unless other people need this, probably this issue can be closed. (especially if I can assign the raw escape sequence in the config file after your fix gets merged)
I have to confess that I was not patient enough to read all the 100+ comments here. Still I hope I can be relevant.
I am new to micro, so I read the documentation. When I realise that micro does not work through ssh/tmux/... because it gets the escape sequences and does not interpret them, I started looking for why and failed (it seems either documentation is oblivious about escapes not supported [yes I see the mention, but not the resolution], or maybe it's supported but my version isn't latest, v2.11).
Anyway. The documentation talks about \x1b, and 0x1b and it seems neither works (as they are) in the config. \uXXXX seems to be vaguely mentioned but it's not obvious for the causal reader that despite how it's referred to and how raw mode displays the \u001b form is what works, others aren't. This is mainly the problem of the documentation (it should be spelled out that \x1b shall be written as \u001b), but inconsistent with raw output as well.
Summarizing:
the page keybindings.md >> Binding raw escape sequences shall be consistent about ESC format and be unabiguous about how the config file expects it.
either \x1b should work in config file or raw should be fixed?
a few words about what's expected through xterm->ssh->tmux (I get \x1b[1;5C for CtrlRight which shall be in fact WordRight in config).
doc as well: may mention that how the current bindings could be printed. If possible, I mean. :-)
either \x1b should work in config file or raw should be fixed?
It would work with the config files as well, when zyedidia/json5#1 would be merged. Unfortunately I can't speed this up, since I've no merge rights. Afterwards the dependency within micro needs to be bumped.
a few words about what's expected through xterm->ssh->tmux (I get \x1b[1;5C for CtrlRight which shall be in fact WordRight in config).
From my perspective this highly depends on the users local scenario and mentioned every possibility is too much for the documentation of micro itself. But I confirm, that the documentation should be consistent.
doc as well: [...]
Currently it makes no sense, at least in my opinion, because that part need to be changed again after the above mentioned PR is merged (if and when ever). But everyone is encouraged to support with his own PR. :wink:
From my perspective this highly depends on the users local scenario and mentioned every possibility is too much for the documentation of micro itself. But I confirm, that the documentation should be consistent.
I meant a brief list what's included and what's not, like:
micro contains by default handling local X terminals on Linux, character console, etc.
default doesn't handle \x1b[xx;yy escape sequences, these can be included from example-binding-esc.json file
β¦
I have started writing bindings for ESC[ sequences but I was wondering whether it's already have been created somewhere by someone, since I do not like to reinvent warm water.
I am too fresh meat here to start rewriting the docs, so I ask around first! :-)
But that one contained an implicite question as "can I print the current bindings please?" ;-)
|
2025-04-01T04:36:03.307426
| 2024-10-01T00:58:32
|
2557943400
|
{
"authors": [
"Andriamanitra",
"Drsheppard01",
"JoeKar",
"niten94"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12400",
"repo": "zyedidia/micro",
"url": "https://github.com/zyedidia/micro/issues/3488"
}
|
gharchive/issue
|
issue with highlighting
Text of error:
Error parsing syntax file sh: interface conversion: interface {} is nil, not []interface {}
Commit hash: 2.0.14
OS: Chimera Linux (it uses Musl)
Terminal: Gnome Console 47.1
P.S. When I wrote this issue and checked the available versions, I tried the nightly build and the nightly build didn't have this problem.
Could you please make new release?
I am unable to reproduce the error on 2.0.14. Does this happen even if you start micro with a clean config directory [^1]? If not, please share your sh syntax file (typically located under ~/.config/micro/syntax/) β there is likely a mistake in it.
[^1]: you can specify a temporary directory as the config directory by running micro -config-dir $(mktemp -d)
I tried testing a bit but I think the error occured because sh.yaml in master was copied and used. Empty rules did not have to be defined anymore in regions when #3458 was merged after v2.0.14 was released so they have been removed in builtin syntax files. Syntax files in v2.0.14 can be seen in this link or when switching to the tag in the file list page:
https://github.com/zyedidia/micro/tree/v2.0.14/runtime/syntax
I was thinking that it may be better to add a notice about incompatibility that can be seen when looking at runtime files on GitHub, but README.md in directories cannot be easily seen when looking at files or directories with a lot of files.
I tried testing a bit but I think the error occured because sh.yaml in master was copied and used. Empty rules did not have to be defined anymore in regions when #3458 was merged after v2.0.14 was released so they have been removed in builtin syntax files.
Indeed this sounds to be the most likely case.
I was thinking that it may be better to add a notice about incompatibility that can be seen when looking at runtime files on GitHub, but README.md in directories cannot be easily seen when looking at files or directories with a lot of files.
No, the README.md is not a good place for that and offers a high risk to be ignored.
Since the runtime files (colorschemes, plugins and syntax) files highly depend on the related SW interfaces it is better to add a kind of a interface version description into these files. On incompatible changes they should be incremented on both sides as well as checked for compatibility in SW. If they don't fit a precise error message is the better way to tell the user what's going wrong.
|
2025-04-01T04:36:03.348937
| 2023-05-28T11:56:04
|
1729419443
|
{
"authors": [
"StefH",
"VyacheslavGarshin",
"zspitz"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12402",
"repo": "zzzprojects/System.Linq.Dynamic.Core",
"url": "https://github.com/zzzprojects/System.Linq.Dynamic.Core/issues/710"
}
|
gharchive/issue
|
Is there a way to convert lambda where expression into string representaion?
Use case is that I have an endpoint which accepts a filter part as string.
I'm going to create a client application on .net and construct this filter part from the models I have from the server.
Is there method like in this example string filter = Customers.Where(x => x.Name.Contains("apple")).ToDynamicLinqFilter()?
Tried to find it on stackoverflow and source code with no avail.
If your Where returns an IQueryable, every IQueryable has an Expression property, returning an expression tree representing the query.
I've written a library which creates strings from expression trees; one of the available representations is Dynamic LINQ:
var qry = Customers.Where(x => x.Name.Contains("apple"));
var expr = qry.Expression
string filter = expr.ToString("Dynamic LINQ", "C#");
Great project! Why there is no nuget package though?
Great project! Why there is no nuget package though?
https://www.nuget.org/packages/ExpressionTreeToString/
My bad=) Have been looking Installation section in readme. Thanks a lot!
@VyacheslavGarshin
Can I close your question since it's resolved by ExpressionTreeToString?
My bad=) Have been looking Installation section in readme. Thanks a lot!
Sure! And it would be nice to have some mentioning of the solution in documentation. This is a usual case in using API based on DynamicLinq and should help to promote it.
|
2025-04-01T04:36:03.354414
| 2024-01-27T12:23:29
|
2103566311
|
{
"authors": [
"JonathanMagnan",
"ovolkov"
],
"license": "mit",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12403",
"repo": "zzzprojects/html-agility-pack",
"url": "https://github.com/zzzprojects/html-agility-pack/issues/534"
}
|
gharchive/issue
|
it happened again after a Rolled back to version HtmlAgilityPack 1.11.50, then again to HtmlAgilityPack 1.11.57 and it worked.
Rolled back to version HtmlAgilityPack 1.11.50, then again to HtmlAgilityPack 1.11.57 and it worked.
Microsoft VisualΒ Studio CommunityΒ 2022
Originally posted by @ovolkov in https://github.com/zzzprojects/html-agility-pack/issues/533#issuecomment-1913137152
Hello @ovolkov ,
We will close this issue as I'm not sure exactly if there is still an issue or not.
Look like, with your last comment everything is working correctly.
Best Regards,
Jon
Hi, see issue #535. Ver.1.11.50 worked fine, but next versions is broken
ΠΏΠ½, 29 ΡΡΡ. 2024 Ρ., 00:17 ΠΊΠΎΡΠΈΡΡΡΠ²Π°Ρ Jonathan Magnan <
@.***> ΠΏΠΈΡΠ΅:
Closed #534 https://github.com/zzzprojects/html-agility-pack/issues/534
as completed.
β
Reply to this email directly, view it on GitHub
https://github.com/zzzprojects/html-agility-pack/issues/534#event-11621041277,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC6BHF2RLPGJHTBNB6CSMI3YQ3E77AVCNFSM6AAAAABCNKIWEOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGYZDCMBUGEZDONY
.
You are receiving this because you were mentioned.Message ID:
@.***
com>
|
2025-04-01T04:36:03.375629
| 2023-04-19T15:58:38
|
1675198177
|
{
"authors": [
"justinmccann14"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12404",
"repo": "1904labs/Svelvet",
"url": "https://github.com/1904labs/Svelvet/pull/3"
}
|
gharchive/pull-request
|
RD-154 - Disable creation of nodes when dragging edge
Merging since this repo is irrelevant now anyways.
|
2025-04-01T04:36:03.387456
| 2022-05-13T12:57:45
|
1235211271
|
{
"authors": [
"dpad85",
"nfillion21"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12405",
"repo": "ACINQ/phoenix",
"url": "https://github.com/ACINQ/phoenix/pull/275"
}
|
gharchive/pull-request
|
Allows payment options
This PR gives access to a screen which presents four payments settings
Overriding default invoice description
This payment settings is used in invoices. It allows to override the default description.
Overriding default invoice expiry
This payment settings is used in invoices. It allows to override the default expiry in seconds.
Overriding default fees for outgoing payments
This payment settings is used in payments. The trampoline max base and proportional fees is overriden.
On-the-fly channels
This payment settings cannot be overriden, I just provide a dialog view with a link to the FAQ.
I added a slider to facilitate the payment expiry.
I reworked this PR. The payment options dialogs have been fixed and improved (especially the trampoline max fee dialog).
I've also added several components:
a Checkbox one which contains a clickable label)
a NumberInput component that also does some basic validation and return a Double
the AmountInput component which could completely change its look if the useBasicInput parameter was set has been separated into 2 components. AmountInput is the regular one, it looks like the other inputs and uses the material style. The AmountHeroInput is a component designed to be in the center of a screen (e.g. the screen to send payments). Both can do some validation and use the same method to do so.
|
2025-04-01T04:36:03.393525
| 2023-04-18T21:44:03
|
1673870154
|
{
"authors": [
"esclapez"
],
"license": "BSD-3-Clause",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12406",
"repo": "AMReX-Combustion/PeleLMeX",
"url": "https://github.com/AMReX-Combustion/PeleLMeX/pull/197"
}
|
gharchive/pull-request
|
Add an amr.regrid_on_restart option.
If you want to restart and add level(s) right away or change your tagging criterion right from the start. Otherwise, you will have to wait until the next amr.regrid_int. And even then, regrid is not recursive so that it can only adds a single level each time it is called even if you've increased your amr.max_level by 2.
|
2025-04-01T04:36:03.432846
| 2022-10-20T07:26:52
|
1416110673
|
{
"authors": [
"codecov-commenter",
"zacchaeuschok"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12407",
"repo": "AY2223S1-CS2103-W14-1/tp",
"url": "https://github.com/AY2223S1-CS2103-W14-1/tp/pull/88"
}
|
gharchive/pull-request
|
Add price range command
Codecov Report
Merging #88 (cfe2399) into master (0c07c31) will decrease coverage by 0.68%.
The diff coverage is 45.88%.
@@ Coverage Diff @@
## master #88 +/- ##
============================================
- Coverage 60.35% 59.67% -0.69%
- Complexity 524 533 +9
============================================
Files 104 108 +4
Lines 1897 1969 +72
Branches 224 236 +12
============================================
+ Hits 1145 1175 +30
- Misses 673 708 +35
- Partials 79 86 +7
Impacted Files
Coverage Ξ
...onery/logic/commands/client/EditClientCommand.java
79.66% <ΓΈ> (ΓΈ)
.../logic/commands/property/RangePropertyCommand.java
0.00% <0.00%> (ΓΈ)
.../seedu/condonery/logic/parser/CondoneryParser.java
75.00% <0.00%> (-3.27%)
:arrow_down:
...ic/parser/property/RangePropertyCommandParser.java
0.00% <0.00%> (ΓΈ)
...el/property/PropertyPriceWithinRangePredicate.java
0.00% <0.00%> (ΓΈ)
...ava/seedu/condonery/model/util/SampleDataUtil.java
15.00% <0.00%> (ΓΈ)
src/main/java/seedu/condonery/ui/PropertyCard.java
0.00% <0.00%> (ΓΈ)
.../java/seedu/condonery/logic/parser/ParserUtil.java
84.84% <42.85%> (-11.31%)
:arrow_down:
...a/seedu/condonery/storage/JsonAdaptedProperty.java
72.97% <50.00%> (-7.03%)
:arrow_down:
...ain/java/seedu/condonery/model/property/Price.java
72.72% <72.72%> (ΓΈ)
... and 6 more
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
|
2025-04-01T04:36:03.436077
| 2022-11-10T12:52:48
|
1443857006
|
{
"authors": [
"codecov-commenter",
"fongyj"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12408",
"repo": "AY2223S1-CS2103T-T11-3/tp",
"url": "https://github.com/AY2223S1-CS2103T-T11-3/tp/pull/189"
}
|
gharchive/pull-request
|
Add back to top button at end of every section
Codecov Report
Merging #189 (4e43277) into master (f08172a) will not change coverage.
The diff coverage is n/a.
@@ Coverage Diff @@
## master #189 +/- ##
=========================================
Coverage 69.63% 69.63%
Complexity 1006 1006
=========================================
Files 157 157
Lines 3217 3217
Branches 395 395
=========================================
Hits 2240 2240
Misses 879 879
Partials 98 98
:mega: Weβre building smart automated test selection to slash your CI/CD build times. Learn more
|
2025-04-01T04:36:03.437296
| 2023-10-20T09:14:39
|
1953872419
|
{
"authors": [
"asdfghjkxd"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12409",
"repo": "AY2324S1-CS2103T-T17-1/tp",
"url": "https://github.com/AY2324S1-CS2103T-T17-1/tp/issues/71"
}
|
gharchive/issue
|
Sort Task by Status, Deadline and Priority
Reopened as the Sort by Priority feature is not complete.
Feature is now complete.
|
2025-04-01T04:36:03.477781
| 2023-03-24T00:08:43
|
1638514788
|
{
"authors": [
"znmeb"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12410",
"repo": "AlgoCompSynth/CLAMS",
"url": "https://github.com/AlgoCompSynth/CLAMS/issues/37"
}
|
gharchive/issue
|
Document musical philosophy
Preliminary high points:
Xenakis meets Sethares:
all levels of a composition must allow appropriate stochastic elements
synthesis and and scales have consonance estimates and composition / performance tools can read and write them
Sweet spot is small ensembles:
low clock rate and small RAM limit the amount of audio that can be computed at practical sampling rates by an RP2040
this leads to the need to trade off between a higher-quality of a single voice and multiple lower-quality voices.
|
2025-04-01T04:36:03.505154
| 2023-07-11T22:47:49
|
1799863678
|
{
"authors": [
"azure-sdk",
"swathipil"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12411",
"repo": "Azure/azure-sdk-for-python",
"url": "https://github.com/Azure/azure-sdk-for-python/pull/31085"
}
|
gharchive/pull-request
|
[SchemaRegistry] regenerate + update typing
API change check
API changes are not detected in this pull request.
|
2025-04-01T04:36:03.507606
| 2022-01-14T17:19:45
|
1103931380
|
{
"authors": [
"cataggar"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12412",
"repo": "Azure/azure-sdk-for-rust",
"url": "https://github.com/Azure/azure-sdk-for-rust/pull/613"
}
|
gharchive/pull-request
|
add source for errors in generated services
This currently prints:
PS C:\Users\cataggar\io\azure-sdk-for-rust\services\svc\batch> cargo run --package azure_svc_batch --example create_task_thiserror -- a b c d e
Finished dev [unoptimized + debuginfo] target(s) in 0.52s
Running `C:\Users\cataggar\io\azure-sdk-for-rust\services\target\debug\examples\create_task_thiserror.exe a b c d e`
creating job
- batch error
- Failed to execute request: policy error
error: process didn't exit successfully: `C:\Users\cataggar\io\azure-sdk-for-rust\services\target\debug\examples\create_task_thiserror.exe a b c d e` (exit code: 1)
You can see policy error printed, but it doesn't have a source. That is fixed in #613. After that is merged:
PS C:\Users\cataggar\io\azure-sdk-for-rust\services\svc\batch> cargo run --package azure_svc_batch --example create_task_thiserror -- a b c d e
Finished dev [unoptimized + debuginfo] target(s) in 0.50s
Running `C:\Users\cataggar\io\azure-sdk-for-rust\services\target\debug\examples\create_task_thiserror.exe a b c d e`
creating job
- batch error
- Failed to execute request
- policy error
- failed to execute request
- error sending request for url (https://a.b.batch.azure.com/jobs?api-version=2022-01-01.15.0): error trying to connect: dns error: No such host is known. (os error 11001)
- error trying to connect: dns error: No such host is known. (os error 11001)
- dns error: No such host is known. (os error 11001)
- No such host is known. (os error 11001)
error: process didn't exit successfully: `C:\Users\cataggar\io\azure-sdk-for-rust\services\target\debug\examples\create_task_thiserror.exe a b c d e` (exit code: 1)
You can see the reqwest::Error is printing is printing the sources in its error message: :/
- error sending request for url (https://a.b.batch.azure.com/jobs?api-version=2022-01-01.15.0): error trying to connect: dns error: No such host is known. (os error 11001)
I'm guessing here: https://github.com/seanmonstar/reqwest/blob/c6eb2c4fcbc3934b119772e0997d91671ff68dc7/src/error.rs#L192-L194
|
2025-04-01T04:36:03.512483
| 2022-03-28T06:06:37
|
1182938839
|
{
"authors": [
"jijopulikkottil"
],
"license": "BSD-3-Clause",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12413",
"repo": "BIDMCDigitalPsychiatry/LAMP-swift",
"url": "https://github.com/BIDMCDigitalPsychiatry/LAMP-swift/pull/23"
}
|
gharchive/pull-request
|
max frequency to 5
https://github.com/BIDMCDigitalPsychiatry/LAMP-platform/issues/541#issuecomment-1075141706
|
2025-04-01T04:36:03.521172
| 2024-11-28T17:36:24
|
2702864652
|
{
"authors": [
"bjsplat",
"deltakosh"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12414",
"repo": "BabylonJS/Babylon.js",
"url": "https://github.com/BabylonJS/Babylon.js/pull/15907"
}
|
gharchive/pull-request
|
Fix grad
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.
You have changed file(s) that make changes to the playground.
You can test the snapshot here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/15907/merge/
The snapshot playground with the CDN snapshot (only when available):
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/15907/merge/?snapshot=refs/pull/15907/merge
Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.
Snapshot stored with reference name:
refs/pull/15907/merge
Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15907/merge/index.html
To test a playground add it to the URL, for example:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15907/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/15907/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/15907/merge
https://gui.babylonjs.com/?snapshot=refs/pull/15907/merge
https://nme.babylonjs.com/?snapshot=refs/pull/15907/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/15907/merge#BCU1XR#0
Visualization tests for WebGPU (Experimental)
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15907/merge/testResults/webgpuplaywright/index.html
WebGL2 visualization test reporter:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15907/merge/testResults/webgl2playwright/index.html
|
2025-04-01T04:36:03.526431
| 2022-01-18T16:31:47
|
1107117772
|
{
"authors": [
"BernhardAhrens"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12415",
"repo": "BernhardAhrens/DAMMmodel.jl",
"url": "https://github.com/BernhardAhrens/DAMMmodel.jl/pull/1"
}
|
gharchive/pull-request
|
update to newer version, see what has changed
I have to move some files into newly created functions first to move them
|
2025-04-01T04:36:03.527527
| 2024-10-24T21:29:22
|
2612590852
|
{
"authors": [
"aymericdelab",
"edisontim"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12416",
"repo": "BibliothecaDAO/eternum",
"url": "https://github.com/BibliothecaDAO/eternum/pull/1905"
}
|
gharchive/pull-request
|
feat: simulate raid
amazing work on this - huge upgrade. Just some hard coded config values need fixing.
@credence0x should take the credit for this, I've merely re-used his simulateBattle script haha
lgtm
|
2025-04-01T04:36:03.544844
| 2023-03-16T00:42:46
|
1626492779
|
{
"authors": [
"BrianPugh",
"codecov-commenter"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12417",
"repo": "BrianPugh/python-template",
"url": "https://github.com/BrianPugh/python-template/pull/18"
}
|
gharchive/pull-request
|
Ruff
Codecov Report
Merging #18 (2f824bc) into main (49d1ff0) will not change coverage.
The diff coverage is n/a.
:mega: This organization is not using Codecovβs GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@ Coverage Diff @@
## main #18 +/- ##
=======================================
Coverage 11.11% 11.11%
=======================================
Files 3 3
Lines 18 18
Branches 1 1
=======================================
Hits 2 2
Misses 16 16
Flag
Coverage Ξ
unittests
11.11% <ΓΈ> (ΓΈ)
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
|
2025-04-01T04:36:03.580803
| 2022-10-20T07:17:00
|
1416098160
|
{
"authors": [
"CatChen"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12418",
"repo": "CatChen/accept-to-ship-action",
"url": "https://github.com/CatChen/accept-to-ship-action/pull/1115"
}
|
gharchive/pull-request
|
Fixed function name spelling
Current dependencies on/for this PR:
main
PR #1106
PR #1107
PR #1108
PR #1113
PR #1114
PR #1115 π
This comment was auto-generated by Graphite.
|
2025-04-01T04:36:03.599442
| 2016-03-05T06:36:18
|
138653752
|
{
"authors": [
"natebrennand",
"rgarcia"
],
"license": "apache-2.0",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12419",
"repo": "Clever/oplog-replay",
"url": "https://github.com/Clever/oplog-replay/pull/45"
}
|
gharchive/pull-request
|
add versioned golang.mk
@rgarcia / @kvigen: can we publicly archive this?
(I don't really want to figure out the broken tests for something we don't use anymore)
I can move to graveyard
KV pointed out there's a chance people are using it. Should we move to "ARCHIVE-..." for a month or two first?
sounds good, done
|
2025-04-01T04:36:03.602096
| 2019-02-01T19:05:08
|
405833372
|
{
"authors": [
"hmarcks",
"josephhess",
"maxkwallace"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12420",
"repo": "CodeForPortland/recordexpungPDX",
"url": "https://github.com/CodeForPortland/recordexpungPDX/issues/65"
}
|
gharchive/issue
|
implement views as react components
@josephhess Hey! I'm not trying to nag, just hoping to understand where the project is and what tasks are available for people to work on. How's this issue going, and do you have any in-progress code you can push up in a branch? If you're working on this I want to make sure that any changes I make in the frontend code aren't going to conflict with or duplicate what you're already working on.
I'm going to cancel this since we have a different frontend approach in progress.
|
2025-04-01T04:36:03.604559
| 2023-11-02T15:37:37
|
1974522878
|
{
"authors": [
"oshadura"
],
"license": "BSD-3-Clause",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12421",
"repo": "CoffeaTeam/docker-coffea-base",
"url": "https://github.com/CoffeaTeam/docker-coffea-base/pull/93"
}
|
gharchive/pull-request
|
Try to enable 3.8 and 3.9 python for cc7
Builds are broken for cc7 and almalinux for python < 3.10:
74.19 ImportError: /usr/local/lib/python3.9/site-packages/libmambapy/../../../libmamba.so.2: undefined symbol: solver_ruleinfo2str, version SOLV_1.0
|
2025-04-01T04:36:03.619885
| 2022-02-03T11:28:07
|
1122970392
|
{
"authors": [
"luke-feeney",
"sreyac"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12422",
"repo": "CriticalAssetManagement/CAMS",
"url": "https://github.com/CriticalAssetManagement/CAMS/issues/35"
}
|
gharchive/issue
|
Other asset operating dependencies (fuel, electricity, etc) β C/T
Part of Asset Inventory: Asset Data Requirements
|
2025-04-01T04:36:03.621972
| 2023-07-25T09:51:37
|
1819951019
|
{
"authors": [
"0xisk",
"0xmad"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12423",
"repo": "CryptKeeperZK/crypt-keeper-extension",
"url": "https://github.com/CryptKeeperZK/crypt-keeper-extension/issues/665"
}
|
gharchive/issue
|
feat: support RLNProver in Chrome via Offscreen
@0xisk can we close this issue?
Done: https://github.com/CryptKeeperZK/crypt-keeper-extension/blob/b973b943306a0c9d04eaceef5d9cced713526150/packages/app/src/offscreen/Offscreen.ts#L84
|
2025-04-01T04:36:03.634746
| 2023-05-22T14:36:21
|
1719832180
|
{
"authors": [
"simonwhatley"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12424",
"repo": "DFE-Digital/bat-design-history",
"url": "https://github.com/DFE-Digital/bat-design-history/pull/911"
}
|
gharchive/pull-request
|
Add post: Adding 'Study sites'
@Kateharries It might be a good idea to remove the link to the form to avoid spam.
Add βStudy siteβ section
|
2025-04-01T04:36:03.636294
| 2024-01-24T09:30:05
|
2097825620
|
{
"authors": [
"killij"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12425",
"repo": "DFE-Digital/childrens-social-care-cpd",
"url": "https://github.com/DFE-Digital/childrens-social-care-cpd/pull/385"
}
|
gharchive/pull-request
|
Perform release
:tada: This PR is included in version 2.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
|
2025-04-01T04:36:03.639873
| 2024-04-20T20:39:35
|
2254710146
|
{
"authors": [
"aakankshaduggal",
"thienantran010"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12426",
"repo": "DS219/spark-seprep",
"url": "https://github.com/DS219/spark-seprep/pull/120"
}
|
gharchive/pull-request
|
thienan tran: add assignment 8 md file and ss
Great job @thienantran010
Very well documented.
A++ π’ π
|
2025-04-01T04:36:03.659774
| 2024-09-01T15:42:23
|
2499547060
|
{
"authors": [
"FaheemorFAB",
"aqib-m31"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12427",
"repo": "Dev-Wizards/front-end-frenzy",
"url": "https://github.com/Dev-Wizards/front-end-frenzy/pull/4"
}
|
gharchive/pull-request
|
week 1
@FaheemorFAB You have to maintain a repository on your own account!
No need to make a PR here!
|
2025-04-01T04:36:03.714512
| 2024-04-17T11:30:57
|
2248065024
|
{
"authors": [
"codecov-commenter",
"dt-team-kubernetes"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12428",
"repo": "Dynatrace/dynatrace-operator",
"url": "https://github.com/Dynatrace/dynatrace-operator/pull/3019"
}
|
gharchive/pull-request
|
Adapt csv files for release version 1.0.1
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 67.86%. Comparing base (cf8e5c7) to head (329a015).
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## release-1.0 #3019 +/- ##
===============================================
- Coverage 67.87% 67.86% -0.02%
===============================================
Files 250 250
Lines 13673 13673
===============================================
- Hits 9281 9279 -2
- Misses 3585 3586 +1
- Partials 807 808 +1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
|
2025-04-01T04:36:03.716395
| 2022-10-31T19:41:40
|
1430390808
|
{
"authors": [
"kovacsv",
"tlorantfy"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12429",
"repo": "ENZYME-APD/tapir-archicad-automation",
"url": "https://github.com/ENZYME-APD/tapir-archicad-automation/issues/32"
}
|
gharchive/issue
|
Move Elements
I've already implemented this in my project, see https://github.com/tlorantfy/archicad-additional-json-commands
I've started to merge it to this project.
|
2025-04-01T04:36:03.722728
| 2023-01-16T15:15:28
|
1535097905
|
{
"authors": [
"Panquesito7",
"ashutosh0022"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12430",
"repo": "EddieHubCommunity/hacktoberfest-practice",
"url": "https://github.com/EddieHubCommunity/hacktoberfest-practice/pull/2386"
}
|
gharchive/pull-request
|
Added my name Ashutosh Biswal
Kindly tell me, how to remove the .DS_Store and .github/.DS_Store files.
It is my first contribution in open source, so a bit confused.
If you're using the GitHub web, follow these steps:
Go to your fork.
Click on the .DS_Store file.
Next, click on the small trash can icon. You will be prompted to create a commit.
Follow the same steps, but for the .github/.DS_Store file now.
If you need any help, let us know. π
If you're using the GitHub web, follow these steps:
Go to your fork.
Click on the .DS_Store file.
Next, click on the small trash can icon. You will be prompted to create a commit.
Follow the same steps, but for the .github/.DS_Store file now.
If you need any help, let us know. π
Yes sir, I did what you mentioned.
What should I do next, so that my name appears in the main https://github.com/EddieHubCommunity/hacktoberfest-practice
|
2025-04-01T04:36:03.732135
| 2023-11-12T08:49:01
|
1989310019
|
{
"authors": [
"Dimenpsyonal",
"ccuser44"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12431",
"repo": "Epix-Incorporated/Adonis",
"url": "https://github.com/Epix-Incorporated/Adonis/pull/1269"
}
|
gharchive/pull-request
|
Add backwards compatibility code to a dedicated plugin
Does this redirect functions automatically
Does this redirect functions automatically
The behavior is the same as before. I think yes.
Idk I can't merge based on "I think"
Yes it is. it does the same thing expect from a plugin
|
2025-04-01T04:36:03.754444
| 2022-06-16T10:18:17
|
1273359127
|
{
"authors": [
"Fdawgs",
"coveralls"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12432",
"repo": "Fdawgs/docsmith",
"url": "https://github.com/Fdawgs/docsmith/pull/896"
}
|
gharchive/pull-request
|
chore: remove redundant async keywords
Pull Request Test Coverage Report for Build<PHONE_NUMBER>
0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%
Totals
Change from base Build<PHONE_NUMBER>:
0.0%
Covered Lines:
562
Relevant Lines:
562
π - Coveralls
|
2025-04-01T04:36:03.770746
| 2023-03-21T01:33:15
|
1633097276
|
{
"authors": [
"austinFlipside",
"sam-xyz"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12433",
"repo": "FlipsideCrypto/bsc-models",
"url": "https://github.com/FlipsideCrypto/bsc-models/pull/40"
}
|
gharchive/pull-request
|
fixing cast
@sam-xyz this will be fixed with the streamline pivot, see silver.transactions2
completed with migration
|
2025-04-01T04:36:03.808845
| 2023-10-03T16:39:02
|
1924531863
|
{
"authors": [
"GhadgeGauri",
"Sankalp20Tiwari",
"gauriiighadge",
"kittoteja",
"vaishnavin01"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12434",
"repo": "GhadgeGauri/HactoberFest23",
"url": "https://github.com/GhadgeGauri/HactoberFest23/issues/8"
}
|
gharchive/issue
|
cpp program to add two numbers
pls assign me
I like to contribute in this issue
pls assign me
I would be highly obiliged to work on this issue. So I request you to assign me this issue.
|
2025-04-01T04:36:03.813812
| 2024-08-26T23:46:15
|
2487979562
|
{
"authors": [
"developer982",
"tomayac"
],
"license": "apache-2.0",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12435",
"repo": "GoogleChromeLabs/browser-fs-access",
"url": "https://github.com/GoogleChromeLabs/browser-fs-access/pull/155"
}
|
gharchive/pull-request
|
Create devcontainer.json
Looks like this is only relevant in certain circumstances. I don't want to clutter the repo with configuration files, so I'm closing this PR.
|
2025-04-01T04:36:03.819044
| 2024-01-10T23:53:15
|
2075415932
|
{
"authors": [
"DevoFalcon",
"g-awmalik"
],
"license": "apache-2.0",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12436",
"repo": "GoogleCloudPlatform/terraform-google-secret-manager",
"url": "https://github.com/GoogleCloudPlatform/terraform-google-secret-manager/issues/55"
}
|
gharchive/issue
|
The module should allow secrets to be created without requiring secrets data to be set
This features gives a "key definition error" when supplying generated secret_data
module "secrets" {
source = "../../modules/secrets"
secrets = [
{
name = "sa_secrets",
secret_data = google_service_account_key.key.private_key
}
]
project_id = var.project_id
}
...
β Error: Invalid for_each argument
β
β on ../../modules/secrets/main.tf line 37, in resource "google_secret_manager_secret_version" "secret_version":
β 37: for_each = { for secret in var.secrets : secret.name => secret if can(secret.secret_data) }
β βββββββββββββββββ
β β var.secrets is list of object with 1 element
β
β The "for_each" map includes keys derived from resource attributes that cannot be determined until apply, and so Terraform cannot determine the full set of keys that will identify the instances
β of this resource.
β
β When working with unknown values in for_each, it's better to define the map keys statically in your configuration and place apply-time results only in the map values.
β
β Alternatively, you could use the -target planning option to first apply only the resources that the for_each value depends on, and then apply a second time to fully converge.
I don't fully understand why, since the secret_data is not in the key. Any advice for fixing this?
I see this was also referenced in https://github.com/GoogleCloudPlatform/terraform-google-secret-manager/issues/15. It seems like this module can't be used with generated secret data
|
2025-04-01T04:36:03.831422
| 2022-01-31T16:09:37
|
1119628902
|
{
"authors": [
"CanadaHonk",
"CoderLogy",
"VilotStar"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12437",
"repo": "GooseMod/GooseMod",
"url": "https://github.com/GooseMod/GooseMod/issues/64"
}
|
gharchive/issue
|
How to uninstall googse mod and is it safe mod do you collect data or something like passwords etc
Please use the Discord for support and Q&A (as already said). This is for issues like bugs. The answer to your latter question is also no.
I'm still quite confused as to why the uninstall button in goosemod was removed, was it a security flaw or something?
You cannot just uninstall GooseMod from within the client.
Yeah confusing, it makes it difficult to uninstall
On Sun, May 22, 2022, 7:35 PM ElonGates @.***> wrote:
I'm still quite confused as to why the uninstall button in goosemod was
removed, was it a security flaw or something?
β
Reply to this email directly, view it on GitHub
https://github.com/GooseMod/GooseMod/issues/64#issuecomment-1133903134,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARCQFBKESS4HE7GKQ5MLIKTVLI5IZANCNFSM5NGVQ6GQ
.
You are receiving this because you authored the thread.Message ID:
@.***>
How?
On Sun, May 22, 2022, 7:36 PM CanadaHonk @.***> wrote:
You cannot just uninstall GooseMod from within the client.
β
Reply to this email directly, view it on GitHub
https://github.com/GooseMod/GooseMod/issues/64#issuecomment-1133903452,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARCQFBPTPZ746EY4XONTMKLVLI5OZANCNFSM5NGVQ6GQ
.
You are receiving this because you authored the thread.Message ID:
@.***>
You cannot just uninstall GooseMod from within the client.
There used to be a button for that though, plus having a external script possibly to uninstall it would be a nice addition
It was possible but then was no longer possible as Discord patched something. You can uninstall by deleting the settings.json, for Windows the paths are:
Stable: %appdata%\discord\settings.json
PTB: %appdata%\discordptb\settings.json
Canary: %appdata%\discordcanary\settings.json
Development: %appdata%\discorddevelopment\settings.json
Also as said prior, please use the Discord for support/questions and don't revive dead mostly unrelated issues, GitHub isn't meant for this.
Yeah, I already uninstalled it by just doing a fresh uninstall but thanks for the info and hopefully someone in the same situation can read this and use it and I'm sorry for revive a dead thread
The same uninstall are pinned in the Discord.
Thnks Canada honk, I was just helping him anyway or other ha
On Sun, May 22, 2022, 7:44 PM CanadaHonk @.***> wrote:
The same uninstall guide is pinned in the Discord.
β
Reply to this email directly, view it on GitHub
https://github.com/GooseMod/GooseMod/issues/64#issuecomment-1133906210,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARCQFBNQVMARTGOFXHIN6E3VLI6MPANCNFSM5NGVQ6GQ
.
You are receiving this because you authored the thread.Message ID:
@.***>
|
2025-04-01T04:36:03.832610
| 2024-05-15T17:26:34
|
2298453893
|
{
"authors": [
"Isaac-DeFrain",
"trevorbernard"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12438",
"repo": "Granola-Team/mina-indexer",
"url": "https://github.com/Granola-Team/mina-indexer/issues/895"
}
|
gharchive/issue
|
Cannot sort accounts in db by nonce for GQL queries
Is this an actual problem? Do we want to make fast who has issued the most transactions?
Not an issue. Closing.
|
2025-04-01T04:36:03.845339
| 2023-05-26T09:10:24
|
1727216190
|
{
"authors": [
"Guts",
"codecov-commenter"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12439",
"repo": "Guts/qgis-deployment-cli",
"url": "https://github.com/Guts/qgis-deployment-cli/pull/269"
}
|
gharchive/pull-request
|
Feature: add subcommand to convert an existing QGIS profile into a QDT config
Codecov Report
Merging #269 (57cb293) into main (d27ba93) will decrease coverage by 0.02%.
The diff coverage is 64.51%.
Additional details and impacted files
@@ Coverage Diff @@
## main #269 +/- ##
==========================================
- Coverage 64.70% 64.68% -0.02%
==========================================
Files 35 36 +1
Lines 2037 2067 +30
Branches 429 430 +1
==========================================
+ Hits 1318 1337 +19
- Misses 605 616 +11
Partials 114 114
Impacted Files
Coverage Ξ
qgis_deployment_toolbelt/profiles/qdt_profile.py
76.59% <33.33%> (-1.93%)
:arrow_down:
qgis_deployment_toolbelt/commands/extract.py
65.00% <65.00%> (ΓΈ)
qgis_deployment_toolbelt/cli.py
85.71% <100.00%> (+0.93%)
:arrow_up:
qgis_deployment_toolbelt/commands/__init__.py
100.00% <100.00%> (ΓΈ)
|
2025-04-01T04:36:03.865603
| 2024-12-10T23:18:14
|
2731431897
|
{
"authors": [
"Brennan1994"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12440",
"repo": "HydrologicEngineeringCenter/HEC-FDA",
"url": "https://github.com/HydrologicEngineeringCenter/HEC-FDA/pull/1190"
}
|
gharchive/pull-request
|
closes #1187
I believe the behavior described before was due to bad occtype ID's being assigned. New code increments the last ID from the group by 1, which i I think was the intent of the original author.
@rnugent3 that change should have fixed the issue. Along with it I removed the tracking of group id from occtypes. Occtypes don't need a group ID because they're children of a group, with an ID already. It was redundant, and leading to situations where they dissagreed.
|
2025-04-01T04:36:03.947870
| 2024-03-19T09:27:50
|
2194449305
|
{
"authors": [
"SmetDenis",
"coveralls"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12441",
"repo": "JBZoo/Csv-Blueprint",
"url": "https://github.com/JBZoo/Csv-Blueprint/pull/60"
}
|
gharchive/pull-request
|
Fixed typos
Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details
0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.337%
Totals
Change from base Build<PHONE_NUMBER>:
0.0%
Covered Lines:
920
Relevant Lines:
965
π - Coveralls
Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details
0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.337%
Totals
Change from base Build<PHONE_NUMBER>:
0.0%
Covered Lines:
920
Relevant Lines:
965
π - Coveralls
|
2025-04-01T04:36:03.950769
| 2024-08-22T22:15:13
|
2481902940
|
{
"authors": [
"JS-AK"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12442",
"repo": "JS-AK/db-manager",
"url": "https://github.com/JS-AK/db-manager/pull/233"
}
|
gharchive/pull-request
|
feat: updated pg-core qb added toSubquery method
:tada: This PR is included in version 3.34.0 :tada:
The release is available on:
npm package (@latest dist-tag)
GitHub release
Your semantic-release bot :package::rocket:
|
2025-04-01T04:36:03.952973
| 2024-09-23T19:32:19
|
2543483556
|
{
"authors": [
"robsv",
"virginiascarlett"
],
"license": "BSD-3-Clause",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12443",
"repo": "JaneliaSciComp/dis-utilities",
"url": "https://github.com/JaneliaSciComp/dis-utilities/issues/98"
}
|
gharchive/issue
|
Add email to librarian for "to be processed" items that need tagging
I'll close this once I see it work successfully in the wild
|
2025-04-01T04:36:03.956208
| 2024-04-07T15:56:49
|
2229829960
|
{
"authors": [
"JeffFessler"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12444",
"repo": "JeffFessler/Sound.jl",
"url": "https://github.com/JeffFessler/Sound.jl/pull/24"
}
|
gharchive/pull-request
|
Use Type not DataType; compat; Julia 1.10
linux is failing but now docs compile by using macOS for them.
so merging and will worry about linux later
|
2025-04-01T04:36:03.960111
| 2022-06-05T11:42:24
|
1261028705
|
{
"authors": [
"ALharchi",
"philipto"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12445",
"repo": "JetBrains/swot",
"url": "https://github.com/JetBrains/swot/pull/14324"
}
|
gharchive/pull-request
|
add Royal Danish Academy
@ALharchi First stage of verification passed, official domain is kglakademi.dk as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.
@ALharchi Thank you for your patience while waiting for a review and processing your request. Pull request merged.
|
2025-04-01T04:36:03.961706
| 2023-03-18T11:19:31
|
1630282182
|
{
"authors": [
"pandorarp",
"philipto"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12446",
"repo": "JetBrains/swot",
"url": "https://github.com/JetBrains/swot/pull/16970"
}
|
gharchive/pull-request
|
Added stud.bzbs.ch
@pandorarp First stage of verification passed, official domain is bzbs.ch as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.
@pandorarp Pull request merged. Thank you.
|
2025-04-01T04:36:03.983721
| 2023-08-09T12:08:30
|
1843102358
|
{
"authors": [
"codecov-commenter",
"eliascarv"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12447",
"repo": "JuliaEarth/GeoStatsSolvers.jl",
"url": "https://github.com/JuliaEarth/GeoStatsSolvers.jl/pull/14"
}
|
gharchive/pull-request
|
Use the new searchdists! function from Meshes.jl v0.34.7
Codecov Report
Merging #14 (1a6d205) into main (58971b6) will decrease coverage by 0.03%.
The diff coverage is 100.00%.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@ Coverage Diff @@
## main #14 +/- ##
==========================================
- Coverage 88.53% 88.50% -0.03%
==========================================
Files 14 14
Lines 558 557 -1
==========================================
- Hits 494 493 -1
Misses 64 64
Files Changed
Coverage Ξ
src/estimation/idw.jl
93.22% <100.00%> (-0.12%)
:arrow_down:
src/estimation/lwr.jl
98.33% <100.00%> (+0.02%)
:arrow_up:
src/ui.jl
100.00% <100.00%> (ΓΈ)
|
2025-04-01T04:36:03.995044
| 2023-08-21T16:11:49
|
1859706803
|
{
"authors": [
"CLAassistant",
"aqnuep"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12448",
"repo": "KhronosGroup/KTX-Software-CTS",
"url": "https://github.com/KhronosGroup/KTX-Software-CTS/pull/3"
}
|
gharchive/pull-request
|
Tests to fix issue 751
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.
Is this still a WiP?
I'm just double-checking that everything is rebased so that we don't break git history.
Will un-WIP it in a few minutes.
|
2025-04-01T04:36:03.997664
| 2022-11-16T10:59:04
|
1451370763
|
{
"authors": [
"ReFil",
"allanwind"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12449",
"repo": "KinesisCorporation/Adv360-Pro-ZMK",
"url": "https://github.com/KinesisCorporation/Adv360-Pro-ZMK/pull/57"
}
|
gharchive/pull-request
|
Update README.md to account for new makefile setup
@allanwind The make install stuff wasn't merged afaik, but i've made the other changes you suggested including mentioning the clean up stuff. I also added firmware install instructions linking to the kinesis QSG
That's a good idea, i'll do that, documentation isn't really my strong suit so i appreciate the advice :)
I find it hard, too :-)
Thanks for the advice. I wanted to give enough information to make it easier, although I can see how it can look quite complicated, it's a hard balance to walk. I think I'll leave it as is
|
2025-04-01T04:36:04.003483
| 2022-11-05T10:35:55
|
1436965046
|
{
"authors": [
"Kludex",
"pathawks"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:12450",
"repo": "Kludex/fastapi-health",
"url": "https://github.com/Kludex/fastapi-health/pull/16"
}
|
gharchive/pull-request
|
Add HealthEndpoint compliant with RFC draft
This seems incredibly useful. Is there an ETA when a new version will be available with this feature?
Sorry, no. :(
I need to allocate time for it.
I'm working on the release.
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.