added stringdate 2025-04-01 04:05:38 2025-04-01 07:14:06 | created timestamp[us]date 2001-10-09 16:19:16 2025-01-01 03:51:31 | id stringlengths 4 10 | metadata dict | source stringclasses 2
values | text stringlengths 0 1.61M |
|---|---|---|---|---|---|
2025-04-01T04:10:21.795439 | 2022-08-28T14:30:02 | 1353371025 | {
"authors": [
"MhouneyLH",
"dinurymomshad"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14036",
"repo": "EXERLOG/exer_log",
"url": "https://github.com/EXERLOG/exer_log/pull/167"
} | gharchive/pull-request | Bugfix/custom floating action button fixed #132
Summary
This PR fixed a bug, where the heroTag-property of the FloatingActionButton caused an error. (even if it was set to null)
I created a CustomFloatingActionButton without the heroTag-property and replaced all default FloatingActionButtons.
By now the Class only have 3 members:
Icon
size
Function, when tapped
@MhouneyLH Why was this closed?
I didn't do anything. I will make a new PR in the evening. Sorry.
|
2025-04-01T04:10:21.818871 | 2020-02-12T06:30:52 | 563783590 | {
"authors": [
"risipatel"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14037",
"repo": "EasyCloudConsultants/EasyCloudBooks",
"url": "https://github.com/EasyCloudConsultants/EasyCloudBooks/issues/834"
} | gharchive/issue | Displays Easycloudbooks logo on click of logout.
In Tabs, where User are is open doesn't gets logged out automatically.
In above situation, when user clicks on Edit button then it goes into infinite buffering.
|
2025-04-01T04:10:21.828171 | 2018-09-04T13:48:00 | 356818413 | {
"authors": [
"mbtamuli",
"mrrobot47"
],
"license": "mit",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14038",
"repo": "EasyEngine/easyengine",
"url": "https://github.com/EasyEngine/easyengine/issues/1205"
} | gharchive/issue | webroot challenge of letsencrypt fails when global auth is enabled
The path ~/ee-sites/site-name/app/src/.well-known/acme-challenge/ should be excluded from global auth so that letsencrypt webroot challenge can validate the challenge by reading the file in that folder.
Step 1
A file /opt/easyengine/vhost.d/default should contain the following location block.
location ^~ /.well-known/acme-challenge/ {
auth_basic off;
allow all;
root /usr/share/nginx/html;
try_files $uri =404;
break;
}
This file should be created before acmephp invocation, and removed after acmephp invocation.
Step 2
https://github.com/EasyEngine/site-command/blob/b487904942a192727e110788a0241f454f84de2a/src/helper/site-utils.php#L174
This directory needs to be host mounted. /usr/share/nginx/html:/opt/easyengine/nginx/html
The acme challenge needs to be created here - /opt/easyengine/nginx/html
Then cleaned up on successful generation of certificates.
|
2025-04-01T04:10:21.829702 | 2023-05-10T15:25:35 | 1704179381 | {
"authors": [
"ldewald",
"stephenjwatkins"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14039",
"repo": "EasyPost/easy-ui",
"url": "https://github.com/EasyPost/easy-ui/pull/192"
} | gharchive/pull-request | Create pull request template
I looked into creating multiple PR templates and you have to use query parameters to specify the template when creating a pull request, which feels a little too complicated for now.
I think this PR template won't be relevant for all PRs, mostly for component ones, but we can always simply edit it when creating a PR if it's not relevant. So using it as the default makes sense to me for now. We can adjust as we use it.
Thoughts on the emojis? lol. I'm not super great at picking emojis to use so any input is welcome there.
The emojis you picked lgtm!
|
2025-04-01T04:10:21.877620 | 2019-10-31T10:22:24 | 515316607 | {
"authors": [
"Varadinsky",
"eshellman"
],
"license": "CC-BY-4.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14040",
"repo": "EbookFoundation/free-programming-books",
"url": "https://github.com/EbookFoundation/free-programming-books/pull/3440"
} | gharchive/pull-request | Add Raku One-Liners book
What does this PR do?
Add Resource(s)
For resources
Description
Raku One-Liners book
Why is this valuable (or not)
Book from a well known Raku community member/author.
How do we know it's really free?
PDF version of the book is available for free from the link provided
For book lists, is it a book?
yes
Checklist:
[x] Not a duplicate
[x] Included author(s) if appropriate
[x] Lists are in alphabetical order
[x] Needed indications added (PDF, access notes, under construction)
welcome to free-programming-books!
|
2025-04-01T04:10:21.882379 | 2022-10-07T18:10:48 | 1401519011 | {
"authors": [
"ahmad-14a",
"eshellman"
],
"license": "CC-BY-4.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14041",
"repo": "EbookFoundation/free-programming-books",
"url": "https://github.com/EbookFoundation/free-programming-books/pull/7797"
} | gharchive/pull-request | Ahmad's branch
What does this PR do?
Add resource(s) | Remove resource(s) | Add info | Improve repo
s
For resources
Description
A C++ book for Object Oriented programming in English language is being added
Why is this valuable (or not)?
it's good for beginners
How do we know it's really free?
By oppening it
For book lists, is it a book? For course lists, is it a course? etc.
yes its a book
Checklist:
[ *] Read our contributing guidelines.
[* ] Search for duplicates.
[ *] Include author(s) and platform where appropriate.
[* ] Put lists in alphabetical order, correct spacing.
[ *] Add needed indications (PDF, access notes, under construction).
[ *] Used an informative name for this pull request.
Follow-up
Check the status of GitHub Actions and resolve any reported warnings!
This appears not to be an authorized distribution. Please see docs/CONTRIBUTING.md guidelines.
|
2025-04-01T04:10:21.885130 | 2024-08-21T18:18:19 | 2478706428 | {
"authors": [
"Eccenux"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14042",
"repo": "Eccenux/wlm-zabytki-mapa",
"url": "https://github.com/Eccenux/wlm-zabytki-mapa/issues/33"
} | gharchive/issue | Deploy script-service
[ ] Script to download data from Github and deploy for testing.
[ ] Private config to contain git address and testing path and token.
[ ] Test trigger with test token.
[ ] 2nd token for release-deploy.
Wcześniejsze koncepcje:
CI/CD build and rollout #29
Test and release:
https://zabytki.toolforge.org/_deploy_script/?type=test&token=
https://zabytki.toolforge.org/_deploy_script/?type=main&token=
|
2025-04-01T04:10:21.896920 | 2018-02-04T05:57:18 | 294173029 | {
"authors": [
"EdOverflow",
"anshumanbh"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14043",
"repo": "EdOverflow/megplus",
"url": "https://github.com/EdOverflow/megplus/pull/4"
} | gharchive/pull-request | Dockerized Megplus | GLHF
I've built a Docker image and pushed it to my public repository here - https://hub.docker.com/r/abhartiya/tools_megplus/
So, anybody can just pull it and run megplus now without having to worry about the dependencies.
In this PR, I am providing the Dockerfile that was used to build that image, updated the README and also provided a sample test.txt file to test against.
Thanks again for giving back to the community!
Cheers!
Thank you so much, @anshumanbh!
|
2025-04-01T04:10:21.902171 | 2021-09-09T02:08:03 | 991681282 | {
"authors": [
"Aditya664",
"FayasNoushad",
"schmelto"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14045",
"repo": "EddieHubCommunity/support",
"url": "https://github.com/EddieHubCommunity/support/issues/2372"
} | gharchive/issue | [REVIEW]
Portfolio link
http://aditya-deshmukh.me/Mark-up-Portfolio/
Closing this one due to duplicate with #2373
Closing this one due to duplicate with #2373
Yeah he closing and re opening as other issue in so many times.
|
2025-04-01T04:10:21.907035 | 2024-02-07T14:48:24 | 2123204447 | {
"authors": [
"EddyLuten",
"MatteoGisondi"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14046",
"repo": "EddyLuten/mkdocs-live-edit-plugin",
"url": "https://github.com/EddyLuten/mkdocs-live-edit-plugin/issues/3"
} | gharchive/issue | OSError: [Errno 99] error while attempting to bind on address ('::1', 8484, 0, 0): cannot assign requested address
Python version(s): 3.10.13 / 3.11.7
mkdocs-live-edit-plugin = "^0.1.4"
...
INFO - Documentation built in 21.14 seconds
INFO - live-edit websocket server starting
INFO - live-edit websocket server thread started
Exception in thread Thread-5 (server_thread_main):
Traceback (most recent call last):
File "/home/user/.pyenv/versions/3.10.13/lib/python3.10/threading.py", line 1016, in _bootstrap_inner
self.run()
File "/home/user/.pyenv/versions/3.10.13/lib/python3.10/threading.py", line 953, in run
self._target(*self._args, **self._kwargs)
File ".venv/lib/python3.10/site-packages/live/plugin.py", line 221, in server_thread_main
asyncio.run(self.event_loop())
File "/home/user/.pyenv/versions/3.10.13/lib/python3.10/asyncio/runners.py", line 44, in run
return loop.run_until_complete(main)
File "/home/user/.pyenv/versions/3.10.13/lib/python3.10/asyncio/base_events.py", line 649, in run_until_complete
return future.result()
File ".venv/lib/python3.10/site-packages/live/plugin.py", line 207, in event_loop
async with serve(
File ".venv/lib/python3.10/site-packages/websockets/legacy/server.py", line 1098, in __aenter__
return await self
File ".venv/lib/python3.10/site-packages/websockets/legacy/server.py", line 1116, in __await_impl__
server = await self._create_server()
File "/home/user/.pyenv/versions/3.10.13/lib/python3.10/asyncio/base_events.py", line 1519, in create_server
raise OSError(err.errno, 'error while attempting '
OSError: [Errno 99] error while attempting to bind on address ('::1', 8484, 0, 0): cannot assign requested address
INFO - [09:28:22] Watching paths for changes: 'docs', 'mkdocs.yml'
INFO - [09:28:22] Serving on http://<IP_ADDRESS>:8000/
Fix:
/live/plugin.py
async with serve(
self.websocket_receiver,
"localhost",
self.config['websockets_port']
):
...
async with serve(
self.websocket_receiver,
"<IP_ADDRESS>",
self.config['websockets_port']
):
...
PR coming shortly 😃
Thanks for finding and fixing this issue! I've verified the fix locally and everything seems to work right. I'll make sure to include it in the next release.
|
2025-04-01T04:10:21.987302 | 2023-07-23T18:22:33 | 1817251111 | {
"authors": [
"BrunoZockt",
"Edouard127",
"asdhuman-dev",
"darkmaster420",
"n1ebe",
"orelt06",
"r4ngu"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14049",
"repo": "Edouard127/reddit-placebot-2023",
"url": "https://github.com/Edouard127/reddit-placebot-2023/issues/66"
} | gharchive/issue | Stuck at waiting for board data
Launched Tor and login was successful. Am I missing something?
Same error. I think it happens because the canvas has expanded and the program can't handle it. Couldn't fix it yet though.
yeah, wait for Edouard127 to update the code
go to board.go and modify the values it might work
@Edouard127 please fix!
same error, "waiting for board data"
same error, @Edouard127, fix please <3
1521c71
|
2025-04-01T04:10:21.996085 | 2024-10-04T00:30:25 | 2565199981 | {
"authors": [
"Eein"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14050",
"repo": "Eein/sea-of-stars-tas",
"url": "https://github.com/Eein/sea-of-stars-tas/issues/37"
} | gharchive/issue | Integrate Puffin Egui more neatly
Currently i just have some things uncommented.
[ ] integrate https://crates.io/crates/profiling for nicer profiling decorators
[ ] Add a debug helper with the puffin window added into it as its currently a floating window within the egui window
[ ] add a build flag to enable it (ie: cargo run --profile)
waiting on this: https://github.com/EmbarkStudios/puffin/pull/234
|
2025-04-01T04:10:22.032961 | 2023-01-12T22:17:31 | 1531438109 | {
"authors": [
"PatrickZGW",
"jesterhodl"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14051",
"repo": "Einundzwanzig-Podcast/einundzwanzigbot",
"url": "https://github.com/Einundzwanzig-Podcast/einundzwanzigbot/issues/51"
} | gharchive/issue | ImportError: cannot import name 'Filters' from 'telegram.ext'
Hi, I'm trying to launch the bot from docker image.
After cloning the repo, and putting in the token from Bot Father and doing docker-compose up it ultimately ends up with:
einundzwanzigbot_1 | Traceback (most recent call last):
einundzwanzigbot_1 | File "src/main.py", line 2, in <module>
einundzwanzigbot_1 | from bot import run
einundzwanzigbot_1 | File "/app/src/bot.py", line 3, in <module>
einundzwanzigbot_1 | from telegram.ext import Updater, CommandHandler, MessageHandler, Filters, ConversationHandler, CallbackQueryHandler
einundzwanzigbot_1 | ImportError: cannot import name 'Filters' from 'telegram.ext' (/usr/local/lib/python3.8/site-packages/telegram/ext/__init__.py)
twentyoneworldbot_einundzwanzigbot_1 exited with code 1
Any ideas?
This is because the python-telegram-bot library was updated to a new version. I pinned the version in the file.
|
2025-04-01T04:10:22.038622 | 2021-04-23T17:31:57 | 866304578 | {
"authors": [
"ElMassimo",
"doabit"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14052",
"repo": "ElMassimo/vite_ruby",
"url": "https://github.com/ElMassimo/vite_ruby/pull/67"
} | gharchive/pull-request | chore: Update DEFAULT_PLUGIN_VERSION to use the latest version
Description 📖
When run bundle exec vite install, still use plugin 1.0 version, i think we should use the latest version.
Sorry, i still can't find out why it still failed.
Thanks for the reminder!
|
2025-04-01T04:10:22.051578 | 2019-11-25T16:14:08 | 528188690 | {
"authors": [
"arshamnm",
"omid3098"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14053",
"repo": "ElectroGryphon/EGGA",
"url": "https://github.com/ElectroGryphon/EGGA/issues/12"
} | gharchive/issue | The referenced script on this Behaviour is missing!
Currently, the EGG script will cause the error:
The referenced script on this Behaviour (Game Object 'text') is missing!
because of the wrong place of directives.
Modify the code to:
using UnityEditor; using UnityEngine; namespace UPersian.Scripts { [ExecuteInEditMode] public class EGG : MonoBehaviour { #if UNITY_EDITOR .. the remaining code .. #endif } }
or add:
#else using UnityEngine; namespace UPersian.Scripts { public class EGG : MonoBehaviour {} }
right before #endif
to avoid such error
Thank you @arshamnm
It would be great if you send a PR on this case and I will gladly check and merge it.
Don't mention it
Sure :)
I was in rush at that time
There you are...
Thanks for the PR. ✌️
Merged
|
2025-04-01T04:10:22.074234 | 2019-01-31T22:01:52 | 405460132 | {
"authors": [
"GregorBiswanger",
"GustavoGSA",
"PitySOFT",
"Spiti",
"ffetech",
"jsantanders"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14054",
"repo": "ElectronNET/Electron.NET",
"url": "https://github.com/ElectronNET/Electron.NET/issues/210"
} | gharchive/issue | Cannot get a ipc connection to run with aspnetcore 2.1 & angular 6
Hello Gregor, Hello Robert, Hello all,
Thank you for this library!
I have a AspNetCore 2.1 Angular 6 App with ElectronApi 0.11. "electronize start" works fine and the app starts fine but I cannot get a ipc connection to run.
I have an Angular service with the following parts of code to establish a ipc connection. Its executing immediately after angular app start,
import { IpcRenderer } from 'electron';
...
if (process.versions.electron && (<any>window).require)
this.ipc = (<any>window).require("electron").ipcRenderer;
...
this.ipc.send("connect", "x");
This is my code on C# side
var browserWindow = await Electron.WindowManager.CreateWindowAsync(new BrowserWindowOptions { Show = false });
browserWindow.OnReadyToShow += () =>
{
Electron.IpcMain.On("connect", args => Connect());
browserWindow.Show();
};
if I make a sendSync on angular side, the app freezes. Do you have some idea what i did wrong.
Hi @ffetech
do you can create a small project with the problem?
So I can download and try it...
Best,
Gregor
Hi Gregor,
Thank you for help. Now I have created a new small project with angular 7.
You can download it from here.
https://customer.ffe-tech.com/code/ElectronDotNet.Core21Ng7Ipc.zip
Now I have a different solution (but also not working). In the header of index.html you can find the javascript-like electron import "const electron = require('electron'). Then there is a angular service "IpcService" which encapsulates the ipc code. The app component injects the service and make the corresponding method calls to the IpcService. Debugging with the chrome dev tools is possible. But on c# side the message is not receiving.
Best Regards
Hi ffetech,
I'm having the same issue, do you solve it? or find a workaroud?
Cheers,
Jesus Santander.
Hi jsantanders, Hi Gregor,
It‘s not solves yet, but I have noticed the following behaviour:
If i debug it in chrome developer tools it surprisingly worked if i step over the ipcRenderer.send method.
Because of that I had the idea to implement a „setTimeout“ of 5000ms to send delayed. But this also do not work.
Hey @ffetech, @jsantanders and other Angular Devs from our Community :)
@ffetech I downloaded your sample code and immediately recognized the problem.
The ipcRenderer works asynchronously in the background. When a message arrives and your data is changed, no Angular Change Detection becomes active.
That's because the Change Detection runs over Zone.js. This subscribes to all DOM events, XHR events, etc. - When these are triggered, only their call stack is processed. Then goes through the change detection. With otherwise asynchronous code, Zone.js does not recognize this.
The solution is to run your own asynchronous code in one zone. This automatically triggers a change detection. Here the updated code from your sample:
constructor(private ipc: IpcService, zone: NgZone) {
this.ipc.on('asynchronous-reply', (event, args) => {
zone.run(() => {
this.message = `Asynchronous message reply: ${args}`;
});
});
this.ipc.send("async-msg", 'ping');
}
p.s. I would disguise the zone call in the service. Looks like better... :)
Hello Gregor,
good to know. Thank You :)
Hi guys, I tried to run the example above, but I get an error:
pm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: `tsc -p . "--port" "59776"`
I installed the npm packages, built the angular project and ran electronize start. what am I missing?
Thanks!
Hi,
The same problema of @Spiti here.
stdout: fail: Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware[1] An unhandled exception has occurred while executing the request. System.AggregateException: One or more errors occurred. (One or more errors occurred. (The NPM script 'start' exited without indicating that the Angular CLI was listening for requests. The error output was: npm ERR! cod e ELIFECYCLE npm ERR! errno 1 npm ERR<EMAIL_ADDRESS>start: tsc -p . "--port" "50649"npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the<EMAIL_ADDRESS>start script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above. npm ERR! C:\Users\gusta\AppData\Roaming\npm-cache\_logs\2019-09-20T02_36_29_998Z-debug.log )) ---> System.AggregateException: One or more errors occurred. (The NPM script 'start' exited without indicating that the Angular CLI was listening for requests. The error output was: npm ERR! code ELIFECYCLE npm ERR! errno 1 npm ERR<EMAIL_ADDRESS>start:tsc -p . "--port" "50649"npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the<EMAIL_ADDRESS>start script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above. npm ERR! C:\Users\gusta\AppData\Roaming\npm-cache\_logs\2019-09-20T02_36_29_998Z-debug.log ) ---> System.InvalidOperationException: The NPM script 'start' exited without indicating that the Angular CLI was listening for requests. The error output was: npm ERR! code ELIFECYCLE npm ERR! errno 1 npm ERR<EMAIL_ADDRESS>start:tsc -p . "--port" "50649" npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the<EMAIL_ADDRESS>start script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above. npm ERR! C:\Users\gusta\AppData\Roaming\npm-cache\_logs\2019-09-20T02_36_29_998Z-debug.log ---> System.IO.EndOfStreamException: Attempted to read past the end of the stream. at Microsoft.AspNetCore.SpaServices.AngularCli.AngularCliMiddleware.StartAngularCliServerAsync(String sourcePath, String npmScriptName, ILogger logger) --- End of inner exception stack trace --- at Microsoft.AspNetCore.SpaServices.AngularCli.AngularCliMiddleware.StartAngularCliServerAsync(String sourcePath, String npmScriptName, ILogger logger) --- End of inner exception stack trace --- at System.Threading.Tasks.Task1.GetResultCore(Boolean waitCompletionNotification)
at Microsoft.AspNetCore.SpaServices.AngularCli.AngularCliMiddleware.<>c.b__2_0(Task1 task) at System.Threading.Tasks.ContinuationResultTaskFromResultTask2.InnerInvoke()
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location where exception was thrown ---
at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot)
--- End of inner exception stack trace ---
at System.Threading.Tasks.Task1.GetResultCore(Boolean waitCompletionNotification) at Microsoft.AspNetCore.SpaServices.Extensions.Util.TaskTimeoutExtensions.WithTimeout[T](Task1 task, TimeSpan timeoutDelay, String message)
at Microsoft.AspNetCore.SpaServices.Extensions.Proxy.SpaProxy.PerformProxyRequest(HttpContext context, HttpClient httpClient, Task1 baseUriTask, CancellationToken applicationStoppingToken, Boolean proxy404s) at Microsoft.AspNetCore.Builder.SpaProxyingExtensions.<>c__DisplayClass2_0.<<UseProxyToSpaDevelopmentServer>b__0>d.MoveNext() --- End of stack trace from previous location where exception was thrown --- at Microsoft.AspNetCore.Routing.EndpointMiddleware.Invoke(HttpContext httpContext) at Microsoft.AspNetCore.Routing.EndpointRoutingMiddleware.Invoke(HttpContext httpContext) at Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware.Invoke(HttpContext context) at Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware.Invoke(HttpContext context) at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware.Invoke(HttpContext context) ---> (Inner Exception #0) System.AggregateException: One or more errors occurred. (The NPM script 'start' exited without indicating that the Angular CLI was listening for requests. The error output was: npm ERR! code EL IFECYCLE npm ERR! errno 1 npm ERR<EMAIL_ADDRESS>start: tsc -p . "--port" "50649"npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the<EMAIL_ADDRESS>start script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above. npm ERR! C:\Users\gusta\AppData\Roaming\npm-cache\_logs\2019-09-20T02_36_29_998Z-debug.log ) ---> System.InvalidOperationException: The NPM script 'start' exited without indicating that the Angular CLI was listening for requests. The error output was: npm ERR! code ELIFECYCLE npm ERR! errno 1 npm ERR<EMAIL_ADDRESS>start:tsc -p . "--port" "50649" npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the<EMAIL_ADDRESS>start script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above. npm ERR! C:\Users\gusta\AppData\Roaming\npm-cache\_logs\2019-09-20T02_36_29_998Z-debug.log ---> System.IO.EndOfStreamException: Attempted to read past the end of the stream. at Microsoft.AspNetCore.SpaServices.AngularCli.AngularCliMiddleware.StartAngularCliServerAsync(String sourcePath, String npmScriptName, ILogger logger) --- End of inner exception stack trace --- at Microsoft.AspNetCore.SpaServices.AngularCli.AngularCliMiddleware.StartAngularCliServerAsync(String sourcePath, String npmScriptName, ILogger logger) --- End of inner exception stack trace --- at System.Threading.Tasks.Task1.GetResultCore(Boolean waitCompletionNotification)
at Microsoft.AspNetCore.SpaServices.AngularCli.AngularCliMiddleware.<>c.b__2_0(Task1 task) at System.Threading.Tasks.ContinuationResultTaskFromResultTask2.InnerInvoke()
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location where exception was thrown ---
at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot)
---> (Inner Exception #0) System.InvalidOperationException: The NPM script 'start' exited without indicating that the Angular CLI was listening for requests. The error output was: npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: tsc -p . "--port" "50649"
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! C:\Users\gusta\AppData\Roaming\npm-cache_logs\2019-09-20T02_36_29_998Z-debug.log
---> System.IO.EndOfStreamException: Attempted to read past the end of the stream.
at Microsoft.AspNetCore.SpaServices.AngularCli.AngularCliMiddleware.StartAngularCliServerAsync(String sourcePath, String npmScriptName, ILogger logger)
--- End of inner exception stack trace ---
at Microsoft.AspNetCore.SpaServices.AngularCli.AngularCliMiddleware.StartAngularCliServerAsync(String sourcePath, String npmScriptName, ILogger logger)<---
<---
stdout: info: Microsoft.AspNetCore.Hosting.Internal.WebHost[2]
Request finished in 499.0983ms 500 text/html; charset=utf-8
C:\WorkSpace\Electron\ASP.NETCoreWebApplication\ASP.NETCoreWebApplication\obj\Host\node_modules.bin>
`
Anybody can help?
thanks.
I have the same issue with .Net Core 2.2 and 3.0 using a default MVC project but with Angular.
11 silly lifecycle<EMAIL_ADDRESS>start: Returned: code: 1 signal: null
12 info lifecycle<EMAIL_ADDRESS>start: Failed to exec start script
13 verbose stack Error<EMAIL_ADDRESS>start: tsc -p . "--port" "55259"
13 verbose stack Exit status 1
Any idea why this error and how to solve it?
|
2025-04-01T04:10:22.077262 | 2017-11-12T22:48:20 | 273273058 | {
"authors": [
"robertmuehsig",
"yoDon"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14055",
"repo": "ElectronNET/Electron.NET",
"url": "https://github.com/ElectronNET/Electron.NET/issues/52"
} | gharchive/issue | dotnet electronize start should abort if build fails
Hi guys, at least in VS Code if there is a compiler error during the dotnet electronize start's build step, there are still enough old built *.exe's lying around that the electron app will appear to launch and run, but it's running the last successful build not the current code. Definitely a recipe for burning a ton of extra time debugging the wrong exe, and trying to remember to either manually clean bin and obj before each build or manually doing an explicit build step (which spews less into the terminal window) before running start. Having start abort if the build fails would be a huge help.
The build/start command will now stop if the publish command fails (e.g. compilation error occured) - maybe not perfect, but should be better then now.
mhh... i broke it...
Not perfect, but could work. The code now searchs for "error". It would be way cleaner to get the exit code of the actual cmd.exe/bash, but I couldn't get it and the actual cmd.exe runs fine...
|
2025-04-01T04:10:22.078894 | 2021-07-21T13:58:25 | 949737506 | {
"authors": [
"molekilla",
"urbinaalex17"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14056",
"repo": "Electronic-Signatures-Industries/xdv-universal-wallet",
"url": "https://github.com/Electronic-Signatures-Industries/xdv-universal-wallet/issues/15"
} | gharchive/issue | Pass in Custom Headers for Authentication
To use any IPFS cloud provider, we need to pass in custom headers like authorization with JWT or API Keys, which currently is not supported.
This library uses the ipfs-http-client to interact with IPFS, so here is what should be done. https://www.npmjs.com/package/ipfs-http-client#custom-headers
you need to override and customize on your side
|
2025-04-01T04:10:22.085638 | 2023-07-03T21:34:31 | 1786836124 | {
"authors": [
"4ydan"
],
"license": "BSD-3-Clause",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14057",
"repo": "ElektraInitiative/PermaplanT",
"url": "https://github.com/ElektraInitiative/PermaplanT/pull/567"
} | gharchive/pull-request | New Docker base image for CI
Linked to #544
Basics
[ ] I added a line to /doc/CHANGELOG.md
[ ] The PR is rebased with current master.
[ ] Details of what you changed are in commit messages.
[ ] References to issues, e.g. close #X, are in the commit messages.
[ ] The buildserver is happy.
Checklist
[ ] I have installed and I am using pre-commit hooks
[ ] I fully described what my PR does in the documentation
(not in the PR description)
[ ] I fixed all affected documentation
[ ] I fixed all affected decisions
[ ] I added unit tests for my code
[ ] I added code comments, logging, and assertions as appropriate
[ ] I translated all strings visible to the user
[ ] I mentioned every code or binary not directly written or done by me in reuse syntax
[ ] I created left-over issues for things that are still to be done
[ ] Code is conforming to our Architecture
[ ] Code is conforming to our Guidelines
(exceptions are documented)
[ ] Code is consistent to our Design Decisions
Review
[ ] I've tested the code
[ ] I've read through the whole code
[ ] Examples are well chosen and understandable
I dont know what happened with my git here...
|
2025-04-01T04:10:22.106287 | 2017-09-04T13:45:06 | 255047009 | {
"authors": [
"Leopoldthecoder",
"lsycxyj"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14058",
"repo": "ElemeFE/element",
"url": "https://github.com/ElemeFE/element/issues/6845"
} | gharchive/issue | [Bug Report] el-elect fires remoteMethod even though the v-model id doesn't match any value of el-options
Element UI version
1.4.1
OS/Browsers version
Any
Vue version
2.4.2
Reproduction Link
https://jsfiddle.net/pj71jkyw/
Steps to reproduce
My computer was blocked by GFW. Codes are here.
<script src="//unpkg.com/vue/dist/vue.js"></script>
<script src="//unpkg.com/element-ui/lib/index.js"></script>
<div id="app">
<el-select v-model="input" remoteMethod="log"></el-select>
</div>
@import url("//unpkg.com/element-ui/lib/theme-default/index.css");
var Main = {
data() {
return {
input: 5
}
},
methods: {log(){ console.log('fired') }}
}
var Ctor = Vue.extend(Main)
new Ctor().$mount('#app')
What is Expected?
5 should not be shown and remoteMethod should not be fired.
What is actually happening?
5 was shown and remoteMethod was fired.
If you don't want 5 to be shown, you can avoid initializing input. Assign input after you have the corresponding option. remote-method behavior will be updated in the next major version, and it will not fire on initialization.
@Leopoldthecoder When will the next major version will be released?
|
2025-04-01T04:10:22.120441 | 2024-04-10T02:51:02 | 2234655304 | {
"authors": [
"LSinev",
"ozgurcelik"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14059",
"repo": "EleutherAI/lm-evaluation-harness",
"url": "https://github.com/EleutherAI/lm-evaluation-harness/issues/1693"
} | gharchive/issue | Is it possible to shuffle the dataset?
Hi. I only want to use a subset of a dataset. For that I am using --limit. But I will be repeating tests multiple times for parameter search and I don't want to overfit for to small subset so I want to take different subsets at different times. I thought changing seeds might shuffle the dataset but looking at the outputs I got by using --log_samples, it doesn't. So, how can I shuffle the dataset?
If no one comes with better idea, you can write custom process_docs with shuffling of dataset inside (new seed from environment variables, for example). Quick untested example
def process_docs(dataset: datasets.Dataset) -> datasets.Dataset:
return dataset.shuffle(seed=int(os.environ("DATA_SEED")))
|
2025-04-01T04:10:22.122778 | 2024-03-08T20:21:09 | 2176714284 | {
"authors": [
"cosmo3769",
"haileyschoelkopf"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14060",
"repo": "EleutherAI/lm-evaluation-harness",
"url": "https://github.com/EleutherAI/lm-evaluation-harness/pull/1546"
} | gharchive/pull-request | Fix incorrect max_gen_toks generation kwarg default in generative Bigbench
cc @lintangsutawika
closes #1513 .
Hi @haileyschoelkopf, thank you for the pr regarding the issue #1513. Can you please explain how this can help to resolve the issue? If input_ids is more than the defined max_token, will the input be truncated to only 128 or something else will happen entirely?
Also, I am getting same error in all code2_text too. Thank you!
Well, I ran with bigbench_code_line_description_generate_until and it runs successfully.
Taking this as reference, I have made changes in code2_text. Can I make a PR for this? @haileyschoelkopf
Yep, go for it!
|
2025-04-01T04:10:22.127015 | 2023-10-30T09:39:33 | 1967920162 | {
"authors": [
"Zengyu-98",
"osainz59"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14061",
"repo": "EleutherAI/the-pile",
"url": "https://github.com/EleutherAI/the-pile/issues/118"
} | gharchive/issue | Issue reproducing the GitHub partition
Hi there,
I followed the GitHub downloader repository and executed the download_repo_text.py script.
I obtained a total of 27,819,203 documents, just half of the documents reported here:
https://github.com/EleutherAI/the-pile/blob/df97f8651ae3da658b19659b3ceaa6a34b0fc014/the_pile/datasets.py#L704
I fixed and added some metadata I need for my analyses. In total the file is around 60Gb in disc. I did not run the github_reduce.py yet, as the full dataset is not the same as reported by the authors.
Also, as the links to the GitHub partition are not available anymore, I would like to know if there is something I can do to obtain the original GitHub data that is in The Pile (hopefully with correct metadata).
Thank you
Hello, does your documents refer to the total number of single data item (namely each json line)? I also had the same problem where our total data items are similar to your number.
Is your downloaded data around 800 GB? We downloaded the pile but only around ~400 GB. That's probably why it is only half of it?
Yes, by documents I refer to each data item. I only have the preprocessed data after downloading the GitHub partition, so I do not know the numbers for the complete dataset.
Yes, by documents I refer to each data item. I only have the preprocessed data after downloading the GitHub partition, so I do not know the numbers for the complete dataset.
How large is your downloaded dataset in total? Mine is ~400 GB which is also half of the paper (800 GB). I guess that might be the reason
|
2025-04-01T04:10:22.176931 | 2016-06-09T21:46:31 | 159515840 | {
"authors": [
"Eloston",
"triceratops1"
],
"license": "BSD-3-Clause",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14062",
"repo": "Eloston/ungoogled-chromium",
"url": "https://github.com/Eloston/ungoogled-chromium/issues/21"
} | gharchive/issue | Impossible to compile: debian 8
at debian8 compilation is impossible
its a fresh install "opensuse build service instance"
32bit log https://mega.nz/#!INZx2Yqa!YRzIPlrrmxnHCZZam4zeyDjL6jIDC2od8c34hr0MsTo
64bit log https://mega.nz/#!9Qhmib4Q!RWF5ufPfqaFZiSCG7KK_BHCpnpyG5QIRJljbfZwHNC0
I noticed in your logs that you're using an old version of the libav* libraries. Have you seen the note for Debian Jessie users?.
If you want to use Chromium's bundled FFmpeg, then don't apply ffmpeg.patch from build_templates/debian/patches/system/.
Let me know how it goes. I haven't actually tested the patches yet, so if it works that will be helpful for me.
and i've got a very disturbing bug of ungoogled "a clean opensuse build service xenial vm"
with this log Supervised users aren't enabled
and after the compilation has been aborted
"a clean opensuse build service xenial vm"
Are you saying that you're trying to build on a Ubuntu Xenial machine now? Are you not building on Debian 8 anymore?
Supervised users aren't enabled
What are "supervised users"?
and after the compilation has been aborted
What's the error? Is it related to the code? If so, do you have a log?
New version is out. Please see the new README for info. Let me know if you still have the problem.
|
2025-04-01T04:10:22.179081 | 2021-04-16T07:09:34 | 859531123 | {
"authors": [
"Eloston",
"fabriziobagala"
],
"license": "BSD-3-Clause",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14063",
"repo": "Eloston/ungoogled-chromium",
"url": "https://github.com/Eloston/ungoogled-chromium/pull/1491"
} | gharchive/pull-request | Add macOS compatibility for set_quilt_vars.sh
(Please ensure you have read SUPPORT.md and docs/contributing.md before submitting the Pull Request)
The macOS repo already has its own set_quilt_vars.sh file. Why do we need to note this here?
The macOS repo already has its own set_quilt_vars.sh file. Why do we need to note this here?
You are right, there is no need. I did not see the repository for macOS.
|
2025-04-01T04:10:22.182534 | 2022-09-02T13:05:06 | 1360170277 | {
"authors": [
"Elringus",
"promontis"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14064",
"repo": "Elringus/DotNetJS",
"url": "https://github.com/Elringus/DotNetJS/issues/88"
} | gharchive/issue | Why does typescript definitions render any?
I have the following C# code:
[JSInvokable]
public static EquationSystem.SolveResult Move(IEntity entity, Vector3 pos)
{
var editor = GetEditor();
var moveTool = new MoveTool();
return moveTool.Move(entity, editor.ActiveFeature, pos);
}
Vector3 is a struct from System.Numerics.Vectors.dll.
This renders the following typescript:
export namespace Bindings {
export function Move(entity: Bindings.IEntity, pos: any): Bindings.SolveResult;
}
Do you know why pos is of type any?
All runtime assemblies (Microsoft.* and System.*) are ignored when resolving types. It's assumed that you will use only custom types when defining bindings, because most of the built-in types won't work with interop serialization anyway.
Ok that makes sense!
|
2025-04-01T04:10:22.189923 | 2015-11-09T03:04:11 | 115782858 | {
"authors": [
"DavePearce",
"Matt--"
],
"license": "bsd-3-clause",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14065",
"repo": "ElvisResearchGroup/DictionaryOfNewZealandEnglish",
"url": "https://github.com/ElvisResearchGroup/DictionaryOfNewZealandEnglish/pull/12"
} | gharchive/pull-request | Database finished
Woohoo, database is done and ready to go live.
Updated database entries to include lost Registers and Flags. Changed headword list page to have the link for more detail on the headword rather than seperate link text. Added Quick-start Project set-up notes to Readme and tidied several entries. Consolidated dev functions in nzdc_data_massage.py file to allow easy removal in production (just delete the file).
Also placed two historic excel files here on github to save ever having to ask a DBA for them... They contain information the client may like that was not ported across the last time the db was updated. See issue #11 .
I think this is it. I am going to have a beer or three tonight :-)
AWESOME work!!
|
2025-04-01T04:10:22.222234 | 2023-11-27T17:58:09 | 2012807504 | {
"authors": [
"LegNeato"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14066",
"repo": "EmbarkStudios/rust-gpu",
"url": "https://github.com/EmbarkStudios/rust-gpu/issues/1104"
} | gharchive/issue | Infrastructure for using ShaderToy as a test corpus
Proposal
Create infrastructure that translates (working) shadertoy shaders into rust-gpu (and runs?). This would make it so we have a sort of burndown chart a la https://github.com/uutils/coreutils#gnu-test-suite-compatibility and https://boajs.dev/boa/test262/ and stress test different parts of rust-gpu. Implementing enough to flip a shader from not working to working may be an easier place for contributors to start, and seeing shaders work is neat!
Feasibility
The shadertoy api looks pretty straightforward to implement from the runner side: https://www.shadertoy.com/howto.
I'm not sure how easy the transpiling will be, but there is https://github.com/phaazon/glsl/tree/master/glsl/src/transpiler and spot checks on some shadertoy shaders doesn't look too crazy. We could probably allowlist or denylist.
Implementation
I wanted to open this for comments before starting on an implementation.
Related: https://github.com/EmbarkStudios/rust-gpu/issues/1096
I hand ported three shaders from shadertoy...I think automating this is doable for most of the image shaders. It would be cool to have a harness that compares rendering results.
Example, which works with mouse too:
Ported from https://www.shadertoy.com/view/DlGfzh. Code in https://github.com/LegNeato/rust-gpu/tree/fork-shield
Update: I have a WIP PR to make naga translate to rust.
Update: I have a WIP differential harness that compares the original shadertoy shader and the converted rust shader's output.
|
2025-04-01T04:10:22.228589 | 2021-01-09T21:29:41 | 782688663 | {
"authors": [
"paveljandejsek",
"thradec"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14067",
"repo": "EmbedITCZ/jbehave-support",
"url": "https://github.com/EmbedITCZ/jbehave-support/pull/542"
} | gharchive/pull-request | Fixed saving of rest headers from response if body is empty.
Closes #541
Question - do we want to fail or return null when header that is not present is being saved? Current fix makes the value being saved in context null (instead of previous NPE)
Question - do we want to fail or return null when header that is not present is being saved? Current fix makes the value being saved in context null (instead of previous NPE)
I'd say, it should behave the same way as for saving parts of the response body, when the path is missing.
I'd say, it should behave the same way as for saving parts of the response body, when the path is missing.
I'd say, it should behave the same way as for saving parts of the response body, when the path is missing.
Good point, currently we do not solve it on our side and let json path implementation handle it, eg:
com.jayway.jsonpath.PathNotFoundException: No results for path: $['asdName']
So I added assert to the headers... Do we want to add assert to json path as well (to keep the exceptions the same?)
I'd say, it should behave the same way as for saving parts of the response body, when the path is missing.
Good point, currently we do not solve it on our side and let json path implementation handle it, eg:
com.jayway.jsonpath.PathNotFoundException: No results for path: $['asdName']
So I added assert to the headers... Do we want to add assert to json path as well (to keep the exceptions the same?)
Do we want to add assert to json path as well (to keep the exceptions the same?)
I think it is not necessary.
Do we want to add assert to json path as well (to keep the exceptions the same?)
I think it is not necessary.
|
2025-04-01T04:10:22.237722 | 2017-06-08T04:49:55 | 234410800 | {
"authors": [
"backtoback1",
"mr64bit",
"xorrior"
],
"license": "bsd-3-clause",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14068",
"repo": "EmpireProject/Empire",
"url": "https://github.com/EmpireProject/Empire/issues/568"
} | gharchive/issue | how can add new module to empire 2?
Empire Version 2
OS Information (kali linux)
Hello Guys i was trying to add new module to empire V2 i put the module in the right path
(the powershell script and the python script) but when i run the module it show this error
[!] Invalid module or agent language version: 'MinLanguageVersion'
Thanks
Regards
Can you show us the self.info and self.options dictionaries?
On Thu, Jun 8, 2017 at 12:49 AM, backtoback1<EMAIL_ADDRESS>wrote:
Empire Version 2 OS Information (kali linux) Hello Guys i was trying to
add new module to empire V2 i put the module in the right path
(the powershell script and the python script) but when i run the module it
show this error
[!] Invalid module or agent language version: 'MinLanguageVersion'
Thanks
Regards
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/EmpireProject/Empire/issues/568, or mute the thread
https://github.com/notifications/unsubscribe-auth/ACFwUGIs7sOW2D8UNZUu6Ev6cnvkSoEIks5sB311gaJpZM4NzksZ
.
HI @mr64bit
where i can find this files?
@backtoback1 If you look in empire/lib/modules/ you should see a powershell and python module template. Modify the respective template for your module, then move that module file to the appropriate folder.
@xorrior the MinLanguageVersion of powershell template is the same with the module i want to import
both is 2 and i can't edit python version at my module
|
2025-04-01T04:10:22.246594 | 2019-12-04T16:21:55 | 532792033 | {
"authors": [
"k-wall",
"lulf"
],
"license": "apache-2.0",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14069",
"repo": "EnMasseProject/enmasse",
"url": "https://github.com/EnMasseProject/enmasse/issues/3542"
} | gharchive/issue | Addresses stuck in configuring after kubernetes api server restart
Describe the bug
During Kubernetes API server restarts, the admin/agent pod seems to fail reconnecting its watch. Until restarted, new addresses are not provisioned.
The steps to reproduce should be considered a working hypothesis for reproducing the issue and have not been confirmed.
To Reproduce
Steps to reproduce the behavior:
Create address space and wait until ready
Restart openshift api server(s)
Look for watch failure in agent log
Try to create new addresses and see them not getting provisioned
Expected behavior
Address is provisioned
Additional context
agent.log
I was able to trigger a similar issue locally. However, this time it was the standard-controller that never got notified of address creation after the restart, until it reached the resync point where the watch is recreated.
I think we should add a similar logic to the agent, i.e. recreate any watches at a specific resync interval (every 5 or 10 minutes) to recover from this kind of scenario.
I'm also wondering if we should have the error event in agent's Watcher.watchrestart the watch. The coding would need to take care not to start two watches if both end and closed get fired.
The underlying reason that the watch 'stuck' remains unclear, however #3544 means that a similarly stuck watch will be automatically aborted and restarted by the period resync
|
2025-04-01T04:10:22.261460 | 2024-11-15T22:09:36 | 2663300330 | {
"authors": [
"Arcitec",
"EnderIce2"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14070",
"repo": "EnderIce2/rpc-bridge",
"url": "https://github.com/EnderIce2/rpc-bridge/issues/8"
} | gharchive/issue | New instructions for connecting Flatpak Wine/Proton games to native Discord RPC clients
Hey, absolutely awesome project! I love how you've created a service that runs in the background and bridges the Windows pipe to the UNIX pipe. :)
On that note, the entire section about Flatpak apps is using a deeply broken, unfixable method of linking to the host socket.
Here are the resources that describe the best way of linking between native Discord clients and your Flatpak games:
https://github.com/Arcitec/discord-flatpak-rpc-bridge
Additional information at the arRPC project, which is an open-source Discord RPC implementation: https://github.com/OpenAsar/arrpc/issues/122
Installing that bridge is all you have to do. The Flatpak apps (such as Heroic, Steam, Lutris) must of course also be correctly configured to use the RPC sockets, as described here, but that's a job for the Flatpak app maintainers.
Hey, absolutely awesome project! I love how you've created a service that runs in the background and bridges the Windows pipe to the UNIX pipe. :)
Thank you!
On that note, the entire section about Flatpak apps is using a deeply broken, unfixable method of linking to the host socket.
Installing that bridge is all you have to do. The Flatpak apps (such as Heroic, Steam, Lutris) must of course also be correctly configured to use the RPC sockets, as described here, but that's a job for the Flatpak app maintainers.
Hmm, looks like a good idea. I will have to test myself when I got more free time and maybe automate it?
@EnderIce2 Feel free to use the project for anything you want, or even just tell people to install it if you detect that the Flatpak RPC socket is missing. It requires sudo to install the service, and must be installed via the host (not inside the Flatpak environment), so that's a problem for automating installation. I don't think you'll be able to automate it from the Wine side.
discord-flatpak-rpc-bridge is however 100% complete and won't need any changes, so what you see there is the finished project.
Systemd sets up a listening socket at the Flatpak RPC path, then as soon as a Flatpak tries to use the Discord RPC socket, systemd launches the proxy service and gives ownership of the listening socket to the proxy process, bridging the Flatpak socket to the real native Discord RPC socket.
I wrote it in a way that people just ./install.sh a single time per computer, and it will be immediately installed system-wide for all users, with no need to think about it anymore. It'll just exist in the background as a socket trigger, and as soon as some Flatpak uses Discord RPC, the lightweight bridge/proxy starts up. Things just work automatically after that.
Flatpaks will not need any changes to their manifest/permissions. They just have to be configured by the Flatpak author to use the standardized xdg-run/app/com.discordapp.Discord:create permission.
|
2025-04-01T04:10:22.300785 | 2024-06-28T09:12:49 | 2379966116 | {
"authors": [
"EngineerGuy314",
"nilspupils",
"serych",
"whallmann"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14072",
"repo": "EngineerGuy314/pico-WSPRer",
"url": "https://github.com/EngineerGuy314/pico-WSPRer/issues/27"
} | gharchive/issue | Option to use as a stationary WSPR beacon?
First of all thank you very much for this wonderful piece of software!
Is there any chance you are planning to develop this also into a stationary beacon with the option to disable tracking and to choose the transmitting band (and processor clock) within the console options?
Thanks and best wishes,
Nils
It should be possible to add the CPU clock option to the console menu.
What do you mean by disabling tracking? There are Maidenhead coordinates in the normal WSPR packet and you need to use GPS receiver to correct the oscillator frequency. Or do you just mean a beacon transmitting constant frequency? You still need a GPS to correct it.
Jakub, OK1SE
into a stationary beacon with the option to disable tracking
as serych said there is no reason you cannot use it as stationary beacon right now.
If you configure it just for the Zachtek protocol, it will transmit perfectly standard WSPR Type-3 messages. oops, i take that back, it will encode altitude into the power fields, which is definitely not standard...
Adding a config option to do just a single, WSPR type-1 beacon message shouldnt be too hard, and I agree is good idea. I will keep this issue open until I can get around to it.
But I guess the question is, how flexible does it need to be? Does it need option to specify which timeslot? Every 2 minutes or once ten minutes enough? At specific fixed frequencies, or frequency hopping? Alternating different bands on different timeslots? I might need to re-think the way I am doing the user-interface, it might be very cumbersome to implement this many selections. But I can see a lot of use for a dirt-cheap WSPR beacon.
30, 40 or 80 meter bands shouldn't be too hard to implement. And for a stationary application with an AC power source we could put back the overclocking and probably run it on higher frequencies too.
You still need a GPS to correct it.
absolutely. Although, if you use a pico-W, it might be possible to do frequency correction based on reading time values from ntp.org or something similar. It would have to average out readings over several minutes, but that would be enough if you mount it somewhere with relatively constant temperature. not really something i want to pursue.
my opinion: dont put some new bugs in there for this tiny ballon version.
It may be a better idea to Clone a new project?!
EngineerGuy314 @.***> schrieb am Fr., 28. Juni 2024,
16:05:
You still need a GPS to correct it.
absolutely. Although, if you use a pico-W, it might be possible to do
frequency correction based on reading time values from ntp.org or
something similar. It would have to average out readings over several
minutes, but that would be enough if you mount it somewhere with relatively
constant temperature. not really something i want to pursue.
—
Reply to this email directly, view it on GitHub
https://github.com/EngineerGuy314/pico-WSPRer/issues/27#issuecomment-2197010108,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKZWUDRY42LKN3GRM3MB53ZJVURXAVCNFSM6AAAAABKBPCQRGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJXGAYTAMJQHA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>
I will add these to the list of features for a future cloned or forked version.
|
2025-04-01T04:10:22.305324 | 2017-12-01T23:11:17 | 278623994 | {
"authors": [
"george-e-shaw-iv"
],
"license": "mit",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14073",
"repo": "Ennovar/gPanel",
"url": "https://github.com/Ennovar/gPanel/issues/100"
} | gharchive/issue | Impliment domain manager
Severity level (1-10):
10
Files/Directories Involved:
account/ (and other various API endpoints in the backend)
Description:
The account panel needs to have a place to register which domains are pointed at the server's name-server(s). The name-servers will also be listed here for convenient access to the owner of the account.
With that being said, there also needs to be a way to configure nameservers/automatically detect them from the server... I'm honestly not too sure how that works.
Once an account owner registers a domain in their account, that will be stored in a database that links that domain to the bundle. Any requests coming in from port 80 of the server (which will be linked to the nameservers in some way shape or form... also not too sure how this works) will take a look at the 'Host' header field, look for that specific host in the database, and if that domain exists in the database, route the request to that bundle.
Personal Comments:
This is going to be hard.
In PR #108 it says the following still needs addressed on this issue:
* Listing all of them on the server side and allowing them to be deleted from there
* Nameserver configuration from the server side
* Displaying nameservers to the clients on their account panels
|
2025-04-01T04:10:22.311477 | 2020-11-18T09:01:32 | 745468841 | {
"authors": [
"coveralls",
"magaliruffier"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14074",
"repo": "Ensembl/ensembl",
"url": "https://github.com/Ensembl/ensembl/pull/545"
} | gharchive/pull-request | ENSCORESW-3591: clean up deprecated methods
Requirements
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion;
Review the contributing guidelines for this repository; remember in particular:
do not modify code without testing for regression
provide simple unit tests to test the changes
if you change the schema you must patch the test databases as well, see Updating the schema
the PR must not fail unit testing
Description
Some species have a separate config file to overwrite methods in various Mapper modules.
Some of these methods are not used any more and making maintenance of the config files difficult.
The proposed change removes any method that is not used in other modules.
Use case
Remove species-specific configuration that is not used.
Benefits
Code is cleaner and easier to maintain.
Possible Drawbacks
NA
Testing
Have you added/modified unit tests to test the changes?
No test cases available for the mapping part of the xref pipeline.
The methods removed are not found any where else in the whole repository
If so, do the tests pass/fail?
NA
Have you run the entire test suite and no regression was detected?
NA
Coverage increased (+0.08%) to 82.365% when pulling 159b398929202182e87e05af639332fb5e172757 on feature/cleanup_species into 38af135d51d089a644b16db7450026dde01b7868 on master.
|
2025-04-01T04:10:22.359797 | 2024-02-21T21:12:50 | 2147722363 | {
"authors": [
"swilliamson7",
"wsmoses"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14075",
"repo": "EnzymeAD/Enzyme.jl",
"url": "https://github.com/EnzymeAD/Enzyme.jl/issues/1304"
} | gharchive/issue | Unexpected zero derivative
Not sure if this is an Enzyme issue or a my code issue, but Enzyme is returning a zero where I would expect a non-zero value. I'm using Checkpointing + Enzyme to try and compute a derivative of a cost function w.r.t. a specific parameter, and running this script will attempt to do it. It successfully runs, the relevant variables in the output structures S and dS are S.parameters.J (this is the total value of the cost function), and dS.parameters.\gamma\_0 (this is the derivative I want). I did a finite difference calculation to find the derivative and I really think it shouldn't be zero, so I'm not quite sure what's happening.
Happy to provide more info if needed!
An update to this, I think the zero is happening because the initial derivative is being chosen incorrectly/something is happening with the initial derivative. This could fall under either Enzyme or Checkpointing, I'm not sure which is causing it, but I get a correct non-zero value if I modify my code slightly so it's not quite a full issue
@swilliamson7 I assume this is resolved by our debug session earlier? Please reopen if not
|
2025-04-01T04:10:22.382043 | 2015-08-30T14:28:42 | 103928167 | {
"authors": [
"ddelella",
"finalight"
],
"license": "mit",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14076",
"repo": "Eonasdan/bootstrap-datetimepicker",
"url": "https://github.com/Eonasdan/bootstrap-datetimepicker/issues/1295"
} | gharchive/issue | multiple datetimepicker on modal not working well
I attempt to create multiple datepicker on a modal dialog
and this happens
the first date picker is still okay
however the second one has this problem...
same goes for the third one..
any idea on how to fix this?
They appear to be working just fine in the latest version for me (4.15.35). Make sure you do not have any other CSS which could be interfering.
this is very serious problem:
if it's CSS interfering with it; it would have affect all datetimepicker already, and not only just the first one.
so that's why I don't think it's my CSS at all, but rather the way it works with angular
I think the key was that you did not initially say it was using AngularJS. That might be it since I am not using that and mine is working.
|
2025-04-01T04:10:22.398134 | 2023-04-07T15:51:43 | 1658949299 | {
"authors": [
"ccuser44"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14078",
"repo": "Epix-Incorporated/Adonis",
"url": "https://github.com/Epix-Incorporated/Adonis/pull/1065"
} | gharchive/pull-request | Don't save groups
Groups saving in datastore is the worst feature ever. It makes datastores very bloated
Biggest bruh moment feature
Is there any reason they are saved? They shouldn't be saved under any circumstance, I can't think of a good reason for them being saved
|
2025-04-01T04:10:22.407685 | 2021-04-24T15:53:31 | 866777210 | {
"authors": [
"jbelien",
"ynux"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14079",
"repo": "EqualStreetNames/equalstreetnames",
"url": "https://github.com/EqualStreetNames/equalstreetnames/issues/174"
} | gharchive/issue | OSM organized editing
@kr4lt points out in https://github.com/EqualStreetNames/equalstreetnames-munich/issues/1 :
Your effort may possibly be considered organised editing (https://wiki.osmfoundation.org/wiki/Organised_Editing_Guidelines)
So should this project be added to https://wiki.openstreetmap.org/wiki/Organised_Editing/Activities ?
Good point, thanks @kr4lt !
EqualStreetNames project has been added to https://wiki.openstreetmap.org/wiki/Organised_Editing/Activities
|
2025-04-01T04:10:22.433564 | 2017-08-08T12:41:46 | 248701894 | {
"authors": [
"eanevul",
"likelion",
"swarupmohalik"
],
"license": "apache-2.0",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14080",
"repo": "EricssonResearch/scott-eu",
"url": "https://github.com/EricssonResearch/scott-eu/pull/42"
} | gharchive/pull-request | Make a PDDL ontology with shapes that is machine processable
Apparently, this PR also contains a PDDL generator, a Planner OSLC Service, and a number of useful OSLC features explained below.
I think I reached a "logical comma", here is current design of PDDL ontology:
Here is usage of that ontology to specify an example planning domain:
and example planning problem:
I believe this PR closes issues #31, #32, #33.
[ a oslc:Property ;
dcterms:description "Problem init."^^rdf:XMLLiteral ;
oslc:propertyDefinition :init ;
oslc:name "init"^^xsd:string ;
oslc:occurs oslc:Zero-or-many ;
oslc:valueType oslc:AnyResource
There should be exactly one occurrence of :init
:FluentMinusShape
a oslc:ResourceShape ;
oslc:describes :Minus ;
dcterms:description "Unary operator (-) in fluent."^^rdf:XMLLiteral ;
oslc:property [ a oslc:Property ;
dcterms:description "Unary operator argument (fluent)."^^rdf:XMLLiteral ;
oslc:propertyDefinition :argument ;
oslc:name "argument"^^xsd:string ;
oslc:occurs oslc:Exactly-one ;
oslc:valueType oslc:AnyResource
] .
There should be a :FluentPlusShape as well
:QuantifierShape
a oslc:ResourceShape ;
oslc:describes :Quantifier ;
dcterms:description "Quantifiers (forall,exists) in precondition."^^rdf:XMLLiteral ;
:ForAllShape
a oslc:ResourceShape ;
oslc:describes :ForAll ;
dcterms:description "Universal quantifier (forall) in effect."^^rdf:XMLLiteral ;
**Do we need the ForAllShape ? **
@swarupmohalik:
According to https://www.jair.org/media/1129/live-1129-2132-jair.pdf (page 119), it is possible to have multiple entries in init:
<init> ::= (:init <init-el>∗)
<init-el> ::= <literal(name)>
<init-el> ::= (= <f-head> <number>)
I didn't put a FluentPlusShape because it doesn't restrict anything. According to OSLC shapes it is not possible to set oslc:occurs to exactly 2 and it is not possible to restrict arguments with oslc:range to anything reasonable because inferencing over rdfs:subClassOf is not allowed. I only left resource shapes that can restrict at least something, e.g. for FluentMinusShape they restrict occurrences to exactly 1 in case of unary - operator.
There is ForAllShape for the case when it is used in effect, otherwise see my point 2 (such a shape will not restrict anything).
I know shapes are not perfect to perform complete validation of PDDL in RDF documents, but this is what they can do. If we want to impose stricter constraints, we need to use some other technology (e.g. SHACL), but I there is no implementation of it for Prolog, and I don't have time at the moment to implement it. In any case resource shapes are optional and everything will work without them, plus there are additional constraints imposed by the code to perform more validation during transformation operations.
Planner service base URI: http://<host>/planner/planCreationFactory
Generate PDDL text: do POST with Accept: text/x-pddl header and body containing either pddl:Domain or pddl:Problem resources or both.
Generate plan: do POST with Accept: application/turtle header and body containing both pddl:Domain and pddl:Problem resources. The returned resource is of type pddl:Plan.
In scott-eu/planner_reasoner/rdf/base/pddl_example.ttl
[ a pddl:Increase ;
pddl:parameter [ a :moved ;
:moved-m :move-b
] ;
pddl:argument 1
] ,
[ a pddl:Increase ;
pddl:parameter [ a :total-moved ] ;
pddl:argument 1
] ,
"1" should be an expression (f-exp)
::= ( )
::= assign
::= scale-up
::= scale-down
::= increase
::= decrease
::=
::= ( )
::= (- )
::=
::= ( ∗)
::=
I think the conditional effects (When) are not fully supported, am I right?
It is alright for the time being since the warehouse domain does not use conditional effects.
::= (:init ∗)
There is only one :init block in a problem.
Multiple s can be there in the block.
[ a oslc:Property ;
dcterms:description "Problem init."^^rdf:XMLLiteral ;
oslc:propertyDefinition :init ;
oslc:name "init"^^xsd:string ;
oslc:occurs oslc:Zero-or-many ;
oslc:valueType oslc:AnyResource
] ,
I was referring to this earlier. The shape allows multiple init blocks.
the occurs should be exactly-one
@swarupmohalik
The f-exp is an abstract syntax node, so it is not specified in the input RDF file, but it is properly handled by the PDDL generator (see pddl_generator.pl, which has f_exp rule). One of the possible contents of f_exp is a number, the type can be infered from the xsd literal type. So, the example file is correct.
The conditional effect using when construct is supported by the PDDL generator completely, but actual operational support is up to a planning engine that we plug in.
Regarding init: your interpretation is correct.
@swarupmohalik
The resource shape of init property allows multiple values of the property, not multiple init specifications. The PDDL generator always generates single init with all property values combined in it.
In general, resource shapes have nothing to do with syntax of PDDL files, they specify allowed properties of RDF files.
Done review on the PDDL ontology...
Considering Parameters. I like that there are no variables, and it is solved everything with parameters. Note that the order of parameters in an action is not important, however as you noted the order in a predicate or a function is important. Since there is only one ParameterShape i am ok with having sh:order (or any other mechanism to model the position) property there, even when not used.
On a side note, currently the plan is described as a set of steps using StepShape. Swarup and me discussed that we should include a plan validator tool in the planner adapter (probably VAL https://nms.kcl.ac.uk/planning/software/val.html) that will take the plan and translate it in a format of add/delete predicates, so that during runtime the Estimator knows whether the current state is equvalent to the planned state.
|
2025-04-01T04:10:22.439572 | 2020-03-24T18:21:02 | 587186707 | {
"authors": [
"Erigitic",
"MarkL4YG",
"codeturtle00"
],
"license": "mit",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14081",
"repo": "Erigitic/TotalEconomy",
"url": "https://github.com/Erigitic/TotalEconomy/issues/363"
} | gharchive/issue | Console Errors on Player Join
Sponge Version: 1.12.2-2825-7.1.6
Forge Version: 2838
Total Economy Version: 1.8.1
Description of issue
These may be 3 seperate issues, but all related to player connection.
On Player join, console will most of the time log a connection leak: https://pastebin.com/71P1N9S2
On player's first-join, there will be warnings of "Unknown column 'staff_balance' in 'field list'": https://pastebin.com/k7UMYAGg
I'm unsure what this is, but pretty sure it's been crashing my server at least once a day (this pastebin is a continuation of the last one): https://pastebin.com/YYBL3EKX
Not sure about that one. Might be true but is normally not that much of an issue since regular restarts are recommended for MC servers anyways.
That is because TE is currently not designed to automatically update your database when new currencies are registered. You can manually create a clone of the dollar_balance column and name it staff_balance and this will be resolved.
That is probably caused by the connection leak. When connections are leaked, at some point there are not connections left in the pool. Adjusting the pool size or just restarting more frequently will mitigate this issue. However, a fix needs to be implemented on TEs side.
All things aside, I am not sure whether or not @Erigitic will resume development on TotalEconomy any time soon. And my time as an active code-contributor is currently frozen too since my community no longer hosts MC servers. I would assist with any questions though.
I'm working full time so I don't have much time to work on Total Economy at the moment. But I would like to eventually get back to it and start fixing up all of the breaking issues such as the connection leak and the automatic updating of the database, which should address all of the issues you've outlined above. And @MarkL4YG, I appreciate you assisting people with this issue, along with all of the other issues.
|
2025-04-01T04:10:22.441996 | 2021-07-07T01:07:15 | 938382471 | {
"authors": [
"Erisa",
"superkid200"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14082",
"repo": "Erisa/Cliptok",
"url": "https://github.com/Erisa/Cliptok/pull/54"
} | gharchive/pull-request | Add BetterDiscord as naughty URL
BetterDiscord violates Discord ToS.
It is against ToS but I don't think it fits the reason of "Malicious URL" in quite the same sense. Plus talking about the thing isnt disallowed, only using it.
Well, I think better take the download link.
I'm afraid I wouldn't see the point in that either. Nobody is realistically going to link to it, and it's not so important it needs to immediately be removed like everything else in this list.
|
2025-04-01T04:10:22.478140 | 2022-09-01T18:43:22 | 1359258934 | {
"authors": [
"sadbox"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14083",
"repo": "Espresso-Aficionados/sprobot",
"url": "https://github.com/Espresso-Aficionados/sprobot/issues/9"
} | gharchive/issue | Image Saving Kinda Sucks
Consider alternatives to allow profile image uploads:
e.g. generate a link they can click to a separate website to do the upload, sign it with an HMAC token to verify that X link is allowed to update Y users profile
This was more or less fixed a while ago, go me
|
2025-04-01T04:10:22.481802 | 2018-09-05T08:27:56 | 357119258 | {
"authors": [
"jbiendara",
"shailesh91"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14084",
"repo": "Esri/arcgis-powershell-dsc",
"url": "https://github.com/Esri/arcgis-powershell-dsc/issues/93"
} | gharchive/issue | Multi machine setup - issues
Hello,
I've set up a five machine environment (Portal, hosted Server, Data Store, Image Server, GeoEvent Server). I used three configuration files:
BaseDeployment-ThreeMachine-10.6-ssl
GISServer-GeoEvent
GISServer-GeneralPurpose
During and after the installation, I see two issues:
Configurations 2. (GeoEvent Server) and 3. (Image Server) display incomplete server URLs.
The various servers are federated in portal with different ports (443 and 6443 respectively), although in all three configuration files I declared port 443 as "Federation - PortalPort".
Any idea or explanation for these issues?
Thank you very much, best regards,
Jürgen
Pull request #95 should solve this issue. You can fork the PR and try it out.
Closing the issue. Please open again if you have any further issues.
|
2025-04-01T04:10:22.509781 | 2018-08-07T16:56:38 | 348406083 | {
"authors": [
"mara-dolan",
"paulcpederson"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14085",
"repo": "Esri/calcite-web",
"url": "https://github.com/Esri/calcite-web/issues/972"
} | gharchive/issue | Links broken on https://esri.github.io/calcite-web/
Most of the in-paragraph links I clicked on https://esri.github.io/calcite-web/ are broken, but perhaps I don't have access to the target spots. Just thought it'd best to report it.
@mara-dolan updated, thanks for reporting!
|
2025-04-01T04:10:22.517555 | 2018-03-05T20:05:30 | 302442235 | {
"authors": [
"ACueva",
"BobBooth",
"csmoore",
"dfoll"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14086",
"repo": "Esri/distance-direction-addin-dotnet",
"url": "https://github.com/Esri/distance-direction-addin-dotnet/issues/535"
} | gharchive/issue | Distance and Direction Ring [and ellipse] tool causes ArcMap to go unresponsive click outside basemap extent
ArcMap <IP_ADDRESS>21 Distance and Direction <IP_ADDRESS> (3/5/18)
ArcMap <IP_ADDRESS>21 and MT build 23 (5Mar)
When you create a set of rings and radials (non-interactive mode), set a distance, number of rings, number of radials and click outside the extent of the map, add a point, it is not handled, and you can hit enter to start creating range rings, but ArcMap goes unresponsive. This also affects Ellipses.
We should handle this like we do Circles (https://github.com/Esri/distance-direction-addin-dotnet/issues/512).
Addressed in #546 - ready for QA/QC
While testing this I saw another, less common issue - written up in a new issue #547
I have tested this on ArcMap 10.6, the fixes appear to have worked, however, I'm noticing the following:
The label appears to be inverse while zoomed way out. Once you zoom in, it appears fine.
I'll log another issue to address these findings.
FYI @csmoore @kgonzago
Remaining work:
[ ] https://github.com/ArcGIS/solutions-defense-test-catalog/pull/127 Reviewed and merged.
[ ] Possible CMS work (@acueva is still looking into this)
@dfoll @topowright I believe this can be moved to done. Do we need a Verify tag to verify my CMS changes?
verified list as an issue addressed. was never listed as a known issue, so nothing to remove there
@ACueva I forgot to add that this should be added to the What's New page for Defense and the What's New section on the homepage.
[x] Resources page
[x] Defense What's New page
[x] What's New section on homepage
[df - 24Apr -- verified the fix is a message box that the point is out of bounds]
|
2025-04-01T04:10:22.600768 | 2016-08-29T08:43:48 | 173725246 | {
"authors": [
"cousquer",
"vbonamy"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14087",
"repo": "EsupPortail/esup-portlet-sympa",
"url": "https://github.com/EsupPortail/esup-portlet-sympa/issues/3"
} | gharchive/issue | EPTLSYMPA-1 Less and bootstrap style refactoring for Respondr
Styles for uPortal 4.3 and more
Styles in RWD
add Bootstrap markup
add bootstrap-fontawesone-checkbox (MIT)
table reflow Mixin on mobile and on multicolumns layout
Thank you Christian for your PR #4 -> the next TAG will be the version 5.0 :)
@vbonamy
thanks. wait a little for the NOTICE PR and the response of Olivier, before switching to 5.0
|
2025-04-01T04:10:22.602599 | 2019-07-22T17:32:19 | 471214936 | {
"authors": [
"alpine971",
"pidorawka"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14088",
"repo": "EternityX/DEADCELL-CSGO",
"url": "https://github.com/EternityX/DEADCELL-CSGO/issues/141"
} | gharchive/issue | SetupBones meme
I'm really-really interested in how overwriting entity id supposed to fix setupbones for you? |
2025-04-01T04:10:22.603587 | 2018-09-20T15:19:27 | 362238162 | {
"authors": [
"alexvandesande",
"marekkirejczyk"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14089",
"repo": "EthWorks/UniversalLoginSDK",
"url": "https://github.com/EthWorks/UniversalLoginSDK/pull/50"
} | gharchive/pull-request | Some CSS fixes
Could you give me write access to your repo so I can add branches directly to it?
Changes manually merged in #53
|
2025-04-01T04:10:22.613778 | 2024-05-29T13:38:12 | 2323363048 | {
"authors": [
"EuanScott"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14091",
"repo": "EuanScott/project-tweety",
"url": "https://github.com/EuanScott/project-tweety/issues/10"
} | gharchive/issue | Update base services implementation
What is it that I can improve upon
Take the already existing base impl for the services.dart and look into improving it in the following by adding in (as per the TODO comments):
Input Validation
Logging (dev purposes and to sentry.io/Firebase)
Tests
Modularization
Security
Note: Before any work is done, determine if this is really necessary and if not, just leave out the sections that aren't required.
Reason for the change
Let's improve on what is already implemented
Acceptance Criteria
[ ] Does the feature still do what its original intention was?
[ ] Have I made the overall system better? Explain.
Additional Context
The initial impl was entirely done using AI. See if you can keep on doing it this way.
hmmm... it seems that this may not be possible as I can't just access the raw JSON data on github. Maybe look into another way of doing this?
Firebase functions perhaps?
This work has been completed and can be found in the main branch.
The following has been done as per the issue description:
Input validation
Tests
Modularization has been deemed as YAGNI at this stage in the project. Should it be required in the future, it can be looked into.
Logging still need to be investigated and implemented (create a follow-up issue for this to investigate a potential solution (ideally freemium).
Acceptance Criteria
[x] Does the feature still do what its original intention was?
[x] Have I made the overall system better? Explain.
I believe that I have. I now have a solution that I can "plug and play" that has been tested to ensure that it works. Overall code quality has gone up.
Additional Context
This was done majority using duck.ai and github copilot as part of an investigation/feasibility study on my part. AI is a tool that we should all be using.
|
2025-04-01T04:10:22.628681 | 2019-01-29T20:50:40 | 404480624 | {
"authors": [
"CoskunSunali",
"Sureiya"
],
"license": "mit",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14092",
"repo": "Eugeny/terminus",
"url": "https://github.com/Eugeny/terminus/issues/634"
} | gharchive/issue | Titlebar not set for WSL shell
Is there any way to get the WSL shell's title bar set correctly?
For comparison, from top left to bottom right,
Windows cmd
WSL terminal
Git Bash
wsltty window (expected behaviour)
@Sureiya Have you found any workarounds?
|
2025-04-01T04:10:22.636506 | 2023-07-11T11:55:14 | 1798769150 | {
"authors": [
"JamesWrigley",
"RobertRosca",
"philsmt",
"takluyver",
"tmichela"
],
"license": "BSD-3-Clause",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14093",
"repo": "European-XFEL/EXtra",
"url": "https://github.com/European-XFEL/EXtra/pull/17"
} | gharchive/pull-request | Final packaging touches
As discussed this changes to a calendar-based numbering scheme, and potentially any future change we need on the way to first release.
@JamesWrigley @takluyver @tmichela
LGTM! We should also replace the initial tag.
O hello I did something having not seen this... oopsie
LGTM
LGTM
|
2025-04-01T04:10:22.666115 | 2024-02-15T12:00:20 | 2136352594 | {
"authors": [
"josephcummings"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14094",
"repo": "EventStore/EventStoreDB-Client-Java",
"url": "https://github.com/EventStore/EventStoreDB-Client-Java/pull/265"
} | gharchive/pull-request | DEV-282 - Upgrade grpc client and protoc to access arm64 artifact binaries
Changed: Updated gRPC client and Protoc to latest, which come with arm64 binaries, enabling compile on arm64
Depends on #264 for CI tests to pass
|
2025-04-01T04:10:22.702763 | 2021-04-15T10:31:25 | 858741674 | {
"authors": [
"EvgSkv",
"tel"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14095",
"repo": "EvgSkv/logica",
"url": "https://github.com/EvgSkv/logica/issues/32"
} | gharchive/issue | Documentation on -> operator
The tutorial uses at one point the -> operator.
# Finding most popular name for each year.
@OrderBy(TopNameByYear, "year");
TopNameByYear(year) ArgMax= name -> NameCountByYear(name:, year:);
While this seems to be a variant on the functional aggregation method, it's not documented anywhere. Is there a more complete language reference that can be linked?
Thanks!
Thank you for bringing this up. We will create a reference to make looking up meaning of functions easier.
Meanwhile as for the "->" operator: it's just a streamlined syntax for writing structure {arg:, value:}. E.g. the program
Q("hello" -> "world");
results in a table:
col0
{'arg': 'hello', 'value': 'world'}
Aggregating operator ArgMax takes in a single argument, which has to be a struct {arg:, value:}, it then finds an arg that has maximal value. So the program that you cited could be written as
# Finding most popular name for each year.
@OrderBy(TopNameByYear, "year");
TopNameByYear(year) ArgMax= {arg: name, value: NameCountByYear(name:, year:)};
Leaving the issue open, as we need formal documentation.
Meanwhile let me know if you have further questions.
Awesome, that's helpful! I had seen that struct behavior happening but didn't realize that it was being caused directly by ->. That makes sense now, though doubles as a need for functions like ArgMax needing documentation (sooner or later) as well.
|
2025-04-01T04:10:22.706254 | 2023-09-06T12:59:15 | 1883967117 | {
"authors": [
"EvgSkv",
"KantorSerhiy"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14096",
"repo": "EvgSkv/logica",
"url": "https://github.com/EvgSkv/logica/pull/284"
} | gharchive/pull-request | Databricks dialect
Hi @EvgSkv!
In the continuation of the discussion https://github.com/EvgSkv/logica/issues/236 -> I add the databricks dialect.
I am waiting for feedback from you!
Thank you.
Serhii.
hey @EvgSkv, i add Apache compliance comment and checked Unnesting and Records.
It works.
I'm not entirely sure about the function UnnestPhrase, but for my cases - it works.
also i added minor TODO, but they are not critical.
I hope it will be useful for you!
Serhii.
Looking great! I'll be resolving conflicts and merging the PR this week. Thank you @KantorSerhiy !
|
2025-04-01T04:10:22.723137 | 2023-10-20T08:19:00 | 1953778869 | {
"authors": [
"Exarkuniv",
"actraiser30"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14097",
"repo": "Exarkuniv/RetroPie-Extra",
"url": "https://github.com/Exarkuniv/RetroPie-Extra/issues/164"
} | gharchive/issue | Devilutionx error
Hello there just for your info devilutionx installation in not working,after a while it stops with an error saying:
home/pi/RetroPie-Setup/ext/RetroPie-Extra/scriptmodules/ports/devilutionx.sh line 31: cmake: command not found
home/pi/RetroPie-Setup/ext/RetroPie-Extra/scriptmodules/ports/devilutionx.sh line 32: cmake: command not found
Could not successfully build devilutionx diablo engine
(/home/pi/RetroPie-Setup/tmp/build/devilutionx/build/devilutionx not found)
What you posted doesn't tell me anything. That's the generic error that everything says when it fails
You need to post the log file.
cmake is missing from the depends you can understand that i think,when I
installed it manual everything worked fine.
On Sat, Oct 21, 2023, 2:05 AM Exarkuniv @.***> wrote:
What you posted doesn't tell me anything. That's the generic error that
everything says when it fails
You need to post the log file.
—
Reply to this email directly, view it on GitHub
https://github.com/Exarkuniv/RetroPie-Extra/issues/164#issuecomment-1773492184,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJCXONOGJBRGFK5AXKQE4OLYAL7SRAVCNFSM6AAAAAA6IUQZLSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZTGQ4TEMJYGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>
|
2025-04-01T04:10:22.754753 | 2016-02-09T14:21:44 | 132431282 | {
"authors": [
"AWhetter",
"bhouston"
],
"license": "bsd-3-clause",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14098",
"repo": "Exocortex/ExocortexCrate",
"url": "https://github.com/Exocortex/ExocortexCrate/pull/44"
} | gharchive/pull-request | Can now reattach Alembics to referenced geometry in Maya
This works by allowing the addition of intermediate nodes to the internal representation of the Maya scene graph when an associated Deformed Shape node is found that has been deformed by an ExocortexAlembicPolyMeshDeform. This is done for attachments only.
These intermediate nodes flag to the attachment code that it should connect to the Deformed node instead of the shape node, using a new connectTo attribute on SceneNodeMaya.
Fixes #43
Sweet. Thank you!
|
2025-04-01T04:10:22.761747 | 2019-11-07T23:37:41 | 519574636 | {
"authors": [
"awittha",
"natsen",
"sparshev"
],
"license": "Apache-2.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14099",
"repo": "ExpediaGroup/jenkins-spock",
"url": "https://github.com/ExpediaGroup/jenkins-spock/issues/45"
} | gharchive/issue | Pipeline logic is not executed using groovy-cps
Hi Guys,
I'm trying to find a testing framework that actually can execute the pipeline logic in the same way as workflow-cps-plugin do to catch the next bug in jenkins pipelines: JENKINS-59911
Expected Behavior
...
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running DefaultPipelineSpec
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.271 s - in DefaultPipelineSpec
[INFO] Running DeployerSpec
DEBUG: CPS results: null, 6
DEBUG: CPS results: null, 6
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.093 s - in DeployerSpec
...
According to the bug, the logic should print "null, 6" and CPS tests of JenkinsPipelineUnit is almost doing the job: jenkinsci/JenkinsPipelineUnit#159 - but contains a bug with .find/.findAll and the other closure-based functions and its CPS testing is useless on a complex pipelines.
Actual Behavior
...
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running DefaultPipelineSpec
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.271 s - in DefaultPipelineSpec
[INFO] Running DeployerSpec
DEBUG: CPS results: 6, 6
DEBUG: CPS results: 6, 6
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.093 s - in DeployerSpec
...
jenkins-spock printing "6, 6" - that could mean anything, but for sure it's not the expected behavior - because of the previously described issue in groovy-cps.
Steps to Reproduce
Modify shared-library example with the next changes:diff --git a/examples/shared-library/vars/Deployer.groovy b/examples/shared-library/vars/Deployer.groovy
index 1e594fd..d399249 100644
--- a/examples/shared-library/vars/Deployer.groovy
+++ b/examples/shared-library/vars/Deployer.groovy
@@ -1,6 +1,10 @@
import com.example.SharedLibraryConstants
def call( _env ) {
+ def a = 4
+ def b = 3
+ a = b = 6
+ System.out.println("DEBUG: CPS results: ${a}, ${b}")
if( _env == "test" ) {
sshagent(["test-ssh"]) {
Run mvn clean verify in examples/shared-library
Additional Information
It seems like jenkins-spock actually not using groovy-cps to execute the logic.
It seems like jenkins-spock actually not using groovy-cps to execute the logic.
This is correct. For simplicity, we don't CPS-transform the code.
This was a deliberate design choice: jenkins-spock is focused on unit-testing pipeline code. That the pipeline DSL & Groovy code is CPS-transformed by Jenkins behind-the-scenes is an implementation detail that isn't relevant to whether the pipeline source code is correct or not.
To actually run Jenkins pipeline code, jenkinsfile-runner sounds better-suited - though I haven't used it and couldn't say whether it transforms its pipelines or not.
@awittha jenkins pipeline execution implementation has limitations/differences (https://www.jenkins.io/doc/book/pipeline/cps-method-mismatches/) from jenkins-spock test environment, it is useful if unit test framework can provide same limitations.
I am interested in your thoughts on how easier it is to enable jenkins-spock to run cps transformed code and what needs to be done.
From my understanding, After CPS transforming code, We would need to handle CPSCallableInvocation to be able to run CPS transformed code. Do you think this can be entirely done in jenkins-spock. Or does it need support from spock.
|
2025-04-01T04:10:22.774387 | 2022-12-13T19:09:57 | 1494990638 | {
"authors": [
"grgia",
"mallenexpensify",
"mananjadhav",
"shawnborton"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14100",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/13564"
} | gharchive/issue | Update dark mode colors
We'd like to make some adjustments to dark mode to make it a bit more friendly on the eyes. The feedback we received was:
The greens feel a bit too saturated and make the app feel almost too much like a theme or skin
There is too much contrast between sidebar and chat content
The white text has too much contrast with the background of the app
People want to be able to go back to light mode
Before entertaining the last option, we’d like to perfect the dark mode theme first and address the first three bullets. So that being said, let's do this:
darken white text from #FFFFFF to #E7ECE9
darken supporting text from #C9D3C5 to #AFBBB0
darken and desaturate borders from #1B5744 to #1A3D32
darken LHN/highlight BG color from #002E22 to #07271F
get rid of the rightBorder on the LHN, and use the inset style with rounded edges to reduce the harshness of the border
That gives us something like this:
Figma is here.
For the sidebar changes, I had trouble getting rid of the white background behind the sidebar area as a heads up:
Also for the sidebar:
we only want the rounded/inset effect to happen on desktop
to achieve this effect, we just need to give the sidebar a border of 8px using the same color as the appBG. Note that we can try making it so that we only have borderTop, borderLeft, and borderBottom. If we have 0 for borderRight, I think the content will fit snugly against the LHN
We also might want to consider making the LHN a bit wider since the border will eat up 16px of space. So maybe we bump up the sidebar width from 375px to something like 392px? (I love numbers divisible by 4 hehe)
Upwork Automation - Do Not Edit
Upwork Job URL: https://www.upwork.com/jobs/~01b424baf5aca597d8
Upwork Job ID:<PHONE_NUMBER>255846912
Last Price Increase: 2022-12-29
Will all true whites in the app be replaced with #E7ECE9? Or only text/buttons?
Good question. I think it can't hurt to just update the white variable we are using in colors.js:
Quick color check:
Yup, that checks out!
Do you know what might cause the sharp corners on the bottom section? I figured I'm applying the style in the wrong place. Pink for visibility :)
Here's where I'm at! For personal reference, I think I might need to add the border to the drawer styles instead
While I'm here, do you have an idea of what the RHN would look like? Would it have the same border?
Nice!
For the RHN, I think we can just leave it as-is.
I have no idea why the bottom is not getting the roundedness that we want, perhaps we need to add overflow:hidden to that container?
Also for the top right of the LHN, it doesn't quite look perfectly rounded - any idea what's happening there?
@mananjadhav can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01b424baf5aca597d8
Accepted @mallenexpensify
Paid @mananjadhav $1000.
Unsure if we want to update regression test steps for this so leaving open (I'm assigned) and bumping to weekly
@grgia @shawnborton do we need to add regression steps here? else we can close this one out?
I think we decided not to add anything for now? cc @grgia @JmillsExpensify
Gonna close until we have a plan for design-related issues. Otherwise it's updating the test steps "verify new dark mode colors are everywhere" which isn't too helpful or actionable.
|
2025-04-01T04:10:22.807994 | 2023-06-20T17:21:07 | 1765829827 | {
"authors": [
"Santhosh-Sellavel",
"Thanos30",
"aldo-expensify",
"bfitzexpensify",
"daordonez11",
"joekaufmanexpensify",
"kameshwarnayak",
"kavimuru",
"slafortune"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14101",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/21137"
} | gharchive/issue | [HOLD for payment 2023-07-21] [$1000] The cursor resets to the beginning for the edit message in draft
If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!
Action Performed:
Go to any report
Send any comment
Long press the comment
Press Edit comment
Set cursor position anywhere except at the beginning
Go to any other report
Come back to the report that has edit draft
Expected Result:
The cursor position remains unchanged
Actual Result:
The cursor position resets to the beginning
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
[x] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop
Version Number: 1.3.29-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/ca8641a6-4984-4242-ac0e-3f033c691473
https://github.com/Expensify/App/assets/43996225/254a5d80-ac77-4d63-989e-433d274b30fe
Expensify/Expensify Issue URL:
Issue reported by: @adeel0202
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686597604159949
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Upwork Job URL: https://www.upwork.com/jobs/~014a2eb8967fd1486f
Upwork Job ID:<PHONE_NUMBER>187853312
Last Price Increase: 2023-06-29
Looks good!
Proposal
Please re-state the problem that we are trying to solve in this issue.
The selection (cursor position / text selected) of the draft edit message is not persistent when we exit and re-enter a chat report.
What is the root cause of that problem?
We have this code here on ReportActionItemMessageEdit.js:
/**
* Save the draft of the comment. This debounced so that we're not ceaselessly saving your edit. Saving the draft
* allows one to navigate somewhere else and come back to the comment and still have it in edit mode.
* @param {String} newDraft
*/
const debouncedSaveDraft = useMemo(
() =>
_.debounce((newDraft) => {
Report.saveReportActionDraft(props.reportID, props.action.reportActionID, newDraft);
}, 1000),
[props.reportID, props.action.reportActionID],
);
The saveReportActionDraft() function is like that:
function saveReportActionDraft(reportID, reportActionID, draftMessage) {
Onyx.set(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS_DRAFTS}${reportID}_${reportActionID}`, draftMessage);
}
As you can see, we are only saving the draftMessage on Onyx, and not the values of the start and end of the selection.
What changes do you think we should make in order to solve the problem?
If we want to keep the selection value, we should also save the selection on Onyx as we do with the draftMessage.
This will also demand to make changes on all the different components that share the draftMessage, I will avoid adding all of them not to make this proposal too long, but I can provide a list of changed files below.
In general we should save the draftMessage like this:
function saveReportActionDraft(reportID, reportActionID, draftMessage, selection) {
Onyx.set(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS_DRAFTS}${reportID}_${reportActionID}`, {message: draftMessage, selection});
}
List of changed files:
Report.js
ReportActionItem.js
ReportActionItemMessageEdit.js
ContextMenuActions.js
genericReportActionContextMenuPropTypes.js
PopoverReportActionContextMenu.js
PS. This happens on all devices.
Proposal
Please re-state the problem that we are trying to solve in this issue.
The cursor resets to the beginning for the edit message in draft
What is the root cause of that problem?
The selection values in the react native TextInput are not being set in few scenarios. There are multiple open bugs relating TextInput selection option (29063, 35005) in react native GH. However they don't point to the exact scenario that we are facing.
One of the workaround mentioned is to use setNativeProps to set the selection values.
What changes do you think we should make in order to solve the problem?
Using setNativeProps to set the selection in the use effects of the following file will solve the issue
https://github.com/Expensify/App/blob/820fa93ad1e799c12d8b639b98018b5350ea17af/src/pages/home/report/ReportActionItemMessageEdit.js#L98-L101
becomes
useEffect(() => {
// required for keeping last state of isFocused variable
isFocusedRef.current = isFocused;
textInputRef.current.setNativeProps({
selection: selection
});
}, [isFocused]);
Result :
https://github.com/Expensify/App/assets/2232432/280a0f9e-442e-4cb5-a1e6-a4d07dfa4230
What alternative solutions did you explore? (Optional)
None
@thesahindia - thoughts?
@kameshwarnayak's proposal looks good.
🎀 👀 🎀 C+ reviewed
@thesahindia Thanks for the confirmation. I have submitted the proposal on Upwork. Will create the PR once I get the approval on Upwork.
I'll be out of office next week, I don't think you need any action from me 👋
PR merged
@thesahindia can you please complete the checklist?
@aldo-expensify @slafortune
Sorry for the late notice. The PR has caused a regression, please hold on for any action here, thanks!
This is the regression. Now this can be reproduced on main.
https://github.com/Expensify/App/assets/85645967/714fd14e-8981-4c77-b9d3-10741ad73212
As an fyi, the PR in this issue caused another regression here.
I think we should do a revert and then check with more time what is a better way to fix this
Revert: https://github.com/Expensify/App/pull/23518
I tried to recreate the issue with the latest main, and I can't reproduce it. Can anyone please confirm if we care recreate this?
Are you referring to this issue: https://github.com/Expensify/App/issues/21137#issuecomment-1646963074?
I reproduced it, and I confirmed the revert fixes it: https://github.com/Expensify/App/pull/23518
Maybe you can't reproduce because the revert was already merged to main?
@kameshwarnayak I'm able to reproduce it's just that instead of resetting to the beginning for me now it's resetting to the end instead of keeping the position.
@kameshwarnayak any update on this?
I'm having a hard time understanding what is complete in what timeframe on this GH and trying to set up payment and reassign this. @thesahindia are you able to summarize this for us?
CC @aldo-expensify @kameshwarnayak
reassigning a BZ member, I am out on sabbatical
@thesahindia bump on this question, so I can get payments sorted out:
I'm having a hard time understanding what is complete in what timeframe on this GH and trying to set up payment and reassign this. @thesahindia are you able to summarize this for us?
Sure, title updated.
So, my understanding is that we're waiting on the 2nd PR to be reviewed, merged and deployed, and then we can follow the typical close-out process (BZ checklist and payments issued) after that's done — is that correct?
Awesome, and https://github.com/Expensify/App/pull/24552 is the new PR, right?
@thesahindia Was a bit held up with a personal commitment. I will have a look at the comment in a couple of days.
Have we changed the behaviour of the focus on returning to a report. The focus is not on the draft when we open a report in the current main. Is it intended or a regression?
https://github.com/Expensify/App/assets/2232432/f62595bc-ad06-424b-851c-7495dbcda602
cc @Beamanator since you were talking the other day about documenting this kind of things (like focus behaviour) ^
The focus is not on the draft when we open a report in the current main. Is it intended or a regression?
No idea. For me it makes sense that it should be focused automatically, but I don't know if someone thought differently and removed it on purpose or if it is a regression.
@aldo-expensify My personal choice would be to focus automatically.
Should we proceed with that change or find if the change is on purpose? If there is a document with these changes, it would be great to refer.
OK, I think it might be related to this broader issue - https://github.com/Expensify/App/issues/15992 - that's dealing with general Composer Component Focus Issues. Does that sound right to everyone else?
I think it would make a lot of sense to define the focus behaviour we want and write it down so we don't end up changing it after because of someone personal preference.
I'm going OOO today, please reassign if you think you need an engineer. I'm not sure about where we are with this issue... it has the label "Awaiting Payment"
I'm not entirely sure, either. @thesahindia, what are your thoughts on where this is at? https://github.com/Expensify/App/pull/24552 was opened, but not merged, and my understanding is that the intent was to finalise that and then action payment on that PR.
https://github.com/Expensify/App/issues/15992 is open, set to monthly, and unassigned, so I don't think anything will happen there anytime soon.
So, should we move forward with https://github.com/Expensify/App/pull/24552, and then wrap this up, or should we leave this entirely?
@bfitzexpensify https://github.com/Expensify/App/pull/24552 this will not work because the behaviour has changed. With the current behaviour, we may not need a fix.
I am confused on the behaviour of the app when the user goes back to a report with a draft. Let me check the latest main and get back on that.
Any update on this one @kameshwarnayak?
Friendly bump @kameshwarnayak
@bfitzexpensify - will look into it today. Was but held up and but under the weather
@bfitzexpensify Tested this on the latest master. The behaviour has changed and the keyboard doesn't appear by default. Please find the video below.
https://github.com/Expensify/App/assets/2232432/7dc6521f-1ac6-4615-90df-c4066a9c4d85
If this is the new behaviour, then the bug becomes irrelevant.
Agreed @kameshwarnayak. Closing this out.
|
2025-04-01T04:10:22.824552 | 2023-08-09T16:00:54 | 1843582332 | {
"authors": [
"OSBotify",
"aditygrg2",
"jasperhuangg",
"lanitochka17",
"puneetlath",
"rezkiy37",
"situchan"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14102",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/24326"
} | gharchive/issue | Attachments - User can not scroll the PDF by using the down/up arrow in Keyboard
If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!
Action Performed:
Navigate to staging.new.expensify.com
On a conversation, click on the + button in the compose box
Upload a PDF
Verify you can scroll the PDF by using the up/down arrow in Keyboard
Expected Result:
User should be able to scroll through PDF file using the keyboard arrow
Actual Result:
Up/down keyboard arrows does not response when try to scroll to PDF
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] Windows / Chrome
[ ] MacOS / Desktop
Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/2282aa52-e844-4885-9555-ca4c455adc56
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.
Hi, I’m Michael (Mykhailo) from Callstack and I would like to work in this issue, because I am the author of the broken PR.
Proposal
Please re-state the problem that we are trying to solve in this issue.
User can not scroll the PDF by using down/up arrow on keyboard
What is the root cause of that problem?
The PDF is not autofocused as soon as the preview modal of PDF appears
What changes do you think we should make in order to solve the problem?
We just need to add focus to the modal element when it is launched. It can be easily done by adding a focus event.
here
Implementing event.nativeEvent.target.focus() on the onLayout listener will help us to achieve the same.
What alternative solutions did you explore? (Optional)
N/A
Implementation:
https://github.com/Expensify/App/assets/98523623/9b34de46-35b9-4c50-b86c-04296b131c0c
Guys, as I commented above this is a regression from https://github.com/Expensify/App/pull/22760 where I am an author of changes. So, it should be self-assigning.
This is not open for proposals everyone.
The offending PR author (@rezkiy37) and reviewer (me) will be taking this.
Thanks @situchan, be sure to tag this issue in the PR fixing it!
Discussion ongoing: https://expensify.slack.com/archives/C01GTK53T8Q/p1691596990023679
@jasperhuangg I can take this over since it's related to an issue I was CME for.
Looks like this was deployed to production quite a while ago. Closing!
|
2025-04-01T04:10:22.847941 | 2023-10-05T17:23:27 | 1928744296 | {
"authors": [
"DylanDylann",
"alexpensify",
"kbecciv",
"s77rt",
"studentofcoding"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14103",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/28937"
} | gharchive/issue | [$500] Security - Error message displays briefly after reopening the 2FA step 2 page
If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!
Action Performed:
Go to Settings > Security > Two-factor authentication
Click on the Copy button
Click on the Next button
Enter an invalid code
When the error message shows up, click on the back icon
Click on the Next button again
Expected Result:
Error message is not displayed after reopening the 2FA step 2 page
Actual Result:
Error message is briefly displayed after reopening the 2FA step 2 page
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop
Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/7297379f-5b18-4374-b5e9-a3c754671fa0
https://github.com/Expensify/App/assets/93399543/719d9fff-5e3c-438d-9e1d-da1031e595ab
https://github.com/Expensify/App/assets/93399543/f59ad6dd-7f5a-4464-b249-ba57eb8269ba
https://github.com/Expensify/App/assets/93399543/a23ef437-2d32-4c5f-a8fb-b0a1999221e5
https://github.com/Expensify/App/assets/93399543/a89f6a38-5180-4e8b-b1e1-4a2b376aeee4
https://github.com/Expensify/App/assets/93399543/a8ec3b78-a3b8-48c7-b4ca-442b997350fc
https://github.com/Expensify/App/assets/93399543/e00800cb-37ba-41b7-af56-5eb386752bb2
Expensify/Expensify Issue URL:
Issue reported by: @adeel0202
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696253182828299
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Upwork Job URL: https://www.upwork.com/jobs/~01c5525a081fe174f8
Upwork Job ID:<PHONE_NUMBER>785621504
Last Price Increase: 2023-10-05
Proposal
Please re-state the problem that we are trying to solve in this issue.
Error message displays briefly after reopening the 2FA step 2 page
What is the root cause of that problem?
When we enter the wrong 2FA code, we will update the errors in the onyx account, and back to step 1 return to step 2, we still have errors in the onyx account until the function clearAccountMessages in here is finished running.
What changes do you think we should make in order to solve the problem?
In here We should clear errors in account when we back to step 1
useEffect(()=>() => Session.clearAccountMessages(), [])
What alternative solutions did you explore? (Optional)
Proposal
Please re-state the problem that we are trying to solve in this issue
Security - Error message displays briefly after reopening the 2FA step 2 page
What is the root cause of that problem?
The root cause of the problem is that the error message is not being cleared when changing pages. The error message is stored in the account object and is not being reset when navigating away from the VerifyStep component.
What changes do you think we should make in order to solve the problem?
To solve the problem, we need to clear the error message when changing pages. This can be done by adding a cleanup function to the useEffect hook in the src/pages/settings/Security/TwoFactorAuth/Steps/VerifyStep.js component.
Here's the updated code:
useEffect(() => {
Session.clearAccountMessages();
return () => {
Session.clearAccountMessages();
};
}, []);
By adding the cleanup function, Session.clearAccountMessages() will be called when the component is unmounted, effectively clearing the error message.
This change should reset and remove the error message when changing pages in the Security section.
Result
https://github.com/Expensify/App/assets/20473526/dc3a5c5d-023d-4acb-8eca-f7cfb9699314
What alternative solutions did you explore? (Optional)
None
cc: @alexpensify @s77rt
@DylanDylann Thanks for the proposal. Your RCA makes sense. The solution is mostly okay except that I think we should clear the error in the responsible page and not the component i.e. in VerifyStep and not TwoFactorAuthForm.
@studentofcoding Thanks for the proposal. Your RCA is correct and the solution makes sense.
🎀 👀 🎀 C+ reviewed
Link to proposal
Not overdue. @grgia https://github.com/Expensify/App/issues/28937#issuecomment-1750706551
I've reached out in chat
It's ready to be review @s77rt
The PR that introduced the bug has been identified: https://github.com/Expensify/App/pull/23060
The offending PR has been commented on: https://github.com/Expensify/App/pull/23060#discussion_r1361373743
A discussion in #expensify-bugs has been started: Not needed
Determine if we should create a regression test for this bug: No
Hi guys, as today is the date for the payment, please kindly proceed it, thanks!
@s77rt @alexpensify
Here is the payment summary:
@s77rt - Reviewer $1000
@studentofcoding - Contributor $1000
@adeel0202 - Reporter $50
Upwork Job: https://www.upwork.com/jobs/~01c5525a081fe174f8
*If applicable, the bonuses will be applied on the final payment
Extra Notes regarding payment: There is an urgency bonus - https://github.com/Expensify/App/issues/28937#issuecomment-1761365861
Great work, everyone has now been paid via Upwork!
@alexpensify The total here should be $750. I have refunded the
Thanks @s77rt -- it looks like I miscalculated the amounts and I've updated the summary.
Thanks for the payment @alexpensify, but yes it should be $750. How do I refund the remaining $250? (also Upwork already deducted $50 from the bonus, lol)
I appreciate your honesty here. I confirmed that all refunds have been sent via Upwork. Thank you!
|
2025-04-01T04:10:22.873225 | 2023-12-29T00:18:01 | 2058955855 | {
"authors": [
"MariaHCD",
"MitchExpensify",
"abdulrahuman5196",
"aswin-s",
"cead22",
"lanitochka17"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14104",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/33731"
} | gharchive/issue | [$500] Web - Settings - Unable to log out after being redirected to ND from OD by clicking on workspace
If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!
Version Number: 1.4.18-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Log out of ND
Log into OD with an account that has an existing workspace without a bank account
Click on "Continue setup" in the inbox task or Settings> Workspace > User's workspace
After being redirected to ND, click on the avatar and sign out
Expected Result:
User is logged out and the home screen is displayed
Actual Result:
The page refreshes and the user is still logged in
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] Windows: Chrome
[ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/78819774/e5cde966-c16e-4e16-8e2b-c61991efbe8f
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Upwork Job URL: https://www.upwork.com/jobs/~0152728ca06936b7d2
Upwork Job ID:<PHONE_NUMBER>973801472
Last Price Increase: 2023-12-29
Proposal
Please re-state the problem that we are trying to solve in this issue.
User is not getting signed out after being redirected to ND from OD
What is the root cause of that problem?
We are using a transition url with shortLivedAuthToken to redirect from oldDot to newDot. We are using exitTo param for navigating to a screen immediately after signIn. The transition url route is mapped to loadLogOutPreviousUserPage.
https://github.com/Expensify/App/blob/5c5c862a10b75214899da32333a7f3a694e38be3/src/libs/Navigation/AppNavigator/AuthScreens.tsx#L268-L272
TheLogOutPreviousUserPage has an effect which handles the exitTo param in transition url. Note that we are directly navigating to exitTo route from transition route.
https://github.com/Expensify/App/blob/5c5c862a10b75214899da32333a7f3a694e38be3/src/pages/LogOutPreviousUserPage.js#L57-L65
When user closes the Connect Bank Account modal, screen goes back to the transition URL. So if user tries to signout at this point, the page reloads with transition url which will again invoke signInWithShortLived access token which inturn will sign the user back in.
What changes do you think we should make in order to solve the problem?
We should reset the transition route before navigating to exitTo route in LogOutPreviousUserPage . This prevents the screen from going back to transition route on closing the modal.
if (exitTo && exitTo !== ROUTES.WORKSPACE_NEW && !props.account.isLoading && !isLoggingInAsNewUser) {
Navigation.isNavigationReady().then(() => {
Navigation.goBack(ROUTES.HOME);
Navigation.navigate(exitTo);
});
}
What alternative solutions did you explore? (Optional)
None (edited)
Expected right now
@MitchExpensify As explained in the proposal above this seems to be a bug on client side which re-authenticates the user using the short lived auth token just because we are not clearing the used transition url. This bug will also cause below screen to be shown when user tries to signout when the short lived token has expired. Both of these results are not as per expectation.
Could you please shed some light on why this is the expected behaviour at the moment or point to a discussion where this is discussed in detail?
I initially misunderstood the issue, I think this fits into Wave 9 because its related to the redirect introduced in that wave
@abdulrahuman5196 Do you think this looks like it will need to be handled internally?
Reviewing now
@aswin-s I am unable to fully understand your proposal. I assume you are saying we using the same exitTo url during transition and during logout as well, which is causing the user to re-signin.
And in the change mentioned, you are just routing to home before navigating to exitTo which seems to be a workaround IMO.
Let me elaborate the series of events once again
User logs into old dot, taps on the "Continue setup" for bank account button
Gets redirected to Newdot with a url of the pattern
https://staging.new.expensify.com/transition?accountId=123&email&user%40gmail.com&shortLivedAccessToken=1234&exitTo=bank-account%2Fnew%3FpolicyID%3D72D1
Note that the route being used is /transition
On NewDot '/transion' route is being handled by LogInWithShortLivedAuthTokenPage & loadLogOutPreviousUserPage components. It logsOut previous user and signins in again using the short lived token in the Url. This is a regular GET url and could pasted any time within the validity of shortAuthToken to signOut current user and login again.
After signin there is an effect in loadLogOutPreviousUserPage which basically redirects the user to the exitRoute. In this case it is /bank-account/new. This is a drawer page that opens on top of ReportActionScreen.
So navigation route changes from /transition to /bank-account
At this point user cancels the action and signs out
SignOut action closes the drawer and goes back in history, which takes user back to transition url
Page gets reloaded using the transition url which triggers a re-login
If you see above steps it is quite evident that the transition should have been from /transition -> /r/reportId (Home) -> /bank-account. The reason user goes back to transition url is because the home route is not set before navigating directly to a drawer screen. Thats the reason why user needs to navigate to ROUTES.HOME before navigating to an exitRoute. This could further be verified by simply closing the modal and checking the url in address bar.
https://github.com/Expensify/App/assets/6880914/7d8648f4-c228-4005-a339-a92aec23a466
Let me know if you have any further questions.
Next step here is for @abdulrahuman5196 to review @aswin-s 's resopnse
@abdulrahuman5196 Any feedback on above comment?
Reviewing now
REviewing now. thanks for the detailed explanation.
The proposal here https://github.com/Expensify/App/issues/33731#issuecomment-1871852199 and extended explanation here https://github.com/Expensify/App/issues/33731#issuecomment-1887559200 seems reasonable. But still wondering about routing to home and then routing to bank page.
@MitchExpensify Could you kindly involve internal engineer worked on Authentication and Session to double confirm, If the the thought process of the proposal is fine or is the transition url expected to behave someway different in this case requiring a different fix?
Could you kindly involve internal engineer worked on Authentication and Session to double confirm, If the the thought process of the proposal is fine or is the transition url expected to behave someway different in this case requiring a different fix?
This seems like a good question for @marcaaron or @cead22
The proposal looks good to me, and it's the only one we have for now that makes this work the way it should.
I understand navigating to home feels like a workaround, and if we have a way to set the home route or to remove the transition page from the navigation stack without navigating to home, those could be good fixes too. If we don't have a way to do either or no other way to accomplish this, then navigating to home is better than the bug, so I think we can go with the proposal and add a comment above Navigation.goBack(ROUTES.HOME); to explain why we're doing that
Thank you for the confirmation @cead22 .
@aswin-s 's proposal here https://github.com/Expensify/App/issues/33731#issuecomment-1871852199 looks good and works well. @aswin-s Kindly update your proposal as well on the new discussions. Would be helpful for future reference.
🎀 👀 🎀
C+ Reviewed
@abdulrahuman5196 Updated my proposal with additional details
@MariaHCD @abdulrahuman5196 I'm unable to reproduce this issue anymore. Looks like it got fixed over here.
Oh nice catch, I'll defer to @MariaHCD or @abdulrahuman5196 to confirm before closing or not
Yes. I don't see this issue anymore.
Nice, since this is no longer reproducible, I'd agree with closing this out.
|
2025-04-01T04:10:22.886492 | 2024-02-20T11:59:12 | 2144213563 | {
"authors": [
"izarutskaya",
"kbecciv",
"sonialiap"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14105",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/36874"
} | gharchive/issue | Task – Error message appears when mark as complete the task as group external user
If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!
Version Number: v1.4.43-2
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:
Action Performed:
Go to https://staging.new.expensify.com/
Login
Navigate to a Group Chat
Click on the + in the compose box and select "Assign task"
Enter a Title and assign a user who is NOT part of the group and that you have access to
Create the task
Log in as the user that was assigned the task
Click on the task report/conversation
Click on complete the task
Expected Result:
Task is marked as complete
Actual Result:
Error message appears when mark as complete the task as user C (task assignee, not task creator, not group member). The red dot appears in LHN and not disappearing after dismissing the error.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop
Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/0a5f2f73-1273-4e03-898a-58892162597b
View all open jobs on GitHub
I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
We think that this bug might be related to #vip-vsb
CC @quinthar
Checking if part of vip-vsb
Added to vsb and moved to weekly because we're not fixing bugs yet
Changing to weekly because we're not fixing bugs yet
Bugs are in the future ✨
The future is not overdue
Still on hold for the future
This has been waiting for the "future" for quite a while so I've asked for a retest in QA
Issue is still reproducible
https://github.com/Expensify/App/assets/93399543/01066d2b-bd46-41f5-a109-16a295f1292f
Thanks Katya!
Keeping the issue open to be fixed once priority is increased
Closing per this thread
|
2025-04-01T04:10:23.002083 | 2021-07-28T00:38:00 | 954367398 | {
"authors": [
"Christinadobrzyn",
"Julesssss",
"MelvinBot",
"arosiclair",
"kadiealexander",
"kidroca",
"mananjadhav",
"quinthar",
"roryabraham",
"trjExpensify"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14106",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/4264"
} | gharchive/issue | [Network][$2000] Implement periodic background updates on mobile, keeping Onyx in sync
If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!
cc @Julesssss
Context
Coming from this issue and also this one.
We have been working to improve the background data trickle of our mobile apps to speed up start-times and improve offline-first behavior. Thusfar, we have been relying on push notifications to wake the backgrounded or killed mobile app and execute some JS to update the app data. However, there are some strict OS limitations on how frequently push notifications can wake an app in the background and perform JS tasks. Furthermore, it seems those limitations are trending towards greater stringency in upcoming OS versions.
So we're hoping to supplement our background app updates through the use of react-native-background-fetch. Early testing shows that the library will allow fetching of report data when killed or backgrounded. We understand that 15 minutes is a best-case scenario and that this will vary widely depending on many variables that are outside of our control.
We need to implement the following:
Depend on react-native-background-fetch package
Set up regular (non-headless) task to run in the background periodically (Android | iOS)
Setup a second headless task which will run when the app is killed (Android)
For now, both tasks should call the fetchAllReports function (later issues should simplify this API call)
Action Performed:
Background the mobile app OR kill the app
Wait 15+ minutes.
Expected Result:
Our background tasks should run, fetching report data and persisting it to Onyx
Actual Result:
Nothing 🙃
Workaround:
n/a
Platform:
Where is this issue occurring?
[ ] Web
[x] iOS
[x] Android
[ ] Desktop App
[ ] Mobile Web
Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
View all open jobs on Upwork
@Julesssss Thoughts on making this external?
Love this!
On Tue, Jul 27, 2021 at 5:38 PM Rory Abraham @.***>
wrote:
@Julesssss https://github.com/Julesssss Thoughts on making this
external?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Expensify/App/issues/4264#issuecomment-887924260, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEMNUWJLKSZXNAY5NKZ7Y3TZ5GP5ANCNFSM5BDJLJVA
.
If you're planning to make it external, I've got experience with react-native-background-fetch and react-native-background-timer`. I had used it to fetch Ads in the background for a Radio app.
The older version of 'fetch' had issues with the iOS and had to combine 'timer' too. But updates of 'fetch' won't require a timer now. I would still highlight that these are not 100% reliable for all the different models.
Thoughts on making this external?
I think some work can eventually be made external, but for now I would like to keep it internal while I research and test which libraries best meet our requirements, ensuring we implement this critical feature correctly. It doesn't look like react-native-background-fetch meets the Android 12 requirement -- so we may need an alternative (other libraries do seem to abide by the OS guidelines).
Sure. As far as my experience goes, you won't find a one-size-fits-all lib/solution for all platforms.
I would recommend creating a wrapper around existing one/multiple libs and keeping it outside of the main App repo.
I was working on another WIP PR today, will pick this up tomorrow after I submit it.
Started on this, but switched focus to an API-Error fire and a couple of houry QA issues.
I have started looking deep into the libraries. One thing unrelated to this issue is that I need to confirm whether the Urban Airship headless service is foreground or not. If not then we should be able to reduce the OS cooldown by making it a foreground headless service (or asking UA to do this) -- will follow up tomorrow.
@Julesssss Eep! 4 days overdue now. Issues have feelings too...
I took a good look at the alternative packages, but react-native-background-fetch meets our requirements and has the best documentation/support. For iOS the default native solution is used and for Android It uses JobScheduler under the hood, which the OS will happily let run (as opposed to Services).
This alternative react-native-background-worker would be even better as it uses the newer WorkManager solution, but the package does not support iOS. I don't think it's worth the effort to use one package for each OS selectively, so let's stick with react-native-background-fetch for now.
Android seems far easier to test as we can manually trigger tasks, so I started there. Some setup is required, which I'll document in this issue for now:
As expected, without enabling Headless the Background task will only succeed if the app is in the foreground or background. but will cancel immediately if the app is killed (next step will be to enable headless support)
Compiling a release build will be necessary to test Headless mode
Seems like it should be tied to the main App lifecycle, but need to confirm this. I need to make sure we don't initialize the task again when running the headless app
TSBackgroundFetch logs will appear in the native IDE consoles (or Flipper), our logs will appear in the JS console
We can manually run tasks for testing on Android with adb shell cmd jobscheduler run -f com.expensify.chat 999
I also found this excellent source of information on which device manufacturers attempt to further restrict apps and how to get around these issues: https://dontkillmyapp.com/. Finally, this issue has some hints for configuring headless tasks. I'll continue from there tomorrow.
WIP PR
Had some issues with the example project setup, but I was able to both Headless and non-headless background tasks via the example app:
In our app I'm not yet able to get headless tasks to run. Will continue to debug. We report the broadcast intent, but see no other logs.
@Julesssss Eep! 4 days overdue now. Issues have feelings too...
I'm unable to focus on this currently due to allocations, but now that I've settled on a library that suits our needs and works as expected, we can probably export this issue.
CC @mananjadhav -- perhaps you would be interested in working on this issue next week if I update the task with the latest information and make it external? As this is a relatively complex issue, I think we should double the payment.
That's right. @Julesssss Can you share what we have so far in a small comment and the expected goal here? I'll go through it.
Sure, I'll do this and update the issue but it will need to wait until next week as we're super busy on some high-priority internal projects.
@Julesssss Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
I've updated the issue with our requirements, following the process to make external.
Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.
FYI I'm going to take over from the contributor manager that is assigned here
Added to Upwork
Internal Upwork job posting - https://www.upwork.com/ab/applicants/1430356207860531200/job-details
External Upwork job posting - https://www.upwork.com/jobs/~01efefc0e091692d09
Doubling the price to $500.
CC @mananjadhav in case you are interested
@Julesssss I can pick this starting weekend. Is there a provision to discuss the budget for this task? I feel the effort required might be more than the quote. Let me know if we are open to this.
That sounds good. Yep, I totally agree this should be valued a bit higher than the average issue and would suggest that we set the price to $1000. I think the library is proven, but I would suggest taking a look at this PR to work out how to access Onyx in the background.
It also has steps for building a release version of the app that will let you kill the app entirely (unlike the JS/Chrome builds).
That sounds good.
That sounds good. Yep, I totally agree this should be valued a bit higher than the average issue and would suggest that we set the price to $1000. Does that sound reasonable?
That sounds good.
I think the library is proven, but I would suggest taking a look at this PR to work out how to access Onyx in the background.
It also has steps for building a release version of the app that will let you kill the app entirely (unlike the JS/Chrome builds).
Oh, that's great. Thanks for this. I was going through the link and I don't have access to the StackOverflow link mentioned in the PR.
Oh right, that is one of our internal Stack overflow posts, but you can find similar public posts with pretty much the same info. You just need to search 'How to build iOS/android release' separately. But please let me know if you run into any issues at all here.
Also, when would you like to take on the job? Let me know when you are ready and we will get you hired on UpWork.
As I'll start on this by the weekend, I can apply today or Monday. Anything is fine.
I've had an issue earlier running a build on my iPhone which said:
Provisioning Profile is missing and account is not a part of xxxx group
Does it need an Apple Developer account to run the release build?
If you can help with these questions that'll be great.
Does it need an Apple Developer account to run the release build?
I am pretty sure that's not necessary. See if you can enable the Automatically manage signing checkbox here. I think this is possible without being part of the Expensify team...
Thanks for the response. I’ll check tonight and get it working. Android shouldn’t be a problem as I’ve done that earlier.
@mananjadhav when you get a chance can you apply for the UpWork job too, please.
Done
@Julesssss This is what I get when I tried Automatically manage signing.
Hi @mananjadhav, I have asked in Slack here.
Thankfully iOS is the simpler platform to implement, so I am happy to manually test iOS for you if necessary.
Okay, I struggled with the release setup of iOS over the weekend with some other issues. I'll be starting back to it by tomorrow. Thanks 👍
Hired @mananjadhav in Upwork for this! 🎉
I ran their demo example and it looks okay. I'll now start with Expensify and close it by the weekend. Should have something to test by then with Android.
Hi @mananjadhav do you have an update on this for the team?
Still WIP. Should have by Wednesday.
@Julesssss Can you help with the release version of Android? Debug version works fine, but the release doesn't.
I am aware of the general key signing process and updating in build.gradle but I am not sure if Expensify follows something specific. I am unable to access the SO link mentioned in the push notification task.
Sure. There is a bit of info here. We're not doing anything special here though.
Can you share more info on the gradle error?
Okay, I'll try this info and get back. This looks similar to what I had on Google. What I wasn't sure was if I could replace the values in build.gradle with hardcoded values.
Yeah, you can hardcode the key info in build.gradle and just clear it before pushing the PR for review.
Hi @mananjadhav, I've placed this issue on hold as per this update, as we are prioritising issues related to a feature release scheduled for 9/24. As an apology for the delay, we will add a $100 bonus as a thank you for waiting.
Not overdue - on hold
I wasn’t available last week due to some exigency. Quick update, release build worked. Task doesn’t get auto triggered in the killed state but if I simulate the trigger it works fine. I’ll raise a draft PR today.
No worries @mananjadhav, thanks for the update! Please let me know if I can help in any way with testing, etc.
Please refer to this post for updated information on the n6 hold, we've raised the bonus to $250 for all issues where a PR is created before the N6 hold is lifted.
On hold for n6
I wasn’t available last week due to health issues. But yeah testing as of now.
Resumed now. I’ll raise the PR by tomorrow.
N6 hold is lifted - this job will include a $250 bonus for the n6 hold.
Still waiting on a PR from @mananjadhav
just checking in on this @Julesssss and @mananjadhav - it looks like we're still working through the PR?
@Christinadobrzyn yep, I've caused the delay here due to a busy period at work, then some OOO due to an injury. I'll be back onto this soon.
Sounds good @Julesssss! Looks like melvin is looking for an update - sounds like we're still reviewing the PR.
Yep, unfortunately, I haven't had time to review this due to being out for that injury, then the IPO week followed by OOO time. I'm back from the 29th. Sorry for the delay @mananjadhav!
This ticket is related to some of my work so I'll do whatever I can to help move it forward
I took a look at the PR here: #5953 and left a review
So far it looks on the right track but it just proves the concept of the idea - the background task that is defined would make a sample request and then log to the console
It should instead do something similar to the stuff we do on startup - make a call to fetch reports and then persist data to Onyx
Probably the task need to just import Report and call the appropriate method
Since the documentation states that if we receive a timeout event from BackgroundFetch we should abort immediately, we might need to implement something similar to what's proposed here: https://github.com/Expensify/App/pull/6388#issuecomment-991236205
@kidroca Thanks for the comments. Yes, the PR is still in draft and requires cleanup.
It should instead do something similar to the stuff we do on startup - make a call to fetch reports and then persist data to Onyx
We wanted to start a basic function call and then convert
Looks like the PR is still under review.
No change
Hi @mananjadhav, maybe we should think about closing this for now?
maybe we should think about closing this for now?
Why?
Was a bit unwell, will push an update by Fri.
Hey @mananjadhav, how is this looking?
Pushing the update today.
I spoke with @mananjadhav about dropping this issue and he agreed that it was for the best. Thanks for your time looking into this Manan, we will pay out $500 for the time you spent (once the issue is solved).
This issue is more complex than I initially realized, so I would also like to raise the bounty before seeking another contributor.
I know the current task is regarding fetching report data in the background, but once that is setup we can easily use it to push persisted messages when the user regains connectivity (instead of waiting for them to open the app again):
https://github.com/Expensify/App/issues/6690
Proposal
Extract a lib to configure and register a background-fetch task
Use existing logic to sync any report updates. Pretty much same as the reconnect callback here:
https://github.com/Expensify/App/blob/75c7986c1b3fcb1683c42adc2a0079ddc58e0b2d/src/libs/actions/Report.js#L1397-L1398
Use requiredNetworkType: BackgroundFetch.NETWORK_TYPE_ANY to skip running the task if the phone is offline
The implementation would try to do roughly this:
BackgroundFetch.configure({
minimumFetchInterval: 15
}, (taskId) => {
Log.info(`[Background] running background task: ${taskId}`);
fetchAllReports().finally(() => BackgroundFetch.finish(taskId))
}, async (taskId) => { // <-- Event timeout callback
// This task has exceeded its allowed running-time.
// You must stop what you're doing and immediately .finish(taskId)
Log.info(`[Background] task timed out: ${taskId}`);
BackgroundFetch.finish(taskId);
});
Furthermore...
When the iOS app is launched by a background task it would mount the root component and execute React lifecycle events
Mounting the React tree while in the background is something we'd like to avoid (as explained in this slack thread)
RN firebase has documented the problem and a possible solution here: https://rnfirebase.io/messaging/usage#background-application-state
We can apply their suggestion and alter AppDelegate.m so it passes an isHeadless prop to the root component
The root (<Expensify />) would use it to skip mounting the rest of the App tree
This is great, thanks for explaining the proposal.
So to clarify, this issue would now be to A) Implement periodic background updates ensuring that iOS is not mounting the app when running the background task, and B) Pushing cached messages in the background instead of awaiting the next App open. I wasn't sure that 2 will be possible to implement yet though, does that sound reasonable to you @kidroca?
We should also increase the bounty to $2000 given the additional tasks, and the complexity of implementing the above.
We can have B) as a continuation work, definitely a separate PR
I'm just bringing it back up because it would be a lot easier to implement if we already have A) and I see value in it
Gotcha. That's fine.
If you would like to continue with this issue I'll go ahead and assign you.
📣 @kidroca You have been assigned to this job by @Julesssss!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
Hi @Christinadobrzyn, would you please hire kidroca on UpWork and update the amount if that's possible? Thanks!
I can't find an Upwork job about this ATM, can you post it here when it's available
I think it is this one
Thanks, I'll wait for the amount to be updated before applying
Seems there are some discussion around the topic of this issue: https://expensify.slack.com/archives/C01GTK53T8Q/p1646082982919629
@Julesssss
New idea: Instead of using background-fetch which tries to sync periodically (poll) we can receive a data-only notification
Notifications payloads are small so we can't use them to update Onyx directly but we can use them to wake-up App and make it execute specific GET call and sync itself depending on the notification payload
Now that I think of it we don't even need to use data-only notifications. Currently we can implement the same when a regular notification wakes up App.
When a notification is received run fetchAllReports - ⚠️but only if reports haven't been fetched in the last 30 min. So receiving multiple pushes would not trigger too much fetching
At the end of fetchAllReports we capture a timestamp that will serve for this check
Some cons for background-fetch:
it's based on polling - increased battery usage (though I'm not sure how much)
not strict - you can set an interval like 30 minutes. but events can happen a lot less often or regularly
if the user kills the app iOS would no longer fire events and wake the app up to let us try to sync
Compared to Notifications:
not based on polying - a notification would wake up the app anyway and cost batter so we might as well try to fetch some data
easier to test - if we trigger fetchAllReports when a notification is received - it's visible in both server and local logs
if the app was killed a notification would wake it up and give it the chance to sync
Ideally at some point this can be switched to data-only notifications so we only run fetch when it's guaranteed there's data we don't have locally
I'm OK for implementing background-fetch the fetching logic would be reusable no matter what strategy triggers it. And things like not mounting the whole React tree are still needed
New idea: Instead of using background-fetch which tries to sync periodically (poll) we can receive a data-only notification
I can provide some additional context from my understanding of push notifications here @kidroca. There's a lot of inconsistent information out there, but this is my understanding.
The flag that makes a difference on iOS is called content_available, and that informs that iOS app that it needs to wake from the background and perform some operations. That flag can be passed with "silent" data-only notifications (i.e: no alert), or with "loud" notifications that will be displayed by the OS and included in the messaging center. In both cases, the flag informs the OS that it needs to perform a background update.
You may find some outdated information that says content_available only works when an app is backgrounded but not completely closed, but IIRC that changed as of iOS 10 or 11, and it works when the app is completely killed. We send the content_available flag with all our report comment push notifications, so we already have the background data updating implemented via push notifications. However, from the Apple Documentation:
The system treats background notifications as low priority: you can use them to refresh your app’s content, but the system doesn’t guarantee their delivery. In addition, the system may throttle the delivery of background notifications if the total number becomes excessive. The number of background notifications allowed by the system depends on current conditions, but don’t try to send more than two or three per hour.
There are also other variables that come into play. For example, from my testing background notifications do not work on iOS at all if the phone is in low power mode. I've also found that by saying "the system doesn't guarantee their delivery", Apple really means "the OS doesn't guarantee that your app will actually be awoken in the background when the notification is received".
So the problem in this issue is that background data updates on iOS are just not consistent or reliable. This issue is really meant to bootstrap the background updates we already have through a more reliable, OS-sanctioned channel via background-fetch.
A bit more detail too – when we receive a push notification, it includes the reportID and the reportAction. We just update the report with the single reportAction included in the notification payload. We could improve that and fetch all the new actions for the report, or maybe all actions for all reports. But I think the OS is pretty stringent in the amount of time you have to complete callbacks. It even might forbid the app from doing network requests in the background update, we would have to test and be sure that's allowed. If we can, though, this update strategy would make sense to me:
type
update
push notification
All actions for the single report with a new chat
periodic (background-fetch)
All actions for all reports
I agree this is a fair alternative, but also that notifications can be unreliable. For any reason the OS can throttle them and background updates help to handle these cases.
We do have other issues for the silent notification, but I think it's out of scope for this issue. Once this is done we can look at improving the notification logic in addition.
There are also other variables that come into play. For example, from my testing background notifications do not work on iOS at all if the phone is in low power mode
Power mode affects all background activities and background fetching/refreshing is disabled as well in low power mode
Apple really means "the OS doesn't guarantee that your app will actually be awoken in the background when the notification is received".
What's guaranteed though is the background push would be processed either in the background or when App is launched
So the problem in this issue is that background data updates on iOS are just not consistent or reliable.
Background fetch is actually subject to more rate limiting than background pushes - specifically app usage
Background push is subject to the same throttling as fetch, but is not gated by app usage
What does that mean:
Background fetch might run as little as 0 or 1 times per day, on the other hand receiving a background push might be delayed somewhat so that receiving 2-3 pushes in 30min. would only launch the app after the last push
I find push more reliable
This issue is really meant to bootstrap the background updates we already have through a more reliable, OS-sanctioned channel via background-fetch.
When App launches we still won't know whether Report data is fresh, and we'd still have to run fetchAllReports defeating the purpose of any prior polling that background fetch might have performed
If we're still going to trigger fetchAllReports when App is foregrounded, it makes little sense to poll the same action in the background
We could improve that and fetch all the new actions for the report, or maybe all actions for all reports.
I don't think we need to fetch actions - they are already getting delivered through Push Notifications. Pushes have TTL even if we've missed some (being offline) they would arrive. But even if that fails we have fetchAllReports when App is foregrounded
We can use background push to trickle and react to other updates silently - Reports last read, max actions, etc...
But I think the OS is pretty stringent in the amount of time you have to complete callbacks
Both fetch and push have a 30 sec. limit
It even might forbid the app from doing network requests in the background update, we would have to test and be sure that's allowed
You are allowed to use a notification to let an app know there's new data it can fetch from the server and fetch it in the provided 30sec. wake window. Bonus points if you're done earlier and signal the system it's free to re-suspend the app
periodic (background-fetch) All actions for all reports
I don't know about you but I see a lot of wasted bandwidth here
Unless we have a sure way to sync only stuff that we're lacking
If we're going to fetch all reports each time the app is foregrounded background-fetch loses even more value
I agree this is a fair alternative, but also that notifications can be unreliable. For any reason the OS can throttle them and background updates help to handle these cases.
background updates are arguably throttled even more
The aim of the OS is to predict and run a background updated shortly before you foreground the app (based on user habits), but that's not guaranteed to happen every time or even 50% of the time
While a push notification might be delayed, but will be processed at the time the app is being foregrounded
Background fetch tries to runs tasks periodically so that App can be fresh just before the user foregrounds it
It's great for stuff like fetching news, stock prices, social media feed - a constant stream of information where there's always something new to be retrieved
The world of a messaging / mailing it's not following the same dynamics. Modern apps use efficient budgeting and fetch new content when it becomes available, they are not blindly polling for new data as often as possible
Actual apple suggestion
Use background push as best effort way to download content
Can always download when app re-enters foreground
Okay, so given all that @kidroca, what's your suggestion?
One you login on mobile all relevant Report actions are immediately fetched
As explained on this slack thread any new report actions are delivered through Pusher and/or push notifications
Most of the time when App is focused we'll be up to date on actions
Since actions are already pushed to us I don't think we need to periodically fetch all report actions
Instead when the app is foregrounded it should be able to quickly fetch whatever might be missing - most of the time this would be nothing, so a fetchAllReports that returns 10 reports and 500 actions that you already have is not ideal
The idea I like so far is: Whenever a push notifications carrying a report actions is received - it re-fetches Report information regarding its own Report. The updated information would allows to make decision on whether we need to fetch anything more for the given report (if it's a Report we somehow don't have locally fetch it's latest 50 actions)
If we can somehow make fetchAllReports work with a timestamp so that we can call it to get everything new since the morning (when we last called it) it would be great and we can use that with background fetch as well as when App is foregrounded
If we can't make fetchAllReports get only updates, then I would leave it the way it is. Rely on having up to date information from pushes and trigger fetchAllReports when App is foregrounded
if we're already up to date, we're good
if we aren't we're getting there shortly
A single call fetchAllReports is enough to get you up to date and then you can carry on receiving further updates from pushes
If we can somehow make fetchAllReports work with a timestamp so that we can call it to get everything new since the [last time we called it]
This should be possible, sounds reasonable to me.
Whenever a push notifications carrying a report actions is received - it re-fetches Report information regarding its own Report
There used to be an issue for this: https://github.com/Expensify/App/issues/4008 and it got closed in preference of this one.
So it sounds like @kidroca is suggesting we should:
Close this issue and reopen https://github.com/Expensify/App/issues/4008. Having forgotten the context for why https://github.com/Expensify/App/issues/4008 was closed, it seems obvious to me that we should make the most of our inconsistent background updates, and that only adding a single reportAction to a report is not a great use of that opportunity.
Optimize fetchAllReports to take a timestamp and only provide reportActions added to any of your reports since a given time. It's unclear to me whether this will lead to a meaningful performance improvement, but it's possible. It would also depend on how that change affects the speed of the query. In any event, I think this should really be a separate issue.
Okay, thanks for taking the time to explain all that. I still think there is some value to both, but I'm on board with the above ^
Let's move this bounty to the #4008 and reassess once we have push notification backup 👍 (I think the bounty still makes sense as it resolves our main issue)
Another thought:
What's guaranteed though is the background push would be processed either in the background or when App is launched
Let's say 5 different reports received background push updates, but due to OS throttling, none of them ran while the app was backgrounded/closed. When the app comes back to the foreground, we would then do 5 network requests to update each of the 5 reports we know are out-of-date. It would be preferable to have a single updateReports API that could take a list of reportIDs and update them all with a single request.
And yet another scenario:
We receive 5 push notifications for a report when we're at the airport and the app is closed in our pocket.
We go on the plane, and put the phone in airplane mode.
We open the app on the plane to see the 5 messages we missed, but since the network request to update that report will fail, we don't see them ❌
So if we're offline, we'll need to fallback onto the push notification payloads so that we don't get "ghost messages" that's visible via a push notification but not in the app. Or better yet, always add the reportAction to Onyx right away, then attempt a network request to update all the actions on that report.
Thanks for bearing with me
Let's agree the goal of background updates is to have as up to date data as possible when App is brought back to focus
A summary why pushes are satisfying the above goal:
they work for logged in users - being logged in means you've been through the "big" data fetching (that happens after login)
new messages are typically being pushed to you - Pusher or Push Notifications
Apple calls this "best effort to be fresh"
There are circumstances, as pointed out, where neither bg fetch or push would work making a foreground logic necessary - to resync at least once when App is relaunched/foregrounded
When we talk about Reports, there are 2 kinds of report data - actions and the report metadata itself
@roryabraham
When a new comment is received via push notification (alert or not), we definitely would keep the payload and merge it to Onyx. I supposed it already works that way. In addition to that we can try to fetch Report metadata (not actions) - or something else that makes sense:
if we're offline we can write the request to the persisted queue (now this is something that you can later flush using background fetch, or when app is foregrounded, whichever is first). A more simple solution might be to take a note and do a "big" refresh when App is foregrounded
does it make sense to fetch report metadata? - max action sequence number can be derived from the message, but what about anything else. If it doesn't make sense to fetch metadata we can use the time to do something else (or nothing)
if for some reason we don't have information for the report, e.g. someone starts a chat with us, we would fetch the info. Maybe it would be a good idea to include more metadata in the first report action to be able to construct a report out of it (in case we're offline and can't fetch)
if for some reason we don't have a report and it's not the first action, then if possible we should fetch metadata and latest actions
When the app comes back to the foreground, we would then do 5 network requests to update each of the 5 reports we know are out-of-date.
Depending on what we're fetching it's probably not a big deal, and the requests would happen in parallel
One thing that we have to make sure if not already so is to prevent notification collapsing.
Notification collapsing (apns-collapse-id) is when a newer notification replaces an older one
Data only notifications (no alert, no sound, content-available: 1) are non collapsible by default, but regular notifications are.
Resuming connectivity would receive only the latest message of a collapsible notification
What makes sense for a chat App is to stack notifications in groups using thread-id - notifications for the same report can be visually stacked together. Not sure about what's the Android counterpart for this
When a new comment is received via push notification (alert or not), we definitely would keep the payload and merge it to Onyx. I supposed it already works that way. In addition to that we can try to fetch Report metadata (not actions)
Hmmm, why not actions (for that specific report)?
if we're offline we can write the request to the persisted queue
I like this idea!
[The persisted queue] is something that you can later flush using background fetch
Love this idea! This would be great if you had a spotty network. Let's say a network request fails while a push notification is processing – we would add that request to the persisted queue and then, even if you didn't open the app, the persisted request queue would attempt to flush every 15-30 minutes with background fetch.
does it make sense to fetch report metadata? - max action sequence number can be derived from the message, but what about anything else
Maybe participants! We could maybe also pass up-to-date report metadata along with the push notification
One thing that we have to make sure if not already so is to prevent notification collapsing.
This is definitely something that is not already handled. I'll create an issue to follow-up.
Hmmm, why not actions (for that specific report)?
We presume we already have all the actions predating the one from the notification
We can have some sanity check and if we don't then yeah fetch previous actions and meta
Another topic to consider is the redesign of the read queue: https://expensify.slack.com/archives/C01GTK53T8Q/p1645658235688649
App receives updates for almost everything through pusher
When App is re-focused, currently mounted components would know what data they can try to refresh and trigger a fetch. (Typically on a Report page - everything related to the current reportID)
Same as 2) when we transition from offline to online
As a consequence this simplifies the read queue and makes it unnecessary to persist any read requests. When we're offline we don't make read requests, when we're back online we only fetch data for the latest page we're on
Point 4) is conflicting with proposals here suggesting to persist a read request, though it's a situation that might have been overlooked and deserves to be an exception
We decided in favor of 4) because the most important thing is to get the current screen you're coming back to be up to date or be quickly made that way, which 2) and 3) achieve. Then doing a general fetchAll would take care of getting any actions we might have missed being offline
Resuming connectivity would receive only the latest message of a collapsible notification
What makes sense for a chat App is to stack notifications in groups using thread-id - notifications for the same report can be visually stacked together. Not sure about what's the Android counterpart for this
Similar behavior exists on Android -- but we have to configure it similar to how you said it works for iOS: We can 'update' notifications by making a push with the same uniqueID. This is how all other chat apps work usually on Android, but we haven't implemented this yet. We could either send the entire 'thread' of unread message data with each push, or instead build this unread message cache locally.
Point 4) is conflicting with proposals here suggesting to persist a read request, though it's a situation that might have been overlooked and deserves to be an exception
Would you say we're currently blocked by the read network queue proposal in that case? Or do we know enough about the eventual solution to tailor this issue?
Would you say we're currently blocked by the read network queue proposal in that case? Or do we know enough about the eventual solution to tailor this issue?
I don't think we're blocked
The idea to flush persisted requests in a background task can be tackled separately
We can start with the outline here: https://github.com/Expensify/App/issues/4264#issuecomment-1055888496
When a new comment is received via push notification (alert or not), we merge it to Onyx
Check whether we need to fetch anything more about the involved Report
Or use the time to do arbitrary work like fetchAllReports if we haven't done so recently
Or do nothing - scoring nice app points from the OS
Inform the OS we're done doing background work.
If we're happen to be offline by the time the background execution run we can just do nothing for the moment
⚠️ Regarding 5) - Urban Airship seems to lack this capability
See how other libraries have a hook to inform the OS they are done doing background work:
https://github.com/zo0r/react-native-push-notification#usage
// (required) Called when a remote is received or opened, or local notification is opened
notification.finish(PushNotificationIOS.FetchResult.NoData);
https://wix.github.io/react-native-notifications/api/general-events#registernotificationreceivedbackground
Notifications.events().registerNotificationReceivedBackground((notification: Notification, completion: (response: NotificationCompletion) => void) => {
console.log(JSON.stringify(notification.payload));
// Calling completion on iOS with `alert: true` will present the native iOS inApp notification.
completion({alert: true, sound: true, badge: false});
});
Should call completion function on iOS
https://notifee.app/react-native/docs/events#background-events
notifee uses Promises to track this, when a promise is over the OS is informed we're done:
The onBackgroundEvent method is used to register a callback handler which will be executed whenever a background event is sent. Executing the callback handler in the background requires device resources so it is important that any code is executed efficiently & quickly.
Unless Urban Airship allows finishing background work, we'll have to swap it for another lib
We can still use it as a service, but handle notifications (or at least their payload) with another lib
We have a pretty good relationship with UA, we can ask for that functionality or even submit a PR to their library if necessary.
I find UA's Push Notifications API for react-native lacking other useful functionalities
when app is foregrounded get all unprocessed notifications (like when you open App from it's icon and not from a notifications in the notification bar)
clearing notifications - we'd probably want to automatically dismiss a notification when user sees a chat for which they have a notification in the notification bar
modify notification content - we might never needs this
create local notifications - we might have the need to raise a notification from the background - like "We failed to sync some information in the background because you seem to be Offline, tap here when you're back online so we can try again". Or when the user leaves App while messages are sending and OS asks us to stop - "We couldn't deliver you're last 3 message, tap here to retry"
finishing background work - already explained here
I guess this ticket is blocked if we need to have this on the UA react-native API
At the same time we can work with any Push Notifications library by modifying the code here: https://github.com/Expensify/App/blob/0e3bbe77a3ed497b49ffb3ee32d952e480bda448/src/libs/Notification/PushNotification/index.native.js#L16-L46
We can avoid efforts writing PRs, but just submit feature requests, when some day features are implemented we can switch the above code to use UA
I don't know about you but I don't feel confident writing native code for both Android and iOS, or at least I don't think I'll create something better than what already exists
Hmm actually it was just hard finding these docs: https://docs.airship.com/reference/libraries/react-native/latest/urbanairship-react-native/classes/urbanairship.urbanairship.html
There are methods covering above items like:
https://docs.airship.com/reference/libraries/react-native/latest/urbanairship-react-native/classes/_urbanairship_.urbanairship.html#getactivenotifications
https://docs.airship.com/reference/libraries/react-native/latest/urbanairship-react-native/classes/_urbanairship_.urbanairship.html#clearnotification
Still it doesn't seem possible to notify OS when we're done doing work in the background
(I want to remove the Overdue label) - @Julesssss or @kidroca can you provide an update on the next steps for this job? thanks!
I think the issue is now blocked by the planned networking changes and receiving data through Pusher
We then have to decide how background updates work
API sends background push -> device tries to resync
or device does some resync work each time a notification arrives
And decide how the update logic works
make background sync an exception case and use HTTP responses in order to complete a background task as fast as possible
when App wakes up in the background still make a Pusher connection and wait (30 sec. max) to receive messages - always consuming the max allowed wait time
It seems we're moving in a direction where the 1 bullet won't be an option, because API responses would just not carry the information
Still in planning
No changes
Same as above
Still held for now.
Held on notification project
Can we pop a [Hold #219254] in the title to link to the notifications project, so it's clear what this is held on?
Yeah, I'll do this for all these issues.
Hey @Julesssss @kidroca would you be able to give an update on this? I'm not really sure what we're doing with this job at the moment. Thanks!
I'm not sure as well, but I think we should change the ticket description or open a new one, since things changed significantly
AFAIK we don't pursue periodic attempts to sync the app, but instead trickle down updates via Pusher or Push notifications
Hey @Christinadobrzyn this issue should be on hold for the moment, so I just updated the title
Still held for now
Will still be held for a while. It might be covered by the notifications doc #2, but more likely it will follow it instead.
Not overdue. it's on hold
Getting closer to unblocking this.
Making progress with other notification issues, and this one remains one of the lower priorities.
@Julesssss would you have an update on this one?
This is now completely on hold as we might have an alternate solution to the missing onyx data problem.
Closing this out in favor of #15058. We considered this background-fetch approach, but there's a lot of concern about increased server load so we won't be using it. More context here.
@arosiclair @Julesssss I had spent time on this issue earlier, also worked on a PR. We had decided to for a payout here, when the issue is resolved. Is this still valid @Julesssss ?
cc - @Christinadobrzyn
Yep, that still seems valid. @Christinadobrzyn would you mind handling that payment please?
Here's a new job posting for this:
Internal: https://www.upwork.com/ab/applicants/1669723658502512640/job-details
External: https://www.upwork.com/jobs/~013d0af18888aa9942
@mananjadhav I invited you to this one - can you please accept and I'll pay out? Thanks!
Thanks @Christinadobrzyn. Accepted
Awesome! Thanks! I paid you in Upwork.
Hey @Julesssss should we close this?
Yeah 👍
|
2025-04-01T04:10:23.024245 | 2024-06-07T10:16:13 | 2340090075 | {
"authors": [
"davidcardoza",
"muttmuure",
"tgolen"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14107",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/43253"
} | gharchive/issue | [CRITICAL] UX RELIABILITY - Receipt is stuck in a scanning state and the expense fails to load when the IOU preview is tapped
If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!
Version Number: v1.4.79-7
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @davidcardoza
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1717631386394629
Action Performed:
Open mobile app
Got to new NewDot test workspace chat
tap a IOU request with a receipt scanning in progress
Wait several minutes, nothing loads
Press back
Tap a different IOU request
IOU loads as expected
Expected Result:
The receipt loads immediately
Actual Result:
The loading skeleton loads infinitely
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Issue OwnerCurrent Issue Owner: @davidcardoza
Going to ask Doza to try and reproduce
@davidcardoza I'm going to reassign this to you since it happened in your account.
Can you update to the latest version, turn on client side logs and then try to reproduce this?
I was able to ti access the mobile app! I've scanned two receipts, both are still scanning after 6 minutes. I will check back in a few hours.
Note: This PR was released in version 1.4.82-4 yesterday to production. It should contain the additional logs that might help us track this down.
According to the logs I am looking at right now, there is a client here that has a broken sequential queue that keeps growing and never shrinking.
I need to get this client updated to at least version 1.4.82-4 of the app so that we can look at the new client logs that we added.
Weekly Update
@marcaaron and I have been looking at client logs and server logs, and think we might have found a problem.
Doza's OpenApp request is timing out (which is the first request that happens when he signs in)
I posted this to the #fast-apis channel because there are several open BugBots for the slow query that is happening
Next Steps
@tgolen Try to brainstorm some solutions for improving the speed of the query and get someone working on that
@tgolen Figure out what front-end changes we can make to better handle a failure such as this
ETA
Hard to say, so I'm going to give two weeks to start with.
Finished by Friday, July 12
Now all I need is a specific window of time to look at. @davidcardoza can you please try a new smart scan and let me know the approximate time (and your timezone) that you made the requests?
Do you still need this?
Nope! I found a good timeframe in the logs yesterday and found what I
needed.
On Mon, Jun 24, 2024 at 4:22 PM David Cardoza @.***>
wrote:
Now all I need is a specific window of time to look at. @davidcardoza
https://github.com/davidcardoza can you please try a new smart scan and
let me know the approximate time (and your timezone) that you made the
requests?
Do you still need this?
—
Reply to this email directly, view it on GitHub
https://github.com/Expensify/App/issues/43253#issuecomment-2187510489,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJMAB6YJ2XXWJMBHFHWGZTZJCL25AVCNFSM6AAAAABI6MEO7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBXGUYTANBYHE
.
You are receiving this because you were mentioned.Message ID:
@.***>
Looks like we're done with this one and it's fixed for Doza.
|
2025-04-01T04:10:23.070867 | 2024-06-28T09:36:21 | 2380012128 | {
"authors": [
"HezekielT",
"dangrous",
"garrettmknight",
"hannojg",
"izarutskaya",
"kirillzyusko",
"mountiny",
"wildan-m"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14108",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/44600"
} | gharchive/issue | [$500] Login – No Abracadabra page when logging in via Magic link
If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!
Version Number: 9.0.3-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4678326
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Go to https://staging.new.expensify.com/
Log in with new Expensifail account
Copy the Magic link and change it to staging
Open a new tab and navigate to the staging magic link
Expected Result:
Abracadabra page is displayed
Actual Result:
Inbox page opens. Abracadabra page isn’t displayed
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop
Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/d2d389b6-c3f2-4f0d-8e5a-23fdbf93c84b
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Upwork Job URL: https://www.upwork.com/jobs/~01e239faee992134cd
Upwork Job ID:<PHONE_NUMBER>074984740
Last Price Increase: 2024-08-13
Automatic offers:
HezekielT | Contributor | 103331186
Issue OwnerCurrent Issue Owner: @garrettmknight
@garrettmknight I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
This is definitely external. Haven't figured out the cause yet, I need to remember how to send magic links from dev.
So I just tried this with the production build and the production server on my local and still had it occur.
I think this might be something just with copying and modifying the link, rather than literally clicking on it... I vaguely remember something about that in another bug in the past. But I'm not confident yet - other ideas welcome!
Trying to get some assistance here - https://expensify.slack.com/archives/C01GTK53T8Q/p1719583721705269
The abracadabra page is just a confirmation so I don't think we need to call this a blocker.
It doesn't look like we deployed any backend changes between when this bug was reported and when I tested it with prod/prod server and staging/staging server, so I don't think it's backend? But I would be happy to be proven wrong. I'm still confused how it could show the behavior I noted in Slack - copied below for reference - so there might be something funky going on.
This happens on staging, but not on prod.
Testing locally, it happens on the staging build using the staging server - but also on the production build using the production server.
So…. I’m a little confused as to what might be happening here. Is it front end? back end? neither? Or am I testing incorrectly (checking out staging or production, using env.production or env.staging)?
Still awaiting a proposal - @aimane-chnaif looks like they identified a PR at the root of a similar issue: https://github.com/Expensify/App/pull/44536. Is this the one?
There's definitely a chance this could be backend, and maybe my testing just got weird. So if anyone has any proposals that confirm that, I could try to investigate a fix...
Alternately maybe we increase the bounty?
The PR that I guess we thought caused this was reverted... but this is still happening on staging. So maybe it IS backend?
This seems to be open for even before the mentioned pr was deployed to staging, right? We reverted the onboarding navigation changes but it must have been something else given when this was reported. Unless i am reading it wrong
yeah i think that was a mistake, i don't think it's related. Still not sure where it's coming from, but it wasn't that.
I'm updating the price of this one to see if we can get some more action!
Asked QA to retest https://expensify.slack.com/archives/C9YU7BX5M/p1721434498416799?thread_ts=1721433611.664079&cid=C9YU7BX5M
Reproduced by QA.
Reproduced by QA.
@aimane-chnaif you don't have any ideas on this one, do you? Not getting any proposals so figured I'd check
Proposal
Please re-state the problem that we are trying to solve in this issue.
When user tries to login using a magic link in other tab, instead of showing the abracadabra page, the report page(inbox) is shown.
What is root cause of that problem?
This is due to withOnyx not returning the correct value of session. The value of autoAuthState(session.autoAuthState) that is returned by withOnyx for session is SIGNING_IN even though the backend has returned the correct value which is just-signed-in which results in the report page being opened instead of the abracadabra page.
I believe the offending PR is #44457 which bumped the onyx to 2.0.54 in order to use the changes made in https://github.com/Expensify/react-native-onyx/pull/563 and in that PR, changes were made to Onyx.ts for performance improvements which in turn has affected the functionality of withOnyx causing this issue. I’m not 100% sure as my attempt to revert that change locally was unsuccessful.
What Changes do you think we should make in order to solve the problem?
Since the usage of withOnyx is deprecated, I suggest to replace withOnyx that is found in ValidateLoginPage by useOnyx since the usage of useOnyx solves this issue by returning the correct value of session.autoAuthState.
https://github.com/Expensify/App/blob/cd14a035095e8ace627d125db931d0c90408f898/src/pages/ValidateLoginPage/index.website.tsx#L90-L94
Replace the above by
export default ValidateLoginPage; and then use useOnyx inside the function.
const [session] = useOnyx(ONYXKEYS.SESSION);
const [credentials] = useOnyx(ONYXKEYS.CREDENTIALS)
const [account] = useOnyx(ONYXKEYS.ACCOUNT)
But the above change is not enough since AuthScreens.tsx also uses withOnyx to get the value of session which means even if the above changes causes the abracadabra page to be rendered the AuthScreen will still cause the report page to be rendered therefore we also need to replace the usage of withOnyx by useOnyx.
Replace
https://github.com/Expensify/App/blob/4ba10bf106e23e95c3e6c58fa8131a1f70a3bd69/src/libs/Navigation/AppNavigator/AuthScreens.tsx#L507-L517
By
export default AuthScreensMemoized; and then add the following inside the AuthScreens function.
const [session] = useOnyx(ONYXKEYS.SESSION)
const [lastOpenedPublicRoomID] = useOnyx(ONYXKEYS.LAST_OPENED_PUBLIC_ROOM_ID)
const [initialLastUpdateIDAppliedToClient] = useOnyx(ONYXKEYS.ONYX_UPDATES_LAST_UPDATE_ID_APPLIED_TO_CLIENT)
This will fix the issue.
What alternative solutions did you explore? (Optional)
None.
@johncschuster just adding you for the next week while I'm out. I'll pick it back up when I get back, thanks!
@aimane-chnaif Thanks for the review. Here is the test branch - https://github.com/HezekielT/App/tree/fix---no-abracadabra-page-shown
Can't reproduce it locally. In dev abracadabra page shown, then it's auto login when we access the link in the same browser session
The issue is still reproducible on the latest main. @wildan-m it should not auto login
The more we test the more this feels like a backend bug haha. Let me bring it up in Slack and see if anyone has any ideas.
Yeah I think if we can switch to useOnyx we should do it!
Alas, it looks like this caused https://github.com/Expensify/App/issues/47066 - (confirmed with git bisect) - any thoughts on a potential solution @HezekielT @aimane-chnaif ?
@dangrous I will raise a PR with a fix in max 2 hours. 👍
Noting here as well - we're reverting the PR so will need to figure out an alternate/adjusted fix
Ignore Melvin, we had to revert this PR. @HezekielT @aimane-chnaif any thoughts on an updated fix?
oh i didn't realize it was that many. Yeah, let's do that - feel free to resubmit if you like, though, @HezekielT!
Hey, Kiryl from Margelo is here 👋
I'd like to work on this issue 👀
Go for it @kirillzyusko - let us know what you figure out!
As of now I have two questions:
the video below is showing how it works in dev (i. e. I see abracadabra page for a second, but then I'm redirected to inbox page)
https://github.com/user-attachments/assets/157d7f9b-b8e4-4e3b-b6c0-a61c6d62ab84
Is it expected result or not? On staging I'm redirected straight to the inbox page.
why email link can be received in 2 formats? Sometimes it is https://new.expensify.com/v/17876122/103223 sometimes https://email.expensify.com/c/long-long-token 🤔 Which factors determine which format will be received?
cc @dangrous tagging you since you may know the answers on my questions 😊
So for the first answer, both of these are wrong - if you open a magic link in a new tab, that tab should stay as the abracadabra page permanently, and you should only get logged in on the original tab.
As for the second question, I'm not actually sure! I'm pretty confident we should only see the first format. Where are you seeing the second?
As for the second question, I'm not actually sure! I'm pretty confident we should only see the first format. Where are you seeing the second?
In email and it's super random when I see first format or a second one 🤷♂️
Anyway, will post the result of investigation.
In development mode I can see abracadabra page for a fraction of a second - it happens because dev builds works slower than optimized/compiled versions. I assembled dev build with optimizations and I'm getting the same result as on staging. The problem appears to be in fact, that in dev/staging the authenticated prop gets changed from false to true, we unmount previous navigator with abracadabra page and automatically redirect user to the authenticated pages (inbox).
I'm going to investigate why we change authenticated property and why it wasn't changing in current prod and will get back with results/fix 👍
sounds good!
re: the links - it sounds like the email. version is just the same link but with some user tracking included. Should resolve to the same thing
@dangrous just want to ask one question. We have next flow - when we open second tab we send API request to SigninUserWithLink. It returns us:
{
"onyxMethod": "merge",
"key": "session",
"value": {
"authToken": "bb",
"accountID": 1111111,
"email"<EMAIL_ADDRESS> "encryptedAuthToken": "aa",
"authTokenType": null
}
},
Is it a correct response? I'm asking, because in the code I see that we expect autoAuthState to be there (to show Abracadabra page the value for this field should be just-signed-in). So just curious whether it's BE responsibility to send this field or we set it on FE only 🤔
so I don't actually see autoAuthState anywhere in our backend so it looks like it's FE only. Seems like it's only set in the success / optimistic data
Okay, finally made assembled a puzzle from all pieces! 🧩
Basically changes introduced in https://github.com/Expensify/App/pull/42592 produced the problem. Originally in react-navigation there was a check on component unmount:
- setTimeout(() => {
- if (getCurrentState() !== undefined && getKey() === navigatorKey) {
- cleanUpState();
- }
- }, 0);
Which should call cleanUpState asynchronously. Asynchronous is needed to handle a case when we are mounting a new navigator while unmounting previous navigator (in order not to loose a part of state):
// We need to clean up state for this navigator on unmount
- // We do it in a timeout because we need to detect if another navigator mounted in the meantime
- // For example, if another navigator has started rendering, we should skip cleanup
- // Otherwise, our cleanup step will cleanup state for the other navigator and re-initialize it
This is exactly what happened in our code - we were switching from PublicScreens to AuthScreens, but since the check was running synchronously - we couldn't properly reconcile the state, because a new component is not mounted yet... So we replaced all navigation state with undefined (which caused to display a default screen in a new navigator).
Nonetheless we can not revert this code, because in StrictMode effects are fired twice, and if we add additional delay - then all navigation becomes broken, since we clean them up when are trying to perform a navigation, so it literally becomes impossible to navigate to any of screen 🤯
If I disable StrictMode and revert the patch (add back setTimeout(..., 0) then I can see abracadabra page again 😎). I'm glad that I found a root cause - now I'll think on how to prepare a proper fix for that! 🤞
Amazing! That makes a lot of sense, and is very tricky! code timing will get you every time haha. Good luck on figuring out the fix, let me know if you want to talk anything through or anything!
@kirillzyusko Wild RCA! When do you think you'll have a proposal for fixing ready?
@garrettmknight I'm currently busy with e2e tests failures after RN 0.75 merge, but @hannojg promised to help here and to look into the issue as well.
I had several ideas on how to fix this problem, but all of them failed, so having a fresh look will definitely help!
why email link can be received in 2 formats? Sometimes it is
To answer that part I think that happens through the email tool and its a question of whether your email client followed the redirect yet. You can put the url in curl to get the /v/ url, as it won't follow the redirect:
Just to understand how that is supposed to work - once I opened the link and the abracadabra page stays - the other tab is expected to automatically authenticate?
https://github.com/user-attachments/assets/833d4f8a-dd71-4ab7-8802-eeb93cdc49d2
@hannojg I saw an email about a comment you sent confirming expected behavior, since that's deleted I'm guessing you figured it out? Short version - yes, opening the magic link should authenticate the original tab/window.
Yeah, sorry, when writing that comment I was still confused 😄
So, we've found a solution, however, that solution currently doesn't work in strict mode (debug), but will work in release. How open are we to "only" fix that for release and not debug?
We can spend more hours making this fix also viable for debug, just wanted to check with you first if its worth the effort?
Note: we actually have a solution available now that works also in strict mode 😊
oh awesome!
We have a PR here which fixes the issue:
https://github.com/Expensify/App/pull/48347
https://github.com/user-attachments/assets/5d1b4dc7-b88e-4fcd-a51f-ec5cafda7ef7
The main fix we found is to disable the cleaning mechanism entirely when switching navigators in react-navigation. When we sign in and switch from our PublicScreens to AuthScreens we explicitly expect the navigation state to persist. There are no built-in mechanisms to stop the cleanup from happen (it has internal logic for that but it is buggy as Kiryl pointed out).
Instead we add an explicit clean point when we signout, as this is the only place to my understanding where we'd ever want to drop our navigation state.
Alternative solutions
The main problem is, that react-navigation's cleanup mechanism is build on the assumption that when you unmount a navigator, you either instantly mount a new one - or no new navigator is mounted instantly, in which case we want to clear the state.
In Expensify's case our navigators are wrapped with <Suspense /> and it can happen that our navigators "are rendered" but are only really mounted after X milliseconds. This breaks react-navigation's assumption.
We could work out a reproduction for react-navigation, open an issue there, and work on a fix with Satya, but I believe this could take days. Not sure if thats worth for that issue?
I will finish the PR with testing all platforms tomorrow - however, we could already assign someone for testing (or do an adhoc build and ask people to test it). I am slightly unsure whether I was overlooking some case where we'd also need to clean the navigator state.
How are we looking on this one @hannojg? Thanks!
@dangrous Hanno is OOO for two weeks, so I'm taking this over again and will try to fix it ASAP!
Waiting on library review
we're discussing expected behavior for this one again, we may not end up needing it?
https://expensify.slack.com/archives/C03TQ48KC/p1730456781086199
Okay we're closing this issue, and will update the expected behavior to match the current behavior. Thanks for investigating @kirillzyusko!!
Can anyone confirm whether or not we need payment here? It's been a long road with a lot of PRs (many of which reverted) so I'm a little confused haha
i'm going to go ahead and close and if anyone needs payment we can reopen
|
2025-04-01T04:10:23.082825 | 2021-08-18T16:12:17 | 973842589 | {
"authors": [
"botify",
"iwiznia",
"roryabraham"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14109",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/4727"
} | gharchive/issue | Post deploy announcements in slack
If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!
Action Performed:
Run a staging or prod deploy of Expensify/App.
Expected Result:
OSBotify should post in Slack, telling us that a deploy occurred. Staging deploys should be announced in #announce, while production deploys should be announced in #expensify-open-source.
Actual Result:
No post in slack.
Workaround:
n/a
Platform:
GitHub/Slack
View all open jobs on GitHub
Making this internal so that it can be tested by the same engineer who writes the code. Testing will be the most painful part of this issue. FP instructions:
Add a step in platformDeploy.yml at the end of the file in the postGithubComment job that uses action-slack (example) to post a well-formatted deploy comment in the correct slack room. The SHOULD_DEPLOY_PRODUCTION environment variable tells us whether or not the completed deploy was a production deploy.
Also, please delete this outdated, unused step. That is not an accurate way to determine whether a given staging deploy was a CP or standard deploy.
Testing instructions:
Make sure that the StagingDeployCash is not locked.
Lock the StagingDeployCash, then verify that the resulting staging deploy is announced in #announce.
Merge a PR with the CP Staging label, then verify that the resulting staging deploy is announced in #announce.
Once the deploy checklist is complete and we close it out, verify that the resulting prod deploy is announced in #expensify-open-source.
Staging deploys should be announced in #announce, while production deploys should be announced in #expensify-open-source
Let's post in announce everything we can. In the end, no one reads that channel, is more like a log of everything that was deployed.
🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
failure ❌
🕸 web 🕸
success ✅
|
2025-04-01T04:10:23.095398 | 2024-11-15T15:49:22 | 2662407519 | {
"authors": [
"OfstadC",
"akinwale",
"lanitochka17",
"rojiphil",
"yuwenmemon"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14110",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/52626"
} | gharchive/issue | [HOLD for payment 2024-12-11] [$250] mweb - Netsuite - Offline indicator is below the text in Auto-sync page
If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!
Version Number: 9.0.63-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause - Internal Team
Issue found when executing PR https://github.com/Expensify/App/pull/51949
Action Performed:
Precondition:
Workspace is connected to NetSuite
Go to staging.new.expensify.com
Go to workspace settings
Go to Accounting
Tap Advanced
Tap Auto-sync
Go offline
Expected Result:
Offline indicator will be at the bottom of the page
Actual Result:
Offline indicator is below the text instead of bottom of the page
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
[ ] Android: Standalone
[ ] Android: HybridApp
[x] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/user-attachments/assets/ad25a3d1-bfe6-46ee-a207-7cf0d1963a25
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Upwork Job URL: https://www.upwork.com/jobs/~021857460821129435659
Upwork Job ID:<PHONE_NUMBER>129435659
Last Price Increase: 2024-11-15
Automatic offers:
rojiphil | Contributor | 104956911
Issue OwnerCurrent Issue Owner: @akinwale
Yeah doesn't look like a blocker to me.
@yuwenmemon Since this is a regression, the C+ who reviewed the initial PR can be assigned here as well, unless they're currently unavailable.
Since this is a regression, the C+ who reviewed the initial PR can be assigned here as well, unless they're currently unavailable.
Yeah! That makes sense. @yuwenmemon Please assign me here. Thanks.
@twilight2294 When can you raise a PR for this?
@yuwenmemon I think we can close this as we can consider this to be part of the implementation here
@rojiphil are you indicating payment doesn't need to be issued on this issue?
@OfstadC yeah. you can close this out
|
2025-04-01T04:10:23.101646 | 2022-08-25T09:00:27 | 1350571041 | {
"authors": [
"OSBotify"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14111",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/pull/10561"
} | gharchive/pull-request | 🍒 Cherry pick PR #10545 to staging 🍒
🍒 Cherry pick https://github.com/Expensify/App/pull/10545 to staging 🍒
🚀 Cherry-picked to staging by @OSBotify in version: 1.1.89-3 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.
🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.
|
2025-04-01T04:10:23.151840 | 2023-01-13T07:04:42 | 1531812903 | {
"authors": [
"OSBotify",
"esh-g",
"mollfpr",
"tienifr"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14112",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/pull/14270"
} | gharchive/pull-request | fix/14084 Bank account : The bottom section of Personal Information blinks when opening and closing DatePicker
Details
The action Keyboard.dismiss() and this.setState({isPickerVisible: true}) are executed asynchronous. Besides, Ios will dismiss the keyboard when popover is opened and open again when it's closed.
This PR implement this logic: "If keyboard is opening => I'll dismiss keyboard and open popover in keyboardDidHide listener. Otherwise I just open popover".
Fixed Issues
$ https://github.com/Expensify/App/issues/14084
PROPOSAL: https://github.com/Expensify/App/issues/14084#issuecomment-1378466238
Tests
1, Login with any account
2, Open Settings => Workspace => Connect Bank Account => Connect Manually => Enter valid information.
3, Tap on any TextInput then tap on DatePicker, tap outside to dismiss DatePicker.
4a. For iOS verify that the bottom section of the page isn't blinking after Date Picker closes.
4b. For other platforms make sure the Date Picker is working fine.
[x] Verify that no errors appear in the JS console
Offline tests
QA Steps
1, Login with any account
2, Open Settings => Workspace => Connect Bank Account => Connect Manually => Enter valid information.
3, Tap on any TextInput then tap on DatePicker, tap outside to dismiss DatePicker.
4a. For iOS verify that the bottom section of the page isn't blinking after Date Picker closes.
4b. For other platforms make sure the Date Picker is working fine.
[x] Verify that no errors appear in the JS console
PR Author Checklist
[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR
[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:
[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop
[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:
[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.
Screenshots/Videos
Web
Mobile Web - Chrome
https://user-images.githubusercontent.com/113963320/212257942-567955e6-4f21-4665-9713-54c8b00515fd.mp4
Mobile Web - Safari
https://user-images.githubusercontent.com/113963320/212257994-c56a6423-e3d4-48c7-bc4d-73d78198c0fb.mp4
Desktop
iOS
https://user-images.githubusercontent.com/113963320/212258054-30a6fb91-2568-44cd-9ed5-c826cb40fbc3.mp4
Android
https://user-images.githubusercontent.com/113963320/212257915-e1638e82-5caa-4a2d-ada6-7d9c49b705d5.mp4
Hi @mollfpr @jasperhuangg , the PR has been created and all checks have passed. Please help me review my PR. Thank you!
Reviewer Checklist
[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR
[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:
[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop
[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)
[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed
[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:
[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[ ] If any new file was added I verified that:
[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[ ] If a new CSS style is added I verified that:
[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android
Hi @mollfpr @jasperhuangg, I just fixed the comments. Please help to review it again. Thanks
Thanks for the update @tienifr! Just a minor change on the test description, let's update the case since the noticeable fix is only on iOS.
4a. For iOS verify that the bottom section of the page isn't blinking after Date Picker closes.
4b. For other platforms make sure the Date Picker is working fine.
@mollfpr Done. Thanks for pointing out that
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
🚀 Deployed to staging by @jasperhuangg in version: 1.2.55-0 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
🚀 Deployed to production by @AndrewGable in version: 1.2.55-0 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
Regression !!!!
I caught a regression from this PR: https://expensify.slack.com/archives/C049HHMV9SM/p1674144058692939
APP CRASHES on clicking RESET in date picker.
Solution
diff --git a/src/components/DatePicker/index.ios.js b/src/components/DatePicker/index.ios.js
index 6f37202cf..960fa798c 100644
--- a/src/components/DatePicker/index.ios.js
+++ b/src/components/DatePicker/index.ios.js
@@ -41,6 +41,7 @@ class DatePicker extends React.Component {
showPicker(event) {
// Opens the popover only after the keyboard is hidden to avoid a "blinking" effect where the keyboard was on iOS
// See https://github.com/Expensify/App/issues/14084 for more context
+ this.initialValue = this.state.selectedDate;
if (!this.props.isKeyboardShown) {
this.setState({isPickerVisible: true});
return;
@@ -50,7 +51,6 @@ class DatePicker extends React.Component {
listener.remove();
});
Keyboard.dismiss();
- this.initialValue = this.state.selectedDate;
event.preventDefault();
}
May I be added as a contributor to this issue/PR?
Thanks @esh-g! Please, comment on the issue https://github.com/Expensify/App/issues/14417
|
2025-04-01T04:10:23.260450 | 2023-11-07T17:53:08 | 1981912359 | {
"authors": [
"DylanDylann",
"OSBotify",
"cubuspl42",
"paultsimura"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14114",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/pull/31017"
} | gharchive/pull-request | fix: Distance – show "Add stop" button only when start & finish are filled
Details
Show the "Add stop" button for Distance requests only when start & finish are filled.
Fixed Issues
$ https://github.com/Expensify/App/issues/29886
PROPOSAL: https://github.com/Expensify/App/issues/29886#issuecomment-1782714921
Tests
Same as QA.
Offline tests
Same as QA.
QA Steps
Click "+" -> "Request money" -> "Distance" tab;
[ ] Verify that the "Add stop" button is not shown;
Fill in the "start" and "finish" waypoints;
[ ] Verify that the "Add stop" button is shown;
Click "Add stop" and add a waypoint;
[ ] Verify that the new waypoint is added at the end of a route and is now marked as "finish".
PR Author Checklist
[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR
[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:
[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop
[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:
[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.
Screenshots/Videos
Android: Native
https://github.com/Expensify/App/assets/12595293/493ba3d8-6387-43d5-bdd0-1c163cfd713f
Android: mWeb Chrome
https://github.com/Expensify/App/assets/12595293/8b58489b-f189-4e75-9e6f-bffdacf8f173
iOS: Native
https://github.com/Expensify/App/assets/12595293/a3da9301-31c4-4abd-8f25-b76a3c10b8c4
iOS: mWeb Safari
https://github.com/Expensify/App/assets/12595293/9c87479d-bbfe-429e-a888-81ac2bb6dee9
MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/12595293/8b571f15-5c1e-4500-bf0e-b330d0ab8f2d
MacOS: Desktop
https://github.com/Expensify/App/assets/12595293/1bcd7e28-104d-4a34-970c-42a28fbeb9bf
@paultsimura User still can add stop by accessing deeplink. So I think we need to update condition here
https://github.com/Expensify/App/blob/c2e40423ac71fa67e65b570342c39e4c2b25a46f/src/pages/iou/WaypointEditor.js#L187
using (parsedWaypointIndex > 1 && parsedWaypointIndex > numberOfFilledWaypoints) instead of using waypointCount
User still can add stop by accessing deeplink
Thank you, that's a reasonable catch.
Considering that we do not share these links anywhere, the only case when a user can access this page is by manually changing the URL to https://new.expensify.com/request/new/waypoint/2. To me, it looks like the user is trying to shoot their own leg. @cubuspl42 how do you think, should we handle a case when a user manually changes the URL and adds a waypoint?
@DylanDylann Thanks for catching this!
@paultsimura Yes, we should handle it. The URL bar is an extension of the app's UI. It's not like the user typed something to the developer console, after all.
Yes, we should handle it
Cool, I'm on it
I have added a new condition: (filledWaypointsCount < 2 && parsedWaypointIndex >= waypointsCount).
Also, refactored the component a tiny bit: there was a duplicated variable: waypointsCount and totalWaypoints.
@cubuspl42 all yours☝🏼
Verify that the "Add stop" button is shown
Please make it clear that it should appear after both mentioned fields are filled
Plesae add a step that ensures that the button disappears while again < 2 waypoints are filled (use user's terms)
Reviewer Checklist
[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR
[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:
[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop
[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:
[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Screenshots/Videos
Web
https://github.com/Expensify/App/assets/2590174/1c2240b4-4317-4fa1-9b59-56fa461c5a4a
Mobile Web - Chrome
https://github.com/Expensify/App/assets/2590174/8731141a-fd88-42e2-aa6c-84e1b2c405c4
Mobile Web - Safari
https://github.com/Expensify/App/assets/2590174/3a3bbc26-9ad7-4585-b49a-ac522dbe11e9
Desktop
iOS
https://github.com/Expensify/App/assets/2590174/69fdbec5-65a9-4520-8138-87f14fbed322
Android
https://github.com/Expensify/App/assets/2590174/3978582d-acd6-4593-b8d9-c6b502d0b8c2
@cubuspl42, updated the PR description and renamed vars.
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
🚀 Deployed to staging by https://github.com/iwiznia in version: 1.3.99-0 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.99-0 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
🚀 Deployed to staging by https://github.com/iwiznia in version: 1.4.0-0 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
|
2025-04-01T04:10:23.330006 | 2024-01-11T14:30:03 | 2076820386 | {
"authors": [
"OSBotify",
"akinwale",
"robertjchen",
"s77rt"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14115",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/pull/34357"
} | gharchive/pull-request | Fix Selection List Item Styling
Details
Follow up https://github.com/Expensify/App/pull/33808
Fixed Issues
$ https://github.com/Expensify/App/issues/32614
PROPOSAL: https://github.com/Expensify/App/issues/32614#issuecomment-1851610628
Tests
Go to Settings > Workspaces > any workspace > Members and click Invite
Verify that the font size of the second line (email line) of each option is smaller than that of the first line (full name line)
Go to Settings > Preferences > Priority mode
Verify that the font size of the second line of each option is smaller than that of the first line
[ ] Verify that no errors appear in the JS console
Offline tests
Same as tests
QA Steps
Same as tests
[ ] Verify that no errors appear in the JS console
PR Author Checklist
[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR
[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:
[X] Android: Native
[X] Android: mWeb Chrome
[X] iOS: Native
[X] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[X] MacOS: Desktop
[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)
[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed
[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If any new file was added I verified that:
[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[X] If a new CSS style is added I verified that:
[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If the PR modifies the form input styles:
[X] I verified that all the inputs inside a form are aligned with each other.
[X] I added Design label so the design team can review the changes.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
cc @shawnborton
cc @robertjchen
Reviewer Checklist
[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR
[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:
[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop
[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)
[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed
[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:
[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[ ] If any new file was added I verified that:
[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[ ] If a new CSS style is added I verified that:
[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the form input styles:
[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label so the design team can review the changes.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
@akinwale I don't think a C+ is needed here. This is just a quick follow up
@akinwale I don't think a C+ is needed here. This is just a quick follow up
Gotcha.
@robertjchen Can you please merge this?
Reviewer Checklist
[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR
[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:
[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop
[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)
[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed
[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:
[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[ ] If any new file was added I verified that:
[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[ ] If a new CSS style is added I verified that:
[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the form input styles:
[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label so the design team can review the changes.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
🚀 Deployed to staging by https://github.com/robertjchen in version: 1.4.26-1 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
Thank you!
🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.26-2 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
failure ❌
🕸 web 🕸
success ✅
|
2025-04-01T04:10:23.385131 | 2024-05-18T19:48:18 | 2304288591 | {
"authors": [
"OSBotify",
"ikevin127",
"marcaaron",
"s77rt"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14116",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/pull/42369"
} | gharchive/pull-request | Combine report name routes
cc @marcaaron
Details
Part of https://github.com/Expensify/App/issues/40187
Fixed Issues
$ https://github.com/Expensify/App/issues/40187
PROPOSAL:
Tests
Test 1 (Renaming a group chat):
Create or navigate to a group chat report
Click on the report header
Go to Settings > Name
(Web Only): Verify that the url ends with /settings/name
Change the name
Verify that the name is changed
Test 2 (Renaming a room):
Create or navigate to a room that you own
Click on the report header
Go to Settings > Room name
(Web Only): Verify that the url ends with /settings/name
Change the name
Verify that the name is changed
[X] Verify that no errors appear in the JS console
Offline tests
Same as Tests
QA Steps
Same as Tests
[X] Verify that no errors appear in the JS console
PR Author Checklist
[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR
[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:
[X] Android: Native
[X] Android: mWeb Chrome
[X] iOS: Native
[X] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[X] MacOS: Desktop
[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)
[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed
[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If any new file was added I verified that:
[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[X] If a new CSS style is added I verified that:
[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
[X] I verified that all the inputs inside a form are aligned with each other.
[X] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
Screenshots/Videos
Android: Native
https://github.com/Expensify/App/assets/16493223/f3a1399b-0622-40cd-9b66-9aad127c577b
Android: mWeb Chrome
Networking issue
iOS: Native
https://github.com/Expensify/App/assets/16493223/501eb8fe-9663-469d-81ae-e8a715efb289
iOS: mWeb Safari
https://github.com/Expensify/App/assets/16493223/4c147f4c-f21c-4172-b3c5-50561073b516
MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/16493223/57b0d0a5-4c99-4731-803a-f43b43227407
MacOS: Desktop
https://github.com/Expensify/App/assets/16493223/8796dde3-14a6-4413-b3b7-affab86c51f0
Reviewer Checklist
[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR
[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:
[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop
[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:
[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Screenshots/Videos
Android: Native
https://github.com/Expensify/App/assets/56457735/04df5908-c808-4704-b597-9ff808a312ec
Android: mWeb Chrome
https://github.com/Expensify/App/assets/56457735/f7d1b69e-8212-4463-8830-2b6293a12faf
iOS: Native
https://github.com/Expensify/App/assets/56457735/b3da6597-704a-461e-aa63-e719bcac5fc1
iOS: mWeb Safari
https://github.com/Expensify/App/assets/56457735/ef976951-f253-4b05-bc2f-a6d111086c5c
MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/56457735/37a005b0-b0c1-45cf-b986-567369c3297c
MacOS: Desktop
https://github.com/Expensify/App/assets/56457735/2289bcad-e189-4efe-bd31-03079dc47897
The group offline behaviour is being implemented in this PR https://github.com/Expensify/App/pull/41826
as my assumption is that none of the items should be grayed-out by simply going offline
That's correct, in your case you probably already had a queued request
On my list to get to. Still on a merge freeze I believe but prioritizing everything as it comes in. Thanks for your patience here.
I think we're off the merge freeze hence I think this is good for merge ?
cc @marcaaron
Thank for the bump @ikevin127. Apologies, this fell off my radar!
The typescript error is unrelated, it should be fixed here https://github.com/Expensify/App/pull/42808
Looks like the PR has been merged now if we want to merge main on this so the checks pass.
Tests 🚀
cc @marcaaron
Thanks y'all! Nice work here ❤️
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.79-11 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
|
2025-04-01T04:10:23.425043 | 2024-05-24T11:46:34 | 2315201478 | {
"authors": [
"OSBotify",
"WojtekBoman",
"adamgrzybowski",
"mountiny",
"roryabraham",
"yuwenmemon"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14117",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/pull/42582"
} | gharchive/pull-request | Simplify the RootNavigator structure
Details
This PR refactors an approach of storing CentralPane screens in the navigation stack. In the old approach all screens displayed in CentralPane are wrapped by CentralPaneNavigator, in this PR this wrapper has been removed, screens are stored directly in the navigation stack.
Fixed Issues
$ https://github.com/Expensify/App/issues/42507
PROPOSAL:
Tests
[ ] Verify that no errors appear in the JS console
[ ] Verify if central pane screens are displayed correctly and animations and deeplinks work fine
Pages to test:
SCREENS.SETTINGS.WORKSPACES,
SCREENS.SETTINGS.PREFERENCES.ROOT,
SCREENS.SETTINGS.SECURITY,
SCREENS.SETTINGS.PROFILE.ROOT,
SCREENS.SETTINGS.WALLET.ROOT,
SCREENS.SETTINGS.ABOUT,
SCREENS.SETTINGS.TROUBLESHOOT,
SCREENS.SETTINGS.SAVE_THE_WORLD,
SCREENS.SETTINGS.SUBSCRIPTION.ROOT,
SCREENS.SEARCH.CENTRAL_PANE,
SCREENS.REPORT
Offline tests
QA Steps
[ ] Verify that no errors appear in the JS console
PR Author Checklist
[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR
[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:
[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop
[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
Screenshots/Videos
Android: Native
https://github.com/Expensify/App/assets/47774969/3b29ca62-d58a-42c0-9352-ea2297671c1a
Android: mWeb Chrome
https://github.com/Expensify/App/assets/47774969/f243caaf-b880-4c45-93a1-09846e6e5cbc
iOS: Native
https://github.com/Expensify/App/assets/47774969/43b4ca06-3319-43a0-8593-ba17ded26155
iOS: mWeb Safari
https://github.com/Expensify/App/assets/47774969/66aa39a3-3dad-4a8f-b2ed-7b76200c5589
MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/47774969/506b6615-f0da-4f0b-aecb-52c4b454890e
MacOS: Desktop
https://github.com/Expensify/App/assets/47774969/557ca56f-f749-41ec-99f3-65318f7f62b3
Looks great to me 💪 Good job!
running a build
@mountiny should work now!
Conflicts resolved and it works again
@WojtekBoman is this ready for another testing from @hoangzinh ?
@mountiny @hoangzinh I fixed the problem with blinking. I found a root cause for the Unable to access submit expense by direct link. I will continue with the implementation tomorrow. The second reported issue App shows not found page forever after sign-in with a deep link may be related but I have to confirm.
@hoangzinh @mountiny Hey guys. I spent today quite some time trying to debug the second reported issue Bug 2: App shows not found page forever after sign-in with a deep link
I haven't figured out anything. But I realised that it's exists on the main as well. So I think it shouldn't block this PR.
Generally speaking, things that happen after logging in seems unreliable. Sometimes it takes long and sometimes we land on the not found page. I managed to get not found screen on the new.expensify only once though.
The rest of the bugs for this PR should be fixed now.
Thanks @hoangzinh @adamgrzybowski
@mountiny I solved conflicts in this PR, we can proceed with it
Hi @dominictb! The test you added recently is failing after our changes. I tested this case manually and it all looks fine. I am trying to figure out what is wrong but I can't figure it out. Could you please take a look? 🙏
It would be great to merge these changes to avoid more conflicts etc. But maybe we could tackle this test later. @mountiny What do you think?
@WojtekBoman @adamgrzybowski sorry there is more conflicts
@dominictb it would be great to get this fixd before merging.
@mountiny Conflicts solved and all checks passed :)
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.2-0 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
We discovered a potential problem with this PR when it made some automated UI tests that we're adding in another PR start failing.
Actions taken
Open report A
Click link to report B
Expected result
OpenReport is called once for report A and once for reportB
Actual result
OpenReport is called twice for reportA and once for report B.
note: This likely happens because ReportScreen remounts for report A.
This caused the regression here: https://github.com/Expensify/App/issues/44422 (Discussion)
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.3-7 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
|
2025-04-01T04:10:23.479299 | 2024-07-15T20:37:10 | 2409579919 | {
"authors": [
"OSBotify",
"allroundexperts",
"puneetlath"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14118",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/pull/45424"
} | gharchive/pull-request | Assign optimistic onboarding tasks to user
Details
With this back-end PR, we made it so that onboarding tasks are assigned to the user. This updates the optimistic flow to do the same.
Fixed Issues
$ https://github.com/Expensify/App/issues/41619
PROPOSAL: https://github.com/Expensify/App/issues/41619#issuecomment-2228936813
Tests
Same as QA steps.
[x] Verify that no errors appear in the JS console
Offline tests
Same as QA steps.
QA Steps
Create a new account on NewDot
Select one of the options in the intent dialog
Once you complete the Guided setup, you should see your Concierge or Expensify chat with a GBR
The onboarding tasks in the chat should be assigned to you
This should be true, no matter whether it's the Concierge chat or the Expensify chat that has the tasks
Click into the task
If the task is in the Concierge chat, you should be able to comment on it
If the task is in the Expensify chat, there should be no comment bar
[x] Verify that no errors appear in the JS console
PR Author Checklist
[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR
[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:
[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop
[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
Bump @allroundexperts. Should be an easy one.
Reviewer Checklist
[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR
[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:
[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop
[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)
[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed
[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:
[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[ ] If any new file was added I verified that:
[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[ ] If a new CSS style is added I verified that:
[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
@thienlnam The task does not show up in the LHN.
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
@thienlnam we now make them "hidden" if you have access to the parent (similar to expense reports, IOUs, etc). That's why they don't show up in the LHN, even when assigned.
🚀 Deployed to staging by https://github.com/thienlnam in version: 9.0.9-1 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.9-2 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.
🚀 Deployed to production by https://github.com/mountiny in version: 9.0.9-5 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
🚀 Deployed to production by https://github.com/mountiny in version: 9.0.10-7 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
failure ❌
🕸 web 🕸
success ✅
|
2025-04-01T04:10:23.525734 | 2024-08-09T04:27:51 | 2457077292 | {
"authors": [
"Beamanator",
"OSBotify",
"bernhardoj",
"ikevin127"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14119",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/pull/47132"
} | gharchive/pull-request | When verifying secondary login, set it as the primary login if primary login isn't validated yet
Details
If the user primary login isn't validated yet, and they validate the secondary login, we want to set the secondary login as the primary login.
Fixed Issues
$ https://github.com/Expensify/App/issues/46350
PROPOSAL: https://github.com/Expensify/App/issues/46350#issuecomment-2253721504
Tests
Same as QA Steps
[x] Verify that no errors appear in the JS console
Offline tests
Same as QA Steps
QA Steps
Login as a new user
Create a new workspace
Add a secondary contact method and validate it
Verify the secondary contact method is assigned as the default contact method
Open the workspace members page
Verify the owner contact method/login is updated
Open the contact method page again and now verify the other contact method
Set the other contact method as default
Verify the other contact method is set as default
Repeat step 5-6
[x] Verify that no errors appear in the JS console
PR Author Checklist
[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR
[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:
[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop
[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
Screenshots/Videos
Android: Native
https://github.com/user-attachments/assets/4774b03e-ea8d-4948-85e8-521550d1c4d3
Android: mWeb Chrome
https://github.com/user-attachments/assets/1cc9f2eb-a9cc-4910-9cd2-14a8d6c3fde8
iOS: Native
https://github.com/user-attachments/assets/e4eccec7-3120-4262-8564-8e0b41e28372
iOS: mWeb Safari
https://github.com/user-attachments/assets/a80265ae-07f3-401d-8a2d-302a6010c227
MacOS: Chrome / Safari
https://github.com/user-attachments/assets/b5e28aad-4c78-4f5e-a79e-9a93e698d2d8
MacOS: Desktop
https://github.com/user-attachments/assets/05938c1f-c3df-42a0-af7f-007bf547b7a0
Reviewer Checklist
[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR
[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:
[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop
[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)
[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed
[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:
[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[ ] If any new file was added I verified that:
[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[ ] If a new CSS style is added I verified that:
[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
FYI I believe this was deployed to prod yesterday, from this checklist - https://github.com/Expensify/App/issues/47219
|
2025-04-01T04:10:23.573291 | 2024-11-25T22:26:49 | 2692433594 | {
"authors": [
"DylanDylann",
"pac-guerreiro"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14120",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/pull/53095"
} | gharchive/pull-request | Debug Mode - "Hmm... it's not here page" is shown when deleting a created violation
Explanation of Change
Fixed Issues
$https://github.com/Expensify/App/issues/52997
PROPOSAL: https://github.com/Expensify/App/issues/52997#issuecomment-2495476096
Tests
Enable debug mode in Settings > Troubleshoot
Open an existing expense report or create one
Open report details then click on debug
Click on transaction button
Click on violations tab, create a violation then open it and delete it
Confirm that you are redirected to the violations list
Click on details tab and delete transaction
Confirm that you are redirected to the report debug details tab
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR
[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:
[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop
[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
Screenshots/Videos
Android: Native
https://github.com/user-attachments/assets/083df54c-bf21-42c7-be04-aaaa8af12d4f
Android: mWeb Chrome
https://github.com/user-attachments/assets/fe1e884f-cd4d-4790-bfdb-e257bb8bf6fc
iOS: Native
https://github.com/user-attachments/assets/ae5a9313-87c0-4223-a23c-963fa957d8f9
iOS: mWeb Safari
https://github.com/user-attachments/assets/4494ed0f-e7dd-4a3f-8335-71d47da22d59
MacOS: Chrome / Safari
https://github.com/user-attachments/assets/0264a7f3-0a8b-4db0-9907-d86648702a4b
MacOS: Desktop
https://github.com/user-attachments/assets/46cc8781-0c1e-476e-9306-023f407e1f4b
Todo:
[ ] Add screen recordings
Just added the missing screen recordings. The PR is now ready for review 😄
This next week I'll be off, but someone from my team will take care of any feedback on this PR 😄
Reviewer Checklist
[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR
[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:
[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop
[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:
[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Screenshots/Videos
Android: Native
https://github.com/user-attachments/assets/b52832f5-af1b-4923-9a38-83d857ad257d
Android: mWeb Chrome
https://github.com/user-attachments/assets/282c1151-6da0-42c5-add0-15db24823cd1
iOS: Native
https://github.com/user-attachments/assets/20d8e31a-ec06-44d5-88fd-c7cdd853dbbe
iOS: mWeb Safari
https://github.com/user-attachments/assets/8c47f0f3-caf8-47f5-9023-2bd1c72c953e
MacOS: Chrome / Safari
https://github.com/user-attachments/assets/c0486053-9d8a-4d4c-a2ec-7cd770d3274e
MacOS: Desktop
https://github.com/user-attachments/assets/ae318dae-e8ea-4326-998b-25b13189898e
|
2025-04-01T04:10:23.596805 | 2022-04-05T15:33:05 | 1193351254 | {
"authors": [
"OSBotify",
"tylerkaraszewski"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14121",
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/pull/8486"
} | gharchive/pull-request | Fix typo
Details
Trivial text change.
Fixed Issues
$ https://github.com/Expensify/App/issues/8381
Tests
The tests are just to verify the text. See screenshots.
PR Review Checklist
Contributor (PR Author) Checklist
[X] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR
[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I included screenshots or videos for tests on all platforms
[ ] I ran the tests on all platforms & verified they passed on:
[x] iOS / native
[ ] Android / native
[x] iOS / Safari
[ ] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop
[x] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)
[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[X] I verified any copy / text shown in the product was added in all src/languages/* files
[X] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] I followed the guidelines as stated in the Review Guidelines
PR Reviewer Checklist
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR
[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:
[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop
[ ] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I verified proper code patterns were followed (see Reviewing the code)
[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed
QA Steps
[ ] Verify that no errors appear in the JS console
Screenshots
Web
Mobile Web
Desktop
iOS
Android
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
🚀 Deployed to staging by @techievivek in version: 1.1.52-0 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
🚀 Deployed to production by @roryabraham in version: 1.1.52-0 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
|
2025-04-01T04:10:23.610275 | 2021-06-18T22:40:02 | 925246398 | {
"authors": [
"NikkiWines",
"OSBotify",
"isagoico",
"marcaaron"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14122",
"repo": "Expensify/Expensify.cash",
"url": "https://github.com/Expensify/Expensify.cash/pull/3689"
} | gharchive/pull-request | Hook Request Step up to setupWithdrawalAccount
cc: @marcaaron
Details
Hooks up the Requestor Step to our API so that submitting the form actually moves the user through to the next step of setting up their bank account
Fixed Issues
Fixes (partially) https://github.com/Expensify/Expensify/issues/167762#event-4911211124
Tests/QA
Non-OnFido Route
Log into Expensify.cash
Navigate to /bank-account/ and click Log Into Your Bank
Follow the instructions from this SO to add an OPEN bank account
Confirm you can get to the Requestor Step and that after submitting that step you are routed to the Beneficial Owners step.
OnFido Route
Log into Expensify.cash
Navigate to /bank-account/ and click Log Into Your Bank
Follow the instructions from this SO to add an VERIFYING bank account
Confirm you can get to the Requestor Step and that after submitting that step you are routed to the OnFido view.
Tested On
[x] Web
[ ] Mobile Web
[ ] Desktop
[ ] iOS
[ ] Android
Screenshots
Web
Mobile Web
Desktop
iOS
Android
Currently trying to figure out why I get stuck in an endless loop when following the SO steps for adding a verifying BBA. Can't get past the requestor step, even though all of the data seems to be getting sent across correctly and entering the same values on E.com gets me to the OnFido stage without issue.
updated!
@NikkiWines Gonna :shipit: this since it seems to be working really well!
@thienlnam feel free to leave a review after it's merged if you spot anything we missed.
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
Throwing an InternalQA on here. But I'm not too sure if this can be QA'd at all while the secure server endpoint is pointing at production. Since this entire flow is behind a beta I don't think we need to worry about staging QA and can E2E test once everything is ready.
🚀 Deployed to staging in version: 1.0.73-4🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
@NikkiWines Hello! not sure if we're able to test this PR. I'm unable to access the /bank-account URL, it just redirects me to the main page.
@isagoico this one is marked InternalQA, but actually (as marc mentioned above) we're actually going to be testing this everything goes live. You're good to check it off
🚀 Deployed to production in version: 1.0.74-0🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
|
2025-04-01T04:10:23.920471 | 2024-07-22T20:33:09 | 2423722683 | {
"authors": [
"Exunys",
"fhudufin"
],
"license": "CC0-1.0",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14123",
"repo": "Exunys/AirHub-V2",
"url": "https://github.com/Exunys/AirHub-V2/issues/9"
} | gharchive/issue | Since you are so confident, please try to point me to a single instance where "game.Players" is used in AirHub V2, even further look for an instance in both the ESP and Aimbot V3 module for me not using "GetService" to index "Players".
|
2025-04-01T04:10:23.970067 | 2020-11-10T14:28:11 | 739957298 | {
"authors": [
"Soyvolon"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14124",
"repo": "FAForever/faf-qai",
"url": "https://github.com/FAForever/faf-qai/issues/10"
} | gharchive/issue | Attribute Based Permission Checks
Feature
Create a system for Attribute based permission verification for commands. See DSharPlus.CommandsNext permission attributes for examples.
Allow for a mix of DSharPlus.Permissions emun along with other permissions that are used with the IRC client.
Need to figure out how IRC handles permissions, and how IRCDotNet reads those perms and stores them.
From the a bit of poking around in the IRCDotNet documentation I know that the IrcUser and IrcChannelUser objects hold forms of permission checks. The IrcUser.IsOperator field being one of them.
Other than that, the IrcChannelUser is supposed to hold user specific permissions for the channel the message was sent from in the form of Modes, but I don't have any clue of what those are.
@Brutus5000 do you have any resources we can use for IRC permissions?
https://www.anope.org/ Is used for the IRC server.
Closing this as it is working and implemented, but could very well need improvements in the future for the IRC side of things.
Closing this as it is working and implemented, but could very well need improvements in the future for the IRC side of things.
|
2025-04-01T04:10:23.978445 | 2024-03-14T14:53:35 | 2186584012 | {
"authors": [
"Extraweich",
"lukashof"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14125",
"repo": "FAST-LB/pyGCodeDecode",
"url": "https://github.com/FAST-LB/pyGCodeDecode/issues/1"
} | gharchive/issue | brace example traceback error
The second example does not run, using the current version "0.2.0" through pypi, giving the following error:
Only a machine name was specified but no full setup. Trying to create a setup from pyGCD's default values...
Traceback (most recent call last):
File "D:\Code\Python\pyGCodeDecode\examples\brace\brace.py", line 11, in
brace_simulation = simulation(gcode_path=script_dir / "data" / "brace.gcode", machine_name="anisoprint_a4")
File "C:\Anaconda3\envs\pyGCodeDecode\lib\site-packages\pyGCodeDecode\gcode_interpreter.py", line 215, in init
default_presets_file = importlib.resources.files("pyGCodeDecode").joinpath(
AttributeError: module 'importlib' has no attribute 'resources'
According to @FelixFroelich, changing import importlib -> import importlib.resources in gcode_interpreter.py seems to fix this issue.
Thank you for making us aware! I'll fix it asap!
|
2025-04-01T04:10:23.989006 | 2024-09-09T08:49:25 | 2513332516 | {
"authors": [
"FAZuH"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14126",
"repo": "FAZuH/faz-bot",
"url": "https://github.com/FAZuH/faz-bot/pull/32"
} | gharchive/pull-request | fix(bot): fix overwritten admin cog commands
Fix commands in AdminCog overwritten by admin command on WynnTrackCog.admin
TODO
[ ] Sign 8767626
[ ] Test bot commands in dev
Should probably test commands on bot changes before merging the PR
Tested on dev
|
2025-04-01T04:10:24.036614 | 2023-08-30T12:45:47 | 1873608121 | {
"authors": [
"johngrimes"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14127",
"repo": "FHIR/sql-on-fhir-v2",
"url": "https://github.com/FHIR/sql-on-fhir-v2/pull/100"
} | gharchive/pull-request | Update view spec and purpose
I have made some updates to the "View Definition" page to reflect our recent discussions and work on the logical model. I've also added example results.
I have also added the problem statement I previously posted to https://github.com/FHIR/sql-on-fhir-v2/discussions/75, to the "Purpose" page.
Thanks for the review @rbrush!
|
2025-04-01T04:10:24.052282 | 2019-09-11T12:38:28 | 492211667 | {
"authors": [
"Datseris",
"FHell",
"lindnemi"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14128",
"repo": "FHell/NetworkDynamics.jl",
"url": "https://github.com/FHell/NetworkDynamics.jl/issues/7"
} | gharchive/issue | Host documentation online
Hi there. Documenter.jl is the go-to standard in creating a documentation for Julia packages. Besides the plethora of features it involves, it also allows you to build your documentation using Julia code.
Documenter.jl also has clear instructions on how you can host your documentation on the very github repository that you host your code, see for example here: https://juliadocs.github.io/Documenter.jl/stable/man/hosting/
There seems to be a dedicated folder already containing some documentation docs/ but it is inaccessible.
The documentation is already at
https://fhell.github.io/NetworkDynamics.jl/
But there was no link. We need to update the readme to show this, and rework the Docs to start with.
I'd also recommend to replace all Julia code blocks in teh documentation with @example code blocks, to ensure that the output of what you present is indeed what you would like it to be.
The documentation has been up for a while, so i think this issue can be closed. However one problem with the @example blocks remains. Apparently the ubuntu-worker that builds the docs is missing a library and prints the follwing error message into the documentation:
/home/runner/.julia/packages/GR/NSt7D/src/../deps/gr/bin/gksqt: error while loading shared libraries: libQt5Widgets.so.5: cannot open shared object file: No such file or directory
connect: Connection refused
GKS: can't connect to GKS socket application
Did you start 'gksqt'?
GKS: Open failed in routine OPEN_WS
GKS: GKS not in proper state. GKS must be either in the state WSOP or WSAC in routine ACTIVATE_WS
@Datseris, do you know how to fix this by any chance? It seems in the docs for DynamicalBillards.jl you don't have that problem.
I use PyPlot for DynamicalBilliards.jl . You should report this issue to GR's github page. However, I think that adding:
ENV["GKSwstype"] = "100"
as the first line of your make.jl tends to fix problems on Travis.
@lindnemi the docs have been up for a while, but at which link? This https://fhell.github.io/NetworkDynamics.jl/ doesn't work for me.
Thank, I'll try out your suggestions.
docs can be found here: https://fhell.github.io/NetworkDynamics.jl/dev/
I added a redirect from https://fhell.github.io/NetworkDynamics.jl/ to the dev version of the docs. Eventually the redirect should be changed to the stable version, however, as of now that is terribly out of date. @FHell we should think of incrementing the version to 0.2.1 in order to include the improved docs in the package.
|
2025-04-01T04:10:24.085024 | 2023-12-07T15:33:27 | 2031011901 | {
"authors": [
"FL550",
"PeterHoge"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14129",
"repo": "FL550/dwd_weather",
"url": "https://github.com/FL550/dwd_weather/issues/111"
} | gharchive/issue | Wrong area in Weather report after update to v2.0.13
HA: 2023.11.3
Update dwd_weather from ? to 2.0.13
Station G005 Berlin-Marzahn
Before: Wetter- und Warnlage für Brandenburg und Berlin
Now (wrong): Wetter- und Warnlage für Bayern
Card: {{ state_attr("sensor.berlin_marzahn_wetterbericht", "data") }}
The other enities are OK.
I have tried this on 3 machines.
Thank you
I've found the error. Thanks for reporting. I will soon release a new version which fixes this!
|
2025-04-01T04:10:24.093191 | 2023-10-14T19:23:45 | 1943498423 | {
"authors": [
"Eyco1981",
"FL550",
"microraptor",
"sevorl",
"variada"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14130",
"repo": "FL550/dwd_weather",
"url": "https://github.com/FL550/dwd_weather/issues/91"
} | gharchive/issue | Wrong nightly icon for clear sky
Is your feature request related to a problem? Please describe.
A clear sky condition at night is shown as "sunny" (at least in the hourly forcast).
Describe the solution you'd like
Showing the icon "clear-night" during night hours, like this weather integration:
Is implemented in 2.0.9
It is still showing sunny at night with 2.0.9.
Was able to see a bit more.
Later than midnight the clear-night symbol is shown.
But everything up to midnight still shows sunny.
The time period for clear-night might need some further adjustments.
The right way to time it would be via the sunset/sunrise times for the selected station. If DWD doesn't provide that, perhaps it is best to pull it from a different API. Otherwise you could also use a monthly table for Germany in general to approximate the times.
Or at least a more plausible fixed time period. For example 8pm to 7am or something like that.
Thanks for the suggested solutions. As the weather data is provided for stations all over the world (I guess it's mainly used in Germany, but there are some stations used outside Germany), I have to find a solution which fits all.
The "sun.sun" entity is available in home assistant out of the box. If "below horizon", show clear-night.
If sun.sun is above horizon (or unavailable/unknown) show sunny.
The "sun.sun" entity is available in home assistant out of the box. If "below horizon", show clear-night. If sun.sun is above horizon (or unavailable/unknown) show sunny.
But this will only work, if you select a station which is near your home.
with 2.0.11 I get 'sunny' instead of 'clear-night' for 4 o'clock in the morning when it's definitely still pitch-black dark over here (earlier it's cloudy here, so can't really say for evening behaviour). see screenshot.
Same here. At 3am it is sunny.
Found the error. The arguments of lat and lon for the library were in an unexpected order, which led to false sunrise/sunset times. Should be fixed in 2.0.12
Just wanted to say thanks again for this fix.
Every time I see the clear-night icon now, I enjoy this!
|
2025-04-01T04:10:24.149112 | 2017-11-09T20:44:18 | 272717802 | {
"authors": [
"padeler",
"sberryman"
],
"license": "bsd-3-clause",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14131",
"repo": "FORTH-ModelBasedTracker/PyOpenPose",
"url": "https://github.com/FORTH-ModelBasedTracker/PyOpenPose/issues/13"
} | gharchive/issue | OpenPose 1.2.0
https://github.com/CMU-Perceptual-Computing-Lab/openpose/commit/3e957ba6a10884496583ff5c351622049fbd65a0
Scanning dependencies of target PyOpenPose
[ 25%] Building CXX object PyOpenPoseLib/CMakeFiles/PyOpenPose.dir/PyOpenPose.cpp.o
[ 50%] Building CXX object PyOpenPoseLib/CMakeFiles/PyOpenPose.dir/OpenPoseWrapper.cpp.o
[ 75%] Building CXX object PyOpenPoseLib/CMakeFiles/PyOpenPose.dir/opencv_expose.cpp.o
/opt/PyOpenPose-master/PyOpenPoseLib/OpenPoseWrapper.cpp: In member function 'void OpenPoseWrapper::detectPose(const cv::Mat&)':
/opt/PyOpenPose-master/PyOpenPoseLib/OpenPoseWrapper.cpp:136:76: error: conversion from 'std::vector<op::Array<float> >' to non-scalar type 'op::Array<float>' requested
op::Array<float> netInputArray = membersPtr->cvMatToOpInput.createArray(rgb, scaleInputToNetInputs, netInputSizes);
^
/opt/PyOpenPose-master/PyOpenPoseLib/OpenPoseWrapper.cpp:139:95: error: no matching function for call to 'op::PoseExtractorCaffe::forwardPass(op::Array<float>&, const op::Point<int>&, std::vector<double>&)'
membersPtr->poseExtractorCaffe.forwardPass(netInputArray, imageSize, scaleInputToNetInputs);
^
In file included from /opt/openpose-master/include/openpose/pose/headers.hpp:10:0,
from /opt/PyOpenPose-master/PyOpenPoseLib/OpenPoseWrapper.cpp:13:
/opt/openpose-master/include/openpose/pose/poseExtractorCaffe.hpp:22:14: note: candidate: virtual void op::PoseExtractorCaffe::forwardPass(const std::vector<op::Array<float> >&, const op::Point<int>&, const std::vector<double>&)
void forwardPass(const std::vector<Array<float>>& inputNetData, const Point<int>& inputDataSize,
^
/opt/openpose-master/include/openpose/pose/poseExtractorCaffe.hpp:22:14: note: no known conversion for argument 1 from 'op::Array<float>' to 'const std::vector<op::Array<float> >&'
make[2]: *** [PyOpenPoseLib/CMakeFiles/PyOpenPose.dir/OpenPoseWrapper.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
PyOpenPoseLib/CMakeFiles/PyOpenPose.dir/build.make:62: recipe for target 'PyOpenPoseLib/CMakeFiles/PyOpenPose.dir/OpenPoseWrapper.cpp.o' failed
CMakeFiles/Makefile2:117: recipe for target 'PyOpenPoseLib/CMakeFiles/PyOpenPose.dir/all' failed
make[1]: *** [PyOpenPoseLib/CMakeFiles/PyOpenPose.dir/all] Error 2
Makefile:127: recipe for target 'all' failed
make: *** [all] Error 2
Looks like the build broke withe this commit: d1d483f3bdd90be7f3766cea36a01bfc282a3f98
Last working commit: 7ae8d776204e265ae50f11d0ddfec1e73fb24bea
thanks! I will push a fix on Monday.
Thanks! Hopefully the interface becomes a bit more stable now
@sberryman I updated PyOpenPose to work with the latest openpose. Thanks for reporting!
|
2025-04-01T04:10:24.185923 | 2022-11-07T08:45:34 | 1437980303 | {
"authors": [
"Karinon",
"antarcticrainforest"
],
"license": "BSD-2-Clause",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14132",
"repo": "FREVA-CLINT/freva-web",
"url": "https://github.com/FREVA-CLINT/freva-web/pull/4"
} | gharchive/pull-request | the clipboard changes have never been merged in gitlab due to our run…
…ner issues, so a new try here..
need some approval to merge, please
Thanks, LGTM!
|
2025-04-01T04:10:24.258530 | 2020-04-22T14:58:11 | 604826392 | {
"authors": [
"A-Manning",
"mtzguido"
],
"license": "apache-2.0",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14133",
"repo": "FStarLang/FStar",
"url": "https://github.com/FStarLang/FStar/issues/2019"
} | gharchive/issue | Bad resolution for unbundled type classes
Consider an unbundled class definition of functors -
type carrier = Type -> Type
type map_t (k: carrier) =
#a:Type -> #b:Type -> (a -> b) -> k a -> k b
// functor laws
assume val laws(#k: carrier): map_t k -> prop
type t #k = laws #k
let map [|t #'k 'map|]: map_t 'k = 'map
let ( <| ) [|t #'k 'map|]: map_t 'k = map
Goal 1/1:
('k: carrier), ('map: map_t 'k), (_: t 'map) |- _ : t (*?u16*) _
(Error 228) user tactic failed: Typeclass resolution failed: could not solve constraint: t (*?u16*) _
A more minimal repro:
let const x y = x
let foo [|const unit 'a|]: unit = ()
let bar [|const unit 'a|]: unit = foo
Goal 1/1:
('a: (*?u7*) _), (_: const Prims.unit 'a) |- _ : const Prims.unit (*?u16*) _
(Error 228) user tactic failed: Typeclass resolution failed: could not solve constraint: const Prims.unit (*?u16*) _ (see also FStar.Tactics.Derived.fst(340,4-342,16))
I'm not sure this is a bug. Looking at your second example, foo and bar are elaborated to something like:
let foo (#a:Type) [| d : const unit a |] : unit = ()
let bar (#a:Type) [| d : const unit a |] : unit = foo #?u1 #?u2
where ?u2 is a dictionary of type const unit ?u1. But nothing is constraining the fact that ?u1 must be a, as I believe you intended. Typeclass resolution could attempt to use d, and succeed, but it has checks in place to not cause any instantiation. This was added so that instances such as eq a -> eq (list a) won't cause an infinite loop when run on a goal such as eq ?1.
One way around it is doing this to make the a visible in the goals:
let ty 'a = unit
let foo' [|const unit 'a|]: ty 'a = ()
let bar' [|const unit 'a|]: ty 'a = foo'
Unification will identify ?u1 with a since it does so before unfolding ty.
Or just annotate the a:
let foo (#a:Type) [|const unit a|]: unit = ()
let bar (#a:Type) [|const unit a|]: unit = foo #a
Yet another option is to disallow instantiation only for global hypotheses (i.e. instances), while allowing it locally. With that patch (plus a bandaid) this program is accepted
let const x y = x
let foo (#a:Type) [|const unit a|]: unit = ()
let bar (#a:Type) [|const unit a|]: unit = foo
But somehow it still doesn't work with 'a, since the type of 'a is not constrained to Type and remains a uvar, so it could potentially be a solution to the dictionary goal and is tried first.
(That last bit is very surprising to me given #2011 and all...)
|
2025-04-01T04:10:24.291656 | 2016-10-11T22:12:44 | 182387829 | {
"authors": [
"davidhonfi",
"lazloz92"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14134",
"repo": "FTSRG/swsv",
"url": "https://github.com/FTSRG/swsv/issues/2"
} | gharchive/issue | Test naming convention wrong to "mvn test"
In spaceship project the GT4500Tests.java class doesn't follow the default maven naming conventions.
By default Maven uses the following naming conventions when looking for tests to run:
Test*
*Test
*TestCase
Thank you for the contribution!
|
2025-04-01T04:10:24.419396 | 2022-03-26T22:45:06 | 1182143726 | {
"authors": [
"AlphaMode",
"redstonerti"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14135",
"repo": "Fabricators-of-Create/Create",
"url": "https://github.com/Fabricators-of-Create/Create/issues/219"
} | gharchive/issue | Gantry shaft has no cogwheel animation
Describe the Bug
Gantry shaft has no cogwheel animation
tested with build 443 and 445
https://redstoner.me/downloads/videos/cog no turn.mp4
Reproduction Steps
Already showed a video
Expected Result
I expected the cog to turn as it does on forge
Screenshots and Videos
No response
Crash Report or Log
No response
Operating System
Windows 10
Mod Version
0.4.0d
Minecraft Version
1.18.1
Other Mods
No response
Additional Context
No response
Please check if the issue occurs on forge please before opening a issue
Please report this to upstream if you believe it is a issue. I am pretty sure this is intended though
Sorry about that. The cog might have turned in previous versions of create and confused me. Or I could I have made the whole thing up because it looked weird. I made a mistake
|
2025-04-01T04:10:24.430386 | 2022-12-03T16:27:49 | 1474146573 | {
"authors": [
"BitHeaven-Official",
"CoreBytee",
"Hancoki",
"KennyLee2378",
"Polarite",
"SteveNichols5",
"jenchanws"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14136",
"repo": "Fabricators-of-Create/Create",
"url": "https://github.com/Fabricators-of-Create/Create/issues/651"
} | gharchive/issue | Some recipes have incorrect or missing items
Describe the Bug
Some items are missing from a few recipes in the new 0.5g patch 1 version.
Reproduction Steps
Download 0.5.0g patch 1
Download EMI
Open world
View recipe of Precision mechanism
Last step is missing
Expected Result
Items are not missing from recipes
Screenshots and Videos
https://i.corebyte.me/6xh8
https://i.corebyte.me/8ZLU
Crash Report or Log
No response
Operating System
Ubuntu 20
Mod Version
0.5.0g
Minecraft Version
1.19.2
Other Mods
Full list: https://i.corebyte.me/8uVAQ
Additional Context
Using 0.5.0g patch 1
Experiencing same bug in a server I own, however for some reason relaunching and going into singleplayer beforehand sometimes fixes the issue. I think it might just be a loading problem.
I have still the same issue while using version 0.5.0i-1003+1.19.2. Also the iron nugget is shown as 'invalid'.
issue still persists and cant craft the precision mechanism at all.
If you have the Create: Extended Cogwheels mod, it's most likely due to the included recipe sequenced_assembly/precision_mechanism referring to the tag c:nuggets/iron, following Forge convention, instead of the Fabric convention c:iron_nuggets.
I don't think this has to do with Create Fabric at all, but I can't access the original files to verify.
Quick fix would be to add a datapack with the fixed recipe to your world or server.
yep, thats all right except I had to change line 4 to
"tag": "c:gold_plate"
since thats fabric convention.
for the future reference,
thanks for the help.
Wrench crafts using only 3 gold sheets and 1 gear, but need using crafting table, earlier used + 1 stick
I have same problem with broken crafts on latest version 1017
If you have the Create: Extended Cogwheels mod, it's most likely due to the included recipe create:sequenced_assembly/precision_mechanism referring to the tag c:nuggets/iron, following Forge convention, instead of the Fabric convention c:iron_nuggets.
I don't think this has to do with Create Fabric at all, but I can't access the files in the original issue to verify.
Quick fix would be to add a datapack with the fixed recipe to your world or server.
Attaching a fully working version of the datapack that works to fix the precision mechanism
precision_mechanism_fix_5.zip
item: golden_sheet could be changed to tag: gold_plate for the compatibility reasons but yes, that does fix the issue, this can be closed.
|
2025-04-01T04:10:24.435733 | 2024-11-25T18:55:24 | 2691884516 | {
"authors": [
"Fabrizz",
"Megawaldi"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14137",
"repo": "Fabrizz/MMM-OnSpotify",
"url": "https://github.com/Fabrizz/MMM-OnSpotify/issues/81"
} | gharchive/issue | Color change Notification
Is it possible that your module send a notification to the mirror with the color code from the overrode css.
So I could use the color-code to control a led light color according the css colors in the mirror.
Hi, you can do this in your module declaration:
Module.register("MMM-YourModuleName", {
defaults: {
//...
events: {
NOW_PLAYING: "NOW_PLAYING",
}
},
notificationReceived: function (notification, payload) {
this.config.events[notification]?.split(" ").forEach((e) => {
switch (e) {
case "NOW_PLAYING":
// Read the color from CSS when a new song is played
// This is the easiest way to get the current color, but lets say that for some reason
// the color processing is slow (ex: image download), now you have the color of the last song played!
//
// Here is solved with a hard coded delay (And that is not the best solution). Adding an event
// to the OnSpotify module that sends the color when it is updated is probably better, but now
// you need to know when its processing song colors and not other colors like the pfp color.
//
// This is something to keep in mind, if you modify my module to add the event create a PR and I will merge it,
// the change should be done inside the dom builder in the functions that are invoked on a new session and
// on song update if I remember correctly
if (this.nowPlaying) { // If is playing (here you can add more conditions)
setTimeout(() => {
/** rgb(255, 100, 50) */
const cssVariable = getComputedStyle(document.documentElement).getPropertyValue('--ONSP-VIBRANT-VIBRANT').trim();
/** [R, G, B] */
const cssColor = cssVariable.includes("rgb") ? cssVariable.match(/\d+/g).map(Number) : [255, 255, 255];
// Do stuff with you color. Ex: Send it to the node_helper to set your light
console.log("Current CSS color:", cssColor);
this.sendSocketNotification("SET_LIGHT_COLOR", { colorArray: cssColor });
}, 400);
} else {
console.log("Current CSS color:", " NOT PLAYING");
this.sendSocketNotification("SET_LIGHT_COLOR", { colorArray: [0, 0, 0] });
}
break;
}
})
}
// [...]
}
Thank you Fabrizz. It works very well. I used the MMM-notification-to-command module to catch the notification.
|
2025-04-01T04:10:24.507031 | 2024-08-24T16:37:47 | 2484713200 | {
"authors": [
"object-Object",
"vgskye"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14138",
"repo": "FallingColors/HexMod",
"url": "https://github.com/FallingColors/HexMod/pull/739"
} | gharchive/pull-request | Check for Sprint bind instead of Ctrl for ShiftScrollListener
fixes #179.
how does this interact with the "toggle sprint" feature?
I wonder how much effort it would be to add a new keybind. Can we do that without conflicting with existing keys that are also bound to ctrl?
Toggle sprint seems to work the same as toggle sneak, turning ctrl into a toggle in here as well.
LGTM
|
2025-04-01T04:10:24.529421 | 2020-11-06T01:21:16 | 737382719 | {
"authors": [
"codecov-io",
"rus-alex"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14139",
"repo": "Fantom-foundation/go-lachesis",
"url": "https://github.com/Fantom-foundation/go-lachesis/pull/553"
} | gharchive/pull-request | New cmd/tx-storm
New cmd/tx-storm is ported from develop branch and adopted to the existing scripts.
Codecov Report
Merging #553 into develop2 will increase coverage by 0.19%.
The diff coverage is 2.78%.
@@ Coverage Diff @@
## develop2 #553 +/- ##
============================================
+ Coverage 46.46% 46.66% +0.19%
============================================
Files 167 168 +1
Lines 11201 11168 -33
============================================
+ Hits 5205 5212 +7
+ Misses 5470 5432 -38
+ Partials 526 524 -2
Impacted Files
Coverage Δ
cmd/tx-storm/acc.go
23.80% <0.00%> (ø)
cmd/tx-storm/config.go
0.00% <0.00%> (ø)
cmd/tx-storm/flags.go
0.00% <0.00%> (ø)
cmd/tx-storm/metrics.go
0.00% <ø> (ø)
cmd/tx-storm/nodes.go
0.00% <0.00%> (ø)
cmd/tx-storm/sender.go
0.00% <0.00%> (ø)
cmd/tx-storm/txgen.go
0.00% <0.00%> (ø)
utils/avg_buff.go
0.00% <0.00%> (ø)
cmd/tx-storm/main.go
31.57% <33.33%> (-0.93%)
:arrow_down:
gossip/execqueue.go
88.88% <0.00%> (-2.78%)
:arrow_down:
... and 5 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7635d14...359a3d4. Read the comment docs.
|
2025-04-01T04:10:24.538604 | 2024-01-19T16:04:44 | 2090844369 | {
"authors": [
"Kallinteris-Andreas",
"mishmish66"
],
"license": "MIT",
"license_source": "github-api",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14140",
"repo": "Farama-Foundation/Gymnasium-Robotics",
"url": "https://github.com/Farama-Foundation/Gymnasium-Robotics/pull/206"
} | gharchive/pull-request | Change XML saving for maze to fix infrequent crash
Description
I changed the way that temporary xmls are stored for the maze envs. I have used this change for training and it improves stability, without it my training would crash sometimes, usually after about 1m env steps. With this change it seems to be stable.
Type of change
Please delete options that are not relevant.
[x] Bug fix (non-breaking change which fixes an issue)
Checklist:
[x] I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation N/A
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
Can you please elaborate on why the crashing was happening prior to this change?
Honestly it's a little unclear to me, the crash threw a XML parsing error giving a line and reason, but obviously the XML is supposed to be working. My guess is either the XML tool we are using to write to the XML file does not flush the buffers correctly internally, and since here we use the open() context manager it flushes as needed, or it's because there is a collision since I'm using a lot of parallelism and this is using just timestamping. With these changes the directories are unique regardless of time, and also the file is flushed fully.
@Kallinteris-Andreas is there anything else I should do to get this fix in?
@mishmish66 any progress on finding the test?
Note: I am willing to merge without a test, since it is hard to assert concurrency behavior
No, I couldn't replicate the errors in a test which is weird. I was seeing this on a node in a cluster so I guess testing it locally is slightly different, but in any case I guess it isn't a very significant issue if it only happens on strangely configured cluster nodes.
Just remove test_multiprocessing_not_crash and I can merge this, it is still an improvement over the existing implamention
@mishmish66 rebase and remove the test, and I can merge
@mishmish66 please remove tests and rebase
@Kallinteris-Andreas I rebased and fixed a warning that was thrown from the env on cleanup that was causing the tests to fail. I also added the change to maze-v3 envs, let me know if that is the wrong thing to do and I'll go remove that!
Thanks for your patience!
|
2025-04-01T04:10:24.543547 | 2023-12-11T11:02:24 | 2035411462 | {
"authors": [
"Kallinteris-Andreas",
"jamartinh",
"pseudo-rnd-thoughts"
],
"license": "mit",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14141",
"repo": "Farama-Foundation/Gymnasium",
"url": "https://github.com/Farama-Foundation/Gymnasium/issues/836"
} | gharchive/issue | [Question] Are there new rules for attribute forwarding of Wrappers?
Question
Hi, are there new rules for attribute forwarding of Wrappers?
In previous versions <1.0.0rc
The attributes of environments where propagated to the wrappers transparently.
Now I am experiencing many attribute errors, it seems they are not propagated any more or I am doing bad for new library specification?
If this is a NEW design structure please announce this clearly as a design option to be alerted of code breaking.
Ii there a new design documentation for how wrappers will work now ?
Thanks.
Yes, some wrappers need to be imported in a slightly different way, the changes should be included in the 1.0.0rc1 release
Thanks, a part from the importing from wrappers instead of the older routes, I am observing that they behave different with respect to env attribute access.
In the older versions since gym and gymnasium when your root env had an attribute say a Mujoco env containint the dt attribute you can access the attribute even if you top env is a wrapper of 4 layers. However now we are forced to use env.unwrapped.dt.
Is this now by design or a temporal bug ?
This is an explicit design goal to avoid a situation where a wrapper and environment shared the member variable name
Ok, so , by design and starting at version 1.0.0 we should explicitly call the attributes of root env by env.unwrapped.
Is that correct?
yes
Thanks @Kallinteris-Andreas, yes this is a by design change in v1.0.0 as otherwise users could access variables anywhere in the environment stack but importantly not modify them.
This change forces users to be more explicit with where they are accessing the variables from
|
2025-04-01T04:10:24.552806 | 2022-11-03T22:11:21 | 1435316881 | {
"authors": [
"rodrigodelazcano",
"tudorjnu"
],
"license": "mit",
"license_source": "bigquery",
"license_type": "permissive",
"provenance": "gharchive-dolma-0004.json.gz:14142",
"repo": "Farama-Foundation/Gymnasium",
"url": "https://github.com/Farama-Foundation/Gymnasium/pull/112"
} | gharchive/pull-request | Refactor Mujoco Rendering and bump to Mujoco 2.3.0
Description
This PR refactors the mujoco rendering:
Created a new class MujocoRenderer. This class abstracts the viewer (offscreen or window) selection depending on the render_mode.
Solved issue from the gym repository. Only one glfw context can be made current in the main thread. The Offscreen and Window renders switch their context current status. Also note that this only works if the Offscreen renderer uses glfw as the opengl backend, if the environment variable is MUJOCO_GL=glfw, not for egl or osmesa which are usually used for headless rendering (no "human" rendering permitted either way).
New additions:
Bump mujoco to version 2.3.0
Please delete options that are not relevant.
[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist:
[x] I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
Hey @tudorjnu. Will this PR fix your issue in https://github.com/openai/gym/issues/2989? I've used it to render an rgb_array camera sensor at the same time I debug with human rendering in another camera.
Hello @rodrigodelazcano! Thank you for the PR. Unfortunately, it seems like it did not fix the problem. Firstly, it seems that the renderer can render a single camera at a time given the current implementation. I manage to get away with it by redefining the render method and allowing myself to add the parameters:
def render(
self,
render_mode: str = None,
camera_id: int = None,
camera_name: str = None
):
if render_mode is None:
render_mode = self.render_mode
if camera_id is None:
camera_id = self.camera_id
if camera_name is None:
camera_name = self.camera_name
return self.mujoco_renderer.render(
render_mode, camera_id, camera_name
)
Still, rendering the "rgb_array" and "human" at the same time is not possible at this moment. However, I think that allowing the user to change the rendering values as above offers more versatility. Whilst it does not work with the human mode, at least it can generate multiple RGB images from the simulator. This is useful if, for example, someone would want to get images from different angles and form an observation space in this way or get the image and the segmentation mask.
Hello @rodrigodelazcano! Thanks for the prompt answer. Indeed, it seems to work in the way you mentioned. Massive thanks for that! 😁
I thought I tried to render an image that way but it seems I did not! Cheers for your help!
Also, what would be the easiest way to access individual camera information (e.g. extracting segmentation masks from the camera)?
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.