id
stringlengths
22
25
commit_message
stringlengths
137
6.96k
diffs
listlengths
0
63
derby-DERBY-4923-121a5329
DERBY-4923 update of a long row can fail with ERROR nospc: nospc.U exception. This checkin fixes the problem repro'd by the included new test, which shows an update of an existing row in db failing with a nosp.U exception. The problem was an off by 1 error in checking for enough space to update a row on an overflow page to just an overflow pointer. The intent of the code is to always reserve enough space in every overflow row to allow for this update. In this case there was exactly enough space, but the code mistaken thought it needed 1 more byte. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1535413 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/store/raw/data/StoredPage.java", "hunks": [ { "added": [ " if (spaceAvailable < OVERFLOW_POINTER_SIZE) ", " // DERBY-4923 ", " // The fix for DERBY-4923 w...
derby-DERBY-4923-e8e1864a
DERBY-6320 Log a page dump to derby.log if ERROR nospc: nospc.U is returned to the user This patch adds the ability to dump a page in an insane build, and adds 2 calls to do so in 2 outstanding nospc error cases. In those two cases a new user level error is thrown and nests the nospc.U error so that we still know the original stack trace where the lowest error was thrown. The patch passes all tests and the specific errors were hand tested, one of them using the test case filed in DERBY-4923 and in the other case just by hand forcing the codepath. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1535075 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/store/raw/data/StoredPage.java", "hunks": [ { "added": [ "import org.apache.derby.iapi.reference.MessageId;" ], "header": "@@ -32,6 +32,7 @@ import java.util.Arrays;", "removed": [] }, { "added":...
derby-DERBY-4929-b175fd27
DERBY-4856 DERBY-4929 Add thread dump information for error StandardException and SQLException. Due to DERBY-289, ThreadDump.java and ExceptionUtil.java should go to iapi/error for engine. Currently, all thread dump information goes to derby.log git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1043290 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/services/context/ContextManager.java", "hunks": [ { "added": [ "import org.apache.derby.iapi.error.ExceptionUtil;" ], "header": "@@ -29,6 +29,7 @@ import org.apache.derby.iapi.error.PassThroughException;", "removed"...
derby-DERBY-4932-19d913d9
DERBY-4932: Remove the version of StringColumnVTI in the demo subtree. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1043245 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/demo/vtis/java/org/apache/derbyDemo/vtis/core/XmlVTI.java", "hunks": [ { "added": [ "import org.apache.derby.vti.StringColumnVTI;", " " ], "header": "@@ -30,6 +30,8 @@ import java.text.ParseException;", "removed": [] } ] ...
derby-DERBY-4932-96e3f0c2
DERBY-4932: Move StringColumnVTI out of its testing package into the public api. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1043122 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/types/HarmonySerialClob.java", "hunks": [ { "added": [ " Derby - Class org.apache.derby.iapi.types.HarmonySerialClob" ], "header": "@@ -1,6 +1,6 @@", "removed": [ " Derby - Class org.apache.derby.iapi....
derby-DERBY-4933-a720ce8d
DERBY-4933: Use framework helper methods to check result sets in DatabaseMetaDataTest git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1043039 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-4946-433d0845
DERBY-4946: Derby 10.7 DatabaseMetaData.getTypeInfo() should not return BOOLEAN for a soft upgraded database git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1051026 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java", "hunks": [ { "added": [ "\t\treturn getTypeInfoMinion(\"getTypeInfo\");" ], "header": "@@ -2693,7 +2693,7 @@ public class EmbedDatabaseMetaData extends ConnectionChild", "removed": ...
derby-DERBY-4947-3c295362
DERBY-4947: Missing/broken synchronization in BasicDependencyManager.getDependents() Fixed unsynchronized access to a shared structure. The references to the elements in the list are now copied to a new list. Patch file: derby-4947-1a-sync_fix.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1051271 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/depend/BasicDependencyManager.java", "hunks": [ { "added": [ " if (list.isEmpty()) {" ], "header": "@@ -318,8 +318,7 @@ public class BasicDependencyManager implements DependencyManager {", "removed": [ ...
derby-DERBY-4949-6ef238b8
DERBY-4949: Fix coercion error messages in network driver. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1052350 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/Cursor.java", "hunks": [ { "added": [ " throw coercionError( \"boolean\", column );" ], "header": "@@ -792,8 +792,7 @@ public abstract class Cursor {", "removed": [ " throw new C...
derby-DERBY-4951-14478629
DERBY-4951: Revamp tests of binary data types to fix string encoding problems. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1054734 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-4955-eea0d50c
DERBY-4955 Prepare Derby to run with Compact Profiles (JEP 161) Patch derby-5955-embed-restructure-followup, some white space changes plus a missed fix to EmbeddedDataSource40 which was in the original proff-of-concept patch but fell through the cracks in the committed patch derby-5955-embed-restructure-04. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1427047 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/jdbc/EmbeddedDataSource.java", "hunks": [ { "added": [ " public final Reference getReference() throws NamingException", " // These fields will be set by the JNDI server when it decides to", " // materialize ...
derby-DERBY-4958-ffac5c3d
DERBY-4958: Allow wrapper types as output args in the Java signatures of procedures. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1055181 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-4959-f1ec775b
DERBY-4959: All null LOBs as procedure output args. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1055676 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-4960-01a4f9bd
DERBY-4960 Race condition in FileContainer#allocCache when reopening RAFContainer after interrupt Patch derby-4960-2. When reopening the container after an interrupt we now call "reopenContainer" instead of "openContainer". "reopenContainer" is a (new) variant of "openContainer" which skips reading the header, which is ok, since it has not changed. This sidesteps the race situation. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1056591 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/store/raw/data/RAFContainer.java", "hunks": [ { "added": [ " private boolean reopen;" ], "header": "@@ -94,6 +94,7 @@ class RAFContainer extends FileContainer implements PrivilegedExceptionAction", "removed": [] ...
derby-DERBY-4963-a552fe6e
DERBY-4963 Revert to FileDescriptor#sync from FileChannel#force to improve interrupt resilience Patch derby-4963-2 removes DirRandomAccessFile4 and with it the use of FileChannel#force. It also removes the metadata boolean argument (no longer used) from the StorageRandomAccessFile#sync. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1057702 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/store/raw/data/BaseDataFileFactory.java", "hunks": [ { "added": [ " fileLockOnDB.sync();" ], "header": "@@ -1899,7 +1899,7 @@ public class BaseDataFileFactory", "removed": [ " fileLoc...
derby-DERBY-4964-a220692e
DERBY-4964: Client driver fails to convert string to boolean with setObject(col, str, Types.BIT) git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1059888 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/CrossConverters.java", "hunks": [ { "added": [ "import java.util.Locale;" ], "header": "@@ -25,6 +25,7 @@ import java.sql.Date;", "removed": [] }, { "added": [ " case Types....
derby-DERBY-4965-d326b7dd
DERBY-4965: Boolean to char conversion results in integer Made JDBC level conversion from boolean to character types result in "true" and "false" instead of "1" and "0". git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1062743 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/DatabaseMetaData.java", "hunks": [ { "added": [ " /**", " * True if the server supports transport of boolean parameter values as", " * booleans. If false, boolean values used as parameters in prepared", ...
derby-DERBY-4967-482ff80f
DERBY-4967 Handle interrupt received while waiting for database lock Patch derby-4967-locking-4 which makes the existing test LockInterruptTest assert that the interrupt flag is set when we see 08000 (CONN_INTERRUPT) - in accordance with the behavior we expect after DERBY-4741. The assert is skipped on Solaris/Sun Java <= 1.6 unless the flag -XX:-UseVMInterruptibleIO is used. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1060832 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-4970-0252fa4f
DERBY-4970: ClassCastException from getBlob()/getClob() in EmbedCallableStatement git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1058478 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/jdbc/EmbedCallableStatement.java", "hunks": [ { "added": [ " Object o = getObject(parameterIndex);", " if (o == null || o instanceof Blob) {", " return (Blob) o;", " }", ...
derby-DERBY-4973-d1ba0d0c
DERBY-4973 NullPointerException in updatelocks.sql encryption tests on IBM 1.6 Change Xact.getContextId() to just read xc value once to avoid possible NPE with lock table query. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1062096 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/store/raw/xact/Xact.java", "hunks": [ { "added": [ " /**", " * Get my transaction context Id", " */", " public final String getContextId() {", " //DERBY-4973. Make a copy of xc s...
derby-DERBY-4974-391d4a65
DERBY-4974 InterruptResilienceTest fails on Solaris with Sun VMs prior to 1.6 Patch DERBY-4974, which: a) skips the tests in InterruptResilienceTest if running with interruptible IO on Solaris b) improves the check for interruptible IO to work even if system/derby.log doesn't yet exist (which would be the case if the test is run stand-alone). git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1061988 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-498-4b9c0f51
DERBY-498 - Result set holdability defined inside stored procedures is ignored by server/client The attached patch 'derby-498.diff' changes network server to use statement holdability set within stored procedures. The patch does the following: 1. For callable statements, the execute method in DRDAStatement gets holdability from the statement that produced the resultset. 2. Added getResultSetHoldability method which takes a resultset and returns holdability. 3. execute method passes this holdability to addResultSet method, which sets DRDAResultSet.withHoldCursor with this value. 4. writeOPNQRYRM method in DRDAConnThread is changed to use the holdability of the current DRDAResultSet for setting SQLCSRHLD. 5. Added tests in lang/holdCursorJava.java. Created a new master file for DerbyNetClient. Ran derbyall on WinXP Sun jdk1.4.2. No failures. However, in a previous run of derbyall I got failures in few encryption tests. The failures did not seem related to my change. So I ran the encryption suites again and they passed. Then ran derbyall again and all tests passed. Also attaching an additional patch "xa_proc_test.diff" for xa tests. It does the following: 1. Adds procedure test to jdbcapi/xaSimplePositive.sql. 2. Updates master files. Contributed by Deepa Remesh dremesh@gmail.com git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@326718 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/drda/org/apache/derby/impl/drda/DRDAStatement.java", "hunks": [ { "added": [ "\t", "\t/**", "\t *", "\t * get resultSetHoldability with reflection. ", "\t * We need to use reflection so we can use hold cursors with 1.3.1. ", ...
derby-DERBY-4982-dede9bfc
DERBY-4982 Retrying after interrupts in store pops a bug in derbyall/storeall/storeunit/T_RawStoreFactory in some cases Patch derby-4982c. Makes the sane and insane behavior of double patch attempt detection the same: throw DATA_DOUBLE_LATCH_INTERNAL_ERROR. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1063960 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/unitTests/store/T_Util.java", "hunks": [ { "added": [ " if (!\"XSDAO\".equals(se.getSQLState())) {" ], "header": "@@ -1142,48 +1142,15 @@ public class T_Util", "removed": [ "\t\t// we expect ...
derby-DERBY-4984-1bee891c
DERBY-5079 " DERBY-4984 caused a regression which will not allow users to drop a table if the table was involved in a trigger action rebind during ALTER TABLE DROP COLUMN Adding some commented out test cases to show the problem with drop table after ALTER TABLE DROP COLUMN and some combination of triggers. This is caused because the changes for DERBY-4984 used an incorrect current dependent for the dpendency system before doing a recompile of trigger action sql. Work is being done to use the correct dependent and recreate the dependencies in SYSDEPENDS correctly after a trigger action recompile is done following an ALTER TABLE DROP COLUMN. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1076387 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-4984-bf58aa63
DERBY-5079 (DERBY-4984 caused a regression which will not allow users to drop a table if the table was involved in a trigger action rebind during ALTER TABLE DROP COLUMN) Trigger action sql should be rebound using the statement and not the trigger table. Also, dependency between the trigger table and trigger action SPS should be established. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1078693 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-4985-414ba6f7
DERBY-4985 BootLockTest can fail with ERROR XCY03: Required property 'derby.serviceProtocol' has not been set with slow configurations Use file created by BootLockMinion to coordinate the processes. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1063809 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-4987-e9f4ad9a
DERBY-4987 BootLockTest can hang reading spawned process output The test will now only attempt to get the error output if BootLockMinion has exited and also has a max timeout of ten minutes which won't slow down normal runs of the test but hopefully be long enough without risk of hanging again. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1065061 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-4988-69dbd137
DERBY-4988 ALTER TABLE DROP COLUMN should make use of information in SYSTRIGGERS to detect column used through REFERENCING clause to find trigger dependencies Derby at the time of ALTER TABLE DROP COLUMN looks for trigger dependencies by looking for column being dropped in trigger column list but that is not enough. SQL standard requires that column should not be part of explicit trigger column list or a triggered action column set. starting Derby 10.7, we have started keeping track of trigger action columns which are referenced through the REFERENCING clause. This commit will make use of that additional info to make a step forward towards meeting the SQL standards. It still does not recognize the trigger action columns that are not part of REFERENCING clause. That work can go separately. I have added upgrade test to make sure that the compatibility does not break between Derby releases prior to 10.7 and forward. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1066290 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/execute/AlterTableConstantAction.java", "hunks": [ { "added": [ "\t\t//Now go through each trigger on this table and see if the column ", "\t\t//being dropped is part of it's trigger columns or trigger action ", "\t...
derby-DERBY-4997-22db8062
DERBY-4997 SysinfoTest version output filtering is fragile with new java versions git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1067250 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-5001-7711d18e
DERBY-5001 Intermittent bug in InterruptResilienceTest Fix to allow for lock interrupts during writing in the MT RAF test fixture. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1066911 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-5002-cf3b595e
DERBY-5002 In case of checksum error, insure correct error reported to user. Changed the order of sanity page checking to make sure that if there is a checksum error on reading the page from disk, then it is the error reported. Before this change certain page inconsistencies would be found before doing the checksum check and would report different kinds of errors depending on where the corruption happened on the page. The main error case checksums try to catch is partially written page where because a derby page is made up of multiple OS/drive blocks some blocks can make it to disk before others and in the case of a hardware crash an incomplete page may be written. In this case, the current derby implementation can not recover from log as it needs a valid page to look at in order to apply log records. The db must be recovered from derby backup in this case. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1067357 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/store/raw/data/StoredPage.java", "hunks": [ { "added": [], "header": "@@ -774,18 +774,6 @@ public class StoredPage extends CachedPage", "removed": [ " try ", " {", " readPageHead...
derby-DERBY-5003-87c74010
DERBY-5003 NPE in ReplicationRun_Local_3_p5 when stopping slave after purposefully crashing master Patch to collect diagnostics (sane jars only): derby-5003-diagnostics.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1617484 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/store/raw/log/LogToFile.java", "hunks": [ { "added": [ " catch (NullPointerException e) {", " if (SanityManager.DEBUG) {", " SanityManager.DEBUG_PRINT(\"DERBY-5003 [1]:\", th...
derby-DERBY-501-fade7e97
DERBY-501: Client and embedded drivers differ on invoking a procedure that returns a single Dynamic resultSet using CallableStatement.executeQuery() This patch modifies EmbedStatement.processDynamicResults() so that it returns the number of dynamic results instead of a boolean. EmbedStatement.executeStatement() uses this number to decide whether an exception is to be raised. With this change, the executeQuery and executeUpdate parameters are no longer needed in GenericPreparedStatement.execute(). ProcedureTest.junit is now enabled in derbyall (all frameworks). Seven of the test cases run in the embedded framework only, but I expect all of them to succeed with the client driver after DERBY-1314 and DERBY-1364 have been fixed. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@414795 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/sql/PreparedStatement.java", "hunks": [ { "added": [], "header": "@@ -101,8 +101,6 @@ public interface PreparedStatement", "removed": [ "\t * @param executeQuery\t\tWhether or not called from a Statement.executeQuery()", ...
derby-DERBY-5012-3f4ebad6
DERBY-5012: bad allocation guard in ResultSet#resetUpdatedColumnsForInsert Reworked fix based on patch contributed by Dave Brosius <dbrosius@apache.org>. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1068772 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/ResultSet.java", "hunks": [ { "added": [ " for (int i = 0; i < resultSetMetaData_.columns_; i++) {" ], "header": "@@ -4694,16 +4694,8 @@ public abstract class ResultSet implements java.sql.ResultSet,", "...
derby-DERBY-5014-fff8cb7a
DERBY-5014 Tests should restore the timeout values to default after they are done running. Fixed one test that was not restoring the timeout value. Contributed by Siddharth Srivastava <akssps011@gmail.com> git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1132747 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-5015-c3bf8e5b
DERBY-5015: Use Arrays.fill() in client/am/ResultSet.java git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1069354 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/ResultSet.java", "hunks": [ { "added": [ " Arrays.fill(updatedColumns_, null);", " Arrays.fill(columnUpdated_, false);" ], "header": "@@ -4702,14 +4702,10 @@ public abstract class Result...
derby-DERBY-5017-c7a1d17d
DERBY-5017: push code assignments down to where they are used Patch contributed by Dave Brosius <dbrosius@apache.org>. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1071320 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/jdbc/BrokeredConnection.java", "hunks": [ { "added": [ "\t\t Connection conn = getRealConnection();" ], "header": "@@ -424,12 +424,9 @@ public abstract class BrokeredConnection implements EngineConnection", "remo...
derby-DERBY-5021-fc54674b
DERBY-5021: avoid map look ups in a loop by using entrySet Patch contributed by Dave Brosius <dbrosius@apache.org>. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1085409 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/tools/org/apache/derby/impl/tools/dblook/DB_Table.java", "hunks": [ { "added": [ "import java.util.Map;" ], "header": "@@ -29,6 +29,7 @@ import java.sql.SQLException;", "removed": [] }, { "added": [ "\t\tSet entrie...
derby-DERBY-5022-65014c58
DERBY-5022 : override equals correctly Fix for the .equals() override Patch contributed by Dave Brosius <dbrosius@apache.org> git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1070190 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/services/io/FormatableBitSet.java", "hunks": [ { "added": [ "\tpublic boolean equals(Object other)", " if (other instanceof FormatableBitSet) ", " {", " FormatableBitSet that = (Format...
derby-DERBY-5025-c287c8c3
DERBY-5025: Disable the automatic calculation of statistics when running UpdateStatisticsTest. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1069890 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-5028-f24f53cb
DERBY-4463; JMX test in nightly test suite failed with: JMXTest:clientjava.lang.InterruptedException DERBY-5028; InterruptResilienceTest passes with IBM 1.6 SR9 but creates javacore dumps Adjusted the skipping of this test with ibm jvms to only skip with 1.5; Added setting of derby.stream.error.extendedDiagSeverityLevel to 50000 to prevent unnecessary javacore dump files. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1071545 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-5029-c341df03
DERBY-5029, DERBY-2095 getParentLogger() won't work after the engine has been shut down onece. Change comments and AutoloadTest per Dag's comments. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1069981 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/jdbc/AutoloadedDriver.java", "hunks": [ { "added": [ " // This is the driver that memorizes the autoloadeddriver (DERBY-2905)", " // This flag is true unless the deregister attribute has been set to", " // false by ...
derby-DERBY-5037-ccdcb3de
DERBY-5037: Swallow exceptions encountered by the istat thread while the database is being shutdown. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1071310 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/services/daemon/IndexStatisticsDaemonImpl.java", "hunks": [ { "added": [ " tryToGatherStats(lcc, td, cds, AS_BACKGROUND_TASK);" ], "header": "@@ -321,7 +321,7 @@ public class IndexStatisticsDaemonImpl", ...
derby-DERBY-5040-c2c2fb81
DERBY-5040: On Windows, cascade of errors after failed test AutomaticIndexStatisticsTest Rewrote failing test (deleting the database directory fails) to use a separate database instead of the default db wombat. This should eliminate the cascade of errors. Patch file: derby-5040-1a-use_separate_db.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1071783 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-5042-74f00971
DERBY-5042: ResultSet.updateBoolean() on new BOOLEAN type throws exception git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1074127 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-5044-2198fafc
DERBY-5379 testDERBY5120NumRowsInSydependsForTrigger - The number of values assigned is not the same as the number of specified or implied columns. DERBY-5484 Upgradetest fails with upgrade from 10.8.2.2 (7 errors, 1 failure) on trunk The above 2 jiras are duplicates. The upgrade tests are failing when doing an upgrade from 10.8.2.2 to trunk. The tests that are failing were written for DERBY-5120, DERBY-5044. Both these bugs got fixed in 10.8.2.2 and higher. The purpose of these tests is to show that when the tests are done with a release with those fixes missing, we will see the incorrect behavior but once the database is upgraded to 10.8.2.2 and higher, the tests will start functioning correctly. The problem is that we do not recognize that if the database is created with 10.8.2.2, then we will not the problem behavior because 10.8.2.2 already has the required fixes in it for DERBY-5120 and DERBY-5044. I have fixed this by making the upgrade test understand that incorrect behavior would be seen only for releases under 10.8.2.2 git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1203252 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-5044-4895279b
DERBY-5044 ALTER TABLE DROP COLUMN will not detect triggers defined on other with their trigger action using the column being dropped Adding few tests for this jira git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1080707 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-5044-9355c131
Fixing comments for the tests written for DERBY-5044. The comments don't need to talk in terms of specific Derby release numbers. This will allow us to backport DERBY-5044 changes to 10.8 without having to fix the comments during the backport. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1171227 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-5045-328c3cab
DERBY-5045: Assert failures in UpdateStatisticsTest Updated statistics shouldn't be inserted into SYSSTATISTICS if the index has been dropped. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1080947 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/services/daemon/IndexStatisticsDaemonImpl.java", "hunks": [ { "added": [ "", " // DERBY-5045: When running as a background task, we don't take", " // intention locks that prevent dropping the table...
derby-DERBY-5046-afbc4ba9
DERBY-6144 nightly regression test failure, intermittent error : testStatisticsCorrectness(org.apache.derbyTesting.functionTests.tests.store.AutomaticIndexStatisticsTest)junit.framework.A test was asserting that stats had to be created after "now". I think the nightly was getting a case where the time was the same. DERBY-5046 fixed a different part to the same test to check for greater than now, so implemented that same fix at the offending line. Also added some text to be printed with the variable values if it happens again. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1467011 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-5050-b16f7705
DERBY-5050: BrokeredConnection could call setHoldability() without using reflection git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1071558 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/jdbc/BrokeredConnection.java", "hunks": [ { "added": [], "header": "@@ -32,14 +32,7 @@ import java.sql.SQLWarning;", "removed": [ "import java.io.ObjectOutput;", "import java.io.ObjectInput;", "", ...
derby-DERBY-506-24c87005
DERBY-506 Removing unused class. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@344344 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/QueryTimerTask.java", "hunks": [ { "added": [], "header": "@@ -1,51 +0,0 @@", "removed": [ "/*", "", " Derby - Class org.apache.derby.client.am.QueryTimerTask", "", " Copyrig...
derby-DERBY-506-c8ceb5f0
DERBY-506 Implements Statement.setQueryTimeout in the client driver by "piggybacking" an EXCSQLSET command on statement execution. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@344147 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/PreparedStatement.java", "hunks": [ { "added": [], "header": "@@ -1259,15 +1259,6 @@ public class PreparedStatement extends Statement", "removed": [ " java.util.Timer queryTimer = null;", " Quer...
derby-DERBY-5060-a32eb9f3
DERBY-5060: use collection apis Patch contributed by Dave Brosius <dbrosius@apache.org>. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1073375 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/drda/org/apache/derby/impl/drda/DRDAConnThread.java", "hunks": [ { "added": [ "\t\t\t\tknownManagers.add(new Integer(manager));" ], "header": "@@ -1685,7 +1685,7 @@ class DRDAConnThread extends Thread {", "removed": [ "\t\t\t\tknownMa...
derby-DERBY-5062-39244bff
DERBY-5062 push code assignments down to where they are used Patch contributed by Dave Brosius <dbrosius@apache.org> git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1074227 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/drda/org/apache/derby/drda/NetServlet.java", "hunks": [ { "added": [], "header": "@@ -85,8 +85,6 @@ public class NetServlet extends HttpServlet {", "removed": [ "\t\tLocalizedResource langUtil = new LocalizedResource(null,null,SERVLET_PROP_MESSAGES);",...
derby-DERBY-5063-8e6e96f8
DERBY-5063: Embedded driver allows updateBytes() on BOOLEAN column Make embedded driver throw same exception as the client driver when updateBytes() is executed on a BOOLEAN column. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1073287 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-5067-167094b1
DERBY-5067: Performance regression tests should populate tables before creating indexes git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1074449 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/perf/clients/BankAccountFiller.java", "hunks": [ { "added": [ " \"(ACCOUNT_ID INT NOT NULL, \" +" ], "header": "@@ -147,7 +147,7 @@ public class BankAccountFiller implements DBFiller {", "r...
derby-DERBY-5068-018948af
DERBY-5068: Investigate increased CPU usage on client after introduction of UTF-8 CcsidManager Make the CcsidManager implementations encode strings directly into the ByteBuffer instead of going via an intermediate byte array. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1125299 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/net/CcsidManager.java", "hunks": [ { "added": [ "import java.nio.ByteBuffer;", "import java.nio.CharBuffer;", "import org.apache.derby.client.am.Agent;", "import org.apache.derby.client.am.SqlException;", ...
derby-DERBY-5071-a9c38636
DERBY-5071 use string buffers when building strings in loops Patch contributed by Dave Brosius <dbrosius@apache.org> git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1075568 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/ResultSet.java", "hunks": [ { "added": [ " StringBuffer updateString = new StringBuffer(64);", " updateString.append(\"UPDATE \").append(getTableName()).append(\" SET \");", " updat...
derby-DERBY-5073-e0699eac
DERBY-3980: Conflicting select then update with REPEATABLE_READ gives lock timeout instead of deadlock DERBY-5073: Derby deadlocks without recourse on simultaneous correlated subqueries Added more comments describing the deadlock detection algorithm. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1084561 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/services/locks/Deadlock.java", "hunks": [ { "added": [ " * <p>", " * Code to support deadlock detection.", " * </p>", " *", " * <p>", " * This class implements deadlock detection by searchi...
derby-DERBY-5076-64bc46b3
DERBY-5076: Remove some unnecessary casts in ExceptionFormatter Based on patch contributed by Dave Brosius <dbrosius@apache.org>. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1075842 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/ExceptionFormatter.java", "hunks": [ { "added": [ " Sqlca sqlca = e.getSqlca();", " sqlca.returnTokensOnlyInMessageText(returnTokensOnly);", " if (e.getSqlca() == nu...
derby-DERBY-5077-7f7477d1
DERBY-5077: [patch] remove non productive instanceof checks Removed useless instanceof checks. Made checkColumnOrdering in MergeSort private and rewrote the comment, and merged two SanityManager.DEBUG blocks. Patch provided by Dave Brosius (dbrosius at apache dot org), extended by kristwaa at apache dot org. Patch file: derby-5077-1a-remove_useless_instanceofs.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1145926 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/compile/SubqueryNode.java", "hunks": [ { "added": [ " parentComparisonOperator != null;" ], "header": "@@ -689,7 +689,7 @@ public class SubqueryNode extends ValueNode", "removed": [ ...
derby-DERBY-5079-1bee891c
DERBY-5079 " DERBY-4984 caused a regression which will not allow users to drop a table if the table was involved in a trigger action rebind during ALTER TABLE DROP COLUMN Adding some commented out test cases to show the problem with drop table after ALTER TABLE DROP COLUMN and some combination of triggers. This is caused because the changes for DERBY-4984 used an incorrect current dependent for the dpendency system before doing a recompile of trigger action sql. Work is being done to use the correct dependent and recreate the dependencies in SYSDEPENDS correctly after a trigger action recompile is done following an ALTER TABLE DROP COLUMN. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1076387 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-5079-bf58aa63
DERBY-5079 (DERBY-4984 caused a regression which will not allow users to drop a table if the table was involved in a trigger action rebind during ALTER TABLE DROP COLUMN) Trigger action sql should be rebound using the statement and not the trigger table. Also, dependency between the trigger table and trigger action SPS should be established. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1078693 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-5080-695493d0
DERBY-5080: Utilize JQL to fetch JIRA issue list for release notes generation Added JQL functionality, allowing the list of JIRA issues for a release to be obtained without having to create a JIRA filter manully. Actived by specifying a JIRA filter id of 0 (zero) when running 'ant genrelnotes'. Patch file: derby-5080-2a-utilize_jql.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1129117 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "tools/release/jirasoap/src/main/java/org/apache/derbyBuild/jirasoap/FilteredIssueLister.java", "hunks": [ { "added": [ "\" JIRA id, only digits allowed.\\n\" +", "\" If '0' (zero), a JQL query will be generated instead of using an\\n\" +", "\"...
derby-DERBY-5082-15b7b103
DERBY-5082: ShutdownException in ContextManager.checkInterrupt() during shutdown The fix is two-fold: a) Avoid destroying tx, which will fail, if the database is [being] shut down. b) If destroying tx, catch ShutdownException in case someone shuts down the database under our feet. Added a break to make the flow clearer (also avoids an unnecessary trace-line). Patch file: derby-5082-1a-fix.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1076462 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/services/daemon/IndexStatisticsDaemonImpl.java", "hunks": [ { "added": [ " break;" ], "header": "@@ -741,6 +741,7 @@ public class IndexStatisticsDaemonImpl", "removed": [] }, { ...
derby-DERBY-5084-4109a77d
DERBY-5084; convert ijConnName.sql to a ScriptTest junit test adding apache headers to two new files. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1097469 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-5086-d1ded580
DERBY-5086: Disable istat logging by default git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1076559 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java", "hunks": [ { "added": [], "header": "@@ -435,8 +435,6 @@ public final class\tDataDictionaryImpl", "removed": [ " /** TODO: Remove this when code goes into production (i.e. a release)...
derby-DERBY-5087-299b9e7b
DERBY-5087: NPE in istat daemon when encountering critical exception during shutdown Don't null out the index stats refresher reference in the data dictionary when stopping the module. Removed unnecessary variable 'daemonStopped', used existing 'daemonDisabled' instead. Patch file: derby-5087-1a-npe_on_shutdown.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1076445 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/services/daemon/IndexStatisticsDaemonImpl.java", "hunks": [ { "added": [], "header": "@@ -131,8 +131,6 @@ public class IndexStatisticsDaemonImpl", "removed": [ " /** Tells if the daemon has been stopped. */", "...
derby-DERBY-5088-cd02474f
DERBY-5088: ShutdownException raised in istat thread during factory call Refactored outer-level error handling, and moved context service factory call inside try/catch. Patch file: derby-5088-1a-shutdownexception_refactor.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1076802 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/services/daemon/IndexStatisticsDaemonImpl.java", "hunks": [ { "added": [ " * <p>", " * This method is run as a background task." ], "header": "@@ -307,6 +307,8 @@ public class IndexStatisticsDaemonImpl", ...
derby-DERBY-5089-3a6d457f
DERBY-5089: Improve tracing/logging of runtime exceptions raised in the istat thread Added tracing/logging of runtime exceptions and checked exceptions. Removed/added/modified some other traces. Patch file: derby-5089-1a-improved_tracing.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1078449 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/services/daemon/IndexStatisticsDaemonImpl.java", "hunks": [ { "added": [ " \"update scheduled\" +", " : \", reason=[\" + schedulingReason + \"]\") +" ], "header": ...
derby-DERBY-5090-2d1bc8fc
DERBY-5090: Retrieving BLOB fields sometimes fails Clean up use of messages when accessing closed objects (mostly streams): o remove unused XJ094.S o rename J104 to OBJECT_CLOSED. o replace uses of XCL53 with J104. o remove XCL53 Patch file: derby-5090-3a-change_messages.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1155332 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/jdbc/ClobUtf8Writer.java", "hunks": [ { "added": [ "import org.apache.derby.iapi.reference.MessageId;" ], "header": "@@ -23,12 +23,9 @@", "removed": [ "import java.io.InputStreamReader;", "import...
derby-DERBY-5090-b9960232
DERBY-5090: Retrieving BLOB fields sometimes fails Make Derby close open streams obtained from the result set when the next get-call is invoked (as dictated by JDBC standard). This was done for some streams, but not all. What happened was also different for the client and the embedded driver. Added CloseFilterInputStream (modeled after existing class in the client). Removed NewByteArrayInputStream, used Java API class instead. Patch file: derby-5090-1b-fix.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1142896 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/ResultSet.java", "hunks": [ { "added": [], "header": "@@ -30,7 +30,6 @@ import java.sql.Time;", "removed": [ "import org.apache.derby.client.am.SQLExceptionFactory;" ] }, { "added": [ ...
derby-DERBY-5093-5da491e6
DERBY-5093: avoid Integer allocations fetching client meta data info Patch contributed by Dave Brosius <dbrosius@apache.org>. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1085407 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/DatabaseMetaData.java", "hunks": [ { "added": [ " if ((Integer.parseInt(st.nextToken())) == type) {" ], "header": "@@ -2560,7 +2560,7 @@ public abstract class DatabaseMetaData implements java.sql.Databas...
derby-DERBY-5099-ecef2eb1
DERBY-5099: PrepareStatementTest depends on ordering of test cases Merged two test cases that depended on one another so that the order in which the test cases run doesn't affect the result. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1079336 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-5100-a5209eb6
DERBY-5100: GetCurrentPropertiesTest depends on implicit ordering of test cases Made the test ordering explicit. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1082226 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/TestConfiguration.java", "hunks": [ { "added": [ "import java.util.Collections;", "import java.util.Comparator;", "import java.util.Iterator;" ], "header": "@@ -28,8 +28,11 @@ import java.sql.Co...
derby-DERBY-5101-84349af5
DERBY-5101: TruncateTableTest depends on implicit ordering of test cases Added a workaround for DERBY-5139 so that the test doesn't fail when testSelfReferencing runs first. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1082428 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-5102-ad5e6e3d
DERBY-5102: GrantRevokeDDLTest depends on implicit ordering of test cases More cleanup when the test cases complete. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1080557 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-5103-8010935f
DERBY-5103: ProcedureInTriggerTest depends on implicit ordering of test cases Change the test cases to be self-contained and not depend on the side effects of the other test cases. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1079805 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-5104-ac0be7fe
DERBY-5104: InterruptResilienceTest fails to remove tables in tearDown() git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1079349 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-5105-ae72a308
DERBY-6003: Create row templates outside of the generated code Upgrade test fix in preparation for the actual fix for this issue. Improve SYSCS_INVALIDATE_STORED_STATEMENTS by making it null out the plans in SYS.SYSSTATEMENTS. Previously, it only marked them as invalid. Use the improved SYSCS_INVALIDATE_STORED_STATEMENTS to work around problems in the upgrade tests when downgrading to a version that suffers from DERBY-4835 or DERBY-5289. Remove the old workarounds for DERBY-4835, DERBY-5105, DERBY-5263 and DERBY-5289, as they are now handled by the centralized workaround that uses SYSCS_INVALIDATE_STORED_STATEMENTS. This change is needed because later patches for this issue will change the format of many stored plans, so more of the test cases need to work around the downgrade bugs in some old versions. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1418296 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java", "hunks": [ { "added": [ " * @param recompile Whether to recompile or invalidate" ], "header": "@@ -4429,6 +4429,7 @@ public final class\tDataDictionaryImpl", "removed": [] ...
derby-DERBY-5105-caf6b950
DERBY-5105: NoSuchMethodError in upgrade tests (testTriggerBasic) Disable the post soft upgrade phase for the versions that suffer from DERBY-4835. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1081072 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-5107-04c0d4e2
DERBY-5107: BasicInMemoryDbTest depends on implicit ordering of test cases Use helper methods that ensure created databases are dropped between each test case, and also load the JDBC driver explicitly in test cases that used to require that an earlier test case had already loaded the driver implicitly. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1082282 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-5108-764b3a0f
DERBY-5108: Intermittent failure in AutomaticIndexStatisticsTest.testShutdownWhileScanningThenDelete on Windows Adjust the istat log message if the scan is aborted. Patch file: derby-5108-3a-istat_log_abort.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1133317 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/services/daemon/IndexStatisticsDaemonImpl.java", "hunks": [ { "added": [ " sb.append('c').append(timings[i][0]).append('=');", " // Handle corner-case where the scans are aborted due to the", " ...
derby-DERBY-5108-a346f0c7
DERBY-5108 Changes istat daemon shutdown to check during processing if a shutdown is in progress and respond to the shutdown immediately. Also changes the module stop() to wait for worker threads to exit before returning. Waiting for work to stop allows the subsequent shutdown of the storage system to properly close it's files during a clean shutdown request. Without this change the system sometimes left files open which the nightly tests uncovered on windows machines while trying to delete those files. This change is a slightly modified version of a patch proposed by Knut Anders Ha tlen. Previous to this change the AutomaticIndexStatisticsTest.testShutdownWhileScanni ngThenDelete test would fail on my machine consistently in SANE classes mode on a windows XP laptop. After this I have only seen one failure in 50 runs. Checking it in as it is definitely an improvement and want to see if it fixes the errors in the nightly's across a number of environments. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1081677 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/services/daemon/IndexStatisticsDaemonImpl.java", "hunks": [ { "added": [ "", " if (isShuttingDown()) {", " break;" ], "header": "@@ -424,12 +424,11 @@ public class Index...
derby-DERBY-5108-ebd44de6
DERBY-5108 Intermittent failure in AutomaticIndexStatisticsTest.testShutdownWhileScanningThenDelete on Windows Follow-up patch DERBY-5108-2 which makes the join with the daemon retry in the case the thread gets interrupted, also note the fact in InterruptStatus to follow our new pattern for interrupt handling. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1085027 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/services/daemon/IndexStatisticsDaemonImpl.java", "hunks": [ { "added": [ " while (true) {", " try {", " threadToWaitFor.join();", " break;", ...
derby-DERBY-5108-ee17158f
DERBY-5108: Intermittent failure in AutomaticIndexStatisticsTest.testShutdownWhileScanningThenDelete on Windows Shut down the istat daemon thread at an earlier stage when the database is being shut down (user initiated or due to a severe error). This should avoid the problem where file containers are reopened by the istat daemon after the container cache has been shut down. Patch file: derby-5108-2a-early_istats_shutdown_broad.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1133304 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/db/DatabaseContextImpl.java", "hunks": [ { "added": [ "import org.apache.derby.iapi.sql.dictionary.DataDictionary;" ], "header": "@@ -24,6 +24,7 @@ package org.apache.derby.impl.db;", "removed": [] } ] }...
derby-DERBY-5111-6048528d
DERBY-5111 NullPointerException on unique constraint violation with unique index Patch derby-5111. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1579766 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/sql/dictionary/IndexLister.java", "hunks": [ { "added": [], "header": "@@ -100,19 +100,6 @@ public class IndexLister", "removed": [ " /**", "\t *\tReturns an array of all the index names on a table.", ...
derby-DERBY-5111-75227075
DERBY-5111 NullPointerException on unique constraint violation with unique index Patch derby-5111-test, which adds the repro for this issue as a new test case. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1582819 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-5112-b26ddb05
DERBY-5112: ImportExportTest depends on implicit ordering of test cases Reset test tables between each test case. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1079693 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-5113-995d3745
DERBY-5113: Intermittent failure in BlobSetMethodsTest on Java 7: Unable to set stream: 'Reached EOF prematurely; expected 1,024, got 0.' Blob.truncate() should copy bytes from the beginning of the stream. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1081293 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-5113-9b3569f8
DERBY-5113: Intermittent failure in BlobSetMethodsTest on Java 7: Unable to set stream: 'Reached EOF prematurely; expected 1,024, got 0.' AccessTest should reset the database properties it modifies. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1081059 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-5115-66988078
DERBY-5115: NetworkServerControlApiTest depends on implicit ordering of test cases Made the test ordering explicit. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1082233 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-5117-03e7a1bc
DERBY-5117: ParameterMetaDataJdbc30Test fails with "'DUMMYINT' is not recognized as a function or procedure" git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1079779 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-5119-40ca7ba5
DERBY-5119 testQualifiers(org.apache.derbyTesting.functionTests.tests.store.AccessTest)java.sql.SQLException: Table/View 'FOO' already exists in Schema 'APP'. Add drop of table FOO to teardown method so previous failed fixtures won't leave it around to intefere with others. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1081568 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-5120-2198fafc
DERBY-5379 testDERBY5120NumRowsInSydependsForTrigger - The number of values assigned is not the same as the number of specified or implied columns. DERBY-5484 Upgradetest fails with upgrade from 10.8.2.2 (7 errors, 1 failure) on trunk The above 2 jiras are duplicates. The upgrade tests are failing when doing an upgrade from 10.8.2.2 to trunk. The tests that are failing were written for DERBY-5120, DERBY-5044. Both these bugs got fixed in 10.8.2.2 and higher. The purpose of these tests is to show that when the tests are done with a release with those fixes missing, we will see the incorrect behavior but once the database is upgraded to 10.8.2.2 and higher, the tests will start functioning correctly. The problem is that we do not recognize that if the database is created with 10.8.2.2, then we will not the problem behavior because 10.8.2.2 already has the required fixes in it for DERBY-5120 and DERBY-5044. I have fixed this by making the upgrade test understand that incorrect behavior would be seen only for releases under 10.8.2.2 git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1203252 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-5120-8af5f9e8
I am commiting change which include engine changes and upgrade test addition. Will add tests as another checkin Following is a brief description of the engine changes. For the table being altered, we will go through the dependency system to determine all the triggers that depend on the table being altered(this will include triggers defined directly on the table being altered and the triggers defined on other tables but using the table being altered in their trigger action plan.) This is done by first finding all the objects that depend on the table being altered. We are only interested in SPSDescriptors from that list of dependent objects. For each of these dependent SPSDescriptor, we want to find if they are defined for a trigger action SPS. If yes, then the trigger must be dependent on the table being altered. For each of these dependent triggers, we dropped their trigger descriptor from datadictionary, regenerate and rebind it's trigger action SPS and then add the trigger descriptor(with upto date version of internal representation of trigger action) back to datadictionary.During the rebind of trigger action, we will get exception if the trigger depends on the column being altered. If so, then if the alter table drop column is being done in restrict mode, then we will throw an exception that column can't be dropped because it has dependent object. If the drop column was issued in cascade mode, then we will drop the dependent triggers. As part of this commit, I have removed the code which used to go directly through all the triggers defined on the table being altered and dropping, rebinding and recreating them. This is because the new code going through the dependency system should find all the triggers which would be impacted by drop column, no matter whether the triggers are defined on the table being altered or triggers defined on other tables but using table being altered in their trigger action.) DERBY-5120 could have prevented us from catching all the triggers defined on the table being altered through the dependency system because of missing dependency between trigger action sps and trigger table but that has been fixed in 10.9 and 10.8 so we should be fine. I have run all the existing junit suites and derbyall and they ran fine. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1166313 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/execute/AlterTableConstantAction.java", "hunks": [ { "added": [ "import org.apache.derby.catalog.Dependable;" ], "header": "@@ -29,6 +29,7 @@ import java.util.Properties;", "removed": [] }, { ...
derby-DERBY-5120-95971f27
DERBY-5120 Row from SYSDEPENDS gets deleted when a table has update triggers defined on it and an upate is made to the table This commit moves recording to trigger action sps's dependency on trigger table from create trigger constant action and alter table constant action to SPSDescriptor. This central location in SPSDescriptor for recording the dependency will take care of create trigger, alter table and sps regeneration cases. The checkin also required fixing triggerGeneral.sql because now that we do not loose the dependency between trigger action sps and trigger table, the change in trigger table always sends an invalidation signal to it's triggers which causes those triggers to recompile when they fire next time. For triggerGeneral case, the trigger in question ends up being incorrect(because of alter table add column) and thus would cause the test to fail. I resolved it by fixing the trigger action. Additionally, I have added upgrade test case which checks how the trigger invalidation signal are missed prior to this fix thus not catching incorrect triggers. This test has been disabled for 10.5.1.1, 10.5.3.0, 10.6.1.0 and 10.6.2.1 because those 4 releases do not have DERBY-4835 fix in them. Because of that missing fix, the triggers donot get invalidated as part of upgrade for those releases and hence the test added by this jira would fail for those 4 releases. To avoid the failure, I have disabled the test for those 4 releases. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1146915 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-5121-168be4e5
DERBY-1482 / DERBY-5121 Rick Hillegas contributed a very exhaustive trigger test which I am converting to junit and adding to the upgrade suite // The test exhaustively walks through all subsets and permutations // of columns for a trigger which inserts into a side table based on // updates to a master table. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1125453 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-5121-56bebbea
DERBY-5121 Data corruption when executing an UPDATE trigger With the earlier checkin for DERBY-5121, DERBY-1482 changes weren't completely backed out on trunk and 10.7. We have backed out the code for the triggers so that now triggers look for the columns in their actual column positions at execution time. But DERBY-1482 also made changes to UPDATE code to read only the colunms needed by it and the triggers that it is going to fire. We need to backout the changes to UPDATE code to make sure that it reads all the columns from the trigger table and not do selective column reading. Also adding an upgrade case testing the behavior of UPDATE reading correct columns from the trigger table so that trigger finds the columns it needs. derbyall and junit suite runs fine with these changes git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1087049 13f79535-47bb-0310-9956-ffa450edef68
[]