id stringlengths 22 25 | commit_message stringlengths 137 6.96k | diffs listlengths 0 63 |
|---|---|---|
derby-DERBY-2435-c9c3c8e8 | DERBY-2435: Commit derby-2435-01.diff, making NetworkServerControl pick up properties from derby.properties as needed.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@519004 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/drda/NetworkServerControl.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.services.property.PropertyUtil;"
],
"header": "@@ -26,6 +26,7 @@ import java.net.InetAddress;",
"removed": []
},
{
... |
derby-DERBY-244-958e2569 | DERBY-244: with linux, depending on env setting $LANG and console
encoding, some i18n tests fail
* Run the i18n tests run with -Dfile.encoding=UTF-8 and
-Dconsole.encoding=UTF-8
* Use UTF-8 encoding in ProcessStreamResult for the i18n tests
* Make Sed.java read result files from i18n tests using UTF-8 encoding
* Respect the derby.ui.codeset setting in i18n tests, and use UTF-8 if it
is not specified.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@432645 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/harness/Sed.java",
"hunks": [
{
"added": [
" if (is == null && isI18N) {",
" // read UTF-8 encoded file",
" InputStream fs = new FileInputStream(srcFile);",
" ... |
derby-DERBY-2440-d2e9303e | DERBY-2440 DerbyNetNewServer should specify port when it starts a server to avoid requiring 1527 to run
Committed patch d2440.diff.
Contributed by Julius Stroffek (julius.stroffek@sun.com).
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@532498 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-2442-41943bbb | DERBY-2442: Remove code made redundant by DERBY 681.
Patch contributed by Manish Khettry.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@519936 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/FromSubquery.java",
"hunks": [
{
"added": [],
"header": "@@ -21,12 +21,8 @@",
"removed": [
"import org.apache.derby.iapi.reference.SQLState;",
"",
"import org.apache.derby.iapi.services.conte... |
derby-DERBY-2442-b3bf9cab | DERBY-2442: Remove code made redundant by DERBY 681.
Patch contributed by Manish Khettry.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@520885 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/ResultColumnList.java",
"hunks": [
{
"added": [],
"header": "@@ -1582,11 +1582,6 @@ public class ResultColumnList extends QueryTreeNodeVector",
"removed": [
"\t\t\t\t/* Make sure that every RC and expression is ... |
derby-DERBY-2443-89459c8f | DERBY-2443: Implement ResultSet updateClob/updateBlob methods on the
NetworkClient
Patch contributed by V. Narayanan.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@522873 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/ResultSet.java",
"hunks": [
{
"added": [
" /**",
" * Updates the designated column with a <code>java.sql.Blob</code> value.",
" * The updater methods are used to update column values in the",
"... |
derby-DERBY-2444-c9382f06 | DERBY-2444: Implement not implemented methods
Blob.getBinaryStream(long pos, long length) and
Clob.getCharacterStream(long pos, long length) in the Network Client
Patch contributed by V. Narayanan.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@528546 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-2446-504ba175 | DERBY-2446; Remove notion of the old test harness from TestConfiguration
Removing remaining references, and also removing remaining files from tests/junitTests
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1531729 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/TestConfiguration.java",
"hunks": [
{
"added": [],
"header": "@@ -131,13 +131,6 @@ public final class TestConfiguration {",
"removed": [
" /**",
" * Default Derby test configuration object based",
... |
derby-DERBY-2447-ad0c80a9 | DERBY-2447: ejbql and floattypes fail intermittently
A bug in the HotSpot optimization made normalization of floating point
values return negative zero instead of positive zero. This patch adds
a workaround for the bug and a regression test. The workaround also
makes the intent of the code clearer.
For details about the HotSpot bug, see:
http://bugs.sun.com/view_bug.do?bug_id=6833879
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@772449 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/NumberDataType.java",
"hunks": [
{
"added": [
" // DERBY-2447: It shouldn't matter whether we compare to 0.0f or -0.0f,",
" // both should match negative zero, but comparing to 0.0f triggered",
" ... |
derby-DERBY-2457-e6d28aa0 | DERBY-2457: Use of column aliases in GROUP BY / HAVING clauses may fail
Some use of column aliases in group by / having clauses can cause queries
to fail with error 42X04. The queries can sometimes be made to work by
also aliasing the table or rewriting the query to use a subselect.
After analyzing the script, and studying the standard, we came to feel
that Derby was behaving correctly according to the standard. While
column aliases are valid in the ORDER BY clause, they are not valid
in the GROUP BY and HAVING clauses. Instead, Derby currently correctly
enforces the standard's requirement that the underlying column name
be used in these clauses.
This change updates the Derby GroupByTest.java test program to contain
the examples from the reproduction script, demonstrating that Derby's
behavior is correct, and adding to the body of GROUP BY test cases.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@655947 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-246-88c25bba | DERBY-339 Network client XA should only keep XA state for transaction branch association
Network client XA should only keep XA state for transaction branch association, to track whether to send commit in autocommit mode. All other state and state related decisions should be defered to the server.
The client tries to track XA state to make decisions based on current XA state. Most of this state handling was removed with DERBY246, but it still was not being handled properly. This is evidenced by multiple failures in xaSimplePostive that now that it gets past DERBY-246.
This fix will have the client track only branch association as outlined in the XA+ specification. Table 6-2, State Table for Transaction Branch Association. The client will track only
XA_TO_NOT_ASSOCIATED
XA_T1_ASSOCIATED
Association Suspended (T2) will map to XA_TO_NOT_ASSOCIATED for the client's pupurposes.
The client commit in autocommit mode only for
XA_TO_NOT_ASSOCIATED.
git-svn-id: https://svn.apache.org/repos/asf/incubator/derby/code/trunk@189710 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/Connection.java",
"hunks": [
{
"added": [
" // The client needs to keep track of the connection's transaction branch association",
" // per table 2.6 in the XA+ specification in order to determine if commits should flo... |
derby-DERBY-2462-1e762f52 | DERBY-2462 Committed DERBY-2462-4, which fixes this issue and improves the test.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@538572 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/store/access/DiskHashtable.java",
"hunks": [
{
"added": [
"import org.apache.derby.shared.common.reference.SQLState;"
],
"header": "@@ -24,6 +24,7 @@ import java.util.Enumeration;",
"removed": []
},
{
... |
derby-DERBY-2465-3568cea1 | DERBY-378 (partial)
This patch adds some code required to support import/exoprt of lob data.
1) Addded code to read clob data using getCharacterStream()
instead of getString() while importing clob data from an extern file.
(Note: Clobs are read using getString() until DERBY-2465 is fixed).
2) Made some code changes to make each lob column has it it's own file handle to
the lob file to read the data, otherwise streams can get corrupted when
there are more than one clob/blob type column in the table.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@520197 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/load/ImportAbstract.java",
"hunks": [
{
"added": [
" if (isColumnInExtFile(columnIndex)) {",
"\t\t\tval = importReadData.getClobColumnFromExtFileAsString(val, ",
" ... |
derby-DERBY-2466-59a5a70a | DERBY-2466: Introduce system procedure which reloads the security policy file.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@522515 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/catalog/SystemProcedures.java",
"hunks": [
{
"added": [
"import java.security.AccessControlException;",
"import java.security.AccessController;",
"import java.security.PrivilegedExceptionAction;",
"import java.secu... |
derby-DERBY-2466-dc095348 | DERBY-2466: Add upgrade test for new policy-reloading procedure.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@523399 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-2466-f35adc58 | DERBY-2466: Attempt to fix NPE during run of SecurityPolicyReloadingTest on some environments.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@524252 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/SecurityManagerSetup.java",
"hunks": [
{
"added": [
"\t\t\tString newPolicyProperty = set.getProperty(\"java.security.policy\" );",
"\t\t\tif ( newPolicyProperty == null ) { newPolicyProperty = \"\"; } ",
" ... |
derby-DERBY-2468-b3bfe123 | DERBY-4067: ClientConnectionPoolDataSource.getPooledConnection and ClientXADataSource.getXAConnection ignore connection attributes
DERBY-2468: would be nice if traceFile=filename connection attribute would be supported with ClientConnectionPoolDataSource and ClientXADataSource
Made two changes:
- moved the parsing of the connection attribute string to before the log
writer is constructed, since the construction may depend on some attributes
specified in the connection attribute string
- added parsing of the connection attribute string to the client ConnectionPool
and XA data sources
Also re-enabled 'testClientMessageTextConnectionAttribute' and removed a
work-around for the issue fixed by this commit.
Patch file: derby-4067-1a-update_attrs.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@965793 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/jdbc/ClientConnectionPoolDataSource.java",
"hunks": [
{
"added": [
" updateDataSourceValues(",
" tokenizeAttributes(getConnectionAttributes(), null));"
],
"header": "@@ -74,6 +74,8 @@ publ... |
derby-DERBY-247-6558c147 | DERBY-247: Update demos to support Derby Network Client driver.
Committed for Lance Andersen <Lance.Andersen@sun.com>
git-svn-id: https://svn.apache.org/repos/asf/incubator/derby/code/trunk@190803 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/demo/nserverdemo/NsSample.java",
"hunks": [
{
"added": [
" 2.\tloads the IBM DB2 JDBC Universal driver or derby client JDBC driver",
" (default is the derby client JDBC driver)"
],
"header": "@@ -40,7 +40,8 @@ import java.io.PrintWrite... |
derby-DERBY-2472-10951832 | DERBY-2472 (partial) Use Throwable.initCause() to improve error reporting
Let EmbedSQLException use initCause/getCause instead of getJavaException.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@537592 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedSQLException.java",
"hunks": [
{
"added": [],
"header": "@@ -42,14 +42,6 @@ public class EmbedSQLException extends SQLException {",
"removed": [
"\t/**",
"\t\tJava exception that caused this exception, c... |
derby-DERBY-2472-1870e8fa | DERBY-2472 (partial) Use Throwable.initCause() to improve error reporting
Fix some unsafe calls to initCause() by catching IllegalStateException.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@542446 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/conn/GenericLanguageConnectionContext.java",
"hunks": [
{
"added": [
"\t\t\t\tif (topLevelStandardException == null) {",
"\t\t\t\t\t// always keep the first exception unchanged",
"\t\t\t\t\ttopLevelStandardException... |
derby-DERBY-2472-40888728 | DERBY-2472 (partial) Use Throwable.initCause() to improve error reporting
Chain exceptions from EmbedConnection.createDatabase() and
EmbedConnection.bootDatabase() properly.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@537753 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedConnection.java",
"hunks": [
{
"added": [
" throw Util.seeNextException(SQLState.CREATE_DATABASE_FAILED,",
" new Object[] { dbname },",
" ... |
derby-DERBY-2472-de3b1087 | DERBY-1440: jdk 1.6 client driver omits SQLStates and chained exceptions in
error messages
While working on DERBY-2472 I found out what caused this difference between
the JDBC 3.0 driver and the JDBC 4.0 driver. There are three
problems. Firstly, StandardException.unexpectedUserException() doesn't
recognize that an SQLException is generated Derby since it is not an
EmbedSQLException. Secondly, TransactionResourceImpl.wrapInSQLException()
invokes SQLException.setNextException() explicitly so that the required
chaining/ferrying logic in the exception factory and in EmbedSQLException's
constructor is not used. Thirdly,
SQLException40.wrapArgsForTransportAcrossDRDA() puts a standard
SQLException, not an EmbedSQLException, in the argument ferry's
next-exception chain, which prevents the network server from seeing it as a
Derby exception.
The attached patch fixes the problem by
1) using SQLExceptionFactory.getArgumentFerry() to find out whether the
exception is a Derby exception in unexpectedUserException()
2) using factory methods instead of setNextException() to do the chaining
in wrapInSQLException()
3) improving Util.javaException() so that it sets up a next-exception
chain if the Java exception contains nested exceptions
4) changing wrapArgsForTransportAcrossDRDA() to create an argument ferry
whose next exception is the argument ferry of the main exception's next
exception
This patch also fixes all the JUnit tests that contain code looking like this:
assertStatementError(JDBC.vmSupportsJDBC4() ? "38000" : "42X62", cSt);
Now, the check for JDBC level is not needed anymore for those tests.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@541435 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/error/StandardException.java",
"hunks": [
{
"added": [
"import org.apache.derby.impl.jdbc.Util;"
],
"header": "@@ -24,6 +24,7 @@ package org.apache.derby.iapi.error;",
"removed": []
},
{
"added":... |
derby-DERBY-2472-e70c716c | DERBY-2472 (partial) Use Throwable.initCause() to improve error reporting
Replace StandardException's implementation of exception chaining with
initCause/getCause.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@537412 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/error/StandardException.java",
"hunks": [
{
"added": [],
"header": "@@ -57,7 +57,6 @@ public class StandardException extends Exception",
"removed": [
"\tprivate Throwable nestedException;"
]
},
{
... |
derby-DERBY-2485-f06ca0f0 | DERBY-2485 Example code for a simple transaction listener scheme. Not yet used or
compiled by the build.xml files.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@522656 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/transaction/TransactionListener.java",
"hunks": [
{
"added": [
"/*",
"",
" Derby - Class org.apache.derby.iapi.transaction.TransactionListener",
"",
" Licensed to the Apache Software Foundation (... |
derby-DERBY-2486-84178905 | DERBY-2486 Rename SortController.close to completeInserts which better matches its current use
and future use once SortController is used to completely control a sort.
Also some minor protection changes of methods in the sort implementation.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@522280 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/store/access/SortController.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.types.DataValueDescriptor;"
],
"header": "@@ -21,11 +21,8 @@",
"removed": [
"import org.apache.derby.iapi.types.Clon... |
derby-DERBY-2487-48a98847 | DERBY-2487: Enhance Derby with XPLAIN functionality.
This feature was contributed by Felix Beyer (beyer dot felix at gmx dot net).
This feature introduces an alternate handling of runtime statistics
information. Derby can now be configured so that it will capture the
statistics in a machine-readable form and will store them into a set of
simply-structured tables in a schema which is specified by the user. We
call this behavior "XPLAIN style", and we call the tables which are
used the "XPLAIN tables".
Having captured statistics about statement execution, you can then
analyze the statement behavior by querying these tables. For example, you
can determine how much time was taken, what resources were used, what
query plan was chosen, and so on.
This is the initial commit of this new functionality. Subsequent changes
will provide documentation, additional tests, fully-tested upgrade support.
As the community gains more experience with this feature, we will find more
enhancements to make, but the initial commit provides a working feature
with an initial set of basic regression tests.
Many thanks to the community for reviewing the changes through several
iterations of development.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@768597 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/catalog/SystemProcedures.java",
"hunks": [
{
"added": [
"import java.sql.Statement;"
],
"header": "@@ -26,6 +26,7 @@ import java.security.PrivilegedAction;",
"removed": []
},
{
"added": [
"i... |
derby-DERBY-2487-d54fabde | DERBY-2487: Enhance Derby with EXPLAIN Functionality
Updated list of expected functions in TestDbMetaData to contain the
XPLAIN functions.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@768671 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-2488-8fcae923 | DERBY-2488: Patch to ensure that JDBC 4 Pooled and XA connections are returned
from JDBC 3 DataSources if the app is running with Java SE 6. In particular:
1. Adds two methods, "getNewPooledConnection()" and "getNewXAConnection()",
to the Driver30 class and makes those methods return JDBC 3 objects.
2. Overides the two methods from #1 in Driver40 to return JDBC 4 objects.
3. Changes the "createPooledConnection()" method and "createXAConnection()"
methods in EmbeddedConnectionPoolDataSource and EmbeddedXADataSource
(respectively) to call the new methods on the DriverXX object returned
from the existing "findDriver()" method.
4. Removes the now unused "createPooledConnection()" method from
EmbedConnectionionPoolDataSource40, and removes "createXAConnection()"
from EmbedXADataSource40.
5. Changes ClientXADataSource, which had a problem similar to the Embedded
data sources, to match the behavior of ClientConnectionPoolDataSource
so that client now correctly returns JDBC 4 objects for Java SE 6 apps.
6. Includes a new test, jdbc4/JDBC4FromJDBC3DataSourceTest, which verifies
that JDBC 4 connections will be returned from JDBC 3 data sources if the
JDK in use is JDK 1.6.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@531129 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/ClientJDBCObjectFactory.java",
"hunks": [
{
"added": [
"import org.apache.derby.client.ClientXAConnection;"
],
"header": "@@ -22,6 +22,7 @@",
"removed": []
}
]
},
{
"file": "java/client/org/ap... |
derby-DERBY-2493-0b3c2c9d | DERBY-2493 (partial) Use unsynchronized collections in BackingStoreHashtable
Replace Hashtable with HashMap.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@527402 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/store/access/BackingStoreHashtable.java",
"hunks": [
{
"added": [
"import java.util.Collections;",
"import java.util.HashMap;",
"import java.util.Iterator;"
],
"header": "@@ -32,8 +32,10 @@ import org.ap... |
derby-DERBY-2493-1523f049 | DERBY-2493 (partial) Use unsynchronized collections in BackingStoreHashtable
Updated some tests so that they are not sensitive to the order of the
rows in the returned ResultSet.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@523621 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/JDBC.java",
"hunks": [
{
"added": [
" /**",
" * Assert that the ResultSet contains the same rows as the specified",
" * two-dimensional array. The order of the results is ignored. Convert the",
... |
derby-DERBY-2493-bd34a3ac | DERBY-2493: Use unsynchronized collections in BackingStoreHashtable
Store the duplicates in ArrayLists instead of Vectors.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@528374 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/store/access/BackingStoreHashtable.java",
"hunks": [
{
"added": [
"import java.util.ArrayList;",
"import java.util.List;"
],
"header": "@@ -32,12 +32,13 @@ import org.apache.derby.iapi.types.DataValueDescriptor;",... |
derby-DERBY-2498-f9f83296 | DERBY-2498; fix NullPointerException in clientDataSource.getConnection and ClientConnectionPoolDataSource.getConnection when the databaseName is invalid.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@711266 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/net/NetConnection.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.reference.Attribute;"
],
"header": "@@ -33,6 +33,7 @@ import org.apache.derby.shared.common.reference.MessageId;",
"removed": []
... |
derby-DERBY-2500-435c451f | DERBY-2500: Fix PredicateList.orderUsefulPredicates() to recognize when we're
doing a hash join and to explicitly avoid generating probe predicates in that
case. Also re-enable the "testResultSetInOrderWhenUsingIndex()" fixture for
lang/DistinctTest.java and add some additional test cases. Finally, update
comments where appropriate to better explain the need for this restriction
on probe predicates.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@525925 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/PredicateList.java",
"hunks": [
{
"added": [
"\t\t/* If we have a \"useful\" IN list probe predicate we will generate a",
"\t\t * start/stop key for optTable of the form \"col = <val>\", where <val>",
"\t\t ... |
derby-DERBY-2502-031843a0 | DERBY-2502: Fix error in XMLTypeAndOpsTest introduced by ResultSet-closing patch.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@525924 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/JDBC.java",
"hunks": [
{
"added": [
" {",
" assertFullResultSet( rs, expectedRows, allAsTrimmedStrings, true );",
" }",
"",
" /**",
" * Takes a result set and a... |
derby-DERBY-2502-ccce12c3 | DERBY-2502: Add a header comment to XML.java, explaining how to configure your environment so that the XML tests run. Also fix a javadoc warning in BaseJDBCTestCase.java.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@525933 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/XML.java",
"hunks": [
{
"added": [
" * <p>",
" * </p>",
" *",
" * <p>",
" * Note that The XML tests require a more advanced version of Xalan",
" * than the default version bundled ... |
derby-DERBY-2505-38520af2 | DERBY-2505 (partial): Convert derbynet/testij.java to JUnit. Getting an NPE
looking for the test script when running with jars, need to resolve that before
hooking it into the derbynet _Suite.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@525326 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/tools/org/apache/derby/impl/tools/ij/ConnectionEnv.java",
"hunks": [
{
"added": [
"import java.security.AccessController;",
"import java.security.PrivilegedAction;"
],
"header": "@@ -28,6 +28,8 @@ import java.util.Hashtable;",
"remove... |
derby-DERBY-2515-932c26ff | DERBY-2515: Improve exception handling when copying INOUT args.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1087346 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/CallableStatement.java",
"hunks": [
{
"added": [
" ",
" for ( int i = 0; i < cursorParamCount; i++ )",
" {",
" if ( parameterMetaData_.sqlxParmmode_[ i ] == java.sql.Parame... |
derby-DERBY-2516-b98b60ea | DERBY-2516: Network Client allows execution of callable statement when one of the parameters is not set
Check that INOUT parameters are set, not only registered with registerOutParam().
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1428256 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-2519-b224e664 | DERBY-2519: Commit Oystein's derby-2519.diff, cleaning up the BlobClob4BlobTest.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@533785 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-2524-13117b07 | My earlier commit 525568 caused grantRevokeDDL.sql to fail because in TypeDescriptorImpl's equals method, I was comparing the collaiton
type and derivation for non-character datatypes to derive equality. Collation type and derivation should only be checked for character
datatypes. This commit addresses that problem. I ran the derbyall suite and noticed no new test failures because of this patch.
The patch is being tracked as part of DERBY-2524
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@527033 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/catalog/types/TypeDescriptorImpl.java",
"hunks": [
{
"added": [
"\t {",
"\t\t\tswitch (typeId.getJDBCTypeId()) {",
"\t\t\tcase Types.CHAR:",
"\t\t\tcase Types.VARCHAR:",
"\t\t\tcase Types.LONGVARCHAR:"... |
derby-DERBY-2524-7752cf6d | This patch is for DERBY-2524 (DataTypeDescriptor(DTD) needs to have collation type and collation derivation. These new fields will apply
only for character string types. Other types should ignore them.) and it does following 2 things
1)Add collation type and collation derivation attributes and apis to TypeDescriptor interface and it's implementations.
2)Save the collation type in the scale field of character types in writeExternal method of TypeDescriptorImpl. And read the scale field into
the collation type for character types in readExternal method of TypeDescriptorImpl.
svn stat -q
M java\engine\org\apache\derby\iapi\types\DataTypeDescriptor.java
M java\engine\org\apache\derby\catalog\TypeDescriptor.java
M java\engine\org\apache\derby\catalog\types\TypeDescriptorImpl.java
Details of the patch
1)Added getters and setters for collationType and collationDerivation in TypeDescriptor. In addition, TypeDescriptor has new constants
defined in them which will be used by the rest of the collation related code in Derby. One of the constants is COLLATION_DERIVATION_INCORRECT
I am initializing the collation derivation for all the data types to COLLATION_DERIVATION_INCORRECT in TypeDescriptorImpl. This should get
changed to "implicit" or "none" for character string types before the runtime code kicks in. For all the other types, it will remain set to
COLLATION_DERIVATION_INCORRECT because collation does not apply to those data types.
2)DTD implements the new apis in the TypeDescriptor interface.
3)2 set of changes went into
a)TypeDescriptorImpl has 2 new fields, namely, collationType and collationDerivation. collationDerivation is initialized to
TypeDescriptor.COLLATION_DERIVATION_INCORRECT. For character string types, these field should get set correctly. In addition, there are apis
to set and get values out of these 2 fields.
b)The next change for this class is in writeExternal and readExternal methods. I would like community's feedback on my assumption for this
particular change. The collation type of a character string type will get saved in the existing scale field since scale does not apply to
character string types. My question is about collation derivation. The collation derivation infromation does not get saved like collation
type. But may be that is ok because I am assuming that writeExternal and readExternal get called only for the persistent columns (ie columns
belonging to system and user tables). Collation derivation of such character string columns (coming from persistent tables) is always
implicit. And, hence in readExternal, for character string types, I can initialize collation derivation to be implicit. My assumption is
that readExternal and writeExternal methods will never get called for character string types with collation of none or explicit. Today we
don't have explicit as one of the possible values for collation derivation, but a character string type will have the collation derivation
of none if it was the result of an aggregate method involving operands with different collation derivations. This comes from item 11) from
Section Collation Determination section at http://wiki.apache.org/db-derby/BuiltInLanguageBasedOrderingDERBY-1478
Questions
1)I have included all the constant definitions related to collation in TypeDescriptor. If anyone has suggestion on a better place to
define them, let me know. Wonder if there is already a class to define miscellaneous constant definitions like the ones I have added.
TypeDescriptor does look like a good place for these constants defined by me because these constants all belong to the data type world.
2)Is it right to assume that readExternal and writeExternal methods in TypeDescriptorImpl will get called only for persistent columns?
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@525568 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/catalog/TypeDescriptor.java",
"hunks": [
{
"added": [
"\t/**",
"\t For a character string type, the collation derivation should always be ",
"\t \"explicit\"(not possible in Derby 10.3), \"implicit\" or \"none\". We will "... |
derby-DERBY-2524-96a630c7 | Submitting a patch (DERBY2524_Collation_Info_In_DTD_v2_diff.txt) attached to DERBY-2524. This is a followup to the earlier commited patch (DERBY2524_Collation_Info_In_DTD_v1_diff.txt svn revision 525568)
svn stat -q
M java\engine\org\apache\derby\iapi\types\DataTypeDescriptor.java
M java\engine\org\apache\derby\iapi\types\StringDataValue.java
M java\engine\org\apache\derby\catalog\TypeDescriptor.java
M java\engine\org\apache\derby\catalog\types\TypeDescriptorImpl.java
The patch does following to address feedback received on the earlier patch in thread http://www.nabble.com/-jira--Created%3A-%28DERBY-2524%29-DataTypeDescriptor%28DTD%29-needs-to-have-collation-type-and-collation-derivation.-These-new-fields-will-apply-only-for-character-string-types.-Other-types-should-ignore-them.-p9842379.html
1)Moved the constant definitions from TypeDescriptor to StringDataValue.
2)Added javadoc comments for all the constants. One big javadoc comment for one of the constants in the related constants and other
constants in that group will just have a javadoc of @see.
3)I had used string costants for collation derivation since they are more verbose. But that is more expensive than simply using
int. As a middle ground, I have defined collation derivation constants as int but the names of the constants are verbose :)
I also changed the api for collation derivation to work with int rather than String. Finally, changed collationDerivation from
String to int in TypeDescriptorImpl.
4)Rather than using "error" to indicate incorrect collation derivation, we will just initialize collation derivation to "none".
For all character string types, the collation derivation should get changed to "implicit" unless we are working with aggregate
result type of character string type and the operands to the aggregate have different collation types.
5)Currently, I only save collation type of a persistent character string type column into SYSCOLUMNS's COLUMNDATATYPE column. Collation
derivation for such character string type is assumed as "implicit" because that is the only possible option in Derby 10.3 for persistent
columns. But in some future release of Derby, when we will start supporting SQL COLLATE clause, we will want to differentiate between
"explicit" and "implicit" collation derivation for such persistent columns. So, may be it will be good for us to start saving collation
derivation too. For now, I have added this task as a line item under wiki page http://wiki.apache.org/db-derby/BuiltInLanguageBasedOrderingDERBY-1478 under "Performance/Desirable items" section.
6)I caused several javadoc errors for using @see Classname.methodname rather than @see Classname#methodname. Sorry about that. Fixed
those errors in this patch.
I think with this patch, I have taken care of all the feedback received on the earlier patch DERBY2524_Collation_Info_In_DTD_v1_diff.txt.
Again, if anyone has any comment on this committed patch or earlier commit svn revision 525568, please send your feedback on
Derby mailing list.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@525729 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/catalog/TypeDescriptor.java",
"hunks": [
{
"added": [],
"header": "@@ -46,31 +46,6 @@ public interface TypeDescriptor",
"removed": [
"\t/**",
"\t For a character string type, the collation derivation should always be ... |
derby-DERBY-2526-125f9182 | DERBY-4679 Several left outer joins causes unstable query with incorrect results
Patch derby-4679b, which solves the following problem:
When transitive closure generates new criteria into the query, it is
sometimes confused by situations where the same column name appears in
a result column list multiple times due to flattening of sub-queries.
Flattening requires remapping of (table, column) numbers in column
references. In cases where the same column name appears in a result
column list multiple times, this lead to remapping (reassigning) wrong
(table, column) numbers to column references in join predicates
transformed to where clauses as a result of the flattening.
See also DERBY-2526 and DERBY-3023 whose fixes which were partial
solutions to the problem of wrong column number remappings confusing
the transitive closure of search predicates performed by the
preprocessing step of the optimizer.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@952237 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/ColumnReference.java",
"hunks": [
{
"added": [
" /* For remembering original (tn,cn) of this CR during join flattening. */",
" private int tableNumberBeforeFlattening = -1;",
" private int columnNum... |
derby-DERBY-2530-6e48cbee | Committing the patch DERBY2530_create_alter_table_collation_type_v1_diff.txt attached to DERBY-2530. This patch changes alter table and
create table code so that the persistent user defined character types will have collation type of their schema.
svn stat -q
M java\engine\org\apache\derby\impl\sql\compile\AlterTableNode.java
M java\engine\org\apache\derby\impl\sql\compile\CreateTableNode.java
M java\engine\org\apache\derby\iapi\sql\dictionary\SchemaDescriptor.java
This patch includes following changes
1)If a character type is getting added by alter table statement then AlterTable node needs to set the collation type of that character
column to same value as schema descriptor's collation type. Collation derivation of this column will be set to implicit.
2)For all the character columns that get added by create table statement, CreateTable node should set their collation type to same value
as schema descriptor's collation type. Collation derivation of such columns will be set to implicit.
3)Provide a method called getCollationType on SchemaDescriptor so that AlterTable node and CreateTable node can call that method.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@526385 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/AlterTableNode.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.types.StringDataValue;"
],
"header": "@@ -35,6 +35,7 @@ import org.apache.derby.iapi.sql.dictionary.SchemaDescriptor;",
"remove... |
derby-DERBY-2534-0cab10f1 | I am committing an intermediate patch for language based ordering. This patch is also attached to DERBY-2534 as
DERBY2534_getValue_On_StringDataValue_v1_diff.txt. The patch adds a new api to StringDataValue interface and the new api looks as follows
public StringDataValue getValue(RuleBasedCollator collatorForComparison);
The new api will be needed in quite a few different places. 2 distinct uses that I can see at this point are
1)Store will have a format id and collation type when it is trying to construct a DVD template. Using the formatid, we will first
always get the base class DVD for char datatypes namely SQLChar, SQLVarchar, SQLLongvarchar or SQLClob. But, if the collation type
is not 0 ie it is not UCS_BASIC, then we want to use Collation sensitive DVDs of base char DVDs because we want to use the passed
Collator for collation rather than the default UCS_BASIC Collator. The collation sensitive DVDs of char datatypes are CollatorSQLChar,
CollatorSQLVarchar, CollatorSQLLongvarchar and CollatorSQLClob. In order to derive these collation sensitive DVDs of character datatypes,
we will use this new api called getValue on base character DVDs. The getValue method will have the Collator object as parameter to it.
If the Collator object is null, then we can continue to use the base DVD. But if the Collator object is not null, then we want to
construct collation sensitive DVD. The new api on StringDataValue will help achieve this behavior.
2)Another place which I can envision using this new api is in DataTypeDescriptor.getNull() method which returns a DVD. Currently, the
implementation of this method looks as follows
public DataValueDescriptor getNull() {
return typeId.getNull();
}
So, if the typeid of DTD is character data type, this method will always return base char DVD, no matter what is the collation type of
the DTD. But, if the DTD has a territory based collation set for it, then this method should return collation sensitive char DVD. This
functionality can be achieved by using the new api on StringDataValue.
I do not anticipate this new method ever getting called on collation sensitive DVDs in Derby 10.3 In future, when Derby will start
supporting SQL standard COLLATE clause, this method might get called on the collation sensitive DVDs but for Derby 10.3, the new api
in collation sensitive DVDs is just a place holder.
Another change to note is I have changed all the collation sensitive subclasses to have their method setCollator changed from private to
protected. This is so that the getValue method from their correspoding base classes can call the setCollator method on subclasses.
The files changed by this commit are
svn stat -q
M java\engine\org\apache\derby\iapi\types\SQLLongvarchar.java
M java\engine\org\apache\derby\iapi\types\StringDataValue.java
M java\engine\org\apache\derby\iapi\types\CollatorSQLChar.java
M java\engine\org\apache\derby\iapi\types\CollatorSQLClob.java
M java\engine\org\apache\derby\iapi\types\CollatorSQLVarchar.java
M java\engine\org\apache\derby\iapi\types\SQLChar.java
M java\engine\org\apache\derby\iapi\types\SQLClob.java
M java\engine\org\apache\derby\iapi\types\SQLVarchar.java
M java\engine\org\apache\derby\iapi\types\CollatorSQLLongvarchar.java
The code compiles ok with my changes. None of the tests should get impacted because currently, this new api on StringDataValue is
not called by any other code in Derby.
If anyone has any feedback, please let me know.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@526668 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/CollatorSQLChar.java",
"hunks": [
{
"added": [
"\tprotected void setCollator(RuleBasedCollator collatorForCharacterDatatypes)"
],
"header": "@@ -65,7 +65,7 @@ public class CollatorSQLChar extends SQLChar implements Co... |
derby-DERBY-2543-4d83c528 | DERBY-2543: Wrapping the original SystemPropertyTestSetup in a DatabasePropertyTestSetup that shutdowns and restarts the engine allows the new setting for maxMemoryPerTable to be properly set for testVirtualMemoryHeap. Reenabling the test.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@528677 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-2543-9584a612 | DERBY-2543: remove testVirtualMemoryHeap from the nightly runs until it can be fixed.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@528670 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-2546-2d3034fb | DERBY-2546 - avoiding running a section of the test that hits a CharConversionException with JSR169 (weme6.1)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@545846 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-2549-f576b26f | DERBY-2549
contributed by Mayuresh Nirhali
Fix null pointer when running inplace compress. Change code to correctly
handle when more than 100 rows are moved from a single page. The new code
returns to the caller after processing the 100 rows, and the next trip
through the loop picks up the scan where it left off on that same page.
Test case was added to existing test.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@540657 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/access/heap/HeapCompressScan.java",
"hunks": [
{
"added": [
" // only fetch maximum number of rows per \"group\" as the size of",
" // the array. If more than one group is available on page, just",
... |
derby-DERBY-255-43592363 | This fixes DERBY-255
Closing a resultset after retriving BLOB or CLOB data > 32K, does not release locks properly.
Network server/client materializes the LOB on the client and cannot differentiate getBlob from getBytes or getBinaryStream. Previously, network server would always call getBlob/getClob for any lob related call. This change changes network server to use getBytes/getString and not hold locks for any of the calls.
The implementation adds a new class EXTDTAInputStream to network server to localize the stream handling for large objects. This should make it easier to adjust in the future as improvements are made in the large object handling. Because we need a length in order to write a stream, EXTDTAInputStream currently call getBytes or getString to get the length and stream out that object. This is apparently required because we cannot reset the input stream after traversing it to get the length.
Future suggestions for changes to network server to handle this in a more complete way would be to:
1) Change DDMWriter.writeScalarStream to not require a length and optimize EXTDTAObjectInputStream accordingly
2) Add support for lob locators with network server. The getBlob, getClob calls would use the locators and would hold locks until the end of the transaction.
git-svn-id: https://svn.apache.org/repos/asf/incubator/derby/code/trunk@179014 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/DDMWriter.java",
"hunks": [
{
"added": [
"\t// TODO: Rewrite writeScalarStream to avoid passing a length.",
"\t// The length is never written and not required by the DRDA spec.",
"\t// Also looks like on IOException ... |
derby-DERBY-255-a3acaa59 | Add test for verification of DERBY-255 fix that ResultSet.getString(), ResultSet.getCharacterStream(), ResultSet.getBytes(), and ResultSet.getBinaryStream() do not hold locks after the ResultSet is closed.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@554073 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/Utilities.java",
"hunks": [
{
"added": [
" \t/**",
" \t * repeatChar is used to create strings of varying lengths.",
" \t * called from various tests to test edge cases and such.",
" \t *"... |
derby-DERBY-2551-2dabeef0 | DERBY-2551: Global Xid value garbled in syscs_diag.transaction_table
Fix contributed by Julius Stroffek.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@531468 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/store/access/GlobalXact.java",
"hunks": [
{
"added": [
" if (mask < 16) {",
" globalhex += \"0\" + Integer.toHexString(mask);",
" } else {",
" ... |
derby-DERBY-2556-0c41dd14 | DERBY-2556 Code paths for db restore do not use doPrivileged-calls, causing SecurityException
Add priv blocks for File.exists() calls in restore.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@536677 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/monitor/StorageFactoryService.java",
"hunks": [
{
"added": [
"\t\t\tif(privExists(backupRoot))",
"\t\t\t\tif(privExists(bserviceProp))"
],
"header": "@@ -574,11 +574,11 @@ final class StorageFactoryServic... |
derby-DERBY-2556-27c7e012 | DERBY-2556: Replaced tabs with spaces and updated JavaDoc for method privExists.
Patch file: derby-2556-2a_whitespace-javadoc.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@536856 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/monitor/StorageFactoryService.java",
"hunks": [
{
"added": [
" * Wrap {@link File#exists} in a priv block to avoid security exceptions.",
" * <p>",
" * This method allows Derby to check if a file ex... |
derby-DERBY-2556-63b1dd7a | DERBY-2556: Code paths for db restore do not use doPrivileged-calls, causing SecurityException. Modified patch by correcting a few spelling errors of mine and deleted a blank line.
Patch file: derby-2556-4a_alternative-patch.diff (M)
Patch contributed by Kathey Marsden and Kristian Waagan.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@537735 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/monitor/StorageFactoryService.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.util.PrivilegedFileOps;"
],
"header": "@@ -21,6 +21,7 @@",
"removed": []
},
{
"added": [
... |
derby-DERBY-2556-65882228 | DERBY-2556: Code paths for db restore do not use doPrivileged-calls, causing SecurityException.
Removed utility class calling AccessController.doPrivileged, because it is a security hole and it is strongly discouraged by the Java docs.
Adjusted the policy files as the code bases changed when the code moved into different classes.
Patch file: derby-2556-5b-reworked_fix.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@691576 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/DssTrace.java",
"hunks": [
{
"added": [
"import java.security.PrivilegedAction;"
],
"header": "@@ -24,12 +24,10 @@ import java.io.File;",
"removed": [
"import org.apache.derby.iapi.util.PrivilegedFileOp... |
derby-DERBY-2557-57cb9986 | DERBY-2557 : This commit renames getInstanceUsingFormatIdAndCollationType method on DVF to getNull. It also changes the implementation of
the that method so that it bypasses the InstanceGetter. This implementation is much simpler than the old one because there is no
InstanceGetter involved. Lastly, the code associated with getting a DVD from a format id is moved out of DTSClassinfo into a static
method on DataValueFactoryImpl. This static method will be called by DTSClassinfo.
The changes made in the patch are as follows
1)DataValueFactory
Changed the name of the new interface from getInstanceUsingFormatIdAndCollationType to getNull. This interface now returns a DVD rather
than an Object. The functionality of the interface remains the same but the implementation has changed.
2)DataValueFactoryImpl
a)Removed the class level array and the code associated with InstanceGetter.
b)Added a new static method called getNullDVDWithUCS_BASICcollation(int formatId). This static method handles all the format ids associated
with DVDs with the exception of Decimals. The class to be returned for Decimals depends on what VM is being used. This dependency on the VM
is handled by getNullDecimal defined on DVF. But since getNullDecimal is not a static method, it can't be called by static method
getNullDVDWithUCS_BASICcollation. I could go the path of defining getNullDecimal as static but that will require changes in
NumericTypeCompiler.nullMethodName method. Also, all the other getNullXXX on DVF are non-static So, the code for returning the right DVD
for Decimal is not in getNullDVDWithUCS_BASICcollation. Rather it is in the calling method, getNull. For other format ids associated with
DVDs, getNull will check if the DVD is of type StringDataValue and the collation type is territory based and if so, then it will return
((StringDataValue)returnDVD).getValue(getCharacterCollator(collationType));
3)DTSClassInfo
This class now calls the static method in DVF to get the DVDs. But if the format id is not for a DVD, then it checks if it needs to return
TypeId.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@530546 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/DataValueFactoryImpl.java",
"hunks": [
{
"added": [],
"header": "@@ -79,12 +79,6 @@ abstract class DataValueFactoryImpl implements DataValueFactory, ModuleControl",
"removed": [
" \t/** ",
" \t * For p... |
derby-DERBY-2557-d19a66fe | The previous patch for DERBY-2557 (revision 529697) had a bug in it. After getting a collation sensitive DVD, the new method on DVF
(getInstanceUsingFormatIdAndCollationType) was still returning the DVD with UCS_BASIC collation. This patch fixes that problem. More info
on this can be found in DERBY-2557.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@529866 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/DataValueFactoryImpl.java",
"hunks": [
{
"added": [
"\t\t\t\t//return a StringDataValue with territory based collation.",
"\t\t\t\t\treturn ((StringDataValue)returnObject).getValue(getCharacterCollator(collationType));"
... |
derby-DERBY-2559-0b884ead | DERBY-2559: recreating a datasource using javax.naming.Reference from a ClientDataSource40 fails.
A followup patch to avoid throwing an exception when the input arguments are not as expected. The point is to allow another factory to try recreating the object, which will not happen if an exception is thrown. Null will now be returned for null objects and objects whose class does not start with "org.apache.derby.jdbc.Client".
Patch file: derby-2559-2a-defenses.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@628647 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/ClientDataSourceFactory.java",
"hunks": [
{
"added": [
" Object ds = null;",
" if (refObj instanceof javax.naming.Reference) {",
" javax.naming.Reference ref = (javax.naming.Reference) refObj;... |
derby-DERBY-2559-a8d30d78 | DERBY-2559: recreating a datasource using javax.naming.Reference from a ClientDataSource40 fails. Incremental commit, which enables the factory to create all Derby (client) datasources. However, some mechanisms to avoid throwing exceptions must be added, for instance if a null object is passed. The test that was disabled has been enabled again.
Patch file: derby-2559-1a.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@617492 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/ClientDataSourceFactory.java",
"hunks": [
{
"added": [],
"header": "@@ -26,11 +26,6 @@ import java.util.Enumeration;",
"removed": [
"import org.apache.derby.jdbc.ClientBaseDataSource;",
"",
"import org... |
derby-DERBY-2559-af931719 | DERBY-2559: recreating a datasource using javax.naming.Reference from a ClientDataSource40 fails.
Documentation / JavaDoc changes (contents and formatting).
Patch file: derby-2559-3b-documentation.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@628654 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/ClientDataSourceFactory.java",
"hunks": [
{
"added": [
" * The data source factory for Derby client driver data sources.",
" * <p>",
" * This factory reconstructs a Derby data source object when it is retrieved",
... |
derby-DERBY-2560-fc87a439 | DERBY-2560 Missing asserts in ProcedureInTriggerTest
fix missing asserts and enable for network server.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@529801 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-2564-6d8a24d9 | DERBY-2564 calls to Thread.interrupt need privilege blocks
Changed calls to Thread.interrupt to occur in privilege blocks.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@595861 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/NetworkServerControlImpl.java",
"hunks": [
{
"added": [
"import java.security.PrivilegedAction;"
],
"header": "@@ -42,6 +42,7 @@ import javax.net.ssl.SSLServerSocketFactory;",
"removed": []
},
{
... |
derby-DERBY-2569-2bb198ae | DERBY-2569 Basically, this commit moves the logic for comparable method from various TypeCompiler implementations into DTD. This is because
now we need collation information also to determine if 2 types are comparable or not and that information is not available to TypeCompilers.
In addition, ofcourse, all the callers of TypeCompiler's comparable method now call DTD.comparable.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@530910 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/DataTypeDescriptor.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.reference.JDBC30Translation;"
],
"header": "@@ -42,6 +42,7 @@ import org.apache.derby.iapi.services.loader.ClassFactory;",
"remov... |
derby-DERBY-2569-2d32bab3 | This is more of a code cleanup for DERBY-2569.
Rather than using switch statement to check for individual format ids, this patch uses isXXX methods wherever applicable to determine if two
types are comparable or not. This is because with format id checking, in future, when say another numeric type is added, we will have to
modify the switch statement to look for that new numeric type's format id. Instead, if we check for isXXX() method, then the formatid checks
won't have to be maintained because the new numeric type will fall into existing isXXX() umbrella.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@532627 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/DataTypeDescriptor.java",
"hunks": [
{
"added": [
"\t\t// Long types cannot be compared. ",
"\t\t// XML types also fall in this window",
"\t\t// Says SQL/XML[2003] spec:",
"\t\t// 4.2.2 XML comparison an... |
derby-DERBY-2570-286c99fc | DERBY-2570: Improve error reporting for release note generator--now it buffers up problems detected while parsing the individual notes. This is better than failing on the first bad note.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@547969 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/build/org/apache/derbyBuild/ReleaseNotesGenerator.java",
"hunks": [
{
"added": [
" private ArrayList _errors;"
],
"header": "@@ -216,6 +216,7 @@ public class ReleaseNotesGenerator extends Task",
"removed": []
},
{
... |
derby-DERBY-2570-2981b190 | DERBY-2570: Create a lint tool which people can use to satisfy themselves that their release notes can be digested by the release note generator.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@547982 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/build/org/apache/derbyBuild/ReleaseNotesGenerator.java",
"hunks": [
{
"added": [
" private ReleaseNoteReader _releaseNoteReader;"
],
"header": "@@ -214,6 +214,7 @@ public class ReleaseNotesGenerator extends Task",
"removed": []
}... |
derby-DERBY-2570-3455c754 | DERBY-2570: adding the JiraConnector.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@547965 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/build/org/apache/derbyBuild/JiraConnector.java",
"hunks": [
{
"added": [
"/*",
"",
" Derby - Class org.apache.derbyBuild.JiraConnector",
"",
" Licensed to the Apache Software Foundation (ASF) under one or more",
" ... |
derby-DERBY-2570-3a7cee20 | DERBY-2570: In the summary section, treat <releaseID/> and <previousReleaseID/> as variables which the ReleaseNotesGenerator substitutes with appropriate values.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@548432 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/build/org/apache/derbyBuild/ReleaseNotesGenerator.java",
"hunks": [
{
"added": [
" replaceVariables( gs );"
],
"header": "@@ -381,6 +381,7 @@ public class ReleaseNotesGenerator extends Task",
"removed": []
},
{
"a... |
derby-DERBY-2570-4c14d1b0 | DERBY-2570: Construct nice link text from summary paragraphs which have interesting markup in them.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@548781 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/build/org/apache/derbyBuild/ReleaseNoteReader.java",
"hunks": [
{
"added": [
" Element summary = me.getReleaseNoteSummary( doc );"
],
"header": "@@ -105,7 +105,7 @@ public class ReleaseNoteReader",
"removed": [
... |
derby-DERBY-2570-994a2959 | DERBY-2570: Make the release note generator report notes which have badly formatted summaries.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@547957 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/build/org/apache/derbyBuild/ReleaseNotesGenerator.java",
"hunks": [
{
"added": [
" String summary = getReleaseNoteSummary( issue, releaseNote );"
],
"header": "@@ -622,7 +622,7 @@ public class ReleaseNotesGenerator extends Task",
... |
derby-DERBY-2579-1b482f44 | DERBY-2579: AssertFailure class should use JDK's built-in chaining of exceptions
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@531822 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/shared/org/apache/derby/shared/common/sanity/AssertFailure.java",
"hunks": [
{
"added": [],
"header": "@@ -34,8 +34,6 @@ import java.io.*;",
"removed": [
"\tprivate Throwable nestedException;",
""
]
},
{
"added": [... |
derby-DERBY-258-4d80643f | Fix DERBY-258 - Changes to parse the signature in the context of the parameter types of the function or procedure.
Ensures declared signature Java types are mappable to the parameter types, as specified in the SQL2003 spec part 13
Checks for various invalid formats as well.
git-svn-id: https://svn.apache.org/repos/asf/incubator/derby/code/trunk@190508 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/MethodCallNode.java",
"hunks": [
{
"added": [
"import java.util.StringTokenizer;"
],
"header": "@@ -56,6 +56,7 @@ import org.apache.derby.catalog.types.RoutineAliasInfo;",
"removed": []
},
{
... |
derby-DERBY-2581-e7d2a423 | DERBY-2581: Callers of SanityManager.THROWASSERT should chain the exceptions when possible
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@531827 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/BinaryDecimal.java",
"hunks": [
{
"added": [
"\t\t\t\tSanityManager.THROWASSERT(se);"
],
"header": "@@ -167,7 +167,7 @@ abstract class BinaryDecimal extends NumberDataType",
"removed": [
"\t\t\t\tSan... |
derby-DERBY-2583-869152fa | DERBY-2335
Made changes such that rather than having a new method in BaseTypeCompiler to push the DVD on the stack at code generation time, we use the
existing method that accomplishes the same task in ExpressionClassBuilder. The junit tests have run fine with these changes and the stack
trace experienced by Army in DERBY-2335 has been fixed by this fix. The reason for stack trace was that the lifetime of a BaseTypeCompiler
is longer than a single class generation and I was trying to hold a reference to a declared method from MethodBuilder.describeMethod across
the generated classes. This discussion can be found at
http://www.nabble.com/DERBY-1478-subtask-DERBY-2583---need-help-in-debugging-stack-trace-thrown-during-code-generation-p10611184.html
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@538325 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/compile/TypeCompiler.java",
"hunks": [
{
"added": [
"import org.apache.derby.impl.sql.compile.ExpressionClassBuilder;"
],
"header": "@@ -25,6 +25,7 @@ import org.apache.derby.iapi.services.loader.ClassFactory;",
... |
derby-DERBY-2583-ba7683ca | DERBY-2583 This commit mainly addresses how code generation should account for collation type when generating DVDs for character types. In
the past, there was one to one correspondance between a character DTD and the corresponding DVD that got generated for it. Starting
Derby 10.3, a DTD associated with a character type can generate one of the 2 different kinds of DVDs and the DVD chosen will depend on the
collation type of the DTD. Note that this applies only to character types.
Character types that will have a collation of UCS_BASIC associated with them will continue to generate what was generated in Derby 10.2 ie
SQLChar/SQLVarchar/SQLLongvarchar/SQLClob. But the character types that will have collation type of territory based associated with them
will now generate CollatorSQLChar/CollatorSQLVarchar/CollatorSQLLongvarchar/CollatorSQLClob. This dependency of DVD type on collation type
will be handled in classes ExpressionClassBuilder and in TypeCompiler implementations.
CastNode, ConstantNode, NotNode, ResultColumn, SpecialFunctionNode, JavaToSQLValueNode, UnaryComparisonOperatorNode, UserTypeConstantNode,
CurrentDatetimeOperatorNode, CurrentRowLocationNode, CoalesceFunctionNode, ConcatenationOperatorNode, ResultColumnList : All of
these compile time classes require code generation of DVDs. These classes now need to pass the collation type of the DTD for which a DVD
needs to be generated. This collation type will be used to generate code for correct DVD.
The actual changes for generating the correct DVD went into CLOBTypeCompiler and CharTypeCompiler. These 2 classes will first generate a
DVD for character types w/o taking the collation type into consideration. Then it will call a new method which is defined on the base class
BaseTypeCompiler and that new method is called generateCollationSensitiveDataValue. This new method will check if the collation type is
UCS_BASIC and if yes, then it will simply return because we have already generated code for DVD with collation type of UCS_BASIC. But if
the collation type is territory based, then it will generate the additional code of
DVDwithUCS_BASIC.getValue(DVF.getCharacterCollator(collationType));
This generated code will make sure that the DVD generated has territory based collator associated with it and the new DVD class will be of
type CollatorSQLChar/CollatorSQLVarchar/CollatorSQLLongvarchar/CollatorSQLClob. In order to generate the additional code above, we need to
have DVF on the stack. This pusing of DVF on stack will be done by the private method pushDataValueFactory defined on BaseTypeCompiler
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@532082 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/compile/TypeCompiler.java",
"hunks": [
{
"added": [],
"header": "@@ -27,7 +27,6 @@ import org.apache.derby.iapi.services.compiler.MethodBuilder;",
"removed": [
"import org.apache.derby.iapi.types.DataValueDescriptor;"
... |
derby-DERBY-2584-01c5d899 | DERBY-2584: Creating a database with JPOX SchemaTool sometimes gives
ArrayIndexOutOfBoundsException when getIndexInfo() is called
Make sure meta-data queries are properly written to the database when
the first attempt to compile them fails with a lock timeout.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@536516 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/dictionary/SPSDescriptor.java",
"hunks": [
{
"added": [
"\t\t\t\t// DERBY-2584: If the first attempt to compile the query fails,",
"\t\t\t\t// we need to reset initiallyCompilable to make sure the",
"\t\t\t\t// prep... |
derby-DERBY-2594-763e014e | DERBY-2594: Revoking a privilege from an SQL Object should invalidate
statements dependent on that object
Patch contributed by Dyre Tjeldvoll.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@536767 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/dictionary/ViewDescriptor.java",
"hunks": [
{
"added": [
"",
"\t\t\t\t// When REVOKE_PRIVILEGE gets sent to a",
"\t\t\t\t// TablePermsDescriptor we must also send",
"\t\t\t\t// INTERNAL_RECOMPILE_REQUEST t... |
derby-DERBY-2595-d18c1af6 | DERBY-2595: JUnit tests use getExportedKeys with table name null
Rewrote invalid usage of DatabaseMetaData.getExportedKeys() in
JDBC.dropSchema().
Contributed by Jørgen Løland.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@533175 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/JDBC.java",
"hunks": [
{
"added": [
" ResultSet table_rs = dmd.getTables((String) null, schema, (String) null,",
" new String[] {\"TABLE\"});",
"",
" while (table_rs.next(... |
derby-DERBY-2599-2364fd8e | DERBY-2599
Committing changes explained by following paragraphs
DataTypeDescriptor has a method called getDominantType which compares itself with the DTD passed as parameter to getDominantType and creates a new DTD with the dominant type of the 2 DTDs, But, while doing so, It was not setting the collation information on the new DTD based on the 2 involved DTDs. I have made changes into the method which now will set the correct collation information on the new DTD. The algorithm, as copied from the method javadoc, is as follows
* If dealing with character string types, then make sure to set the
* collation info on the dominant type. Following algorithm will be used
* for dominant DTD's collation determination. Each of the steps of the
* algorithem have been numbered in the comments below and those same
* numbers are used in the actual algorithm below so it is easier to
* understand and maintain.
*
* Step 1
* If the DTD for "this" node has the same collation derivation as the
* otherDTS, then check if their collation types match too. If the
* collation types match too, then DTD for dominant type will get the same
* collation derivation and type.
*
* Step 2
* If the collation derivation for DTD for "this" node and otherDTS do not
* match, then check if one of them has the collation derivation of NONE.
* If that is the case, then dominant DTD will get the collation type and
* derivation of DTD whose collation derivation is not NONE.
*
* Step 3
* If the collation derivation for DTD for "this" node and otherDTS do not
* match, and none of them have the derivation of NONE then it means that
* we are dealing with collation derivation of IMPLICIT and EXPLICIT and
* hence the dominant DTD should get collation derivation of NONE. This is
* not a possibility in Derby 10.3 because the only 2 possible collation
* derivation supported are IMPLICIT and NONE.
*
* Step 4
* If the collation derivation for DTD for "this" node and otherDTS match,
* then check if the collation types match too. If not, then the dominant
* DTD should get collation derivation of NONE.
Now, note that ValueNodeList has a method called getDominantTypeServices where it could deal with any number of DTDs to determine the dominant DTD. It calls DataTypeDescriptor.getDominantType on 2 DTDs at a time. At the beginning, the 2 DTDs are the first two in it's vector. It gets an intermediate dominantDTS back for those 2 DTDs. Next, it calls DataTypeDescriptor.getDominantType with the intermediate dominantDTS and the 3rd element in it's vector and so on and so forth. It is not enough to just use 2 DTDs at a time to determine the collation info for the final dominantDTS. We need to consider all the DTDs in the vector together to determine the correct collation info for the final dominantDTS. The algorithm used by ValueNodeList.getDominantTypeServices is in that method's javadoc and included here for reference
* Algorithm for determining collation information
* This method will check if it is dealing with character string datatypes.
* If yes, then it will check if all the character string datatypes have
* the same collation derivation and collation type associated with them.
* If not, then the resultant DTD from this method will have collation
* derivation of NONE. If yes, then the resultant DTD from this method will
* have the same collation derivation and collation type as all the
* character string datatypes.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@545706 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/DataTypeDescriptor.java",
"hunks": [
{
"added": [
"\t * ",
"\t * If dealing with character string types, then make sure to set the",
"\t * collation info on the dominant type. Following algorithm will be used ",
... |
derby-DERBY-2599-244952e1 | DERBY-2599
Commiting patch attached to DERBY2599_Set_collation_for_aggregates_v1_diff.txt which does the job of setting the correct collation type and
derivation for aggregates. As per SQL standard, if the operands of the aggregate methods are string operands and they do not all have the
same collation derivaiton and type on them, then the resultant string operand will have collation derivaiton of NONE. One thing that is
missing is as per SQL spec, in a comparison operator, as far as there is one operand with non-NONE collation derivation, the comparison
should work. I do not have that part working yet. If the two operands of the comparison operator do not have the same collation, the
comparison will fail. Also, if both the sides of the comparison operator have NONE collation, the current DERBY10.3 code will not catch
that. Both of these issues can go as a subsequent patch.
The aggregate methods that are covered by the patch are COALESCE, CONCATENATE, NULLIF, CASE
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@540201 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/DataTypeDescriptor.java",
"hunks": [
{
"added": [
"\t\t\t\t\t\t\t\t\t\t\t\tmaximumWidth,",
"\t\t\t\t\t\t\t\t\t\t\t\tsource.getCollationType(),",
"\t\t\t\t\t\t\t\t\t\t\t\tsource.getCollationDerivation());"
... |
derby-DERBY-2599-68f9f47a | DERBY-2599
Committing patch DERBY2599_getNull_should_set_collation_info_v1_diff.txt attached to DERBY-2599. This address the correct collation setting
for ConstantNode created through QueryTreeNode's getNullNode method. This method currently creates a ConstantNode using the passed typeId.
We need to set the correct collation type and derivation on this ConstantNode. This is accomplished by having the caller of this method
pass the correct collation type and derivation. The junit tests have run fine with no problems. derbyall is almost finished with no new
failures.
In addition to the above change, this patch also fixes some comments in DataTypeDescriptor.java and TypeDescriptorImpl.java
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@540667 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/AggregateNode.java",
"hunks": [
{
"added": [
"\t\t\t\tcompTypeId,",
"\t\t\t\tgetContextManager(),",
"\t\t\t\tgetTypeServices().getCollationType(),",
"\t\t\t\tgetTypeServices().getCollationDerivatio... |
derby-DERBY-2599-f63b7da8 | DERBY-2599
There are few character string types that should take their collation type from compilation schema. I had earlier checked in code for them
to use current schema rather than compilation schema (For reference http://www.nabble.com/more-on-system-schema-vs.-user-schema-and-character-constants.-p10885286.html)
With this commit, I am adding an utility method in ValueNode called setCollationUsingCompilationSchema(int) which will use the compilation
schema's collation type for it's DTD. And it will use the passed int value to set its DTD's collation derivation. This utility method will
be used by the subclasses of ValueNode to set their DTD's collation type to compilation schema's type wherever required. Note that NOT all the
character string types take their collation from the compilation schema. For instance, persistent character string type column from a
table will take the collation type from the schema their table belongs to rather than the compilation schema.
I have run the 2 collation related tests, CollationTest and CollationTest2 and they run with no problems.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@543266 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/BinaryOperatorNode.java",
"hunks": [
{
"added": [
"\t\t\t//collation of ? operand should be same as the compilation schema",
"\t\t\tleftOperand.setCollationUsingCompilationSchema("
],
"header": "@@ -31... |
derby-DERBY-2599-fc245d8f | DERBY-2599
Committing the patch DERBY2599_correct_collation_for_cast_v1_diff.txt attached to DERBY-2599 which will ensure that when an operand is
CASTed to string datatype, the result type will take the collation of the current schema. So, if current schema is user schema for a
database with territory based collation, then a comparison between a persistent character column from system table and a constant character
string will fail because persistent character column from system table will have the collation of UCS_BASIC but the constant character
string will pick up it's collation from current schema which is user schema and hence the collation will be territory based. Since the 2
collations don't match, we will get a compilation error for the query. To get around this, a user can rewrite the query to CAST persistent
character column from system table to one of the character types and that resultant character type will pickup it's collation from current
schema, so now both the operands will have collation of territory based and the query will execute without collation mismatch failure.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@539060 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-2601-b54db0f3 | DERBY-2601: Server SQLException error codes are not returned to client
Encode the error code in the SQLCODE value sent from the server. This
value used to be -1 for all errors, but the client was OK with any
negative value. Now it's a negative value equal to -(errorCode+1).
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1346833 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/SQLExceptionFactory40.java",
"hunks": [
{
"added": [
" } else if (sqlState.startsWith(SQLState.CONNECTIVITY_PREFIX)) {"
],
"header": "@@ -64,8 +64,7 @@ public class SQLExceptionFactory40 extends SQLExceptionFact... |
derby-DERBY-2602-bead0abc | DERBY-2602: Allow full JDBC nanosecond-precision in timestamps across the network just as is done in the embedded scenario.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@933726 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/DateTime.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.reference.DRDAConstants;"
],
"header": "@@ -22,6 +22,7 @@ package org.apache.derby.client.am;",
"removed": []
},
{
"adde... |
derby-DERBY-2605-d25aee08 | DERBY-2605: Patch to add compile-time checking of columns created from a
"CREATE TABLE AS ... WITH NO DATA" statement, to ensure that the resultant
table only includes columns with types that a user can create him/herself.
In particular this blocks indirect creation of BOOLEAN columns, Object
columns, and DECIMAL columns with precision greater than 31.
Contributed by: James F. Adams (derby@xemaps.com)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@539164 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/CreateTableNode.java",
"hunks": [
{
"added": [
"\t\t\t\t{",
"\t\t\t\t\tcontinue;"
],
"header": "@@ -297,8 +297,8 @@ public class CreateTableNode extends DDLStatementNode",
"removed": [
... |
derby-DERBY-2607-920fea50 | DERBY-2607 DatabaseMetaData is not consistent about throwing SqlException when tablename=null
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@548251 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/DatabaseMetaData.java",
"hunks": [
{
"added": [
" // validate the table name ",
" if (table == null) {",
" throw new SqlException(agent_.logWriter_,",
" new C... |
derby-DERBY-2610-9078aae5 | DERBY-2610: Queries in metadata.properties allow tablepattern for JDBC methods that do not allow patterns. Patterns are now disallowed, except for in one of the queries (see Jira issue for details).
Patch file: DERBY-2610-1.diff
Patch contributed by Jørgen Løland.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@538072 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-2610-fde4b69a | DERBY-2758: Update ODBCMetadataGenerator to create an ODBC version of the
getCrossReference metadata query. This is required because, as of DERBY-2610,
the JDBC version of that query no longer allows pattern matching on table
names. Since the ODBC SQLForeignKeys function, which is mapped onto the
getCrossReference metadata query, depends on pattern matching for correct
behavior, we now create an ODBC-version of getCrossReference that allows
pattern matching as in pre-10.3 releases. The SQLForeignKeys function is
then mapped to the new, ODBC-specific version of the query.
Contributed by: Jorgen Loland (jorgen.loland@sun.com)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@545321 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/build/org/apache/derbyBuild/ODBCMetadataGenerator.java",
"hunks": [
{
"added": [
"\t// Types of changes that are possible. There are four",
"\t//\t2. Where clause:",
"\t//\t\tChange the where clause of the query. For ex. ",
"\t//\t\tused... |
derby-DERBY-2611-0ba46a7f | DERBY-2611
Fixed upgrade test when run against 10.3 to not try and use in place compress
in version 10.0. This feature was added in 10.1.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@535429 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-2612-9ba17d84 | DERBY-2612 - making running of DatabaseMetaDataTest in upgrade test more selective - not all fixtures can be run with all older versions.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@537728 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-2613-c243be14 | DERBY-2613
Upgrade of 10.0 to 10.3 was failing because system procedures were being
created, and as part of the creation some updates were attempted to catalogs
that were not created yet. Fixed in full upgrade by first creating the
new system catalogs and then creating the procedures.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@535466 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/catalog/DD_Version.java",
"hunks": [
{
"added": [
" if (fromMajorVersionNumber <= DataDictionary.DD_VERSION_DERBY_10_1)",
" {",
" // add catalogs 1st, subsequent procedure adding may depend ... |
derby-DERBY-2616-765b3e42 | DERBY-2616
Increase the maximum wait time for tests that start the server. On my
windows XP system I would get intermittent failures at the old 60 second
max. I believe the issue is turnaround time on the port, rather than a
specific startup issue in the code. Setting the max to 300 seconds allowed
me to pass a complete nightly test and also passed a reiterated test 30 times
that would previously fail every time at the 60 second level.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@535572 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/NetworkServerTestSetup.java",
"hunks": [
{
"added": [
" /** Setting maximum wait time to 300 seconds. For some systems it looks",
" * like restarting a server to listen on the same port is blocked waiting",
... |
derby-DERBY-2618-685a1474 | DERBY-2618 (partial) Make ClobAsciiStream honour the contract for OutputStream.write(int) by ignoring
top 24 bits. Optimize ClobAsciiStream by re-using an array rather than recreating one for each write(byte[]) call.
Fix ClobStreamControl to correctly process a Derby UTF8 encoded stream.
Does not fix the issue, fixes are being worked on by others under related bugs.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@538311 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/ClobAsciiStream.java",
"hunks": [
{
"added": [
"/**",
" * Wrap a Writer as an OutputStream to support Clob.setAsciiStream().",
" * Any value written to the OutputStream is a valid ASCII value",
" * (0-255... |
derby-DERBY-2620-bff53129 | DERBY-1025 / DERBY-2620 test cases
Make sure statement is created with holdability CLOSE_CURSORS_AT_COMMIT when testing if xa_start commits the transaction. Exempt embedded from running DERBY-1025 test because of 08003 - No current connection
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@535973 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-2631-e3bd4bbd | DERBY-2631: Expose existing auto-generated key functionality through more JDBC
APIs in embedded mode.
1. Updates the following JDBC methods so that they no longer throw a "Feature
not implemented" error in embedded mode. Instead they make calls to an
already existing internal method and pass in the appropriate arguments:
Connection.prepareStatement(String sql, String[] columnNames);
Connection.prepareStatement(String sql, int[] columnIndexes);
Statement.execute(String sql, String[] columNames);
Statement.execute(String sql, int[] columIndexes);
Statement.executeUpdate(String sql, String[] columnNames);
Statement.executeUpdate(String sql, int[] columnIndexes);
2. Changes the (already existing but not currently used) code in
sql/execute/InsertResultSet that handles autogen column indexes/names
to throw an error for any target column that is not an auto-increment
column. This is because Derby's implementation of getGeneratedKeys()
internally maps to the IDENTITY_VAL_LOCAL() function, which only returns
keys for identity (autoincrement) columns. So if the user specifies
something else, we'll throw an error.
3. Changes the names of two existing (but unused) errors to more accurately
reflect their intended use (they are now called by the changes for #2).
Also changes the text for those errors as the old text seemed a tad
awkward. No regression impact here because the two errors in question
were never exposed to users before now.
4. Makes a slight change to jdbcapi/statementJdbc30.java (a test) to
reflect the new behavior (we no longer throw "Feature not implemented"
errors).
5. Adds test cases for the newly supported APIs to the JUnit test
lang/AutoGenJDBC30Test.java. This involved adding two more utility
methods to junit/BaseJDBCTestCase.java, as well.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@538260 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedConnection.java",
"hunks": [
{
"added": [
"\t * @exception SQLException Thrown on error.",
" \t\treturn prepareStatement(sql,",
"\t\t\tJDBC20Translation.TYPE_FORWARD_ONLY,",
"\t\t\tJDBC20Translatio... |
derby-DERBY-2632-af9a4394 | DERBY-2632 - attempt to fix some failing upgrade tests with JSR169 by preventing them from running.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@536598 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-2635-e257b0e2 | DERBY-2635: intermittent failure in T_RawStoreFactory unit test
Disabled the interrupter thread which sometimes caused stray
interrupts in sane builds.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@537409 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/unitTests/store/T_Util.java",
"hunks": [
{
"added": [
"\t * Check that it's not possible to get a page which is already latched by",
"\t * the same transaction."
],
"header": "@@ -1132,7 +1132,8 @@ public class... |
derby-DERBY-2653-aadfc186 | DERBY-2653 (partial)Expose existing auto-generated key functionality through more JDBC APIs in Derby Client.
Enables API's that take columnNames.
Connection.prepareStatement(String sql, String[] columnNames);
Statement.execute(String sql, String[] columNames);
Statement.executeUpdate(String sql, String[] columnNames);
To get generated keys, user must specify an array of one column name, which
should be the identity column. Client actually ignores the contents at this
time.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@629171 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/Connection.java",
"hunks": [
{
"added": [],
"header": "@@ -1634,7 +1634,6 @@ public abstract class Connection implements java.sql.Connection,",
"removed": [
" checkAutoGeneratedKeysParameters(autoGeneratedKeys, ... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.