idx int64 | func_before string | Vulnerability Classification string | vul int64 | func_after string | patch string | CWE ID string | lines_before string | lines_after string |
|---|---|---|---|---|---|---|---|---|
13,100 | BaseShadow::jobWantsGracefulRemoval()
{
bool job_wants_graceful_removal = false;
ClassAd *thejobAd = getJobAd();
if( thejobAd ) {
thejobAd->LookupBool( ATTR_WANT_GRACEFUL_REMOVAL, job_wants_graceful_removal );
}
return job_wants_graceful_removal;
}
| DoS Exec Code | 0 | BaseShadow::jobWantsGracefulRemoval()
{
bool job_wants_graceful_removal = false;
ClassAd *thejobAd = getJobAd();
if( thejobAd ) {
thejobAd->LookupBool( ATTR_WANT_GRACEFUL_REMOVAL, job_wants_graceful_removal );
}
return job_wants_graceful_removal;
}
| @@ -1141,7 +1141,7 @@ BaseShadow::log_except(const char *msg)
bool exception_already_logged = false;
if(!msg) msg = "";
- sprintf(event.message, msg);
+ sprintf(event.message, "%s", msg);
if ( BaseShadow::myshadow_ptr ) {
BaseShadow *shadow = BaseShadow::myshadow_ptr; | CWE-134 | null | null |
13,101 | BaseShadow::logEvictEvent( int exitReason )
{
struct rusage run_remote_rusage;
memset( &run_remote_rusage, 0, sizeof(struct rusage) );
run_remote_rusage = getRUsage();
switch( exitReason ) {
case JOB_CKPTED:
case JOB_NOT_CKPTED:
case JOB_KILLED:
break;
default:
dprintf( D_ALWAYS,
"logEvictEvent with unknown reason (%d), aborting\n",
exitReason );
return;
}
JobEvictedEvent event;
event.checkpointed = (exitReason == JOB_CKPTED);
event.run_remote_rusage = run_remote_rusage;
/*
we want to log the events from the perspective of the user
job, so if the shadow *sent* the bytes, then that means the
user job *received* the bytes
*/
event.recvd_bytes = bytesSent();
event.sent_bytes = bytesReceived();
if (!uLog.writeEvent (&event,jobAd)) {
dprintf (D_ALWAYS, "Unable to log ULOG_JOB_EVICTED event\n");
}
}
| DoS Exec Code | 0 | BaseShadow::logEvictEvent( int exitReason )
{
struct rusage run_remote_rusage;
memset( &run_remote_rusage, 0, sizeof(struct rusage) );
run_remote_rusage = getRUsage();
switch( exitReason ) {
case JOB_CKPTED:
case JOB_NOT_CKPTED:
case JOB_KILLED:
break;
default:
dprintf( D_ALWAYS,
"logEvictEvent with unknown reason (%d), aborting\n",
exitReason );
return;
}
JobEvictedEvent event;
event.checkpointed = (exitReason == JOB_CKPTED);
event.run_remote_rusage = run_remote_rusage;
/*
we want to log the events from the perspective of the user
job, so if the shadow *sent* the bytes, then that means the
user job *received* the bytes
*/
event.recvd_bytes = bytesSent();
event.sent_bytes = bytesReceived();
if (!uLog.writeEvent (&event,jobAd)) {
dprintf (D_ALWAYS, "Unable to log ULOG_JOB_EVICTED event\n");
}
}
| @@ -1141,7 +1141,7 @@ BaseShadow::log_except(const char *msg)
bool exception_already_logged = false;
if(!msg) msg = "";
- sprintf(event.message, msg);
+ sprintf(event.message, "%s", msg);
if ( BaseShadow::myshadow_ptr ) {
BaseShadow *shadow = BaseShadow::myshadow_ptr; | CWE-134 | null | null |
13,102 | BaseShadow::logTerminateEvent( int exitReason, update_style_t kind )
{
struct rusage run_remote_rusage;
JobTerminatedEvent event;
MyString corefile;
memset( &run_remote_rusage, 0, sizeof(struct rusage) );
switch( exitReason ) {
case JOB_EXITED:
case JOB_COREDUMPED:
break;
default:
dprintf( D_ALWAYS,
"UserLog logTerminateEvent with unknown reason (%d), aborting\n",
exitReason );
return;
}
if (kind == US_TERMINATE_PENDING) {
float float_value;
int exited_by_signal = FALSE;
int exit_signal = 0;
int exit_code = 0;
getJobAdExitedBySignal(jobAd, exited_by_signal);
if (exited_by_signal == TRUE) {
getJobAdExitSignal(jobAd, exit_signal);
event.normal = false;
event.signalNumber = exit_signal;
} else {
getJobAdExitCode(jobAd, exit_code);
event.normal = true;
event.returnValue = exit_code;
}
/* grab usage information out of job ad */
if( jobAd->LookupFloat(ATTR_JOB_REMOTE_SYS_CPU, float_value) ) {
run_remote_rusage.ru_stime.tv_sec = (int) float_value;
}
if( jobAd->LookupFloat(ATTR_JOB_REMOTE_USER_CPU, float_value) ) {
run_remote_rusage.ru_utime.tv_sec = (int) float_value;
}
event.run_remote_rusage = run_remote_rusage;
event.total_remote_rusage = run_remote_rusage;
/*
we want to log the events from the perspective of the user
job, so if the shadow *sent* the bytes, then that means the
user job *received* the bytes
*/
jobAd->LookupFloat(ATTR_BYTES_SENT, event.recvd_bytes);
jobAd->LookupFloat(ATTR_BYTES_RECVD, event.sent_bytes);
event.total_recvd_bytes = event.recvd_bytes;
event.total_sent_bytes = event.sent_bytes;
if( exited_by_signal == TRUE ) {
jobAd->LookupString(ATTR_JOB_CORE_FILENAME, corefile);
event.setCoreFile( corefile.Value() );
}
if (!uLog.writeEvent (&event,jobAd)) {
dprintf (D_ALWAYS,"Unable to log "
"ULOG_JOB_TERMINATED event\n");
EXCEPT("UserLog Unable to log ULOG_JOB_TERMINATED event");
}
return;
}
run_remote_rusage = getRUsage();
if( exitedBySignal() ) {
event.normal = false;
event.signalNumber = exitSignal();
} else {
event.normal = true;
event.returnValue = exitCode();
}
event.run_remote_rusage = run_remote_rusage;
event.total_remote_rusage = run_remote_rusage;
/*
we want to log the events from the perspective of the user
job, so if the shadow *sent* the bytes, then that means the
user job *received* the bytes
*/
event.recvd_bytes = bytesSent();
event.sent_bytes = bytesReceived();
event.total_recvd_bytes = prev_run_bytes_recvd + bytesSent();
event.total_sent_bytes = prev_run_bytes_sent + bytesReceived();
if( exitReason == JOB_COREDUMPED ) {
event.setCoreFile( core_file_name );
}
if (!uLog.writeEvent (&event,jobAd)) {
dprintf (D_ALWAYS,"Unable to log "
"ULOG_JOB_TERMINATED event\n");
EXCEPT("UserLog Unable to log ULOG_JOB_TERMINATED event");
}
}
| DoS Exec Code | 0 | BaseShadow::logTerminateEvent( int exitReason, update_style_t kind )
{
struct rusage run_remote_rusage;
JobTerminatedEvent event;
MyString corefile;
memset( &run_remote_rusage, 0, sizeof(struct rusage) );
switch( exitReason ) {
case JOB_EXITED:
case JOB_COREDUMPED:
break;
default:
dprintf( D_ALWAYS,
"UserLog logTerminateEvent with unknown reason (%d), aborting\n",
exitReason );
return;
}
if (kind == US_TERMINATE_PENDING) {
float float_value;
int exited_by_signal = FALSE;
int exit_signal = 0;
int exit_code = 0;
getJobAdExitedBySignal(jobAd, exited_by_signal);
if (exited_by_signal == TRUE) {
getJobAdExitSignal(jobAd, exit_signal);
event.normal = false;
event.signalNumber = exit_signal;
} else {
getJobAdExitCode(jobAd, exit_code);
event.normal = true;
event.returnValue = exit_code;
}
/* grab usage information out of job ad */
if( jobAd->LookupFloat(ATTR_JOB_REMOTE_SYS_CPU, float_value) ) {
run_remote_rusage.ru_stime.tv_sec = (int) float_value;
}
if( jobAd->LookupFloat(ATTR_JOB_REMOTE_USER_CPU, float_value) ) {
run_remote_rusage.ru_utime.tv_sec = (int) float_value;
}
event.run_remote_rusage = run_remote_rusage;
event.total_remote_rusage = run_remote_rusage;
/*
we want to log the events from the perspective of the user
job, so if the shadow *sent* the bytes, then that means the
user job *received* the bytes
*/
jobAd->LookupFloat(ATTR_BYTES_SENT, event.recvd_bytes);
jobAd->LookupFloat(ATTR_BYTES_RECVD, event.sent_bytes);
event.total_recvd_bytes = event.recvd_bytes;
event.total_sent_bytes = event.sent_bytes;
if( exited_by_signal == TRUE ) {
jobAd->LookupString(ATTR_JOB_CORE_FILENAME, corefile);
event.setCoreFile( corefile.Value() );
}
if (!uLog.writeEvent (&event,jobAd)) {
dprintf (D_ALWAYS,"Unable to log "
"ULOG_JOB_TERMINATED event\n");
EXCEPT("UserLog Unable to log ULOG_JOB_TERMINATED event");
}
return;
}
run_remote_rusage = getRUsage();
if( exitedBySignal() ) {
event.normal = false;
event.signalNumber = exitSignal();
} else {
event.normal = true;
event.returnValue = exitCode();
}
event.run_remote_rusage = run_remote_rusage;
event.total_remote_rusage = run_remote_rusage;
/*
we want to log the events from the perspective of the user
job, so if the shadow *sent* the bytes, then that means the
user job *received* the bytes
*/
event.recvd_bytes = bytesSent();
event.sent_bytes = bytesReceived();
event.total_recvd_bytes = prev_run_bytes_recvd + bytesSent();
event.total_sent_bytes = prev_run_bytes_sent + bytesReceived();
if( exitReason == JOB_COREDUMPED ) {
event.setCoreFile( core_file_name );
}
if (!uLog.writeEvent (&event,jobAd)) {
dprintf (D_ALWAYS,"Unable to log "
"ULOG_JOB_TERMINATED event\n");
EXCEPT("UserLog Unable to log ULOG_JOB_TERMINATED event");
}
}
| @@ -1141,7 +1141,7 @@ BaseShadow::log_except(const char *msg)
bool exception_already_logged = false;
if(!msg) msg = "";
- sprintf(event.message, msg);
+ sprintf(event.message, "%s", msg);
if ( BaseShadow::myshadow_ptr ) {
BaseShadow *shadow = BaseShadow::myshadow_ptr; | CWE-134 | null | null |
13,103 | BaseShadow::publishShadowAttrs( ClassAd* ad )
{
MyString tmp;
tmp = ATTR_SHADOW_IP_ADDR;
tmp += "=\"";
tmp += daemonCore->InfoCommandSinfulString();
tmp += '"';
ad->Insert( tmp.Value() );
tmp = ATTR_SHADOW_VERSION;
tmp += "=\"";
tmp += CondorVersion();
tmp += '"';
ad->Insert( tmp.Value() );
char* my_uid_domain = param( "UID_DOMAIN" );
if( my_uid_domain ) {
tmp = ATTR_UID_DOMAIN;
tmp += "=\"";
tmp += my_uid_domain;
tmp += '"';
ad->Insert( tmp.Value() );
free( my_uid_domain );
}
}
| DoS Exec Code | 0 | BaseShadow::publishShadowAttrs( ClassAd* ad )
{
MyString tmp;
tmp = ATTR_SHADOW_IP_ADDR;
tmp += "=\"";
tmp += daemonCore->InfoCommandSinfulString();
tmp += '"';
ad->Insert( tmp.Value() );
tmp = ATTR_SHADOW_VERSION;
tmp += "=\"";
tmp += CondorVersion();
tmp += '"';
ad->Insert( tmp.Value() );
char* my_uid_domain = param( "UID_DOMAIN" );
if( my_uid_domain ) {
tmp = ATTR_UID_DOMAIN;
tmp += "=\"";
tmp += my_uid_domain;
tmp += '"';
ad->Insert( tmp.Value() );
free( my_uid_domain );
}
}
| @@ -1141,7 +1141,7 @@ BaseShadow::log_except(const char *msg)
bool exception_already_logged = false;
if(!msg) msg = "";
- sprintf(event.message, msg);
+ sprintf(event.message, "%s", msg);
if ( BaseShadow::myshadow_ptr ) {
BaseShadow *shadow = BaseShadow::myshadow_ptr; | CWE-134 | null | null |
13,104 | BaseShadow::reconnectFailed( const char* reason )
{
dprintf( D_ALWAYS, "Reconnect FAILED: %s\n", reason );
logReconnectFailedEvent( reason );
DC_Exit( JOB_SHOULD_REQUEUE );
}
| DoS Exec Code | 0 | BaseShadow::reconnectFailed( const char* reason )
{
dprintf( D_ALWAYS, "Reconnect FAILED: %s\n", reason );
logReconnectFailedEvent( reason );
DC_Exit( JOB_SHOULD_REQUEUE );
}
| @@ -1141,7 +1141,7 @@ BaseShadow::log_except(const char *msg)
bool exception_already_logged = false;
if(!msg) msg = "";
- sprintf(event.message, msg);
+ sprintf(event.message, "%s", msg);
if ( BaseShadow::myshadow_ptr ) {
BaseShadow *shadow = BaseShadow::myshadow_ptr; | CWE-134 | null | null |
13,105 | void BaseShadow::removeJob( const char* reason )
{
this->removeJobPre(reason);
DC_Exit( JOB_SHOULD_REMOVE );
}
| DoS Exec Code | 0 | void BaseShadow::removeJob( const char* reason )
{
this->removeJobPre(reason);
DC_Exit( JOB_SHOULD_REMOVE );
}
| @@ -1141,7 +1141,7 @@ BaseShadow::log_except(const char *msg)
bool exception_already_logged = false;
if(!msg) msg = "";
- sprintf(event.message, msg);
+ sprintf(event.message, "%s", msg);
if ( BaseShadow::myshadow_ptr ) {
BaseShadow *shadow = BaseShadow::myshadow_ptr; | CWE-134 | null | null |
13,106 | void BaseShadow::removeJobPre( const char* reason )
{
if( ! jobAd ) {
dprintf( D_ALWAYS, "In removeJob() w/ NULL JobAd!" );
}
dprintf( D_ALWAYS, "Job %d.%d is being removed: %s\n",
getCluster(), getProc(), reason );
cleanUp();
int size = strlen( reason ) + strlen( ATTR_REMOVE_REASON ) + 4;
char* buf = (char*)malloc( size * sizeof(char) );
if( ! buf ) {
EXCEPT( "Out of memory!" );
}
sprintf( buf, "%s=\"%s\"", ATTR_REMOVE_REASON, reason );
jobAd->Insert( buf );
free( buf );
emailRemoveEvent( reason );
if( !updateJobInQueue(U_REMOVE) ) {
dprintf( D_ALWAYS, "Failed to update job queue!\n" );
}
}
| DoS Exec Code | 0 | void BaseShadow::removeJobPre( const char* reason )
{
if( ! jobAd ) {
dprintf( D_ALWAYS, "In removeJob() w/ NULL JobAd!" );
}
dprintf( D_ALWAYS, "Job %d.%d is being removed: %s\n",
getCluster(), getProc(), reason );
cleanUp();
int size = strlen( reason ) + strlen( ATTR_REMOVE_REASON ) + 4;
char* buf = (char*)malloc( size * sizeof(char) );
if( ! buf ) {
EXCEPT( "Out of memory!" );
}
sprintf( buf, "%s=\"%s\"", ATTR_REMOVE_REASON, reason );
jobAd->Insert( buf );
free( buf );
emailRemoveEvent( reason );
if( !updateJobInQueue(U_REMOVE) ) {
dprintf( D_ALWAYS, "Failed to update job queue!\n" );
}
}
| @@ -1141,7 +1141,7 @@ BaseShadow::log_except(const char *msg)
bool exception_already_logged = false;
if(!msg) msg = "";
- sprintf(event.message, msg);
+ sprintf(event.message, "%s", msg);
if ( BaseShadow::myshadow_ptr ) {
BaseShadow *shadow = BaseShadow::myshadow_ptr; | CWE-134 | null | null |
13,107 | BaseShadow::requeueJob( const char* reason )
{
if( ! jobAd ) {
dprintf( D_ALWAYS, "In requeueJob() w/ NULL JobAd!" );
}
dprintf( D_ALWAYS,
"Job %d.%d is being put back in the job queue: %s\n",
getCluster(), getProc(), reason );
cleanUp();
int size = strlen( reason ) + strlen( ATTR_REQUEUE_REASON ) + 4;
char* buf = (char*)malloc( size * sizeof(char) );
if( ! buf ) {
EXCEPT( "Out of memory!" );
}
sprintf( buf, "%s=\"%s\"", ATTR_REQUEUE_REASON, reason );
jobAd->Insert( buf );
free( buf );
logRequeueEvent( reason );
if( !updateJobInQueue(U_REQUEUE) ) {
dprintf( D_ALWAYS, "Failed to update job queue!\n" );
}
DC_Exit( JOB_SHOULD_REQUEUE );
}
| DoS Exec Code | 0 | BaseShadow::requeueJob( const char* reason )
{
if( ! jobAd ) {
dprintf( D_ALWAYS, "In requeueJob() w/ NULL JobAd!" );
}
dprintf( D_ALWAYS,
"Job %d.%d is being put back in the job queue: %s\n",
getCluster(), getProc(), reason );
cleanUp();
int size = strlen( reason ) + strlen( ATTR_REQUEUE_REASON ) + 4;
char* buf = (char*)malloc( size * sizeof(char) );
if( ! buf ) {
EXCEPT( "Out of memory!" );
}
sprintf( buf, "%s=\"%s\"", ATTR_REQUEUE_REASON, reason );
jobAd->Insert( buf );
free( buf );
logRequeueEvent( reason );
if( !updateJobInQueue(U_REQUEUE) ) {
dprintf( D_ALWAYS, "Failed to update job queue!\n" );
}
DC_Exit( JOB_SHOULD_REQUEUE );
}
| @@ -1141,7 +1141,7 @@ BaseShadow::log_except(const char *msg)
bool exception_already_logged = false;
if(!msg) msg = "";
- sprintf(event.message, msg);
+ sprintf(event.message, "%s", msg);
if ( BaseShadow::myshadow_ptr ) {
BaseShadow *shadow = BaseShadow::myshadow_ptr; | CWE-134 | null | null |
13,108 | BaseShadow::retryJobCleanup( void )
{
m_num_cleanup_retries++;
if (m_num_cleanup_retries > m_max_cleanup_retries) {
dprintf(D_ALWAYS,
"Maximum number of job cleanup retry attempts "
"(SHADOW_MAX_JOB_CLEANUP_RETRIES=%d) reached"
"; Forcing job requeue!\n",
m_max_cleanup_retries);
DC_Exit(JOB_SHOULD_REQUEUE);
}
ASSERT(m_cleanup_retry_tid == -1);
m_cleanup_retry_tid = daemonCore->Register_Timer(m_cleanup_retry_delay, 0,
(TimerHandlercpp)&BaseShadow::retryJobCleanupHandler,
"retry job cleanup", this);
dprintf(D_FULLDEBUG, "Will retry job cleanup in "
"SHADOW_JOB_CLEANUP_RETRY_DELAY=%d seconds\n",
m_cleanup_retry_delay);
}
| DoS Exec Code | 0 | BaseShadow::retryJobCleanup( void )
{
m_num_cleanup_retries++;
if (m_num_cleanup_retries > m_max_cleanup_retries) {
dprintf(D_ALWAYS,
"Maximum number of job cleanup retry attempts "
"(SHADOW_MAX_JOB_CLEANUP_RETRIES=%d) reached"
"; Forcing job requeue!\n",
m_max_cleanup_retries);
DC_Exit(JOB_SHOULD_REQUEUE);
}
ASSERT(m_cleanup_retry_tid == -1);
m_cleanup_retry_tid = daemonCore->Register_Timer(m_cleanup_retry_delay, 0,
(TimerHandlercpp)&BaseShadow::retryJobCleanupHandler,
"retry job cleanup", this);
dprintf(D_FULLDEBUG, "Will retry job cleanup in "
"SHADOW_JOB_CLEANUP_RETRY_DELAY=%d seconds\n",
m_cleanup_retry_delay);
}
| @@ -1141,7 +1141,7 @@ BaseShadow::log_except(const char *msg)
bool exception_already_logged = false;
if(!msg) msg = "";
- sprintf(event.message, msg);
+ sprintf(event.message, "%s", msg);
if ( BaseShadow::myshadow_ptr ) {
BaseShadow *shadow = BaseShadow::myshadow_ptr; | CWE-134 | null | null |
13,109 | BaseShadow::retryJobCleanupHandler( void )
{
m_cleanup_retry_tid = -1;
dprintf(D_ALWAYS, "Retrying job cleanup, calling terminateJob()\n");
terminateJob();
return TRUE;
}
| DoS Exec Code | 0 | BaseShadow::retryJobCleanupHandler( void )
{
m_cleanup_retry_tid = -1;
dprintf(D_ALWAYS, "Retrying job cleanup, calling terminateJob()\n");
terminateJob();
return TRUE;
}
| @@ -1141,7 +1141,7 @@ BaseShadow::log_except(const char *msg)
bool exception_already_logged = false;
if(!msg) msg = "";
- sprintf(event.message, msg);
+ sprintf(event.message, "%s", msg);
if ( BaseShadow::myshadow_ptr ) {
BaseShadow *shadow = BaseShadow::myshadow_ptr; | CWE-134 | null | null |
13,110 | BaseShadow::terminateJob( update_style_t kind ) // has a default argument of US_NORMAL
{
int reason;
bool signaled;
MyString str;
if( ! jobAd ) {
dprintf( D_ALWAYS, "In terminateJob() w/ NULL JobAd!" );
}
/* The first thing we do is record that we are in a termination pending
state. */
if (kind == US_NORMAL) {
str.sprintf("%s = TRUE", ATTR_TERMINATION_PENDING);
jobAd->Insert(str.Value());
}
if (kind == US_TERMINATE_PENDING) {
int exited_by_signal = FALSE;
int exit_signal = 0;
int exit_code = 0;
getJobAdExitedBySignal(jobAd, exited_by_signal);
if (exited_by_signal == TRUE) {
getJobAdExitSignal(jobAd, exit_signal);
} else {
getJobAdExitCode(jobAd, exit_code);
}
if (exited_by_signal == TRUE) {
reason = JOB_COREDUMPED;
str.sprintf("%s = \"%s\"", ATTR_JOB_CORE_FILENAME, core_file_name);
jobAd->Insert(str.Value());
} else {
reason = JOB_EXITED;
}
dprintf( D_ALWAYS, "Job %d.%d terminated: %s %d\n",
getCluster(), getProc(),
exited_by_signal? "killed by signal" : "exited with status",
exited_by_signal ? exit_signal : exit_code );
logTerminateEvent( reason, kind );
emailTerminateEvent( reason, kind );
DC_Exit( reason );
}
cleanUp();
reason = getExitReason();
signaled = exitedBySignal();
/* also store the corefilename into the jobad so we can recover this
during a termination pending scenario. */
if( reason == JOB_COREDUMPED ) {
str.sprintf("%s = \"%s\"", ATTR_JOB_CORE_FILENAME, getCoreName());
jobAd->Insert(str.Value());
}
int last_ckpt_time = 0;
jobAd->LookupInteger(ATTR_LAST_CKPT_TIME, last_ckpt_time);
int current_start_time = 0;
jobAd->LookupInteger(ATTR_JOB_CURRENT_START_DATE, current_start_time);
int int_value = (last_ckpt_time > current_start_time) ?
last_ckpt_time : current_start_time;
if( int_value > 0 ) {
int job_committed_time = 0;
jobAd->LookupInteger(ATTR_JOB_COMMITTED_TIME, job_committed_time);
int delta = (int)time(NULL) - int_value;
job_committed_time += delta;
jobAd->Assign(ATTR_JOB_COMMITTED_TIME, job_committed_time);
float slot_weight = 1;
jobAd->LookupFloat(ATTR_JOB_MACHINE_ATTR_SLOT_WEIGHT0, slot_weight);
float slot_time = 0;
jobAd->LookupFloat(ATTR_COMMITTED_SLOT_TIME, slot_time);
slot_time += slot_weight * delta;
jobAd->Assign(ATTR_COMMITTED_SLOT_TIME, slot_time);
}
CommitSuspensionTime(jobAd);
if (m_num_cleanup_retries < 1 &&
param_boolean("SHADOW_TEST_JOB_CLEANUP_RETRY", false)) {
dprintf( D_ALWAYS,
"Testing Failure to perform final update to job queue!\n");
retryJobCleanup();
return;
}
if( !updateJobInQueue(U_TERMINATE) ) {
dprintf( D_ALWAYS,
"Failed to perform final update to job queue!\n");
retryJobCleanup();
return;
}
dprintf( D_ALWAYS, "Job %d.%d terminated: %s %d\n",
getCluster(), getProc(),
signaled ? "killed by signal" : "exited with status",
signaled ? exitSignal() : exitCode() );
logTerminateEvent( reason );
emailTerminateEvent( reason );
if( reason == JOB_EXITED && claimIsClosing() ) {
dprintf(D_FULLDEBUG,"Startd is closing claim, so no more jobs can be run on it.\n");
reason = JOB_EXITED_AND_CLAIM_CLOSING;
}
if( recycleShadow(reason) ) {
return;
}
DC_Exit( reason );
}
| DoS Exec Code | 0 | BaseShadow::terminateJob( update_style_t kind ) // has a default argument of US_NORMAL
{
int reason;
bool signaled;
MyString str;
if( ! jobAd ) {
dprintf( D_ALWAYS, "In terminateJob() w/ NULL JobAd!" );
}
/* The first thing we do is record that we are in a termination pending
state. */
if (kind == US_NORMAL) {
str.sprintf("%s = TRUE", ATTR_TERMINATION_PENDING);
jobAd->Insert(str.Value());
}
if (kind == US_TERMINATE_PENDING) {
int exited_by_signal = FALSE;
int exit_signal = 0;
int exit_code = 0;
getJobAdExitedBySignal(jobAd, exited_by_signal);
if (exited_by_signal == TRUE) {
getJobAdExitSignal(jobAd, exit_signal);
} else {
getJobAdExitCode(jobAd, exit_code);
}
if (exited_by_signal == TRUE) {
reason = JOB_COREDUMPED;
str.sprintf("%s = \"%s\"", ATTR_JOB_CORE_FILENAME, core_file_name);
jobAd->Insert(str.Value());
} else {
reason = JOB_EXITED;
}
dprintf( D_ALWAYS, "Job %d.%d terminated: %s %d\n",
getCluster(), getProc(),
exited_by_signal? "killed by signal" : "exited with status",
exited_by_signal ? exit_signal : exit_code );
logTerminateEvent( reason, kind );
emailTerminateEvent( reason, kind );
DC_Exit( reason );
}
cleanUp();
reason = getExitReason();
signaled = exitedBySignal();
/* also store the corefilename into the jobad so we can recover this
during a termination pending scenario. */
if( reason == JOB_COREDUMPED ) {
str.sprintf("%s = \"%s\"", ATTR_JOB_CORE_FILENAME, getCoreName());
jobAd->Insert(str.Value());
}
int last_ckpt_time = 0;
jobAd->LookupInteger(ATTR_LAST_CKPT_TIME, last_ckpt_time);
int current_start_time = 0;
jobAd->LookupInteger(ATTR_JOB_CURRENT_START_DATE, current_start_time);
int int_value = (last_ckpt_time > current_start_time) ?
last_ckpt_time : current_start_time;
if( int_value > 0 ) {
int job_committed_time = 0;
jobAd->LookupInteger(ATTR_JOB_COMMITTED_TIME, job_committed_time);
int delta = (int)time(NULL) - int_value;
job_committed_time += delta;
jobAd->Assign(ATTR_JOB_COMMITTED_TIME, job_committed_time);
float slot_weight = 1;
jobAd->LookupFloat(ATTR_JOB_MACHINE_ATTR_SLOT_WEIGHT0, slot_weight);
float slot_time = 0;
jobAd->LookupFloat(ATTR_COMMITTED_SLOT_TIME, slot_time);
slot_time += slot_weight * delta;
jobAd->Assign(ATTR_COMMITTED_SLOT_TIME, slot_time);
}
CommitSuspensionTime(jobAd);
if (m_num_cleanup_retries < 1 &&
param_boolean("SHADOW_TEST_JOB_CLEANUP_RETRY", false)) {
dprintf( D_ALWAYS,
"Testing Failure to perform final update to job queue!\n");
retryJobCleanup();
return;
}
if( !updateJobInQueue(U_TERMINATE) ) {
dprintf( D_ALWAYS,
"Failed to perform final update to job queue!\n");
retryJobCleanup();
return;
}
dprintf( D_ALWAYS, "Job %d.%d terminated: %s %d\n",
getCluster(), getProc(),
signaled ? "killed by signal" : "exited with status",
signaled ? exitSignal() : exitCode() );
logTerminateEvent( reason );
emailTerminateEvent( reason );
if( reason == JOB_EXITED && claimIsClosing() ) {
dprintf(D_FULLDEBUG,"Startd is closing claim, so no more jobs can be run on it.\n");
reason = JOB_EXITED_AND_CLAIM_CLOSING;
}
if( recycleShadow(reason) ) {
return;
}
DC_Exit( reason );
}
| @@ -1141,7 +1141,7 @@ BaseShadow::log_except(const char *msg)
bool exception_already_logged = false;
if(!msg) msg = "";
- sprintf(event.message, msg);
+ sprintf(event.message, "%s", msg);
if ( BaseShadow::myshadow_ptr ) {
BaseShadow *shadow = BaseShadow::myshadow_ptr; | CWE-134 | null | null |
13,111 | BaseShadow::updateJobAttr( const char *name, const char *expr, bool log )
{
return job_updater->updateAttr( name, expr, false, log );
}
| DoS Exec Code | 0 | BaseShadow::updateJobAttr( const char *name, const char *expr, bool log )
{
return job_updater->updateAttr( name, expr, false, log );
}
| @@ -1141,7 +1141,7 @@ BaseShadow::log_except(const char *msg)
bool exception_already_logged = false;
if(!msg) msg = "";
- sprintf(event.message, msg);
+ sprintf(event.message, "%s", msg);
if ( BaseShadow::myshadow_ptr ) {
BaseShadow *shadow = BaseShadow::myshadow_ptr; | CWE-134 | null | null |
13,112 | BaseShadow::updateJobAttr( const char *name, int value, bool log )
{
return job_updater->updateAttr( name, value, false, log );
}
| DoS Exec Code | 0 | BaseShadow::updateJobAttr( const char *name, int value, bool log )
{
return job_updater->updateAttr( name, value, false, log );
}
| @@ -1141,7 +1141,7 @@ BaseShadow::log_except(const char *msg)
bool exception_already_logged = false;
if(!msg) msg = "";
- sprintf(event.message, msg);
+ sprintf(event.message, "%s", msg);
if ( BaseShadow::myshadow_ptr ) {
BaseShadow *shadow = BaseShadow::myshadow_ptr; | CWE-134 | null | null |
13,113 | BaseShadow::updateJobInQueue( update_t type )
{
MyString buf;
buf.sprintf( "%s = %f", ATTR_BYTES_SENT, (prev_run_bytes_sent +
bytesReceived()) );
jobAd->Insert( buf.Value() );
buf.sprintf( "%s = %f", ATTR_BYTES_RECVD, (prev_run_bytes_recvd +
bytesSent()) );
jobAd->Insert( buf.Value() );
ASSERT( job_updater );
return job_updater->updateJob( type );
}
| DoS Exec Code | 0 | BaseShadow::updateJobInQueue( update_t type )
{
MyString buf;
buf.sprintf( "%s = %f", ATTR_BYTES_SENT, (prev_run_bytes_sent +
bytesReceived()) );
jobAd->Insert( buf.Value() );
buf.sprintf( "%s = %f", ATTR_BYTES_RECVD, (prev_run_bytes_recvd +
bytesSent()) );
jobAd->Insert( buf.Value() );
ASSERT( job_updater );
return job_updater->updateJob( type );
}
| @@ -1141,7 +1141,7 @@ BaseShadow::log_except(const char *msg)
bool exception_already_logged = false;
if(!msg) msg = "";
- sprintf(event.message, msg);
+ sprintf(event.message, "%s", msg);
if ( BaseShadow::myshadow_ptr ) {
BaseShadow *shadow = BaseShadow::myshadow_ptr; | CWE-134 | null | null |
13,114 | BaseShadow::~BaseShadow() {
if (spool) free(spool);
if (fsDomain) free(fsDomain);
if (jobAd) FreeJobAd(jobAd);
if (gjid) free(gjid);
if (scheddAddr) free(scheddAddr);
if( job_updater ) delete job_updater;
}
| DoS Exec Code | 0 | BaseShadow::~BaseShadow() {
if (spool) free(spool);
if (fsDomain) free(fsDomain);
if (jobAd) FreeJobAd(jobAd);
if (gjid) free(gjid);
if (scheddAddr) free(scheddAddr);
if( job_updater ) delete job_updater;
}
| @@ -1141,7 +1141,7 @@ BaseShadow::log_except(const char *msg)
bool exception_already_logged = false;
if(!msg) msg = "";
- sprintf(event.message, msg);
+ sprintf(event.message, "%s", msg);
if ( BaseShadow::myshadow_ptr ) {
BaseShadow *shadow = BaseShadow::myshadow_ptr; | CWE-134 | null | null |
13,115 | static int access_via_afs( const char * /* file */ )
{
char *my_fs_domain=0;
char *remote_fs_domain=0;
int result=0;
dprintf( D_SYSCALLS, "\tentering access_via_afs()\n" );
my_fs_domain = param("FILESYSTEM_DOMAIN");
thisRemoteResource->getFilesystemDomain(remote_fs_domain);
if(!param_boolean_crufty("USE_AFS", false)) {
dprintf( D_SYSCALLS, "\tnot configured to use AFS for file access\n" );
goto done;
}
if(!my_fs_domain) {
dprintf( D_SYSCALLS, "\tmy FILESYSTEM_DOMAIN is not defined\n" );
goto done;
}
if(!remote_fs_domain) {
dprintf( D_SYSCALLS, "\tdon't know FILESYSTEM_DOMAIN of executing machine\n" );
goto done;
}
dprintf( D_SYSCALLS,
"\tMy_FS_Domain = \"%s\", Executing_FS_Domain = \"%s\"\n",
my_fs_domain,
remote_fs_domain
);
if( strcmp(my_fs_domain,remote_fs_domain) != MATCH ) {
dprintf( D_SYSCALLS, "\tFilesystem domains don't match\n" );
goto done;
}
result = 1;
done:
dprintf(D_SYSCALLS,"\taccess_via_afs() returning %s\n", result ? "TRUE" : "FALSE" );
if(my_fs_domain) free(my_fs_domain);
if(remote_fs_domain) free(remote_fs_domain);
return result;
}
| DoS Exec Code | 0 | static int access_via_afs( const char * /* file */ )
{
char *my_fs_domain=0;
char *remote_fs_domain=0;
int result=0;
dprintf( D_SYSCALLS, "\tentering access_via_afs()\n" );
my_fs_domain = param("FILESYSTEM_DOMAIN");
thisRemoteResource->getFilesystemDomain(remote_fs_domain);
if(!param_boolean_crufty("USE_AFS", false)) {
dprintf( D_SYSCALLS, "\tnot configured to use AFS for file access\n" );
goto done;
}
if(!my_fs_domain) {
dprintf( D_SYSCALLS, "\tmy FILESYSTEM_DOMAIN is not defined\n" );
goto done;
}
if(!remote_fs_domain) {
dprintf( D_SYSCALLS, "\tdon't know FILESYSTEM_DOMAIN of executing machine\n" );
goto done;
}
dprintf( D_SYSCALLS,
"\tMy_FS_Domain = \"%s\", Executing_FS_Domain = \"%s\"\n",
my_fs_domain,
remote_fs_domain
);
if( strcmp(my_fs_domain,remote_fs_domain) != MATCH ) {
dprintf( D_SYSCALLS, "\tFilesystem domains don't match\n" );
goto done;
}
result = 1;
done:
dprintf(D_SYSCALLS,"\taccess_via_afs() returning %s\n", result ? "TRUE" : "FALSE" );
if(my_fs_domain) free(my_fs_domain);
if(remote_fs_domain) free(remote_fs_domain);
return result;
}
| @@ -717,7 +717,7 @@ pseudo_ulog( ClassAd *ad )
Shadow->exception_already_logged = true;
//lame: at the time of this writing, EXCEPT does not want const:
- EXCEPT(critical_error);
+ EXCEPT("%s", critical_error);
}
delete event; | CWE-134 | null | null |
13,116 | static int access_via_nfs( const char * /* file */ )
{
char *my_uid_domain=0;
char *my_fs_domain=0;
char *remote_uid_domain=0;
char *remote_fs_domain=0;
int result = 0;
dprintf( D_SYSCALLS, "\tentering access_via_nfs()\n" );
my_uid_domain = param("UID_DOMAIN");
my_fs_domain = param("FILESYSTEM_DOMAIN");
thisRemoteResource->getUidDomain(remote_uid_domain);
thisRemoteResource->getFilesystemDomain(remote_fs_domain);
if( !param_boolean_crufty("USE_NFS", false) ) {
dprintf( D_SYSCALLS, "\tnot configured to use NFS for file access\n" );
goto done;
}
if( !my_uid_domain ) {
dprintf( D_SYSCALLS, "\tdon't know my UID domain\n" );
goto done;
}
if( !my_fs_domain ) {
dprintf( D_SYSCALLS, "\tdon't know my FS domain\n" );
goto done;
}
if( !remote_uid_domain ) {
dprintf( D_SYSCALLS, "\tdon't know UID domain of executing machine\n" );
goto done;
}
if( !remote_fs_domain ) {
dprintf( D_SYSCALLS, "\tdon't know FS domain of executing machine\n" );
goto done;
}
dprintf( D_SYSCALLS,
"\tMy_FS_Domain = \"%s\", Executing_FS_Domain = \"%s\"\n",
my_fs_domain,
remote_fs_domain
);
dprintf( D_SYSCALLS,
"\tMy_UID_Domain = \"%s\", Executing_UID_Domain = \"%s\"\n",
my_uid_domain,
remote_uid_domain
);
if( strcmp(my_fs_domain,remote_fs_domain) != MATCH ) {
dprintf( D_SYSCALLS, "\tFilesystem domains don't match\n" );
goto done;
}
if( strcmp(my_uid_domain,remote_uid_domain) != MATCH ) {
dprintf( D_SYSCALLS, "\tUID domains don't match\n" );
goto done;
}
result = 1;
done:
dprintf( D_SYSCALLS, "\taccess_via_NFS() returning %s\n", result ? "TRUE" : "FALSE" );
if (remote_fs_domain) free(remote_fs_domain);
if (remote_uid_domain) free(remote_uid_domain);
return result;
}
| DoS Exec Code | 0 | static int access_via_nfs( const char * /* file */ )
{
char *my_uid_domain=0;
char *my_fs_domain=0;
char *remote_uid_domain=0;
char *remote_fs_domain=0;
int result = 0;
dprintf( D_SYSCALLS, "\tentering access_via_nfs()\n" );
my_uid_domain = param("UID_DOMAIN");
my_fs_domain = param("FILESYSTEM_DOMAIN");
thisRemoteResource->getUidDomain(remote_uid_domain);
thisRemoteResource->getFilesystemDomain(remote_fs_domain);
if( !param_boolean_crufty("USE_NFS", false) ) {
dprintf( D_SYSCALLS, "\tnot configured to use NFS for file access\n" );
goto done;
}
if( !my_uid_domain ) {
dprintf( D_SYSCALLS, "\tdon't know my UID domain\n" );
goto done;
}
if( !my_fs_domain ) {
dprintf( D_SYSCALLS, "\tdon't know my FS domain\n" );
goto done;
}
if( !remote_uid_domain ) {
dprintf( D_SYSCALLS, "\tdon't know UID domain of executing machine\n" );
goto done;
}
if( !remote_fs_domain ) {
dprintf( D_SYSCALLS, "\tdon't know FS domain of executing machine\n" );
goto done;
}
dprintf( D_SYSCALLS,
"\tMy_FS_Domain = \"%s\", Executing_FS_Domain = \"%s\"\n",
my_fs_domain,
remote_fs_domain
);
dprintf( D_SYSCALLS,
"\tMy_UID_Domain = \"%s\", Executing_UID_Domain = \"%s\"\n",
my_uid_domain,
remote_uid_domain
);
if( strcmp(my_fs_domain,remote_fs_domain) != MATCH ) {
dprintf( D_SYSCALLS, "\tFilesystem domains don't match\n" );
goto done;
}
if( strcmp(my_uid_domain,remote_uid_domain) != MATCH ) {
dprintf( D_SYSCALLS, "\tUID domains don't match\n" );
goto done;
}
result = 1;
done:
dprintf( D_SYSCALLS, "\taccess_via_NFS() returning %s\n", result ? "TRUE" : "FALSE" );
if (remote_fs_domain) free(remote_fs_domain);
if (remote_uid_domain) free(remote_uid_domain);
return result;
}
| @@ -717,7 +717,7 @@ pseudo_ulog( ClassAd *ad )
Shadow->exception_already_logged = true;
//lame: at the time of this writing, EXCEPT does not want const:
- EXCEPT(critical_error);
+ EXCEPT("%s", critical_error);
}
delete event; | CWE-134 | null | null |
13,117 | static int attr_list_has_file( const char *attr, const char *path )
{
char const *file;
MyString str;
file = condor_basename(path);
Shadow->getJobAd()->LookupString(attr,str);
StringList list(str.Value());
if( list.contains_withwildcard(path) || list.contains_withwildcard(file) ) {
return 1;
} else {
return 0;
}
}
| DoS Exec Code | 0 | static int attr_list_has_file( const char *attr, const char *path )
{
char const *file;
MyString str;
file = condor_basename(path);
Shadow->getJobAd()->LookupString(attr,str);
StringList list(str.Value());
if( list.contains_withwildcard(path) || list.contains_withwildcard(file) ) {
return 1;
} else {
return 0;
}
}
| @@ -717,7 +717,7 @@ pseudo_ulog( ClassAd *ad )
Shadow->exception_already_logged = true;
//lame: at the time of this writing, EXCEPT does not want const:
- EXCEPT(critical_error);
+ EXCEPT("%s", critical_error);
}
delete event; | CWE-134 | null | null |
13,118 | static void complete_path( const char *short_path, MyString &full_path )
{
if(short_path[0]==DIR_DELIM_CHAR) {
full_path = short_path;
} else {
full_path.sprintf("%s%s%s",
Shadow->getIwd(),
DIR_DELIM_STRING,
short_path);
}
}
| DoS Exec Code | 0 | static void complete_path( const char *short_path, MyString &full_path )
{
if(short_path[0]==DIR_DELIM_CHAR) {
full_path = short_path;
} else {
full_path.sprintf("%s%s%s",
Shadow->getIwd(),
DIR_DELIM_STRING,
short_path);
}
}
| @@ -717,7 +717,7 @@ pseudo_ulog( ClassAd *ad )
Shadow->exception_already_logged = true;
//lame: at the time of this writing, EXCEPT does not want const:
- EXCEPT(critical_error);
+ EXCEPT("%s", critical_error);
}
delete event; | CWE-134 | null | null |
13,119 | pseudo_begin_execution()
{
thisRemoteResource->beginExecution();
return 0;
}
| DoS Exec Code | 0 | pseudo_begin_execution()
{
thisRemoteResource->beginExecution();
return 0;
}
| @@ -717,7 +717,7 @@ pseudo_ulog( ClassAd *ad )
Shadow->exception_already_logged = true;
//lame: at the time of this writing, EXCEPT does not want const:
- EXCEPT(critical_error);
+ EXCEPT("%s", critical_error);
}
delete event; | CWE-134 | null | null |
13,120 | int pseudo_get_file_info_new( const char *logical_name, char *&actual_url )
{
MyString remap_list;
MyString split_dir;
MyString split_file;
MyString full_path;
MyString remap;
MyString urlbuf;
const char *method;
dprintf( D_SYSCALLS, "\tlogical_name = \"%s\"\n", logical_name );
ASSERT( actual_url == NULL );
/* The incoming logical name might be a simple, relative, or complete path */
/* We need to examine both the full path and the simple name. */
filename_split( logical_name, split_dir, split_file );
complete_path( logical_name, full_path );
/* Any name comparisons must check the logical name, the simple name, and the full path */
if(Shadow->getJobAd()->LookupString(ATTR_FILE_REMAPS,remap_list) &&
(filename_remap_find( remap_list.Value(), logical_name, remap ) ||
filename_remap_find( remap_list.Value(), split_file.Value(), remap ) ||
filename_remap_find( remap_list.Value(), full_path.Value(), remap ))) {
dprintf(D_SYSCALLS,"\tremapped to: %s\n",remap.Value());
/* If the remap is a full URL, return right away */
/* Otherwise, continue processing */
if(strchr(remap.Value(),':')) {
dprintf(D_SYSCALLS,"\tremap is complete url\n");
actual_url = strdup(remap.Value());
return 0;
} else {
dprintf(D_SYSCALLS,"\tremap is simple file\n");
complete_path( remap.Value(), full_path );
}
} else {
dprintf(D_SYSCALLS,"\tnot remapped\n");
}
dprintf( D_SYSCALLS,"\tfull_path = \"%s\"\n", full_path.Value() );
/* Now, we have a full pathname. */
/* Figure out what url modifiers to slap on it. */
#ifdef HPUX
/* I have no idea why this is happening, but I have seen it happen many
* times on the HPUX version, so here is a quick hack -Todd 5/19/95 */
if ( full_path == "/usr/lib/nls////strerror.cat" )
full_path = "/usr/lib/nls/C/strerror.cat\0";
#endif
if( use_special_access(full_path.Value()) ) {
method = "special";
} else if( use_local_access(full_path.Value()) ) {
method = "local";
} else if( access_via_afs(full_path.Value()) ) {
method = "local";
} else if( access_via_nfs(full_path.Value()) ) {
method = "local";
} else {
method = "remote";
}
if( use_fetch(method,full_path.Value()) ) {
urlbuf += "fetch:";
}
if( use_compress(method,full_path.Value()) ) {
urlbuf += "compress:";
}
append_buffer_info(urlbuf,method,full_path.Value());
if( use_append(method,full_path.Value()) ) {
urlbuf += "append:";
}
urlbuf += method;
urlbuf += ":";
urlbuf += full_path;
actual_url = strdup(urlbuf.Value());
dprintf(D_SYSCALLS,"\tactual_url: %s\n",actual_url);
return 0;
}
| DoS Exec Code | 0 | int pseudo_get_file_info_new( const char *logical_name, char *&actual_url )
{
MyString remap_list;
MyString split_dir;
MyString split_file;
MyString full_path;
MyString remap;
MyString urlbuf;
const char *method;
dprintf( D_SYSCALLS, "\tlogical_name = \"%s\"\n", logical_name );
ASSERT( actual_url == NULL );
/* The incoming logical name might be a simple, relative, or complete path */
/* We need to examine both the full path and the simple name. */
filename_split( logical_name, split_dir, split_file );
complete_path( logical_name, full_path );
/* Any name comparisons must check the logical name, the simple name, and the full path */
if(Shadow->getJobAd()->LookupString(ATTR_FILE_REMAPS,remap_list) &&
(filename_remap_find( remap_list.Value(), logical_name, remap ) ||
filename_remap_find( remap_list.Value(), split_file.Value(), remap ) ||
filename_remap_find( remap_list.Value(), full_path.Value(), remap ))) {
dprintf(D_SYSCALLS,"\tremapped to: %s\n",remap.Value());
/* If the remap is a full URL, return right away */
/* Otherwise, continue processing */
if(strchr(remap.Value(),':')) {
dprintf(D_SYSCALLS,"\tremap is complete url\n");
actual_url = strdup(remap.Value());
return 0;
} else {
dprintf(D_SYSCALLS,"\tremap is simple file\n");
complete_path( remap.Value(), full_path );
}
} else {
dprintf(D_SYSCALLS,"\tnot remapped\n");
}
dprintf( D_SYSCALLS,"\tfull_path = \"%s\"\n", full_path.Value() );
/* Now, we have a full pathname. */
/* Figure out what url modifiers to slap on it. */
#ifdef HPUX
/* I have no idea why this is happening, but I have seen it happen many
* times on the HPUX version, so here is a quick hack -Todd 5/19/95 */
if ( full_path == "/usr/lib/nls////strerror.cat" )
full_path = "/usr/lib/nls/C/strerror.cat\0";
#endif
if( use_special_access(full_path.Value()) ) {
method = "special";
} else if( use_local_access(full_path.Value()) ) {
method = "local";
} else if( access_via_afs(full_path.Value()) ) {
method = "local";
} else if( access_via_nfs(full_path.Value()) ) {
method = "local";
} else {
method = "remote";
}
if( use_fetch(method,full_path.Value()) ) {
urlbuf += "fetch:";
}
if( use_compress(method,full_path.Value()) ) {
urlbuf += "compress:";
}
append_buffer_info(urlbuf,method,full_path.Value());
if( use_append(method,full_path.Value()) ) {
urlbuf += "append:";
}
urlbuf += method;
urlbuf += ":";
urlbuf += full_path;
actual_url = strdup(urlbuf.Value());
dprintf(D_SYSCALLS,"\tactual_url: %s\n",actual_url);
return 0;
}
| @@ -717,7 +717,7 @@ pseudo_ulog( ClassAd *ad )
Shadow->exception_already_logged = true;
//lame: at the time of this writing, EXCEPT does not want const:
- EXCEPT(critical_error);
+ EXCEPT("%s", critical_error);
}
delete event; | CWE-134 | null | null |
13,121 | pseudo_get_job_attr( const char *name, MyString &expr )
{
RemoteResource *remote;
if (parallelMasterResource == NULL) {
remote = thisRemoteResource;
} else {
remote = parallelMasterResource;
}
ClassAd *ad = remote->getJobAd();
ExprTree *e = ad->LookupExpr(name);
if(e) {
expr = ExprTreeToString(e);
dprintf(D_SYSCALLS,"pseudo_get_job_attr(%s) = %s\n",name,expr.Value());
return 0;
} else {
dprintf(D_SYSCALLS,"pseudo_get_job_attr(%s) is UNDEFINED\n",name);
expr = "UNDEFINED";
return 0;
}
}
| DoS Exec Code | 0 | pseudo_get_job_attr( const char *name, MyString &expr )
{
RemoteResource *remote;
if (parallelMasterResource == NULL) {
remote = thisRemoteResource;
} else {
remote = parallelMasterResource;
}
ClassAd *ad = remote->getJobAd();
ExprTree *e = ad->LookupExpr(name);
if(e) {
expr = ExprTreeToString(e);
dprintf(D_SYSCALLS,"pseudo_get_job_attr(%s) = %s\n",name,expr.Value());
return 0;
} else {
dprintf(D_SYSCALLS,"pseudo_get_job_attr(%s) is UNDEFINED\n",name);
expr = "UNDEFINED";
return 0;
}
}
| @@ -717,7 +717,7 @@ pseudo_ulog( ClassAd *ad )
Shadow->exception_already_logged = true;
//lame: at the time of this writing, EXCEPT does not want const:
- EXCEPT(critical_error);
+ EXCEPT("%s", critical_error);
}
delete event; | CWE-134 | null | null |
13,122 | pseudo_get_job_info(ClassAd *&ad, bool &delete_ad)
{
ClassAd * the_ad;
delete_ad = false;
the_ad = thisRemoteResource->getJobAd();
ASSERT( the_ad );
thisRemoteResource->filetrans.Init( the_ad, false, PRIV_USER, false );
std::string file;
if ( the_ad->LookupString( ATTR_JOB_OUTPUT, file ) &&
strcmp( file.c_str(), StdoutRemapName ) ) {
thisRemoteResource->filetrans.AddDownloadFilenameRemap( StdoutRemapName, file.c_str() );
}
if ( the_ad->LookupString( ATTR_JOB_ERROR, file ) &&
strcmp( file.c_str(), StderrRemapName ) ) {
thisRemoteResource->filetrans.AddDownloadFilenameRemap( StderrRemapName, file.c_str() );
}
Shadow->publishShadowAttrs( the_ad );
ad = the_ad;
const CondorVersionInfo *vi = syscall_sock->get_peer_version();
if ( vi && !vi->built_since_version(7,7,2) ) {
std::string value;
ad->LookupString( ATTR_SHOULD_TRANSFER_FILES, value );
ShouldTransferFiles_t should_transfer = getShouldTransferFilesNum( value.c_str() );
if ( should_transfer == STF_IF_NEEDED || should_transfer == STF_YES ) {
ad = new ClassAd( *ad );
delete_ad = true;
bool stream;
std::string stdout_name;
std::string stderr_name;
ad->LookupString( ATTR_JOB_OUTPUT, stdout_name );
ad->LookupString( ATTR_JOB_ERROR, stderr_name );
if ( ad->LookupBool( ATTR_STREAM_OUTPUT, stream ) && !stream &&
!nullFile( stdout_name.c_str() ) ) {
ad->Assign( ATTR_JOB_OUTPUT, StdoutRemapName );
}
if ( ad->LookupBool( ATTR_STREAM_ERROR, stream ) && !stream &&
!nullFile( stderr_name.c_str() ) ) {
if ( stdout_name == stderr_name ) {
ad->Assign( ATTR_JOB_ERROR, StdoutRemapName );
} else {
ad->Assign( ATTR_JOB_ERROR, StderrRemapName );
}
}
} else if ( should_transfer != STF_NO ) {
dprintf( D_ALWAYS, "pseudo_get_job_info(): Unexpected value for %s: %s (%d)!\n",
ATTR_SHOULD_TRANSFER_FILES, value.c_str(),
should_transfer );
}
}
return 0;
}
| DoS Exec Code | 0 | pseudo_get_job_info(ClassAd *&ad, bool &delete_ad)
{
ClassAd * the_ad;
delete_ad = false;
the_ad = thisRemoteResource->getJobAd();
ASSERT( the_ad );
thisRemoteResource->filetrans.Init( the_ad, false, PRIV_USER, false );
std::string file;
if ( the_ad->LookupString( ATTR_JOB_OUTPUT, file ) &&
strcmp( file.c_str(), StdoutRemapName ) ) {
thisRemoteResource->filetrans.AddDownloadFilenameRemap( StdoutRemapName, file.c_str() );
}
if ( the_ad->LookupString( ATTR_JOB_ERROR, file ) &&
strcmp( file.c_str(), StderrRemapName ) ) {
thisRemoteResource->filetrans.AddDownloadFilenameRemap( StderrRemapName, file.c_str() );
}
Shadow->publishShadowAttrs( the_ad );
ad = the_ad;
const CondorVersionInfo *vi = syscall_sock->get_peer_version();
if ( vi && !vi->built_since_version(7,7,2) ) {
std::string value;
ad->LookupString( ATTR_SHOULD_TRANSFER_FILES, value );
ShouldTransferFiles_t should_transfer = getShouldTransferFilesNum( value.c_str() );
if ( should_transfer == STF_IF_NEEDED || should_transfer == STF_YES ) {
ad = new ClassAd( *ad );
delete_ad = true;
bool stream;
std::string stdout_name;
std::string stderr_name;
ad->LookupString( ATTR_JOB_OUTPUT, stdout_name );
ad->LookupString( ATTR_JOB_ERROR, stderr_name );
if ( ad->LookupBool( ATTR_STREAM_OUTPUT, stream ) && !stream &&
!nullFile( stdout_name.c_str() ) ) {
ad->Assign( ATTR_JOB_OUTPUT, StdoutRemapName );
}
if ( ad->LookupBool( ATTR_STREAM_ERROR, stream ) && !stream &&
!nullFile( stderr_name.c_str() ) ) {
if ( stdout_name == stderr_name ) {
ad->Assign( ATTR_JOB_ERROR, StdoutRemapName );
} else {
ad->Assign( ATTR_JOB_ERROR, StderrRemapName );
}
}
} else if ( should_transfer != STF_NO ) {
dprintf( D_ALWAYS, "pseudo_get_job_info(): Unexpected value for %s: %s (%d)!\n",
ATTR_SHOULD_TRANSFER_FILES, value.c_str(),
should_transfer );
}
}
return 0;
}
| @@ -717,7 +717,7 @@ pseudo_ulog( ClassAd *ad )
Shadow->exception_already_logged = true;
//lame: at the time of this writing, EXCEPT does not want const:
- EXCEPT(critical_error);
+ EXCEPT("%s", critical_error);
}
delete event; | CWE-134 | null | null |
13,123 | int pseudo_get_sec_session_info(
char const *starter_reconnect_session_info,
MyString &reconnect_session_id,
MyString &reconnect_session_info,
MyString &reconnect_session_key,
char const *starter_filetrans_session_info,
MyString &filetrans_session_id,
MyString &filetrans_session_info,
MyString &filetrans_session_key)
{
RemoteResource *remote;
if (parallelMasterResource == NULL) {
remote = thisRemoteResource;
} else {
remote = parallelMasterResource;
}
bool rc = remote->getSecSessionInfo(
starter_reconnect_session_info,
reconnect_session_id,
reconnect_session_info,
reconnect_session_key,
starter_filetrans_session_info,
filetrans_session_id,
filetrans_session_info,
filetrans_session_key);
if( !rc ) {
return -1;
}
return 1;
}
| DoS Exec Code | 0 | int pseudo_get_sec_session_info(
char const *starter_reconnect_session_info,
MyString &reconnect_session_id,
MyString &reconnect_session_info,
MyString &reconnect_session_key,
char const *starter_filetrans_session_info,
MyString &filetrans_session_id,
MyString &filetrans_session_info,
MyString &filetrans_session_key)
{
RemoteResource *remote;
if (parallelMasterResource == NULL) {
remote = thisRemoteResource;
} else {
remote = parallelMasterResource;
}
bool rc = remote->getSecSessionInfo(
starter_reconnect_session_info,
reconnect_session_id,
reconnect_session_info,
reconnect_session_key,
starter_filetrans_session_info,
filetrans_session_id,
filetrans_session_info,
filetrans_session_key);
if( !rc ) {
return -1;
}
return 1;
}
| @@ -717,7 +717,7 @@ pseudo_ulog( ClassAd *ad )
Shadow->exception_already_logged = true;
//lame: at the time of this writing, EXCEPT does not want const:
- EXCEPT(critical_error);
+ EXCEPT("%s", critical_error);
}
delete event; | CWE-134 | null | null |
13,124 | pseudo_get_user_info(ClassAd *&ad)
{
static ClassAd* user_ad = NULL;
if( ! user_ad ) {
user_ad = new ClassAd;
#ifndef WIN32
char buf[1024];
sprintf( buf, "%s = %d", ATTR_UID, (int)get_user_uid() );
user_ad->Insert( buf );
sprintf( buf, "%s = %d", ATTR_GID, (int)get_user_gid() );
user_ad->Insert( buf );
#endif
}
ad = user_ad;
return 0;
}
| DoS Exec Code | 0 | pseudo_get_user_info(ClassAd *&ad)
{
static ClassAd* user_ad = NULL;
if( ! user_ad ) {
user_ad = new ClassAd;
#ifndef WIN32
char buf[1024];
sprintf( buf, "%s = %d", ATTR_UID, (int)get_user_uid() );
user_ad->Insert( buf );
sprintf( buf, "%s = %d", ATTR_GID, (int)get_user_gid() );
user_ad->Insert( buf );
#endif
}
ad = user_ad;
return 0;
}
| @@ -717,7 +717,7 @@ pseudo_ulog( ClassAd *ad )
Shadow->exception_already_logged = true;
//lame: at the time of this writing, EXCEPT does not want const:
- EXCEPT(critical_error);
+ EXCEPT("%s", critical_error);
}
delete event; | CWE-134 | null | null |
13,125 | pseudo_job_termination( ClassAd *ad )
{
bool exited_by_signal = false;
bool core_dumped = false;
int exit_signal = 0;
int exit_code = 0;
MyString exit_reason;
ad->LookupBool(ATTR_ON_EXIT_BY_SIGNAL,exited_by_signal);
ad->LookupBool(ATTR_JOB_CORE_DUMPED,core_dumped);
ad->LookupString(ATTR_EXIT_REASON,exit_reason);
ad->LookupInteger(ATTR_ON_EXIT_SIGNAL,exit_signal);
ad->LookupInteger(ATTR_ON_EXIT_CODE,exit_code);
Shadow->mockTerminateJob( exit_reason, exited_by_signal, exit_code,
exit_signal, core_dumped );
return 0;
}
| DoS Exec Code | 0 | pseudo_job_termination( ClassAd *ad )
{
bool exited_by_signal = false;
bool core_dumped = false;
int exit_signal = 0;
int exit_code = 0;
MyString exit_reason;
ad->LookupBool(ATTR_ON_EXIT_BY_SIGNAL,exited_by_signal);
ad->LookupBool(ATTR_JOB_CORE_DUMPED,core_dumped);
ad->LookupString(ATTR_EXIT_REASON,exit_reason);
ad->LookupInteger(ATTR_ON_EXIT_SIGNAL,exit_signal);
ad->LookupInteger(ATTR_ON_EXIT_CODE,exit_code);
Shadow->mockTerminateJob( exit_reason, exited_by_signal, exit_code,
exit_signal, core_dumped );
return 0;
}
| @@ -717,7 +717,7 @@ pseudo_ulog( ClassAd *ad )
Shadow->exception_already_logged = true;
//lame: at the time of this writing, EXCEPT does not want const:
- EXCEPT(critical_error);
+ EXCEPT("%s", critical_error);
}
delete event; | CWE-134 | null | null |
13,126 | pseudo_register_starter_info( ClassAd* ad )
{
thisRemoteResource->setStarterInfo( ad );
return 0;
}
| DoS Exec Code | 0 | pseudo_register_starter_info( ClassAd* ad )
{
thisRemoteResource->setStarterInfo( ad );
return 0;
}
| @@ -717,7 +717,7 @@ pseudo_ulog( ClassAd *ad )
Shadow->exception_already_logged = true;
//lame: at the time of this writing, EXCEPT does not want const:
- EXCEPT(critical_error);
+ EXCEPT("%s", critical_error);
}
delete event; | CWE-134 | null | null |
13,127 | pseudo_set_job_attr( const char *name, const char *expr, bool log )
{
RemoteResource *remote;
if (parallelMasterResource == NULL) {
remote = thisRemoteResource;
} else {
remote = parallelMasterResource;
}
if(Shadow->updateJobAttr(name,expr,log)) {
dprintf(D_SYSCALLS,"pseudo_set_job_attr(%s,%s) succeeded\n",name,expr);
ClassAd *ad = remote->getJobAd();
ASSERT(ad);
ad->AssignExpr(name,expr);
return 0;
} else {
dprintf(D_SYSCALLS,"pseudo_set_job_attr(%s,%s) failed\n",name,expr);
return -1;
}
}
| DoS Exec Code | 0 | pseudo_set_job_attr( const char *name, const char *expr, bool log )
{
RemoteResource *remote;
if (parallelMasterResource == NULL) {
remote = thisRemoteResource;
} else {
remote = parallelMasterResource;
}
if(Shadow->updateJobAttr(name,expr,log)) {
dprintf(D_SYSCALLS,"pseudo_set_job_attr(%s,%s) succeeded\n",name,expr);
ClassAd *ad = remote->getJobAd();
ASSERT(ad);
ad->AssignExpr(name,expr);
return 0;
} else {
dprintf(D_SYSCALLS,"pseudo_set_job_attr(%s,%s) failed\n",name,expr);
return -1;
}
}
| @@ -717,7 +717,7 @@ pseudo_ulog( ClassAd *ad )
Shadow->exception_already_logged = true;
//lame: at the time of this writing, EXCEPT does not want const:
- EXCEPT(critical_error);
+ EXCEPT("%s", critical_error);
}
delete event; | CWE-134 | null | null |
13,128 | static int use_append( const char * /* method */, const char *path )
{
return attr_list_has_file( ATTR_APPEND_FILES, path );
}
| DoS Exec Code | 0 | static int use_append( const char * /* method */, const char *path )
{
return attr_list_has_file( ATTR_APPEND_FILES, path );
}
| @@ -717,7 +717,7 @@ pseudo_ulog( ClassAd *ad )
Shadow->exception_already_logged = true;
//lame: at the time of this writing, EXCEPT does not want const:
- EXCEPT(critical_error);
+ EXCEPT("%s", critical_error);
}
delete event; | CWE-134 | null | null |
13,129 | static int use_compress( const char * /* method */, const char *path )
{
return attr_list_has_file( ATTR_COMPRESS_FILES, path );
}
| DoS Exec Code | 0 | static int use_compress( const char * /* method */, const char *path )
{
return attr_list_has_file( ATTR_COMPRESS_FILES, path );
}
| @@ -717,7 +717,7 @@ pseudo_ulog( ClassAd *ad )
Shadow->exception_already_logged = true;
//lame: at the time of this writing, EXCEPT does not want const:
- EXCEPT(critical_error);
+ EXCEPT("%s", critical_error);
}
delete event; | CWE-134 | null | null |
13,130 | static int use_fetch( const char * /* method */, const char *path )
{
return attr_list_has_file( ATTR_FETCH_FILES, path );
}
| DoS Exec Code | 0 | static int use_fetch( const char * /* method */, const char *path )
{
return attr_list_has_file( ATTR_FETCH_FILES, path );
}
| @@ -717,7 +717,7 @@ pseudo_ulog( ClassAd *ad )
Shadow->exception_already_logged = true;
//lame: at the time of this writing, EXCEPT does not want const:
- EXCEPT(critical_error);
+ EXCEPT("%s", critical_error);
}
delete event; | CWE-134 | null | null |
13,131 | static int use_local_access( const char *file )
{
return
!strcmp(file,"/dev/null") ||
!strcmp(file,"/dev/zero") ||
attr_list_has_file( ATTR_LOCAL_FILES, file );
}
| DoS Exec Code | 0 | static int use_local_access( const char *file )
{
return
!strcmp(file,"/dev/null") ||
!strcmp(file,"/dev/zero") ||
attr_list_has_file( ATTR_LOCAL_FILES, file );
}
| @@ -717,7 +717,7 @@ pseudo_ulog( ClassAd *ad )
Shadow->exception_already_logged = true;
//lame: at the time of this writing, EXCEPT does not want const:
- EXCEPT(critical_error);
+ EXCEPT("%s", critical_error);
}
delete event; | CWE-134 | null | null |
13,132 | static int use_special_access( const char *file )
{
return
!strcmp(file,"/dev/tcp") ||
!strcmp(file,"/dev/udp") ||
!strcmp(file,"/dev/icmp") ||
!strcmp(file,"/dev/ip");
}
| DoS Exec Code | 0 | static int use_special_access( const char *file )
{
return
!strcmp(file,"/dev/tcp") ||
!strcmp(file,"/dev/udp") ||
!strcmp(file,"/dev/icmp") ||
!strcmp(file,"/dev/ip");
}
| @@ -717,7 +717,7 @@ pseudo_ulog( ClassAd *ad )
Shadow->exception_already_logged = true;
//lame: at the time of this writing, EXCEPT does not want const:
- EXCEPT(critical_error);
+ EXCEPT("%s", critical_error);
}
delete event; | CWE-134 | null | null |
13,133 | CStarter::CStarter()
{
Execute = NULL;
orig_cwd = NULL;
is_gridshell = false;
ShuttingDown = FALSE;
jic = NULL;
jobUniverse = CONDOR_UNIVERSE_VANILLA;
pre_script = NULL;
post_script = NULL;
starter_stdin_fd = -1;
starter_stdout_fd = -1;
starter_stderr_fd = -1;
deferral_tid = -1;
suspended = false;
m_privsep_helper = NULL;
m_configured = false;
m_job_environment_is_ready = false;
m_all_jobs_done = false;
m_deferred_job_update = false;
}
| DoS Exec Code | 0 | CStarter::CStarter()
{
Execute = NULL;
orig_cwd = NULL;
is_gridshell = false;
ShuttingDown = FALSE;
jic = NULL;
jobUniverse = CONDOR_UNIVERSE_VANILLA;
pre_script = NULL;
post_script = NULL;
starter_stdin_fd = -1;
starter_stdout_fd = -1;
starter_stderr_fd = -1;
deferral_tid = -1;
suspended = false;
m_privsep_helper = NULL;
m_configured = false;
m_job_environment_is_ready = false;
m_all_jobs_done = false;
m_deferred_job_update = false;
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,134 | CStarter::Config()
{
if( Execute ) {
free( Execute );
}
if( (Execute = param("EXECUTE")) == NULL ) {
if( is_gridshell ) {
Execute = strdup( orig_cwd );
} else {
EXCEPT("Execute directory not specified in config file.");
}
}
if (!m_configured) {
bool ps = privsep_enabled();
bool gl = param_boolean("GLEXEC_JOB", false);
#if !defined(LINUX)
dprintf(D_ALWAYS,
"GLEXEC_JOB not supported on this platform; "
"ignoring\n");
gl = false;
#endif
if (ps && gl) {
EXCEPT("can't support both "
"PRIVSEP_ENABLED and GLEXEC_JOB");
}
if (ps) {
m_privsep_helper = new CondorPrivSepHelper;
ASSERT(m_privsep_helper != NULL);
}
else if (gl) {
#if defined(LINUX)
m_privsep_helper = new GLExecPrivSepHelper;
ASSERT(m_privsep_helper != NULL);
#endif
}
}
jic->config();
m_configured = true;
}
| DoS Exec Code | 0 | CStarter::Config()
{
if( Execute ) {
free( Execute );
}
if( (Execute = param("EXECUTE")) == NULL ) {
if( is_gridshell ) {
Execute = strdup( orig_cwd );
} else {
EXCEPT("Execute directory not specified in config file.");
}
}
if (!m_configured) {
bool ps = privsep_enabled();
bool gl = param_boolean("GLEXEC_JOB", false);
#if !defined(LINUX)
dprintf(D_ALWAYS,
"GLEXEC_JOB not supported on this platform; "
"ignoring\n");
gl = false;
#endif
if (ps && gl) {
EXCEPT("can't support both "
"PRIVSEP_ENABLED and GLEXEC_JOB");
}
if (ps) {
m_privsep_helper = new CondorPrivSepHelper;
ASSERT(m_privsep_helper != NULL);
}
else if (gl) {
#if defined(LINUX)
m_privsep_helper = new GLExecPrivSepHelper;
ASSERT(m_privsep_helper != NULL);
#endif
}
}
jic->config();
m_configured = true;
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,135 | CStarter::Continue( void )
{
dprintf(D_ALWAYS, "Continuing all jobs.\n");
UserProc *job;
m_job_list.Rewind();
while ((job = m_job_list.Next()) != NULL) {
job->Continue();
}
this->suspended = false;
return ( true );
}
| DoS Exec Code | 0 | CStarter::Continue( void )
{
dprintf(D_ALWAYS, "Continuing all jobs.\n");
UserProc *job;
m_job_list.Rewind();
while ((job = m_job_list.Next()) != NULL) {
job->Continue();
}
this->suspended = false;
return ( true );
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,136 | void CStarter::FinalCleanup()
{
RemoveRecoveryFile();
removeTempExecuteDir();
}
| DoS Exec Code | 0 | void CStarter::FinalCleanup()
{
RemoveRecoveryFile();
removeTempExecuteDir();
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,137 | CStarter::GetJobEnv( ClassAd *jobad, Env *job_env, MyString *env_errors )
{
char *env_str = param( "STARTER_JOB_ENVIRONMENT" );
ASSERT( jobad );
ASSERT( job_env );
if( !job_env->MergeFromV1RawOrV2Quoted(env_str,env_errors) ) {
if( env_errors ) {
env_errors->sprintf_cat(
" The full value for STARTER_JOB_ENVIRONMENT: %s\n",env_str);
}
free(env_str);
return false;
}
free(env_str);
if(!job_env->MergeFrom(jobad,env_errors)) {
if( env_errors ) {
env_errors->sprintf_cat(
" (This error was from the environment string in the job "
"ClassAd.)");
}
return false;
}
PublishToEnv( job_env );
return true;
}
| DoS Exec Code | 0 | CStarter::GetJobEnv( ClassAd *jobad, Env *job_env, MyString *env_errors )
{
char *env_str = param( "STARTER_JOB_ENVIRONMENT" );
ASSERT( jobad );
ASSERT( job_env );
if( !job_env->MergeFromV1RawOrV2Quoted(env_str,env_errors) ) {
if( env_errors ) {
env_errors->sprintf_cat(
" The full value for STARTER_JOB_ENVIRONMENT: %s\n",env_str);
}
free(env_str);
return false;
}
free(env_str);
if(!job_env->MergeFrom(jobad,env_errors)) {
if( env_errors ) {
env_errors->sprintf_cat(
" (This error was from the environment string in the job "
"ClassAd.)");
}
return false;
}
PublishToEnv( job_env );
return true;
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,138 | CStarter::Hold( void )
{
bool jobRunning = false;
UserProc *job;
dprintf( D_ALWAYS, "Hold all jobs\n" );
if ( this->deferral_tid != -1 ) {
this->removeDeferredJobs();
}
m_job_list.Rewind();
while( (job = m_job_list.Next()) != NULL ) {
if( job->Hold() ) {
m_job_list.DeleteCurrent();
delete job;
} else {
jobRunning = true;
}
}
ShuttingDown = TRUE;
return ( !jobRunning );
}
| DoS Exec Code | 0 | CStarter::Hold( void )
{
bool jobRunning = false;
UserProc *job;
dprintf( D_ALWAYS, "Hold all jobs\n" );
if ( this->deferral_tid != -1 ) {
this->removeDeferredJobs();
}
m_job_list.Rewind();
while( (job = m_job_list.Next()) != NULL ) {
if( job->Hold() ) {
m_job_list.DeleteCurrent();
delete job;
} else {
jobRunning = true;
}
}
ShuttingDown = TRUE;
return ( !jobRunning );
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,139 | CStarter::PeriodicCkpt( void )
{
dprintf(D_ALWAYS, "Periodic Checkpointing all jobs.\n");
if( jobUniverse != CONDOR_UNIVERSE_VM ) {
return false;
}
UserProc *job;
m_job_list.Rewind();
while ((job = m_job_list.Next()) != NULL) {
if( job->Ckpt() ) {
CondorPrivSepHelper* cpsh = condorPrivSepHelper();
if (cpsh != NULL) {
PrivSepError err;
if( !cpsh->chown_sandbox_to_condor(err) ) {
jic->notifyStarterError(
err.holdReason(),
false,
err.holdCode(),
err.holdSubCode());
dprintf(D_ALWAYS,"failed to change sandbox to condor ownership before checkpoint");
return false;
}
}
bool transfer_ok = jic->uploadWorkingFiles();
if (cpsh != NULL) {
PrivSepError err;
if( !cpsh->chown_sandbox_to_user(err) ) {
jic->notifyStarterError(
err.holdReason(),
true,
err.holdCode(),
err.holdSubCode());
EXCEPT("failed to restore sandbox to user ownership after checkpoint");
return false;
}
}
if( transfer_ok == false ) {
dprintf(D_ALWAYS, "Periodic Checkpointing failed.\n");
job->CkptDone(false);
}else {
dprintf(D_ALWAYS, "Periodic Checkpointing is done.\n");
jic->updateCkptInfo();
job->CkptDone(true);
}
}
}
return true;
}
| DoS Exec Code | 0 | CStarter::PeriodicCkpt( void )
{
dprintf(D_ALWAYS, "Periodic Checkpointing all jobs.\n");
if( jobUniverse != CONDOR_UNIVERSE_VM ) {
return false;
}
UserProc *job;
m_job_list.Rewind();
while ((job = m_job_list.Next()) != NULL) {
if( job->Ckpt() ) {
CondorPrivSepHelper* cpsh = condorPrivSepHelper();
if (cpsh != NULL) {
PrivSepError err;
if( !cpsh->chown_sandbox_to_condor(err) ) {
jic->notifyStarterError(
err.holdReason(),
false,
err.holdCode(),
err.holdSubCode());
dprintf(D_ALWAYS,"failed to change sandbox to condor ownership before checkpoint");
return false;
}
}
bool transfer_ok = jic->uploadWorkingFiles();
if (cpsh != NULL) {
PrivSepError err;
if( !cpsh->chown_sandbox_to_user(err) ) {
jic->notifyStarterError(
err.holdReason(),
true,
err.holdCode(),
err.holdSubCode());
EXCEPT("failed to restore sandbox to user ownership after checkpoint");
return false;
}
}
if( transfer_ok == false ) {
dprintf(D_ALWAYS, "Periodic Checkpointing failed.\n");
job->CkptDone(false);
}else {
dprintf(D_ALWAYS, "Periodic Checkpointing is done.\n");
jic->updateCkptInfo();
job->CkptDone(true);
}
}
}
return true;
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,140 | CStarter::PublishToEnv( Env* proc_env )
{
ASSERT(proc_env);
if( pre_script ) {
pre_script->PublishToEnv( proc_env );
}
proc_env->SetEnv("_CONDOR_JOB_IWD",jic->jobRemoteIWD());
MyString job_pids;
UserProc* uproc;
m_job_list.Rewind();
while ((uproc = m_job_list.Next()) != NULL) {
uproc->PublishToEnv( proc_env );
if( ! job_pids.IsEmpty() ) {
job_pids += " ";
}
job_pids.sprintf_cat("%d",uproc->GetJobPid());
}
proc_env->SetEnv("_CONDOR_JOB_PIDS",job_pids);
m_reaped_job_list.Rewind();
while ((uproc = m_reaped_job_list.Next()) != NULL) {
uproc->PublishToEnv( proc_env );
}
ASSERT(jic);
ClassAd* jobAd = jic->jobClassAd();
if( jobAd ) {
bool using_file_transfer = jic->usingFileTransfer();
build_job_env( *proc_env, *jobAd, using_file_transfer );
} else {
dprintf(D_ALWAYS, "Unable to find job ad for job. Environment may be incorrect\n");
}
MyString base;
base = "_";
base += myDistro->GetUc();
base += '_';
MyString env_name;
const char* output_ad = jic->getOutputAdFile();
if( output_ad && !(output_ad[0] == '-' && output_ad[1] == '\0') ) {
env_name = base.Value();
env_name += "OUTPUT_CLASSAD";
proc_env->SetEnv( env_name.Value(), output_ad );
}
env_name = base.Value();
env_name += "SCRATCH_DIR";
proc_env->SetEnv( env_name.Value(), GetWorkingDir() );
env_name = base.Value();
env_name += "SLOT";
int slot = getMySlotNumber();
if (!slot) {
slot = 1;
}
proc_env->SetEnv(env_name.Value(), slot);
int low, high;
if (get_port_range (TRUE, &low, &high) == TRUE) {
MyString tmp_port_number;
tmp_port_number = high;
env_name = base.Value();
env_name += "HIGHPORT";
proc_env->SetEnv( env_name.Value(), tmp_port_number.Value() );
tmp_port_number = low;
env_name = base.Value();
env_name += "LOWPORT";
proc_env->SetEnv( env_name.Value(), tmp_port_number.Value() );
}
proc_env->SetEnv("TMPDIR", GetWorkingDir());
proc_env->SetEnv("TEMP", GetWorkingDir()); // Windows
proc_env->SetEnv("TMP", GetWorkingDir()); // Windows
}
| DoS Exec Code | 0 | CStarter::PublishToEnv( Env* proc_env )
{
ASSERT(proc_env);
if( pre_script ) {
pre_script->PublishToEnv( proc_env );
}
proc_env->SetEnv("_CONDOR_JOB_IWD",jic->jobRemoteIWD());
MyString job_pids;
UserProc* uproc;
m_job_list.Rewind();
while ((uproc = m_job_list.Next()) != NULL) {
uproc->PublishToEnv( proc_env );
if( ! job_pids.IsEmpty() ) {
job_pids += " ";
}
job_pids.sprintf_cat("%d",uproc->GetJobPid());
}
proc_env->SetEnv("_CONDOR_JOB_PIDS",job_pids);
m_reaped_job_list.Rewind();
while ((uproc = m_reaped_job_list.Next()) != NULL) {
uproc->PublishToEnv( proc_env );
}
ASSERT(jic);
ClassAd* jobAd = jic->jobClassAd();
if( jobAd ) {
bool using_file_transfer = jic->usingFileTransfer();
build_job_env( *proc_env, *jobAd, using_file_transfer );
} else {
dprintf(D_ALWAYS, "Unable to find job ad for job. Environment may be incorrect\n");
}
MyString base;
base = "_";
base += myDistro->GetUc();
base += '_';
MyString env_name;
const char* output_ad = jic->getOutputAdFile();
if( output_ad && !(output_ad[0] == '-' && output_ad[1] == '\0') ) {
env_name = base.Value();
env_name += "OUTPUT_CLASSAD";
proc_env->SetEnv( env_name.Value(), output_ad );
}
env_name = base.Value();
env_name += "SCRATCH_DIR";
proc_env->SetEnv( env_name.Value(), GetWorkingDir() );
env_name = base.Value();
env_name += "SLOT";
int slot = getMySlotNumber();
if (!slot) {
slot = 1;
}
proc_env->SetEnv(env_name.Value(), slot);
int low, high;
if (get_port_range (TRUE, &low, &high) == TRUE) {
MyString tmp_port_number;
tmp_port_number = high;
env_name = base.Value();
env_name += "HIGHPORT";
proc_env->SetEnv( env_name.Value(), tmp_port_number.Value() );
tmp_port_number = low;
env_name = base.Value();
env_name += "LOWPORT";
proc_env->SetEnv( env_name.Value(), tmp_port_number.Value() );
}
proc_env->SetEnv("TMPDIR", GetWorkingDir());
proc_env->SetEnv("TEMP", GetWorkingDir()); // Windows
proc_env->SetEnv("TMP", GetWorkingDir()); // Windows
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,141 | CStarter::Reaper(int pid, int exit_status)
{
int handled_jobs = 0;
int all_jobs = 0;
UserProc *job;
if( WIFSIGNALED(exit_status) ) {
dprintf( D_ALWAYS, "Process exited, pid=%d, signal=%d\n", pid,
WTERMSIG(exit_status) );
} else {
dprintf( D_ALWAYS, "Process exited, pid=%d, status=%d\n", pid,
WEXITSTATUS(exit_status) );
}
if( pre_script && pre_script->JobReaper(pid, exit_status) ) {
if( ! SpawnJob() ) {
dprintf( D_ALWAYS, "Failed to start main job, exiting\n" );
main_shutdown_fast();
return FALSE;
}
return TRUE;
}
if( post_script && post_script->JobReaper(pid, exit_status) ) {
allJobsDone();
return TRUE;
}
m_job_list.Rewind();
while ((job = m_job_list.Next()) != NULL) {
all_jobs++;
if( job->GetJobPid()==pid && job->JobReaper(pid, exit_status) ) {
handled_jobs++;
m_job_list.DeleteCurrent();
m_reaped_job_list.Append(job);
}
}
dprintf( D_FULLDEBUG, "Reaper: all=%d handled=%d ShuttingDown=%d\n",
all_jobs, handled_jobs, ShuttingDown );
if( handled_jobs == 0 ) {
dprintf( D_ALWAYS, "unhandled job exit: pid=%d, status=%d\n",
pid, exit_status );
}
if( all_jobs - handled_jobs == 0 ) {
if( post_script ) {
post_script->StartJob();
return TRUE;
} else {
if( !allJobsDone() ) {
dprintf(D_ALWAYS, "Returning from CStarter::JobReaper()\n");
return 0;
}
}
}
if ( ShuttingDown && (all_jobs - handled_jobs == 0) ) {
dprintf(D_ALWAYS,"Last process exited, now Starter is exiting\n");
StarterExit(0);
}
return 0;
}
| DoS Exec Code | 0 | CStarter::Reaper(int pid, int exit_status)
{
int handled_jobs = 0;
int all_jobs = 0;
UserProc *job;
if( WIFSIGNALED(exit_status) ) {
dprintf( D_ALWAYS, "Process exited, pid=%d, signal=%d\n", pid,
WTERMSIG(exit_status) );
} else {
dprintf( D_ALWAYS, "Process exited, pid=%d, status=%d\n", pid,
WEXITSTATUS(exit_status) );
}
if( pre_script && pre_script->JobReaper(pid, exit_status) ) {
if( ! SpawnJob() ) {
dprintf( D_ALWAYS, "Failed to start main job, exiting\n" );
main_shutdown_fast();
return FALSE;
}
return TRUE;
}
if( post_script && post_script->JobReaper(pid, exit_status) ) {
allJobsDone();
return TRUE;
}
m_job_list.Rewind();
while ((job = m_job_list.Next()) != NULL) {
all_jobs++;
if( job->GetJobPid()==pid && job->JobReaper(pid, exit_status) ) {
handled_jobs++;
m_job_list.DeleteCurrent();
m_reaped_job_list.Append(job);
}
}
dprintf( D_FULLDEBUG, "Reaper: all=%d handled=%d ShuttingDown=%d\n",
all_jobs, handled_jobs, ShuttingDown );
if( handled_jobs == 0 ) {
dprintf( D_ALWAYS, "unhandled job exit: pid=%d, status=%d\n",
pid, exit_status );
}
if( all_jobs - handled_jobs == 0 ) {
if( post_script ) {
post_script->StartJob();
return TRUE;
} else {
if( !allJobsDone() ) {
dprintf(D_ALWAYS, "Returning from CStarter::JobReaper()\n");
return 0;
}
}
}
if ( ShuttingDown && (all_jobs - handled_jobs == 0) ) {
dprintf(D_ALWAYS,"Last process exited, now Starter is exiting\n");
StarterExit(0);
}
return 0;
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,142 | CStarter::RemoteContinue(int)
{
int retval = this->Continue();
jic->Continue();
return retval;
}
| DoS Exec Code | 0 | CStarter::RemoteContinue(int)
{
int retval = this->Continue();
jic->Continue();
return retval;
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,143 | CStarter::RemoteHold( int )
{
if( jic ) {
jic->gotHold();
}
if ( this->Hold( ) ) {
dprintf( D_FULLDEBUG, "Got Hold when no jobs running\n" );
this->allJobsDone();
return ( true );
}
return ( false );
}
| DoS Exec Code | 0 | CStarter::RemoteHold( int )
{
if( jic ) {
jic->gotHold();
}
if ( this->Hold( ) ) {
dprintf( D_FULLDEBUG, "Got Hold when no jobs running\n" );
this->allJobsDone();
return ( true );
}
return ( false );
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,144 | CStarter::RemotePeriodicCkpt(int)
{
return ( this->PeriodicCkpt( ) );
}
| DoS Exec Code | 0 | CStarter::RemotePeriodicCkpt(int)
{
return ( this->PeriodicCkpt( ) );
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,145 | CStarter::RemoteShutdownFast(int)
{
bool fast_in_progress = false;
if( jic ) {
fast_in_progress = jic->isFastShutdown();
jic->gotShutdownFast();
}
if( fast_in_progress == false ) {
return ( this->ShutdownFast( ) );
}
else {
return ( false );
}
}
| DoS Exec Code | 0 | CStarter::RemoteShutdownFast(int)
{
bool fast_in_progress = false;
if( jic ) {
fast_in_progress = jic->isFastShutdown();
jic->gotShutdownFast();
}
if( fast_in_progress == false ) {
return ( this->ShutdownFast( ) );
}
else {
return ( false );
}
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,146 | CStarter::RemoteShutdownGraceful( int )
{
bool graceful_in_progress = false;
if ( jic ) {
graceful_in_progress = jic->isGracefulShutdown();
jic->gotShutdownGraceful();
}
if ( graceful_in_progress == false ) {
return ( this->ShutdownGraceful( ) );
}
else {
return ( false );
}
}
| DoS Exec Code | 0 | CStarter::RemoteShutdownGraceful( int )
{
bool graceful_in_progress = false;
if ( jic ) {
graceful_in_progress = jic->isGracefulShutdown();
jic->gotShutdownGraceful();
}
if ( graceful_in_progress == false ) {
return ( this->ShutdownGraceful( ) );
}
else {
return ( false );
}
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,147 | CStarter::RemoteSuspend(int)
{
int retval = this->Suspend();
jic->Suspend();
return retval;
}
| DoS Exec Code | 0 | CStarter::RemoteSuspend(int)
{
int retval = this->Suspend();
jic->Suspend();
return retval;
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,148 | CStarter::Remove( ) {
bool jobRunning = false;
UserProc *job;
dprintf( D_ALWAYS, "Remove all jobs\n" );
if ( this->deferral_tid != -1 ) {
this->removeDeferredJobs();
}
m_job_list.Rewind();
while( (job = m_job_list.Next()) != NULL ) {
if( job->Remove() ) {
m_job_list.DeleteCurrent();
delete job;
} else {
jobRunning = true;
}
}
ShuttingDown = TRUE;
return ( !jobRunning );
}
| DoS Exec Code | 0 | CStarter::Remove( ) {
bool jobRunning = false;
UserProc *job;
dprintf( D_ALWAYS, "Remove all jobs\n" );
if ( this->deferral_tid != -1 ) {
this->removeDeferredJobs();
}
m_job_list.Rewind();
while( (job = m_job_list.Next()) != NULL ) {
if( job->Remove() ) {
m_job_list.DeleteCurrent();
delete job;
} else {
jobRunning = true;
}
}
ShuttingDown = TRUE;
return ( !jobRunning );
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,149 | CStarter::RemoveRecoveryFile()
{
if ( m_recoveryFile.Length() > 0 ) {
unlink( m_recoveryFile.Value() );
m_recoveryFile = "";
}
}
| DoS Exec Code | 0 | CStarter::RemoveRecoveryFile()
{
if ( m_recoveryFile.Length() > 0 ) {
unlink( m_recoveryFile.Value() );
m_recoveryFile = "";
}
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,150 | CStarter::SSHDRetry(Stream *s,char const *fmt,...)
{
va_list args;
va_start( args, fmt );
vSSHDFailed(s,true,fmt,args);
va_end( args );
return FALSE;
}
| DoS Exec Code | 0 | CStarter::SSHDRetry(Stream *s,char const *fmt,...)
{
va_list args;
va_start( args, fmt );
vSSHDFailed(s,true,fmt,args);
va_end( args );
return FALSE;
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,151 | CStarter::ShutdownFast( void )
{
bool jobRunning = false;
UserProc *job;
dprintf(D_ALWAYS, "ShutdownFast all jobs.\n");
if ( this->deferral_tid != -1 ) {
this->removeDeferredJobs();
}
m_job_list.Rewind();
while ((job = m_job_list.Next()) != NULL) {
if ( job->ShutdownFast() ) {
m_job_list.DeleteCurrent();
delete job;
} else {
jobRunning = true;
}
}
ShuttingDown = TRUE;
if (!jobRunning) {
dprintf(D_FULLDEBUG,
"Got ShutdownFast when no jobs running.\n");
return ( this->allJobsDone() );
}
return ( false );
}
| DoS Exec Code | 0 | CStarter::ShutdownFast( void )
{
bool jobRunning = false;
UserProc *job;
dprintf(D_ALWAYS, "ShutdownFast all jobs.\n");
if ( this->deferral_tid != -1 ) {
this->removeDeferredJobs();
}
m_job_list.Rewind();
while ((job = m_job_list.Next()) != NULL) {
if ( job->ShutdownFast() ) {
m_job_list.DeleteCurrent();
delete job;
} else {
jobRunning = true;
}
}
ShuttingDown = TRUE;
if (!jobRunning) {
dprintf(D_FULLDEBUG,
"Got ShutdownFast when no jobs running.\n");
return ( this->allJobsDone() );
}
return ( false );
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,152 | CStarter::ShutdownGraceful( void )
{
bool jobRunning = false;
UserProc *job;
dprintf(D_ALWAYS, "ShutdownGraceful all jobs.\n");
if ( this->deferral_tid != -1 ) {
this->removeDeferredJobs();
}
m_job_list.Rewind();
while ((job = m_job_list.Next()) != NULL) {
if ( job->ShutdownGraceful() ) {
m_job_list.DeleteCurrent();
delete job;
} else {
jobRunning = true;
}
}
ShuttingDown = TRUE;
if (!jobRunning) {
dprintf(D_FULLDEBUG,
"Got ShutdownGraceful when no jobs running.\n");
this->allJobsDone();
return 1;
}
return 0;
}
| DoS Exec Code | 0 | CStarter::ShutdownGraceful( void )
{
bool jobRunning = false;
UserProc *job;
dprintf(D_ALWAYS, "ShutdownGraceful all jobs.\n");
if ( this->deferral_tid != -1 ) {
this->removeDeferredJobs();
}
m_job_list.Rewind();
while ((job = m_job_list.Next()) != NULL) {
if ( job->ShutdownGraceful() ) {
m_job_list.DeleteCurrent();
delete job;
} else {
jobRunning = true;
}
}
ShuttingDown = TRUE;
if (!jobRunning) {
dprintf(D_FULLDEBUG,
"Got ShutdownGraceful when no jobs running.\n");
this->allJobsDone();
return 1;
}
return 0;
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,153 | CStarter::SpawnJob( void )
{
ClassAd* jobAd = jic->jobClassAd();
if ( jobAd->LookupInteger( ATTR_JOB_UNIVERSE, jobUniverse ) < 1 ) {
dprintf( D_ALWAYS,
"Job doesn't specify universe, assuming VANILLA\n" );
}
dprintf( D_ALWAYS, "Starting a %s universe job with ID: %d.%d\n",
CondorUniverseName(jobUniverse), jic->jobCluster(),
jic->jobProc() );
UserProc *job;
switch ( jobUniverse )
{
case CONDOR_UNIVERSE_LOCAL:
case CONDOR_UNIVERSE_VANILLA:
job = new VanillaProc( jobAd );
break;
case CONDOR_UNIVERSE_JAVA:
job = new JavaProc( jobAd, WorkingDir.Value() );
break;
case CONDOR_UNIVERSE_PARALLEL:
job = new ParallelProc( jobAd );
break;
case CONDOR_UNIVERSE_MPI: {
int is_master = FALSE;
if ( jobAd->LookupBool( ATTR_MPI_IS_MASTER, is_master ) < 1 ) {
is_master = FALSE;
}
if ( is_master ) {
dprintf ( D_FULLDEBUG, "Starting a MPIMasterProc\n" );
job = new MPIMasterProc( jobAd );
} else {
dprintf ( D_FULLDEBUG, "Starting a MPIComradeProc\n" );
job = new MPIComradeProc( jobAd );
}
break;
}
case CONDOR_UNIVERSE_VM:
job = new VMProc( jobAd );
ASSERT(job);
break;
default:
dprintf( D_ALWAYS, "Starter doesn't support universe %d (%s)\n",
jobUniverse, CondorUniverseName(jobUniverse) );
return FALSE;
} /* switch */
if (job->StartJob()) {
m_job_list.Append(job);
if ( this->suspended ) {
this->Suspend( );
}
char* tool_daemon_name = NULL;
jobAd->LookupString( ATTR_TOOL_DAEMON_CMD,
&tool_daemon_name );
if( tool_daemon_name ) {
ToolDaemonProc* tool_daemon_proc;
tool_daemon_proc = new ToolDaemonProc( jobAd, job->GetJobPid() );
if( tool_daemon_proc->StartJob() ) {
m_job_list.Append( tool_daemon_proc );
dprintf( D_FULLDEBUG, "ToolDaemonProc added to m_job_list\n");
if ( this->suspended ) {
this->Suspend( );
}
} else {
dprintf( D_ALWAYS, "Failed to start ToolDaemonProc!\n");
delete tool_daemon_proc;
}
free( tool_daemon_name );
}
jic->allJobsSpawned();
return TRUE;
} else {
delete job;
dprintf( D_ALWAYS, "Failed to start job, exiting\n" );
main_shutdown_fast();
return FALSE;
}
}
| DoS Exec Code | 0 | CStarter::SpawnJob( void )
{
ClassAd* jobAd = jic->jobClassAd();
if ( jobAd->LookupInteger( ATTR_JOB_UNIVERSE, jobUniverse ) < 1 ) {
dprintf( D_ALWAYS,
"Job doesn't specify universe, assuming VANILLA\n" );
}
dprintf( D_ALWAYS, "Starting a %s universe job with ID: %d.%d\n",
CondorUniverseName(jobUniverse), jic->jobCluster(),
jic->jobProc() );
UserProc *job;
switch ( jobUniverse )
{
case CONDOR_UNIVERSE_LOCAL:
case CONDOR_UNIVERSE_VANILLA:
job = new VanillaProc( jobAd );
break;
case CONDOR_UNIVERSE_JAVA:
job = new JavaProc( jobAd, WorkingDir.Value() );
break;
case CONDOR_UNIVERSE_PARALLEL:
job = new ParallelProc( jobAd );
break;
case CONDOR_UNIVERSE_MPI: {
int is_master = FALSE;
if ( jobAd->LookupBool( ATTR_MPI_IS_MASTER, is_master ) < 1 ) {
is_master = FALSE;
}
if ( is_master ) {
dprintf ( D_FULLDEBUG, "Starting a MPIMasterProc\n" );
job = new MPIMasterProc( jobAd );
} else {
dprintf ( D_FULLDEBUG, "Starting a MPIComradeProc\n" );
job = new MPIComradeProc( jobAd );
}
break;
}
case CONDOR_UNIVERSE_VM:
job = new VMProc( jobAd );
ASSERT(job);
break;
default:
dprintf( D_ALWAYS, "Starter doesn't support universe %d (%s)\n",
jobUniverse, CondorUniverseName(jobUniverse) );
return FALSE;
} /* switch */
if (job->StartJob()) {
m_job_list.Append(job);
if ( this->suspended ) {
this->Suspend( );
}
char* tool_daemon_name = NULL;
jobAd->LookupString( ATTR_TOOL_DAEMON_CMD,
&tool_daemon_name );
if( tool_daemon_name ) {
ToolDaemonProc* tool_daemon_proc;
tool_daemon_proc = new ToolDaemonProc( jobAd, job->GetJobPid() );
if( tool_daemon_proc->StartJob() ) {
m_job_list.Append( tool_daemon_proc );
dprintf( D_FULLDEBUG, "ToolDaemonProc added to m_job_list\n");
if ( this->suspended ) {
this->Suspend( );
}
} else {
dprintf( D_ALWAYS, "Failed to start ToolDaemonProc!\n");
delete tool_daemon_proc;
}
free( tool_daemon_name );
}
jic->allJobsSpawned();
return TRUE;
} else {
delete job;
dprintf( D_ALWAYS, "Failed to start job, exiting\n" );
main_shutdown_fast();
return FALSE;
}
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,154 | CStarter::SpawnPreScript( void )
{
if ( this->deferral_tid != -1 ) {
this->deferral_tid = -1;
}
ClassAd* jobAd = jic->jobClassAd();
char* tmp = NULL;
MyString attr;
attr = "Pre";
attr += ATTR_JOB_CMD;
if( jobAd->LookupString(attr.Value(), &tmp) ) {
free( tmp );
tmp = NULL;
pre_script = new ScriptProc( jobAd, "Pre" );
}
attr = "Post";
attr += ATTR_JOB_CMD;
if( jobAd->LookupString(attr.Value(), &tmp) ) {
free( tmp );
tmp = NULL;
post_script = new ScriptProc( jobAd, "Post" );
}
if( pre_script ) {
if( pre_script->StartJob() ) {
return;
} else {
dprintf( D_ALWAYS, "Failed to start prescript, exiting\n" );
main_shutdown_fast();
return;
}
}
if( ! SpawnJob() ) {
dprintf( D_ALWAYS, "Failed to start main job, exiting.\n" );
main_shutdown_fast();
}
}
| DoS Exec Code | 0 | CStarter::SpawnPreScript( void )
{
if ( this->deferral_tid != -1 ) {
this->deferral_tid = -1;
}
ClassAd* jobAd = jic->jobClassAd();
char* tmp = NULL;
MyString attr;
attr = "Pre";
attr += ATTR_JOB_CMD;
if( jobAd->LookupString(attr.Value(), &tmp) ) {
free( tmp );
tmp = NULL;
pre_script = new ScriptProc( jobAd, "Pre" );
}
attr = "Post";
attr += ATTR_JOB_CMD;
if( jobAd->LookupString(attr.Value(), &tmp) ) {
free( tmp );
tmp = NULL;
post_script = new ScriptProc( jobAd, "Post" );
}
if( pre_script ) {
if( pre_script->StartJob() ) {
return;
} else {
dprintf( D_ALWAYS, "Failed to start prescript, exiting\n" );
main_shutdown_fast();
return;
}
}
if( ! SpawnJob() ) {
dprintf( D_ALWAYS, "Failed to start main job, exiting.\n" );
main_shutdown_fast();
}
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,155 | CStarter::StarterExit( int code )
{
FinalCleanup();
#if !defined(WIN32)
if ( GetEnv( "CONDOR_GLEXEC_STARTER_CLEANUP_FLAG" ) ) {
exitAfterGlexec( code );
}
#endif
DC_Exit( code );
}
| DoS Exec Code | 0 | CStarter::StarterExit( int code )
{
FinalCleanup();
#if !defined(WIN32)
if ( GetEnv( "CONDOR_GLEXEC_STARTER_CLEANUP_FLAG" ) ) {
exitAfterGlexec( code );
}
#endif
DC_Exit( code );
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,156 | CStarter::Suspend( void ) {
dprintf(D_ALWAYS, "Suspending all jobs.\n");
UserProc *job;
m_job_list.Rewind();
while ((job = m_job_list.Next()) != NULL) {
job->Suspend();
}
this->suspended = true;
return ( true );
}
| DoS Exec Code | 0 | CStarter::Suspend( void ) {
dprintf(D_ALWAYS, "Suspending all jobs.\n");
UserProc *job;
m_job_list.Rewind();
while ((job = m_job_list.Next()) != NULL) {
job->Suspend();
}
this->suspended = true;
return ( true );
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,157 | CStarter::WriteAdFiles()
{
ClassAd* ad;
const char* dir = this->GetWorkingDir();
MyString ad_str, filename;
FILE* fp;
bool ret_val = true;
ad = this->jic->jobClassAd();
if (ad != NULL)
{
filename.sprintf("%s%c%s", dir, DIR_DELIM_CHAR, JOB_AD_FILENAME);
fp = safe_fopen_wrapper_follow(filename.Value(), "w");
if (!fp)
{
dprintf(D_ALWAYS, "Failed to open \"%s\" for to write job ad: "
"%s (errno %d)\n", filename.Value(),
strerror(errno), errno);
ret_val = false;
}
else
{
ad->SetPrivateAttributesInvisible(true);
ad->fPrint(fp);
ad->SetPrivateAttributesInvisible(false);
fclose(fp);
}
}
else
{
ret_val = false;
}
ad = this->jic->machClassAd();
if (ad != NULL)
{
filename.sprintf("%s%c%s", dir, DIR_DELIM_CHAR, MACHINE_AD_FILENAME);
fp = safe_fopen_wrapper_follow(filename.Value(), "w");
if (!fp)
{
dprintf(D_ALWAYS, "Failed to open \"%s\" for to write machine "
"ad: %s (errno %d)\n", filename.Value(),
strerror(errno), errno);
ret_val = false;
}
else
{
ad->SetPrivateAttributesInvisible(true);
ad->fPrint(fp);
ad->SetPrivateAttributesInvisible(false);
fclose(fp);
}
}
return ret_val;
}
| DoS Exec Code | 0 | CStarter::WriteAdFiles()
{
ClassAd* ad;
const char* dir = this->GetWorkingDir();
MyString ad_str, filename;
FILE* fp;
bool ret_val = true;
ad = this->jic->jobClassAd();
if (ad != NULL)
{
filename.sprintf("%s%c%s", dir, DIR_DELIM_CHAR, JOB_AD_FILENAME);
fp = safe_fopen_wrapper_follow(filename.Value(), "w");
if (!fp)
{
dprintf(D_ALWAYS, "Failed to open \"%s\" for to write job ad: "
"%s (errno %d)\n", filename.Value(),
strerror(errno), errno);
ret_val = false;
}
else
{
ad->SetPrivateAttributesInvisible(true);
ad->fPrint(fp);
ad->SetPrivateAttributesInvisible(false);
fclose(fp);
}
}
else
{
ret_val = false;
}
ad = this->jic->machClassAd();
if (ad != NULL)
{
filename.sprintf("%s%c%s", dir, DIR_DELIM_CHAR, MACHINE_AD_FILENAME);
fp = safe_fopen_wrapper_follow(filename.Value(), "w");
if (!fp)
{
dprintf(D_ALWAYS, "Failed to open \"%s\" for to write machine "
"ad: %s (errno %d)\n", filename.Value(),
strerror(errno), errno);
ret_val = false;
}
else
{
ad->SetPrivateAttributesInvisible(true);
ad->fPrint(fp);
ad->SetPrivateAttributesInvisible(false);
fclose(fp);
}
}
return ret_val;
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,158 | CStarter::WriteRecoveryFile( ClassAd *recovery_ad )
{
MyString tmp_file;
FILE *tmp_fp;
if ( recovery_ad == NULL ) {
return;
}
if ( m_recoveryFile.Length() == 0 ) {
m_recoveryFile.sprintf( "%s%cdir_%ld.recover", Execute,
DIR_DELIM_CHAR, (long)daemonCore->getpid() );
}
tmp_file.sprintf( "%s.tmp", m_recoveryFile.Value() );
tmp_fp = safe_fcreate_replace_if_exists( tmp_file.Value(), "w" );
if ( tmp_fp == NULL ) {
dprintf( D_ALWAYS, "Failed to open recovery file %s\n", tmp_file.Value() );
return;
}
if ( recovery_ad->fPrint( tmp_fp ) == FALSE ) {
dprintf( D_ALWAYS, "Failed to write recovery file\n" );
fclose( tmp_fp );
return;
}
if ( fclose( tmp_fp ) != 0 ) {
dprintf( D_ALWAYS, "Failed close recovery file\n" );
unlink( tmp_file.Value() );
return;
}
if ( rotate_file( tmp_file.Value(), m_recoveryFile.Value() ) != 0 ) {
dprintf( D_ALWAYS, "Failed to rename recovery file\n" );
unlink( tmp_file.Value() );
}
}
| DoS Exec Code | 0 | CStarter::WriteRecoveryFile( ClassAd *recovery_ad )
{
MyString tmp_file;
FILE *tmp_fp;
if ( recovery_ad == NULL ) {
return;
}
if ( m_recoveryFile.Length() == 0 ) {
m_recoveryFile.sprintf( "%s%cdir_%ld.recover", Execute,
DIR_DELIM_CHAR, (long)daemonCore->getpid() );
}
tmp_file.sprintf( "%s.tmp", m_recoveryFile.Value() );
tmp_fp = safe_fcreate_replace_if_exists( tmp_file.Value(), "w" );
if ( tmp_fp == NULL ) {
dprintf( D_ALWAYS, "Failed to open recovery file %s\n", tmp_file.Value() );
return;
}
if ( recovery_ad->fPrint( tmp_fp ) == FALSE ) {
dprintf( D_ALWAYS, "Failed to write recovery file\n" );
fclose( tmp_fp );
return;
}
if ( fclose( tmp_fp ) != 0 ) {
dprintf( D_ALWAYS, "Failed close recovery file\n" );
unlink( tmp_file.Value() );
return;
}
if ( rotate_file( tmp_file.Value(), m_recoveryFile.Value() ) != 0 ) {
dprintf( D_ALWAYS, "Failed to rename recovery file\n" );
unlink( tmp_file.Value() );
}
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,159 | CStarter::classadCommand( int, Stream* s )
{
ClassAd ad;
ReliSock* rsock = (ReliSock*)s;
int cmd = 0;
cmd = getCmdFromReliSock( rsock, &ad, false );
switch( cmd ) {
case FALSE:
return FALSE;
break;
case CA_RECONNECT_JOB:
return jic->reconnect( rsock, &ad );
break;
default:
const char* tmp = getCommandString(cmd);
MyString err_msg = "Starter does not support command (";
err_msg += tmp;
err_msg += ')';
sendErrorReply( s, tmp, CA_INVALID_REQUEST, err_msg.Value() );
return FALSE;
}
return TRUE;
}
| DoS Exec Code | 0 | CStarter::classadCommand( int, Stream* s )
{
ClassAd ad;
ReliSock* rsock = (ReliSock*)s;
int cmd = 0;
cmd = getCmdFromReliSock( rsock, &ad, false );
switch( cmd ) {
case FALSE:
return FALSE;
break;
case CA_RECONNECT_JOB:
return jic->reconnect( rsock, &ad );
break;
default:
const char* tmp = getCommandString(cmd);
MyString err_msg = "Starter does not support command (";
err_msg += tmp;
err_msg += ')';
sendErrorReply( s, tmp, CA_INVALID_REQUEST, err_msg.Value() );
return FALSE;
}
return TRUE;
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,160 | CStarter::cleanupJobs( void )
{
UserProc *job;
m_reaped_job_list.Rewind();
while( (job = m_reaped_job_list.Next()) != NULL) {
if( job->JobExit() ) {
m_reaped_job_list.DeleteCurrent();
delete job;
} else {
dprintf( D_ALWAYS, "JobExit() failed, waiting for job "
"lease to expire or for a reconnect attempt\n" );
return false;
}
}
jic->allJobsGone();
return true;
}
| DoS Exec Code | 0 | CStarter::cleanupJobs( void )
{
UserProc *job;
m_reaped_job_list.Rewind();
while( (job = m_reaped_job_list.Next()) != NULL) {
if( job->JobExit() ) {
m_reaped_job_list.DeleteCurrent();
delete job;
} else {
dprintf( D_ALWAYS, "JobExit() failed, waiting for job "
"lease to expire or for a reconnect attempt\n" );
return false;
}
}
jic->allJobsGone();
return true;
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,161 | CStarter::closeSavedStderr( void )
{
if( starter_stderr_fd > -1 ) {
close( starter_stderr_fd );
starter_stderr_fd = -1;
}
}
| DoS Exec Code | 0 | CStarter::closeSavedStderr( void )
{
if( starter_stderr_fd > -1 ) {
close( starter_stderr_fd );
starter_stderr_fd = -1;
}
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,162 | CStarter::closeSavedStdin( void )
{
if( starter_stdin_fd > -1 ) {
close( starter_stdin_fd );
starter_stdin_fd = -1;
}
}
| DoS Exec Code | 0 | CStarter::closeSavedStdin( void )
{
if( starter_stdin_fd > -1 ) {
close( starter_stdin_fd );
starter_stdin_fd = -1;
}
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,163 | CStarter::closeSavedStdout( void )
{
if( starter_stdout_fd > -1 ) {
close( starter_stdout_fd );
starter_stdout_fd = -1;
}
}
| DoS Exec Code | 0 | CStarter::closeSavedStdout( void )
{
if( starter_stdout_fd > -1 ) {
close( starter_stdout_fd );
starter_stdout_fd = -1;
}
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,164 | CStarter::createJobOwnerSecSession( int /*cmd*/, Stream* s )
{
MyString fqu;
getJobOwnerFQUOrDummy(fqu);
ASSERT( !fqu.IsEmpty() );
MyString error_msg;
ClassAd input;
s->decode();
if( !input.initFromStream(*s) || !s->end_of_message() ) {
dprintf(D_ALWAYS,"Failed to read request in createJobOwnerSecSession()\n");
return FALSE;
}
MyString job_claim_id;
MyString input_claim_id;
getJobClaimId(job_claim_id);
input.LookupString(ATTR_CLAIM_ID,input_claim_id);
if( job_claim_id != input_claim_id || job_claim_id.IsEmpty() ) {
dprintf(D_ALWAYS,
"Claim ID provided to createJobOwnerSecSession does not match "
"expected value! Rejecting connection from %s\n",
s->peer_description());
return FALSE;
}
char *session_id = Condor_Crypt_Base::randomHexKey();
char *session_key = Condor_Crypt_Base::randomHexKey();
MyString session_info;
input.LookupString(ATTR_SESSION_INFO,session_info);
IpVerify* ipv = daemonCore->getSecMan()->getIpVerify();
bool rc = ipv->PunchHole(READ, fqu);
if( !rc ) {
error_msg = "Starter failed to create authorization entry for job owner.";
}
if( rc ) {
rc = daemonCore->getSecMan()->CreateNonNegotiatedSecuritySession(
READ,
session_id,
session_key,
session_info.Value(),
fqu.Value(),
NULL,
0 );
}
if( rc ) {
session_info = "";
rc = daemonCore->getSecMan()->ExportSecSessionInfo(
session_id,
session_info );
}
ClassAd response;
response.Assign(ATTR_VERSION,CondorVersion());
if( !rc ) {
if( error_msg.IsEmpty() ) {
error_msg = "Failed to create security session.";
}
response.Assign(ATTR_RESULT,false);
response.Assign(ATTR_ERROR_STRING,error_msg);
dprintf(D_ALWAYS,
"createJobOwnerSecSession failed: %s\n", error_msg.Value());
}
else {
ClaimIdParser claimid(session_id,session_info.Value(),session_key);
response.Assign(ATTR_RESULT,true);
response.Assign(ATTR_CLAIM_ID,claimid.claimId());
response.Assign(ATTR_STARTER_IP_ADDR,daemonCore->publicNetworkIpAddr());
dprintf(D_FULLDEBUG,"Created security session for job owner (%s).\n",
fqu.Value());
}
if( !response.put(*s) || !s->end_of_message() ) {
dprintf(D_ALWAYS,
"createJobOwnerSecSession failed to send response\n");
}
free( session_id );
free( session_key );
return TRUE;
}
| DoS Exec Code | 0 | CStarter::createJobOwnerSecSession( int /*cmd*/, Stream* s )
{
MyString fqu;
getJobOwnerFQUOrDummy(fqu);
ASSERT( !fqu.IsEmpty() );
MyString error_msg;
ClassAd input;
s->decode();
if( !input.initFromStream(*s) || !s->end_of_message() ) {
dprintf(D_ALWAYS,"Failed to read request in createJobOwnerSecSession()\n");
return FALSE;
}
MyString job_claim_id;
MyString input_claim_id;
getJobClaimId(job_claim_id);
input.LookupString(ATTR_CLAIM_ID,input_claim_id);
if( job_claim_id != input_claim_id || job_claim_id.IsEmpty() ) {
dprintf(D_ALWAYS,
"Claim ID provided to createJobOwnerSecSession does not match "
"expected value! Rejecting connection from %s\n",
s->peer_description());
return FALSE;
}
char *session_id = Condor_Crypt_Base::randomHexKey();
char *session_key = Condor_Crypt_Base::randomHexKey();
MyString session_info;
input.LookupString(ATTR_SESSION_INFO,session_info);
IpVerify* ipv = daemonCore->getSecMan()->getIpVerify();
bool rc = ipv->PunchHole(READ, fqu);
if( !rc ) {
error_msg = "Starter failed to create authorization entry for job owner.";
}
if( rc ) {
rc = daemonCore->getSecMan()->CreateNonNegotiatedSecuritySession(
READ,
session_id,
session_key,
session_info.Value(),
fqu.Value(),
NULL,
0 );
}
if( rc ) {
session_info = "";
rc = daemonCore->getSecMan()->ExportSecSessionInfo(
session_id,
session_info );
}
ClassAd response;
response.Assign(ATTR_VERSION,CondorVersion());
if( !rc ) {
if( error_msg.IsEmpty() ) {
error_msg = "Failed to create security session.";
}
response.Assign(ATTR_RESULT,false);
response.Assign(ATTR_ERROR_STRING,error_msg);
dprintf(D_ALWAYS,
"createJobOwnerSecSession failed: %s\n", error_msg.Value());
}
else {
ClaimIdParser claimid(session_id,session_info.Value(),session_key);
response.Assign(ATTR_RESULT,true);
response.Assign(ATTR_CLAIM_ID,claimid.claimId());
response.Assign(ATTR_STARTER_IP_ADDR,daemonCore->publicNetworkIpAddr());
dprintf(D_FULLDEBUG,"Created security session for job owner (%s).\n",
fqu.Value());
}
if( !response.put(*s) || !s->end_of_message() ) {
dprintf(D_ALWAYS,
"createJobOwnerSecSession failed to send response\n");
}
free( session_id );
free( session_key );
return TRUE;
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,165 | CStarter::createTempExecuteDir( void )
{
if( is_gridshell ) {
dprintf( D_ALWAYS, "gridshell running in: \"%s\"\n", WorkingDir.Value() );
return true;
}
#ifndef WIN32
bool use_chown = false;
if (can_switch_ids()) {
struct stat st;
if (stat(Execute, &st) == -1) {
EXCEPT("stat failed on %s: %s",
Execute,
strerror(errno));
}
if (!(st.st_mode & S_IWOTH)) {
use_chown = true;
}
}
priv_state priv;
if (use_chown) {
priv = set_condor_priv();
}
else {
priv = set_user_priv();
}
#else
priv_state priv = set_condor_priv();
#endif
CondorPrivSepHelper* cpsh = condorPrivSepHelper();
if (cpsh != NULL) {
cpsh->initialize_sandbox(WorkingDir.Value());
WriteAdFiles();
} else {
if( mkdir(WorkingDir.Value(), 0777) < 0 ) {
dprintf( D_FAILURE|D_ALWAYS,
"couldn't create dir %s: %s\n",
WorkingDir.Value(),
strerror(errno) );
set_priv( priv );
return false;
}
WriteAdFiles();
#if !defined(WIN32)
if (use_chown) {
priv_state p = set_root_priv();
if (chown(WorkingDir.Value(),
get_user_uid(),
get_user_gid()) == -1)
{
EXCEPT("chown error on %s: %s",
WorkingDir.Value(),
strerror(errno));
}
set_priv(p);
}
#endif
}
#ifdef WIN32
{
canonicalize_dir_delimiters(WorkingDir);
perm dirperm;
const char * nobody_login = get_user_loginname();
ASSERT(nobody_login);
dirperm.init(nobody_login);
bool ret_val = dirperm.set_acls( WorkingDir.Value() );
if ( !ret_val ) {
dprintf(D_ALWAYS,"UNABLE TO SET PERMISSIONS ON EXECUTE DIRECTORY\n");
set_priv( priv );
return false;
}
}
if ( param_boolean_crufty("ENCRYPT_EXECUTE_DIRECTORY", false) ) {
typedef BOOL (WINAPI *FPEncryptionDisable)(LPCWSTR,BOOL);
typedef BOOL (WINAPI *FPEncryptFileA)(LPCSTR);
bool efs_support = true;
HINSTANCE advapi = LoadLibrary("ADVAPI32.dll");
if ( !advapi ) {
dprintf(D_FULLDEBUG, "Can't load advapi32.dll\n");
efs_support = false;
}
FPEncryptionDisable EncryptionDisable = (FPEncryptionDisable)
GetProcAddress(advapi,"EncryptionDisable");
if ( !EncryptionDisable ) {
dprintf(D_FULLDEBUG, "cannot get address for EncryptionDisable()");
efs_support = false;
}
FPEncryptFileA EncryptFile = (FPEncryptFileA)
GetProcAddress(advapi,"EncryptFileA");
if ( !EncryptFile ) {
dprintf(D_FULLDEBUG, "cannot get address for EncryptFile()");
efs_support = false;
}
if ( efs_support ) {
wchar_t *WorkingDir_w = new wchar_t[WorkingDir.Length()+1];
swprintf(WorkingDir_w, L"%S", WorkingDir.Value());
EncryptionDisable(WorkingDir_w, FALSE);
delete[] WorkingDir_w;
if ( EncryptFile(WorkingDir.Value()) == 0 ) {
dprintf(D_ALWAYS, "Could not encrypt execute directory "
"(err=%li)\n", GetLastError());
}
FreeLibrary(advapi); // don't leak the dll library handle
} else {
dprintf(D_ALWAYS, "ENCRYPT_EXECUTE_DIRECTORY set to True, "
"but the Encryption" " functions are unavailable!");
}
} // ENCRYPT_EXECUTE_DIRECTORY is True
#endif /* WIN32 */
if( chdir(WorkingDir.Value()) < 0 ) {
dprintf( D_FAILURE|D_ALWAYS, "couldn't move to %s: %s\n", WorkingDir.Value(),
strerror(errno) );
set_priv( priv );
return false;
}
dprintf( D_FULLDEBUG, "Done moving to directory \"%s\"\n", WorkingDir.Value() );
set_priv( priv );
return true;
}
| DoS Exec Code | 0 | CStarter::createTempExecuteDir( void )
{
if( is_gridshell ) {
dprintf( D_ALWAYS, "gridshell running in: \"%s\"\n", WorkingDir.Value() );
return true;
}
#ifndef WIN32
bool use_chown = false;
if (can_switch_ids()) {
struct stat st;
if (stat(Execute, &st) == -1) {
EXCEPT("stat failed on %s: %s",
Execute,
strerror(errno));
}
if (!(st.st_mode & S_IWOTH)) {
use_chown = true;
}
}
priv_state priv;
if (use_chown) {
priv = set_condor_priv();
}
else {
priv = set_user_priv();
}
#else
priv_state priv = set_condor_priv();
#endif
CondorPrivSepHelper* cpsh = condorPrivSepHelper();
if (cpsh != NULL) {
cpsh->initialize_sandbox(WorkingDir.Value());
WriteAdFiles();
} else {
if( mkdir(WorkingDir.Value(), 0777) < 0 ) {
dprintf( D_FAILURE|D_ALWAYS,
"couldn't create dir %s: %s\n",
WorkingDir.Value(),
strerror(errno) );
set_priv( priv );
return false;
}
WriteAdFiles();
#if !defined(WIN32)
if (use_chown) {
priv_state p = set_root_priv();
if (chown(WorkingDir.Value(),
get_user_uid(),
get_user_gid()) == -1)
{
EXCEPT("chown error on %s: %s",
WorkingDir.Value(),
strerror(errno));
}
set_priv(p);
}
#endif
}
#ifdef WIN32
{
canonicalize_dir_delimiters(WorkingDir);
perm dirperm;
const char * nobody_login = get_user_loginname();
ASSERT(nobody_login);
dirperm.init(nobody_login);
bool ret_val = dirperm.set_acls( WorkingDir.Value() );
if ( !ret_val ) {
dprintf(D_ALWAYS,"UNABLE TO SET PERMISSIONS ON EXECUTE DIRECTORY\n");
set_priv( priv );
return false;
}
}
if ( param_boolean_crufty("ENCRYPT_EXECUTE_DIRECTORY", false) ) {
typedef BOOL (WINAPI *FPEncryptionDisable)(LPCWSTR,BOOL);
typedef BOOL (WINAPI *FPEncryptFileA)(LPCSTR);
bool efs_support = true;
HINSTANCE advapi = LoadLibrary("ADVAPI32.dll");
if ( !advapi ) {
dprintf(D_FULLDEBUG, "Can't load advapi32.dll\n");
efs_support = false;
}
FPEncryptionDisable EncryptionDisable = (FPEncryptionDisable)
GetProcAddress(advapi,"EncryptionDisable");
if ( !EncryptionDisable ) {
dprintf(D_FULLDEBUG, "cannot get address for EncryptionDisable()");
efs_support = false;
}
FPEncryptFileA EncryptFile = (FPEncryptFileA)
GetProcAddress(advapi,"EncryptFileA");
if ( !EncryptFile ) {
dprintf(D_FULLDEBUG, "cannot get address for EncryptFile()");
efs_support = false;
}
if ( efs_support ) {
wchar_t *WorkingDir_w = new wchar_t[WorkingDir.Length()+1];
swprintf(WorkingDir_w, L"%S", WorkingDir.Value());
EncryptionDisable(WorkingDir_w, FALSE);
delete[] WorkingDir_w;
if ( EncryptFile(WorkingDir.Value()) == 0 ) {
dprintf(D_ALWAYS, "Could not encrypt execute directory "
"(err=%li)\n", GetLastError());
}
FreeLibrary(advapi); // don't leak the dll library handle
} else {
dprintf(D_ALWAYS, "ENCRYPT_EXECUTE_DIRECTORY set to True, "
"but the Encryption" " functions are unavailable!");
}
} // ENCRYPT_EXECUTE_DIRECTORY is True
#endif /* WIN32 */
if( chdir(WorkingDir.Value()) < 0 ) {
dprintf( D_FAILURE|D_ALWAYS, "couldn't move to %s: %s\n", WorkingDir.Value(),
strerror(errno) );
set_priv( priv );
return false;
}
dprintf( D_FULLDEBUG, "Done moving to directory \"%s\"\n", WorkingDir.Value() );
set_priv( priv );
return true;
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,166 | static bool extract_delimited_data(
char const *input_buffer,
int input_len,
char const *begin_marker,
char const *end_marker,
MyString &output_buffer,
MyString *error_msg)
{
int start = find_str_in_buffer(input_buffer,input_len,begin_marker);
int end = find_str_in_buffer(input_buffer,input_len,end_marker);
if( start < 0 ) {
if( error_msg ) {
error_msg->sprintf("Failed to find '%s' in input: %.*s",
begin_marker,input_len,input_buffer);
}
return false;
}
start += strlen(begin_marker);
if( end < 0 || end < start ) {
if( error_msg ) {
error_msg->sprintf("Failed to find '%s' in input: %.*s",
end_marker,input_len,input_buffer);
}
return false;
}
output_buffer.sprintf("%.*s",end-start,input_buffer+start);
return true;
}
| DoS Exec Code | 0 | static bool extract_delimited_data(
char const *input_buffer,
int input_len,
char const *begin_marker,
char const *end_marker,
MyString &output_buffer,
MyString *error_msg)
{
int start = find_str_in_buffer(input_buffer,input_len,begin_marker);
int end = find_str_in_buffer(input_buffer,input_len,end_marker);
if( start < 0 ) {
if( error_msg ) {
error_msg->sprintf("Failed to find '%s' in input: %.*s",
begin_marker,input_len,input_buffer);
}
return false;
}
start += strlen(begin_marker);
if( end < 0 || end < start ) {
if( error_msg ) {
error_msg->sprintf("Failed to find '%s' in input: %.*s",
end_marker,input_len,input_buffer);
}
return false;
}
output_buffer.sprintf("%.*s",end-start,input_buffer+start);
return true;
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,167 | static bool extract_delimited_data_as_base64(
char const *input_buffer,
int input_len,
char const *begin_marker,
char const *end_marker,
MyString &output_buffer,
MyString *error_msg)
{
int start = find_str_in_buffer(input_buffer,input_len,begin_marker);
int end = find_str_in_buffer(input_buffer,input_len,end_marker);
if( start < 0 ) {
if( error_msg ) {
error_msg->sprintf("Failed to find '%s' in input: %.*s",
begin_marker,input_len,input_buffer);
}
return false;
}
start += strlen(begin_marker);
if( end < 0 || end < start ) {
if( error_msg ) {
error_msg->sprintf("Failed to find '%s' in input: %.*s",
end_marker,input_len,input_buffer);
}
return false;
}
char *encoded = condor_base64_encode((unsigned char const *)input_buffer+start,end-start);
output_buffer = encoded;
free(encoded);
return true;
}
| DoS Exec Code | 0 | static bool extract_delimited_data_as_base64(
char const *input_buffer,
int input_len,
char const *begin_marker,
char const *end_marker,
MyString &output_buffer,
MyString *error_msg)
{
int start = find_str_in_buffer(input_buffer,input_len,begin_marker);
int end = find_str_in_buffer(input_buffer,input_len,end_marker);
if( start < 0 ) {
if( error_msg ) {
error_msg->sprintf("Failed to find '%s' in input: %.*s",
begin_marker,input_len,input_buffer);
}
return false;
}
start += strlen(begin_marker);
if( end < 0 || end < start ) {
if( error_msg ) {
error_msg->sprintf("Failed to find '%s' in input: %.*s",
end_marker,input_len,input_buffer);
}
return false;
}
char *encoded = condor_base64_encode((unsigned char const *)input_buffer+start,end-start);
output_buffer = encoded;
free(encoded);
return true;
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,168 | static int find_str_in_buffer(
char const *buffer,
int buffer_len,
char const *str)
{
int str_len = strlen(str);
int i;
for(i=0; i+str_len <= buffer_len; i++) {
if( memcmp(buffer+i,str,str_len)==0 ) {
return i;
}
}
return -1;
}
| DoS Exec Code | 0 | static int find_str_in_buffer(
char const *buffer,
int buffer_len,
char const *str)
{
int str_len = strlen(str);
int i;
for(i=0; i+str_len <= buffer_len; i++) {
if( memcmp(buffer+i,str,str_len)==0 ) {
return i;
}
}
return -1;
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,169 | bool CStarter::getJobClaimId(MyString &result)
{
ClassAd *jobAd = jic ? jic->jobClassAd() : NULL;
if( jobAd ) {
return jobAd->LookupString(ATTR_CLAIM_ID,result);
}
return false;
}
| DoS Exec Code | 0 | bool CStarter::getJobClaimId(MyString &result)
{
ClassAd *jobAd = jic ? jic->jobClassAd() : NULL;
if( jobAd ) {
return jobAd->LookupString(ATTR_CLAIM_ID,result);
}
return false;
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,170 | void CStarter::getJobOwnerFQUOrDummy(MyString &result)
{
ClassAd *jobAd = jic ? jic->jobClassAd() : NULL;
if( jobAd ) {
jobAd->LookupString(ATTR_USER,result);
}
if( result.IsEmpty() ) {
result = "job-owner@submit-domain";
}
}
| DoS Exec Code | 0 | void CStarter::getJobOwnerFQUOrDummy(MyString &result)
{
ClassAd *jobAd = jic ? jic->jobClassAd() : NULL;
if( jobAd ) {
jobAd->LookupString(ATTR_USER,result);
}
if( result.IsEmpty() ) {
result = "job-owner@submit-domain";
}
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,171 | CStarter::getMySlotNumber( void )
{
char *logappend = param("STARTER_LOG");
char const *tmp = NULL;
int slot_number = 0; // default to 0, let our caller decide how to
if ( logappend ) {
char const *log_basename = condor_basename(logappend);
MyString prefix;
char* resource_prefix = param("STARTD_RESOURCE_PREFIX");
if( resource_prefix ) {
prefix.sprintf(".%s",resource_prefix);
free( resource_prefix );
}
else {
prefix = ".slot";
}
tmp = strstr(log_basename, prefix.Value());
if ( tmp ) {
prefix += "%d";
if ( sscanf(tmp, prefix.Value(), &slot_number) < 1 ) {
slot_number = 0;
}
}
free(logappend);
}
return slot_number;
}
| DoS Exec Code | 0 | CStarter::getMySlotNumber( void )
{
char *logappend = param("STARTER_LOG");
char const *tmp = NULL;
int slot_number = 0; // default to 0, let our caller decide how to
if ( logappend ) {
char const *log_basename = condor_basename(logappend);
MyString prefix;
char* resource_prefix = param("STARTD_RESOURCE_PREFIX");
if( resource_prefix ) {
prefix.sprintf(".%s",resource_prefix);
free( resource_prefix );
}
else {
prefix = ".slot";
}
tmp = strstr(log_basename, prefix.Value());
if ( tmp ) {
prefix += "%d";
if ( sscanf(tmp, prefix.Value(), &slot_number) < 1 ) {
slot_number = 0;
}
}
free(logappend);
}
return slot_number;
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,172 | CStarter::publishJobExitAd( ClassAd* ad )
{
return publishJobInfoAd(&m_reaped_job_list, ad);
}
| DoS Exec Code | 0 | CStarter::publishJobExitAd( ClassAd* ad )
{
return publishJobInfoAd(&m_reaped_job_list, ad);
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,173 | CStarter::publishJobInfoAd(List<UserProc>* proc_list, ClassAd* ad)
{
bool found_one = false;
if( pre_script && pre_script->PublishUpdateAd(ad) ) {
found_one = true;
}
if (m_deferred_job_update)
{
MyString buf;
buf.sprintf( "%s=\"Exited\"", ATTR_JOB_STATE );
}
UserProc *job;
proc_list->Rewind();
while ((job = proc_list->Next()) != NULL) {
if( job->PublishUpdateAd(ad) ) {
found_one = true;
}
}
if( post_script && post_script->PublishUpdateAd(ad) ) {
found_one = true;
}
return found_one;
}
| DoS Exec Code | 0 | CStarter::publishJobInfoAd(List<UserProc>* proc_list, ClassAd* ad)
{
bool found_one = false;
if( pre_script && pre_script->PublishUpdateAd(ad) ) {
found_one = true;
}
if (m_deferred_job_update)
{
MyString buf;
buf.sprintf( "%s=\"Exited\"", ATTR_JOB_STATE );
}
UserProc *job;
proc_list->Rewind();
while ((job = proc_list->Next()) != NULL) {
if( job->PublishUpdateAd(ad) ) {
found_one = true;
}
}
if( post_script && post_script->PublishUpdateAd(ad) ) {
found_one = true;
}
return found_one;
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,174 | CStarter::publishPostScriptUpdateAd( ClassAd* ad )
{
if( post_script && post_script->PublishUpdateAd(ad) ) {
return true;
}
return false;
}
| DoS Exec Code | 0 | CStarter::publishPostScriptUpdateAd( ClassAd* ad )
{
if( post_script && post_script->PublishUpdateAd(ad) ) {
return true;
}
return false;
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,175 | CStarter::publishPreScriptUpdateAd( ClassAd* ad )
{
if( pre_script && pre_script->PublishUpdateAd(ad) ) {
return true;
}
return false;
}
| DoS Exec Code | 0 | CStarter::publishPreScriptUpdateAd( ClassAd* ad )
{
if( pre_script && pre_script->PublishUpdateAd(ad) ) {
return true;
}
return false;
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,176 | CStarter::remoteHoldCommand( int /*cmd*/, Stream* s )
{
MyString hold_reason;
int hold_code;
int hold_subcode;
s->decode();
if( !s->get(hold_reason) ||
!s->get(hold_code) ||
!s->get(hold_subcode) ||
!s->end_of_message() )
{
dprintf(D_ALWAYS,"Failed to read message from %s in CStarter::remoteHoldCommand()\n", s->peer_description());
return FALSE;
}
if( jic ) {
jic->holdJob(hold_reason.Value(),hold_code,hold_subcode);
}
int reply = 1;
s->encode();
if( !s->put(reply) || !s->end_of_message()) {
dprintf(D_ALWAYS,"Failed to send response to startd in CStarter::remoteHoldCommand()\n");
}
if ( this->Hold( ) ) {
dprintf( D_FULLDEBUG, "Got Hold when no jobs running\n" );
this->allJobsDone();
return ( true );
}
return ( false );
}
| DoS Exec Code | 0 | CStarter::remoteHoldCommand( int /*cmd*/, Stream* s )
{
MyString hold_reason;
int hold_code;
int hold_subcode;
s->decode();
if( !s->get(hold_reason) ||
!s->get(hold_code) ||
!s->get(hold_subcode) ||
!s->end_of_message() )
{
dprintf(D_ALWAYS,"Failed to read message from %s in CStarter::remoteHoldCommand()\n", s->peer_description());
return FALSE;
}
if( jic ) {
jic->holdJob(hold_reason.Value(),hold_code,hold_subcode);
}
int reply = 1;
s->encode();
if( !s->put(reply) || !s->end_of_message()) {
dprintf(D_ALWAYS,"Failed to send response to startd in CStarter::remoteHoldCommand()\n");
}
if ( this->Hold( ) ) {
dprintf( D_FULLDEBUG, "Got Hold when no jobs running\n" );
this->allJobsDone();
return ( true );
}
return ( false );
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,177 | CStarter::removeTempExecuteDir( void )
{
if( is_gridshell ) {
return true;
}
MyString dir_name = "dir_";
dir_name += (int)daemonCore->getpid();
#if !defined(WIN32)
if (condorPrivSepHelper() != NULL) {
MyString path_name;
path_name.sprintf("%s/%s", Execute, dir_name.Value());
if (!privsep_remove_dir(path_name.Value())) {
dprintf(D_ALWAYS,
"privsep_remove_dir failed for %s\n",
path_name.Value());
return false;
}
return true;
}
#endif
Directory execute_dir( Execute, PRIV_ROOT );
if ( execute_dir.Find_Named_Entry( dir_name.Value() ) ) {
chdir(Execute);
dprintf( D_FULLDEBUG, "Removing %s%c%s\n", Execute,
DIR_DELIM_CHAR, dir_name.Value() );
return execute_dir.Remove_Current_File();
}
return true;
}
| DoS Exec Code | 0 | CStarter::removeTempExecuteDir( void )
{
if( is_gridshell ) {
return true;
}
MyString dir_name = "dir_";
dir_name += (int)daemonCore->getpid();
#if !defined(WIN32)
if (condorPrivSepHelper() != NULL) {
MyString path_name;
path_name.sprintf("%s/%s", Execute, dir_name.Value());
if (!privsep_remove_dir(path_name.Value())) {
dprintf(D_ALWAYS,
"privsep_remove_dir failed for %s\n",
path_name.Value());
return false;
}
return true;
}
#endif
Directory execute_dir( Execute, PRIV_ROOT );
if ( execute_dir.Find_Named_Entry( dir_name.Value() ) ) {
chdir(Execute);
dprintf( D_FULLDEBUG, "Removing %s%c%s\n", Execute,
DIR_DELIM_CHAR, dir_name.Value() );
return execute_dir.Remove_Current_File();
}
return true;
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,178 | CStarter::startSSHD( int /*cmd*/, Stream* s )
{
MyString error_msg;
Sock *sock = (Sock*)s;
char const *fqu = sock->getFullyQualifiedUser();
MyString job_owner;
getJobOwnerFQUOrDummy(job_owner);
if( !fqu || job_owner != fqu ) {
dprintf(D_ALWAYS,"Unauthorized attempt to start sshd by '%s'\n",
fqu ? fqu : "");
return FALSE;
}
ClassAd input;
s->decode();
if( !input.initFromStream(*s) || !s->end_of_message() ) {
dprintf(D_ALWAYS,"Failed to read request in START_SSHD.\n");
return FALSE;
}
#if !defined(HAVE_SSH_TO_JOB)
return SSHDFailed(s,"This version of condor_starter does not support ssh access.");
#else
ClassAd *jobad = NULL;
ClassAd *machinead = NULL;
if( jic ) {
jobad = jic->jobClassAd();
machinead = jic->machClassAd();
}
bool enabled = param_boolean("ENABLE_SSH_TO_JOB",true,true,machinead,jobad);
if( !enabled ) {
return SSHDFailed(s,"Rejecting request, because ENABLE_SSH_TO_JOB=false");
}
if( !jic || !jobad ) {
return SSHDRetry(s,"Rejecting request, because job not yet initialized.");
}
if( !m_job_environment_is_ready ) {
return SSHDRetry(s,"Rejecting request, because the job execution environment is not yet ready.");
}
if( m_all_jobs_done ) {
return SSHDFailed(s,"Rejecting request, because the job is finished.");
}
if( suspended ) {
return SSHDRetry(s,"This slot is currently suspended.");
}
MyString preferred_shells;
input.LookupString(ATTR_SHELL,preferred_shells);
MyString slot_name;
input.LookupString(ATTR_NAME,slot_name);
if( !jic->userPrivInitialized() ) {
return SSHDRetry(s,"Rejecting request, because job execution account not yet established.");
}
MyString libexec;
if( !param(libexec,"LIBEXEC") ) {
return SSHDFailed(s,"LIBEXEC not defined, so cannot find condor_ssh_to_job_sshd_setup");
}
MyString ssh_to_job_sshd_setup;
MyString ssh_to_job_shell_setup;
ssh_to_job_sshd_setup.sprintf(
"%s%ccondor_ssh_to_job_sshd_setup",libexec.Value(),DIR_DELIM_CHAR);
ssh_to_job_shell_setup.sprintf(
"%s%ccondor_ssh_to_job_shell_setup",libexec.Value(),DIR_DELIM_CHAR);
if( access(ssh_to_job_sshd_setup.Value(),X_OK)!=0 ) {
return SSHDFailed(s,"Cannot execute %s: %s",
ssh_to_job_sshd_setup.Value(),strerror(errno));
}
if( access(ssh_to_job_shell_setup.Value(),X_OK)!=0 ) {
return SSHDFailed(s,"Cannot execute %s: %s",
ssh_to_job_shell_setup.Value(),strerror(errno));
}
MyString sshd_config_template;
if( !param(sshd_config_template,"SSH_TO_JOB_SSHD_CONFIG_TEMPLATE") ) {
if( param(sshd_config_template,"LIB") ) {
sshd_config_template.sprintf_cat("%ccondor_ssh_to_job_sshd_config_template",DIR_DELIM_CHAR);
}
else {
return SSHDFailed(s,"SSH_TO_JOB_SSHD_CONFIG_TEMPLATE and LIB are not defined. At least one of them is required.");
}
}
if( access(sshd_config_template.Value(),F_OK)!=0 ) {
return SSHDFailed(s,"%s does not exist!",sshd_config_template.Value());
}
MyString ssh_keygen;
MyString ssh_keygen_args;
ArgList ssh_keygen_arglist;
param(ssh_keygen,"SSH_TO_JOB_SSH_KEYGEN","/usr/bin/ssh-keygen");
param(ssh_keygen_args,"SSH_TO_JOB_SSH_KEYGEN_ARGS","\"-N '' -C '' -q -f %f -t rsa\"");
ssh_keygen_arglist.AppendArg(ssh_keygen.Value());
if( !ssh_keygen_arglist.AppendArgsV2Quoted(ssh_keygen_args.Value(),&error_msg) ) {
return SSHDFailed(s,
"SSH_TO_JOB_SSH_KEYGEN_ARGS is misconfigured: %s",
error_msg.Value());
}
MyString client_keygen_args;
input.LookupString(ATTR_SSH_KEYGEN_ARGS,client_keygen_args);
if( !ssh_keygen_arglist.AppendArgsV2Raw(client_keygen_args.Value(),&error_msg) ) {
return SSHDFailed(s,
"Failed to produce ssh-keygen arg list: %s",
error_msg.Value());
}
MyString ssh_keygen_cmd;
if(!ssh_keygen_arglist.GetArgsStringSystem(&ssh_keygen_cmd,0,&error_msg)) {
return SSHDFailed(s,
"Failed to produce ssh-keygen command string: %s",
error_msg.Value());
}
int setup_pipe_fds[2];
setup_pipe_fds[0] = -1;
setup_pipe_fds[1] = -1;
if( !daemonCore->Create_Pipe(setup_pipe_fds) ) {
return SSHDFailed(
s,"Failed to create pipe for condor_ssh_to_job_sshd_setup.");
}
int setup_std_fds[3];
setup_std_fds[0] = 0;
setup_std_fds[1] = setup_pipe_fds[1]; // write end of pipe
setup_std_fds[2] = setup_pipe_fds[1];
Env setup_env;
if( !GetJobEnv( jobad, &setup_env, &error_msg ) ) {
return SSHDFailed(
s,"Failed to get job environment: %s",error_msg.Value());
}
if( !slot_name.IsEmpty() ) {
setup_env.SetEnv("_CONDOR_SLOT_NAME",slot_name.Value());
}
int setup_opt_mask = 0;
if (!param_boolean("JOB_INHERITS_STARTER_ENVIRONMENT",false)) {
setup_opt_mask = DCJOBOPT_NO_ENV_INHERIT;
}
if( !preferred_shells.IsEmpty() ) {
dprintf(D_FULLDEBUG,
"Checking preferred shells: %s\n",preferred_shells.Value());
StringList shells(preferred_shells.Value(),",");
shells.rewind();
char *shell;
while( (shell=shells.next()) ) {
if( access(shell,X_OK)==0 ) {
dprintf(D_FULLDEBUG,"Will use shell %s\n",shell);
setup_env.SetEnv("_CONDOR_SHELL",shell);
break;
}
}
}
ArgList setup_args;
setup_args.AppendArg(ssh_to_job_sshd_setup.Value());
setup_args.AppendArg(GetWorkingDir());
setup_args.AppendArg(ssh_to_job_shell_setup.Value());
setup_args.AppendArg(sshd_config_template.Value());
setup_args.AppendArg(ssh_keygen_cmd.Value());
int setup_reaper = 1;
int setup_pid;
if( privSepHelper() ) {
setup_pid = privSepHelper()->create_process(
ssh_to_job_sshd_setup.Value(),
setup_args,
setup_env,
GetWorkingDir(),
setup_std_fds,
NULL,
0,
NULL,
setup_reaper,
setup_opt_mask,
NULL);
}
else {
setup_pid = daemonCore->Create_Process(
ssh_to_job_sshd_setup.Value(),
setup_args,
PRIV_USER_FINAL,
setup_reaper,
FALSE,
&setup_env,
GetWorkingDir(),
NULL,
NULL,
setup_std_fds,
NULL,
0,
NULL,
setup_opt_mask);
}
daemonCore->Close_Pipe(setup_pipe_fds[1]); // write-end of pipe
char *setup_output = NULL;
int setup_output_len = 0;
char pipe_buf[1024];
while( true ) {
int n = daemonCore->Read_Pipe(setup_pipe_fds[0],pipe_buf,1024);
if( n <= 0 ) {
break;
}
char *old_setup_output = setup_output;
setup_output = (char *)realloc(setup_output,setup_output_len+n+1);
if( !setup_output ) {
free( old_setup_output );
daemonCore->Close_Pipe(setup_pipe_fds[0]); // read-end of pipe
return SSHDFailed(s,"Out of memory");
}
memcpy(setup_output+setup_output_len,pipe_buf,n);
setup_output_len += n;
setup_output[setup_output_len] = '\0';
}
daemonCore->Close_Pipe(setup_pipe_fds[0]); // read-end of pipe
if( find_str_in_buffer(setup_output,setup_output_len,"condor_ssh_to_job_sshd_setup SUCCESS") < 0 ) {
error_msg.sprintf("condor_ssh_to_job_sshd_setup failed: %s",
setup_output);
free( setup_output );
return SSHDFailed(s,"%s",error_msg.Value());
}
bool rc = true;
MyString session_dir;
if( rc ) {
rc = extract_delimited_data(
setup_output,
setup_output_len,
"condor_ssh_to_job_sshd_setup SSHD DIR BEGIN\n",
"\ncondor_ssh_to_job_sshd_setup SSHD DIR END\n",
session_dir,
&error_msg);
}
MyString sshd_user;
if( rc ) {
rc = extract_delimited_data(
setup_output,
setup_output_len,
"condor_ssh_to_job_sshd_setup SSHD USER BEGIN\n",
"\ncondor_ssh_to_job_sshd_setup SSHD USER END\n",
sshd_user,
&error_msg);
}
MyString public_host_key;
if( rc ) {
rc = extract_delimited_data_as_base64(
setup_output,
setup_output_len,
"condor_ssh_to_job_sshd_setup PUBLIC SERVER KEY BEGIN\n",
"condor_ssh_to_job_sshd_setup PUBLIC SERVER KEY END\n",
public_host_key,
&error_msg);
}
MyString private_client_key;
if( rc ) {
rc = extract_delimited_data_as_base64(
setup_output,
setup_output_len,
"condor_ssh_to_job_sshd_setup AUTHORIZED CLIENT KEY BEGIN\n",
"condor_ssh_to_job_sshd_setup AUTHORIZED CLIENT KEY END\n",
private_client_key,
&error_msg);
}
free( setup_output );
if( !rc ) {
MyString msg;
return SSHDFailed(s,
"Failed to parse output of condor_ssh_to_job_sshd_setup: %s",
error_msg.Value());
}
dprintf(D_FULLDEBUG,"StartSSHD: session_dir='%s'\n",session_dir.Value());
MyString sshd_config_file;
sshd_config_file.sprintf("%s%csshd_config",session_dir.Value(),DIR_DELIM_CHAR);
MyString sshd;
param(sshd,"SSH_TO_JOB_SSHD","/usr/sbin/sshd");
if( access(sshd.Value(),X_OK)!=0 ) {
return SSHDFailed(s,"Failed, because sshd not correctly configured (SSH_TO_JOB_SSHD=%s): %s.",sshd.Value(),strerror(errno));
}
ArgList sshd_arglist;
MyString sshd_arg_string;
param(sshd_arg_string,"SSH_TO_JOB_SSHD_ARGS","\"-i -e -f %f\"");
if( !sshd_arglist.AppendArgsV2Quoted(sshd_arg_string.Value(),&error_msg) )
{
return SSHDFailed(s,"Invalid SSH_TO_JOB_SSHD_ARGS (%s): %s",
sshd_arg_string.Value(),error_msg.Value());
}
char **argarray = sshd_arglist.GetStringArray();
sshd_arglist.Clear();
for(int i=0; argarray[i]; i++) {
char const *ptr;
MyString new_arg;
for(ptr=argarray[i]; *ptr; ptr++) {
if( *ptr == '%' ) {
ptr += 1;
if( *ptr == '%' ) {
new_arg += '%';
}
else if( *ptr == 'f' ) {
new_arg += sshd_config_file.Value();
}
else {
return SSHDFailed(s,
"Unexpected %%%c in SSH_TO_JOB_SSHD_ARGS: %s\n",
*ptr ? *ptr : ' ', sshd_arg_string.Value());
}
}
else {
new_arg += *ptr;
}
}
sshd_arglist.AppendArg(new_arg.Value());
}
deleteStringArray(argarray);
argarray = NULL;
ClassAd sshd_ad;
sshd_ad.CopyAttribute(ATTR_REMOTE_USER,jobad);
sshd_ad.CopyAttribute(ATTR_JOB_RUNAS_OWNER,jobad);
sshd_ad.Assign(ATTR_JOB_CMD,sshd.Value());
CondorVersionInfo ver_info;
if( !sshd_arglist.InsertArgsIntoClassAd(&sshd_ad,&ver_info,&error_msg) ) {
return SSHDFailed(s,
"Failed to insert args into sshd job description: %s",
error_msg.Value());
}
if( !setup_env.InsertEnvIntoClassAd(&sshd_ad,&error_msg,NULL,&ver_info) ) {
return SSHDFailed(s,
"Failed to insert environment into sshd job description: %s",
error_msg.Value());
}
ClassAd response;
response.Assign(ATTR_RESULT,true);
response.Assign(ATTR_REMOTE_USER,sshd_user);
response.Assign(ATTR_SSH_PUBLIC_SERVER_KEY,public_host_key.Value());
response.Assign(ATTR_SSH_PRIVATE_CLIENT_KEY,private_client_key.Value());
s->encode();
if( !response.put(*s) || !s->end_of_message() ) {
dprintf(D_ALWAYS,"Failed to send response to START_SSHD.\n");
return FALSE;
}
MyString sshd_log_fname;
sshd_log_fname.sprintf(
"%s%c%s",session_dir.Value(),DIR_DELIM_CHAR,"sshd.log");
int std[3];
char const *std_fname[3];
std[0] = sock->get_file_desc();
std_fname[0] = "stdin";
std[1] = sock->get_file_desc();
std_fname[1] = "stdout";
std[2] = -1;
std_fname[2] = sshd_log_fname.Value();
SSHDProc *proc = new SSHDProc(&sshd_ad);
if( !proc ) {
dprintf(D_ALWAYS,"Failed to create SSHDProc.\n");
return FALSE;
}
if( !proc->StartJob(std,std_fname) ) {
dprintf(D_ALWAYS,"Failed to start sshd.\n");
return FALSE;
}
m_job_list.Append(proc);
if( this->suspended ) {
proc->Suspend();
}
return TRUE;
#endif
}
| DoS Exec Code | 0 | CStarter::startSSHD( int /*cmd*/, Stream* s )
{
MyString error_msg;
Sock *sock = (Sock*)s;
char const *fqu = sock->getFullyQualifiedUser();
MyString job_owner;
getJobOwnerFQUOrDummy(job_owner);
if( !fqu || job_owner != fqu ) {
dprintf(D_ALWAYS,"Unauthorized attempt to start sshd by '%s'\n",
fqu ? fqu : "");
return FALSE;
}
ClassAd input;
s->decode();
if( !input.initFromStream(*s) || !s->end_of_message() ) {
dprintf(D_ALWAYS,"Failed to read request in START_SSHD.\n");
return FALSE;
}
#if !defined(HAVE_SSH_TO_JOB)
return SSHDFailed(s,"This version of condor_starter does not support ssh access.");
#else
ClassAd *jobad = NULL;
ClassAd *machinead = NULL;
if( jic ) {
jobad = jic->jobClassAd();
machinead = jic->machClassAd();
}
bool enabled = param_boolean("ENABLE_SSH_TO_JOB",true,true,machinead,jobad);
if( !enabled ) {
return SSHDFailed(s,"Rejecting request, because ENABLE_SSH_TO_JOB=false");
}
if( !jic || !jobad ) {
return SSHDRetry(s,"Rejecting request, because job not yet initialized.");
}
if( !m_job_environment_is_ready ) {
return SSHDRetry(s,"Rejecting request, because the job execution environment is not yet ready.");
}
if( m_all_jobs_done ) {
return SSHDFailed(s,"Rejecting request, because the job is finished.");
}
if( suspended ) {
return SSHDRetry(s,"This slot is currently suspended.");
}
MyString preferred_shells;
input.LookupString(ATTR_SHELL,preferred_shells);
MyString slot_name;
input.LookupString(ATTR_NAME,slot_name);
if( !jic->userPrivInitialized() ) {
return SSHDRetry(s,"Rejecting request, because job execution account not yet established.");
}
MyString libexec;
if( !param(libexec,"LIBEXEC") ) {
return SSHDFailed(s,"LIBEXEC not defined, so cannot find condor_ssh_to_job_sshd_setup");
}
MyString ssh_to_job_sshd_setup;
MyString ssh_to_job_shell_setup;
ssh_to_job_sshd_setup.sprintf(
"%s%ccondor_ssh_to_job_sshd_setup",libexec.Value(),DIR_DELIM_CHAR);
ssh_to_job_shell_setup.sprintf(
"%s%ccondor_ssh_to_job_shell_setup",libexec.Value(),DIR_DELIM_CHAR);
if( access(ssh_to_job_sshd_setup.Value(),X_OK)!=0 ) {
return SSHDFailed(s,"Cannot execute %s: %s",
ssh_to_job_sshd_setup.Value(),strerror(errno));
}
if( access(ssh_to_job_shell_setup.Value(),X_OK)!=0 ) {
return SSHDFailed(s,"Cannot execute %s: %s",
ssh_to_job_shell_setup.Value(),strerror(errno));
}
MyString sshd_config_template;
if( !param(sshd_config_template,"SSH_TO_JOB_SSHD_CONFIG_TEMPLATE") ) {
if( param(sshd_config_template,"LIB") ) {
sshd_config_template.sprintf_cat("%ccondor_ssh_to_job_sshd_config_template",DIR_DELIM_CHAR);
}
else {
return SSHDFailed(s,"SSH_TO_JOB_SSHD_CONFIG_TEMPLATE and LIB are not defined. At least one of them is required.");
}
}
if( access(sshd_config_template.Value(),F_OK)!=0 ) {
return SSHDFailed(s,"%s does not exist!",sshd_config_template.Value());
}
MyString ssh_keygen;
MyString ssh_keygen_args;
ArgList ssh_keygen_arglist;
param(ssh_keygen,"SSH_TO_JOB_SSH_KEYGEN","/usr/bin/ssh-keygen");
param(ssh_keygen_args,"SSH_TO_JOB_SSH_KEYGEN_ARGS","\"-N '' -C '' -q -f %f -t rsa\"");
ssh_keygen_arglist.AppendArg(ssh_keygen.Value());
if( !ssh_keygen_arglist.AppendArgsV2Quoted(ssh_keygen_args.Value(),&error_msg) ) {
return SSHDFailed(s,
"SSH_TO_JOB_SSH_KEYGEN_ARGS is misconfigured: %s",
error_msg.Value());
}
MyString client_keygen_args;
input.LookupString(ATTR_SSH_KEYGEN_ARGS,client_keygen_args);
if( !ssh_keygen_arglist.AppendArgsV2Raw(client_keygen_args.Value(),&error_msg) ) {
return SSHDFailed(s,
"Failed to produce ssh-keygen arg list: %s",
error_msg.Value());
}
MyString ssh_keygen_cmd;
if(!ssh_keygen_arglist.GetArgsStringSystem(&ssh_keygen_cmd,0,&error_msg)) {
return SSHDFailed(s,
"Failed to produce ssh-keygen command string: %s",
error_msg.Value());
}
int setup_pipe_fds[2];
setup_pipe_fds[0] = -1;
setup_pipe_fds[1] = -1;
if( !daemonCore->Create_Pipe(setup_pipe_fds) ) {
return SSHDFailed(
s,"Failed to create pipe for condor_ssh_to_job_sshd_setup.");
}
int setup_std_fds[3];
setup_std_fds[0] = 0;
setup_std_fds[1] = setup_pipe_fds[1]; // write end of pipe
setup_std_fds[2] = setup_pipe_fds[1];
Env setup_env;
if( !GetJobEnv( jobad, &setup_env, &error_msg ) ) {
return SSHDFailed(
s,"Failed to get job environment: %s",error_msg.Value());
}
if( !slot_name.IsEmpty() ) {
setup_env.SetEnv("_CONDOR_SLOT_NAME",slot_name.Value());
}
int setup_opt_mask = 0;
if (!param_boolean("JOB_INHERITS_STARTER_ENVIRONMENT",false)) {
setup_opt_mask = DCJOBOPT_NO_ENV_INHERIT;
}
if( !preferred_shells.IsEmpty() ) {
dprintf(D_FULLDEBUG,
"Checking preferred shells: %s\n",preferred_shells.Value());
StringList shells(preferred_shells.Value(),",");
shells.rewind();
char *shell;
while( (shell=shells.next()) ) {
if( access(shell,X_OK)==0 ) {
dprintf(D_FULLDEBUG,"Will use shell %s\n",shell);
setup_env.SetEnv("_CONDOR_SHELL",shell);
break;
}
}
}
ArgList setup_args;
setup_args.AppendArg(ssh_to_job_sshd_setup.Value());
setup_args.AppendArg(GetWorkingDir());
setup_args.AppendArg(ssh_to_job_shell_setup.Value());
setup_args.AppendArg(sshd_config_template.Value());
setup_args.AppendArg(ssh_keygen_cmd.Value());
int setup_reaper = 1;
int setup_pid;
if( privSepHelper() ) {
setup_pid = privSepHelper()->create_process(
ssh_to_job_sshd_setup.Value(),
setup_args,
setup_env,
GetWorkingDir(),
setup_std_fds,
NULL,
0,
NULL,
setup_reaper,
setup_opt_mask,
NULL);
}
else {
setup_pid = daemonCore->Create_Process(
ssh_to_job_sshd_setup.Value(),
setup_args,
PRIV_USER_FINAL,
setup_reaper,
FALSE,
&setup_env,
GetWorkingDir(),
NULL,
NULL,
setup_std_fds,
NULL,
0,
NULL,
setup_opt_mask);
}
daemonCore->Close_Pipe(setup_pipe_fds[1]); // write-end of pipe
char *setup_output = NULL;
int setup_output_len = 0;
char pipe_buf[1024];
while( true ) {
int n = daemonCore->Read_Pipe(setup_pipe_fds[0],pipe_buf,1024);
if( n <= 0 ) {
break;
}
char *old_setup_output = setup_output;
setup_output = (char *)realloc(setup_output,setup_output_len+n+1);
if( !setup_output ) {
free( old_setup_output );
daemonCore->Close_Pipe(setup_pipe_fds[0]); // read-end of pipe
return SSHDFailed(s,"Out of memory");
}
memcpy(setup_output+setup_output_len,pipe_buf,n);
setup_output_len += n;
setup_output[setup_output_len] = '\0';
}
daemonCore->Close_Pipe(setup_pipe_fds[0]); // read-end of pipe
if( find_str_in_buffer(setup_output,setup_output_len,"condor_ssh_to_job_sshd_setup SUCCESS") < 0 ) {
error_msg.sprintf("condor_ssh_to_job_sshd_setup failed: %s",
setup_output);
free( setup_output );
return SSHDFailed(s,"%s",error_msg.Value());
}
bool rc = true;
MyString session_dir;
if( rc ) {
rc = extract_delimited_data(
setup_output,
setup_output_len,
"condor_ssh_to_job_sshd_setup SSHD DIR BEGIN\n",
"\ncondor_ssh_to_job_sshd_setup SSHD DIR END\n",
session_dir,
&error_msg);
}
MyString sshd_user;
if( rc ) {
rc = extract_delimited_data(
setup_output,
setup_output_len,
"condor_ssh_to_job_sshd_setup SSHD USER BEGIN\n",
"\ncondor_ssh_to_job_sshd_setup SSHD USER END\n",
sshd_user,
&error_msg);
}
MyString public_host_key;
if( rc ) {
rc = extract_delimited_data_as_base64(
setup_output,
setup_output_len,
"condor_ssh_to_job_sshd_setup PUBLIC SERVER KEY BEGIN\n",
"condor_ssh_to_job_sshd_setup PUBLIC SERVER KEY END\n",
public_host_key,
&error_msg);
}
MyString private_client_key;
if( rc ) {
rc = extract_delimited_data_as_base64(
setup_output,
setup_output_len,
"condor_ssh_to_job_sshd_setup AUTHORIZED CLIENT KEY BEGIN\n",
"condor_ssh_to_job_sshd_setup AUTHORIZED CLIENT KEY END\n",
private_client_key,
&error_msg);
}
free( setup_output );
if( !rc ) {
MyString msg;
return SSHDFailed(s,
"Failed to parse output of condor_ssh_to_job_sshd_setup: %s",
error_msg.Value());
}
dprintf(D_FULLDEBUG,"StartSSHD: session_dir='%s'\n",session_dir.Value());
MyString sshd_config_file;
sshd_config_file.sprintf("%s%csshd_config",session_dir.Value(),DIR_DELIM_CHAR);
MyString sshd;
param(sshd,"SSH_TO_JOB_SSHD","/usr/sbin/sshd");
if( access(sshd.Value(),X_OK)!=0 ) {
return SSHDFailed(s,"Failed, because sshd not correctly configured (SSH_TO_JOB_SSHD=%s): %s.",sshd.Value(),strerror(errno));
}
ArgList sshd_arglist;
MyString sshd_arg_string;
param(sshd_arg_string,"SSH_TO_JOB_SSHD_ARGS","\"-i -e -f %f\"");
if( !sshd_arglist.AppendArgsV2Quoted(sshd_arg_string.Value(),&error_msg) )
{
return SSHDFailed(s,"Invalid SSH_TO_JOB_SSHD_ARGS (%s): %s",
sshd_arg_string.Value(),error_msg.Value());
}
char **argarray = sshd_arglist.GetStringArray();
sshd_arglist.Clear();
for(int i=0; argarray[i]; i++) {
char const *ptr;
MyString new_arg;
for(ptr=argarray[i]; *ptr; ptr++) {
if( *ptr == '%' ) {
ptr += 1;
if( *ptr == '%' ) {
new_arg += '%';
}
else if( *ptr == 'f' ) {
new_arg += sshd_config_file.Value();
}
else {
return SSHDFailed(s,
"Unexpected %%%c in SSH_TO_JOB_SSHD_ARGS: %s\n",
*ptr ? *ptr : ' ', sshd_arg_string.Value());
}
}
else {
new_arg += *ptr;
}
}
sshd_arglist.AppendArg(new_arg.Value());
}
deleteStringArray(argarray);
argarray = NULL;
ClassAd sshd_ad;
sshd_ad.CopyAttribute(ATTR_REMOTE_USER,jobad);
sshd_ad.CopyAttribute(ATTR_JOB_RUNAS_OWNER,jobad);
sshd_ad.Assign(ATTR_JOB_CMD,sshd.Value());
CondorVersionInfo ver_info;
if( !sshd_arglist.InsertArgsIntoClassAd(&sshd_ad,&ver_info,&error_msg) ) {
return SSHDFailed(s,
"Failed to insert args into sshd job description: %s",
error_msg.Value());
}
if( !setup_env.InsertEnvIntoClassAd(&sshd_ad,&error_msg,NULL,&ver_info) ) {
return SSHDFailed(s,
"Failed to insert environment into sshd job description: %s",
error_msg.Value());
}
ClassAd response;
response.Assign(ATTR_RESULT,true);
response.Assign(ATTR_REMOTE_USER,sshd_user);
response.Assign(ATTR_SSH_PUBLIC_SERVER_KEY,public_host_key.Value());
response.Assign(ATTR_SSH_PRIVATE_CLIENT_KEY,private_client_key.Value());
s->encode();
if( !response.put(*s) || !s->end_of_message() ) {
dprintf(D_ALWAYS,"Failed to send response to START_SSHD.\n");
return FALSE;
}
MyString sshd_log_fname;
sshd_log_fname.sprintf(
"%s%c%s",session_dir.Value(),DIR_DELIM_CHAR,"sshd.log");
int std[3];
char const *std_fname[3];
std[0] = sock->get_file_desc();
std_fname[0] = "stdin";
std[1] = sock->get_file_desc();
std_fname[1] = "stdout";
std[2] = -1;
std_fname[2] = sshd_log_fname.Value();
SSHDProc *proc = new SSHDProc(&sshd_ad);
if( !proc ) {
dprintf(D_ALWAYS,"Failed to create SSHDProc.\n");
return FALSE;
}
if( !proc->StartJob(std,std_fname) ) {
dprintf(D_ALWAYS,"Failed to start sshd.\n");
return FALSE;
}
m_job_list.Append(proc);
if( this->suspended ) {
proc->Suspend();
}
return TRUE;
#endif
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,179 | CStarter::transferOutput( void )
{
UserProc *job;
bool transient_failure = false;
if (jic->transferOutput(transient_failure) == false) {
if( transient_failure ) {
return false;
}
m_reaped_job_list.Rewind();
while ((job = m_reaped_job_list.Next()) != NULL) {
ClassAd ad;
int pid;
job->PublishUpdateAd(&ad);
if (ad.LookupInteger(ATTR_JOB_PID, pid)) {
jic->notifyJobTermination(job);
break;
}
}
jic->transferOutputMopUp();
/*
there was an error with the JIC in this step. at this
point, the only possible reason is if we're talking to a
shadow and file transfer failed to send back the files.
in this case, just return to DaemonCore and wait for
other events (like the shadow reconnecting or the startd
deciding the job lease expired and killing us)
*/
dprintf( D_ALWAYS, "JIC::transferOutput() failed, waiting for job "
"lease to expire or for a reconnect attempt\n" );
return false;
}
jic->transferOutputMopUp();
return cleanupJobs();
}
| DoS Exec Code | 0 | CStarter::transferOutput( void )
{
UserProc *job;
bool transient_failure = false;
if (jic->transferOutput(transient_failure) == false) {
if( transient_failure ) {
return false;
}
m_reaped_job_list.Rewind();
while ((job = m_reaped_job_list.Next()) != NULL) {
ClassAd ad;
int pid;
job->PublishUpdateAd(&ad);
if (ad.LookupInteger(ATTR_JOB_PID, pid)) {
jic->notifyJobTermination(job);
break;
}
}
jic->transferOutputMopUp();
/*
there was an error with the JIC in this step. at this
point, the only possible reason is if we're talking to a
shadow and file transfer failed to send back the files.
in this case, just return to DaemonCore and wait for
other events (like the shadow reconnecting or the startd
deciding the job lease expired and killing us)
*/
dprintf( D_ALWAYS, "JIC::transferOutput() failed, waiting for job "
"lease to expire or for a reconnect attempt\n" );
return false;
}
jic->transferOutputMopUp();
return cleanupJobs();
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,180 | CStarter::updateX509Proxy( int cmd, Stream* s )
{
ASSERT(s);
ReliSock* rsock = (ReliSock*)s;
ASSERT(jic);
return jic->updateX509Proxy(cmd,rsock) ? TRUE : FALSE;
}
| DoS Exec Code | 0 | CStarter::updateX509Proxy( int cmd, Stream* s )
{
ASSERT(s);
ReliSock* rsock = (ReliSock*)s;
ASSERT(jic);
return jic->updateX509Proxy(cmd,rsock) ? TRUE : FALSE;
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,181 | CStarter::~CStarter()
{
if( Execute ) {
free(Execute);
}
if( orig_cwd ) {
free(orig_cwd);
}
if( jic ) {
delete jic;
}
if( pre_script ) {
delete( pre_script );
}
if( post_script ) {
delete( post_script );
}
}
| DoS Exec Code | 0 | CStarter::~CStarter()
{
if( Execute ) {
free(Execute);
}
if( orig_cwd ) {
free(orig_cwd);
}
if( jic ) {
delete jic;
}
if( pre_script ) {
delete( pre_script );
}
if( post_script ) {
delete( post_script );
}
}
| @@ -1800,7 +1800,7 @@ CStarter::removeDeferredJobs() {
error += this->jic->jobCluster();
error += ".";
error += this->jic->jobProc();
- EXCEPT( error.Value() );
+ EXCEPT( "%s", error.Value() );
ret = false;
}
return ( ret ); | CWE-134 | null | null |
13,182 | get_aix_arch( struct utsname *buf )
{
char *ret = "UNK";
char d[3];
int model;
/* The model number is encoded in the last two non zero digits of the
model code. */
d[0] = buf->machine[ strlen( buf->machine ) - 4 ];
d[1] = buf->machine[ strlen( buf->machine ) - 3 ];
d[2] = '\0';
model = strtol(d, NULL, 16);
/* ok, group the model numbers into processor families: */
switch(model)
{
case 0x10:
/* Model 530/730 */
break;
case 0x11:
case 0x14:
/* Model 540 */
break;
case 0x18:
/* Model 530H */
break;
case 0x1C:
/* Model 550 */
break;
case 0x20:
/* Model 930 */
break;
case 0x2E:
/* Model 950/950E */
break;
case 0x30:
/* Model 520 or 740/741 */
break;
case 0x31:
/* Model 320 */
break;
case 0x34:
/* Model 520H */
break;
case 0x35:
/* Model 32H/320E */
break;
case 0x37:
/* Model 340/34H */
break;
case 0x38:
/* Model 350 */
break;
case 0x41:
/* Model 220/22W/22G/230 */
break;
case 0x42:
/* Model 41T/41W */
break;
case 0x43:
/* Model M20 */
break;
case 0x45:
/* Model 220/M20/230/23W */
break;
case 0x46:
case 0x49:
/* Model 250 */
break;
case 0x47:
/* Model 230 */
break;
case 0x48:
/* Model C10 */
break;
case 0x4C:
/* PowerPC 603/604 model, and later */
ret = strdup("PWR3II");
break;
case 0x4D:
/* Model 40P */
break;
case 0x57:
/* Model 390/3AT/3BT */
break;
case 0x58:
/* Model 380/3AT/3BT */
break;
case 0x59:
/* Model 39H/3CT */
break;
case 0x5C:
/* Model 560 */
break;
case 0x63:
/* Model 970/97B */
break;
case 0x64:
/* Model 980/98B */
break;
case 0x66:
/* Model 580/58F */
break;
case 0x67:
/* Model 570/770/R10 */
break;
case 0x70:
/* Model 590 */
break;
case 0x71:
/* Model 58H */
break;
case 0x72:
/* Model 59H/58H/R12/R20 */
break;
case 0x75:
/* Model 370/375/37T */
break;
case 0x76:
/* Model 360/365/36T */
break;
case 0x77:
/* Model 315/350/355/510/550H/550L */
break;
case 0x79:
/* Model 591 */
break;
case 0x80:
/* Model 990 */
break;
case 0x81:
/* Model R24 */
break;
case 0x82:
/* Model R00/R24 */
break;
case 0x89:
/* Model 595 */
break;
case 0x90:
/* Model C20 */
break;
case 0x91:
/* Model 42T */
break;
case 0x94:
/* Model 397 */
break;
case 0xA0:
/* Model J30 */
break;
case 0xA1:
/* Model J40 */
break;
case 0xA3:
/* Model R30 */
break;
case 0xA4:
/* Model R40 */
break;
case 0xA6:
/* Model G30 */
break;
case 0xA7:
/* Model G40 */
break;
case 0xC4:
/* Model F30 */
break;
default:
/* unknown model, use default value of ret */
break;
}
return ret;
}
| DoS Exec Code | 0 | get_aix_arch( struct utsname *buf )
{
char *ret = "UNK";
char d[3];
int model;
/* The model number is encoded in the last two non zero digits of the
model code. */
d[0] = buf->machine[ strlen( buf->machine ) - 4 ];
d[1] = buf->machine[ strlen( buf->machine ) - 3 ];
d[2] = '\0';
model = strtol(d, NULL, 16);
/* ok, group the model numbers into processor families: */
switch(model)
{
case 0x10:
/* Model 530/730 */
break;
case 0x11:
case 0x14:
/* Model 540 */
break;
case 0x18:
/* Model 530H */
break;
case 0x1C:
/* Model 550 */
break;
case 0x20:
/* Model 930 */
break;
case 0x2E:
/* Model 950/950E */
break;
case 0x30:
/* Model 520 or 740/741 */
break;
case 0x31:
/* Model 320 */
break;
case 0x34:
/* Model 520H */
break;
case 0x35:
/* Model 32H/320E */
break;
case 0x37:
/* Model 340/34H */
break;
case 0x38:
/* Model 350 */
break;
case 0x41:
/* Model 220/22W/22G/230 */
break;
case 0x42:
/* Model 41T/41W */
break;
case 0x43:
/* Model M20 */
break;
case 0x45:
/* Model 220/M20/230/23W */
break;
case 0x46:
case 0x49:
/* Model 250 */
break;
case 0x47:
/* Model 230 */
break;
case 0x48:
/* Model C10 */
break;
case 0x4C:
/* PowerPC 603/604 model, and later */
ret = strdup("PWR3II");
break;
case 0x4D:
/* Model 40P */
break;
case 0x57:
/* Model 390/3AT/3BT */
break;
case 0x58:
/* Model 380/3AT/3BT */
break;
case 0x59:
/* Model 39H/3CT */
break;
case 0x5C:
/* Model 560 */
break;
case 0x63:
/* Model 970/97B */
break;
case 0x64:
/* Model 980/98B */
break;
case 0x66:
/* Model 580/58F */
break;
case 0x67:
/* Model 570/770/R10 */
break;
case 0x70:
/* Model 590 */
break;
case 0x71:
/* Model 58H */
break;
case 0x72:
/* Model 59H/58H/R12/R20 */
break;
case 0x75:
/* Model 370/375/37T */
break;
case 0x76:
/* Model 360/365/36T */
break;
case 0x77:
/* Model 315/350/355/510/550H/550L */
break;
case 0x79:
/* Model 591 */
break;
case 0x80:
/* Model 990 */
break;
case 0x81:
/* Model R24 */
break;
case 0x82:
/* Model R00/R24 */
break;
case 0x89:
/* Model 595 */
break;
case 0x90:
/* Model C20 */
break;
case 0x91:
/* Model 42T */
break;
case 0x94:
/* Model 397 */
break;
case 0xA0:
/* Model J30 */
break;
case 0xA1:
/* Model J40 */
break;
case 0xA3:
/* Model R30 */
break;
case 0xA4:
/* Model R40 */
break;
case 0xA6:
/* Model G30 */
break;
case 0xA7:
/* Model G40 */
break;
case 0xC4:
/* Model F30 */
break;
default:
/* unknown model, use default value of ret */
break;
}
return ret;
}
| @@ -299,7 +299,7 @@ sysapi_translate_arch( const char *machine, const char *)
}
else {
// Unknown, just use what uname gave:
- sprintf( tmp, machine );
+ sprintf( tmp, "%s", machine );
}
tmparch = strdup( tmp ); | CWE-134 | null | null |
13,183 | init_arch(void)
{
struct utsname buf;
if( uname(&buf) < 0 ) {
return;
}
uname_arch = strdup( buf.machine );
if( !uname_arch ) {
EXCEPT( "Out of memory!" );
}
uname_opsys = strdup( buf.sysname );
if( !uname_opsys ) {
EXCEPT( "Out of memory!" );
}
arch = sysapi_translate_arch( buf.machine, buf.sysname );
opsys = sysapi_translate_opsys( buf.sysname, buf.release, buf.version, _sysapi_opsys_is_versioned );
opsys_versioned = sysapi_translate_opsys( buf.sysname, buf.release, buf.version, true );
opsys_version = sysapi_translate_opsys_version( buf.sysname, buf.release, buf.version );
if ( arch && opsys ) {
arch_inited = TRUE;
}
}
| DoS Exec Code | 0 | init_arch(void)
{
struct utsname buf;
if( uname(&buf) < 0 ) {
return;
}
uname_arch = strdup( buf.machine );
if( !uname_arch ) {
EXCEPT( "Out of memory!" );
}
uname_opsys = strdup( buf.sysname );
if( !uname_opsys ) {
EXCEPT( "Out of memory!" );
}
arch = sysapi_translate_arch( buf.machine, buf.sysname );
opsys = sysapi_translate_opsys( buf.sysname, buf.release, buf.version, _sysapi_opsys_is_versioned );
opsys_versioned = sysapi_translate_opsys( buf.sysname, buf.release, buf.version, true );
opsys_version = sysapi_translate_opsys_version( buf.sysname, buf.release, buf.version );
if ( arch && opsys ) {
arch_inited = TRUE;
}
}
| @@ -299,7 +299,7 @@ sysapi_translate_arch( const char *machine, const char *)
}
else {
// Unknown, just use what uname gave:
- sprintf( tmp, machine );
+ sprintf( tmp, "%s", machine );
}
tmparch = strdup( tmp ); | CWE-134 | null | null |
13,184 | sysapi_condor_arch(void)
{
SYSTEM_INFO info;
GetNativeSystemInfo(&info);
if ( info.wProcessorArchitecture >= PROCESSOR_ARCHITECTURE_INTEL
&& info.wProcessorArchitecture <= PROCESSOR_ARCHITECTURE_IA32_ON_WIN64 ) {
return windows_architectures[info.wProcessorArchitecture];
} else {
return unknown_architecture;
}
}
| DoS Exec Code | 0 | sysapi_condor_arch(void)
{
SYSTEM_INFO info;
GetNativeSystemInfo(&info);
if ( info.wProcessorArchitecture >= PROCESSOR_ARCHITECTURE_INTEL
&& info.wProcessorArchitecture <= PROCESSOR_ARCHITECTURE_IA32_ON_WIN64 ) {
return windows_architectures[info.wProcessorArchitecture];
} else {
return unknown_architecture;
}
}
| @@ -299,7 +299,7 @@ sysapi_translate_arch( const char *machine, const char *)
}
else {
// Unknown, just use what uname gave:
- sprintf( tmp, machine );
+ sprintf( tmp, "%s", machine );
}
tmparch = strdup( tmp ); | CWE-134 | null | null |
13,185 | sysapi_condor_arch(void)
{
if( ! arch_inited ) {
init_arch();
}
return arch;
}
| DoS Exec Code | 0 | sysapi_condor_arch(void)
{
if( ! arch_inited ) {
init_arch();
}
return arch;
}
| @@ -299,7 +299,7 @@ sysapi_translate_arch( const char *machine, const char *)
}
else {
// Unknown, just use what uname gave:
- sprintf( tmp, machine );
+ sprintf( tmp, "%s", machine );
}
tmparch = strdup( tmp ); | CWE-134 | null | null |
13,186 | sysapi_opsys(void)
{
if (_sysapi_opsys_is_versioned) {
return sysapi_opsys_versioned();
}
return "WINDOWS";
}
| DoS Exec Code | 0 | sysapi_opsys(void)
{
if (_sysapi_opsys_is_versioned) {
return sysapi_opsys_versioned();
}
return "WINDOWS";
}
| @@ -299,7 +299,7 @@ sysapi_translate_arch( const char *machine, const char *)
}
else {
// Unknown, just use what uname gave:
- sprintf( tmp, machine );
+ sprintf( tmp, "%s", machine );
}
tmparch = strdup( tmp ); | CWE-134 | null | null |
13,187 | int sysapi_opsys_version()
{
if ( ! opsys_version) {
sysapi_opsys_versioned(); // init opsys_version
}
return opsys_version;
}
| DoS Exec Code | 0 | int sysapi_opsys_version()
{
if ( ! opsys_version) {
sysapi_opsys_versioned(); // init opsys_version
}
return opsys_version;
}
| @@ -299,7 +299,7 @@ sysapi_translate_arch( const char *machine, const char *)
}
else {
// Unknown, just use what uname gave:
- sprintf( tmp, machine );
+ sprintf( tmp, "%s", machine );
}
tmparch = strdup( tmp ); | CWE-134 | null | null |
13,188 | sysapi_opsys_versioned(void)
{
static char answer[128] = {0};
if (answer[0])
return answer;
OSVERSIONINFO info;
info.dwOSVersionInfoSize = sizeof(OSVERSIONINFO);
if (GetVersionEx(&info) > 0) {
switch(info.dwPlatformId) {
case VER_PLATFORM_WIN32s:
sprintf(answer, "WIN32s%d%d", info.dwMajorVersion, info.dwMinorVersion);
break;
case VER_PLATFORM_WIN32_WINDOWS:
sprintf(answer, "WIN32%d%d", info.dwMajorVersion, info.dwMinorVersion);
break;
case VER_PLATFORM_WIN32_NT:
sprintf(answer, "WINNT%d%d", info.dwMajorVersion, info.dwMinorVersion);
break;
default:
sprintf(answer, "UNKNOWN");
break;
}
opsys_version = info.dwMajorVersion * 100 + info.dwMinorVersion;
} else {
sprintf(answer, "ERROR");
}
return answer;
}
| DoS Exec Code | 0 | sysapi_opsys_versioned(void)
{
static char answer[128] = {0};
if (answer[0])
return answer;
OSVERSIONINFO info;
info.dwOSVersionInfoSize = sizeof(OSVERSIONINFO);
if (GetVersionEx(&info) > 0) {
switch(info.dwPlatformId) {
case VER_PLATFORM_WIN32s:
sprintf(answer, "WIN32s%d%d", info.dwMajorVersion, info.dwMinorVersion);
break;
case VER_PLATFORM_WIN32_WINDOWS:
sprintf(answer, "WIN32%d%d", info.dwMajorVersion, info.dwMinorVersion);
break;
case VER_PLATFORM_WIN32_NT:
sprintf(answer, "WINNT%d%d", info.dwMajorVersion, info.dwMinorVersion);
break;
default:
sprintf(answer, "UNKNOWN");
break;
}
opsys_version = info.dwMajorVersion * 100 + info.dwMinorVersion;
} else {
sprintf(answer, "ERROR");
}
return answer;
}
| @@ -299,7 +299,7 @@ sysapi_translate_arch( const char *machine, const char *)
}
else {
// Unknown, just use what uname gave:
- sprintf( tmp, machine );
+ sprintf( tmp, "%s", machine );
}
tmparch = strdup( tmp ); | CWE-134 | null | null |
13,189 | sysapi_opsys_versioned(void)
{
if( ! arch_inited ) {
init_arch();
}
return opsys_versioned;
}
| DoS Exec Code | 0 | sysapi_opsys_versioned(void)
{
if( ! arch_inited ) {
init_arch();
}
return opsys_versioned;
}
| @@ -299,7 +299,7 @@ sysapi_translate_arch( const char *machine, const char *)
}
else {
// Unknown, just use what uname gave:
- sprintf( tmp, machine );
+ sprintf( tmp, "%s", machine );
}
tmparch = strdup( tmp ); | CWE-134 | null | null |
13,190 | sysapi_translate_opsys( const char *sysname,
const char *release,
const char *version,
int append_version)
{
char tmp[64];
char ver[24];
const char * pver="";
char *tmpopsys;
if( !strcmp(sysname, "Linux") ) {
sprintf( tmp, "LINUX" );
}
else if( !strcmp(sysname, "linux") ) { //LDAP entry
sprintf( tmp, "LINUX" );
}
else if( !strcmp(sysname, "SunOS")
|| !strcmp(sysname, "solaris" ) ) //LDAP entry
{
sprintf( tmp, "SOLARIS" );
if ( !strcmp(release, "2.10") //LDAP entry
|| !strcmp(release, "5.10") )
{
pver = "210";
}
else if ( !strcmp(release, "2.9") //LDAP entry
|| !strcmp(release, "5.9") )
{
pver = "29";
}
else if ( !strcmp(release, "2.8") //LDAP entry
|| !strcmp(release, "5.8") )
{
pver = "28";
}
else if ( !strcmp(release, "2.7") //LDAP entry
|| !strcmp(release, "5.7") )
{
pver = "27";
}
else if( !strcmp(release, "5.6")
|| !strcmp(release, "2.6") ) //LDAP entry
{
pver = "26";
}
else if ( !strcmp(release, "5.5.1")
|| !strcmp(release, "2.5.1") ) //LDAP entry
{
pver = "251";
}
else if ( !strcmp(release, "5.5")
|| !strcmp(release, "2.5") ) //LDAP entry
{
pver = "25";
}
else {
pver = release;
}
}
else if( !strcmp(sysname, "HP-UX") ) {
sprintf( tmp, "HPUX" );
if( !strcmp(release, "B.10.20") ) {
pver = "10";
}
else if( !strcmp(release, "B.11.00") ) {
pver = "11";
}
else if( !strcmp(release, "B.11.11") ) {
pver = "11";
}
else {
pver = release;
}
}
else if ( !strncmp(sysname, "Darwin", 6) ) {
sprintf( tmp, "OSX");
}
else if ( !strncmp(sysname, "AIX", 3) ) {
sprintf(tmp, "%s", sysname);
if ( !strcmp(version, "5") ) {
sprintf(ver, "%s%s", version, release);
pver = ver;
}
}
else if ( !strncmp(sysname, "FreeBSD", 7) ) {
sprintf( tmp, "FREEBSD" );
sprintf( ver, "%c", release[0]);
pver = ver;
}
else {
sprintf( tmp, "%s", sysname);
pver = release;
}
if (append_version && pver) {
strcat( tmp, pver );
}
tmpopsys = strdup( tmp );
if( !tmpopsys ) {
EXCEPT( "Out of memory!" );
}
return( tmpopsys );
}
| DoS Exec Code | 0 | sysapi_translate_opsys( const char *sysname,
const char *release,
const char *version,
int append_version)
{
char tmp[64];
char ver[24];
const char * pver="";
char *tmpopsys;
if( !strcmp(sysname, "Linux") ) {
sprintf( tmp, "LINUX" );
}
else if( !strcmp(sysname, "linux") ) { //LDAP entry
sprintf( tmp, "LINUX" );
}
else if( !strcmp(sysname, "SunOS")
|| !strcmp(sysname, "solaris" ) ) //LDAP entry
{
sprintf( tmp, "SOLARIS" );
if ( !strcmp(release, "2.10") //LDAP entry
|| !strcmp(release, "5.10") )
{
pver = "210";
}
else if ( !strcmp(release, "2.9") //LDAP entry
|| !strcmp(release, "5.9") )
{
pver = "29";
}
else if ( !strcmp(release, "2.8") //LDAP entry
|| !strcmp(release, "5.8") )
{
pver = "28";
}
else if ( !strcmp(release, "2.7") //LDAP entry
|| !strcmp(release, "5.7") )
{
pver = "27";
}
else if( !strcmp(release, "5.6")
|| !strcmp(release, "2.6") ) //LDAP entry
{
pver = "26";
}
else if ( !strcmp(release, "5.5.1")
|| !strcmp(release, "2.5.1") ) //LDAP entry
{
pver = "251";
}
else if ( !strcmp(release, "5.5")
|| !strcmp(release, "2.5") ) //LDAP entry
{
pver = "25";
}
else {
pver = release;
}
}
else if( !strcmp(sysname, "HP-UX") ) {
sprintf( tmp, "HPUX" );
if( !strcmp(release, "B.10.20") ) {
pver = "10";
}
else if( !strcmp(release, "B.11.00") ) {
pver = "11";
}
else if( !strcmp(release, "B.11.11") ) {
pver = "11";
}
else {
pver = release;
}
}
else if ( !strncmp(sysname, "Darwin", 6) ) {
sprintf( tmp, "OSX");
}
else if ( !strncmp(sysname, "AIX", 3) ) {
sprintf(tmp, "%s", sysname);
if ( !strcmp(version, "5") ) {
sprintf(ver, "%s%s", version, release);
pver = ver;
}
}
else if ( !strncmp(sysname, "FreeBSD", 7) ) {
sprintf( tmp, "FREEBSD" );
sprintf( ver, "%c", release[0]);
pver = ver;
}
else {
sprintf( tmp, "%s", sysname);
pver = release;
}
if (append_version && pver) {
strcat( tmp, pver );
}
tmpopsys = strdup( tmp );
if( !tmpopsys ) {
EXCEPT( "Out of memory!" );
}
return( tmpopsys );
}
| @@ -299,7 +299,7 @@ sysapi_translate_arch( const char *machine, const char *)
}
else {
// Unknown, just use what uname gave:
- sprintf( tmp, machine );
+ sprintf( tmp, "%s", machine );
}
tmparch = strdup( tmp ); | CWE-134 | null | null |
13,191 | int sysapi_translate_opsys_version(
const char * /*sysname*/,
const char *release,
const char * /*version*/ )
{
const char * psz = release;
while (psz[0] && (psz[0] < '0' || psz[0] > '9')) {
++psz;
}
int major = 0;
while (psz[0]) {
if (psz[0] >= '0' && psz[0] <= '9') {
major = major * 10 + (psz[0] - '0');
} else {
break;
}
++psz;
}
int minor = 0;
if (psz[0] == '.') {
++psz;
if (psz[0] >= '0' && psz[0] <= '9') {
minor = psz[0] - '0';
++psz;
}
if (psz[0] >= '0' && psz[0] <= '9') {
minor = minor * 10 + psz[0] - '0';
}
}
return (major * 100) + minor;
}
| DoS Exec Code | 0 | int sysapi_translate_opsys_version(
const char * /*sysname*/,
const char *release,
const char * /*version*/ )
{
const char * psz = release;
while (psz[0] && (psz[0] < '0' || psz[0] > '9')) {
++psz;
}
int major = 0;
while (psz[0]) {
if (psz[0] >= '0' && psz[0] <= '9') {
major = major * 10 + (psz[0] - '0');
} else {
break;
}
++psz;
}
int minor = 0;
if (psz[0] == '.') {
++psz;
if (psz[0] >= '0' && psz[0] <= '9') {
minor = psz[0] - '0';
++psz;
}
if (psz[0] >= '0' && psz[0] <= '9') {
minor = minor * 10 + psz[0] - '0';
}
}
return (major * 100) + minor;
}
| @@ -299,7 +299,7 @@ sysapi_translate_arch( const char *machine, const char *)
}
else {
// Unknown, just use what uname gave:
- sprintf( tmp, machine );
+ sprintf( tmp, "%s", machine );
}
tmparch = strdup( tmp ); | CWE-134 | null | null |
13,192 | sysapi_uname_arch(void)
{
return sysapi_condor_arch();
}
| DoS Exec Code | 0 | sysapi_uname_arch(void)
{
return sysapi_condor_arch();
}
| @@ -299,7 +299,7 @@ sysapi_translate_arch( const char *machine, const char *)
}
else {
// Unknown, just use what uname gave:
- sprintf( tmp, machine );
+ sprintf( tmp, "%s", machine );
}
tmparch = strdup( tmp ); | CWE-134 | null | null |
13,193 | sysapi_uname_arch(void)
{
if( ! arch_inited ) {
init_arch();
}
return uname_arch;
}
| DoS Exec Code | 0 | sysapi_uname_arch(void)
{
if( ! arch_inited ) {
init_arch();
}
return uname_arch;
}
| @@ -299,7 +299,7 @@ sysapi_translate_arch( const char *machine, const char *)
}
else {
// Unknown, just use what uname gave:
- sprintf( tmp, machine );
+ sprintf( tmp, "%s", machine );
}
tmparch = strdup( tmp ); | CWE-134 | null | null |
13,194 | sysapi_uname_opsys(void)
{
if( ! arch_inited ) {
init_arch();
}
return uname_opsys;
}
| DoS Exec Code | 0 | sysapi_uname_opsys(void)
{
if( ! arch_inited ) {
init_arch();
}
return uname_opsys;
}
| @@ -299,7 +299,7 @@ sysapi_translate_arch( const char *machine, const char *)
}
else {
// Unknown, just use what uname gave:
- sprintf( tmp, machine );
+ sprintf( tmp, "%s", machine );
}
tmparch = strdup( tmp ); | CWE-134 | null | null |
13,195 | SetSyscalls( int foo ) { return foo; }
| DoS Exec Code | 0 | SetSyscalls( int foo ) { return foo; }
| @@ -221,17 +221,17 @@ produce_output()
}
szTmp.sprintf("The condor_preen process has found the following stale condor files on <%s>:\n\n", get_local_hostname().Value());
- dprintf(D_ALWAYS, szTmp.Value());
+ dprintf(D_ALWAYS, "%s", szTmp.Value());
if( MailFlag ) {
fprintf( mailer, "\n" );
- fprintf( mailer, szTmp.Value());
+ fprintf( mailer, "%s", szTmp.Value());
}
for( BadFiles->rewind(); (str = BadFiles->next()); ) {
szTmp.sprintf(" %s\n", str);
- dprintf(D_ALWAYS, szTmp.Value() );
- fprintf( mailer, szTmp.Value() );
+ dprintf(D_ALWAYS, "%s", szTmp.Value() );
+ fprintf( mailer, "%s", szTmp.Value() );
}
if( MailFlag ) { | CWE-134 | null | null |
13,196 | bad_file( const char *dirpath, const char *name, Directory & dir )
{
MyString pathname;
MyString buf;
if( is_relative_to_cwd( name ) ) {
pathname.sprintf( "%s%c%s", dirpath, DIR_DELIM_CHAR, name );
}
else {
pathname = name;
}
if( VerboseFlag ) {
printf( "%s - BAD\n", pathname.Value() );
dprintf( D_ALWAYS, "%s - BAD\n", pathname.Value() );
}
if( RmFlag ) {
bool removed = dir.Remove_Full_Path( pathname.Value() );
if( !removed && privsep_enabled() ) {
removed = privsep_remove_dir( pathname.Value() );
if( VerboseFlag ) {
if( removed ) {
dprintf( D_ALWAYS, "%s - failed to remove directly, but succeeded via privsep switchboard\n", pathname.Value() );
printf( "%s - failed to remove directly, but succeeded via privsep switchboard\n", pathname.Value() );
}
}
}
if( removed ) {
buf.sprintf( "%s - Removed", pathname.Value() );
} else {
buf.sprintf( "%s - Can't Remove", pathname.Value() );
}
} else {
buf.sprintf( "%s - Not Removed", pathname.Value() );
}
BadFiles->append( buf.Value() );
}
| DoS Exec Code | 0 | bad_file( const char *dirpath, const char *name, Directory & dir )
{
MyString pathname;
MyString buf;
if( is_relative_to_cwd( name ) ) {
pathname.sprintf( "%s%c%s", dirpath, DIR_DELIM_CHAR, name );
}
else {
pathname = name;
}
if( VerboseFlag ) {
printf( "%s - BAD\n", pathname.Value() );
dprintf( D_ALWAYS, "%s - BAD\n", pathname.Value() );
}
if( RmFlag ) {
bool removed = dir.Remove_Full_Path( pathname.Value() );
if( !removed && privsep_enabled() ) {
removed = privsep_remove_dir( pathname.Value() );
if( VerboseFlag ) {
if( removed ) {
dprintf( D_ALWAYS, "%s - failed to remove directly, but succeeded via privsep switchboard\n", pathname.Value() );
printf( "%s - failed to remove directly, but succeeded via privsep switchboard\n", pathname.Value() );
}
}
}
if( removed ) {
buf.sprintf( "%s - Removed", pathname.Value() );
} else {
buf.sprintf( "%s - Can't Remove", pathname.Value() );
}
} else {
buf.sprintf( "%s - Not Removed", pathname.Value() );
}
BadFiles->append( buf.Value() );
}
| @@ -221,17 +221,17 @@ produce_output()
}
szTmp.sprintf("The condor_preen process has found the following stale condor files on <%s>:\n\n", get_local_hostname().Value());
- dprintf(D_ALWAYS, szTmp.Value());
+ dprintf(D_ALWAYS, "%s", szTmp.Value());
if( MailFlag ) {
fprintf( mailer, "\n" );
- fprintf( mailer, szTmp.Value());
+ fprintf( mailer, "%s", szTmp.Value());
}
for( BadFiles->rewind(); (str = BadFiles->next()); ) {
szTmp.sprintf(" %s\n", str);
- dprintf(D_ALWAYS, szTmp.Value() );
- fprintf( mailer, szTmp.Value() );
+ dprintf(D_ALWAYS, "%s", szTmp.Value() );
+ fprintf( mailer, "%s", szTmp.Value() );
}
if( MailFlag ) { | CWE-134 | null | null |
13,197 | check_execute_dir()
{
time_t now = time(NULL);
const char *f;
bool busy;
State s = get_machine_state();
switch( s ) {
case owner_state:
case unclaimed_state:
case matched_state:
busy = false;
break;
case claimed_state:
case preempting_state:
busy = true;
break;
default:
dprintf( D_ALWAYS,
"Error getting startd state, not cleaning execute directory.\n" );
return;
}
ExecuteDirs.rewind();
char const *Execute;
while( (Execute=ExecuteDirs.next()) ) {
Directory dir( Execute, PRIV_ROOT );
while( (f = dir.Next()) ) {
if( busy ) {
good_file( Execute, f ); // let anything go here
} else {
if( dir.GetCreateTime() < now ) {
bad_file( Execute, f, dir ); // junk it
}
else {
dprintf(D_FULLDEBUG, "In %s, found %s with recent "
"creation time. Not removing.\n", Execute, f );
good_file( Execute, f ); // too young to kill
}
}
}
}
}
| DoS Exec Code | 0 | check_execute_dir()
{
time_t now = time(NULL);
const char *f;
bool busy;
State s = get_machine_state();
switch( s ) {
case owner_state:
case unclaimed_state:
case matched_state:
busy = false;
break;
case claimed_state:
case preempting_state:
busy = true;
break;
default:
dprintf( D_ALWAYS,
"Error getting startd state, not cleaning execute directory.\n" );
return;
}
ExecuteDirs.rewind();
char const *Execute;
while( (Execute=ExecuteDirs.next()) ) {
Directory dir( Execute, PRIV_ROOT );
while( (f = dir.Next()) ) {
if( busy ) {
good_file( Execute, f ); // let anything go here
} else {
if( dir.GetCreateTime() < now ) {
bad_file( Execute, f, dir ); // junk it
}
else {
dprintf(D_FULLDEBUG, "In %s, found %s with recent "
"creation time. Not removing.\n", Execute, f );
good_file( Execute, f ); // too young to kill
}
}
}
}
}
| @@ -221,17 +221,17 @@ produce_output()
}
szTmp.sprintf("The condor_preen process has found the following stale condor files on <%s>:\n\n", get_local_hostname().Value());
- dprintf(D_ALWAYS, szTmp.Value());
+ dprintf(D_ALWAYS, "%s", szTmp.Value());
if( MailFlag ) {
fprintf( mailer, "\n" );
- fprintf( mailer, szTmp.Value());
+ fprintf( mailer, "%s", szTmp.Value());
}
for( BadFiles->rewind(); (str = BadFiles->next()); ) {
szTmp.sprintf(" %s\n", str);
- dprintf(D_ALWAYS, szTmp.Value() );
- fprintf( mailer, szTmp.Value() );
+ dprintf(D_ALWAYS, "%s", szTmp.Value() );
+ fprintf( mailer, "%s", szTmp.Value() );
}
if( MailFlag ) { | CWE-134 | null | null |
13,198 | check_log_dir()
{
const char *f;
Directory dir(Log, PRIV_ROOT);
StringList invalid;
invalid.initializeFromString (InvalidLogFiles ? InvalidLogFiles : "");
while( (f = dir.Next()) ) {
if( invalid.contains(f) ) {
bad_file( Log, f, dir );
} else {
good_file( Log, f );
}
}
}
| DoS Exec Code | 0 | check_log_dir()
{
const char *f;
Directory dir(Log, PRIV_ROOT);
StringList invalid;
invalid.initializeFromString (InvalidLogFiles ? InvalidLogFiles : "");
while( (f = dir.Next()) ) {
if( invalid.contains(f) ) {
bad_file( Log, f, dir );
} else {
good_file( Log, f );
}
}
}
| @@ -221,17 +221,17 @@ produce_output()
}
szTmp.sprintf("The condor_preen process has found the following stale condor files on <%s>:\n\n", get_local_hostname().Value());
- dprintf(D_ALWAYS, szTmp.Value());
+ dprintf(D_ALWAYS, "%s", szTmp.Value());
if( MailFlag ) {
fprintf( mailer, "\n" );
- fprintf( mailer, szTmp.Value());
+ fprintf( mailer, "%s", szTmp.Value());
}
for( BadFiles->rewind(); (str = BadFiles->next()); ) {
szTmp.sprintf(" %s\n", str);
- dprintf(D_ALWAYS, szTmp.Value() );
- fprintf( mailer, szTmp.Value() );
+ dprintf(D_ALWAYS, "%s", szTmp.Value() );
+ fprintf( mailer, "%s", szTmp.Value() );
}
if( MailFlag ) { | CWE-134 | null | null |
13,199 | check_spool_dir()
{
unsigned int history_length, startd_history_length;
const char *f;
const char *history, *startd_history;
Directory dir(Spool, PRIV_ROOT);
StringList well_known_list, bad_spool_files;
Qmgr_connection *qmgr;
if ( ValidSpoolFiles == NULL ) {
dprintf( D_ALWAYS, "Not cleaning spool directory: No VALID_SPOOL_FILES defined\n");
return;
}
history = param("HISTORY");
history = condor_basename(history); // condor_basename never returns NULL
history_length = strlen(history);
startd_history = param("STARTD_HISTORY");
startd_history = condor_basename(startd_history);
startd_history_length = strlen(startd_history);
well_known_list.initializeFromString (ValidSpoolFiles);
well_known_list.append( "job_queue.log" );
well_known_list.append( "job_queue.log.tmp" );
well_known_list.append( "spool_version" );
well_known_list.append( "Accountant.log" );
well_known_list.append( "Accountantnew.log" );
well_known_list.append( "local_univ_execute" );
well_known_list.append( "EventdShutdownRate.log" );
well_known_list.append( "OfflineLog" );
well_known_list.append( "SCHEDD.lock" );
well_known_list.append( ".quillwritepassword" );
well_known_list.append( ".pgpass" );
if (!(qmgr = ConnectQ (0))) {
dprintf( D_ALWAYS, "Not cleaning spool directory: Can't contact schedd\n" );
return;
}
while( (f = dir.Next()) ) {
if( well_known_list.contains(f) ) {
good_file( Spool, f );
continue;
}
if( !strncmp(f,"job_queue.log",13) ) {
good_file( Spool, f );
continue;
}
if ( strlen(f) >= history_length
&& strncmp(f, history, history_length) == 0) {
good_file( Spool, f );
continue;
}
if ( startd_history_length > 0 &&
strlen(f) >= startd_history_length &&
strncmp(f, startd_history, startd_history_length) == 0) {
good_file( Spool, f );
continue;
}
if( is_valid_shared_exe(f) ) {
good_file( Spool, f );
continue;
}
if( is_ckpt_file(f) ) {
good_file( Spool, f );
continue;
}
if ( is_myproxy_file( f ) ) {
good_file( Spool, f );
continue;
}
if ( is_ccb_file( f ) ) {
good_file( Spool, f );
continue;
}
if( IsDirectory( dir.GetFullPath() ) && !IsSymlink( dir.GetFullPath() ) ) {
if( check_job_spool_hierarchy( Spool, f, bad_spool_files ) ) {
good_file( Spool, f );
continue;
}
}
bad_spool_files.append( f );
}
if( DisconnectQ(qmgr) ) {
bad_spool_files.rewind();
while( (f = bad_spool_files.next()) ) {
bad_file( Spool, f, dir );
}
} else {
dprintf( D_ALWAYS,
"Error disconnecting from job queue, not deleting spool files.\n" );
}
}
| DoS Exec Code | 0 | check_spool_dir()
{
unsigned int history_length, startd_history_length;
const char *f;
const char *history, *startd_history;
Directory dir(Spool, PRIV_ROOT);
StringList well_known_list, bad_spool_files;
Qmgr_connection *qmgr;
if ( ValidSpoolFiles == NULL ) {
dprintf( D_ALWAYS, "Not cleaning spool directory: No VALID_SPOOL_FILES defined\n");
return;
}
history = param("HISTORY");
history = condor_basename(history); // condor_basename never returns NULL
history_length = strlen(history);
startd_history = param("STARTD_HISTORY");
startd_history = condor_basename(startd_history);
startd_history_length = strlen(startd_history);
well_known_list.initializeFromString (ValidSpoolFiles);
well_known_list.append( "job_queue.log" );
well_known_list.append( "job_queue.log.tmp" );
well_known_list.append( "spool_version" );
well_known_list.append( "Accountant.log" );
well_known_list.append( "Accountantnew.log" );
well_known_list.append( "local_univ_execute" );
well_known_list.append( "EventdShutdownRate.log" );
well_known_list.append( "OfflineLog" );
well_known_list.append( "SCHEDD.lock" );
well_known_list.append( ".quillwritepassword" );
well_known_list.append( ".pgpass" );
if (!(qmgr = ConnectQ (0))) {
dprintf( D_ALWAYS, "Not cleaning spool directory: Can't contact schedd\n" );
return;
}
while( (f = dir.Next()) ) {
if( well_known_list.contains(f) ) {
good_file( Spool, f );
continue;
}
if( !strncmp(f,"job_queue.log",13) ) {
good_file( Spool, f );
continue;
}
if ( strlen(f) >= history_length
&& strncmp(f, history, history_length) == 0) {
good_file( Spool, f );
continue;
}
if ( startd_history_length > 0 &&
strlen(f) >= startd_history_length &&
strncmp(f, startd_history, startd_history_length) == 0) {
good_file( Spool, f );
continue;
}
if( is_valid_shared_exe(f) ) {
good_file( Spool, f );
continue;
}
if( is_ckpt_file(f) ) {
good_file( Spool, f );
continue;
}
if ( is_myproxy_file( f ) ) {
good_file( Spool, f );
continue;
}
if ( is_ccb_file( f ) ) {
good_file( Spool, f );
continue;
}
if( IsDirectory( dir.GetFullPath() ) && !IsSymlink( dir.GetFullPath() ) ) {
if( check_job_spool_hierarchy( Spool, f, bad_spool_files ) ) {
good_file( Spool, f );
continue;
}
}
bad_spool_files.append( f );
}
if( DisconnectQ(qmgr) ) {
bad_spool_files.rewind();
while( (f = bad_spool_files.next()) ) {
bad_file( Spool, f, dir );
}
} else {
dprintf( D_ALWAYS,
"Error disconnecting from job queue, not deleting spool files.\n" );
}
}
| @@ -221,17 +221,17 @@ produce_output()
}
szTmp.sprintf("The condor_preen process has found the following stale condor files on <%s>:\n\n", get_local_hostname().Value());
- dprintf(D_ALWAYS, szTmp.Value());
+ dprintf(D_ALWAYS, "%s", szTmp.Value());
if( MailFlag ) {
fprintf( mailer, "\n" );
- fprintf( mailer, szTmp.Value());
+ fprintf( mailer, "%s", szTmp.Value());
}
for( BadFiles->rewind(); (str = BadFiles->next()); ) {
szTmp.sprintf(" %s\n", str);
- dprintf(D_ALWAYS, szTmp.Value() );
- fprintf( mailer, szTmp.Value() );
+ dprintf(D_ALWAYS, "%s", szTmp.Value() );
+ fprintf( mailer, "%s", szTmp.Value() );
}
if( MailFlag ) { | CWE-134 | null | null |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.