language
string
code-snippit
string
instruction
string
flaws
list
flaw_count
int64
python
self.log.info('Test bitcoind with -noasmap arg passed') self.stop_node(0) with self.node.assert_debug_log(['Using /16 prefix for IP bucketing']): self.start_node(0, ["-noasmap"]) def test_asmap_with_absolute_path(self): self.log.info('Test bitcoind -asmap=<absolute path>') ...
Review this code and list any quality issues.
[ { "issue": "nit: I was going to say that the unspecified file and the missing file test could be deduplicated since they are currently similar but I think the better change would be to have an explicit error message for the empty `-asmap` arg.", "severity": "major", "line": 26 } ]
1
python
("spaceflights-pandas", "https://github.com/kedro-org/kedro-starters.git"), ( "git+https://github.com/fake/fake.git", "https://github.com/fake/fake.git", ), ], ) def test_invalid_checkout(self, starter, repo, fake_kedro_cli, mocker): mocker...
Review this code and list any quality issues.
[]
0
python
'episode_number': 1, 'episode': 'Episode 1', # Then if the test run fails, it will output the missing/incorrect fields. # Properties can be added as: # * A value, e.g. # 'title': 'Video title goes here', # * MD5 checksum; start the string with ...
Review this code and list any quality issues.
[ { "issue": "Use single quotes. Don't create single use variables (`endpoint_url`, `ajax_cookie`).", "severity": "minor", "line": 26 } ]
1
python
""" Return boolean ndarray denoting duplicate values. Parameters ---------- keep : {'first', 'last', False}, default 'first' - ``first`` : Mark duplicates as ``True`` except for the first occurrence. - ``last`` : Mark duplicates as ``True`` except for the last oc...
Review this code and list any quality issues.
[ { "issue": "Can you modify this example to use a `SparseDtype(np.int64)` to match the parent class?", "severity": "minor", "line": 26 } ]
1
python
"-m", "--model", dest="model", type=str, default="chatgptapi", choices=translate_model_list, # support DeepL later metavar="MODEL", help="model to use, available: {%(choices)s}", ) parser.add_argument( "--language", type=str, choic...
Review this code and list any quality issues.
[]
0
python
def parse_values(astr): # replaces all occurrences of '(a,b,c)*4' in astr # with 'a,b,c,a,b,c,a,b,c,a,b,c'. Empty braces generate # empty values, i.e., ()*4 yields ',,,'. The result is # split at ',' and a list of values returned. astr = parenrep.sub(paren_repl, astr) # replaces occurrences of x...
Review this code and list any quality issues.
[]
0
python
mock_filtered_query.one_or_none.return_value = None # This should not raise TypeError if filter() is used correctly result = Slice.get(test_uuid) # Verify that query() was called with Slice mock_db.session.query.assert_called_once_with(Slice) # Verify that ...
Review this code and list any quality issues.
[ { "issue": "[nitpick] The comment should end with a period for consistency: \"Success - no TypeError occurred, result can be None or a Slice.\"\n```suggestion\n # Success - no TypeError occurred, result can be None or a Slice. # noqa: E501\n```", "severity": "minor", "line": 26 } ]
1
python
yield { 'id': str(item['id']), 'title': item.get('title'), 'description': item.get('description'), 'formats': formats, 'subtitles': subtitle, 'duration': parse_duration(item.get('duration')), ...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n str(nextjs_json['id']),\r\n title=nextjs_json.get('title') or self._html_search_meta(['title', 'og:title', 'twitter:title'], webpage),\r\n description=nextjs_json.get('description') or self._html_search_meta(['description', 'twitter:description', 'o...
1
python
else islice(iterator, self.batch_size - 1) ) key_examples_list = [(key, example)] + list(iterator_batch) keys, examples = zip(*key_examples_list) if ( self.drop_last_batch and self.batch_size is not None ...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n if processed_inputs is inputs and c in processed_inputs:\r\n```", "severity": "minor", "line": 26 } ]
1
python
base_path = self._get_base_path(key) file_name = self._get_file_name(key) file_path = base_path / file_name if self.relative_tmp_dir is not None: tmp_path = base_path / self.relative_tmp_dir / file_name else: tmp_path = file_path.with_suffix(".tmp") return...
Review this code and list any quality issues.
[]
0
python
ExceptionGroup = ExceptionGroup # pragma: lax no cover with try_import() as logfire_imports_successful: from logfire.testing import CaptureLogfire pytestmark = pytest.mark.anyio def success_response(_model_messages: list[ModelMessage], _agent_info: AgentInfo) -> ModelResponse: return ModelResponse(parts=[...
Review this code and list any quality issues.
[ { "issue": "I think we should specifically define this method to return the `model_id`s of the wrapped models with the `fallback` prefix, like with the `model_name` and `system` methods:\r\n\r\nhttps://github.com/pydantic/pydantic-ai/blob/9a0757c97593ae9bd6aa778460b0ceff0d44068e/pydantic_ai_slim/pydantic_ai/mod...
1
python
def unspecialize(self): """ Unspecialize a column to its generic form. This is equivalent to ``column.specialize(GENERIC)``. """ return self.specialize(GENERIC) @coerce_types(currency=(str, Currency)) def fx(self, currency): """ Construct a currency-conv...
Review this code and list any quality issues.
[ { "issue": "I think we probably want to use `self.qualname` in the error message.", "severity": "minor", "line": 26 } ]
1
python
The length of the x-axis. y_length The length of the y-axis. z_length The length of the z-axis. z_axis_config Arguments to be passed to :class:`~.NumberLine` that influence the z-axis. z_normal The direction of the normal. num_axis_pieces The number of pieces ...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n z_range: Optional[Union[List[float], np.ndarray]] = (-4, 4, 1),\r\n```", "severity": "minor", "line": 26 } ]
1
python
if key: attr = key transformer: Optional[Transformer] try: before = elem['old_value'] except KeyError: before = None else: if transformer: before = transformer(entry, before) ...
Review this code and list any quality issues.
[]
0
python
def generate_points(self): self.add_points( [ r * (np.cos(theta) * RIGHT + np.sin(theta) * UP) for r in np.arange(self.epsilon, self.radius, self.epsilon) # Num is equal to int(stop - start)/ (step + 1) reformulated. for theta in np.lin...
Review this code and list any quality issues.
[ { "issue": "Again use the bot's `!md` command.", "severity": "minor", "line": 26 } ]
1
python
_TESTS = [{ 'url': 'http://www.rottentomatoes.com/m/toy_story_3/trailers/11028566/', 'info_dict': { 'id': '11028566', 'ext': 'mp4', 'title': 'Best Tom Hanks Movies', 'description': 'We look at the filmography of America\'s Dad, as we count down our list of...
Review this code and list any quality issues.
[ { "issue": "We need to try to construct the `playlist_id` since /trailers/ URLs have different playlists than their non-trailers URL counterparts. `join_nonempty` can be imported from utils\r\n```suggestion\r\n playlist_id, trailers, video_id = self._match_valid_url(url).group('playlist', 'tr', 'id')\r\n...
1
python
from configs import dify_config from core.helper.marketplace import marketplace_api_url, record_install_plugin_event from core.plugin.entities.marketplace import MarketplacePluginSnapshot from core.plugin.entities.plugin import PluginInstallationSource from core.plugin.impl.plugin import PluginInstaller from extensions...
Review this code and list any quality issues.
[ { "issue": "The docstring is outdated. It states that the function can return `None` when \"cached as not found (marketplace returned no result)\", but with the new implementation, `fetch_global_plugin_manifest()` never stores `None` values in the cache. The function now only returns `False` (not in cache) or `...
1
python
station = self._get_pageProps(url, video_id)['station'] url = station['streamUrl'] display_id = [station.get('brandSlug'), station.get('slug')] if None not in display_id: display_id = '-'.join(display_id) else: display_id = station.get('brandSlug') or station.get...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\nclass GlobalPlayerLivePlaylistIE(GlobalPlayerBaseIE):\r\n _VALID_URL = r'https?://www\\.globalplayer\\.com/playlists/(?P<id>\\w+)'\r\n```", "severity": "minor", "line": 26 } ]
1
python
else: init_filename = 'oppia-%s-v%s.zip' % ( exploration.title.replace(' ', ''), version) filename = utils.to_ascii(init_filename) if output_format == feconf.OUTPUT_FORMAT_ZIP: self.render_downloadable_file( exp_services.export_to_zip_file( ...
Review this code and list any quality issues.
[]
0
python
import dataclasses import json import os import random import time from datetime import datetime from typing import List, Optional, Tuple, Dict import openai import asyncio import logging from transformers import PreTrainedTokenizerBase from vllm.engine.arg_utils import EngineArgs from vllm.utils import FlexibleArgu...
Review this code and list any quality issues.
[ { "issue": "@happyandslow Can you help review the benchmark changes?", "severity": "major", "line": 6 } ]
1
python
from ..constants import DEFAULT_POINTWISE_FUNCTION_RUN_TIME, DEGREES, ORIGIN, OUT from ..mobject.mobject import Group, Mobject from ..utils.paths import path_along_arc, path_along_circles from ..utils.rate_functions import smooth, squish_rate_func if TYPE_CHECKING: from ..scene.scene import Scene class Transform...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n The axis to rotate along if using a circular path arc, see ``path_arc_centers``.\r\n```", "severity": "minor", "line": 26 } ]
1
python
logger.warning("skipping non-.yml file: %s", file) continue rule_file_paths.append(Path(root) / file) return rule_file_paths # TypeAlias. note: using `foo: TypeAlias = bar` is Python 3.10+ RulePath = Path def on_load_rule_default(_path: RulePath, i: int, _total: int) ...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n enable_cache: enable loading of a cached ruleset (default: True)\r\n```", "severity": "major", "line": 26 } ]
1
python
else: size = size_index() with self._lock: if size < 0: size = len(self._buffer) if len(self._buffer) <= self._pos: return b"" newpos = min(len(self._buffer), self._pos + size) b = self._buffer[self._pos : newpos] ...
Review this code and list any quality issues.
[ { "issue": "The rest of the code should be moved in the `with` block.\n\nOtherwise writing to BytesIO after seeking can not just overwrite existing bytes, but move bytes after the current position.\n\nThis is a separate bug, so you can open a separate issue and fix it in a separate PR.", "severity": "critic...
1
python
def test_root_create(self): root_page = Page.objects.get(pk=1) self.assertIsNotNone(root_page) def test_homepage_create(self): root_page = Page.objects.get(pk=1) homepage = HomePage(title="Home") root_page.add_child(instance=homepage) self.assertTrue(HomePage.object...
Review this code and list any quality issues.
[ { "issue": "Note, AI suggestion, but maybe we should do something else here to actually have a basic starting set of tests.\r\n\r\n```suggestion\r\n def test_homepage_status_code(self):\r\n response = self.client.get(reverse('home'))\r\n self.assertEqual(response.status_code, 200)\r\n\r\n de...
1
python
video_url = video.get('url') if not video_url: continue if is_live is None: is_live = (try_get( video, lambda x: x['plages_ouverture'][0]['direct'], bool) is True or video.get('is_live') is True or '/live...
Review this code and list any quality issues.
[ { "issue": "Tested this on `francetv:162311093`. May find more later.\r\n\r\n(I’m not even sure extracting storyboards is worth it in the first place.)", "severity": "major", "line": 26 } ]
1
python
'ext': 'mp4', 'title': '原神', 'description': 'md5:e345f39a5fea5de2a46923f70d5f76ab', 'duration': 26, 'thumbnail': r're:^https?://.*\.(png|jpg)', } }, { 'info_dict': { 'id': '4058462', 'ext': 'm...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\nclass TapTapPostIntlIE(TapTapIntlBase):\r\n```", "severity": "minor", "line": 26 } ]
1
python
else: yield None def _do_global_fixed_clipping( self, group: Dict[str, Any], max_norm: float, all_metrics: Dict[str, torch.Tensor], collect_param_metrics: bool = True, ) -> Generator[Optional[bool], None, None]: """ Do global fixed gradien...
Review this code and list any quality issues.
[ { "issue": "Same question about `detach()`.", "severity": "minor", "line": 26 } ]
1
python
# At this point, scheduler has tried to schedule the task once and # heartbeated the executor once, which moved the state of the task from # SCHEDULED to QUEUED and then to SCHEDULED, to fail the task execution # we need to ignore the TaskInstance state as SCHEDULED is not a valid state to start...
Review this code and list any quality issues.
[]
0
python
# Create mock snapshots with varying creation times snapshots = Snapshotter._get_sorted_list_by_created_at( [ CpuSnapshot(used_ratio=0.5, max_used_ratio=0.95, created_at=five_hours_ago), CpuSnapshot(used_ratio=0.6, max_used_ratio=0.95, created_at=three_hours_ago), CpuSnap...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n snapshotter._cpu_snapshots = Snapshotter._get_sorted_list_by_created_at(list[CpuSnapshot]())\r\n```", "severity": "minor", "line": 26 } ]
1
python
gradient_as_bucket_view: bool = False, static_graph: bool = False) -> None: super().__init__() self.ddp_kwargs = dict(broadcast_buffers=broadcast_buffers, bucket_cap_mb=bucket_cap_mb, find_unused_parameters=find_unused_parame...
Review this code and list any quality issues.
[ { "issue": "`no_sync()` method has already been implemented", "severity": "minor", "line": 26 } ]
1
python
'thumbnail': thumbnail, 'series': show_info.get('title'), 'season_number': season_info.get('season'), 'season': season_info['title'], } elif re.fullmatch(self._VIDEO_ID, url_id) is None: # Not a playlist or video raise Extracto...
Review this code and list any quality issues.
[ { "issue": "Error message should be like `IE_NAME said: code - message`. Also set `expected=True`", "severity": "minor", "line": 26 } ]
1
python
# vendor_part_id=uuid4(), part=web_search_return # ) if candidate.content is None or candidate.content.parts is None: if self.finish_reason == 'content_filter' and raw_finish_reason: # pragma: no cover raise UnexpectedModelBehavior( ...
Review this code and list any quality issues.
[ { "issue": "I slightly prefer this, here and below:\r\n\r\n```suggestion\r\n if len(part.text) > 0:\r\n```", "severity": "minor", "line": 26 } ]
1
python
SOCIAL_AUTH_GITHUB_ENTERPRISE_ORG_SCOPE = ['user:email', 'read:org'] SOCIAL_AUTH_GITHUB_ENTERPRISE_TEAM_KEY = '' SOCIAL_AUTH_GITHUB_ENTERPRISE_TEAM_SECRET = '' SOCIAL_AUTH_GITHUB_ENTERPRISE_TEAM_ID = '' SOCIAL_AUTH_GITHUB_ENTERPRISE_TEAM_SCOPE = ['user:email', 'read:org'] SOCIAL_AUTH_AZUREAD_OAUTH2_KEY = '' SOCIAL_AU...
Review this code and list any quality issues.
[]
0
python
cmd += ['--auto-file-renaming=false'] if 'fragments' in info_dict: cmd += ['--file-allocation=none', '--uri-selector=inorder'] url_list_file = '%s.frag.urls' % tmpfilename url_list = [] for frag_index, fragment in enumerate(info_dict['fragments']): ...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n # note: there's no need to be UUID (it can even a numeric value), but that's easier and long enough not to make duplicate one\r\n```", "severity": "major", "line": 26 } ]
1
python
return "op_builder.xpu" except ImportError: return "deepspeed.ops.op_builder.xpu" def on_accelerator(self, tensor): device_str = str(tensor.device) if device_str.startswith('xpu:'): return True else: return False def _lazy_init_class_dict(sel...
Review this code and list any quality issues.
[ { "issue": "builder_class could return NotImplementedBuilder or None. It's error prone to check between the two.", "severity": "minor", "line": 26 } ]
1
python
def blackify(base_branch, black_command): current_branch = git("branch", "--show-current") if not current_branch or base_branch == current_branch: print("You need to check out a feature brach to work on") return 1 if not os.path.exists(".git"): print("Run me in the root of your rep...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n import shlex\r\n check_output(shlex.split(black_command))\r\n```\r\nShouldn't need shell=True here ...", "severity": "minor", "line": 26 } ]
1
python
] test_microvm.spawn() if test_microvm.jailer.cgroup_ver == 1: check_cgroups_v1(test_microvm.jailer.cgroups, test_microvm.jailer.jailer_id) else: check_cgroups_v2(test_microvm) def test_cgroups_custom_parent(uvm_plain, cgroups_info): """ Test cgroups when a custom parent cgroup i...
Review this code and list any quality issues.
[]
0
python
errorState = False def setup(self, sfc, userOpts=dict()): self.sf = sfc self.results = self.tempStorage() for opt in list(userOpts.keys()): self.opts[opt] = userOpts[opt] # What events is this module interested in for input def watchedEvents(self): return ["DOM...
Review this code and list any quality issues.
[ { "issue": "In my testing I'm seeing throttling errors returned, indicated by a return code of `502`. This should be handled, with an error log reported. I don't know what the throttling limits are depending on whether an API key is provided, but perhaps have a `sleep` after each call to avoid throttling.", ...
1
python
name=topic, meta_data={"topic": topic}, content=summary, ) ] return [] async def async_read(self, topic: str) -> List[Document]: """ Asynchronously read content from Wikipedia. Args: topic: The Wikipedi...
Review this code and list any quality issues.
[ { "issue": "```suggestion\n log_debug(\"Wikipedia PageError: Page not found.\")\n```", "severity": "critical", "line": 26 } ]
1
python
raise UserCancelledError() path = self.ask_user_directory() if not path: raise UserCancelledError() settings.user[CAPA_SETTINGS_RULE_PATH] = path except UserCancelledError as e: capa.ida.helpers.inform_user_ida_ui("Analysis requir...
Review this code and list any quality issues.
[ { "issue": "can we remove this block? the same check happens above", "severity": "major", "line": 26 } ]
1
python
IE_NAME = 'tvp:vod:series' _VALID_URL = r'https?://vod\.tvp\.pl/[a-z\d-]+,\d+/[a-z\d-]+-odcinki,(?P<id>\d+)(?:\?[^#]+)?(?:#.+)?$' _TESTS = [{ 'url': 'https://vod.tvp.pl/seriale,18/ranczo-odcinki,316445', 'info_dict': { 'id': '316445', 'title': 'Ranczo', 'age_...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n yield from map(self._parse_video, episodes)\r\n```", "severity": "minor", "line": 26 } ]
1
python
# coding: utf-8 from __future__ import unicode_literals from datetime import datetime import re import time from .common import InfoExtractor from ..utils import ( ExtractorError, url_or_none, traverse_obj, ) class Kanal2IE(InfoExtractor): SUBTITLE_DATE_RE = re.compile(r'\((\d{2}\.\d{2}\.\d{4}\s\d{2}:...
Review this code and list any quality issues.
[ { "issue": "will this extractor work with other postimees.ee sites? if so, then should it still be named Kanal2?\r\n```suggestion\r\n _VALID_URL = r'https?://kanal2\\.postimees\\.ee/[^?]+\\?(.*?&)?id=(?P<id>\\d+)'\r\n```\r\nor if we do want to match any subdomain then we should do it safely:\r\n```suggestion...
1
python
m2m_data[field.name] = value elif field.remote_field and isinstance( field.remote_field, models.ManyToOneRel ): value = self._handle_fk_field_node(field_node, field) if value == base.DEFER_FIELD: deferred_fields[field] = [ ...
Review this code and list any quality issues.
[ { "issue": "For the sake of having a much smaller diff, I would suggest leaving most of this where it was and just fix the condition. (e.g. lift up `keys = ...` and then check `... and not keys: return None`, perhaps improving the variable name `keys`).\n\nYour version has a terser if condition, but this code i...
1
python
class AltCensoredChannelIE(InfoExtractor): _VALID_URL = r'https?://(?:www\.)altcensored\.com/channel/(?P<id>[^/?#]+)' _PAGE_SIZE = 24 _TESTS = [{ 'url': 'https://www.altcensored.com/channel/UCFPTO55xxHqFqkzRZHu4kcw', 'info_dict': { 'title': 'Virginie Vota Channel (91 Censored Vid...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n page_num += 1\r\n webpage = self._download_webpage(\r\n f'https://altcensored.com/channel/{channel_id}/page/{page_num}',\r\n channel_id, note=f'Downloading page {page_num}')\r\n```", "severity": "minor", "line": 26 } ]
1
python
'url': 'https://now.naver.com/show/4759', 'info_dict': { 'id': '4759', 'title': '아이키의 떰즈업', }, 'playlist_mincount': 48 }, { 'url': 'https://now.naver.com/show/4759?shareReplayId=5901#replay', 'info_dict': { 'id': '4759', 'title'...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n }, {\r\n 'url': 'https://now.naver.com/show/4759?shareHightlight=1078#highlight=',\r\n 'info_dict': {\r\n 'id': '4759',\r\n 'title': '아이키의 떰즈업',\r\n },\r\n 'playlist_mincount': 48,\r\n```", "severity": "minor", "line": 26...
1
python
ranked_results = [] # Process in larger batches for better throughput batch_size = min(self.max_concurrent_requests * 2, len(query_document_pairs)) for i in range(0, len(query_document_pairs), batch_size): batch = query_document_pairs[i:i + batch_size] try: ...
Review this code and list any quality issues.
[]
0
python
ids = traverse_obj(get_element_html_by_class('btn-play cursor-pointer mr-small', td), {extract_attributes}) yield { **album_meta, 'title': title, 'track': title, 'track_number': traverse_obj(get_element_by_class('py-xsmall', td), {int_or_none})...
Review this code and list any quality issues.
[ { "issue": "input url might have a query or fragment, let's reconstruct\r\n```suggestion\r\n 'thumbnail': f'https://www.monstercat.com/release/{url_id}/cover',\r\n```", "severity": "minor", "line": 26 } ]
1
python
tokenizer_kwargs["padding_side"] = padding_side # Download and build the tokenizer from the HuggingFace Hub. tokenizer = transformers.AutoTokenizer.from_pretrained( tokenizer_name, trust_remote_code=model_params.trust_remote_code, **tokenizer_kwargs, ) tokenizer_pad_token = mod...
Review this code and list any quality issues.
[ { "issue": "I don't think this is necessary. As long as we don't set model_params.chat_template, don't register anything in the internal config, it'll use the model's built-in chat template if it has one.", "severity": "minor", "line": 26 } ]
1
python
field_scores=None, ) def _create_inference_engine( self, inference_config: InferenceConfig ) -> BaseInferenceEngine: """Create the inference engine based on the provided configuration.""" from oumi.builders.inference_engines import build_inference_engine if inference_co...
Review this code and list any quality issues.
[ { "issue": "nit: we could simplify the name to `from_path` or `from_config`", "severity": "major", "line": 26 } ]
1
python
target_versions: Set[TargetVersion] = field(default_factory=set) line_length: int = DEFAULT_LINE_LENGTH string_normalization: bool = True is_pyi: bool = False is_ipynb: bool = False magic_trailing_comma: bool = True experimental_string_processing: bool = False python_cell_magics: Set[str] = ...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n \",\".join(sorted(self.python_cell_magics)),\r\n```\r\nSet iteration order is randomized, so this would make the cache key unstable", "severity": "major", "line": 26 } ]
1
python
__all__ = ["SurroundingRectangle", "BackgroundRectangle", "Cross", "Underline"] from ..constants import * from ..mobject.geometry import Line, Rectangle from ..mobject.types.vectorized_mobject import VGroup, VMobject from ..utils.color import BLACK, RED, YELLOW, Color class SurroundingRectangle(Rectangle): """A...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n class SurroundingRectExample(Scene):\r\n def construct(self):\r\n title = Title(\"A Quote from Newton\")\r\n quote = Text(\r\n \"If I have seen further than others, \\n\"\r\n \"it is by standing u...
1
python
] ) graph.node(explain_info["name"], label) def _add_graphviz_edges(explain_info, graph): name = explain_info["name"] for _, dep in explain_info["dependencies"]: graph.edge(dep, name) def _explain_info(expr: Expr): return { "name": expr._name, "label": funcname(type(expr...
Review this code and list any quality issues.
[ { "issue": "I believe explain should just work out of the box for arrays (and HLGs) but the nodes wouldn't be annotated. Still, it's something", "severity": "minor", "line": 26 } ]
1
python
cls._default_config._unique_sections[default_section.name] = default_section elif def_sections := cls._default_config._sections.get(default_section.name, None): def_sections[default_section.id] = default_section else: cls._default_config._sections[default_section.name] = {default...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n cls._serializer._section_class[section.name] = section.__class__\r\n cls.__json_serializer._section_class[section.name] = section.__class__\r\n```", "severity": "minor", "line": 26 } ]
1
python
Examples -------- .. manim:: BecomeScene class BecomeScene(Scene): def construct(self): circ = Circle(fill_color=RED, fill_opacity=0.8) square = Square(fill_color=BLUE, fill_opacity=0.2) self.add(circ) ...
Review this code and list any quality issues.
[ { "issue": "Ah, I think I found the issue. This should probably be `MatchPointsScene`, not `BecomeScene`\r\n```suggestion\r\n .. manim:: MatchPointsScene\r\n```", "severity": "minor", "line": 26 } ]
1
python
'thumbnail': r're:https?://.+/.+\.jpg', 'timestamp': 1437785037, 'upload_date': '20150725', }, }, { # video with window.__INITIAL_DATA__ and value as JSON string 'url': 'https://www.bbc.com/news/av/world-europe-59468682', 'info_dict': { 'id': 'p0b7...
Review this code and list any quality issues.
[ { "issue": "this is wrong, need to convert milliseconds to seconds", "severity": "critical", "line": 26 } ]
1
python
if func.__closure__ is not None: closure_values = list(map(_get_cell_contents, func.__closure__)) else: closure_values = () # Extract currently-imported submodules used by func. Storing these modules # in a smoke _cloudpickle_subimports attribute of the object's state will # trigger the...
Review this code and list any quality issues.
[]
0
python
X = _convert_container([[1.0, 0.0], [0.0, 2.0], [1.0, 3.0]], accepted_sparse_type) X.data = X.data.astype(dtype, copy=False) X.indices = X.indices.astype(index_dtype, copy=False) X.indptr = X.indptr.astype(index_dtype, copy=False) labels = [0, 1, -1] clf = Estimator(**parameters).fit(X, labels) ...
Review this code and list any quality issues.
[ { "issue": "The `getattr` looks quite cryptic to me :) Is it to coerce `graph` to a numpy array if need be ? Maybe\r\n```suggestion\r\n if sparse.issparse(graph):\r\n graph = graph.toarray()\r\n assert_allclose(graph, expected)\r\n```", "severity": "minor", "line": 26 } ]
1
python
@setup_required @login_required @account_initialization_required def post(self): current_user, _ = current_account_with_tenant() # The role of the current user in the ta table must be admin, owner, or editor if not (current_user.has_edit_permission or current_user.is_dataset_editor):...
Review this code and list any quality issues.
[ { "issue": "Typo in comment: \"ta table\" should be \"tag table\".", "severity": "minor", "line": 26 } ]
1
python
Returns: A tuple of (function_calls, remaining_content) if tool calls were parsed, or None if no tool calls. """ function_calls: list[FunctionCall] = [] if request.tool_choice and isinstance(request.tool_choice, ToolChoiceFunction): # Forced Function Call (Re...
Review this code and list any quality issues.
[ { "issue": "I remember there should be an assertion here to check that `content` is not `None`. Please keep it.", "severity": "minor", "line": 26 } ]
1
python
'duration': 2716.333, 'subtitles': {'eng': [{'ext': 'vtt', 'protocol': 'm3u8_native'}]}, 'thumbnail': 'https://thumbnails.cbc.ca/maven_legacy/thumbnails/481/326/thumbnail.jpeg', 'uploader': 'CBCC-NEW', 'chapters': 'count:5', 'upload_date': '20230729', ...
Review this code and list any quality issues.
[ { "issue": "- `cbcplayer:` prefix should only be matched by `CBCPlayerIE`\r\n - `.+` is too broad, we want to exclude query and fragment, yeah?\r\n```suggestion\r\n _VALID_URL = r'https?://(?:www\\.)?cbc\\.ca/(?:player/)(?!play/)(?P<id>[^?#]+)'\r\n```", "severity": "minor", "line": 26 } ]
1
python
@pytest.mark.parametrize("operation, sequence_is_valid", [(EventOperation.CREATION, True), (EventOperation.CREATION, False), (EventOperation.UPDATE, True), ...
Review this code and list any quality issues.
[]
0
python
self.logger = logger if logger is not None else logging.getLogger(__name__) self.gpu_type = None self.process = None device_type = torch.accelerator.current_accelerator().type if is_torch_accelerator_available() else "cuda" torch_accelerator_module = getattr(torch, device_type, torch.cu...
Review this code and list any quality issues.
[ { "issue": "Nit: I'd move this to the top of the file, just a convention at this point", "severity": "major", "line": 26 } ]
1
python
gemini_response_text, resolution_wh=(1000, 1000), classes=['cat', 'dog'], ) detections.xyxy # array([[543., 40., 728., 200.], [653., 352., 820., 522.]]) detections.data # {'class_name': array(['cat', 'dog'], dtype='<U26')} ...
Review this code and list any quality issues.
[ { "issue": "```suggestion\n According to the [Gemini API documentation on image prompts](\n https://ai.google.dev/gemini-api/docs/vision?hl=en),\n```", "severity": "minor", "line": 26 } ]
1
python
import threading import typing as t from ._warnings import _warn from .gui import Gui from .state import State def download( state: State, content: t.Any, name: t.Optional[str] = "", on_action: t.Optional[t.Union[str, t.Callable]] = "" ): """Download content to the client. Arguments: state (Stat...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n - a buffer (such as a `bytes` object): if the size of the buffer is smaller than the\r\n```", "severity": "minor", "line": 26 } ]
1
python
from .common import InfoExtractor from .streaks import StreaksBaseIE from ..utils import ( clean_html, int_or_none, str_or_none, unified_timestamp, ) from ..utils.traversal import find_element, traverse_obj class TBSJPEpisodeIE(StreaksBaseIE): _VALID_URL = r'https?://cu\.tbs\.co\.jp/episode/(?P<id...
Review this code and list any quality issues.
[ { "issue": "doesn’t the geo-restriction seem to be applied only by STREAKS and not TBS FREE? If so, is `_GEO_BYPASS` really necessary?", "severity": "minor", "line": 14 } ]
1
python
}] def _real_extract(self, url): video_id = self._match_id(url) webpage = self._download_webpage(url, video_id) info = self._search_nextjs_data(webpage, video_id) entry = info['props']['pageProps']['entry'] track_id = entry['id'] title = entry['title'] da...
Review this code and list any quality issues.
[ { "issue": "- inline metadata extraction in the return when you are able to\r\n- metadata extraction should be non-fatal; use `.get()` (when it is actually non-fatal) or use the `traverse_obj()` util func (instead of chaining `.get()`s)\r\n- use helper funcs like `parse_iso8601` or `unified_timestamp` (import f...
1
python
except Exception as e: # pragma: no cover _warn( f"Exception raised in '{lib_name}.get_data({lib_name}, payload, {user_var_name}, value)'", # noqa: E501 e, ) if not isinstance(ret_payloa...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n if page_path in [\"/\", \"\"]:\r\n```\r\nMore efficient don't you think?", "severity": "major", "line": 26 } ]
1
python
""" <py-config> # we use asciitree because it's one of the smallest packages # which are built and distributed with pyodide packages = ["asciitree"] </py-config> <py-script> import js import asciitree ...
Review this code and list any quality issues.
[ { "issue": "I think this comment shouldn't be there", "severity": "minor", "line": 26 } ]
1
python
batch = _examples_to_batch(examples) if self.features: # `IterableDataset` automatically fills missing columns with None. # This is done with `_apply_feature_types_on_batch`. batch = _apply_feature_types_on_batch(batch, self.features, token_per_repo_id=self._t...
Review this code and list any quality issues.
[ { "issue": "My bad, I forgot the colon:\r\n```suggestion\r\n split ([`NamedSplit`], defaults to `Split.TRAIN`):\r\n```", "severity": "minor", "line": 26 } ]
1
python
return rv return Expr.__ge__(*rv) def __lt__(self, other): rv = self._Rrel(other, '__gt__') if rv is None: rv = self, other elif not isinstance(rv, tuple): return rv return Expr.__lt__(*rv) def __le__(self, other): rv = self._Rrel(other, ...
Review this code and list any quality issues.
[ { "issue": "There should be a blank line in between each function in a class.", "severity": "minor", "line": 26 } ]
1
python
csa_high_result = csa_high_val + 1 OVERSIZE_NUMBER = 2**31 assert_equal(len(CScriptNum.encode(CScriptNum(OVERSIZE_NUMBER))), 6) assert_equal(len(CScriptNum.encode(CScriptNum(OVERSIZE_NUMBER-1))), 5) big_choices = [] big_scriptops = [] for i in range(1000): r = random.randrange(len(pubs...
Review this code and list any quality issues.
[]
0
python
'view_count': int, 'categories': ['Science & Technology'], 'tags': [], 'thumbnail': r're:^https?://.*\.(?:jpg|webp)', 'thumbnails': 'count:42', 'chapters': 'count:20', }, 'params': { 'skip_download': 'm3u8', }, }, { ...
Review this code and list any quality issues.
[]
0
python
providers_cann, "onnxruntime.dll", ] # DNNL, TensorRT, OpenVINO, and QNN EPs are built as shared libs libs.extend(["onnxruntime_providers_shared.dll"]) libs.extend(["onnxruntime_providers_dnnl.dll"]) libs.extend(["onnxruntime_providers_tensorrt.dll"]) libs.extend(["onnxruntime_providers_...
Review this code and list any quality issues.
[ { "issue": "This should have been included previously; I suspect that dumping `.dlc` files from Python on Windows is broken.", "severity": "critical", "line": 26 } ]
1
python
""" Fetch a PO Token for a given client and context. This function will validate required parameters for a given context and client. EXPERIMENTAL: This method is unstable and may change or be removed without notice. @param client: The client to fetch the PO Token for. @param context: T...
Review this code and list any quality issues.
[ { "issue": "can shorten these lines:\r\n```suggestion\r\n experiments = traverse_obj(ytcfg, (\r\n 'WEB_PLAYER_CONTEXT_CONFIGS', ..., 'serializedExperimentFlags', {urllib.parse.parse_qs}))\r\n if traverse_obj(experiments, (..., 'html5_generate_content_po_token', -1, any)) == 'true':\r\n`...
1
python
class TestCookies(unittest.TestCase): def test_get_desktop_environment(self): """ based on https://chromium.googlesource.com/chromium/src/+/refs/heads/main/base/nix/xdg_util_unittest.cc """ test_cases = [ ({}, _LinuxDesktopEnvironment.OTHER), ({'DESKTOP_SESSION': 'gnome'}, _...
Review this code and list any quality issues.
[]
0
python
self.index_map = dict(zip(self.idx_list, range(len(self)))) self._is_sorted = False def __getitem__(self, i: int): return self.idx_list[i] def _convert_type(self, item): """ After user creates indices with Type A, user may query data with other types with the same info. ...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n # NOTE: It is hard to consider every cases at first. \r\n # We just try to cover part of cases to make it more user-friendly \r\n```", "severity": "minor", "line": 26 } ]
1
python
limit=limit, had_multiple_clients=False, queue_modified_at=existing_queue_by_id._modified_at, # noqa: SLF001 items=requests, ) @override async def list_and_lock_head(self, *, lock_secs: int, limit: int | None = None) -> RequestQueueHeadWithLocks: ...
Review this code and list any quality issues.
[ { "issue": "Maybe add a read-only property `in_progress` to avoid type ignores?", "severity": "minor", "line": 26 } ]
1
python
def test_credentials_can_be_set(self): bc_session = self.bc_session_cls.return_value # Set values in constructor Session(aws_access_key_id='key', aws_secret_access_key='secret', aws_session_token='token') self.assertTrue(self.bc_session_cls.called, ...
Review this code and list any quality issues.
[ { "issue": "I'm missing something. How does this test actually work? Is there some global patching happening that I'm missing.\n\nPerhaps it's worth making this test more straightforward and exposing a user agent interface on the session itself. That's what we really care about:\n\n```\nsession = <create bot...
1
python
from .common import InfoExtractor from ..utils import ( ExtractorError, mimetype2ext, url_or_none, ) from ..utils.traversal import traverse_obj class VidlyIE(InfoExtractor): _VALID_URL = r'https?://(?:vid\.ly/|(?:s\.)?vid\.ly/embeded.html\?(?:[^#/]+&)?link=)(?P<id>\w+)' _EMBED_REGEX = [r'<script[^...
Review this code and list any quality issues.
[ { "issue": "do you have any `_WEBPAGE_TESTS` we can add?", "severity": "minor", "line": 13 } ]
1
python
if name.endswith(".pre_mixer_norm.weight"): data_torch = data_torch + 1.0 elif name.endswith(".post_mixer_norm.weight"): data_torch = data_torch + 1.0 / 5 elif name.endswith(".pre_mlp_norm.weight"): data_torch = data_torch + 1.0 elif name.endswith(".post_mlp_n...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n return [(self.map_tensor_name(name), data_torch)]\r\n```", "severity": "minor", "line": 26 } ]
1
python
runtime=runtime, creds=creds, overwrite=overwrite, token=token, org_id=org_id, public=public, verbose=verbose, ) feature_report_path( dest_path, "like", {"Overwrite": overwrite, "Public": pub...
Review this code and list any quality issues.
[]
0
python
'view_count': int, }, }] def _real_extract(self, url): broadcast_type, display_id = self._match_valid_url(url).groups() if broadcast_type == 'events': timeline = self._call_api( f'live_event/1/{display_id}/timeline.json', display_id) broadcast_id...
Review this code and list any quality issues.
[ { "issue": "if adding this can you update the other tests too please", "severity": "minor", "line": 26 } ]
1
python
if shape is not None: interface['shape'] = tuple(shape) if strides is not None: interface['strides'] = tuple(strides) array = np.asarray(DummyArray(interface, base=base)) # The route via `__interface__` does not preserve structured # dtypes. Since dtype should remain unchanged, we set i...
Review this code and list any quality issues.
[ { "issue": "\"before starts\" and \"after ends\" reads a bit funny, but doesn't matter.", "severity": "minor", "line": 26 } ]
1
python
self.raise_login_required(method='any') raise ExtractorError(login_err, expected=True) embed_url = self._html_search_regex(r'embed_url:\s*["\'](.+?)["\']', webpage, 'embed url') thumbnail = self._og_search_thumbnail(webpage) watch_info = get_element_by_id('watch-info', webpage) ...
Review this code and list any quality issues.
[ { "issue": "what does this value look like? also it's not extracted in either of the tests", "severity": "major", "line": 26 } ]
1
python
def _extract_episode(self, podcast, episode): return { 'id': str(episode.get('id')), 'title': episode.get('title'), 'description': episode.get('description'), 'url': episode.get('audio_url'), 'thumbnail': episode.get('image_url'), 'duration...
Review this code and list any quality issues.
[ { "issue": "Regarding the errors, would this be a good fix?\r\n`r'(?P<id>\\d+).+[^\\d]$'`", "severity": "minor", "line": 26 } ]
1
python
detections=detections, ) cv2.imshow("Processed Video", annotated_frame) if cv2.waitKey(1) & 0xFF == ord("q"): break cv2.destroyAllWindows() if __name__ == "__main__": try: # Try to import jsonargparse for CLI parsing from jsonargparse im...
Review this code and list any quality issues.
[ { "issue": "The fallback CLI implementation doesn't handle potential ValueError exceptions when converting sys.argv values to float (lines 202-203). If a user provides non-numeric values for confidence_threshold or iou_threshold, the script will crash with an unclear error. Consider wrapping the float conversio...
1
python
class LineRunFieldName: LINE_RUN_ID = "line_run_id" TRACE_ID = "trace_id" ROOT_SPAN_ID = "root_span_id" INPUTS = "inputs" OUTPUTS = "outputs" START_TIME = "start_time" END_TIME = "end_time" STATUS = "status" LATENCY = "latency" NAME = "name" KIND = "kind" CUMULATIVE_TOKEN...
Review this code and list any quality issues.
[ { "issue": "one silly questoin, what is instance results? may add to the pr desc.", "severity": "minor", "line": 26 } ]
1
python
if session['script_mode'] == NATIVE: is_installed = check_programs('Calibre', 'ebook-convert', '--version') if not is_installed: error = f'check_programs() Calibre failed: {e}' is_installed = check_programs('FFmpeg', 'ff...
Review this code and list any quality issues.
[ { "issue": "The logic is inverted. When `compare_checksums` returns `True` (checksum matches), conversion should be skipped. When it returns `False` (no match/new file), conversion is needed. The condition should be `if checksum:` to skip conversion when checksums match.", "severity": "minor", "line": 2...
1
python
value=value, searchable=searchable, id="dropdown", ), html.Button("Remove option", id="remove"), html.Div(id="value-output"), ] ) @app.callback(Output("dropdown", "options"), [Input("remove", "n_clicks")]) def on_click(n_clicks): ...
Review this code and list any quality issues.
[ { "issue": "@TillerBurr While investigating this issue earlier, I found a quirk of `wait_for_text_to_equal` which gives false positives when used with the text`\"None\"`.\r\n\r\nI recommend to try changing this string to anything besides `\"None\"` (both here and on line 46) and see whether the test still passe...
1
python
if tag == qn('w:r'): # Regular run run = Run(child, paragraph) process_run(run) elif tag == qn('w:hyperlink'): # Hyperlink containing runs r_id = child.get(qn('r:id')) # Extract text ...
Review this code and list any quality issues.
[ { "issue": "The exception handling here is too broad and silently swallows all exceptions. While the error is logged, the link text will be appended without the URL formatting (line 357), which could lead to confusing output. Consider handling specific exceptions (e.g., `KeyError`, `AttributeError`) and potenti...
1
python
import numpy as np import math import warnings from collections import namedtuple from collections.abc import Callable from scipy.special import roots_legendre from scipy.special import gammaln, logsumexp from scipy._lib._util import _rng_spawn from scipy._lib._array_api import (_asarray, array_namespace, xp_result_ty...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n xp_size,\r\n```", "severity": "minor", "line": 13 } ]
1
python
if recurse: for submob in self.submobjects: submob.resume_updating(recurse) for parent in self.parents: parent.resume_updating(recurse=False, call_updater=False) if call_updater: self.update(dt=0, recurse=recurse) return self def refresh_h...
Review this code and list any quality issues.
[]
0
python
super().__init__(logger, binary=binary, webdriver_binary=binary, webdriver_args=args, host=webdriver_host, env=env, supports_pac=False, **kwargs) self.hosts_path = hosts_path def make_command(self): return [self.webdriver_binary, f"--webdriver={sel...
Review this code and list any quality issues.
[ { "issue": "```suggestion\n except Exception as exception:\n self.logger.debug(f\"Servo has shut down normally. {exception}\")\n return False\n```", "severity": "critical", "line": 26 } ]
1
python
# View of the data on/after the split. self.adj_closes = adj_closes = self.closes.copy() adj_closes.ix[:self.split_date, self.split_asset] *= self.split_ratio self.pipeline_loader = DataFrameLoader( column=USEquityPricing.close, baseline=self.closes, adjustme...
Review this code and list any quality issues.
[ { "issue": "I would expect this function to have to account for the split in the test data used by this test.", "severity": "minor", "line": 26 } ]
1
python
serialize_multimedia_during_execution=True, ) self._init = True @classmethod def get_instance(cls): if cls._instance is None: raise UninitializedError( "Please initialize the executor service with the '/initialize' api before sending execution requests." ...
Review this code and list any quality issues.
[ { "issue": "You can remove this line because it is included in the `exec_aggregation`.", "severity": "major", "line": 26 } ]
1
python
Creates an HTML table with parameter names and values, wrapped in a collapsible details element. Parameters are styled differently based on whether they are default or user-set values. """ PARAMS_TABLE_TEMPLATE = """ <div class="estimator-table"> <details> <summary>Pa...
Review this code and list any quality issues.
[]
0
python
}, }, { 'url': 'https://play.su.se/media/H1YA0EYNCxiesrSU1kaRBQ/baltic-breakfast', 'md5': '2b817647c3058002526269deff4c0683', 'info_dict': { 'id': 'H1YA0EYNCxiesrSU1kaRBQ', 'ext': 'mp4', 'title': 'Baltic Breakfast', ...
Review this code and list any quality issues.
[ { "issue": "why not extract all formats instead of the `if not formats`?", "severity": "major", "line": 26 } ]
1
python
assert result["source"]["data"] == csv_content assert result["citations"] == {"enabled": True} def test_filepath_pdf_returns_base64_source(self, tmp_path): pdf_bytes = b"%PDF-1.4 fake content" p = tmp_path / "doc.pdf" p.write_bytes(pdf_bytes) result = _format_file_for_messa...
Review this code and list any quality issues.
[]
0
python
import gc import logging import os from pathlib import Path from typing import Callable, Iterator, List, Optional, Tuple import torch import torch.distributed as dist import torch.nn as nn from torch.optim import Optimizer from torch.optim.lr_scheduler import _LRScheduler as LRScheduler from torch.utils.data import Da...
Review this code and list any quality issues.
[ { "issue": "Don't use DDP. There sychronization logic may have conflicts", "severity": "minor", "line": 13 } ]
1
python
'ext': ext, }) return { 'id': video_id, 'title': title, 'formats': formats, 'description': description, 'duration': duration, 'thumbnail': try_get(video_params, lambda vi: 'https:' + compat_b64de...
Review this code and list any quality issues.
[ { "issue": "```suggestion\r\n if not items:\r\n raise ExtractorError('Video is not available', video_id=video_id, expected=True)\r\n```", "severity": "major", "line": 26 } ]
1