id stringlengths 40 40 | instruction stringlengths 68 308 | input stringlengths 17 33.4k | output stringlengths 100 30k |
|---|---|---|---|
c1f60a5a419cc60aff27daffb150f5a3a3a79ef4 | Analyze and fix the following issue in the Linux kernel code: [PATCH] reduce MAX_NR_ZONES: move HIGHMEM counters into highmem.c/.h | Problem Details:
Move totalhigh_pages and nr_free_highpages() into highmem.c/.h
Move the totalhigh_pages definition into highmem.c/.h. Move the
nr_free_highpages function into highmem.c
[yoichi_yuasa@tripeaks.co.jp: build fix]
Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Yoichi Yuasa <yoichi_yu... | ```diff
diff --git a/arch/mips/sgi-ip27/ip27-memory.c b/arch/mips/sgi-ip27/ip27-memory.c
index 59bfc0fc3f45..16e5682b01f1 100644
--- a/arch/mips/sgi-ip27/ip27-memory.c
+++ b/arch/mips/sgi-ip27/ip27-memory.c
@@ -19,6 +19,7 @@
#include <linux/swap.h>
#include <linux/bootmem.h>
#include <linux/pfn.h>
+#include <linux/h... |
f06a96844a577c43249fce25809a4fae07407f46 | Analyze and fix the following issue in the Linux kernel code: [PATCH] reduce MAX_NR_ZONES: fix MAX_NR_ZONES array initializations | Problem Details:
Fix array initialization in lots of arches
The number of zones may now be reduced from 4 to 2 for many arches. Fix the
array initialization for the zones array for all architectures so that it is
not initializing a fixed number of elements.
Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-... | ```diff
diff --git a/arch/alpha/mm/init.c b/arch/alpha/mm/init.c
index 917dad1b74c8..550f4907d613 100644
--- a/arch/alpha/mm/init.c
+++ b/arch/alpha/mm/init.c
@@ -270,7 +270,7 @@ callback_init(void * kernel_end)
void
paging_init(void)
{
- unsigned long zones_size[MAX_NR_ZONES] = {0, 0, 0};
+ unsigned long zones_size... |
776ed98b842ee8551793f842fe028c8091f3633e | Analyze and fix the following issue in the Linux kernel code: [PATCH] reduce MAX_NR_ZONES: remove two strange uses of MAX_NR_ZONES | Problem Details:
I keep seeing zones on various platforms that are never used and wonder why we
compile support for them into the kernel. Counters show up for HIGHMEM and
DMA32 that are alway zero.
This patch allows the removal of ZONE_DMA32 for non x86_64 architectures and
it will get rid of ZONE_HIGHMEM for arches ... | ```diff
diff --git a/arch/i386/mm/init.c b/arch/i386/mm/init.c
index 89e8486aac34..353453d550a4 100644
--- a/arch/i386/mm/init.c
+++ b/arch/i386/mm/init.c
@@ -657,7 +657,7 @@ void __init mem_init(void)
int arch_add_memory(int nid, u64 start, u64 size)
{
struct pglist_data *pgdata = &contig_page_data;
- struct zone ... |
f71bf0cac730ccb5ebcdf21747db75ae0445ccde | Analyze and fix the following issue in the Linux kernel code: [PATCH] bootmem: miscellaneous coding style fixes | Problem Details:
It fixes various coding style issues, specially when spaces are useless. For
example '*' go next to the function name.
Signed-off-by: Franck Bui-Huu <vagabon.xyz@gmail.com>
Cc: Dave Hansen <haveblue@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.... | ```diff
diff --git a/include/linux/bootmem.h b/include/linux/bootmem.h
index b2067e4a4486..31e9abb6d977 100644
--- a/include/linux/bootmem.h
+++ b/include/linux/bootmem.h
@@ -38,29 +38,30 @@ typedef struct bootmem_data {
struct list_head list;
} bootmem_data_t;
-extern unsigned long bootmem_bootmap_pages (unsigned... |
204ec841fbea3e5138168edbc3a76d46747cc987 | Analyze and fix the following issue in the Linux kernel code: [PATCH] mm: msync() cleanup | Problem Details:
With the tracking of dirty pages properly done now, msync doesn't need to scan
the PTEs anymore to determine the dirty status.
From: Hugh Dickins <hugh@veritas.com>
In looking to do that, I made some other tidyups: can remove several
#includes, and sys_msync loop termination not quite right.
Most of... | ```diff
diff --git a/mm/msync.c b/mm/msync.c
index d083544df21b..358d73cf7b78 100644
--- a/mm/msync.c
+++ b/mm/msync.c
@@ -7,149 +7,33 @@
/*
* The msync() system call.
*/
-#include <linux/slab.h>
-#include <linux/pagemap.h>
#include <linux/fs.h>
#include <linux/mm.h>
#include <linux/mman.h>
-#include <linux/hug... |
3998b9301d3d55be8373add22b6bc5e11c1d9b71 | Analyze and fix the following issue in the Linux kernel code: [PATCH] jbd: fix commit of ordered data buffers | Problem Details:
Original commit code assumes, that when a buffer on BJ_SyncData list is
locked, it is being written to disk. But this is not true and hence it can
lead to a potential data loss on crash. Also the code didn't count with
the fact that journal_dirty_data() can steal buffers from committing
transaction a... | ```diff
diff --git a/fs/jbd/commit.c b/fs/jbd/commit.c
index 42da60784311..32a8caf0c41e 100644
--- a/fs/jbd/commit.c
+++ b/fs/jbd/commit.c
@@ -160,6 +160,117 @@ static int journal_write_commit_record(journal_t *journal,
return (ret == -EIO);
}
+static void journal_do_submit_data(struct buffer_head **wbuf, int bufs... |
0a2966b48fb784e437520e400ddc94874ddbd4e8 | Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix longstanding load balancing bug in the scheduler | Problem Details:
The scheduler will stop load balancing if the most busy processor contains
processes pinned via processor affinity.
The scheduler currently only does one search for busiest cpu. If it cannot
pull any tasks away from the busiest cpu because they were pinned then the
scheduler goes into a corner and su... | ```diff
diff --git a/kernel/sched.c b/kernel/sched.c
index a234fbee1238..5c848fd4e461 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -238,6 +238,7 @@ struct rq {
/* For active balancing */
int active_balance;
int push_cpu;
+ int cpu; /* cpu of this runqueue */
struct task_struct *migration_thread;
str... |
d7e7a1567894146ca6c9442c824dded4f0f48dde | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4631): Av7110: remove V4L2_CAP_VBI_CAPTURE flag | Problem Details:
Implement fix suggested by Michael Hunold for a bug reported
by Philipp Matthias Hahn: Starting "kdetv" on a Siemens DVB-C 1.x
produced an oops because kdetv opened "/dev/vbi0".
Remove the V4L2_CAP_VBI_CAPTURE flag because it does not work with
this type of hardware anyway.
Signed-off-by: Oliver Endri... | ```diff
diff --git a/drivers/media/dvb/ttpci/av7110_v4l.c b/drivers/media/dvb/ttpci/av7110_v4l.c
index 52b500a38c86..10cfe3131e72 100644
--- a/drivers/media/dvb/ttpci/av7110_v4l.c
+++ b/drivers/media/dvb/ttpci/av7110_v4l.c
@@ -921,7 +921,7 @@ static struct saa7146_ext_vv av7110_vv_data_st = {
static struct saa7146_ext... |
666c73d9e123b9ea230fcb1e2bf47fe0294332a8 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4628): Fix VIDIOC_ENUMSTD ioctl in videodev.c | Problem Details:
Do not return -EINVAL for index=0 in VIDIOC_ENUMSTD, because it is a
valid index
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/videodev.c b/drivers/media/video/videodev.c
index 2299e294e8df..26e7ea252a0e 100644
--- a/drivers/media/video/videodev.c
+++ b/drivers/media/video/videodev.c
@@ -836,7 +836,7 @@ static int __video_do_ioctl(struct inode *inode, struct file *file,
break;
}
- if (index < ... |
bc28287979592c015560f8837a98b63a3be8bbc1 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4624): Tvaudio: Replaced kernel_thread() with kthread_run() | Problem Details:
Replaced kernel_thread() with kthread_run() since kernel_thread() is
deprecated in drivers/modules.
Removed the completion and the wait queue which are now useless with
kthread. Also removed the allow_signal() call as signals don't apply
to kernel threads.
Fixed a small race condition when thread is st... | ```diff
diff --git a/drivers/media/video/tvaudio.c b/drivers/media/video/tvaudio.c
index 936e3f746fba..fcaef4bf8289 100644
--- a/drivers/media/video/tvaudio.c
+++ b/drivers/media/video/tvaudio.c
@@ -28,6 +28,7 @@
#include <linux/i2c-algo-bit.h>
#include <linux/init.h>
#include <linux/smp_lock.h>
+#include <linux/kth... |
c93a5c34887426daa70f3caf05881fafb1cd687f | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4622): Copy-paste bug in videodev.c | Problem Details:
This patch fixes a copy-paste bug in videodev.c where the vidioc_qbuf()
function gets called for the dqbuf ioctl.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/videodev.c b/drivers/media/video/videodev.c
index edd7b83c3464..2299e294e8df 100644
--- a/drivers/media/video/videodev.c
+++ b/drivers/media/video/videodev.c
@@ -739,13 +739,13 @@ static int __video_do_ioctl(struct inode *inode, struct file *file,
case VIDIOC_DQBUF:
{
str... |
5ab6b267e5684452e229c58f4a5ba9f267866d42 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4620): Fix AGC configuration for MOD3000P-based boards | Problem Details:
While converting the configuration for the old DiB3000MC-module to the new one
a wrong AGC configuration was introduced.
This is using the old one again.
Signed-off-by: Jose Alberto Reguero <jareguero@telefonica.net>
Signed-off-by: Patrick Boettcher <pb@linuxtv.org>
Signed-off-by: Mauro Carvalho Cheha... | ```diff
diff --git a/drivers/media/dvb/dvb-usb/dibusb-common.c b/drivers/media/dvb/dvb-usb/dibusb-common.c
index ead1f7a4dc00..124e25ac53b3 100644
--- a/drivers/media/dvb/dvb-usb/dibusb-common.c
+++ b/drivers/media/dvb/dvb-usb/dibusb-common.c
@@ -199,24 +199,24 @@ static struct dib3000mc_config stk3000p_dib3000p_config... |
6386828cb1748ba466e3d9df5d650ffeab937fd2 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4619): Fixes some I2C dependencies on V4L devices | Problem Details:
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig
index 69a16cab1bd8..d1183c939221 100644
--- a/drivers/media/video/Kconfig
+++ b/drivers/media/video/Kconfig
@@ -595,7 +595,7 @@ source "drivers/media/video/saa7134/Kconfig"
config VIDEO_MXB
tristate "Siemens-Nixdorf 'Multimedia eXtensio... |
c4e4aac88737879a562760ac07e51167847f193d | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4604): Fix broken pvrusb2 build | Problem Details:
Fix broken build when 24XXX support is not selected. This is required
due to the requirement of removing 24XXX ifdef's from the driver
source.
Signed-off-by: Mike Isely <isely@pobox.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/pvrusb2/Makefile b/drivers/media/video/pvrusb2/Makefile
index 02e414210dac..69b3e43cd0eb 100644
--- a/drivers/media/video/pvrusb2/Makefile
+++ b/drivers/media/video/pvrusb2/Makefile
@@ -1,10 +1,6 @@
obj-pvrusb2-sysfs-$(CONFIG_VIDEO_PVRUSB2_SYSFS) := pvrusb2-sysfs.o
obj-pvrusb2... |
1e9dadbe7a0afa0c3eeae538164d8b9d489d3cc0 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4600): Fix DVB Front-End Signal Strength Inconsistency | Problem Details:
The cx22702 returns an 8 bit unshifted value for signal strength; this is
inconsistent with most other frontends
Signed-off-by: Bradley Derek Kite <bradley.kite@gmail.com>
Signed-off-by: Andrew de Quincey <adq_dvb@lidskialf.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/frontends/cx22702.c b/drivers/media/dvb/frontends/cx22702.c
index 4106d46c957f..335219ebce2d 100644
--- a/drivers/media/dvb/frontends/cx22702.c
+++ b/drivers/media/dvb/frontends/cx22702.c
@@ -399,7 +399,9 @@ static int cx22702_read_signal_strength(struct dvb_frontend* fe, u16* sig... |
97d9e80e75547e940a24ebcd2ec99e817bcf47d6 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4598): Fix a typo: VRES, instead o HRES | Problem Details:
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/saa7115.c b/drivers/media/video/saa7115.c
index 4f61b972d680..7ba3714bf2a0 100644
--- a/drivers/media/video/saa7115.c
+++ b/drivers/media/video/saa7115.c
@@ -48,7 +48,7 @@
#include <media/saa7115.h>
#include <asm/div64.h>
-#define HRES_60HZ (480+16)
+#define VRES_60HZ (480+1... |
22ebb77dfa94904f534563512b70178f98bbe962 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4596): Fix saa7115 miscalculation that breaks NTSC | Problem Details:
This repairs a problem introduced by a commit earlier applied.
Thanks-to: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mike Isely <isely@pobox.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/saa7115.c b/drivers/media/video/saa7115.c
index 61642f83c957..4f61b972d680 100644
--- a/drivers/media/video/saa7115.c
+++ b/drivers/media/video/saa7115.c
@@ -851,7 +851,7 @@ static int saa711x_set_size(struct i2c_client *client, int width, int height)
/* On 60Hz, it is using... |
d9dce96faec043f261dc5a57d43cfc0e2905f2a5 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4592): Fixes some troubles on saa7115 | Problem Details:
Scaling were not working fine;
Some reserved registers were wrong;
On some situations, saa7115 were not properly being initializated.
Removed some duplicated code.
Thanks-to: Hans Verkuil <hverkuil@xs4all.nl> for co-working on this
patch.
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by:... | ```diff
diff --git a/drivers/media/video/saa7115.c b/drivers/media/video/saa7115.c
index 327a43d5116b..61642f83c957 100644
--- a/drivers/media/video/saa7115.c
+++ b/drivers/media/video/saa7115.c
@@ -48,6 +48,8 @@
#include <media/saa7115.h>
#include <asm/div64.h>
+#define HRES_60HZ (480+16)
+
MODULE_DESCRIPTION("Ph... |
b31e341be01475e016842a662946b4fc9cff6bd4 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4584): Fix VIDIOC_S_FMT min/max check in pvrusb2 | Problem Details:
Acked-by: Mike Isely <isely@pobox.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/pvrusb2/pvrusb2-v4l2.c b/drivers/media/video/pvrusb2/pvrusb2-v4l2.c
index 5f5438aca136..3608c2f81df9 100644
--- a/drivers/media/video/pvrusb2/pvrusb2-v4l2.c
+++ b/drivers/media/video/pvrusb2/pvrusb2-v4l2.c
@@ -468,18 +468,18 @@ static int pvr2_v4l2_do_ioctl(struct inode *inode, ... |
d87edf264a1f7d7678015e5a6752cde877434d4b | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4573): Fix: There were some missing breaks at register check routine | Problem Details:
Without the breaks, saa7115 were not initializing PLL2.
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/saa7115.c b/drivers/media/video/saa7115.c
index 987f540bc161..2257e4e835a1 100644
--- a/drivers/media/video/saa7115.c
+++ b/drivers/media/video/saa7115.c
@@ -98,19 +98,23 @@ static int saa711x_has_reg(const int id, const u8 reg)
if (reg>0x1f || reg==1 || reg==0x0f || reg==0x1... |
66440ccbf2f4077ce59c9692a2c7288201ea0171 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4565): Fix scaling calculus | Problem Details:
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/saa7115.c b/drivers/media/video/saa7115.c
index 08a324f9a48d..987f540bc161 100644
--- a/drivers/media/video/saa7115.c
+++ b/drivers/media/video/saa7115.c
@@ -1053,7 +1053,7 @@ static int saa711x_set_size(struct i2c_client *client, int width, int height)
int VSCY;
int res;
... |
4fcd7d8f7b6ce0a0adb3edd6d6edcbf2fd05a02b | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4561): Sync'ing dvb-usb-remote with changes in USB input subsystem | Problem Details:
This patch fixes the physical address and takes into account recent
changes in the USB input subsystem.
Acked-by: Dmitry Torokhov <dtor@mail.ru>
Signed-off-by: Unai Uribarri <unaiur@gmail.com>
Signed-off-by: Trent Piepho <xyzzy@speakeasy.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org... | ```diff
diff --git a/drivers/media/dvb/dvb-usb/dvb-usb-remote.c b/drivers/media/dvb/dvb-usb/dvb-usb-remote.c
index e5c6d9835e06..380b2a45ee4c 100644
--- a/drivers/media/dvb/dvb-usb/dvb-usb-remote.c
+++ b/drivers/media/dvb/dvb-usb/dvb-usb-remote.c
@@ -6,6 +6,7 @@
* This file contains functions for initializing the the... |
58f56cbe29042dca81fd59c05fb2055d58557d1e | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4556): Fix a typo. | Problem Details:
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/pvrusb2/pvrusb2-encoder.c b/drivers/media/video/pvrusb2/pvrusb2-encoder.c
index 18a7073501c6..c94f97b79392 100644
--- a/drivers/media/video/pvrusb2/pvrusb2-encoder.c
+++ b/drivers/media/video/pvrusb2/pvrusb2-encoder.c
@@ -317,7 +317,7 @@ int pvr2_encoder_configure(struct pvr2_hd... |
fb6065bbd915f9cf6022d52e114f5078654834b5 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4530): Another fix for the PID parsing | Problem Details:
Still the pid_parse bit was erased.
Signed-off-by: Patrick Boettcher <pb@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/frontends/dib3000mc.c b/drivers/media/dvb/frontends/dib3000mc.c
index 6d61237a450d..cc28417fa33a 100644
--- a/drivers/media/dvb/frontends/dib3000mc.c
+++ b/drivers/media/dvb/frontends/dib3000mc.c
@@ -169,8 +169,7 @@ static int dib3000mc_set_output_mode(struct dib3000mc_state *stat... |
559463bba8b91d36b12f6722dc27440567e4f6be | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4529): Keep the PID parse bit when resetting the output mode | Problem Details:
Matthieu Castet found that with the rewritten dib3000mc-driver the PID-parsing
was handled correctly. This changeset fixes it.
Thanks Matthieu
Signed-off-by: Patrick Boettcher <pb@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/frontends/dib3000mc.c b/drivers/media/dvb/frontends/dib3000mc.c
index 0b4b8220b69d..6d61237a450d 100644
--- a/drivers/media/dvb/frontends/dib3000mc.c
+++ b/drivers/media/dvb/frontends/dib3000mc.c
@@ -169,7 +169,8 @@ static int dib3000mc_set_output_mode(struct dib3000mc_state *stat... |
56760f07a7948d53b807c8f00c1639df9acf97fd | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4525): Drivers/media/dvb/dvb-usb/dibusb-mb.c: NULL dereference | Problem Details:
The Coverity checker spotted the following "we dereference d->fe only
when we know it's NULL" bug:
<-- snip -->
...
static int dibusb_dib3000mb_frontend_attach(struct dvb_usb_device *d)
{
...
if ((d->fe = dib3000mb_attach(&demod_cfg,&d->i2c_adap,&st->ops)) == NULL) {
d->fe->ops.tuner_ops.init = dvb_u... | ```diff
diff --git a/drivers/media/dvb/dvb-usb/dibusb-mb.c b/drivers/media/dvb/dvb-usb/dibusb-mb.c
index f181d10fd88d..5439889af2f5 100644
--- a/drivers/media/dvb/dvb-usb/dibusb-mb.c
+++ b/drivers/media/dvb/dvb-usb/dibusb-mb.c
@@ -21,11 +21,11 @@ static int dibusb_dib3000mb_frontend_attach(struct dvb_usb_device *d)
... |
1e805e679a4e92099c62cc952cd668a6c683e849 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4523): Fix a warning caused by a typo (comma instead of dot-comma) | Problem Details:
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/frontends/dibx000_common.c b/drivers/media/dvb/frontends/dibx000_common.c
index 61d28de30305..a18c8f45a2ee 100644
--- a/drivers/media/dvb/frontends/dibx000_common.c
+++ b/drivers/media/dvb/frontends/dibx000_common.c
@@ -63,7 +63,7 @@ static int dibx000_i2c_gated_tuner_xfer(struct ... |
d084aa706761060940110279794e6a4e83785858 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4510): Fix signedness error in drivers/media/video/vivi.c | Problem Details:
when checking the -Wextra signedness warnings issued by gcc 4.1
I came across this one:
drivers/media/video/vivi.c:1001: warning: comparison of unsigned expression < 0 is always false
Since videobuf_reqbufs() returns negative values on errors the current
code does no real error checking since gcc remov... | ```diff
diff --git a/drivers/media/video/vivi.c b/drivers/media/video/vivi.c
index 841884af0cc0..06b44e1dda1d 100644
--- a/drivers/media/video/vivi.c
+++ b/drivers/media/video/vivi.c
@@ -992,7 +992,8 @@ static int vidiocgmbuf (struct file *file, void *priv, struct video_mbuf *mbuf)
struct vivi_fh *fh=priv;
struct ... |
0d0d871b3f3395820ec33a78fb2cc101b9bdcced | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4508): Fix an array overflow on bt866 | Problem Details:
The Coverity checker spotted the following two array overflows.
Registers 0xcc and 0xdc were cached on reg[] array, with only 128 elements,
instead of 256.
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/bt866.c b/drivers/media/video/bt866.c
index 05e42bbcfc3d..772fd52d551a 100644
--- a/drivers/media/video/bt866.c
+++ b/drivers/media/video/bt866.c
@@ -65,7 +65,7 @@ MODULE_LICENSE("GPL");
struct bt866 {
struct i2c_client *i2c;
int addr;
- unsigned char reg[128];
+ unsigned c... |
0d7466146fa59cfa4b992a52cf274d603b475fd1 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4500): Fix KNC1 DVBC support | Problem Details:
This actually needs the same configuration as the other DVBC cards; simply
no one had managed to test before to find out.
Signed-off-by: Andrew de Quincey <adq_dvb@lidskialf.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/ttpci/budget-av.c b/drivers/media/dvb/ttpci/budget-av.c
index 6f1c41fb2cb4..764c7ad95347 100644
--- a/drivers/media/dvb/ttpci/budget-av.c
+++ b/drivers/media/dvb/ttpci/budget-av.c
@@ -1141,15 +1141,6 @@ static void frontend_init(struct budget_av *budget_av)
break;
case SUBI... |
d536e9c41f78c9959c585181f8a1e7fe8b157197 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4497): Reset USB part of DViCO Dual Digital during PCI driver attach | Problem Details:
If the FX2 does not reset properly during reboot, it can present an
invalid USB device ID and fail to attach. Prevent this situation
from occuring by resetting the USB part of the card when the PCI part
probes.
Also fix the GPIO configurations so that analog capture will not
inadvertantly reset the US... | ```diff
diff --git a/drivers/media/video/cx88/cx88-cards.c b/drivers/media/video/cx88/cx88-cards.c
index ba3ff57bba75..29ba5d53ce34 100644
--- a/drivers/media/video/cx88/cx88-cards.c
+++ b/drivers/media/video/cx88/cx88-cards.c
@@ -1041,11 +1041,11 @@ struct cx88_board cx88_boards[] = {
.input = {{
.type... |
8fb957841b2f4311e6418dcbef24564e4cebb87d | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4495): Fix "no data from ZL10353 based USB tuner" problem | Problem Details:
Force parallel transport stream output on the ZL10353 attached to a
bluebird device.
Addresses the problem where a frontend lock was observed, but no MPEG
transport data was received.
Signed-off-by: Chris Pascoe <c.pascoe@itee.uq.edu.au>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/dvb-usb/cxusb.c b/drivers/media/dvb/dvb-usb/cxusb.c
index ac72e7ed9fcc..c710c0176e07 100644
--- a/drivers/media/dvb/dvb-usb/cxusb.c
+++ b/drivers/media/dvb/dvb-usb/cxusb.c
@@ -349,6 +349,7 @@ static struct mt352_config cxusb_dee1601_config = {
static struct zl10353_config cxusb... |
7df0994d7bda8eb30b459e31f8b6be97a8f1b0b0 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4492): [dvb_attach] dvb_frontend_detach fix | Problem Details:
dvb_frontend_detach() used invalid config option CONFIG_DVB_DETACH,
so dvb_frontend_detach() did not call symbol_put_addr().
Replaced CONFIG_DVB_DETACH by CONFIG_DVB_CORE_ATTACH.
Signed-off-by: Oliver Endriss <o.endriss@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.c b/drivers/media/dvb/dvb-core/dvb_frontend.c
index 86dadc71cd61..3dd5dbafb330 100644
--- a/drivers/media/dvb/dvb-core/dvb_frontend.c
+++ b/drivers/media/dvb/dvb-core/dvb_frontend.c
@@ -1113,7 +1113,7 @@ int dvb_unregister_frontend(struct dvb_frontend* fe)
}... |
18795eb98d117dbb96fadfc17a7da44c93857fd6 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4488): Fix possible crash in Hauppauge eeprom reading | Problem Details:
If an eeprom defined two tuners and they supported more than eight
standards combined (as opposed to each), it would overflow an array.
Signed-off-by: Trent Piepho <xyzzy@speakeasy.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/tveeprom.c b/drivers/media/video/tveeprom.c
index d95529e8e513..cd1502ac9560 100644
--- a/drivers/media/video/tveeprom.c
+++ b/drivers/media/video/tveeprom.c
@@ -605,6 +605,8 @@ void tveeprom_hauppauge_analog(struct i2c_client *c, struct tveeprom *tvee,
tvee->tuner_formats |... |
40346b290fcbf95d17c05ffe5101a1b5de8af548 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4485): Fix a warning on PPC64 | Problem Details:
drivers/media/video/pvrusb2/pvrusb2-i2c-cmd-v4l2.c: In function 'set_standard':
drivers/media/video/pvrusb2/pvrusb2-i2c-cmd-v4l2.c:33: warning: format '%llx' expects type 'long long unsigned int', but argument 2 has type 'v4l2_std_id'
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/pvrusb2/pvrusb2-i2c-cmd-v4l2.c b/drivers/media/video/pvrusb2/pvrusb2-i2c-cmd-v4l2.c
index 8a9933dec912..05ea17afe903 100644
--- a/drivers/media/video/pvrusb2/pvrusb2-i2c-cmd-v4l2.c
+++ b/drivers/media/video/pvrusb2/pvrusb2-i2c-cmd-v4l2.c
@@ -31,7 +31,7 @@ static void set_standar... |
d591b9ccbe27fe974702411cff422fb6c6c62ad2 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4484): Git-dvb: cadet build fix | Problem Details:
drivers/media/radio/radio-cadet.c: In function 'cadet_do_ioctl':
drivers/media/radio/radio-cadet.c:362: warning: implicit declaration of function 'KERNEL_VERSION'
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/radio/radio-cadet.c b/drivers/media/radio/radio-cadet.c
index 938856588831..69d4b7919c5a 100644
--- a/drivers/media/radio/radio-cadet.c
+++ b/drivers/media/radio/radio-cadet.c
@@ -30,6 +30,7 @@
* Changed API to V4L2
*/
+#include <linux/version.h>
#include <linux/module.h> /* M... |
8a36ecf0f4c0861330cc9e69885b0502fedac14a | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4475): Fix most Compat32 stuff on V4L2 | Problem Details:
Tested on x64 with a bttv board. Most Get ioctls are fixed. The only
non-completely working one is VIDIOCGAUDIO. All other IOR ioctls give the
same results on x86_64 and i386 architectures.
Thanks to Alastair Poole <netstar@gatheringofgray.com> for part of this
patch and tests on ppc64.
Signed-off-by:... | ```diff
diff --git a/drivers/media/video/compat_ioctl32.c b/drivers/media/video/compat_ioctl32.c
index b69ee1194815..d82a488f12a6 100644
--- a/drivers/media/video/compat_ioctl32.c
+++ b/drivers/media/video/compat_ioctl32.c
@@ -58,6 +58,7 @@ static int put_video_tuner32(struct video_tuner *kp, struct video_tuner32 __use... |
a202a5bfb6c1d7c778f67f28b5f2caac21beafce | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4472): Remove debug-print from dib3000mc | Problem Details:
Removed and commented a small debug function.
Signed-off-by: Patrick Boettcher <pb@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/frontends/dib3000mc.c b/drivers/media/dvb/frontends/dib3000mc.c
index 04ce6276f873..0b4b8220b69d 100644
--- a/drivers/media/dvb/frontends/dib3000mc.c
+++ b/drivers/media/dvb/frontends/dib3000mc.c
@@ -69,29 +69,6 @@ static int dib3000mc_write_word(struct dib3000mc_state *state, u16... |
0f69e7f3f5256ab392fc44e7340777348b5da2cd | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4468): Another fix for attaching the DiB3000MC | Problem Details:
Another stupid fix for attaching the DiB3000MC. == 0 instead of != 0.
Signed-off-by: Patrick Boettcher <pb@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/dvb-usb/dibusb-common.c b/drivers/media/dvb/dvb-usb/dibusb-common.c
index 6723c153e3f4..ead1f7a4dc00 100644
--- a/drivers/media/dvb/dvb-usb/dibusb-common.c
+++ b/drivers/media/dvb/dvb-usb/dibusb-common.c
@@ -230,19 +230,16 @@ static struct dib3000mc_config mod3000p_dib3000p_config... |
46f73f936665ab26c8501634e6aa34464fcc1521 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: Update for MT2060 to use dvb_tuner_ops | Problem Details:
new tuner api
minor fixes for tuning
Signed-off-by: Olivier DANET <odanet@caramail.com>
Signed-off-by: Patrick Boettcher <pb@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/dvb-usb/dibusb-common.c b/drivers/media/dvb/dvb-usb/dibusb-common.c
index a32ff63d170b..78a604dfadfc 100644
--- a/drivers/media/dvb/dvb-usb/dibusb-common.c
+++ b/drivers/media/dvb/dvb-usb/dibusb-common.c
@@ -168,40 +168,6 @@ int dibusb_read_eeprom_byte(struct dvb_usb_device *d, u8... |
e4d6c1f74aaac1bbe5be50e7368e5ac99d54e5a2 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB: Cleanups for mt2060-integration | Problem Details:
- some coding style fixes for newly added mt2060
- moved agc-config from fixed values in dib3000mc to configurable ones
- whitespace clean-ups for usb-id-file
Signed-off-by: Patrick Boettcher <pb@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/dvb-usb/dibusb-common.c b/drivers/media/dvb/dvb-usb/dibusb-common.c
index 4d3d0d3dab95..e079ba95d384 100644
--- a/drivers/media/dvb/dvb-usb/dibusb-common.c
+++ b/drivers/media/dvb/dvb-usb/dibusb-common.c
@@ -168,63 +168,61 @@ int dibusb_read_eeprom_byte(struct dvb_usb_device *d, u... |
47922e9c3f583adf05a23842ff98f3b0bf7eec6d | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4441): Flexcop/nxt200x attach fix | Problem Details:
Address another case where the test in dvb-pll to see if a tuner's
PLL responds when attaching may fail.
Signed-off-by: Chris Pascoe <c.pascoe@itee.uq.edu.au>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/b2c2/flexcop-fe-tuner.c b/drivers/media/dvb/b2c2/flexcop-fe-tuner.c
index 0c3bab37d8df..b8ba87863457 100644
--- a/drivers/media/dvb/b2c2/flexcop-fe-tuner.c
+++ b/drivers/media/dvb/b2c2/flexcop-fe-tuner.c
@@ -527,7 +527,7 @@ int flexcop_frontend_init(struct flexcop_device *fc)
/*... |
4ad8eee5ac8d8336ac7965e4a4027a7b4ec080f1 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4438): Fix dvb_pll_attach for nxt2004-based cards | Problem Details:
The test in dvb-pll to see if a tuner's PLL responds when attaching fails
on NXT2004 based boards before the firmware is loaded.
This patch allows us to avoid this test by not passing an I2C bus handle to
the dvb_pll_attach routine, just as Chris Pascoe has done for MT352 and
ZL10353 based boards when ... | ```diff
diff --git a/drivers/media/video/cx88/cx88-dvb.c b/drivers/media/video/cx88/cx88-dvb.c
index b39b3629f1d0..52467b2ecdcb 100644
--- a/drivers/media/video/cx88/cx88-dvb.c
+++ b/drivers/media/video/cx88/cx88-dvb.c
@@ -701,8 +701,7 @@ static int dvb_register(struct cx8802_dev *dev)
&dev->core->i2c_adap);
... |
c162dff6437d5f66c272b1811074ee32c53d17b9 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4436): Dvb-pll support for MT352/ZL10353 based tuners. | Problem Details:
Typical wiring of MT352 and ZL10353 based tuners differs from dvb-pll's
expectation that the PLL is directly accessible. On these boards, the
PLL is actually hidden behind the demodulator, and as such can only be
accessed via the demodulator's interface. It was failing to communicate
with the PLL dur... | ```diff
diff --git a/drivers/media/dvb/frontends/dvb-pll.c b/drivers/media/dvb/frontends/dvb-pll.c
index c92877baada2..b7e7108ee5b3 100644
--- a/drivers/media/dvb/frontends/dvb-pll.c
+++ b/drivers/media/dvb/frontends/dvb-pll.c
@@ -493,6 +493,9 @@ static int dvb_pll_sleep(struct dvb_frontend *fe)
int i;
int result;
... |
bbdd11fa957913d6648cabbca59be1da479180ed | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4432): Fix Circular dependencies | Problem Details:
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/bt8xx/dst.c b/drivers/media/dvb/bt8xx/dst.c
index 52b6fb2455f9..9f72b7000c08 100644
--- a/drivers/media/dvb/bt8xx/dst.c
+++ b/drivers/media/dvb/bt8xx/dst.c
@@ -1715,6 +1715,15 @@ static int dst_get_frontend(struct dvb_frontend *fe, struct dvb_frontend_paramet
static void dst_rele... |
e4a49d76ca4e2c0b2b4c89d59d43486d781ffe95 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4428): Fix tda826x detection | Problem Details:
The tda826x detection was (correctly) cleaned up earlier, but unfortunately
changing the number of received i2c messages from 2 -> 1 was missed. This
fixes it.
Signed-off-by: Andrew de Quincey <adq_dvb@lidskialf.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/frontends/tda826x.c b/drivers/media/dvb/frontends/tda826x.c
index 7c19b88e950f..eeab26bd36ed 100644
--- a/drivers/media/dvb/frontends/tda826x.c
+++ b/drivers/media/dvb/frontends/tda826x.c
@@ -133,18 +133,18 @@ struct dvb_frontend *tda826x_attach(struct dvb_frontend *fe, int addr, ... |
0518999c5fd640bfac24c7c452e902007b1a2b0a | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4422): Improved comment for AR device and fix some typos | Problem Details:
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig
index 94d078b77bab..6afe0cf09360 100644
--- a/drivers/media/video/Kconfig
+++ b/drivers/media/video/Kconfig
@@ -320,11 +320,16 @@ config VIDEO_M32R_AR
camera module.
config VIDEO_M32R_AR_M64278
- tristate "Use Colour AR module M64278(... |
5aff308c5e73307fc495b89b6421b491f56d3657 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4410): Cleanups and fixes for dsbr100 | Problem Details:
Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig
index bb527b1df1f6..7015517e2c1b 100644
--- a/drivers/media/radio/Kconfig
+++ b/drivers/media/radio/Kconfig
@@ -352,7 +352,7 @@ config RADIO_ZOLTRIX_PORT
config USB_DSBR
tristate "D-Link USB FM radio support (EXPERIMENTAL)"
- depends on... |
2b100e7d3c448dd369cf36ff38844b2440fab49d | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4402): Fix budget-ci to use dvb_frontend_detach() | Problem Details:
I missed one call during the dvb_attach() development.
Signed-off-by: Andrew de Quincey <adq_dvb@lidskialf.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/ttpci/budget-ci.c b/drivers/media/dvb/ttpci/budget-ci.c
index e440fa100b94..2c4089cab60a 100644
--- a/drivers/media/dvb/ttpci/budget-ci.c
+++ b/drivers/media/dvb/ttpci/budget-ci.c
@@ -1046,8 +1046,7 @@ static void frontend_init(struct budget_ci *budget_ci)
budget_ci->budget.dv... |
07e19c20c8cdd5e1cc96e0bc8a37f5322ce78cdb | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4401): Disable tda10086 debug by default. | Problem Details:
Left on by accident.
Signed-off-by: Andrew de Quincey <adq_dvb@lidskialf.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/frontends/tda10086.c b/drivers/media/dvb/frontends/tda10086.c
index 5d18eba5c649..7456b0b9976b 100644
--- a/drivers/media/dvb/frontends/tda10086.c
+++ b/drivers/media/dvb/frontends/tda10086.c
@@ -43,7 +43,7 @@ struct tda10086_state {
u32 symbol_rate;
};
-static int debug = 1;... |
2cd885aa0f35e9329292e5be2a6c9d424bba5531 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4394): Git-dvb: radio-sf16fmi build fix | Problem Details:
drivers/media/radio/radio-sf16fmi.c: In function 'fmi_do_ioctl':
drivers/media/radio/radio-sf16fmi.c:147: warning: implicit declaration of function 'KERNEL_VERSION'
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/radio/radio-sf16fmi.c b/drivers/media/radio/radio-sf16fmi.c
index 5b62285ed0ce..ecc854b4ba38 100644
--- a/drivers/media/radio/radio-sf16fmi.c
+++ b/drivers/media/radio/radio-sf16fmi.c
@@ -16,6 +16,7 @@
* Converted to V4L2 API by Mauro Carvalho Chehab <mchehab@infradead.org>
*/
+... |
0912ad0b0fdee374f1f49d75fee341980f0868b6 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4392): Fix dst_ca attach | Problem Details:
Move the call to dst_attach into the dst_attach function to eliminate
problems caused with dvb_attach.
Signed-off-by: Andrew de Quincey <adq_dvb@lidskialf.net>
Acked-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/bt8xx/dst.c b/drivers/media/dvb/bt8xx/dst.c
index a853c14c61d3..52b6fb2455f9 100644
--- a/drivers/media/dvb/bt8xx/dst.c
+++ b/drivers/media/dvb/bt8xx/dst.c
@@ -1715,12 +1715,6 @@ static int dst_get_frontend(struct dvb_frontend *fe, struct dvb_frontend_paramet
static void dst_rele... |
434449f4c8902198e6fa90023f60395230f36c23 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4372): Clean up some post mpeg-controls issues in pvrusb2 | Problem Details:
Fix a few miscellaneous issues in the pvrusb2 driver related to use of
the new mpeg controls. This also should fix problems involving
update of the saa7115 / cx25840 configuration as control changes are made.
Signed-off-by: Mike Isely <isely@pobox.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@in... | ```diff
diff --git a/drivers/media/video/pvrusb2/pvrusb2-hdw-internal.h b/drivers/media/video/pvrusb2/pvrusb2-hdw-internal.h
index 0bc85c8fb8d6..14800b69e60c 100644
--- a/drivers/media/video/pvrusb2/pvrusb2-hdw-internal.h
+++ b/drivers/media/video/pvrusb2/pvrusb2-hdw-internal.h
@@ -40,32 +40,6 @@
#include "pvrusb2-io.... |
3ca57169ce979be1919b013230940bb5c7b3ba5d | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4370): Fix some typos on ioctl handling function | Problem Details:
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/radio/radio-gemtek-pci.c b/drivers/media/radio/radio-gemtek-pci.c
index ee19979e540c..cfab57d6bc4a 100644
--- a/drivers/media/radio/radio-gemtek-pci.c
+++ b/drivers/media/radio/radio-gemtek-pci.c
@@ -317,7 +317,7 @@ static int gemtek_pci_do_ioctl(struct inode *inode, struct file *file... |
fa38ad6592558660086e8ed4b12e5fdf90e78f90 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4354): A small fix at fmi->flags logic | Problem Details:
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/radio/radio-sf16fmi.c b/drivers/media/radio/radio-sf16fmi.c
index 43524119ac1c..5b62285ed0ce 100644
--- a/drivers/media/radio/radio-sf16fmi.c
+++ b/drivers/media/radio/radio-sf16fmi.c
@@ -165,7 +165,7 @@ static int fmi_do_ioctl(struct inode *inode, struct file *file,
v->rangelow =... |
38ee04f04340ffd6af868499862341d11ed2b331 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (4348): Fix: compile for radio aimslab and aztech with V4L2 only | Problem Details:
All radio devices use an obsolete mode of opening/release driver.
Since this is not V4L1 core, better to keep the method available for more
time than to rewrite open/release without a radio device to test, since the
newer method is much more complex than the previous one (although providing
support for... | ```diff
diff --git a/drivers/media/radio/radio-aimslab.c b/drivers/media/radio/radio-aimslab.c
index 7b9043f9d9bc..3368a89bfadb 100644
--- a/drivers/media/radio/radio-aimslab.c
+++ b/drivers/media/radio/radio-aimslab.c
@@ -372,7 +372,7 @@ static struct video_device rtrack_radio=
.owner = THIS_MODULE,
.name = "Rad... |
b89ebd0b0a65d5371aa9ad98e873c4616056ca68 | Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix unwinder warning in traps.c | Problem Details:
Fix
linux/arch/x86_64/kernel/traps.c: In function 'dump_trace':
linux/arch/x86_64/kernel/traps.c:275: warning: cast to pointer from integer of different size
with allnoconfig
Cc: jbeulich@novell.com
Signed-off-by: Andi Kleen <ak@suse.de> | ```diff
diff --git a/include/asm-x86_64/unwind.h b/include/asm-x86_64/unwind.h
index b8fa5cb7ff88..2e7ff10fd775 100644
--- a/include/asm-x86_64/unwind.h
+++ b/include/asm-x86_64/unwind.h
@@ -99,8 +99,8 @@ static inline int arch_unw_user_mode(const struct unwind_frame_info *info)
#else
-#define UNW_PC(frame) ((void... |
adf1423698f00d00b267f7dca8231340ce7d65ef | Analyze and fix the following issue in the Linux kernel code: [PATCH] i386/x86-64: Work around gcc bug with noreturn functions in unwinder | Problem Details:
Current gcc generates calls not jumps to noreturn functions. When that happens the
return address can point to the next function, which confuses the unwinder.
This patch works around it by marking asynchronous exception
frames in contrast normal call frames in the unwind information. Then teach
the u... | ```diff
diff --git a/arch/i386/Makefile b/arch/i386/Makefile
index 508cdbeb3a09..7cc0b189b82b 100644
--- a/arch/i386/Makefile
+++ b/arch/i386/Makefile
@@ -50,6 +50,10 @@ CFLAGS += $(shell if [ $(call cc-version) -lt 0400 ] ; then echo $(call cc-op
cflags-y += $(call as-instr,.cfi_startproc\n.cfi_endproc,-DCONFIG_AS... |
ab2e0b46cb9a197fab7d98e147cac7cd41a14047 | Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix some broken white space in ia32_signal.c | Problem Details:
No functional changes
Signed-off-by: Andi Kleen <ak@suse.de> | ```diff
diff --git a/arch/x86_64/ia32/ia32_signal.c b/arch/x86_64/ia32/ia32_signal.c
index ced15012a3d7..a6ba9951e86c 100644
--- a/arch/x86_64/ia32/ia32_signal.c
+++ b/arch/x86_64/ia32/ia32_signal.c
@@ -490,9 +490,9 @@ int ia32_setup_frame(int sig, struct k_sigaction *ka,
regs->ss = __USER32_DS;
set_fs(USER_DS);... |
35d534a3ff4905c0a7bddbad0fc9df55967742c7 | Analyze and fix the following issue in the Linux kernel code: [PATCH] x86: - restore i8259A eoi status on resume | Problem Details:
Got it. i8259A_resume calls init_8259A(0) unconditionally, even if
auto_eoi has been set. Keep track of the current status and restore that
on resume. This fixes it for AMD64 and i386.
Signed-off-by: Matthew Garrett <mjg59@srcf.ucam.org>
Signed-off-by: Andi Kleen <ak@suse.de> | ```diff
diff --git a/arch/i386/kernel/i8259.c b/arch/i386/kernel/i8259.c
index d4756d154f47..ea5f4e7958d8 100644
--- a/arch/i386/kernel/i8259.c
+++ b/arch/i386/kernel/i8259.c
@@ -45,6 +45,8 @@ static void end_8259A_irq (unsigned int irq)
#define shutdown_8259A_irq disable_8259A_irq
+static int i8259A_auto_eoi;
+
... |
f354b3a92af9b132b188b9c8ebbfb74de699926d | Analyze and fix the following issue in the Linux kernel code: [PATCH] i386: Split multi-line printk in oops output. | Problem Details:
Sometimes, bug reports come in where we've had an oops, and the
only record we have is what the reporter saw on screen shortly
before the system locked up completely. Unfortunatly, syslog
only prints lines beginning with KERN_EMERG to the console, so
some lines get lost.
An example of this can be seen... | ```diff
diff --git a/arch/i386/kernel/traps.c b/arch/i386/kernel/traps.c
index 5c0f4960c67d..c7adb076e811 100644
--- a/arch/i386/kernel/traps.c
+++ b/arch/i386/kernel/traps.c
@@ -351,8 +351,9 @@ void show_registers(struct pt_regs *regs)
ss = regs->xss & 0xffff;
}
print_modules();
- printk(KERN_EMERG "CPU: %d\... |
2817716ace8c397685bd702223cc5a8a42c7e997 | Analyze and fix the following issue in the Linux kernel code: [PATCH] i386: Fix pack_descriptor() | Problem Details:
Fix pack_descriptor:
1. flags are bits 20-23 in the high word
2. limit's 4 msb are bits 16-19 in the high word
These haven't mattered so far, because all users have had small limits
and a flags setting of 0.
Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com>
Signed-off-by: Andi Kleen <ak@sus... | ```diff
diff --git a/include/asm-i386/desc.h b/include/asm-i386/desc.h
index 5db9e96e8dc1..5874ef119ffd 100644
--- a/include/asm-i386/desc.h
+++ b/include/asm-i386/desc.h
@@ -46,7 +46,7 @@ static inline void pack_descriptor(__u32 *a, __u32 *b,
{
*a = ((base & 0xffff) << 16) | (limit & 0xffff);
*b = (base & 0xff000... |
9abd79280bbb9f56049f0168f412c3538cadb6eb | Analyze and fix the following issue in the Linux kernel code: [PATCH] i386/x86-64: Only do MCFG e820 check when type 1 works | Problem Details:
Needs earlier patch to split type 1 probing from use.
This patch should fix the x86 macs where type 1 PCI config space access
doesn't work, but MCFG does. They also don't have a usable e820 table
so the e820 sanity check failed.
Instead assume now that if type 1 doesn't work then MCFG must work
and d... | ```diff
diff --git a/arch/i386/pci/mmconfig.c b/arch/i386/pci/mmconfig.c
index 44155c5e85d1..2c4f585510c9 100644
--- a/arch/i386/pci/mmconfig.c
+++ b/arch/i386/pci/mmconfig.c
@@ -198,7 +198,9 @@ void __init pci_mmcfg_init(int type)
(pci_mmcfg_config[0].base_address == 0))
return;
- if (!e820_all_mapped(pci_m... |
a15da49debaf7f09460a886b0ecd08588410715e | Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix idle notifiers | Problem Details:
Previously exit_idle would be called more often than enter_idle
Now instead of using complicated tests just keep track of it
using the per CPU variable as a flip flop. I moved the idle state into the
PDA to make the access more efficient.
Original bug report and an initial patch from Stephane Erania... | ```diff
diff --git a/arch/x86_64/kernel/process.c b/arch/x86_64/kernel/process.c
index 885c318f76ab..458006ae19f3 100644
--- a/arch/x86_64/kernel/process.c
+++ b/arch/x86_64/kernel/process.c
@@ -80,25 +80,25 @@ void idle_notifier_unregister(struct notifier_block *n)
}
EXPORT_SYMBOL(idle_notifier_unregister);
-enum ... |
383d079bfdfcfccd6a720405a510fe325b3e6576 | Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix some stylistic issues in uaccess.h | Problem Details:
- Replace some broken white space.
- Replace __ keywords with standard names
No functional changes.
Signed-off-by: Andi Kleen <ak@suse.de> | ```diff
diff --git a/include/asm-x86_64/uaccess.h b/include/asm-x86_64/uaccess.h
index 802a4a068ef6..e856570c0689 100644
--- a/include/asm-x86_64/uaccess.h
+++ b/include/asm-x86_64/uaccess.h
@@ -84,7 +84,7 @@ struct exception_table_entry
*/
#define __get_user_x(size,ret,x,ptr) \
- __asm__ __volatile__("call __get_... |
758333458aa719bfc26ec16eafd4ad3a9e96014d | Analyze and fix the following issue in the Linux kernel code: [PATCH] Check return value of copy_to_user in compat_sys_pselect7 | Problem Details:
Fix
linux/fs/compat.c: In function compat_sys_pselect7
linux/fs/compat.c:1869: warning: ignoring return value of copy_to_user, declared with attribute warn_unused_result
To make it easier to handle I changed to semantics to not try to
write out a timespec if an error occurred. I hope that's ok.
Cc: ... | ```diff
diff --git a/fs/compat.c b/fs/compat.c
index e31e9cf96647..ce982f6e8c80 100644
--- a/fs/compat.c
+++ b/fs/compat.c
@@ -1855,7 +1855,7 @@ asmlinkage long compat_sys_pselect7(int n, compat_ulong_t __user *inp,
} while (!ret && !timeout && tsp && (ts.tv_sec || ts.tv_nsec));
- if (tsp && !(current->personalit... |
95912008ba1fb9d0677c1ce5930aeb0e85ba5710 | Analyze and fix the following issue in the Linux kernel code: [PATCH] Add __must_check to copy_*_user | Problem Details:
Following i386.
And also fix the two occurrences that caused warnings in arch/x86_64/*
Signed-off-by: Andi Kleen <ak@suse.de> | ```diff
diff --git a/arch/x86_64/ia32/ptrace32.c b/arch/x86_64/ia32/ptrace32.c
index 72bf92a9d375..d18198ed636b 100644
--- a/arch/x86_64/ia32/ptrace32.c
+++ b/arch/x86_64/ia32/ptrace32.c
@@ -375,8 +375,10 @@ asmlinkage long sys32_ptrace(long request, u32 pid, u32 addr, u32 data)
ret = -EIO;
if (!access_ok(VERIFY_... |
3022d734a54cbd2b65eea9a024564821101b4a9a | Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix zeroing on exception in copy_*_user | Problem Details:
- Don't zero for __copy_from_user_inatomic following i386.
This will prevent spurious zeros for parallel file system writers when
one does a exception
- The string instruction version didn't zero the output on
exception. Oops.
Also I cleaned up the code a bit while I was at it and added a minor
optimi... | ```diff
diff --git a/arch/x86_64/kernel/x8664_ksyms.c b/arch/x86_64/kernel/x8664_ksyms.c
index 370952c4ff22..c3454af5e3a2 100644
--- a/arch/x86_64/kernel/x8664_ksyms.c
+++ b/arch/x86_64/kernel/x8664_ksyms.c
@@ -29,6 +29,7 @@ EXPORT_SYMBOL(__put_user_8);
EXPORT_SYMBOL(copy_user_generic);
EXPORT_SYMBOL(copy_from_user);... |
ec5c09269ba9cd3b9cf879390db6d5c7dcdcaf1e | Analyze and fix the following issue in the Linux kernel code: [PATCH] i386: Do better early exception handlers | Problem Details:
Add early i386 fault handlers with debug information for common faults.
Handles:
divide error
invalid opcode
protection fault
page fault
Also adds code to detect early recursive/multiple faults and halt the
system when they happen (taken from x86_64.)
Signed-off-by: C... | ```diff
diff --git a/arch/i386/kernel/head.S b/arch/i386/kernel/head.S
index a6b8bd89aa27..be9d883c62ce 100644
--- a/arch/i386/kernel/head.S
+++ b/arch/i386/kernel/head.S
@@ -371,8 +371,65 @@ rp_sidt:
addl $8,%edi
dec %ecx
jne rp_sidt
+
+.macro set_early_handler handler,trapno
+ lea \handler,%edx
+ movl $(__KERNE... |
7b0bda74f7e77f362eaeee837e7911238acf4c76 | Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix a PDA warning uncovered by the new type checking | Problem Details:
Fix
linux/arch/x86_64/kernel/process.c: In function __switch_to:
linux/arch/x86_64/kernel/process.c:626: warning: assignment makes integer from pointer without a cast
Signed-off-by: Andi Kleen <ak@suse.de> | ```diff
diff --git a/arch/x86_64/kernel/process.c b/arch/x86_64/kernel/process.c
index fba8dfeda67c..885c318f76ab 100644
--- a/arch/x86_64/kernel/process.c
+++ b/arch/x86_64/kernel/process.c
@@ -624,7 +624,7 @@ __switch_to(struct task_struct *prev_p, struct task_struct *next_p)
And the AMD workaround requires it t... |
96e540492ab54423f3693958329e095878f1f12b | Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix a irqcount comment in entry.S | Problem Details:
Signed-off-by: Andi Kleen <ak@suse.de> | ```diff
diff --git a/arch/x86_64/kernel/entry.S b/arch/x86_64/kernel/entry.S
index 4fcc0ad8bbeb..ea32688386fd 100644
--- a/arch/x86_64/kernel/entry.S
+++ b/arch/x86_64/kernel/entry.S
@@ -519,7 +519,12 @@ END(stub_rt_sigreturn)
testl $3,CS(%rdi)
je 1f
swapgs
-1: incl %gs:pda_irqcount # RED-PEN should check preemp... |
4f7fd4d7a79193ceda4ce77f75e22917d33fa154 | Analyze and fix the following issue in the Linux kernel code: [PATCH] Add the -fstack-protector option to the CFLAGS | Problem Details:
Add a feature check that checks that the gcc compiler has stack-protector
support and has the bugfix for PR28281 to make this work in kernel mode.
The easiest solution I could find was to have a shell script in scripts/
to do the detection; if needed we can make this fancier in the future
without makin... | ```diff
diff --git a/arch/x86_64/Makefile b/arch/x86_64/Makefile
index d6472ddf5f6e..2b8d07c70106 100644
--- a/arch/x86_64/Makefile
+++ b/arch/x86_64/Makefile
@@ -58,6 +58,9 @@ cflags-y += $(call cc-option,-mno-sse -mno-mmx -mno-sse2 -mno-3dnow,)
cflags-y += $(call as-instr,.cfi_startproc\n.cfi_endproc,-DCONFIG_AS_CFI... |
f574164491d00d28b727d713685fb5edc9138200 | Analyze and fix the following issue in the Linux kernel code: [PATCH] Remove most of the special cases for the debug IST stack | Problem Details:
Remove most of the special cases for the debug IST stack. This is a
follow on clean up patch, it requires the bug fix patch that adds
orig_ist.
Signed-off-by: Keith Owens <kaos@ocs.com.au>
Signed-off-by: Andi Kleen <ak@suse.de> | ```diff
diff --git a/arch/x86_64/kernel/setup64.c b/arch/x86_64/kernel/setup64.c
index 491361752c70..9332d2361e08 100644
--- a/arch/x86_64/kernel/setup64.c
+++ b/arch/x86_64/kernel/setup64.c
@@ -237,28 +237,17 @@ void __cpuinit cpu_init (void)
* set up and load the per-CPU TSS
*/
for (v = 0; v < N_EXCEPTION_STA... |
575400d1b483fbe9e03c68758059bfaf4e4768d1 | Analyze and fix the following issue in the Linux kernel code: [PATCH] i386: Fix the EDD code misparsing the command line | Problem Details:
The EDD code would scan the command line as a fixed array, without
taking account of either whitespace, null-termination, the old
command-line protocol, late overrides early, or the fact that the
command line may not be reachable from INITSEG.
This should fix those problems, and enable us to use a lon... | ```diff
diff --git a/arch/i386/boot/edd.S b/arch/i386/boot/edd.S
index 4b84ea216f2b..34321368011a 100644
--- a/arch/i386/boot/edd.S
+++ b/arch/i386/boot/edd.S
@@ -15,42 +15,95 @@
#include <asm/setup.h>
#if defined(CONFIG_EDD) || defined(CONFIG_EDD_MODULE)
+
+# It is assumed that %ds == INITSEG here
+
movb $0, (ED... |
b3698c03eb6d4581e879d6bb0f183ed8dda96d37 | Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix boot code head.S warning | Problem Details:
When compiling a 64-bit kernel on an Ubuntu 6.06 32bit system (whose GCC is also
a cross-compiler for x86_64) I've seen that head.o is compiled as a 64-bit file
(while it should not) and ld complaining about this during linking:
[AK: it happens on all systems with new binutils]
ld: warning: i386:x86-6... | ```diff
diff --git a/arch/x86_64/boot/compressed/Makefile b/arch/x86_64/boot/compressed/Makefile
index f89d96f11a9f..e70fa6e1da08 100644
--- a/arch/x86_64/boot/compressed/Makefile
+++ b/arch/x86_64/boot/compressed/Makefile
@@ -7,7 +7,8 @@
#
targets := vmlinux vmlinux.bin vmlinux.bin.gz head.o misc.o piggy.o
-EXTRA... |
aecc63615e15de861db7436c50dade495639132c | Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix coding style and output of the mptable parser | Problem Details:
Give the printks a consistent prefix.
Add some missing white space.
Cc: len.brown@intel.com
Signed-off-by: Andi Kleen <ak@suse.de> | ```diff
diff --git a/arch/x86_64/kernel/mpparse.c b/arch/x86_64/kernel/mpparse.c
index 02eef8f6415f..20e88f4b564b 100644
--- a/arch/x86_64/kernel/mpparse.c
+++ b/arch/x86_64/kernel/mpparse.c
@@ -205,7 +205,7 @@ static int __init smp_read_mpc(struct mp_config_table *mpc)
unsigned char *mpt=((unsigned char *)mpc)+count... |
df992848f5aa803fcacd2c5e7d67034bb89e3fa3 | Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix pte_exec/mkexec and use it in change_page_attr() | Problem Details:
Fix the pte_exec/mkexec page table accessor functions to really
use the NX bit. Previously they only checked the USER bit, but
weren't actually used for anything.
Then use them in change_page_attr() to manipulate the NX bit
properly.
Signed-off-by: Andi Kleen <ak@suse.de> | ```diff
diff --git a/arch/x86_64/mm/pageattr.c b/arch/x86_64/mm/pageattr.c
index 2685b1f3671c..01591b649f4e 100644
--- a/arch/x86_64/mm/pageattr.c
+++ b/arch/x86_64/mm/pageattr.c
@@ -190,10 +190,12 @@ int change_page_attr_addr(unsigned long address, int numpages, pgprot_t prot)
* lowmem */
if (__pa(address) < KE... |
6f6b1e0477ccb2f25a9b045e38440347d2ce21c8 | Analyze and fix the following issue in the Linux kernel code: [PATCH] i386: Disallow kprobes on NMI handlers | Problem Details:
A kprobe executes IRET early and that could cause NMI recursion and stack
corruption.
Note: This problem was originally spotted by Andi Kleen. This patch
adds fixes not included in his original patch.
[AK: Jan Beulich originally discovered these classes of bugs]
Signed-off-by: Fernando Vazquez ... | ```diff
diff --git a/arch/i386/kernel/mca.c b/arch/i386/kernel/mca.c
index cd5456f14af4..eb57a851789d 100644
--- a/arch/i386/kernel/mca.c
+++ b/arch/i386/kernel/mca.c
@@ -42,6 +42,7 @@
#include <linux/errno.h>
#include <linux/kernel.h>
#include <linux/mca.h>
+#include <linux/kprobes.h>
#include <asm/system.h>
#inc... |
6ad916581181a105d7832a7dec9e1eb58f7a1621 | Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64 kernel mapping fix | Problem Details:
Fix for the x86_64 kernel mapping code. Without this patch the update path
only inits one pmd_page worth of memory and tramples any entries on it. now
the calling convention to phys_pmd_init and phys_init is to always pass a
[pmd/pud] page not an offset within a page.
Signed-off-by: Keith Mannthey<k... | ```diff
diff --git a/arch/x86_64/mm/init.c b/arch/x86_64/mm/init.c
index d40134bd6399..984155b75e4c 100644
--- a/arch/x86_64/mm/init.c
+++ b/arch/x86_64/mm/init.c
@@ -250,12 +250,13 @@ __init void early_iounmap(void *addr, unsigned long size)
}
static void __meminit
-phys_pmd_init(pmd_t *pmd, unsigned long address,... |
40bee2ee73c745922e9b2d5595c46f19d1cf1b6f | Analyze and fix the following issue in the Linux kernel code: [PATCH] fix bus numbering format in mmconfig warning | Problem Details:
Make an mmconfig warning print the bus id with a regular format.
Signed-off-by: Brice Goglin <brice@myri.com>
Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org> | ```diff
diff --git a/arch/x86_64/pci/mmconfig.c b/arch/x86_64/pci/mmconfig.c
index 3c55c76c6fd5..dd78f4d18df1 100644
--- a/arch/x86_64/pci/mmconfig.c
+++ b/arch/x86_64/pci/mmconfig.c
@@ -156,9 +156,8 @@ static __init void unreachable_devices(void)
addr = pci_dev_base(0, k, PCI_DEVFN(i, 0));
if (addr == NULL|| r... |
5e4edbb711417be40f350a319db39888a4edd450 | Analyze and fix the following issue in the Linux kernel code: [PATCH] i386: Fix warning in mpparse.c | Problem Details:
Fix
linux/arch/i386/kernel/mpparse.c: In function #MP_bus_info#:
linux/arch/i386/kernel/mpparse.c:232: warning: comparison is always false due to limited range of data type
Signed-off-by: Andi Kleen <ak@suse.de> | ```diff
diff --git a/arch/i386/kernel/mpparse.c b/arch/i386/kernel/mpparse.c
index bdaa75a5bc1c..772a4233bfe6 100644
--- a/arch/i386/kernel/mpparse.c
+++ b/arch/i386/kernel/mpparse.c
@@ -229,12 +229,14 @@ static void __init MP_bus_info (struct mpc_config_bus *m)
mpc_oem_bus_info(m, str, translation_table[mpc_record... |
cbf9b4bb76c9ce53b7fdde0dffcd000951b5f0d4 | Analyze and fix the following issue in the Linux kernel code: [PATCH] X86_64 monotonic_clock goes backwards | Problem Details:
I've noticed some erratic behavior while testing the X86_64 version
of monotonic_clock().
While spinning in a loop reading monotonic clock values (pinned to a
single cpu) I noticed that the difference between subsequent values
occasionally went negative (time going backwards).
I found that in the fol... | ```diff
diff --git a/arch/x86_64/kernel/time.c b/arch/x86_64/kernel/time.c
index d66c7f750e75..97115e608ed8 100644
--- a/arch/x86_64/kernel/time.c
+++ b/arch/x86_64/kernel/time.c
@@ -276,6 +276,7 @@ static void set_rtc_mmss(unsigned long nowtime)
* Note: This function is required to return accurate
* time even in... |
d28c4393a7bf558538e9def269c1caeab6ec056f | Analyze and fix the following issue in the Linux kernel code: [PATCH] x86: error_code is not safe for kprobes | Problem Details:
This patch moves the entry.S:error_entry to .kprobes.text section,
since code marked unsafe for kprobes jumps directly to entry.S::error_entry,
that must be marked unsafe as well.
This patch also moves all the ".previous.text" asm directives to ".previous"
for kprobes section.
AK: Following a similar ... | ```diff
diff --git a/arch/i386/kernel/entry.S b/arch/i386/kernel/entry.S
index 87f9f60b803b..ba22ec8fab54 100644
--- a/arch/i386/kernel/entry.S
+++ b/arch/i386/kernel/entry.S
@@ -591,11 +591,9 @@ ENTRY(name) \
/* The include is where all of the SMP etc. interrupts come from */
#include "entry_arch.h"
-ENTRY(divi... |
5758d5dfef1c514200bda3f29ba700f1c3e3bc99 | Analyze and fix the following issue in the Linux kernel code: [PATCH] i386: fix dubious segment register clear in cpu_init() | Problem Details:
Fix a very dubious piece of code in
arch/i386/kernel/cpu/common.c:cpu_init(). This clears out %fs and
%gs, but clobbers %eax in the process without telling gcc. It turns
out that gcc happens to be not using %eax at that point anyway so it
doesn't matter much, but it looks like a bomb waiting to go of... | ```diff
diff --git a/arch/i386/kernel/cpu/common.c b/arch/i386/kernel/cpu/common.c
index 70c87de582c7..730a7ab75009 100644
--- a/arch/i386/kernel/cpu/common.c
+++ b/arch/i386/kernel/cpu/common.c
@@ -675,7 +675,7 @@ old_gdt:
#endif
/* Clear %fs and %gs. */
- asm volatile ("xorl %eax, %eax; movl %eax, %fs; movl %eax... |
4ccf4ae3144360ab9c00d0b53427f43369287bfb | Analyze and fix the following issue in the Linux kernel code: [PATCH] remove tce_cache_blast_stress() | Problem Details:
tce_cache_blast_stress was useful during bringup to stress the IOMMU's
cache flushing. Now that we quiesce DMAs on every cache flush, using
_stress() brings the machine down to its knees once you put it under
load. Remove this debug / bringup code that isn't useful anymore
completely.
Signed-off-by: M... | ```diff
diff --git a/arch/x86_64/kernel/pci-calgary.c b/arch/x86_64/kernel/pci-calgary.c
index 7c43cb0f71a3..cd866135e4ef 100644
--- a/arch/x86_64/kernel/pci-calgary.c
+++ b/arch/x86_64/kernel/pci-calgary.c
@@ -129,11 +129,6 @@ static void tce_cache_blast(struct iommu_table *tbl);
#ifdef CONFIG_IOMMU_DEBUG
int debugg... |
796e4390e0378e1e57c033349610cfc741696a3d | Analyze and fix the following issue in the Linux kernel code: [PATCH] only verify the allocation bitmap if CONFIG_IOMMU_DEBUG is on | Problem Details:
Introduce new function verify_bit_range(). Define two versions, one
for CONFIG_IOMMU_DEBUG enabled and one for disabled. Previously we
were checking that the bitmap was consistent every time we allocated
or freed an entry in the TCE table, which is good for debugging but
incurs an unnecessary penalty o... | ```diff
diff --git a/arch/x86_64/kernel/pci-calgary.c b/arch/x86_64/kernel/pci-calgary.c
index ebe4e930b64d..7c43cb0f71a3 100644
--- a/arch/x86_64/kernel/pci-calgary.c
+++ b/arch/x86_64/kernel/pci-calgary.c
@@ -133,12 +133,35 @@ static inline void tce_cache_blast_stress(struct iommu_table *tbl)
{
tce_cache_blast(tbl... |
de684652f34f57cb60d4d78d09139a0e0c5e7b1b | Analyze and fix the following issue in the Linux kernel code: [PATCH] print whether CONFIG_IOMMU_DEBUG is enabled | Problem Details:
Signed-off-by: Muli Ben-Yehuda <muli@il.ibm.com>
Signed-off-by: Jon Mason <jdmason@us.ibm.com>
Signed-off-by: Andi Kleen <ak@suse.de> | ```diff
diff --git a/arch/x86_64/kernel/pci-calgary.c b/arch/x86_64/kernel/pci-calgary.c
index caf84e4e4ca9..ebe4e930b64d 100644
--- a/arch/x86_64/kernel/pci-calgary.c
+++ b/arch/x86_64/kernel/pci-calgary.c
@@ -127,15 +127,19 @@ static void tce_cache_blast(struct iommu_table *tbl);
/* enable this to stress test the ... |
2ade2920dcefdf5595c6380ebed131c964190855 | Analyze and fix the following issue in the Linux kernel code: [PATCH] i386/x86-64: rename is_at_popf(), add iret to tests and fix | Problem Details:
is_at_popf() needs to test for the iret instruction as well as
popf. So add that test and rename it to is_setting_trap_flag().
Also change max insn length from 16 to 15 to match reality.
LAHF / SAHF can't affect TF, so the comment in x86_64 is removed.
Signed-off-by: Chuck Ebbert <76306.1226@compus... | ```diff
diff --git a/arch/i386/kernel/ptrace.c b/arch/i386/kernel/ptrace.c
index d3db03f4085d..775f50e9395b 100644
--- a/arch/i386/kernel/ptrace.c
+++ b/arch/i386/kernel/ptrace.c
@@ -185,17 +185,17 @@ static unsigned long convert_eip_to_linear(struct task_struct *child, struct pt_
return addr;
}
-static inline int... |
52d522f53f137c7903db22f9196a48ad8658fb2b | Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix sparse warnings in compat aout code | Problem Details:
Signed-off-by: Andi Kleen <ak@suse.de> | ```diff
diff --git a/arch/x86_64/ia32/ia32_aout.c b/arch/x86_64/ia32/ia32_aout.c
index 3bf58af98936..396d3c100011 100644
--- a/arch/x86_64/ia32/ia32_aout.c
+++ b/arch/x86_64/ia32/ia32_aout.c
@@ -333,7 +333,8 @@ static int load_aout_binary(struct linux_binprm * bprm, struct pt_regs * regs)
return error;
}
- er... |
ddb15ec130d38cb8076a9926040c7435b126db65 | Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix most sparse warnings in sys_ia32.c | Problem Details:
Mostly by adding casts.
I didn't touch the "invalid access past ..." which are caused
by the sigset conversion.
Signed-off-by: Andi Kleen <ak@suse.de> | ```diff
diff --git a/arch/x86_64/ia32/sys_ia32.c b/arch/x86_64/ia32/sys_ia32.c
index 9c130993380d..33cd0a4fe388 100644
--- a/arch/x86_64/ia32/sys_ia32.c
+++ b/arch/x86_64/ia32/sys_ia32.c
@@ -60,6 +60,7 @@
#include <linux/highuid.h>
#include <linux/vmalloc.h>
#include <linux/fsnotify.h>
+#include <linux/sysctl.h>
#i... |
dd2994f619752fb731f21c89ad16536dd6673948 | Analyze and fix the following issue in the Linux kernel code: [PATCH] Add sparse annotations to quiet sparse in arch/x86_64/mm/fault.c | Problem Details:
Fixes
linux/arch/x86_64/mm/fault.c:125:7: warning: incorrect type in argument 1 (different address spaces)
linux/arch/x86_64/mm/fault.c:125:7: expected void [noderef] *<noident><asn:1>
linux/arch/x86_64/mm/fault.c:125:7: got unsigned char *[assigned] instr
linux/arch/x86_64/mm/fault.c:163:8: war... | ```diff
diff --git a/arch/x86_64/mm/fault.c b/arch/x86_64/mm/fault.c
index ac8ea66ccb94..449a437f5d70 100644
--- a/arch/x86_64/mm/fault.c
+++ b/arch/x86_64/mm/fault.c
@@ -102,7 +102,7 @@ void bust_spinlocks(int yes)
static noinline int is_prefetch(struct pt_regs *regs, unsigned long addr,
unsigned long error_code... |
131cfd7bd54767ec8959e013f83839442a54d546 | Analyze and fix the following issue in the Linux kernel code: [PATCH] Add sparse annotation to vsyscall.c | Problem Details:
Fixes
linux/arch/x86_64/kernel/vsyscall.c:276:7: warning: constant 0x0f40000000000 is so big it is long
linux/arch/x86_64/kernel/vsyscall.c:80:14: warning: incorrect type in argument 1 (different address spaces)
linux/arch/x86_64/kernel/vsyscall.c:80:14: expected void const volatile [noderef] *addr... | ```diff
diff --git a/arch/x86_64/kernel/vsyscall.c b/arch/x86_64/kernel/vsyscall.c
index 902783bc4d53..ac48c3857ddb 100644
--- a/arch/x86_64/kernel/vsyscall.c
+++ b/arch/x86_64/kernel/vsyscall.c
@@ -77,7 +77,8 @@ static __always_inline void do_vgettimeofday(struct timeval * tv)
__vxtime.tsc_quot) >> 32;
/* Se... |
2c8c0e6b8d7700a990da8d24eff767f9ca223b96 | Analyze and fix the following issue in the Linux kernel code: [PATCH] Convert x86-64 to early param | Problem Details:
Instead of hackish manual parsing
Requires earlier i386 patchkit, but also fixes i386 early_printk again.
I removed some obsolete really early parameters which didn't do anything useful.
Also made a few parameters that needed it early (mostly oops printing setup)
Also removed one panic check that wa... | ```diff
diff --git a/arch/x86_64/kernel/apic.c b/arch/x86_64/kernel/apic.c
index 496cd1bd2ae5..660602c51f51 100644
--- a/arch/x86_64/kernel/apic.c
+++ b/arch/x86_64/kernel/apic.c
@@ -36,6 +36,7 @@
#include <asm/idle.h>
#include <asm/proto.h>
#include <asm/timex.h>
+#include <asm/apic.h>
int apic_verbosity;
int a... |
d4d35854a1cf7fb170c8e133a5e40a9d19e7fc17 | Analyze and fix the following issue in the Linux kernel code: [PATCH] remove lock prefix from is_at_popf() tests | Problem Details:
The lock prefix will cause an exception when used with the
popf instruction, so no need to continue searching after it's
found.
Signed-off-by: Chuck Ebbert <76306.1226@compuserve.com>
Signed-off-by: Andi Kleen <ak@suse.de> | ```diff
diff --git a/arch/x86_64/kernel/ptrace.c b/arch/x86_64/kernel/ptrace.c
index 3a52c7bcfd12..412c6a8bf906 100644
--- a/arch/x86_64/kernel/ptrace.c
+++ b/arch/x86_64/kernel/ptrace.c
@@ -138,7 +138,7 @@ static int is_at_popf(struct task_struct *child, struct pt_regs *regs)
case 0x26: case 0x2e:
case 0x36: cas... |
29a6c25bd63dbd52e73d25268402d065ad84c0fe | Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix gdt table size in trampoline.S | Problem Details:
Allows easier extension of the GDT by using the proper C symbol
for the size in the descriptor.
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Andi Kleen <ak@suse.de> | ```diff
diff --git a/arch/x86_64/kernel/trampoline.S b/arch/x86_64/kernel/trampoline.S
index 23a03eb91fc7..c79b99a9e2f6 100644
--- a/arch/x86_64/kernel/trampoline.S
+++ b/arch/x86_64/kernel/trampoline.S
@@ -64,7 +64,7 @@ idt_48:
.word 0, 0 # idt base = 0L
gdt_48:
- .short __KERNEL32_CS + 7 # gdt limit
+ .short G... |
a752d7194c4fb5a3e767c95542d04fc5decb1d52 | Analyze and fix the following issue in the Linux kernel code: [PATCH] fix is_at_popf() for compat tasks | Problem Details:
When testing for the REX instruction prefix, first check
for 32-bit mode because in compat mode the REX prefix is an
increment instruction.
Signed-off-by: Chuck Ebbert <76306.1226@compuserve.com>
Signed-off-by: Andi Kleen <ak@suse.de> | ```diff
diff --git a/arch/x86_64/kernel/ptrace.c b/arch/x86_64/kernel/ptrace.c
index d35ec1bc696a..3a52c7bcfd12 100644
--- a/arch/x86_64/kernel/ptrace.c
+++ b/arch/x86_64/kernel/ptrace.c
@@ -141,8 +141,11 @@ static int is_at_popf(struct task_struct *child, struct pt_regs *regs)
case 0xf0: case 0xf2: case 0xf3:
c... |
871b17008e93d7e96f96829ce5f0393c9902d25b | Analyze and fix the following issue in the Linux kernel code: [PATCH] Calgary IOMMU: fix reference counting of Calgary PCI devices | Problem Details:
The pci_get_device() API decrements the reference count on the 'from'
parameter when it continues searching. Therefore, take a ref count on
Calgary bus when we initialize them in either translated or
non-translated mode.
Signed-off-by: Muli Ben-Yehuda <muli@il.ibm.com>
Signed-off-by: Jon Mason <jdmaso... | ```diff
diff --git a/arch/x86_64/kernel/pci-calgary.c b/arch/x86_64/kernel/pci-calgary.c
index 6c5da1d813f3..7302834718c8 100644
--- a/arch/x86_64/kernel/pci-calgary.c
+++ b/arch/x86_64/kernel/pci-calgary.c
@@ -786,6 +786,7 @@ static inline unsigned int __init locate_register_space(struct pci_dev *dev)
static int __... |
b8f4fe66a560b5ccbb4d4d0d2df356a5d9b98b83 | Analyze and fix the following issue in the Linux kernel code: [PATCH] Calgary IOMMU: fix error path memleak in calgary_free_tar | Problem Details:
We were freeing the iommu_table and leaking the bitmap pages. Also
rename it to calgary_free_bus, which is more accurate.
Signed-off-by: Muli Ben-Yehuda <muli@il.ibm.com>
Signed-off-by: Jon Mason <jdmason@us.ibm.com>
Signed-off-by: Andi Kleen <ak@suse.de> | ```diff
diff --git a/arch/x86_64/kernel/pci-calgary.c b/arch/x86_64/kernel/pci-calgary.c
index b2182c936305..6c5da1d813f3 100644
--- a/arch/x86_64/kernel/pci-calgary.c
+++ b/arch/x86_64/kernel/pci-calgary.c
@@ -658,11 +658,12 @@ static int __init calgary_setup_tar(struct pci_dev *dev, void __iomem *bbar)
return 0;
}... |
ba9c231f7499ff6918c069c72ff5fd836c76b963 | Analyze and fix the following issue in the Linux kernel code: [PATCH] i386: initialize end-of-memory variables as early as possible | Problem Details:
Move initialization of all memory end variables to as early as
possible, so that dependent code doesn't need to check whether these
variables have already been set.
Change the range check in kunmap_atomic to actually make use of this
so that the no-mapping-estabished path (under CONFIG_DEBUG_HIGHMEM)
... | ```diff
diff --git a/arch/i386/kernel/setup.c b/arch/i386/kernel/setup.c
index f1682206d304..71a540362b78 100644
--- a/arch/i386/kernel/setup.c
+++ b/arch/i386/kernel/setup.c
@@ -1170,6 +1170,14 @@ static unsigned long __init setup_memory(void)
}
printk(KERN_NOTICE "%ldMB HIGHMEM available.\n",
pages_to_mb(highe... |
efec3b9a3282714c8441b9bf476f8358bed9ecaa | Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix up some non linuxy style in ACPI functions in mpparse.c | Problem Details:
No functional changes.
Cc: len.brown@intel.com
Signed-off-by: Andi Kleen <ak@suse.de> | ```diff
diff --git a/arch/x86_64/kernel/mpparse.c b/arch/x86_64/kernel/mpparse.c
index 0cc88f7f288b..d63f849aea2c 100644
--- a/arch/x86_64/kernel/mpparse.c
+++ b/arch/x86_64/kernel/mpparse.c
@@ -614,23 +614,17 @@ void __init find_smp_config(void)
#ifdef CONFIG_ACPI
-void __init mp_register_lapic_address (
- u64 ... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.