id
stringlengths
40
40
instruction
stringlengths
68
308
input
stringlengths
17
33.4k
output
stringlengths
100
30k
190f4939222b8c07cd62a20e1ce0c7a97fffde99
Analyze and fix the following issue in the Linux kernel code: [PATCH] uml: fix off-by-one bug in VM file creation
Problem Details: Fix an off-by-one bug in temp file creation. Seeking to the desired length and writing a byte resulted in the file being one byte longer than expected. Signed-off-by: Jeff Dike <jdike@addtoit.com> Cc: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it> Signed-off-by: Andrew Morton <akpm@osdl.org> ...
```diff diff --git a/arch/um/os-Linux/mem.c b/arch/um/os-Linux/mem.c index d24d1a960523..560c8063c77c 100644 --- a/arch/um/os-Linux/mem.c +++ b/arch/um/os-Linux/mem.c @@ -210,8 +210,11 @@ int create_tmp_file(unsigned long long len) exit(1); } - if (lseek64(fd, len, SEEK_SET) < 0) { - perror("os_seek_fil...
c2b7a4bb30008dc256d63802e02b6fb950958443
Analyze and fix the following issue in the Linux kernel code: [PATCH] uml: fix /proc/mounts parsing boundary condition
Problem Details: When parsing /proc/mounts looking for a tmpfs mount on /dev/shm, if a string that we are looking for if split across reads, then it won't be recognized. Fix this by refilling the buffer whenever we advance the cursor. Signed-off-by: Jeff Dike <jdike@addtoit.com> Cc: Paolo 'Blaisorblade' Giarrusso <bl...
```diff diff --git a/arch/um/os-Linux/mem.c b/arch/um/os-Linux/mem.c index c6432e729241..d24d1a960523 100644 --- a/arch/um/os-Linux/mem.c +++ b/arch/um/os-Linux/mem.c @@ -55,7 +55,7 @@ static void __init find_tempdir(void) */ static int next(int fd, char *buf, int size, char c) { - int n; + int n, len; char *ptr;...
dd673bca474a199fb8d1b6a311832592977ecb5f
Analyze and fix the following issue in the Linux kernel code: [PATCH] UML: fix the INIT_ENV_ARG_LIMIT dependencies
Problem Details: Fix the INIT_ENV_ARG_LIMIT dependencies to what seems to have been intended. Spotted by Jean-Luc Leger. Signed-off-by: Adrian Bunk <bunk@stusta.de> Acked-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it> Cc: Jeff Dike <jdike@addtoit.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-of...
```diff diff --git a/init/Kconfig b/init/Kconfig index f515948889a7..a5b073a103e7 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -54,8 +54,8 @@ config LOCK_KERNEL config INIT_ENV_ARG_LIMIT int - default 32 if !USERMODE - default 128 if USERMODE + default 32 if !UML + default 128 if UML help Maximum of each ...
ed11d9eb2228acc483c819ab353e3c41bcb158fa
Analyze and fix the following issue in the Linux kernel code: [PATCH] slab: consolidate code to free slabs from freelist
Problem Details: Post and discussion: http://marc.theaimsgroup.com/?t=115074342800003&r=1&w=2 Code in __shrink_node() duplicates code in cache_reap() Add a new function drain_freelist that removes slabs with objects that are already free and use that in various places. This eliminates the __node_shrink() function an...
```diff diff --git a/mm/slab.c b/mm/slab.c index 5dcfb9044801..3936af344542 100644 --- a/mm/slab.c +++ b/mm/slab.c @@ -309,6 +309,13 @@ struct kmem_list3 __initdata initkmem_list3[NUM_INIT_LISTS]; #define SIZE_AC 1 #define SIZE_L3 (1 + MAX_NUMNODES) +static int drain_freelist(struct kmem_cache *cache, + struct km...
f8891e5e1f93a128c3900f82035e8541357896a7
Analyze and fix the following issue in the Linux kernel code: [PATCH] Light weight event counters
Problem Details: The remaining counters in page_state after the zoned VM counter patches have been applied are all just for show in /proc/vmstat. They have no essential function for the VM. We use a simple increment of per cpu variables. In order to avoid the most severe races we disable preempt. Preempt does not p...
```diff diff --git a/arch/s390/appldata/appldata_base.c b/arch/s390/appldata/appldata_base.c index 61bc44626c04..2476ca739c1e 100644 --- a/arch/s390/appldata/appldata_base.c +++ b/arch/s390/appldata/appldata_base.c @@ -766,7 +766,6 @@ unsigned long nr_iowait(void) #endif /* MODULE */ EXPORT_SYMBOL_GPL(si_swapinfo); ...
d2c5e30c9a1420902262aa923794d2ae4e0bc391
Analyze and fix the following issue in the Linux kernel code: [PATCH] zoned vm counters: conversion of nr_bounce to per zone counter
Problem Details: Conversion of nr_bounce to a per zone counter nr_bounce is only used for proc output. So it could be left as an event counter. However, the event counters may not be accurate and nr_bounce is categorizing types of pages in a zone. So we really need this to also be a per zone counter. [akpm@osdl.or...
```diff diff --git a/drivers/base/node.c b/drivers/base/node.c index b73d869c9d48..772eadac57a7 100644 --- a/drivers/base/node.c +++ b/drivers/base/node.c @@ -65,6 +65,7 @@ static ssize_t node_read_meminfo(struct sys_device * dev, char * buf) "Node %d AnonPages: %8lu kB\n" "Node %d PageTables: ...
fd39fc8561be33065306bdac0e30414e1e8ac8e1
Analyze and fix the following issue in the Linux kernel code: [PATCH] zoned vm counters: conversion of nr_unstable to per zone counter
Problem Details: Conversion of nr_unstable to a per zone counter We need to do some special modifications to the nfs code since there are multiple cases of disposition and we need to have a page ref for proper accounting. This converts the last critical page state of the VM and therefore we need to remove several fun...
```diff diff --git a/drivers/base/node.c b/drivers/base/node.c index a7b3dcbbdfc9..b73d869c9d48 100644 --- a/drivers/base/node.c +++ b/drivers/base/node.c @@ -40,13 +40,11 @@ static ssize_t node_read_meminfo(struct sys_device * dev, char * buf) int n; int nid = dev->id; struct sysinfo i; - struct page_state ps; ...
ce866b34ae1b7f1ce60234cf65855886ac7e7d30
Analyze and fix the following issue in the Linux kernel code: [PATCH] zoned vm counters: conversion of nr_writeback to per zone counter
Problem Details: Conversion of nr_writeback to per zone counter. This removes the last page_state counter from arch/i386/mm/pgtable.c so we drop the page_state from there. [akpm@osdl.org: bugfix] Signed-off-by: Christoph Lameter <clameter@sgi.com> Cc: Trond Myklebust <trond.myklebust@fys.uio.no> Signed-off-by: Andrew...
```diff diff --git a/arch/i386/mm/pgtable.c b/arch/i386/mm/pgtable.c index aa211dcddb08..5e735ff90e8a 100644 --- a/arch/i386/mm/pgtable.c +++ b/arch/i386/mm/pgtable.c @@ -30,7 +30,6 @@ void show_mem(void) struct page *page; pg_data_t *pgdat; unsigned long i; - struct page_state ps; unsigned long flags; prin...
b1e7a8fd854d2f895730e82137400012b509650e
Analyze and fix the following issue in the Linux kernel code: [PATCH] zoned vm counters: conversion of nr_dirty to per zone counter
Problem Details: This makes nr_dirty a per zone counter. Looping over all processors is avoided during writeback state determination. The counter aggregation for nr_dirty had to be undone in the NFS layer since we summed up the page counts from multiple zones. Someone more familiar with NFS should probably review wh...
```diff diff --git a/arch/i386/mm/pgtable.c b/arch/i386/mm/pgtable.c index 0bb1e5c13442..aa211dcddb08 100644 --- a/arch/i386/mm/pgtable.c +++ b/arch/i386/mm/pgtable.c @@ -59,7 +59,7 @@ void show_mem(void) printk(KERN_INFO "%d pages swap cached\n", cached); get_page_state(&ps); - printk(KERN_INFO "%lu pages dirty\...
df849a1529c106f7460e51479ca78fe07b07dc8c
Analyze and fix the following issue in the Linux kernel code: [PATCH] zoned vm counters: conversion of nr_pagetables to per zone counter
Problem Details: Conversion of nr_page_table_pages to a per zone counter [akpm@osdl.org: bugfix] Signed-off-by: Christoph Lameter <clameter@sgi.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/arm/mm/mm-armv.c b/arch/arm/mm/mm-armv.c index 95273de4f772..931be1798122 100644 --- a/arch/arm/mm/mm-armv.c +++ b/arch/arm/mm/mm-armv.c @@ -227,7 +227,7 @@ void free_pgd_slow(pgd_t *pgd) pte = pmd_page(*pmd); pmd_clear(pmd); - dec_page_state(nr_page_table_pages); + dec_zone_page_state(v...
9a865ffa34b6117a5e0b67640a084d8c2e198c93
Analyze and fix the following issue in the Linux kernel code: [PATCH] zoned vm counters: conversion of nr_slab to per zone counter
Problem Details: - Allows reclaim to access counter without looping over processor counts. - Allows accurate statistics on how many pages are used in a zone by the slab. This may become useful to balance slab allocations over various zones. [akpm@osdl.org: bugfix] Signed-off-by: Christoph Lameter <clameter@sgi.co...
```diff diff --git a/arch/i386/mm/pgtable.c b/arch/i386/mm/pgtable.c index f85f1a40e5c8..73ac3599a0ea 100644 --- a/arch/i386/mm/pgtable.c +++ b/arch/i386/mm/pgtable.c @@ -62,7 +62,7 @@ void show_mem(void) printk(KERN_INFO "%lu pages dirty\n", ps.nr_dirty); printk(KERN_INFO "%lu pages writeback\n", ps.nr_writeback);...
bf02cf4b6cf931d060ad5c6ce9b960af6faefd2d
Analyze and fix the following issue in the Linux kernel code: [PATCH] zoned vm counters: remove NR_FILE_MAPPED from scan control structure
Problem Details: We can now access the number of pages in a mapped state in an inexpensive way in shrink_active_list. So drop the nr_mapped field from scan_control. [akpm@osdl.org: bugfix] Signed-off-by: Christoph Lameter <clameter@sgi.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <t...
```diff diff --git a/mm/vmscan.c b/mm/vmscan.c index d2caf7471cf1..08bc54e80862 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -47,8 +47,6 @@ struct scan_control { /* Incremented by the number of inactive pages that were scanned */ unsigned long nr_scanned; - unsigned long nr_mapped; /* From page_state */ - /* T...
65ba55f500a37272985d071c9bbb35256a2f7c14
Analyze and fix the following issue in the Linux kernel code: [PATCH] zoned vm counters: convert nr_mapped to per zone counter
Problem Details: nr_mapped is important because it allows a determination of how many pages of a zone are not mapped, which would allow a more efficient means of determining when we need to reclaim memory in a zone. We take the nr_mapped field out of the page state structure and define a new per zone counter named NR_...
```diff diff --git a/arch/i386/mm/pgtable.c b/arch/i386/mm/pgtable.c index 2889567e21a1..f85f1a40e5c8 100644 --- a/arch/i386/mm/pgtable.c +++ b/arch/i386/mm/pgtable.c @@ -61,7 +61,7 @@ void show_mem(void) get_page_state(&ps); printk(KERN_INFO "%lu pages dirty\n", ps.nr_dirty); printk(KERN_INFO "%lu pages writebac...
672b2714ae57af16fe7d760dc4e0918a7a6cb0fa
Analyze and fix the following issue in the Linux kernel code: [PATCH] fix ISTALLION=y
Problem Details: drivers/char/istallion.c: In function ‘stli_initbrds’: drivers/char/istallion.c:4150: error: implicit declaration of function ‘stli_parsebrd’ drivers/char/istallion.c:4150: error: ‘stli_brdsp’ undeclared (first use in this function) drivers/char/istallion.c:4150: error: (Each undeclared ide...
```diff diff --git a/drivers/char/istallion.c b/drivers/char/istallion.c index c74e5660a9b7..18c0dcf894cd 100644 --- a/drivers/char/istallion.c +++ b/drivers/char/istallion.c @@ -282,7 +282,6 @@ static char *stli_brdnames[] = { /*****************************************************************************/ -#ifdef...
1017f6afd578fe519d316d7148356703c04e8f03
Analyze and fix the following issue in the Linux kernel code: [PATCH] fix platform_device_put/del mishaps
Problem Details: This fixes drivers/char/pc8736x_gpio.c and drivers/char/scx200_gpio.c to use the platform_device_del/put ops correctly. Signed-off-by: Ingo Molnar <mingo@elte.hu> Cc: Jim Cromie <jim.cromie@gmail.com> Cc: Greg KH <greg@kroah.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torval...
```diff diff --git a/drivers/char/pc8736x_gpio.c b/drivers/char/pc8736x_gpio.c index 1c706ccfdbb3..c860de6a6fde 100644 --- a/drivers/char/pc8736x_gpio.c +++ b/drivers/char/pc8736x_gpio.c @@ -319,9 +319,10 @@ static int __init pc8736x_gpio_init(void) return 0; undo_platform_dev_add: - platform_device_put(pdev); + p...
491d525ff19ead83b5e27ae4096b5c3e27805601
Analyze and fix the following issue in the Linux kernel code: [PATCH] fix drivers/video/imacfb.c compilation
Problem Details: Fix build error on x86_64. There's nothing even remotely close to imacmp_seg in the kernel, so I removed the whole line. Signed-off-by: Ingo Molnar <mingo@elte.hu> Cc: Edgar Hucek <hostmaster@ed-soft.at> Cc: Antonino Daplas <adaplas@pol.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by:...
```diff diff --git a/drivers/video/imacfb.c b/drivers/video/imacfb.c index 7b1c168c834d..cdbae173d69a 100644 --- a/drivers/video/imacfb.c +++ b/drivers/video/imacfb.c @@ -207,10 +207,6 @@ static int __init imacfb_probe(struct platform_device *dev) size_remap = size_total; imacfb_fix.smem_len = size_remap; -#ifnd...
741c80c24b20b5ce1903d767a13caeac0fef62c6
Analyze and fix the following issue in the Linux kernel code: Documentation/DocBook/mtdnand.tmpl: typo fixes
Problem Details: Signed-off-by: Adrian Bunk <bunk@stusta.de>
```diff diff --git a/Documentation/DocBook/mtdnand.tmpl b/Documentation/DocBook/mtdnand.tmpl index 6e463d0db266..999afe1ca8cb 100644 --- a/Documentation/DocBook/mtdnand.tmpl +++ b/Documentation/DocBook/mtdnand.tmpl @@ -189,9 +189,9 @@ static unsigned long baseaddr; <sect1> <title>Partition defines</title> <para...
d254c8f70abcb560d941e68c8c1f3b816c44a020
Analyze and fix the following issue in the Linux kernel code: typo fixes: specfic -> specific
Problem Details: Signed-off-by: Adrian Bunk <bunk@stusta.de>
```diff diff --git a/arch/i386/mm/discontig.c b/arch/i386/mm/discontig.c index fe6eb901326e..b3873327be74 100644 --- a/arch/i386/mm/discontig.c +++ b/arch/i386/mm/discontig.c @@ -43,7 +43,7 @@ EXPORT_SYMBOL(node_data); bootmem_data_t node0_bdata; /* - * numa interface - we expect the numa architecture specfic code ...
d0f19d82173e46bd7f7544d0207aec7d467b3fe4
Analyze and fix the following issue in the Linux kernel code: typo fixes in Documentation/networking/pktgen.txt
Problem Details: Three typos in only one line... Signed-off-by: Adrian Bunk <bunk@stusta.de>
```diff diff --git a/Documentation/networking/pktgen.txt b/Documentation/networking/pktgen.txt index 278771c9ad99..44f2f769e865 100644 --- a/Documentation/networking/pktgen.txt +++ b/Documentation/networking/pktgen.txt @@ -74,7 +74,7 @@ Examples: pgset "pkt_size 9014" sets packet size to 9014 pgset "frags 5" ...
80f7228b59e4bbe9d840af3ff0f2fe480d6e7c79
Analyze and fix the following issue in the Linux kernel code: typo fixes: occuring -> occurring
Problem Details: Signed-off-by: Adrian Bunk <bunk@stusta.de>
```diff diff --git a/Documentation/memory-barriers.txt b/Documentation/memory-barriers.txt index cf0d5416a4c3..28d1bc3edb1c 100644 --- a/Documentation/memory-barriers.txt +++ b/Documentation/memory-barriers.txt @@ -602,7 +602,7 @@ Consider the following sequence of events: This sequence of events is committed to the...
47bdd718c6547d84c8e140cd0f495c016f13b08b
Analyze and fix the following issue in the Linux kernel code: typo fixes: infomation -> information
Problem Details: Signed-off-by: Adrian Bunk <bunk@stusta.de>
```diff diff --git a/drivers/net/dl2k.c b/drivers/net/dl2k.c index 038447fb5c5e..29778055223b 100644 --- a/drivers/net/dl2k.c +++ b/drivers/net/dl2k.c @@ -390,7 +390,7 @@ parse_eeprom (struct net_device *dev) for (i = 0; i < 6; i++) dev->dev_addr[i] = psrom->mac_addr[i]; - /* Parse Software Infomation Block */ +...
fd245f00695cbcf0f8430f35841c216559d243df
Analyze and fix the following issue in the Linux kernel code: typo fixes: disadvantadge -> disadvantage
Problem Details: Signed-off-by: Adrian Bunk <bunk@stusta.de>
```diff diff --git a/Documentation/arm/IXP4xx b/Documentation/arm/IXP4xx index d4c6d3aa0c25..43edb4ecf27d 100644 --- a/Documentation/arm/IXP4xx +++ b/Documentation/arm/IXP4xx @@ -85,7 +85,7 @@ IXP4xx provides two methods of accessing PCI memory space: 2) If > 64MB of memory space is required, the IXP4xx can be co...
0418726bb5c7b5a70c7e7e82e860d5979d0c78cf
Analyze and fix the following issue in the Linux kernel code: typo fixes: aquire -> acquire
Problem Details: Signed-off-by: Adrian Bunk <bunk@stusta.de> Acked-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/Documentation/digiepca.txt b/Documentation/digiepca.txt index 88820fe38dad..f2560e22f2c9 100644 --- a/Documentation/digiepca.txt +++ b/Documentation/digiepca.txt @@ -2,7 +2,7 @@ NOTE: This driver is obsolete. Digi provides a 2.6 driver (dgdm) at http://www.digi.com for PCI cards. They no longer...
b3c2ffd5343645fc9b46f67e8c0eaac1e2dde7b4
Analyze and fix the following issue in the Linux kernel code: typo fixes: mecanism -> mechanism
Problem Details: Signed-off-by: Adrian Bunk <bunk@stusta.de>
```diff diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c index 8c28eb0cbdac..a820b772927d 100644 --- a/arch/powerpc/kernel/prom_init.c +++ b/arch/powerpc/kernel/prom_init.c @@ -988,7 +988,7 @@ static void reserve_mem(u64 base, u64 size) } /* - * Initialize memory allocation mecanism, p...
9aaeded72f923212e6d9d7b6b8e3830e983f323e
Analyze and fix the following issue in the Linux kernel code: typo fixes: bandwith -> bandwidth
Problem Details: Signed-off-by: Adrian Bunk <bunk@stusta.de>
```diff diff --git a/arch/cris/arch-v32/kernel/arbiter.c b/arch/cris/arch-v32/kernel/arbiter.c index 3870d2fd5160..c741a9bf26d4 100644 --- a/arch/cris/arch-v32/kernel/arbiter.c +++ b/arch/cris/arch-v32/kernel/arbiter.c @@ -1,9 +1,9 @@ /* - * Memory arbiter functions. Allocates bandwith through the + * Memory arbiter f...
27ae4104b69bd5e3d9006ba31b39fc186020f38e
Analyze and fix the following issue in the Linux kernel code: fix a typo in the RTC_CLASS help text
Problem Details: This patch fixes a typo spotted by Matt LaPlante <webmaster@cyberdogtech.com>. This patch fixes kernel Bugzilla #6704. Signed-off-by: Adrian Bunk <bunk@stusta.de>
```diff diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index f2fc81a9074d..d51afbe014e5 100644 --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig @@ -15,7 +15,7 @@ config RTC_CLASS help Generic RTC class support. If you say yes here, you will be allowed to plug one or more RTCs to your system. You w...
0a1f1ab8de815cb63a48d24450f6b5fbb1b1f89c
Analyze and fix the following issue in the Linux kernel code: ACPI: fixup memhotplug debug message
Problem Details: Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Len Brown <len.brown@intel.com>
```diff diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c index 6f5e395c78af..cd57372a6729 100644 --- a/drivers/acpi/acpi_memhotplug.c +++ b/drivers/acpi/acpi_memhotplug.c @@ -248,7 +248,7 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device) num_enabled++; } i...
caf430f37119af5faac9252ec4e18cb1c55dde26
Analyze and fix the following issue in the Linux kernel code: [IrDA]: Fix the AU1000 FIR dependencies
Problem Details: AU1000 FIR is broken, it should depend on SOC_AU1000. Spotted by Jean-Luc Leger. Signed-off-by: Adrian Bunk <bunk@stusta.de> Signed-off-by: Samuel Ortiz <samuel@sortiz.org> Signed-off-by: David S. Miller <davem@davemloft.net>
```diff diff --git a/drivers/net/irda/Kconfig b/drivers/net/irda/Kconfig index d2ce4896abff..e9e6d99a9add 100644 --- a/drivers/net/irda/Kconfig +++ b/drivers/net/irda/Kconfig @@ -350,7 +350,7 @@ config TOSHIBA_FIR config AU1000_FIR tristate "Alchemy Au1000 SIR/FIR" - depends on MIPS_AU1000 && IRDA + depends on SOC...
1bc1731133140dccdd08899a59bbc06d975d0a15
Analyze and fix the following issue in the Linux kernel code: [IrDA]: Fix RCU lock pairing on error path
Problem Details: irlan_client_discovery_indication calls rcu_read_lock and rcu_read_unlock, but returns without unlocking in an error case. Fix that by replacing the return with a goto so that the rcu_read_unlock always gets executed. Signed-off-by: Josh Triplett <josh@freedesktop.org> Acked-by: Paul E. McKenney <pau...
```diff diff --git a/net/irda/irlan/irlan_client.c b/net/irda/irlan/irlan_client.c index f8e6cb0db04b..95cf1234ea17 100644 --- a/net/irda/irlan/irlan_client.c +++ b/net/irda/irlan/irlan_client.c @@ -173,13 +173,14 @@ void irlan_client_discovery_indication(discinfo_t *discovery, rcu_read_lock(); self = irlan_get_any...
c22751b73a3770b3046102bb97b139218ff1875b
Analyze and fix the following issue in the Linux kernel code: [NETFILTE] ipv4: Fix typo (Bugzilla #6753)
Problem Details: This patch fixes bugzilla #6753, a typo in the netfilter Kconfig Signed-off-by: David S. Miller <davem@davemloft.net>
```diff diff --git a/net/ipv4/netfilter/Kconfig b/net/ipv4/netfilter/Kconfig index e1d7f5fbc526..ef0b5aac5838 100644 --- a/net/ipv4/netfilter/Kconfig +++ b/net/ipv4/netfilter/Kconfig @@ -332,7 +332,7 @@ config IP_NF_MATCH_HASHLIMIT help This option adds a new iptables `hashlimit' match. - As opposed to `lim...
d6b4991ad5d1a9840e12db507be1a6593def01fe
Analyze and fix the following issue in the Linux kernel code: [NET]: Fix logical error in skb_gso_ok
Problem Details: The test in skb_gso_ok is backwards. Noticed by Michael Chan <mchan@broadcom.com>. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Acked-by: Michael Chan <mchan@broadcom.com> Signed-off-by: David S. Miller <davem@davemloft.net>
```diff diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 84b0f0d16fcb..efd1e2af0bf3 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -994,12 +994,12 @@ static inline int skb_gso_ok(struct sk_buff *skb, int features) { int feature = skb_shinfo(skb)->gso_size ? ...
1c7e47726a88303e4cfa2785f0a357bf1ceecee1
Analyze and fix the following issue in the Linux kernel code: [NETFILTER]: xt_sctp: fix --chunk-types matching
Problem Details: xt_sctp uses an incorrect header offset when --chunk-types is used. Signed-off-by: Jorge Matias <jorge.matias@motorola.com> Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net>
```diff diff --git a/net/netfilter/xt_sctp.c b/net/netfilter/xt_sctp.c index 9316c753692f..843383e01d41 100644 --- a/net/netfilter/xt_sctp.c +++ b/net/netfilter/xt_sctp.c @@ -151,7 +151,7 @@ match(const struct sk_buff *skb, && SCCHECK(((ntohs(sh->dest) >= info->dpts[0]) && (ntohs(sh->dest) <= info->dpts[1])), ...
9abdcf6b6cf387035d934c77bf9ebe5e747166f9
Analyze and fix the following issue in the Linux kernel code: [NETFILTER]: xt_tcpudp: fix double unregistration in error path
Problem Details: "xt_unregister_match(AF_INET, &tcp_matchstruct)" is called twice, leaving "udp_matchstruct" registered, in case of a failure in the registration of the udp6 structure. Signed-off-by: Yuri Gushin <yuri@ecl-labs.org> Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@...
```diff diff --git a/net/netfilter/xt_tcpudp.c b/net/netfilter/xt_tcpudp.c index 1b61dac9c873..a9a63aa68936 100644 --- a/net/netfilter/xt_tcpudp.c +++ b/net/netfilter/xt_tcpudp.c @@ -260,7 +260,7 @@ static int __init xt_tcpudp_init(void) return ret; out_unreg_udp: - xt_unregister_match(&tcp_matchstruct); + xt_unre...
40a839fdbd5d76cebb2a61980bc1fc7ecd784be2
Analyze and fix the following issue in the Linux kernel code: [NETFILTER]: nf_conntrack: Fix undefined references to local_bh_*
Problem Details: CC net/netfilter/nf_conntrack_proto_sctp.o net/netfilter/nf_conntrack_proto_sctp.c: In function `sctp_print_conntrack': net/netfilter/nf_conntrack_proto_sctp.c:206: warning: implicit declaration of function `local_bh_disable' net/netfilter/nf_conntrack_proto_sctp.c:208: warning: implicit declarati...
```diff diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c index b8c7c567c9df..af4845971f70 100644 --- a/net/netfilter/nf_conntrack_netlink.c +++ b/net/netfilter/nf_conntrack_netlink.c @@ -29,6 +29,7 @@ #include <linux/errno.h> #include <linux/netlink.h> #include <linux/spinlock...
da298d3a4f01dbc10c54da75d6b5717a99fb9cbc
Analyze and fix the following issue in the Linux kernel code: [NETFILTER]: x_tables: fix xt_register_table error propagation
Problem Details: When xt_register_table fails the error is not properly propagated back. Based on patch by Lepton Wu <ytht.net@gmail.com>. Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net>
```diff diff --git a/net/ipv4/netfilter/arp_tables.c b/net/ipv4/netfilter/arp_tables.c index d0d19192026d..ad39bf640567 100644 --- a/net/ipv4/netfilter/arp_tables.c +++ b/net/ipv4/netfilter/arp_tables.c @@ -1120,7 +1120,8 @@ int arpt_register_table(struct arpt_table *table, return ret; } - if (xt_register_table(...
89d1d0ab4d99e1e0fe193352e1dd857787a0bfc0
Analyze and fix the following issue in the Linux kernel code: [SERIAL] sunsab: Fix section mis-match errors.
Problem Details: sunsab_init_one() needs to be __devinit, not __init Signed-off-by: David S. Miller <davem@davemloft.net>
```diff diff --git a/drivers/serial/sunsab.c b/drivers/serial/sunsab.c index 8d3c7e28ba71..141fedbefbc4 100644 --- a/drivers/serial/sunsab.c +++ b/drivers/serial/sunsab.c @@ -976,10 +976,10 @@ static inline struct console *SUNSAB_CONSOLE(void) #define sunsab_console_init() do { } while (0) #endif -static int __init...
4fa97dcf9d48b02934c60a48873199850351e760
Analyze and fix the following issue in the Linux kernel code: [SERIAL] sunzilog: Fix bugs in device deregristration.
Problem Details: 1) Need to unregister 2 ports per of_device. 2) Need to of_iounmap() 1 mapping per of_device. 3) Need to free up the IRQ only after all devices have been unregistered. Signed-off-by: David S. Miller <davem@davemloft.net>
```diff diff --git a/drivers/serial/sunzilog.c b/drivers/serial/sunzilog.c index cbdf9d605b3f..98342eeba734 100644 --- a/drivers/serial/sunzilog.c +++ b/drivers/serial/sunzilog.c @@ -1335,9 +1335,10 @@ static int __devinit zs_get_instance(struct device_node *dp) return ret; } +static int zilog_irq = -1; + static ...
c3a8b85f5ac2c21f4ef75e87bfe55ee7a753ffcf
Analyze and fix the following issue in the Linux kernel code: [SPARC64]: Fix typo in clock_probe().
Problem Details: Signed-off-by: David S. Miller <davem@davemloft.net>
```diff diff --git a/arch/sparc64/kernel/time.c b/arch/sparc64/kernel/time.c index 75cb6b4dc14f..e3132b467681 100644 --- a/arch/sparc64/kernel/time.c +++ b/arch/sparc64/kernel/time.c @@ -783,8 +783,8 @@ static int __devinit clock_probe(struct of_device *op, const struct of_device_id /* On an Enterprise system there c...
d44b3be88ed58bb1bbbf7d70c533598b3dc3d870
Analyze and fix the following issue in the Linux kernel code: [SPARC64]: Fix typo in isa_dev_get_irq_using_imap().
Problem Details: Signed-off-by: David S. Miller <davem@davemloft.net>
```diff diff --git a/arch/sparc64/kernel/isa.c b/arch/sparc64/kernel/isa.c index 6f16dee280a8..24c0dc34be31 100644 --- a/arch/sparc64/kernel/isa.c +++ b/arch/sparc64/kernel/isa.c @@ -75,7 +75,7 @@ static int __init isa_dev_get_irq_using_imap(struct sparc_isa_device *isa_dev, struct linux_prom_registers *reg)...
a75a6e4c3ada10b15e26f6d12f72c03efde266e0
Analyze and fix the following issue in the Linux kernel code: ocfs2: fix init of uuid_net_key
Problem Details: ocfs2_initialize_super() should be copying from the beginning of the uuid. Signed-off-by: Mark Fasheh <mark.fasheh@oracle.com>
```diff diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c index 4e214ecb5886..3aa9f18527f0 100644 --- a/fs/ocfs2/super.c +++ b/fs/ocfs2/super.c @@ -1417,7 +1417,7 @@ static int ocfs2_initialize_super(struct super_block *sb, goto bail; } - memcpy(&uuid_net_key, &osb->uuid[i], sizeof(osb->net_key)); + memcpy(&uuid_...
e7607ab3daeeaea50b3b5aebe8dfa29a1dfb8311
Analyze and fix the following issue in the Linux kernel code: ocfs2: silence a debug print
Problem Details: Signed-off-by: Mark Fasheh <mark.fasheh@oracle.com>
```diff diff --git a/fs/ocfs2/slot_map.c b/fs/ocfs2/slot_map.c index 871627961d6d..aa6f5aadedc4 100644 --- a/fs/ocfs2/slot_map.c +++ b/fs/ocfs2/slot_map.c @@ -264,7 +264,7 @@ int ocfs2_find_slot(struct ocfs2_super *osb) osb->slot_num = slot; spin_unlock(&si->si_lock); - mlog(ML_NOTICE, "taking node slot %d\n", os...
2b388c67906ee8cd3bf1a600a7023cd0807d414f
Analyze and fix the following issue in the Linux kernel code: ocfs2: Compile-time disabling of ocfs2 debugging output.
Problem Details: Give gcc the chance to compile out the debug logging code in ocfs2. This saves some size at the expense of being able to debug the code. Signed-off-by: Joel Becker <joel.becker@oracle.com> Signed-off-by: Mark Fasheh <mark.fasheh@oracle.com>
```diff diff --git a/fs/Kconfig b/fs/Kconfig index 6dc8cfd6d80c..be870db242b3 100644 --- a/fs/Kconfig +++ b/fs/Kconfig @@ -356,6 +356,16 @@ config OCFS2_FS - POSIX ACLs - readpages / writepages (not user visible) +config OCFS2_DEBUG_MASKLOG + bool "OCFS2 logging support" + depends on OCFS2_FS ...
bf7e8511088963078484132636839b59e25cf14f
Analyze and fix the following issue in the Linux kernel code: [PATCH] usb gadget: fixup pxa2xx_udc to include asm/arch/udc.h again
Problem Details: This fixes pxa2xx_udc.c to include asm/arch/udc.h again to fix current build breakage. Signed-off-by: Milan Svoboda <msvoboda@ra.rockwell.com> [ forwarded by David Brownell <david-b@pacbell.net> ] [ fixed to apply properly by Linus ] Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/usb/gadget/pxa2xx_udc.c b/drivers/usb/gadget/pxa2xx_udc.c index 269ce7f4ad66..735e9dbd39fd 100644 --- a/drivers/usb/gadget/pxa2xx_udc.c +++ b/drivers/usb/gadget/pxa2xx_udc.c @@ -60,7 +60,7 @@ #include <linux/usb_ch9.h> #include <linux/usb_gadget.h> -#include <asm/arch/hardware/intel_udc...
127fe6af38fe237374fc158c11da6bb44bcfdc9a
Analyze and fix the following issue in the Linux kernel code: [MIPS] Death list of board support to be removed after 2.6.18.
Problem Details: As usual fixes would be prefered. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt index 482cc622798f..b1c6c7036c1c 100644 --- a/Documentation/feature-removal-schedule.txt +++ b/Documentation/feature-removal-schedule.txt @@ -224,3 +224,47 @@ Why: The interface no longer has any callers left in...
a2c2bc4b263828a380813a236fa6fcf8185b460b
Analyze and fix the following issue in the Linux kernel code: [MIPS] MIPS32/MIPS64 S-cache fix and cleanup
Problem Details: Use blast_scache_range, blast_inv_scache_range for mips32/mips64 scache routine. Also initialize waybit for MIPS32/MIPS64 S-cache. Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/arch/mips/mm/sc-mips.c b/arch/mips/mm/sc-mips.c index d3f92a9e8310..42b50964c644 100644 --- a/arch/mips/mm/sc-mips.c +++ b/arch/mips/mm/sc-mips.c @@ -24,22 +24,7 @@ */ static void mips_sc_wback_inv(unsigned long addr, unsigned long size) { - unsigned long sc_lsize = cpu_scache_line_size(); - un...
38e9156147e5b0defb71a3eb7e9eff74609c496a
Analyze and fix the following issue in the Linux kernel code: [MIPS] au1xxx: fix PSC_SMBTXRX_RSR.
Problem Details: Signed-off-by: Domen Puncer <domen.puncer@ultra.si> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/include/asm-mips/mach-au1x00/au1xxx_psc.h b/include/asm-mips/mach-au1x00/au1xxx_psc.h index d7cbacdd21fe..1bd4e27caf6b 100644 --- a/include/asm-mips/mach-au1x00/au1xxx_psc.h +++ b/include/asm-mips/mach-au1x00/au1xxx_psc.h @@ -512,7 +512,7 @@ typedef struct psc_smb { /* Transmit register control....
73f403527b9ec5367376076eafb3d2f505d8e2e3
Analyze and fix the following issue in the Linux kernel code: [MIPS] Fix handling of 0 length I & D caches.
Problem Details: Don't ask. Signed-off-by: Chris Dearman <chris@mips.com> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/arch/mips/mm/c-r4k.c b/arch/mips/mm/c-r4k.c index 01450938db8b..a78355a44c41 100644 --- a/arch/mips/mm/c-r4k.c +++ b/arch/mips/mm/c-r4k.c @@ -60,13 +60,13 @@ static unsigned long scache_size __read_mostly; /* * Dummy cache handling routines for machines without boardcaches */ -static void no_s...
c09b47d8a99104897afd682b48f292e05461a0c2
Analyze and fix the following issue in the Linux kernel code: [MIPS] Typo fixes.
Problem Details: Signed-off-by: Chris Dearman <chris@mips.com> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig index bc6a8f97721d..aedeee9009fc 100644 --- a/arch/mips/Kconfig +++ b/arch/mips/Kconfig @@ -1254,7 +1254,7 @@ config CPU_R6000 select CPU_SUPPORTS_32BIT_KERNEL help MIPS Technologies R6000 and R6000A series processors. Note these - processors are ext...
f7a849153be3b66326b52dce0d07896b56cb4cd7
Analyze and fix the following issue in the Linux kernel code: [MIPS] Fix FIXADDR_TOP for TX39/TX49.
Problem Details: FIXADDR_TOP is used for HIGHMEM and for upper limit of vmalloc area on 32bit kernel. TX39XX and TX49XX have "reserved" segment in CKSEG3 area. 0xff000000-0xff3fffff on TX49XX and 0xff000000-0xfffeffff on TX39XX are reserved (unmapped, uncached) therefore can not be used as mapped area. Signed-off-by...
```diff diff --git a/include/asm-mips/fixmap.h b/include/asm-mips/fixmap.h index 1cadefbbc037..6959bdb59310 100644 --- a/include/asm-mips/fixmap.h +++ b/include/asm-mips/fixmap.h @@ -69,7 +69,11 @@ extern void __set_fixmap (enum fixed_addresses idx, * the start of the fixmap, and leave one page empty * at the top o...
f41ae0b2b9e5b4455cfc68dcc885f4fa2a973384
Analyze and fix the following issue in the Linux kernel code: [MIPS] Fix configuration of R2 CPU features and multithreading.
Problem Details: Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig index 002845e820f3..05663e5ddd39 100644 --- a/arch/mips/Kconfig +++ b/arch/mips/Kconfig @@ -308,6 +308,7 @@ config MIPS_ATLAS select SYS_SUPPORTS_64BIT_KERNEL select SYS_SUPPORTS_BIG_ENDIAN select SYS_SUPPORTS_LITTLE_ENDIAN + select SYS_SUPPORTS_MULTITHRE...
e73ea273ef87a04ff59fc368fa33333dca275dde
Analyze and fix the following issue in the Linux kernel code: [MIPS] Fix build error: don't offer SMP on systems that don't have SMP.
Problem Details: Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig index b8616a0bf93e..002845e820f3 100644 --- a/arch/mips/Kconfig +++ b/arch/mips/Kconfig @@ -536,6 +536,7 @@ config PMC_YOSEMITE select SYS_SUPPORTS_64BIT_KERNEL select SYS_SUPPORTS_BIG_ENDIAN select SYS_SUPPORTS_HIGHMEM + select SYS_SUPPORTS_SMP help ...
4277ff5ee55694f67d9c6586bb4c06991e221a68
Analyze and fix the following issue in the Linux kernel code: [MIPS] Fix use of ehb instruction for non-R2 configurations.
Problem Details: Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/arch/mips/kernel/entry.S b/arch/mips/kernel/entry.S index a9c6de1b9542..457565162dd5 100644 --- a/arch/mips/kernel/entry.S +++ b/arch/mips/kernel/entry.S @@ -87,7 +87,7 @@ FEXPORT(restore_all) # restore full frame ori v1, v0, TCSTATUS_IXMT mtc0 v1, CP0_TCSTATUS andi v0, TCSTATUS_IXMT - ehb ...
6adb5fe7020e8f99d27da932157ea27325df9263
Analyze and fix the following issue in the Linux kernel code: [MIPS] Only register RAM as resources if UNCAC_BASE != IO_BASE.
Problem Details: This fixes a resource collision of RAM and I/O memory on systems that use the physical address space multiple times. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c index bfcec8d9bfe4..d3e087115023 100644 --- a/arch/mips/kernel/setup.c +++ b/arch/mips/kernel/setup.c @@ -488,6 +488,9 @@ static inline void resource_init(void) { int i; + if (UNCAC_BASE != IO_BASE) + return; + code_resource.start = virt_t...
9247857f5acadf0ea87fd6a9514c633644634f08
Analyze and fix the following issue in the Linux kernel code: [MIPS] Fix the build error of Wind River PPMC board, rewrite irq code to C
Problem Details: o Fix the build error Wind River PPMC board caused by the change of plat_setup hook interface. o Rewrite first level interrupt dispatch code to C. Signed-off-by: Rongkai.Zhan <rongkai.zhan@windriver.com> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig index 35e038a974c6..3fa67af8725d 100644 --- a/arch/mips/Kconfig +++ b/arch/mips/Kconfig @@ -358,7 +358,7 @@ config MIPS_SEAD board. config WR_PPMC - bool "Support for Wind River PPMC board" + bool "Wind River PPMC board" select IRQ_CPU select BOOT_EL...
ba53201180e267bd1f0792e6c375ced7c100738e
Analyze and fix the following issue in the Linux kernel code: [ARM] Fix sa11x0 SDRAM selection
Problem Details: Avoid folk having to edit cpu-sa1110.c to select their RAM type; instead, allow the SDRAM type to be selected via the kernel command line. Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
```diff diff --git a/arch/arm/mach-sa1100/cpu-sa1110.c b/arch/arm/mach-sa1100/cpu-sa1110.c index 04c94ab6c18b..639597729932 100644 --- a/arch/arm/mach-sa1100/cpu-sa1110.c +++ b/arch/arm/mach-sa1100/cpu-sa1110.c @@ -15,7 +15,10 @@ * SDRAM reads (rev A0, B0, B1) * * We ignore rev. A0 and B0 devices; I don't th...
27a288677de33c50af980e55abec5643db4cd0b8
Analyze and fix the following issue in the Linux kernel code: [MTD] NAND: Fix broken sharpsl driver
Problem Details: Remove the not longer supported NO_VIRTBLOCKS flag and remove an unused variable while at it. Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
```diff diff --git a/drivers/mtd/nand/sharpsl.c b/drivers/mtd/nand/sharpsl.c index 21743658d150..fbeedc3184e9 100644 --- a/drivers/mtd/nand/sharpsl.c +++ b/drivers/mtd/nand/sharpsl.c @@ -237,11 +237,6 @@ static int __init sharpsl_nand_init(void) } } - if (machine_is_husky() || machine_is_borzoi() || machine_is_a...
dae8620421833bb2e9a01c4ccc42bdc3759b81df
Analyze and fix the following issue in the Linux kernel code: [PATCH] genirq MSI fixes
Problem Details: This is a fixed up and cleaned up replacement for genirq-msi-fixes.patch, which should solve the i386 4KSTACKS problem. I also added Ben's idea of pushing the __do_IRQ() check into generic_handle_irq(). I booted this with MSI enabled, but i only have MSI devices, not MSI-X devices. I'd still expect ...
```diff diff --git a/arch/i386/kernel/irq.c b/arch/i386/kernel/irq.c index 3336cef9605a..16b491703967 100644 --- a/arch/i386/kernel/irq.c +++ b/arch/i386/kernel/irq.c @@ -82,6 +82,10 @@ fastcall unsigned int do_IRQ(struct pt_regs *regs) } #endif + if (!irq_desc[irq].handle_irq) { + __do_IRQ(irq, regs); + goto ou...
096c8131c573ed37939dc3f1440221c92c87e74b
Analyze and fix the following issue in the Linux kernel code: [PATCH] genirq: debug: better debug printout in enable_irq()
Problem Details: Make enable_irq() debug printouts user-readable. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index 8389d1817fe8..76c8eda67295 100644 --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c @@ -114,6 +114,7 @@ void enable_irq(unsigned int irq) spin_lock_irqsave(&desc->lock, flags); switch (desc->depth) { case 0: + printk(KERN_WARNING "Unablanced ...
a53da52fd743fd637637572838c0a7af23a2d038
Analyze and fix the following issue in the Linux kernel code: [PATCH] genirq: cleanup: merge irq_affinity[] into irq_desc[]
Problem Details: Consolidation: remove the irq_affinity[NR_IRQS] array and move it into the irq_desc[NR_IRQS].affinity field. [akpm@osdl.org: sparc64 build fix] Signed-off-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Lin...
```diff diff --git a/arch/alpha/kernel/irq.c b/arch/alpha/kernel/irq.c index ec9d243d42c9..63af36cf7f6e 100644 --- a/arch/alpha/kernel/irq.c +++ b/arch/alpha/kernel/irq.c @@ -56,7 +56,7 @@ select_smp_affinity(unsigned int irq) cpu = (cpu < (NR_CPUS-1) ? cpu + 1 : 0); last_cpu = cpu; - irq_affinity[irq] = cpumask...
7256d819e43f89af6ba30047936c96c683436941
Analyze and fix the following issue in the Linux kernel code: [PATCH] ufs: printk() fix
Problem Details: fs/ufs/inode.c: In function `ufs_frag_map': fs/ufs/inode.c:101: warning: long long unsigned int format, u64 arg (arg 4) fs/ufs/inode.c: In function `ufs_getfrag_block': fs/ufs/inode.c:432: warning: long long unsigned int format, u64 arg (arg 2) Cc: Evgeniy Dushistov <dushistov@mail.ru> Signed-off-by: ...
```diff diff --git a/fs/ufs/inode.c b/fs/ufs/inode.c index 8e1f90e42040..488b5ff48afb 100644 --- a/fs/ufs/inode.c +++ b/fs/ufs/inode.c @@ -98,7 +98,9 @@ static u64 ufs_frag_map(struct inode *inode, sector_t frag) u64 temp = 0L; UFSD(": frag = %llu depth = %d\n", (unsigned long long)frag, depth); - UFSD(": uspi->...
94583779e6625154e8d7fce33d097ae7d089e9de
Analyze and fix the following issue in the Linux kernel code: [PATCH] sparc: register_cpu() build fix
Problem Details: arch/sparc/kernel/setup.c: In function 'topology_init': arch/sparc/kernel/setup.c:528: error: too many arguments to function 'register_cpu' Cc: William Lee Irwin III <wli@holomorphy.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/sparc/kernel/setup.c b/arch/sparc/kernel/setup.c index a893a9cc9534..2e5d08ce217b 100644 --- a/arch/sparc/kernel/setup.c +++ b/arch/sparc/kernel/setup.c @@ -496,7 +496,7 @@ static int __init topology_init(void) if (!p) err = -ENOMEM; else - register_cpu(p, i, NULL); + register_cp...
81b0c8713385ce1b1b9058e916edcf9561ad76d6
Analyze and fix the following issue in the Linux kernel code: [PATCH] generic_file_buffered_write(): handle zero-length iovec segments
Problem Details: The recent generic_file_write() deadlock fix caused generic_file_buffered_write() to loop inifinitely when presented with a zero-length iovec segment. Fix. Note that this fix deliberately avoids calling ->prepare_write(), ->commit_write() etc with a zero-length write. This is because I don't trust a...
```diff diff --git a/mm/filemap.c b/mm/filemap.c index 4082b3b3cea7..648f2c0c8e18 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -2125,6 +2125,12 @@ generic_file_buffered_write(struct kiocb *iocb, const struct iovec *iov, break; } + if (unlikely(bytes == 0)) { + status = 0; + copied = 0; + goto zero_le...
0686cd8fbe3e5fb1441ae84b9cbc813f9297b879
Analyze and fix the following issue in the Linux kernel code: [PATCH] fix sgivwfb compile
Problem Details: drivers/built-in.o: In function `sgivwfb_set_par': sgivwfb.c:(.text+0x88583): undefined reference to `sgivwfb_mem_phys' sgivwfb.c:(.text+0x88596): undefined reference to `sgivwfb_mem_phys' sgivwfb.c:(.text+0x885a8): undefined reference to `sgivwfb_mem_phys' drivers/built-in.o: In function `sgivwfb_chec...
```diff diff --git a/arch/i386/mach-visws/setup.c b/arch/i386/mach-visws/setup.c index 8a9e1a6f745d..11e83a0e1d62 100644 --- a/arch/i386/mach-visws/setup.c +++ b/arch/i386/mach-visws/setup.c @@ -140,8 +140,8 @@ void __init time_init_hook(void) #define MB (1024 * 1024) -static unsigned long sgivwfb_mem_phys; -stati...
0f13fc09db68de92585558984bff1c51b87db72f
Analyze and fix the following issue in the Linux kernel code: [SCSI] 53c700: fix breakage caused by the autosense update
Problem Details: A bit of a brown paper bag issue. The previous patch to remove the soon to be ripped out fields that were used in autosense actually broke the driver. This patch fixes it and has been tested (honestly). Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
```diff diff --git a/drivers/scsi/53c700.c b/drivers/scsi/53c700.c index bff04797739a..24dfd54865ee 100644 --- a/drivers/scsi/53c700.c +++ b/drivers/scsi/53c700.c @@ -174,6 +174,7 @@ STATIC int NCR_700_bus_reset(struct scsi_cmnd * SCpnt); STATIC int NCR_700_host_reset(struct scsi_cmnd * SCpnt); STATIC void NCR_700_ch...
8434aa8b6fe5af27a33b8aa830c24e3680356c83
Analyze and fix the following issue in the Linux kernel code: [SCSI] iscsi: break up session creation into two stages
Problem Details: qla4xxx is initialized in two steps like other HW drivers. It allocates the host, sets up the HW, then adds the host. For iscsi part of HW setup is setting up persistent iscsi sessions. At that time, the interupts are off and the driver is not completely set up so we just want to allocate them. We do n...
```diff diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c index c0ec502835ee..f39da0cf5f18 100644 --- a/drivers/scsi/scsi_transport_iscsi.c +++ b/drivers/scsi/scsi_transport_iscsi.c @@ -287,20 +287,11 @@ void iscsi_block_session(struct iscsi_cls_session *session) } EXPORT_SYMBOL_G...
f53a88da18e3c04c3ade07bc5eff520ee4259c3e
Analyze and fix the following issue in the Linux kernel code: [SCSI] iscsi: fix session refcouting
Problem Details: iscsi_tcp and iser cannot be rmmod from the kernel when sessions are running because session removal is driven from userspace. For those modules we get a module reference when a session is created then drop it when the session is removed. For qla4xxx, they can jsut remove the sessions from the pci rem...
```diff diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c index 7c76a989b218..7e6e031cc41b 100644 --- a/drivers/scsi/libiscsi.c +++ b/drivers/scsi/libiscsi.c @@ -1287,13 +1287,18 @@ iscsi_session_setup(struct iscsi_transport *iscsit, if (scsi_add_host(shost, NULL)) goto add_host_fail; + if (!try_mod...
358ff019b89aa530ab6c0dd139d8089c932b103f
Analyze and fix the following issue in the Linux kernel code: [SCSI] iscsi: convert iser to new set/get param fns
Problem Details: Convert iser to libiscsi get/set param functions. Fix bugs in it returning old error return values and have it expose exp_statsn. Signed-off-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
```diff diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.c b/drivers/infiniband/ulp/iser/iscsi_iser.c index 4c3f2de2a06e..d277fdff5dc1 100644 --- a/drivers/infiniband/ulp/iser/iscsi_iser.c +++ b/drivers/infiniband/ulp/iser/iscsi_iser.c @@ -438,159 +438,50 @@ iscsi_iser_session_create(struct iscsi_transport *iscsit, ...
656602978e43a4e5d929423d766be0448bdacc1e
Analyze and fix the following issue in the Linux kernel code: [ARM] 3673/1: lpd270: parse lcd= command line parameter
Problem Details: Patch from Lennert Buytenhek The bootloader on the LogicPD PXA270 platform informs the kernel of which type of TFT screen is connected via an lcd=$FOO kernel command line parameter. Before this patch, we ignored this parameter and just hardcoded the use of the Sharp lq64d343 display kit. This patch ...
```diff diff --git a/arch/arm/mach-pxa/lpd270.c b/arch/arm/mach-pxa/lpd270.c index ec0f43a102c7..1a5f5c21481e 100644 --- a/arch/arm/mach-pxa/lpd270.c +++ b/arch/arm/mach-pxa/lpd270.c @@ -248,58 +248,137 @@ static void lpd270_backlight_power(int on) /* 5.7" TFT QVGA (LoLo display number 1) */ static struct pxafb_mac...
c6e8c6ccf96e9249805d0e9828b994f4c926ad51
Analyze and fix the following issue in the Linux kernel code: [JFFS2][XATTR] Fix xd->refcnt race condition
Problem Details: When xd->refcnt is checked whether this xdatum should be released or not, atomic_dec_and_lock() is used to ensure holding the c->erase_completion_lock. This fix change a specification of delete_xattr_datum(). Previously, it's only called when xd->refcnt equals zero. (calling it with positive xd->refcn...
```diff diff --git a/fs/jffs2/xattr.c b/fs/jffs2/xattr.c index 18e66dbf23b4..25bc1ae08648 100644 --- a/fs/jffs2/xattr.c +++ b/fs/jffs2/xattr.c @@ -50,9 +50,10 @@ * is used to write xdatum to medium. xd->version will be incremented. * create_xattr_datum(c, xprefix, xname, xvalue, xsize) * is used to create new...
264edb35ce5c85749bfdd2942c74b786ea1cde41
Analyze and fix the following issue in the Linux kernel code: [ARM] Remove yucky ifdefs to print "id(wb)BRR" suffix on CPU name
Problem Details: The "id(wb)BRR" suffix reports which CPU debugging options were (or were not) selected at kernel build time. Rather than have every proc-*.S file implement this, report the control register value, from which this information can be deduced. Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
```diff diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c index 093ccba0503c..7d02f96eeb9d 100644 --- a/arch/arm/kernel/setup.c +++ b/arch/arm/kernel/setup.c @@ -315,9 +315,9 @@ static void __init setup_processor(void) cpu_cache = *list->cache; #endif - printk("CPU: %s [%08x] revision %d (ARMv%s)\n", ...
94bb063312d872d9269deb2e5c0c7c6d5b0318e1
Analyze and fix the following issue in the Linux kernel code: [S390] rework of channel measurement facility.
Problem Details: Fixes for several channel measurement facility bugs: * Blocks copied from the hardware might not be consistent. Solve this by moving the copying into idle state and repeating the copying. * avg_sample_interval changed with every read, even though no new block was available. Solve this by storing a ...
```diff diff --git a/drivers/s390/cio/cmf.c b/drivers/s390/cio/cmf.c index 07ef3f640f4a..1c3e8e9012b0 100644 --- a/drivers/s390/cio/cmf.c +++ b/drivers/s390/cio/cmf.c @@ -3,9 +3,10 @@ * * Linux on zSeries Channel Measurement Facility support * - * Copyright 2000,2003 IBM Corporation + * Copyright 2000,2006 IBM Co...
8e0474f3b43e8bec1be164006a378e9dbd439b2c
Analyze and fix the following issue in the Linux kernel code: [S390] fix duplicate export of overflow{ug}id
Problem Details: overflowuid and overflowgid were exported twice. Remove the export from s390_ksyms.c Signed-off-by: Serge E. Hallyn <serue@us.ibm.com> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
```diff diff --git a/arch/s390/kernel/s390_ksyms.c b/arch/s390/kernel/s390_ksyms.c index 4176c77670c4..0886e739d122 100644 --- a/arch/s390/kernel/s390_ksyms.c +++ b/arch/s390/kernel/s390_ksyms.c @@ -46,8 +46,6 @@ EXPORT_SYMBOL(__down_interruptible); */ extern int dump_fpu (struct pt_regs * regs, s390_fp_regs *fpregs...
445b5b499e0ca1584ee3aa8af298c9ef8c84d711
Analyze and fix the following issue in the Linux kernel code: [S390] dasd_eckd_dump_sense bug.
Problem Details: The ccw dump function dasd_eckd_dump_ccw_range can crash because it does not take care about the IDAL flag in the ccw. Check for IDALs flag set in CCW and follow the indirect list to print the data that is refered by the ccw. Signed-off-by: Horst Hummel <horst.hummel@de.ibm.com> Signed-off-by: Martin ...
```diff diff --git a/drivers/s390/block/dasd_eckd.c b/drivers/s390/block/dasd_eckd.c index 7d5a6cee4bd8..7565d30f8c2f 100644 --- a/drivers/s390/block/dasd_eckd.c +++ b/drivers/s390/block/dasd_eckd.c @@ -1521,6 +1521,40 @@ dasd_eckd_ioctl(struct dasd_device *device, unsigned int cmd, void __user *argp) } } +/* + * ...
06fa46a2fcb7e13386707a3eac74f11140a9f818
Analyze and fix the following issue in the Linux kernel code: [S390] console_unblank woes.
Problem Details: The software watchdog calls machine_restart from a timer function. The s390 machine_restart calls console_unblank to flush the console output. This is needed for panic to get the panic message printed. If console_unblank is called in interrupt a BUG is triggered in acquire_console_sem. That makes the s...
```diff diff --git a/arch/s390/kernel/setup.c b/arch/s390/kernel/setup.c index b282034452a4..813444aac7d7 100644 --- a/arch/s390/kernel/setup.c +++ b/arch/s390/kernel/setup.c @@ -289,19 +289,34 @@ void (*_machine_power_off)(void) = do_machine_power_off_nonsmp; void machine_restart(char *command) { - console_unblank...
4980082db1a8aa3ec45aa22cd4a10021955e22ed
Analyze and fix the following issue in the Linux kernel code: [S390] __syscall_return error check.
Problem Details: Fix __syscall_return macro: valid error numbers are in the range of -1..-4095. Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
```diff diff --git a/include/asm-s390/unistd.h b/include/asm-s390/unistd.h index e21443d3ea1d..aa7a243862e1 100644 --- a/include/asm-s390/unistd.h +++ b/include/asm-s390/unistd.h @@ -394,11 +394,9 @@ #ifdef __KERNEL__ -/* user-visible error numbers are in the range -1 - -122: see <asm-s390/errno.h> */ - #define _...
231caa1cac555bdd5cb64bf91b554b38e8ddf715
Analyze and fix the following issue in the Linux kernel code: [S390] channel measurement fix.
Problem Details: Specify correct sizeof() in chp_measurement_read() and return correct amount of read data. Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
```diff diff --git a/drivers/s390/cio/chsc.c b/drivers/s390/cio/chsc.c index 72187e54dcac..4a9da5bdd535 100644 --- a/drivers/s390/cio/chsc.c +++ b/drivers/s390/cio/chsc.c @@ -918,12 +918,13 @@ chp_measurement_read(struct kobject *kobj, char *buf, loff_t off, size_t count) chp = to_channelpath(container_of(kobj, struc...
ea9b6dcc152f09c207117ab121d4fa03d2db282a
Analyze and fix the following issue in the Linux kernel code: MTD: kernel-doc fixes + additions
Problem Details: Fix some kernel-doc typos/spellos. Use kernel-doc syntax in places where it was almost used. Correct/add struct, struct field, and function param names where needed. Signed-off-by: Randy Dunlap <rdunlap@xenotime.net> Signed-off-by: David Woodhouse <dwmw2@infradead.org>
```diff diff --git a/Documentation/DocBook/mtdnand.tmpl b/Documentation/DocBook/mtdnand.tmpl index 32f385605981..630159c5bdba 100644 --- a/Documentation/DocBook/mtdnand.tmpl +++ b/Documentation/DocBook/mtdnand.tmpl @@ -109,7 +109,7 @@ for most of the implementations. These functions can be replaced by the board d...
844d3b427ef1a4f96e54866747bdb6c6cbca4c6a
Analyze and fix the following issue in the Linux kernel code: MTD: fix all kernel-doc warnings
Problem Details: Fix all kernel-doc warnings in MTD headers and source files: - add some missing struct fields; - correct some function parameter names; - use kernel-doc format for function doc. headers; - nand_ecc.c contains only exported interfaces, no internal ones; Signed-off-by: Randy Dunlap <rdunlap@xenotime.net...
```diff diff --git a/Documentation/DocBook/mtdnand.tmpl b/Documentation/DocBook/mtdnand.tmpl index 6e463d0db266..32f385605981 100644 --- a/Documentation/DocBook/mtdnand.tmpl +++ b/Documentation/DocBook/mtdnand.tmpl @@ -1295,7 +1295,9 @@ in this page</entry> </para> !Idrivers/mtd/nand/nand_base.c !Idrivers/mtd/n...
f86c9747fe1cd72b2c5c6bdf72d17aeb2a3c6cb0
Analyze and fix the following issue in the Linux kernel code: [POWERPC] Fix idr locking in init_new_context
Problem Details: We always need to serialize accesses to mmu_context_idr. I hit this bug when testing with a small number of mmu contexts. Signed-off-by: Sonny Rao <sonny@burdell.org> Signed-off-by: Paul Mackerras <paulus@samba.org>
```diff diff --git a/arch/powerpc/mm/mmu_context_64.c b/arch/powerpc/mm/mmu_context_64.c index 65d18dca266f..e2051efa09c5 100644 --- a/arch/powerpc/mm/mmu_context_64.c +++ b/arch/powerpc/mm/mmu_context_64.c @@ -44,7 +44,9 @@ again: return err; if (index > MAX_CONTEXT) { + spin_lock(&mmu_context_lock); idr_re...
0a6047eef1c465c38aacfbdab193161b3f0cd144
Analyze and fix the following issue in the Linux kernel code: Fix vsnprintf off-by-one bug
Problem Details: The recent vsnprintf() fix introduced an off-by-one, and it's now possible to overrun the target buffer by one byte. The "end" pointer points to past the end of the buffer, so if we have to truncate the result, it needs to be done though "end[-1]". [ This is just an alternate and simpler patch to one...
```diff diff --git a/lib/vsprintf.c b/lib/vsprintf.c index 797428afd111..bed7229378f2 100644 --- a/lib/vsprintf.c +++ b/lib/vsprintf.c @@ -489,7 +489,7 @@ int vsnprintf(char *buf, size_t size, const char *fmt, va_list args) if (str < end) *str = '\0'; else - *end = '\0'; + end[-1] = '\0'; } /* the tra...
b44597906e03d5e2b467c17a3b73585596c0d7be
Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix plist include dependency
Problem Details: plist.h uses container_of, which is defined in kernel.h. Include kernel.h in plist.h as the kernel.h include does not longer happen automatically on all architectures. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/include/linux/plist.h b/include/linux/plist.h index 3404faef542c..b95818a037ad 100644 --- a/include/linux/plist.h +++ b/include/linux/plist.h @@ -73,6 +73,7 @@ #ifndef _LINUX_PLIST_H_ #define _LINUX_PLIST_H_ +#include <linux/kernel.h> #include <linux/list.h> #include <linux/spinlock_types.h> ...
3448ff8967a00067cbc3b6ebe9a3741b4e72f6d0
Analyze and fix the following issue in the Linux kernel code: [PATCH] m68knommu: fix 68EZ328/config.c asm
Problem Details: Fix 68EZ328/config.c asm to be clean for new gcc versions. Signed-off-by: Greg Ungerer <gerg@uclinux.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/m68knommu/platform/68EZ328/config.c b/arch/m68knommu/platform/68EZ328/config.c index d8d56e5de310..15a14a67c2bf 100644 --- a/arch/m68knommu/platform/68EZ328/config.c +++ b/arch/m68knommu/platform/68EZ328/config.c @@ -42,13 +42,13 @@ void m68328_timer_gettod(int *year, int *mon, int *day, int *...
69614fc66a11222baf61e05a3e5b98ef2e3427be
Analyze and fix the following issue in the Linux kernel code: [PATCH] m68knommu: fix 68VZ328/config.c asm
Problem Details: Fix 68VZ328/config.c asm to be clean for new gcc versions. Signed-off-by: Greg Ungerer <gerg@uclinux.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/m68knommu/platform/68VZ328/config.c b/arch/m68knommu/platform/68VZ328/config.c index d926524cdf82..4058de5c8fa2 100644 --- a/arch/m68knommu/platform/68VZ328/config.c +++ b/arch/m68knommu/platform/68VZ328/config.c @@ -141,13 +141,13 @@ static void init_hardware(char *command, int size) static ...
bda658382614198714b27581528f9bfb60c05a71
Analyze and fix the following issue in the Linux kernel code: [PATCH] m68knommu: fix 68360/config.c asm
Problem Details: Fix 68360/config.c asm to be clean for new gcc versions. Signed-off-by: Greg Ungerer <gerg@uclinux.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/m68knommu/platform/68360/config.c b/arch/m68knommu/platform/68360/config.c index 3db244625f0f..69c670dfd62b 100644 --- a/arch/m68knommu/platform/68360/config.c +++ b/arch/m68knommu/platform/68360/config.c @@ -141,13 +141,13 @@ int BSP_set_clock_mmss (unsigned long nowtime) void BSP_reset (voi...
0aee77b221a68bf8ef5401712bb55c89e36b461c
Analyze and fix the following issue in the Linux kernel code: [PATCH] m68knommu: fix clobber list in uCdimm/uCsimm helper asm
Problem Details: Fix clobber list in uCsimm/uCdimm boot load helper asm. Signed-off-by: Greg Ungerer <gerg@uclinux.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/include/asm-m68knommu/bootstd.h b/include/asm-m68knommu/bootstd.h index 3fdc79f06d50..bdc1a4ac4fe9 100644 --- a/include/asm-m68knommu/bootstd.h +++ b/include/asm-m68knommu/bootstd.h @@ -52,7 +52,7 @@ type name(void) \ __asm__ __volatile__ ("trap #2" \ : "=g" (__res) \ ...
727dda800f5076ce6f4653393fab651706959c93
Analyze and fix the following issue in the Linux kernel code: [PATCH] m68knommu: fix compilation problems with 68328serial driver
Problem Details: Clean out the 68328serial driver: . remove use of cli/sti . fix usage of tty_* calls . remove unused variables Signed-off-by: Greg Ungerer <gerg@uclinux.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/serial/68328serial.c b/drivers/serial/68328serial.c index b88a7c1158af..bff94541991c 100644 --- a/drivers/serial/68328serial.c +++ b/drivers/serial/68328serial.c @@ -131,17 +131,6 @@ static int m68328_console_baud = CONSOLE_BAUD_RATE; static int m68328_console_cbaud = DEFAULT_CBAUD; ...
d9a5685436b0dd08a6386a2f9423103cb4689dbc
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: oprofile build fix
Problem Details: WARNING: "unset_nmi_callback" [arch/x86_64/oprofile/oprofile.ko] undefined! WARNING: "set_nmi_callback" [arch/x86_64/oprofile/oprofile.ko] undefined! Cc: Andi Kleen <ak@muc.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/x86_64/kernel/nmi.c b/arch/x86_64/kernel/nmi.c index 399489c93132..0ef9cf2bc45e 100644 --- a/arch/x86_64/kernel/nmi.c +++ b/arch/x86_64/kernel/nmi.c @@ -607,11 +607,13 @@ void set_nmi_callback(nmi_callback_t callback) vmalloc_sync_all(); rcu_assign_pointer(nmi_callback, callback); } +EXPO...
f201f5046ddaeeccb036bdf6848549bf5cb51bb1
Analyze and fix the following issue in the Linux kernel code: [PATCH] ide: housekeeping on IDE drivers
Problem Details: Move auto arrays to static (const). Clean up using PCI_DEVICE in places, remove unreachable junk and dead code. Fix the serverworks cable detect logic (if ordering is wrong). Backport from libata. Plenty of scope for more cleanup left. Signed-off-by: Alan Cox <alan@redhat.com> Cc: Bartlomiej Zolni...
```diff diff --git a/drivers/ide/pci/aec62xx.c b/drivers/ide/pci/aec62xx.c index c743e68c33aa..ff0cdc142f17 100644 --- a/drivers/ide/pci/aec62xx.c +++ b/drivers/ide/pci/aec62xx.c @@ -22,7 +22,7 @@ struct chipset_bus_clock_list_entry { u8 ultra_settings; }; -static struct chipset_bus_clock_list_entry aec6xxx_33_bas...
da574af755bcb1d604e01feadf2a8c31b364447c
Analyze and fix the following issue in the Linux kernel code: [PATCH] ide: fix error handling for drives which clear the FIFO on error
Problem Details: If the controller FIFO cleared automatically on error we must not try and drain it as this will hang some chips. Based in concept on a broken patch from -mm some while back Signed-off-by: Alan Cox <alan@redhat.com> Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com> Cc: Bartlomiej Zolnierkiewicz <B.Zolnier...
```diff diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c index 935cb2583770..26ceab1e90bb 100644 --- a/drivers/ide/ide-io.c +++ b/drivers/ide/ide-io.c @@ -505,7 +505,7 @@ static ide_startstop_t ide_ata_error(ide_drive_t *drive, struct request *rq, u8 } } - if ((stat & DRQ_STAT) && rq_data_dir(rq) == READ...
2930d1bed7ffea3062e43b8acdeb9e0587bfc6a9
Analyze and fix the following issue in the Linux kernel code: [PATCH] SC1200 debug printk
Problem Details: Kill a pair of long escaped debug printk calls Signed-off-by: Alan Cox <alan@redhat.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/ide/pci/sc1200.c b/drivers/ide/pci/sc1200.c index 24e21b2838c1..778b82ae964d 100644 --- a/drivers/ide/pci/sc1200.c +++ b/drivers/ide/pci/sc1200.c @@ -395,7 +395,6 @@ static int sc1200_resume (struct pci_dev *dev) { ide_hwif_t *hwif = NULL; -printk("SC1200: resume\n"); pci_set_power_s...
1a1276e7b6cba549553285f74e87f702bfff6fac
Analyze and fix the following issue in the Linux kernel code: [PATCH] Old IDE, fix SATA detection for cabling
Problem Details: This is based on the proposed patches flying around but also checks that the device in question is new enough to have word 93 rather thanb blindly assuming word 93 == 0 means SATA (see ATA-5, ATA-7) Signed-off-by: Alan Cox <alan@redhat.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: L...
```diff diff --git a/drivers/ide/ide-iops.c b/drivers/ide/ide-iops.c index 97a49e77a8f1..32117f0ec5c0 100644 --- a/drivers/ide/ide-iops.c +++ b/drivers/ide/ide-iops.c @@ -597,6 +597,10 @@ u8 eighty_ninty_three (ide_drive_t *drive) { if(HWIF(drive)->udma_four == 0) return 0; + + /* Check for SATA but only if we ar...
e85f8dcc2750685e50139df4da8bdb68475393fc
Analyze and fix the following issue in the Linux kernel code: [PATCH] sound: fix cs4232 section mismatch
Problem Details: Fix section mismatch: adds __init to probe function, frees some init memory, not critical. WARNING: sound/oss/cs4232.o - Section mismatch: reference to .init.text: from .text after 'cs4232_pnp_probe' (at offset 0x152) Signed-off-by: Randy Dunlap <rdunlap@xenotime.net> Signed-off-by: Andrew Morton <akp...
```diff diff --git a/sound/oss/cs4232.c b/sound/oss/cs4232.c index c7f86f09c28d..80f6c08e26e7 100644 --- a/sound/oss/cs4232.c +++ b/sound/oss/cs4232.c @@ -405,7 +405,7 @@ static const struct pnp_device_id cs4232_pnp_table[] = { MODULE_DEVICE_TABLE(pnp, cs4232_pnp_table); -static int cs4232_pnp_probe(struct pnp_dev...
cab267c65f44337974e4f1eae490b21dce0e9811
Analyze and fix the following issue in the Linux kernel code: [PATCH] powermac backlight fixes
Problem Details: Fix a erroneous calculation of the legacy brightness values as reported by Paul Collins. Additionally, it moves the calculation of the negative value in the radeonfb driver after the value check. Signed-off-by: Michael Hanselmann <linux-kernel@hansmi.ch> Acked-by: Benjamin Herrenschmidt <benh@kernel....
```diff diff --git a/arch/powerpc/platforms/powermac/backlight.c b/arch/powerpc/platforms/powermac/backlight.c index 498b042e1837..c7a27eddca6d 100644 --- a/arch/powerpc/platforms/powermac/backlight.c +++ b/arch/powerpc/platforms/powermac/backlight.c @@ -119,7 +119,14 @@ int pmac_backlight_set_legacy_brightness(int bri...
effc8b704b48c3c727715abf49592a57547b6818
Analyze and fix the following issue in the Linux kernel code: [PATCH] stallion: fix recent SMP locking cleanup
Problem Details: Works better on SMP if... Signed-off-by: Alan Cox <alan@redhat.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/char/stallion.c b/drivers/char/stallion.c index bf361a5ba70d..00b4a2187164 100644 --- a/drivers/char/stallion.c +++ b/drivers/char/stallion.c @@ -3029,6 +3029,9 @@ static int __init stl_init(void) int i; printk(KERN_INFO "%s: version %s\n", stl_drvtitle, stl_drvversion); + spin_lock_i...
9d7fa40098253a6768cfc3ffbbd5988ba852d364
Analyze and fix the following issue in the Linux kernel code: [PATCH] v9fs: fix fid check in v9fs_create
Problem Details: Fix an incorrect check whether a fid was allocated in v9fs_create and if it should be freed on error. Signed-off-by: Latchesar Ionkov <lucho@ionkov.net> Cc: Eric Van Hensbergen <ericvh@ericvh.myip.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c index 5c6bdf82146c..2f580a197b8d 100644 --- a/fs/9p/vfs_inode.c +++ b/fs/9p/vfs_inode.c @@ -300,7 +300,7 @@ clunk_fid: fid = V9FS_NOFID; put_fid: - if (fid >= 0) + if (fid != V9FS_NOFID) v9fs_put_idpool(fid, &v9ses->fidpool); kfree(fcall); ```
79bc79b07c9c6f8ae9290704e9e503a9327fcbb2
Analyze and fix the following issue in the Linux kernel code: [PATCH] small fix for not releasing the mmap semaphore in i386/arch_setup_additional_pages
Problem Details: the VDSO randomization code on i386 fails to release the mmap semaphore if insert_vm_struct() fails. [ Made the conditional unlikely. -- Linus ] Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/i386/kernel/sysenter.c b/arch/i386/kernel/sysenter.c index c60419dee018..713ba39d32c6 100644 --- a/arch/i386/kernel/sysenter.c +++ b/arch/i386/kernel/sysenter.c @@ -148,8 +148,10 @@ int arch_setup_additional_pages(struct linux_binprm *bprm, int exstack) vma->vm_mm = mm; ret = insert_vm_s...
adf8a287150667feb5747f8beade62acacc17d4e
Analyze and fix the following issue in the Linux kernel code: [AGPGART] Make AGP depend on PCI
Problem Details: Fixes possible compile error in amd64 with pci=n pointed out by Adrian Bunk. Signed-off-by: Dave Jones <davej@redhat.com>
```diff diff --git a/drivers/char/agp/Kconfig b/drivers/char/agp/Kconfig index 7c88c060a9e6..3dbbb9544ae8 100644 --- a/drivers/char/agp/Kconfig +++ b/drivers/char/agp/Kconfig @@ -1,6 +1,7 @@ config AGP tristate "/dev/agpgart (AGP Support)" if !GART_IOMMU depends on ALPHA || IA64 || PPC || X86 + depends on PCI de...
8caf7aa26e0797e5706043f94c491acd1a08636a
Analyze and fix the following issue in the Linux kernel code: [ALSA] echoaudio - Remove kfree_nocheck()
Problem Details: Remove obsoleted kfree_nochec() (for debug). Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Jaroslav Kysela <perex@suse.cz>
```diff diff --git a/sound/pci/echoaudio/echoaudio.c b/sound/pci/echoaudio/echoaudio.c index e695502f7135..43b408ada1da 100644 --- a/sound/pci/echoaudio/echoaudio.c +++ b/sound/pci/echoaudio/echoaudio.c @@ -1878,10 +1878,9 @@ static int snd_echo_free(struct echoaudio *chip) if (chip->dsp_registers) iounmap(chip->d...
ccb99eee9c2430ad7ce2e7026fae93d6668d2d27
Analyze and fix the following issue in the Linux kernel code: [ALSA] echoaudio - Fix Makefile
Problem Details: Fix missing makefile entries for echoaudio drivers (sorry for cut-n-paste error!) Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Jaroslav Kysela <perex@suse.cz>
```diff diff --git a/sound/pci/echoaudio/Makefile b/sound/pci/echoaudio/Makefile index 02ab0e5232b2..7b576aeb3f8d 100644 --- a/sound/pci/echoaudio/Makefile +++ b/sound/pci/echoaudio/Makefile @@ -15,3 +15,16 @@ snd-echo3g-objs := echo3g.o snd-indigo-objs := indigo.o snd-indigoio-objs := indigoio.o snd-indigodj-objs :...
8c42d5bafa08baad5d647dd0b9050086ffe36e15
Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix a typo in echoaudio/midi.c
Problem Details: Fixed a typo in echoaudio/midi.c. Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Jaroslav Kysela <perex@suse.cz>
```diff diff --git a/sound/pci/echoaudio/midi.c b/sound/pci/echoaudio/midi.c index 5919b5c879a4..e31f0f11e3a8 100644 --- a/sound/pci/echoaudio/midi.c +++ b/sound/pci/echoaudio/midi.c @@ -44,7 +44,7 @@ static int enable_midi_input(struct echoaudio *chip, char enable) if (enable) { chip->mtc_state = MIDI_IN_STATE_NO...