id stringlengths 40 40 | instruction stringlengths 68 308 | input stringlengths 17 33.4k | output stringlengths 100 30k |
|---|---|---|---|
4078006568c142a909e7889cbdc28804cec25461 | Analyze and fix the following issue in the Linux kernel code: [PATCH] efi_call_phys_epilog() warning fix | Problem Details:
arch/i386/kernel/efi.c: In function `efi_call_phys_epilog': arch/i386/kernel/efi.c:118: warning: assignment makes integer from pointer without a cast
Cc: Matt Domsch <Matt_Domsch@dell.com>
Cc: "Tolentino, Matthew E" <matthew.e.tolentino@intel.com>
Cc: Zachary Amsden <zach@vmware.co... | ```diff
diff --git a/arch/i386/kernel/efi.c b/arch/i386/kernel/efi.c
index c9cad7ba0d2d..aeabb4196861 100644
--- a/arch/i386/kernel/efi.c
+++ b/arch/i386/kernel/efi.c
@@ -115,7 +115,7 @@ static void efi_call_phys_epilog(void)
unsigned long cr4;
struct Xgt_desc_struct *cpu_gdt_descr = &per_cpu(cpu_gdt_descr, 0);
-... |
c6077b3000184c7f69c4798b9025e5fbd69c8c62 | Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix memory leaks in error path of control.c | Problem Details:
Modules: Control Midlevel
Fix memory leaks in error path of control.c (only with CONFIG_SND_DEBUG=y).
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/core/control.c b/sound/core/control.c
index 9742bdba0de1..574745314e70 100644
--- a/sound/core/control.c
+++ b/sound/core/control.c
@@ -309,28 +309,29 @@ int snd_ctl_add(struct snd_card *card, struct snd_kcontrol *kcontrol)
{
struct snd_ctl_elem_id id;
unsigned int idx;
+ int err = -EINV... |
bb160b850d7e285f8b15906d9c0d1916acfdb953 | Analyze and fix the following issue in the Linux kernel code: [ALSA] AMD Au1x00: fix DMA init/cleanup | Problem Details:
Modules: MIPS AU1x00 driver
AMD Au1x00 ALSA driver causes kernel oops in au1000_init() by trying
to set DMA channel to -1 in yet unallocated audio streams. Here's the
patch that staightens up DMA init/cleanup code.
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Takashi Iwai <... | ```diff
diff --git a/sound/mips/au1x00.c b/sound/mips/au1x00.c
index e66b0144e3b5..961453b77fc9 100644
--- a/sound/mips/au1x00.c
+++ b/sound/mips/au1x00.c
@@ -612,14 +612,17 @@ snd_au1000_free(struct snd_card *card)
release_and_free_resource(au1000->ac97_res_port);
}
- if (au1000->stream[PLAYBACK]->dma >= 0)
- ... |
97ec558a88fb03fa23aee0832a88964e76e4a4db | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix generic auto-configurator | Problem Details:
Modules: HDA generic driver
Fixed the generic auto-configurator to check speaker pins in
addition.
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/pci/hda/hda_generic.c b/sound/pci/hda/hda_generic.c
index 39edfcfd3abd..85ad164ada59 100644
--- a/sound/pci/hda/hda_generic.c
+++ b/sound/pci/hda/hda_generic.c
@@ -47,10 +47,10 @@ struct hda_gnode {
/* patch-specific record */
struct hda_gspec {
- struct hda_gnode *dac_node; /* DAC node *... |
82bc955f6379135e6ce35ff90c7ac411fd412c4c | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix BIOS auto-configuration | Problem Details:
Modules: HDA Codec driver,HDA generic driver
- Fix autoconfig speaker/hp detection
Now it allows multiple speaker pins (e.g. Dell laptops have such config)
- Use speaker or hp pins if no line-outs are available
This fixes the silence output on recent Dell laptops with STAC9200
(ALSA bug#1843)
... | ```diff
diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
index fc91256e42eb..b42dff7ceed0 100644
--- a/sound/pci/hda/hda_codec.c
+++ b/sound/pci/hda/hda_codec.c
@@ -1899,6 +1899,13 @@ int snd_hda_multi_out_analog_prepare(struct hda_codec *codec, struct hda_multi_o
if (mout->hp_nid)
/* headphone o... |
19739fef0203d2f3eecc9c4b1ef25b57d85f2b30 | Analyze and fix the following issue in the Linux kernel code: [ALSA] Fixes typos in Audiophile-USB.txt | Problem Details:
Modules: Documentation
Fixes typos in Audiophile-USB.txt.
Signed-off-by: Thibault LE MEUR <Thibault.LeMeur@supelec.fr>
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/Documentation/sound/alsa/Audiophile-Usb.txt b/Documentation/sound/alsa/Audiophile-Usb.txt
index 3ba45adbf040..4692c8e77dc1 100644
--- a/Documentation/sound/alsa/Audiophile-Usb.txt
+++ b/Documentation/sound/alsa/Audiophile-Usb.txt
@@ -1,4 +1,4 @@
- Guide to using M-Audio Audiophile USB with ALSA and... |
01a00e5e421b3c40240781d67bb9fd5fd9b1f0f1 | Analyze and fix the following issue in the Linux kernel code: [ALSA] ice1712 - typo fixes for dxr_enable module option | Problem Details:
Modules: ICE1712 driver
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/ice1712/ice1712.c b/sound/pci/ice1712/ice1712.c
index 78098319209c..b96b5d6efc5d 100644
--- a/sound/pci/ice1712/ice1712.c
+++ b/sound/pci/ice1712/ice1712.c
@@ -83,11 +83,11 @@ MODULE_SUPPORTED_DEVICE("{"
static int index[SNDRV_CARDS] = SNDRV_DEFAULT_IDX; /* Index 0-MAX */
static char ... |
6682025e1220a1ab0b6b855b7805928c3163e043 | Analyze and fix the following issue in the Linux kernel code: [ALSA] ice1712 - Fix wrong value types for enum items | Problem Details:
Modules: ICE1712 driver
Fix the access to wrong type values for enum items in aureon.c
(ALSA bug#1527).
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/pci/ice1712/aureon.c b/sound/pci/ice1712/aureon.c
index 0f7f4d8263c0..7e6608b14abc 100644
--- a/sound/pci/ice1712/aureon.c
+++ b/sound/pci/ice1712/aureon.c
@@ -955,8 +955,8 @@ static int wm_adc_mux_get(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_val
mutex_lock(&ice->gpio_mutex);
... |
878b4789196e3cd470f843854b6b09d963214659 | Analyze and fix the following issue in the Linux kernel code: [ALSA] fix resource leak in usbmixer | Problem Details:
Modules: USB generic driver
We may leak 'namelist' in sound/usb/usbmixer.c::parse_audio_selector_unit()
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/usb/usbmixer.c b/sound/usb/usbmixer.c
index 0bfea7237395..8d08b34a1cb5 100644
--- a/sound/usb/usbmixer.c
+++ b/sound/usb/usbmixer.c
@@ -1468,6 +1468,7 @@ static int parse_audio_selector_unit(struct mixer_build *state, int unitid, unsi
kctl = snd_ctl_new1(&mixer_selectunit_ctl, cval);
if (... |
d61975fc6b40dadd2cd61fc9535499c7d7b806de | Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix gus_pcm dereference before NULL | Problem Details:
Modules: GUS Library
The NULL check of substream is simply superfluous. It is
guaranteed to receive non-NULL substream. Thanks Takashi.
Coverity bug #861
Signed-off-by: Eugene Teo <eugene.teo@eugeneteo.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/isa/gus/gus_pcm.c b/sound/isa/gus/gus_pcm.c
index d0829393ec8a..c7f95e7aa018 100644
--- a/sound/isa/gus/gus_pcm.c
+++ b/sound/isa/gus/gus_pcm.c
@@ -114,8 +114,6 @@ static void snd_gf1_pcm_trigger_up(struct snd_pcm_substream *substream)
unsigned char pan;
unsigned int voice;
- if (substr... |
e64d2e36236175a56fd1d8b2acd784e21bdc7de6 | Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix seq_clientmgr dereferences before NULL check | Problem Details:
Modules: ALSA sequencer
cptr->pool must be non-NULL there, so just the if (cptr->pool) is
superfluous. Thanks Takashi.
Signed-off-by: Eugene Teo <eugene.teo@eugeneteo.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/core/seq/seq_clientmgr.c b/sound/core/seq/seq_clientmgr.c
index aae6420f5948..bb15d9ee8842 100644
--- a/sound/core/seq/seq_clientmgr.c
+++ b/sound/core/seq/seq_clientmgr.c
@@ -1866,8 +1866,7 @@ static int snd_seq_ioctl_get_client_pool(struct snd_seq_client *client,
info.output_pool = cptr->... |
825aa97241b46d2819c1db984c86a1a9df41b8e1 | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix for Samsung R65 and ASUS A6J | Problem Details:
Modules: Documentation,HDA Codec driver
Added a new model 'laptop-eapd' to AD1986A codec for Samsung R65 and
ASUS A6J laptops.
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/Documentation/sound/alsa/ALSA-Configuration.txt b/Documentation/sound/alsa/ALSA-Configuration.txt
index dcc9cd9633dd..1def6049784c 100644
--- a/Documentation/sound/alsa/ALSA-Configuration.txt
+++ b/Documentation/sound/alsa/ALSA-Configuration.txt
@@ -745,6 +745,7 @@ Prior to version 0.9.0rc4 options... |
a23446c085faed6c1c90fba5cdd21d6990871750 | Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix NM256 hard lock up | Problem Details:
Modules: NM256 driver
Treat the nm256 mixer as a write-only device so as to avoid hangs on
initialisation.
Signed-off-by: Florian Schlichting <Florian.Schlichting@gmx.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/pci/nm256/nm256.c b/sound/pci/nm256/nm256.c
index 3a3ba6f547bc..cc297abc9d11 100644
--- a/sound/pci/nm256/nm256.c
+++ b/sound/pci/nm256/nm256.c
@@ -228,6 +228,7 @@ struct nm256 {
unsigned int use_cache: 1; /* use one big coef. table */
unsigned int reset_workaround: 1; /* Workaround for s... |
e311334ee6bdd173d53be52f4fdffa5f39652e26 | Analyze and fix the following issue in the Linux kernel code: [ALSA] Fixes audiophile usb analog capture with the new device_setup parameter | Problem Details:
Modules: Documentation,USB generic driver
The patch adds the 'device_setup' module parameter and a specific
quirk to correctly initialize the audiophile usb device: this fixes
the distorted sound bug on the Analog capture port. Backward
compatibility is achieved by simply omitting the new parameter.
... | ```diff
diff --git a/Documentation/sound/alsa/ALSA-Configuration.txt b/Documentation/sound/alsa/ALSA-Configuration.txt
index 1065beed8d75..f947c4b04ab8 100644
--- a/Documentation/sound/alsa/ALSA-Configuration.txt
+++ b/Documentation/sound/alsa/ALSA-Configuration.txt
@@ -1411,6 +1411,9 @@ Prior to version 0.9.0rc4 optio... |
202728d783a0fc180e7141d18186eeae167218a1 | Analyze and fix the following issue in the Linux kernel code: [ALSA] fix some memory leaks | Problem Details:
Modules: Generic drivers,ES18xx driver,CS46xx driver
This patch fixes two memory leaks spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/drivers/serial-u16550.c b/sound/drivers/serial-u16550.c
index 13b46d12564a..1a7fbefe4740 100644
--- a/sound/drivers/serial-u16550.c
+++ b/sound/drivers/serial-u16550.c
@@ -789,6 +789,7 @@ static int __init snd_uart16550_create(struct snd_card *card,
if ((err = snd_uart16550_detect(uart)) ... |
ede3531e8ce2deb81e477e18d72ef10efeb20ebe | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix Aopen i915GMm-HFS mobo | Problem Details:
Modules: HDA Codec driver
Add a model entry for Aopen i915GMm-HFS mobo with ALC880 codec.
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 928141b1d74e..0697c9bd45cc 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -2022,6 +2022,8 @@ static struct hda_board_config alc880_cfg_tbl[] = {
{ .pci_subvendor = 0x8086, .pci_subdevice = 0xa10... |
5bab2482083077d1e14644db2546c54534156849 | Analyze and fix the following issue in the Linux kernel code: [ALSA] sound/pci/rme9652/hdspm.c: fix off-by-one errors | Problem Details:
Modules: RME9652 driver
This patch fixes off-by-one errors found by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/pci/rme9652/hdspm.c b/sound/pci/rme9652/hdspm.c
index 103b4d715ff4..980b9cd689dd 100644
--- a/sound/pci/rme9652/hdspm.c
+++ b/sound/pci/rme9652/hdspm.c
@@ -474,7 +474,7 @@ static inline unsigned int hdspm_read(struct hdspm * hdspm, unsigned int reg)
static inline int hdspm_read_in_gain(struc... |
3a63e44420932852efd6a7d6d46cdad4d427f880 | Analyze and fix the following issue in the Linux kernel code: [ALSA] sound/core/: fix 3 off-by-one errors | Problem Details:
Modules: ALSA Core
This patch fixes three off-by-one errors found by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/core/sound.c b/sound/core/sound.c
index df4ab94d006e..4d28e5212611 100644
--- a/sound/core/sound.c
+++ b/sound/core/sound.c
@@ -121,7 +121,7 @@ void *snd_lookup_minor_data(unsigned int minor, int type)
struct snd_minor *mreg;
void *private_data;
- if (minor > ARRAY_SIZE(snd_minors))
+ i... |
9230d2148a0c53188c216b446cf17ea213ebca8a | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix support of laptops with AD1986A codec | Problem Details:
Modules: Documentation,HDA Codec driver
Fix the support of laptops with AD1986A HD-audio codec.
Added new models '3stack' and 'laptop'. Currently, fixed for FSC V2060
and Samsung M50.
Also fixed the description of missing models in ALSA-Configuration.txt.
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/Documentation/sound/alsa/ALSA-Configuration.txt b/Documentation/sound/alsa/ALSA-Configuration.txt
index c12dab05176a..1065beed8d75 100644
--- a/Documentation/sound/alsa/ALSA-Configuration.txt
+++ b/Documentation/sound/alsa/ALSA-Configuration.txt
@@ -737,6 +737,24 @@ Prior to version 0.9.0rc4 option... |
5e315e9248329c53a8932b71532c28240125e3c4 | Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix use after free in opl3_seq and opl3_oss | Problem Details:
Modules: OPL3
Don't read from free'd memory. Also make use of the return
value, and don't register the device if something went wrong
creating the port.
Coverity #954, #955
Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/drivers/opl3/opl3_oss.c b/sound/drivers/opl3/opl3_oss.c
index 0345ae647681..fccf019a6d85 100644
--- a/sound/drivers/opl3/opl3_oss.c
+++ b/sound/drivers/opl3/opl3_oss.c
@@ -104,8 +104,10 @@ static int snd_opl3_oss_create_port(struct snd_opl3 * opl3)
voices, voices,
name);
... |
bcc54f9a563f146e723ead16c76f842bcaeb694e | Analyze and fix the following issue in the Linux kernel code: [ALSA] sound/isa/sb/sb_mixer.c double kfree | Problem Details:
Modules: SB drivers
snd_ctl_add() already does the free on error.
Coverity bug #957
Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/isa/sb/sb_mixer.c b/sound/isa/sb/sb_mixer.c
index 1a6ee344dddb..490b1ca5cf58 100644
--- a/sound/isa/sb/sb_mixer.c
+++ b/sound/isa/sb/sb_mixer.c
@@ -453,10 +453,8 @@ int snd_sbmixer_add_ctl(struct snd_sb *chip, const char *name, int index, int ty
strlcpy(ctl->id.name, name, sizeof(ctl->id.na... |
c27e8c591854ef349fdf5bec777355dae04bb48f | Analyze and fix the following issue in the Linux kernel code: [ALSA] emu10k1_synth use after free | Problem Details:
Modules: EMU10K1/EMU10K2 driver
Thou shalt not dereference freed memory.
Coverity bug #958
Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/pci/emu10k1/emu10k1_synth.c b/sound/pci/emu10k1/emu10k1_synth.c
index 1fa393f22a99..204995a1dfbd 100644
--- a/sound/pci/emu10k1/emu10k1_synth.c
+++ b/sound/pci/emu10k1/emu10k1_synth.c
@@ -62,7 +62,6 @@ static int snd_emu10k1_synth_new_device(struct snd_seq_device *dev)
if (snd_emux_regist... |
a2df813beab42740fa8043b3fdc9e1d15784b9ec | Analyze and fix the following issue in the Linux kernel code: [ALSA] fix usbmixer double kfree | Problem Details:
Modules: USB generic driver
snd_ctl_add() kfree's the kcontrol already if we fail there,
so this driver is currently doing a double kfree.
Coverity bug #959
Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/usb/usbmixer.c b/sound/usb/usbmixer.c
index 678dac2d4dba..0bfea7237395 100644
--- a/sound/usb/usbmixer.c
+++ b/sound/usb/usbmixer.c
@@ -434,7 +434,6 @@ static int add_control_to_empty(struct mixer_build *state, struct snd_kcontrol *
kctl->id.index++;
if ((err = snd_ctl_add(state->chip->c... |
ac57b84984859f3e1d567c031556d3de872c1a91 | Analyze and fix the following issue in the Linux kernel code: [ALSA] vx - Fix memory leak on error path | Problem Details:
Modules: Digigram VX core
Noticed by Eric Sesterhenn on kernel-janitors@
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/drivers/vx/vx_pcm.c b/sound/drivers/vx/vx_pcm.c
index 2195e25087b4..c4af84995d05 100644
--- a/sound/drivers/vx/vx_pcm.c
+++ b/sound/drivers/vx/vx_pcm.c
@@ -1253,9 +1253,13 @@ static int vx_init_audio_io(struct vx_core *chip)
/* allocate pipes */
chip->playback_pipes = kmalloc(sizeof(str... |
0b7bed4ec2a16434336e018505b66bd51bb35560 | Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix typos in document | Problem Details:
Modules: Documentation
Fixed typos in document.
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/Documentation/sound/alsa/DocBook/writing-an-alsa-driver.tmpl b/Documentation/sound/alsa/DocBook/writing-an-alsa-driver.tmpl
index 4251085d38d3..6dc9d9f622ca 100644
--- a/Documentation/sound/alsa/DocBook/writing-an-alsa-driver.tmpl
+++ b/Documentation/sound/alsa/DocBook/writing-an-alsa-driver.tmpl
@... |
a7ee8201a507fe1f89f0e5fc32516daed6621ffd | Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix missing AD1986a capsrc | Problem Details:
Modules: HDA Codec driver
Fix missing AD1986a capsrc setting in the last patch.
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/pci/hda/patch_analog.c b/sound/pci/hda/patch_analog.c
index b2479268778d..4d363cfa6c81 100644
--- a/sound/pci/hda/patch_analog.c
+++ b/sound/pci/hda/patch_analog.c
@@ -603,7 +603,7 @@ static int patch_ad1986a(struct hda_codec *codec)
spec->multiout.dig_out_nid = AD1986A_SPDIF_OUT;
spec->n... |
18a815d7426986890b88078ea63b77732baca0b5 | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix AD198x recording and add HP model | Problem Details:
Modules: HDA Codec driver
- Fixed recording of AD1981HD/AD1983/AD1986A
- Added model 'hp' to AD1981HD for HP nx6320
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/pci/hda/patch_analog.c b/sound/pci/hda/patch_analog.c
index 5a3821ae93a8..b2479268778d 100644
--- a/sound/pci/hda/patch_analog.c
+++ b/sound/pci/hda/patch_analog.c
@@ -310,7 +310,7 @@ static int ad198x_resume(struct hda_codec *codec)
struct ad198x_spec *spec = codec->spec;
int i;
- ad19... |
834be88d136ee82828e3ce1b34fa7a1dcf947b81 | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix ALC262 for Fujitsu laptop | Problem Details:
Modules: HDA Codec driver,HDA generic driver
Add 'fujitsu' model for ALC262 patch to support a FSC laptop.
The internal speaker is turned on/off with jack sensing.
Also fixed alc262 'basic' model.
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
index 0d1566a39965..fc91256e42eb 100644
--- a/sound/pci/hda/hda_codec.c
+++ b/sound/pci/hda/hda_codec.c
@@ -729,7 +729,8 @@ static void put_vol_mute(struct hda_codec *codec, struct hda_amp_info *info,
/*
* read AMP value. The volume is betwe... |
381e3cda682abcef2acd7828e9639f4ceb95880f | Analyze and fix the following issue in the Linux kernel code: [ALSA] ice1712 - Fix wordclock status on Delta1010LT | Problem Details:
Modules: ICE1712 driver
I posted this patch to bug 1806 a while back, and have been awaiting a
reply or commit. It currently reports the Locked/No Signal text
backwards in envy24control, since i was using an older version of
envy24control when I wrote the original code. The Locked/No Signal test
was... | ```diff
diff --git a/sound/pci/ice1712/delta.c b/sound/pci/ice1712/delta.c
index 74c4d03720bb..465eeb50eb98 100644
--- a/sound/pci/ice1712/delta.c
+++ b/sound/pci/ice1712/delta.c
@@ -412,7 +412,7 @@ int snd_ice1712_delta1010lt_wordclock_status_get(struct snd_kcontrol *kcontrol,
if (snd_i2c_sendbytes(ice->cs8427, ®... |
92621f130e60da865de2f5aa6d3dec2ee844b803 | Analyze and fix the following issue in the Linux kernel code: [ALSA] HDA/ALC260: 7/7 - add SPDIF enable to test model | Problem Details:
Modules: HDA Codec driver
This patch adds mixer controls to the 'test' ALC260 model which allow the
user to selectively enable or disable the SPDIF output pins. This should
assist people identify digital outputs on machines which bring them to the
outside world.
Note that while the patch *should* wo... | ```diff
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index c8b0ec814375..219ddf0b8d43 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -395,6 +395,60 @@ static int alc_gpio_data_put(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_
.private_value = ni... |
0bfc90e95946ac420e2de049707232ce18ddeba9 | Analyze and fix the following issue in the Linux kernel code: [ALSA] HDA/ALC260: 5/7 - add 'acer' model | Problem Details:
Modules: HDA Codec driver
This patch adds a new 'acer' model. It is based on work by Rimas and many
other dedicated Acer owners over the past few weeks (see bug number
1618) - kudos to them. This adds support for a variety of Acer laptops,
although we are still in the process of collecting pci/subsys... | ```diff
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 4f6dea23d8b2..104d2a37f45a 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -64,6 +64,7 @@ enum {
ALC260_HP,
ALC260_HP_3013,
ALC260_FUJITSU_S702X,
+ ALC260_ACER,
#ifdef CONFIG_SND_DEBUG
ALC... |
17e7aec680a252ec0cea6d886d3983319af43ac4 | Analyze and fix the following issue in the Linux kernel code: [ALSA] HDA/ALC260: 1/7 - Fix test model input mux label | Problem Details:
Modules: HDA Codec driver
This patch fixes input mux labels used for the ALC260 'test' model. This is
needed to avoid confusion which comes about because the two ADCs in the
ALC260 have slightly different mappings for their input selectors. Since
this is just the test model it's sufficient to simply ... | ```diff
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index ea4200a4ee42..b34d2448d172 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -2414,8 +2414,8 @@ static struct hda_input_mux alc260_capture_source = {
},
};
-/* On Fujitsu S702x laptops capture o... |
0bbbc4ca7e2459f2750bd4bd8dda2ccbf7a71f02 | Analyze and fix the following issue in the Linux kernel code: [ALSA] opti9x - Fix compile without CONFIG_PNP | Problem Details:
Modules: Opti9xx drivers
Fix compile errors without CONFIG_PNP.
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/isa/opti9xx/opti92x-ad1848.c b/sound/isa/opti9xx/opti92x-ad1848.c
index 63d96be11b2b..65b28cbc0ebd 100644
--- a/sound/isa/opti9xx/opti92x-ad1848.c
+++ b/sound/isa/opti9xx/opti92x-ad1848.c
@@ -2088,9 +2088,11 @@ static int __init alsa_card_opti9xx_init(void)
int error;
struct platform_devi... |
a5a6bbd9b2481dd556236ea866424590f5f987a4 | Analyze and fix the following issue in the Linux kernel code: [ALSA] cs4236 - Fix a typo | Problem Details:
Modules: CS4236+ driver
Fixed a typo in snd_cs4236_put_master_digital(), resulting in silence
right channel.
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/isa/cs423x/cs4236_lib.c b/sound/isa/cs423x/cs4236_lib.c
index 1125ddb2b1aa..7a5a6c71f5e4 100644
--- a/sound/isa/cs423x/cs4236_lib.c
+++ b/sound/isa/cs423x/cs4236_lib.c
@@ -644,7 +644,7 @@ static int snd_cs4236_put_master_digital(struct snd_kcontrol *kcontrol, struct s
val2 = (chip->eimage[C... |
62c5549ee246fa30606f918f97c6b3cde2831292 | Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix sleep in atomic in virmidi driver | Problem Details:
Modules: ALSA sequencer
Debug: sleeping function called from invalid context at /usr/src/linux/include/linux/rwsem.h:43
in_atomic():1, irqs_disabled():0
[<f999d15e>] snd_seq_deliver_event+0xb4/0x1a8 [snd_seq]
[<f999d2be>] snd_seq_kernel_client_dispatch+0x6c/0x7c [snd_seq]
[<f93321fc>] snd_virm... | ```diff
diff --git a/sound/core/seq/seq_virmidi.c b/sound/core/seq/seq_virmidi.c
index 14fd1a608e14..f4edec603b8f 100644
--- a/sound/core/seq/seq_virmidi.c
+++ b/sound/core/seq/seq_virmidi.c
@@ -167,7 +167,7 @@ static void snd_virmidi_output_trigger(struct snd_rawmidi_substream *substream,
return; /* ignored */
... |
8278ca8feb2748cf02d756ac6c5b9ab2e047c84a | Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix check of enable module option | Problem Details:
Fix the check of enable module option in probe of platform_device drivers.
It shouldn't break the loop but just ignore if enable[i] is false.
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/drivers/dummy.c b/sound/drivers/dummy.c
index 14e1a671b5cf..e35fd5779a9d 100644
--- a/sound/drivers/dummy.c
+++ b/sound/drivers/dummy.c
@@ -669,8 +669,10 @@ static int __init alsa_card_dummy_init(void)
return err;
cards = 0;
- for (i = 0; i < SNDRV_CARDS && enable[i]; i++) {
+ for (i =... |
f7004f3975591f3d4cdf457f879e9ede57394500 | Analyze and fix the following issue in the Linux kernel code: [ALSA] ice1712 - Delta 1010LT S/PDIF fixes | Problem Details:
Modules: ICE1712 driver
See ALSA bug#1806 for details.
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/ice1712/delta.c b/sound/pci/ice1712/delta.c
index 4bbf1e2ae653..74c4d03720bb 100644
--- a/sound/pci/ice1712/delta.c
+++ b/sound/pci/ice1712/delta.c
@@ -393,6 +393,37 @@ static void delta_setup_spdif(struct snd_ice1712 *ice, int rate)
snd_ice1712_delta_cs8403_spdif_write(ice, tmp);
}
... |
d08a23e2509e8e80637b4dfa5607ea00b9151b0a | Analyze and fix the following issue in the Linux kernel code: [ALSA] ad1816a - Fix PCM trigger direction | Problem Details:
Modules: AD1816A driver
Fixed the bug of capture with Shark Predator ISA resulting in:
arecord: pcm_read:1196: read error: Input/output error
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/isa/ad1816a/ad1816a_lib.c b/sound/isa/ad1816a/ad1816a_lib.c
index ac0d808fff57..fd8fe16c09ee 100644
--- a/sound/isa/ad1816a/ad1816a_lib.c
+++ b/sound/isa/ad1816a/ad1816a_lib.c
@@ -1,4 +1,3 @@
-
/*
ad1816a.c - lowlevel code for Analog Devices AD1816A chip.
Copyright (C) 1999-2000 by... |
7cf51e48315d87b4c1cf600d611894f45f661142 | Analyze and fix the following issue in the Linux kernel code: [ALSA] hda: ALC260 test model implementation | Problem Details:
Modules: HDA Codec driver
The following patch adds a 'test' ALC260 model specification to the
patch_realtek.c driver if CONFIG_SND_DEBUG is set. This is similar to the
'test' ALC880 model in that it sets up mixer controls for almost everything
to make it easier for people to test their laptop/soundca... | ```diff
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 8ec2db2e9b60..ea4200a4ee42 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6,6 +6,7 @@
* Copyright (c) 2004 Kailang Yang <kailang@realtek.com.tw>
* PeiSen Hou <pshou@realtek... |
e957ebf164e880ddb0c057418195db47d013c4ac | Analyze and fix the following issue in the Linux kernel code: [ALSA] ice1712 & cs8427 - fix problem for S/PDIF input setup | Problem Details:
Modules: I2C cs8427,ICE1712 driver
See ALSA bug#1785 for more details.
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/i2c/cs8427.c b/sound/i2c/cs8427.c
index 9deba80a587c..cb89f7eb9236 100644
--- a/sound/i2c/cs8427.c
+++ b/sound/i2c/cs8427.c
@@ -291,11 +291,13 @@ static void snd_cs8427_reset(struct snd_i2c_device *cs8427)
{
struct cs8427 *chip;
unsigned long end_time;
- int data;
+ int data, aes3input =... |
c82590d2b2877ec846c5313ea897420209b91ea7 | Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix mulaw -> linear conversion in OSS PCM emulation | Problem Details:
Modules: ALSA<-OSS emulation
Fixed the missing mulaw -> linear conversion in OSS PCM emulation code.
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/core/oss/pcm_plugin.c b/sound/core/oss/pcm_plugin.c
index cec2774425ec..0e67dd280a5d 100644
--- a/sound/core/oss/pcm_plugin.c
+++ b/sound/core/oss/pcm_plugin.c
@@ -470,7 +470,8 @@ int snd_pcm_plug_format_plugins(struct snd_pcm_substream *plug,
/* format change */
if (srcformat.format != d... |
05422575d4bc5d1a6aff22dfa9a0b5bc701ccf6f | Analyze and fix the following issue in the Linux kernel code: [ALSA] usb-audio: fix number of G-70 ports | Problem Details:
Modules: USB generic driver
The G-70 has one MIDI port in each direction, no two.
Signed-off-by: Clemens Ladisch <clemens@ladisch.de> | ```diff
diff --git a/sound/usb/usbquirks.h b/sound/usb/usbquirks.h
index 42079dadbe8c..edb88871ff4a 100644
--- a/sound/usb/usbquirks.h
+++ b/sound/usb/usbquirks.h
@@ -1100,8 +1100,8 @@ YAMAHA_DEVICE(0x7010, "UB99"),
.ifnum = 0,
.type = QUIRK_MIDI_FIXED_ENDPOINT,
.data = & (const struct snd_usb_midi_endpoint_in... |
f0283f45a04d5cf31512e5e390a38504d97e7a97 | Analyze and fix the following issue in the Linux kernel code: [ALSA] au88x0 - Fix structs for equalizer | Problem Details:
Modules: au88x0 driver
Fixed the structures for equalizer.
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/pci/au88x0/au88x0_eq.h b/sound/pci/au88x0/au88x0_eq.h
index 717544af58ad..474cd0046294 100644
--- a/sound/pci/au88x0/au88x0_eq.h
+++ b/sound/pci/au88x0/au88x0_eq.h
@@ -13,18 +13,16 @@
typedef struct {
u16 LeftCoefs[50]; //0x4
u16 RightCoefs[50]; // 0x68
- u16 LeftGains[20]; //0xd0
- u16 ... |
f7cbb7fcd3bae5264a079e06411b35366da9bd4d | Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix snd_xxx_t typedefs | Problem Details:
Modules: PXA Mainstone driver,CX88 driver,SAA7134 driver
Replace snd_xxx_t typedefs with explicit structs.
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/arch/arm/mach-pxa/mainstone.c b/arch/arm/mach-pxa/mainstone.c
index d5bda60209ec..98356f810007 100644
--- a/arch/arm/mach-pxa/mainstone.c
+++ b/arch/arm/mach-pxa/mainstone.c
@@ -157,14 +157,14 @@ static struct platform_device smc91x_device = {
.resource = smc91x_resources,
};
-static int mst_a... |
97c67b65cbdfd19887450ae1b80ddbb54de9559d | Analyze and fix the following issue in the Linux kernel code: [ALSA] au88x0 - 64bit arch fixes | Problem Details:
Modules: au88x0 driver
Fix the driver codes to run on 64bit architectures.
The patch taken from ALSA BTS bug#1047.
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/pci/au88x0/au88x0.c b/sound/pci/au88x0/au88x0.c
index 7d9184f7367a..126870ec063a 100644
--- a/sound/pci/au88x0/au88x0.c
+++ b/sound/pci/au88x0/au88x0.c
@@ -151,14 +151,18 @@ snd_vortex_create(struct snd_card *card, struct pci_dev *pci, vortex_t ** rchip)
// check PCI availability (DMA).
i... |
45fe722ba814dc50410729a473022c550dd96910 | Analyze and fix the following issue in the Linux kernel code: [ALSA] ice1724 - Add support of Prodigy-7.1LT | Problem Details:
Modules: ICE1712 driver
Added the support of Prodigy-7.1LT board.
The patch taken from ALSA BTS bug#1090.
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/pci/ice1712/aureon.c b/sound/pci/ice1712/aureon.c
index 8809812a1c22..2175f6721347 100644
--- a/sound/pci/ice1712/aureon.c
+++ b/sound/pci/ice1712/aureon.c
@@ -322,36 +322,48 @@ static void aureon_spi_write(struct snd_ice1712 *ice, unsigned int cs, unsigned
{
unsigned int tmp;
int i;
+ u... |
9d83911ac082c6d63c1c08f235349113d8c1d0a3 | Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix a typo | Problem Details:
Modules: ALSA<-OSS emulation
Fixed a typo.
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/core/oss/copy.c b/sound/core/oss/copy.c
index 7c008c4c0dd1..6658facc5cda 100644
--- a/sound/core/oss/copy.c
+++ b/sound/core/oss/copy.c
@@ -21,7 +21,7 @@
#include <sound/driver.h>
-#ifdef SND_PCM_OSS_PLUGINS
+#ifdef CONFIG_SND_PCM_OSS_PLUGINS
#include <linux/time.h>
#include <sound/c... |
153abaa4ff0500070a282dd0868367d69388d527 | Analyze and fix the following issue in the Linux kernel code: [ALSA] ymfpci: fix swapped channels in SPDIF output | Problem Details:
Modules: YMFPCI driver
The routing of the effect 2/3 channels to the digital output is the
opposite of the rear analog output (left/right swapped).
We make the order correct for the digital output (which will make the
analog rear have the channels swapped) to make AC3 output work.
Signed-off-by: Cle... | ```diff
diff --git a/sound/pci/ymfpci/ymfpci_main.c b/sound/pci/ymfpci/ymfpci_main.c
index a1aa74b79b3d..30ee53adb494 100644
--- a/sound/pci/ymfpci/ymfpci_main.c
+++ b/sound/pci/ymfpci/ymfpci_main.c
@@ -536,13 +536,17 @@ static void snd_ymfpci_pcm_init_voice(struct snd_ymfpci_pcm *ypcm, unsigned int
}
}
if (y... |
84a43bd523a63f1b53fd734c3798d71b7b53f123 | Analyze and fix the following issue in the Linux kernel code: [ALSA] intel8x0 - Fix/cleanup detection of codecs on SIS7012 | Problem Details:
Modules: Intel8x0 driver
Fix the detection of tertriary codec on SIS7012, including clean-ups
of relevant codes.
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/pci/intel8x0.c b/sound/pci/intel8x0.c
index 174237f4a22c..da024ffe96c2 100644
--- a/sound/pci/intel8x0.c
+++ b/sound/pci/intel8x0.c
@@ -178,6 +178,8 @@ DEFINE_REGSET(SP, 0x60); /* SPDIF out */
#define ICH_SAMPLE_CAP 0x00c00000 /* ICH4: sample capability bits (RO) */
#define ICH_SAMPLE_1... |
15f500a6994e552b7772d8b8459ee3114c47897d | Analyze and fix the following issue in the Linux kernel code: [ALSA] ens1370 - Fix resume | Problem Details:
Modules: ENS1370/1+ driver
Fix resume of ens1370 driver.
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/pci/ens1370.c b/sound/pci/ens1370.c
index 55aaf110331a..bee382995fe9 100644
--- a/sound/pci/ens1370.c
+++ b/sound/pci/ens1370.c
@@ -2061,6 +2061,13 @@ static int snd_ensoniq_suspend(struct pci_dev *pci, pm_message_t state)
#ifdef CHIP1371
snd_ac97_suspend(ensoniq->u.es1371.ac97);
#else
+... |
34226c4239861654c69888e6e98973b2cc908c0b | Analyze and fix the following issue in the Linux kernel code: [ALSA] pcxhr - Suppress debug messages | Problem Details:
Modules: Digigram PCXHR driver
Suppress debug messages.
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/pci/pcxhr/pcxhr_core.c b/sound/pci/pcxhr/pcxhr_core.c
index fa0d27e2c79b..fdc652c6992d 100644
--- a/sound/pci/pcxhr/pcxhr_core.c
+++ b/sound/pci/pcxhr/pcxhr_core.c
@@ -1176,7 +1176,7 @@ irqreturn_t pcxhr_interrupt(int irq, void *dev_id, struct pt_regs *regs)
mgr->dsp_time_last = dsp_time_n... |
caf636c760b33c72ebf018ff03c1b0d79ea6656a | Analyze and fix the following issue in the Linux kernel code: [TG3]: Fix SRAM access during tg3_init_one() | Problem Details:
5700 and 5701 will not return correct SRAM data when the chip is in
D3hot power state. tg3_get_eeprom_hw_cfg() must first put the device
in D0 before reading SRAM.
Thanks to Thomas Chenault at Dell for noticing this problem.
Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Mil... | ```diff
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index e03d1ae50c3e..cb687fcaae1f 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -9436,12 +9436,18 @@ static inline struct subsys_tbl_ent *lookup_by_subsys(struct tg3 *tp)
return NULL;
}
-/* Since this function may be called in D3-hot power state... |
bac37ec8300389d355d41a828b47577c1ec2e4f4 | Analyze and fix the following issue in the Linux kernel code: [X25]: fix kernel error message 64 bit kernel | Problem Details:
Fixes the following error from kernel
T2 kernel: schedule_timeout:
wrong timeout value ffffffffffffffff from ffffffff88164796
Signed-off-by: Shaun Pereira <spereira@tusc.com.au>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: David S. Miller <davem@d... | ```diff
diff --git a/net/x25/af_x25.c b/net/x25/af_x25.c
index a41cc0201760..03725c051752 100644
--- a/net/x25/af_x25.c
+++ b/net/x25/af_x25.c
@@ -744,7 +744,7 @@ out:
return rc;
}
-static int x25_wait_for_data(struct sock *sk, int timeout)
+static int x25_wait_for_data(struct sock *sk, long timeout)
{
DECLARE_... |
caf80e579b5fc0048681a47c5a55487116e56a88 | Analyze and fix the following issue in the Linux kernel code: [PATCH] powerpc: Unconfuse htab_bolt_mapping() callers | Problem Details:
htab_bolt_mapping() takes a vstart and pstart parameter, but all but one of
its callers actually pass it vstart and vstart. Luckily before it passes
paddr (calculated from paddr) to the hpte_insert routines it calls
virt_to_abs() (aka. __pa()) on the address, so there isn't actually a bug.
map_io_page... | ```diff
diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c
index 7d9ce9a48219..7b4eccffd002 100644
--- a/arch/powerpc/mm/hash_utils_64.c
+++ b/arch/powerpc/mm/hash_utils_64.c
@@ -169,7 +169,7 @@ int htab_bolt_mapping(unsigned long vstart, unsigned long vend,
#ifdef CONFIG_PPC_ISERIES
if ... |
bf4b85b0e4bab42b3e8d8b0acc6851bb85e2050b | Analyze and fix the following issue in the Linux kernel code: [PATCH] powerpc numa: Minor debugging code changes | Problem Details:
Add debug statement for map_cpu_to_node; it's useful for cpu hotplug.
Clarify debug statement about not finding the numa reference points
property.
Don't print a meaningless associativity depth (-1) on non-numa systems.
Signed-off-by: Nathan Lynch <nathanl@austin.ibm.com>
Signed-off-by: Paul Mackerr... | ```diff
diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
index dc6392ce2530..2ae491d9404f 100644
--- a/arch/powerpc/mm/numa.c
+++ b/arch/powerpc/mm/numa.c
@@ -133,6 +133,8 @@ static inline void map_cpu_to_node(int cpu, int node)
{
numa_cpu_lookup_table[cpu] = node;
+ dbg("adding cpu %d to node %d\n", c... |
c08888cf3c80fe07bfd176113c390ca31d3ba5c2 | Analyze and fix the following issue in the Linux kernel code: [PATCH] powerpc numa: fix boot_cpuid always assigned to node 0 | Problem Details:
At boot, the numa code is assigning boot_cpuid to node 0
unconditionally. Basically, numa_setup_cpu is being stupid about it,
but this is the minimal fix -- just call numa_setup_cpu(boot_cpuid)
later, after all nodes have been set online.
Signed-off-by: Nathan Lynch <nathanl@austin.ibm.com>
Signed-of... | ```diff
diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
index da5280f8cf42..dc6392ce2530 100644
--- a/arch/powerpc/mm/numa.c
+++ b/arch/powerpc/mm/numa.c
@@ -375,7 +375,7 @@ static int __init parse_numa_properties(void)
{
struct device_node *cpu = NULL;
struct device_node *memory = NULL;
- int max_dom... |
c962990a38167aacac91738501815deffa3afbd6 | Analyze and fix the following issue in the Linux kernel code: [libata] sata_vsc: fix inconsistent NULL checking | Problem Details:
Also, cleanup interrupt mask content and note in Kconfig that this
driver supports the Intel 31244.
Signed-off-by: Jeff Garzik <jeff@garzik.org> | ```diff
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 5c94a5d4efc0..4035920ce3d8 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -595,10 +595,10 @@ config SCSI_SATA_VIA
If unsure, say N.
config SCSI_SATA_VITESSE
- tristate "VITESSE VSC-7174 SATA support"
+ tristate "VITESSE VSC-7... |
4d4681f6b994baf93dff0e4f59ab4fe38b49ef13 | Analyze and fix the following issue in the Linux kernel code: [libata] fix oops on non-DMA bmdma hardware | Problem Details:
Alan noted: "bmdma may be zero but the bmdma_irq_clear function gets
called even in this case during pure PIO operation. Check we have a
bmdma before we use it."
I fixed this by adding a check for zero. While was I there, I fixed the
non-standard indentation of the small function's code.
Signed-off-... | ```diff
diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
index 673ddf611d0e..c8d2201b126f 100644
--- a/drivers/scsi/libata-core.c
+++ b/drivers/scsi/libata-core.c
@@ -4202,14 +4202,17 @@ void ata_bmdma_setup(struct ata_queued_cmd *qc)
void ata_bmdma_irq_clear(struct ata_port *ap)
{
- if (ap->... |
806a6e7a9904d4a1dfd3fd79d373bf31d71d34cb | Analyze and fix the following issue in the Linux kernel code: [libata] sata_mv: off-by-1 fix | Problem Details:
This patch addresses a number of weird behaviours observed
for the sata_mv driver, by fixing an "off by one" bug in processing
of the EDMA response queue.
Basically, sata_mv was looking in the wrong place for
command results, and this produced a lot of unpredictable behaviour.
Signed-off-by: Mark Lor... | ```diff
diff --git a/drivers/scsi/sata_mv.c b/drivers/scsi/sata_mv.c
index e561281967dd..eed67ae2dc08 100644
--- a/drivers/scsi/sata_mv.c
+++ b/drivers/scsi/sata_mv.c
@@ -1263,6 +1263,7 @@ static u8 mv_get_crpb_status(struct ata_port *ap)
void __iomem *port_mmio = mv_ap_base(ap);
struct mv_port_priv *pp = ap->priva... |
b142eb6594003d3f82fd552a9b2ad73d774465d2 | Analyze and fix the following issue in the Linux kernel code: [libata] SCSI VPD page 0x83 fixes | Problem Details:
Original patch (and description) by Douglas Gilbert, with minor fixes
and API updates from me.
Changelog:
- make existing libata VPD device identification page (0x83)
supply the ATA serial number in the libata "vendor
specific" designator (from Chris Paulson-Ellis)
- add a "t10 vendor id b... | ```diff
diff --git a/drivers/scsi/libata-scsi.c b/drivers/scsi/libata-scsi.c
index ccedb4536977..3aaa74cbef1d 100644
--- a/drivers/scsi/libata-scsi.c
+++ b/drivers/scsi/libata-scsi.c
@@ -1542,7 +1542,7 @@ void ata_scsi_rbuf_fill(struct ata_scsi_args *args,
* @buflen: Response buffer length.
*
* Returns standard d... |
9e6b48732d53bd986178bca3bce18d2329e4b0ca | Analyze and fix the following issue in the Linux kernel code: Fix spelling in E1000_DISABLE_PACKET_SPLIT Kconfig description | Problem Details:
Signed-off-by: Adrian Bunk <bunk@stusta.de> | ```diff
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index e0b11095b9da..00993e8ba589 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -1914,7 +1914,7 @@ config E1000_DISABLE_PACKET_SPLIT
depends on E1000
help
Say Y here if you want to use the legacy receive path for PCI express
- hadwa... |
d7f2baaadc0e2da3b4dff76494f9cf46d48ad301 | Analyze and fix the following issue in the Linux kernel code: Documentation/dvb/get_dvb_firmware: fix firmware URL | Problem Details:
This patch fixes a wrong URL in Documentation/dvb/get_dvb_firmware.
This patch fixes kernel Bugzilla #4301.
Signed-off-by: Adrian Bunk <bunk@stusta.de> | ```diff
diff --git a/Documentation/dvb/get_dvb_firmware b/Documentation/dvb/get_dvb_firmware
index bb55f49f2745..15fc8fbef67e 100644
--- a/Documentation/dvb/get_dvb_firmware
+++ b/Documentation/dvb/get_dvb_firmware
@@ -246,7 +246,7 @@ sub vp7041 {
}
sub dibusb {
- my $url = "http://www.linuxtv.org/downloads/firmwar... |
43019a56aa99dbf67f32fb7bd04851b1ba63fa58 | Analyze and fix the following issue in the Linux kernel code: Documentation: Update to BUG-HUNTING | Problem Details:
Signed-off-by: Ian McDonald <imcdnzl@gmail.com>
Signed-off-by: Adrian Bunk <bunk@stusta.de> | ```diff
diff --git a/Documentation/BUG-HUNTING b/Documentation/BUG-HUNTING
index ca29242dbc38..65b97e1dbf70 100644
--- a/Documentation/BUG-HUNTING
+++ b/Documentation/BUG-HUNTING
@@ -1,3 +1,56 @@
+Table of contents
+=================
+
+Last updated: 20 December 2005
+
+Contents
+========
+
+- Introduction
+- Devices n... |
80682fa9f70932950c913fd10411c004c4c2e8b0 | Analyze and fix the following issue in the Linux kernel code: Fix "frist", "fisrt", typos | Problem Details:
Signed-off-by: Uwe Zeisberger <Uwe_Zeisberger@digi.com>
Signed-off-by: Adrian Bunk <bunk@stusta.de> | ```diff
diff --git a/drivers/base/platform.c b/drivers/base/platform.c
index 89b268321321..83f5c5984d1a 100644
--- a/drivers/base/platform.c
+++ b/drivers/base/platform.c
@@ -326,7 +326,7 @@ EXPORT_SYMBOL_GPL(platform_device_register);
* platform_device_unregister - unregister a platform-level device
* @pdev: platf... |
7ad4a5d56874b37ad24d89aae2f8d192ba7b1521 | Analyze and fix the following issue in the Linux kernel code: fix rwlock usage example | Problem Details:
This is a trivial patch which fixes a typo on rwlock usage under
Documentation/spinlocks.txt.
Signed-Off-By: Lucas Correia Villa Real <lucasvr@gobolinux.org>
Signed-off-by: Adrian Bunk <bunk@stusta.de> | ```diff
diff --git a/Documentation/spinlocks.txt b/Documentation/spinlocks.txt
index c2122996631e..a661d684768e 100644
--- a/Documentation/spinlocks.txt
+++ b/Documentation/spinlocks.txt
@@ -9,7 +9,7 @@ removed soon. So for any new code dynamic initialization should be used:
static int __init xxx_init(void)
{
... |
4de151d8cd2553e7e89044ab5d72fcad4eb04afb | Analyze and fix the following issue in the Linux kernel code: It's UTF-8 | Problem Details:
Fix some comments to "UTF-8".
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Adrian Bunk <bunk@stusta.de> | ```diff
diff --git a/Documentation/filesystems/isofs.txt b/Documentation/filesystems/isofs.txt
index 424585ff6ea1..758e50401c16 100644
--- a/Documentation/filesystems/isofs.txt
+++ b/Documentation/filesystems/isofs.txt
@@ -9,9 +9,9 @@ when using discs encoded using Microsoft's Joliet extensions.
iocharset=name Chara... |
e0f4ab8a1741193891f096aa63df9ac8672af54c | Analyze and fix the following issue in the Linux kernel code: Revert "V4L/DVB (3543): Fix Makefile to adapt to bt8xx/ conversion" | Problem Details:
This reverts commit 08f1d0b99f4e2203935d86640a7fec5c233b777c
The "bt8xx/ conversion" for drivers/video/ hasn't actually percolated
all the way to this tree, so the Makefile change escaped too soon.
Build breakage noticed by Jeff Garzik <jeff@garzik.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.o... | ```diff
diff --git a/drivers/media/dvb/bt8xx/Makefile b/drivers/media/dvb/bt8xx/Makefile
index 9d197efb481d..d188e4c670b5 100644
--- a/drivers/media/dvb/bt8xx/Makefile
+++ b/drivers/media/dvb/bt8xx/Makefile
@@ -1,3 +1,3 @@
obj-$(CONFIG_DVB_BT8XX) += bt878.o dvb-bt8xx.o dst.o dst_ca.o
-EXTRA_CFLAGS = -Idrivers/media/... |
da956fd6b84f61bc98a18a63cdbd8190ec7b8cd0 | Analyze and fix the following issue in the Linux kernel code: [ARM] 3375/1: S3C2440 - fix osiris machine build | Problem Details:
Patch from Ben Dooks
Fix the build of arch/arm/mach-s3c2410/mach-osiris.c
and fix the warnings from sparse.
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> | ```diff
diff --git a/arch/arm/mach-s3c2410/mach-osiris.c b/arch/arm/mach-s3c2410/mach-osiris.c
index 72083e645e77..ae0787557751 100644
--- a/arch/arm/mach-s3c2410/mach-osiris.c
+++ b/arch/arm/mach-s3c2410/mach-osiris.c
@@ -123,7 +123,7 @@ static int external_map[] = { 2 };
static int chip0_map[] = { 0 };
stati... |
6d4518d76f9612d580f9423cc0c3364a06b69588 | Analyze and fix the following issue in the Linux kernel code: [ARM] 3346/1: Fix udelay() for HZ values different from 100 | Problem Details:
Patch from Peter Teichmann
Currently, if the kernels HZ value is greater than 100, delays with the udelay function are too short. This can cause trouble for instance with the zd1201 usb wlan driver.
This patch suggests a solution that keeps the overhead small and maintains (hopefully) sufficient reso... | ```diff
diff --git a/arch/arm/lib/delay.S b/arch/arm/lib/delay.S
index b3fb475b4120..9183b06c0e2f 100644
--- a/arch/arm/lib/delay.S
+++ b/arch/arm/lib/delay.S
@@ -9,28 +9,32 @@
*/
#include <linux/linkage.h>
#include <asm/assembler.h>
+#include <asm/param.h>
.text
.LC0: .word loops_per_jiffy
+.LC1: .word (21... |
766636cc3630ae3b9827e7b4b1f566572963f1ef | Analyze and fix the following issue in the Linux kernel code: [ARM] 3329/1: S3C24XX - fix time for osiris machine | Problem Details:
Patch from Ben Dooks
Add selection for timer code for the Simtec Osiris
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> | ```diff
diff --git a/arch/arm/mach-s3c2410/time.c b/arch/arm/mach-s3c2410/time.c
index 10a2976aefdd..9d7b799ea4a4 100644
--- a/arch/arm/mach-s3c2410/time.c
+++ b/arch/arm/mach-s3c2410/time.c
@@ -142,6 +142,12 @@ static struct irqaction s3c2410_timer_irq = {
.handler = s3c2410_timer_interrupt,
};
+#define use_tclk1... |
71dccd0f158a8077c92d51f213b55991b7a0e47e | Analyze and fix the following issue in the Linux kernel code: [ARM] Collect Primecell PL01x-based debug implementations together | Problem Details:
Several ARM machine implementations used a PL01x primecell compatible
serial port for debugging purposes, and indepdently implemented the low
level debug macros every time. Provide a common implementation and
convert these implementations to use this version.
Signed-off-by: Russell King <rmk+kernel@a... | ```diff
diff --git a/include/asm-arm/arch-integrator/debug-macro.S b/include/asm-arm/arch-integrator/debug-macro.S
index 031d30941791..85b327c352df 100644
--- a/include/asm-arm/arch-integrator/debug-macro.S
+++ b/include/asm-arm/arch-integrator/debug-macro.S
@@ -11,8 +11,6 @@
*
*/
-#include <linux/amba/serial.h>
-... |
268099e3ccca5a988632ce18abd21d809d632ddc | Analyze and fix the following issue in the Linux kernel code: [ARM] Collect 8250-based debug implementations together | Problem Details:
Several ARM machine implementations used an 8250 compatible port for
debugging purposes, and indepdently implemented the low level debug
macros every time. Provide a common implementation and convert these
implementations to use this version.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> | ```diff
diff --git a/include/asm-arm/arch-cl7500/debug-macro.S b/include/asm-arm/arch-cl7500/debug-macro.S
index a5d489d7955a..9a2b67d24098 100644
--- a/include/asm-arm/arch-cl7500/debug-macro.S
+++ b/include/asm-arm/arch-cl7500/debug-macro.S
@@ -17,15 +17,5 @@
orr \rx, \rx, #0x00000be0
.endm
- .macro senduart... |
22398f57b6372f3150f9ebb4b6d0aa4bf98c5dfb | Analyze and fix the following issue in the Linux kernel code: [ARM] Fix SA1100 debug-macros.S | Problem Details:
This needs asm/hardware.h - include it.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> | ```diff
diff --git a/include/asm-arm/arch-sa1100/debug-macro.S b/include/asm-arm/arch-sa1100/debug-macro.S
index 755fa3453862..267c317a7408 100644
--- a/include/asm-arm/arch-sa1100/debug-macro.S
+++ b/include/asm-arm/arch-sa1100/debug-macro.S
@@ -10,6 +10,7 @@
* published by the Free Software Foundation.
*
*/
+#in... |
f78f10436806660f39440a729acbaf03e3a01023 | Analyze and fix the following issue in the Linux kernel code: [ARM] Remove unnecessary asm/hardware.h includes | Problem Details:
asm/hardware.h is not required for the majority of processor support
files, ioremap support, mm initialisation, acorn IO support, nor
the debug code (which picks up its machine specific includes via
debug-macros.S)
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> | ```diff
diff --git a/arch/arm/kernel/debug.S b/arch/arm/kernel/debug.S
index caaa919ab47a..da280bae3d07 100644
--- a/arch/arm/kernel/debug.S
+++ b/arch/arm/kernel/debug.S
@@ -11,7 +11,6 @@
*/
#include <linux/config.h>
#include <linux/linkage.h>
-#include <asm/hardware.h>
.text
diff --git a/arch/arm/lib/io-ac... |
bfe65704812f82751470106ea50aeb7e7d37cc3f | Analyze and fix the following issue in the Linux kernel code: [ARM] Fix HZ definition for OMAP without 32K timer | Problem Details:
Unfortunately, OMAP platforms without the 32K timer left HZ set to
an empty value. Fix this by making the dependency on OMAP_32K_TIMER
rather than OMAP_32K_TIMER_HZ.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> | ```diff
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 2c63228b4ab6..6e9e8cedd723 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -438,7 +438,7 @@ config HZ
int
default 128 if ARCH_L7200
default 200 if ARCH_EBSA110 || ARCH_S3C2410
- default OMAP_32K_TIMER_HZ if ARCH_OMAP && OMAP_32K_TIMER_HZ != 0
... |
fb1c7762b9b1f3c53daf0e700e977d77a29bcf04 | Analyze and fix the following issue in the Linux kernel code: [ARM] Fix typo in tlbflush.h | Problem Details:
s/CONFIG_MMY/CONFIG_MMU/
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> | ```diff
diff --git a/include/asm-arm/tlbflush.h b/include/asm-arm/tlbflush.h
index d64b180200fa..728992451dd1 100644
--- a/include/asm-arm/tlbflush.h
+++ b/include/asm-arm/tlbflush.h
@@ -16,7 +16,7 @@
#define tlb_flush(tlb) ((void) tlb)
-#else /* CONFIG_MMY */
+#else /* CONFIG_MMU */
#include <asm/glue.h>
``` |
3d781a02313e9f22923ee919d99e1cf72fd1f468 | Analyze and fix the following issue in the Linux kernel code: [PATCH] skfp warning fixes | Problem Details:
drivers/net/skfp/fplustm.c: In function `enable_formac':
drivers/net/skfp/fplustm.c:552: warning: large integer implicitly truncated to unsigned type
drivers/net/skfp/fplustm.c:555: warning: large integer implicitly truncated to unsigned type
These arguments were changed to `const', so the compiler ca... | ```diff
diff --git a/drivers/net/skfp/fplustm.c b/drivers/net/skfp/fplustm.c
index a4b2b6975d6c..0784f558ca9a 100644
--- a/drivers/net/skfp/fplustm.c
+++ b/drivers/net/skfp/fplustm.c
@@ -549,12 +549,12 @@ void formac_tx_restart(struct s_smc *smc)
static void enable_formac(struct s_smc *smc)
{
/* set formac IMSK : 0... |
ac62ef043504d5c754357325cd514553ddabb046 | Analyze and fix the following issue in the Linux kernel code: [PATCH] pcnet32: support boards with multiple phys | Problem Details:
Boards with multiple PHYs were not being handled properly by the pcnet32
driver. This patch by Thomas Bogendoerfer with changes by me will allow
Allied Telesyn 2700FTX and 2701FTX boards to use either the copper or
the fiber interfaces. It has been tested on ia32 and ppc64 hardware.
Philippe Seewer a... | ```diff
diff --git a/drivers/net/pcnet32.c b/drivers/net/pcnet32.c
index 7e900572eaf8..1bc3f5bffb95 100644
--- a/drivers/net/pcnet32.c
+++ b/drivers/net/pcnet32.c
@@ -22,8 +22,8 @@
*************************************************************************/
#define DRV_NAME "pcnet32"
-#define DRV_VERSION "1.31c"
-#d... |
d89e1343959200a578465d50bb36c89733cf66a7 | Analyze and fix the following issue in the Linux kernel code: [PATCH] sky2: whitespace fixes | Problem Details:
Small whitespace fixes.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org> | ```diff
diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c
index 2e29972b8d0b..ffe3aa7e2ab2 100644
--- a/drivers/net/sky2.c
+++ b/drivers/net/sky2.c
@@ -852,7 +852,7 @@ static int sky2_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
if (!netif_running(dev))
return -ENODEV; /* Phy still in reset */
- ... |
c4b1580e8ad1aab13e0d8b97c7af3eebab8791ae | Analyze and fix the following issue in the Linux kernel code: [PATCH] sky2: drop broken wake on lan support | Problem Details:
Remove wake on lan support for now. It doesn't work right, and I
don't have a machine with working suspend/resume to test or fix it.
It will be re-enabled later.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org> | ```diff
diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c
index 3086e52032a8..3a6c796eb70e 100644
--- a/drivers/net/sky2.c
+++ b/drivers/net/sky2.c
@@ -2777,38 +2777,6 @@ static int sky2_set_pauseparam(struct net_device *dev,
return err;
}
-#ifdef CONFIG_PM
-static void sky2_get_wol(struct net_device *dev, stru... |
203babb650d0c99a8be08f479d4a05d420988d89 | Analyze and fix the following issue in the Linux kernel code: [PATCH] skge: formmating and whitespace cleanup | Problem Details:
Reformat some code to make it easier to read. And whitespace
fixes.
Signed-off-by: Stephen Hemminger <sheminger@osdl.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org> | ```diff
diff --git a/drivers/net/skge.c b/drivers/net/skge.c
index 8c674cdecd7b..7f8e8dd0fc6e 100644
--- a/drivers/net/skge.c
+++ b/drivers/net/skge.c
@@ -2177,15 +2177,17 @@ static int skge_up(struct net_device *dev)
memset(skge->mem, 0, skge->mem_size);
- if ((err = skge_ring_alloc(&skge->rx_ring, skge->mem, sk... |
08f1d0b99f4e2203935d86640a7fec5c233b777c | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3543): Fix Makefile to adapt to bt8xx/ conversion | Problem Details:
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/bt8xx/Makefile b/drivers/media/dvb/bt8xx/Makefile
index d188e4c670b5..9d197efb481d 100644
--- a/drivers/media/dvb/bt8xx/Makefile
+++ b/drivers/media/dvb/bt8xx/Makefile
@@ -1,3 +1,3 @@
obj-$(CONFIG_DVB_BT8XX) += bt878.o dvb-bt8xx.o dst.o dst_ca.o
-EXTRA_CFLAGS = -Idrivers/media/... |
f5c08a2ee906381d85a6f0a3ca309fd56cf3b90f | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3528): Kconfig: fix ATSC frontend menu item names by manufacturer | Problem Details:
- Corrected typo for NxtWave NXT200X
- Added "Oren" manufacturer name to menu items for OR51132 and OR51211
- Removed "(pcHDTV HDx000 card)" from Oren frontends menu item names,
This isn't necessary, as these frontends are selected by the card drivers,
build configuration (DVB_BT8XX and VIDEO_CX88_... | ```diff
diff --git a/drivers/media/dvb/frontends/Kconfig b/drivers/media/dvb/frontends/Kconfig
index a1a894d81040..94233168d241 100644
--- a/drivers/media/dvb/frontends/Kconfig
+++ b/drivers/media/dvb/frontends/Kconfig
@@ -161,7 +161,7 @@ comment "ATSC (North American/Korean Terresterial DTV) frontends"
depends on DV... |
02c17224da6182d11cde34d57b27b93aaa7206cf | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3522): Fixed a trouble with other PAL standards | Problem Details:
V4L2_STD_PAL define is not correct. It specifies only 50Hz PAL standards.
This patch fixes saa7113 color config for other PAL video standards.
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/saa7115.c b/drivers/media/video/saa7115.c
index 498d9aaec1e5..b184fd00b4e7 100644
--- a/drivers/media/video/saa7115.c
+++ b/drivers/media/video/saa7115.c
@@ -725,18 +725,14 @@ static void saa7115_set_v4lstd(struct i2c_client *client, v4l2_std_id std)
if (state->ident == V4L2_I... |
67ac9a40f90db57b09f7d98f72d8d0344acefbac | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3503): Whitespace: fix incorrect indentation of curly bracket | Problem Details:
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/saa7134/saa7134-cards.c b/drivers/media/video/saa7134/saa7134-cards.c
index 5e0251a33e8b..3824fba7fb1c 100644
--- a/drivers/media/video/saa7134/saa7134-cards.c
+++ b/drivers/media/video/saa7134/saa7134-cards.c
@@ -536,7 +536,7 @@ struct saa7134_board saa7134_boards[] = {
.rad... |
19478843e4f8af7de9b297876519ee8b98c2f5ad | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3499): Fix a bug when more than MAXBOARDS were plugged on em28xx | Problem Details:
Coverity reported a bug at checking max number of supported boards by
em28xx init code.
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/em28xx/em28xx-video.c b/drivers/media/video/em28xx/em28xx-video.c
index f56ae4852165..78f0f7a706ea 100644
--- a/drivers/media/video/em28xx/em28xx-video.c
+++ b/drivers/media/video/em28xx/em28xx-video.c
@@ -1949,7 +1949,7 @@ static int em28xx_usb_probe(struct usb_interface *inter... |
9f9c907fdc331fc6062d758f46f65cb0d2dd11be | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3449): Cx88 default picture controls values | Problem Details:
This patch fixes default values for some picture controls:
- brightness set to 50% by default (now is 0%)
- hue set to 50% by default (now is 0%)
- sets saturation to datasheet value
- volume set to 0dB (now is -32dB)
and some left small fixes:
- twice offset adding
- balance didn't follow datash... | ```diff
diff --git a/drivers/media/video/cx88/cx88-video.c b/drivers/media/video/cx88/cx88-video.c
index 7bbc81fb43b5..b1892dff0fe8 100644
--- a/drivers/media/video/cx88/cx88-video.c
+++ b/drivers/media/video/cx88/cx88-video.c
@@ -227,7 +227,7 @@ static struct cx88_ctrl cx8800_ctls[] = {
.minimum = 0x00,
... |
49239c35f28e53f280b47efdbccfdf2cbd728993 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3447): Cx88-cards.c: fix values of gpio0 for card CX88_BOARD_PROLINK_PLAYTVPVR | Problem Details:
This patch changes the gpio0 values for the card CX88_BOARD_PROLINK_PLAYTVPVR
to the ones observed using RegSpy from the dscaler project.
Signed-off-by: Matheus Izvekov <mizvekov@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/cx88/cx88-cards.c b/drivers/media/video/cx88/cx88-cards.c
index c8f91b1c2068..c91f30e11f22 100644
--- a/drivers/media/video/cx88/cx88-cards.c
+++ b/drivers/media/video/cx88/cx88-cards.c
@@ -323,19 +323,19 @@ struct cx88_board cx88_boards[] = {
.input = {{
.type ... |
bbad7dc5488a04fadebd7fa8aa051d81c2ae0080 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3437): Fix typo in enum name and use enum in struct dmxdev_filter | Problem Details:
Rename 'enum dmxdevype' to 'enum dmxdev_type' and use this enum instead
of int for the member 'type' of struct dmxdev_filter.
Signed-off-by: Andreas Oberritter <obi@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/dvb/dvb-core/dmxdev.h b/drivers/media/dvb/dvb-core/dmxdev.h
index 5d4d18a00a68..1b3e49bd9aa2 100644
--- a/drivers/media/dvb/dvb-core/dmxdev.h
+++ b/drivers/media/dvb/dvb-core/dmxdev.h
@@ -37,7 +37,7 @@
#include "dvbdev.h"
#include "demux.h"
-enum dmxdevype {
+enum dmxdev_type {
... |
cef4e7af71ec16aba13ae291e41262a8913a56d8 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3423): Fix cx88 error messages on balance change | Problem Details:
There is an error in the cx88 code that causes this message in the syslog when
balance is changed at full volume:
Mar 4 18:35:08 ian2 kernel: cx88[0]: irq pci [0x1] vid*
Mar 4 18:35:39 ian2 last message repeated 348 times
Mar 4 18:36:01 ian2 last message repeated 564 times
... and so on
The attached... | ```diff
diff --git a/drivers/media/video/cx88/cx88.h b/drivers/media/video/cx88/cx88.h
index 21738b664bc9..cfa8668784b4 100644
--- a/drivers/media/video/cx88/cx88.h
+++ b/drivers/media/video/cx88/cx88.h
@@ -63,7 +63,7 @@
/* need "shadow" registers for some write-only ones ... */
#define SHADOW_AUD_VOL_CTL 1... |
efcf55cb5c21d7142aeb1a5a4c14e40960600bd6 | Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3419): This patch fixes Tuner TNF5335 family | Problem Details:
Radio now works.
Tuner now supports both PAL/D and STD/MN models
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> | ```diff
diff --git a/drivers/media/video/tuner-simple.c b/drivers/media/video/tuner-simple.c
index aba0688d7c1c..5d7abed71674 100644
--- a/drivers/media/video/tuner-simple.c
+++ b/drivers/media/video/tuner-simple.c
@@ -364,6 +364,9 @@ static void default_set_radio_freq(struct i2c_client *c, unsigned int freq)
case TU... |
b1bcb362d921f5e46a3bec0c7a73c32abfe74db2 | Analyze and fix the following issue in the Linux kernel code: [MIPS] fix wrong __user usage in _sysn32_rt_sigsuspend | Problem Details:
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org> | ```diff
diff --git a/arch/mips/kernel/signal_n32.c b/arch/mips/kernel/signal_n32.c
index 220e6deb3aa4..477c5334ec1b 100644
--- a/arch/mips/kernel/signal_n32.c
+++ b/arch/mips/kernel/signal_n32.c
@@ -87,7 +87,8 @@ save_static_function(sysn32_rt_sigsuspend);
__attribute_used__ noinline static int
_sysn32_rt_sigsuspend(... |
06b42aa94b65806b4f8c5fc893ef97a2f491fb32 | Analyze and fix the following issue in the Linux kernel code: [CRYPTO] tcrypt: Fix key alignment | Problem Details:
Force 32-bit alignment on keys in tcrypt test vectors. Also rearrange the
structure to prevent unnecessary padding.
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> | ```diff
diff --git a/crypto/tcrypt.h b/crypto/tcrypt.h
index 733d07ed75e9..1f683ba794ee 100644
--- a/crypto/tcrypt.h
+++ b/crypto/tcrypt.h
@@ -26,37 +26,38 @@
#define MAX_IVLEN 32
struct hash_testvec {
+ /* only used with keyed hash algorithms */
+ char key[128] __attribute__ ((__aligned__(4)));
char plaintext[1... |
3400112794724d9bdc3de6e1ce1475b726e6ca7d | Analyze and fix the following issue in the Linux kernel code: [DECNET]: net/decnet/dn_route.c: fix inconsequent NULL checking | Problem Details:
The Coverity checker noted this inconsequent NULL checking in
dnrt_drop().
Since all callers ensure that NULL isn't passed, we can simply remove
the check.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/decnet/dn_route.c b/net/decnet/dn_route.c
index d7037fe3cafe..e172cf98d7fc 100644
--- a/net/decnet/dn_route.c
+++ b/net/decnet/dn_route.c
@@ -149,8 +149,7 @@ static inline void dnrt_free(struct dn_route *rt)
static inline void dnrt_drop(struct dn_route *rt)
{
- if (rt)
- dst_release(&rt->u... |
8b42ec39264a1e7a508f5d80169a5fb137bcc833 | Analyze and fix the following issue in the Linux kernel code: [BRIDGE]: netfilter VLAN macro cleanup | Problem Details:
Fix the VLAN macros in bridge netfilter code. Macros should
not depend on magic variables.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/bridge/br_netfilter.c b/net/bridge/br_netfilter.c
index ea34aa505af2..6fc9ecc4eb39 100644
--- a/net/bridge/br_netfilter.c
+++ b/net/bridge/br_netfilter.c
@@ -61,15 +61,25 @@ static int brnf_filter_vlan_tagged = 1;
#define brnf_filter_vlan_tagged 1
#endif
-#define IS_VLAN_IP (skb->protocol =... |
789bc3e5b66d3664f651f6c10a188c8e3e025037 | Analyze and fix the following issue in the Linux kernel code: [BRIDGE]: netfilter whitespace | Problem Details:
Run br_netfilter through Lindent to fix whitespace.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/bridge/br_netfilter.c b/net/bridge/br_netfilter.c
index 70a395baaa01..cf18d0235ccb 100644
--- a/net/bridge/br_netfilter.c
+++ b/net/bridge/br_netfilter.c
@@ -136,7 +136,7 @@ static void __br_dnat_complain(void)
if (jiffies - last_complaint >= 5 * HZ) {
printk(KERN_WARNING "Performing cro... |
9ebddc1aa386f257125a569b41f90418b63b4d5f | Analyze and fix the following issue in the Linux kernel code: [BRIDGE] br_netfilter: Warning fixes. | Problem Details:
net/bridge/br_netfilter.c: In function `br_nf_pre_routing':
net/bridge/br_netfilter.c:427: warning: unused variable `vhdr'
net/bridge/br_netfilter.c:445: warning: unused variable `vhdr'
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/bridge/br_netfilter.c b/net/bridge/br_netfilter.c
index 6787bc5197f7..70a395baaa01 100644
--- a/net/bridge/br_netfilter.c
+++ b/net/bridge/br_netfilter.c
@@ -424,7 +424,6 @@ static unsigned int br_nf_pre_routing(unsigned int hook, struct sk_buff **pskb,
goto out;
if (skb->protocol == _... |
74ca4e5acd7d09a5133bb75043c2c474347f2c7e | Analyze and fix the following issue in the Linux kernel code: [BRIDGE] ebtables: Build fix. | Problem Details:
net/bridge/netfilter/ebtables.c:1481: warning: initialization makes pointer from integer without a cast
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c
index 4b178b4a2a95..997953367204 100644
--- a/net/bridge/netfilter/ebtables.c
+++ b/net/bridge/netfilter/ebtables.c
@@ -1477,8 +1477,14 @@ static int do_ebt_get_ctl(struct sock *sk, int cmd, void __user *user, int *len)
}
static ... |
dbeff12b4d2fd5943f6f03f7ed9a3ca486577bb0 | Analyze and fix the following issue in the Linux kernel code: [INET]: Fix typo in Arnaldo's connection sock compat fixups. | Problem Details:
"struct inet_csk" --> "struct inet_connection_sock" :-)
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c
index 9f6b44ca28a8..9a01bb81f8bf 100644
--- a/net/ipv4/inet_connection_sock.c
+++ b/net/ipv4/inet_connection_sock.c
@@ -672,7 +672,7 @@ EXPORT_SYMBOL_GPL(inet_csk_ctl_sock_create);
int inet_csk_compat_getsockopt(struct sock *sk, int... |
c841aa030437bdf1b6fb22d93eb760e35380a4ed | Analyze and fix the following issue in the Linux kernel code: [SECURITY] getpeersec: Fix build breakage | Problem Details:
A recent changeset removes dummy_socket_getpeersec, replacing it with
two new functions, but still references the removed function in the
security_fixup_ops table, fix it by doing the replacement operation in
the fixup table too.
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
Signed-off-b... | ```diff
diff --git a/security/dummy.c b/security/dummy.c
index a326d6e0b6d7..a678f094b72d 100644
--- a/security/dummy.c
+++ b/security/dummy.c
@@ -1008,7 +1008,8 @@ void security_fixup_ops (struct security_operations *ops)
set_to_dummy_if_null(ops, socket_getsockopt);
set_to_dummy_if_null(ops, socket_shutdown);
s... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.