id
stringlengths
40
40
instruction
stringlengths
68
308
input
stringlengths
17
33.4k
output
stringlengths
100
30k
4a471b7ddfe76e39c1633d5a23a687f4b5fc0d8d
Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Small clean up and fixes
Problem Details: Modules: HDA Codec driver,HDA generic driver - Common labels for input pins - Fix and clean up of Realtek codec parsers Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c index bd375f895ec0..4a6dd97deba6 100644 --- a/sound/pci/hda/hda_codec.c +++ b/sound/pci/hda/hda_codec.c @@ -2051,6 +2051,12 @@ int snd_hda_parse_pin_def_config(struct hda_codec *codec, struct auto_pin_cfg *c return 0; } +/* labels for input...
156b2aa3bef17c964006c6448aadd440781d7e7d
Analyze and fix the following issue in the Linux kernel code: [ALSA] ens1371: fix compilation without SUPPORT_JOYSTICK
Problem Details: Modules: ENS1370/1+ driver Move the spdif and lineio parameters around so that they are compiled even when SUPPORT_JOYSTICK isn't set. Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
```diff diff --git a/sound/pci/ens1370.c b/sound/pci/ens1370.c index 856f7c63d32f..55aaf110331a 100644 --- a/sound/pci/ens1370.c +++ b/sound/pci/ens1370.c @@ -86,12 +86,14 @@ static int enable[SNDRV_CARDS] = SNDRV_DEFAULT_ENABLE_PNP; /* Enable switches */ #ifdef SUPPORT_JOYSTICK #ifdef CHIP1371 static int joystick_p...
a3bcba384c2f2448ad204ea52baa15f1227d0d40
Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix Oops with ALC260 auto-probe
Problem Details: Modules: HDA Codec driver - Fix Oops with auto-probing of ALC260 with digital I/O - Fix a typo Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 63aeddb731d9..2a6a4804cb92 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -2678,6 +2678,9 @@ static struct hda_pcm_stream alc260_pcm_analog_capture = { .channels_max = 2, }; +#define alc260_p...
c5f2ea08fbd8911e2c975094780d2b16e65f27e0
Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix ALC codec probing
Problem Details: Modules: HDA Codec driver - Fix ALC882 BIOS auto-probe - Fix ALC262 basic model - Add assert for debugging Oops Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index a98c0e4da0ac..63aeddb731d9 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -1259,6 +1259,8 @@ static int alc_build_pcms(struct hda_codec *codec) codec->num_pcms = 1; codec->pcm_info = info; +...
031c95d4338127a9599fcb7d449f4aa6f086786b
Analyze and fix the following issue in the Linux kernel code: [ALSA] ac97 - Small fix for ALC65x codec
Problem Details: Modules: AC97 Codec Small fix for ALC65x codec, sync with Realtek's driver codes: - Rename 'IEC958 Playback Route' to 'IEC958 Playback Source' so that mixer can handle it properly Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/ac97/ac97_codec.c b/sound/pci/ac97/ac97_codec.c index 17c3ddac35cc..33d7a1fc2f9f 100644 --- a/sound/pci/ac97/ac97_codec.c +++ b/sound/pci/ac97/ac97_codec.c @@ -2411,6 +2411,8 @@ static int tune_alc_jack(struct snd_ac97 *ac97) } snd_ac97_update_bits(ac97, 0x7a, 0x20, 0x20); /* select j...
bd01e7bc9e975d7d3d6fe4eb2f2cf7ae83041c49
Analyze and fix the following issue in the Linux kernel code: [ALSA] emu10k1 - Fix missing declarations
Problem Details: Modules: EMU10K1/EMU10K2 driver sound/pci/emu10k1/emufx.c: In function 'snd_emu10k1_efx_alloc_pm_buffer': sound/pci/emu10k1/emufx.c:2402: error: implicit declaration of function 'vmalloc' sound/pci/emu10k1/emufx.c:2402: warning: assignment makes pointer from integer without a cast sound/pci/emu10k1/em...
```diff diff --git a/sound/pci/emu10k1/emufx.c b/sound/pci/emu10k1/emufx.c index cd356b04078b..1a903390ad6d 100644 --- a/sound/pci/emu10k1/emufx.c +++ b/sound/pci/emu10k1/emufx.c @@ -29,6 +29,7 @@ #include <linux/pci.h> #include <linux/delay.h> #include <linux/slab.h> +#include <linux/vmalloc.h> #include <linux/ini...
19b99fbaed2e2971b756311435c67e84431d8515
Analyze and fix the following issue in the Linux kernel code: [ALSA] emu10k1: Partial support for Creative emu1212m
Problem Details: Modules: EMU10K1/EMU10K2 driver Distorted sound now comes from the Audio Out socket. Still more work to do. Signed-off-by: James Courtier-Dutton <James@superbug.co.uk>
```diff diff --git a/include/sound/emu10k1.h b/include/sound/emu10k1.h index 3d0496cc1090..0d6e68c43e63 100644 --- a/include/sound/emu10k1.h +++ b/include/sound/emu10k1.h @@ -1061,6 +1061,7 @@ struct snd_emu_chip_details { unsigned char spdif_bug; /* Has Spdif phasing bug */ unsigned char ac97_chip; /* Has an...
9d70d91c4663d580bd18317dac3c7dc3bee79480
Analyze and fix the following issue in the Linux kernel code: [ALSA] ad1848 - Fix compilation without CONFIG_PM
Problem Details: Modules: AD1848 driver Fix compilation without CONFIG_PM. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/isa/ad1848/ad1848_lib.c b/sound/isa/ad1848/ad1848_lib.c index 83764c941533..b78530d7ea90 100644 --- a/sound/isa/ad1848/ad1848_lib.c +++ b/sound/isa/ad1848/ad1848_lib.c @@ -932,8 +932,10 @@ int snd_ad1848_create(struct snd_card *card, return err; } +#ifdef CONFIG_PM chip->suspend = sn...
403d19446bd0cabee70110415d2f3bc466f46448
Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - update sigmatel support and bug fixes
Problem Details: Modules: HDA Codec driver - Explictly set pin control as input for all input pins - Fix bug in 922x mixer (no mute on adc0vol) - Remove broken ch_mode control - Add support for jack retasking mixer controls to use rear line and mic as surround outputs - Add board tables to support autodetect and pin...
```diff diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c index c8c539cb4a8f..78662d3539e2 100644 --- a/sound/pci/hda/patch_sigmatel.c +++ b/sound/pci/hda/patch_sigmatel.c @@ -4,7 +4,7 @@ * HD audio interface patch for SigmaTel STAC92xx * * Copyright (c) 2005 Embedded Alley Solutions, I...
954fa19ab7a14c3f54044780a90cd6a95149f90b
Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-intel - Fix HDA probe_mask default
Problem Details: Modules: HDA Intel driver The probe_mask module parameter comment notes that the intended default is -1. Fix it to be so, otherwise all codecs are skipped and init fails. Signed-off-by: Matt Porter <mporter@embeddedalley.com> Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 8a0a0a7d5d49..a983deba4025 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -52,7 +52,7 @@ static int index = SNDRV_DEFAULT_IDX1; static char *id = SNDRV_DEFAULT_STR1; static char *model; static int position_fix...
f8c7c7b8dd2828b42c1230c6b0235e7d1dcf57e5
Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix surrounds on 3stack mode of AD1988
Problem Details: Modules: HDA Codec driver Fixed the swapped surround/CLFE on 3stack mode of AD1988. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/hda/patch_analog.c b/sound/pci/hda/patch_analog.c index fabcbcf77a10..fc144155f7a6 100644 --- a/sound/pci/hda/patch_analog.c +++ b/sound/pci/hda/patch_analog.c @@ -911,7 +911,7 @@ static int patch_ad1981(struct hda_codec *codec) * * DAC assignment * 6stack - front/surr/CLFE/side/o...
d32410b1095cf93e8e31f8919de46f496d7b3ce0
Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix/enhance AD1988 support
Problem Details: Modules: HDA Codec driver Fix/enhance AD1988 support code. - Fix for h/w bug of AD1988A rev 2 - The BIOS auto-configuration is added and used as fallback Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/hda/patch_analog.c b/sound/pci/hda/patch_analog.c index 3799d8a1afae..fabcbcf77a10 100644 --- a/sound/pci/hda/patch_analog.c +++ b/sound/pci/hda/patch_analog.c @@ -1,5 +1,5 @@ /* - * HD audio interface patch for AD1981HD, AD1983, AD1986A + * HD audio interface patch for AD1981HD, AD1983,...
b2ec642362eef10f660e2b857dda12e2d61e0198
Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix channel mode helper
Problem Details: Modules: HDA Codec driver Fix the channel mode helper (for put callback). Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c index 402ce00c6a13..5ead2a3d05ad 100644 --- a/sound/pci/hda/hda_codec.c +++ b/sound/pci/hda/hda_codec.c @@ -1771,7 +1771,7 @@ int snd_hda_ch_mode_put(struct hda_codec *codec, struct snd_ctl_elem_value *ucon mode = ucontrol->value.enumerated....
5014f193166d14e47525a34d65a1c7d77b0f6f38
Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix auto-probe of ALC880
Problem Details: Modules: HDA Codec driver This patch is to fix the problem of calculating the nid incorrectly when auto-probe for ALC880. The problem to be fixed often behaves with such words when using dmesg, 'num_steps = 0 for NID=0x8' when auto-probe for ALC880. The patch contains: - alsa-kernel/pci/hda/patch_rea...
```diff diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 77c5f95ea55b..c5fb141f6222 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -1760,7 +1760,7 @@ static int alc880_auto_fill_dac_nids(struct alc_spec *spec, const struct auto_pi nid = cfg->line_out...
9a1a2a1d4eeda00df45ccf7a3a375d1887f1efb3
Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix a missing include
Problem Details: Modules: ALSA Core Fix missing include <linux/device.h> Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/core/sound.c b/sound/core/sound.c index 5febd0545d7d..3b91f180f687 100644 --- a/sound/core/sound.c +++ b/sound/core/sound.c @@ -23,6 +23,7 @@ #include <linux/init.h> #include <linux/slab.h> #include <linux/time.h> +#include <linux/device.h> #include <linux/moduleparam.h> #include <sound/...
6a81dbf23df5400e4f8182e9f2eb52fabcf42015
Analyze and fix the following issue in the Linux kernel code: [ALSA] ice1712 - Fix Front Digital Input of Terratec DMX 6Fire
Problem Details: Modules: ICE1712 driver Fix the inverted switch of 'Front Digital Input' of Terratec DMX 6Fire. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/ice1712/ews.c b/sound/pci/ice1712/ews.c index 2127d57da190..2c529e741384 100644 --- a/sound/pci/ice1712/ews.c +++ b/sound/pci/ice1712/ews.c @@ -917,7 +917,7 @@ static struct snd_kcontrol_new snd_ice1712_6fire_controls[] __devinitdata = { .get = snd_ice1712_6fire_select_input_get, .p...
1f14a657d87aa0e1a6c08c2e31588fbca34a8844
Analyze and fix the following issue in the Linux kernel code: [ALSA] usb-audio: fix Edirol UA-20 support
Problem Details: Modules: USB generic driver Somebody at Edirol fucked up and released a new revision of the UA-20 without class-specific descriptors, so now we have to hard-code the sample format. Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
```diff diff --git a/sound/usb/usbquirks.h b/sound/usb/usbquirks.h index 0e0575425797..6190ada00e38 100644 --- a/sound/usb/usbquirks.h +++ b/sound/usb/usbquirks.h @@ -664,17 +664,51 @@ YAMAHA_DEVICE(0x7010, "UB99"), .ifnum = QUIRK_ANY_INTERFACE, .type = QUIRK_COMPOSITE, .data = (const struct snd_usb_audio_quir...
2e5b9567f7444673a93cbacdcbeb3feacdb4914f
Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix AD1988 support
Problem Details: Modules: HDA Codec driver Fix AD1988 support. As default, 6stack model is used. Still no auto-BIOS setup is implemented. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/hda/patch_analog.c b/sound/pci/hda/patch_analog.c index 25116a883ca6..3799d8a1afae 100644 --- a/sound/pci/hda/patch_analog.c +++ b/sound/pci/hda/patch_analog.c @@ -50,6 +50,7 @@ struct ad198x_spec { /* capture source */ const struct hda_input_mux *input_mux; + hda_nid_t *capsrc_nids...
54d174031576a2855c49611d83d4946bde81b504
Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix connection list parsing
Problem Details: Modules: HDA Codec driver,HDA generic driver - Fix connection list parsing (with ranged flag). - Increase the max number of connections - Introduce widget capabilities cache - Power up/down widgets at init, suspend and resume Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c index 7f4e19951bae..402ce00c6a13 100644 --- a/sound/pci/hda/hda_codec.c +++ b/sound/pci/hda/hda_codec.c @@ -155,8 +155,9 @@ int snd_hda_get_connections(struct hda_codec *codec, hda_nid_t nid, hda_nid_t *conn_list, int max_conns) { uns...
0ef797c5ca8a73853c827cf495caed44676cfe17
Analyze and fix the following issue in the Linux kernel code: [ALSA] adjust documentation for higher card limit
Problem Details: Modules: Documentation Fix all places in the docs where the card number limit is mentioned. Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
```diff diff --git a/Documentation/sound/alsa/ALSA-Configuration.txt b/Documentation/sound/alsa/ALSA-Configuration.txt index 9a58ed9e6952..c30fd30a19e8 100644 --- a/Documentation/sound/alsa/ALSA-Configuration.txt +++ b/Documentation/sound/alsa/ALSA-Configuration.txt @@ -105,7 +105,7 @@ Prior to version 0.9.0rc4 options...
a2c855bbd76e7044c54a9d84ae46f6eead1b8f89
Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix a compile warning
Problem Details: Modules: CS4231 driver Fix a compile warning (unused variable). Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/isa/cs423x/cs4231_lib.c b/sound/isa/cs423x/cs4231_lib.c index 05d0d4092ded..eab7eb59b5f7 100644 --- a/sound/isa/cs423x/cs4231_lib.c +++ b/sound/isa/cs423x/cs4231_lib.c @@ -1306,7 +1306,7 @@ static void snd_cs4231_resume(struct snd_cs4231 *chip) { int reg; unsigned long flags; - int timeo...
b32425ac93370e1ba5556110e662f896b2e143b3
Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix possible races in timer callbacks
Problem Details: Fix possible races in timer callbacks. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/core/timer.c b/sound/core/timer.c index 74637cef6d2c..6aad411dd7b8 100644 --- a/sound/core/timer.c +++ b/sound/core/timer.c @@ -662,12 +662,13 @@ void snd_timer_interrupt(struct snd_timer * timer, unsigned long ticks_left) struct snd_timer_instance *ti, *ts; unsigned long resolution, tick...
fa55f837bb1bfc3d9ac9988d6f5450a603fa079a
Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix resume of cs4231
Problem Details: Modules: CS4231 driver Use mce_down() again in the resume callback. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/isa/cs423x/cs4231_lib.c b/sound/isa/cs423x/cs4231_lib.c index ced22fd73497..582cc751d547 100644 --- a/sound/isa/cs423x/cs4231_lib.c +++ b/sound/isa/cs423x/cs4231_lib.c @@ -1320,7 +1320,7 @@ static void snd_cs4231_resume(struct snd_cs4231 *chip) } } spin_unlock_irqrestore(&chip->reg_loc...
2b3f558727244efb6edb0866952331f537da13a4
Analyze and fix the following issue in the Linux kernel code: [ALSA] Use platform_device
Problem Details: Modules: SA11xx UDA1341 driver Rewrite the probe/remove with platform_device. Fix PM support, too. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/arm/sa11xx-uda1341.c b/sound/arm/sa11xx-uda1341.c index 785726e627d0..3c342c1a7c80 100644 --- a/sound/arm/sa11xx-uda1341.c +++ b/sound/arm/sa11xx-uda1341.c @@ -21,7 +21,7 @@ * merged HAL layer (patches from Brian) */ -/* $Id: sa11xx-uda1341.c,v 1.25 2005/11/...
792a6c51875c9d3b4a7b9af553b7fd18e8d84684
Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix PM support
Problem Details: Modules: ARM AACI PL041 driver,ARM PXA2XX driver Fix PM support of aaci and pxa2xx drivers. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/arm/aaci.c b/sound/arm/aaci.c index 691f6dd81c30..5e9a81ab990b 100644 --- a/sound/arm/aaci.c +++ b/sound/arm/aaci.c @@ -635,19 +635,14 @@ static struct snd_pcm_ops aaci_playback_ops = { static int aaci_do_suspend(struct snd_card *card, unsigned int state) { struct aaci *aaci = card->priva...
e4f163d96080dda40fd02df725f3672d035e4c5a
Analyze and fix the following issue in the Linux kernel code: [ALSA] pdaudiocf - Fix PM support
Problem Details: Modules: PDAudioCF driver Fix the PM support on pdaudiocf driver. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pcmcia/pdaudiocf/pdaudiocf.c b/sound/pcmcia/pdaudiocf/pdaudiocf.c index 0ba335d045f8..a7cd2d4df757 100644 --- a/sound/pcmcia/pdaudiocf/pdaudiocf.c +++ b/sound/pcmcia/pdaudiocf/pdaudiocf.c @@ -217,8 +217,6 @@ static int snd_pdacf_assign_resources(struct snd_pdacf *pdacf, int port, int irq if...
7bb35e20e8a00cf9e3f4e9df0457eee9f312a637
Analyze and fix the following issue in the Linux kernel code: [ALSA] cs4231 - Fix PM support
Problem Details: Modules: CS4231 driver Fix PM support. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/isa/cs423x/cs4231_lib.c b/sound/isa/cs423x/cs4231_lib.c index ab9075f51237..ced22fd73497 100644 --- a/sound/isa/cs423x/cs4231_lib.c +++ b/sound/isa/cs423x/cs4231_lib.c @@ -1294,8 +1294,7 @@ static void snd_cs4231_suspend(struct snd_cs4231 *chip) int reg; unsigned long flags; - if (chip...
fe8be10786c040bce53c18048d75b1b23aec64ae
Analyze and fix the following issue in the Linux kernel code: [ALSA] ens137x - Fix and ADD PM support
Problem Details: Modules: ENS1370/1+ driver Fix PM support on ens1371 driver. Add PM support on ens1370 (together with AK4531), too. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/ens1370.c b/sound/pci/ens1370.c index 2cc0f83a0fde..ff86fabc98c3 100644 --- a/sound/pci/ens1370.c +++ b/sound/pci/ens1370.c @@ -2034,40 +2034,45 @@ static void snd_ensoniq_chip_init(struct ensoniq *ensoniq) } #ifdef CONFIG_PM -static int snd_ensoniq_suspend(struct snd_card *card, pm_m...
3fcf7d2cd8e0ebce10e4bf89da175ff9bd6aa2da
Analyze and fix the following issue in the Linux kernel code: [ALSA] nm256-intel - Fix PM support
Problem Details: Modules: NM256 driver Fix PM support on NM256 driver. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/nm256/nm256.c b/sound/pci/nm256/nm256.c index 99ec1c17049b..0d0ff54f0fc6 100644 --- a/sound/pci/nm256/nm256.c +++ b/sound/pci/nm256/nm256.c @@ -1308,24 +1308,29 @@ snd_nm256_peek_for_sig(struct nm256 *chip) * APM event handler, so the card is properly reinitialized after a power * eve...
421a12520d4ed4a0c96640fb672ef24ad8019beb
Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-intel - Fix PM support
Problem Details: Modules: HDA Intel driver Fix PM support on HDA-Intel driver. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index abdbd96d4c06..3945c44440cf 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -1326,28 +1326,33 @@ static int __devinit azx_init_stream(struct azx *chip) /* * power management */ -static int azx_suspend(struct s...
bf53c3b3f368cdc2aa9a59f220337ede854f507d
Analyze and fix the following issue in the Linux kernel code: [ALSA] ali5451 - Fix PM support
Problem Details: Modules: ALI5451 driver Fix PM support on ALI5451 driver. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/ali5451/ali5451.c b/sound/pci/ali5451/ali5451.c index 2538cda2521d..bc4d1ef08efa 100644 --- a/sound/pci/ali5451/ali5451.c +++ b/sound/pci/ali5451/ali5451.c @@ -1991,9 +1991,10 @@ static int __devinit snd_ali_mixer(struct snd_ali * codec) } #ifdef CONFIG_PM -static int ali_suspend(stru...
57feb83507d598de04e986cfa463acda9f2a67a8
Analyze and fix the following issue in the Linux kernel code: [ALSA] via82xx - Fix PM support
Problem Details: Modules: VIA82xx driver,VIA82xx-modem driver Fix PM support on VIA82xx and modem drivers. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/via82xx.c b/sound/pci/via82xx.c index c87000130dd2..ce4985f8078e 100644 --- a/sound/pci/via82xx.c +++ b/sound/pci/via82xx.c @@ -2126,14 +2126,15 @@ static int snd_via82xx_chip_init(struct via82xx *chip) /* * power management */ -static int snd_via82xx_suspend(struct snd_card *card, p...
0e2364a7013688c06d1a9454a2c20567027f6a6e
Analyze and fix the following issue in the Linux kernel code: [ALSA] maestro3 - Fix PM support
Problem Details: Modules: Maestro3 driver Fix PM support on maestro3 driver. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/maestro3.c b/sound/pci/maestro3.c index 9878595abe34..d3ef0cc6c4f9 100644 --- a/sound/pci/maestro3.c +++ b/sound/pci/maestro3.c @@ -2546,14 +2546,16 @@ static int snd_m3_free(struct snd_m3 *chip) * APM support */ #ifdef CONFIG_PM -static int m3_suspend(struct snd_card *card, pm_messa...
5809c6c41ae95ce3f45ad14d31503deb1fa8268a
Analyze and fix the following issue in the Linux kernel code: [ALSA] intel8x0 - Fix PM support
Problem Details: Modules: Intel8x0 driver,Intel8x0-modem driver Fix PM support on Intel8x0 and modem drivers. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/intel8x0.c b/sound/pci/intel8x0.c index 3ea90f1e22e5..c5c4ec64a156 100644 --- a/sound/pci/intel8x0.c +++ b/sound/pci/intel8x0.c @@ -2396,11 +2396,13 @@ static int snd_intel8x0_free(struct intel8x0 *chip) /* * power management */ -static int intel8x0_suspend(struct snd_card *card, pm_...
ded462356886e5f80f6a20b227f7e5cf7cfc5159
Analyze and fix the following issue in the Linux kernel code: [ALSA] ymfpci - Fix PM support
Problem Details: Modules: YMFPCI driver Fix PM support on YMFPCI driver. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/include/sound/ymfpci.h b/include/sound/ymfpci.h index ec790a9c496f..d567bfdbf513 100644 --- a/include/sound/ymfpci.h +++ b/include/sound/ymfpci.h @@ -369,6 +369,9 @@ int snd_ymfpci_create(struct snd_card *card, struct snd_ymfpci ** rcodec); void snd_ymfpci_free_gameport(struct snd_ymfpci ...
fb0700b4debbf45fb0465b40188bdc5396947bda
Analyze and fix the following issue in the Linux kernel code: [ALSA] trident - Fix PM support
Problem Details: Modules: Trident driver Fix PM support on Trident driver. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/include/sound/trident.h b/include/sound/trident.h index 2c54569fc606..9752243241e5 100644 --- a/include/sound/trident.h +++ b/include/sound/trident.h @@ -452,6 +452,8 @@ void snd_trident_free_voice(struct snd_trident * trident, struct snd_trident_voi void snd_trident_start_voice(struct snd_trident...
cb28e45ba2aa42393596a364d4f947027db8a1b5
Analyze and fix the following issue in the Linux kernel code: [ALSA] cs46xx - Fix PM support
Problem Details: Modules: CS46xx driver Fix PM support on CS46xx driver. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/include/sound/cs46xx.h b/include/sound/cs46xx.h index b33ca2a36300..199b5098ff7e 100644 --- a/include/sound/cs46xx.h +++ b/include/sound/cs46xx.h @@ -1728,6 +1728,8 @@ int snd_cs46xx_create(struct snd_card *card, struct pci_dev *pci, int external_amp, int thinkpad, struct...
1d4b822be64b119b47c172aaac7ee76949470e28
Analyze and fix the following issue in the Linux kernel code: [ALSA] es1968 - Fix PM support
Problem Details: Modules: ES1968 driver Fix PM support on ES1968 driver. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/es1968.c b/sound/pci/es1968.c index 021862d28f2b..240cf2b42054 100644 --- a/sound/pci/es1968.c +++ b/sound/pci/es1968.c @@ -2378,33 +2378,38 @@ static void snd_es1968_start_irq(struct es1968 *chip) /* * PM support */ -static int es1968_suspend(struct snd_card *card, pm_message_t stat...
b34a580ec5b2eb7d3a7645552821e9dadb42bdab
Analyze and fix the following issue in the Linux kernel code: [ALSA] es1938 - Fix PM support
Problem Details: Modules: ES1938 driver Fix PM support on ES1938 driver. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/es1938.c b/sound/pci/es1938.c index 577877dad2eb..0d556b09ad04 100644 --- a/sound/pci/es1938.c +++ b/sound/pci/es1938.c @@ -1398,11 +1398,13 @@ static unsigned char saved_regs[SAVED_REG_SIZE+1] = { }; -static int es1938_suspend(struct snd_card *card, pm_message_t state) +static int e...
38c0a158ee23027e6a4fe47311e05d9c34c94da4
Analyze and fix the following issue in the Linux kernel code: [ALSA] cs4281 - Fix PM support
Problem Details: Modules: CS4281 driver Fix PM support on CS4281 driver. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/cs4281.c b/sound/pci/cs4281.c index 116cdc1c5528..4f65ec56bf35 100644 --- a/sound/pci/cs4281.c +++ b/sound/pci/cs4281.c @@ -1339,10 +1339,6 @@ static int snd_cs4281_dev_free(struct snd_device *device) } static int snd_cs4281_chip_init(struct cs4281 *chip); /* defined below */ -#ifdef ...
92304cc7ecfc87d8336696ab5fe6a1c0eec2ff00
Analyze and fix the following issue in the Linux kernel code: [ALSA] atiixp - Fix PM support
Problem Details: Modules: ATIIXP driver,ATIIXP-modem driver Fix PM support on ATIIXP and modem drivers. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/atiixp.c b/sound/pci/atiixp.c index 5ead66610ed7..a039284c7c54 100644 --- a/sound/pci/atiixp.c +++ b/sound/pci/atiixp.c @@ -1415,11 +1415,13 @@ static int __devinit snd_atiixp_mixer_new(struct atiixp *chip, int clock, /* * power management */ -static int snd_atiixp_suspend(struct snd...
0ed1cad172176a4595f82e8cd9055938ad54bd4b
Analyze and fix the following issue in the Linux kernel code: [ALSA] vx-driver - Fix PM support
Problem Details: Fix PM support on VX drivers (vxpocket and vx222). Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/include/sound/vx_core.h b/include/sound/vx_core.h index 0a85c37d1bc7..5fd6f3305e0d 100644 --- a/include/sound/vx_core.h +++ b/include/sound/vx_core.h @@ -346,6 +346,12 @@ void vx_set_internal_clock(struct vx_core *chip, unsigned int freq); int vx_change_frequency(struct vx_core *chip); +/* + *...
8d88bc3d361bdd81a214eb9c5d06b291d06c603a
Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix assignment of speaker pin
Problem Details: Modules: HDA Codec driver,HDA generic driver Fix the auto-assignment of speaker pin. Handle it independently from line-out pins. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c index cfd50b56187b..2e9f5877386e 100644 --- a/sound/pci/hda/hda_codec.c +++ b/sound/pci/hda/hda_codec.c @@ -1889,7 +1889,6 @@ int snd_hda_parse_pin_def_config(struct hda_codec *codec, struct auto_pin_cfg *c loc = get_defcfg_location(def_conf)...
a2a20939b1cc82222eb67a4631009338791f1acd
Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix a typo
Problem Details: Modules: HDA Codec driver Fix a typo in hda_codec.h. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/hda/hda_codec.h b/sound/pci/hda/hda_codec.h index b0123adc569c..58b9949aca46 100644 --- a/sound/pci/hda/hda_codec.h +++ b/sound/pci/hda/hda_codec.h @@ -98,7 +98,7 @@ enum { #define AC_VERB_SET_UNSOLICITED_ENABLE 0x708 #define AC_VERB_SET_PIN_SENSE 0x709 #define AC_VERB_SET_BEEP_CONT...
10e4097fb47b57d095204d3fad10b25e3b4d42a3
Analyze and fix the following issue in the Linux kernel code: [ALSA] [Trivial] Fix ac97_quirk option in document
Problem Details: Modules: Documentation Fix a wrong option value for ac97_quirk option in the document. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/Documentation/sound/alsa/ALSA-Configuration.txt b/Documentation/sound/alsa/ALSA-Configuration.txt index 23d1870d522f..84068baf587b 100644 --- a/Documentation/sound/alsa/ALSA-Configuration.txt +++ b/Documentation/sound/alsa/ALSA-Configuration.txt @@ -1481,7 +1481,7 @@ the proper value with this opti...
cb432379eff40d5656ca9f24afc435b4df353d13
Analyze and fix the following issue in the Linux kernel code: [ALSA] usx2y - Code clean up
Problem Details: Modules: USB USX2Y Clean up snd-usb-usx2y driver code: - Avoid unnecessary cast - Fix spaces/indents - Use kzalloc() - Remove weird debug prints Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/usb/usx2y/usX2Yhwdep.c b/sound/usb/usx2y/usX2Yhwdep.c index 8abe08611df6..fc0d534ec7fc 100644 --- a/sound/usb/usx2y/usX2Yhwdep.c +++ b/sound/usb/usx2y/usX2Yhwdep.c @@ -67,15 +67,15 @@ static struct vm_operations_struct us428ctls_vm_ops = { static int snd_us428ctls_mmap(snd_hwdep_t * hw, stru...
95a98265eb7b112b3268761053d643635171e219
Analyze and fix the following issue in the Linux kernel code: [ALSA] ca0106 - Code clean up
Problem Details: Modules: CA0106 driver Clean up snd-ca0106 driver code: - Fix spaces and indents - Remove unnecessary spinlocks - Clean up the mixer callbacks using private_value - Clean up mixer constructors using an array Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/ca0106/ca0106_main.c b/sound/pci/ca0106/ca0106_main.c index a89eed255098..0120c4683c79 100644 --- a/sound/pci/ca0106/ca0106_main.c +++ b/sound/pci/ca0106/ca0106_main.c @@ -207,7 +207,8 @@ static snd_pcm_hardware_t snd_ca0106_playback_hw = { SNDRV_PCM_INFO_BLOCK_TRANSFER | SNDR...
03f9ae2505cf2f5d56c197b4045ed9dba5ce8912
Analyze and fix the following issue in the Linux kernel code: [ALSA] harmony - Code clean up
Problem Details: Modules: PARISC Harmony driver Clean up snd-harmony driver code: - Give standard module options - Fix spinlocks - Fix the error path of request_irq() - Clean up redundant codes Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/parisc/harmony.c b/sound/parisc/harmony.c index d833349ed518..0513137d4ec4 100644 --- a/sound/parisc/harmony.c +++ b/sound/parisc/harmony.c @@ -59,6 +59,14 @@ #include "harmony.h" +static int index = SNDRV_DEFAULT_IDX1; /* Index 0-MAX */ +static char *id = SNDRV_DEFAULT_STR1; /* ID for t...
33ea25c113a7d63645b10ed89851e08f7c984d1a
Analyze and fix the following issue in the Linux kernel code: [ALSA] au1x00 - Code clean up
Problem Details: Modules: MIPS AU1x00 driver Clean up snd-au1x00 driver code: - Remove global variables - Remove old compatibility codes - Fix DMA-link allocation/release functions in hw_params and hw_free callbacks (they may be called multiple times) - Fix spinlocks Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/mips/au1x00.c b/sound/mips/au1x00.c index d08a42b24b1f..a8f9a3b6e73d 100644 --- a/sound/mips/au1x00.c +++ b/sound/mips/au1x00.c @@ -50,12 +50,7 @@ MODULE_AUTHOR("Charles Eidsness <charles@cooper-street.com>"); MODULE_DESCRIPTION("Au1000 AC'97 ALSA Driver"); MODULE_LICENSE("GPL"); -#if LINU...
bc1ff7fc0ae6ec2d7f2202d9126901aeb3f596cd
Analyze and fix the following issue in the Linux kernel code: [ALSA] [Trivial] Fix spaces in gus.h
Problem Details: Modules: GUS Library Fix spaces in gus.h. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/include/sound/gus.h b/include/sound/gus.h index 7000d9d9199d..bb12e9fab8a7 100644 --- a/include/sound/gus.h +++ b/include/sound/gus.h @@ -49,32 +49,32 @@ #define SNDRV_g_u_s_IRQSTAT (0x226-0x220) #define SNDRV_g_u_s_TIMERCNTRL (0x228-0x220) #define SNDRV_g_u_s_TIMERDATA (0x229-0x220) -#define...
0948e3c8bb187b3dea38be1e1ffd1797866014f1
Analyze and fix the following issue in the Linux kernel code: [ALSA] Clean up sa11xx-uda1341 driver
Problem Details: Modules: SA11xx UDA1341 driver,L3 drivers,UDA1341 Clean up sa11xx-uda1341 driver: - Fix buggy destructor - Remove the global variable - Move array definitions from uda1341.h - Make functions in uda1341.c static Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/include/sound/uda1341.h b/include/sound/uda1341.h index 61ff65a628bc..54a048ac6e4f 100644 --- a/include/sound/uda1341.h +++ b/include/sound/uda1341.h @@ -15,7 +15,7 @@ * features support */ -/* $Id: uda1341.h,v 1.6 2004/05/03 17:36:50 tiwai Exp $ */ +/* $Id: uda1341....
3e8731740e17f01ec1ecce556ccdc4c42279ce1b
Analyze and fix the following issue in the Linux kernel code: [ALSA] Minor clean up and fixes for CS5535 audio driver
Problem Details: Modules: Documentation,CS5535 driver Minor clean up and fixes for CS5535 audio driver. Added an entry in ALSA-Configuration.txt, too. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/Documentation/sound/alsa/ALSA-Configuration.txt b/Documentation/sound/alsa/ALSA-Configuration.txt index 2f27f391c7cc..23d1870d522f 100644 --- a/Documentation/sound/alsa/ALSA-Configuration.txt +++ b/Documentation/sound/alsa/ALSA-Configuration.txt @@ -410,6 +410,13 @@ Prior to version 0.9.0rc4 option...
f31a31b9024f21b2ad8f5a7c30e265a652e2e211
Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix missing suspend/resume-code for ens1371
Problem Details: Modules: ENS1370/1+ driver This patch fixes missing suspend/resume-code for snd-ens1371 (but not for snd-ens1370) Signed-off-by: Kurt J. Bosch <kjb-temp-2005@gmx.de> Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/ens1370.c b/sound/pci/ens1370.c index 2daa575f43ff..fa619a959d8c 100644 --- a/sound/pci/ens1370.c +++ b/sound/pci/ens1370.c @@ -19,6 +19,13 @@ * */ +/* Power-Management-Code ( CONFIG_PM ) + * for ens1371 only ( FIXME ) + * derived from cs4281.c, atiixp.c and via82xx.c + * using http...
26741b5512a99ee35f398ef018d23a38e8dc6e8a
Analyze and fix the following issue in the Linux kernel code: [ALSA] hda-codec - Fix HDA sound and V.92 modem for notebook Siemens FieldPG-M
Problem Details: Modules: HDA Codec driver The patch fixes the problem of mute onboard HDA sound output, buildin V.92 modem idendification and functionality. Signed-off-by: Daniel Mueller <daniel.mueller@siemens.com> Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/hda/patch_si3054.c b/sound/pci/hda/patch_si3054.c index 9c7fe0b3200a..12b5de29f42f 100644 --- a/sound/pci/hda/patch_si3054.c +++ b/sound/pci/hda/patch_si3054.c @@ -295,6 +295,7 @@ static int patch_si3054(struct hda_codec *codec) * patch entries */ struct hda_codec_preset snd_hda_pres...
6ef7e8614c03f90ecb924938f5cc074af2723d35
Analyze and fix the following issue in the Linux kernel code: [ALSA] snd-emu10k1: Found some new registers to display in debug mode.
Problem Details: Modules: EMU10K1/EMU10K2 driver Signed-off-by: James Courtier-Dutton <James@superbug.co.uk>
```diff diff --git a/sound/pci/emu10k1/emuproc.c b/sound/pci/emu10k1/emuproc.c index cc22707c91fa..6cdee588d35d 100644 --- a/sound/pci/emu10k1/emuproc.c +++ b/sound/pci/emu10k1/emuproc.c @@ -445,7 +445,7 @@ static void snd_emu_proc_ptr_reg_read(snd_info_entry_t *entry, emu10k1_t *emu = entry->private_data; unsigned...
e2b15f8f7dfc7a60ab89162502732120792a644f
Analyze and fix the following issue in the Linux kernel code: [ALSA] snd-emu10k1: Attenuate output volume to reduce distortion
Problem Details: Modules: EMU10K1/EMU10K2 driver on Audigy 2 ZS Notebook. Set the master volume to about 6 or 8% in alsamixer. This will attenuate the output enough for better sound quality. Note: Only stereo enabled at present. The distortion is caused by the output path after the DSP adding 12...
```diff diff --git a/sound/pci/emu10k1/emu10k1_main.c b/sound/pci/emu10k1/emu10k1_main.c index 541aad6c7126..2d1ebe8c6b41 100644 --- a/sound/pci/emu10k1/emu10k1_main.c +++ b/sound/pci/emu10k1/emu10k1_main.c @@ -40,6 +40,7 @@ #include <sound/core.h> #include <sound/emu10k1.h> #include "p16v.h" +#include "tina2.h" ...
755e137138007200c3e2549fbd8390a4e7708ed9
Analyze and fix the following issue in the Linux kernel code: [ALSA] ali5451 - Fix and clean up codec accessor
Problem Details: Modules: ALI5451 driver Fix the codec accessors to avoid soft lockup. Spin locks are revised, too. Signed-off-by: Takashi Iwai <tiwai@suse.de>
```diff diff --git a/sound/pci/ali5451/ali5451.c b/sound/pci/ali5451/ali5451.c index feffbe73387e..21be4c26ebc4 100644 --- a/sound/pci/ali5451/ali5451.c +++ b/sound/pci/ali5451/ali5451.c @@ -387,26 +387,24 @@ static inline void snd_ali_5451_poke( ali_t *codec, } static int snd_ali_codec_ready( ali_t *codec, - un...
8f493d797bc1fe470377adc9d8775845427e240e
Analyze and fix the following issue in the Linux kernel code: [PATCH] Make sure interleave masks have at least one node set
Problem Details: Otherwise a bad mem policy system call can confuse the interleaving code into referencing undefined nodes. Originally reported by Doug Chapman I was told it's CVE-2005-3358 (one has to love these security people - they make everything sound important) Signed-off-by: Andi Kleen <ak@suse.de> Signed-of...
```diff diff --git a/mm/mempolicy.c b/mm/mempolicy.c index bec88c81244e..72f402cc9c9a 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -161,6 +161,10 @@ static struct mempolicy *mpol_new(int mode, nodemask_t *nodes) switch (mode) { case MPOL_INTERLEAVE: policy->v.nodes = *nodes; + if (nodes_weight(*nodes) ==...
f12f4d90308a22396ac87f6c3a7b2620589614c3
Analyze and fix the following issue in the Linux kernel code: [PATCH] powerpc: more g5 overtemp problem fix
Problem Details: Some G5s still occasionally experience shutdowns due to overtemp conditions despite the recent fix. After analyzing logs from such machines, it appears that the overtemp code is a bit too quick at shutting the machine down when reaching the critical temperature (tmax + 8) and doesn't leave the fan enou...
```diff diff --git a/drivers/macintosh/therm_pm72.c b/drivers/macintosh/therm_pm72.c index 5bb36274a5c6..190878eef990 100644 --- a/drivers/macintosh/therm_pm72.c +++ b/drivers/macintosh/therm_pm72.c @@ -923,7 +923,7 @@ static void do_monitor_cpu_combined(void) if (temp_combi >= ((state0->mpu.tmax + 8) << 16)) { pr...
fe34765be1ee9465b10406e6e5dddbd43ddc4fbe
Analyze and fix the following issue in the Linux kernel code: drm: drm_ioctl.c sync with fixes from CVS
Problem Details: Apply the fixes from CVS that were outstanding for this file Signed-off-by: Dave Airlie <airlied@linux.ie>
```diff diff --git a/drivers/char/drm/drm_ioctl.c b/drivers/char/drm/drm_ioctl.c index a654ac17a900..bcd4e604d3ec 100644 --- a/drivers/char/drm/drm_ioctl.c +++ b/drivers/char/drm/drm_ioctl.c @@ -137,17 +137,22 @@ int drm_setunique(struct inode *inode, struct file *filp, static int drm_set_busid(drm_device_t * dev) ...
f0c408b564ddefa0959ada4e2c2248f4a57f1842
Analyze and fix the following issue in the Linux kernel code: drm: update drm_memory_debug.h
Problem Details: Update from DRM CVS for drm memory debug From: Jon Smirl <jonsmirl@gmail.com> Signed-off-by: Dave Airlie <airlied@linux.ie>
```diff diff --git a/drivers/char/drm/drm_memory_debug.h b/drivers/char/drm/drm_memory_debug.h index 4542353195bd..706b75251ea1 100644 --- a/drivers/char/drm/drm_memory_debug.h +++ b/drivers/char/drm/drm_memory_debug.h @@ -1,5 +1,5 @@ /** - * \file drm_memory.h + * \file drm_memory_debug.h * Memory management wrappe...
1e7d51902a8bd08e37113aaf182d12233b157151
Analyze and fix the following issue in the Linux kernel code: drm: proper fix for drm_context
Problem Details: Bad patch in last version Signed-off-by: Dave Airlie <airlied@linux.ie>
```diff diff --git a/drivers/char/drm/drm_context.c b/drivers/char/drm/drm_context.c index 7a7bcef2aa84..f84254526949 100644 --- a/drivers/char/drm/drm_context.c +++ b/drivers/char/drm/drm_context.c @@ -432,11 +432,10 @@ int drm_addctx(struct inode *inode, struct file *filp, if (ctx.handle != DRM_KERNEL_CONTEXT) { ...
b5e9fc13dd0f25a2f422000c185f491bfd4f7335
Analyze and fix the following issue in the Linux kernel code: drm: fix issue with contexts running out of RAM
Problem Details: Signed-off-by: Dave Airlie <airlied@linux.ie>
```diff diff --git a/drivers/char/drm/drm_context.c b/drivers/char/drm/drm_context.c index bdd168d88f49..7a7bcef2aa84 100644 --- a/drivers/char/drm/drm_context.c +++ b/drivers/char/drm/drm_context.c @@ -432,6 +432,10 @@ int drm_addctx(struct inode *inode, struct file *filp, if (ctx.handle != DRM_KERNEL_CONTEXT) { ...
3528af1b189d0fbb4c7a3f121f46d9987b9af5b6
Analyze and fix the following issue in the Linux kernel code: drm: fix a LOR issue on FreeBSD for savage driver
Problem Details: Correct a LOR issue on FreeBSD by allocating temporary space and doing a single DRM_COPY_FROM_USER rather than DRM_VERIFYAREA_READ followed by tons of DRM_COPY_FROM_USER_UNCHECKED. I don't like the look of the temporary space allocation, but I like the simplification in the rest of the file. Tested w...
```diff diff --git a/drivers/char/drm/savage_drv.h b/drivers/char/drm/savage_drv.h index 2f73558fb9cf..dd46cb85439c 100644 --- a/drivers/char/drm/savage_drv.h +++ b/drivers/char/drm/savage_drv.h @@ -1,5 +1,5 @@ -/* savage_drv.h -- Private header for the savage driver - * +/* savage_drv.h -- Private header for the savag...
6073aa643f52fd12b02f0532dc96287f4c3293b5
Analyze and fix the following issue in the Linux kernel code: kbuild: tar-pkg with out-out-tree building
Problem Details: Fix out-of-tree builds for the tar-pkg targets When I wrote the buildtar script, I didn't even think about out-of-tree builds because I didn't use these back then. This patch throughoutly uses ${objtree} instead of `pwd`. Also, the kernel version is no longer manually built. Instead, it will properly...
```diff diff --git a/scripts/package/Makefile b/scripts/package/Makefile index f3e7e8e4a500..c201ef001f09 100644 --- a/scripts/package/Makefile +++ b/scripts/package/Makefile @@ -84,7 +84,7 @@ clean-dirs += $(objtree)/debian/ # --------------------------------------------------------------------------- .PHONY: tar%pk...
557962a926c62a9c4bd79d6b36df873d4f8c51ef
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86: teach dump_task_regs() about the -8 offset.
Problem Details: This should fix multi-threaded core-files Signed-off-by: stsp@aknet.ru Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/i386/kernel/process.c b/arch/i386/kernel/process.c index df6c2bcde067..2333aead0563 100644 --- a/arch/i386/kernel/process.c +++ b/arch/i386/kernel/process.c @@ -554,7 +554,9 @@ int dump_task_regs(struct task_struct *tsk, elf_gregset_t *regs) struct pt_regs ptregs; ptregs = *(struct pt_r...
de9e007d9105bf8fa613a89810feff32a43add03
Analyze and fix the following issue in the Linux kernel code: sysctl: make sure to terminate strings with a NUL
Problem Details: This is a slightly more complete fix for the previous minimal sysctl string fix. It always terminates the returned string with a NUL, even if the full result wouldn't fit in the user-supplied buffer. The returned length is the full untruncated length, so that you can tell when truncation has occurred...
```diff diff --git a/kernel/sysctl.c b/kernel/sysctl.c index e5102ea6e104..b53115b882e1 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -2192,27 +2192,32 @@ int sysctl_string(ctl_table *table, int __user *name, int nlen, void __user *oldval, size_t __user *oldlenp, void __user *newval, size_t newlen, vo...
fdf7f2e91981938702ab2f58f44dc5685dd1bdc1
Analyze and fix the following issue in the Linux kernel code: [CIFS] Fix typos in rfc1002pdu.h
Problem Details: Pointed out by Leo Comitale Signed-off-by: Steve French <sfrench@us.ibm.com>
```diff diff --git a/fs/cifs/rfc1002pdu.h b/fs/cifs/rfc1002pdu.h index 9222033cad8e..aede606132aa 100644 --- a/fs/cifs/rfc1002pdu.h +++ b/fs/cifs/rfc1002pdu.h @@ -24,11 +24,11 @@ /* NB: unlike smb/cifs packets, the RFC1002 structures are big endian */ /* RFC 1002 session packet types */ -#define RFC1002_SESSION_ME...
82c9df820112c6286a8e8fbe482e94b65b49062c
Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix false old value return of sysctl
Problem Details: For the sysctl syscall, if the user wants to get the old value of a sysctl entry and set a new value for it in the same syscall, the old value is always overwritten by the new value if the sysctl entry is of string type and if the user sets its strategy to sysctl_string. This issue lies in the strateg...
```diff diff --git a/kernel/sysctl.c b/kernel/sysctl.c index ad0425a8f709..e5102ea6e104 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -2221,7 +2221,7 @@ int sysctl_string(ctl_table *table, int __user *name, int nlen, len--; ((char *) table->data)[len] = 0; } - return 0; + return 1; } /* ```
8febdd85adaa41fa1fc1cb31286210fc2cd3ed0c
Analyze and fix the following issue in the Linux kernel code: sysctl: don't overflow the user-supplied buffer with '\0'
Problem Details: If the string was too long to fit in the user-supplied buffer, the sysctl layer would zero-terminate it by writing past the end of the buffer. Don't do that. Noticed by Yi Yang <yang.y.yi@gmail.com> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/kernel/sysctl.c b/kernel/sysctl.c index 9990e10192e8..ad0425a8f709 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -2201,14 +2201,12 @@ int sysctl_string(ctl_table *table, int __user *name, int nlen, if (get_user(len, oldlenp)) return -EFAULT; if (len) { - l = strlen(table->data);...
40c37213a081990b1d3778f57630f97df75a7ec1
Analyze and fix the following issue in the Linux kernel code: [PATCH] Input: wacom - fix X axis setup
Problem Details: This patch fixes a typo introduced by conversion to dynamic input_dev allocation. Signed-off-by: Dmitry Torokhov <dtor@mail.ru> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/usb/input/wacom.c b/drivers/usb/input/wacom.c index aea1cfae34cc..dc099bbe12bf 100644 --- a/drivers/usb/input/wacom.c +++ b/drivers/usb/input/wacom.c @@ -854,7 +854,7 @@ static int wacom_probe(struct usb_interface *intf, const struct usb_device_id *i input_dev->evbit[0] |= BIT(EV_KEY) |...
ae5536d6f7f9b51f7a0451421eade1988cfd7126
Analyze and fix the following issue in the Linux kernel code: [PATCH] Input: warrior - fix HAT0Y axis setup
Problem Details: This patch fixes a typo introduced by conversion to dynamic input_dev allocation. Signed-off-by: Dmitry Torokhov <dtor@mail.ru> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/input/joystick/warrior.c b/drivers/input/joystick/warrior.c index 99a642d2a1fe..1849b176cf18 100644 --- a/drivers/input/joystick/warrior.c +++ b/drivers/input/joystick/warrior.c @@ -172,7 +172,7 @@ static int warrior_connect(struct serio *serio, struct serio_driver *drv) input_set_abs_par...
1994754412536d4ab902a81530b49bcaf496a59c
Analyze and fix the following issue in the Linux kernel code: [PATCH] Input: kbtab - fix Y axis setup
Problem Details: This patch fixes a typo introduced by conversion to dynamic input_dev allocation. Signed-off-by: Dmitry Torokhov <dtor@mail.ru> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/usb/input/kbtab.c b/drivers/usb/input/kbtab.c index a248664b5d1d..fd48e74e78ed 100644 --- a/drivers/usb/input/kbtab.c +++ b/drivers/usb/input/kbtab.c @@ -159,7 +159,7 @@ static int kbtab_probe(struct usb_interface *intf, const struct usb_device_id *i input_dev->keybit[LONG(BTN_DIGI)] |= B...
04348e69e7e78ad69a09b2e1157f628d6c764370
Analyze and fix the following issue in the Linux kernel code: [ACPI] reduce kernel size: move 5BK .bss to 2.5KB .init.data
Problem Details: put __initdata on sdt_entry[], as it is accessed only by __init functions. http://bugzilla.kernel.org/show_bug.cgi?id=1311 Signed-off-by: Len Brown <len.brown@intel.com>
```diff diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c index a2bf25b05e1c..31d4f3ffc265 100644 --- a/drivers/acpi/tables.c +++ b/drivers/acpi/tables.c @@ -37,7 +37,7 @@ #define PREFIX "ACPI: " -#define ACPI_MAX_TABLES 256 +#define ACPI_MAX_TABLES 128 static char *acpi_table_signatures[ACPI_TABLE...
392c14beaca2ee85a98d0c6b453501be67423a20
Analyze and fix the following issue in the Linux kernel code: Revert radeon AGP aperture offset changes
Problem Details: This reverts the series of commits 67dbb4ea33731415fe09c62149a34f472719ac1d 281ab031a8c9e5b593142eb4ec59a87faae8676a 47807ce381acc34a7ffee2b42e35e96c0f322e52 that changed the GART VM start offset. It fixed some machines, but seems to continually interact badly with some X versions. Quoth Ben Her...
```diff diff --git a/drivers/char/drm/radeon_cp.c b/drivers/char/drm/radeon_cp.c index b517ae515801..342302d46743 100644 --- a/drivers/char/drm/radeon_cp.c +++ b/drivers/char/drm/radeon_cp.c @@ -1312,8 +1312,6 @@ static void radeon_set_pcigart(drm_radeon_private_t * dev_priv, int on) static int radeon_do_init_cp(drm_d...
80c72579f74fcfcd63e27c5e317091cb35bb1f12
Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix recursive config dependency for SAA7134
Problem Details: Fix the cyclic dependency issue between CONFIG_SAA7134_ALSA and CONFIG_SAA7134_OSS (credits to Mauro Carvalho Chehab.) Signed-off-by: Jean Delvare <khali@linux-fr.org> Acked-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/media/video/saa7134/Kconfig b/drivers/media/video/saa7134/Kconfig index c0f604a6fe42..86e1bb391a4e 100644 --- a/drivers/media/video/saa7134/Kconfig +++ b/drivers/media/video/saa7134/Kconfig @@ -14,7 +14,7 @@ config VIDEO_SAA7134 config VIDEO_SAA7134_ALSA tristate "Philips SAA7134 DMA a...
576fc0978b6b3673fce6d4b405f36449e508826c
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: Fix incorrect node_present_pages on NUMA
Problem Details: Currently, we do not pass the correct start_pfn to e820_hole_size, to calculate holes. Following patch fixes that. The bug results in incorrect number of node_present_pages for each pgdat and causes ugly output in /sys and probably VM inbalances. Signed-off-by: Alok N Kataria <alokk@calsoftinc.com> ...
```diff diff --git a/arch/x86_64/mm/init.c b/arch/x86_64/mm/init.c index 286f6a624c3a..c016dfe84784 100644 --- a/arch/x86_64/mm/init.c +++ b/arch/x86_64/mm/init.c @@ -348,7 +348,7 @@ size_zones(unsigned long *z, unsigned long *h, } /* Compute holes */ - w = 0; + w = start_pfn; for (i = 0; i < MAX_NR_ZONES; i++)...
f873e3e88d52774633968826c5b7fa7bf9697999
Analyze and fix the following issue in the Linux kernel code: [PATCH] Input: aiptek - fix Y axis setup
Problem Details: This patch fixes a typo introduced by conversion to dynamic input_dev allocation. Signed-off-by: Dmitry Torokhov <dtor@mail.ru> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/usb/input/aiptek.c b/drivers/usb/input/aiptek.c index 1c3b472a3bca..0e2505c073db 100644 --- a/drivers/usb/input/aiptek.c +++ b/drivers/usb/input/aiptek.c @@ -2103,7 +2103,7 @@ aiptek_probe(struct usb_interface *intf, const struct usb_device_id *id) * values. */ input_set_abs_params(...
ee025949586f80effa634ff273c2444795472780
Analyze and fix the following issue in the Linux kernel code: [PATCH] fix ia64 compile failure with gcc4.1
Problem Details: __get_unaligned creates a typeof the var its passed, and writes to it, which on gcc4.1, spits out the following error: drivers/char/vc_screen.c: In function 'vcs_write': drivers/char/vc_screen.c:422: error: assignment of read-only variable 'val' Signed-off-by: Dave Jones <davej@redhat.com> [ The "rig...
```diff diff --git a/drivers/char/vc_screen.c b/drivers/char/vc_screen.c index f66c7ad6fd38..3c1dafaa3441 100644 --- a/drivers/char/vc_screen.c +++ b/drivers/char/vc_screen.c @@ -419,7 +419,7 @@ vcs_write(struct file *file, const char __user *buf, size_t count, loff_t *ppos) while (this_round > 1) { unsigned s...
63b44442416a243f05881b0dd094b621a46ab4b3
Analyze and fix the following issue in the Linux kernel code: [PATCH] uml: fix compilation with CONFIG_MODE_TT disabled
Problem Details: Fix UML compilation when SKAS mode is disabled. Indeed, we were compiling SKAS-only object files, which failed due to some SKAS-only headers being excluded from the search path. Thanks to the bug report from Pekka J Enberg. Acked-by: Pekka J Enberg <penberg (at) cs ! helsinki ! fi> Signed-off-by: Pao...
```diff diff --git a/arch/um/sys-i386/Makefile b/arch/um/sys-i386/Makefile index 150059dbee12..f5fd5b0156d0 100644 --- a/arch/um/sys-i386/Makefile +++ b/arch/um/sys-i386/Makefile @@ -1,6 +1,8 @@ -obj-y = bitops.o bugs.o checksum.o delay.o fault.o ksyms.o ldt.o ptrace.o \ - ptrace_user.o semaphore.o signal.o sigcontext....
30f04a4efa73dc80bf3f59f3f19ad5a24ac5ac0a
Analyze and fix the following issue in the Linux kernel code: [PATCH] uml: hostfs - fix possible PAGE_CACHE_SHIFT overflows
Problem Details: Prevent page->index << PAGE_CACHE_SHIFT from overflowing. There is a casting there, but was added without care, so it's at the wrong place. Note the extra parens around the shift - "+" is higher precedence than "<<", leading to a GCC warning which saved all us. Signed-off-by: Paolo 'Blaisorblade' Gia...
```diff diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c index 3aac164c7726..b3ad0bd0312f 100644 --- a/fs/hostfs/hostfs_kern.c +++ b/fs/hostfs/hostfs_kern.c @@ -501,11 +501,16 @@ int hostfs_commit_write(struct file *file, struct page *page, unsigned from, long long start; int err = 0; - start = (lon...
516949480d3700cbde4272228a102c84721d6007
Analyze and fix the following issue in the Linux kernel code: [PATCH] uml: fix random segfaults at bootup
Problem Details: Don't use printk() where "current_thread_info()" is crap. Until when we switch to running on init_stack, current_thread_info() evaluates to crap. Printk uses "current" at times (in detail, &current is evaluated with CONFIG_DEBUG_SPINLOCK to check the spinlock owner task). And this leads to random seg...
```diff diff --git a/arch/um/os-Linux/start_up.c b/arch/um/os-Linux/start_up.c index 37517d49c4ae..29a9e3f43763 100644 --- a/arch/um/os-Linux/start_up.c +++ b/arch/um/os-Linux/start_up.c @@ -116,16 +116,16 @@ static int stop_ptraced_child(int pid, void *stack, int exitcode, if(!WIFEXITED(status) || (WEXITSTATUS(statu...
b697b5372ecfe0c57ee26e0c3787fc2306109228
Analyze and fix the following issue in the Linux kernel code: [ASUS_ACPI] work around Samsung P30s oops
Problem Details: The code used to rely on a certain method to return a NULL buffer, which is now hardly possible with the implicit return code on by default. This sort of fixes bugs #5067 and #5092 for now. Note: this patch makes the driver unusable on said machines (and on said machines only) iff acpi=strict is speci...
```diff diff --git a/drivers/acpi/asus_acpi.c b/drivers/acpi/asus_acpi.c index fec895af6ae6..582995ef9f34 100644 --- a/drivers/acpi/asus_acpi.c +++ b/drivers/acpi/asus_acpi.c @@ -987,9 +987,21 @@ static int __init asus_hotk_get_info(void) printk(KERN_NOTICE " BSTS called, 0x%02x returned\n", bsts_result);...
d5784b57d2e08a632b971baae23266121004ef3b
Analyze and fix the following issue in the Linux kernel code: [SPARC]: Use STABS_DEBUG and DWARF_DEBUG macros in vmlinux.lds.S
Problem Details: Signed-off-by: David S. Miller <davem@davemloft.net>
```diff diff --git a/arch/sparc/kernel/vmlinux.lds.S b/arch/sparc/kernel/vmlinux.lds.S index 38938d2e63aa..346c19a949fd 100644 --- a/arch/sparc/kernel/vmlinux.lds.S +++ b/arch/sparc/kernel/vmlinux.lds.S @@ -85,19 +85,9 @@ SECTIONS } _end = . ; PROVIDE (end = .); - /* Stabs debugging sections. */ - .stab 0 :...
3173cdfe02995f6c6841a28b5148f94cefd8ab77
Analyze and fix the following issue in the Linux kernel code: [ACPI] fix osl.c build warning
Problem Details: typecheck complains on i386 that u32 != unsigned long Signed-off-by: Len Brown <len.brown@intel.com>
```diff diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c index 4ece850b2af1..58e7c47354ee 100644 --- a/drivers/acpi/osl.c +++ b/drivers/acpi/osl.c @@ -1073,7 +1073,7 @@ acpi_native_uint acpi_os_acquire_lock(acpi_handle handle) void acpi_os_release_lock(acpi_handle handle, acpi_native_uint flags) { - spin_unlock...
cb654695f6b912cef7cb3271665b6ee0d416124c
Analyze and fix the following issue in the Linux kernel code: [ACPI] acpi_register_gsi() fix needed for ACPICA 20051021
Problem Details: Use the #define for ACPI_LEVEL_SENSITIVE instead of assuming non-zero, because ACPICA 20051021 changes its value to zero. Also, use uniform variable names: edge_level -> triggering active_high_low -> polarity Signed-off-by: Len Brown <len.brown@intel.com>
```diff diff --git a/arch/i386/kernel/acpi/boot.c b/arch/i386/kernel/acpi/boot.c index 447fa9e33ffb..1f378df14f34 100644 --- a/arch/i386/kernel/acpi/boot.c +++ b/arch/i386/kernel/acpi/boot.c @@ -464,7 +464,7 @@ int acpi_gsi_to_irq(u32 gsi, unsigned int *irq) * success: return IRQ number (>=0) * failure: return < 0 ...
67dbb4ea33731415fe09c62149a34f472719ac1d
Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix more radeon GART start calculation cases
Problem Details: As reported by Jules Villard <jvillard@ens-lyon.fr> and some others, the recent GART aperture start reconfiguration causes problems on some setups. What I _think_ might be happening is that the X server is also trying to muck around with the card memory map and is forcing it back into a wrong setting ...
```diff diff --git a/drivers/char/drm/radeon_cp.c b/drivers/char/drm/radeon_cp.c index 501e557cbc86..b517ae515801 100644 --- a/drivers/char/drm/radeon_cp.c +++ b/drivers/char/drm/radeon_cp.c @@ -1312,7 +1312,7 @@ static void radeon_set_pcigart(drm_radeon_private_t * dev_priv, int on) static int radeon_do_init_cp(drm_d...
5ab4a6c81eb3dbe32361791d1535f9153f79b0ed
Analyze and fix the following issue in the Linux kernel code: [IPV6] mcast: Fix multiple issues in MLDv2 reports.
Problem Details: The below "jumbo" patch fixes the following problems in MLDv2. 1) Add necessary "ntohs" to recent "pskb_may_pull" check [breaks all nonzero source queries on little-endian (!)] 2) Add locking to source filter list [resend of prior patch] 3) fix "mld_marksources()" to a) send nothing ...
```diff diff --git a/include/net/if_inet6.h b/include/net/if_inet6.h index d8234f9bd4c4..eb8afe3499a9 100644 --- a/include/net/if_inet6.h +++ b/include/net/if_inet6.h @@ -83,6 +83,7 @@ struct ipv6_mc_socklist struct in6_addr addr; int ifindex; struct ipv6_mc_socklist *next; + rwlock_t sflock; unsigned int ...
6732badee0dad467fcc9dd0168af8677b2b1bc2f
Analyze and fix the following issue in the Linux kernel code: [IPV6]: Fix addrconf dead lock.
Problem Details: We need to release idev->lcok before we call addrconf_dad_stop(). It calls ipv6_addr_del(), which will hold idev->lock. Bug spotted by Yasuyuki KOZAKAI <yasuyuki.kozakai@toshiba.co.jp>. Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> Signed-off-by: David S. Miller <davem@davemloft.net>
```diff diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 2a6439e3c91c..a60585fd85ad 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -2467,11 +2467,9 @@ static void addrconf_dad_start(struct inet6_ifaddr *ifp, u32 flags) return; } - if (idev->if_flags & IF_READY) { - addrconf_dad_kick(i...
a710ce08585e920740ffc84c7f3c82f4081169cf
Analyze and fix the following issue in the Linux kernel code: [SERIAL] Fix AMBA PL011 sysrq character handling
Problem Details: We only want the received character without the status bits for sysrq handling. Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
```diff diff --git a/drivers/serial/amba-pl011.c b/drivers/serial/amba-pl011.c index 89d7bd3eaee3..d84476ee6592 100644 --- a/drivers/serial/amba-pl011.c +++ b/drivers/serial/amba-pl011.c @@ -160,7 +160,7 @@ pl011_rx_chars(struct uart_amba_port *uap) flag = TTY_FRAME; } - if (uart_handle_sysrq_char(&uap->port...
79cac2a221ce18642550a13bed0f0203514923ea
Analyze and fix the following issue in the Linux kernel code: [BR_NETFILTER]: Fix leak if skb traverses > 1 bridge
Problem Details: Call nf_bridge_put() before allocating a new nf_bridge structure and potentially overwriting the pointer to a previously allocated one. This fixes a memory leak which can occur when the bridge topology allows for an skb to traverse more than one bridge. Signed-off-by: David Kimdon <david.kimdon@device...
```diff diff --git a/net/bridge/br_netfilter.c b/net/bridge/br_netfilter.c index 43a0b35dfe6f..23422bd53a5e 100644 --- a/net/bridge/br_netfilter.c +++ b/net/bridge/br_netfilter.c @@ -369,6 +369,7 @@ static unsigned int br_nf_pre_routing_ipv6(unsigned int hook, if (hdr->nexthdr == NEXTHDR_HOP && check_hbh_len(skb)) ...
752625cff3eba81cbc886988d5b420064c033948
Analyze and fix the following issue in the Linux kernel code: kbuild: always run 'make silentoldconfig' when tree is cleaned
Problem Details: If the file .kconfig.d is missing then make sure to run 'make silentoldconfig', since we have no way to detect if a Kconfig file has been updated. -kconfig.d is created by kconfig and is removed as part of 'make clean' so the situation is likely to occur in reality. Jan Beulich <JBeulich@novell.com> ...
```diff diff --git a/Makefile b/Makefile index 922c7633797f..d3598ef3c777 100644 --- a/Makefile +++ b/Makefile @@ -477,18 +477,20 @@ ifeq ($(dot-config),1) # Read in dependencies to all Kconfig* files, make sure to run # oldconfig if changes are detected. --include .config.cmd +-include .kconfig.d include .confi...
a89a0a2354ae666612968e254d650bfd04f11eb6
Analyze and fix the following issue in the Linux kernel code: kbuild: Fix genksyms handling of DEFINE_PER_CPU(struct foo_s *, bar);
Problem Details: This is a one-line change to parse.y. To take advantage of this the scripts/genksyms/*_shipped files needs to be rebuild - this is the next patch. When a .c file contains: DEFINE_PER_CPU(struct foo_s *, bar); the .cpp output looks like: __attribute__((__section__(".data.percpu"))) __typeof__(struct f...
```diff diff --git a/scripts/genksyms/parse.y b/scripts/genksyms/parse.y index 099043713db4..ca04c944b7c3 100644 --- a/scripts/genksyms/parse.y +++ b/scripts/genksyms/parse.y @@ -197,6 +197,7 @@ storage_class_specifier: type_specifier: simple_type_specifier | cvar_qualifier + | TYPEOF_KEYW '(' decl_specifier_seq '...
04333393b930370db0cc29fdf0dbbd08ecd43337
Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix Fibre Channel boot oops
Problem Details: The oops is characteristic of the underlying device being removed from visibility before the class device, and sure enough we do device_del() before transport_unregister() in the scsi_target_reap() routines. I've no idea why this is suddenly showing up, since the code has been in there since that func...
```diff diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index e36c21e06d31..4e6709f448e1 100644 --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c @@ -418,8 +418,9 @@ static void scsi_target_reap_work(void *data) { if (--starget->reap_ref == 0 && list_empty(&starget->devices)) { list_de...
f83b5e323f57d6e1f35a839d663e91cebe985e54
Analyze and fix the following issue in the Linux kernel code: kbuild: set correct KBUILD_MODNAME when using well known kernel symbols as module names
Problem Details: This patch fixes a problem when we use well known kernel symbols as module names. For example, if module source name is current.c, idle_stack.c or etc., we have a bad KBUILD_MODNAME value. For example, KBUILD_MODNAME will be "get_current()" instead of "current", or "(init_thread_union.stack)" instead ...
```diff diff --git a/include/linux/spinlock.h b/include/linux/spinlock.h index 0e9682c9def5..799be6747944 100644 --- a/include/linux/spinlock.h +++ b/include/linux/spinlock.h @@ -59,8 +59,7 @@ /* * Must define these before including other files, inline functions need them */ -#define LOCK_SECTION_NAME ...
9572b28faf72859c6b91891c627870cfa282d19d
Analyze and fix the following issue in the Linux kernel code: kbuild: Fix crc-error warning on modules
Problem Details: This is the patch for the following issue: In include/linux/module.h, "__crc_" and "__ksymtab_" are hard coded to be the prefix for some kinds of symbols (CRC symbol and ksymtab section). But in script /mod/modpost.c, MODULE_SYMBOL_PREFIX##"__crc_" is used as the prefix to search CRC symbols. So if...
```diff diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index 3bed09e625c0..8ce5a6318684 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -326,8 +326,8 @@ parse_elf_finish(struct elf_info *info) release_file(info->hdr, info->size); } -#define CRC_PFX MODULE_SYMBOL_PREFIX "__crc_" -#...
01e33b5a2a153eec74dd87522e264948030b88c1
Analyze and fix the following issue in the Linux kernel code: [PATCH] n_r3964: fixed usage of HZ; removed bad include
Problem Details: Fix n_r3964 timeouts (hardcoded for 100Hz) Also the include of <asm/termios.h> in 'n_r3964.h' is unnecessary and prevents using the header file in any application that has to include <termios.h> due to duplicate definition of 'struct termio'. Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/include/linux/n_r3964.h b/include/linux/n_r3964.h index 2352bcd31a06..db4f3776978a 100644 --- a/include/linux/n_r3964.h +++ b/include/linux/n_r3964.h @@ -13,6 +13,10 @@ * L. Haag * * $Log: r3964.h,v $ + * Revision 1.4 2005/12/21 19:54:24 Kurt Huwig <kurt huwig de> + * Fixed HZ usage on 2.6 ...
e5c34a57c8b3a94b8d2b329936f8b1cbcc765307
Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix typo in x86_64 __build_write_lock_const assembly
Problem Details: Based on __build_read_lock_const, this looked like a bug. [ Indeed. Maybe nobody uses this version? Worth fixing up anyway ] Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/include/asm-x86_64/rwlock.h b/include/asm-x86_64/rwlock.h index 8a78a4ace53c..9942cc393064 100644 --- a/include/asm-x86_64/rwlock.h +++ b/include/asm-x86_64/rwlock.h @@ -64,7 +64,7 @@ ::"a" (rw) : "memory") #define __build_write_lock_const(rw, helper) \ - asm volatile(LOCK "subl $" RW_LO...
c660439ba90aaaa056f68a5b0fc79f6b9e0506f5
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64/ia64 : Fix compilation error for node_to_first_cpu
Problem Details: Fixes a compiler error in node_to_first_cpu, __ffs expects unsigned long as a parameter; instead cpumask_t was being passed. The macro node_to_first_cpu was not yet used in x86_64 and ia64 arches, and so we never hit this. This patch replaces __ffs with first_cpu macro, similar to other arches. Sign...
```diff diff --git a/include/asm-ia64/topology.h b/include/asm-ia64/topology.h index a9f738bf18a7..f7c330467e7e 100644 --- a/include/asm-ia64/topology.h +++ b/include/asm-ia64/topology.h @@ -38,7 +38,7 @@ /* * Returns the number of the first CPU on Node 'node'. */ -#define node_to_first_cpu(node) (__ffs(node_to_cp...
1224b375ed7982128602a3fa1da53eeeac1750b4
Analyze and fix the following issue in the Linux kernel code: Fix silly typo ("smb" vs "smp")
Problem Details: Introduced by commit 6003a93e7bf6c02f33c02976ff364785d4273295
```diff diff --git a/ipc/sem.c b/ipc/sem.c index 6a16f8edf2b2..cb5bb2a5df96 100644 --- a/ipc/sem.c +++ b/ipc/sem.c @@ -381,7 +381,7 @@ static void update_queue (struct sem_array * sma) /* hands-off: q will disappear immediately after * writing q->status. */ - smb_wmb(); + smp_wmb(); q->status = er...