id stringlengths 40 40 | instruction stringlengths 68 308 | input stringlengths 17 33.4k | output stringlengths 100 30k |
|---|---|---|---|
61d9cdf2a9ccb9e4770d7723db8b18b8952778ce | Analyze and fix the following issue in the Linux kernel code: [PATCH] kbuild: signed char fixes for scripts | Problem Details:
This time I did not break anything... and they shut up gcc4 ;)
Signed-off-by: Sam Ravnborg <sam@ravnborg.org> | ```diff
diff --git a/scripts/conmakehash.c b/scripts/conmakehash.c
index 93dd23f21ec9..e0c6891a9ad4 100644
--- a/scripts/conmakehash.c
+++ b/scripts/conmakehash.c
@@ -33,7 +33,7 @@ void usage(char *argv0)
int getunicode(char **p0)
{
- unsigned char *p = *p0;
+ char *p = *p0;
while (*p == ' ' || *p == '\t')
... |
84c2a2eb348f3bd85ec8eb3bb95ba04f65f4e217 | Analyze and fix the following issue in the Linux kernel code: [PATCH] kbuild: signed/unsigned char fix for make menuconfig | Problem Details:
Quiet some silly warnings.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org> | ```diff
diff --git a/scripts/lxdialog/dialog.h b/scripts/lxdialog/dialog.h
index c571548daa82..eb63e1bb63a3 100644
--- a/scripts/lxdialog/dialog.h
+++ b/scripts/lxdialog/dialog.h
@@ -163,7 +163,7 @@ int dialog_menu (const char *title, const char *prompt, int height, int width,
int dialog_checklist (const char *title, ... |
db8c1a7b2ca25f37b1429c00e82d6568f86caec1 | Analyze and fix the following issue in the Linux kernel code: kbuild: fix building external modules | Problem Details:
kbuild failed to locate Makefile for external modules.
This brought to my attention how the variables for directories
have different values in different usage scenarios.
Different kbuild usage scenarios:
make - plain make in same directory where kernel source lives
make O= - kbuild is told to... | ```diff
diff --git a/scripts/Makefile.build b/scripts/Makefile.build
index 8f4f5a347767..506e3f3befe3 100644
--- a/scripts/Makefile.build
+++ b/scripts/Makefile.build
@@ -11,8 +11,8 @@ __build:
-include .config
# The filename Kbuild has precedence over Makefile
-include $(if $(wildcard $(srctree)/$(src)/Kbuild), \
... |
eaa1c5d05947819643b2e72cbfc51ae2ddcf1991 | Analyze and fix the following issue in the Linux kernel code: [IPV4]: Fix Kconfig syntax error | Problem Details:
From: "Hans-Juergen Tappe (SYSGO AG)" <hjt@sysgo.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
index fc561c0ae8e2..0b3d9f1d8069 100644
--- a/net/ipv4/Kconfig
+++ b/net/ipv4/Kconfig
@@ -124,7 +124,7 @@ config IP_ROUTE_MULTIPATH
config IP_ROUTE_MULTIPATH_CACHED
bool "IP: equal cost multipath with caching support (EXPERIMENTAL)"
- depends on: IP_ROUTE_MU... |
72ba47c1b293ae78f7d798b458bb9d3db65c7551 | Analyze and fix the following issue in the Linux kernel code: kbuild: silence mystery message | Problem Details:
During last phase of the build the following message were displayed:
/bin/sh: +@: command not found
This message appears due to slightly changed semantics
of cmd and if_changed_rule.
The easy fix was to insert a dummy command first in rule_ksym_ld.
The alternative was to redo part of this processing i... | ```diff
diff --git a/Makefile b/Makefile
index 2467aa0f6689..06995fe7f57c 100644
--- a/Makefile
+++ b/Makefile
@@ -688,8 +688,10 @@ endef
# Update vmlinux version before link
# Use + in front of this rule to silent warning about make -j1
+# First command is ':' to allow us to use + in front of this rule
cmd_ksym_l... |
23a45e2c0a16bfd80eba853b44717d21c37bcf30 | Analyze and fix the following issue in the Linux kernel code: kbuild: pass less variables to second make invocation when using make O=... | Problem Details:
make exports all variables assigned on the command-line, so no need to pass
them explicit.
This fixes http://bugzilla.kernel.org/show_bug.cgi?id=4725
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
--- | ```diff
diff --git a/Makefile b/Makefile
index 887ba28da765..2467aa0f6689 100644
--- a/Makefile
+++ b/Makefile
@@ -109,10 +109,9 @@ $(if $(KBUILD_OUTPUT),, \
.PHONY: $(MAKECMDGOALS)
$(filter-out _all,$(MAKECMDGOALS)) _all:
- $(if $(KBUILD_VERBOSE:1=),@)$(MAKE) -C $(KBUILD_OUTPUT) \
- KBUILD_SRC=$(CURDIR) KBUI... |
e579d351b4bcea0038f5df08fff7160352b2c365 | Analyze and fix the following issue in the Linux kernel code: kbuild: KBUILD_VERBOSE was exported twice | Problem Details:
This fixes http://bugzilla.kernel.org/show_bug.cgi?id=4727
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
--- | ```diff
diff --git a/Makefile b/Makefile
index ed1f4b5b714f..887ba28da765 100644
--- a/Makefile
+++ b/Makefile
@@ -233,7 +233,7 @@ ifeq ($(MAKECMDGOALS),)
KBUILD_MODULES := 1
endif
-export KBUILD_MODULES KBUILD_BUILTIN KBUILD_VERBOSE
+export KBUILD_MODULES KBUILD_BUILTIN
export KBUILD_CHECKSRC KBUILD_SRC KBUILD_... |
9e566d8bd61f939b7f5d7d969f5b178571471cf9 | Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64 fsnotify build fix | Problem Details:
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/arch/x86_64/ia32/sys_ia32.c b/arch/x86_64/ia32/sys_ia32.c
index 70caf89d4c21..be996d1b691e 100644
--- a/arch/x86_64/ia32/sys_ia32.c
+++ b/arch/x86_64/ia32/sys_ia32.c
@@ -61,7 +61,7 @@
#include <linux/ptrace.h>
#include <linux/highuid.h>
#include <linux/vmalloc.h>
-#include <linux/fsnotify.>
+#in... |
479d0f41e50646a618c43f69af7af31a8f748433 | Analyze and fix the following issue in the Linux kernel code: [PATCH] softdog build fix | Problem Details:
drivers/char/watchdog/softdog.c:94: too many arguments to function `emergency_restart'
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/drivers/char/watchdog/softdog.c b/drivers/char/watchdog/softdog.c
index 0d93097f06b4..98c7578740e2 100644
--- a/drivers/char/watchdog/softdog.c
+++ b/drivers/char/watchdog/softdog.c
@@ -97,7 +97,7 @@ static void watchdog_fire(unsigned long data)
else
{
printk(KERN_CRIT PFX "Initiating system... |
cc1d3a9a78f0f602fa1e7993dba4d16ad9781bc1 | Analyze and fix the following issue in the Linux kernel code: [PATCH] eurotechwdt build fix | Problem Details:
drivers/char/watchdog/eurotechwdt.c:165: too many arguments to function `emergency_restart'
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/drivers/char/watchdog/eurotechwdt.c b/drivers/char/watchdog/eurotechwdt.c
index f1016e3ba117..2a29a511df7f 100644
--- a/drivers/char/watchdog/eurotechwdt.c
+++ b/drivers/char/watchdog/eurotechwdt.c
@@ -167,7 +167,7 @@ static irqreturn_t eurwdt_interrupt(int irq, void *dev_id, struct pt_regs *regs)
... |
a4f1bac62564049ea4718c4624b0fadc9f597c84 | Analyze and fix the following issue in the Linux kernel code: [XFRM]: Fix possible overflow of sock->sk_policy | Problem Details:
Spotted by, and original patch by, Balazs Scheidler.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c
index ecade4893a13..8da3e25b2c4c 100644
--- a/net/xfrm/xfrm_user.c
+++ b/net/xfrm/xfrm_user.c
@@ -1350,6 +1350,9 @@ static struct xfrm_policy *xfrm_compile_policy(u16 family, int opt,
if (nr > XFRM_MAX_DEPTH)
return NULL;
+ if (p->dir > XFRM_POLICY... |
d46523ea32a79fbc8cd1237f9441f45cc3f02456 | Analyze and fix the following issue in the Linux kernel code: [PATCH] fix MAX_USER_RT_PRIO and MAX_RT_PRIO | Problem Details:
Here's the patch again to fix the code to handle if the values between
MAX_USER_RT_PRIO and MAX_RT_PRIO are different.
Without this patch, an SMP system will crash if the values are
different.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Dean Nels... | ```diff
diff --git a/arch/ia64/sn/kernel/xpc_main.c b/arch/ia64/sn/kernel/xpc_main.c
index d580adcad927..bb1d5cf30440 100644
--- a/arch/ia64/sn/kernel/xpc_main.c
+++ b/arch/ia64/sn/kernel/xpc_main.c
@@ -420,7 +420,7 @@ xpc_activating(void *__partid)
partid_t partid = (u64) __partid;
struct xpc_partition *part = &xp... |
cadf01c2fc0cd66dfef4956ef1a6482ed01c3150 | Analyze and fix the following issue in the Linux kernel code: [NETFILTER]: Fix ip_conntrack_put() prototype. | Problem Details:
The function is not inline.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/include/linux/netfilter_ipv4/ip_conntrack.h b/include/linux/netfilter_ipv4/ip_conntrack.h
index f8da7ddeff3a..08fe5f7d14a0 100644
--- a/include/linux/netfilter_ipv4/ip_conntrack.h
+++ b/include/linux/netfilter_ipv4/ip_conntrack.h
@@ -239,7 +239,7 @@ ip_conntrack_get(const struct sk_buff *skb, enum ... |
18586e721636527cb5177467fb17e2350615978a | Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix RLIMIT_RTPRIO breakage | Problem Details:
RLIMIT_RTPRIO is supposed to grant non privileged users the right to use
SCHED_FIFO/SCHED_RR scheduling policies with priorites bounded by the
RLIMIT_RTPRIO value via sched_setscheduler(). This is usually used by
audio users.
Unfortunately this is broken in 2.6.13rc3 as you can see in the excerpt
from... | ```diff
diff --git a/kernel/sched.c b/kernel/sched.c
index 4107db0dc091..a5fb654ea590 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -3528,7 +3528,8 @@ recheck:
*/
if (!capable(CAP_SYS_NICE)) {
/* can't change policy */
- if (policy != p->policy)
+ if (policy != p->policy &&
+ !p->signal->rlim[RLIMIT_R... |
db776a14f327c20d4984ac4b724a934df34bfe31 | Analyze and fix the following issue in the Linux kernel code: Fix compiler warning in qla_iocb.c | Problem Details:
Remove bogus initialization that was re-done (correctly) later. | ```diff
diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c
index 5f3450429cd0..ebdc3c54d155 100644
--- a/drivers/scsi/qla2xxx/qla_iocb.c
+++ b/drivers/scsi/qla2xxx/qla_iocb.c
@@ -748,7 +748,7 @@ qla24xx_start_scsi(srb_t *sp)
uint16_t cnt;
uint16_t req_cnt;
uint16_t tot_dsds;
- struct d... |
d8e392e7c8f019657ff3ebe70a45d234990831db | Analyze and fix the following issue in the Linux kernel code: [PATCH] machine_shutdown: Typo fix to actually allow specifying which cpu to reboot on | Problem Details:
This appears to be a typo I introduced when cleaning
this code up earlier. Ooops.
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/arch/i386/kernel/reboot.c b/arch/i386/kernel/reboot.c
index d473350aa055..1049876702aa 100644
--- a/arch/i386/kernel/reboot.c
+++ b/arch/i386/kernel/reboot.c
@@ -284,7 +284,7 @@ void machine_shutdown(void)
reboot_cpu_id = 0;
/* See if there has been given a command line override */
- if ((reb... |
f82567e55fcd25bb7addf2cfd8b79f36f409dc2e | Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix watchdog drivers to call emergency_reboot() | Problem Details:
If a watchdog driver has decided it is time to reboot the system
we know something is wrong and we are in interrupt context
so emergency_reboot() is what we want.
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/drivers/char/watchdog/eurotechwdt.c b/drivers/char/watchdog/eurotechwdt.c
index d10e554a14d6..f1016e3ba117 100644
--- a/drivers/char/watchdog/eurotechwdt.c
+++ b/drivers/char/watchdog/eurotechwdt.c
@@ -167,7 +167,7 @@ static irqreturn_t eurwdt_interrupt(int irq, void *dev_id, struct pt_regs *regs)
... |
7c9a90073c75bffbb89763a0c7d44a2e44e9e628 | Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: Fix reboot_force | Problem Details:
We only want to shutdown the apics if reboot_force
is not specified. Be we are doing this both
in machine_shutdown which is called unconditionally
and if (!reboot_force). So simply call machine_shutdown
if (!reboot_force). It looks like something
went weird with merging some of the kexec patches for... | ```diff
diff --git a/arch/x86_64/kernel/reboot.c b/arch/x86_64/kernel/reboot.c
index 0515d3266634..d4c45ff92d5c 100644
--- a/arch/x86_64/kernel/reboot.c
+++ b/arch/x86_64/kernel/reboot.c
@@ -115,15 +115,8 @@ void machine_restart(char * __unused)
printk("machine restart\n");
- machine_shutdown();
-
if (!reboot_f... |
16dcb4bbda579c4e3d80048b755ac124d8fab21a | Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix the arguments to machine_restart on cris | Problem Details:
It appears machine_restart has been working cris just
by luck.
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/arch/cris/kernel/process.c b/arch/cris/kernel/process.c
index 9f7cad7c7849..7645c4d4de6f 100644
--- a/arch/cris/kernel/process.c
+++ b/arch/cris/kernel/process.c
@@ -113,6 +113,7 @@
#include <linux/user.h>
#include <linux/elfcore.h>
#include <linux/mqueue.h>
+#include <linux/reboot.h>
//#defi... |
a6fa657b9d5c892c6a92912632c4b5715955b4f8 | Analyze and fix the following issue in the Linux kernel code: [PATCH] qla2xxx: Kconfig dependency fix | Problem Details:
*** Warning: "fc_remote_port_block" [drivers/scsi/qla2xxx/qla2xxx.ko] undefined!
*** Warning: "scsi_is_fc_rport" [drivers/scsi/qla2xxx/qla2xxx.ko] undefined!
*** Warning: "fc_remote_port_unblock" [drivers/scsi/qla2xxx/qla2xxx.ko] undefined!
*** Warning: "fc_remote_port_rolechg" [drivers/scsi/qla2xxx/ql... | ```diff
diff --git a/drivers/scsi/qla2xxx/Kconfig b/drivers/scsi/qla2xxx/Kconfig
index 6c73b84c6e64..fccecf67423e 100644
--- a/drivers/scsi/qla2xxx/Kconfig
+++ b/drivers/scsi/qla2xxx/Kconfig
@@ -2,6 +2,7 @@ config SCSI_QLA2XXX
tristate
default (SCSI && PCI)
depends on SCSI && PCI
+ select SCSI_FC_ATTRS
config ... |
9a168bddc2f13686336a86f8235b84347edac13a | Analyze and fix the following issue in the Linux kernel code: [PATCH] qla: remove anonymous union | Problem Details:
Older gcc's dont support anonymous unions, so this driver gets hundreds of
error.
Fortunately the fix is easy...
Cc: James Bottomley <James.Bottomley@steeleye.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
index acf40dcbfb30..1c6d366f4fad 100644
--- a/drivers/scsi/qla2xxx/qla_def.h
+++ b/drivers/scsi/qla2xxx/qla_def.h
@@ -451,11 +451,9 @@ struct device_reg_2xxx {
} u_end;
};
-typedef struct {
- union {
+typedef union {
struct dev... |
89373de7dd010832d8b68cb37dabb33ff5a688bb | Analyze and fix the following issue in the Linux kernel code: [PATCH] inotify: fix oops fix | Problem Details:
Cc: Robert Love <rml@novell.com>
Cc: John McCutchan <ttb@tentacle.dhs.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/fs/inotify.c b/fs/inotify.c
index cdfff9067149..a8a714e48140 100644
--- a/fs/inotify.c
+++ b/fs/inotify.c
@@ -1032,7 +1032,7 @@ static int __init inotify_setup(void)
panic("inotify: register_filesystem returned %d!\n", ret);
inotify_mnt = kern_mount(&inotify_fs_type);
- if (unlikely(PTR_ERR(... |
783bc29bbc5d6625a4669d3eb1d989a8fb275d43 | Analyze and fix the following issue in the Linux kernel code: [PATCH] inotify: oops fix | Problem Details:
Bug fix: Ensure that the fd passed to inotify_add_watch() and
inotify_rm_watch() belongs to inotify.
Signed-off-by: Robert Love <rml@novell.com>
Signed-off-by: John McCutchan <ttb@tentacle.dhs.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/fs/inotify.c b/fs/inotify.c
index 807209f0bcda..b55d6e4a0911 100644
--- a/fs/inotify.c
+++ b/fs/inotify.c
@@ -929,6 +929,12 @@ asmlinkage long sys_inotify_add_watch(int fd, const char __user *path, u32 mask)
if (unlikely(!filp))
return -EBADF;
+ /* verify that this is indeed an inotify insta... |
b680716ed28baf549f777fb125fc23ba975985c5 | Analyze and fix the following issue in the Linux kernel code: [PATCH] inotify: misc. cleanup | Problem Details:
Miscellaneous invariant clean up, comment fixes, and so on. Trivial
stuff.
Signed-off-by: Robert Love <rml@novell.com>
Signed-off-by: John McCutchan <ttb@tentacle.dhs.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/fs/inotify.c b/fs/inotify.c
index 54757be888b6..a87926584cd2 100644
--- a/fs/inotify.c
+++ b/fs/inotify.c
@@ -62,8 +62,8 @@ int inotify_max_queued_events;
* Lifetimes of the three main data structures--inotify_device, inode, and
* inotify_watch--are managed by reference count.
*
- * inotify_d... |
821ca478867433502fc614b4be83e0362cd7e67e | Analyze and fix the following issue in the Linux kernel code: [PATCH] ARM: 2830/1: Fix Jornada 720 PCMCIA-support | Problem Details:
Patch from Michael Gernoth
This patch lets the Jornada 720 PCMCIA-driver compile again. The
resulting driver has been tested on a Jornada with a CF-card, which
was mounted and accessed successfully.
Signed-off-by: Michael Gernoth <michael@gernoth.net>
Signed-off-by: Russell King <rmk+kernel@arm.linux... | ```diff
diff --git a/drivers/pcmcia/sa1100_jornada720.c b/drivers/pcmcia/sa1100_jornada720.c
index 0a387106acb0..7a87298bae99 100644
--- a/drivers/pcmcia/sa1100_jornada720.c
+++ b/drivers/pcmcia/sa1100_jornada720.c
@@ -30,20 +30,9 @@ static int jornada720_pcmcia_hw_init(struct soc_pcmcia_socket *skt)
*/
GRER |= ... |
02cdad3f932d533e5cbde1b15092418ce7af1a70 | Analyze and fix the following issue in the Linux kernel code: [PATCH] ARM: 2819/1: Fix several S3C24x0 IIS defines | Problem Details:
Patch from Dimitry Andric
- Change S3C2440_IISCON_MPLL to S3C2440_IISMOD_MPLL:
The S3C2440 IISCON register doesn\'t control the master clock selection, this is done with the IISMOD register.
- Correct S3C2410_IISMOD_256FS and S3C2410_IISMOD_384FS:
This is set via bit 2 of IISMOD, not bit 1.
- Add ... | ```diff
diff --git a/include/asm-arm/arch-s3c2410/regs-iis.h b/include/asm-arm/arch-s3c2410/regs-iis.h
index 385b07d510da..fdd62e8cd6cb 100644
--- a/include/asm-arm/arch-s3c2410/regs-iis.h
+++ b/include/asm-arm/arch-s3c2410/regs-iis.h
@@ -15,6 +15,9 @@
* 12-03-2004 BJD Updated include protection
* 07-... |
18190cc08d70a6ec8ef69f0f6ede021f7cb3f9b8 | Analyze and fix the following issue in the Linux kernel code: JFS: Fix i_blocks accounting when allocation fails | Problem Details:
A failure in dbAlloc caused a directory's i_blocks to be incorrectly
incremented, causing jfs_fsck to find the inode to be corrupt.
Signed-off-by: Dave Kleikamp <shaggy@austin.ibm.com> | ```diff
diff --git a/fs/jfs/jfs_dtree.c b/fs/jfs/jfs_dtree.c
index 73b5fc7eda80..404f33eae507 100644
--- a/fs/jfs/jfs_dtree.c
+++ b/fs/jfs/jfs_dtree.c
@@ -381,9 +381,12 @@ static u32 add_index(tid_t tid, struct inode *ip, s64 bn, int slot)
* It's time to move the inline table to an external
* page and begin to ... |
2a691470345a0024dd7ffaf47ad3d0f5f4f41924 | Analyze and fix the following issue in the Linux kernel code: kbuild: fix make O=... | Problem Details:
kbuild failed to locate Kbuild.include.
Teach kbuild how to find Kbuild files when using make O=...
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
--- | ```diff
diff --git a/Makefile b/Makefile
index 7c607dc64479..ed1f4b5b714f 100644
--- a/Makefile
+++ b/Makefile
@@ -310,7 +310,7 @@ cc-version = $(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-version.sh \
MAKEFLAGS += --include-dir=$(srctree)
# We need some generic definitions
-include scripts/Kbuild.include
+includ... |
7c6b155fb49fbc63e0b30a1d49552693c0b45be7 | Analyze and fix the following issue in the Linux kernel code: kbuild: drop descend - converting existing users | Problem Details:
There was only two users left of descend. Fix them so they
use $(clean)= and $(build)=.
Drop definition of descend.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
--- | ```diff
diff --git a/Makefile b/Makefile
index 77198748ad71..7e4624a14586 100644
--- a/Makefile
+++ b/Makefile
@@ -1356,11 +1356,6 @@ build := -f $(if $(KBUILD_SRC),$(srctree)/)scripts/Makefile.build obj
# $(Q)$(MAKE) $(clean)=dir
clean := -f $(if $(KBUILD_SRC),$(srctree)/)scripts/Makefile.clean obj
-# $(call desce... |
43af5f23354dbd67d2fd2d523eefad8053ac388b | Analyze and fix the following issue in the Linux kernel code: kbuild: drop -Wundef from HOSTCFLAGS for now | Problem Details:
-Wundef caused warnings in the bison generated code in kconfig.
Updating to a newer bison (1.875d) did not fix it. The alternatives
was to correct the autogenerated code or drop -Wundef.
For now -Wundef is dropped from HOSTCFLAGS.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
--- | ```diff
diff --git a/Makefile b/Makefile
index 423397f03921..77198748ad71 100644
--- a/Makefile
+++ b/Makefile
@@ -203,7 +203,7 @@ CONFIG_SHELL := $(shell if [ -x "$$BASH" ]; then echo $$BASH; \
HOSTCC = gcc
HOSTCXX = g++
-HOSTCFLAGS = -Wall -Wundef -Wstrict-prototypes -O2 -fomit-frame-pointer
+HOSTCFLAGS = -Wa... |
4b502421aac89c8d4e61ecc89a70065a33305a0b | Analyze and fix the following issue in the Linux kernel code: [SPARC]: Fix __KERNEL_SYSCALLS__ defining in envctrl.c and bbc_envctrl.c | Problem Details:
It needs to happen before any header includes because nowadays
some things implicitly include asm/unistd.h which ends up being
before the __KERNEL_SYSCALLS__ define gets done.
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/drivers/sbus/char/bbc_envctrl.c b/drivers/sbus/char/bbc_envctrl.c
index d5259f7fee6d..b8a2c7353b0a 100644
--- a/drivers/sbus/char/bbc_envctrl.c
+++ b/drivers/sbus/char/bbc_envctrl.c
@@ -4,13 +4,14 @@
* Copyright (C) 2001 David S. Miller (davem@redhat.com)
*/
+#define __KERNEL_SYSCALLS__
+
#i... |
227510c7f175c44b12cdff6eab316e53dbf71f92 | Analyze and fix the following issue in the Linux kernel code: [IPV6]: fix implicit declaration of function `xfrm6_tunnel_unregister' | Problem Details:
Signed-off-by: Cal Peake <cp@absolutedigital.net>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c
index f39ddeae1eef..09613729404c 100644
--- a/net/ipv6/ip6_tunnel.c
+++ b/net/ipv6/ip6_tunnel.c
@@ -1123,7 +1123,7 @@ static inline int ip6ip6_register(void)
static inline int ip6ip6_unregister(void)
{
- return xfrm6_tunnel_unregister(&ip6ip6_handle... |
4e8fd22bd421d7aa279bcb76189505a1f96bb7bf | Analyze and fix the following issue in the Linux kernel code: [PATCH] ARM SMP: Fix ARMv6 spinlock and semaphore implementations | Problem Details:
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> | ```diff
diff --git a/include/asm-arm/locks.h b/include/asm-arm/locks.h
index c26298f3891f..9cb33fcc06c1 100644
--- a/include/asm-arm/locks.h
+++ b/include/asm-arm/locks.h
@@ -61,7 +61,7 @@
" strex ip, lr, [%0]\n" \
" teq ip, #0\n" \
" bne 1b\n" \
-" teq lr, #0\n" \
+" cmp lr, #0\n" \
" movle ip, %0\n" ... |
33fdfa97f2b3aab698ef849ec50dcc5102017f0a | Analyze and fix the following issue in the Linux kernel code: Input: synaptics - fix setting packet size on passthrough port. | Problem Details:
Synaptics driver used child->type to select either 3-byte or 4-byte
packet size for the pass-through port; this gives wrong results for
the newer protocols. Change the check to use child->pktsize instead.
Signed-off-by: Sergey Vlasov <vsu@altlinux.ru>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru> | ```diff
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 39cc1e51b908..029309422409 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -219,7 +219,7 @@ static void synaptics_pass_pt_packet(struct serio *ptport, unsigned char *packet
serio_interru... |
668d74c04c16bb69de564e25e85dd94eeb0175d9 | Analyze and fix the following issue in the Linux kernel code: ACPI: delete unnecessary EC console messages | Problem Details:
http://bugzilla.kernel.org/show_bug.cgi?id=4534
Signed-off-by: Luming Yu <luming.yu@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com> | ```diff
diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index 8e665f2e3138..fca4140a50a9 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -170,22 +170,19 @@ acpi_ec_enter_burst_mode (
status = acpi_ec_read_status(ec);
if (status != -EINVAL &&
!(status & ACPI_EC_FLAG_BURST)){
- ACPI_DEBUG_PRINT((ACPI... |
d3984a6b6abac6203868f0e9095c0ed9e33ece03 | Analyze and fix the following issue in the Linux kernel code: [NETFILTER]: Fix ip6t_LOG MAC format | Problem Details:
I broke this in the patch that consolidated MAC logging.
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/ipv6/netfilter/ip6t_LOG.c b/net/ipv6/netfilter/ip6t_LOG.c
index c44685e391b7..a692e26a4fa3 100644
--- a/net/ipv6/netfilter/ip6t_LOG.c
+++ b/net/ipv6/netfilter/ip6t_LOG.c
@@ -373,9 +373,10 @@ ip6t_log_packet(unsigned int hooknum,
in ? in->name : "",
out ? out->name : "");
if (in && !out)... |
21f930e4abdcb9649f26e5b959c14dddee4e600b | Analyze and fix the following issue in the Linux kernel code: [NETFILTER]: Wait until all references to ip_conntrack_untracked are dropped on unload | Problem Details:
Fixes a crash when unloading ip_conntrack.
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/ipv4/netfilter/ip_conntrack_core.c b/net/ipv4/netfilter/ip_conntrack_core.c
index 14af55cad5d6..63bf88264980 100644
--- a/net/ipv4/netfilter/ip_conntrack_core.c
+++ b/net/ipv4/netfilter/ip_conntrack_core.c
@@ -1107,6 +1107,9 @@ void ip_conntrack_cleanup(void)
schedule();
goto i_see_dead_p... |
d04b4f8c1c9766e49fad6a141fc61cb30db69a5c | Analyze and fix the following issue in the Linux kernel code: [NETFILTER]: Fix potential memory corruption in NAT code (aka memory NAT) | Problem Details:
The portptr pointing to the port in the conntrack tuple is declared static,
which could result in memory corruption when two packets of the same
protocol are NATed at the same time and one conntrack goes away.
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davem... | ```diff
diff --git a/net/ipv4/netfilter/ip_nat_proto_tcp.c b/net/ipv4/netfilter/ip_nat_proto_tcp.c
index a91cfceff272..a98e36d2b3c6 100644
--- a/net/ipv4/netfilter/ip_nat_proto_tcp.c
+++ b/net/ipv4/netfilter/ip_nat_proto_tcp.c
@@ -40,7 +40,8 @@ tcp_unique_tuple(struct ip_conntrack_tuple *tuple,
enum ip_nat_manip_ty... |
4c1217deeb148ff8ab838ba4f1875d0f52dea343 | Analyze and fix the following issue in the Linux kernel code: [NETFILTER]: Fix deadlock in ip6_queue | Problem Details:
Already fixed in ip_queue, ip6_queue was missed.
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/ipv6/netfilter/ip6_queue.c b/net/ipv6/netfilter/ip6_queue.c
index 750943e2d34e..5493180f0d44 100644
--- a/net/ipv6/netfilter/ip6_queue.c
+++ b/net/ipv6/netfilter/ip6_queue.c
@@ -76,7 +76,9 @@ static DECLARE_MUTEX(ipqnl_sem);
static void
ipq_issue_verdict(struct ipq_queue_entry *entry, int ver... |
b339a18b81a1f6ca1455559594f5df872b9e59f4 | Analyze and fix the following issue in the Linux kernel code: Fix up incorrect "unlikely()" on %gs reload in x86 __switch_to | Problem Details:
These days %gs is normally the TLS segment, so it's no longer zero. As
a result, we shouldn't just assume that %fs/%gs tend to be zero
together, but test them independently instead.
Also, fix setting of debug registers to use the "next" pointer instead
of "current". It so happens that the scheduler ... | ```diff
diff --git a/arch/i386/kernel/process.c b/arch/i386/kernel/process.c
index ba243a4cc119..d9492058aaf3 100644
--- a/arch/i386/kernel/process.c
+++ b/arch/i386/kernel/process.c
@@ -700,23 +700,27 @@ struct task_struct fastcall * __switch_to(struct task_struct *prev_p, struct tas
/*
* Restore %fs and %gs if... |
c40c202493d18de42fcd0b8b5d68c22aefb70f03 | Analyze and fix the following issue in the Linux kernel code: JFS: Fix typo in last patch | Problem Details:
Signed-off-by: Dave Kleikamp <shaggy@austin.ibm.com> | ```diff
diff --git a/fs/jfs/jfs_metapage.c b/fs/jfs/jfs_metapage.c
index 02add5d8ff89..13d7e3f1feb4 100644
--- a/fs/jfs/jfs_metapage.c
+++ b/fs/jfs/jfs_metapage.c
@@ -640,7 +640,7 @@ struct metapage *__get_metapage(struct inode *inode, unsigned long lblock,
} else {
page = read_cache_page(mapping, page_index,
... |
d178817803d95e4e3ca270bccd1ae2bed4780977 | Analyze and fix the following issue in the Linux kernel code: [PATCH] kbuild: make help binrpm-pkg fix | Problem Details:
This fixes kbuild make help binrpm-pkg missing `''.
Signed-off-by: Coywolf Qi Hunt <coywolf@lovecn.org>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org> | ```diff
diff --git a/scripts/package/Makefile b/scripts/package/Makefile
index 8afdef921cb7..f3e7e8e4a500 100644
--- a/scripts/package/Makefile
+++ b/scripts/package/Makefile
@@ -94,7 +94,7 @@ clean-dirs += $(objtree)/tar-install/
# ---------------------------------------------------------------------------
help:
@... |
b72f6eccb0fc516070f2de469f73870cb6cb1149 | Analyze and fix the following issue in the Linux kernel code: [NET]: Fix tc_verd thinko in skb_clone() | Problem Details:
It was overwriting the computer n->tc_verd value over
and over with skb->tc_verd, by mistake.
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index d9f7b06fe886..7eab867ede59 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -377,8 +377,8 @@ struct sk_buff *skb_clone(struct sk_buff *skb, unsigned int __nocast gfp_mask)
C(tc_index);
#ifdef CONFIG_NET_CLS_ACT
n->tc_verd = SET_TC_VERD(skb->... |
88e9fa8a54cf4d66ee8fc1d855e82de827233d74 | Analyze and fix the following issue in the Linux kernel code: [ATM]: Trivial spelling fix patch for net/Kconfig | Problem Details:
Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Chas Williams <chas@cmf.nrl.navy.mil>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/atm/Kconfig b/net/atm/Kconfig
index bea2426229b1..21ff276b2d80 100644
--- a/net/atm/Kconfig
+++ b/net/atm/Kconfig
@@ -60,7 +60,7 @@ config ATM_BR2684
tristate "RFC1483/2684 Bridged protocols"
depends on ATM && INET
help
- ATM PVCs can carry ethernet PDUs according to rfc2684 (formerly 1... |
5938a7b580bb7a738ee349048565ac76e6f3f5d7 | Analyze and fix the following issue in the Linux kernel code: [ATM]: [ambassador] Fix the sparse warning "implicit cast to nocast type" | Problem Details:
Signed-off-by: Victor Fusco <victor@cetuc.puc-rio.br>
Signed-off-by: Domen Puncer <domen@coderock.org>
Signed-off-by: Chas Williams <chas@cmf.nrl.navy.mil>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassador.c
index c46d9520c5a7..73c6b85299c1 100644
--- a/drivers/atm/ambassador.c
+++ b/drivers/atm/ambassador.c
@@ -794,7 +794,9 @@ static void drain_rx_pools (amb_dev * dev) {
drain_rx_pool (dev, pool);
}
-static inline void fill_rx_pool (amb_dev *... |
c9e42614585dddd544a56907ff5fd5ca55411967 | Analyze and fix the following issue in the Linux kernel code: [ATM]: [firestream] fix the sparse warning "implicit cast to nocast type" | Problem Details:
Signed-off-by: Victor Fusco <victor@cetuc.puc-rio.br>
Signed-off-by: Domen Puncer <domen@coderock.org>
Signed-off-by: Chas Williams <chas@cmf.nrl.navy.mil>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/drivers/atm/firestream.c b/drivers/atm/firestream.c
index 101f0cc33d10..b078fa548ebf 100644
--- a/drivers/atm/firestream.c
+++ b/drivers/atm/firestream.c
@@ -1374,7 +1374,8 @@ static void reset_chip (struct fs_dev *dev)
}
}
-static void __devinit *aligned_kmalloc (int size, int flags, int alig... |
6876f95f201ce2d62367d85dd793c1fee351d7a6 | Analyze and fix the following issue in the Linux kernel code: [IPV4]: fix IP_FIB_HASH kconfig warning | Problem Details:
This patch fixes the following kconfig warning:
net/ipv4/Kconfig:92:warning: defaults for choice values not supported
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
index df5386885a90..ecea2bc8229f 100644
--- a/net/ipv4/Kconfig
+++ b/net/ipv4/Kconfig
@@ -54,9 +54,9 @@ config IP_ADVANCED_ROUTER
choice
prompt "Choose IP: FIB lookup algorithm (choose FIB_HASH if unsure)"
depends on IP_ADVANCED_ROUTER
- default IP_FIB_HASH... |
54208991e15fa00e37a9d172ac0d87191a832165 | Analyze and fix the following issue in the Linux kernel code: [NET]: Kconfig: NETCONSOLE and NETPOLL together | Problem Details:
Put NETCONSOLE and NETPOLL options together since they are related.
This cuts down on the hassle of flipping back and forth between
the Networking menu and the Network drivers menu to change their
config settings.
Tested with menuconfig, gconfig, and xconfig.
gconfig has a small problem with this. I ... | ```diff
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 9a07ff7a7777..f827f0a1e1a6 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -2549,4 +2549,20 @@ config NETCONSOLE
If you want to log kernel messages over the network, enable this.
See <file:Documentation/networking/netconsole.txt> for... |
d1ad1ff299dd908d07c5e5f27f88bbdb235eb7a5 | Analyze and fix the following issue in the Linux kernel code: [SCTP]: Fix potential null pointer dereference while handling an icmp error | Problem Details:
Signed-off-by: Sridhar Samudrala <sri@us.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/include/net/sctp/sctp.h b/include/net/sctp/sctp.h
index 4a26adfaed71..e1d5ec1c23c0 100644
--- a/include/net/sctp/sctp.h
+++ b/include/net/sctp/sctp.h
@@ -167,15 +167,12 @@ void sctp_unhash_established(struct sctp_association *);
void sctp_hash_endpoint(struct sctp_endpoint *);
void sctp_unhash_en... |
e2bf521d9728bfae9b6c3d484614e5962d0b5afd | Analyze and fix the following issue in the Linux kernel code: [NET]: Fix "nocast type" warnings in skbuff.h | Problem Details:
From: Victor Fusco <victor@cetuc.puc-rio.br>
Fix the sparse warning "implicit cast to nocast type"
Signed-off-by: Victor Fusco <victor@cetuc.puc-rio.br>
Signed-off-by: Domen Puncer <domen@coderock.org>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 5d4a990d5577..0061c9470482 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -502,7 +502,8 @@ static inline struct sk_buff *skb_share_check(struct sk_buff *skb,
*
* %NULL is returned on a memory allocation failure.
*/
-st... |
37da647d994cdac7e0bc8d2a365fbda403939a2b | Analyze and fix the following issue in the Linux kernel code: [NETLINK]: Fix "nocast type" warnings | Problem Details:
From: Victor Fusco <victor@cetuc.puc-rio.br>
Fix the sparse warning "implicit cast to nocast type"
Signed-off-by: Victor Fusco <victor@cetuc.puc-rio.br>
Signed-off-by: Domen Puncer <domen@coderock.org>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index 3405fdf41b93..ff774a06c89d 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -648,7 +648,8 @@ void netlink_detachskb(struct sock *sk, struct sk_buff *skb)
sock_put(sk);
}
-static inline struct sk_buff *netlink_trim... |
b7523418f6af9093c462341c08c2233f44f7a28d | Analyze and fix the following issue in the Linux kernel code: [PATCH] ARM: 2815/1: Shark: new defconfig, fixes with __io and serial ports | Problem Details:
Patch from Alexander Schulz
This patch brings a new default config file for the shark and
fixes a compilation issue with io addressing and a runtime
problem with the serial ports, where I corrected a wrong
regshift value.
These are all shark specific files so I hope it is ok to
put them in one patch.
... | ```diff
diff --git a/arch/arm/configs/shark_defconfig b/arch/arm/configs/shark_defconfig
index 1d9bcbbc8dfc..271823f0d708 100644
--- a/arch/arm/configs/shark_defconfig
+++ b/arch/arm/configs/shark_defconfig
@@ -1,22 +1,21 @@
#
# Automatically generated make config: don't edit
-# Linux kernel version: 2.6.12-rc1-bk2
-... |
19870da7ea2fc483bf73a189046a430fd9b01391 | Analyze and fix the following issue in the Linux kernel code: [MTD] NAND: Fix broken bad block scan for 16 bit devices | Problem Details:
The previous change to read a single byte from oob breaks the
bad block scan on 16 bit devices, when the byte is on an odd
address. Read the complete oob for now.
Remove the unused arguments from check_short_pattern()
Move the wait for ready function so it is only executed when
consecutive reads happen... | ```diff
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index 1bd71a598c79..eee5115658c8 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -59,7 +59,7 @@
* The AG-AND chips have nice features for speed improvement,
* which are not supported yet. Read / program ... |
9fb1759a3102c26cd8f64254a7c3e532782c2bb8 | Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: TASK_SIZE fixes for compatibility mode processes | Problem Details:
A malicious 32bit app can have an elf section at 0xffffe000. During
exec of this app, we will have a memory leak as insert_vm_struct() is
not checking for return value in syscall32_setup_pages() and thus not
freeing the vma allocated for the vsyscall page.
Check the return value and free the vma inca... | ```diff
diff --git a/arch/x86_64/ia32/syscall32.c b/arch/x86_64/ia32/syscall32.c
index 01d8db1a1c09..816a3b89f13d 100644
--- a/arch/x86_64/ia32/syscall32.c
+++ b/arch/x86_64/ia32/syscall32.c
@@ -57,6 +57,7 @@ int syscall32_setup_pages(struct linux_binprm *bprm, int exstack)
int npages = (VSYSCALL32_END - VSYSCALL32_B... |
38d84c3bd6dd22bdb1f797c87006931133d71aea | Analyze and fix the following issue in the Linux kernel code: [PATCH] dvb: cx88 output mode fix | Problem Details:
The output_mode needs to be set for the Hauppauge Nova-T DVB-T
(cx88-dvb.c).
Cc: Johannes Stezenbach <js@linuxtv.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/drivers/media/video/cx88/cx88-dvb.c b/drivers/media/video/cx88/cx88-dvb.c
index 00ca40a129b9..6ad1458ab652 100644
--- a/drivers/media/video/cx88/cx88-dvb.c
+++ b/drivers/media/video/cx88/cx88-dvb.c
@@ -180,12 +180,14 @@ static struct mt352_config dntv_live_dvbt_config = {
#if CONFIG_DVB_CX22702
s... |
a1287ba1ba810aae1f8b81e32560d5d3bf3ff9f0 | Analyze and fix the following issue in the Linux kernel code: [PATCH] rocket.c: Fix ldisc ref count handling | Problem Details:
If bailing out because there is nothing to receive in rp_do_receive(),
tty_ldisc_deref is not called. Failure to do so increases the ref count
and causes release_dev() to hang since it can't get the ref count to 0.
Signed-off-by: Michal Ostrowski <mostrows@watson.ibm.com>
Signed-off-by: Andrew Morton... | ```diff
diff --git a/drivers/char/rocket.c b/drivers/char/rocket.c
index f463d6baa685..5b1d3680c8ab 100644
--- a/drivers/char/rocket.c
+++ b/drivers/char/rocket.c
@@ -355,7 +355,7 @@ static void rp_do_receive(struct r_port *info,
ToRecv = space;
if (ToRecv <= 0)
- return;
+ goto done;
/*
* if status ind... |
afa597ba20e9ef55fc6283c1a564854b1c9f13c0 | Analyze and fix the following issue in the Linux kernel code: [PATCH] execute-in-place fixes | Problem Details:
This patch includes feedback from Andrew and Christoph. Thanks for
taking time to review.
Use of empty_zero_page was eliminated to fix compilation for architectures
that don't have it.
This patch removes setting pages up-to-date in ext2_get_xip_page and all
bug checks to verify that the page is indee... | ```diff
diff --git a/fs/ext2/xip.c b/fs/ext2/xip.c
index d44431d1a338..0aa5ac159c09 100644
--- a/fs/ext2/xip.c
+++ b/fs/ext2/xip.c
@@ -15,66 +15,79 @@
#include "xip.h"
static inline int
-__inode_direct_access(struct inode *inode, sector_t sector, unsigned long *data) {
+__inode_direct_access(struct inode *inode, se... |
c5287ba132ff742e595d42c28b66cbba19522c4e | Analyze and fix the following issue in the Linux kernel code: [PATCH] v4l: bug fixes for tuner, cx88 and tea5767 | Problem Details:
- In CX88 code, some cards needs to have audio reprogramed after changing
video channel;
- Tuner autodetection code seems not to work on some cards. Now,
no_autodetect insmod option allows disabling autodetection code;
- Minor fixes in tea5767 to reduce integer trunc;
- There are some new Pixel... | ```diff
diff --git a/drivers/media/video/cx88/cx88-cards.c b/drivers/media/video/cx88/cx88-cards.c
index b0b47c3cde3c..3d0c784b376f 100644
--- a/drivers/media/video/cx88/cx88-cards.c
+++ b/drivers/media/video/cx88/cx88-cards.c
@@ -1,5 +1,5 @@
/*
- * $Id: cx88-cards.c,v 1.85 2005/07/04 19:35:05 mkrufky Exp $
+ * $Id: c... |
1eb29128c644581fa51f822545921394ad4f719f | Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix raid0's attempt to divide by 64bit numbers | Problem Details:
Apparently sector_div is only guaranteed to work with a 32bit divisor, even
on 64bit architectures. So allow for this in raid0.
Signed-off-by: Neil Brown <neilb@cse.unsw.edu.au>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c
index e11dd14d0b43..2120710172c5 100644
--- a/drivers/md/raid0.c
+++ b/drivers/md/raid0.c
@@ -314,16 +314,16 @@ static int raid0_run (mddev_t *mddev)
sector_t space = conf->hash_spacing;
int round;
conf->preshift = 0;
- if (sizeof(sector_t) > sizeof... |
030babac6ae54df64ae3bba4685ecb1d8d8dd8c3 | Analyze and fix the following issue in the Linux kernel code: [PATCH] vt.c build fix | Problem Details:
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/drivers/char/vt.c b/drivers/char/vt.c
index d7aa7a29f67e..30d96739fb23 100644
--- a/drivers/char/vt.c
+++ b/drivers/char/vt.c
@@ -2796,7 +2796,7 @@ void do_blank_screen(int entering_gfx)
return;
if (vesa_off_interval) {
- blank_state = blank_vesa_wait,
+ blank_state = blank_vesa_wait;
m... |
9d853c3757ef74ded5ae564d68370f22208fb88b | Analyze and fix the following issue in the Linux kernel code: [CRYPTO]: Fix zero-extension bug on 64-bit architectures. | Problem Details:
Noticed by Ken-ichirou MATSUZAWA.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/crypto/cipher.c b/crypto/cipher.c
index 1c92c6bb138b..8da644364cb4 100644
--- a/crypto/cipher.c
+++ b/crypto/cipher.c
@@ -41,7 +41,7 @@ static unsigned int crypt_slow(const struct cipher_desc *desc,
struct scatter_walk *in,
struct scatter_walk *out, unsigned int bsize)
{
- un... |
d5b454f2c40c9efd0cc113bc3220ebcb66b7c022 | Analyze and fix the following issue in the Linux kernel code: AUDIT: Fix livelock in audit_serial(). | Problem Details:
The tricks with atomic_t were bizarre. Just do it sensibly instead.
Signed-off-by: David Woodhouse <dwmw2@infradead.org> | ```diff
diff --git a/kernel/audit.c b/kernel/audit.c
index 518a833b676a..27ffcf363f8d 100644
--- a/kernel/audit.c
+++ b/kernel/audit.c
@@ -610,26 +610,25 @@ err:
* (timestamp,serial) tuple is unique for each syscall and is live from
* syscall entry to syscall exit.
*
- * Atomic values are only guaranteed to be 24... |
5d157885f383ccc0660c011fa488ae4edb77ab16 | Analyze and fix the following issue in the Linux kernel code: [JFFS2] Fix node allocation leak | Problem Details:
In the rare case of failing to write the cleanmarker
the allocated node was not freed.
Pointed out by Forrest Zhao
Initial cleanup by Joern Engel
Signed-off-by: Thomas Gleixner <tglx@linutronix.de> | ```diff
diff --git a/fs/jffs2/erase.c b/fs/jffs2/erase.c
index 6a4c0a3685da..787d84ac2bcd 100644
--- a/fs/jffs2/erase.c
+++ b/fs/jffs2/erase.c
@@ -7,7 +7,7 @@
*
* For licensing information, see the file 'LICENCE' in this directory.
*
- * $Id: erase.c,v 1.76 2005/05/03 15:11:40 dedekind Exp $
+ * $Id: erase.c,v 1.... |
f4cfd69cf349dd27e00d5cf804b57aee04e059c2 | Analyze and fix the following issue in the Linux kernel code: [CIFS] Fix path name conversion for long filenames when mapchars mount | Problem Details:
option was specified at mount time.
Signed-off-by: Steve French (sfrench@us.ibm.com) | ```diff
diff --git a/fs/cifs/CHANGES b/fs/cifs/CHANGES
index dab4774ee7bb..3196d4c4eed3 100644
--- a/fs/cifs/CHANGES
+++ b/fs/cifs/CHANGES
@@ -1,3 +1,9 @@
+Version 1.35
+------------
+Add writepage performance improvements. Fix path name conversions
+for long filenames on mounts which were done with "mapchars" mount o... |
946dc121d7d1c606f6bbeb8ae778963a1e2ff59c | Analyze and fix the following issue in the Linux kernel code: kbuild: fix make O=... build | Problem Details:
It fixes the following error:
make[1]: *** No rule to make target `include/asm', needed by `arch/alpha/kernel/asm-offsets.s'. Stop.
Reported by:
From: Jan Dittmer <j.dittmer@portrix.net>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org> | ```diff
diff --git a/Makefile b/Makefile
index a8d41b7d549d..38384f898d61 100644
--- a/Makefile
+++ b/Makefile
@@ -779,7 +779,7 @@ endif
# prepare1 creates a makefile if using a separate output directory
prepare1: prepare2 outputmakefile
-prepare0: prepare1 include/linux/version.h $(objtree)/include/asm \
+prepare0... |
a91f98a284321ffc9eb28ccfbf4329f7aa422f97 | Analyze and fix the following issue in the Linux kernel code: kbuild: Fix bug in make deb-pkg when using seperate source and output directories | Problem Details:
From: Ryan Anderson <ryan@michonline.com>
When running "make O=something deb-pkg", I get a failure that claims I
haven't configured my kernel (I have). Running it a second time tells
me to run "make mrproper" (include/linux/version.h got built on the
first run)
Original patch from:
From: Ajay Patel... | ```diff
diff --git a/scripts/package/Makefile b/scripts/package/Makefile
index 353b8ea5c32c..8afdef921cb7 100644
--- a/scripts/package/Makefile
+++ b/scripts/package/Makefile
@@ -59,7 +59,7 @@ $(objtree)/binkernel.spec: $(MKSPEC) $(srctree)/Makefile
$(CONFIG_SHELL) $(MKSPEC) prebuilt > $@
binrpm-pkg: $(objtree)/b... |
687c3dac59f1746a1cf877eb52e93046a4998e03 | Analyze and fix the following issue in the Linux kernel code: uml: Make deb-pkg build target build a Debian-style user-mode-linux package | Problem Details:
From: Ryan Anderson <ryan@michonline.com>
Make the deb-pkg build target understand the "um" arch and set up the
package and directory structure to match a mainline-Debian style
user-mode-linux package.
This is primarily so that it stops matching, exactly, the naming
convention used by normal, non-UML... | ```diff
diff --git a/scripts/package/builddeb b/scripts/package/builddeb
index c279b6310f02..bec1a10174ec 100644
--- a/scripts/package/builddeb
+++ b/scripts/package/builddeb
@@ -14,18 +14,38 @@ set -e
# Some variables and settings used throughout the script
version=$KERNELRELEASE
tmpdir="$objtree/debian/tmp"
+packa... |
c5f75eca120de6587e67a1951ce3e6912e2c6879 | Analyze and fix the following issue in the Linux kernel code: kbuild: fix buildcheck | Problem Details:
From: Randy Dunlap <rddunlap@osdl.org>
I should not have added init.text test here;
it's more than useless, it actually degrades the output.
Signed-off-by: Randy Dunlap <rddunlap@osdl.org>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org> | ```diff
diff --git a/scripts/reference_discarded.pl b/scripts/reference_discarded.pl
index 44b8722da0ea..f04f62736851 100644
--- a/scripts/reference_discarded.pl
+++ b/scripts/reference_discarded.pl
@@ -82,8 +82,6 @@ foreach $object (keys(%object)) {
}
if (($line =~ /\.text\.exit$/ ||
$line =~ /\.exit\.te... |
cfca82f2179dd1aee84a5bf3b14710e4d7487aed | Analyze and fix the following issue in the Linux kernel code: kbuild: Fix build as root then user | Problem Details:
From: Matthew Wilcox <matthew@wil.cx>
I inadvertently built a tree as root and then rebuilt it as a user. I
got a lot of prompts ...
mv: overwrite `drivers/char/drm/drm_auth.o', overriding mode 0644?
Using mv -f fixes that.
Signed-off-by: Matthew Wilcox <matthew@wil.cx>
Signed-off-by: Sam Ravnborg ... | ```diff
diff --git a/scripts/Makefile.build b/scripts/Makefile.build
index 76ba6be3dfc9..282bfb310f5b 100644
--- a/scripts/Makefile.build
+++ b/scripts/Makefile.build
@@ -169,7 +169,7 @@ cmd_modversions = \
-T $(@D)/.tmp_$(@F:.o=.ver); \
rm -f $(@D)/.tmp_$(@F) $(@D)/.tmp_$(@F:.o=.ver); \
else \
... |
e10fb91c4dc81a4ae47caf0828df152f600f2546 | Analyze and fix the following issue in the Linux kernel code: [SCSI] fix function prototype warning | Problem Details:
int_to_scsilun() takes a pointer to a struct scsi_lun in it's
prototype, so add this structure to scsi_device.h to avoid declaration
inside function prototype warnings.
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com> | ```diff
diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
index 223f92f4d2cb..835af8ecbb7c 100644
--- a/include/scsi/scsi_device.h
+++ b/include/scsi/scsi_device.h
@@ -9,7 +9,7 @@
struct request_queue;
struct scsi_cmnd;
struct scsi_mode_data;
-
+struct scsi_lun;
/*
* sdev state: If you alter ... |
46906c4415f88cebfad530917bada0835d651824 | Analyze and fix the following issue in the Linux kernel code: [IA64] Fix undefined reference to can_cpei_retarget for simulator | Problem Details:
The simulator build doesn't turn on ACPI, so doesn't have a definition
of can_cpei_retarget.
Signed-off-by: Tony Luck <tony.luck@intel.com> | ```diff
diff --git a/arch/ia64/kernel/topology.c b/arch/ia64/kernel/topology.c
index d8030f3bd865..92ff46ad21e2 100644
--- a/arch/ia64/kernel/topology.c
+++ b/arch/ia64/kernel/topology.c
@@ -36,12 +36,14 @@ int arch_register_cpu(int num)
parent = &sysfs_nodes[cpu_to_node(num)];
#endif /* CONFIG_NUMA */
+#ifdef CON... |
ba460e48064edeb57e3398eb8972c58de33f11ea | Analyze and fix the following issue in the Linux kernel code: [PATCH] Option Card driver update, Maintainer entry | Problem Details:
This patch updates the Option Card driver:
- remove a deadlock
- add sponsor notice
- add new card
- renamed the device to what's usually printed on it
- removed some dead code
- clean up a bunch of irregular whitespace (end-of-line, tabs)
Also add a MAINTAINERS entry for the Option Card driver.
Sign... | ```diff
diff --git a/MAINTAINERS b/MAINTAINERS
index 5d014725901c..f73381af4d5e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2420,6 +2420,12 @@ L: linux-usb-users@lists.sourceforge.net
L: linux-usb-devel@lists.sourceforge.net
S: Maintained
+USB OPTION-CARD DRIVER
+P: Matthias Urlichs
+M: smurf@smurf.noris.de
+L: ... |
8e0a21812427313f8ee8521688e81bfcc6f207a2 | Analyze and fix the following issue in the Linux kernel code: [PATCH] uml: fix hppfs error path | Problem Details:
Fix the error message to refer to the error code, i.e. err, not count, plus
add some cosmetical fixes.
Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Cc: Jeff Dike <jdike@addtoit.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/fs/hppfs/hppfs_kern.c b/fs/hppfs/hppfs_kern.c
index 6f553e17c375..ff150fedb981 100644
--- a/fs/hppfs/hppfs_kern.c
+++ b/fs/hppfs/hppfs_kern.c
@@ -233,7 +233,7 @@ static ssize_t read_proc(struct file *file, char *buf, ssize_t count,
set_fs(USER_DS);
if(ppos) *ppos = file->f_pos;
- return(n);
... |
1c30385ae479ec4774bdc1048726aeb15cde0d21 | Analyze and fix the following issue in the Linux kernel code: [PATCH] uml: gcc 2.95 fix and Makefile cleanup | Problem Details:
1) Cleanup an ugly hyper-nested code in Makefile (now only the arith.
expression is passed through the host bash).
2) Fix a problem with GCC 2.95: according to a report from Raphael Bossek,
.remap_data : { arch/um/sys-SUBARCH/unmap_fin.o (.data .bss) } is expanded
into: .remap_data : { arch/u... | ```diff
diff --git a/arch/um/Makefile b/arch/um/Makefile
index 4a375bbac109..dfcc9eaafaa7 100644
--- a/arch/um/Makefile
+++ b/arch/um/Makefile
@@ -116,13 +116,14 @@ CONFIG_KERNEL_STACK_ORDER ?= 2
STACK_SIZE := $(shell echo $$[ 4096 * (1 << $(CONFIG_KERNEL_STACK_ORDER)) ] )
ifndef START
- START = $$(($(TOP_ADDR) - ... |
1feb8d2d7396748fb3bd6795d09bbfbdd4c03dff | Analyze and fix the following issue in the Linux kernel code: [PATCH] uml: workaround host bug in "TT mode vs. NPTL link fix" | Problem Details:
A big bug has been diagnosed on hosts running the SKAS patch and built with
CONFIG_REGPARM, due to some missing prevent_tail_call().
On these hosts, this workaround is needed to avoid triggering that bug,
because "to" is kept by GCC only in EBX, which is corrupted at the return of
mmap2().
Since to t... | ```diff
diff --git a/arch/um/sys-i386/unmap.c b/arch/um/sys-i386/unmap.c
index 136875263d27..1b0ad0e4adcd 100644
--- a/arch/um/sys-i386/unmap.c
+++ b/arch/um/sys-i386/unmap.c
@@ -15,7 +15,7 @@ int switcheroo(int fd, int prot, void *from, void *to, int size)
if(munmap(to, size) < 0){
return(-1);
}
- if(mmap2(to, ... |
bcb01b8a67476e6f748086e626df8424cc27036d | Analyze and fix the following issue in the Linux kernel code: [PATCH] uml: fix lvalue for gcc4 | Problem Details:
Russell King <rmk+lkml@arm.linux.org.uk>
This construct is refused by GCC 4, so here's the (corrected) fix. Thanks to
Russell for noticing a stupid mistake I did when first sending this.
As he noted, the code is largely suboptimal however it currently works, and
will be fixed shortly. Just read the... | ```diff
diff --git a/arch/um/sys-x86_64/signal.c b/arch/um/sys-x86_64/signal.c
index 73a7926f7370..8fdaed06c10d 100644
--- a/arch/um/sys-x86_64/signal.c
+++ b/arch/um/sys-x86_64/signal.c
@@ -168,7 +168,7 @@ int setup_signal_stack_si(unsigned long stack_top, int sig,
frame = (struct rt_sigframe __user *)
round_do... |
3952db66efee4f22f3c6a0fd02a1e7071556a8d6 | Analyze and fix the following issue in the Linux kernel code: [PATCH] dvb: LGDT3302 QAM lock bug fix | Problem Details:
Fix QAM lock bug. Previously, it was necessary to first scan in VSB before
attempting to get a QAM lock.
Signed-off-by: Mac Michaels <wmichaels1@earthlink.net>
Signed-off-by: Michael Krufky <mkrufky@m1k.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org... | ```diff
diff --git a/drivers/media/dvb/frontends/lgdt3302.c b/drivers/media/dvb/frontends/lgdt3302.c
index 2eea03d218cd..c85a2a99df42 100644
--- a/drivers/media/dvb/frontends/lgdt3302.c
+++ b/drivers/media/dvb/frontends/lgdt3302.c
@@ -217,13 +217,11 @@ static int lgdt3302_set_parameters(struct dvb_frontend* fe,
stati... |
84e29308ede3edb4f03911246c33d697ff18722e | Analyze and fix the following issue in the Linux kernel code: [SCSI] aacraid: Fix sgmap error | Problem Details:
The wrong sgmap structure is being assigned in aac_send_raw_srb.
Signed-off-by: Mark Haverkamp <markh@osdl.org>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com> | ```diff
diff --git a/drivers/scsi/aacraid/commctrl.c b/drivers/scsi/aacraid/commctrl.c
index 1fef92d55dee..d005ad77378d 100644
--- a/drivers/scsi/aacraid/commctrl.c
+++ b/drivers/scsi/aacraid/commctrl.c
@@ -517,7 +517,7 @@ static int aac_send_raw_srb(struct aac_dev* dev, void __user * arg)
}
if (dev->dac_support ==... |
351bb722590b2329ac5e72c4b824b8b6ce6e3082 | Analyze and fix the following issue in the Linux kernel code: AUDIT: Fix compile error in audit_filter_syscall | Problem Details:
We didn't rename it to audit_tgid after all. Except once... Doh.
Signed-off-by: David Woodhouse <dwmw2@infradead.org> | ```diff
diff --git a/kernel/auditsc.c b/kernel/auditsc.c
index 517b253f1efe..242d45e53738 100644
--- a/kernel/auditsc.c
+++ b/kernel/auditsc.c
@@ -517,7 +517,7 @@ static enum audit_state audit_filter_syscall(struct task_struct *tsk,
int word = AUDIT_WORD(ctx->major);
int bit = AUDIT_BIT(ctx->major);
- if... |
4c3ffbd79529b680b3c3ef2b6f42f0c89c694ec5 | Analyze and fix the following issue in the Linux kernel code: [ACPI] revert R40 workaround | Problem Details:
Should not be necessary...
http://bugme.osdl.org/show_bug.cgi?id=1038
Signed-off-by: Len Brown <len.brown@intel.com> | ```diff
diff --git a/drivers/acpi/utilities/utdelete.c b/drivers/acpi/utilities/utdelete.c
index bc5403022681..be97ada23c3d 100644
--- a/drivers/acpi/utilities/utdelete.c
+++ b/drivers/acpi/utilities/utdelete.c
@@ -439,7 +439,7 @@ acpi_ut_update_object_reference (
u32 i;
union acpi_gener... |
be3cef986f7c44593d6d112584fbdf4618b6569e | Analyze and fix the following issue in the Linux kernel code: [PATCH] kbuild: restrain output of "make help" to 80 columns | Problem Details:
This patch fixes the output of "make help" to fit in a 80 column
screen. Please push upstream as part of your other patches.
Signed-off-by: Yum Rayan <yum.rayan@gmail.com>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org> | ```diff
diff --git a/scripts/package/Makefile b/scripts/package/Makefile
index fbb8cf5d4e19..353b8ea5c32c 100644
--- a/scripts/package/Makefile
+++ b/scripts/package/Makefile
@@ -94,7 +94,8 @@ clean-dirs += $(objtree)/tar-install/
# ---------------------------------------------------------------------------
help:
@... |
e0af0d85f55ea800a2e38bf782d68b83e9942611 | Analyze and fix the following issue in the Linux kernel code: [PATCH] kbuild: obey HOSTLOADLIBES_programname for single-file compilation | Problem Details:
Single-file HOSTCC calls added the libraries from $(HOSTLOADLIBES),
but not from $(HOSTLOADLIBES_programname). Multi-file HOSTCC calls do
both.
This patch fixes that inconsistency.
Signed-Off-By: Matthias Urlichs <smurf@debian.org>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org> | ```diff
diff --git a/scripts/Makefile.host b/scripts/Makefile.host
index 2821a2b83bbb..2d519704b8fd 100644
--- a/scripts/Makefile.host
+++ b/scripts/Makefile.host
@@ -98,7 +98,8 @@ hostcxx_flags = -Wp,-MD,$(depfile) $(__hostcxx_flags)
# Create executable from a single .c file
# host-csingle -> Executable
quiet_cmd_... |
6c8c8ba5d7e31b37d0184c388183a6039a672417 | Analyze and fix the following issue in the Linux kernel code: [AUDIT] Fix sparse warning about gfp_mask type | Problem Details:
Fix the sparse warning "implicit cast to nocast type"
Signed-off-by: Victor Fusco <victor@cetuc.puc-rio.br>
Signed-off-by: Domen Puncer <domen@coderock.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: David Woodhouse <dwmw2@infradead.org> | ```diff
diff --git a/kernel/audit.c b/kernel/audit.c
index b683f2b5e866..518a833b676a 100644
--- a/kernel/audit.c
+++ b/kernel/audit.c
@@ -564,7 +564,7 @@ static void audit_buffer_free(struct audit_buffer *ab)
}
static struct audit_buffer * audit_buffer_alloc(struct audit_context *ctx,
- int gfp_mask, int type... |
88ac00f5a841dcfc5c682000f4a6add0add8caac | Analyze and fix the following issue in the Linux kernel code: ACPICA 20050526 from Bob Moore <robert.moore@intel.com> | Problem Details:
Implemented support to execute Type 1 and Type 2 AML
opcodes appearing at the module level (not within a control
method.) These opcodes are executed exactly once at the
time the table is loaded. This type of code was legal up
until the release of ACPI 2.0B (2002) and is now supported
within ACPI CA in... | ```diff
diff --git a/drivers/acpi/dispatcher/dsmethod.c b/drivers/acpi/dispatcher/dsmethod.c
index 9fc3f4c033eb..c9d9a6c45ae3 100644
--- a/drivers/acpi/dispatcher/dsmethod.c
+++ b/drivers/acpi/dispatcher/dsmethod.c
@@ -139,7 +139,8 @@ acpi_ds_parse_method (
walk_state = acpi_ds_create_walk_state (owner_id, NULL, NU... |
f62c4a96f74d6c6dd56d1742697e94a5c2085e87 | Analyze and fix the following issue in the Linux kernel code: [IA64] Make PCDP work again. | Problem Details:
Mark's patch added "attribute((packed))" for pcdp_uart, without
accounting for the fact that the structure definition _relied_ on
implicit padding by 6 bytes. Fix is to make the padding explicit.
Signed-off-by: David Mosberger-Tang <David.Mosberger@acm.org>
Signed-off-by: Tony Luck <tony.luck@intel.c... | ```diff
diff --git a/drivers/firmware/pcdp.h b/drivers/firmware/pcdp.h
index e72cc47de33b..ce910d68bd19 100644
--- a/drivers/firmware/pcdp.h
+++ b/drivers/firmware/pcdp.h
@@ -52,6 +52,8 @@ struct pcdp_uart {
u32 clock_rate;
u8 pci_prog_intfc;
u8 flags;
+ u16 conout_index;
+ u32 reserved;
} __attri... |
59a0a8aa6ab6e46926e8d12694593267c0869440 | Analyze and fix the following issue in the Linux kernel code: [IA64] fix call of smp_processor_id() by XPC while | Problem Details:
XPC calls smp_processor_id() twice from xpc_setup_infrastructure() with
preemption enabled, which gets flagged if 'DEBUG_PREEMPT=y'. This patch
replaces the two calls to smp_processor_id() by a single call to
raw_smp_processor_id() since any CPU within the partition will do.
Signed-off-by: Dean Nelson... | ```diff
diff --git a/arch/ia64/sn/kernel/xpc_channel.c b/arch/ia64/sn/kernel/xpc_channel.c
index 6d02dac8056f..94698bea7be0 100644
--- a/arch/ia64/sn/kernel/xpc_channel.c
+++ b/arch/ia64/sn/kernel/xpc_channel.c
@@ -72,7 +72,7 @@ xpc_initialize_channels(struct xpc_partition *part, partid_t partid)
enum xpc_retval
xpc_... |
a61caa8523a76e497f6b2a05350c892bc5ee402c | Analyze and fix the following issue in the Linux kernel code: [PATCH] Amiga joystick: Fix typo introduced by the open/close race fixes | Problem Details:
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/drivers/input/joystick/amijoy.c b/drivers/input/joystick/amijoy.c
index 033456bb9fe0..e996183c5b06 100644
--- a/drivers/input/joystick/amijoy.c
+++ b/drivers/input/joystick/amijoy.c
@@ -105,7 +105,7 @@ out:
static void amijoy_close(struct input_dev *dev)
{
- down(&amijoysem);
+ down(&amijoy_sem... |
f13487c66c75f5db004a0631047309d9e7c5aab7 | Analyze and fix the following issue in the Linux kernel code: [PATCH] ppc32: make -j12 all fails in uImage target | Problem Details:
make -j zImage may call if_changed twice at the same time, the result is a
corrupted vmlinux.gz
Write to a temporary file for the time being until someone with make skills
fix the serialization properly.
Signed-off-by: Olaf Hering <olh@suse.de>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc... | ```diff
diff --git a/arch/ppc/boot/images/Makefile b/arch/ppc/boot/images/Makefile
index c9ac5f5fa9e4..532e7ef1edb6 100644
--- a/arch/ppc/boot/images/Makefile
+++ b/arch/ppc/boot/images/Makefile
@@ -6,12 +6,17 @@ MKIMAGE := $(srctree)/scripts/mkuboot.sh
extra-y := vmlinux.bin vmlinux.gz
+# two make processes may... |
ddca3b80cef36cc668f924ef5154a79acb19ebd7 | Analyze and fix the following issue in the Linux kernel code: [PATCH] ppc32: fix destroy_context() race condition | Problem Details:
Fix for a race condition when a task gets preempted by another task while
executing the destroy_context(...) in a FEW_CONTEXTS environment.
mm->context == NO_CONTEXT but the context_map may indicate all contexts are
in use.
The solution to this problem is to disable kernel preemption while
destroying ... | ```diff
diff --git a/include/asm-ppc/mmu_context.h b/include/asm-ppc/mmu_context.h
index ccabbce39d85..afe26ffc2e2d 100644
--- a/include/asm-ppc/mmu_context.h
+++ b/include/asm-ppc/mmu_context.h
@@ -149,6 +149,7 @@ static inline void get_mmu_context(struct mm_struct *mm)
*/
static inline void destroy_context(struct ... |
88bd5121d635136e01369141367f315665534b3c | Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix soft lockup due to NTFS: VFS part and explanation | Problem Details:
Something has changed in the core kernel such that we now get concurrent
inode write outs, one e.g via pdflush and one via sys_sync or whatever.
This causes a nasty deadlock in ntfs. The only clean solution
unfortunately requires a minor vfs api extension.
First the deadlock analysis:
Prerequisive k... | ```diff
diff --git a/fs/inode.c b/fs/inode.c
index 96364fae0844..e57f1724db3e 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -757,6 +757,7 @@ EXPORT_SYMBOL(igrab);
* @head: the head of the list to search
* @test: callback used for comparisons between inodes
* @data: opaque data pointer to pass to @test
+ * @wa... |
153f805781d35c91ab2f54aa2b8930cc4cfc7e89 | Analyze and fix the following issue in the Linux kernel code: [PATCH] fix voyager subarchitecture EXPORT_SYMBOL breakage caused by i386_ksym reduction | Problem Details:
This patch:
[PATCH] Remove i386_ksyms.c, almost
made files like smp.c do their own EXPORT_SYMBOLS. This means that all
subarchitectures that override these symbols now have to do the exports
themselves. This patch adds the exports for voyager (which is the most
affected since it has a separate smp... | ```diff
diff --git a/arch/i386/mach-voyager/voyager_basic.c b/arch/i386/mach-voyager/voyager_basic.c
index 3e439ce5e1b2..8680080a6a89 100644
--- a/arch/i386/mach-voyager/voyager_basic.c
+++ b/arch/i386/mach-voyager/voyager_basic.c
@@ -36,6 +36,7 @@
* Power off function, if any
*/
void (*pm_power_off)(void);
+EXPOR... |
ad3f9a2238e401a1fc493b8c91341f9e57940eda | Analyze and fix the following issue in the Linux kernel code: Fix positioning of audit in MAINTAINERS. | Problem Details:
Signed-off-by: David Woodhouse <dwmw2@infradead.org> | ```diff
diff --git a/MAINTAINERS b/MAINTAINERS
index a47b74102479..6b2de371f0fb 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -363,13 +363,6 @@ L: linux-atm-general@lists.sourceforge.net
W: http://linux-atm.sourceforge.net
S: Maintained
-AUDIT SUBSYSTEM
-P: David Woodhouse
-M: dwmw2@infradead.org
-L: linux-audit@re... |
6211502d7ee9e515e4458d0c0ebfbb70553dc7de | Analyze and fix the following issue in the Linux kernel code: JFS: Allow security.* xattrs to be set on symlinks | Problem Details:
All of the different xattr namespaces have different rules.
user.* and ACL's are not allowed on symlinks, and since these were the
first xattrs implemented, I assumed there was no need to support xattrs
on symlinks. This one-line patch should fix it.
Signed-off-by: Dave Kleikamp <shaggy@austin.ibm.co... | ```diff
diff --git a/fs/jfs/xattr.c b/fs/jfs/xattr.c
index ee438d429d45..fdd8f3f5a72f 100644
--- a/fs/jfs/xattr.c
+++ b/fs/jfs/xattr.c
@@ -781,7 +781,7 @@ static int can_set_xattr(struct inode *inode, const char *name,
if (IS_RDONLY(inode))
return -EROFS;
- if (IS_IMMUTABLE(inode) || IS_APPEND(inode) || S_ISLNK(... |
7fa94c8868edfef8cb6a201fcc9a5078b7b961da | Analyze and fix the following issue in the Linux kernel code: [PATCH] reiserfs: fix up case where indent misreads the code | Problem Details:
indent(1) doesn't know how to handle the "do not compile" error. It results
in the item_ops array declaration being indented a tab stop in when it should
not be. This patch replaces it with a #error that describes why it's failing.
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Linus To... | ```diff
diff --git a/fs/reiserfs/item_ops.c b/fs/reiserfs/item_ops.c
index 0ce33db1acdf..e477aeba8c92 100644
--- a/fs/reiserfs/item_ops.c
+++ b/fs/reiserfs/item_ops.c
@@ -772,7 +772,7 @@ static struct item_operations errcatch_ops = {
//
//
#if ! (TYPE_STAT_DATA == 0 && TYPE_INDIRECT == 1 && TYPE_DIRECT == 2 && TYPE_... |
93c534aefb906824d71ea779ed0c7f1573843f4e | Analyze and fix the following issue in the Linux kernel code: [PATCH] device-mapper: Fix dm_swap_table error cases | Problem Details:
Fix dm_swap_table() __bind error cases: a missing unlock, and EINVAL
preferable to EPERM.
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index bb3ad79c14d7..54fabbf06678 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -966,23 +966,20 @@ static void __flush_deferred_io(struct mapped_device *md, struct bio *c)
*/
int dm_swap_table(struct mapped_device *md, struct dm_table *table)
{
- int r;
... |
c3cd4f6b275da0f594797b73f721a4185335478f | Analyze and fix the following issue in the Linux kernel code: [PATCH] device-mapper multipath: Fix pg initialisation races | Problem Details:
Prevent more than one priority group initialisation function from being
outstanding at once. Otherwise the completion functions interfere with each
other. Also, reloading the table could reference a freed pointer.
Only reset queue_io in pg_init_complete if another pg_init isn't required.
Skip proces... | ```diff
diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
index 98da8eee2d2c..785806bdb248 100644
--- a/drivers/md/dm-mpath.c
+++ b/drivers/md/dm-mpath.c
@@ -63,6 +63,7 @@ struct multipath {
unsigned nr_priority_groups;
struct list_head priority_groups;
unsigned pg_init_required; /* pg_init needs calling... |
436d41087d047b61f8ab0604dc74fff3240a8933 | Analyze and fix the following issue in the Linux kernel code: [PATCH] device-mapper multipath: Avoid possible suspension deadlock | Problem Details:
To avoid deadlock when suspending a multipath device after all its paths have
failed, stop queueing any I/O that is about to fail *before* calling
freeze_bdev instead of after.
Instead of setting a multipath 'suspended' flag which would have to be reset
if an error occurs during the process, save the ... | ```diff
diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
index fa72f0153206..98da8eee2d2c 100644
--- a/drivers/md/dm-mpath.c
+++ b/drivers/md/dm-mpath.c
@@ -72,7 +72,7 @@ struct multipath {
unsigned queue_io; /* Must we queue all I/O? */
unsigned queue_if_no_path; /* Queue I/O if last path fails? */
- ... |
7c2a6c62c013a4ea57243536fc7f3987e4ba04bc | Analyze and fix the following issue in the Linux kernel code: [IA64] Altix pcibus_to_node implementation | Problem Details:
The Altix subarch does not provide node information via ACPI. Instead hooks
are used to fixup pci structures. This patch determines the nodes for Altix
PCI busses.
Remote Bridges:
---------------
Altix supports remote I/O nodes without memory or processors but with bridges.
The TIOCA type of bridge is... | ```diff
diff --git a/arch/ia64/sn/kernel/io_init.c b/arch/ia64/sn/kernel/io_init.c
index a67f39e448cb..a6649baf629a 100644
--- a/arch/ia64/sn/kernel/io_init.c
+++ b/arch/ia64/sn/kernel/io_init.c
@@ -61,7 +61,7 @@ sn_default_pci_unmap(struct pci_dev *pdev, dma_addr_t addr, int direction)
}
static void *
-sn_default_... |
85369df350b138f26eac779da33de0960635ca4d | Analyze and fix the following issue in the Linux kernel code: [PATCH] v4l: MXB fix to correct tuner ioctl | Problem Details:
- driver command adapted to use new control (TUNER_SET_TYPE_ADDR,
instead of TUNER_SET_TYPE)
Signed-off-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/drivers/media/video/mxb.c b/drivers/media/video/mxb.c
index 70bf1f1fad59..486234d41b56 100644
--- a/drivers/media/video/mxb.c
+++ b/drivers/media/video/mxb.c
@@ -326,6 +326,7 @@ static int mxb_init_done(struct saa7146_dev* dev)
struct mxb* mxb = (struct mxb*)dev->ext_priv;
struct video_decoder_... |
27b05fd22f8a1f9afd0377817b1811cfc95f8b7b | Analyze and fix the following issue in the Linux kernel code: [PATCH] dvb: fix kobject names (no slashes) | Problem Details:
The / in the driver name (budget dvb /w video in) is not a valid character for
device names - removed it, now it works!
Same for ttusb-budget.
Signed-off-by: Patrick Boettcher <pb@linuxtv.org>
Signed-off-by: Julian Scheel <julian@jusst.de>
Signed-off-by: Johannes Stezenbach <js@linuxtv.org>
Signed-of... | ```diff
diff --git a/drivers/media/dvb/ttpci/budget-av.c b/drivers/media/dvb/ttpci/budget-av.c
index b65f4b0a481f..9746d2bb916f 100644
--- a/drivers/media/dvb/ttpci/budget-av.c
+++ b/drivers/media/dvb/ttpci/budget-av.c
@@ -1022,7 +1022,7 @@ static struct pci_device_id pci_tbl[] = {
MODULE_DEVICE_TABLE(pci, pci_tbl);
... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.