input stringlengths 1 18.7k | output stringlengths 1 18.7k |
|---|---|
thanks!
| no problem
|
jburns good job with the article. if you want i can tweet it
| Absolutely. Tyty!
|
Absolutely. Tyty!
| Done
|
Are Flyte workflows appropriate for long-running tasks? Example: if you have security camera video streams and want to sample X frames a second, do object detection, then log results.
• Should each frame be an execution in this case? You have something outside of Flyte sampling frames and creating an execution for each... | Hey Zach :wave:
While Flyte supports fairly long running tasks, (we have some Flyte tasks run for multiple days), the system does assume the amount of work is finite (it expects the task to finish at some point).
While there isn't anything stopping you from creating one execution per-frame, I would lean toward submit... |
Hey Zach :wave:
While Flyte supports fairly long running tasks, (we have some Flyte tasks run for multiple days), the system does assume the amount of work is finite (it expects the task to finish at some point).
While there isn't anything stopping you from creating one execution per-frame, I would lean toward submit... | Hi Zach Hobbs welcome to Flyte. Johnny has explained a solution. Let me provide some background. So the workflows execute tasks. Tasks are execute for some finite time. The duration can be very small or very large, but there are caveats and overheads. For example very short duration like milliseconds is not recommended... |
Hi Zach Hobbs welcome to Flyte. Johnny has explained a solution. Let me provide some background. So the workflows execute tasks. Tasks are execute for some finite time. The duration can be very small or very large, but there are caveats and overheads. For example very short duration like milliseconds is not recommended... | Thanks for the info Ketan and Johnny! As I think about it more, since a given task can only emit output once during an execution it makes sense that I can't treat it as a pipeline to continuously stream data into.
I'll keep digging into the architecture to see if it would make sense to extend Flyte to support this. Lo... |
Thanks for the info Ketan and Johnny! As I think about it more, since a given task can only emit output once during an execution it makes sense that I can't treat it as a pipeline to continuously stream data into.
I'll keep digging into the architecture to see if it would make sense to extend Flyte to support this. Lo... | Hey Zach Hobbs, this is definitely an interesting use-case. If it's desired to process each frame as they come, it seems more appropriate to consider a streaming solution (Flink maybe?) <https://github.com/lyft/flinkk8soperator>
We are looking for ways to integrate Flyte with Flink, as you learn more about the archite... |
Hello, could someone direct me to the right channel to discuss setting up Flyte locally with Minikube on MacOS? Thanks!
| i think <#CP2HDHKE1|onboarding> could be a good place to chat. Johnny Burns and Yee are pretty experienced with this and might be able to help
|
i think <#CP2HDHKE1|onboarding> could be a good place to chat. Johnny Burns and Yee are pretty experienced with this and might be able to help
| <#CP2HDHKE1|onboarding>
|
<#CP2HDHKE1|onboarding>
| jinx
|
jinx
| oh you beat me to it :slightly_smiling_face:
|
oh you beat me to it :slightly_smiling_face:
| thanks :+1:
|
Hello
| Hello Sergio! thank you for joining
|
Hello Sergio! thank you for joining
| Hi Sergio
|
Hello everyone, I just started playing with Flyte and I'm very excited, it looks like a very promising project
| glad to hear it! welcome and please don’t hesitate to ask any questions!!
|
glad to hear it! welcome and please don’t hesitate to ask any questions!!
| Thank you Matt, as a matter of fact I do have a few…what would be the best channel to discuss them?
|
Thank you Matt, as a matter of fact I do have a few…what would be the best channel to discuss them?
| I think you can ask here and if it’s better to be in another channel, we can help re-route it for you Though i’m about to head off to bed so someone will have to pick it up tomorrow morning.
|
ok I got a couple of questions:
1)
I followed the examples in the flytesnacks repository and created a simple workflow with a few tasks, now I am trying to schedule it to run every 5 minutes by using this code that I found in the docs (<https://lyft.github.io/flyte/user/features/lanuchplans.html>) which I added after t... | Hi Giordano sorry for the late reply. So in the local sandbox cluster mode we do not have a scheduler today. When you deploy to a cloud environment we use either AWS cloud watch schedules or on GCP cloud scheduler. This is an area of active interest and we prefer to write a simple one using k8s operator or better optio... |
Hi Giordano sorry for the late reply. So in the local sandbox cluster mode we do not have a scheduler today. When you deploy to a cloud environment we use either AWS cloud watch schedules or on GCP cloud scheduler. This is an area of active interest and we prefer to write a simple one using k8s operator or better optio... | Hi Ketan Umare thanks for the info, i was looking at flyte to replace airflow running on a barematal k8s cluster so I guess I’ll have to manage without the scheduling part
|
Hi Ketan Umare thanks for the info, i was looking at flyte to replace airflow running on a barematal k8s cluster so I guess I’ll have to manage without the scheduling part
| Giordano we would love to work with you on a replacement for the cloud scheduler
Try out the other features and e See is you like everything else
The reason for not packaging a scheduler is reinvention of wheel And building a scheduler for our scale will take sometime 100ks execution per day
|
2) are there any examples on how to connect to flyteadmin and launch/manage and query workflow results via the flytesdk?
| There is documentation for this, will share a link. It’s as simple as importing the workflow and there are bunch of API’s on them
Also you can use Flyte-cli
|
There is documentation for this, will share a link. It’s as simple as importing the workflow and there are bunch of API’s on them
Also you can use Flyte-cli
| great thanks looking forward to the link.
|
great thanks looking forward to the link.
| <https://lyft.github.io/flyte/user/features/flytecli.html|https://lyft.github.io/flyte/user/features/flytecli.html> Flyte cli
<https://lyft.github.io/flyte/flytekit/flytekit.common.html#module-flytekit.common.workflow_execution|https://lyft.github.io/flyte/flytekit/flytekit.common.html#module-flytekit.common.workflow_e... |
ok one more question, I was trying to create a workflow that would call some tasks aready defined in another workflow using an example that I found on the kubecon 19 presentation
```from flytekit.models.launch_plan import LaunchPlanState
from flytekit.common import utils, schedules, tasks
from flytekit.sdk.tasks impor... | is your code pushed anywhere we can take a look?
|
is your code pushed anywhere we can take a look?
| No but i can create a quick repo
|
No but i can create a quick repo
| sure, if you don’t mind.
always helpful
|
sure, if you don’t mind.
always helpful
| hmm yeh, i’m not seeing where `fk_workflow.workflow` is referenced
(the code you copied originally looks great!)
|
hmm yeh, i’m not seeing where `fk_workflow.workflow` is referenced
(the code you copied originally looks great!)
| hi Matt thanks, i just pushed to the repo my example
<https://github.com/giordyb/flyte_demo>
the workflow inside the fk_tasks folder works just fine (it’s 4 tasks and 1 workflow)
in the workflow inside the fk_workflow folder I’m trying fetch the tasks created with the previous workflow but doesn’t work
|
hi Matt thanks, i just pushed to the repo my example
<https://github.com/giordyb/flyte_demo>
the workflow inside the fk_tasks folder works just fine (it’s 4 tasks and 1 workflow)
in the workflow inside the fk_workflow folder I’m trying fetch the tasks created with the previous workflow but doesn’t work
| what happens if you run `flyte-cli -h <your-url> list-task-names -p flytedemo -d development`
|
what happens if you run `flyte-cli -h <your-url> list-task-names -p flytedemo -d development`
| Welcome to Flyte CLI! Version: 0.4.4
Task Names Found in flytedemo:development
fk_tasks.tasks_and_workflow.download_dataset
fk_tasks.tasks_and_workflow.read_pickle
fk_tasks.tasks_and_workflow.reverse_task
fk_tasks.tasks_and_workflow.uppercase_task
btw I also tried fetch_latest without t... |
Welcome to Flyte CLI! Version: 0.4.4
Task Names Found in flytedemo:development
fk_tasks.tasks_and_workflow.download_dataset
fk_tasks.tasks_and_workflow.read_pickle
fk_tasks.tasks_and_workflow.reverse_task
fk_tasks.tasks_and_workflow.uppercase_task
btw I also tried fetch_latest without t... | cool and also: `flyte-cli -h <your-url> list-task-versions -p flytedemo -d development -n fk_tasks.tasks_and_workflow.download_dataset`
|
cool and also: `flyte-cli -h <your-url> list-task-versions -p flytedemo -d development -n fk_tasks.tasks_and_workflow.download_dataset`
| Welcome to Flyte CLI! Version: 0.4.4
Task Versions Found for flytedemo:development:fk_tasks.tasks_and_workflow.download_dataset
Version Urn
1e0d95cc82b85cdd96feab3c6f9b6e2f7baba216 tsk:flytedemo:development:fk_tasks.tasks_and_workflow.download_dataset:1e0d95cc82b85c... |
Welcome to Flyte CLI! Version: 0.4.4
Task Versions Found for flytedemo:development:fk_tasks.tasks_and_workflow.download_dataset
Version Urn
1e0d95cc82b85cdd96feab3c6f9b6e2f7baba216 tsk:flytedemo:development:fk_tasks.tasks_and_workflow.download_dataset:1e0d95cc82b85c... | ok cool, the SHA `470cae526836f7a05d41ef81faa07a3b275b9de9` doesn’t look like it was ever registered
if you swapped that with `1e0d95cc82b85cdd96feab3c6f9b6e2f7baba216`, it should work
|
ok cool, the SHA `470cae526836f7a05d41ef81faa07a3b275b9de9` doesn’t look like it was ever registered
if you swapped that with `1e0d95cc82b85cdd96feab3c6f9b6e2f7baba216`, it should work
| sorry i had rebuilt the deployment in the meantime
just tried with that version and it still throws
```flytekit.common.exceptions.user.FlyteAssertion: An entity was not found in modules accessible from the workflow packages configuration. Please ensure that entities in 'fk_workflow.workflow' are moved to a configured ... |
sorry i had rebuilt the deployment in the meantime
just tried with that version and it still throws
```flytekit.common.exceptions.user.FlyteAssertion: An entity was not found in modules accessible from the workflow packages configuration. Please ensure that entities in 'fk_workflow.workflow' are moved to a configured ... | ```read_task = SdkTask.fetch("flytedemo","development","fk_tasks.tasks.read_pickle","1e0d95cc82b85cdd96feab3c6f9b6e2f7baba216")
download_task = SdkTask.fetch("flytedemo","development","fk_tasks.tasks.download_dataset","1e0d95cc82b85cdd96feab3c6f9b6e2f7baba216")
@workflow_class
class myworkflow(object):
string_in... |
```read_task = SdkTask.fetch("flytedemo","development","fk_tasks.tasks.read_pickle","1e0d95cc82b85cdd96feab3c6f9b6e2f7baba216")
download_task = SdkTask.fetch("flytedemo","development","fk_tasks.tasks.download_dataset","1e0d95cc82b85cdd96feab3c6f9b6e2f7baba216")
@workflow_class
class myworkflow(object):
string_in... | ```Running task, workflow, and launch plan registration for flytedemo, development, ['fk_workflow'] with version 1e0d95cc82b85cdd96feab3c6f9b6e2f7baba216
Traceback (most recent call last):
File "/app/venv/bin/pyflyte", line 11, in <module>
sys.exit(main())
File "/app/venv/lib/python3.6/site-packages/click... |
```Running task, workflow, and launch plan registration for flytedemo, development, ['fk_workflow'] with version 1e0d95cc82b85cdd96feab3c6f9b6e2f7baba216
Traceback (most recent call last):
File "/app/venv/bin/pyflyte", line 11, in <module>
sys.exit(main())
File "/app/venv/lib/python3.6/site-packages/click... | no, definitely not for a workflow…and you don’t actually technically need to be in a container for a task either. Being in a container that is configured in a certain way just makes it easy to auto-fill in information when creating tasks.
|
no, definitely not for a workflow…and you don’t actually technically need to be in a container for a task either. Being in a container that is configured in a certain way just makes it easy to auto-fill in information when creating tasks.
| right that’s what I figured
if you could provide some simple example of a workflow created with the pure client I would appreciate it
another thing that’s not very clear from the flytekit documentation is how to connect to the admin service
i know that with flyte-cli I can just pass the host parameters but I couldn’t f... |
right that’s what I figured
if you could provide some simple example of a workflow created with the pure client I would appreciate it
another thing that’s not very clear from the flytekit documentation is how to connect to the admin service
i know that with flyte-cli I can just pass the host parameters but I couldn’t f... | do you get this error when using the pyflyte tool? or just when writing a script yourself?
if the latter, take a look at this method: <https://github.com/lyft/flytekit/blob/master/flytekit/configuration/__init__.py#L11>
|
do you get this error when using the pyflyte tool? or just when writing a script yourself?
if the latter, take a look at this method: <https://github.com/lyft/flytekit/blob/master/flytekit/configuration/__init__.py#L11>
| when creating a script myself
|
when creating a script myself
| alternatively, you can set env vars that follow the format: `FLYTE_{SECTION}_{KEY}` . so in this case FLYTE_PLATFORM_URL, but i recommend creating a `flytekit.conf` file
and i will find an example of a pure client use case
|
alternatively, you can set env vars that follow the format: `FLYTE_{SECTION}_{KEY}` . so in this case FLYTE_PLATFORM_URL, but i recommend creating a `flytekit.conf` file
and i will find an example of a pure client use case
| is the flytekit.config supposed to be created when running flyte-cli setup-config?
|
is the flytekit.config supposed to be created when running flyte-cli setup-config?
| it is the same config file format, so it can be.
|
it is the same config file format, so it can be.
| because I tried running
```flyte-cli setup-config -h localhost:30081 -i```
but I got a jsondecode error…should I open an issue about that?
|
because I tried running
```flyte-cli setup-config -h localhost:30081 -i```
but I got a jsondecode error…should I open an issue about that?
| yes please. cc: Yee
|
yes please. cc: Yee
| :+1:
|
:+1:
| there should be a barebones config in the demo repository you can copy
|
there should be a barebones config in the demo repository you can copy
| ok thanks I’ll take a look
|
ok thanks I’ll take a look
| here is an example script for a pure client approach. note: i copy-pasted different elements so there _might_ be a copy-paste error (and the interface definitions for your tasks/workflows will be different):
```my_task = SdkTask.fetch("flytedemo","development","fk_tasks.tasks.download_dataset", "1e0d95cc82b85cdd96feab3... |
here is an example script for a pure client approach. note: i copy-pasted different elements so there _might_ be a copy-paste error (and the interface definitions for your tasks/workflows will be different):
```my_task = SdkTask.fetch("flytedemo","development","fk_tasks.tasks.download_dataset", "1e0d95cc82b85cdd96feab3... | hi matt I got it to work after all
one of the issues was that I renamed the task names but didn’t rename them in the code
the other issue is that the docker image has the flytekit pinned to an older version in the flytesnacks example
that’s why I got the error with fetch_latest
thank you for your help!
|
hi matt I got it to work after all
one of the issues was that I renamed the task names but didn’t rename them in the code
the other issue is that the docker image has the flytekit pinned to an older version in the flytesnacks example
that’s why I got the error with fetch_latest
thank you for your help!
| awesome! glad to hear it!!
|
Hongxin Liang and Haytham Abuelfutuh
I’ve merged the boilerplate change
and updated the idl pr <https://github.com/lyft/flyteidl/pull/27>
thanks honnix for adding me as a collab
mind taking a look one last time before we merge?
| Awesome!!! thank you both
|
Awesome!!! thank you both
| I will take care of the rest repos.
Thanks.
|
I will take care of the rest repos.
Thanks.
| good morning
thank you!
i’ll approve everything tomorrow morning.
will then test, and then post an annoucement to the issue and this channel
|
good morning
thank you!
i’ll approve everything tomorrow morning.
will then test, and then post an annoucement to the issue and this channel
| I have updated all the rest repos accordingly and poked you in those PRs. Please take a look. Thanks.
|
Hello everyone… are there any known issues with running a script that uses the “hyperopt” python library under flyte?
| None that we know off
is not playing well with flytekit
|
None that we know off
is not playing well with flytekit
| I have been trying to run a script that uses it under a workflow
|
I have been trying to run a script that uses it under a workflow
| hmmm and
but you are using the python bindings (flytekit) right?
|
hmmm and
but you are using the python bindings (flytekit) right?
| i don’t even have to actually use the library, as soon as I import it in the script i get this
|
i don’t even have to actually use the library, as soon as I import it in the script i get this
| are you pasting the error?
|
are you pasting the error?
| ```ERROR:root:Error from command '['aws', '--endpoint-url', '<http://minio.yolotrainframework.svc.cluster.local:9000>', 's3', 'cp', '<s3://my-s3-bucket/metadata/propeller/flytedemo-d> │
│ b'' ... |
```ERROR:root:Error from command '['aws', '--endpoint-url', '<http://minio.yolotrainframework.svc.cluster.local:9000>', 's3', 'cp', '<s3://my-s3-bucket/metadata/propeller/flytedemo-d> │
│ b'' ... | hmmm
Exit code -9
let me check
Giordano can you share your code
if you dont mind?
|
hmmm
Exit code -9
let me check
Giordano can you share your code
if you dont mind?
| it seems like importing hyperopt createss some issues with connecting to s3
sure
gimme a sec
|
it seems like importing hyperopt createss some issues with connecting to s3
sure
gimme a sec
| ya this is actually connecting to minio in your sandbox cluster
|
ya this is actually connecting to minio in your sandbox cluster
| Looks like the subprocess which was trying to copy from s3 got a SIGKILL signal.
The most common reason for that would be OOM. `aws s3 cp` shouldn't take too much memory, but it might be worth trying to bump the memory in your container using something like:
```@python_task(cpu_limit="10000m", memory_limit="10000Mi")... |
Looks like the subprocess which was trying to copy from s3 got a SIGKILL signal.
The most common reason for that would be OOM. `aws s3 cp` shouldn't take too much memory, but it might be worth trying to bump the memory in your container using something like:
```@python_task(cpu_limit="10000m", memory_limit="10000Mi")... | Johnny Burns Ketan Umare just tried what you suggested and it's working now, thanks!
It was indeed a resource issue
|
Johnny Burns Ketan Umare just tried what you suggested and it's working now, thanks!
It was indeed a resource issue
| Woot woot :tada:
|
As of today, we have migrated all golang Flyte repos to use go mod. Thanks to Hongxin Liang for driving this change.
Boilerplate changes: <https://github.com/lyft/boilerplate/pull/4>
The boilerplate code will now default to go.mod.
<https://github.com/lyft/flytestdlib/releases/tag/v0.3.0> (was already on go mod as of... | Wow awesome!! Way to finish it off—I know it wasn’t easy! :p
|
Wow awesome!! Way to finish it off—I know it wasn’t easy! :p
| Thank you both! this not only aligns Flyte Repos with what's becoming the standards but also improves our tooling in the process (consistent build tools' versions). Big shout out to Hongxin Liang for going above and beyond to deliver that across all Flyte repos.
|
Thank you both! this not only aligns Flyte Repos with what's becoming the standards but also improves our tooling in the process (consistent build tools' versions). Big shout out to Hongxin Liang for going above and beyond to deliver that across all Flyte repos.
| Great job everyone! It was a good learning process for me to get better understanding of go ecosystem, and I enjoyed working on this. Super excited to see everything in place. :thumbsup:
|
I want to understand:
• Flyte's Monitoring
• Logging
• Alerting
• Integeration with Slack or something: Say this job is started by user X, job X is finished etc..
| This is a good place to start learning about notifications:
<https://lyft.github.io/flyte/user/features/notifications.html>
As far as logging/monitoring, there are two "stories" there:
1. As an administrator of the "Flyte" system, you want logging monitoring about the heath of your Flyte cluster.
2. As a user (workfl... |
This is a good place to start learning about notifications:
<https://lyft.github.io/flyte/user/features/notifications.html>
As far as logging/monitoring, there are two "stories" there:
1. As an administrator of the "Flyte" system, you want logging monitoring about the heath of your Flyte cluster.
2. As a user (workfl... | Email and Slack is good enough
So What about Logging and Monitoring?
|
Email and Slack is good enough
So What about Logging and Monitoring?
| <https://lyft.github.io/flyte/user/features/observability.html>
Flyte system components use Prometheus (they expose metrics through prometheus port).
We found that prometheus can be a hit or a miss for user containers (since it's a pull model, it can miss data points). So for metrics emitted from user containers, you... |
<https://lyft.github.io/flyte/user/features/notifications.html#howto-slack> link is broken?
| Hmmmm.... Looks like the docs for that are missing :disappointed:
The notification code should look something like this:
```@workflow(notify=[Email(when=[States.FAILED, States.TIMED_OUT], who=["<mailto:me@email.com|me@email.com>"],
service_instances=["staging", "production"]),
... |
<!here> Ketan Umare and myself on TWIML, talking about Flyte, giving a bit more history about how it all started, where it's going and key differentiators: <https://twimlai.com/twiml-talk-343-scalable-and-maintainable-workflows-at-lyft-with-flyte-w-haytham-abuelfutuh-and-ketan-umare/>
| Nice! TWiML is my favorite podcast! (went to Twimlcon recently too). Will listen to it this evening.
Great interview!
|
Nice! TWiML is my favorite podcast! (went to Twimlcon recently too). Will listen to it this evening.
Great interview!
| Thank you Richard
|
Thank you Richard
| Awesome! Congrats!
|
Awesome! Congrats!
| Good listen :+1:. Wish you got more time to talk about the caching and cataloguing stuff though as I think that’s a big differentiator from say Argo and Airflow.
|
Good listen :+1:. Wish you got more time to talk about the caching and cataloguing stuff though as I think that’s a big differentiator from say Argo and Airflow.
| Thank you Jonathon, that's certainly true. Stay tuned for more :wink:
|
Thank you Jonathon, that's certainly true. Stay tuned for more :wink:
| Memoization part sounded really exciting !
|
Memoization part sounded really exciting !
| Adhita Selvaraj how’s the tf operator stuff going
|
Adhita Selvaraj how’s the tf operator stuff going
| Slowly :disappointed: I haven't had time to work on it with the Kubeflow 1.0 sprints
After this week, I'll have more time on my hands
|
Hi guys, I've been working the past few days to implement some DL pipelines that I use at work on Flyte and I've been spending a lot of time debugging...right now i'm working locally on my docker-desktop k8s environment and the workflow is as follows:
edit code -> build container -> register workflow -> launc... | Are you able to run just the raw container that contains the task in question?
|
Are you able to run just the raw container that contains the task in question?
| Yes, of course
|
Yes, of course
| what are the types of these inputs?
the command that is passed to the container is in the task spec. it’ll look something like this.
the braces are filled in by Propeller before execution to be the location of the s3 inputs file and the path that the outputs should be written to.
|
what are the types of these inputs?
the command that is passed to the container is in the task spec. it’ll look something like this.
the braces are filled in by Propeller before execution to be the location of the s3 inputs file and the path that the outputs should be written to.
| Ok thanks I'll try that
I didn't think I could run the command directly
|
Ok thanks I'll try that
I didn't think I could run the command directly
| yup you absolutely can…. this is probably the most black-box way of debugging. you can also run the task outside of the container entirely, just in a virtualenv (assuming this is python).
this isn’t yet sanitized for outside lyft so i’m gonna copy paste some
|
yup you absolutely can…. this is probably the most black-box way of debugging. you can also run the task outside of the container entirely, just in a virtualenv (assuming this is python).
this isn’t yet sanitized for outside lyft so i’m gonna copy paste some
| Thank you for your help I'll look into that
|
Hello Everyone! :hand: I am interested in a small part of `flytepropeller` in `flyte`.
Default, Propeller container is started with the command `flytepropeller --config "/etc/flyte/config*/config.yaml"`
Source: <https://github.com/lyft/flyte/blob/master/kustomize/base/propeller/deployment.yaml#L35-L39> It works great!... | Nice catch. Yeah, my impression is that this is a bug.
My best guess is that it's related to this:
<https://github.com/lyft/flyteadmin/blob/master/cmd/entrypoints/root.go#L80>
Both Flyteadmin and Datacatalog do this, flytepropeller does not.
Haytham Abuelfutuh, can you confirm?
|
Nice catch. Yeah, my impression is that this is a bug.
My best guess is that it's related to this:
<https://github.com/lyft/flyteadmin/blob/master/cmd/entrypoints/root.go#L80>
Both Flyteadmin and Datacatalog do this, flytepropeller does not.
Haytham Abuelfutuh, can you confirm?
| Can you show me the storage section in config?
|
Can you show me the storage section in config?
| Thank you for quick response!
I did only these small changes in comparison with sandbox example <https://github.com/lyft/flyte/blob/master/kustomize/overlays/sandbox/propeller/config.yaml#L40-L49>
just commented two lines with creds:
|
Thank you for quick response!
I did only these small changes in comparison with sandbox example <https://github.com/lyft/flyte/blob/master/kustomize/overlays/sandbox/propeller/config.yaml#L40-L49>
just commented two lines with creds:
| I also reproduced the issue locally (removed the `endpoint` config from the file, added it as a command line arg).
|
I also reproduced the issue locally (removed the `endpoint` config from the file, added it as a command line arg).
| Awesome!. This should work. I agree this is a bug, mind filing an issue on <http://github.com/lyft/flyte|github.com/lyft/flyte> and assign it to me (@enghabu), Ruslan Stanevich?
|
Awesome!. This should work. I agree this is a bug, mind filing an issue on <http://github.com/lyft/flyte|github.com/lyft/flyte> and assign it to me (@enghabu), Ruslan Stanevich?
| oh of course!
thanks for your responsiveness
|
oh of course!
thanks for your responsiveness
| Haytham Abuelfutuh haven't tested this yet, but if you like how it looks, I can give it a whirl.
<https://github.com/lyft/flytepropeller/pull/63/files>
^ Guess it's never that simple. Looks like this results in a whole new problem:
```* '' has invalid keys: qubolelimit, quboletokenpath, redishostkey, redishostpath, r... |
Haytham Abuelfutuh haven't tested this yet, but if you like how it looks, I can give it a whirl.
<https://github.com/lyft/flytepropeller/pull/63/files>
^ Guess it's never that simple. Looks like this results in a whole new problem:
```* '' has invalid keys: qubolelimit, quboletokenpath, redishostkey, redishostpath, r... | <https://github.com/lyft/flyte/issues/167>
hope I missed nothing
Johnny, I don’t know exactly, but from my expirience, at least this error:
```1 error(s) decoding:
* '' has invalid keys: qubolelimit```
can be related to using flytepropeller:v0.2* with old plugin configs
<https://github.com/lyft/flyte/commit/b6c38aed501... |
<https://github.com/lyft/flyte/issues/167>
hope I missed nothing
Johnny, I don’t know exactly, but from my expirience, at least this error:
```1 error(s) decoding:
* '' has invalid keys: qubolelimit```
can be related to using flytepropeller:v0.2* with old plugin configs
<https://github.com/lyft/flyte/commit/b6c38aed501... | Ah, you might be right! Maybe my fix is working. Let me look.
That helps, but doesn't totally fix the issue. Seems some work will need to go into fixing it
|
Ah, you might be right! Maybe my fix is working. Let me look.
That helps, but doesn't totally fix the issue. Seems some work will need to go into fixing it
| oh, as I see there is `secrets` section in pfopeller’s config
<https://github.com/lyft/flytepropeller/blob/b1595306d38404c41eb3e6bf7dbabd8c8978544b/pkg/controller/nodes/task/secretmanager/config.go>
does it mean we are able to use it in the workflow task? Sorry, maybe silly question, I didn’t manage to find it in doc ... |
oh, as I see there is `secrets` section in pfopeller’s config
<https://github.com/lyft/flytepropeller/blob/b1595306d38404c41eb3e6bf7dbabd8c8978544b/pkg/controller/nodes/task/secretmanager/config.go>
does it mean we are able to use it in the workflow task? Sorry, maybe silly question, I didn’t manage to find it in doc ... | Great question.
The secret manager in propeller is designed for the secrets of `flytepropeller` (and its plugins). Not so much for individual tasks.
That might be a bit confusing, so I can elaborate a bit.
Flytepropeller launches tasks based on their task "type". In order to launch those tasks, propeller might need ... |
Great question.
The secret manager in propeller is designed for the secrets of `flytepropeller` (and its plugins). Not so much for individual tasks.
That might be a bit confusing, so I can elaborate a bit.
Flytepropeller launches tasks based on their task "type". In order to launch those tasks, propeller might need ... | Oh, cool
It makes sense!
Thank you!
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.