threads
listlengths
1
2.99k
[ { "msg_contents": "Folks,\n\nI noticed that the API document for IMPORT FOREIGN SCHEMA states in\npart:\n\n It should return a list of C strings, each of which must contain a\n CREATE FOREIGN TABLE command. These strings will be parsed and\n executed by the core server.\n\nA reasonable reading of the a...
[ { "msg_contents": "Hi hackers,\n\nWhen I define a view relevant with `char varying`, it shows the type is casted to text. See,\n\ngpadmin=# CREATE TABLE foobar (a character varying);\nCREATE TABLE\ngpadmin=# CREATE VIEW fooview AS SELECT * FROM foobar WHERE a::character varying = ANY(ARRAY['foo'::character vary...
[ { "msg_contents": "Hi hackers,\n\nI want to share results of my last research of implementing LSM index in \nPostgres.\nMost of modern databases (RocksDB, MongoDB, Tarantool,...) are using LSM \ntree instead of classical B-Tree.\n\n From one side, capacity of RAM at modern servers allows to keep the \nwhole dat...
[ { "msg_contents": "Commit 13838740f fixed some issues with step generation in partition\npruning, but as I mentioned in [1], I noticed that there is yet\nanother issue: get_steps_using_prefix() assumes that clauses in the\npassed-in prefix list are sorted in ascending order of their partition\nkey numbers, but ...
[ { "msg_contents": "Hi hackers,\n\nI've attached a small patch to add information to rm_redo_error_callback().\n\nThe changes attached in this patch came while working on the \"Add \ninformation during standby recovery conflicts\" patch (See [1]).\n\nThe goal is to add more information during the callback (if do...
[ { "msg_contents": "If shutdown (non hot enabled) standby and promote the standby using\npromote_trigger_file via pg_ctl start with -w (wait), currently pg_ctl\nreturns as soon as recovery is started. Instead would be helpful if\npg_ctl can wait till PM_STATUS_READY for this case, given promotion is\nrequested.\...
[ { "msg_contents": "I'm testing with a customer's data on pg13dev and got output for which Peak\nMemory doesn't look right/useful. I reproduced it on 565f16902.\n\nCREATE TABLE p(i int) PARTITION BY RANGE(i);\nCREATE TABLE p1 PARTITION OF p FOR VALUES FROM (0)TO(1000);\nCREATE TABLE p2 PARTITION OF p FOR VALUES...
[ { "msg_contents": "Hi,\n\nI see that release 13 is currently in beta.\nWhen will be the official production release of 13 be out?\n\nWe need to see if we can include this as part of our product release cycle.\n\nRegards,\nJoel\n\n\n\n\n\n\n\n\n\nHi,\n \nI see that release 13 is currently in beta.\nWhen will be ...
[ { "msg_contents": "A colleague of mine brought to my attention that pg_rewind is not crash \nsafe. If it is interrupted for any reason, it leaves behind a data \ndirectory with a mix of data from the source and target images. If \nyou're \"lucky\", the server will start up, but it can be in an \ninconsistent st...
[ { "msg_contents": "Hi all,\n\nAs $subject says, pg_test_fsync and pg_test_timing don't really check\nthe range of option values specified. It is possible for example to\nmake pg_test_fsync run an infinite amount of time, and pg_test_timing\ndoes not handle overflows with --duration at all.\n\nThese are far fro...
[ { "msg_contents": "The function pg_sequence_last_value() was added to underlie the\npg_sequences view, and it's the only way I'm aware of from userspace\nto directly get the last value of a sequence globally (i.e., not\nwithin the current session like currval()/lastval()). Obviously you\ncan join to the pg_sequ...
[ { "msg_contents": "I got the first draft of $SUBJECT done a little earlier than usual.\nSee\n\nhttps://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=a2e0cf45c21afbcbc544d1aca8d51d90004aa5d9\n\nThere seemed to be more than the usual quota of commits that I decided\nnot to document because they seeme...
[ { "msg_contents": "Ashutosh Bapat noticed that WalSndWaitForWal() is setting\nwaiting_for_ping_response after sending a keepalive that does *not*\nrequest a reply. The bad consequence is that other callers that do\nrequire a reply end up in not sending a keepalive, because they think it\nwas already sent previ...
[ { "msg_contents": "While reviewing an amcheck patch of Andrey Borodin's, I noticed that\nit had a problem that I tied back to btree_xlog_split()'s loose\napproach to locking buffers compared to the primary [1] (i.e. compared\nto _bt_split()). This created a problem the proposed new check that is\nnot unlike the...
[ { "msg_contents": "Hi all,\n\nThis is a continuation of the work that has been previously discussed\nhere, resulting mainly in e3931d0 for pg_attribute and pg_shdepend:\nhttps://www.postgresql.org/message-id/20190213182737.mxn6hkdxwrzgxk35@alap3.anarazel.de\n\nI have been looking at the amount of work that coul...
[ { "msg_contents": "Hi, hackers!\n\nI'd like to propose a patch which introduces a functionality to include\nadditional columns to SPGiST index to increase speed of queries containing\nthem due to making the scans index only in this case. To date this\nfunctionality was available in GiSt and btree, I suppose the...
[ { "msg_contents": "Hi all,\n\nAs far as I understand, in the upcoming version 13, information about\nbuffers used during planning is now available in the explain plan.\n\n[…]\n Planning Time: 0.203 ms\n Buffers: shared hit=14\n[…]\n\nIn the JSON format, the data structure is a bit different:\n\n[…]\n \"Pl...
[ { "msg_contents": "I'm thinking about whether we should get rid of the distprep target, the \nstep in the preparation of the official source tarball that creates a \nbunch of prebuilt files using bison, flex, perl, etc. for inclusion in \nthe tarball. I think this concept is no longer fitting for contemporary ...
[ { "msg_contents": "Hi,\n\nAttached is a draft of the release announcement for the update release\non 2020-08-13, which also includes the release of PostgreSQL 13 Beta 3.\nReviews and feedback are welcome.\n\nThis is a fairly hefty release announcement as it includes notes both\nabout the update release and the ...
[ { "msg_contents": "Hi hackers,\n\nHere are some more experimental patches to reduce system calls.\n\n0001 skips sending signals when the recipient definitely isn't\nwaiting, using a new flag-and-memory-barrier dance. This seems to\nskip around 12% of the kill() calls for \"make check\", and probably\nhelps wit...
[ { "msg_contents": "I use IMPORT FOREIGN SCHEMA a bit to set up systems for testing. But not\nenough that I can ever remember whether INTO or FROM SERVER comes first in\nthe syntax.\n\nHere is an improvement to the tab completion, so I don't have to keep\nlooking it up in the docs.\n\nIt accidentally (even befo...
[ { "msg_contents": "Is there a way that we can show information about nested queries in\npg_stat_activity? It's often inconvenient for users when somebody's\nexecuting a function and it doesn't seem to be finishing as quickly as\nanticipated. You can't really tell where in that function things broke\ndown. There...
[ { "msg_contents": "Hello,\n\nAn other solution is to expose nested queryid, and to join it with pg_stat_statements.\nActual development trying to add queryid to pg_stat_activity isn't helpfull, because it is only exposing top level one.\nExtension pg_stat_sql_plans (github) propose a function called pg_backend_...
[ { "msg_contents": "Last week, James reported to us that after promoting a replica, some\nseqscan was taking a huge amount of time; on investigation he saw that\nthere was a high rate of FPI_FOR_HINT wal messages by the seqscan.\nLooking closely at the generated traffic, HEAP_XMIN_COMMITTED was being\nset on som...
[ { "msg_contents": "I previously[1] posted a patch to have multiple CREATE INDEX CONCURRENTLY\nnot wait for the slowest of them. This is an update of that, with minor\nconflicts fixed and a fresh thread.\n\nTo recap: currently, any CREATE INDEX CONCURRENTLY will wait for all\nother CICs running concurrently to ...
[ { "msg_contents": "I want to write some test cases with extended query in core test system.\nbasically it looks like\n\nPreparedStatement preparedStatement = conn.prepareStatement(\"select *\nfrom bigtable\");\npreparedStatement.setFetchSize(4);\nResultSet rs = preparedStatement.executeQuery();\nwhile(rs.next(...
[ { "msg_contents": "I think this change neglected to add plpgsql to the extension\ndependencies in the .control file:\n\n12:53:51 # Failed test 'psql -qc 'CREATE EXTENSION \"cube\"''\n12:53:51 # at t/TestLib.pm line 213.\n12:53:51 not ok 68 - psql -qc 'CREATE EXTENSION \"cube\"'\n12:53:51 # got: '1'...
[ { "msg_contents": "Hi,\n\nIn case of smart shutdown postmaster receives SIGTERM from the pg_ctl,\nit \"disallows new connections, but lets existing sessions end their\nwork normally\". Which means that it doesn't abort any ongoing txns in\nany of the sessions and it lets the sessions to exit(on their own) and\n...
[ { "msg_contents": "There are two ancient hacks in the cygwin and solaris ports that appear \nto have been solved more than 10 years ago, so I think we can remove \nthem. See attached patches.\n\n-- \nPeter Eisentraut http://www.2ndQuadrant.com/\nPostgreSQL Development, 24x7 Support, Remote DBA, Tr...
[ { "msg_contents": "Here is a patch to have pg_dump use pg_get_functiondef() instead of \nassembling the CREATE FUNCTION/PROCEDURE commands itself. This should \nsave on maintenance effort in the future. It's also a prerequisite for \nbeing able to dump functions with SQL-standard function body discussed \nin ...
[ { "msg_contents": "Hi,\n\nAfter a smart shutdown is issued(with pg_ctl), run a parallel query,\nthen the query hangs. The postmaster doesn't inform backends about the\nsmart shutdown(see pmdie() -> SIGTERM -> BACKEND_TYPE_NORMAL are not\ninformed), so if they request parallel workers, the postmaster is\nunabl...
[ { "msg_contents": "Hi\n\nI would like to start another thread to follow up on [1], mostly to bump up the\ntopic. Just to remind, it's about how pg_stat_statements jumbling ArrayExpr in\nqueries like:\n\n SELECT something FROM table WHERE col IN (1, 2, 3, ...)\n\nThe current implementation produces different ...
[ { "msg_contents": "I am finally trying to move from python2.7 to python 3.x\n\nfor both 3.7 and 3.8 I have (attached log):\n\n2020-08-12 18:35:47.433 CEST [10418] pg_regress/python3/ltree_plpython \nERROR: incompatible library \"/pub/devel/postgresql/prov\na38/postgresql-12.4-1.x86_64/build/tmp_install/usr/lib...
[ { "msg_contents": "Hi,\n\nWhen developing patches I find it fairly painful that I cannot re-indent\npatches with pgindent without also seeing a lot of indentation changes\nin unmodified parts of files. It is easy enough ([1]) to only re-indent\nfiles that I have modified, but there's often a lot of independent...
[ { "msg_contents": "Hi all,\n\nPer the following commit in upstream SELinux, security_context_t has\nbeen marked as deprecated, generating complains with\n-Wdeprecated-declarations:\nhttps://github.com/SELinuxProject/selinux/commit/7a124ca2758136f49cc38efc26fb1a2d385ecfd9\n\nThis can be seen with Debian GID when...
[ { "msg_contents": "Hi hackers,\n\nPGRES_FATAL_ERROR is the result status in most cases in the client-side when the backend process raises an error. When the query is failed to execute, PGRES_FATAL_ERROR is returned.\nBut in another case, PGRES_FATAL_ERROR is also returned. The situation is that the network is b...
[ { "msg_contents": "Hello,\n\nI'm not sure if I should have posted this to pgsql-advocacy, but this is being developed so I posted here.\n\nDoes anyone know if this development come to open source Postgres, or only to the cloud services of Microsoft and Google?\n\n(I wonder this will become another reason that P...
[ { "msg_contents": "Hello!\n\nAccording to the docs[1], one may use DEFAULT keyword while inserting\ninto generated columns (stored and identity). However, currently it\nworks only for a single VALUES sublist with DEFAULT for a generated column\nbut not for the case when VALUES RTE is used. This is not being tes...
[ { "msg_contents": "Hi all,\n\nWhile working on support for REINDEX for partitioned relations, I have\nnoticed an old bug in the logic of ReindexMultipleTables(): the list\nof relations to process is built in a first transaction, and then each\ntable is done in an independent transaction, but we don't actually\n...
[ { "msg_contents": "Hi hackers,\n\nRight now jsonb functions are treated as non-shippable by postgres_fdw \nand so predicates with them are not pushed down to foreign server:\n\ncreate table jt(content jsonb);\ncreate extension postgres_fdw;\ncreate server pg_fdw  FOREIGN DATA WRAPPER postgres_fdw options(host \...
[ { "msg_contents": "I ran into this while running pg_upgrade from beta2 to beta3:\n$ time sudo -u postgres sh -c 'cd /var/lib/pgsql; /usr/pgsql-13/bin/pg_upgrade -b /usr/pgsql-13b2/bin/ -d ./13b2/data -D ./13/data --link'\n\treal 94m18.335s\n\nThis instances has many table partitions, and the production insta...
[ { "msg_contents": "Hi,\n\nThe following sentence in high-availability.sgml is not true:\n\n The background writer is active during recovery and will perform\n restartpoints (similar to checkpoints on the primary) and normal block\n cleaning activities.\n\nI think this is an oversight of the commit 806a...
[ { "msg_contents": "While hacking on pg_rewind, this in pg_rewind's main() function caught \nmy eye:\n\n progress_report(true);\n printf(\"\\n\");\n\nIt is peculiar, because progress_report() uses fprintf(stderr, ...) for \nall its printing, and in fact the only other use of printf() in \npg_rewind is in...
[ { "msg_contents": "While hacking on pg_rewind, I noticed that commit and abort WAL records \nare never marked with the XLR_SPECIAL_REL_UPDATE flag. But if the record \ncontains \"dropped relfilenodes\", surely it should be?\n\nIt's harmless as far as the backend and all the programs in PostgreSQL \nrepository a...
[ { "msg_contents": "Hello\n\nI would like to implement a new data type next to char, number, varchar... for example a special \"Money\" type, but\nI don't want to use extensions and the Create type command. I want to implement it directly inside source code,\nbecause I want to implement my new type at lower lev...
[ { "msg_contents": "Yesterday's releases included some fixes meant to make it harder\nfor a malicious user to sabotage an extension installation/update\nscript. There are some things remaining to be done in the area,\nthough:\n\n1. We don't have a way to make things adequately secure for extensions\nthat depend...
[ { "msg_contents": "Hi,\n\nI wonder what caused this[1] one-off failure to see tuples in clustered order:\n\ndiff -U3 /home/pgbfarm/buildroot/REL_13_STABLE/pgsql.build/src/test/regress/expected/cluster.out\n/home/pgbfarm/buildroot/REL_13_STABLE/pgsql.build/src/test/regress/results/cluster.out\n--- /home/pgbfarm/...
[ { "msg_contents": "Hi\n\nI am working on tracing support to plpgsql_check\n\nhttps://github.com/okbob/plpgsql_check\n\nI would like to print content of variables - and now, I have to go some\ndeeper than I would like. I need to separate between scalar, row, and\nrecord variables. PLpgSQL has code for it - but i...
[ { "msg_contents": "Hi\n\nplpgsql_check extension is almost complete now. This extension is available\non all environments and for all supported Postgres releases. It is probably\ntoo big to be part of contrib, but I think so it can be referenced in\nhttps://www.postgresql.org/docs/current/plpgsql-development-ti...
[ { "msg_contents": "Dear all\n\nIn MobilityDB\nhttps://github.com/MobilityDB/MobilityDB\nwe use extensively the range types.\n\nIs there any possibility to make the function range_union_internal available to\nuse by other extensions ? Otherwise we need to copy/paste it verbatim. For\nexample lines 114-153 in\nht...
[ { "msg_contents": "Hi,\n\nWith [1] applied so that you can get crash recovery to be CPU bound\nwith a pgbench workload, we spend an awful lot of time in qsort(),\ncalled from compactify_tuples(). I tried replacing that with a\nspecialised sort, and I got my test crash recovery time from ~55.5s\ndown to ~49.5s ...
[ { "msg_contents": "The following bug has been logged on the website:\n\nBug reference: 16583\nLogged by: Jiří Fejfar\nEmail address: jurafejfar@gmail.com\nPostgreSQL version: 12.4\nOperating system: debian 10.5\nDescription: \n\nJoining two identical tables placed on separate DBs wit...
[ { "msg_contents": "snapshot scalability: cache snapshots using a xact completion counter.\n\nPrevious commits made it faster/more scalable to compute snapshots. But not\nbuilding a snapshot is still faster. Now that GetSnapshotData() does not\nmaintain RecentGlobal* anymore, that is actually not too hard:\n\nTh...
[ { "msg_contents": "Hi,\nRight now pg_waldump just prints whether the message is transactional\nor not and its size. That doesn't help much to understand the message\nitself. If it prints the contents of a logical WAL message, it helps\ndebugging logical replication related problems. Prefix is a\nnull-terminated...
[ { "msg_contents": "Hi,\n\nIt's important to provide the metrics for tuning the size of WAL \nbuffers.\nFor now, it's lack of the statistics how often processes wait to write \nWAL because WAL buffer is full.\n\nIf those situation are often occurred, WAL buffer is too small for the \nworkload.\nDBAs must to tune...
[ { "msg_contents": "Hi,\n\nprotocol.sgml describes the protocol messages received by a BASE_BACKUP\nstreaming command, but doesn't tell anything about the additional\nCopyResponse data message containing the contents of the backup\nmanifest (if requested) after having received the tar files. So i\npropose the at...
[ { "msg_contents": "During crash recovery, the server writes this to log:\n\n< 2020-08-16 08:46:08.601 -03 >LOG: redo done at 2299C/1EC6BA00\n< 2020-08-16 08:46:08.877 -03 >LOG: checkpoint starting: end-of-recovery immediate\n\nBut runs a checkpoint, which can take a long time, while the \"ps\" display still...
[ { "msg_contents": "Hi,\n\nI started to hack on making pg_rewind crash-safe (see [1]), but I \nquickly got side-tracked into refactoring and tidying up up the code in \ngeneral. I ended up with this series of patches:\n\nThe first four patches are just refactoring that make the code and the \nlogic more readable...
[ { "msg_contents": "As a note I tried to use the deb repo today:\n\nhttps://www.postgresql.org/download/linux/debian/\n\nwith an old box on Wheezy.\nIt only seems to have binaries up to postgres 10.\n\nMight be nice to make a note on the web page so people realize some\ndistro's aren't supported fully instead of...
[ { "msg_contents": "Hi hackers,\n\nMore than month ago I have sent bug report to pgsql-bugs:\n\nhttps://www.postgresql.org/message-id/flat/5d335911-fb25-60cd-4aa7-a5bd0954aea0%40postgrespro.ru\n\nwith the proposed patch but have not received any response.\n\nI wonder if there is some other way to fix this issue ...
[ { "msg_contents": "Hello\n\nThe REINDEX CONCURRENTLY documentation states that if a transient index\nused lingers, the fix is to drop the invalid index and perform RC again;\nand that this is to be done for \"ccnew\" indexes and also for \"ccold\"\nindexes:\n\n The recommended recovery method in such cases i...
[ { "msg_contents": "Hello\n\nI have a publisher instance, cpu 32 core, ram 64GB, with SSD and installed\nPostgreSQL 10 on it. I want to use logical replication with it , I\ncreate publication on it, add about 20 tables in the pub, each tables will\nhave about 1 million line data,.\n\nI wonder how many subscr...
[ { "msg_contents": "Hello,\r\n\r\nI am trying to handle the limit that we can't do a tuple move caused by BEFORE TRIGGER,\r\nduring which I get two doubt points:\r\n\r\nThe first issue:\r\nIn ExecBRUpdateTriggers() or ExecBRInsertTriggers() function why we need to check the\r\nresult slot after every trigger cal...
[ { "msg_contents": "Hi,\n\nI was just looking over the JIT code and noticed a few comment and\ndocumentation typos. The attached fixes them.\n\nI'll push this in my UTC+12 morning if nobody objects to any of the\nchanges before then.\n\nUnsure if it'll be worth backpatching or not.\n\nDavid", "msg_date": "T...
[ { "msg_contents": "While trying to make sense of Adam Sjøgren's problem [1], I found\nmyself staring at ReplicationSlotsComputeRequiredXmin() in slot.c.\nIt seems to me that that is very shaky code, on two different\ngrounds:\n\n1. Sometimes it's called with ProcArrayLock already held exclusively.\nThis means t...
[ { "msg_contents": "While working with Nathan Bossart on an extension, we came across an\ninteresting quirk and possible inconsistency in the PostgreSQL code\naround infomask flags. I'd like to know if there's something I'm\nmisunderstanding here or if this really is a correctness/robustness gap\nin the code.\n...
[ { "msg_contents": "I'm concerned about how the FSM gives out pages to heapam. Disabling\nthe FSM entirely helps TPC-C/BenchmarkSQL, which uses non-default heap\nfillfactors for most tables [1]. Testing has shown that this actually\nincreases throughput for the benchmark (as measured in TPM) by 5% -\n9%, even th...
[ { "msg_contents": "Hi,\n\nI've attached the patch for $subject.\n\ns/replications lots/replication slots/\n\nRegards,\n\n-- \nMasahiko Sawada http://www.2ndQuadrant.com/\nPostgreSQL Development, 24x7 Support, Remote DBA, Training & Services", "msg_date": "Fri, 21 Aug 2020 10:58:27 +0900", "ms...
[ { "msg_contents": "Hello hackers,\r\n\r\nCurrently, if BEFORE TRIGGER causes a partition change, it reports an error 'moving row\r\nto another partition during a BEFORE FOR EACH ROW trigger is not supported' and fails\r\nto execute. I want to try to address this limitation and have made an initial patch to get\...
[ { "msg_contents": "Hi hackers,\n\nI am sorry for the question which may be already discussed multiple times.\nBut I have not found answer for it neither in internet neither in \npgsql-hackers archieve.\nUPSERT (INSERT ... IN CONFLICT...) clause was added to the Postgres a \nlong time ago.\nAs far as I remember ...
[ { "msg_contents": "We've seen repeated failures in the tests added by commit 43e084197:\n\nhttps://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=anole&dt=2020-08-23%2005%3A46%3A17\nhttps://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=tern&dt=2020-08-04%2001%3A05%3A30\nhttps://buildfarm.postgresql.org/cgi-b...
[ { "msg_contents": "Hi!\n\nI created a POC patch that allows showing a list of extended statistics by\n\"\\dz\" command on psql. I believe this feature helps DBA and users who\nwould like to know all extended statistics easily. :-D\n\nI have not a strong opinion to assign \"\\dz\". I prefer \"\\dx\" or \"\\de*\"...
[ { "msg_contents": "Hi Hackers,\n\nI may be wrong, but an issue seems to have been introduced by the\nfollowing commit (March 11, 2019):\n\n Allow fractional input values for integer GUCs, and improve rounding logic\n https://github.com/postgres/postgres/commit/1a83a80a2fe5b559f85ed4830acb92d5124b7a9a\n\nT...
[ { "msg_contents": "Hi,\n\nAs specified in $subject, if the bitmap constructed by bitmap index\nscan is non-lossy i.e. row-level bitmap, then showing \"Recheck Cond\"\nin EXPLAIN ANALYZE output is pointless. However in EXPLAIN without\nANALYZE we can't say the bitmap is actually a non-lossy one, as we\ndon't act...
[ { "msg_contents": "Hi all,\n\nAdmittedly quite ahead of time, I would like to volunteer as Commitfest manager for 2020-11.\n\nIf the role is not filled and there are no objections, I can reach out again in October for confirmation.\n\n//Georgios\n\n\n", "msg_date": "Mon, 24 Aug 2020 13:08:53 +0000", "ms...
[ { "msg_contents": "Hi Tom,\nI'm starting tests using ASAN (address sanitizer) at Windows side, using\nmsvc 2019 (built in asan support):\n\nFirst test report this:\n2020-08-24 10:02:33.220 -03 postmaster[6656] LOG: starting PostgreSQL\n14devel, compiled by Visual C++ build 1927, 64-bit\n2020-08-24 10:02:33.228...
[ { "msg_contents": "Hi\n\nI wrote a proof concept for the support window function from plpgsql.\n\nWindow function API - functions named WinFuncArg* are polymorphic and it is\nnot easy to wrap these functions for usage from SQL level. I wrote an\nenhancement of the GET statement - for this case GET WINDOW_CONTEX...
[ { "msg_contents": "Hi,\n\nCurrently lwlock acquisition, whether direct, or via the LockBuffer()\nwrapper, have a mode argument. I don't like that much, for three\nreasons:\n\n1) I've tried to add annotations for static analyzers to help with\n locking correctness. The ones I looked at don't support annotating...
[ { "msg_contents": "Hi all,\n\nWhile testing with DTrace, I realized we acquire\nReplicationSlotControl lwlock at some places even when\nmax_replication_slots is set to 0. For instance, we call\nReplicationSlotCleanup() within PostgresMian() when an error happens\nand acquire ReplicationSlotControl lwlock.\n\nTh...
[ { "msg_contents": "Here is a series of patches to remove some unused function parameters. \nIn each case, the need for them was removed by some other code changes \nover time but the unusedness was not noticed. I have included a \nreference to when they became unused in each case.\n\n-- \nPeter Eisentraut ...
[ { "msg_contents": "A user tried to use the cracklib build-time option of the passwordcheck \nmodule. This failed, as it turned out because there was no dictionary \ninstalled in the right place, but the error was not properly reported, \nbecause the existing code just throws away the error message from \ncrack...
[ { "msg_contents": "I noticed today there are a few places where we use bms_num_memebers()\nwhere we really should be using bms_membership(). These are not bugs,\nthey're mostly just bad examples to leave laying around, at best, and\na small performance penalty, at worst.\n\nUnless there are any objections, I p...
[ { "msg_contents": "Hi Tom,\n\nPer Coverity.\n\nThe function parse_hba_auth_op at (src/backend/libpq/hba.c) allows resource\nleaks when called\nby the function parse_hba_line, with parameters LOG and DEBUG3 levels.\n\nThe function SplitGUCList (src/bin/pg_dump/dumputils.c) allows even\nreturning FALSE,\nthat nam...
[ { "msg_contents": "The USE_OPENSSL_RANDOM macro is defined when OpenSSL is used as a randomness\nprovider, but the implementation of strong randomness is guarded by USE_OPENSSL\nin most places. This is technically the same thing today, but it seems\nhygienic to use the appropriate macro in case we ever want to...
[ { "msg_contents": "Hi Tom,\n\nPer Coverity.\n\nThe SearchSysCache1 allows return NULL and at function AlterStatistics,\nhas one mistake, lack of, check of return, which enables a dereference NULL\npointer,\nat function heap_modify_tuple.\n\nWhile there is room for improvement.\nAvoid calling SearchSysCache1 and...
[ { "msg_contents": "Hi Tom,\n\nPer Coverity.\n\nThe variable root_offsets is read at line 1641, but, at this point,\nthe content is unknown, so it is impossible to test works well.\n\nregards,\nRanier Vilela", "msg_date": "Tue, 25 Aug 2020 13:19:33 -0300", "msg_from": "Ranier Vilela <ranier.vf@gmail.com>...
[ { "msg_contents": "Hi,\n\nPer Coverity.\n\nARRAY vs SINGLETON\n\nIf variable htids is accessed like array, but is a simple pointer, can be\n\"This might corrupt or misinterpret adjacent memory locations.\"\n\nat line 723:\n/* Form standard non-pivot tuple */\nitup->t_info &= ~INDEX_ALT_TID_MASK;\nhtids = &itup-...
[ { "msg_contents": "I see a compiler warning on git master:\n\n sharedfileset.c:288:8: warning: variable ‘found’ set but not used [-Wunused-but-set-variable]\n\n-- \n Bruce Momjian <bruce@momjian.us> https://momjian.us\n EnterpriseDB https://enterprisedb.com\n\n The usefu...
[ { "msg_contents": "The comment in procarray.c that described GlobalVisDataRels instead \nmentioned GlobalVisCatalogRels a second time. Patch attached.", "msg_date": "Wed, 26 Aug 2020 16:22:51 -0500", "msg_from": "Jim Nasby <nasbyj@amazon.com>", "msg_from_op": true, "msg_subject": "Typo in procar...
[ { "msg_contents": "If action and qual reference same object in CREATE RULE, it results in\ncreating duplicate entries in pg_depend for it. Doesn't pose any harm, just\nunnecessarily bloats pg_depend. Reference InsertRule(). I think should be\nable to avoid adding duplicate entries.\n\nDon't know if this behavio...
[ { "msg_contents": "Greeting.\n\nI do see the README says we support bushy plans and I also see bushy\nplans in real life (for example tpc-h Q20) like below. However I don't know\nhow it is generated with the algorithm in join_search_one_lev since it\nalways\nmake_rels_by_clause_join with joinrel[1] which is ini...
[ { "msg_contents": "Hi all,\n\nWhile digging into a different patch involving DROP INDEX CONCURRENTLY\nand replica indexes, I have found that the handling of indisreplident\nis inconsistent for invalid indexes:\nhttps://www.postgresql.org/message-id/20200827022835.GM2017@paquier.xyz\n\nIn short, imagine the foll...
[ { "msg_contents": "Hi,\n\nIs this something to worry about, or is it another problem with the\nanalysis tool, that nobody cares about?\nclang 10 (64 bits)\npostgres 14 (latest)\n\n31422==ERROR: LeakSanitizer: detected memory leaks\n\nDirect leak of 4560 byte(s) in 1 object(s) allocated from:\n #0 0x50e33d in...
[ { "msg_contents": "Hi,\n\nPer Clang UBSan\nClang 10 (64 bits)\nPostgres 14 (latest)\n\n2020-08-27 01:02:14.930 -03 client backend[42432] pg_regress/create_table\nSTATEMENT: create table defcheck_0 partition of defcheck for values in (0);\nindexcmds.c:1162:22: runtime error: null pointer passed as argument 2,\n...
[ { "msg_contents": "I am getting following error in configuration.log of installation . Please help\n\nIs there any pkg-config path that needs to be configured/set in environment for this to work.\n\nconfigure:8172: checking for libxml-2.0 >= 2.6.23\nconfigure:8179: $PKG_CONFIG --exists --print-errors \"libxml-...
[ { "msg_contents": "Procedures currently don't allow OUT parameters. The reason for this is \nthat at the time procedures were added (PG11), some of the details of \nhow this should work were unclear and the issue was postponed. I am now \nintending to resolve this.\n\nAFAICT, OUT parameters in _functions_ are...
[ { "msg_contents": "Hello hackers,\r\n\r\nWhile working on two phase related issues, I found something related to two phase could be optimized.\r\n\r\n1. The current implementation decouples PREPRE and COMMIT/ABORT PREPARE a lot. This is flexible, but if\r\n PREPARE & COMMIT/ABORT mostly happens on the same b...
[ { "msg_contents": "Hi All,\n\nWhile reviewing the patch for pg_surgery contrib module - [1], Asim\nPraveen suggested that it would be better to replace the check for\naccess method OID with handler OID. Otherwise, if someone creates a\nnew AM using the AM handler that is originally supported for e.g.\n\"heap_ta...
[ { "msg_contents": "Hi\n\nI am new to postgreSQL , I am trying to install the same with XML support but it is giving below error on configuration.\n\n./configure --prefix=/opt/postgresql-12.3/pqsql --with-libxml --datadir=/home/postgres/ --with-includes=/usr/lib64/\n\nchecking for libxml/parser.h... no\nconfigur...
[ { "msg_contents": "Hi,\n\nIn good written query IS NULL and IS NOT NULL check on primary and non null\nconstraints columns should not happen but if it is mentioned PostgreSQL\nhave to be smart enough for not checking every return result about null\nvalue on primary key column. Instead it can be evaluate its tru...