threads
listlengths
1
2.99k
[ { "msg_contents": "Hi,\n\nWhile working on [1], I observed that extra memory is allocated in\n'create_list_bounds'\nfunction which can be avoided. So the attached patch removes extra memory\nallocations done inside 'create_list_bounds' function and also removes the\nunused variable 'cell'.\n\nIn the existing co...
[ { "msg_contents": "I think there is a typo in src/backend/storage/lmgr/README.barrier.\nAttached patch should fix it.\n\nBest regards,\n--\nTatsuo Ishii\nSRA OSS, Inc. Japan\nEnglish: http://www.sraoss.co.jp/index_en.php\nJapanese:http://www.sraoss.co.jp", "msg_date": "Sun, 16 May 2021 21:11:33 +0900 (JST)"...
[ { "msg_contents": "Greetings!\n\nLet say I have a foreign server using the reference postgres_fdw defined \nwithout a port number:\n\nCREATE SERVER /dat_server/ FOREIGN DATA WRAPPER /postgres_fdw/ OPTIONS ( \n|/host '172.1.1.1', dbname 'dbover_der'/| )\n\nNaturally the tables in question are setup using a forei...
[ { "msg_contents": "Hi Hackers,\n\nWhile understanding the behaviour of the to_char() function as\nexplained in [1], I observed that some patterns related to time zones\ndo not display values if we mention in lower case. As shown in the\nsample output [2], time zone related patterns TZH, TZM and OF outputs\nprop...
[ { "msg_contents": "Hi all,\n\nI have bumped into $subject while playing with this feature, and this\ncan be really useful to be able to reset the compression method for\nall the tables at restore. The patch is simple but that's perhaps too\nlate for 14, so I am adding it to the next CF. \n\nThanks,\n--\nMichae...
[ { "msg_contents": "While doing logical replication testing we encountered a problem which\ncauses a deadlock error to be logged when replicating a TRUNCATE\nsimultaneously to 2 Subscriptions.\ne.g.\n----------\n2021-05-12 11:30:19.457 AEST [11393] ERROR: deadlock detected\n2021-05-12 11:30:19.457 AEST [11393] ...
[ { "msg_contents": "Since PostgreSQL 9.3, in commit a266f7dd93b, we've added the text:\n\n+ The obsolete \"winflex\" binaries distributed on the PostgreSQL FTP site\n+ and referenced in older documentation will fail with \"flex: fatal\n+ internal error, exec failed\" on 64-bit Windows hosts. Us...
[ { "msg_contents": "Hi,\n\nIt looks like the values such as '123.456', '789.123' '100$%$#$#',\n'9,223,372,' are accepted and treated as valid integers for\npostgres_fdw options batch_size and fetch_size. Whereas this is not\nthe case with fdw_startup_cost and fdw_tuple_cost options for which an\nerror is thrown....
[ { "msg_contents": "Hi,\n\n\n\nWhen loading some data into a partitioned table for testing purpose,\n\nI found even if I specified constant value for the partition key[1], it still do\n\nthe tuple routing for each row.\n\n\n\n[1]---------------------\n\nUPDATE partitioned set part_key = 2 , …\n\nINSERT into part...
[ { "msg_contents": "If a promotion is triggered while recovery is paused, the paused state ends\nand promotion continues. But currently pg_get_wal_replay_pause_state()\nreturns 'paused' in that case. Isn't this a bug?\n\nAttached patch fixes this issue by resetting the recovery pause state to\n'not paused' when ...
[ { "msg_contents": "Hi,\n\npg_attribute is one of the biggest table in a new cluster, and often the\nbiggest table in production clusters. Its size is also quite relevant in\nmemory, due to all the TupleDescs we allocate.\n\nI just noticed that the new attcompression increased the size not just\nby 1 byte, but b...
[ { "msg_contents": "You might find that ICU 69 (pretty new, see \nhttp://site.icu-project.org/download/69) will cause compile failures \nwith PG 10 (pretty old). ICU 69 has switched to using stdbool.h, which \nconflicts with the home-made definitions that we used until PG10. \nCompile errors look like this:\n\n...
[ { "msg_contents": "Dear all\n\nIn MobilityDB we have defined parallel aggregations with a combine\nfunction, e.g.,\n\nCREATE AGGREGATE extent(tbox) (\n SFUNC = tbox_extent_transfn,\n STYPE = tbox,\n COMBINEFUNC = tbox_extent_combinefn,\n PARALLEL = safe\n);\n\nWe would like to trigger the combine functions ...
[ { "msg_contents": "> To: Pengchengliu <pengchengliu@tju.edu.cn>\r\n> Cc: Greg Nancarrow <gregn4422@gmail.com>; Andres Freund <andres@anarazel.de>; PostgreSQL-development <pgsql-hackers@postgresql.org>\r\n> Subject: Re: Re: Parallel scan with SubTransGetTopmostTransaction assert coredump\r\n\r\n> I've also seen ...
[ { "msg_contents": "I wanted to dump all heap WAL records with pg_waldump, so I did this:\n\n> $ pg_waldump --rmgr=heap --rmgr=heap2 data/pg_wal/000000010000000000000001 --stat=record\n> Type N (%) Record size (%) FPI size (%) C...
[ { "msg_contents": "I revently tried to upgrade a standby following the documentation,\nbut I found it hard to understand, and it took me several tries to\nget it right. This is of course owing to my lack of expertise with\nrsync, but I think the documentation and examples could be clearer.\n\nI think it would ...
[ { "msg_contents": "Hi,\n\nI can reproducibly get build failures in pgbench on 32-bit i386\nDebian, both on sid and buster. (The older Debian stretch and Ubuntu\nbionic are unaffected. Other architectures are also fine.)\n\nhttps://pgdgbuild.dus.dg-i.net/view/Binaries/job/postgresql-14-binaries/635/\n\nhttps://p...
[ { "msg_contents": "Hello hackers,\n\nI'm wrapping up a patch that adds SQL:2011 FOR PORTION OF syntax and\nthen uses it to implement CASCADE in temporal foreign keys. The FKs\nare implemented as triggers, like ordinary FKs, and the trigger\nfunction makes a call through SPI that does `UPDATE %s FOR PORTION OF\n...
[ { "msg_contents": "I discovered $SUBJECT after wondering why hyrax hadn't reported\nin recently, and trying to run check-world under CCA to see if\nanything got stuck. Indeed it did --- although this doesn't\nexplain the radio silence from hyrax, because that animal doesn't\nrun any TAP tests. (Neither does a...
[ { "msg_contents": "Hi hackers,\n\nIn response to PMEM-related discussions in the previous thread [1],\nespecially Tomas' performance report [2], I have worked for the way\nthat maps WAL segment files on PMEM as WAL buffers. I start this new\nthread to go that way since the previous one has focused on another\np...
[ { "msg_contents": "Hi,\n\nparse_subscription_options function has some similar code when\nthrowing errors [with the only difference in the option]. I feel we\ncould just use a variable for the option and use it in the error.\nWhile this has no benefit at all, it saves some LOC and makes the code\nlook better wi...
[ { "msg_contents": "Hi\n\n\nI've been discussing about user_catalog_table\nand the possibility of deadlock during synchronous mode\nof logical replication in [1]. I'll launch a new thread\nand summarize the contents so that anyone who is\ninterested in this title can join the discussion.\n\nWe don't have any exa...
[ { "msg_contents": "Several weeks ago I saw this issue in a production environment. The\nread only file looks like a credential file. Michael told me that\nusually such kinds of files should be better kept in non-pgdata\ndirectories in production environments. Thought further it seems that\npg_rewind should be m...
[ { "msg_contents": "Hi,\n\nWhile working on [1], I found that some parts of the code is using\nstrtol and atoi without checking for non-numeric junk input strings. I\nfound this strange. Most of the time users provide proper numeric\nstrings but there can be some scenarios where these strings are not\nuser-suppl...
[ { "msg_contents": "Hello,\n\nwe had a Customer-Report in which `refresh materialized view \nCONCURRENTLY` failed with: `ERROR: column reference \"mv\" is ambiguous`\n\nThey're using `mv` as an alias for one column and this is causing a \ncollision with an internal alias. They also made it reproducible like this...
[ { "msg_contents": "While playing around with the recent SSL testharness changes I wrote a test\nsuite for sslinfo as a side effect, which seemed valuable in its own right as\nwe currently have no coverage of this code. The small change needed to the\ntestharness is to support installing modules, which is broke...
[ { "msg_contents": "Fwiw, if the PostgreSQL projects is considering moving the #postgresql\nIRC channel(s) elsewhere given [1,2], I'm a member of OFTC.net's network\noperations committee and would be happy to help.\n\n[1] https://gist.github.com/aaronmdjones/1a9a93ded5b7d162c3f58bdd66b8f491\n[2] https://fuchsnet...
[ { "msg_contents": "Hi, hackers.\n\nI've been playing with \"autoprepared\" patch, and have got isolation\n\"freeze-the-dead\" test stuck on first VACUUM FREEZE statement.\nAfter some research I found issue is reproduced with unmodified master\nbranch if extended protocol used. I've prepared ruby script for\ndem...
[ { "msg_contents": "I would like to add a thread on pgsql-docs to the commitfest, but I\nfound that that cannot be done.\n\nWhat is the best way to proceed?\nSince we have a \"documentation\" section in the commitfest, it would\nbe useful to allow links to the -docs archives.\n\nYours,\nLaurenz Albe\n\n\n\n", ...
[ { "msg_contents": "Hi all,\n\nWhile diving into a transformation of the tests of pg_upgrade to TAP,\nI am getting annoyed by the fact that regress.so is needed if you\nupgrade an older instance that holds the regression objects from the\nmain regression test suite. The buildfarm code is using a trick to\ncopy ...
[ { "msg_contents": "Currently we are using a custom/generic strategy to handle the data skew\nissue. However, it doesn't work well all the time. For example: SELECT *\nFROM t WHERE a between $1 and $2. We assume the selectivity is 0.0025,\nBut users may provide a large range every time. Per our current strategy...
[ { "msg_contents": "Hi,\nI recently ran into a problem in one of our production postgresql cluster.\nI had noticed lock contention on procarray lock on standby, which causes\nWAL replay lag growth.\nTo reproduce this, you can do the following:\n\n1) set max_connections to big number, like 100000\n2) begin a tran...
[ { "msg_contents": "Hi all,\n\nRobert has mentioned https://nvd.nist.gov/vuln/detail/CVE-2021-3449 on\nthe -security list where a TLS server could crash with some crafted\nrenegociation message. We already disable SSL renegociation\ninitialization for some time now, per 48d23c72, but we don't prevent\nthe serve...
[ { "msg_contents": "Hi\nLogicalIncreaseRestartDecodingForSlot() has a debug log to report a\nnew restart_lsn. But the corresponding function for catalog_xmin.\nHere's a patch to add the same.\n\n-- \nBest Wishes,\nAshutosh Bapat", "msg_date": "Thu, 20 May 2021 17:43:32 +0530", "msg_from": "Ashutosh Bapat...
[ { "msg_contents": "Hi.\n\nThe attached patch allows pushing joins with function RTEs to PostgreSQL \ndata sources.\nThis makes executing queries like this\n\ncreate foreign table f_pgbench_accounts (aid int, bid int, abalance int, \nfiller char(84)) SERVER local_srv OPTIONS (table_name \n'pgbench_accounts');\ns...
[ { "msg_contents": "I'm not too happy with this:\n\nregression=# create procedure p1(out x int) language plpgsql\nregression-# as 'begin x := 42; end';\nCREATE PROCEDURE\n\nregression=# call p1();\nERROR: procedure p1() does not exist\nLINE 1: call p1();\n ^\nHINT: No procedure matches the given na...
[ { "msg_contents": "\nWhile solving a problem with the Beta RPMs, I noticed that they export\nour perl test modules as capabilities like this:\n\n [andrew@f34 x86_64]$ rpm -q --provides -p\n postgresql14-devel-14-beta1_PGDG.fc34.x86_64.rpm | grep ^perl\n perl(PostgresNode)\n perl(PostgresVersion)\n ...
[ { "msg_contents": "Hi,\r\n\r\nWhen reading the code, I noticed some possible issue about fdw batch insert.\r\nWhen I set batch_size > 65535 and insert more than 65535 rows into foreign table, \r\nIt will throw an error:\r\n\r\nFor example:\r\n\r\n------------------\r\nCREATE FOREIGN TABLE vzdalena_tabulka2(a in...
[ { "msg_contents": "-hackers,\n\nI think commit 82ed7748b710e3ddce3f7ebc74af80fe4869492f created some confusion that should be cleaned up before release. I'd like some guidance on what the intended behavior is before I submit a patch for this, though:\n\n+ALTER SUBSCRIPTION mysubscription SET PUBLICATION nosuch...
[ { "msg_contents": "Hello\n\nI some time ago asks about \"Proposition for autoname columns\"\nhttps://www.postgresql.org/message-id/131355559.20201102170529%40yandex.ru\n\n\nNow I have another idea. How about table_name.**?\n\nwhich will be expanded to: table_name.id, table_name.name, table_name.qty etc.\n\n\nIn...
[ { "msg_contents": "Our website links to:\n\nhttps://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=guaibasaurus&dt=latest&stg=make-doc\n\nin order to display the latest build log for the docs.\n\nThis appears to have stopped working at some point. I don't know when,\nunfortunately, it was just brought to...
[ { "msg_contents": "It appears the development version of the release notes are not\naccessible. If you go from:\n\n https://www.postgresql.org/developer/testing/\nto\n https://www.postgresql.org/docs/devel/\nto\n https://www.postgresql.org/docs/devel/release.html\n\nit is fine, but once yo...
[ { "msg_contents": "Hi,\n\nI was just looking at RelOptInfo's partitioning fields and noticed\nthat all_partrels seems to be set in a couple of places but never\nactually referenced.\n\nThe field was added in c8434d64c - Allow partitionwise joins in more\ncases for PG13.\n\nMaybe it did something during the deve...
[ { "msg_contents": "Hi\n\n\nDuring my review of a patch in the community,\nI've encountered failures of OSS HEAD'S make check-world in a continuous loop.\nI just repeated make check-world. Accordingly, this should be an existing issue.\nMake check-world fails once in about 20 times in my env. I'd like to report ...
[ { "msg_contents": "Hi,\n\ndc7420c2 has removed RecentGlobalXmin, but there are still references\nto it in the code, and a set of FIXME references, like this one in\nautovacuum.c (three in total):\n/*\n * Start a transaction so we can access pg_database, and get a snapshot.\n * We don't have a use for the snapsh...
[ { "msg_contents": "Hi all,\n\nIf a logical replication worker cannot apply the change on the\nsubscriber for some reason (e.g., missing table or violating a\nconstraint, etc.), logical replication stops until the problem is\nresolved. Ideally, we resolve the problem on the subscriber (e.g., by\ncreating the mis...
[ { "msg_contents": "Hello pg-devs,\n\nI have given a go at proposing a replacement for rand48.\n\nPOSIX 1988 (?) rand48 is a LCG PRNG designed to generate 32 bits integers \nor floats based on a 48 bits state on 16 or 32 bits architectures. LCG \ncycles on the low bits, which can be quite annoying. Given that we...
[ { "msg_contents": "Hey,\n\nWhile working on the french translation of the manual, I found that one\ncolumn of pg_stats_ext was on the pg_stats columns' list. Here is a quick\npatch to fix this.\n\nRegards.\n\n\n-- \nGuillaume.", "msg_date": "Mon, 24 May 2021 15:53:19 +0200", "msg_from": "Guillaume Lelar...
[ { "msg_contents": "Hi,\n\nPossible pointer TupleDesc rettupdesc used not initialized?\n\nif (!isNull) at line 4346 taking a true branch, the function\ncheck_sql_fn_retval at line 4448 can use rettupdesc uninitialized.\n\nregards,\nRanier Vilela\n\nHi,Possible pointer TupleDesc\trettupdesc used not initialized?i...
[ { "msg_contents": "Hi,\n\nWhile working on an output plugin that uses streaming protocol, I hit an\nassertion failure. Further investigations revealed a possible bug in core\nPostgres. This must be new to PG14 since streaming support is new to this\nrelease. I extended the test_decoding regression test to demon...
[ { "msg_contents": "Hi hackers,\n\nI found this when reading the related code. Here is the scenario:\n\nbool\nRegisterSyncRequest(const FileTag *ftag, SyncRequestType type,\n bool retryOnError)\n\nFor the case retryOnError is true, the function would in loop call\nForwardSyncRequest() until it...
[ { "msg_contents": "In the attached patch, the error message was checking that the \nstructures returned from the parser matched expectations. That's \nsomething we usually use assertions for, not a full user-facing error \nmessage. So I replaced that with an assertion (hidden inside \nlfirst_node()).", "m...
[ { "msg_contents": "My question can be demonstrated with the below example:\n\ncreate table m1(a int, b int);\nexplain (costs off) select (select count(*) filter (*where true*) from m1\nt1)\nfrom m1 t2 where t2.b % 2 = 1;\n\n QUERY PLAN\n---------------------------------\n Seq Scan on m1 t2\n Filter...
[ { "msg_contents": "Hi hackers,\n\nBack in 2016 while being at PostgresPro I developed the ZSON extension [1].\nThe extension introduces the new ZSON type, which is 100% compatible with\nJSONB but uses a shared dictionary of strings most frequently used in given\nJSONB documents for compression. These strings ar...
[ { "msg_contents": "When I am understanding the relationship between Query->rtable and\nroot->simple_rte_array, I'd like to assume that Query->rtable should be\nnever used\nwhen root->simple_rte_array is ready. I mainly checked two places,\nmake_one_rel and\ncreate_plan with the below hacks.\n\n{\n List *l = ro...
[ { "msg_contents": "Hi all,\n\nI got curious with what Justin just told here with\nmax_logical_replication_workers:\nhttps://www.postgresql.org/message-id/20210526001359.GE3676@telsasoft.com\n\nAnd while looking at the full set of GUCs, I noticed much more than\none parameter that needed adjustments in the docum...
[ { "msg_contents": "It seems that a concurrent UPDATE can restart heap_lock_tuple() even if it's\nnot necessary. Is the attached proposal correct and worth applying?\n\n-- \nAntonin Houska\nWeb: https://www.cybertec-postgresql.com", "msg_date": "Wed, 26 May 2021 09:03:34 +0200", "msg_from": "Antonin Hous...
[ { "msg_contents": "Hi,\n\nI found a possible typo in the code comments of heap_multi_insert.\n\n- *\theap_multi_insert\t- insert multiple tuple into a heap\n+ *\theap_multi_insert\t- insert multiple tuples into a heap\n\nAttaching a patch to fix it.\n\nBest regards,\nhouzj", "msg_date": "Wed, 26 May 2021 07...
[ { "msg_contents": "The attached patch makes an optimization to pg_checksums which prevents\nrewriting the block if the checksum is already what we expect. This can\nlead to much faster runs in cases where it is already set (e.g. enabled ->\ndisabled -> enable, external helper process, interrupted runs, future\n...
[ { "msg_contents": "The attached patch stems from the conversation at [1];\nI'm starting a new thread to avoid confusing the cfbot.\n\nBriefly, the idea is to allow reverting the change made in\ncommit ab596105b to increase FirstBootstrapObjectId from\n12000 to 13000, by teaching genbki.pl to assign OIDs\nindepe...
[ { "msg_contents": "The RADIUS-related checks in parse_hba_line() did not respect elevel\nand did not fill in *err_msg. Also, verify_option_list_length()\npasted together error messages in an untranslatable way. To fix the\nlatter, remove the function and do the error checking inline. It's a\nbit more verbose...
[ { "msg_contents": "Hi,\n\nSince writing SECURITY DEFINER functions securely requires annoying\nincantations[1], wouldn't it be nice if we provided a way for the superuser\nto override the default search path via a GUC in postgresql.conf? That way\nyou can set search_path if you want to override the default, bu...
[ { "msg_contents": "Hi\n\nI think I just found a bug in logical replication. Data couldn't be synchronized while updating toast data. Could anyone take a look at it?\n\nHere is the steps to proceduce the BUG:\n------publisher------\nCREATE TABLE toasted_key (\n id serial,\n toasted_key text PRIMARY KEY,\n ...
[ { "msg_contents": "Hi all,\n\nNow that hamerkop has been fixed and that we have some coverage with\nbuilds of GSSAPI on Windows thanks to 02511066, the buildfarm has been\ncomplaining about a build failure on Windows for 12 and 13:\nhttps://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=hamerkop&dt=2021-...
[ { "msg_contents": "Hi,\n\nWhen trying to upgrade an existing database from version 10 to 13 I came\nacross a degression in some existing code used by clients. Further\ninvestigations showed that performance measures are similar in versions\n11 to 13, while in the original database on version 10 it's around 100\...
[ { "msg_contents": "[Reposted to the proper list]\n\nI started to use PostgreSQL v7.3 in 2003 on my home Linux systems (4 at \none point), gradually moving to v9.0 w/ replication in 2010.  In 2017 I \nmoved my 20GB database to AWS/RDS, gradually upgrading to v9.6, & was \nentirely satisfied with the result.\n\nI...
[ { "msg_contents": "The accounting used by ANALYZE to count dead tuples in\nacquire_sample_rows() (actually in heapam_scan_analyze_next_tuple()\nthese days) makes some dubious assumptions about how it should count\ndead tuples. This is something that I discussed with Masahiko in the\ncontext of our Postgres 14 w...
[ { "msg_contents": "Hi:\n\nI'm always confused about the following codes.\n\nstatic void\ninitscan(HeapScanDesc scan, ScanKey key, bool keep_startblock)\n{\nParallelBlockTableScanDesc bpscan = NULL;\nbool allow_strat;\nbool allow_sync;\n\n/*\n* Determine the number of blocks we have to scan.\n*\n* It is sufficie...
[ { "msg_contents": "Hi,\n\nI felt inclusion of alias types regpublication and regsubscription will\nhelp the logical replication users. This will also help in [1].\nThe alias types allow simplified lookup of publication oid values for\nobjects. For example, to examine the pg_publication_rel rows, one could\nwrit...
[ { "msg_contents": "Good day.\n\nLong time ago I've been played with proprietary \"compressed storage\"\npatch on heavily updated table, and found empty pages (ie cleaned by\nvacuum) are not compressed enough.\n\nWhen table is stress-updated, page for new row versions are allocated\nin round-robin kind, therefor...
[ { "msg_contents": "Hi,\n\nIRIX gave the world O_DIRECT, and then every Unix I've used followed\ntheir lead except Apple's, which gave the world fcntl(fd, F_NOCACHE,\n1). From what I could find in public discussion, this API difference\nmay stem from the caching policy being controlled at the per-file\n(vnode) ...
[ { "msg_contents": "While working on something in \"psql/common.c\" I noticed some triplicated \ncode, including a long translatable string. This minor patch refactors \nthis in one function.\n\n-- \nFabien.", "msg_date": "Sun, 30 May 2021 11:09:41 +0200 (CEST)", "msg_from": "Fabien COELHO <coelho@cri.en...
[ { "msg_contents": "I got interested in $SUBJECT as a result of the thread at [1].\nIt turns out that the existing implementation in inval.c is quite\ninefficient when a lot of individual commands each register just\na few invalidations --- but a few invalidations per command is\npretty typical. As an example, ...
[ { "msg_contents": "Hi,\n\nwhile looking at the other thread related to postgres_fdw batching [1]\nand testing with very large batches, I noticed this disappointing\nbehavior when inserting 1M rows (just integers, nothing fancy):\n\nno batching: 64782 ms\n100 rows: 2118 ms\n32767 rows: 41115 ms\n\nPretty ni...
[ { "msg_contents": "Our team uses postgresql as the database, but we have some problem on grant and revoke.\n\nimagine the following sequence of operations:\n\ncreateuser test;\nCREATETABLE sales (trans_id int,datedate, amount int)\nPARTITIONBYRANGE(date);\nCREATETABLE sales_1 PARTITION OF sales\n FORVALUESFR...
[ { "msg_contents": "Dear all\n\nAny idea how to disable the autovacuum during the regression and coverage\ntests for the MobilityDB extension ?\n\nI have tried\nalter system set autovacuum = off;\nbut it does not seem to work.\n\nAny suggestions are much appreciated.\n\nEsteban\n\nDear allAny idea how to disable...
[ { "msg_contents": "The comparison predicates IS [NOT] TRUE/FALSE/UNKNOWN were not\nrecognised by postgres_fdw, so they were not pushed down to the remote\nserver. The attached patch adds support for them.\n\nI am adding this to the commitfest 2021-07.", "msg_date": "Mon, 31 May 2021 11:03:05 +0300", "m...
[ { "msg_contents": "Hi.\n\nThere's issue with join pushdown after\n\ncommit 86dc90056dfdbd9d1b891718d2e5614e3e432f35\nAuthor: Tom Lane <tgl@sss.pgh.pa.us>\nDate: Wed Mar 31 11:52:34 2021 -0400\n\n Rework planning and execution of UPDATE and DELETE\n\nTo make sure that join pushdown path selected, one can p...
[ { "msg_contents": "I've been thinking about rationalizing some of the buildfarm code, which\nhas grown somewhat like Topsy over the years. One useful thing would be\nto run all the \"make\" and \"install\" pieces together. When the buildfarm\nstarted we didn't have world targets, but they are now almost ancient...
[ { "msg_contents": "I noticed that 428b260f87e8 (v12) broke the cases where a parent\nforeign table has row marks assigned. Specifically, the following\nAssert added to expand_inherited_rtentry() by that commit looks bogus\nin this regard:\n\n/* The old PlanRowMark should already have necessitated adding TID */...
[ { "msg_contents": "Hi,\nIt seems error code checking in pgtls_init() should follow the same\nconvention as PG codebase adopts - i.e. the non-zero error code should be\nreturned (instead of hard coded -1).\n\nPlease see the attached patch.\n\nThanks", "msg_date": "Tue, 1 Jun 2021 10:32:59 -0700", "msg_fr...
[ { "msg_contents": "Hi.\n\nThe documentation of ALTER SUBSCRIPTION REFRESH PUBLICATION [1] says:\n\n----------\n\nREFRESH PUBLICATION\n\nFetch missing table information from publisher. This will start\nreplication of tables that were added to the subscribed-to\npublications since the last invocation of REFRESH P...
[ { "msg_contents": "Hi,\r\n\r\nIn the latest HEAD branch, I found some places were using\r\nappendStringInfo/appendPQExpBuffer() when they could have been using\r\nappendStringInfoString/ appendPQExpBufferStr() instead. I think we'd better\r\nfix these places in case other developers will use these codes as a re...
[ { "msg_contents": "Hi all,\n\nWhile looking at a separate issue, I have noticed that TestLib.pm is\nlagging behind in terms of environment variables it had better mask to\navoid failures:\nhttps://www.postgresql.org/message-id/YLXjFOV3teAPirmS@paquier.xyz\n\nOnce I began playing with the variables not covered y...
[ { "msg_contents": "Add regression test for recovery pause.\n\nPreviously there was no regression test for recovery pause feature.\nThis commit adds the test that checks\n\n- recovery can be paused or resumed expectedly\n- pg_get_wal_replay_pause_state() reports the correct pause state\n- the paused state ends a...
[ { "msg_contents": "Hi\n\nAttached a patch to support tab completion for CREATE TYPE ... SUBSCRIPT introduced at c7aba7c14e.\n\nRegards,\nTang", "msg_date": "Wed, 2 Jun 2021 09:50:51 +0000", "msg_from": "\"tanghy.fnst@fujitsu.com\" <tanghy.fnst@fujitsu.com>", "msg_from_op": true, "msg_subject": "...
[ { "msg_contents": "Hi,\n\nWhile experimenting with parallel index builds, I've noticed a somewhat \nstrange behavior of pg_stat_progress_create_index when a btree index is \nbuilt with parallel workers - some of the phases seem to be missing.\n\nIn serial (no parallelism) mode, the progress is roughly this (it'...
[ { "msg_contents": "Working with users over the years, some have large libraries of server\nside code sometimes consisting of 100k+ lines of code over 1000+ functions\nand procedures. This usually comes from a migration of a commercial\ndatabase like Oracle where it was best practice to put all of your\nbusiness...
[ { "msg_contents": "I just had a case where a new user was slightly confused by our\ninstallation \"Short Version\" instructions. I think the confusion would\nbe lessened by adding a couple of comments, as in the attached patch.\n\n\ncheers\n\n\nandrew\n\n--\nAndrew Dunstan\nEDB: https://www.enterprisedb.com", ...
[ { "msg_contents": "Commit 19890a064 changed pg_create_logical_replication_slot() to allow\ndecoding of two-phase transactions, but did not extend the\nCREATE_REPLICATION_SLOT command to support it. Strangely, it does\nextend the CreateReplicationSlotCmd struct to add a \"two_phase\" field,\nbut doesn't set it a...
[ { "msg_contents": "Hi all,\n\nI have noticed that the documentation for PGSSLCRLDIR is missing.\nThat seems like an oversight in f5465fa.\n\nThoughts?\n--\nMichael", "msg_date": "Thu, 3 Jun 2021 12:13:22 +0900", "msg_from": "Michael Paquier <michael@paquier.xyz>", "msg_from_op": true, "msg_subje...
[ { "msg_contents": "Hi all,\n\nserinus has been complaining about the new gcd functions in 13~:\nhttps://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=serinus&dt=2021-06-03%2003%3A44%3A14\n\nThe overflow detection is going wrong the way up and down, like here:\n SELECT gcd((-9223372036854775808)::int8, (-92233...
[ { "msg_contents": "Hi,\n\nIn one of my testing scenario, i found pg_upgrade is failed for \n'plpgsql_call_handler' handler\n\nSteps to reproduce - ( on any supported version of PG)\n\nPerform initdb ( ./initdb -D  d1 ;  ./initdb -D d2)\n\nStart d1 cluster(./pg_ctl -D d1 start) , connect to postgres (./psql \npo...
[ { "msg_contents": "Hi,\n\nIt looks like for some of the fsm_set_and_search calls whose return\nvalue is ignored (in fsm_search and RecordPageWithFreeSpace), there's\nno (void). Is it intentional? In the code base, we generally have\n(void) when non-void return value of a function is ignored.\n\nThoughts?\n\nWit...
[ { "msg_contents": "I noticed earlier today when working in brin_minmax_multi.c that the\ncopyright year was incorrect. That caused me to wonder if any other\nsource files have the incorrect year.\n\ngit grep -E \"Portions Copyright \\(c\\) ([0-9]{4}-[0-9]{4}|[0-9]{4}),\nPostgreSQL Global Development Group\" | g...
[ { "msg_contents": "Hi,\n\nI was checking the GRANT on pg_subscription and noticed that the command is not\ncorrect. There is a comment that says \"All columns of pg_subscription except\nsubconninfo are readable\". However, there are columns that aren't included: oid\nand subsynccommit. It seems an oversight in ...
[ { "msg_contents": "One problem with unlogged tables is that the application has no way to\ntell if they were reset, or they just happen to be empty.\n\nThis can be a problem with sharding, where you might have different\nshards of an unlogged table on different servers. If one server\ncrashes, you'll be missing...
[ { "msg_contents": "Hi -hackers,\n\nPresented for discussion is a POC for a DELETE CASCADE functionality,\nwhich will allow you one-shot usage of treating existing NO ACTION and\nRESTRICT FK constraints as if they were originally defined as CASCADE\nconstraints. I can't tell you how many times this functionalit...
[ { "msg_contents": "Hi,\nI was looking at write_relcache_init_file() where an attempt is made to\nunlink the tempfilename.\n\nHowever, the return value is not checked.\nIf the tempfilename is not removed (the file exists), I think we should log\na warning and proceed.\n\nPlease comment on the proposed patch.\n\n...
[ { "msg_contents": "Found a few small typos in the docs as per the attached.\n\n--\nDaniel Gustafsson\t\thttps://vmware.com/", "msg_date": "Fri, 4 Jun 2021 10:17:25 +0200", "msg_from": "Daniel Gustafsson <daniel@yesql.se>", "msg_from_op": true, "msg_subject": "A few random typos in the docs" },...