threads
listlengths
1
2.99k
[ { "msg_contents": "\nI don't know if this has been discussed before, but I mentioned recently\n(<https://www.postgresql.org/message-id/e4233934-98a6-6f76-46a0-992c0f4f1208%40dunslane.net>)\nthat I think the MSVC build system is too eager about installing\nexecutables it builds. In particular, it installs these ...
[ { "msg_contents": "Consider this admittedly-rather-contrived example:\n\nregression=# create table foo(f1 int);\nCREATE TABLE\nregression=# alter table foo add column bar text default repeat('xyzzy', 1000000);\nERROR: row is too big: size 57416, maximum size 8160\n\nSince the table contains no rows at all, thi...
[ { "msg_contents": "Hi,\n\nI found that when we use pipeline mode, we can execute commands\nwhich is not allowed in a transaction block, for example\nCREATE DATABASE, in the same transaction with other commands.\n\nIn extended query protocol, a transaction starts when Parse, \nBind, Executor, or Describe message...
[ { "msg_contents": "Hi hackers,\n\nI needed an aggregate function similar to array_agg() but which\naggregates only unique values. As it turned out there is no convenient\nway of doing this. What I ended up doing instead was aggregating to\nJSONB keys and then converting a JSONB object to an array:\n\nSELECT arr...
[ { "msg_contents": "Last November Daniel Gustafsson did a patch triage. It took him three\nemails to get through the patches in the commitfest back then. Since\nthen we've had the November and the January commitfests so I was\ninterested to see how many of these patches had advanced....\n\nI'm only part way thr...
[ { "msg_contents": "The final commitfest of this release begins now.\n\nWhereas most commitfests are about getting feedback to authors so they\ncan advance the patch -- this one is about actually committing patches\nto wrap up the release.\n\nPlease when reviewing patches try to push yourself to make the\ndiffic...
[ { "msg_contents": "Hi,\n\nFollowing are the files related to PostgreSQL statistics collector,\nbackend status reporting and command progress reporting.\n\npgstat.[ch] - Definitions for the PostgreSQL statistics collector daemon.\nbackend_status.[ch] - Definitions related to backend status reporting.\nbackend_pr...
[ { "msg_contents": "> 2096: psql - add SHOW_ALL_RESULTS option\n> ========================================\n> Peter posted an updated version of Fabiens patch about a month ago (which at\n> this point no longer applies) fixing a few issues, but also point at old review\n> comments still unaddressed. Since this ...
[ { "msg_contents": "Hi.\n\nPSA a PG docs patch that is associated with the logical replication\nRow Filters feature which was recently pushed [1].\n\nThis patch introduces a new \"Filtering\" page to give a common place\nwhere all kinds of logical replication filtering can be described.\n(e.g. It is envisaged th...
[ { "msg_contents": "Hi all,\n\nIn my hunt looking for incorrect SRFs, I have noticed a new case of a\nsystem function marked as proretset while it builds and returns only\none record. And this is a popular one: pg_stop_backup(), labelled\nv2.\n\nThis leads to a lot of unnecessary work, as the function creates a...
[ { "msg_contents": "Hi,\n\nwith reference to the discussion in docs: https://www.postgresql.org/message-id/flat/2221339.1645896597%40sss.pgh.pa.us#5a346c15ec2edbe8fcc93a1ffc2a7c7d\n\nHere is a patch that changes \"Hot Standby\" to \"hot standby\" in high-availability.sgml, so we have a consistent wording.\nThoug...
[ { "msg_contents": "Hi,\n\nI have noticed that the CHECKPOINT_REQUESTED flag information is not\npresent in the log message of LogCheckpointStart() function. I would\nlike to understand if it was missed or left intentionally. The log\nmessage describes all the possible checkpoint flags except\nCHECKPOINT_REQUEST...
[ { "msg_contents": "This is not intended for PG15.\n\nAttached are a proof of concept patchset to implement multiple valid\npasswords, which have independent expirations, set by a GUC or SQL\nusing an interval.\n\nThis allows the superuser to set a password validity period of e.g.,\n60 days, and for users to cre...
[ { "msg_contents": "If you enable the CHECK_WRITE_VS_EXTEND-protected assert in mdwrite(),\nyou'll trip it anytime you exercise btbuildempty(), blbuildempty(), or\nspgbuildempty().\n\nIn this case, it may not make any meaningful difference if smgrwrite()\nor smgrextend() is called (_mdfd_getseg() behavior won't ...
[ { "msg_contents": "Hi, hackers\n\nWhen I try to change wal_level to minimal and restart the database, it complains\nmax_wal_senders > 0.\n\n2022-03-03 10:10:16.938 CST [6389] FATAL: WAL streaming (max_wal_senders > 0) requires wal_level \"replica\" or \"logical\"\n\nHowever, the documentation about wal_level [...
[ { "msg_contents": "Hi, hackers!\n\nAround 2 months ago I've noticed a problem that messages containing patches\nin the thread [1] were always processed with manual moderation. They appear\nin hackers' thread hours after posting None of them are from new CF members\nand personally, I don't see a reason for such ...
[ { "msg_contents": "Hi,\nIn test output, I saw:\n\nsrc/backend/utils/adt/tid.c:112:16: runtime error: left shift of 65535 by\n16 places cannot be represented in type 'int'\n\nI think this was due to the left shift in BlockIdGetBlockNumber not\nproperly casting its operand.\n\nPlease see the proposed change in pa...
[ { "msg_contents": "Hello.\n\nThe CF-CI complained on one of my patch for seemingly a reason\nunrelated to the patch.\n\nhttps://cirrus-ci.com/task/5544213843542016?logs=test_world#L1666\n\n> diff -U3 /tmp/cirrus-ci-build/contrib/test_decoding/expected/slot_creation_error.out /tmp/cirrus-ci-build/contrib/test_de...
[ { "msg_contents": "Hi all,\n\nWhile playing with tablespaces and recovery in a TAP test, I have\nnoticed that retrieving the location of a tablespace created with\nallow_in_place_tablespaces enabled fails in pg_tablespace_location(),\nbecause readlink() sees a directory in this case.\n\nThe use may be limited t...
[ { "msg_contents": "Hi,\n\n\nWhen we want to vacuum and/or analyze all tables in a dedicated schema, \nlet's say pg_catalog for example, there is no easy way to do that. The \nVACUUM command doesn't allow it so we have to use \\gexec or a SQL script \nto do that. We have an external command vacuumdb that could b...
[ { "msg_contents": "Hi,\n\nIt looks like regression tests are failing on Windows Server 2019 [1].\nIgnore if it's reported elsewhere.\n\n[1] https://github.com/postgres/postgres/runs/5419324953\n❌ 00:02 test_pl\n\n[08:28:53.758]\n[08:28:53.758] c:\\cirrus>call \"C:/Program\nFiles/Git/usr/bin/timeout.exe\" -v -k6...
[ { "msg_contents": "Hi,\n\nWhile using pg_rewind, I found that it is a bit difficult to use pg_rewind\nas it seems to copy even the configuration files and also remove some of\nthe files created on the old primary which may not be present on the new\nprimary. Similarly it copies files under the data directory of...
[ { "msg_contents": "Hello,\r\n\r\nTL;DR: this patch lets you specify exactly one authentication method in\r\nthe connection string, and libpq will fail the connection if the server\r\ndoesn't use that method.\r\n\r\n(This is not intended for PG15. I'm generally anxious about posting\r\nexperimental work during a...
[ { "msg_contents": "Hi,\nLooking at pg_stat_statements, there doesn't seem to be timestamp column\nfor when the underlying query is performed.\nSince the same query can be run multiple times, the absence of timestamp\ncolumn makes finding the most recent invocation of the query difficult.\n\nDoes it make sense t...
[ { "msg_contents": "PSA patch to fix a comment typo.\n\n(The 'OR' should not be uppercase - that keyword is irrelevant here).\n\n------\nKind Regards,\nPeter Smith.\nFujitsu Australia", "msg_date": "Mon, 7 Mar 2022 09:31:33 +1100", "msg_from": "Peter Smith <smithpb2250@gmail.com>", "msg_from_op": tru...
[ { "msg_contents": "Hi,\nCurrently the query id for pg_stat_statements gets calculated based on the\nparse nodes specifics.\nThis means that the user cannot add a comment to a SQL query to test\nsomething. (though some other RDBMS allows this practice).\n\nConsider this use case: for query q, admin looks at stat...
[ { "msg_contents": "Hi,\n\nI created a .patch that will allow me to recover the stat files after a\npotential crash.\nDepending on the traffic on the server some records might be lost (0.5 sec\nof records / more or less ? ).\n From what I read it is still better than no stat files at all.\n\nI restricted it to t...
[ { "msg_contents": "Hi,\nI just added some tests for the pg_freespacemap extension because the test\ncoverage was 0 percent.\nBut I don't know if I did it correctly.\n\n---\nRegards\nLee Dong Wook", "msg_date": "Tue, 8 Mar 2022 23:39:08 +0900", "msg_from": "Dong Wook Lee <sh95119@gmail.com>", "msg_fr...
[ { "msg_contents": "Hi,\n\nWhen running cpluspluscheck I get many many complaints like\n\nIn file included from /tmp/pg-test-repo/src/include/port/atomics.h:70,\n from /tmp/pg-test-repo/src/include/utils/dsa.h:17,\n from /tmp/pg-test-repo/src/include/nodes/tidbitmap.h:26,\n ...
[ { "msg_contents": "Hi,\nI was looking at commit db632fbca and noticed that,\nin create_list_bounds(), if index is added to boundinfo->interleaved_parts\nin the first if statement, there is no need to perform the second check\ninvolving call to partition_bound_accepts_nulls().\n\nHere is a short patch.\n\nCheers...
[ { "msg_contents": "Hi,\n\nOne thing I'm not yet happy around the shared memory stats patch is\nnaming. Currently a lot of comments say things like:\n\n * [...] We convert to\n * microseconds in PgStat_Counter format when transmitting to the collector.\n\nor\n\n# - Query and Index Statistics Collector -\n\nor\...
[ { "msg_contents": "Hi, hackers!\nI've noticed that check_ok() in pg_upgrade.h has been declared two times.\nHere's a one-line patch correcting this.\n\n-- \nBest regards,\nPavel Borisov\n\nPostgres Professional: http://postgrespro.com <http://www.postgrespro.com>", "msg_date": "Wed, 9 Mar 2022 14:29:09 +040...
[ { "msg_contents": "Hi Michael,\n\n>On Wed, Mar 09, 2022 at 07:45:32AM +0000, Daniel Westermann (DWE) wrote:\n>> Thanks for having a look. Done that way.\n\n>Hmm.  Outside the title that had better use upper-case characters for\n>the first letter of each word, I can see references to the pattern you\n>are trying...
[ { "msg_contents": "On 03/09/22 12:19, Stephen Frost wrote:\n> Let's avoid hijacking [thread about other patch] [1]\n> for an independent debate about what our documentation should or\n> shouldn't include.\n\nAgreed. New thread here.\n\nStephen wrote:\n> Documenting everything that pg_basebackup does to make sur...
[ { "msg_contents": "dshash: Add sequential scan support.\n\nAdd ability to scan all entries sequentially to dshash. The interface is\nsimilar but a bit different both from that of dynahash and simple dshash\nsearch functions. The most significant differences is that dshash's interfac\nalways needs a call to dsha...
[ { "msg_contents": ">Looks the same as v5 for me, that applies the same consistency rules\n>everywhere in the docs.  So applied this one.\n\nThank you, Michael\n\n\n", "msg_date": "Fri, 11 Mar 2022 06:24:15 +0000", "msg_from": "\"Daniel Westermann (DWE)\" <daniel.westermann@dbi-services.com>", "msg_f...
[ { "msg_contents": "Hi,\n\nI have observed that the table naming conventions used in\n'progress-reporting.html' are not consistent across different\nsections. For some cases \"Phases\" (Table 28.37. CREATE INDEX Phases)\nis used and for some cases \"phases\" (Table 28.35. ANALYZE phases) is\nused. I have attache...
[ { "msg_contents": "The following bug has been logged on the website:\n\nBug reference: 17434\nLogged by: Yugo Nagata\nEmail address: nagata@sraoss.co.jp\nPostgreSQL version: 14.2\nOperating system: Ubuntu\nDescription: \n\nCREATE/DROP DATABASE can be executed in the same transaction ...
[ { "msg_contents": "Hi,\n\nXlogreader limits the size of what it considers valid xlog records to\nMaxAllocSize; but this is not currently enforced in the\nXLogRecAssemble API. This means it is possible to assemble a record\nthat postgresql cannot replay.\nSimilarly; it is possible to repeatedly call XlogRegister...
[ { "msg_contents": "So, I noticed that pg_stat_reset_subscription_stats() wasn't working\nproperly, and, upon further investigation, I'm not sure the view\npg_stat_subscription_stats is being properly populated.\n\nI don't think subscriptionStatHash will be created properly and that the\nreset timestamp won't be...
[ { "msg_contents": "Hi,\nw.r.t. v5-0003-Teach-AcquireExecutorLocks-to-skip-locking-pruned.patch :\n\n(pruning steps containing expressions that can be computed before\nbefore the executor proper has started)\n\nthe word 'before' was repeated.\n\nFor ExecInitParallelPlan():\n\n+ char *execlockrelsinfo_dat...
[ { "msg_contents": "Hello PGSQL Mailing List,\nI am Arjun a 2nd year CSE Student and I am eager to contribute to this\ncommunity and was interested in the GUI System Admin Dashboard project\nmentioned here\n<https://wiki.postgresql.org/wiki/GSoC_2022#GUI_representation_of_monitoring_System_Activity_with_the_syst...
[ { "msg_contents": "Hi,\n\nI noticed that the following commands \"CREATE PUBLICATION pub1 FOR ALL\nTABLES IN SCHEMA\" and \"ALTER PUBLICATION pub1 ADD ALL TABLES IN\nSCHEMA\" does not complete with the schema list. I feel this is because\nof the following code in tab-complete.c:\n.........\nCOMPLETE_WITH_QUERY...
[ { "msg_contents": "Hello!\r\n\r\nI propose the attached patch to be applied on the 'master' branch of PostgreSQL\r\nto fix various spelling errors.\r\n\r\nMost fixes are in comments and have no effect on functionality. Some fixes are\r\nalso in variable names but they should be safe to change, as the change is\...
[ { "msg_contents": "Dear Hackers\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\nWhen I audit the Postgresql database recently, I found that after configuring the log type as csv, the output log content is as follows: \"database \"\"lp_db1\"\" does not exist\",,,,,\"DRO...
[ { "msg_contents": "Hi All,\nKindly check the below scenario with INTERVAL datatype.\n\npostgres=# select interval '01 20:59:59' + interval '00 05:00:01' as\ninterval;\n interval\n----------------\n 1 day 26:00:00\n(1 row)\n\nAny operation with INTERVAL data, We are changing the interval values as\n\"60 sec\"...
[ { "msg_contents": "Add 'basebackup_to_shell' contrib module.\n\nAs a demonstration of the sort of thing that can be done by adding a\ncustom backup target, this defines a 'shell' target which executes a\ncommand defined by the system administrator. The command is executed\nonce for each tar archive generate by ...
[ { "msg_contents": "Hello, (Cc:ed Fujii-san)\n\nThis is a diverged topic from [1], which is summarized as $SUBJECT.\n\nTo recap:\n\nWhile discussing on additional LSNs in checkpoint log message,\nFujii-san pointed out [2] that there is a case where\nCreateRestartPoint leaves unrecoverable database when concurre...
[ { "msg_contents": "Hello, this is a follow-up topic of [1] (add LSNs to checkpint logs).\n\nMany user-facing texts contains wording like \"WAL location\" or such\nlike. The attached is WIP patches that fixes such wordings to \"WAL\nLSN\" or alikes.\n\nThe attached patches is v13 but it is not changed at all fro...
[ { "msg_contents": "Hello, this is a derived topic from [1], summarized as $SUBJECT.\n\nThis just removes useless hyphens from the words\n\"(crash|emergency)-recovery\". We don't have such wordings for \"archive\nrecovery\" This patch fixes non-user-facing texts as well as\nuser-facing ones.\n\nregards.\n\n[1] h...
[ { "msg_contents": "Generally, we should define struct in the header file(.h). But I found struct \"DR_intorel\" in createas.c and it doesn't seem to be properly defined. May be it should define in createas.h.\r\nBesides, this is my first contribution.&nbsp;If there are any submitted questions, please let me kno...
[ { "msg_contents": "Hello hackers,\n\nSET ACCESS METHOD is supported in ALTER TABLE since the commit\nb0483263dd. Since that time, this also has be allowed SET ACCESS\nMETHOD in ALTER MATERIALIZED VIEW. Although it is not documented,\nthis works.\n\nI cannot found any reasons to prohibit SET ACCESS METHOD in AL...
[ { "msg_contents": "Hi, pgsql-hackers,\r\n\r\nI think I found a case that database is not recoverable, would you please give a look?\r\n\r\nHere is how it happens:\r\n\r\n- setup primary/standby\r\n- do a lots INSERT at primary\r\n- create a checkpoint at primary\r\n- wait until standby start doing restart point...
[ { "msg_contents": "Hello.\n\n003_sslinfo.pl fails for me.\n\nok 6 - ssl_client_cert_present() for connection with cert\nconnection error: 'psql: error: connection to server at \"127.0.0.1\", port 61688 failed: could not read certificate file \"/home/horiguti/.postgresql/postgresql.crt\": no start line'\nwhile r...
[ { "msg_contents": "Hi All,\nAt the beginning of LogicalIncreaseRestartDecodingForSlot(), we have codeine\n```\n1623 /* don't overwrite if have a newer restart lsn */\n1624 if (restart_lsn <= slot->data.restart_lsn)\n1625 {\n1626 }\n1627\n1628 /*\n1629 * We might have already flushed far...
[ { "msg_contents": "Good day, hackers.\n\nArchitecture Reference Manual for ARMv8 B2.2.1 [1] states:\n\n For explicit memory effects generated from an Exception level the\n following rules apply:\n - A read that is generated by a load instruction that loads a single\n general-purpose register and is aligned ...
[ { "msg_contents": "Hi hackers,\n\nI noticed there was no tab completion for time zones in psql, so here's\na patch that implements that. I chose lower-casing the names since they\nare case insensitive, and verbatim since ones without slashes can be\nentered without quotes, and (at least my version of) readline...
[ { "msg_contents": "Hello,\n\nWhile testing on the current PG master, I noticed a problem between\nbackends communicating over a shared memory queue. I think `shm_mq_sendv()`\nfails to flush the queue, even if `force_flush` is set to true, if the\nreceiver is not yet attached to the queue. This simple fix solve...
[ { "msg_contents": "Add option to use ICU as global locale provider\n\nThis adds the option to use ICU as the default locale provider for\neither the whole cluster or a database. New options for initdb,\ncreatedb, and CREATE DATABASE are used to select this.\n\nSince some (legacy) code still uses the libc local...
[ { "msg_contents": "Hi hackers,\n\nThis thread is a fork of [1], created per request by several people in\nthe discussion. It includes two patches from the patchset that we\nbelieve can be delivered in PG15. The rest of the patches are\ntargeting PG >= 16 and can be discussed further in [1].\n\nv19-0001 changes ...
[ { "msg_contents": "Hi,\n\nA customer has found a limitation, more than a bug:\n\nWhen a partitioned table has a foreign key that points to itself,\nand this FK points only to lines in the same partition\n(the partition key is part of the FK),\nyou cannot detach the partition: PostgreSQL claims that\nthe constra...
[ { "msg_contents": "So far this commitfest these 10 patches have been marked committed.\nThat leaves us with 175 \"Needs Review\" and 28 \"Ready for Comitter\" so\nquite a ways to go ...\n\n* FUNCAPI tuplestore helper function\n* parse/analyze API refactoring\n* Add wal_compression=zstd\n* Add id's to various el...
[ { "msg_contents": "Hackers,\n\nOver in [1], Joshua proposed a new set of Object Access Type hooks based on strings rather than Oids.\n\nHis patch was written to be applied atop my patch for granting privileges on gucs.\n\nOn review of his patch, I became uncomfortable with the complete lack of regression test c...
[ { "msg_contents": "Hey, hackers,\n\nAdding and removing indexes is a regular part of database maintenance,\nbut in a large database, removing an index can be a very risky operation.\nRemoving the wrong index could have disastrous consequences for\nperformance, and it could take tens of minutes, or even hours, t...
[ { "msg_contents": "Hello,\n\nI found a problem that planning takes too much time when the tables\nhave many child partitions. According to my observation, the planning\ntime increases in the order of O(n^2). Here, n is the number of child\npartitions. I attached the patch to solve this problem. Please be\nnoted...
[ { "msg_contents": "Hi, hackers!\nI've noticed that CF bot hasn't been running active branches from yesterday:\nhttps://github.com/postgresql-cfbot/postgresql/branches/active\n\nAlso, there is no new results on the current CF page on cputube.\nI don't know if it is a problem or kind of scheduled maintenance thou...
[ { "msg_contents": "Hi,\n\nI found the following lines in pg_backup_tar.c.\n\n if (len != th->fileLen)\n {\n char buf1[32],\n buf2[32];\n\n snprintf(buf1, sizeof(buf1), INT64_FORMAT, (int64) len);\n snprintf(buf2, sizeof(buf2), INT64_FORMAT, (int64) th->fileLe...
[ { "msg_contents": "Hi, hackers!\n\nI've noticed that in SRLU error reporting both signed and unsigned values\nare output as %u. I think it is worth correcting this with the very simple\npatch attached.\n\nThanks!\n\n-- \nBest regards,\nPavel Borisov\n\nPostgres Professional: http://postgrespro.com <http://www.p...
[ { "msg_contents": "Hi Pgsql-Hackers\n\nWhich hook should I use when overriding the COPY command in an extension?\n\nI am working on adding new functionalities to COPY (compression, index\nmanagement, various other transports in addition to stdin and file, other\ndata formats, etc...) and while the aim is to con...
[ { "msg_contents": "On Wed, Mar 9, 2022 at 4:46 PM Andres Freund <andres@anarazel.de> wrote:\n> On 2022-03-03 19:31:32 -0800, Peter Geoghegan wrote:\n> > Attached is a new revision of my fix. This is more or less a\n> > combination of my v4 fix from November 12 [1] and Andres'\n> > already-committed fix (commit ...
[ { "msg_contents": "Hello, hackers.\n\nWe have a production cluster with 10 hot standby servers. Each server\nhas 48 cores and 762Mbs network.\n\nWe have experienced multiple temporary downtimes caused by long\ntransactions and hint bits.\n\nFor example - we are creating a new big index. It could take even a\nda...
[ { "msg_contents": "In current EXPLAIN ANALYZE implementation, the Sort Node stats from each workers are not summarized: https://github.com/postgres/postgres/blob/d4ba8b51c76300f06cc23f4d8a41d9f7210c4866/src/backend/commands/explain.c#L2762\n\nWhen the worker number is large, it will print out huge amount of nod...
[ { "msg_contents": "Hi hackers,\n\nI learned from Tom [1] that we can simplify the code like:\n\n```\nchar buff[32];\nsnprintf(buf, sizeof(buf), INT64_FORMAT, ...)\nereport(WARNING, (errmsg(\"%s ...\", buf)));\n```\n\n... and rely on %lld/%llu now as long as we explicitly cast the\nargument to long long int / un...
[ { "msg_contents": ">\n> Hi,\n> I was looking at calls to bms_free() in PG code.\n>\n> e.g. src/backend/commands/publicationcmds.c line 362\n>\n> bms_free(bms);\n>\n> The above is just an example, there're other calls to bms_free().\n> Since the bms is allocated from some execution context, I wonder why ...
[ { "msg_contents": "Add ALTER SUBSCRIPTION ... SKIP.\n\nThis feature allows skipping the transaction on subscriber nodes.\n\nIf incoming change violates any constraint, logical replication stops\nuntil it's resolved. Currently, users need to either manually resolve the\nconflict by updating a subscriber-side dat...
[ { "msg_contents": "Hi,\n\nHere's a strange one-off failure seen on CI[1], in the\nCompilerWarnings task where we check that mingw cross-compile works:\n\n[10:48:29.045] time make -s -j${BUILD_JOBS} world-bin\n[10:48:38.705] x86_64-w64-mingw32-gcc: error: win32ver.o: No such file\nor directory\n[10:48:38.705] ma...
[ { "msg_contents": "Hi,\n\nThis feature adds an option to skip changes of all tables in specified\nschema while creating publication.\nThis feature is helpful for use cases where the user wants to\nsubscribe to all the changes except for the changes present in a few\nschemas.\nEx:\nCREATE PUBLICATION pub1 FOR AL...
[ { "msg_contents": "Hi,\n\nWhen LockAcquireExtended(dontWait=false) acquires a lock where we already hold\nstronger lock and somebody else is also waiting for that lock, it goes through\na fairly circuitous path to acquire the lock:\n\nA conflicting lock is detected: if (lockMethodTable->conflictTab[lockmode] & ...
[ { "msg_contents": "Hi,\n\nI was about to propose adding headerscheck / cpluspluscheck to the CI file so\nthat cfbot can catch future issues. Unfortunately running cpluspluscheck with\nICU enabled is, um, not fun: There's 30k lines of error output.\n\n/home/andres/src/postgresql/src/tools/pginclude/cpluspluschec...
[ { "msg_contents": "Hi,\n\nIt's possible to have a good number of standbys (in the context of async\nstreaming replication) as part of the client architecture. Rather than\nasking the client to look into the intricacies of comparing the LSN of each\nstandby with that of primary and performing the pg_rewind, isn'...
[ { "msg_contents": "Hi All,\nWe have (StringInfo::len == 0) checks at many places. I thought it\nwould be better to wrap that into a function isEmptyStringInfo() to\nmake those checks more readable and also abstract the logic to check\nemptiness of a StringInfo. I think this will be useful to extensions\noutside...
[ { "msg_contents": "Over at [1] Mark Dilger got led astray because he used\nsrc/test/modules/test_rls_hooks as a template for his new test module.\nIt looks like that module was created with some over eager copying of\nanother test module, but it has a couple of things wrong with it.\n\n. it isn't an extension, ...
[ { "msg_contents": "Unbreak the build.\n\nCommit ffd53659c46a54a6978bcb8c4424c1e157a2c0f1 broke the build for\nanyone not compiling with LZ4 and ZSTD enabled. Woops.\n\nBranch\n------\nmaster\n\nDetails\n-------\nhttps://git.postgresql.org/pg/commitdiff/607e75e8f0f84544feb879b747da1d40fed71499\n\nModified Files\...
[ { "msg_contents": "Hi,\n\nIt looks like the following errmsg_plural in dependency.c is\nunnecessary as numReportedClient > 1 always and numNotReportedClient\ncan never be < 0. Therefore plural version of the error message is\nsufficient. Attached a patch to fix it.\n\n@@ -1200,10 +1200,8 @@ reportDependentObjec...
[ { "msg_contents": "Hi,\n\nI tried to run postgres with ubsan to debug something. I ran into two main\nissues:\n\n\n1) Despite Tom's recent efforts in [1], I see two ubsan failures in\n HEAD.\n\n These are easy enough to fix as per the attached, although the fix for the\n GetConfigOptionByNum() isn't great...
[ { "msg_contents": "Hi,\n\nStarting with the below commit, pg_stat_reset_single_function_counters,\npg_stat_reset_single_table_counters don't just reset the stats for the\nindividual function, but also set pg_stat_database.stats_reset.\n\ncommit 4c468b37a281941afd3bf61c782b20def8c17047\nAuthor: Magnus Hagander <...
[ { "msg_contents": "Hi,\n\nThe comment for pgwin32_is_junction() says \"Assumes the file exists,\nso will return false if it doesn't (since a nonexistent file is not a\njunction)\". In fact that's the behaviour for any kind of error, and\nalthough we set errno in that case, no caller ever checks it.\n\nI think ...
[ { "msg_contents": "This patch should silence some recent Coverity (false positive)\ncomplaints about assertions contained in these macros.\n\nPortability testing at:\nhttps://cirrus-ci.com/github/alvherre/postgres/macros-to-inlinefuncs\n\nIntend to push later today, unless something ugly happens.\n\n-- \nÁlvaro...
[ { "msg_contents": "Hi Hackers,\n\nI just spotted an unnecessarily gendered example involving a 'salesmen'\ntable in the UPDATE docs. Here's a patch that changes that to\n'salespeople'.\n\n- ilmari", "msg_date": "Thu, 24 Mar 2022 18:34:55 +0000", "msg_from": "=?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <il...
[ { "msg_contents": "Fix possible recovery trouble if TRUNCATE overlaps a checkpoint.\n\nIf TRUNCATE causes some buffers to be invalidated and thus the\ncheckpoint does not flush them, TRUNCATE must also ensure that the\ncorresponding files are truncated on disk. Otherwise, a replay\nfrom the checkpoint might fin...
[ { "msg_contents": "As I was tracking down some of these errors in the sql/json patches I\nnoticed that we have a whole lot of them in the code, so working out\nwhich one has triggered an error is not as easy as it might be. ISTM we\ncould usefully prefix each such message with the name of the function in\nwhich...
[ { "msg_contents": "Hi,\n\nI noticed a possible typo in standby.c:\n\n---\n * The definitions of RunningTransactionsData and xl_xact_running_xacts are\n * similar. We keep them separate because xl_xact_running_xacts is a\n---\n\nIt seems \"xl_xact_running_xacts\" should be \"xl_running_xacts\".\n\nBest regards,\...
[ { "msg_contents": "Hi,\n\nCurrently postgres runs end-of-recovery(EOR) checkpoint in wait mode\nmeaning the server can take longer before it opens up for connections.\nThe EOR checkpoint, at times, can take a while if there was a lot of\nwork the server has done during crash recovery, say it replayed many\nWAL ...
[ { "msg_contents": "The following bug has been logged on the website:\n\nBug reference: 17448\nLogged by: Okano Naoki\nEmail address: okano.naoki@jp.fujitsu.com\nPostgreSQL version: 14.2\nOperating system: Windows\nDescription: \n\nWith huge_pages = on, the postgres process does not a...
[ { "msg_contents": "\nHi, hackers\n\nWhen I try to get total size of partition tables though partitioned table\nname using pg_relation_size(), it always returns zero. I can use the\nfollowing SQL to get total size of partition tables, however, it is a bit\ncomplex.\n\n SELECT\n pg_size_pretty(sum(pg_r...
[ { "msg_contents": "Hi,\n\nThe function GetWalRcvWriteRecPtr isn't being used anywhere, however\npg_atomic_read_u64(&walrcv->writtenUpto); (reading writtenUpto without\nspinlock) is being used directly in pg_stat_get_wal_receiver\nwalreceiver.c. We either make use of the function instead of\npg_atomic_read_u64(&...
[ { "msg_contents": "Hi,\r\n\r\nWe are pleased to announce the Release Management Team (RMT) (cc'd) for \r\nthe PostgreSQL 15 release:\r\n\r\n - John Naylor\r\n - Jonathan Katz\r\n - Michael Paquier\r\n\r\nYou can find information about the responsibilities of the RMT here:\r\n\r\n https://wiki.postgresql...
[ { "msg_contents": "Hi,\n\nWhile reading code around I just noticed that I failed to adapt a comment a\ncouple of lines above a removed line in 0f61727b75b9. Patch attached.", "msg_date": "Sun, 27 Mar 2022 00:01:17 +0800", "msg_from": "Julien Rouhaud <rjuju123@gmail.com>", "msg_from_op": true, "...
[ { "msg_contents": "Several of Andres' buildfarm animals have recently started to whine\nthat \"performing pointer subtraction with a null pointer has undefined\nbehavior\" for assorted places in freepage.c.\n\n From a mathematical standpoint, this astonishes me: \"x - 0 = x\" is a\ntautology. So I'm a bit incl...
[ { "msg_contents": "I chanced to notice that buildfarm member lorikeet has been\nfailing an awful lot lately in the v14 branch, but hardly\nat all in other branches. Here's a log extract from its\nlatest run [1]:\n\n2022-03-26 06:31:47.245 EDT [623eeb93.d202:131] pg_regress/inherit LOG: statement: create table...