threads listlengths 1 2.99k |
|---|
[
{
"msg_contents": "Hi,\nI was looking at ExplainOneQuery() where ExplainOneQuery_hook is called.\n\nCurrently the call to the hook is in if block and normal processing is in\nelse block.\n\nWhat if the hook doesn't want to duplicate the whole code printing\nexecution plan ?\n\nPlease advise.\n\nThanks\n\nHi,I w... |
[
{
"msg_contents": "Hi hackers,\n\nThe bounded heap sorting status flag is set twice in sort_bounded_heap()\nand tuplesort_performsort(). This patch helps remove one of them.\n\nBest Regards,\nXing",
"msg_date": "Wed, 27 Jul 2022 17:09:54 +0800",
"msg_from": "Xing Guo <higuoxing@gmail.com>",
"msg_fro... |
[
{
"msg_contents": "Hi hackers,\n\nWe came across a slowdown in planning, where queries use tables with many\nindexes. In setups with wide tables it is not uncommon to have easily\n10-100 indexes on a single table. The slowdown is already visible in serial\nworkloads with just a handful of indexes, but gets dras... |
[
{
"msg_contents": "Hi hackers,\n\nWe came across a slowdown in planning, where queries use tables with many\nindexes. In setups with wide tables it is not uncommon to have easily\n10-100 indexes on a single table. The slowdown is already visible in serial\nworkloads with just a handful of indexes, but gets dras... |
[
{
"msg_contents": "Hi,\n\n089480c077056 seems to have broken pg_prewarm. When pg_prewarm\nis added to shared_preload_libraries, each new connection results in\nthousands of errors such as this:\n\n\n2022-07-27 04:25:14.325 UTC [2903955] LOG: background worker\n\"autoprewarm leader\" (PID 2904146) exited with ex... |
[
{
"msg_contents": "Howdy folks,\n\nThe attached patch tweaks the wording around finding the psqlrc file\non windows, with the primary goal of removing the generally incorrect\nstatement that windows has no concept of a home directory.\n\nRobert Treat\nhttps://xzilla.net",
"msg_date": "Wed, 27 Jul 2022 14:42... |
[
{
"msg_contents": "Hey,\n\nJust interacted with a frustrated user on Slack trying to upgrade from v13\nto v14 on Windows. Our official download page for the Windows installer\nclaims the core documentation as its official reference - can someone\nresponsible for this area please suggest and test some changes t... |
[
{
"msg_contents": "Greetings,\n\n\nWhen we take backups from a synchronous standby replica, how can we get the accurate timestamp of the backup end time ? (As backup history files are not generated on standbys)\nFor example:\nthis is a part of control file after a backup (created using wal-g by calling pg_start... |
[
{
"msg_contents": "Hello,\n\nIs there any way to get the timestamp of the transaction using LSN value ?\n\nFor example: \ncan we use the minimum recovery ending location in pg control file to get the minimum recovery timestamp ?\n\nMinimum recovery ending location: 28/28000B68\n\n\nThanks in advance,\n\nBes... |
[
{
"msg_contents": "Hi hackers,\n\nI found that when wal_consistency_checking = brin is set, it may cause redo\nabort, all the standby-nodes lost, and the primary node can not be restart.\n\nThis bug exists in all versions of PostgreSQL.\n\nThe operation steps are as follows:\n\n 1. Create a primary instance,... |
[
{
"msg_contents": "Hi,\n\nFreebsd 13.0, so far used by CI, is out of support. I've changed the\nimage to be built against 13.1, so we can switch to that.\n\nI suspect it'd be better to remove the minor version numbers from the\nimage name, so that switches from 13.0 -> 13.1 don't require CI\nchanges. Any argume... |
[
{
"msg_contents": "Starting new thread with updated patch to avoid confusion, as\nmentioned by David Steele on the original thread:\nOriginal messageid: 20201118020418.GA13408@alvherre.pgsql\nOn Wed, 18 Nov 2020 at 02:04, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:\n> On 2020-Nov-17, Simon Riggs wrote:\n>\n... |
[
{
"msg_contents": "In commits 7c34555f8/e1bd4990b, I added a new role used by a TAP\nscript but neglected the auth_extra incantation needed to allow\nlogin as that role. This should have resulted in SSPI auth\nfailures on certain Windows configurations, and indeed it did\non drongo's next run in the v15 branch... |
[
{
"msg_contents": "Hi,\n\nNext up is the large list of Needs Review. This part 1 should include\nentries as old or older than seven commitfests running.\n\nMy heuristics for classifying these continue to evolve as I go, and\nthere's a lot to read, so please let me know if I've made any mistakes.\n\n= Stalled Pa... |
[
{
"msg_contents": "During a recent review, I happened to notice that in the file\nsrc/backend/catalog/pg_publication.c the two functions\n'is_publishable_class' and 'is_publishable_relation' used to be [1]\nadjacent in the source code. This is also evident in\n'is_publishable_relation' because the wording of th... |
[
{
"msg_contents": "Hello,\n\nPart 2 should include entries four commitfests and older. (For the rest,\nit's probably too early to call something \"stalled\", so I don't plan to\ndo any more triage there.) Patch authors CC'd.\n\n= Stalled Patches, Recommend Return =\n\nI plan to return these with a note saying \... |
[
{
"msg_contents": "Hi,\n\nStatistics collector has been removed since 5891c7a8ed8f2d3d5, but there \nwas a comment referring 'statistics collector' in pg_statistic.h.\n\n> Note that since the arrays are variable-size, K may be chosen by the \n> statistics collector.\n\nShould it be modified to 'cumulative stat... |
[
{
"msg_contents": "Hi,\n\nBoth aset.c and generation.c populate mem_allocated in\nAllocSetContextCreateInternal(), GenerationContextCreate()\nrespectively.\naset.c \n /* Finally, do the type-independent part of context creation */ \n MemoryC... |
[
{
"msg_contents": "I've been annoyed several times lately by having to update\nthe list of node types embodied in test_oat_hooks.c's\nnodetag_to_string(). I got around to looking at that more\nclosely, and realized that it is only used for utility\nstatements, which (a) are a very small subset of the node\ntyp... |
[
{
"msg_contents": "Having spent much of the day looking at regression tests for\ndifferent bits of contrib, I was inspired to do a quick\nfinger exercise to add a test for contrib/tcn. When that\nmodule was written, we didn't have a nice way to create a\ntest case with stable output. But now, the isolationtes... |
[
{
"msg_contents": "Since 3a769d823 (pg_upgrade: Allow use of file cloning)\nfile.c has had:\n\n- if (ioctl(dest_fd, FICLONE, src_fd) < 0)\n- {\n- unlink(dst);\n- pg_fatal(\"error while cloning relation \\\"%s.%s\\\" (\\\"%s\\\" to \\\"%s\\\"): %s\",\n- ... |
[
{
"msg_contents": "Twice recently (b998196bb5 and 19408aae7f) I have had to adjust new TAP\ntests to handle log_error_verbosity=verbose, and there's a third case\nneeding adjustment in the new auto_explain tests (7c34555f8c). I'm\nwondering if it would be better to set log_error_verbosity to default\nfor TAP te... |
[
{
"msg_contents": "Dear pgsql hackers,\n\nI am Gianluca Calcagni, a Salesforce Certified Technical Architect. In the course of my career, I accumulated extensive experience working with triggers, both as an architect and as a developer.\n\nWhen I work with multiple developer teams, they often need to create tri... |
[
{
"msg_contents": "Hello!\n\nIn previous discussion\n(https://www.postgresql.org/message-id/flat/6b05291c-f252-4fae-317d-b50dba69c311%40inbox.ru)\n\nOn 05.07.2022 22:08, Justin Pryzby wrote:\n> I'm not\n> sure if anyone is interested in patching test.sh in backbranches. I'm not\n> sure, but there may be more i... |
[
{
"msg_contents": "The following documentation comment has been logged on the website:\n\nPage: https://www.postgresql.org/docs/14/plpgsql-errors-and-messages.html\nDescription:\n\nTowards the end of the \"43.9.1. Reporting Errors and Messages\" section (here\nhttps://www.postgresql.org/docs/current/plpgsql-err... |
[
{
"msg_contents": "\nHi, hackers\n\nI think there is a typo in pg_db_role_setting.h, should we fix it?\n\ndiff --git a/src/include/catalog/pg_db_role_setting.h b/src/include/catalog/pg_db_role_setting.h\nindex 45d478e9e7..f92e867df4 100644\n--- a/src/include/catalog/pg_db_role_setting.h\n+++ b/src/include/catal... |
[
{
"msg_contents": "\nHi, hackers\n\nWhen I try to modify the parameters for all users in the following command [1]\n(the library doesn't exist), and I quit the connection, I cannot log in the\ndatabase, how can I bypass this checking?\n\nI find those parameters loaded by process_settings(), and it seems no way ... |
[
{
"msg_contents": "Hi,\n\nThe previous discussion is:\n\nhttps://www.postgresql.org/message-id/CACJufxEnVqzOFtqhexF2%2BAwOKFrV8zHOY3y%3Dp%2BgPK6eB14pn_w%40mail.gmail.com\n\n\nWe have FORCE_NULL/FORCE_NOT_NULL options when COPY FROM, but users must set the columns one by one.\n\n CREATE TABLE forcetest (\n a I... |
[
{
"msg_contents": "Hi all,\n\nI've just closed out the July commitfest. I'll be working to clear out\nall remaining active patches today.\n\nFinal statistics:\n\n Needs review: 142\n Waiting on Author: 44\n Ready for Committer: 19\n Committed: 76\n Moved to next CF: ... |
[
{
"msg_contents": "\"A mathematical catastrophe is a point in a model of an input-output\nsystem, where a vanishingly small change in the input can produce a\nlarge change in the output.\"\n\nWe have just such a change in Postgres: when a snapshot overflows. In\nthis case it takes only one subxid over the subxi... |
[
{
"msg_contents": "Recent typos...",
"msg_date": "Mon, 1 Aug 2022 20:04:54 +0200",
"msg_from": "Erik Rijkers <er@xs4all.nl>",
"msg_from_op": true,
"msg_subject": "fix typos"
},
{
"msg_contents": "On Mon, Aug 01, 2022 at 08:04:54PM +0200, Erik Rijkers wrote:\n> Recent typos...\n\nLGTM, th... |
[
{
"msg_contents": "This patch tweaks a some tabbing and replaces some spaces with tabs to\nimprove slightly the comment alignment in file\n'postgresql.conf.sample'\n\nPSA.\n\n------\nKind Regards,\nPeter Smith.\nFujitsu Australia",
"msg_date": "Tue, 2 Aug 2022 09:24:02 +1000",
"msg_from": "Peter Smith <... |
[
{
"msg_contents": "Hi Hackers.\n\nI noticed that there are quite a few items in Chapter 28.2 \"The\nCumulative Statistics System\" [1] which have no obvious order.\n\ne.g.\n\n- The views (28.2.3 -> 28.2.23) don't seem to be in any order that I\ncould work out. Why not alphabetical?\n\n- [2] Table 2.1 \"Dynamic ... |
[
{
"msg_contents": "Hi, hackers\nI added some SQL statements to improve test coverage.\nAs data was inserted, the expected file changed.\nSo should I change all `select *` for a stable expected result?\n\nAnd it's the coverage change as I add\n50.6% -> 78.7%\n---\nregards,\nLee Dong Wook",
"msg_date": "Tue, ... |
[
{
"msg_contents": "Hi,\n\nFor long strings, iterate_word_similarity() can run into long-running\ntight-loops without honouring interrupts or statement_timeouts. For\nexample:\n\npostgres=# set statement_timeout='1s';\nSET\npostgres=# select 1 where repeat('1.1',80000) %>> 'Lorem ipsum dolor sit amet';\n?column?... |
[
{
"msg_contents": "I noticed that COPY TO accepts FREEZE option but it is pointless.\n\nDon't we reject that option as the first-attached does? I tempted to\nadd tests for those option combinations that are to be rejected but I\ndidin't come up with a clean way to do that.\n\n\nBy the way, most of the invalid ... |
[
{
"msg_contents": "Hi,\n\nereport_startup_progress infrastructure added by commit 9ce346e [1]\nwill be super-useful for reporting progress of any long-running server\noperations, not just the startup process operations. For instance,\npostmaster can use it for reporting progress of temp file and temp\nrelation ... |
[
{
"msg_contents": "While doing the search in [1], I spotted several places where the\ncomments for the function prototypes are obsoleted. For instance,\nbtree_desc() and btree_identify() are now located in nbtdesc.c but the\ncomment in nbtxlog.h is still claiming they are in nbtxlog.c.\n\nFix these places with ... |
[
{
"msg_contents": "Recently there have been several threads where the problem at hand lends\nitself to using SSE2 SIMD intrinsics. These are convenient because on\n64-bit x86 the instructions are always present and so don't need a runtime\ncheck. To integrate them into our code base, we will need to take some\n... |
[
{
"msg_contents": "abstract the logic of `scankey change attribute num to index col\nnumber` to change_sk_attno_to_index_column_num, which is a static\ninline function.\n\n-- \nRegards\nJunwang Zhao",
"msg_date": "Tue, 2 Aug 2022 19:27:30 +0800",
"msg_from": "Junwang Zhao <zhjwpku@gmail.com>",
"msg_... |
[
{
"msg_contents": "Over on [1] I was complaining that I thought DEFAULT_FDW_TUPLE_COST,\nwhich is defined as 0.01 was unrealistically low.\n\nFor comparison, cpu_tuple_cost, something we probably expect to be in\na CPU cache is also 0.01. We've defined DEFAULT_PARALLEL_TUPLE_COST\nto be 0.1, which is 10x cpu_t... |
[
{
"msg_contents": "I've complained before that the snapshot_too_old TAP tests seem\nridiculously slow --- close to a minute of runtime even on very fast\nmachines. Today I happened to look closer and realized that there's\nan absolutely trivial way to cut that. The core of the slow runtime\nis that there's a ... |
[
{
"msg_contents": "[Trying -hackers rather than -www this time, since the impacted users are here.]\n\nThere are occasionally patches that are dutifully rebased by a\nresponsive author, all feedback implemented... but there have been no\nreviews for a while, and there's no sign of any on the way. This case\nsee... |
[
{
"msg_contents": "The effective_multixact_freeze_max_age mechanism added by commit\n53bb309d2d forces aggressive VACUUMs to take place earlier, as\nprotection against wraparound of the MultiXact member space SLRU.\nThere was also a follow-up bugfix several years later -- commit\n6bda2af039 -- which made sure t... |
[
{
"msg_contents": "Hi, I hope supported Unicode Variation Selector on collate.\n\nD209007=# create table ivstesticu (\nD209007(# moji text\nD209007(# );\nD209007=# create table ivstest (\nD209007(# moji text collate \"ja-x-icu\" CONSTRAINT firstkey PRIMARY KEY D209007(# ); \nD209007=# insert into ivstest (moji... |
[
{
"msg_contents": "Hi.\n\nSuppose on master, I run a *multi-query* using PQexec and save the value\nreturned by pg_current_wal_insert_lsn:\n\nmaster_lsn = query(master, \"INSERT INTO some VALUES (...); SELECT\npg_current_wal_insert_lsn()\")\n\nThen I run a PQexec query on a replica and save the value returned b... |
[
{
"msg_contents": "Hello,\n\nFollowing the bug report at [1], I sent the attached patch to pgsql-bugs \nmailing list. I'm starting a thread here to add it to the next commitfest.\n\nThe problem I'm trying to solve is that, contrary to btree, gist and sp-gist \nindexes, gin indexes do not charge any cpu-cost for... |
[
{
"msg_contents": "I think in the following sentence, were should be replaced with have,\nwhat do you think?\n\n```\n /*\n- * We were just issued a SAVEPOINT inside a\ntransaction block.\n+ * We have just issued a SAVEPOINT inside a\ntransacti... |
[
{
"msg_contents": "HI All,\n\nFollowing comment in RemoveNonParentXlogFiles() says that we are trying to\nremove any WAL file whose segment number is >= the segment number of the\nfirst WAL file on the new timeline. However, looking at the code, I can say\nthat we are trying to remove the WAL files from the pre... |
[
{
"msg_contents": "Hi,\n\nIt appears that config.sgml and pg_settings have not been updated, even \nthough a new subcategory was added in 249d649. a55a984 may have been \nmissed in the cleaning.\n--\nCategory is 'CONNECTIONS AND AUTHENTICATION' and subcategory is \n'Connection Settings' at config.sgml.\nCategor... |
[
{
"msg_contents": "Hi,\n\nA DSS developer from my company, Julien Roze, reported me an error I cannot explained. Is it a new behavior or a bug ?\n\nOriginal query is much more complicated but here is a simplified test case with postgresql 14 and 15 beta 2 on Debian 11, packages from pgdg :\n\nVer Cluster Port S... |
[
{
"msg_contents": "Hi,\n\nI noticed that dir_open_for_write() in walmethods.c uses write() for\nWAL file initialization (note that this code is used by pg_receivewal\nand pg_basebackup) as opposed to core using pg_pwritev_with_retry() in\nXLogFileInitInternal() to avoid partial writes. Do we need to fix\nthis?\... |
[
{
"msg_contents": "Hey all !\n\nI'm on a quest to help the planner (on pg14) use the best of several\npartial, expressional indices we have on some large tables (few TBs in\nsize, billions of records).\n\nAs we know, stats for expressions in partial indices aren't gathered by\ndefault - so I'm tinkering with ex... |
[
{
"msg_contents": "BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking\n\nThat bit is unlogged and therefore it's wrong to consider it in WAL page\ncomparison.\n\nAdd a test that tickles the case, as branch testing technology allows.\n\nThis has been a problem ever since wal consistency checking was\nint... |
[
{
"msg_contents": "... at\n\nhttps://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=aab05919a685449826db986a921c1d8632d673e0\n\nPlease send corrections and comments by Sunday.\n\n\t\t\tregards, tom lane\n\n\n",
"msg_date": "Fri, 05 Aug 2022 17:40:44 -0400",
"msg_from": "Tom Lane <tgl@sss.pgh... |
[
{
"msg_contents": "My bugfix commit 74388a1a (which was pushed back in February) added\nheuristics to VACUUM's reltuples calculation/estimate. This prevented\nVACUUM from distorting our estimate of reltuples over time, across\nsuccessive VACUUM operations run against the same table. The problem\nwas that VACUUM... |
[
{
"msg_contents": "Hi,\n\nEnum COPY_NEW_FE is removed in commit 3174d69fb9.\n\nShould use COPY_FRONTEND instead.\n\nIssue exists on 15 and master.\n\n```\ntypedef struct CopyFromStateData\n\n- StringInfo fe_msgbuf; /* used if copy_src == COPY_NEW_FE */\n+ StringInfo fe_msgbuf; /* used if copy_src == COPY_FRONTE... |
[
{
"msg_contents": "Hi,\n\nAbout the error:\nResult of 'malloc' is converted to a pointer of type 'char', which is\nincompatible with sizeof operand type 'struct guts'\n\nThe patch attached tries to fix this.\n\nregards,\nRanier Vilela",
"msg_date": "Sat, 6 Aug 2022 09:12:53 -0300",
"msg_from": "Ranier V... |
[
{
"msg_contents": "Hello,\n\nPostgres seems to always optimize ORDER BY + LIMIT as top-k sort.\nRecently I happened to notice\nthat in this scenario the output tuple number of the sort node is not\nthe same as the LIMIT tuple number.\n\nSee below,\n\npostgres=# explain analyze verbose select * from t1 order by ... |
[
{
"msg_contents": "Buildfarm animal conchuela recently started spitting a lot of warnings\nlike this one:\n\n conchuela | 2022-08-06 12:35:46 | /home/pgbf/buildroot/HEAD/pgsql.build/../pgsql/src/include/port.h:208:70: warning: 'format' attribute argument not supported: gnu_printf [-Wignored-attributes]\n\nI... |
[
{
"msg_contents": "It's quite possible (and probably very common) for certain tables to\nhave autovacuum scheduling trigger autovacuums based on both the\n\"regular\" bloat-orientated thresholds, and the newer insert-based\nthresholds. It may be far from obvious which triggering condition\nautovacuum.c must hav... |
[
{
"msg_contents": "Hi,\n\nI tried PG on the gcc compile farm solaris 11.31 host. When compiling with sun\nstudio I can build the backend etc, but preproc.c fails to compile:\n\nccache /opt/developerstudio12.6/bin/cc -m64 -Xa -g -v -O0 -D_POSIX_PTHREAD_SEMANTICS -mt -D_REENTRANT -D_THREAD_SAFE -I../include -I../... |
[
{
"msg_contents": "I have to fix log files because its content is not properly formatted, I´m\nusing version 14.4 but that happened when I was using version 11 too. It\nhappens only when that statement is huge, or because it is a long sequence\nof updates in a WITH or DO statements, or because i´m updating a by... |
[
{
"msg_contents": "Hi hackers,\nI wrote a test of the old_snapshot extension for coverage.\nI hope that this is written correctly.\n\nbefore:\n 0%\nafter:\n 100%\n---\nregards,\nLee Dong Wook.",
"msg_date": "Mon, 8 Aug 2022 12:54:36 +0900",
"msg_from": "Dong Wook Lee <sh95119@gmail.com>",
"msg_fro... |
[
{
"msg_contents": "Dear hackers,\n\nI'm Yedil. I'm working on the project \"Postgres Performance Farm\" during\nGsoc. Pgperffarm is a project like Postgres build farm but focuses on the\nperformance of the database. Now it has 2 types of benchmarks, pgbench and\ntpc-h. The website is online here <http://140.211... |
[
{
"msg_contents": "On Thu, 4 Aug 2022 at 13:11, Simon Riggs <simon.riggs@enterprisedb.com> wrote:\n>\n> On Wed, 3 Aug 2022 at 20:18, Andres Freund <andres@anarazel.de> wrote:\n>\n> > I think we should consider redesigning subtrans more substantially - even with\n> > the changes you propose here, there's still p... |
[
{
"msg_contents": "While working on pg_stat_stements, I got some questions from customers to\nhave statistics by application and IP address. I know that we are\ncollecting the\nstatistics by query id, user id, database id and top-level query. There is\nno way to\ncollect the statistics based on IP address and a... |
[
{
"msg_contents": "Hi,\r\n\r\nPlease see attached draft of the 2022-08-11 release announcement.\r\n\r\nPlease provide feedback on {technical accuracy, omissions, any other \r\nerrors} no later than 2022-08-11 0:00 AoE[1].\r\n\r\nThanks,\r\n\r\nJonathan\r\n\r\n[1] https://en.wikipedia.org/wiki/Anywhere_on_Earth"... |
[
{
"msg_contents": "I'm trying to wrap my head around the shared memory stats collector\ninfrastructure from\n<20220406030008.2qxipjxo776dwnqs@alap3.anarazel.de> committed in\n5891c7a8ed8f2d3d577e7eea34dacff12d7b6bbd.\n\nI have one question about locking -- afaics there's nothing protecting\nreading the shared m... |
[
{
"msg_contents": "I couldn't find a clear document which showed how this was done.\nThe example would help.\n\n\nDave Cramer",
"msg_date": "Mon, 8 Aug 2022 13:49:55 -0400",
"msg_from": "Dave Cramer <davecramer@gmail.com>",
"msg_from_op": true,
"msg_subject": "Patch to provide example for ssl ce... |
[
{
"msg_contents": "I'm building a Postgres index access method. For a variety of reasons it's\nmore efficient to store the index data in multiple physical files on disk\nrather in the index's main fork.\n\nI'm trying to create separate rels that can be created and destroyed by the\nparent index access method. I... |
[
{
"msg_contents": "(resending because I sent the original from the wrong email address...)\n\nI'm building a Postgres index access method. For a variety of reasons it's\nmore efficient to store the index data in multiple physical files on disk\nrather than in the index's main fork.\n\nI'm trying to create separ... |
[
{
"msg_contents": "Hello,\n\nLogical replication of DDL commands support is being worked on in [1].\nHowever, global object commands are quite different from other\nnon-global object DDL commands and need to be handled differently. For\nexample, global object commands include ROLE statements, DATABASE\nstatemen... |
[
{
"msg_contents": "Hi,\nI was looking at ExecSort() w.r.t. datum sort.\n\nI wonder if the datumSort field can be dropped.\nHere is a patch illustrating the potential simplification.\n\nPlease take a look.\n\nThanks",
"msg_date": "Mon, 8 Aug 2022 14:57:59 -0700",
"msg_from": "Zhihong Yu <zyu@yugabyte.com... |
[
{
"msg_contents": "Hi,\n\nI found that there are two .c and .h files whose identification in the\nheader comment doesn't match its actual path.\n\nsrc/include/common/compression.h has:\n\n * IDENTIFICATION\n * src/common/compression.h\n *----------------------------------------------------------------... |
[
{
"msg_contents": "Hi,\n\nAttached a patch to fix as well. If the patch looks good to you, can you\nconsider getting this to PG 15?\n\nSteps to repro:\n-- some basic examples from src/test/regress/sql/create_am.sql\nCREATE TABLE heaptable USING heap AS\nSELECT a, repeat(a::text, 100) FROM generate_series(1,9) A... |
[
{
"msg_contents": "The comments considering checking share/ directory was there for\nalmost 13 years, yet nobody ever trying to add the checking, and\nthere seems never any trouble for not checking it, then I think\nwe should remove those comments.\n\ndiff --git a/src/backend/postmaster/postmaster.c\nb/src/back... |
[
{
"msg_contents": "Hi,\n\nI was thinking that it might make sense, to reduce clutter, to move\n*backup*.c from src/backend/replication to a new directory, perhaps\nsrc/backend/replication/backup or src/backend/backup.\n\nThere's no particular reason we *have* to do this, but there are 21 C\nfiles in that direct... |
[
{
"msg_contents": "Hi,\r\n\r\n(Personal hat, not RMT hat unless otherwise noted).\r\n\r\nThis thread[1] raised some concerns around the implementation of the \r\nSQL/JSON features that are slated for v15, which includes an outstanding \r\nopen item[2]. Given the current state of the discussion, when the RMT \r\... |
[
{
"msg_contents": "Hi hackers,\n\nWhilst debugging an issue with the output of pg_get_constraintdef, we've\ndiscovered that pg_get_constraintdef doesn't schema qualify foreign tables\nmentioned in the REFERENCES clause, even if pretty printing\n(PRETTYFLAG_SCHEMA) is turned off.\n\nThis is a problem because it ... |
[
{
"msg_contents": "Hi,\n\nOne CI run for the meson branch just failed in a way I hadn't seen before on\nwindows, when nothing had changed on windows\n\nhttps://cirrus-ci.com/task/6111743586861056\n\n027_stream_regress.pl ended up failing due to a timeout. Which in turn was\ncaused by the standby crashing.\n\n20... |
[
{
"msg_contents": "The separate TRIGGER privilege is considered obsolescent. It is not\nheavily used and exists mainly to facilitate trigger-based replication\nin a multi-user system.\ni.e.\nGRANT TRIGGER ON foo TO bob;\n\nSince logical replication recommends \"Limit ownership and TRIGGER\nprivilege on such tab... |
[
{
"msg_contents": "(I suppose this is a pg15 issue)\n\ncreateuser --help shows the following help text.\n\n> --bypassrls role can bypass row-level security (RLS) policy\n> --no-bypassrls role cannot bypass row-level security (RLS) policy\n> --replication role can initiate... |
[
{
"msg_contents": "new thread [was: WIP Patch: Add a function that returns binary JSONB as a bytea]\n\n> I wrote:\n> > We can also shave a\n> > few percent by having pg_utf8_verifystr use SSE2 for the ascii path. I\n> > can look into this.\n>\n> Here's a patch for that. If the input is mostly ascii, I'd expect ... |
[
{
"msg_contents": "Hi,\n\nIt seems like there's the following typo in pgstatfuncs.c:\n\n- /* Values only available to role member or \npg_read_all_stats */\n+ /* Values only available to role member of \npg_read_all_stats */\n\nAttaching a tiny patch to fix it.\n\nRegards,\n\n-- \nBe... |
[
{
"msg_contents": "Reading over the new object access hook test I spotted a small typo in the\ndocumentation. Will apply a fix shortly.\n\n-A real-world OAT hook should certainly provide more fine-grained conrol than\n+A real-world OAT hook should certainly provide more fine-grained control than\n\n--\nDaniel ... |
[
{
"msg_contents": "Hi,\n\nAre builds being paused on s390x as it looks like the s390x builds were last run 15 days ago. If so, wondering what is the reason for the pause and what is required to resume the builds?\nThe OS the builds were running on seems to have reached end of life. Please let me know if we ca... |
[
{
"msg_contents": "Hi,\n\nToday while hacking I encountered this delight:\n\n2022-08-10 09:30:29.025 EDT [27126] FATAL: something has gone wrong\n\nI actually already knew that something had gone wrong, because the\ncode I was writing was incomplete. And if I hadn't known that, the\nword FATAL would have been ... |
[
{
"msg_contents": "(Coming from https://postgr.es/m/20220809193616.5uucf33piwdxn452@alvherre.pgsql )\n\nOn 2022-Aug-09, Alvaro Herrera wrote:\n\n> On 2022-Aug-09, Andres Freund wrote:\n> \n> > Mildly wondering whether we ought to use designated initializers instead,\n> > given we're whacking it around already. ... |
[
{
"msg_contents": "In the report at [1] we learned that the SQL-language function\nhandler is too cavalier about read/write expanded datums that\nit receives as input. A function that receives such a datum\nis entitled to scribble on its value, or even delete it.\nIf the function turns around and passes the da... |
[
{
"msg_contents": "Hey hackers,\n\nI see that logical replication subscriptions have an option to enable\nbinary [1].\nWhen it's enabled, subscription requests publisher to send data in binary\nformat.\nBut this is only the case for apply phase. In tablesync, tables are still\ncopied as text.\n\nTo copy tables,... |
[
{
"msg_contents": "when parsing command-line options, the -f option support disabling\n8 scan and join methods, o, b and t disable index-only scans,\nbitmap index scans, and TID scans respectively, add them to the\nhelp message.\n\ndiff --git a/src/backend/main/main.c b/src/backend/main/main.c\nindex 5a964a0db6... |
[
{
"msg_contents": "The caller of `get_stats_option_name` pass optarg as the argument,\nit's saner to use the argument instead of the global variable set\nby getopt, which is more safe since the argument has a *const*\nspecifier.\n\ndiff --git a/src/backend/tcop/postgres.c b/src/backend/tcop/postgres.c\nindex 11... |
[
{
"msg_contents": "Hi,\n\nOne of the things motivating me to work on the meson conversion is the ability\nto run tests in an easily understandable way. Meson has a testrunner that\nboth allows to run all tests at once, and run subsets of tests.\n\n\n= Test and testsuite naming =\n\nEach test has a unique name, ... |
[
{
"msg_contents": "Hi,\n\nOne other case suspicious, which I think deserves a conference.\nAt function wait_on_slots (src/fe_utils/parallel_slot.c)\nThe variable \"slots\" are array, but at function call SetCancelConn,\n\"slots\" are used as an object, which at the very least would be suspicious.\n\ncancelconn ... |
[
{
"msg_contents": "Hi,\n\nHere's a small patch replacing the explicit setting of\nXLogCtl->InstallXLogFileSegmentActive with the existing function\nSetInstallXLogFileSegmentActive(), removes duplicate code and saves 4\nLOC.\n\n-- \nBharath Rupireddy\nRDS Open Source Databases: https://aws.amazon.com/rds/postgre... |
[
{
"msg_contents": "Hi,\nIn cash_out(), we have the following code:\n\n if (value < 0)\n {\n /* make the amount positive for digit-reconstruction loop */\n value = -value;\n\nThe negation cannot be represented in type long when the value is LONG_MIN.\nIt seems we can error out when LONG_MIN i... |
[
{
"msg_contents": "Hi,\n\nFor my optimized builds I've long used -O3 -march=native. After one of the\nrecent package updates (I'm not certain when exactly yet), the main regression\ntests started to fail for me with that. Oddly enough in opr_sanity:\n\n -- Ask access methods to validate opclasses\n -- (this rep... |
[
{
"msg_contents": "Hi hackers,\n\nAt ServiceNow, we frequently encounter queries with very large IN lists\nwhere the number of elements in the IN list range from a few hundred to\nseveral thousand. For a significant fraction of the queries, the IN clauses\nare constructed on primary key columns. While planning ... |
[
{
"msg_contents": "Hi,\n\nWith commit 64da07c41a8c0a680460cdafc79093736332b6cf making default\nvalue of log_checkpoints to on, do we need to remove explicit settings\nin perl tests to save some (5) LOC?\n\nAlthough, it's harmless, here's a tiny patch to remove them.\n\n--\nBharath Rupireddy\nRDS Open Source Dat... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.