threads
listlengths
1
2.99k
[ { "msg_contents": "Hi,\n\n\nParam isSlice was once used to identity targetTypeId for transformAssignmentIndirection.\n\nIn commit c7aba7c14e, the evaluation was pushed down to transformContainerSubscripts.\n\nNo need to keep isSlice around transformAssignmentSubscripts.\n\nAttach a patch to remove it.\n\nRegard...
[ { "msg_contents": "AFAICS, the Vars forced nonnullable by given clause are only used to\ncheck if we can reduce JOIN_LEFT to JOIN_ANTI, and it is checking the\njoin's own quals there. It seems to me we do not need to pass down\nnonnullable_vars by upper quals to the children of a join.\n\nAttached is a patch to...
[ { "msg_contents": "Shouldn't such tuples be considered dead right away, even if the inserting\ntransaction is still active? That would allow cleaning them up even before\nthe transaction is done.\n\nThere is this code in HeapTupleSatisfiesVacuumHorizon:\n\n else if (TransactionIdIsCurrentTransactionId(H...
[ { "msg_contents": "Hi,\n\nThe commit: Revert SQL/JSON features\nhttps://github.com/postgres/postgres/commit/2f2b18bd3f554e96a8cc885b177211be12288e4a\n\nLeft a little oversight.\nI believe it will be properly corrected when it is applied again.\nHowever, for Postgres 15 this may can cause a small memory leak.\n\...
[ { "msg_contents": "While messing with the new guc.h stuff I happened run headerscheck and\nwanted to abort it right away, and in doing so I realized that its\n'trap' line is incorrect: it only removes its temp dir, but it doesn't\nexit the program; so after you C-c it, it will spew a ton of complaints\nabout it...
[ { "msg_contents": "I saw the following message recently modified.\n\n> This controls the maximum distance we can read ahead in the WAL to prefetch referenced data blocks.\n\nMaybe the \"we\" means \"PostgreSQL program and you\" but I see it\nsomewhat out of place.\n\nI found other three uses of \"we\" in backen...
[ { "msg_contents": "I found a small typo in a comment in pgbench.c of 15/master.\n\n- * Return the number fo failed transactions.\n+ * Return the number of failed transactions.\n\nWhile at it, I found \"* lot fo unnecessary work.\" in pg13's\nprocsignal.c. It has been fixed by 2a093355aa in PG14 but PG13 was\nle...
[ { "msg_contents": "\nHi hackers,\n\nI found the StartSubTransaction has the following code:\n\n static void\n StartSubTransaction(void)\n {\n [...]\n\n s->state = TRANS_START;\n\n /*\n * Initialize subsystems for new subtransaction\n *\n * must initialize re...
[ { "msg_contents": "Hi!\n\nI found prepare statement are not jumbled.\nFro example PREPARE 't1'; and PREPARE 't2' are counted separately in \npg_stat_statements.\nI think it needs to be fixed.\nWhat do you think?\n\nRegards,\n\nKotaro Kawamoto\n\n\n", "msg_date": "Wed, 14 Sep 2022 17:14:06 +0900", "msg_f...
[ { "msg_contents": "I miss UUID, which indexes very strangely, is more and more popular and \npeople want to search for it.\n\nSee: https://www.postgresql.org/docs/current/textsearch-parsers.html\n\nUUID is fairly easy to parse:\nThe hexadecimal digits are grouped as 32 hexadecimal characters with \nfour hyphens...
[ { "msg_contents": "Hi hackers,\n\nRecently in one discussion a user complained [1] about\ncounterintuitive behavior of toast_tuple_target. Here is a quote:\n\n\"\"\"\nTable size 177.74 GB\nToast table size 12 GB\nIndexes size 33.49 GB\n\nThis table is composed of small columns \"id\", \"hash\", \"size\", and a\...
[ { "msg_contents": "In 29f45e29 we added support for executing NOT IN(values) with a\nhashtable, however this comment still claims that we only do so for\ncases where the ScalarArrayOpExpr's useOr flag is true.\n\nSee attached for fix.\n\nThanks,\nJames Coleman", "msg_date": "Wed, 14 Sep 2022 12:07:50 -0400"...
[ { "msg_contents": "Hi.\n\nAccording to:\nhttps://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-localalloc\n\"Note The local functions have greater overhead and provide fewer features\nthan other memory management functions. New applications should use the\nheap functions unless documentation sta...
[ { "msg_contents": "Hi hacker,\n\nRecently, I find there might be a typo in xact.c comments. The comments\nsay \"PG_PROC\", however, it actually means \"PGPROC\" structure. Since we\nhave pg_proc catalog, and use PG_PROC to reference the catalog [1], so,\nwe should use PGPROC to reference the structure. Any t...
[ { "msg_contents": "Detect format-string mistakes in the libpq_pipeline test module.\n\nI happened to notice that libpq_pipeline's private implementation\nof pg_fatal lacked any pg_attribute_printf decoration. Indeed,\nadding that turned up a mistake! We'd likely never have noticed\nbecause the error exits in ...
[ { "msg_contents": "Following my discovery of missed pg_attribute_printf coverage\nin libpq_pipeline (cf2c7a736), I went looking to see if we'd\nforgotten that anywhere else. The coverage seems to be solid\n... except at the very root, where we have no such markers for\npg_vsnprintf, pg_vsprintf, pg_vfprintf, p...
[ { "msg_contents": "We recently saw many backends (close to max_connection limit) get stalled\nin 'startup' in one of the production environments for Greenplum (fork of\nPostgreSQL). Tracing the reason, it was found all the tuples created by\nbootstrap (xmin=1) in pg_attribute were at super high block numbers (f...
[ { "msg_contents": "Hi,\n\n\"\"\"\\set ON_ERROR_STOP on\"\"\" stops any subsequent incoming query that \ncomes after an error of an SQL, but does not stop after a shell script \nran by \"\"\"\\! <some command>\"\"\" returning values other than 0, -1, or \n127, which suggests a failure in the result of the shell ...
[ { "msg_contents": "Hi Hackers,\n\nI see in the texteq() function calls to DatumGetTextPP() are followed\nby conditional calls to PG_FREE_IF_COPY. e.g.\n\nhttps://github.com/postgres/postgres/blob/master/src/backend/utils/adt/varlena.c#L1792\n\n text *targ1 = DatumGetTextPP(arg1);\n text *targ2 = DatumGetTex...
[ { "msg_contents": "I have a question about displaying NestLoopParam. In the plan below,\n\n# explain (costs off)\nselect * from a, lateral (select sum(i) as i from b where exists (select\nsum(c.i) from c where c.j = a.j and c.i = b.i) ) ss where a.i = ss.i;\n QUERY PLAN\n------------...
[ { "msg_contents": "Someone on general list recently complained that the error message\nfrom trying to use options on a partitioned table was misleading,\nwhich it definitely is:\n\nCREATE TABLE parted_col_comment (a int, b text) PARTITION BY LIST (a)\nWITH (fillfactor=100);\nERROR: unrecognized parameter \"fil...
[ { "msg_contents": "A user asked me whether we prune never visible changes, such as\n\nBEGIN;\nINSERT...\nUPDATE.. (same row)\nCOMMIT;\n\nOnce committed, the original insert is no longer visible to anyone, so\n\"ought to be able to be pruned\", sayeth the user. And they also say\nthat changing the app is much ha...
[ { "msg_contents": "Hi,\r\n\r\nThe release team is planning to release PostgreSQL 15 Release Candidate \r\n1 (RC1) on 2022-09-29. Please ensure all open items[1] are resolved no \r\nlater than 2022-09-24 0:00 AoE.\r\n\r\nFollowing recent release patterns, we planning for 2022-10-06 to be the \r\nGA date. This ma...
[ { "msg_contents": "According to\n\nhttps://bugzilla.redhat.com/show_bug.cgi?id=2127503\n\nbleeding-edge clang complains thusly:\n\nllvmjit_inline.cpp: In function 'std::unique_ptr<llvm::ModuleSummaryIndex> llvm_load_summary(llvm::StringRef)':\nllvmjit_inline.cpp:771:37: error: incomplete type 'llvm::MemoryBuffe...
[ { "msg_contents": "Hi Hackers,\r\n\r\nA recent observation in the way pg_stat_statements\r\nhandles CURSORS appears to be undesirable. This\r\nwas also recently brought up by Fujii Masao in the thread [1].\r\n\r\nThe findings are:\r\n1. DECLARE CURSOR statements are not normalized.\r\n2. The statistics are aggr...
[ { "msg_contents": "Hi,\n\nI liked this idea and after reviewing code I noticed some moments and \nI'd rather ask you some questions.\n\n\nFirstly, I suggest some editing in the comment of commit. I think, it is \nturned out the more laconic and the same clear. I wrote it below since I \ncan't think of any other...
[ { "msg_contents": "Hi y'all, I've got a proposed clarification to the documentation on the\nnuances of RLS behavior for update policies, and maybe a (humble) request\nfor a change in behavior to make it more intuitive. I am starting with\npgsql-docs since I think the documentation change is a good starting poin...
[ { "msg_contents": "I applied clang-tidy's\nreadability-inconsistent-declaration-parameter-name check with\n\"readability-inconsistent-declaration-parameter-name.Strict:true\" [1]\nto write the attached refactoring patch series. The patch series makes\nparameter names consistent between each function's definitio...
[ { "msg_contents": "On Fri, Sep 16, 2022 at 02:54:14PM +0700, John Naylor wrote:\n> v6 demonstrates why this should have been put off towards the end. (more below)\n\nSince the SIMD code is fresh in my mind, I wanted to offer my review for\n0001 in the \"Improve dead tuple storage for lazy vacuum\" thread [0].\n...
[ { "msg_contents": "Hi.\n\nThere are already multiple places that are building the subscription\norigin name, and there are more coming with some new patches [1] doing\nthe same:\n\ne.g.\nsnprintf(originname, sizeof(originname), \"pg_%u\", subid);\n\n~~\n\nIMO it is better to encapsulate this name formatting in ...
[ { "msg_contents": "Hi,\n\nWhile working on some other patches, I found serval typos(duplicate words and\nincorrect function name reference) in the code comments. Here is a small patch\nto fix them.\n\nBest regards,\nHou zhijie", "msg_date": "Mon, 19 Sep 2022 02:44:12 +0000", "msg_from": "\"houzj.fnst@fu...
[ { "msg_contents": "\nHi hackers,\n\nWhen I read the heapam_visibility.c, I found that there is some code in\nHeapTupleSatisfiesXXX that has a similar code for pre-9.0 binary upgrades.\n\nHeapTupleSatisfiesSelf, HeapTupleSatisfiesToast and HeapTupleSatisfiesDirty\nhave the same code for pre-9.0 binary upgrades. ...
[ { "msg_contents": "Hi,\n\n\nIn preprocess_aggref(), list same_input_transnos is used to track compatible transnos.\n\nFree it if we don’t need it anymore.\n\n```\n\n/*\n * 2. See if this aggregate can share transition state with another\n * aggregate that we've initialized already.\n */\n transno = find_compati...
[ { "msg_contents": "Hi,\n\nI'm sorry,if this message is duplicated previous this one, but the \nprevious message is sent incorrectly. I sent it from email address \nlena.ribackina@yandex.ru.\n\nI liked this idea and after reviewing code I noticed some moments and \nI'd rather ask you some questions.\n\nFirstly, ...
[ { "msg_contents": "Hi,\n\nI added xlogreader cache stats (hits/misses) to pg_stat_wal in\nReadPageInternal() for some of my work and ran some tests with logical\nreplication subscribers. I had expected that the new stats generated\nby walsenders serving the subscribers would be accumulated and shown\nvia pg_sta...
[ { "msg_contents": "Hi,\n\nI was recently asked about converting an offset reported in WAL read\nerror messages[1] to an LSN with which pg_waldump can be used to\nverify the records or WAL file around that LSN (basically one can\nfilter out the output based on LSN). AFAICS, there's no function that\ntakes offset...
[ { "msg_contents": "\nAll of a sudden I'm getting repo not found for\nUbuntu 16.04 LTS on the APT repo. Why?\n\n-- \nLarry Rosenman http://www.lerctr.org/~ler\nPhone: +1 214-642-9640 E-Mail: ler@lerctr.org\nUS Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106\n\n\n", "msg_d...
[ { "msg_contents": "Hi All,\n\nCurrently, we have pg_current_wal_insert_lsn and pg_walfile_name sql\nfunctions which gives us information about the next wal insert\nlocation and the WAL file that the next wal insert location belongs\nto. Can we have a binary version of these sql functions? It would be\nlike any ...
[ { "msg_contents": "\nHi hacker,\n\nAs $subject detailed, the tab-complete cannot work such as:\n\n CREATE SUBSCRIPTION sub CONNECTION 'dbname=postgres port=6543' \\t\n\nIt seems that the get_previous_words() could not parse the single quote.\n\nOTOH, it works for CREATE SUBSCRIPTION sub CONNECTION xx \\t, sho...
[ { "msg_contents": "Hello,\n\nThe function `pg_create_logical_replication_slot()` is documented to have\na `two_phase` argument(note the underscore), but the function instead\nrequires `twophase`.\n\n```\n\\df pg_catalog.pg_create_logical_replication_slot\nList of functions\n-[ RECORD 1\n]-------+--------------...
[ { "msg_contents": "While working on the -Wdeprecated-non-prototype fixups discussed\nnearby, I saw that clang 15.0 produces a few other new warnings\n(which are also visible in the buildfarm). Pursuant to our\nusual policy that we should suppress warnings on compilers likely\nto be used for development, here's...
[ { "msg_contents": "Over in the \"Add last commit LSN to pg_last_committed_xact()\" [1]\nthread this patch had been added as a precursor, but Michael Paquier\nsuggested it be broken out separately, so I'm doing that here.\n\nIt turns out that MSVC supports both noreturn [2] [3] and alignment\n[4] [5] attributes,...
[ { "msg_contents": "Hello hackers,\n\nAs noted in the source:\n\nhttps://github.com/postgres/postgres/blob/master/src/include/nodes/pg_list.h#L6-L11\n\n * Once upon a time, parts of Postgres were written in Lisp and used real\n * cons-cell lists for major data structures. When that code was rewritten\n * in C, ...
[ { "msg_contents": "Hi,\n\nI realized that there are some places where we use XLogRecPtr for\nvariables for replication origin id. The attached patch fixes them to\nuse RepOriginiId instead.\n\nRegards,\n\n-- \nMasahiko Sawada\nPostgreSQL Contributors Team\nRDS Open Source Databases\nAmazon Web Services: https:/...
[ { "msg_contents": "Hi,\nI was looking at this check in src/backend/parser/parse_utilcmd.c w.r.t.\nconstraint:\n\n if (indclass->values[i] != defopclass ||\n attform->attcollation != index_rel->rd_indcollation[i]\n||\n attoptions != (Datum) 0 ||\n ...
[ { "msg_contents": "Hopefully I'm not missing something obvious, but as far as I know\nthere's no way to configure auto explain to work fire\nstatement_timeout fires.\n\nI'd like to look into this at some point, but I'm wondering if anyone\nhas thought about it before, and, if so, is there any obvious\nimpedimen...
[ { "msg_contents": "For publication schemas (OBJECT_PUBLICATION_NAMESPACE) and user\nmappings (OBJECT_USER_MAPPING), pg_get_object_address() checked the\narray length of the second argument, but not of the first argument.\nIf the first argument was too long, it would just silently ignore\neverything but the firs...
[ { "msg_contents": "Hello,\n\nI’m working on a patch to support logical replication of large objects\n(LOBs). This is a useful feature when a database in logical\nreplication has lots of tables, functions and other objects that\nchange over time, such as in online cross major version upgrade. As\nan example, th...
[ { "msg_contents": "Hi hackers,\n\nIn 6c2003f8a1bbc7c192a2e83ec51581c018aa162f, we change the snapshot name\nwhen exporting snapshot, however, there is one place we missed update the\nsnapshot name in documentation. Attach a patch to fix it.\n\n-- \nRegrads,\nJapin Li.\nChengDu WenWu Information Technology Co.,...
[ { "msg_contents": "Hello Hackers!\n\nIs it possible to get the current virtual txid from C somehow?\n\nI've looked through the code, but can't seem to find anything other than\ngetting a NULL when there is no (real) xid assigned. Maybe I'm missing\nsomething?\n\nCheers,\nJames\n\nHello Hackers!Is it possible to...
[ { "msg_contents": "Hi hackers,\n\nRecently, we discover that the field of tts_tableOid of TupleTableSlot is\nassigned duplicated in table AM's interface which is not necessary. For\nexample, in table_scan_getnextslot,\n\n```\nstatic inline bool\ntable_scan_getnextslot(TableScanDesc sscan, ScanDirection directio...
[ { "msg_contents": "Hi,\n\nWhile working on the “Fast COPY FROM based on batch insert” patch, I\nnoticed this:\n\n else if (proute != NULL && resultRelInfo->ri_TrigDesc != NULL &&\n resultRelInfo->ri_TrigDesc->trig_insert_new_table)\n {\n /*\n * For partitioned tables we can't su...
[ { "msg_contents": "when a error occurs when creating proc, it should point out the\nspecific proc kind instead of just printing \"function\".\n\ndiff --git a/src/backend/catalog/pg_proc.c b/src/backend/catalog/pg_proc.c\nindex a9fe45e347..58af4b48ce 100644\n--- a/src/backend/catalog/pg_proc.c\n+++ b/src/backend...
[ { "msg_contents": "In view of\n\nAuthor: John Naylor <john.naylor@postgresql.org>\nBranch: master [8b878bffa] 2022-09-09 12:55:23 +0700\n\n Bump minimum version of Flex to 2.5.35\n\nI wonder if we should go a little further and get rid of\nsrc/tools/fix-old-flex-code.pl (just in HEAD, to be clear).\nThat doe...
[ { "msg_contents": "Hi hackers,\n\nSharing a small patch to remove an unused parameter\nin SnapBuildGetOrBuildSnapshot function in snapbuild.c\n\nWith commit 6c2003f8a1bbc7c192a2e83ec51581c018aa162f,\nSnapBuildBuildSnapshot no longer needs transaction id. This also makes the\nxid parameter in SnapBuildGetOrBuild...
[ { "msg_contents": "Hi all,\n\nI am working on a project with LLVM ORC that led us to PostgreSQL as a\ntarget application. We were surprised by learning that PGSQL already uses\nLLVM ORC to JIT certain queries.\n\nI would love to know what motivated this feature and for what it is being\ncurrently used for, as i...
[ { "msg_contents": "Currently, pg_basebackup has\n--create-slot option to create slot if not already exists or\n--slot to use existing slot\n\nWhich means it needs knowledge on if the slot with the given name already\nexists or not before invoking the command. If pg_basebackup --create-slot\n<> command fails for...
[ { "msg_contents": "meson: Add initial version of meson based build system\n\nAutoconf is showing its age, fewer and fewer contributors know how to wrangle\nit. Recursive make has a lot of hard to resolve dependency issues and slow\nincremental rebuilds. Our home-grown MSVC build system is hard to maintain for\n...
[ { "msg_contents": "Hi\n\nToday I found new bug\n\n-o llvmjit_wrap.o llvmjit_wrap.cpp -MMD -MP -MF .deps/llvmjit_wrap.Po\nllvmjit.c: In function ‘llvm_resolve_symbols’:\nllvmjit.c:1115:57: error: ‘LLVMJITCSymbolMapPair’ undeclared (first use in\nthis function); did you mean ‘LLVMOrcCSymbolMapPair’?\n 1115 | ...
[ { "msg_contents": "I was confused about how come the new patches I'd just posted in\nthe 3848 CF item (write/read support for raw parse trees) are\nshowing a mix of passes and fails in the cfbot. I eventually\nrealized that the fail results are all old and stale, because\n(for example) there's no longer a \"Fr...
[ { "msg_contents": "When using ON CONFLICT DO NOTHING together with RETURNING, the \nconflicted rows are not returned. Sometimes, this would be useful \nthough, for example when generated columns or default values are in play:\n\nCREATE TABLE x (\n id INT PRIMARY KEY,\n created_at TIMESTAMPTZ DEFAULT CURRENT...
[ { "msg_contents": "Hi,\n\nI amd working on adding an \"installcheck\" equivalent mode to the meson\nbuild. One invocation of something \"installcheck-world\" like lead to things\ngetting stuck.\n\nLots of log messages like:\n\n2022-09-25 16:16:30.999 PDT [2705454][client backend][28/1112:41269][pg_regress] LOG:...
[ { "msg_contents": "The max size for the shared memory hash table name is SHMEM_INDEX_KEYSIZE - 1\n (shared hash table name is stored and indexed by ShmemIndex hash table,\n the key size of it is SHMEM_INDEX_KEYSIZE), but when the caller uses a\n longer hash table name, it doesn't report any error, instead it ju...
[ { "msg_contents": "Hi,\n\npg_stat_statements module distinguishes queries with different \nstructures, but some visibly different MERGE queries were combined as \none pg_stat_statements entry.\nFor example,\nMERGE INTO test1 USING test2 ON test1.id = test2.id WHEN MATCHED THEN \nUPDATE var = 1;\nMERGE INTO test...
[ { "msg_contents": "Hi hackers,\n\nWhile reviewing [1], I and Amit noticed that a flag ParallelMessagePending is defined\nas \"volatile bool\", but other flags set by signal handlers are defined as \"volatile sig_atomic_t\".\n\nThe datatype has been defined in standard C,\nand it says that variables referred by ...
[ { "msg_contents": "I saw the following message recently added to publicationcmds.c.\n\n(ERROR: cannot use publication column list for relation \"%s.%s\"\")\n> DETAIL: Column list cannot be specified if any schema is part of the publication or specified in the list.\n\nAs my reading, the \"the list\" at the end ...
[ { "msg_contents": "Hi All,\n\nConsider the below test:\n\npostgres@53130=#create role test WITH login createdb;\nCREATE ROLE\npostgres@53130=#\\c - test\nYou are now connected to database \"postgres\" as user \"test\".\npostgres@53150=#create database test;\nCREATE DATABASE\npostgres@53150=#\\c - rushabh\nYou a...
[ { "msg_contents": "Hi hackers,\n\nI wanted to add ARM CPU darwin to the CI but it seems\nthat kerberos/001_auth fails on ARM CPU darwin.\n\nOS:\nDarwin admins-Virtual-Machine.local 21.6.0 Darwin Kernel Version 21.6.0:\nWed Aug 10 14:26:07 PDT 2022; root:xnu-8020.141.5~2/RELEASE_ARM64_VMAPPLE\narm64\n\nError mes...
[ { "msg_contents": "Hi,\n\nPostgres currently can leak memory if a failure occurs during base\nbackup in do_pg_backup_start() or do_pg_backup_stop() or\nperform_base_backup(). The palloc'd memory such as backup_state or\ntablespace_map in xlogfuncs.c or basebackup.c or tablespaceinfo or the\nmemory that gets all...
[ { "msg_contents": "Hi,\r\n\r\nThe PostgreSQL 15 GA release (15.0) is now scheduled for October 13, \r\n2022. The release team changed this from the planned date of October 6 \r\nto allow for additional testing of recent changes.\r\n\r\nPlease let us know if you have any questions. We're excited that we are \r\n...
[ { "msg_contents": "Hi, hackers\n\nheap_force_kill/heap_force_freeze doesn’t consider other transactions that are using the same tuples even with tuple-locks.\nThe functions may break transaction semantic, ex:\n\nsession1\n```\ncreate table htab(id int);\ninsert into htab values (100), (200), (300), (400), (500)...
[ { "msg_contents": "Just a reminder that only some days left of \"September 2022 commitfest\"\nAs of now, there are \"295\" patches in total. Out of these 295 patches, \"18\"\npatches required committer attention, and 167 patches needed reviews.\n\nTotal: 295.\nNeeds review: 167.\nWaiting on Author: 44.\nReady f...
[ { "msg_contents": "Hi hackers,\n\nEnums index a number of the GUC tables. This all relies on the\nelements being carefully arranged to be in the same order as those\nenums. There are comments to say what enum index belongs to each table\nelement.\n\nBut why not use designated initializers to enforce what the co...
[ { "msg_contents": "Hi hackers.\n\nI have a question about the recommended way to declare the C variables\nused for the GUC values.\n\nHere are some examples from the code:\n\n~\n\nThe GUC boot values are defined in src/backend.utils/misc/guc_tables.c\n\ne.g. See the 4, and 2 below\n\n{\n{\"max_logical_replicati...
[ { "msg_contents": "I was wondering about how to debug failed builds on Cirrus CI, and\nafter poking at the interface I realized we helpfully upload the logs\nfrom CI runs for user download.\n\nIn an effort to save the next person a few minutes I thought the\nattached minor patch would help.\n\nThanks,\nJames Co...
[ { "msg_contents": "I had a build on Cirrus CI fail tonight in what I have to assume was\neither a problem with caching across builds or some such similar\nflakiness. In the Debian task [1] I received this error:\n\nsu postgres -c \"make -s -j${BUILD_JOBS} world-bin\"\nIn file included from parser.c:25:\n./gramp...
[ { "msg_contents": "Like other Postgres hackers [1], I have a custom .clang-format file\nthat I use for my work on Postgres. It's a useful tool, despite some\nnotable problems.\n\nFirst, I should mention the problems. The config that I use makes an\nawkward trade-off that results in function declarations getting...
[ { "msg_contents": "Hi,\n\nThe x86 mac VMs from cirrus-ci claim to have 12 CPUs, but when working on\ninitdb caching for tests I noticed that using all those CPUs for tests hurts\nthe test times noticably.\n\nSee [1] (note that the overall time is influenced by different degrees of\ncache hit ratios):\n\nconcurr...
[ { "msg_contents": "Hi,\n\nI recently faced an issue on windows where one of the tests was\nfailing with 'unrecognized win32 error code: 123', see [1]. I figured\nout that it was due to a wrong file name being sent to open() system\ncall (this error is of my own making and I fixed it for that thread).\nThe failu...
[ { "msg_contents": "Hi Wolfgang Walther, I saw your patch and thought it would be very handy in some cases!\r\n\r\n\r\nAfter I applied this patch, I felt something was wrong: the description in the sgml documentation is different from the actual code. I don't know if there is something wrong with my understandin...
[ { "msg_contents": "Hi hackers,\n\nI saw a problem when using tab-complete for \"GRANT\", \"TABLES IN SCHEMA\" should\nbe \"ALL TABLES IN SCHEMA\" in the following case.\n\npostgres=# grant all on\nALL FUNCTIONS IN SCHEMA DATABASE FUNCTION PARAMETER SCHEMA ...
[ { "msg_contents": "Increase width of RelFileNumbers from 32 bits to 56 bits.\n\nRelFileNumbers are now assigned using a separate counter, instead of\nbeing assigned from the OID counter. This counter never wraps around:\nif all 2^56 possible RelFileNumbers are used, an internal error\noccurs. As the cluster is ...
[ { "msg_contents": "Hi,\n\nlongfin and tamandua recently begun failing like this, quite possibly\nas a result of 05d4cbf9b6ba708858984b01ca0fc56d59d4ec7c:\n\n+++ regress check in contrib/test_decoding +++\ntest ddl ... FAILED (test process exited with\nexit code 2) 3276 ms\n(all othe...
[ { "msg_contents": "Hi,\n\nMelih mentioned on IM that while he could build postgres with meson on windows\nw/ mingw, the tests didn't run.\n\nIssues:\n\n- The bit computing PATH to the temporary installation for running tests only\n dealt with backward slashes in paths on windows, because that's what\n python....
[ { "msg_contents": "Hi,\n\nWhile reviewing the “Fast COPY FROM based on batch insert\" patch, I\nnoticed this comment introduced in commit b663a4136:\n\n /*\n * If a certain number of tuples have already been accumulated, or\n * a tuple has come for a different relation than th...
[ { "msg_contents": "Hi,\r\n\r\nAttached is a draft of the PostgreSQL 15 RC 1 release announcement. \r\nPlease provide feedback no later than 2022-09-29 0:00 AoE.\r\n\r\nThanks,\r\n\r\nJonathan", "msg_date": "Wed, 28 Sep 2022 09:42:39 -0400", "msg_from": "\"Jonathan S. Katz\" <jkatz@postgresql.org>", ...
[ { "msg_contents": "Hi,\n\nxlog.c currently has ~9000 LOC, out of which ~700 LOC is backup\nrelated, making the file really unmanageable. The commit\n7d708093b7400327658a30d1aa1d5e284d37622c added new files\nxlogbackup.c/.h for hosting all backup related code eventually. I\npropose to move all the backp related ...
[ { "msg_contents": "We have discussed the problems caused by the use of pg_stat_reset() and \npg_stat_reset_shared(), specifically the removal of information needed\nby autovacuum. I don't see these risks documented anywhere. Should we\ndo that? Are there other risks?\n\n-- \n Bruce Momjian <bruce@momjian.u...
[ { "msg_contents": "Hi hackers,\n\nWith PG 15 (rc1 or beta4), I'm observing an interesting memory pattern. I\nhave not seen a similar discussion on the mailing list. If I missed that,\nplease refer me there. The problem that I'm going to explain does not\nhappen on PG 13/14.\n\nIt seems like there is a memory le...
[ { "msg_contents": ">CREATE TABLE t1 (a text);\n>CREATE TABLE t2 (a text);\n\n>-- make the text a little large by adding 100000000000\n>INSERT INTO t1 SELECT (100000000000+i%1000)::text FROM\n>generate_series(0,10000000) i;\n\n>-- make the text a little large by adding 100000000000\n>INSERT INTO t2 SELECT (10000...
[ { "msg_contents": "Hi hackers,\n\nThe proposed patch removes the redundant `fixOwner` argument.\n\n\"\"\"\nThe fixOwner bool argument ended up always being true, so it doesn't do much\nanymore. Removing it doesn't necessarily affect the performance a lot, but at\nleast improves the readability. The procedure is...
[ { "msg_contents": "OK, so the recent commit and revert of the 56-bit relfilenode patch\nrevealed a few issues that IMHO need design-level input. Let me try to\nsurface those here, starting a new thread to separate this discussion\nfrom the clutter:\n\n1. Commit Record Alignment. ParseCommitRecord() and ParseAbo...
[ { "msg_contents": "Hi,\n\nThe max size for the shmem hash table name is SHMEM_INDEX_KEYSIZE - 1.\nbut when the caller uses a longer hash table name, it doesn't report any error, instead\nit just uses the first SHMEM_INDEX_KEYSIZE -1 chars as the hash table name.\n\nI created some shmem hash tables with the same...
[ { "msg_contents": "We originally did this in 91e9e89dc, but a memory leak was discovered\nas I neglected to pfree the datum which is freshly allocated in\ntuplesort_getdatum. Because that was discovered late in the PG15\ncycle, we opted to just disable the datum sort optimisation for byref\ntypes in 3a5817695.\...
[ { "msg_contents": "Hi hackers,\n\nWhile running `make check LANC=C` with 32-bit virtual machine,\nI found that it was failed at \"aggregates\". PSA the a1b3bca1_regression.diffs.\nIIUC that part has been added by db0d67db. \nI checked out the source, tested, and got same result. PSA the db0d67db_regression.diff...
[ { "msg_contents": "I already mentioned this in [1]: we can remove a few subcmd types that\nwere added to support exec-time recursion, by keeping a separate flag\nfor it. We're already doing that for alter trigger operations, so this\npatch just extends that to the other subcommand types that need it.\n\nThere'...
[ { "msg_contents": "Hi,\n\nThe psql improvement in v15 to output multiple result sets does not\nbehave as one might expect with \\g: the output file or program\nto pipe into is opened/closed on each result set, overwriting the\nprevious ones in the case of \\g file.\n\nExample:\n\npsql -At <<EOF\n-- good (two re...
[ { "msg_contents": "The following documentation comment has been logged on the website:\n\nPage: https://www.postgresql.org/docs/14/app-pgrestore.html\nDescription:\n\npg_restore seems to have two ways to restore data:\r\n\r\n--section=data \r\n\r\nor\r\n\r\n --data-only\r\n\r\nThere is this cryptic warning that...
[ { "msg_contents": "I'd like to revamp this important discussion.\n\nAs is well described in this fairly recent paper here https://www.vldb.org/pvldb/vol9/p204-leis.pdf (which also looks at Postgres) \"estimation errors quickly grow as the number of joins increases, and that these errors are usually the reason f...
[ { "msg_contents": "Hackers,\n\nPer the documentation in TupleTableSlotOps, an AM can choose not to supply a get_heap_tuple function, and instead set this field to NULL. Doing so appears to almost work, but breaks the xmin and xmax returned by a INSERT..ON CONFLICT DO UPDATE..RETURNING. In particular, the call...