threads
listlengths
1
2.99k
[ { "msg_contents": "Hi hackers,\n I encounter a problem, as shown below:\n\nquery:\n select\n ref_0.ps_suppkey as c0,\n ref_1.c_acctbal as c1,\n ref_2.o_totalprice as c2,\n ref_2.o_orderpriority as c3,\n ref_2.o_clerk as c4\nfrom\n public.partsupp as ref_0\n left join public.nation as sample_0\n ...
[ { "msg_contents": "Dear hackers,\n(CC: Amit and Julien)\n\nThis is a fork thread of Julien's thread, which allows to upgrade subscribers\nwithout losing changes [1].\n\nI briefly implemented a prototype for allowing to upgrade publisher node.\nIIUC the key lack was that replication slots used for logical replic...
[ { "msg_contents": "Hi,\n\n\nWe are looking forward to get help from community on publishing s390x binaries. As per downloads page, apt repo supports Ubuntu on amd,arm,i386 and ppc64le.\nWe had reached out earlier and are ready to provide infra if needed. Wanted to check again if community is willing to help.\n\...
[ { "msg_contents": "Hi,\n\nFor quite a while I'd been wishing to see *differential* code coverage, to see\nwhat changed in code coverage between two major releases. Unfortunately lcov\ndidn't provide that. A few months ago a PR for it has been merged into lcov\n([1]). There hasn't yet been a release though. And ...
[ { "msg_contents": "Hi,\n\nLook at:\n\nstatic void\nfill_seq_fork_with_data(Relation rel, HeapTuple tuple, ForkNumber forkNum)\n{\n\tBuffer\t\tbuf;\n\tPage\t\tpage;\n\tsequence_magic *sm;\n\tOffsetNumber offnum;\n\n\t/* Initialize first page of relation with special magic number */\n\n\tbuf = ReadBufferExtended(...
[ { "msg_contents": "There are some recent comment that added new options for CREATE SUBSCRIPTION\n\n\"Add new predefined role pg_create_subscription.\" [1]\nThis added a new \"password_required\" option.\n\n\"Add a run_as_owner option to subscriptions.\" [2]\nThis added a \"run_as_owner\" option.\n\n~~\n\nAFAICT...
[ { "msg_contents": "There seems to be a comment typo in the recent commit \"Perform logical\nreplication actions as the table owner\" [1].\n\n/*\n * Switch back to the original user ID.\n *\n * If we created a new GUC nest level, also role back any changes that were\n * made within it.\n */\n\n\n/role back/rollb...
[ { "msg_contents": "Hi Hackers,\n\nThis Koshi Shibagaki.\nI found out that there is a mistake written in contrib/postgres_fdw/postgres_fdw.c.\n\nPatch file is attached.\n\nThe non-existent function name \" ExecCheckRTEPerms \" was written in \nthe comment in postgresBeginForeignScan.\nThis mistake is considered ...
[ { "msg_contents": "Hi hackers,\n\nParallelism has been in core since 9.6, it's a great feature that got \nseveral\nupgrades since then. However, it lacks metrics to determine if and how\nparallelism is used and help tune parameters related to it.\n\nCurrently, the only information available are pg_stat_activity...
[ { "msg_contents": "Not sure if this is the right place to ask but I've tried to build using\nthis source rpm\nhttps://ftp.postgresql.org/pub/repos/yum/srpms/13/redhat/rhel-9-x86_64/postgresql13-13.9-1PGDG.rhel9.src.rpm\non a RHEL 9 system and gotten the follow error:\nrpmbuild -bb SPECS/postgresql-13.spec\nwarn...
[ { "msg_contents": "I wrote an optimizer talk that explains memoize, slides 24-25:\n\n\thttps://momjian.us/main/writings/pgsql/beyond.pdf#page=25\n\nDuring two presentations, I was asked if negative cache entries were\ncreated for cases where inner-side lookups returned no rows.\n\nIt seems we don't do that. Ha...
[ { "msg_contents": "Add smgrzeroextend(), FileZero(), FileFallocate()\n\nsmgrzeroextend() uses FileFallocate() to efficiently extend files by multiple\nblocks. When extending by a small number of blocks, use FileZero() instead, as\nusing posix_fallocate() for small numbers of blocks is inefficient for some\nfile...
[ { "msg_contents": "Hi,\n\nI just saw the following failure:\nhttps://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=mylodon&dt=2023-04-05%2017%3A47%3A03\nafter a commit of mine. The symptoms look unrelated though.\n\n[17:54:42.188](258.345s) # poll_query_until timed out executing this query:\n# SELECT wal_stat...
[ { "msg_contents": "Hi,\n\nCurrently the standby reaches ResolveRecoveryConflictWithVirtualXIDs()\nwith a waitlist of VXIDs that are preventing it from making progress.\nFor each one it enters a sleep/poll loop that repeatedly tries to\nacquire (conditionally) the VXID lock with VirtualXactLock(vxid,\nwait=false...
[ { "msg_contents": "psql: add an optional execution-count limit to \\watch.\n\n\\watch can now be told to stop after N executions of the query.\n\nWith the idea that we might want to add more options to \\watch\nin future, this patch generalizes the command's syntax to a list\nof name=value options, with the int...
[ { "msg_contents": "Hi Hackers,\n\nI opened https://git.postgresql.org/gitweb/?p=postgresql.git;a=tree and\nclone the repo. The README file says that I can read the INSTALL file to\nunderstand how to build from source. But there is no such file in Git\nsources. Is it expected? If so, why?\n\nBest,\ntison.\n\nHi ...
[ { "msg_contents": "I was reading the logical replication code and found a little\nunnecessary work we are doing.\n\nThe confirmed_flushed_lsn cannot reasonably be ahead of the\ncurrent_lsn, so there is no point of calling\nLogicalConfirmReceivedLocation() every time we update the candidate\nxmin or restart_lsn....
[ { "msg_contents": "Hi,\n\nIf you build with --with-wal-blocksize=/-Dwal_blocksize= anything but\n8, this breaks:\n\nrunning bootstrap script ... LOG: GUC (PGC_INT)\nwal_writer_flush_after, boot_val=256, C-var=128\nTRAP: failed Assert(\"check_GUC_init(hentry->gucvar)\"), File: \"guc.c\",\nLine: 1519, PID: 84605...
[ { "msg_contents": "Greetings,\n\nLooks like longfin has a particularly old Kerberos/GSSAPI installation\non it which pre-dates MIT release 1.11 from circa 2012 and is missing\ngssapi_ext.h, causing the recently committed patch to add Kerberos\ncredential delegation to fail to build.\n\nI'm inclined to update ou...
[ { "msg_contents": "Hi\n\non fresh Fedora 38, I cannot to run regress tests\n\n+ERROR: could not load library\n\"/home/pavel/src/postgresql.master/tmp_install/usr/local/pgsql/master/lib/llvmjit.so\":\n/home/pavel/src/p\nostgresql.master/tmp_install/usr/local/pgsql/master/lib/llvmjit.so:\nundefined symbol: LLVMB...
[ { "msg_contents": "TAP test for logical decoding on standby\n\nAuthor: \"Drouvot, Bertrand\" <bertranddrouvot.pg@gmail.com>\nAuthor: Amit Khandekar <amitdkhan.pg@gmail.com>\nAuthor: Craig Ringer <craig@2ndquadrant.com> (in an older version)\nAuthor: Andres Freund <andres@anarazel.de>\nReviewed-by: \"Drouvot, Be...
[ { "msg_contents": "Hi,\n\nI'd planned to write this soon anyway, but it was just brought up in [1].\n\nOriginally we had planned to drop src/tools/msvc support shortly after meson\nwent in. Unfortunately, it took a bit longer than originally hoped for to\nmerge meson support and then longer than hoped to add bu...
[ { "msg_contents": "Hi all,\n\nThis patch does three things in the DecodeInterval function:\n\n1) Removes dead code for handling unit type RESERVE. There used to be\na unit called \"invalid\" that was of type RESERVE. At some point that\nunit was removed and there were no more units of type RESERVE.\nTherefore, ...
[ { "msg_contents": "Hello, we encountered unexpected behavior from an ECPG program\ncomplied with the -C ORACLE option. The program executes the\nfollowing query:\n\n SELECT 123::numeric(3,0), 't'::char(2)\";\n\nCompilation and execution steps:\n\n$ ecpg -C ORACLE ecpgtest.pgc (attached)\n$ gcc -g -o ecpgtest e...
[ { "msg_contents": "When I am working on \"Pushing limit into subqueries of a union\" [1], I\nfound we already have a great infrastructure to support this. For a query\nlike\n\nsubquery-1 UNION ALL subquery-2 LIMIT 3;\n\nWe have considered the root->tuple_fraction when planning the subqueries\nwithout an extra L...
[ { "msg_contents": "As the comment above add_path() says, 'The pathlist is kept sorted by\ntotal_cost, with cheaper paths at the front.' And it seems that\nget_cheapest_parallel_safe_total_inner() relies on this ordering\n(without being mentioned in the comments, which I think we should do).\nI'm wondering if t...
[ { "msg_contents": "Hi all,\n\nWhile doing a few things on Windows with meson, I have noticed that,\nwhile we output some information related to bison after a setup step,\nthere is nothing about flex.\n\nI think that adding something about flex in the \"Programs\" section\nwould be pretty useful, particularly fo...
[ { "msg_contents": "cfbot [1] is listing some already committed patches under the \"Needs\nReview\" category. For example here are some of mine [1][2]. And\nbecause they are already committed, the 'apply' fails, so they get\nflagged by cfbot as needed rebase.\n\nSomething seems broken.\n\n------\n[1] http://cfb...
[ { "msg_contents": "The check for parallel_safe should be even cheaper than cost comparison\nso I think it's better to do that first. The attached patch does this\nand also updates the comment to mention the requirement about being\nparallel-safe.\n\nThanks\nRichard", "msg_date": "Tue, 11 Apr 2023 15:19:41 ...
[ { "msg_contents": "Over in [1], Horiguchisan mentioned a few things about VACUUM's new\nBUFFER_USAGE_LIMIT option.\n\n1) buffer_usage_limit in the ERROR messages should be consistently in uppercase.\n2) defGetString() already checks for opt->args == NULL and raises an\nERROR when it is.\n\nI suspect that Melani...
[ { "msg_contents": "hi hackers,\n\nwhile working on the issue reported by Noah in [1], I realized that there is an\nissue in 035_standby_logical_decoding.pl.\n\nThe issue is here:\n\n\"\n$node_standby->reload;\n\n$node_primary->psql('postgres', q[CREATE DATABASE testdb]);\n$node_primary->safe_psql('testdb', qq[C...
[ { "msg_contents": "Over on [1], Tom mentioned that we might want to rethink the decision\nto not protect chunk headers with Valgrind. That thread fixed a bug\nthat was accessing array element -1, which effectively was reading the\nMemoryChunk at the start of the allocated chunk as an array element.\n\nI wrote ...
[ { "msg_contents": "Reduced from sqlsmith, this query fails under debug_parallel_query=1.\n\nThe elog was added at: 55416b26a98fcf354af88cdd27fc2e045453b68a\nBut (I'm not sure) the faulty commit may be 8edd0e7946 (Suppress Append\nand MergeAppend plan nodes that have a single child).\n\npostgres=# SET force_para...
[ { "msg_contents": "Hi,\n\nI've attached a patch with a few typo and grammatical fixes.\n\nRegards\n\nThom", "msg_date": "Tue, 11 Apr 2023 15:36:02 +0100", "msg_from": "Thom Brown <thom@linux.com>", "msg_from_op": true, "msg_subject": "Various typo fixes" }, { "msg_contents": "On Tue, Apr...
[ { "msg_contents": "Hi,\n\nI was looking at this issue: \nhttps://www.postgresql.org/message-id/flat/17888-f72930e6b5ce8c14%40postgresql.org\n\npfree call on contrib/intarray/_int_gist.c:345\n\n```\n\n     if (in != (ArrayType *) DatumGetPointer(entry->key))\n         pfree(in);\n\n```\n\nleads to BogusFree func...
[ { "msg_contents": "Hi,\n\nWhile playing with a new single board computer (VisionFive 2) I\ndiscovered that postgresql:unsafe_tests suite fails like this:\n\n```\n--- /home/user/projects/postgresql/src/test/modules/unsafe_tests/expected/rolenames.out\n2023-04-11 14:58:57.844550612 +0000\n+++ /home/user/projects/...
[ { "msg_contents": "Hi,\n\nWhen using postgres_fdw, in the event of a local transaction being\naborted while a query is running on a remote server,\npostgres_fdw sends a cancel request to the remote server.\nHowever, if PQgetCancel() returned NULL and no cancel request was issued,\nI found that postgres_fdw coul...
[ { "msg_contents": "I have seen this failure a couple of times recently while\ntesting code that caused crashes and restarts:\n\n#2 0x00000000009987e3 in ExceptionalCondition (\n conditionName=conditionName@entry=0xb31bc8 \"mode == RBM_NORMAL || mode == RBM_ZERO_ON_ERROR || mode == RBM_ZERO_AND_LOCK\", \n ...
[ { "msg_contents": "Yes, $SUBJECT is correct.\n\nOn an old centos6 VM which I'd forgotten about and never removed from\nmonitoring, I noticed that a process had recently crashed...\n\nMaybe this is an issue which was already fixed, but I looked and find no\nbug report nor patch about it. Feel free to dismiss th...
[ { "msg_contents": "Commit 0ac5ad5134 (\"Improve concurrency of foreign key locking\") added\ninfobits_set fields to certain WAL records. However, in the case of\nxl_heap_lock, it made the data type int8 rather than uint8.\n\nI believe that this was a minor oversight. Attached patch fixes the issue.\n\n-- \nPete...
[ { "msg_contents": "Hi Hackers,\n\nIs it fair to assume that, given the same data, a partitioned table should\nreturn the same results as a non-partitioned table? If that's true, then I\nthink I may have stumbled across a case of wrong results on boolean partitioned\ntables.\n\nIn following example, I think we ...
[ { "msg_contents": "Hi,\n\nI am trying to understand the Plan tree for select queries. Can you\nplease help me with the below queries?\n\n1) Why is there a difference in plan tree for these two queries? User\ntable tidx1 has an index on column 'a' .\n2) Why do we do Index scan and not Bitmap Index Scan for cata...
[ { "msg_contents": "Over on [1], Tim reported that the planner is making some bad choices\nwhen the plan contains a WindowFunc which requires reading all of, or\na large portion of the WindowAgg subnode in order to produce the first\nWindowAgg row.\n\nFor example:\n\nEXPLAIN (ANALYZE, TIMING OFF)\nSELECT COUNT(*...
[ { "msg_contents": "I came across $subject and reduced the repro query as below.\n\ncreate table a (i int);\ncreate table b (i int);\ninsert into a values (1);\ninsert into b values (2);\nupdate b set i = 2;\n\nset min_parallel_table_scan_size to 0;\nset parallel_tuple_cost to 0;\nset parallel_setup_cost to 0;\n...
[ { "msg_contents": "Hi,\n\nIMO I think that commit 31966b1\n<https://github.com/postgres/postgres/commit/31966b151e6ab7a6284deab6e8fe5faddaf2ae4c>\nhas an oversight.\n\nAll the logic of the changes are based on the \"extend_by\" variable, which\nis a uint32, but in some places it is using \"int\", which can lead...
[ { "msg_contents": "The SQL Language part of the docs has a brief page on unique indexes.\nIt doesn't mention the new NULLS NOT DISTINCT functionality on unique\nindexes and this is a good place to mention it, as it already warns\nthe user about the old/default behavior.\n\n-- \nDavid Gilman\n:DG<", "msg_dat...
[ { "msg_contents": "hi hackers,\n\nIn the logical decoding on standby thread [1], Andres proposed 2 new tests (that I did\nnot find the time to complete before the finish line):\n\n- Test that we can subscribe to the standby (with the publication created on the primary)\n- Verify that invalidated logical slots d...
[ { "msg_contents": "Pursuant to the discussion at [1], here's a patch that removes our\nold restriction that a plan node having initPlans can't be marked\nparallel-safe (dating to commit ab77a5a45). That was really a special\ncase of the fact that we couldn't transmit subplans to parallel\nworkers at all. We f...
[ { "msg_contents": "Hi,\n\nForking of [1].\n\nOn 2023-04-12 14:11:10 -0400, Joe Conway wrote:\n> On 4/12/23 13:44, Alvaro Herrera wrote:\n> > Revert \"Catalog NOT NULL constraints\" and fallout\n> >\n> > This reverts commit e056c557aef4 and minor later fixes thereof.\n>\n> Seems 76c111a7f1 (as well as some other...
[ { "msg_contents": "Hi,\n\npg_create_logical_replication_slot can take longer than usual on a standby\nwhen there is no activity on the primary. We don't have enough information\nin the pg_stat_activity or process title to debug why this is taking so\nlong. Attached a small patch to update the process title whil...
[ { "msg_contents": "Hi all,\n\nWith db4f21e in place, there is no need to worry about explicitely\nfreeing any regular expressions that may have been compiled when\nloading HBA or ident files because MemoryContextDelete() would be\nable to take care of that now that these are palloc'd (the definitions\nin regcus...
[ { "msg_contents": "Greetings,\n\n* buildfarm-admins@lists.postgresql.org (buildfarm-admins@lists.postgresql.org) wrote:\n> The PGBuildfarm member pollock had the following event on branch HEAD:\n> Failed at Stage: Make\n> The snapshot timestamp for the build is: 2023-04-13 13:06:34\n> The specs of this machine ...
[ { "msg_contents": "Hi,\n\nThe documentation [1] says max_wal_size and min_wal_size defaults are 1GB\nand 80 MB respectively. However, these are configured based on the\nwal_segment_size and documentation is not clear about it. Attached a patch\nto fix the documentation.\n\n[1] https://www.postgresql.org/docs/de...
[ { "msg_contents": "I find that if I run the following test against a standard debug build\non HEAD, my local installation reliably segfaults:\n\n$ meson test --setup running --suite test_rls_hooks-running\n\nAttached is a \"bt full\" run from gdb against a core dump. The query\n\"EXPLAIN (costs off) SELECT * FR...
[ { "msg_contents": "Just for fun, I broke time up into 15 minute intervals and counted how\nmany machines were showing red on HEAD at each sample point (lateral\njoin for last tick interpolation of data I collect from the BF), and\nplotted that over time. See attached.\n\nI excluded seawasp (it tells us about *...
[ { "msg_contents": "Hi hackers,\n\nToo small value of work_mem cause memory overflow in parallel hash join \nbecause of too much number batches.\nThere is the plan:\n\nexplain SELECT * FROM solixschema.MIG_50GB_APR04_G1_H a join \nsolixschema.MIG_50GB_APR04_G2_H b on a.seq_pk = b.seq_pk join \nsolixschema.MIG_50...
[ { "msg_contents": "Hi,\n\n\nWe have observed that running the same self JOIN query on postgres FDW\nsetup is returning different results with set enable_nestloop off & on. I\nam at today's latest commit:- 928e05ddfd4031c67e101c5e74dbb5c8ec4f9e23\n\nI created a local FDW setup. And ran this experiment on the sam...
[ { "msg_contents": "LLVM 16 is apparently released, because Fedora has started using\nit in their rawhide (development) branch, which means Postgres\nis failing to build there [1][2]:\n\n../../../../src/include/jit/llvmjit_emit.h: In function 'l_load_gep1':\n../../../../src/include/jit/llvmjit_emit.h:123:30: war...
[ { "msg_contents": "I hit this elog() while testing reports under v16 and changed to PANIC\nto help diagnose.\n\nDETAILS: PANIC: invalid memory alloc request size 18446744072967930808\nCONTEXT: PL/pgSQL function array_weight(real[],real[]) while storing call arguments into local variables\n\nI can't share the ...
[ { "msg_contents": "Hi there,\n\nIn my implementation of CustomScan, when I have a query that scans multiple\ntables (select c from t1,t2,t3), the planner always picks one table to be\nscanned by CustomScan and offloads the rest to SeqScan. I tried assigning a\ncost of 0 to the CustomScan path, but still not wor...
[ { "msg_contents": "Current version of postgresql don't support incremental sort using\nordered scan on access method.\n\nExample database:\n\nCREATE TABLE t (id serial, p point, PRIMARY KEY(id));\nINSERT INTO t (SELECT generate_series(1, 10000000), point(random(), random()));\nCREATE INDEX p_idx ON t USING gist...
[ { "msg_contents": "I noticed that prion recently failed [1] with\n\n SELECT schema_to_xml_and_xmlschema('testxmlschema', true, true, 'foo');\n...\n+ERROR: relation with OID 30019 does not exist\n+CONTEXT: SQL statement \"SELECT oid FROM pg_catalog.pg_class WHERE relnamespace = 29949 AND relkind IN ('r','m','v...
[ { "msg_contents": "Hi Team,\n\nPostgres Version:- 13.8\nIssue:- Logical replication failing with SSL SYSCALL error\nPriority:-High\n\nWe are migrating our database through logical replications, and all of\nsudden below error pops up in the source and target logs which leads us to\nnowhere.\n\n*Logs from Source:...
[ { "msg_contents": "Hi\n\nI missing some variants of to_regclass\n\nto_regclass(schemaname, objectname)\nto_regclass(catalogname, schemaname, objectname)\n\nIt can helps with object identification, when I have separated schema and\nname\n\nWhat do you think about this?\n\nRegards\n\nPavel\n\nHiI missing some var...
[ { "msg_contents": "I was just looking at the vacuumdb docs and noticed that I had\nneglected to follow the tradition of adding a note to mention which\nversion we added the new option in when I committed the\n--buffer-usage-limit patch.\n\nThere are 3 notes there that read \"This option is only available for\ns...
[ { "msg_contents": "The PGDATABASE is documented as behaving the same as the dbname connection\nparameter but they differ in the support for postgres:// URIs: the\nPGDATABASE will never be expanded even thought expand_dbname is set:\n\n\t$ psql postgres://localhost/test -c 'select 1' >/dev/null # Works\n\t$ PGD...
[ { "msg_contents": "I hit this assertion while pg_restoring data into a v16 instance.\npostgresql16-server-16-alpha_20230417_PGDG.rhel7.x86_64\n\nwal_level=minimal and pg_dump --single-transaction both seem to be\nrequired to hit the issue.\n\n$ /usr/pgsql-16/bin/postgres -D ./pg16test -c maintenance_work_mem=1G...
[ { "msg_contents": "Further cleanup of autoconf output files for GSSAPI changes.\n\nRunning autoheader was missed in f7431bca8. This is cosmetic since\nwe aren't using these HAVE_ symbols, but let's get everything in\nsync while we're looking at this.\n\nDiscussion: https://postgr.es/m/2422362.1681741814@sss.pg...
[ { "msg_contents": "Hello hackers,\n\nPlease consider fixing the following unique words/identifiers introduced in v16:\n1. addresess -> addresses\n2. adminstrator -> administrator // the same typo found in src/backend/po/id.po, but perhaps it should be fixed via \npgsql-translators\n3. appeneded -> appended\n4. ...
[ { "msg_contents": "Recently, I ran into a problem, InvokeObjectPostAlterHook was implemented for sepgsql,\r\nsepgsql use it to determine whether to check permissions during certain operations.\r\nBut InvokeObjectPostAlterHook doesn't handle all of the alter's behavior, at least the table is not controlled.&nbsp...
[ { "msg_contents": "Attached patch removes xl_heap_lock_updated/XLOG_HEAP2_LOCK_UPDATED,\nwhich allows us to throw out about a hundred lines of duplicative\n(though hairy) code, net total. The patch also reclaims some Heap2\ninfo bit space, which seems quite useful.\n\nThe patch teaches heap_lock_updated_tuple_r...
[ { "msg_contents": "Over on [1], Peter mentions that we might want to consider putting the\nVACUUM options into some order that's better than the apparent random\norder that they're currently in.\n\nVACUUM is certainly one command that's grown a fairly good number of\noptions over the years and it appears we've ...
[ { "msg_contents": "In thread [1] which discussed 'Right Anti Join', Tom once mentioned\n'Right Semi Join'. After a preliminary investigation I think it is\nbeneficial and can be implemented with very short change. With 'Right\nSemi Join', what we want to do is to just have the first match for each\ninner tupl...
[ { "msg_contents": "Hi hackers,\n\nI found that GRANT MAINTAIN is not tab-completed with ON, so here is a \npatch.\n\nBest wishes,\n\n-- \nKen Kato\nAdvanced Computing Technology Center\nResearch and Development Headquarters\nNTT DATA CORPORATION", "msg_date": "Tue, 18 Apr 2023 18:08:23 +0900", "msg_from...
[ { "msg_contents": "Hi,\n\nget_collation_actual_version() in pg_locale.c currently \nexcludes C.UTF-8 (and more generally C.*) from versioning,\nwhich makes pg_collation.collversion being empty for these\ncollations.\n\nchar *\nget_collation_actual_version(char collprovider, const char *collcollate)\n{\n....\n\t...
[ { "msg_contents": "Hi,\n\nWe have a few different places in the code where we generate or modify\ntar headers or just read data out of them. The code in question uses\none of my less-favorite programming things: magic numbers. The offsets\nof the various fields within the tar header are just hard-coded in\neach...
[ { "msg_contents": "Recent commits that enhanced rmgr desc routines (commits 7d8219a4 and\n1c453cfd) dealt with records that lack relevant block data (and so\nlack anything to give a more detailed summary of) by testing\n!DecodedBkpBlock.has_image -- that is the gating condition that\ndetermines if we want to (s...
[ { "msg_contents": "The wal size related gucs use the MB unit, so we should just use\nINT_MAX instead of MAX_KILOBYTES as the max value.\n\n-- \nRegards\nJunwang Zhao", "msg_date": "Wed, 19 Apr 2023 11:26:26 +0800", "msg_from": "Junwang Zhao <zhjwpku@gmail.com>", "msg_from_op": true, "msg_subject...
[ { "msg_contents": "Hello there, \n\nA few years ago, someone reported a bug (#13489) about attndims, which\nreturned a false value on an array on a table created by CREATE TABLE\n<cloned_table> (LIKE <original_table> INCLUDING ALL), \n\nexample:\n\nCREATE TABLE test (data integer, data_array integer[];\nCREATE ...
[ { "msg_contents": "Please find below simple repro for CacheMemoryContext memory leak\n\ncreate type two_int4s as (f1 int4, f2 int4);\ncreate type two_int8s as (q1 int8, q2 int8);\n\nPLpgSQL example:\ndo $$ declare c4 two_int4s; c8 two_int8s;\nbegin\n c8 := row(1,2);\n c4 := c8;\nend$$;\n\nExecuting above plpg...
[ { "msg_contents": "Hi,\n\nI've attached a patch that removes some now redundant messaging about\nunsupported versions.\n\nRegards\n\nThom", "msg_date": "Wed, 19 Apr 2023 13:37:30 +0100", "msg_from": "Thom Brown <thom@linux.com>", "msg_from_op": true, "msg_subject": "Remove references to pre-11 v...
[ { "msg_contents": "Hi,\n\nOver in [1], we discussed removing the \"io\" prefix from the columns\n\"io_context\" and \"io_object\" in pg_stat_io since they seem redundant\ngiven the view name\n\nAttached patch does that.\n\n- Melanie\n\n[1]\nhttps://www.postgresql.org/message-id/20230215.164021.22754367543582602...
[ { "msg_contents": "Hi,\n\nI noticed that the numbers in pg_stat_io dont't quite add up to what I\nexpected in write heavy workloads. Particularly for checkpointer, the numbers\nfor \"write\" in log_checkpoints output are larger than what is visible in\npg_stat_io.\n\nThat partially is because log_checkpoints' \...
[ { "msg_contents": "I wondered at [1] why ExecAggTransReparent doesn't do what you'd\nguess from the name, that is reparent a supplied R/W expanded object\nunder the aggcontext even if it's not there already. I tried to\nmake it do that, and after I'd finished bandaging my wounds,\nI wrote some commentary expla...
[ { "msg_contents": "As far as I know, when a index page is full, if you insert a new tuple here, you will split it into two pages.\r\nBut pg won't delete the half tuples in the old page in real. So if there is another tuple inserted into this old\r\npage, will pg split it again? I think that's not true, so how i...
[ { "msg_contents": "As far as I know, when a index page is full, if you insert a new tuple here, you will split it into two pages.\r\nBut pg won't delete the half tuples in the old page in real. So if there is another tuple inserted into this old\r\npage, will pg split it again? I think that's not true, so how i...
[ { "msg_contents": "Hi,\n\nConsidering two partitionned tables with a FK between them:\n\n DROP TABLE IF EXISTS p, c, c_1 CASCADE;\n\n ----------------------------------\n -- Parent table + partition + data\n CREATE TABLE p (\n id bigint PRIMARY KEY\n )\n PARTITION BY list (id);\n\n CREATE TABLE p_1 PA...
[ { "msg_contents": "Hi All,\nLockMethodLocalHash hash table is allocated in memory context \"\"LOCALLOCK hash\".\nLockAcquireExtended() fetches an entry from this hash table and\nallocates memory for locallock->lockOwners in TopMemoryContext. Thus\nthe entry locallock and an array pointed from this entry are all...
[ { "msg_contents": "Hi,\n\nMoving this to -hackers.\n\nOn 2023-04-20 11:49:23 +0200, Palle Girgensohn wrote:\n> I was recently made aware of a problem building postgresql using LLVM binutils.\n> \n> A summary:\n> \n> --\n> \n> pgsql's build has requested to strip all non-global symbols (strip -x), but\n> there i...
[ { "msg_contents": "The Core Team would like to extend our congratulations to\nNathan Bossart, Amit Langote, and Masahiko Sawada, who have\naccepted invitations to become our newest Postgres committers.\n\nPlease join me in wishing them much success and few reverts.\n\n\t\t\tregards, tom lane\n\n\n", "msg_da...
[ { "msg_contents": ">I searched the codes and found some other places where the manipulation\n>of lists can be improved in a similar way.\n\n>* lappend(list_copy(list), datum) as in get_required_extension().\n>This is not very efficient as after list_copy it would need to enlarge\n>the list immediately. It can b...
[ { "msg_contents": "When reviewing a recently committed patch [1] I noticed the odd usage\nof a format specifier:\n\n+ libpq_append_conn_error(conn, \"invalid %s value: \\\"%s\\\"\",\n+ \"load_balance_hosts\",\n+ conn->load_balance_hos...
[ { "msg_contents": "Commit [1] implements Fisher-Yates shuffling algorithm to shuffle\nconnection addresses, in two places.\n\nThe attached patch moves the duplicated code to a function, and calls\nit in those 2 places.\n\n[1]: Support connection load balancing in libpq\n7f5b19817eaf38e70ad1153db4e644ee9456853e\...
[ { "msg_contents": "Commit 7f5b198 introduced TAP tests that use string literals to mark\nthe presence of a query in server logs. For no explicable reason, the\ntests with the marker 'connect2' occur before the tests that use\n'connect1' marker.\n\nThe attached patch swaps the connection marker strings so that a...
[ { "msg_contents": "Hi -hackers,\n\nI would like to ask if it wouldn't be good idea to copy the\nhttps://wiki.postgresql.org/wiki/TOAST#Total_table_size_limit\ndiscussion (out-of-line OID usage per TOAST-ed columns / potential\nlimitation) to the official \"Appendix K. PostgreSQL Limits\" with also\nlittle bonus...
[ { "msg_contents": "There was discussion in [1] about improvements to list manipulation in\nseveral places. But since the discussion is not related to the topic in\nthat thread, fork a new thread here and attach a patch to show my\nthoughts.\n\nSome are just cosmetic changes by using macros. The others should ...
[ { "msg_contents": "Hi Michael\r\nthank you for your explanation.\r\nactually, some location can be tricky to add.\r\nit looks like CREATE, but it’s actually ALTER, should call InvokeObjectPostAlterHook instead of&nbsp;InvokeObjectPostCreateHook? eg.,CREATE OR REPLACE, CREATE TYPE(perfecting shell type)\r\n\r\n\...
[ { "msg_contents": "Hi.\n\nWe've found that in cases like the one attached, when we insert into \nforeign partition with batch_size set, buffer refcount leak is detected.\n\nThe above example we see a dozen of similar messages:\n\nrepro_small.sql:31: WARNING: buffer refcount leak: [14621] \n(rel=base/16718/1673...
[ { "msg_contents": "Hello, hackers,\n\nwe have a duplicate line, declaration of default_multirange_selectivity() in\nsrc/backend/utils/adt/multirangetypes_selfuncs.c:\n\nstatic double default_multirange_selectivity(Oid operator);\nstatic double default_multirange_selectivity(Oid operator);\n\nAffected branches: ...
[ { "msg_contents": "Hi hackers,\n\nFollowing my previous mail about adding stats on parallelism[1], this \npatch introduces the log_parallel_worker_draught parameter, which \ncontrols whether a log message is produced when a backend attempts to \nspawn a parallel worker but fails due to insufficient worker slots...