id stringlengths 29 30 | content stringlengths 152 2.6k |
|---|---|
codereview_new_java_data_12506 | private ApiError validateAlterConfig(ConfigResource configResource,
for (ApiMessageAndVersion recordImplicitlyDeleted : recordsImplicitlyDeleted) {
ConfigRecord configRecord = (ConfigRecord) recordImplicitlyDeleted.message();
allConfigs.remove(configRecord.name());
- // do... |
codereview_new_java_data_12507 | private ApiError validateAlterConfig(ConfigResource configResource,
for (ApiMessageAndVersion recordImplicitlyDeleted : recordsImplicitlyDeleted) {
ConfigRecord configRecord = (ConfigRecord) recordImplicitlyDeleted.message();
allConfigs.remove(configRecord.name());
- // As... |
codereview_new_java_data_12508 | static void createCompactedTopic(String topicName, short partitions, short repli
}
if (cause instanceof UnsupportedVersionException) {
log.debug("Unable to create topic '{}' since the brokers do not support the CreateTopics API." +
- " Falling b... |
codereview_new_java_data_12509 |
import java.util.Set;
/**
- * ForwardingAdmin is the default value of `forwarding.admin.class` in MM2.
- * MM2 users who wish to use customized behaviour Admin; they can extend the ForwardingAdmin and override some behaviours
- * without need to provide a whole implementation of Admin.
- * The class must have a co... |
codereview_new_java_data_12510 |
import java.util.Set;
/**
- * {@code ForwardingAdmin} is the default value of {@code forwarding.admin.class} in MM2.
- * Users who wish to customize the MM2 behaviour for the creation of topics and access control lists can extend this
* class without needing to provide a whole implementation of {@code Admin}.
... |
codereview_new_java_data_12511 | public class MirrorClientConfig extends AbstractConfig {
public static final String FORWARDING_ADMIN_CLASS = "forwarding.admin.class";
public static final String FORWARDING_ADMIN_CLASS_DOC = "Class which extends ForwardingAdmin to define custom cluster resource management (topics, configs, etc). " +
- ... |
codereview_new_java_data_12512 | public void testPutConnectorConfig() throws Exception {
FutureCallback<Herder.Created<ConnectorInfo>> reconfigureCallback = new FutureCallback<>();
herder.putConnectorConfig(CONNECTOR_NAME, newConnConfig, true, reconfigureCallback);
Herder.Created<ConnectorInfo> newConnectorInfo = reconfigur... |
codereview_new_java_data_12513 | ClusterAssignment performTaskAssignment(
scheduledRebalance = time.milliseconds() + delay;
} else if (!toExplicitlyRevoke.isEmpty()) {
// We had a revocation in this round but not in the previous round. Let's store that state.
- log.debug("Revoking rebalanc... |
codereview_new_java_data_12515 | public interface TasksRegistry {
void addPendingTaskToInit(final Collection<Task> tasks);
- void addNewActiveTasks(final Collection<Task> newTasks);
- void addNewStandbyTasks(final Collection<Task> newTasks);
void addTask(final Task task);
I think in future we can consolidate `addNewActiveTa... |
codereview_new_java_data_12516 | public enum MetadataVersion {
public static final String FEATURE_NAME = "metadata.version";
/**
- * The first version we currently support in KRaft. We chose 3.3IV0 since it is the first
- * version that supports storing the metadata.version in the log.
*/
public static final MetadataVer... |
codereview_new_java_data_12518 | public void testBackgroundConnectorDeletion() throws Exception {
// Task configs for the deleted connector should also be removed from the snapshot
assertEquals(Collections.emptyList(), configState.allTaskConfigs(CONNECTOR_IDS.get(0)));
assertEquals(0, configState.taskCount(CONNECTOR_IDS.get... |
codereview_new_java_data_12522 | private void handleError(
case GROUP_AUTHORIZATION_FAILED:
// Member level errors.
case UNKNOWN_MEMBER_ID:
- case FENCED_INSTANCE_ID:
log.debug("OffsetCommit request for group id {} failed due to error {}.",
groupId.idValue, error)... |
codereview_new_java_data_12523 | public synchronized void handleCommit(BatchReader<Integer> reader) {
}
log.debug("Counter incremented from {} to {}", initialCommitted, committed);
- // A snapshot is being taken here too, not being able to -
- // `import org.apache.kafka.metadata.utils.SnapshotReason`... |
codereview_new_java_data_12526 | public static String[] enumOptions(Class<? extends Enum<?>> enumClass) {
.toArray(String[]::new);
}
- /**
- * Ensures that the provided {@code reason} remains within a range of 255 chars.
- * @param reason This is the reason that is sent to the broker over the wire
- * ... |
codereview_new_java_data_12527 | public int hashCode() {
*
* This method does not block until the task is paused.
*
- * The task to be paused is not removed from the restored active tasks and the failed tasks.
* Stateless tasks will never be paused since they are immediately added to the
* restored active tasks.
... |
codereview_new_java_data_12530 | public ListConsumerGroupOffsetsOptions topicPartitions(List<TopicPartition> topi
/**
* Sets an optional requireStable flag.
*/
- public void requireStable(final boolean requireStable) {
this.requireStable = requireStable;
}
/**
Do we need a KIP for this change?
public ListCo... |
codereview_new_java_data_12532 |
* In contrast, two sub-topologies are not connected but can be linked to each other via topics, i.e., if one
* sub-topology {@link Topology#addSink(String, String, String...) writes} into a topic and another sub-topology
* {@link Topology#addSource(String, String...) reads} from the same topic.
- * Processors an... |
codereview_new_java_data_12533 | public void shouldQueryStoresAfterAddingAndRemovingStreamThread() throws Excepti
});
}
- private Matcher<String> retrievableException() {
return is(
- anyOf(
- containsString("Cannot get state store source-table because the stream thread is PARTITIONS_A... |
codereview_new_java_data_12537 | public Optional<QuerySpecification> getCurrentQuerySpecification()
return currentQuerySpecification;
}
@Immutable
public static final class Insert
{
you can use
`functionHandles.values().stream().map(FunctionHandle::getName).collect(toImmutableList());`
public Optional<QuerySpecifica... |
codereview_new_java_data_12592 | private static TextIO.Write writeWithCSVFormatHeaderAndComments(
result.add(
withHeaderCommentsRemoved
// The withSkipHeaderRecord parameter prevents CSVFormat from outputting two copies of
- // the header; we already
.withSkipHeaderRecord()
.... |
codereview_new_java_data_12595 | public void testConcurrentNewSampler() throws Exception {
() -> {
for (int i = 0; i < 1000000; i++) {
sampler.sampleOutput("pcollection-" + i, coder).sample(0);
-
- // This sleep is here to allow for the test to stop this thread.
- try {
- ... |
codereview_new_java_data_12627 | public enum RunecraftAction implements ItemSkillAction
@Override
public String getName(final ItemManager itemManager)
{
- return "Blood Rune (Zeah)";
}
},
TRUE_BLOOD_RUNE(ItemID.BLOOD_RUNE, 77, 10.5f, false)
```suggestion
return "Blood rune (Zeah)";
```
public enum RunecraftAction implements ... |
codereview_new_java_data_12628 | default int outlineFeather()
position = 7,
keyName = "npcToHighlight",
name = "NPCs to Highlight",
- description = "List of NPC names to highlight<br>Separate entries with commas (,)<br>Click anywhere in plugin to reflect changes"
)
default String getNpcToHighlight()
{
```suggestion
description = "... |
codereview_new_java_data_12629 | public Dimension render(Graphics2D graphics)
sb.append("Run Time Remaining: ").append(plugin.getEstimatedRunTimeRemaining(false));
}
- if (client.getVarbitValue(Varbits.RUN_SLOWED_DEPLETION_ACTIVE) == 0 && plugin.getRingOfEnduranceCharges() == null && plugin.isRingOfEnduranceEquipped())
{
sb.appe... |
codereview_new_java_data_12630 |
@Getter
public enum FishingSpot
{
- SHRIMP("Shrimp, Sardine, Herring, Anchovies", "Anchovies", ItemID.RAW_SHRIMPS,
FISHING_SPOT_1514, FISHING_SPOT_1517, FISHING_SPOT_1518,
FISHING_SPOT_1521, FISHING_SPOT_1523, FISHING_SPOT_1524,
FISHING_SPOT_1525, FISHING_SPOT_1528, FISHING_SPOT_1530,
These should be grou... |
codereview_new_java_data_12631 |
package io.cdap.cdap.sourcecontrol.operationrunner;
/**
- * Exception thrown when push operation fails in operation runner.
- * Encapsulates all underlying exceptions.
*/
-public class PushFailureException extends Exception {
- public PushFailureException(String message, Exception cause) {
super(message, c... |
codereview_new_java_data_12948 | private static boolean themeConfigurationChanged(Options options,
JsonObject statsJson,
FrontendDependenciesScanner frontendDependencies)
throws IOException {
- Map<String, String> themeJsonHashes = new HashMap<>(1);
if (options.jarFiles == null) {
... |
codereview_new_java_data_12950 | public class BuildFrontendMojo extends FlowModeAbstractMojo
* If using pnpm, the install will be run with {@code --frozen-lockfile}
* parameter.
*
- * This makes sure that the package lock file will not be overwritten.
*/
@Parameter(property = InitParameters.CI_BUILD, defaultValue = "f... |
codereview_new_java_data_12951 | public void applicationTheme_GlobalCss_isUsedOnlyInEmbeddedComponent() {
"none", background);
// font-family from web component doesn't leak to the document
- Assert.assertFalse(body.getCssValue("font-family").contains("Ostrich"));
// font-family of the document is applied... |
codereview_new_java_data_12952 |
* <p>
* Vaadin gets the SystemMessages from the {@link SystemMessagesProvider}
* configured in {@link VaadinService}. You can customize this by creating a
- * {@link VaadinServiceInitListener} that sets an instance on
* {@link SystemMessagesProvider} to
* {@link VaadinService#setSystemMessagesProvider(System... |
codereview_new_java_data_12953 | public SecurityContextHolderStrategy securityContextHolderStrategy() {
return vaadinAwareSecurityContextHolderStrategy;
}
-}
\ No newline at end of file
new line missing
```suggestion
}
```
public SecurityContextHolderStrategy securityContextHolderStrategy() {
return vaadinAwareSecurit... |
codereview_new_java_data_12954 | public interface EndpointRequestUtil extends Serializable {
boolean isAnonymousEndpoint(HttpServletRequest request);
/**
- * Shows whether the Hilla is used in the project.
*
- * @return true if Hilla is used, false otherwise
*/
static boolean isEndpointUsed() {
try {
```... |
codereview_new_java_data_12955 | public void filter_messageNotYetSeen_addToCacheAndContinue() {
Assert.assertEquals("Expecting message not seen on client to be sent",
ACTION.CONTINUE, action.action());
Assert.assertSame(
- "Message should not be altered by filter when aborting",
messa... |
codereview_new_java_data_12956 | public boolean isNavigationSupported() {
* @return the currently active route instance if available
*/
public Optional<Component> getCurrentView() {
- try {
- return Optional.ofNullable((Component) getInternals()
- .getActiveRouterTargetsChain().get(0));
- }... |
codereview_new_java_data_12957 |
import com.vaadin.flow.server.VaadinServletContext;
import jakarta.servlet.ServletContext;
-import jakarta.servlet.ServletContextListener;
import jakarta.websocket.DeploymentException;
import jakarta.websocket.server.ServerContainer;
import jakarta.websocket.server.ServerEndpointConfig;
/**
* Creates the w... |
codereview_new_java_data_12958 | public void onOpen(Session session, EndpointConfig config) {
proxy = new ViteWebsocketProxy(session, vitePort);
session.addMessageHandler(proxy);
} catch (Exception e) {
- getLogger().debug("Error creating Vite proxy connection", e);
try {
ses... |
codereview_new_java_data_12959 |
* that manages instances according to the conventions of that framework.
* <p>
* {@link VaadinService} will by default use {@link ServiceLoader} for finding
- * an instantiator implementation. It is possible to override this mechanism by
- * overriding {@link VaadinService#createInstantiator}.
*
* @author Va... |
codereview_new_java_data_12960 | public void testAddOn() {
}
@Test
- public void noFrontendFilesCreated() {
File baseDir = new File(System.getProperty("user.dir", "."));
- // shouldn't create a dev-bundle
Assert.assertTrue("New devBundle should be generated",
new File(baseDir, "dev-bundle").e... |
codereview_new_java_data_12961 | public void fetchCurrentURL(SerializableConsumer<URL> callback) {
* to be notified when the direction is resolved.
*/
public void fetchPageDirection(SerializableConsumer<Direction> callback) {
- UI.getCurrent().getPage().executeJs("return document.dir")
- .then(String.... |
codereview_new_java_data_12962 | && frontendFileExists(localModulePath)) {
notFoundMessage(resourceNotFound, prefix, suffix));
}
if (!npmNotFound.isEmpty() && getLogger().isInfoEnabled()
- && (options.productionMode || options.isDevBundleBuild())) {
getLogger().info(notFoundMessage(... |
codereview_new_java_data_12963 | protected void checkLogsForErrors(
"Received error message in browser log console right after opening the page, message: %s",
logEntry));
} else {
- if (logEntry.getMessage().contains(
- "Lit is in dev mode. Not recomm... |
codereview_new_java_data_12964 | public <T> T findAncestor(Class<T> componentType) {
* Removes the component from its parent.
*/
public void removeFromParent() {
- findAncestor(HasComponents.class).remove(this);
}
}
There's no guarantee the immediate parent component implements `HasComponents` since that's just a mark... |
codereview_new_java_data_12965 | public class InitParameters implements Serializable {
* Configuration name for the time waiting for the frontend build tool to
* output a success or error pattern.
*/
- public static final String SERVLET_PARAMETER_DEVMODE_WEBPACK_TIMEOUT = "devmode.webpack.output.pattern.timeout";
/**
... |
codereview_new_java_data_12966 |
import org.apache.commons.io.FileUtils;
/**
- * Utility class for stubbing Node.JS and Vite scripts.
*/
public class FrontendStubs {
Should we just say bundler instead of naming the specific one used?
import org.apache.commons.io.FileUtils;
/**
+ * Utility class for stubbing Node.JS and frontend toolin... |
codereview_new_java_data_12968 |
.getResourceAsStream("version.properties"));
} catch (Exception e) {
LoggerFactory.getLogger(PolymerTemplate.class.getName())
- .warn("Unable to read the version.properties file.", e);
- throw new ExceptionInInitializerError(e);
}
... |
codereview_new_java_data_12969 |
import java.net.URISyntaxException;
import java.nio.file.Path;
-import org.apache.commons.lang3.Conversion;
import org.junit.After;
import org.junit.Before;
import org.junit.Rule;
Leftover? Remove if not used.
import java.net.URISyntaxException;
import java.nio.file.Path;
import org.junit.After;
import... |
codereview_new_java_data_12970 |
*/
public class TaskGenerateBootstrap extends AbstractTaskClientGenerator {
- static final String DEV_TOOLS_IMPORT = String.format("import '"
- + FrontendUtils.JAR_RESOURCES_IMPORT + "vaadin-dev-tools.js';%n");
private final FrontendDependenciesScanner frontDeps;
private final File fronten... |
codereview_new_java_data_12972 | default boolean isPnpmEnabled() {
* Returns whether server-side and offline license checking are enabled or
* not.
* <p>
- * New license checker is only available in NPM mode with enabled live reload.
* Once compatibility/bower mode is used or live reload is disabled,
* the old licens... |
codereview_new_java_data_12973 | public static class Builder implements Serializable {
* Whether to disable server-side and offline new license checking
* features and enable old JavaScript license checker.
*/
- private boolean enableOldLicenseChecker = false;
/**
* Create a builder instance g... |
codereview_new_java_data_12974 | protected void configure(HttpSecurity http) throws Exception {
* {@link org.springframework.security.config.annotation.method.configuration.GlobalMethodSecurityConfiguration}
* to configure the current {@link SecurityContextHolderStrategy}.
*/
- @Bean
public SecurityContextHolderStrategy secu... |
codereview_new_java_data_12975 |
/*
- * Copyright 2000-2017 Vaadin Ltd.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not
* use this file except in compliance with the License. You may obtain a copy of
```suggestion
* Copyright 2000-2022 Vaadin Ltd.
```
/*
+ * Copyright 2000-2022 Vaadin Ltd.
*
* License... |
codereview_new_java_data_12977 | protected UI(UIInternalUpdater internalsHandler) {
getNode().getFeature(ElementData.class).setTag("body");
Component.setElement(this, Element.get(getNode()));
pushConfiguration = new PushConfigurationImpl(this);
- // Component::setVisible relies on hidden attribute.
- // Adds a... |
codereview_new_java_data_12978 | public void should_failWithIllegalStateException_when_customWebpackConfigFileExi
IllegalStateException.class,
() -> builder.build().execute());
Assert.assertTrue(exception.getMessage().contains(
- "webpack related config file 'webpack.config.js'... |
codereview_new_java_data_12979 | public class FeatureFlags implements Serializable {
"collaborationEngineBackend",
"https://github.com/vaadin/platform/issues/1988", true, null);
public static final Feature GRID_MULTI_SORT_PRIORITY_APPEND = new Feature(
- "Grid Grid MultiSort priority new behavior",
... |
codereview_new_java_data_12980 | public interface TaskGenerateHilla extends FallibleCommand {
* the project root directory. In a Maven multi-module project,
* this is the module root, not the main project one.
* @param buildDirectoryName
- * the name of the build directory (i.e. "build" or
... |
codereview_new_java_data_12981 | public boolean hasListener(Class<? extends ComponentEvent> eventType) {
*
* @param eventType
* the component event type
- * @return A collection with all registered listeners. Empty if no listeners
- * are found.
*/
- protected Collection<?> getListeners(
... |
codereview_new_java_data_12982 | public static <T extends ComponentEvent<?>> boolean hasEventListener(
*
* @param eventType
* the component event type
- * @return A collection with all registered listeners. Empty if no listeners
- * are found.
*/
public static Collection<?> getListeners(Componen... |
codereview_new_java_data_12983 | public class TaskUpdateThemeImport implements FallibleCommand {
TaskUpdateThemeImport(File npmFolder, ThemeDefinition theme,
File frontendDirectory) {
- this(npmFolder, theme, frontendDirectory,
- new File(frontendDirectory, GENERATED));
- }
-
- TaskUpdateThemeImport(Fil... |
codereview_new_java_data_12984 | default Validator<V> getDefaultValidator() {
* */
* @Override
* public Validator getDefaultValidator() {
- * return (value, valueContext) -> clientSideValid ? ValidationResult.ok()
* : ValidationResult.error("Invalid date format");
* }... |
codereview_new_java_data_12985 | Map<String, String> getDefaultDependencies() {
defaults.put("@polymer/polymer", POLYMER_VERSION);
- defaults.put("lit", "2.2.5");
// Constructable style sheets is only implemented for chrome,
// polyfill needed for FireFox et.al. at the moment
```suggestion
defaults.pu... |
codereview_new_java_data_12986 | public void should_BeAbleToCustomizeFolders() throws Exception {
.exists());
}
- @Ignore("Vite doesn't take into account v14 bootstrapping")
@Test
public void should_SetIsClientBootstrapMode_When_EnableClientSideBootstrapMode()
throws ExecutionFailedException, ... |
codereview_new_java_data_12987 |
import org.junit.After;
import org.junit.Ignore;
-@Ignore("Vite, service worker not working on nested path")
public class ServiceWorkerOnNestedMappingIT extends ServiceWorkerIT {
@Override
Issue reference is needed
import org.junit.After;
import org.junit.Ignore;
+@Ignore("Service worker not working... |
codereview_new_java_data_12988 | JsonObject getPlatformPinnedDependencies() throws IOException {
URL commVersionsResource = finder
.getResource(Constants.VAADIN_VERSIONS_JSON);
if (commVersionsResource == null) {
- log().info(
- "Couldn't find {} file to pin dependency versions for comm... |
codereview_new_java_data_12989 |
* subscribe for each other's validation statuses and enable/disable or clear
* values, etc. respectively.
*
- * @since 23.2
*
* @see HasValidator
* @see com.vaadin.flow.data.binder.Binder.BindingBuilderImpl#bind(ValueProvider,
```suggestion
* @since 2.7
```
* subscribe for each other's validation s... |
codereview_new_java_data_12990 | default Validator<V> getDefaultValidator() {
*
* @see com.vaadin.flow.data.binder.Binder.BindingBuilderImpl#bind(ValueProvider,
* Setter)
- * @since 23.2
*
* @return Registration of the added listener.
*/
```suggestion
* @since 2.7
```
default Validator<V> getDefa... |
codereview_new_java_data_12991 |
* {@link ValidationStatusChangeListener#validationStatusChanged(ValidationStatusChangeEvent)}
* invoked.
*
- * @since 23.2
*
* @param <V>
* the value type
```suggestion
* @since 2.7
```
* {@link ValidationStatusChangeListener#validationStatusChanged(ValidationStatusChangeEvent)}
* invo... |
codereview_new_java_data_12992 |
* {@link ValidationStatusChangeListener#validationStatusChanged(ValidationStatusChangeEvent)}
* invoked.
*
- * @since 23.2
*
* @param <V>
* the value type
```suggestion
* @since 2.7
```
* {@link ValidationStatusChangeListener#validationStatusChanged(ValidationStatusChangeEvent)}
* invo... |
codereview_new_java_data_12993 | default Validator<V> getDefaultValidator() {
*
* @see com.vaadin.flow.data.binder.Binder.BindingBuilderImpl#bind(ValueProvider,
* Setter)
- * @since 23.2
*
* @return Registration of the added listener.
*/
if this method is down-ported to anything from 14.x to 23.1.x - this... |
codereview_new_java_data_12994 |
* subscribe for each other's validation statuses and enable/disable or clear
* values, etc. respectively.
*
- * @since 23.2
*
* @see HasValidator
* @see com.vaadin.flow.data.binder.Binder.BindingBuilderImpl#bind(ValueProvider,
```suggestion
* @since 2.7
```
* subscribe for each other's validation s... |
codereview_new_java_data_13006 | private final class AsyncReply {
this.noResponseFuture =
getTaskScheduler()
.schedule(() -> {
- cleanUp(this.haveSemaphore, this.connection, this.connection.getConnectionId());
- this.future.completeExceptionally(
new MessageTimeoutException(requestMessage,
- ... |
codereview_new_java_data_13007 | private <T extends IntegrationNode> ReceiveCounters retrieveCounters(T node, Str
(long) (failures == null ? 0 : failures.count()));
}
- private static TimerStats buildTimerStats(Timer timer) {
return timer == null
? ZERO_TIMER_STATS
: new TimerStats(timer.count(), timer.mean(TimeUnit.MILLISECONDS... |
codereview_new_java_data_13008 | public void setLengthCheck(boolean lengthCheck) {
/**
* If true, DNS reverse lookup is done on the remote ip address.
- * Default false: not all environments (e.g. Docker containers) does a reliable DNS resolution.
* @param lookupHost the lookupHost to set
*/
public void setLookupHost(boolean lookupHos... |
codereview_new_java_data_13162 | public void startCommand(@NotNull Project project, @NotNull FlutterSdk sdk, @Nul
ProgramRunnerUtil.executeConfiguration(env, false, true);
}
- public void startCommandInBazelContext(@NotNull Project project, @NotNull Workspace workspace, AnActionEvent event) {
FlutterInitializer.sendAnalyticsAction(thi... |
codereview_new_java_data_13163 | public VirtualFile getPackagesFile() {
public @Nullable Map<String, String> getPackagesMap() {
final var packageConfigFile = getPackageConfigFile();
- if(packageConfigFile != null) {
return DotPackagesFileUtil.getPackagesMapFromPackageConfigJsonFile(packageConfigFile);
}
final var packa... |
codereview_new_java_data_13164 | public static PubRoot forEventWithRefresh(@NotNull final AnActionEvent event) {
}
}
- //final Project project = event.getData(CommonDataKeys.PROJECT);
- //if (project != null) {
- // final List<PubRoot> roots = PubRoots.forProject(project);
- // if (!roots.isEmpty()) {
- // return roo... |
codereview_new_java_data_13471 | private void initBloggingSection() {
initBloggingPrompts();
// check if there's still any blogging settings visible, if not remove the whole section
- PreferenceCategory blogging = (PreferenceCategory) findPreference(getString(R.string.pref_key_blogging));
if (blogging.getPreference... |
codereview_new_java_data_13474 | private void initBloggingReminders() {
.getBlogSettingsUiState(mSite.getId())
.observe(getAppCompatActivity(), s -> {
if (mBloggingRemindersPref != null) {
- CharSequence summary = mUiHelpers.getTextOfUiString(getActivity(), ... |
codereview_new_java_data_13486 | public static Intent createMainActivityAndShowBloggingPromptsOnboardingActivityI
}
public static void showBloggingPromptsListActivity(final Activity activity) {
- Intent intent = BloggingPromptsListActivity.createIntent(activity);
activity.startActivity(intent);
}
Nitpick: would it ... |
codereview_new_java_data_13506 | public void onClick(View view) {
}
});
- if (getEditPostRepository() != null) hideSpecificViews(getEditPostRepository().isPage());
setupSettingHintsForAccessibility();
applyAccessibilityHeadingToSettings();
Small nitpick:
Maybe we can align this with the common used... |
codereview_new_java_data_13511 | public enum UndeletablePrefKey implements PrefKey {
// Indicates if this is the first time we try to get the user flags in Jetpack automatically
IS_FIRST_TRY_USER_FLAGS_JETPACK,
- // Indicates if this is the first time we try to get the user flags in Jetpack automatically
IS_FIRST_T... |
codereview_new_java_data_13515 |
import android.view.LayoutInflater;
import android.view.View;
import android.view.ViewGroup;
-import android.view.ViewGroup.MarginLayoutParams;
import android.view.ViewTreeObserver;
import android.widget.TextView;
unused import here
import android.view.LayoutInflater;
import android.view.View;
import andr... |
codereview_new_java_data_13516 | public static void scrollIntoView(Integer scrollableContainerID, ViewInteraction
}
public static void dismissJetpackAdIfPresent() {
- String jpAdText = "Stats, Reader, Notifications, and other features are powered by Jetpack.";
// Dismiss Jetpack ad that might be shown after Sign-Up or af... |
codereview_new_java_data_13517 | public static void scrollIntoView(Integer scrollableContainerID, ViewInteraction
}
public static void dismissJetpackAdIfPresent() {
- String jpAdText = "Stats, Reader, Notifications, and other features are powered by Jetpack.";
// Dismiss Jetpack ad that might be shown after Sign-Up or af... |
codereview_new_java_data_13519 | public static void populateTextFieldWithin(Integer elementID, String text) {
}
public static void populateTextField(ViewInteraction element, String text) {
- waitForElementToBeDisplayed(element);
clickOn(element);
element.perform(replaceText(text))
.perform(closeSof... |
codereview_new_java_data_13526 | public void onMediaUploadRetry(String localMediaId, MediaType mediaType) {
@Override
public void onMediaUploadSucceeded(final String localMediaId, final MediaFile mediaFile) {
mUploadingMediaProgressMax.remove(localMediaId);
- String mediaURL;
- if (!TextUtils.isEmpty(mediaFile.getFile... |
codereview_new_java_data_13527 | && getIntent().getExtras().getBoolean(ARG_CONTINUE_JETPACK_CONNECT, false)) {
onSetPromptReminderClick(getIntent().getIntExtra(ARG_OPEN_BLOGGING_REMINDERS, 0));
}
- int selectedSiteLocalId = mSelectedSiteRepository.getSelectedSiteLocalId(true);
- SiteModel site = selectedSiteLocal... |
codereview_new_java_data_13528 | && getIntent().getExtras().getBoolean(ARG_CONTINUE_JETPACK_CONNECT, false)) {
onSetPromptReminderClick(getIntent().getIntExtra(ARG_OPEN_BLOGGING_REMINDERS, 0));
}
- int selectedSiteLocalId = mSelectedSiteRepository.getSelectedSiteLocalId(true);
- SiteModel site = selectedSiteLocal... |
codereview_new_java_data_13532 | public static BitmapDrawable getAztecPlaceholderDrawableFromResID(Context contex
public static int getMaximumThumbnailSizeForEditor(Context context) {
Rect size = DisplayUtils.getWindowSize(context);
- int screenWidth = size.height();
- int screenHeight = size.width();
int maximu... |
codereview_new_java_data_13976 |
/**
* The <tt>Conference</tt>s of this <tt>Videobridge</tt> mapped by their local IDs.
*
- * TODO: The only remaining use of this ID is for the colibri WebSocket conference identifier. This should be
- * replaced with meetingId.
*/
private final Map<String, Conference> conferencesBy... |
codereview_new_java_data_13977 | public IQ healthCheckIqReceived(@NotNull HealthCheckIQ iq)
* Number of endpoints whose ICE connection was established, but DTLS
* wasn't (at the time of expiration).
*/
- public CounterMetric dtlsFailedEndpoints = VideobridgeMetricsContainer.getInstance().registerCounter(
- ... |
codereview_new_java_data_13979 | private void updateStatisticsOnExpire()
if (hasPartiallyFailed)
{
- videobridgeStatistics.totalPartiallyFailedConferences.incAndGet();
}
if (hasFailed)
{
- videobridgeStatistics.totalFailedConferences.incAndGet();
}
if (logger.i... |
codereview_new_java_data_13980 | public boolean hasNonZeroEffectiveConstraints(String endpointId)
*/
void expire()
{
ScheduledFuture<?> updateTask = this.updateTask;
if (updateTask != null)
{
updateTask.cancel(false);
}
- expired = true;
}
/**
I'd put the expired = t... |
codereview_new_java_data_13981 |
package org.jitsi.videobridge.metrics;
/**
- * Supplies the current value of a metric, cast as an {@code Object}.
* Metrics are held in the {@link MetricsContainer}.
*/
@FunctionalInterface
-public interface Metric
{
/**
- * Supplies the value of a metric.
*
* @return the current value o... |
codereview_new_java_data_13985 | public JvbHealthChecker getJvbHealthChecker()
void localEndpointCreated(boolean visitor)
{
statistics.currentLocalEndpoints.inc();
}
void localEndpointExpired(boolean visitor)
{
long remainingEndpoints = statistics.currentLocalEndpoints.decAndGet();
if (remainingEn... |
codereview_new_java_data_13987 | public void endpointMessageTransportConnected(@NotNull AbstractEndpoint abstract
{
endpoint.sendMessage(new DominantSpeakerMessage(recentSpeakers, speechActivity.isInSilence()));
}
-
- abstractEndpoint.onMessageTransportConnect();
}
}
We already ha... |
codereview_new_java_data_14387 |
import java.util.function.Function;
public class FtpWithProxyStageTest extends BaseFtpSupport implements CommonFtpStageTest {
- // Trigger actually running the tests
@Rule public final LogCapturingJunit4 logCapturing = new LogCapturingJunit4();
private final Integer PROXYPORT = 3128;
```suggestion
```
... |
codereview_new_java_data_14773 | private SelectResponse process(RegionTask regionTask) {
.getRegionStoreClientBuilder()
.build(region, store, storeType);
client.addResolvedLocks(startTs, resolvedLocks);
- // client.setTimeout(clientSession.getConf().getTimeout(),);
Collection<RegionTask> task... |
codereview_new_java_data_14774 | private static String wrapColumnName(String columnName) {
/**
* Spark SQL will parse string literal without escape, So we need to parse partition definition
- * without escape too. wrapValue will replace the first '' to "", so that antlr will not regard
- * the first '' as a part of string literal. wrapVa... |
codereview_new_java_data_14776 | private Iterator<SelectResponse> processByStreaming(RangeSplitter.RegionTask reg
}
}
public Boolean isMppStoreAlive(long id, RegionStoreClient client) {
try {
Boolean isStoreAlive = storeStatusCache.get(id);
comment to add link to this PR. I think the PR description is valuable.
private Ite... |
codereview_new_java_data_14780 | public TiDAGRequest buildTiDAGReq(
TiKVScanPlan plan =
buildIndexScan(columnList, conditions, index, table, tableStatistics, false);
if (plan.getCost() < minIndexCost) {
- minIndexPlan = plan;
minIndexCost = plan.getCost();
... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.